{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/87826380","pull_request_review_id":8421793,"id":87826380,"diff_hunk":"@@ -328,6 +328,24 @@ const ScrollView = React.createClass({\n      * @platform android\n      */\n     scrollPerfTag: PropTypes.string,\n+\n+     /**\n+     * Used to override default value of overScroll mode.\n+     *\n+     * Possible values:\n+     *\n+     *  - `'always'` - Always allow a user to over-scroll this view.\n+     *  - `'always-if-content-scrolls'` - Default value, allow a user to over-scroll","path":"Libraries/Components/ScrollView/ScrollView.js","position":11,"original_position":11,"commit_id":"991e8c008395fabfc97eb6a27a90d971055c428f","original_commit_id":"991e8c008395fabfc97eb6a27a90d971055c428f","user":{"login":"ericvicenti","id":1483597,"avatar_url":"https://avatars.githubusercontent.com/u/1483597?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvicenti","html_url":"https://github.com/ericvicenti","followers_url":"https://api.github.com/users/ericvicenti/followers","following_url":"https://api.github.com/users/ericvicenti/following{/other_user}","gists_url":"https://api.github.com/users/ericvicenti/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvicenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvicenti/subscriptions","organizations_url":"https://api.github.com/users/ericvicenti/orgs","repos_url":"https://api.github.com/users/ericvicenti/repos","events_url":"https://api.github.com/users/ericvicenti/events{/privacy}","received_events_url":"https://api.github.com/users/ericvicenti/received_events","type":"User","site_admin":false},"body":"It might be more conventional to call this one \"auto\"","created_at":"2016-11-14T15:45:17Z","updated_at":"2016-11-14T15:45:17Z","html_url":"https://github.com/facebook/react-native/pull/10905#discussion_r87826380","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/10905","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/87826380"},"html":{"href":"https://github.com/facebook/react-native/pull/10905#discussion_r87826380"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10905"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/10905","id":93460363,"html_url":"https://github.com/facebook/react-native/pull/10905","diff_url":"https://github.com/facebook/react-native/pull/10905.diff","patch_url":"https://github.com/facebook/react-native/pull/10905.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/10905","number":10905,"state":"open","locked":false,"title":"Android: Add overScrollMode prop to ScrollView","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"body":"This prop exposes the functionality provided by Android ScrollView's setOverScrollMode method.\r\n\r\nOne interesting thing to note is that, if you were to read the Android docs, you would think that the value \"always\" is the default over scroll mode. However, the docs are incorrect and \"always-if-content-scrolls\" is actually the default value (http://stackoverflow.com/a/27116306).\r\n\r\n**Test plan (required)**\r\n\r\nVerified this change in a test app. Also, our team uses this change in our app.\r\n\r\nAdam Comella\r\nMicrosoft Corp.","created_at":"2016-11-13T03:00:21Z","updated_at":"2016-11-14T15:45:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"964941127d8855628be219e539606be8edfeee9c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/10905/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/10905/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/10905/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/991e8c008395fabfc97eb6a27a90d971055c428f","head":{"label":"rigdern:rigdern/androidSetOverScrollMode","ref":"rigdern/androidSetOverScrollMode","sha":"991e8c008395fabfc97eb6a27a90d971055c428f","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"repo":{"id":39579697,"name":"react-native","full_name":"rigdern/react-native","owner":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rigdern/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/rigdern/react-native","forks_url":"https://api.github.com/repos/rigdern/react-native/forks","keys_url":"https://api.github.com/repos/rigdern/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rigdern/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rigdern/react-native/teams","hooks_url":"https://api.github.com/repos/rigdern/react-native/hooks","issue_events_url":"https://api.github.com/repos/rigdern/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/rigdern/react-native/events","assignees_url":"https://api.github.com/repos/rigdern/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/rigdern/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/rigdern/react-native/tags","blobs_url":"https://api.github.com/repos/rigdern/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rigdern/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rigdern/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/rigdern/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rigdern/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/rigdern/react-native/languages","stargazers_url":"https://api.github.com/repos/rigdern/react-native/stargazers","contributors_url":"https://api.github.com/repos/rigdern/react-native/contributors","subscribers_url":"https://api.github.com/repos/rigdern/react-native/subscribers","subscription_url":"https://api.github.com/repos/rigdern/react-native/subscription","commits_url":"https://api.github.com/repos/rigdern/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/rigdern/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/rigdern/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/rigdern/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/rigdern/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/rigdern/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rigdern/react-native/merges","archive_url":"https://api.github.com/repos/rigdern/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rigdern/react-native/downloads","issues_url":"https://api.github.com/repos/rigdern/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/rigdern/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/rigdern/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/rigdern/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rigdern/react-native/labels{/name}","releases_url":"https://api.github.com/repos/rigdern/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/rigdern/react-native/deployments","created_at":"2015-07-23T16:53:43Z","updated_at":"2016-07-20T02:47:21Z","pushed_at":"2016-11-13T04:45:43Z","git_url":"git://github.com/rigdern/react-native.git","ssh_url":"git@github.com:rigdern/react-native.git","clone_url":"https://github.com/rigdern/react-native.git","svn_url":"https://github.com/rigdern/react-native","homepage":"http://facebook.github.io/react-native/","size":58284,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"c612c615449b8645976429ad1c0661a4f6e56115","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-11-14T15:02:51Z","pushed_at":"2016-11-14T15:15:00Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":154471,"stargazers_count":40328,"watchers_count":40328,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9110,"mirror_url":null,"open_issues_count":854,"forks":9110,"open_issues":854,"watchers":40328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10905"},"html":{"href":"https://github.com/facebook/react-native/pull/10905"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/10905"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/10905/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10905/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10905/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/991e8c008395fabfc97eb6a27a90d971055c428f"}}}}
{"actor":{"display_login":"ericvicenti"}}