{"action":"closed","number":285,"pull_request":{"url":"https://api.github.com/repos/agentrickard/domain/pulls/285","id":92664719,"html_url":"https://github.com/agentrickard/domain/pull/285","diff_url":"https://github.com/agentrickard/domain/pull/285.diff","patch_url":"https://github.com/agentrickard/domain/pull/285.patch","issue_url":"https://api.github.com/repos/agentrickard/domain/issues/285","number":285,"state":"closed","locked":false,"title":"Domain config overrides in settings.php","user":{"login":"zerolab","id":31622,"avatar_url":"https://avatars.githubusercontent.com/u/31622?v=3","gravatar_id":"","url":"https://api.github.com/users/zerolab","html_url":"https://github.com/zerolab","followers_url":"https://api.github.com/users/zerolab/followers","following_url":"https://api.github.com/users/zerolab/following{/other_user}","gists_url":"https://api.github.com/users/zerolab/gists{/gist_id}","starred_url":"https://api.github.com/users/zerolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerolab/subscriptions","organizations_url":"https://api.github.com/users/zerolab/orgs","repos_url":"https://api.github.com/users/zerolab/repos","events_url":"https://api.github.com/users/zerolab/events{/privacy}","received_events_url":"https://api.github.com/users/zerolab/received_events","type":"User","site_admin":false},"body":"Based on #284.\r\n\r\nThis PR enables `DomainConfigOverrider` to pick up configuration changes in settings.php\r\n\r\nSomehow it feels more natural to have `$config['domain.config'][$domain_id][$langcode][$config_name];` or `$config['domain.config'][$domain_id][$config_name];`, but for now, ``$config[\"domain.config.{$domain_id}.{$langcode}.{$config_name}\"];` will have to do\r\n\r\nToDo:\r\n- [x] tests","created_at":"2016-11-07T21:10:46Z","updated_at":"2016-11-14T22:14:08Z","closed_at":"2016-11-14T22:14:08Z","merged_at":"2016-11-14T22:14:08Z","merge_commit_sha":"c3cb4697a0e69ee75833e4fb9487de1d8aac34ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/agentrickard/domain/pulls/285/commits","review_comments_url":"https://api.github.com/repos/agentrickard/domain/pulls/285/comments","review_comment_url":"https://api.github.com/repos/agentrickard/domain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/agentrickard/domain/issues/285/comments","statuses_url":"https://api.github.com/repos/agentrickard/domain/statuses/81f5571a37d50da6afc1952ebe901eec46105548","head":{"label":"zerolab:domain-config-settings-php","ref":"domain-config-settings-php","sha":"81f5571a37d50da6afc1952ebe901eec46105548","user":{"login":"zerolab","id":31622,"avatar_url":"https://avatars.githubusercontent.com/u/31622?v=3","gravatar_id":"","url":"https://api.github.com/users/zerolab","html_url":"https://github.com/zerolab","followers_url":"https://api.github.com/users/zerolab/followers","following_url":"https://api.github.com/users/zerolab/following{/other_user}","gists_url":"https://api.github.com/users/zerolab/gists{/gist_id}","starred_url":"https://api.github.com/users/zerolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerolab/subscriptions","organizations_url":"https://api.github.com/users/zerolab/orgs","repos_url":"https://api.github.com/users/zerolab/repos","events_url":"https://api.github.com/users/zerolab/events{/privacy}","received_events_url":"https://api.github.com/users/zerolab/received_events","type":"User","site_admin":false},"repo":{"id":50384409,"name":"domain","full_name":"zerolab/domain","owner":{"login":"zerolab","id":31622,"avatar_url":"https://avatars.githubusercontent.com/u/31622?v=3","gravatar_id":"","url":"https://api.github.com/users/zerolab","html_url":"https://github.com/zerolab","followers_url":"https://api.github.com/users/zerolab/followers","following_url":"https://api.github.com/users/zerolab/following{/other_user}","gists_url":"https://api.github.com/users/zerolab/gists{/gist_id}","starred_url":"https://api.github.com/users/zerolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerolab/subscriptions","organizations_url":"https://api.github.com/users/zerolab/orgs","repos_url":"https://api.github.com/users/zerolab/repos","events_url":"https://api.github.com/users/zerolab/events{/privacy}","received_events_url":"https://api.github.com/users/zerolab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zerolab/domain","description":"Domain module for Drupal port to Drupal 8.","fork":true,"url":"https://api.github.com/repos/zerolab/domain","forks_url":"https://api.github.com/repos/zerolab/domain/forks","keys_url":"https://api.github.com/repos/zerolab/domain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zerolab/domain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zerolab/domain/teams","hooks_url":"https://api.github.com/repos/zerolab/domain/hooks","issue_events_url":"https://api.github.com/repos/zerolab/domain/issues/events{/number}","events_url":"https://api.github.com/repos/zerolab/domain/events","assignees_url":"https://api.github.com/repos/zerolab/domain/assignees{/user}","branches_url":"https://api.github.com/repos/zerolab/domain/branches{/branch}","tags_url":"https://api.github.com/repos/zerolab/domain/tags","blobs_url":"https://api.github.com/repos/zerolab/domain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zerolab/domain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zerolab/domain/git/refs{/sha}","trees_url":"https://api.github.com/repos/zerolab/domain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zerolab/domain/statuses/{sha}","languages_url":"https://api.github.com/repos/zerolab/domain/languages","stargazers_url":"https://api.github.com/repos/zerolab/domain/stargazers","contributors_url":"https://api.github.com/repos/zerolab/domain/contributors","subscribers_url":"https://api.github.com/repos/zerolab/domain/subscribers","subscription_url":"https://api.github.com/repos/zerolab/domain/subscription","commits_url":"https://api.github.com/repos/zerolab/domain/commits{/sha}","git_commits_url":"https://api.github.com/repos/zerolab/domain/git/commits{/sha}","comments_url":"https://api.github.com/repos/zerolab/domain/comments{/number}","issue_comment_url":"https://api.github.com/repos/zerolab/domain/issues/comments{/number}","contents_url":"https://api.github.com/repos/zerolab/domain/contents/{+path}","compare_url":"https://api.github.com/repos/zerolab/domain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zerolab/domain/merges","archive_url":"https://api.github.com/repos/zerolab/domain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zerolab/domain/downloads","issues_url":"https://api.github.com/repos/zerolab/domain/issues{/number}","pulls_url":"https://api.github.com/repos/zerolab/domain/pulls{/number}","milestones_url":"https://api.github.com/repos/zerolab/domain/milestones{/number}","notifications_url":"https://api.github.com/repos/zerolab/domain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zerolab/domain/labels{/name}","releases_url":"https://api.github.com/repos/zerolab/domain/releases{/id}","deployments_url":"https://api.github.com/repos/zerolab/domain/deployments","created_at":"2016-01-25T22:06:25Z","updated_at":"2016-01-25T22:06:26Z","pushed_at":"2016-11-14T20:28:25Z","git_url":"git://github.com/zerolab/domain.git","ssh_url":"git@github.com:zerolab/domain.git","clone_url":"https://github.com/zerolab/domain.git","svn_url":"https://github.com/zerolab/domain","homepage":null,"size":1155,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"agentrickard:8.x-1.x","ref":"8.x-1.x","sha":"6e59d1aecfd810b22c8a552e429502c889101cde","user":{"login":"agentrickard","id":360988,"avatar_url":"https://avatars.githubusercontent.com/u/360988?v=3","gravatar_id":"","url":"https://api.github.com/users/agentrickard","html_url":"https://github.com/agentrickard","followers_url":"https://api.github.com/users/agentrickard/followers","following_url":"https://api.github.com/users/agentrickard/following{/other_user}","gists_url":"https://api.github.com/users/agentrickard/gists{/gist_id}","starred_url":"https://api.github.com/users/agentrickard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentrickard/subscriptions","organizations_url":"https://api.github.com/users/agentrickard/orgs","repos_url":"https://api.github.com/users/agentrickard/repos","events_url":"https://api.github.com/users/agentrickard/events{/privacy}","received_events_url":"https://api.github.com/users/agentrickard/received_events","type":"User","site_admin":false},"repo":{"id":12140101,"name":"domain","full_name":"agentrickard/domain","owner":{"login":"agentrickard","id":360988,"avatar_url":"https://avatars.githubusercontent.com/u/360988?v=3","gravatar_id":"","url":"https://api.github.com/users/agentrickard","html_url":"https://github.com/agentrickard","followers_url":"https://api.github.com/users/agentrickard/followers","following_url":"https://api.github.com/users/agentrickard/following{/other_user}","gists_url":"https://api.github.com/users/agentrickard/gists{/gist_id}","starred_url":"https://api.github.com/users/agentrickard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentrickard/subscriptions","organizations_url":"https://api.github.com/users/agentrickard/orgs","repos_url":"https://api.github.com/users/agentrickard/repos","events_url":"https://api.github.com/users/agentrickard/events{/privacy}","received_events_url":"https://api.github.com/users/agentrickard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agentrickard/domain","description":"Domain module for Drupal port to Drupal 8.","fork":false,"url":"https://api.github.com/repos/agentrickard/domain","forks_url":"https://api.github.com/repos/agentrickard/domain/forks","keys_url":"https://api.github.com/repos/agentrickard/domain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agentrickard/domain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agentrickard/domain/teams","hooks_url":"https://api.github.com/repos/agentrickard/domain/hooks","issue_events_url":"https://api.github.com/repos/agentrickard/domain/issues/events{/number}","events_url":"https://api.github.com/repos/agentrickard/domain/events","assignees_url":"https://api.github.com/repos/agentrickard/domain/assignees{/user}","branches_url":"https://api.github.com/repos/agentrickard/domain/branches{/branch}","tags_url":"https://api.github.com/repos/agentrickard/domain/tags","blobs_url":"https://api.github.com/repos/agentrickard/domain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agentrickard/domain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agentrickard/domain/git/refs{/sha}","trees_url":"https://api.github.com/repos/agentrickard/domain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agentrickard/domain/statuses/{sha}","languages_url":"https://api.github.com/repos/agentrickard/domain/languages","stargazers_url":"https://api.github.com/repos/agentrickard/domain/stargazers","contributors_url":"https://api.github.com/repos/agentrickard/domain/contributors","subscribers_url":"https://api.github.com/repos/agentrickard/domain/subscribers","subscription_url":"https://api.github.com/repos/agentrickard/domain/subscription","commits_url":"https://api.github.com/repos/agentrickard/domain/commits{/sha}","git_commits_url":"https://api.github.com/repos/agentrickard/domain/git/commits{/sha}","comments_url":"https://api.github.com/repos/agentrickard/domain/comments{/number}","issue_comment_url":"https://api.github.com/repos/agentrickard/domain/issues/comments{/number}","contents_url":"https://api.github.com/repos/agentrickard/domain/contents/{+path}","compare_url":"https://api.github.com/repos/agentrickard/domain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agentrickard/domain/merges","archive_url":"https://api.github.com/repos/agentrickard/domain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agentrickard/domain/downloads","issues_url":"https://api.github.com/repos/agentrickard/domain/issues{/number}","pulls_url":"https://api.github.com/repos/agentrickard/domain/pulls{/number}","milestones_url":"https://api.github.com/repos/agentrickard/domain/milestones{/number}","notifications_url":"https://api.github.com/repos/agentrickard/domain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agentrickard/domain/labels{/name}","releases_url":"https://api.github.com/repos/agentrickard/domain/releases{/id}","deployments_url":"https://api.github.com/repos/agentrickard/domain/deployments","created_at":"2013-08-15T17:57:16Z","updated_at":"2016-11-12T13:27:16Z","pushed_at":"2016-11-14T22:14:08Z","git_url":"git://github.com/agentrickard/domain.git","ssh_url":"git@github.com:agentrickard/domain.git","clone_url":"https://github.com/agentrickard/domain.git","svn_url":"https://github.com/agentrickard/domain","homepage":null,"size":3200,"stargazers_count":48,"watchers_count":48,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":52,"forks":40,"open_issues":52,"watchers":48,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/285"},"html":{"href":"https://github.com/agentrickard/domain/pull/285"},"issue":{"href":"https://api.github.com/repos/agentrickard/domain/issues/285"},"comments":{"href":"https://api.github.com/repos/agentrickard/domain/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/agentrickard/domain/statuses/81f5571a37d50da6afc1952ebe901eec46105548"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"agentrickard","id":360988,"avatar_url":"https://avatars.githubusercontent.com/u/360988?v=3","gravatar_id":"","url":"https://api.github.com/users/agentrickard","html_url":"https://github.com/agentrickard","followers_url":"https://api.github.com/users/agentrickard/followers","following_url":"https://api.github.com/users/agentrickard/following{/other_user}","gists_url":"https://api.github.com/users/agentrickard/gists{/gist_id}","starred_url":"https://api.github.com/users/agentrickard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentrickard/subscriptions","organizations_url":"https://api.github.com/users/agentrickard/orgs","repos_url":"https://api.github.com/users/agentrickard/repos","events_url":"https://api.github.com/users/agentrickard/events{/privacy}","received_events_url":"https://api.github.com/users/agentrickard/received_events","type":"User","site_admin":false},"comments":6,"review_comments":7,"commits":7,"additions":67,"deletions":13,"changed_files":6}}
{"actor":{"display_login":"agentrickard"}}