{"action":"closed","number":375,"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/375","id":87132443,"html_url":"https://github.com/01org/parameter-framework/pull/375","diff_url":"https://github.com/01org/parameter-framework/pull/375.diff","patch_url":"https://github.com/01org/parameter-framework/pull/375.patch","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/375","number":375,"state":"closed","locked":false,"title":"IntegerParameterType: Fix Min/Max XML import overflow","user":{"login":"sguiriec","id":124108,"avatar_url":"https://avatars.githubusercontent.com/u/124108?v=3","gravatar_id":"","url":"https://api.github.com/users/sguiriec","html_url":"https://github.com/sguiriec","followers_url":"https://api.github.com/users/sguiriec/followers","following_url":"https://api.github.com/users/sguiriec/following{/other_user}","gists_url":"https://api.github.com/users/sguiriec/gists{/gist_id}","starred_url":"https://api.github.com/users/sguiriec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguiriec/subscriptions","organizations_url":"https://api.github.com/users/sguiriec/orgs","repos_url":"https://api.github.com/users/sguiriec/repos","events_url":"https://api.github.com/users/sguiriec/events{/privacy}","received_events_url":"https://api.github.com/users/sguiriec/received_events","type":"User","site_admin":false},"body":"In case XML data for Min and Max values are wrongly set (out of range). The\r\nImport function is not checking out of range format. In order to avoid\r\nroll over some additional boundary check need to be done.\r\n\r\nFor exemple if we have Sign integer on 8 bits and we set Max value to 200\r\nthe new code will initialize the Max value to 127.\r\n\r\nSigned-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/375%23issuecomment-250185082%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/375%23discussion_r81094555%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/375%23discussion_r81096590%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/375%23discussion_r81096908%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/375%23issuecomment-250418839%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/375%23discussion_r81114649%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/375%23issuecomment-250185082%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40dwagner%20please%20have%20a%20look%20related%20to%20boundary%20check.%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222016-09-28T14%3A35%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/124108%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/sguiriec%22%7D%7D%2C%20%7B%22body%22%3A%20%22%23%23%20%5BCurrent%20coverage%5D%28https%3A//codecov.io/gh/01org/parameter-framework/pull/375%3Fsrc%3Dpr%29%20is%2072.04%25%20%28diff%3A%2075.00%25%29%5Cn%3E%20Merging%20%5B%23375%5D%28https%3A//codecov.io/gh/01org/parameter-framework/pull/375%3Fsrc%3Dpr%29%20into%20%5Bmaster%5D%28https%3A//codecov.io/gh/01org/parameter-framework/branch/master%3Fsrc%3Dpr%29%20will%20increase%20coverage%20by%20%2A%2A%3C.01%25%2A%2A%5Cn%5Cn%60%60%60diff%5Cn%40%40%20%20%20%20%20%20%20%20%20%20%20%20%20master%20%20%20%20%20%20%20%23375%20%20%20diff%20%40%40%5Cn%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%5Cn%20%20Files%20%20%20%20%20%20%20%20%20%20%20211%20%20%20%20%20%20%20%20211%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Lines%20%20%20%20%20%20%20%20%20%206683%20%20%20%20%20%20%206699%20%20%20%20%2B16%20%20%20%5Cn%20%20Methods%20%20%20%20%20%20%20%201438%20%20%20%20%20%20%201439%20%20%20%20%20%2B1%20%20%20%5Cn%20%20Messages%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%200%20%20%20%20%20%20%20%20%20%20%5Cn%20%20Branches%20%20%20%20%20%20%20%20857%20%20%20%20%20%20%20%20859%20%20%20%20%20%2B2%20%20%20%5Cn%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%5Cn%2B%20Hits%20%20%20%20%20%20%20%20%20%20%204814%20%20%20%20%20%20%204826%20%20%20%20%2B12%20%20%20%5Cn-%20Misses%20%20%20%20%20%20%20%20%201397%20%20%20%20%20%20%201399%20%20%20%20%20%2B2%20%20%20%5Cn-%20Partials%20%20%20%20%20%20%20%20472%20%20%20%20%20%20%20%20474%20%20%20%20%20%2B2%20%20%20%5Cn%60%60%60%5Cn%5Cn%3E%20Powered%20by%20%5BCodecov%5D%28https%3A//codecov.io%3Fsrc%3Dpr%29.%20Last%20update%20%5Bb871a8f...ba4e6ae%5D%28https%3A//codecov.io/gh/01org/parameter-framework/compare/b871a8f3b79677ec33642cd16f06868b3c87e740...ba4e6aeb4859f10f53215b9b51a2d7050bf4379f%3Fsrc%3Dpr%29%22%2C%20%22created_at%22%3A%20%222016-09-29T09%3A39%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/8655789%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/codecov-io%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%2014123028502e1d13cea32d3796fa240afe04478d%20parameter/IntegerParameterType.cpp%2013%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/375%23discussion_r81094555%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60iMin%20%3D%20-%281U%20%3C%3C%20sizeInBits%29%3B%60%22%2C%20%22created_at%22%3A%20%222016-09-29T09%3A12%3A03Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/IntegerParameterType.cpp%3AL111-154%22%7D%2C%20%22Pull%2014123028502e1d13cea32d3796fa240afe04478d%20parameter/IntegerParameterType.cpp%2066%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/375%23discussion_r81114649%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22As%20of%20today%20.xsd%20doesn%27t%20check%20the%20range.%20So%20this%20method%20allows%20to%20have%20same%20behavior%20as%20when%20we%20do%20not%20specify%20Min%20and%20Max.%5Cr%5CnIn%20case%20of%20ERROR%20a%20tool%20should%20be%20provided%20in%20order%20to%20check%20XML%20mix/max%20range%20as%20I%20am%20not%20sure%20that%20the%20error%20will%20be%20explicit%20for%20a%20full%20platform%20XML%20loading.%22%2C%20%22created_at%22%3A%20%222016-09-29T11%3A20%3A48Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/124108%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/sguiriec%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/IntegerParameterType.cpp%3AL448-464%22%7D%2C%20%22Pull%2014123028502e1d13cea32d3796fa240afe04478d%20parameter/IntegerParameterType.cpp%2063%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/375%23discussion_r81096590%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22coding%20style%3A%20method%20names%20start%20with%20a%20lowercase%20letter.%22%2C%20%22created_at%22%3A%20%222016-09-29T09%3A24%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/IntegerParameterType.cpp%3AL448-464%22%7D%2C%20%22Pull%20ba4e6aeb4859f10f53215b9b51a2d7050bf4379f%20parameter/IntegerParameterType.cpp%2067%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/375%23discussion_r81096908%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22coding%20style%20%28not%20covered%20by%20clang-format%2C%20unfortunately%29%3A%5Cr%5Cn%5Cr%5Cn%60%60%60%5Cr%5Cnif%20%28condition%29%20%7B%5Cr%5Cn%20%20%20%20statement%3B%5Cr%5Cn%7D%22%2C%20%22created_at%22%3A%20%222016-09-29T09%3A26%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/IntegerParameterType.cpp%3AL450-467%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/375#issuecomment-250185082'>General Comment</a></b>\n- <a href='https://github.com/sguiriec'><img border=0 src='https://avatars.githubusercontent.com/u/124108?v=3' height=16 width=16'></a> @dwagner please have a look related to boundary check.\n- <a href='https://github.com/codecov-io'><img border=0 src='https://avatars.githubusercontent.com/u/8655789?v=3' height=16 width=16'></a> ## [Current coverage](https://codecov.io/gh/01org/parameter-framework/pull/375?src=pr) is 72.04% (diff: 75.00%)\n> Merging [#375](https://codecov.io/gh/01org/parameter-framework/pull/375?src=pr) into [master](https://codecov.io/gh/01org/parameter-framework/branch/master?src=pr) will increase coverage by **<.01%**\n```diff\n@@             master       #375   diff @@\n==========================================\nFiles           211        211\nLines          6683       6699    +16\nMethods        1438       1439     +1\nMessages          0          0\nBranches        857        859     +2\n==========================================\n+ Hits           4814       4826    +12\n- Misses         1397       1399     +2\n- Partials        472        474     +2\n```\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [b871a8f...ba4e6ae](https://codecov.io/gh/01org/parameter-framework/compare/b871a8f3b79677ec33642cd16f06868b3c87e740...ba4e6aeb4859f10f53215b9b51a2d7050bf4379f?src=pr)\n- [ ] <a href='#crh-comment-Pull 14123028502e1d13cea32d3796fa240afe04478d parameter/IntegerParameterType.cpp 13'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/375#discussion_r81094555'>File: parameter/IntegerParameterType.cpp:L111-154</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> `iMin = -(1U << sizeInBits);`\n- [ ] <a href='#crh-comment-Pull 14123028502e1d13cea32d3796fa240afe04478d parameter/IntegerParameterType.cpp 63'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/375#discussion_r81096590'>File: parameter/IntegerParameterType.cpp:L448-464</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> coding style: method names start with a lowercase letter.\n- [ ] <a href='#crh-comment-Pull ba4e6aeb4859f10f53215b9b51a2d7050bf4379f parameter/IntegerParameterType.cpp 67'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/375#discussion_r81096908'>File: parameter/IntegerParameterType.cpp:L450-467</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> coding style (not covered by clang-format, unfortunately):\n```\nif (condition) {\nstatement;\n}\n- [ ] <a href='#crh-comment-Pull 14123028502e1d13cea32d3796fa240afe04478d parameter/IntegerParameterType.cpp 66'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/375#discussion_r81114649'>File: parameter/IntegerParameterType.cpp:L448-464</a></b>\n- <a href='https://github.com/sguiriec'><img border=0 src='https://avatars.githubusercontent.com/u/124108?v=3' height=16 width=16'></a> As of today .xsd doesn't check the range. So this method allows to have same behavior as when we do not specify Min and Max.\nIn case of ERROR a tool should be provided in order to check XML mix/max range as I am not sure that the error will be explicit for a full platform XML loading.\n\n\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/375?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/375?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/375'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-09-28T14:34:40Z","updated_at":"2016-10-20T08:20:46Z","closed_at":"2016-10-20T08:20:46Z","merged_at":null,"merge_commit_sha":"01ce757b6ab0069a10b9af9b05cd8f95f153e1ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/parameter-framework/pulls/375/commits","review_comments_url":"https://api.github.com/repos/01org/parameter-framework/pulls/375/comments","review_comment_url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/375/comments","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/a7d3f0a29e27af0b2e84ec823772be39c2a43d74","head":{"label":"sguiriec:sgc/topic/integer","ref":"sgc/topic/integer","sha":"a7d3f0a29e27af0b2e84ec823772be39c2a43d74","user":{"login":"sguiriec","id":124108,"avatar_url":"https://avatars.githubusercontent.com/u/124108?v=3","gravatar_id":"","url":"https://api.github.com/users/sguiriec","html_url":"https://github.com/sguiriec","followers_url":"https://api.github.com/users/sguiriec/followers","following_url":"https://api.github.com/users/sguiriec/following{/other_user}","gists_url":"https://api.github.com/users/sguiriec/gists{/gist_id}","starred_url":"https://api.github.com/users/sguiriec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguiriec/subscriptions","organizations_url":"https://api.github.com/users/sguiriec/orgs","repos_url":"https://api.github.com/users/sguiriec/repos","events_url":"https://api.github.com/users/sguiriec/events{/privacy}","received_events_url":"https://api.github.com/users/sguiriec/received_events","type":"User","site_admin":false},"repo":{"id":37647981,"name":"parameter-framework","full_name":"sguiriec/parameter-framework","owner":{"login":"sguiriec","id":124108,"avatar_url":"https://avatars.githubusercontent.com/u/124108?v=3","gravatar_id":"","url":"https://api.github.com/users/sguiriec","html_url":"https://github.com/sguiriec","followers_url":"https://api.github.com/users/sguiriec/followers","following_url":"https://api.github.com/users/sguiriec/following{/other_user}","gists_url":"https://api.github.com/users/sguiriec/gists{/gist_id}","starred_url":"https://api.github.com/users/sguiriec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguiriec/subscriptions","organizations_url":"https://api.github.com/users/sguiriec/orgs","repos_url":"https://api.github.com/users/sguiriec/repos","events_url":"https://api.github.com/users/sguiriec/events{/privacy}","received_events_url":"https://api.github.com/users/sguiriec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sguiriec/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":true,"url":"https://api.github.com/repos/sguiriec/parameter-framework","forks_url":"https://api.github.com/repos/sguiriec/parameter-framework/forks","keys_url":"https://api.github.com/repos/sguiriec/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sguiriec/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sguiriec/parameter-framework/teams","hooks_url":"https://api.github.com/repos/sguiriec/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/sguiriec/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/sguiriec/parameter-framework/events","assignees_url":"https://api.github.com/repos/sguiriec/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/sguiriec/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/sguiriec/parameter-framework/tags","blobs_url":"https://api.github.com/repos/sguiriec/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sguiriec/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sguiriec/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/sguiriec/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sguiriec/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/sguiriec/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/sguiriec/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/sguiriec/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/sguiriec/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/sguiriec/parameter-framework/subscription","commits_url":"https://api.github.com/repos/sguiriec/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/sguiriec/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/sguiriec/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/sguiriec/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/sguiriec/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/sguiriec/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sguiriec/parameter-framework/merges","archive_url":"https://api.github.com/repos/sguiriec/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sguiriec/parameter-framework/downloads","issues_url":"https://api.github.com/repos/sguiriec/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/sguiriec/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/sguiriec/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/sguiriec/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sguiriec/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/sguiriec/parameter-framework/releases{/id}","deployments_url":"https://api.github.com/repos/sguiriec/parameter-framework/deployments","created_at":"2015-06-18T08:41:14Z","updated_at":"2015-06-18T08:41:15Z","pushed_at":"2016-09-30T07:01:43Z","git_url":"git://github.com/sguiriec/parameter-framework.git","ssh_url":"git@github.com:sguiriec/parameter-framework.git","clone_url":"https://github.com/sguiriec/parameter-framework.git","svn_url":"https://github.com/sguiriec/parameter-framework","homepage":"","size":43995,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"b871a8f3b79677ec33642cd16f06868b3c87e740","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":16009363,"name":"parameter-framework","full_name":"01org/parameter-framework","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":false,"url":"https://api.github.com/repos/01org/parameter-framework","forks_url":"https://api.github.com/repos/01org/parameter-framework/forks","keys_url":"https://api.github.com/repos/01org/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/parameter-framework/teams","hooks_url":"https://api.github.com/repos/01org/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/01org/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/01org/parameter-framework/events","assignees_url":"https://api.github.com/repos/01org/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/01org/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/01org/parameter-framework/tags","blobs_url":"https://api.github.com/repos/01org/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/01org/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/01org/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/01org/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/01org/parameter-framework/subscription","commits_url":"https://api.github.com/repos/01org/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/01org/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/parameter-framework/merges","archive_url":"https://api.github.com/repos/01org/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/parameter-framework/downloads","issues_url":"https://api.github.com/repos/01org/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/01org/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/01org/parameter-framework/releases{/id}","deployments_url":"https://api.github.com/repos/01org/parameter-framework/deployments","created_at":"2014-01-17T19:24:01Z","updated_at":"2016-10-18T18:08:10Z","pushed_at":"2016-10-20T08:16:23Z","git_url":"git://github.com/01org/parameter-framework.git","ssh_url":"git@github.com:01org/parameter-framework.git","clone_url":"https://github.com/01org/parameter-framework.git","svn_url":"https://github.com/01org/parameter-framework","homepage":"https://01.org/parameter-framework/","size":58835,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":20,"forks":26,"open_issues":20,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/375"},"html":{"href":"https://github.com/01org/parameter-framework/pull/375"},"issue":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/375"},"comments":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/01org/parameter-framework/statuses/a7d3f0a29e27af0b2e84ec823772be39c2a43d74"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":3,"commits":7,"additions":210,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"dawagner"}}