{"action":"created","comment":{"url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/comments/82180181","pull_request_review_id":3104456,"id":82180181,"diff_hunk":"@@ -29,23 +29,23 @@\n namespace cgogn\n {\n \n-template <typename MAP_TRAITS>\n+template <typename MAP2>\n class CMap2Builder_T\n {\n public:\n \n-\tusing Self = CMap2Builder_T<MAP_TRAITS>;\n-\tusing CMap2 = cgogn::CMap2<MAP_TRAITS>;\n-\tusing CDart = typename CMap2::CDart;\n-\tusing Vertex = typename CMap2::Vertex;\n-\tusing Edge = typename CMap2::Edge;\n-\tusing Face = typename CMap2::Face;\n-\tusing Volume = typename CMap2::Volume;\n+\tusing Self = CMap2Builder_T<MAP2>;\n+\tusing Map2 = MAP2;","path":"cgogn/core/cmap/cmap2_builder.h","position":18,"original_position":18,"commit_id":"c80d250f9d40bd29e503ba7c85e5bbf23e3d90e8","original_commit_id":"c80d250f9d40bd29e503ba7c85e5bbf23e3d90e8","user":{"login":"etienneschmitt","id":15106039,"avatar_url":"https://avatars.githubusercontent.com/u/15106039?v=3","gravatar_id":"","url":"https://api.github.com/users/etienneschmitt","html_url":"https://github.com/etienneschmitt","followers_url":"https://api.github.com/users/etienneschmitt/followers","following_url":"https://api.github.com/users/etienneschmitt/following{/other_user}","gists_url":"https://api.github.com/users/etienneschmitt/gists{/gist_id}","starred_url":"https://api.github.com/users/etienneschmitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienneschmitt/subscriptions","organizations_url":"https://api.github.com/users/etienneschmitt/orgs","repos_url":"https://api.github.com/users/etienneschmitt/repos","events_url":"https://api.github.com/users/etienneschmitt/events{/privacy}","received_events_url":"https://api.github.com/users/etienneschmitt/received_events","type":"User","site_admin":false},"body":"Le nœud du problème étant qu'avec VC, quand on compile les cartes multi-res, il arrive pas à compiler la fonction de merge d'une 2-carte. Parce que dans le corps de cette fonction on instancie un Builder qui prenait une CMap2 en paramètres et non une IHCMap2... Il fallait bien trouver une solution !","created_at":"2016-10-06T12:51:18Z","updated_at":"2016-10-06T12:51:18Z","html_url":"https://github.com/cgogn/CGoGN_2/pull/249#discussion_r82180181","pull_request_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/249","_links":{"self":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/comments/82180181"},"html":{"href":"https://github.com/cgogn/CGoGN_2/pull/249#discussion_r82180181"},"pull_request":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/249"}}},"pull_request":{"url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/249","id":88236110,"html_url":"https://github.com/cgogn/CGoGN_2/pull/249","diff_url":"https://github.com/cgogn/CGoGN_2/pull/249.diff","patch_url":"https://github.com/cgogn/CGoGN_2/pull/249.patch","issue_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/249","number":249,"state":"open","locked":false,"title":"Fixed Msvc compilation issue","user":{"login":"etienneschmitt","id":15106039,"avatar_url":"https://avatars.githubusercontent.com/u/15106039?v=3","gravatar_id":"","url":"https://api.github.com/users/etienneschmitt","html_url":"https://github.com/etienneschmitt","followers_url":"https://api.github.com/users/etienneschmitt/followers","following_url":"https://api.github.com/users/etienneschmitt/following{/other_user}","gists_url":"https://api.github.com/users/etienneschmitt/gists{/gist_id}","starred_url":"https://api.github.com/users/etienneschmitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienneschmitt/subscriptions","organizations_url":"https://api.github.com/users/etienneschmitt/orgs","repos_url":"https://api.github.com/users/etienneschmitt/repos","events_url":"https://api.github.com/users/etienneschmitt/events{/privacy}","received_events_url":"https://api.github.com/users/etienneschmitt/received_events","type":"User","site_admin":false},"body":"other changes:\r\n\r\n- CMap2Builder and CMap3Builder directly take the map type as template parameter.\r\n- added unused_params(T&&, ...) function to avoid some warnings.\r\n\r\n","created_at":"2016-10-06T10:29:12Z","updated_at":"2016-10-06T12:51:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d6ebe9910ea0710ec38a412f06bb3513ce8cc93","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/249/commits","review_comments_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/249/comments","review_comment_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/249/comments","statuses_url":"https://api.github.com/repos/cgogn/CGoGN_2/statuses/c80d250f9d40bd29e503ba7c85e5bbf23e3d90e8","head":{"label":"etienneschmitt:msvc_compilation_issue","ref":"msvc_compilation_issue","sha":"c80d250f9d40bd29e503ba7c85e5bbf23e3d90e8","user":{"login":"etienneschmitt","id":15106039,"avatar_url":"https://avatars.githubusercontent.com/u/15106039?v=3","gravatar_id":"","url":"https://api.github.com/users/etienneschmitt","html_url":"https://github.com/etienneschmitt","followers_url":"https://api.github.com/users/etienneschmitt/followers","following_url":"https://api.github.com/users/etienneschmitt/following{/other_user}","gists_url":"https://api.github.com/users/etienneschmitt/gists{/gist_id}","starred_url":"https://api.github.com/users/etienneschmitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienneschmitt/subscriptions","organizations_url":"https://api.github.com/users/etienneschmitt/orgs","repos_url":"https://api.github.com/users/etienneschmitt/repos","events_url":"https://api.github.com/users/etienneschmitt/events{/privacy}","received_events_url":"https://api.github.com/users/etienneschmitt/received_events","type":"User","site_admin":false},"repo":{"id":44173764,"name":"CGoGN_2","full_name":"etienneschmitt/CGoGN_2","owner":{"login":"etienneschmitt","id":15106039,"avatar_url":"https://avatars.githubusercontent.com/u/15106039?v=3","gravatar_id":"","url":"https://api.github.com/users/etienneschmitt","html_url":"https://github.com/etienneschmitt","followers_url":"https://api.github.com/users/etienneschmitt/followers","following_url":"https://api.github.com/users/etienneschmitt/following{/other_user}","gists_url":"https://api.github.com/users/etienneschmitt/gists{/gist_id}","starred_url":"https://api.github.com/users/etienneschmitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienneschmitt/subscriptions","organizations_url":"https://api.github.com/users/etienneschmitt/orgs","repos_url":"https://api.github.com/users/etienneschmitt/repos","events_url":"https://api.github.com/users/etienneschmitt/events{/privacy}","received_events_url":"https://api.github.com/users/etienneschmitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etienneschmitt/CGoGN_2","description":"","fork":true,"url":"https://api.github.com/repos/etienneschmitt/CGoGN_2","forks_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/forks","keys_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/teams","hooks_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/hooks","issue_events_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/issues/events{/number}","events_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/events","assignees_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/assignees{/user}","branches_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/branches{/branch}","tags_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/tags","blobs_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/git/refs{/sha}","trees_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/statuses/{sha}","languages_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/languages","stargazers_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/stargazers","contributors_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/contributors","subscribers_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/subscribers","subscription_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/subscription","commits_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/commits{/sha}","git_commits_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/git/commits{/sha}","comments_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/comments{/number}","issue_comment_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/issues/comments{/number}","contents_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/contents/{+path}","compare_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/merges","archive_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/downloads","issues_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/issues{/number}","pulls_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/pulls{/number}","milestones_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/milestones{/number}","notifications_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/labels{/name}","releases_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/releases{/id}","deployments_url":"https://api.github.com/repos/etienneschmitt/CGoGN_2/deployments","created_at":"2015-10-13T12:10:53Z","updated_at":"2016-05-12T13:03:24Z","pushed_at":"2016-10-06T10:26:22Z","git_url":"git://github.com/etienneschmitt/CGoGN_2.git","ssh_url":"git@github.com:etienneschmitt/CGoGN_2.git","clone_url":"https://github.com/etienneschmitt/CGoGN_2.git","svn_url":"https://github.com/etienneschmitt/CGoGN_2","homepage":"","size":22699,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop-schmitte"}},"base":{"label":"cgogn:develop","ref":"develop","sha":"3667434348b7b5e61cbf73bb3dc4af9d24fa9ab0","user":{"login":"cgogn","id":1519802,"avatar_url":"https://avatars.githubusercontent.com/u/1519802?v=3","gravatar_id":"","url":"https://api.github.com/users/cgogn","html_url":"https://github.com/cgogn","followers_url":"https://api.github.com/users/cgogn/followers","following_url":"https://api.github.com/users/cgogn/following{/other_user}","gists_url":"https://api.github.com/users/cgogn/gists{/gist_id}","starred_url":"https://api.github.com/users/cgogn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgogn/subscriptions","organizations_url":"https://api.github.com/users/cgogn/orgs","repos_url":"https://api.github.com/users/cgogn/repos","events_url":"https://api.github.com/users/cgogn/events{/privacy}","received_events_url":"https://api.github.com/users/cgogn/received_events","type":"Organization","site_admin":false},"repo":{"id":43506722,"name":"CGoGN_2","full_name":"cgogn/CGoGN_2","owner":{"login":"cgogn","id":1519802,"avatar_url":"https://avatars.githubusercontent.com/u/1519802?v=3","gravatar_id":"","url":"https://api.github.com/users/cgogn","html_url":"https://github.com/cgogn","followers_url":"https://api.github.com/users/cgogn/followers","following_url":"https://api.github.com/users/cgogn/following{/other_user}","gists_url":"https://api.github.com/users/cgogn/gists{/gist_id}","starred_url":"https://api.github.com/users/cgogn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgogn/subscriptions","organizations_url":"https://api.github.com/users/cgogn/orgs","repos_url":"https://api.github.com/users/cgogn/repos","events_url":"https://api.github.com/users/cgogn/events{/privacy}","received_events_url":"https://api.github.com/users/cgogn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cgogn/CGoGN_2","description":"n-dimensional Meshes with Combinatorial Maps","fork":false,"url":"https://api.github.com/repos/cgogn/CGoGN_2","forks_url":"https://api.github.com/repos/cgogn/CGoGN_2/forks","keys_url":"https://api.github.com/repos/cgogn/CGoGN_2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgogn/CGoGN_2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgogn/CGoGN_2/teams","hooks_url":"https://api.github.com/repos/cgogn/CGoGN_2/hooks","issue_events_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/events{/number}","events_url":"https://api.github.com/repos/cgogn/CGoGN_2/events","assignees_url":"https://api.github.com/repos/cgogn/CGoGN_2/assignees{/user}","branches_url":"https://api.github.com/repos/cgogn/CGoGN_2/branches{/branch}","tags_url":"https://api.github.com/repos/cgogn/CGoGN_2/tags","blobs_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgogn/CGoGN_2/statuses/{sha}","languages_url":"https://api.github.com/repos/cgogn/CGoGN_2/languages","stargazers_url":"https://api.github.com/repos/cgogn/CGoGN_2/stargazers","contributors_url":"https://api.github.com/repos/cgogn/CGoGN_2/contributors","subscribers_url":"https://api.github.com/repos/cgogn/CGoGN_2/subscribers","subscription_url":"https://api.github.com/repos/cgogn/CGoGN_2/subscription","commits_url":"https://api.github.com/repos/cgogn/CGoGN_2/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgogn/CGoGN_2/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgogn/CGoGN_2/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgogn/CGoGN_2/contents/{+path}","compare_url":"https://api.github.com/repos/cgogn/CGoGN_2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgogn/CGoGN_2/merges","archive_url":"https://api.github.com/repos/cgogn/CGoGN_2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgogn/CGoGN_2/downloads","issues_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues{/number}","pulls_url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls{/number}","milestones_url":"https://api.github.com/repos/cgogn/CGoGN_2/milestones{/number}","notifications_url":"https://api.github.com/repos/cgogn/CGoGN_2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgogn/CGoGN_2/labels{/name}","releases_url":"https://api.github.com/repos/cgogn/CGoGN_2/releases{/id}","deployments_url":"https://api.github.com/repos/cgogn/CGoGN_2/deployments","created_at":"2015-10-01T16:11:58Z","updated_at":"2016-05-24T10:27:29Z","pushed_at":"2016-10-06T10:29:12Z","git_url":"git://github.com/cgogn/CGoGN_2.git","ssh_url":"git@github.com:cgogn/CGoGN_2.git","clone_url":"https://github.com/cgogn/CGoGN_2.git","svn_url":"https://github.com/cgogn/CGoGN_2","homepage":"","size":22884,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/249"},"html":{"href":"https://github.com/cgogn/CGoGN_2/pull/249"},"issue":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/issues/249"},"comments":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/cgogn/CGoGN_2/statuses/c80d250f9d40bd29e503ba7c85e5bbf23e3d90e8"}}}}
{"actor":{"display_login":"etienneschmitt"}}