{"action":"created","comment":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/87191933","pull_request_review_id":7812534,"id":87191933,"diff_hunk":"@@ -65,8 +65,38 @@ if six.PY3:\n IPA_CA_NICKNAME = 'caSigningCert cert-pki-ca'\n \n def get_nickname():\n-    csr = os.environ.get('CERTMONGER_CSR')\n-    return pkcs10.get_friendlyname(csr) if csr else None\n+    subject = os.environ.get('CERTMONGER_REQ_SUBJECT')\n+    if not subject:\n+        return None\n+\n+    subject_base = dsinstance.DsInstance().find_subject_base()\n+    if not subject_base:\n+        return None\n+\n+    nickname_by_subject_dn = {","path":"install/certmonger/dogtag-ipa-ca-renew-agent-submit","position":27,"original_position":27,"commit_id":"396149ac019eea28c127cdb65efc2119f62b65e0","original_commit_id":"396149ac019eea28c127cdb65efc2119f62b65e0","user":{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars.githubusercontent.com/u/2331938?v=3","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false},"body":"Furthermore, I'd like to (eventually) get certmonger to put the nickname into the helper's environment, and then remove the mapping.","created_at":"2016-11-09T13:31:16Z","updated_at":"2016-11-09T13:31:16Z","html_url":"https://github.com/freeipa/freeipa/pull/217#discussion_r87191933","pull_request_url":"https://api.github.com/repos/freeipa/freeipa/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/87191933"},"html":{"href":"https://github.com/freeipa/freeipa/pull/217#discussion_r87191933"},"pull_request":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/217","id":92941818,"html_url":"https://github.com/freeipa/freeipa/pull/217","diff_url":"https://github.com/freeipa/freeipa/pull/217.diff","patch_url":"https://github.com/freeipa/freeipa/pull/217.patch","issue_url":"https://api.github.com/repos/freeipa/freeipa/issues/217","number":217,"state":"open","locked":false,"title":"change certificate processing code to use python-cryptography","user":{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars.githubusercontent.com/u/2331938?v=3","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false},"body":"This commit changes certificate processing code to use python-cryptography\ninstead of NSS.\n\nPart of the refactoring effort, certificates sub-effort.\n\nReviewed at dkupka/freeipa:pull/1","created_at":"2016-11-09T10:54:56Z","updated_at":"2016-11-09T13:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23d7eaf15b346bd21d6b3d65672738715bdddff6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/freeipa/freeipa/pulls/217/commits","review_comments_url":"https://api.github.com/repos/freeipa/freeipa/pulls/217/comments","review_comment_url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeipa/freeipa/issues/217/comments","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/396149ac019eea28c127cdb65efc2119f62b65e0","head":{"label":"frasertweedale:refactor/6398-cert-processing","ref":"refactor/6398-cert-processing","sha":"396149ac019eea28c127cdb65efc2119f62b65e0","user":{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars.githubusercontent.com/u/2331938?v=3","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false},"repo":{"id":68566265,"name":"freeipa","full_name":"frasertweedale/freeipa","owner":{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars.githubusercontent.com/u/2331938?v=3","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frasertweedale/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":true,"url":"https://api.github.com/repos/frasertweedale/freeipa","forks_url":"https://api.github.com/repos/frasertweedale/freeipa/forks","keys_url":"https://api.github.com/repos/frasertweedale/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frasertweedale/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frasertweedale/freeipa/teams","hooks_url":"https://api.github.com/repos/frasertweedale/freeipa/hooks","issue_events_url":"https://api.github.com/repos/frasertweedale/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/frasertweedale/freeipa/events","assignees_url":"https://api.github.com/repos/frasertweedale/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/frasertweedale/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/frasertweedale/freeipa/tags","blobs_url":"https://api.github.com/repos/frasertweedale/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frasertweedale/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frasertweedale/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/frasertweedale/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frasertweedale/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/frasertweedale/freeipa/languages","stargazers_url":"https://api.github.com/repos/frasertweedale/freeipa/stargazers","contributors_url":"https://api.github.com/repos/frasertweedale/freeipa/contributors","subscribers_url":"https://api.github.com/repos/frasertweedale/freeipa/subscribers","subscription_url":"https://api.github.com/repos/frasertweedale/freeipa/subscription","commits_url":"https://api.github.com/repos/frasertweedale/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/frasertweedale/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/frasertweedale/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/frasertweedale/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/frasertweedale/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/frasertweedale/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frasertweedale/freeipa/merges","archive_url":"https://api.github.com/repos/frasertweedale/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frasertweedale/freeipa/downloads","issues_url":"https://api.github.com/repos/frasertweedale/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/frasertweedale/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/frasertweedale/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/frasertweedale/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frasertweedale/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/frasertweedale/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/frasertweedale/freeipa/deployments","created_at":"2016-09-19T03:33:25Z","updated_at":"2016-09-19T03:33:31Z","pushed_at":"2016-11-09T10:53:16Z","git_url":"git://github.com/frasertweedale/freeipa.git","ssh_url":"git@github.com:frasertweedale/freeipa.git","clone_url":"https://github.com/frasertweedale/freeipa.git","svn_url":"https://github.com/frasertweedale/freeipa","homepage":"http://www.freeipa.org","size":37379,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeipa:master","ref":"master","sha":"2725e440bf1e4930f9b1d19223424bcb0d4b7066","user":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars.githubusercontent.com/u/10979201?v=3","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"repo":{"id":4340318,"name":"freeipa","full_name":"freeipa/freeipa","owner":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars.githubusercontent.com/u/10979201?v=3","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeipa/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":false,"url":"https://api.github.com/repos/freeipa/freeipa","forks_url":"https://api.github.com/repos/freeipa/freeipa/forks","keys_url":"https://api.github.com/repos/freeipa/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeipa/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeipa/freeipa/teams","hooks_url":"https://api.github.com/repos/freeipa/freeipa/hooks","issue_events_url":"https://api.github.com/repos/freeipa/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/freeipa/freeipa/events","assignees_url":"https://api.github.com/repos/freeipa/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/freeipa/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/freeipa/freeipa/tags","blobs_url":"https://api.github.com/repos/freeipa/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeipa/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeipa/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeipa/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/freeipa/freeipa/languages","stargazers_url":"https://api.github.com/repos/freeipa/freeipa/stargazers","contributors_url":"https://api.github.com/repos/freeipa/freeipa/contributors","subscribers_url":"https://api.github.com/repos/freeipa/freeipa/subscribers","subscription_url":"https://api.github.com/repos/freeipa/freeipa/subscription","commits_url":"https://api.github.com/repos/freeipa/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeipa/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeipa/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeipa/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeipa/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/freeipa/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeipa/freeipa/merges","archive_url":"https://api.github.com/repos/freeipa/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeipa/freeipa/downloads","issues_url":"https://api.github.com/repos/freeipa/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/freeipa/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/freeipa/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/freeipa/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeipa/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/freeipa/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/freeipa/freeipa/deployments","created_at":"2012-05-15T20:34:40Z","updated_at":"2016-11-07T16:11:54Z","pushed_at":"2016-11-09T13:02:30Z","git_url":"git://github.com/freeipa/freeipa.git","ssh_url":"git@github.com:freeipa/freeipa.git","clone_url":"https://github.com/freeipa/freeipa.git","svn_url":"https://github.com/freeipa/freeipa","homepage":"http://www.freeipa.org","size":38043,"stargazers_count":45,"watchers_count":45,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":49,"forks":54,"open_issues":49,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/217"},"html":{"href":"https://github.com/freeipa/freeipa/pull/217"},"issue":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/217"},"comments":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/freeipa/freeipa/statuses/396149ac019eea28c127cdb65efc2119f62b65e0"}}}}
{"actor":{"display_login":"frasertweedale"}}