{"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/78018867","id":78018867,"diff_hunk":"@@ -53,20 +54,29 @@\n \t\t\t</a>\n \n \t\t\t<div class=\"hover-menu no-tap-interaction\">\n-\t\t\t\t<button class=\"menu-item no-tap-interaction\"\n-\t\t\t\t\ton-click=\"_hoverPinClickHandler\"\n-\t\t\t\t\ton-focus=\"_hoverPinMenuItem\"\n-\t\t\t\t\ton-blur=\"_unhoverPinMenuItem\"\n-\t\t\t\t\ton-mouseover=\"_hoverPinMenuItem\"\n-\t\t\t\t\ton-mouseout=\"_unhoverPinMenuItem\">\n-\t\t\t\t\t<iron-icon class=\"menu-icon\" icon=\"d2l-tier1:pin-filled\" aria-hidden=\"true\"></iron-icon>\n-\t\t\t\t\t<span class=\"menu-text pin\"\n-\t\t\t\t\t\taria-label$=\"[[localize('pinCourse', 'course', _organization.properties.name)]]\"\n-\t\t\t\t\t\t>{{localize('pin')}}</span>\n-\t\t\t\t\t<span class=\"menu-text unpin\"\n-\t\t\t\t\t\taria-label$=\"[[localize('unpinCourse', 'course', _organization.properties.name)]]\"\n-\t\t\t\t\t\t>{{localize('unpin')}}</span>\n-\t\t\t\t</button>\n+\t\t\t\t<d2l-dropdown>\n+\t\t\t\t\t<button\tclass=\"menu-item no-tap-interaction d2l-dropdown-opener\" aria-label$=\"[[_courseSettingsLabel]]\">\n+\t\t\t\t\t\t<iron-icon class=\"menu-icon\" icon=\"d2l-tier1:more\"></iron-icon>\n+\t\t\t\t\t</button>\n+\t\t\t\t\t<d2l-dropdown-menu id=\"overlow-dropdown\">\n+\t\t\t\t\t\t<d2l-menu label$=\"[[_courseSettingsLabel]]\">","path":"d2l-course-tile.html","position":42,"original_position":42,"commit_id":"7ba665ac396cbf2b758662c9f22ef61f40f148ac","original_commit_id":"7ba665ac396cbf2b758662c9f22ef61f40f148ac","user":{"login":"trevorjonesd2l","id":8656538,"avatar_url":"https://avatars.githubusercontent.com/u/8656538?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorjonesd2l","html_url":"https://github.com/trevorjonesd2l","followers_url":"https://api.github.com/users/trevorjonesd2l/followers","following_url":"https://api.github.com/users/trevorjonesd2l/following{/other_user}","gists_url":"https://api.github.com/users/trevorjonesd2l/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorjonesd2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorjonesd2l/subscriptions","organizations_url":"https://api.github.com/users/trevorjonesd2l/orgs","repos_url":"https://api.github.com/users/trevorjonesd2l/repos","events_url":"https://api.github.com/users/trevorjonesd2l/events{/privacy}","received_events_url":"https://api.github.com/users/trevorjonesd2l/received_events","type":"User","site_admin":false},"body":"`d2l-dropdown-opener` class on the `button` hooks up the magic","created_at":"2016-09-08T14:37:34Z","updated_at":"2016-09-08T14:37:34Z","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/115#discussion_r78018867","pull_request_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/78018867"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/115#discussion_r78018867"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/115","id":84373697,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/115","diff_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/115.diff","patch_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/115.patch","issue_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/115","number":115,"state":"open","locked":false,"title":"US75742 Overflow menu","user":{"login":"trevorjonesd2l","id":8656538,"avatar_url":"https://avatars.githubusercontent.com/u/8656538?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorjonesd2l","html_url":"https://github.com/trevorjonesd2l","followers_url":"https://api.github.com/users/trevorjonesd2l/followers","following_url":"https://api.github.com/users/trevorjonesd2l/following{/other_user}","gists_url":"https://api.github.com/users/trevorjonesd2l/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorjonesd2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorjonesd2l/subscriptions","organizations_url":"https://api.github.com/users/trevorjonesd2l/orgs","repos_url":"https://api.github.com/users/trevorjonesd2l/repos","events_url":"https://api.github.com/users/trevorjonesd2l/events{/privacy}","received_events_url":"https://api.github.com/users/trevorjonesd2l/received_events","type":"User","site_admin":false},"body":"I'm opening this branch up for code review as I finish writing the tests.\r\n\r\n## Story Details\r\n\r\n> Currently unpin is a on-hover button, which means users can accidentally unclick it.  We want to move to a menu so it's less likely to unpin, as well, give options to set the course image from this menu.\r\n> \r\n> Need to move to a \"...\" menu design so we can do a 'set course image' link in the future.\r\n> \r\n\r\nThere is no effect on mobile (still only Pin/Unpin option on long-press).\r\n\r\nLink: [US75742](https://rally1.rallydev.com/#/51191528503d/detail/userstory/61127022629).\r\n\r\n## Implementation\r\n\r\nThe implementation is not exact to the design you'll see invisionapp due to working based off `d2l-dropdown` and using their pre-existing designs.\r\n\r\n### Screenshots from implementation\r\n\r\n#### 1 Hover state\r\n![image](https://cloud.githubusercontent.com/assets/8656538/18327945/c9b73b08-751a-11e6-8ce1-d45dc5aef164.png)\r\n\r\n####  2a Open state one (both options)\r\n![image](https://cloud.githubusercontent.com/assets/8656538/18327996/fd5e1094-751a-11e6-8c7d-af7b5c712237.png)\r\n\r\n#### 2b Open state two (user with no edit image permission)\r\n![image](https://cloud.githubusercontent.com/assets/8656538/18328026/1a5a5108-751b-11e6-9886-6de406c445a3.png)\r\n\r\n#### 3 All Courses overlay (same behaviour)\r\n![image](https://cloud.githubusercontent.com/assets/8656538/18328075/463ebf66-751b-11e6-8ea8-a1455c56539a.png)\r\n\r\nYou can see in images 2b and 3 the hover effect with the pin/unpin button.\r\n\r\n### Accessibility\r\n\r\nThe menu is fully tab-accessible. Tested in Chrome, Firefox and Internet Explorer.\r\n\r\nThere are a couple added labels or changed labels:\r\n\r\n- Added: Overflow menu button & dropdown menu label: `Accounting Information Systems course settings`\r\n- Added: Change image is: `Change image`\r\n- Modified: Unpin/pin course are now just: `Pin` or `Unpin`\r\n\r\nI tested the screen-reading with NVDA and Firefox.\r\n\r\n## To do...\r\n\r\n- [ ] Fix tests\r\n- [ ] Write tests\r\n- [ ] Test in safari\r\n","created_at":"2016-09-07T21:06:29Z","updated_at":"2016-09-08T14:37:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2aaaf89e0b6ae0ba3778e7bf2f863cb3eef0d697","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/115/commits","review_comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/115/comments","review_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/115/comments","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/7ba665ac396cbf2b758662c9f22ef61f40f148ac","head":{"label":"Brightspace:overflow-menu","ref":"overflow-menu","sha":"7ba665ac396cbf2b758662c9f22ef61f40f148ac","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":"","fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2016-09-06T18:35:16Z","pushed_at":"2016-09-07T22:48:41Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":467,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"7e77d222efd734b44d4a19d3a2af3335d044af0f","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":"","fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2016-09-06T18:35:16Z","pushed_at":"2016-09-07T22:48:41Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":467,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/115"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/115"},"issue":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/115"},"comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/7ba665ac396cbf2b758662c9f22ef61f40f148ac"}}}}
{"actor":{"display_login":"trevorjonesd2l"}}