{"action":"opened","number":70,"pull_request":{"url":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls/70","id":97465543,"html_url":"https://github.com/jgaeddert/liquid-dsp/pull/70","diff_url":"https://github.com/jgaeddert/liquid-dsp/pull/70.diff","patch_url":"https://github.com/jgaeddert/liquid-dsp/pull/70.patch","issue_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/issues/70","number":70,"state":"open","locked":false,"title":"makefile.in: Fix overloading of LDFLAGS and CFLAGS","user":{"login":"andreasbombe","id":6385157,"avatar_url":"https://avatars.githubusercontent.com/u/6385157?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasbombe","html_url":"https://github.com/andreasbombe","followers_url":"https://api.github.com/users/andreasbombe/followers","following_url":"https://api.github.com/users/andreasbombe/following{/other_user}","gists_url":"https://api.github.com/users/andreasbombe/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasbombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasbombe/subscriptions","organizations_url":"https://api.github.com/users/andreasbombe/orgs","repos_url":"https://api.github.com/users/andreasbombe/repos","events_url":"https://api.github.com/users/andreasbombe/events{/privacy}","received_events_url":"https://api.github.com/users/andreasbombe/received_events","type":"User","site_admin":false},"body":"The makefile.in used the variable LDFLAGS for both flags and libraries\r\nto link. This will create problems as many flags need to appear before\r\nthe object files while the libraries to link need to appear after. A\r\nsimilar problem stems from using CFLAGS for both include path\r\nspecifications and regular C compiler flags, as the CFLAGS are needed\r\nfor proper linking.\r\n\r\nThis patch splits LDFLAGS into LDFLAGS for flags only and LIBS for libs\r\nonly and splits CFLAGS into CFLAGS for compiler flags only and CPPFLAGS\r\nfor include path specifications only. Linking now changes LDFLAGS to\r\nLIBS and adds CFLAGS and LDFLAGS at the beginning of the command. The\r\npreviously ignored @CPPFLAGS@ autoconf value is now also included in\r\nCPPFLAGS.","created_at":"2016-12-11T17:21:08Z","updated_at":"2016-12-11T17:21:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls/70/commits","review_comments_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls/70/comments","review_comment_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/issues/70/comments","statuses_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/statuses/c0b98ac84389854146cbeddb8d2aad5dce55e1bb","head":{"label":"andreasbombe:master","ref":"master","sha":"c0b98ac84389854146cbeddb8d2aad5dce55e1bb","user":{"login":"andreasbombe","id":6385157,"avatar_url":"https://avatars.githubusercontent.com/u/6385157?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasbombe","html_url":"https://github.com/andreasbombe","followers_url":"https://api.github.com/users/andreasbombe/followers","following_url":"https://api.github.com/users/andreasbombe/following{/other_user}","gists_url":"https://api.github.com/users/andreasbombe/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasbombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasbombe/subscriptions","organizations_url":"https://api.github.com/users/andreasbombe/orgs","repos_url":"https://api.github.com/users/andreasbombe/repos","events_url":"https://api.github.com/users/andreasbombe/events{/privacy}","received_events_url":"https://api.github.com/users/andreasbombe/received_events","type":"User","site_admin":false},"repo":{"id":76187955,"name":"liquid-dsp","full_name":"andreasbombe/liquid-dsp","owner":{"login":"andreasbombe","id":6385157,"avatar_url":"https://avatars.githubusercontent.com/u/6385157?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasbombe","html_url":"https://github.com/andreasbombe","followers_url":"https://api.github.com/users/andreasbombe/followers","following_url":"https://api.github.com/users/andreasbombe/following{/other_user}","gists_url":"https://api.github.com/users/andreasbombe/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasbombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasbombe/subscriptions","organizations_url":"https://api.github.com/users/andreasbombe/orgs","repos_url":"https://api.github.com/users/andreasbombe/repos","events_url":"https://api.github.com/users/andreasbombe/events{/privacy}","received_events_url":"https://api.github.com/users/andreasbombe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreasbombe/liquid-dsp","description":"digital signal processing library for software-defined radios","fork":true,"url":"https://api.github.com/repos/andreasbombe/liquid-dsp","forks_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/forks","keys_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/teams","hooks_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/hooks","issue_events_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/issues/events{/number}","events_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/events","assignees_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/assignees{/user}","branches_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/branches{/branch}","tags_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/tags","blobs_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/statuses/{sha}","languages_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/languages","stargazers_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/stargazers","contributors_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/contributors","subscribers_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/subscribers","subscription_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/subscription","commits_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/contents/{+path}","compare_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/merges","archive_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/downloads","issues_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/issues{/number}","pulls_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/pulls{/number}","milestones_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/milestones{/number}","notifications_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/labels{/name}","releases_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/releases{/id}","deployments_url":"https://api.github.com/repos/andreasbombe/liquid-dsp/deployments","created_at":"2016-12-11T17:08:03Z","updated_at":"2016-12-11T17:08:06Z","pushed_at":"2016-12-11T17:19:17Z","git_url":"git://github.com/andreasbombe/liquid-dsp.git","ssh_url":"git@github.com:andreasbombe/liquid-dsp.git","clone_url":"https://github.com/andreasbombe/liquid-dsp.git","svn_url":"https://github.com/andreasbombe/liquid-dsp","homepage":"http://liquidsdr.org","size":23448,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jgaeddert:master","ref":"master","sha":"6b55d1c9c6fa9738b459d1dff6ba4f627b1d866c","user":{"login":"jgaeddert","id":253027,"avatar_url":"https://avatars.githubusercontent.com/u/253027?v=3","gravatar_id":"","url":"https://api.github.com/users/jgaeddert","html_url":"https://github.com/jgaeddert","followers_url":"https://api.github.com/users/jgaeddert/followers","following_url":"https://api.github.com/users/jgaeddert/following{/other_user}","gists_url":"https://api.github.com/users/jgaeddert/gists{/gist_id}","starred_url":"https://api.github.com/users/jgaeddert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgaeddert/subscriptions","organizations_url":"https://api.github.com/users/jgaeddert/orgs","repos_url":"https://api.github.com/users/jgaeddert/repos","events_url":"https://api.github.com/users/jgaeddert/events{/privacy}","received_events_url":"https://api.github.com/users/jgaeddert/received_events","type":"User","site_admin":false},"repo":{"id":655580,"name":"liquid-dsp","full_name":"jgaeddert/liquid-dsp","owner":{"login":"jgaeddert","id":253027,"avatar_url":"https://avatars.githubusercontent.com/u/253027?v=3","gravatar_id":"","url":"https://api.github.com/users/jgaeddert","html_url":"https://github.com/jgaeddert","followers_url":"https://api.github.com/users/jgaeddert/followers","following_url":"https://api.github.com/users/jgaeddert/following{/other_user}","gists_url":"https://api.github.com/users/jgaeddert/gists{/gist_id}","starred_url":"https://api.github.com/users/jgaeddert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgaeddert/subscriptions","organizations_url":"https://api.github.com/users/jgaeddert/orgs","repos_url":"https://api.github.com/users/jgaeddert/repos","events_url":"https://api.github.com/users/jgaeddert/events{/privacy}","received_events_url":"https://api.github.com/users/jgaeddert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgaeddert/liquid-dsp","description":"digital signal processing library for software-defined radios","fork":false,"url":"https://api.github.com/repos/jgaeddert/liquid-dsp","forks_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/forks","keys_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/teams","hooks_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/hooks","issue_events_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/issues/events{/number}","events_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/events","assignees_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/assignees{/user}","branches_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/branches{/branch}","tags_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/tags","blobs_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/statuses/{sha}","languages_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/languages","stargazers_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/stargazers","contributors_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/contributors","subscribers_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/subscribers","subscription_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/subscription","commits_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/contents/{+path}","compare_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/merges","archive_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/downloads","issues_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/issues{/number}","pulls_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls{/number}","milestones_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/milestones{/number}","notifications_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/labels{/name}","releases_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/releases{/id}","deployments_url":"https://api.github.com/repos/jgaeddert/liquid-dsp/deployments","created_at":"2010-05-07T20:11:10Z","updated_at":"2016-12-10T15:16:24Z","pushed_at":"2016-12-11T17:21:08Z","git_url":"git://github.com/jgaeddert/liquid-dsp.git","ssh_url":"git@github.com:jgaeddert/liquid-dsp.git","clone_url":"https://github.com/jgaeddert/liquid-dsp.git","svn_url":"https://github.com/jgaeddert/liquid-dsp","homepage":"http://liquidsdr.org","size":23448,"stargazers_count":291,"watchers_count":291,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":38,"forks":86,"open_issues":38,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls/70"},"html":{"href":"https://github.com/jgaeddert/liquid-dsp/pull/70"},"issue":{"href":"https://api.github.com/repos/jgaeddert/liquid-dsp/issues/70"},"comments":{"href":"https://api.github.com/repos/jgaeddert/liquid-dsp/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jgaeddert/liquid-dsp/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/jgaeddert/liquid-dsp/statuses/c0b98ac84389854146cbeddb8d2aad5dce55e1bb"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":20,"changed_files":1}}
{"actor":{"display_login":"andreasbombe"}}