{"action":"opened","number":1599,"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/1599","id":97073611,"html_url":"https://github.com/twitter/heron/pull/1599","diff_url":"https://github.com/twitter/heron/pull/1599.diff","patch_url":"https://github.com/twitter/heron/pull/1599.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/1599","number":1599,"state":"open","locked":false,"title":"Remove duplicated code in SubmitterMain and SchedulerConfig","user":{"login":"mycFelix","id":4719414,"avatar_url":"https://avatars.githubusercontent.com/u/4719414?v=3","gravatar_id":"","url":"https://api.github.com/users/mycFelix","html_url":"https://github.com/mycFelix","followers_url":"https://api.github.com/users/mycFelix/followers","following_url":"https://api.github.com/users/mycFelix/following{/other_user}","gists_url":"https://api.github.com/users/mycFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/mycFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mycFelix/subscriptions","organizations_url":"https://api.github.com/users/mycFelix/orgs","repos_url":"https://api.github.com/users/mycFelix/repos","events_url":"https://api.github.com/users/mycFelix/events{/privacy}","received_events_url":"https://api.github.com/users/mycFelix/received_events","type":"User","site_admin":false},"body":"As #1597 mentioned, the duplicated code is found in SubmitterMain and SchedulerConfig. \r\n\r\nThis PR is trying to fix it and the changes are following:\r\n\r\n* add an new method ` String getPkgType(String topologyBinaryFile) `\r\n* invoke `getPkgType` method in SubmitterMain\r\n* invoke `getPkgType` method in SchedulerConfig","created_at":"2016-12-08T07:45:40Z","updated_at":"2016-12-08T07:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0986178a70b8390e3532594c6ead618a27004d9f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/heron/pulls/1599/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/1599/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/1599/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/d1efe1be6dab4931b22e0b83b9ec2549345ced86","head":{"label":"mycFelix:remove-duplicated-code","ref":"remove-duplicated-code","sha":"d1efe1be6dab4931b22e0b83b9ec2549345ced86","user":{"login":"mycFelix","id":4719414,"avatar_url":"https://avatars.githubusercontent.com/u/4719414?v=3","gravatar_id":"","url":"https://api.github.com/users/mycFelix","html_url":"https://github.com/mycFelix","followers_url":"https://api.github.com/users/mycFelix/followers","following_url":"https://api.github.com/users/mycFelix/following{/other_user}","gists_url":"https://api.github.com/users/mycFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/mycFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mycFelix/subscriptions","organizations_url":"https://api.github.com/users/mycFelix/orgs","repos_url":"https://api.github.com/users/mycFelix/repos","events_url":"https://api.github.com/users/mycFelix/events{/privacy}","received_events_url":"https://api.github.com/users/mycFelix/received_events","type":"User","site_admin":false},"repo":{"id":64271353,"name":"heron","full_name":"mycFelix/heron","owner":{"login":"mycFelix","id":4719414,"avatar_url":"https://avatars.githubusercontent.com/u/4719414?v=3","gravatar_id":"","url":"https://api.github.com/users/mycFelix","html_url":"https://github.com/mycFelix","followers_url":"https://api.github.com/users/mycFelix/followers","following_url":"https://api.github.com/users/mycFelix/following{/other_user}","gists_url":"https://api.github.com/users/mycFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/mycFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mycFelix/subscriptions","organizations_url":"https://api.github.com/users/mycFelix/orgs","repos_url":"https://api.github.com/users/mycFelix/repos","events_url":"https://api.github.com/users/mycFelix/events{/privacy}","received_events_url":"https://api.github.com/users/mycFelix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mycFelix/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/mycFelix/heron","forks_url":"https://api.github.com/repos/mycFelix/heron/forks","keys_url":"https://api.github.com/repos/mycFelix/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mycFelix/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mycFelix/heron/teams","hooks_url":"https://api.github.com/repos/mycFelix/heron/hooks","issue_events_url":"https://api.github.com/repos/mycFelix/heron/issues/events{/number}","events_url":"https://api.github.com/repos/mycFelix/heron/events","assignees_url":"https://api.github.com/repos/mycFelix/heron/assignees{/user}","branches_url":"https://api.github.com/repos/mycFelix/heron/branches{/branch}","tags_url":"https://api.github.com/repos/mycFelix/heron/tags","blobs_url":"https://api.github.com/repos/mycFelix/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mycFelix/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mycFelix/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/mycFelix/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mycFelix/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/mycFelix/heron/languages","stargazers_url":"https://api.github.com/repos/mycFelix/heron/stargazers","contributors_url":"https://api.github.com/repos/mycFelix/heron/contributors","subscribers_url":"https://api.github.com/repos/mycFelix/heron/subscribers","subscription_url":"https://api.github.com/repos/mycFelix/heron/subscription","commits_url":"https://api.github.com/repos/mycFelix/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/mycFelix/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/mycFelix/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/mycFelix/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/mycFelix/heron/contents/{+path}","compare_url":"https://api.github.com/repos/mycFelix/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mycFelix/heron/merges","archive_url":"https://api.github.com/repos/mycFelix/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mycFelix/heron/downloads","issues_url":"https://api.github.com/repos/mycFelix/heron/issues{/number}","pulls_url":"https://api.github.com/repos/mycFelix/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/mycFelix/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/mycFelix/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mycFelix/heron/labels{/name}","releases_url":"https://api.github.com/repos/mycFelix/heron/releases{/id}","deployments_url":"https://api.github.com/repos/mycFelix/heron/deployments","created_at":"2016-07-27T02:43:27Z","updated_at":"2016-07-27T02:43:31Z","pushed_at":"2016-12-08T07:37:16Z","git_url":"git://github.com/mycFelix/heron.git","ssh_url":"git@github.com:mycFelix/heron.git","clone_url":"https://github.com/mycFelix/heron.git","svn_url":"https://github.com/mycFelix/heron","homepage":"http://heronstreaming.io","size":115055,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"a955456b553929e0b8c5ae985267782b12f4f349","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2016-12-07T14:26:46Z","pushed_at":"2016-12-08T07:45:40Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"git@github.com:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":153482,"stargazers_count":2532,"watchers_count":2532,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":437,"mirror_url":null,"open_issues_count":217,"forks":437,"open_issues":217,"watchers":2532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/1599"},"html":{"href":"https://github.com/twitter/heron/pull/1599"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/1599"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/1599/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/1599/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/1599/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/d1efe1be6dab4931b22e0b83b9ec2549345ced86"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":19,"changed_files":3}}
{"actor":{"display_login":"mycFelix"}}