{"action":"created","issue":{"url":"https://api.github.com/repos/higurashi-mod/tatarigoroshi/issues/3","repository_url":"https://api.github.com/repos/higurashi-mod/tatarigoroshi","labels_url":"https://api.github.com/repos/higurashi-mod/tatarigoroshi/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/higurashi-mod/tatarigoroshi/issues/3/comments","events_url":"https://api.github.com/repos/higurashi-mod/tatarigoroshi/issues/3/events","html_url":"https://github.com/higurashi-mod/tatarigoroshi/pull/3","id":163662442,"number":3,"title":"Add automated voice lines","user":{"login":"enumag","id":539462,"avatar_url":"https://avatars.githubusercontent.com/u/539462?v=3","gravatar_id":"","url":"https://api.github.com/users/enumag","html_url":"https://github.com/enumag","followers_url":"https://api.github.com/users/enumag/followers","following_url":"https://api.github.com/users/enumag/following{/other_user}","gists_url":"https://api.github.com/users/enumag/gists{/gist_id}","starred_url":"https://api.github.com/users/enumag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enumag/subscriptions","organizations_url":"https://api.github.com/users/enumag/orgs","repos_url":"https://api.github.com/users/enumag/repos","events_url":"https://api.github.com/users/enumag/events{/privacy}","received_events_url":"https://api.github.com/users/enumag/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-04T12:00:27Z","updated_at":"2016-07-04T14:30:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/higurashi-mod/tatarigoroshi/pulls/3","html_url":"https://github.com/higurashi-mod/tatarigoroshi/pull/3","diff_url":"https://github.com/higurashi-mod/tatarigoroshi/pull/3.diff","patch_url":"https://github.com/higurashi-mod/tatarigoroshi/pull/3.patch"},"body":"The script uses several methods to match the voice lines to the script. It is just a first draft though so I need a feedback:\r\n\r\n- Are there any missing lines you think the script should be able to insert?\r\n- Did the script insert any lines where it should not have insert anything?\r\n- Did the script insert a wrong voice file anywhere?\r\n- Is there anything else the script should fix?\r\n\r\nAlso I'd like to aim for this script to be better than the old one. So don't restrain your requests to what the old script did.\r\n\r\nOutput from the current version of the script:\r\n\r\n```\r\nInserted 189 voice lines to omake_03.txt.\r\nInserted 610 voice lines to tata_001.txt.\r\nInserted 599 voice lines to tata_002.txt.\r\nInserted 672 voice lines to tata_003.txt.\r\nInserted 597 voice lines to tata_004.txt.\r\nInserted 410 voice lines to tata_005.txt.\r\nInserted 563 voice lines to tata_008.txt.\r\nInserted 14 voice lines to tata_008_02.txt.\r\nInserted 338 voice lines to tata_009.txt.\r\nInserted 176 voice lines to tata_009_02.txt.\r\nInserted 115 voice lines to tata_010.txt.\r\nInserted 143 voice lines to tata_010_02.txt.\r\nInserted 57 voice lines to tata_010_03.txt.\r\nInserted 149 voice lines to tata_010_04.txt.\r\nInserted 40 voice lines to tata_011.txt.\r\nInserted 60 voice lines to tata_011_02.txt.\r\nInserted 149 voice lines to tata_011_03.txt.\r\nInserted 589 voice lines to tata_012.txt.\r\nInserted 28 voice lines to tata_013.txt.\r\nInserted 326 voice lines to tata_013_02.txt.\r\nInserted 83 voice lines to tata_014.txt.\r\nInserted 0 voice lines to tata_ep01.txt.\r\nInserted 108 voice lines to tata_ep02.txt.\r\nInserted 54 voice lines to tata_tips_01.txt.\r\nInserted 38 voice lines to tata_tips_02.txt.\r\nInserted 73 voice lines to tata_tips_03.txt.\r\nInserted 47 voice lines to tata_tips_04.txt.\r\nInserted 1 voice lines to tata_tips_05.txt.\r\nInserted 33 voice lines to tata_tips_06.txt.\r\nInserted 0 voice lines to tata_tips_07.txt.\r\nInserted 0 voice lines to tata_tips_08.txt.\r\nInserted 0 voice lines to tata_tips_09.txt.\r\nInserted 0 voice lines to tata_tips_10.txt.\r\nInserted 0 voice lines to tata_tips_11.txt.\r\nInserted 0 voice lines to tata_tips_12.txt.\r\nInserted 0 voice lines to tata_tips_13.txt.\r\nInserted 0 voice lines to tata_tips_14.txt.\r\nInserted 17 voice lines to tata_tips_15.txt.\r\nInserted 21 voice lines to tata_tips_16.txt.\r\nInserted 20 voice lines to tata_tips_17.txt.\r\nInserted 0 voice lines to tata_tips_18.txt.\r\nInserted 0 voice lines to tata_tips_19.txt.\r\n```\r\n\r\nIf you're satisfied with the results create a new repository for me to push the script source code there."},"comment":{"url":"https://api.github.com/repos/higurashi-mod/tatarigoroshi/issues/comments/230303220","html_url":"https://github.com/higurashi-mod/tatarigoroshi/pull/3#issuecomment-230303220","issue_url":"https://api.github.com/repos/higurashi-mod/tatarigoroshi/issues/3","id":230303220,"user":{"login":"ItaloKnox","id":4702556,"avatar_url":"https://avatars.githubusercontent.com/u/4702556?v=3","gravatar_id":"","url":"https://api.github.com/users/ItaloKnox","html_url":"https://github.com/ItaloKnox","followers_url":"https://api.github.com/users/ItaloKnox/followers","following_url":"https://api.github.com/users/ItaloKnox/following{/other_user}","gists_url":"https://api.github.com/users/ItaloKnox/gists{/gist_id}","starred_url":"https://api.github.com/users/ItaloKnox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItaloKnox/subscriptions","organizations_url":"https://api.github.com/users/ItaloKnox/orgs","repos_url":"https://api.github.com/users/ItaloKnox/repos","events_url":"https://api.github.com/users/ItaloKnox/events{/privacy}","received_events_url":"https://api.github.com/users/ItaloKnox/received_events","type":"User","site_admin":false},"created_at":"2016-07-04T14:30:29Z","updated_at":"2016-07-04T14:30:29Z","body":"Looks fine overall. I would say it catches more stuff than the previous script, and the stuff I could see that needed to be fixed is just the Levenshtein distance threshold being followed. Not a big deal at all, this happens when you have a dialog broken into three voices, and the middle voice is the one where it matches *less* than the others.\r\n\r\nAnyway, I'm accepting this one here. Thank you for you hard work!"}}
{"actor":{"display_login":"ItaloKnox"}}