{"action":"opened","number":5266,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5266","id":84568441,"html_url":"https://github.com/puppetlabs/puppet/pull/5266","diff_url":"https://github.com/puppetlabs/puppet/pull/5266.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5266.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5266","number":5266,"state":"open","locked":false,"title":"(PUP-6636) Only match /environment/:env route as the whole path","user":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"body":"Previously, the /environment/:env route wasn't properly anchored to the\r\nstart of the path, so routes with other prefixes would also match.\r\nBecause auth is performed separately based on the path, this allowed\r\nrequests like /status/environment/production to bypass auth checks and\r\nretrieve environment catalogs. This also meant that other valid requests\r\nending in /environment/:foo, such as for files, would be handled\r\nincorrectly.\r\n\r\nWe now properly anchor the /environment/:env regex to the beginning of\r\nthe path, so only explicit environment requests will match.","created_at":"2016-09-08T22:58:04Z","updated_at":"2016-09-08T22:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31c121ad2dd1c823941c6f533613c1f768385dee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5266/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5266/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5266/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/688802fd27f912cb4894d23b80e0617ca91bd9e9","head":{"label":"McdonaldSeanp:cp-pup6636","ref":"cp-pup6636","sha":"688802fd27f912cb4894d23b80e0617ca91bd9e9","user":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"repo":{"id":48507869,"name":"puppet","full_name":"McdonaldSeanp/puppet","owner":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/McdonaldSeanp/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/McdonaldSeanp/puppet","forks_url":"https://api.github.com/repos/McdonaldSeanp/puppet/forks","keys_url":"https://api.github.com/repos/McdonaldSeanp/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/McdonaldSeanp/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/McdonaldSeanp/puppet/teams","hooks_url":"https://api.github.com/repos/McdonaldSeanp/puppet/hooks","issue_events_url":"https://api.github.com/repos/McdonaldSeanp/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/McdonaldSeanp/puppet/events","assignees_url":"https://api.github.com/repos/McdonaldSeanp/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/McdonaldSeanp/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/McdonaldSeanp/puppet/tags","blobs_url":"https://api.github.com/repos/McdonaldSeanp/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/McdonaldSeanp/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/McdonaldSeanp/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/McdonaldSeanp/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/McdonaldSeanp/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/McdonaldSeanp/puppet/languages","stargazers_url":"https://api.github.com/repos/McdonaldSeanp/puppet/stargazers","contributors_url":"https://api.github.com/repos/McdonaldSeanp/puppet/contributors","subscribers_url":"https://api.github.com/repos/McdonaldSeanp/puppet/subscribers","subscription_url":"https://api.github.com/repos/McdonaldSeanp/puppet/subscription","commits_url":"https://api.github.com/repos/McdonaldSeanp/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/McdonaldSeanp/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/McdonaldSeanp/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/McdonaldSeanp/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/McdonaldSeanp/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/McdonaldSeanp/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/McdonaldSeanp/puppet/merges","archive_url":"https://api.github.com/repos/McdonaldSeanp/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/McdonaldSeanp/puppet/downloads","issues_url":"https://api.github.com/repos/McdonaldSeanp/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/McdonaldSeanp/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/McdonaldSeanp/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/McdonaldSeanp/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/McdonaldSeanp/puppet/labels{/name}","releases_url":"https://api.github.com/repos/McdonaldSeanp/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/McdonaldSeanp/puppet/deployments","created_at":"2015-12-23T19:35:46Z","updated_at":"2016-03-17T16:55:54Z","pushed_at":"2016-09-08T22:57:50Z","git_url":"git://github.com/McdonaldSeanp/puppet.git","ssh_url":"git@github.com:McdonaldSeanp/puppet.git","clone_url":"https://github.com/McdonaldSeanp/puppet.git","svn_url":"https://github.com/McdonaldSeanp/puppet","homepage":"https://puppetlabs.com/puppet/what-is-puppet","size":52677,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"08bb4192951d245d101491222d7cdfd6bf1b346b","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-09-08T00:55:29Z","pushed_at":"2016-09-08T22:58:04Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":82763,"stargazers_count":4148,"watchers_count":4148,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1707,"mirror_url":null,"open_issues_count":61,"forks":1707,"open_issues":61,"watchers":4148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5266"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5266"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5266"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5266/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5266/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5266/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/688802fd27f912cb4894d23b80e0617ca91bd9e9"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"McdonaldSeanp"}}