{"push_id":1150073368,"size":22,"distinct_size":22,"ref":"refs/heads/master","head":"97bf76b3231ad26321dd70e598f02c7160dd64e3","before":"8cb1ca644b0d589542bf64799224c1b23df37cc6","commits":[{"sha":"54b84305f17c25de8dc671ca9f195f31095783c4","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"bump version in the code in advance of some internal beta testing\n\nDeliberately not bumping the docs at this stage.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/54b84305f17c25de8dc671ca9f195f31095783c4"},{"sha":"d8aafa1fd44b1a0f15473a7de1ff87c94e5d9a76","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"remove _ignore_watchmanconfig option\n\nThe foul purposes for which it was needed are no more.  Remove it.\n\nTest Plan: make integration","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/d8aafa1fd44b1a0f15473a7de1ff87c94e5d9a76"},{"sha":"ae931ffe2ab668ca1d9ae0cf41df6bfe0aa357cf","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"pywatchman: add a LICENSE file\n\nWe were missing one for this subdirectory.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/ae931ffe2ab668ca1d9ae0cf41df6bfe0aa357cf"},{"sha":"f4e6c9b61b01c20740cf8b8f6c3380bbd95f570a","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"pywatchman: add reraise from six\n\nTaking a library dependency is way too painful, so just copy this function in.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/f4e6c9b61b01c20740cf8b8f6c3380bbd95f570a"},{"sha":"7658f4089426d7d0ae025333c7018b6d0f281baa","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"pywatchman: raise a structured exception for socket connection issues\n\nThis will help us robustly test for this error in upcoming patches.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/7658f4089426d7d0ae025333c7018b6d0f281baa"},{"sha":"25865ac3f68f455856fdcb39f8ea105e40c45bad","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"tests: raise structured exception if connecting to socket failed\n\nWe were losing this structure before -- maintain it.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/25865ac3f68f455856fdcb39f8ea105e40c45bad"},{"sha":"b7eb74dd520f72dfdaeed7440a4700751a590838","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"statedir: use dirfd to avoid TOCTTOU races","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/b7eb74dd520f72dfdaeed7440a4700751a590838"},{"sha":"5d5acf9f9fa5dca60f768e7d951123cf233581a7","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"opt: add a way to hide options\n\nIf no help text is provided, assume that the option should not be shown. We're\ngoing to use this for a test-only option in an upcoming patch.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/5d5acf9f9fa5dca60f768e7d951123cf233581a7"},{"sha":"72f1fe1cb3e462f83878d256d285f8ff867bdfc2","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"main: allow specifying a test-state-dir option\n\nThis is only meant to be used during testing, and is to allow exercising\nstatedir creation code.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/72f1fe1cb3e462f83878d256d285f8ff867bdfc2"},{"sha":"0d002ac5d944f614f59ed5754b39b1f15d7799f9","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"tests: chown test temp dir to user's group\n\nSee the comment for why.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/0d002ac5d944f614f59ed5754b39b1f15d7799f9"},{"sha":"6d722ef846faaed4ef67e7bfa7b44dfe9ec23393","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"tests: set umask explicitly\n\nThe umask is typically 022, but in some environments it's not.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/6d722ef846faaed4ef67e7bfa7b44dfe9ec23393"},{"sha":"6e6221cd5466ab153fb9723e96fb5efcd25129da","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"tests: separate out code that initializes watchman files into a mixin\n\nSetting up the files beforehand is generally useful, but unfortunately it\ndoesn't catch issues with state directory creation or permissions. So we need\nto have a separate kind of instance, meant specifically to test state dirs.\nSeparating this code out into a mixin will allow us to also plug in a separate\nmixin later.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/6e6221cd5466ab153fb9723e96fb5efcd25129da"},{"sha":"ea24d93c243b6b69272201bf4d269267d0c4ec79","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"tests: log CLI output to another file\n\nThis makes what's output by the CLI vs what's output by the daemon a lot\nclearer, and it also avoids issues with some upcoming work where the CLI log\nneeds to be created before the daemon log.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/ea24d93c243b6b69272201bf4d269267d0c4ec79"},{"sha":"38f5e6ce5facb5bc7cbe63d7b270fc75b557fff2","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"tests: allow customizing the start timeout\n\nFor times that we know the watchman instance won't come up, waiting for a\nsecond seems pointless.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/38f5e6ce5facb5bc7cbe63d7b270fc75b557fff2"},{"sha":"8657b8df6239a6f59bb82837f0eeaed887da18a6","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"tests: add a way to create a watchman instance with a custom state dir\n\nThis is meant mainly to test statedir creation logic.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/8657b8df6239a6f59bb82837f0eeaed887da18a6"},{"sha":"dc8aceb3a2479e48f5c77889866479846348a8d9","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"tests: add test to check if user dir is too open\n\nThis check has existed for a while, but hasn't had a test yet.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/dc8aceb3a2479e48f5c77889866479846348a8d9"},{"sha":"02b0abc23f56b6d350a54fce554b61bb96b9393e","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"cfg: add a function to get permissions\n\nThis will accept an object that looks something like:\n\n```\n\"field\": {\n  \"group\": True,\n  \"others\": False,\n}\n```\n\nand use this to determine a permission bitstring. We're going to use this in an\nupcoming patch to allow setting permissions on the socket.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/02b0abc23f56b6d350a54fce554b61bb96b9393e"},{"sha":"e4ac1b9472ab33b21d26817f2dfd6f5f8a52d57b","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"statedir: set permissions based on sock_access config\n\nThis defaults to 0700, but we now allow custom sock_access configs.\n\nTests for this and other related code will be included in an upcoming patch.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/e4ac1b9472ab33b21d26817f2dfd6f5f8a52d57b"},{"sha":"56f7ccd0ad22c930849ac2c83cbd9c6d8d6b4a62","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"statedir: set up group according to config\n\nWe allow setting up a custom group on the socket and state directory as a\nconfig option.\n\nTests for this and other related code will be included in an upcoming patch.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/56f7ccd0ad22c930849ac2c83cbd9c6d8d6b4a62"},{"sha":"63000aed37643be385258aa0aac60748f5d11e2c","author":{"name":"Siddharth Agarwal","email":"88249354c305f8ee79450b6f8c3b279136b8d992@fb.com"},"message":"listener: set permissions on socket appropriately\n\nNote that not all POSIX operating systems respect permissions on sockets, but\nit's worth setting these up anyway.\n\nTests for this and related code are included in this diff.","distinct":true,"url":"https://api.github.com/repos/jmelfi/watchman/commits/63000aed37643be385258aa0aac60748f5d11e2c"}]}
{"actor":{"display_login":"jmelfi"}}