{"action":"created","issue":{"url":"https://api.github.com/repos/apollostack/graphql-tools/issues/121","repository_url":"https://api.github.com/repos/apollostack/graphql-tools","labels_url":"https://api.github.com/repos/apollostack/graphql-tools/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/apollostack/graphql-tools/issues/121/comments","events_url":"https://api.github.com/repos/apollostack/graphql-tools/issues/121/events","html_url":"https://github.com/apollostack/graphql-tools/pull/121","id":174923969,"number":121,"title":"Bugfix for resolving & mocking, when resolve is wrapped","user":{"login":"DxCx","id":1080411,"avatar_url":"https://avatars.githubusercontent.com/u/1080411?v=3","gravatar_id":"","url":"https://api.github.com/users/DxCx","html_url":"https://github.com/DxCx","followers_url":"https://api.github.com/users/DxCx/followers","following_url":"https://api.github.com/users/DxCx/following{/other_user}","gists_url":"https://api.github.com/users/DxCx/gists{/gist_id}","starred_url":"https://api.github.com/users/DxCx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DxCx/subscriptions","organizations_url":"https://api.github.com/users/DxCx/orgs","repos_url":"https://api.github.com/users/DxCx/repos","events_url":"https://api.github.com/users/DxCx/events{/privacy}","received_events_url":"https://api.github.com/users/DxCx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-04T00:08:56Z","updated_at":"2016-09-06T18:52:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apollostack/graphql-tools/pulls/121","html_url":"https://github.com/apollostack/graphql-tools/pull/121","diff_url":"https://github.com/apollostack/graphql-tools/pull/121.diff","patch_url":"https://github.com/apollostack/graphql-tools/pull/121.patch"},"body":"<!--\r\n  Thanks for filing a pull request on Apollo Client!\r\n\r\n  Please look at the following checklist to ensure that your PR\r\n  can be accepted quickly:\r\n-->\r\n\r\nI've noted a bug with @sebastienbarre 's new logic to merge resolvers & mocks ([#115](https://github.com/apollostack/graphql-tools/pull/115))\r\nBasiclly, if there is a connector or a logger (or any other wrapper, hidden as a resolve function),\r\nthe original resolve function value will be undefined (as it's not provided)\r\nand then an undefined will be returned, instead of the proper mocked value.\r\n\r\nTODO:\r\n\r\n- [x] Update CHANGELOG.md with your change (include reference to issue & this PR)\r\n- [x] Make sure all of the significant new logic is covered by tests\r\n- [x] Rebase your changes on master so that they can be merged easily\r\n- [x] Make sure all tests and linter rules pass\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apollostack/graphql-tools/issues/comments/245051887","html_url":"https://github.com/apollostack/graphql-tools/pull/121#issuecomment-245051887","issue_url":"https://api.github.com/repos/apollostack/graphql-tools/issues/121","id":245051887,"user":{"login":"helfer","id":6569980,"avatar_url":"https://avatars.githubusercontent.com/u/6569980?v=3","gravatar_id":"","url":"https://api.github.com/users/helfer","html_url":"https://github.com/helfer","followers_url":"https://api.github.com/users/helfer/followers","following_url":"https://api.github.com/users/helfer/following{/other_user}","gists_url":"https://api.github.com/users/helfer/gists{/gist_id}","starred_url":"https://api.github.com/users/helfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfer/subscriptions","organizations_url":"https://api.github.com/users/helfer/orgs","repos_url":"https://api.github.com/users/helfer/repos","events_url":"https://api.github.com/users/helfer/events{/privacy}","received_events_url":"https://api.github.com/users/helfer/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T18:52:44Z","updated_at":"2016-09-06T18:52:44Z","body":"I think this could potentially lead to confusion if someone defines a resolver which returns undefined by accident. It will be much harder to find the error in that case, because the return value will be replaced with mock data. I don't have a simple solution for that though, so let's just go with this for now."}}
{"actor":{"display_login":"helfer"}}