{"action":"created","comment":{"url":"https://api.github.com/repos/dry-rb/dry-web/pulls/comments/67320250","id":67320250,"diff_hunk":"@@ -0,0 +1,59 @@\n+require \"yaml\"\n+\n+module Dry\n+  module Web\n+    class Settings\n+      TypeError = Class.new(StandardError)\n+\n+      AnyType = Class.new do\n+        def self.[](value)\n+          value\n+        end\n+      end","path":"lib/dry/web/settings.rb","position":null,"original_position":12,"commit_id":"88ca5329b3f150963a91d71dfa27d20f375ad35d","original_commit_id":"60cf304cfd179a0ad4061bb35969ef4ac0698b45","user":{"login":"timriley","id":3134,"avatar_url":"https://avatars.githubusercontent.com/u/3134?v=3","gravatar_id":"","url":"https://api.github.com/users/timriley","html_url":"https://github.com/timriley","followers_url":"https://api.github.com/users/timriley/followers","following_url":"https://api.github.com/users/timriley/following{/other_user}","gists_url":"https://api.github.com/users/timriley/gists{/gist_id}","starred_url":"https://api.github.com/users/timriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timriley/subscriptions","organizations_url":"https://api.github.com/users/timriley/orgs","repos_url":"https://api.github.com/users/timriley/repos","events_url":"https://api.github.com/users/timriley/events{/privacy}","received_events_url":"https://api.github.com/users/timriley/received_events","type":"User","site_admin":false},"body":"I've replaced `AnyType` with `nil` and an `if` clause around type coercion. Less code :)","created_at":"2016-06-16T10:14:13Z","updated_at":"2016-06-16T10:14:13Z","html_url":"https://github.com/dry-rb/dry-web/pull/26#discussion_r67320250","pull_request_url":"https://api.github.com/repos/dry-rb/dry-web/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/dry-rb/dry-web/pulls/comments/67320250"},"html":{"href":"https://github.com/dry-rb/dry-web/pull/26#discussion_r67320250"},"pull_request":{"href":"https://api.github.com/repos/dry-rb/dry-web/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/dry-rb/dry-web/pulls/26","id":73908932,"html_url":"https://github.com/dry-rb/dry-web/pull/26","diff_url":"https://github.com/dry-rb/dry-web/pull/26.diff","patch_url":"https://github.com/dry-rb/dry-web/pull/26.patch","issue_url":"https://api.github.com/repos/dry-rb/dry-web/issues/26","number":26,"state":"open","locked":false,"title":"App settings on a top-level “Umbrella” container","user":{"login":"timriley","id":3134,"avatar_url":"https://avatars.githubusercontent.com/u/3134?v=3","gravatar_id":"","url":"https://api.github.com/users/timriley","html_url":"https://github.com/timriley","followers_url":"https://api.github.com/users/timriley/followers","following_url":"https://api.github.com/users/timriley/following{/other_user}","gists_url":"https://api.github.com/users/timriley/gists{/gist_id}","starred_url":"https://api.github.com/users/timriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timriley/subscriptions","organizations_url":"https://api.github.com/users/timriley/orgs","repos_url":"https://api.github.com/users/timriley/repos","events_url":"https://api.github.com/users/timriley/events{/privacy}","received_events_url":"https://api.github.com/users/timriley/received_events","type":"User","site_admin":false},"body":"This is a much simplified take on app settings compared to https://github.com/dry-rb/dry-web/pull/25, and I like it a lot more.\r\n\r\nIt automatically loads the settings onto the umbrella container, which I like, and it applies some sensible defaults while still allowing the developer to replace the whole settings object with something of their own choosing, if they want.\r\n\r\nIt also will nicely support integration with dry-types for people who want to make their settings stricter (or coerce stuff coming in from the ENV into richer Ruby types).\r\n\r\nThis is feeling like a decent path for us to include in the near term.\r\n\r\n\r\n\r\n","created_at":"2016-06-15T13:14:18Z","updated_at":"2016-06-16T10:14:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e026c8db7a4fe08a2946d55ff61328bd4b870535","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dry-rb/dry-web/pulls/26/commits","review_comments_url":"https://api.github.com/repos/dry-rb/dry-web/pulls/26/comments","review_comment_url":"https://api.github.com/repos/dry-rb/dry-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dry-rb/dry-web/issues/26/comments","statuses_url":"https://api.github.com/repos/dry-rb/dry-web/statuses/88ca5329b3f150963a91d71dfa27d20f375ad35d","head":{"label":"dry-rb:simpler-config","ref":"simpler-config","sha":"88ca5329b3f150963a91d71dfa27d20f375ad35d","user":{"login":"dry-rb","id":11280820,"avatar_url":"https://avatars.githubusercontent.com/u/11280820?v=3","gravatar_id":"","url":"https://api.github.com/users/dry-rb","html_url":"https://github.com/dry-rb","followers_url":"https://api.github.com/users/dry-rb/followers","following_url":"https://api.github.com/users/dry-rb/following{/other_user}","gists_url":"https://api.github.com/users/dry-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/dry-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dry-rb/subscriptions","organizations_url":"https://api.github.com/users/dry-rb/orgs","repos_url":"https://api.github.com/users/dry-rb/repos","events_url":"https://api.github.com/users/dry-rb/events{/privacy}","received_events_url":"https://api.github.com/users/dry-rb/received_events","type":"Organization","site_admin":false},"repo":{"id":29884722,"name":"dry-web","full_name":"dry-rb/dry-web","owner":{"login":"dry-rb","id":11280820,"avatar_url":"https://avatars.githubusercontent.com/u/11280820?v=3","gravatar_id":"","url":"https://api.github.com/users/dry-rb","html_url":"https://github.com/dry-rb","followers_url":"https://api.github.com/users/dry-rb/followers","following_url":"https://api.github.com/users/dry-rb/following{/other_user}","gists_url":"https://api.github.com/users/dry-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/dry-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dry-rb/subscriptions","organizations_url":"https://api.github.com/users/dry-rb/orgs","repos_url":"https://api.github.com/users/dry-rb/repos","events_url":"https://api.github.com/users/dry-rb/events{/privacy}","received_events_url":"https://api.github.com/users/dry-rb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dry-rb/dry-web","description":"Lightweight web application stack on top of Roda","fork":false,"url":"https://api.github.com/repos/dry-rb/dry-web","forks_url":"https://api.github.com/repos/dry-rb/dry-web/forks","keys_url":"https://api.github.com/repos/dry-rb/dry-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dry-rb/dry-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dry-rb/dry-web/teams","hooks_url":"https://api.github.com/repos/dry-rb/dry-web/hooks","issue_events_url":"https://api.github.com/repos/dry-rb/dry-web/issues/events{/number}","events_url":"https://api.github.com/repos/dry-rb/dry-web/events","assignees_url":"https://api.github.com/repos/dry-rb/dry-web/assignees{/user}","branches_url":"https://api.github.com/repos/dry-rb/dry-web/branches{/branch}","tags_url":"https://api.github.com/repos/dry-rb/dry-web/tags","blobs_url":"https://api.github.com/repos/dry-rb/dry-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dry-rb/dry-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dry-rb/dry-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dry-rb/dry-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dry-rb/dry-web/statuses/{sha}","languages_url":"https://api.github.com/repos/dry-rb/dry-web/languages","stargazers_url":"https://api.github.com/repos/dry-rb/dry-web/stargazers","contributors_url":"https://api.github.com/repos/dry-rb/dry-web/contributors","subscribers_url":"https://api.github.com/repos/dry-rb/dry-web/subscribers","subscription_url":"https://api.github.com/repos/dry-rb/dry-web/subscription","commits_url":"https://api.github.com/repos/dry-rb/dry-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dry-rb/dry-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dry-rb/dry-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dry-rb/dry-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dry-rb/dry-web/contents/{+path}","compare_url":"https://api.github.com/repos/dry-rb/dry-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dry-rb/dry-web/merges","archive_url":"https://api.github.com/repos/dry-rb/dry-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dry-rb/dry-web/downloads","issues_url":"https://api.github.com/repos/dry-rb/dry-web/issues{/number}","pulls_url":"https://api.github.com/repos/dry-rb/dry-web/pulls{/number}","milestones_url":"https://api.github.com/repos/dry-rb/dry-web/milestones{/number}","notifications_url":"https://api.github.com/repos/dry-rb/dry-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dry-rb/dry-web/labels{/name}","releases_url":"https://api.github.com/repos/dry-rb/dry-web/releases{/id}","deployments_url":"https://api.github.com/repos/dry-rb/dry-web/deployments","created_at":"2015-01-26T22:21:40Z","updated_at":"2016-06-11T11:05:54Z","pushed_at":"2016-06-16T10:10:13Z","git_url":"git://github.com/dry-rb/dry-web.git","ssh_url":"git@github.com:dry-rb/dry-web.git","clone_url":"https://github.com/dry-rb/dry-web.git","svn_url":"https://github.com/dry-rb/dry-web","homepage":"","size":191,"stargazers_count":122,"watchers_count":122,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":122,"default_branch":"master"}},"base":{"label":"dry-rb:master","ref":"master","sha":"9dba9c061c06ecd383e2aabbdbefcafb93a7d0e4","user":{"login":"dry-rb","id":11280820,"avatar_url":"https://avatars.githubusercontent.com/u/11280820?v=3","gravatar_id":"","url":"https://api.github.com/users/dry-rb","html_url":"https://github.com/dry-rb","followers_url":"https://api.github.com/users/dry-rb/followers","following_url":"https://api.github.com/users/dry-rb/following{/other_user}","gists_url":"https://api.github.com/users/dry-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/dry-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dry-rb/subscriptions","organizations_url":"https://api.github.com/users/dry-rb/orgs","repos_url":"https://api.github.com/users/dry-rb/repos","events_url":"https://api.github.com/users/dry-rb/events{/privacy}","received_events_url":"https://api.github.com/users/dry-rb/received_events","type":"Organization","site_admin":false},"repo":{"id":29884722,"name":"dry-web","full_name":"dry-rb/dry-web","owner":{"login":"dry-rb","id":11280820,"avatar_url":"https://avatars.githubusercontent.com/u/11280820?v=3","gravatar_id":"","url":"https://api.github.com/users/dry-rb","html_url":"https://github.com/dry-rb","followers_url":"https://api.github.com/users/dry-rb/followers","following_url":"https://api.github.com/users/dry-rb/following{/other_user}","gists_url":"https://api.github.com/users/dry-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/dry-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dry-rb/subscriptions","organizations_url":"https://api.github.com/users/dry-rb/orgs","repos_url":"https://api.github.com/users/dry-rb/repos","events_url":"https://api.github.com/users/dry-rb/events{/privacy}","received_events_url":"https://api.github.com/users/dry-rb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dry-rb/dry-web","description":"Lightweight web application stack on top of Roda","fork":false,"url":"https://api.github.com/repos/dry-rb/dry-web","forks_url":"https://api.github.com/repos/dry-rb/dry-web/forks","keys_url":"https://api.github.com/repos/dry-rb/dry-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dry-rb/dry-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dry-rb/dry-web/teams","hooks_url":"https://api.github.com/repos/dry-rb/dry-web/hooks","issue_events_url":"https://api.github.com/repos/dry-rb/dry-web/issues/events{/number}","events_url":"https://api.github.com/repos/dry-rb/dry-web/events","assignees_url":"https://api.github.com/repos/dry-rb/dry-web/assignees{/user}","branches_url":"https://api.github.com/repos/dry-rb/dry-web/branches{/branch}","tags_url":"https://api.github.com/repos/dry-rb/dry-web/tags","blobs_url":"https://api.github.com/repos/dry-rb/dry-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dry-rb/dry-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dry-rb/dry-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dry-rb/dry-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dry-rb/dry-web/statuses/{sha}","languages_url":"https://api.github.com/repos/dry-rb/dry-web/languages","stargazers_url":"https://api.github.com/repos/dry-rb/dry-web/stargazers","contributors_url":"https://api.github.com/repos/dry-rb/dry-web/contributors","subscribers_url":"https://api.github.com/repos/dry-rb/dry-web/subscribers","subscription_url":"https://api.github.com/repos/dry-rb/dry-web/subscription","commits_url":"https://api.github.com/repos/dry-rb/dry-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dry-rb/dry-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dry-rb/dry-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dry-rb/dry-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dry-rb/dry-web/contents/{+path}","compare_url":"https://api.github.com/repos/dry-rb/dry-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dry-rb/dry-web/merges","archive_url":"https://api.github.com/repos/dry-rb/dry-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dry-rb/dry-web/downloads","issues_url":"https://api.github.com/repos/dry-rb/dry-web/issues{/number}","pulls_url":"https://api.github.com/repos/dry-rb/dry-web/pulls{/number}","milestones_url":"https://api.github.com/repos/dry-rb/dry-web/milestones{/number}","notifications_url":"https://api.github.com/repos/dry-rb/dry-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dry-rb/dry-web/labels{/name}","releases_url":"https://api.github.com/repos/dry-rb/dry-web/releases{/id}","deployments_url":"https://api.github.com/repos/dry-rb/dry-web/deployments","created_at":"2015-01-26T22:21:40Z","updated_at":"2016-06-11T11:05:54Z","pushed_at":"2016-06-16T10:10:13Z","git_url":"git://github.com/dry-rb/dry-web.git","ssh_url":"git@github.com:dry-rb/dry-web.git","clone_url":"https://github.com/dry-rb/dry-web.git","svn_url":"https://github.com/dry-rb/dry-web","homepage":"","size":191,"stargazers_count":122,"watchers_count":122,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dry-rb/dry-web/pulls/26"},"html":{"href":"https://github.com/dry-rb/dry-web/pull/26"},"issue":{"href":"https://api.github.com/repos/dry-rb/dry-web/issues/26"},"comments":{"href":"https://api.github.com/repos/dry-rb/dry-web/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/dry-rb/dry-web/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/dry-rb/dry-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dry-rb/dry-web/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/dry-rb/dry-web/statuses/88ca5329b3f150963a91d71dfa27d20f375ad35d"}}}}
{"actor":{"display_login":"timriley"}}