{"action":"closed","number":836,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/836","id":70975949,"html_url":"https://github.com/opencontainers/runc/pull/836","diff_url":"https://github.com/opencontainers/runc/pull/836.diff","patch_url":"https://github.com/opencontainers/runc/pull/836.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/836","number":836,"state":"closed","locked":false,"title":"*: correctly chown() consoles","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"body":"In user namespaces, we need to make sure we don't chown() the console to\r\nunmapped users. This means we need to get both the UID and GID of the\r\nroot user in the container when changing the owner.\r\n\r\nThis is part of the cleanup I did for rootless containers, but benefits the\r\nproject as a whole so we might as well apply it now. Obviously we still\r\nneed to fix the user namespace interaction (#814).\r\n\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>\r\n\r\n/cc @crosbymichael ","created_at":"2016-05-22T12:35:10Z","updated_at":"2016-05-23T02:25:45Z","closed_at":"2016-05-23T02:25:45Z","merged_at":"2016-05-23T02:25:45Z","merge_commit_sha":"d2d09b9bcd0573c58d7cd94e57bd7555af0c2072","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/836/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/836/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/836/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/1a913c7b896387b6341fef1bedac8b4d8cdd290e","head":{"label":"cyphar:console-chown","ref":"console-chown","sha":"1a913c7b896387b6341fef1bedac8b4d8cdd290e","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"repo":{"id":38178794,"name":"runc","full_name":"cyphar/runc","owner":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyphar/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/cyphar/runc","forks_url":"https://api.github.com/repos/cyphar/runc/forks","keys_url":"https://api.github.com/repos/cyphar/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyphar/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyphar/runc/teams","hooks_url":"https://api.github.com/repos/cyphar/runc/hooks","issue_events_url":"https://api.github.com/repos/cyphar/runc/issues/events{/number}","events_url":"https://api.github.com/repos/cyphar/runc/events","assignees_url":"https://api.github.com/repos/cyphar/runc/assignees{/user}","branches_url":"https://api.github.com/repos/cyphar/runc/branches{/branch}","tags_url":"https://api.github.com/repos/cyphar/runc/tags","blobs_url":"https://api.github.com/repos/cyphar/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyphar/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyphar/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyphar/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyphar/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/cyphar/runc/languages","stargazers_url":"https://api.github.com/repos/cyphar/runc/stargazers","contributors_url":"https://api.github.com/repos/cyphar/runc/contributors","subscribers_url":"https://api.github.com/repos/cyphar/runc/subscribers","subscription_url":"https://api.github.com/repos/cyphar/runc/subscription","commits_url":"https://api.github.com/repos/cyphar/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyphar/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyphar/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyphar/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyphar/runc/contents/{+path}","compare_url":"https://api.github.com/repos/cyphar/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyphar/runc/merges","archive_url":"https://api.github.com/repos/cyphar/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyphar/runc/downloads","issues_url":"https://api.github.com/repos/cyphar/runc/issues{/number}","pulls_url":"https://api.github.com/repos/cyphar/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/cyphar/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/cyphar/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyphar/runc/labels{/name}","releases_url":"https://api.github.com/repos/cyphar/runc/releases{/id}","deployments_url":"https://api.github.com/repos/cyphar/runc/deployments","created_at":"2015-06-27T23:14:24Z","updated_at":"2016-05-07T13:52:02Z","pushed_at":"2016-05-23T02:17:27Z","git_url":"git://github.com/cyphar/runc.git","ssh_url":"git@github.com:cyphar/runc.git","clone_url":"https://github.com/cyphar/runc.git","svn_url":"https://github.com/cyphar/runc","homepage":"","size":3235,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"60eb77dd3ca5d38d8abb312a168a14e0813d44f7","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"runc container cli tools","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runc/deployments","created_at":"2015-06-05T23:30:45Z","updated_at":"2016-05-22T16:06:52Z","pushed_at":"2016-05-23T02:25:45Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"https://www.opencontainers.org/","size":5489,"stargazers_count":2787,"watchers_count":2787,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":360,"mirror_url":null,"open_issues_count":70,"forks":360,"open_issues":70,"watchers":2787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/836"},"html":{"href":"https://github.com/opencontainers/runc/pull/836"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/836"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/836/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/836/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/836/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/1a913c7b896387b6341fef1bedac8b4d8cdd290e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":23,"deletions":17,"changed_files":6}}
{"actor":{"display_login":"hqhq"}}