{"action":"created","issue":{"url":"https://api.github.com/repos/WordPoints/wordpoints/issues/413","repository_url":"https://api.github.com/repos/WordPoints/wordpoints","labels_url":"https://api.github.com/repos/WordPoints/wordpoints/issues/413/labels{/name}","comments_url":"https://api.github.com/repos/WordPoints/wordpoints/issues/413/comments","events_url":"https://api.github.com/repos/WordPoints/wordpoints/issues/413/events","html_url":"https://github.com/WordPoints/wordpoints/issues/413","id":164680540,"number":413,"title":"Is hook mode needed to uniquely identify reactions?","user":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/WordPoints/wordpoints/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/WordPoints/wordpoints/milestones/23","html_url":"https://github.com/WordPoints/wordpoints/milestones/2.1.0","labels_url":"https://api.github.com/repos/WordPoints/wordpoints/milestones/23/labels","id":1152983,"number":23,"title":"2.1.0","description":"","creator":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":42,"state":"open","created_at":"2015-06-06T21:12:15Z","updated_at":"2016-07-09T18:59:02Z","due_on":"2016-07-30T04:00:00Z","closed_at":null},"comments":4,"created_at":"2016-07-09T18:59:02Z","updated_at":"2016-07-09T19:11:36Z","closed_at":null,"body":"After #410, we pass the slug of the hook mode that a reaction store relates to to the store object when it is constructed. We didn't add a way to retrieve the mode from the reaction store yet, because we weren't sure whether such a method should be part of the reaction store interface.\r\n\r\nAs I was working on this I realized that what we were doing in essence is making it so that a reaction store has to be identified based on two items: its slug and the hook mode it is associated with. It needs both of these to be able to prevent conflicts in how reaction stores with the same slug but for different modes are stored in the database. So really we weren't *doing* this just now, it is already this way, we just weren't doing it right before.\r\n\r\nAnyway, this made me wonder whether we should also then be including the mode in the reaction GUID. Otherwise we can't uniquely identify the store to which the reaction belongs, which means we don't really have a GUID. But I'm not 100% sure about this. We need to explore a little more how the interplay between mode and context works, so that we have a good grasp on why this is (or isn't) needed. We already make the reaction store context a part of the reaction GUID, so why isn't that enough?"},"comment":{"url":"https://api.github.com/repos/WordPoints/wordpoints/issues/comments/231550657","html_url":"https://github.com/WordPoints/wordpoints/issues/413#issuecomment-231550657","issue_url":"https://api.github.com/repos/WordPoints/wordpoints/issues/413","id":231550657,"user":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"created_at":"2016-07-09T19:11:36Z","updated_at":"2016-07-09T19:11:36Z","body":"The reason that this is so hard to get clear is that we don't really use multiple modes in a single context right now (`standard` -> `site`, `network` -> `network`). But I'm coming to grips with it."}}
{"actor":{"display_login":"JDGrimes"}}