{"action":"created","issue":{"url":"https://api.github.com/repos/treasure-data/digdag/issues/181","repository_url":"https://api.github.com/repos/treasure-data/digdag","labels_url":"https://api.github.com/repos/treasure-data/digdag/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/treasure-data/digdag/issues/181/comments","events_url":"https://api.github.com/repos/treasure-data/digdag/issues/181/events","html_url":"https://github.com/treasure-data/digdag/pull/181","id":167939307,"number":181,"title":"First schedule time is expected to be calculated using next run time","user":{"login":"frsyuki","id":40720,"avatar_url":"https://avatars.githubusercontent.com/u/40720?v=3","gravatar_id":"","url":"https://api.github.com/users/frsyuki","html_url":"https://github.com/frsyuki","followers_url":"https://api.github.com/users/frsyuki/followers","following_url":"https://api.github.com/users/frsyuki/following{/other_user}","gists_url":"https://api.github.com/users/frsyuki/gists{/gist_id}","starred_url":"https://api.github.com/users/frsyuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frsyuki/subscriptions","organizations_url":"https://api.github.com/users/frsyuki/orgs","repos_url":"https://api.github.com/users/frsyuki/repos","events_url":"https://api.github.com/users/frsyuki/events{/privacy}","received_events_url":"https://api.github.com/users/frsyuki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-27T19:45:26Z","updated_at":"2016-07-29T04:38:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/treasure-data/digdag/pulls/181","html_url":"https://github.com/treasure-data/digdag/pull/181","diff_url":"https://github.com/treasure-data/digdag/pull/181.diff","patch_url":"https://github.com/treasure-data/digdag/pull/181.patch"},"body":"First schedule time was calculated using next session time. But it's\r\nexpected to be calculated using next run time instead as an issue filed\r\nat [#149].\r\n\r\nFor example, a workflow has `daily>: 10:00:00` schedule and current time is at 8am. Current behavior is that first run time becomes tomorrow 10:00:00. This is because today's \"schedule time\" (that is 00:00:00) is already passed.\r\nThis PR changes it to be today 10:00:00 because today's \"run time\" (that is 10:00:00) is not passed yet.\r\n\r\nThis PR also adds `--schedule-from` option to `digdag push` command so that test cases can be independent from the environment's current time.\r\n"},"comment":{"url":"https://api.github.com/repos/treasure-data/digdag/issues/comments/236092810","html_url":"https://github.com/treasure-data/digdag/pull/181#issuecomment-236092810","issue_url":"https://api.github.com/repos/treasure-data/digdag/issues/181","id":236092810,"user":{"login":"danielnorberg","id":393289,"avatar_url":"https://avatars.githubusercontent.com/u/393289?v=3","gravatar_id":"","url":"https://api.github.com/users/danielnorberg","html_url":"https://github.com/danielnorberg","followers_url":"https://api.github.com/users/danielnorberg/followers","following_url":"https://api.github.com/users/danielnorberg/following{/other_user}","gists_url":"https://api.github.com/users/danielnorberg/gists{/gist_id}","starred_url":"https://api.github.com/users/danielnorberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielnorberg/subscriptions","organizations_url":"https://api.github.com/users/danielnorberg/orgs","repos_url":"https://api.github.com/users/danielnorberg/repos","events_url":"https://api.github.com/users/danielnorberg/events{/privacy}","received_events_url":"https://api.github.com/users/danielnorberg/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T04:38:06Z","updated_at":"2016-07-29T04:38:06Z","body":"Yes, I think the `time` and `runTime` fields of `ScheduleTime` is confusing. Would be nice to have some comments there to explain what they mean.\r\n\r\nIt would also be nice to have some comments explaining how `DailySchedulerFactory` is using `CronScheduler`. I.e., why it is using the pattern `0 0 * * *` and what the purpose of the `delaySeconds` argument to the `CronScheduler` constructor is.\r\n\r\n"}}
{"actor":{"display_login":"danielnorberg"}}