{"action":"closed","number":102,"pull_request":{"url":"https://api.github.com/repos/PetaVision/OpenPV/pulls/102","id":81199670,"html_url":"https://github.com/PetaVision/OpenPV/pull/102","diff_url":"https://github.com/PetaVision/OpenPV/pull/102.diff","patch_url":"https://github.com/PetaVision/OpenPV/pull/102.patch","issue_url":"https://api.github.com/repos/PetaVision/OpenPV/issues/102","number":102,"state":"closed","locked":false,"title":"filenamesContainLayerNames and filenamesContainConnectionNames are obsolete","user":{"login":"peteschultz","id":12836019,"avatar_url":"https://avatars.githubusercontent.com/u/12836019?v=3","gravatar_id":"","url":"https://api.github.com/users/peteschultz","html_url":"https://github.com/peteschultz","followers_url":"https://api.github.com/users/peteschultz/followers","following_url":"https://api.github.com/users/peteschultz/following{/other_user}","gists_url":"https://api.github.com/users/peteschultz/gists{/gist_id}","starred_url":"https://api.github.com/users/peteschultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peteschultz/subscriptions","organizations_url":"https://api.github.com/users/peteschultz/orgs","repos_url":"https://api.github.com/users/peteschultz/repos","events_url":"https://api.github.com/users/peteschultz/events{/privacy}","received_events_url":"https://api.github.com/users/peteschultz/received_events","type":"User","site_admin":false},"body":"Currently, there are three options for the filenames generated by outputState, governed by the value of the HyPerCol parameters filenameContainsLayerNames and filenameContainsConnectionNames:\r\n\r\n0: a5.pvp or w5.pvp\r\n1: a5_LayerName.pvp or w5_ConnectionName.pvp\r\n2: LayerName.pvp or ConnectionName.pvp\r\n\r\nThis pull request eliminates the first two choices, so that outputState pvp files have the format LayerName.pvp or ConnectionName.pvp.  Setting the newly obsolete parameters to 2 generates a warning but the run will continue.  Setting one of them to a value other than 2 generates an error.\r\n\r\nThe filename format was the only place that layerId and connId were being used, so these data members have been removed from HyPerLayer and BaseConnection.\r\n\r\nRationale:\r\n- Including the index in the filename means that the filename for an object changes if new layers or connections are added earlier in the hierarchy.\r\n- In lua-generated params files, the order of layers and connections is not always the same, which can change the filename even if the hierarchy does not change.\r\n- The HyPerCol no longer has to manage the number of layers and connections as they are added.\r\n- The layers and connections have fewer occasions where they  call HyPerCol methods.","created_at":"2016-08-13T00:10:42Z","updated_at":"2016-08-15T16:30:07Z","closed_at":"2016-08-15T16:30:07Z","merged_at":"2016-08-15T16:30:07Z","merge_commit_sha":"7aa95887fc490c204e45746eedacb03592f62fb7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PetaVision/OpenPV/pulls/102/commits","review_comments_url":"https://api.github.com/repos/PetaVision/OpenPV/pulls/102/comments","review_comment_url":"https://api.github.com/repos/PetaVision/OpenPV/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PetaVision/OpenPV/issues/102/comments","statuses_url":"https://api.github.com/repos/PetaVision/OpenPV/statuses/e6c1fd321fce999f14c1cb3f38743803f5036838","head":{"label":"PetaVision:output-pvp-filenames","ref":"output-pvp-filenames","sha":"e6c1fd321fce999f14c1cb3f38743803f5036838","user":{"login":"PetaVision","id":12901999,"avatar_url":"https://avatars.githubusercontent.com/u/12901999?v=3","gravatar_id":"","url":"https://api.github.com/users/PetaVision","html_url":"https://github.com/PetaVision","followers_url":"https://api.github.com/users/PetaVision/followers","following_url":"https://api.github.com/users/PetaVision/following{/other_user}","gists_url":"https://api.github.com/users/PetaVision/gists{/gist_id}","starred_url":"https://api.github.com/users/PetaVision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetaVision/subscriptions","organizations_url":"https://api.github.com/users/PetaVision/orgs","repos_url":"https://api.github.com/users/PetaVision/repos","events_url":"https://api.github.com/users/PetaVision/events{/privacy}","received_events_url":"https://api.github.com/users/PetaVision/received_events","type":"Organization","site_admin":false},"repo":{"id":39472309,"name":"OpenPV","full_name":"PetaVision/OpenPV","owner":{"login":"PetaVision","id":12901999,"avatar_url":"https://avatars.githubusercontent.com/u/12901999?v=3","gravatar_id":"","url":"https://api.github.com/users/PetaVision","html_url":"https://github.com/PetaVision","followers_url":"https://api.github.com/users/PetaVision/followers","following_url":"https://api.github.com/users/PetaVision/following{/other_user}","gists_url":"https://api.github.com/users/PetaVision/gists{/gist_id}","starred_url":"https://api.github.com/users/PetaVision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetaVision/subscriptions","organizations_url":"https://api.github.com/users/PetaVision/orgs","repos_url":"https://api.github.com/users/PetaVision/repos","events_url":"https://api.github.com/users/PetaVision/events{/privacy}","received_events_url":"https://api.github.com/users/PetaVision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PetaVision/OpenPV","description":"PetaVision is a C++ library for designing and deploying large-scale neurally-inspired computational models.","fork":false,"url":"https://api.github.com/repos/PetaVision/OpenPV","forks_url":"https://api.github.com/repos/PetaVision/OpenPV/forks","keys_url":"https://api.github.com/repos/PetaVision/OpenPV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PetaVision/OpenPV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PetaVision/OpenPV/teams","hooks_url":"https://api.github.com/repos/PetaVision/OpenPV/hooks","issue_events_url":"https://api.github.com/repos/PetaVision/OpenPV/issues/events{/number}","events_url":"https://api.github.com/repos/PetaVision/OpenPV/events","assignees_url":"https://api.github.com/repos/PetaVision/OpenPV/assignees{/user}","branches_url":"https://api.github.com/repos/PetaVision/OpenPV/branches{/branch}","tags_url":"https://api.github.com/repos/PetaVision/OpenPV/tags","blobs_url":"https://api.github.com/repos/PetaVision/OpenPV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PetaVision/OpenPV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PetaVision/OpenPV/git/refs{/sha}","trees_url":"https://api.github.com/repos/PetaVision/OpenPV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PetaVision/OpenPV/statuses/{sha}","languages_url":"https://api.github.com/repos/PetaVision/OpenPV/languages","stargazers_url":"https://api.github.com/repos/PetaVision/OpenPV/stargazers","contributors_url":"https://api.github.com/repos/PetaVision/OpenPV/contributors","subscribers_url":"https://api.github.com/repos/PetaVision/OpenPV/subscribers","subscription_url":"https://api.github.com/repos/PetaVision/OpenPV/subscription","commits_url":"https://api.github.com/repos/PetaVision/OpenPV/commits{/sha}","git_commits_url":"https://api.github.com/repos/PetaVision/OpenPV/git/commits{/sha}","comments_url":"https://api.github.com/repos/PetaVision/OpenPV/comments{/number}","issue_comment_url":"https://api.github.com/repos/PetaVision/OpenPV/issues/comments{/number}","contents_url":"https://api.github.com/repos/PetaVision/OpenPV/contents/{+path}","compare_url":"https://api.github.com/repos/PetaVision/OpenPV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PetaVision/OpenPV/merges","archive_url":"https://api.github.com/repos/PetaVision/OpenPV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PetaVision/OpenPV/downloads","issues_url":"https://api.github.com/repos/PetaVision/OpenPV/issues{/number}","pulls_url":"https://api.github.com/repos/PetaVision/OpenPV/pulls{/number}","milestones_url":"https://api.github.com/repos/PetaVision/OpenPV/milestones{/number}","notifications_url":"https://api.github.com/repos/PetaVision/OpenPV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PetaVision/OpenPV/labels{/name}","releases_url":"https://api.github.com/repos/PetaVision/OpenPV/releases{/id}","deployments_url":"https://api.github.com/repos/PetaVision/OpenPV/deployments","created_at":"2015-07-21T22:08:31Z","updated_at":"2016-06-24T23:18:11Z","pushed_at":"2016-08-15T16:30:07Z","git_url":"git://github.com/PetaVision/OpenPV.git","ssh_url":"git@github.com:PetaVision/OpenPV.git","clone_url":"https://github.com/PetaVision/OpenPV.git","svn_url":"https://github.com/PetaVision/OpenPV","homepage":"http://petavision.github.io","size":492297,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":17,"default_branch":"master"}},"base":{"label":"PetaVision:develop","ref":"develop","sha":"09983dd5a608dd5b6b1e476f1f8ea933dd559632","user":{"login":"PetaVision","id":12901999,"avatar_url":"https://avatars.githubusercontent.com/u/12901999?v=3","gravatar_id":"","url":"https://api.github.com/users/PetaVision","html_url":"https://github.com/PetaVision","followers_url":"https://api.github.com/users/PetaVision/followers","following_url":"https://api.github.com/users/PetaVision/following{/other_user}","gists_url":"https://api.github.com/users/PetaVision/gists{/gist_id}","starred_url":"https://api.github.com/users/PetaVision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetaVision/subscriptions","organizations_url":"https://api.github.com/users/PetaVision/orgs","repos_url":"https://api.github.com/users/PetaVision/repos","events_url":"https://api.github.com/users/PetaVision/events{/privacy}","received_events_url":"https://api.github.com/users/PetaVision/received_events","type":"Organization","site_admin":false},"repo":{"id":39472309,"name":"OpenPV","full_name":"PetaVision/OpenPV","owner":{"login":"PetaVision","id":12901999,"avatar_url":"https://avatars.githubusercontent.com/u/12901999?v=3","gravatar_id":"","url":"https://api.github.com/users/PetaVision","html_url":"https://github.com/PetaVision","followers_url":"https://api.github.com/users/PetaVision/followers","following_url":"https://api.github.com/users/PetaVision/following{/other_user}","gists_url":"https://api.github.com/users/PetaVision/gists{/gist_id}","starred_url":"https://api.github.com/users/PetaVision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetaVision/subscriptions","organizations_url":"https://api.github.com/users/PetaVision/orgs","repos_url":"https://api.github.com/users/PetaVision/repos","events_url":"https://api.github.com/users/PetaVision/events{/privacy}","received_events_url":"https://api.github.com/users/PetaVision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PetaVision/OpenPV","description":"PetaVision is a C++ library for designing and deploying large-scale neurally-inspired computational models.","fork":false,"url":"https://api.github.com/repos/PetaVision/OpenPV","forks_url":"https://api.github.com/repos/PetaVision/OpenPV/forks","keys_url":"https://api.github.com/repos/PetaVision/OpenPV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PetaVision/OpenPV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PetaVision/OpenPV/teams","hooks_url":"https://api.github.com/repos/PetaVision/OpenPV/hooks","issue_events_url":"https://api.github.com/repos/PetaVision/OpenPV/issues/events{/number}","events_url":"https://api.github.com/repos/PetaVision/OpenPV/events","assignees_url":"https://api.github.com/repos/PetaVision/OpenPV/assignees{/user}","branches_url":"https://api.github.com/repos/PetaVision/OpenPV/branches{/branch}","tags_url":"https://api.github.com/repos/PetaVision/OpenPV/tags","blobs_url":"https://api.github.com/repos/PetaVision/OpenPV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PetaVision/OpenPV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PetaVision/OpenPV/git/refs{/sha}","trees_url":"https://api.github.com/repos/PetaVision/OpenPV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PetaVision/OpenPV/statuses/{sha}","languages_url":"https://api.github.com/repos/PetaVision/OpenPV/languages","stargazers_url":"https://api.github.com/repos/PetaVision/OpenPV/stargazers","contributors_url":"https://api.github.com/repos/PetaVision/OpenPV/contributors","subscribers_url":"https://api.github.com/repos/PetaVision/OpenPV/subscribers","subscription_url":"https://api.github.com/repos/PetaVision/OpenPV/subscription","commits_url":"https://api.github.com/repos/PetaVision/OpenPV/commits{/sha}","git_commits_url":"https://api.github.com/repos/PetaVision/OpenPV/git/commits{/sha}","comments_url":"https://api.github.com/repos/PetaVision/OpenPV/comments{/number}","issue_comment_url":"https://api.github.com/repos/PetaVision/OpenPV/issues/comments{/number}","contents_url":"https://api.github.com/repos/PetaVision/OpenPV/contents/{+path}","compare_url":"https://api.github.com/repos/PetaVision/OpenPV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PetaVision/OpenPV/merges","archive_url":"https://api.github.com/repos/PetaVision/OpenPV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PetaVision/OpenPV/downloads","issues_url":"https://api.github.com/repos/PetaVision/OpenPV/issues{/number}","pulls_url":"https://api.github.com/repos/PetaVision/OpenPV/pulls{/number}","milestones_url":"https://api.github.com/repos/PetaVision/OpenPV/milestones{/number}","notifications_url":"https://api.github.com/repos/PetaVision/OpenPV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PetaVision/OpenPV/labels{/name}","releases_url":"https://api.github.com/repos/PetaVision/OpenPV/releases{/id}","deployments_url":"https://api.github.com/repos/PetaVision/OpenPV/deployments","created_at":"2015-07-21T22:08:31Z","updated_at":"2016-06-24T23:18:11Z","pushed_at":"2016-08-15T16:30:07Z","git_url":"git://github.com/PetaVision/OpenPV.git","ssh_url":"git@github.com:PetaVision/OpenPV.git","clone_url":"https://github.com/PetaVision/OpenPV.git","svn_url":"https://github.com/PetaVision/OpenPV","homepage":"http://petavision.github.io","size":492297,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PetaVision/OpenPV/pulls/102"},"html":{"href":"https://github.com/PetaVision/OpenPV/pull/102"},"issue":{"href":"https://api.github.com/repos/PetaVision/OpenPV/issues/102"},"comments":{"href":"https://api.github.com/repos/PetaVision/OpenPV/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/PetaVision/OpenPV/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/PetaVision/OpenPV/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PetaVision/OpenPV/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/PetaVision/OpenPV/statuses/e6c1fd321fce999f14c1cb3f38743803f5036838"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"peteschultz","id":12836019,"avatar_url":"https://avatars.githubusercontent.com/u/12836019?v=3","gravatar_id":"","url":"https://api.github.com/users/peteschultz","html_url":"https://github.com/peteschultz","followers_url":"https://api.github.com/users/peteschultz/followers","following_url":"https://api.github.com/users/peteschultz/following{/other_user}","gists_url":"https://api.github.com/users/peteschultz/gists{/gist_id}","starred_url":"https://api.github.com/users/peteschultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peteschultz/subscriptions","organizations_url":"https://api.github.com/users/peteschultz/orgs","repos_url":"https://api.github.com/users/peteschultz/repos","events_url":"https://api.github.com/users/peteschultz/events{/privacy}","received_events_url":"https://api.github.com/users/peteschultz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":347,"changed_files":142}}
{"actor":{"display_login":"peteschultz"}}