{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11156","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11156/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11156/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11156/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11156","id":176056243,"number":11156,"title":"[WIP] Retirement - use datetime instead of date - migration","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/sql%20migration","name":"sql migration","color":"6A92BC"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-09T16:51:07Z","updated_at":"2016-09-12T16:07:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11156","html_url":"https://github.com/ManageIQ/manageiq/pull/11156","diff_url":"https://github.com/ManageIQ/manageiq/pull/11156.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11156.patch"},"body":"This was originally a part of https://github.com/ManageIQ/manageiq/pull/7471, splitting off to get merged sooner..\r\n\r\nThis changes the `retires_on` and `retirement_last_warn` fields from `:date` to `:datetime` - the idea is that we will change the UI to let the user pick a specific point in time (including timezone) for the machine to retire, instead of a rather vague \"that day +- 23.5 hours\" (yay timezones!).\r\n\r\n@gmcculloug I know I still need to fix the specs, but can you please look at it if such a change makes sense?"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/246398430","html_url":"https://github.com/ManageIQ/manageiq/pull/11156#issuecomment-246398430","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11156","id":246398430,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T16:07:01Z","updated_at":"2016-09-12T16:07:01Z","body":"<rubocop />Checked commits https://github.com/himdel/manageiq/compare/e031741a1babc901d69a5adaabb555050e69ca89~...e81bea9c097d338e4597b3d4bd082000bea64a35 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n3 files checked, 23 offenses detected\n\n**spec/lib/miq_expression_spec.rb**\n- [ ] :grey_exclamation: - [Line 1003](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1003), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [168/120]\n- [ ] :grey_exclamation: - [Line 1008](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1008), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [168/120]\n- [ ] :grey_exclamation: - [Line 1023](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1023), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [224/120]\n- [ ] :grey_exclamation: - [Line 1028](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1028), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [224/120]\n- [ ] :grey_exclamation: - [Line 1050](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1050), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [157/120]\n- [ ] :grey_exclamation: - [Line 1056](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1056), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [157/120]\n- [ ] :grey_exclamation: - [Line 1062](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1062), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [213/120]\n- [ ] :grey_exclamation: - [Line 1068](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1068), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [213/120]\n- [ ] :grey_exclamation: - [Line 1075](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1075), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [164/120]\n- [ ] :grey_exclamation: - [Line 1085](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1085), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [164/120]\n- [ ] :grey_exclamation: - [Line 1100](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1100), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [220/120]\n- [ ] :grey_exclamation: - [Line 1120](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1120), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [220/120]\n- [ ] :grey_exclamation: - [Line 1125](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1125), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [220/120]\n- [ ] :grey_exclamation: - [Line 1130](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1130), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [220/120]\n- [ ] :grey_exclamation: - [Line 1149](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1149), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [224/120]\n- [ ] :grey_exclamation: - [Line 1169](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1169), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [224/120]\n- [ ] :grey_exclamation: - [Line 1174](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1174), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [224/120]\n- [ ] :grey_exclamation: - [Line 1179](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L1179), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [224/120]\n- [ ] :grey_exclamation: - [Line 954](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L954), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [164/120]\n- [ ] :grey_exclamation: - [Line 959](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L959), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [164/120]\n- [ ] :grey_exclamation: - [Line 969](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L969), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [220/120]\n- [ ] :grey_exclamation: - [Line 979](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L979), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [220/120]\n- [ ] :grey_exclamation: - [Line 984](https://github.com/himdel/manageiq/blob/e81bea9c097d338e4597b3d4bd082000bea64a35/spec/lib/miq_expression_spec.rb#L984), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [220/120]\n"}}
{"actor":{"display_login":"miq-bot"}}