{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/75475032","id":75475032,"diff_hunk":"@@ -323,16 +340,24 @@ def test_issue_10198():\n         -1 + 1/abs(1/x - 1) < 0) == Or(\n         And(-oo < x, x < 0), And(S(0) < x, x < S(1)/2)\n         )\n-    raises(NotImplementedError, lambda: reduce_inequalities(abs(1/sqrt(x)) - 1, x))\n+    assert reduce_inequalities(abs(1/sqrt(x)) - 1, x) == Eq(x, 1)\n     assert reduce_abs_inequality(-3 + 1/abs(1 - 1/x), '<', x) == \\\n         Or(And(-oo < x, x < 0),\n         And(S(0) < x, x < S(3)/4), And(S(3)/2 < x, x < oo))\n     raises(ValueError,lambda: reduce_abs_inequality(-3 + 1/abs(\n         1 - 1/sqrt(x)), '<', x))\n \n+\n def test_issue_10047():\n-    assert solve(sin(x) < 2) == And(-oo < x, x < oo)\n+    assert solve(sin(x) < 2) == And(S(0) <= x, x < 2*pi)","path":"sympy/solvers/tests/test_inequalities.py","position":83,"original_position":83,"commit_id":"f54e15c756a1b1dcc9518ecfe7e2b4b5c2cca5c2","original_commit_id":"bbd8b66d7b6370cc05fe857bd642926639facaf6","user":{"login":"kshitij10496","id":12427142,"avatar_url":"https://avatars.githubusercontent.com/u/12427142?v=3","gravatar_id":"","url":"https://api.github.com/users/kshitij10496","html_url":"https://github.com/kshitij10496","followers_url":"https://api.github.com/users/kshitij10496/followers","following_url":"https://api.github.com/users/kshitij10496/following{/other_user}","gists_url":"https://api.github.com/users/kshitij10496/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij10496/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij10496/subscriptions","organizations_url":"https://api.github.com/users/kshitij10496/orgs","repos_url":"https://api.github.com/users/kshitij10496/repos","events_url":"https://api.github.com/users/kshitij10496/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij10496/received_events","type":"User","site_admin":false},"body":"> My issue is that this solution is wrong, unless you explicitly specify that the domain is [0, 2*pi).\r\n\r\nYes. I agree with you that should not be the solution unless the user specifies the domain to be\r\n`[0, 2*pi)`. \r\nI think it will be better if we do this an XFAIL for now.\r\nWith the implementation of `BigUnion`, we would be able to un-XFAIL it later.\r\n\r\nI have, however, documented this behaviour [here](https://github.com/sympy/sympy/pull/11458/files#diff-8c6b1223d1a80f79ca2509e14ebae02eR408). \r\nShouldn't this suffice for now ?","created_at":"2016-08-19T12:48:42Z","updated_at":"2016-08-19T12:48:43Z","html_url":"https://github.com/sympy/sympy/pull/11458#discussion_r75475032","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/11458","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/75475032"},"html":{"href":"https://github.com/sympy/sympy/pull/11458#discussion_r75475032"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11458"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/11458","id":79559116,"html_url":"https://github.com/sympy/sympy/pull/11458","diff_url":"https://github.com/sympy/sympy/pull/11458.diff","patch_url":"https://github.com/sympy/sympy/pull/11458.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/11458","number":11458,"state":"open","locked":false,"title":"Replacing solve with solveset for solving inequalities","user":{"login":"kshitij10496","id":12427142,"avatar_url":"https://avatars.githubusercontent.com/u/12427142?v=3","gravatar_id":"","url":"https://api.github.com/users/kshitij10496","html_url":"https://github.com/kshitij10496","followers_url":"https://api.github.com/users/kshitij10496/followers","following_url":"https://api.github.com/users/kshitij10496/following{/other_user}","gists_url":"https://api.github.com/users/kshitij10496/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij10496/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij10496/subscriptions","organizations_url":"https://api.github.com/users/kshitij10496/orgs","repos_url":"https://api.github.com/users/kshitij10496/repos","events_url":"https://api.github.com/users/kshitij10496/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij10496/received_events","type":"User","site_admin":false},"body":"This PR is an attempt to use the results from `solveset` for solving univariate inequalities (in the real domain). Currently, the primary method for solving such inequalities - `solve_univariate_inequality`, uses the `solve` internally. \r\n\r\n- [x] implement `solvify`\r\n- [x] XFAIL failing tests\r\n- [x] docstrings\r\n- [x] consolidate `solve_univariate_inequality` function for the new `domain` argument.\r\n- [x] added tests from #9721 \r\n","created_at":"2016-08-01T12:19:48Z","updated_at":"2016-08-19T12:48:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/11458/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/11458/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/11458/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/f54e15c756a1b1dcc9518ecfe7e2b4b5c2cca5c2","head":{"label":"kshitij10496:trig_inequalities","ref":"trig_inequalities","sha":"f54e15c756a1b1dcc9518ecfe7e2b4b5c2cca5c2","user":{"login":"kshitij10496","id":12427142,"avatar_url":"https://avatars.githubusercontent.com/u/12427142?v=3","gravatar_id":"","url":"https://api.github.com/users/kshitij10496","html_url":"https://github.com/kshitij10496","followers_url":"https://api.github.com/users/kshitij10496/followers","following_url":"https://api.github.com/users/kshitij10496/following{/other_user}","gists_url":"https://api.github.com/users/kshitij10496/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij10496/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij10496/subscriptions","organizations_url":"https://api.github.com/users/kshitij10496/orgs","repos_url":"https://api.github.com/users/kshitij10496/repos","events_url":"https://api.github.com/users/kshitij10496/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij10496/received_events","type":"User","site_admin":false},"repo":{"id":43112313,"name":"sympy","full_name":"kshitij10496/sympy","owner":{"login":"kshitij10496","id":12427142,"avatar_url":"https://avatars.githubusercontent.com/u/12427142?v=3","gravatar_id":"","url":"https://api.github.com/users/kshitij10496","html_url":"https://github.com/kshitij10496","followers_url":"https://api.github.com/users/kshitij10496/followers","following_url":"https://api.github.com/users/kshitij10496/following{/other_user}","gists_url":"https://api.github.com/users/kshitij10496/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij10496/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij10496/subscriptions","organizations_url":"https://api.github.com/users/kshitij10496/orgs","repos_url":"https://api.github.com/users/kshitij10496/repos","events_url":"https://api.github.com/users/kshitij10496/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij10496/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kshitij10496/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/kshitij10496/sympy","forks_url":"https://api.github.com/repos/kshitij10496/sympy/forks","keys_url":"https://api.github.com/repos/kshitij10496/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kshitij10496/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kshitij10496/sympy/teams","hooks_url":"https://api.github.com/repos/kshitij10496/sympy/hooks","issue_events_url":"https://api.github.com/repos/kshitij10496/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/kshitij10496/sympy/events","assignees_url":"https://api.github.com/repos/kshitij10496/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/kshitij10496/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/kshitij10496/sympy/tags","blobs_url":"https://api.github.com/repos/kshitij10496/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kshitij10496/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kshitij10496/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kshitij10496/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kshitij10496/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/kshitij10496/sympy/languages","stargazers_url":"https://api.github.com/repos/kshitij10496/sympy/stargazers","contributors_url":"https://api.github.com/repos/kshitij10496/sympy/contributors","subscribers_url":"https://api.github.com/repos/kshitij10496/sympy/subscribers","subscription_url":"https://api.github.com/repos/kshitij10496/sympy/subscription","commits_url":"https://api.github.com/repos/kshitij10496/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kshitij10496/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kshitij10496/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kshitij10496/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kshitij10496/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/kshitij10496/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kshitij10496/sympy/merges","archive_url":"https://api.github.com/repos/kshitij10496/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kshitij10496/sympy/downloads","issues_url":"https://api.github.com/repos/kshitij10496/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/kshitij10496/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/kshitij10496/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/kshitij10496/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kshitij10496/sympy/labels{/name}","releases_url":"https://api.github.com/repos/kshitij10496/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/kshitij10496/sympy/deployments","created_at":"2015-09-25T05:55:24Z","updated_at":"2016-05-28T16:21:12Z","pushed_at":"2016-08-19T12:37:25Z","git_url":"git://github.com/kshitij10496/sympy.git","ssh_url":"git@github.com:kshitij10496/sympy.git","clone_url":"https://github.com/kshitij10496/sympy.git","svn_url":"https://github.com/kshitij10496/sympy","homepage":"http://sympy.org/","size":74416,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"8560d0122c273fdd8187c4f20d689c2da49d973b","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2016-08-19T11:08:12Z","pushed_at":"2016-08-19T12:37:28Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":116069,"stargazers_count":3057,"watchers_count":3057,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1551,"mirror_url":null,"open_issues_count":2494,"forks":1551,"open_issues":2494,"watchers":3057,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11458"},"html":{"href":"https://github.com/sympy/sympy/pull/11458"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/11458"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/11458/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11458/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11458/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/f54e15c756a1b1dcc9518ecfe7e2b4b5c2cca5c2"}}}}
{"actor":{"display_login":"kshitij10496"}}