{"action":"created","comment":{"url":"https://api.github.com/repos/kontena/kontena/pulls/comments/85695042","pull_request_review_id":6395298,"id":85695042,"diff_hunk":"@@ -201,6 +201,7 @@ def start(info)\n         end\n       end\n \n+      attach_router unless interface_ip('weave')","path":"agent/lib/kontena/network_adapters/weave.rb","position":4,"original_position":4,"commit_id":"10ee56f20f0ee2e11ca19d2072b156563d870141","original_commit_id":"10ee56f20f0ee2e11ca19d2072b156563d870141","user":{"login":"jnummelin","id":3205505,"avatar_url":"https://avatars.githubusercontent.com/u/3205505?v=3","gravatar_id":"","url":"https://api.github.com/users/jnummelin","html_url":"https://github.com/jnummelin","followers_url":"https://api.github.com/users/jnummelin/followers","following_url":"https://api.github.com/users/jnummelin/following{/other_user}","gists_url":"https://api.github.com/users/jnummelin/gists{/gist_id}","starred_url":"https://api.github.com/users/jnummelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnummelin/subscriptions","organizations_url":"https://api.github.com/users/jnummelin/orgs","repos_url":"https://api.github.com/users/jnummelin/repos","events_url":"https://api.github.com/users/jnummelin/events{/privacy}","received_events_url":"https://api.github.com/users/jnummelin/received_events","type":"User","site_admin":false},"body":"If weave interface exist without address and agent heals it (with a rescue from `Errno::EADDRNOTAVAIL`) for some reason the \"healed\" weave interface seems to be slightly different compared when it's completely re-created:\r\n```\r\ncore@quiet-frost-93 ~ $ ip addr show dev weave\r\n8: weave: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1410 qdisc noqueue state UP group default qlen 1000\r\n    link/ether be:f4:ed:2d:50:04 brd ff:ff:ff:ff:ff:ff\r\n    inet 10.81.0.1/19 scope global weave\r\n       valid_lft forever preferred_lft forever\r\n```\r\nvs. normally created interface:\r\n```\r\ncore@quiet-frost-93 ~ $ ip addr show dev weave\r\n8: weave: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1410 qdisc noqueue state UP group default qlen 1000\r\n    link/ether be:f4:ed:2d:50:04 brd ff:ff:ff:ff:ff:ff\r\n    inet 10.81.0.1/19 scope global weave\r\n       valid_lft forever preferred_lft forever\r\n    inet6 fe80::bcf4:edff:fe2d:5004/64 scope link \r\n       valid_lft forever preferred_lft forever\r\n```\r\n\r\nSo it misses IPv6 config. As weave (and Kontena) doesn't support IPv6 this should not be an issue.","created_at":"2016-10-31T07:45:46Z","updated_at":"2016-10-31T07:45:46Z","html_url":"https://github.com/kontena/kontena/pull/1253#discussion_r85695042","pull_request_url":"https://api.github.com/repos/kontena/kontena/pulls/1253","_links":{"self":{"href":"https://api.github.com/repos/kontena/kontena/pulls/comments/85695042"},"html":{"href":"https://github.com/kontena/kontena/pull/1253#discussion_r85695042"},"pull_request":{"href":"https://api.github.com/repos/kontena/kontena/pulls/1253"}}},"pull_request":{"url":"https://api.github.com/repos/kontena/kontena/pulls/1253","id":91490387,"html_url":"https://github.com/kontena/kontena/pull/1253","diff_url":"https://github.com/kontena/kontena/pull/1253.diff","patch_url":"https://github.com/kontena/kontena/pull/1253.patch","issue_url":"https://api.github.com/repos/kontena/kontena/issues/1253","number":1253,"state":"open","locked":false,"title":"Call attach-router if interface ip does not exist","user":{"login":"jakolehm","id":1446224,"avatar_url":"https://avatars.githubusercontent.com/u/1446224?v=3","gravatar_id":"","url":"https://api.github.com/users/jakolehm","html_url":"https://github.com/jakolehm","followers_url":"https://api.github.com/users/jakolehm/followers","following_url":"https://api.github.com/users/jakolehm/following{/other_user}","gists_url":"https://api.github.com/users/jakolehm/gists{/gist_id}","starred_url":"https://api.github.com/users/jakolehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakolehm/subscriptions","organizations_url":"https://api.github.com/users/jakolehm/orgs","repos_url":"https://api.github.com/users/jakolehm/repos","events_url":"https://api.github.com/users/jakolehm/events{/privacy}","received_events_url":"https://api.github.com/users/jakolehm/received_events","type":"User","site_admin":false},"body":"Fixes #1249 \n","created_at":"2016-10-29T14:20:54Z","updated_at":"2016-10-31T07:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3195dd4b8f0824c511cc9c8d8d9886a27d09ea8","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kontena/kontena/milestones/54","html_url":"https://github.com/kontena/kontena/milestones/0.16.1","labels_url":"https://api.github.com/repos/kontena/kontena/milestones/54/labels","id":2082109,"number":54,"title":"0.16.1","description":"","creator":{"login":"jakolehm","id":1446224,"avatar_url":"https://avatars.githubusercontent.com/u/1446224?v=3","gravatar_id":"","url":"https://api.github.com/users/jakolehm","html_url":"https://github.com/jakolehm","followers_url":"https://api.github.com/users/jakolehm/followers","following_url":"https://api.github.com/users/jakolehm/following{/other_user}","gists_url":"https://api.github.com/users/jakolehm/gists{/gist_id}","starred_url":"https://api.github.com/users/jakolehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakolehm/subscriptions","organizations_url":"https://api.github.com/users/jakolehm/orgs","repos_url":"https://api.github.com/users/jakolehm/repos","events_url":"https://api.github.com/users/jakolehm/events{/privacy}","received_events_url":"https://api.github.com/users/jakolehm/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":23,"state":"open","created_at":"2016-10-20T10:55:59Z","updated_at":"2016-10-29T14:21:30Z","due_on":"2016-10-27T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kontena/kontena/pulls/1253/commits","review_comments_url":"https://api.github.com/repos/kontena/kontena/pulls/1253/comments","review_comment_url":"https://api.github.com/repos/kontena/kontena/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kontena/kontena/issues/1253/comments","statuses_url":"https://api.github.com/repos/kontena/kontena/statuses/10ee56f20f0ee2e11ca19d2072b156563d870141","head":{"label":"kontena:fix/weave-attach-router-no-interface","ref":"fix/weave-attach-router-no-interface","sha":"10ee56f20f0ee2e11ca19d2072b156563d870141","user":{"login":"kontena","id":10419574,"avatar_url":"https://avatars.githubusercontent.com/u/10419574?v=3","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"repo":{"id":32689932,"name":"kontena","full_name":"kontena/kontena","owner":{"login":"kontena","id":10419574,"avatar_url":"https://avatars.githubusercontent.com/u/10419574?v=3","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kontena/kontena","description":"The developer friendly container and micro services platform. Works on any cloud, easy to setup, simple to use.","fork":false,"url":"https://api.github.com/repos/kontena/kontena","forks_url":"https://api.github.com/repos/kontena/kontena/forks","keys_url":"https://api.github.com/repos/kontena/kontena/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontena/kontena/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontena/kontena/teams","hooks_url":"https://api.github.com/repos/kontena/kontena/hooks","issue_events_url":"https://api.github.com/repos/kontena/kontena/issues/events{/number}","events_url":"https://api.github.com/repos/kontena/kontena/events","assignees_url":"https://api.github.com/repos/kontena/kontena/assignees{/user}","branches_url":"https://api.github.com/repos/kontena/kontena/branches{/branch}","tags_url":"https://api.github.com/repos/kontena/kontena/tags","blobs_url":"https://api.github.com/repos/kontena/kontena/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontena/kontena/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontena/kontena/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontena/kontena/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontena/kontena/statuses/{sha}","languages_url":"https://api.github.com/repos/kontena/kontena/languages","stargazers_url":"https://api.github.com/repos/kontena/kontena/stargazers","contributors_url":"https://api.github.com/repos/kontena/kontena/contributors","subscribers_url":"https://api.github.com/repos/kontena/kontena/subscribers","subscription_url":"https://api.github.com/repos/kontena/kontena/subscription","commits_url":"https://api.github.com/repos/kontena/kontena/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontena/kontena/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontena/kontena/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontena/kontena/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontena/kontena/contents/{+path}","compare_url":"https://api.github.com/repos/kontena/kontena/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontena/kontena/merges","archive_url":"https://api.github.com/repos/kontena/kontena/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontena/kontena/downloads","issues_url":"https://api.github.com/repos/kontena/kontena/issues{/number}","pulls_url":"https://api.github.com/repos/kontena/kontena/pulls{/number}","milestones_url":"https://api.github.com/repos/kontena/kontena/milestones{/number}","notifications_url":"https://api.github.com/repos/kontena/kontena/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontena/kontena/labels{/name}","releases_url":"https://api.github.com/repos/kontena/kontena/releases{/id}","deployments_url":"https://api.github.com/repos/kontena/kontena/deployments","created_at":"2015-03-22T18:52:32Z","updated_at":"2016-10-30T19:30:48Z","pushed_at":"2016-10-29T14:20:54Z","git_url":"git://github.com/kontena/kontena.git","ssh_url":"git@github.com:kontena/kontena.git","clone_url":"https://github.com/kontena/kontena.git","svn_url":"https://github.com/kontena/kontena","homepage":"http://www.kontena.io","size":4604,"stargazers_count":833,"watchers_count":833,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":138,"forks":70,"open_issues":138,"watchers":833,"default_branch":"master"}},"base":{"label":"kontena:master","ref":"master","sha":"889b64fa17d6d9906709c115957acc0b266218ed","user":{"login":"kontena","id":10419574,"avatar_url":"https://avatars.githubusercontent.com/u/10419574?v=3","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"repo":{"id":32689932,"name":"kontena","full_name":"kontena/kontena","owner":{"login":"kontena","id":10419574,"avatar_url":"https://avatars.githubusercontent.com/u/10419574?v=3","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kontena/kontena","description":"The developer friendly container and micro services platform. Works on any cloud, easy to setup, simple to use.","fork":false,"url":"https://api.github.com/repos/kontena/kontena","forks_url":"https://api.github.com/repos/kontena/kontena/forks","keys_url":"https://api.github.com/repos/kontena/kontena/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontena/kontena/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontena/kontena/teams","hooks_url":"https://api.github.com/repos/kontena/kontena/hooks","issue_events_url":"https://api.github.com/repos/kontena/kontena/issues/events{/number}","events_url":"https://api.github.com/repos/kontena/kontena/events","assignees_url":"https://api.github.com/repos/kontena/kontena/assignees{/user}","branches_url":"https://api.github.com/repos/kontena/kontena/branches{/branch}","tags_url":"https://api.github.com/repos/kontena/kontena/tags","blobs_url":"https://api.github.com/repos/kontena/kontena/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontena/kontena/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontena/kontena/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontena/kontena/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontena/kontena/statuses/{sha}","languages_url":"https://api.github.com/repos/kontena/kontena/languages","stargazers_url":"https://api.github.com/repos/kontena/kontena/stargazers","contributors_url":"https://api.github.com/repos/kontena/kontena/contributors","subscribers_url":"https://api.github.com/repos/kontena/kontena/subscribers","subscription_url":"https://api.github.com/repos/kontena/kontena/subscription","commits_url":"https://api.github.com/repos/kontena/kontena/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontena/kontena/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontena/kontena/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontena/kontena/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontena/kontena/contents/{+path}","compare_url":"https://api.github.com/repos/kontena/kontena/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontena/kontena/merges","archive_url":"https://api.github.com/repos/kontena/kontena/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontena/kontena/downloads","issues_url":"https://api.github.com/repos/kontena/kontena/issues{/number}","pulls_url":"https://api.github.com/repos/kontena/kontena/pulls{/number}","milestones_url":"https://api.github.com/repos/kontena/kontena/milestones{/number}","notifications_url":"https://api.github.com/repos/kontena/kontena/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontena/kontena/labels{/name}","releases_url":"https://api.github.com/repos/kontena/kontena/releases{/id}","deployments_url":"https://api.github.com/repos/kontena/kontena/deployments","created_at":"2015-03-22T18:52:32Z","updated_at":"2016-10-30T19:30:48Z","pushed_at":"2016-10-29T14:20:54Z","git_url":"git://github.com/kontena/kontena.git","ssh_url":"git@github.com:kontena/kontena.git","clone_url":"https://github.com/kontena/kontena.git","svn_url":"https://github.com/kontena/kontena","homepage":"http://www.kontena.io","size":4604,"stargazers_count":833,"watchers_count":833,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":138,"forks":70,"open_issues":138,"watchers":833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kontena/kontena/pulls/1253"},"html":{"href":"https://github.com/kontena/kontena/pull/1253"},"issue":{"href":"https://api.github.com/repos/kontena/kontena/issues/1253"},"comments":{"href":"https://api.github.com/repos/kontena/kontena/issues/1253/comments"},"review_comments":{"href":"https://api.github.com/repos/kontena/kontena/pulls/1253/comments"},"review_comment":{"href":"https://api.github.com/repos/kontena/kontena/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kontena/kontena/pulls/1253/commits"},"statuses":{"href":"https://api.github.com/repos/kontena/kontena/statuses/10ee56f20f0ee2e11ca19d2072b156563d870141"}}}}
{"actor":{"display_login":"jnummelin"}}