{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/83711857","pull_request_review_id":4537988,"id":83711857,"diff_hunk":"@@ -229,6 +230,15 @@ bool CGUIWindowPVRBase::OnMessage(CGUIMessage& message)\n       bReturn = true;\n     }\n     break;\n+\n+    case GUI_MSG_NOTIFY_ALL:\n+    {\n+      if (message.GetParam1() == GUI_MSG_UPDATE_SOURCES)\n+      {\n+        // removable drive connected/disconnected. base class triggers a window content refresh, which makes no sense for pvr windows.\n+        return true;","path":"xbmc/pvr/windows/GUIWindowPVRBase.cpp","position":18,"original_position":18,"commit_id":"5991fa912f7bea31d6df47f2bac1f0539a869296","original_commit_id":"5991fa912f7bea31d6df47f2bac1f0539a869296","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"body":"are you serious? why?","created_at":"2016-10-17T19:07:31Z","updated_at":"2016-10-17T19:07:31Z","html_url":"https://github.com/xbmc/xbmc/pull/10723#discussion_r83711857","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10723","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/83711857"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10723#discussion_r83711857"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10723"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10723","id":89675309,"html_url":"https://github.com/xbmc/xbmc/pull/10723","diff_url":"https://github.com/xbmc/xbmc/pull/10723.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10723.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10723","number":10723,"state":"open","locked":false,"title":"[PVR] Fix search window update","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"body":"The problem:\r\n- open pvr search window, click \"Search...\", enter some search string, search\r\n=> search dialog closes, progress dialog appears, progress dialog closes, search window fills with search results\r\n- now, plug in a usb stick (yeah, no kidding)\r\n=> Bug: all search results disappear from search window\r\n\r\nBackground/cause: plugging in a usb stick triggers an update of the pvr search window. where first update works fine, any subsequent update erases search results due to wrong reset of <code>m_bSearchConfirmed</code> during search window content update in <code>OnPrepareFileItems</code>.\r\n\r\nThe second commit introduces to ignore the window message sent upon plugging/unplugging removable media as it makes no sense to update pvr search window content in this case. Nevertheless, the first commit is still needed to ensure proper updates (not erasing the search results) triggered by other window messages/actions.\r\n\r\n@xhaggi for review?","created_at":"2016-10-17T18:20:45Z","updated_at":"2016-10-17T19:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b16c3bd71eb28bdc87bc7427535f8a2e9fec5ea","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/90","html_url":"https://github.com/xbmc/xbmc/milestones/Krypton%2017.0-beta4","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/90/labels","id":2041457,"number":90,"title":"Krypton 17.0-beta4","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":95,"state":"open","created_at":"2016-10-01T10:38:29Z","updated_at":"2016-10-17T18:20:45Z","due_on":"2016-10-23T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10723/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10723/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10723/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/5991fa912f7bea31d6df47f2bac1f0539a869296","head":{"label":"ksooo:pvr-fix-search-window-update","ref":"pvr-fix-search-window-update","sha":"5991fa912f7bea31d6df47f2bac1f0539a869296","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"repo":{"id":17368872,"name":"xbmc","full_name":"ksooo/xbmc","owner":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ksooo/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/ksooo/xbmc","forks_url":"https://api.github.com/repos/ksooo/xbmc/forks","keys_url":"https://api.github.com/repos/ksooo/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ksooo/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ksooo/xbmc/teams","hooks_url":"https://api.github.com/repos/ksooo/xbmc/hooks","issue_events_url":"https://api.github.com/repos/ksooo/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/ksooo/xbmc/events","assignees_url":"https://api.github.com/repos/ksooo/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/ksooo/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/ksooo/xbmc/tags","blobs_url":"https://api.github.com/repos/ksooo/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ksooo/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ksooo/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ksooo/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ksooo/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/ksooo/xbmc/languages","stargazers_url":"https://api.github.com/repos/ksooo/xbmc/stargazers","contributors_url":"https://api.github.com/repos/ksooo/xbmc/contributors","subscribers_url":"https://api.github.com/repos/ksooo/xbmc/subscribers","subscription_url":"https://api.github.com/repos/ksooo/xbmc/subscription","commits_url":"https://api.github.com/repos/ksooo/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ksooo/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ksooo/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ksooo/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ksooo/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/ksooo/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ksooo/xbmc/merges","archive_url":"https://api.github.com/repos/ksooo/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ksooo/xbmc/downloads","issues_url":"https://api.github.com/repos/ksooo/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/ksooo/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/ksooo/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/ksooo/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ksooo/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/ksooo/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/ksooo/xbmc/deployments","created_at":"2014-03-03T14:45:39Z","updated_at":"2016-01-11T21:24:55Z","pushed_at":"2016-10-17T18:42:26Z","git_url":"git://github.com/ksooo/xbmc.git","ssh_url":"git@github.com:ksooo/xbmc.git","clone_url":"https://github.com/ksooo/xbmc.git","svn_url":"https://github.com/ksooo/xbmc","homepage":"http://xbmc.org","size":552691,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"2702d19a3b7b5aa25128603bdf18ddf806663a5e","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-10-17T13:22:52Z","pushed_at":"2016-10-17T18:42:27Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1765343,"stargazers_count":5130,"watchers_count":5130,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3721,"mirror_url":null,"open_issues_count":181,"forks":3721,"open_issues":181,"watchers":5130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10723"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10723"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10723"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10723/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10723/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10723/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/5991fa912f7bea31d6df47f2bac1f0539a869296"}}}}
{"actor":{"display_login":"ksooo"}}