{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/85662873","pull_request_review_id":6366299,"id":85662873,"diff_hunk":"@@ -0,0 +1,190 @@\n+apiVersion: v1\n+kind: Service\n+metadata:\n+  # This service is meant to be used by clients of the database. It exposes a ClusterIP that will\n+  # automatically load balance connections to the different database pods.\n+  name: \"{{ printf \"%s-%s-public\" .Release.Name .Values.Name | trunc 63 }}\"\n+  labels:\n+    heritage: {{.Release.Service | quote }}\n+    release: {{.Release.Name | quote }}\n+    chart: \"{{.Chart.Name}}-{{.Chart.Version}}\"\n+    component: \"{{.Release.Name}}-{{.Values.Component}}\"\n+  annotations:\n+    helm.sh/created: {{.Release.Time.Seconds | quote }}\n+spec:\n+  ports:\n+  # The main port, served by gRPC, serves Postgres-flavor SQL, internode\n+  # traffic and the cli.\n+  - port: {{.Values.GrpcPort}}\n+    targetPort: {{.Values.GrpcPort}}\n+    name: grpc\n+  # The secondary port serves the UI as well as health and debug endpoints.\n+  - port: {{.Values.HttpPort}}\n+    targetPort: {{.Values.HttpPort}}\n+    name: http\n+  selector:\n+    component: \"{{.Release.Name}}-{{.Values.Component}}\"\n+---\n+apiVersion: v1\n+kind: Service\n+metadata:\n+  # This service only exists to create DNS entries for each pet in the petset such that they can resolve\n+  # each other's IP addresses. It does not create a load-balanced ClusterIP and should not be used\n+  # directly by clients in most circumstances.\n+  name: \"{{ printf \"%s-%s\" .Release.Name .Values.Name | trunc 63 }}\"\n+  labels:\n+    heritage: {{.Release.Service | quote }}\n+    release: {{.Release.Name | quote }}\n+    chart: \"{{.Chart.Name}}-{{.Chart.Version}}\"\n+    component: \"{{.Release.Name}}-{{.Values.Component}}\"\n+  annotations:\n+    helm.sh/created: {{.Release.Time.Seconds | quote }}\n+    # This is needed to make the peer-finder work properly and to help avoid\n+    # edge cases where instance 0 comes up after losing its data and needs to\n+    # decide whether it should create a new cluster or try to join an existing\n+    # one. If it creates a new cluster when it should have joined an existing\n+    # one, we'd end up with two separate clusters listening at the same service\n+    # endpoint, which would be very bad.\n+    service.alpha.kubernetes.io/tolerate-unready-endpoints: \"true\"\n+    # Enable automatic monitoring of all instances when Prometheus is running in the cluster.\n+    prometheus.io/scrape: \"true\"\n+    prometheus.io/path: \"_status/vars\"\n+    prometheus.io/port: \"8080\"\n+spec:\n+  ports:\n+  - port: {{.Values.GrpcPort}}\n+    targetPort: {{.Values.GrpcPort}}\n+    name: grpc\n+  - port: {{.Values.HttpPort}}\n+    targetPort: {{.Values.HttpPort}}\n+    name: http\n+  clusterIP: None\n+  selector:\n+    component: \"{{.Release.Name}}-{{.Values.Component}}\"\n+---\n+apiVersion: apps/v1alpha1\n+kind: PetSet\n+metadata:\n+  name: \"{{ printf \"%s-%s\" .Release.Name .Values.Name | trunc 63 }}\"\n+  annotations:\n+    helm.sh/created: {{.Release.Time.Seconds | quote }}\n+spec:\n+  serviceName: \"{{ printf \"%s-%s\" .Release.Name .Values.Name | trunc 63 }}\"\n+  replicas: {{default 3 .Values.Replicas}}\n+  template:\n+    metadata:\n+      labels:\n+        heritage: {{.Release.Service | quote }}\n+        release: {{.Release.Name | quote }}\n+        chart: \"{{.Chart.Name}}-{{.Chart.Version}}\"\n+        component: \"{{.Release.Name}}-{{.Values.Component}}\"\n+      annotations:\n+        helm.sh/created: {{.Release.Time.Seconds | quote }}\n+        pod.alpha.kubernetes.io/initialized: \"true\"\n+        # Init containers are run only once in the lifetime of a pod, before\n+        # it's started up for the first time. It has to exit successfully\n+        # before the pod's main containers are allowed to start.\n+        # This particular init container does a DNS lookup for other pods in\n+        # the petset to help determine whether or not a cluster already exists.\n+        # If any other pets exist, it creates a file in the cockroach-data\n+        # directory to pass that information along to the primary container that\n+        # has to decide what command-line flags to use when starting CockroachDB.\n+        # This only matters when a pod's persistent volume is empty - if it has\n+        # data from a previous execution, that data will always be used.\n+        # The cockroachdb/cockroach-k8s-init image is defined at\n+        # github.com/cockroachdb/cockroach/blob/master/cloud/kubernetes/init\n+        pod.alpha.kubernetes.io/init-containers: '[\n+            {\n+                \"name\": \"bootstrap\",\n+                \"image\": \"cockroachdb/cockroach-k8s-init:0.1\",\n+                \"args\": [\n+                  \"-on-start=/on-start.sh\",\n+                  \"-service={{ printf \"%s-%s\" .Release.Name .Values.Name | trunc 63 }}\"\n+                ],\n+                \"env\": [\n+                  {\n+                      \"name\": \"POD_NAMESPACE\",\n+                      \"valueFrom\": {\n+                          \"fieldRef\": {\n+                              \"apiVersion\": \"v1\",\n+                              \"fieldPath\": \"metadata.namespace\"\n+                          }\n+                      }\n+                   }\n+                ],\n+                \"volumeMounts\": [\n+                    {\n+                        \"name\": \"datadir\",\n+                        \"mountPath\": \"/cockroach/cockroach-data\"\n+                    }\n+                ]\n+            }\n+        ]'\n+    spec:\n+      containers:\n+      - name: \"{{ printf \"%s-%s\" .Release.Name .Values.Name | trunc 63 }}\"\n+        image: \"{{.Values.Image}}:{{.Values.ImageTag}}\"\n+        imagePullPolicy: \"{{.Values.ImagePullPolicy}}\"\n+        ports:\n+        - containerPort: {{.Values.GrpcPort}}\n+          name: grpc\n+        - containerPort: {{.Values.HttpPort}}\n+          name: http\n+        resources:\n+          requests:\n+            cpu: \"{{.Values.Cpu}}\"\n+            memory: \"{{.Values.Memory}}\"\n+        env:\n+        - name: PETSET_NAME\n+          value: \"{{ printf \"%s-%s\" .Release.Name .Values.Name | trunc 63 }}\"\n+        livenessProbe:\n+          httpGet:\n+            path: /_admin/v1/health\n+            port: http\n+          initialDelaySeconds: 30\n+        readinessProbe:\n+          httpGet:\n+            path: /_admin/v1/health\n+            port: http\n+          initialDelaySeconds: 10\n+        volumeMounts:\n+        - name: datadir\n+          mountPath: /cockroach/cockroach-data","path":"incubator/cockroachdb/templates/cockroachdb-petset.yaml","position":152,"original_position":152,"commit_id":"e81d883954813ec56232bc82d1859bc09fb05c13","original_commit_id":"e81d883954813ec56232bc82d1859bc09fb05c13","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars.githubusercontent.com/u/335402?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"body":"Should this be a param? Kinda on the fence myself.","created_at":"2016-10-30T16:07:41Z","updated_at":"2016-10-30T16:07:56Z","html_url":"https://github.com/kubernetes/charts/pull/167#discussion_r85662873","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/85662873"},"html":{"href":"https://github.com/kubernetes/charts/pull/167#discussion_r85662873"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/167","id":91440908,"html_url":"https://github.com/kubernetes/charts/pull/167","diff_url":"https://github.com/kubernetes/charts/pull/167.diff","patch_url":"https://github.com/kubernetes/charts/pull/167.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/167","number":167,"state":"open","locked":false,"title":"Add a chart for CockroachDB to the incubator repo","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"body":"The only question that I ran into during the process is how to get the NOTES.txt info to print when the chart is installed. Does that only happen when installed via a remote repo rather than when installing from a local directory?\r\n\r\n@viglesiasce @tschottdorf @jseldess","created_at":"2016-10-28T19:48:45Z","updated_at":"2016-10-30T16:15:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"060c867493fe5bc3af33e76055e98b6dc82bc8b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/167/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/167/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/167/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/e81d883954813ec56232bc82d1859bc09fb05c13","head":{"label":"a-robinson:cdb","ref":"cdb","sha":"e81d883954813ec56232bc82d1859bc09fb05c13","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"repo":{"id":71575775,"name":"charts","full_name":"a-robinson/charts","owner":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-robinson/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":true,"url":"https://api.github.com/repos/a-robinson/charts","forks_url":"https://api.github.com/repos/a-robinson/charts/forks","keys_url":"https://api.github.com/repos/a-robinson/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-robinson/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-robinson/charts/teams","hooks_url":"https://api.github.com/repos/a-robinson/charts/hooks","issue_events_url":"https://api.github.com/repos/a-robinson/charts/issues/events{/number}","events_url":"https://api.github.com/repos/a-robinson/charts/events","assignees_url":"https://api.github.com/repos/a-robinson/charts/assignees{/user}","branches_url":"https://api.github.com/repos/a-robinson/charts/branches{/branch}","tags_url":"https://api.github.com/repos/a-robinson/charts/tags","blobs_url":"https://api.github.com/repos/a-robinson/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-robinson/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-robinson/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-robinson/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-robinson/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/a-robinson/charts/languages","stargazers_url":"https://api.github.com/repos/a-robinson/charts/stargazers","contributors_url":"https://api.github.com/repos/a-robinson/charts/contributors","subscribers_url":"https://api.github.com/repos/a-robinson/charts/subscribers","subscription_url":"https://api.github.com/repos/a-robinson/charts/subscription","commits_url":"https://api.github.com/repos/a-robinson/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-robinson/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-robinson/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-robinson/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-robinson/charts/contents/{+path}","compare_url":"https://api.github.com/repos/a-robinson/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-robinson/charts/merges","archive_url":"https://api.github.com/repos/a-robinson/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-robinson/charts/downloads","issues_url":"https://api.github.com/repos/a-robinson/charts/issues{/number}","pulls_url":"https://api.github.com/repos/a-robinson/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/a-robinson/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/a-robinson/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-robinson/charts/labels{/name}","releases_url":"https://api.github.com/repos/a-robinson/charts/releases{/id}","deployments_url":"https://api.github.com/repos/a-robinson/charts/deployments","created_at":"2016-10-21T15:05:27Z","updated_at":"2016-10-21T15:05:28Z","pushed_at":"2016-10-28T19:46:56Z","git_url":"git://github.com/a-robinson/charts.git","ssh_url":"git@github.com:a-robinson/charts.git","clone_url":"https://github.com/a-robinson/charts.git","svn_url":"https://github.com/a-robinson/charts","homepage":"","size":271,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ee79deb30b1c05f98e5d797f80ace199c2738c35","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2016-10-28T23:56:47Z","pushed_at":"2016-10-28T22:57:48Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":734,"stargazers_count":110,"watchers_count":110,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":36,"forks":72,"open_issues":36,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/167"},"html":{"href":"https://github.com/kubernetes/charts/pull/167"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/167"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/e81d883954813ec56232bc82d1859bc09fb05c13"}}}}
{"actor":{"display_login":"chrislovecnm"}}