{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/milo/issues/54","repository_url":"https://api.github.com/repos/eclipse/milo","labels_url":"https://api.github.com/repos/eclipse/milo/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/milo/issues/54/comments","events_url":"https://api.github.com/repos/eclipse/milo/issues/54/events","html_url":"https://github.com/eclipse/milo/issues/54","id":178730435,"number":54,"title":"WeakReference<AttributeObserver>>","user":{"login":"ergouser","id":1202439,"avatar_url":"https://avatars.githubusercontent.com/u/1202439?v=3","gravatar_id":"","url":"https://api.github.com/users/ergouser","html_url":"https://github.com/ergouser","followers_url":"https://api.github.com/users/ergouser/followers","following_url":"https://api.github.com/users/ergouser/following{/other_user}","gists_url":"https://api.github.com/users/ergouser/gists{/gist_id}","starred_url":"https://api.github.com/users/ergouser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergouser/subscriptions","organizations_url":"https://api.github.com/users/ergouser/orgs","repos_url":"https://api.github.com/users/ergouser/repos","events_url":"https://api.github.com/users/ergouser/events{/privacy}","received_events_url":"https://api.github.com/users/ergouser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-22T21:52:51Z","updated_at":"2016-09-23T15:44:37Z","closed_at":null,"body":"Is there some reason for using a WeakReference for AttributeObservers? I can think of a number of use-cases where there's a one-to-one relationship between a node and an AttributeObserver and no reason (other than the WeakReference) for any other instance to hold a reference."},"comment":{"url":"https://api.github.com/repos/eclipse/milo/issues/comments/249228093","html_url":"https://github.com/eclipse/milo/issues/54#issuecomment-249228093","issue_url":"https://api.github.com/repos/eclipse/milo/issues/54","id":249228093,"user":{"login":"ergouser","id":1202439,"avatar_url":"https://avatars.githubusercontent.com/u/1202439?v=3","gravatar_id":"","url":"https://api.github.com/users/ergouser","html_url":"https://github.com/ergouser","followers_url":"https://api.github.com/users/ergouser/followers","following_url":"https://api.github.com/users/ergouser/following{/other_user}","gists_url":"https://api.github.com/users/ergouser/gists{/gist_id}","starred_url":"https://api.github.com/users/ergouser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergouser/subscriptions","organizations_url":"https://api.github.com/users/ergouser/orgs","repos_url":"https://api.github.com/users/ergouser/repos","events_url":"https://api.github.com/users/ergouser/events{/privacy}","received_events_url":"https://api.github.com/users/ergouser/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T15:44:37Z","updated_at":"2016-09-23T15:44:37Z","body":"I was leaning towards subclassing the nodes, but you have all the variables labeled as \"private\" - that makes it impossible to implement a subclass that can set the value without also triggering the notification.  (Almost all the \"set\" methods have side-effects, so accessing private variables with set/get is not really an option).\r\n\r\nI would strongly suggest that, for a library, absent any pressing reason for a variable to be private, the default protection level should be \"protected\".  This allows subclasses access to the variables while preventing direct access to non-subclasses outside the package."}}
{"actor":{"display_login":"ergouser"}}