{"action":"created","comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/75333824","id":75333824,"diff_hunk":"@@ -0,0 +1,568 @@\n+#ifndef OPENSIM_VANDENBOGERT2011MUSCLE_H_\n+#define OPENSIM_VANDENBOGERT2011MUSCLE_H_\n+\n+/* -------------------------------------------------------------------------- *\n+*                 OpenSim:  VandenBogert2011Muscle.h                         *\n+* -------------------------------------------------------------------------- *\n+* The OpenSim API is a toolkit for musculoskeletal modeling and simulation.  *\n+* See http://opensim.stanford.edu and the NOTICE file for more information.  *\n+* OpenSim is developed at Stanford University and supported by the US        *\n+* National Institutes of Health (U54 GM072970, R24 HD065690) and by DARPA    *\n+* through the Warrior Web program.                                           *\n+*                                                                            *\n+* Copyright (c) 2016 Stanford University and the Authors                     *\n+* Author(s): Brad Humphreys, Chris Dembia, Antoine van den Bogert            *\n+*                                                                            *\n+* Licensed under the Apache License, Version 2.0 (the \"License\"); you may    *\n+* not use this file except in compliance with the License. You may obtain a  *\n+* copy of the License at http://www.apache.org/licenses/LICENSE-2.0.         *\n+*                                                                            *\n+* Unless required by applicable law or agreed to in writing, software        *\n+* distributed under the License is distributed on an \"AS IS\" BASIS,          *\n+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.   *\n+* See the License for the specific language governing permissions and        *\n+        * limitations under the License.                                     *\n+* -------------------------------------------------------------------------- */\n+\n+#include <OpenSim/Actuators/osimActuatorsDLL.h>\n+#include <simbody/internal/common.h>\n+\n+/*\n+The parent class, Muscle.h, provides\n+    1. max_isometric_force\n+    2. optimal_fiber_length\n+    3. tendon_slack_length\n+    4. pennation_angle_at_optimal\n+    5. max_contraction_velocity\n+*/\n+#include <OpenSim/Simulation/Model/Muscle.h>\n+\n+/*\n+#ifdef SWIG\n+#ifdef OSIMACTUATORS_API\n+        #undef OSIMACTUATORS_API\n+        #define OSIMACTUATORS_API\n+    #endif\n+#endif\n+*/\n+\n+\n+namespace OpenSim {\n+/**\n+This class implements a muscle with implicit dynamics capabilities as described\n+ in van den Bogert et al. \\(2011).\n+ */\n+    //TODO:  Add detailed muscle discription\n+\n+// Derive new class from Muscle.h\n+class OSIMACTUATORS_API VandenBogert2011Muscle : public Muscle {\n+//TODO Do I need: class OSIMACTUATORS_API VandenBogert2011Muscle......\n+        OpenSim_DECLARE_CONCRETE_OBJECT(VandenBogert2011Muscle, Muscle);\n+\n+public:\n+//=============================================================================\n+// PROPERTIES\n+//=============================================================================\n+\n+        //OpenSim_DECLARE_PROPERTY(max_isometric_force, double,\n+        //  F_{max} (N) \"Maximum isometric force that the fibers can generate\");\n+        // Comes from parent class, Muscle.h\n+\n+        OpenSim_DECLARE_PROPERTY(fMaxTendonStrain, double,","path":"OpenSim/Actuators/VandenBogert2011Muscle.h","position":71,"original_position":71,"commit_id":"f0d6af332e031c03f15b602fef41eb6481306e83","original_commit_id":"f0d6af332e031c03f15b602fef41eb6481306e83","user":{"login":"humphreysb","id":7395691,"avatar_url":"https://avatars.githubusercontent.com/u/7395691?v=3","gravatar_id":"","url":"https://api.github.com/users/humphreysb","html_url":"https://github.com/humphreysb","followers_url":"https://api.github.com/users/humphreysb/followers","following_url":"https://api.github.com/users/humphreysb/following{/other_user}","gists_url":"https://api.github.com/users/humphreysb/gists{/gist_id}","starred_url":"https://api.github.com/users/humphreysb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphreysb/subscriptions","organizations_url":"https://api.github.com/users/humphreysb/orgs","repos_url":"https://api.github.com/users/humphreysb/repos","events_url":"https://api.github.com/users/humphreysb/events{/privacy}","received_events_url":"https://api.github.com/users/humphreysb/received_events","type":"User","site_admin":false},"body":"Thx (incorporated)","created_at":"2016-08-18T15:45:22Z","updated_at":"2016-08-18T15:45:22Z","html_url":"https://github.com/opensim-org/opensim-core/pull/1160#discussion_r75333824","pull_request_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1160","_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/75333824"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/1160#discussion_r75333824"},"pull_request":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1160"}}},"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1160","id":80186131,"html_url":"https://github.com/opensim-org/opensim-core/pull/1160","diff_url":"https://github.com/opensim-org/opensim-core/pull/1160.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/1160.patch","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1160","number":1160,"state":"open","locked":false,"title":"[WIP] New Implicit Muscle (vandenBogert)","user":{"login":"humphreysb","id":7395691,"avatar_url":"https://avatars.githubusercontent.com/u/7395691?v=3","gravatar_id":"","url":"https://api.github.com/users/humphreysb","html_url":"https://github.com/humphreysb","followers_url":"https://api.github.com/users/humphreysb/followers","following_url":"https://api.github.com/users/humphreysb/following{/other_user}","gists_url":"https://api.github.com/users/humphreysb/gists{/gist_id}","starred_url":"https://api.github.com/users/humphreysb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphreysb/subscriptions","organizations_url":"https://api.github.com/users/humphreysb/orgs","repos_url":"https://api.github.com/users/humphreysb/repos","events_url":"https://api.github.com/users/humphreysb/events{/privacy}","received_events_url":"https://api.github.com/users/humphreysb/received_events","type":"User","site_admin":false},"body":"Work In Process.  This muscle has Implicit Dynamics.\r\n\r\n**This PR is for the muscle only.**  The files of interest are:\r\n- VandenBogert2011Muscle.h\r\n- VandenBogert2011Muscle.cpp\r\n\r\n\r\nSee @chrisdembia's  PR #1147 for the implicit  components implementation (I had merged his branch with mine so they are inadvertently both contained here).","created_at":"2016-08-05T04:07:15Z","updated_at":"2016-08-18T15:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f29ce697adc7fe73a62d501334572b4b47c26c03","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1160/commits","review_comments_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1160/comments","review_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1160/comments","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/f0d6af332e031c03f15b602fef41eb6481306e83","head":{"label":"humphreysb:vandenBogertMuscle","ref":"vandenBogertMuscle","sha":"f0d6af332e031c03f15b602fef41eb6481306e83","user":{"login":"humphreysb","id":7395691,"avatar_url":"https://avatars.githubusercontent.com/u/7395691?v=3","gravatar_id":"","url":"https://api.github.com/users/humphreysb","html_url":"https://github.com/humphreysb","followers_url":"https://api.github.com/users/humphreysb/followers","following_url":"https://api.github.com/users/humphreysb/following{/other_user}","gists_url":"https://api.github.com/users/humphreysb/gists{/gist_id}","starred_url":"https://api.github.com/users/humphreysb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphreysb/subscriptions","organizations_url":"https://api.github.com/users/humphreysb/orgs","repos_url":"https://api.github.com/users/humphreysb/repos","events_url":"https://api.github.com/users/humphreysb/events{/privacy}","received_events_url":"https://api.github.com/users/humphreysb/received_events","type":"User","site_admin":false},"repo":{"id":62158268,"name":"opensim-core","full_name":"humphreysb/opensim-core","owner":{"login":"humphreysb","id":7395691,"avatar_url":"https://avatars.githubusercontent.com/u/7395691?v=3","gravatar_id":"","url":"https://api.github.com/users/humphreysb","html_url":"https://github.com/humphreysb","followers_url":"https://api.github.com/users/humphreysb/followers","following_url":"https://api.github.com/users/humphreysb/following{/other_user}","gists_url":"https://api.github.com/users/humphreysb/gists{/gist_id}","starred_url":"https://api.github.com/users/humphreysb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphreysb/subscriptions","organizations_url":"https://api.github.com/users/humphreysb/orgs","repos_url":"https://api.github.com/users/humphreysb/repos","events_url":"https://api.github.com/users/humphreysb/events{/privacy}","received_events_url":"https://api.github.com/users/humphreysb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/humphreysb/opensim-core","description":"SimTK OpenSim 4.0 C++ libraries and command-line applications, and Java/Python wrapping.","fork":true,"url":"https://api.github.com/repos/humphreysb/opensim-core","forks_url":"https://api.github.com/repos/humphreysb/opensim-core/forks","keys_url":"https://api.github.com/repos/humphreysb/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humphreysb/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humphreysb/opensim-core/teams","hooks_url":"https://api.github.com/repos/humphreysb/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/humphreysb/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/humphreysb/opensim-core/events","assignees_url":"https://api.github.com/repos/humphreysb/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/humphreysb/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/humphreysb/opensim-core/tags","blobs_url":"https://api.github.com/repos/humphreysb/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humphreysb/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humphreysb/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/humphreysb/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humphreysb/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/humphreysb/opensim-core/languages","stargazers_url":"https://api.github.com/repos/humphreysb/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/humphreysb/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/humphreysb/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/humphreysb/opensim-core/subscription","commits_url":"https://api.github.com/repos/humphreysb/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/humphreysb/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/humphreysb/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/humphreysb/opensim-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/humphreysb/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/humphreysb/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humphreysb/opensim-core/merges","archive_url":"https://api.github.com/repos/humphreysb/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humphreysb/opensim-core/downloads","issues_url":"https://api.github.com/repos/humphreysb/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/humphreysb/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/humphreysb/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/humphreysb/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humphreysb/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/humphreysb/opensim-core/releases{/id}","deployments_url":"https://api.github.com/repos/humphreysb/opensim-core/deployments","created_at":"2016-06-28T16:45:14Z","updated_at":"2016-06-28T16:45:29Z","pushed_at":"2016-08-05T07:22:16Z","git_url":"git://github.com/humphreysb/opensim-core.git","ssh_url":"git@github.com:humphreysb/opensim-core.git","clone_url":"https://github.com/humphreysb/opensim-core.git","svn_url":"https://github.com/humphreysb/opensim-core","homepage":"https://opensim.stanford.edu","size":132081,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opensim-org:master","ref":"master","sha":"50369ea26651d6257dc1574a13685590a2ba645d","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim 4.0 C++ libraries and command-line applications, and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-core/deployments","created_at":"2014-06-12T16:57:56Z","updated_at":"2016-08-16T05:12:12Z","pushed_at":"2016-08-18T08:12:55Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"https://opensim.stanford.edu","size":154489,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":340,"forks":44,"open_issues":340,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1160"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/1160"},"issue":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/1160"},"comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/1160/comments"},"review_comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1160/comments"},"review_comment":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1160/commits"},"statuses":{"href":"https://api.github.com/repos/opensim-org/opensim-core/statuses/f0d6af332e031c03f15b602fef41eb6481306e83"}}}}
{"actor":{"display_login":"humphreysb"}}