{"action":"created","issue":{"url":"https://api.github.com/repos/ibm-js/deliteful/issues/653","repository_url":"https://api.github.com/repos/ibm-js/deliteful","labels_url":"https://api.github.com/repos/ibm-js/deliteful/issues/653/labels{/name}","comments_url":"https://api.github.com/repos/ibm-js/deliteful/issues/653/comments","events_url":"https://api.github.com/repos/ibm-js/deliteful/issues/653/events","html_url":"https://github.com/ibm-js/deliteful/issues/653","id":177658532,"number":653,"title":"List should emit `delite-size-change` every time its content changes.","user":{"login":"brunano21","id":4410485,"avatar_url":"https://avatars.githubusercontent.com/u/4410485?v=3","gravatar_id":"","url":"https://api.github.com/users/brunano21","html_url":"https://github.com/brunano21","followers_url":"https://api.github.com/users/brunano21/followers","following_url":"https://api.github.com/users/brunano21/following{/other_user}","gists_url":"https://api.github.com/users/brunano21/gists{/gist_id}","starred_url":"https://api.github.com/users/brunano21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunano21/subscriptions","organizations_url":"https://api.github.com/users/brunano21/orgs","repos_url":"https://api.github.com/users/brunano21/repos","events_url":"https://api.github.com/users/brunano21/events{/privacy}","received_events_url":"https://api.github.com/users/brunano21/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-18T15:34:58Z","updated_at":"2016-09-27T23:31:59Z","closed_at":null,"body":"With the current implementation, `List` emits a `delite-size-change` event when `this.renderItems` changes. However this is not enough and does not cover all scenarios. \r\nIn fact, the event should be emitted every time the list's content changes, including when displaying the NoItems node and the LoadingPanel node.\r\n\r\n`List#refreshRendering()` should be rearranged like below (`deliteful/list/List.js`):\r\n```\r\nrefreshRendering(props) {\r\n    ...\r\n    if ((\"renderItems\" in props && this.renderItems) ||\r\n        (\"_displayedPanel\" in props && this._displayedPanel !== props._displayedPanel)) {\r\n        // notify the list content changed.\r\n        this.emit(\"delite-size-change\");\r\n    }\r\n    ...\r\n}\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ibm-js/deliteful/issues/comments/250029368","html_url":"https://github.com/ibm-js/deliteful/issues/653#issuecomment-250029368","issue_url":"https://api.github.com/repos/ibm-js/deliteful/issues/653","id":250029368,"user":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T23:31:59Z","updated_at":"2016-09-27T23:31:59Z","body":"How about `\"_displayedPanel\" in props && !isAfterInitialRendering`?   Sounds like you don't think that works.  What case do you think it fails in?"}}
{"actor":{"display_login":"wkeese"}}