{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/68081660","id":68081660,"diff_hunk":"@@ -50,11 +53,13 @@\n /**\n  * Flink Sink to produce data into a Kafka topic.\n  *\n- * Please note that this producer does not have any reliability guarantees.\n+ * Please note that this producer provides at-least-once reliability guarantees when\n+ * checkpoints are enabled and setFlushOnCheckpoint(true) is set.\n+ * Otherwise, the producer doesn't provide any reliability guarantees.","path":"flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java","position":31,"original_position":31,"commit_id":"20e05c0565b56407d88fede3eb91e628fb6972d5","original_commit_id":"20e05c0565b56407d88fede3eb91e628fb6972d5","user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars.githubusercontent.com/u/5756858?v=3","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"Does it make sense to completely remove the old behaviour and always enable flush on checkpoint? I'm wondering, because who would like to use a KafkaProducer with not processing guarantees?","created_at":"2016-06-22T16:00:05Z","updated_at":"2016-06-22T16:00:05Z","html_url":"https://github.com/apache/flink/pull/2108#discussion_r68081660","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/2108","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/68081660"},"html":{"href":"https://github.com/apache/flink/pull/2108#discussion_r68081660"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/2108"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2108","id":73975334,"html_url":"https://github.com/apache/flink/pull/2108","diff_url":"https://github.com/apache/flink/pull/2108.diff","patch_url":"https://github.com/apache/flink/pull/2108.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/2108","number":2108,"state":"open","locked":false,"title":"[FLINK-4027] Flush FlinkKafkaProducer on checkpoints","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"body":"A user on the mailing list raised the point that our Kafka producer can be made at-least-once quite easily.\r\nThe current producer code doesn't have any guarantees \r\n\r\nWe are using the producer's callbacks to account for unacknowledged records. When a checkpoint barrier reaches the sink, it will confirm the checkpoint once all pending records have been acked.","created_at":"2016-06-15T20:08:07Z","updated_at":"2016-06-22T16:00:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"401a9ef9827dc55b3159acbdb9f730b962967d2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/2108/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/2108/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/2108/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/20e05c0565b56407d88fede3eb91e628fb6972d5","head":{"label":"rmetzger:flink4027","ref":"flink4027","sha":"20e05c0565b56407d88fede3eb91e628fb6972d5","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"repo":{"id":20618957,"name":"flink","full_name":"rmetzger/flink","owner":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmetzger/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/rmetzger/flink","forks_url":"https://api.github.com/repos/rmetzger/flink/forks","keys_url":"https://api.github.com/repos/rmetzger/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmetzger/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmetzger/flink/teams","hooks_url":"https://api.github.com/repos/rmetzger/flink/hooks","issue_events_url":"https://api.github.com/repos/rmetzger/flink/issues/events{/number}","events_url":"https://api.github.com/repos/rmetzger/flink/events","assignees_url":"https://api.github.com/repos/rmetzger/flink/assignees{/user}","branches_url":"https://api.github.com/repos/rmetzger/flink/branches{/branch}","tags_url":"https://api.github.com/repos/rmetzger/flink/tags","blobs_url":"https://api.github.com/repos/rmetzger/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmetzger/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmetzger/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmetzger/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmetzger/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/rmetzger/flink/languages","stargazers_url":"https://api.github.com/repos/rmetzger/flink/stargazers","contributors_url":"https://api.github.com/repos/rmetzger/flink/contributors","subscribers_url":"https://api.github.com/repos/rmetzger/flink/subscribers","subscription_url":"https://api.github.com/repos/rmetzger/flink/subscription","commits_url":"https://api.github.com/repos/rmetzger/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmetzger/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmetzger/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmetzger/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmetzger/flink/contents/{+path}","compare_url":"https://api.github.com/repos/rmetzger/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmetzger/flink/merges","archive_url":"https://api.github.com/repos/rmetzger/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmetzger/flink/downloads","issues_url":"https://api.github.com/repos/rmetzger/flink/issues{/number}","pulls_url":"https://api.github.com/repos/rmetzger/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/rmetzger/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/rmetzger/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmetzger/flink/labels{/name}","releases_url":"https://api.github.com/repos/rmetzger/flink/releases{/id}","deployments_url":"https://api.github.com/repos/rmetzger/flink/deployments","created_at":"2014-06-08T14:58:57Z","updated_at":"2016-02-26T14:23:08Z","pushed_at":"2016-06-22T15:45:40Z","git_url":"git://github.com/rmetzger/flink.git","ssh_url":"git@github.com:rmetzger/flink.git","clone_url":"https://github.com/rmetzger/flink.git","svn_url":"https://github.com/rmetzger/flink","homepage":null,"size":95175,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"867be9b6a50f83ee3286309149bdeb71166bda05","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-06-22T15:07:58Z","pushed_at":"2016-06-22T15:56:16Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":119835,"stargazers_count":1380,"watchers_count":1380,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":890,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":118,"forks":890,"open_issues":118,"watchers":1380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/2108"},"html":{"href":"https://github.com/apache/flink/pull/2108"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/2108"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/2108/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/2108/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/2108/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/20e05c0565b56407d88fede3eb91e628fb6972d5"}}}}
{"actor":{"display_login":"tillrohrmann"}}