{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/60764558","id":60764558,"diff_hunk":"@@ -225,3 +225,12 @@ When using this size estimator, each job run will record the average time per re\n If a topic is not pulled in a run, its estimated average time per record is the geometric mean of the estimated average time per record of all topics that are pulled in this run. If no topic was pulled in this run, a default value of 1.0 is used.\n \n The time-based estimator is more accurate than the size-based estimator when the time to pull a record is not proportional to the size of the record. However, the time-based estimator may lose accuracy when there are fluctuations in the Hadoop cluster which causes the average time for a partition to vary between different runs.\n+\n+### Topic-specific Partitioning\n+\n+`kafka.topic.specific.state` is a configuration key that allows a user to specify config parameters on a topic specific level. The value of this config should be a JSON Array. Each entry should be a json string and should contain a primitive value that identifies the topic name. All configs in each topic entry will be added to the WorkUnit for that topic.\n+\n+An example value could be:\n+`[{\"topic.name\" : \"myTopic1\", \"writer.partition.columns\" : \"header.memberId\"}, {\"topic.name\" : \"myTopic2\", \"writer.partition.columns\" : \"auditHeader.time\"}]`.\n+\n+The \"topic.name\" field also allows regular expressions. For example, one can specify key, value \"topic.name\" : \"myTopic.*\". In this case all topics whose name matches the pattern \"myTopic.*\" will have all the specified config properties added to their WorkUnit. If more than a topic matches multiple \"topic.name\"s then the properties from all the JSON objects will be added to their WorkUnit.","path":"gobblin-docs/case-studies/Kafka-HDFS-Ingestion.md","position":12,"original_position":12,"commit_id":"5426dd7691f254639a43bc37cf9cb6cacd0f1b09","original_commit_id":"5426dd7691f254639a43bc37cf9cb6cacd0f1b09","user":{"login":"sahilTakiar","id":1282583,"avatar_url":"https://avatars.githubusercontent.com/u/1282583?v=3","gravatar_id":"","url":"https://api.github.com/users/sahilTakiar","html_url":"https://github.com/sahilTakiar","followers_url":"https://api.github.com/users/sahilTakiar/followers","following_url":"https://api.github.com/users/sahilTakiar/following{/other_user}","gists_url":"https://api.github.com/users/sahilTakiar/gists{/gist_id}","starred_url":"https://api.github.com/users/sahilTakiar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahilTakiar/subscriptions","organizations_url":"https://api.github.com/users/sahilTakiar/orgs","repos_url":"https://api.github.com/users/sahilTakiar/repos","events_url":"https://api.github.com/users/sahilTakiar/events{/privacy}","received_events_url":"https://api.github.com/users/sahilTakiar/received_events","type":"User","site_admin":false},"body":"same comment as above","created_at":"2016-04-22T16:14:42Z","updated_at":"2016-04-22T16:14:42Z","html_url":"https://github.com/linkedin/gobblin/pull/937#discussion_r60764558","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/937","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/60764558"},"html":{"href":"https://github.com/linkedin/gobblin/pull/937#discussion_r60764558"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/937"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/937","id":67528693,"html_url":"https://github.com/linkedin/gobblin/pull/937","diff_url":"https://github.com/linkedin/gobblin/pull/937.diff","patch_url":"https://github.com/linkedin/gobblin/pull/937.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/937","number":937,"state":"open","locked":false,"title":"Add documentation for topic specific partitioning configuration","user":{"login":"rakanalh","id":195829,"avatar_url":"https://avatars.githubusercontent.com/u/195829?v=3","gravatar_id":"","url":"https://api.github.com/users/rakanalh","html_url":"https://github.com/rakanalh","followers_url":"https://api.github.com/users/rakanalh/followers","following_url":"https://api.github.com/users/rakanalh/following{/other_user}","gists_url":"https://api.github.com/users/rakanalh/gists{/gist_id}","starred_url":"https://api.github.com/users/rakanalh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakanalh/subscriptions","organizations_url":"https://api.github.com/users/rakanalh/orgs","repos_url":"https://api.github.com/users/rakanalh/repos","events_url":"https://api.github.com/users/rakanalh/events{/privacy}","received_events_url":"https://api.github.com/users/rakanalh/received_events","type":"User","site_admin":false},"body":"I have been diving into Gobblin and found out there was an additional configuration key that was not documented which enables having topic-specific configuration.\r\n\r\nThe change includes the documentation already available in [KafkaSource](https://github.com/linkedin/gobblin/blob/master/gobblin-core/src/main/java/gobblin/source/extractor/extract/kafka/KafkaSource.java#L91) \r\n\r\nCloses #936.","created_at":"2016-04-22T15:21:05Z","updated_at":"2016-04-22T16:14:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc23c33e04dc97fa1545a067be7b03baccacfb1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/937/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/937/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/937/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/5426dd7691f254639a43bc37cf9cb6cacd0f1b09","head":{"label":"rakanalh:master","ref":"master","sha":"5426dd7691f254639a43bc37cf9cb6cacd0f1b09","user":{"login":"rakanalh","id":195829,"avatar_url":"https://avatars.githubusercontent.com/u/195829?v=3","gravatar_id":"","url":"https://api.github.com/users/rakanalh","html_url":"https://github.com/rakanalh","followers_url":"https://api.github.com/users/rakanalh/followers","following_url":"https://api.github.com/users/rakanalh/following{/other_user}","gists_url":"https://api.github.com/users/rakanalh/gists{/gist_id}","starred_url":"https://api.github.com/users/rakanalh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakanalh/subscriptions","organizations_url":"https://api.github.com/users/rakanalh/orgs","repos_url":"https://api.github.com/users/rakanalh/repos","events_url":"https://api.github.com/users/rakanalh/events{/privacy}","received_events_url":"https://api.github.com/users/rakanalh/received_events","type":"User","site_admin":false},"repo":{"id":56864067,"name":"gobblin","full_name":"rakanalh/gobblin","owner":{"login":"rakanalh","id":195829,"avatar_url":"https://avatars.githubusercontent.com/u/195829?v=3","gravatar_id":"","url":"https://api.github.com/users/rakanalh","html_url":"https://github.com/rakanalh","followers_url":"https://api.github.com/users/rakanalh/followers","following_url":"https://api.github.com/users/rakanalh/following{/other_user}","gists_url":"https://api.github.com/users/rakanalh/gists{/gist_id}","starred_url":"https://api.github.com/users/rakanalh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakanalh/subscriptions","organizations_url":"https://api.github.com/users/rakanalh/orgs","repos_url":"https://api.github.com/users/rakanalh/repos","events_url":"https://api.github.com/users/rakanalh/events{/privacy}","received_events_url":"https://api.github.com/users/rakanalh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rakanalh/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":true,"url":"https://api.github.com/repos/rakanalh/gobblin","forks_url":"https://api.github.com/repos/rakanalh/gobblin/forks","keys_url":"https://api.github.com/repos/rakanalh/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rakanalh/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rakanalh/gobblin/teams","hooks_url":"https://api.github.com/repos/rakanalh/gobblin/hooks","issue_events_url":"https://api.github.com/repos/rakanalh/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/rakanalh/gobblin/events","assignees_url":"https://api.github.com/repos/rakanalh/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/rakanalh/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/rakanalh/gobblin/tags","blobs_url":"https://api.github.com/repos/rakanalh/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rakanalh/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rakanalh/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/rakanalh/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rakanalh/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/rakanalh/gobblin/languages","stargazers_url":"https://api.github.com/repos/rakanalh/gobblin/stargazers","contributors_url":"https://api.github.com/repos/rakanalh/gobblin/contributors","subscribers_url":"https://api.github.com/repos/rakanalh/gobblin/subscribers","subscription_url":"https://api.github.com/repos/rakanalh/gobblin/subscription","commits_url":"https://api.github.com/repos/rakanalh/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/rakanalh/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/rakanalh/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/rakanalh/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/rakanalh/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/rakanalh/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rakanalh/gobblin/merges","archive_url":"https://api.github.com/repos/rakanalh/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rakanalh/gobblin/downloads","issues_url":"https://api.github.com/repos/rakanalh/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/rakanalh/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/rakanalh/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/rakanalh/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rakanalh/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/rakanalh/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/rakanalh/gobblin/deployments","created_at":"2016-04-22T15:06:34Z","updated_at":"2016-04-22T15:06:37Z","pushed_at":"2016-04-22T15:18:29Z","git_url":"git://github.com/rakanalh/gobblin.git","ssh_url":"git@github.com:rakanalh/gobblin.git","clone_url":"https://github.com/rakanalh/gobblin.git","svn_url":"https://github.com/rakanalh/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":89555,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"d27910d00bee1485748cf03d4ebafc956f262146","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/gobblin/deployments","created_at":"2014-12-01T18:10:50Z","updated_at":"2016-04-21T17:22:47Z","pushed_at":"2016-04-22T15:21:06Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":165444,"stargazers_count":530,"watchers_count":530,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":212,"mirror_url":null,"open_issues_count":83,"forks":212,"open_issues":83,"watchers":530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/937"},"html":{"href":"https://github.com/linkedin/gobblin/pull/937"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/937"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/937/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/937/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/937/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/5426dd7691f254639a43bc37cf9cb6cacd0f1b09"}}}}