{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/51512598","id":51512598,"diff_hunk":"@@ -0,0 +1,127 @@\n+// Licensed to the Apache Software Foundation (ASF) under one\n+// or more contributor license agreements.  See the NOTICE file\n+// distributed with this work for additional information\n+// regarding copyright ownership.  The ASF licenses this file\n+// to you under the Apache License, Version 2.0 (the\n+// \"License\"); you may not use this file except in compliance\n+// with the License.  You may obtain a copy of the License at\n+//\n+//   http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing,\n+// software distributed under the License is distributed on an\n+// \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+// KIND, either express or implied.  See the License for the\n+// specific language governing permissions and limitations\n+// under the License.\n+\n+// This module defines an abstract interface for iterating through pages in a\n+// Parquet column chunk within a row group. It could be extended in the future\n+// to iterate through all data pages in all chunks in a file.\n+\n+#ifndef PARQUET_COLUMN_PAGE_H\n+#define PARQUET_COLUMN_PAGE_H\n+\n+#include \"parquet/thrift/parquet_types.h\"\n+\n+namespace parquet_cpp {\n+\n+// Note: Copying the specific page header Thrift metadata to the Page","path":"src/parquet/column/page.h","position":29,"original_position":29,"commit_id":"790bf0f50fa9c823f111a28a46aec97e0e38d913","original_commit_id":"790bf0f50fa9c823f111a28a46aec97e0e38d913","user":{"login":"nongli","id":242468,"avatar_url":"https://avatars.githubusercontent.com/u/242468?v=3","gravatar_id":"","url":"https://api.github.com/users/nongli","html_url":"https://github.com/nongli","followers_url":"https://api.github.com/users/nongli/followers","following_url":"https://api.github.com/users/nongli/following{/other_user}","gists_url":"https://api.github.com/users/nongli/gists{/gist_id}","starred_url":"https://api.github.com/users/nongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nongli/subscriptions","organizations_url":"https://api.github.com/users/nongli/orgs","repos_url":"https://api.github.com/users/nongli/repos","events_url":"https://api.github.com/users/nongli/events{/privacy}","received_events_url":"https://api.github.com/users/nongli/received_events","type":"User","site_admin":false},"body":"I'm not sure I understand this comment. ","created_at":"2016-02-02T02:04:00Z","updated_at":"2016-02-02T02:04:00Z","html_url":"https://github.com/apache/parquet-cpp/pull/32#discussion_r51512598","pull_request_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/51512598"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/32#discussion_r51512598"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/32","id":57758870,"html_url":"https://github.com/apache/parquet-cpp/pull/32","diff_url":"https://github.com/apache/parquet-cpp/pull/32.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/32.patch","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/32","number":32,"state":"open","locked":false,"title":"PARQUET-485: Decouple page deserialization from column reader to facilitate unit testing","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"Several things in this patch\r\n\r\n* Adds PageReader abstraction, and a SerializedPageReader implementation\r\n  according to the Parquet file format\r\n* Adds a MockPageReader and a couple unit tests demonstrating end-to-end test\r\n  without creating a Parquet file\r\n* Adds a DataPageBuilder test fixture tool, may become part of the main write\r\n  path later\r\n* Adds PlainEncoder implementation for a few primitive types\r\n* Fixes a few ColumnReader bugs exposed by the unit tests","created_at":"2016-01-31T03:55:06Z","updated_at":"2016-02-02T02:04:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"502c4ae3fb765a69563b17f19944727a8a02ccac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/32/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/32/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/32/comments","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/790bf0f50fa9c823f111a28a46aec97e0e38d913","head":{"label":"wesm:PARQUET-485","ref":"PARQUET-485","sha":"790bf0f50fa9c823f111a28a46aec97e0e38d913","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":48463753,"name":"parquet-cpp","full_name":"wesm/parquet-cpp","owner":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesm/parquet-cpp","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/wesm/parquet-cpp","forks_url":"https://api.github.com/repos/wesm/parquet-cpp/forks","keys_url":"https://api.github.com/repos/wesm/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/wesm/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/wesm/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/parquet-cpp/events","assignees_url":"https://api.github.com/repos/wesm/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/wesm/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/wesm/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/wesm/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/wesm/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/wesm/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/wesm/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/parquet-cpp/merges","archive_url":"https://api.github.com/repos/wesm/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/wesm/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/wesm/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/parquet-cpp/deployments","created_at":"2015-12-23T02:08:59Z","updated_at":"2016-01-11T19:24:28Z","pushed_at":"2016-02-01T22:25:29Z","git_url":"git://github.com/wesm/parquet-cpp.git","ssh_url":"git@github.com:wesm/parquet-cpp.git","clone_url":"https://github.com/wesm/parquet-cpp.git","svn_url":"https://github.com/wesm/parquet-cpp","homepage":null,"size":389,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cc5c120dfcf8a99022708a38f727c034077a8425","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675634,"name":"parquet-cpp","full_name":"apache/parquet-cpp","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-cpp","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-cpp","forks_url":"https://api.github.com/repos/apache/parquet-cpp/forks","keys_url":"https://api.github.com/repos/apache/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/apache/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-cpp/events","assignees_url":"https://api.github.com/repos/apache/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/apache/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/apache/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-cpp/merges","archive_url":"https://api.github.com/repos/apache/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/apache/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-cpp/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-02-01T22:51:47Z","pushed_at":"2016-02-02T00:24:07Z","git_url":"git://github.com/apache/parquet-cpp.git","ssh_url":"git@github.com:apache/parquet-cpp.git","clone_url":"https://github.com/apache/parquet-cpp.git","svn_url":"https://github.com/apache/parquet-cpp","homepage":null,"size":533,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":"git://git.apache.org/parquet-cpp.git","open_issues_count":6,"forks":19,"open_issues":6,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/32"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/32"},"issue":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/32"},"comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-cpp/statuses/790bf0f50fa9c823f111a28a46aec97e0e38d913"}}}}