{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/55485535","id":55485535,"diff_hunk":"@@ -2492,12 +2492,7 @@ url_rewind(URL_FILE *file, const char *relname)\n \t\t\tbreak;\n \n \t\tcase CFTYPE_EXEC:\n-\t\t\t/* we'll need to execute the command again */\n-\t\t\tassert(0); /* There is no way the following code is right. */\n-\t\t\turl_fclose(file, true, relname);\n-\n-\t\t\t/* most of these are null fo us. */\n-\t\t\turl_fopen(url, false, NULL, NULL, NULL, 0);\n+\t\t\telog(ERROR, \"Rescan is not supported for web external table: %s\", relname);","path":"src/backend/access/external/url.c","position":10,"original_position":10,"commit_id":"e19623d07b93b8cccbb2b1bdeb539297c8905ec7","original_commit_id":"e19623d07b93b8cccbb2b1bdeb539297c8905ec7","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"body":"We are indeed mixing up the nomenclature in the documentation, we have these articles in the current doc set: [Defining a Command-Based Writable External Web Table](http://gpdb.docs.pivotal.io/4350/admin_guide/load/topics/g-defining-a-command-based-writable-external-web-table.html) and [Command-based Web External Tables](http://gpdb.docs.pivotal.io/4360/admin_guide/load/topics/g-command-based-web-external-tables.html). I guess this needs to be punted to the documentation team to decide on.\r\n","created_at":"2016-03-09T08:32:37Z","updated_at":"2016-03-09T08:32:37Z","html_url":"https://github.com/greenplum-db/gpdb/pull/489#discussion_r55485535","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/489","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/55485535"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/489#discussion_r55485535"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/489","id":62174118,"html_url":"https://github.com/greenplum-db/gpdb/pull/489","diff_url":"https://github.com/greenplum-db/gpdb/pull/489.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/489.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/489","number":489,"state":"open","locked":false,"title":"Remove assert with error message when rescan web external table","user":{"login":"yydzero","id":512403,"avatar_url":"https://avatars.githubusercontent.com/u/512403?v=3","gravatar_id":"","url":"https://api.github.com/users/yydzero","html_url":"https://github.com/yydzero","followers_url":"https://api.github.com/users/yydzero/followers","following_url":"https://api.github.com/users/yydzero/following{/other_user}","gists_url":"https://api.github.com/users/yydzero/gists{/gist_id}","starred_url":"https://api.github.com/users/yydzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yydzero/subscriptions","organizations_url":"https://api.github.com/users/yydzero/orgs","repos_url":"https://api.github.com/users/yydzero/repos","events_url":"https://api.github.com/users/yydzero/events{/privacy}","received_events_url":"https://api.github.com/users/yydzero/received_events","type":"User","site_admin":false},"body":"Use better error message instead of assert failure.","created_at":"2016-03-09T03:11:03Z","updated_at":"2016-03-09T08:32:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31c4163324267292007d005250d77755e9d9f5b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/489/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/489/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/489/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/e19623d07b93b8cccbb2b1bdeb539297c8905ec7","head":{"label":"yydzero:webext_rescan","ref":"webext_rescan","sha":"e19623d07b93b8cccbb2b1bdeb539297c8905ec7","user":{"login":"yydzero","id":512403,"avatar_url":"https://avatars.githubusercontent.com/u/512403?v=3","gravatar_id":"","url":"https://api.github.com/users/yydzero","html_url":"https://github.com/yydzero","followers_url":"https://api.github.com/users/yydzero/followers","following_url":"https://api.github.com/users/yydzero/following{/other_user}","gists_url":"https://api.github.com/users/yydzero/gists{/gist_id}","starred_url":"https://api.github.com/users/yydzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yydzero/subscriptions","organizations_url":"https://api.github.com/users/yydzero/orgs","repos_url":"https://api.github.com/users/yydzero/repos","events_url":"https://api.github.com/users/yydzero/events{/privacy}","received_events_url":"https://api.github.com/users/yydzero/received_events","type":"User","site_admin":false},"repo":{"id":45431999,"name":"gpdb","full_name":"yydzero/gpdb","owner":{"login":"yydzero","id":512403,"avatar_url":"https://avatars.githubusercontent.com/u/512403?v=3","gravatar_id":"","url":"https://api.github.com/users/yydzero","html_url":"https://github.com/yydzero","followers_url":"https://api.github.com/users/yydzero/followers","following_url":"https://api.github.com/users/yydzero/following{/other_user}","gists_url":"https://api.github.com/users/yydzero/gists{/gist_id}","starred_url":"https://api.github.com/users/yydzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yydzero/subscriptions","organizations_url":"https://api.github.com/users/yydzero/orgs","repos_url":"https://api.github.com/users/yydzero/repos","events_url":"https://api.github.com/users/yydzero/events{/privacy}","received_events_url":"https://api.github.com/users/yydzero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yydzero/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/yydzero/gpdb","forks_url":"https://api.github.com/repos/yydzero/gpdb/forks","keys_url":"https://api.github.com/repos/yydzero/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yydzero/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yydzero/gpdb/teams","hooks_url":"https://api.github.com/repos/yydzero/gpdb/hooks","issue_events_url":"https://api.github.com/repos/yydzero/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/yydzero/gpdb/events","assignees_url":"https://api.github.com/repos/yydzero/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/yydzero/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/yydzero/gpdb/tags","blobs_url":"https://api.github.com/repos/yydzero/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yydzero/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yydzero/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/yydzero/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yydzero/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/yydzero/gpdb/languages","stargazers_url":"https://api.github.com/repos/yydzero/gpdb/stargazers","contributors_url":"https://api.github.com/repos/yydzero/gpdb/contributors","subscribers_url":"https://api.github.com/repos/yydzero/gpdb/subscribers","subscription_url":"https://api.github.com/repos/yydzero/gpdb/subscription","commits_url":"https://api.github.com/repos/yydzero/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/yydzero/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/yydzero/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/yydzero/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/yydzero/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/yydzero/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yydzero/gpdb/merges","archive_url":"https://api.github.com/repos/yydzero/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yydzero/gpdb/downloads","issues_url":"https://api.github.com/repos/yydzero/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/yydzero/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/yydzero/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/yydzero/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yydzero/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/yydzero/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/yydzero/gpdb/deployments","created_at":"2015-11-03T00:50:31Z","updated_at":"2016-01-21T06:38:34Z","pushed_at":"2016-03-09T03:09:52Z","git_url":"git://github.com/yydzero/gpdb.git","ssh_url":"git@github.com:yydzero/gpdb.git","clone_url":"https://github.com/yydzero/gpdb.git","svn_url":"https://github.com/yydzero/gpdb","homepage":"http://greenplum.org","size":138634,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"190950b4a26e268c0ef213d6db55aa0e3fa9347f","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-03-08T22:29:28Z","pushed_at":"2016-03-09T08:15:46Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":142646,"stargazers_count":1339,"watchers_count":1339,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":79,"forks":330,"open_issues":79,"watchers":1339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/489"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/489"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/489"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/e19623d07b93b8cccbb2b1bdeb539297c8905ec7"}}}}