{"action":"created","comment":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/comments/90548479","pull_request_review_id":11068370,"id":90548479,"diff_hunk":"@@ -218,18 +218,18 @@\n     <mpirun mpilib=\"mvapich2\">\n       <executable>srun</executable>\n       <arguments>\n-        <arg name=\"mpi\">--mpi=none</arg>","path":"cime_config/cesm/machines/config_machines.xml","position":24,"original_position":24,"commit_id":"c3a25235924ccbb6f8823964eb96b43a6a7efe65","original_commit_id":"c3a25235924ccbb6f8823964eb96b43a6a7efe65","user":{"login":"jgfouca","id":7292036,"avatar_url":"https://avatars.githubusercontent.com/u/7292036?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false},"body":"It looks like the rest of the file is using 2-space indenting. Why change that here?","created_at":"2016-12-01T22:10:18Z","updated_at":"2016-12-01T22:17:12Z","html_url":"https://github.com/ESMCI/cime/pull/828#discussion_r90548479","pull_request_url":"https://api.github.com/repos/ESMCI/cime/pulls/828","_links":{"self":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/comments/90548479"},"html":{"href":"https://github.com/ESMCI/cime/pull/828#discussion_r90548479"},"pull_request":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/828"}}},"pull_request":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/828","id":94910841,"html_url":"https://github.com/ESMCI/cime/pull/828","diff_url":"https://github.com/ESMCI/cime/pull/828.diff","patch_url":"https://github.com/ESMCI/cime/pull/828.patch","issue_url":"https://api.github.com/repos/ESMCI/cime/issues/828","number":828,"state":"open","locked":false,"title":"Config build","user":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"body":"Several different issues are contained in this PR:\r\n\r\n\r\nThis PR brings the file currently called config_build.xml into config_compilers.xml.\r\nThere is no longer a config_build.xml file.   The new build tools as written were not compatible with the basic structure of cime, this PR tries to reconcile the discontinuities.   In both acme/machines and cesm/machines:\r\n- removed config_compilers.xml\r\n- renamed config_build.xml to config_compilers.xml\r\n\r\nA new CIME directory has been created, CIME/BuildTools that contain build utilities. \r\n- The file XML/build.py has been removed and the classes contained in build.py have been split into separate new files in CIME/BuildTools.\r\n- A new file, configure.py, has been added that contains the functionality in tools/configure (tools/configure now calls BuildTools/configure)\r\n`  \r\nmacro_maker = Compilers(machobj)\r\n`\r\n      before in tools/configure\r\n`    \r\nmacro_maker = Build(machobj)\r\n`\r\nAs a result the refactoring of configure needs to accompany this PR\r\n\r\n- both case.setup and tools/configure now use the same tools to create the Macros file\r\n      now in  configure.py (called by tools/configure)\r\n\r\n\r\nWill carry out extensive prebeta and prealpha testing on all machines for CESM before the PR is accepted\r\n\r\nTest suite: scripts_regression_tests on yellowstone, cori and theta.   \r\nTest baseline: \r\nTest namelist changes: \r\nTest status: bit for bit\r\n\r\nFixes [CIME Github issue #]\r\n\r\nUser interface changes?: \r\n\r\nCode review: \r\n","created_at":"2016-11-22T22:26:17Z","updated_at":"2016-12-01T22:17:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fbb730ddba9a40f943acd19e39fcb830816b6cb","assignee":{"login":"jgfouca","id":7292036,"avatar_url":"https://avatars.githubusercontent.com/u/7292036?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false},"assignees":[{"login":"jgfouca","id":7292036,"avatar_url":"https://avatars.githubusercontent.com/u/7292036?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ESMCI/cime/pulls/828/commits","review_comments_url":"https://api.github.com/repos/ESMCI/cime/pulls/828/comments","review_comment_url":"https://api.github.com/repos/ESMCI/cime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ESMCI/cime/issues/828/comments","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/c3a25235924ccbb6f8823964eb96b43a6a7efe65","head":{"label":"jedwards4b:config_build","ref":"config_build","sha":"c3a25235924ccbb6f8823964eb96b43a6a7efe65","user":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"repo":{"id":42525196,"name":"cime","full_name":"jedwards4b/cime","owner":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jedwards4b/cime","description":"Common Infrastructure for Modeling the Environment","fork":true,"url":"https://api.github.com/repos/jedwards4b/cime","forks_url":"https://api.github.com/repos/jedwards4b/cime/forks","keys_url":"https://api.github.com/repos/jedwards4b/cime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jedwards4b/cime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jedwards4b/cime/teams","hooks_url":"https://api.github.com/repos/jedwards4b/cime/hooks","issue_events_url":"https://api.github.com/repos/jedwards4b/cime/issues/events{/number}","events_url":"https://api.github.com/repos/jedwards4b/cime/events","assignees_url":"https://api.github.com/repos/jedwards4b/cime/assignees{/user}","branches_url":"https://api.github.com/repos/jedwards4b/cime/branches{/branch}","tags_url":"https://api.github.com/repos/jedwards4b/cime/tags","blobs_url":"https://api.github.com/repos/jedwards4b/cime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jedwards4b/cime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jedwards4b/cime/git/refs{/sha}","trees_url":"https://api.github.com/repos/jedwards4b/cime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jedwards4b/cime/statuses/{sha}","languages_url":"https://api.github.com/repos/jedwards4b/cime/languages","stargazers_url":"https://api.github.com/repos/jedwards4b/cime/stargazers","contributors_url":"https://api.github.com/repos/jedwards4b/cime/contributors","subscribers_url":"https://api.github.com/repos/jedwards4b/cime/subscribers","subscription_url":"https://api.github.com/repos/jedwards4b/cime/subscription","commits_url":"https://api.github.com/repos/jedwards4b/cime/commits{/sha}","git_commits_url":"https://api.github.com/repos/jedwards4b/cime/git/commits{/sha}","comments_url":"https://api.github.com/repos/jedwards4b/cime/comments{/number}","issue_comment_url":"https://api.github.com/repos/jedwards4b/cime/issues/comments{/number}","contents_url":"https://api.github.com/repos/jedwards4b/cime/contents/{+path}","compare_url":"https://api.github.com/repos/jedwards4b/cime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jedwards4b/cime/merges","archive_url":"https://api.github.com/repos/jedwards4b/cime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jedwards4b/cime/downloads","issues_url":"https://api.github.com/repos/jedwards4b/cime/issues{/number}","pulls_url":"https://api.github.com/repos/jedwards4b/cime/pulls{/number}","milestones_url":"https://api.github.com/repos/jedwards4b/cime/milestones{/number}","notifications_url":"https://api.github.com/repos/jedwards4b/cime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jedwards4b/cime/labels{/name}","releases_url":"https://api.github.com/repos/jedwards4b/cime/releases{/id}","deployments_url":"https://api.github.com/repos/jedwards4b/cime/deployments","created_at":"2015-09-15T14:38:34Z","updated_at":"2016-01-21T01:38:18Z","pushed_at":"2016-12-01T17:10:20Z","git_url":"git://github.com/jedwards4b/cime.git","ssh_url":"git@github.com:jedwards4b/cime.git","clone_url":"https://github.com/jedwards4b/cime.git","svn_url":"https://github.com/jedwards4b/cime","homepage":null,"size":23450,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ESMCI:master","ref":"master","sha":"9ed873f207de256fec75580ae4eaf4686b19e8ad","user":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"repo":{"id":31605662,"name":"cime","full_name":"ESMCI/cime","owner":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ESMCI/cime","description":"Common Infrastructure for Modeling the Earth","fork":false,"url":"https://api.github.com/repos/ESMCI/cime","forks_url":"https://api.github.com/repos/ESMCI/cime/forks","keys_url":"https://api.github.com/repos/ESMCI/cime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESMCI/cime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESMCI/cime/teams","hooks_url":"https://api.github.com/repos/ESMCI/cime/hooks","issue_events_url":"https://api.github.com/repos/ESMCI/cime/issues/events{/number}","events_url":"https://api.github.com/repos/ESMCI/cime/events","assignees_url":"https://api.github.com/repos/ESMCI/cime/assignees{/user}","branches_url":"https://api.github.com/repos/ESMCI/cime/branches{/branch}","tags_url":"https://api.github.com/repos/ESMCI/cime/tags","blobs_url":"https://api.github.com/repos/ESMCI/cime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESMCI/cime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESMCI/cime/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESMCI/cime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/{sha}","languages_url":"https://api.github.com/repos/ESMCI/cime/languages","stargazers_url":"https://api.github.com/repos/ESMCI/cime/stargazers","contributors_url":"https://api.github.com/repos/ESMCI/cime/contributors","subscribers_url":"https://api.github.com/repos/ESMCI/cime/subscribers","subscription_url":"https://api.github.com/repos/ESMCI/cime/subscription","commits_url":"https://api.github.com/repos/ESMCI/cime/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESMCI/cime/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESMCI/cime/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESMCI/cime/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESMCI/cime/contents/{+path}","compare_url":"https://api.github.com/repos/ESMCI/cime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESMCI/cime/merges","archive_url":"https://api.github.com/repos/ESMCI/cime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESMCI/cime/downloads","issues_url":"https://api.github.com/repos/ESMCI/cime/issues{/number}","pulls_url":"https://api.github.com/repos/ESMCI/cime/pulls{/number}","milestones_url":"https://api.github.com/repos/ESMCI/cime/milestones{/number}","notifications_url":"https://api.github.com/repos/ESMCI/cime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESMCI/cime/labels{/name}","releases_url":"https://api.github.com/repos/ESMCI/cime/releases{/id}","deployments_url":"https://api.github.com/repos/ESMCI/cime/deployments","created_at":"2015-03-03T15:33:00Z","updated_at":"2016-10-23T17:33:46Z","pushed_at":"2016-11-30T23:05:38Z","git_url":"git://github.com/ESMCI/cime.git","ssh_url":"git@github.com:ESMCI/cime.git","clone_url":"https://github.com/ESMCI/cime.git","svn_url":"https://github.com/ESMCI/cime","homepage":"","size":24517,"stargazers_count":5,"watchers_count":5,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":132,"forks":33,"open_issues":132,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/828"},"html":{"href":"https://github.com/ESMCI/cime/pull/828"},"issue":{"href":"https://api.github.com/repos/ESMCI/cime/issues/828"},"comments":{"href":"https://api.github.com/repos/ESMCI/cime/issues/828/comments"},"review_comments":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/828/comments"},"review_comment":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/828/commits"},"statuses":{"href":"https://api.github.com/repos/ESMCI/cime/statuses/c3a25235924ccbb6f8823964eb96b43a6a7efe65"}}}}
{"actor":{"display_login":"jgfouca"}}