{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/61807970","id":61807970,"diff_hunk":"@@ -299,21 +304,21 @@ angular.module('openshiftConsole')\n   DataService.prototype.get = function(resource, name, context, opts) {\n     resource = APIService.toResourceGroupVersion(resource);\n     opts = opts || {};\n-\n+    var key = this._uniqueKeyForResourceContext(resource, name, context, _.get(opts, 'http.params'));\n     var force = !!opts.force;\n     delete opts.force;\n \n     var deferred = $q.defer();\n \n-    var existingData = this._data(resource, context);\n+    var existingData = this._data(key);\n \n     // If this is a cached resource (immutable resources only), ignore the force parameter\n     if (this._isResourceCached(resource) && existingData && existingData.by('metadata.name')[name]) {\n       $timeout(function() {\n         deferred.resolve(existingData.by('metadata.name')[name]);\n       }, 0);\n     }\n-    else if (!force && this._watchInFlight(resource, context) && this._resourceVersion(resource, context)) {\n+    else if (!force && this._watchInFlight(key) && this._resourceVersion(key)) {","path":"assets/app/scripts/services/data.js","position":null,"original_position":76,"commit_id":"b11e61ad00e2fd97883c6e64b202d5a1e8ef3f3c","original_commit_id":"cd51fd4ee136424df96ea874ef68e339fef98098","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"I read the comment as saying the cached version of the resource is always current since it's immutable. (+1 to changing the name.)","created_at":"2016-05-02T21:29:25Z","updated_at":"2016-05-02T21:29:25Z","html_url":"https://github.com/openshift/origin/pull/8676#discussion_r61807970","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8676","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/61807970"},"html":{"href":"https://github.com/openshift/origin/pull/8676#discussion_r61807970"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8676"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8676","id":68285820,"html_url":"https://github.com/openshift/origin/pull/8676","diff_url":"https://github.com/openshift/origin/pull/8676.diff","patch_url":"https://github.com/openshift/origin/pull/8676.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8676","number":8676,"state":"open","locked":false,"title":"Update data.js to handle fieldSelector/labelSelector","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"[Original PR against console_1.3](https://github.com/jwforres/origin/pull/40) w/conversation.\r\n\r\n@jwforres @spadgett @liggitt \r\n\r\n","created_at":"2016-04-28T20:34:32Z","updated_at":"2016-05-02T21:29:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08d593dc43279021af1ccb95de1ac53c57781e40","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8676/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8676/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8676/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/b11e61ad00e2fd97883c6e64b202d5a1e8ef3f3c","head":{"label":"benjaminapetersen:bpeterse/trello-data-selector-updates","ref":"bpeterse/trello-data-selector-updates","sha":"b11e61ad00e2fd97883c6e64b202d5a1e8ef3f3c","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"repo":{"id":37674696,"name":"origin","full_name":"benjaminapetersen/origin","owner":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminapetersen/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/benjaminapetersen/origin","forks_url":"https://api.github.com/repos/benjaminapetersen/origin/forks","keys_url":"https://api.github.com/repos/benjaminapetersen/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminapetersen/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminapetersen/origin/teams","hooks_url":"https://api.github.com/repos/benjaminapetersen/origin/hooks","issue_events_url":"https://api.github.com/repos/benjaminapetersen/origin/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminapetersen/origin/events","assignees_url":"https://api.github.com/repos/benjaminapetersen/origin/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminapetersen/origin/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminapetersen/origin/tags","blobs_url":"https://api.github.com/repos/benjaminapetersen/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminapetersen/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminapetersen/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminapetersen/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminapetersen/origin/languages","stargazers_url":"https://api.github.com/repos/benjaminapetersen/origin/stargazers","contributors_url":"https://api.github.com/repos/benjaminapetersen/origin/contributors","subscribers_url":"https://api.github.com/repos/benjaminapetersen/origin/subscribers","subscription_url":"https://api.github.com/repos/benjaminapetersen/origin/subscription","commits_url":"https://api.github.com/repos/benjaminapetersen/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminapetersen/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminapetersen/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminapetersen/origin/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminapetersen/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminapetersen/origin/merges","archive_url":"https://api.github.com/repos/benjaminapetersen/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminapetersen/origin/downloads","issues_url":"https://api.github.com/repos/benjaminapetersen/origin/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminapetersen/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminapetersen/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminapetersen/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminapetersen/origin/labels{/name}","releases_url":"https://api.github.com/repos/benjaminapetersen/origin/releases{/id}","deployments_url":"https://api.github.com/repos/benjaminapetersen/origin/deployments","created_at":"2015-06-18T17:38:49Z","updated_at":"2015-06-18T17:38:52Z","pushed_at":"2016-05-02T20:04:48Z","git_url":"git://github.com/benjaminapetersen/origin.git","ssh_url":"git@github.com:benjaminapetersen/origin.git","clone_url":"https://github.com/benjaminapetersen/origin.git","svn_url":"https://github.com/benjaminapetersen/origin","homepage":"http://www.openshift.org","size":265364,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bpeterse/bug/3436-osc-key-value"}},"base":{"label":"openshift:master","ref":"master","sha":"68e1ee27037ded6187a9c4bd4df576177c6e9318","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-05-01T16:26:32Z","pushed_at":"2016-05-02T21:23:21Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":347007,"stargazers_count":1265,"watchers_count":1265,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":762,"mirror_url":null,"open_issues_count":984,"forks":762,"open_issues":984,"watchers":1265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8676"},"html":{"href":"https://github.com/openshift/origin/pull/8676"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8676"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8676/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8676/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8676/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/b11e61ad00e2fd97883c6e64b202d5a1e8ef3f3c"}}}}