{"action":"created","comment":{"url":"https://api.github.com/repos/Tribler/tribler/pulls/comments/54725867","id":54725867,"diff_hunk":"@@ -628,6 +630,11 @@ def move_storage(self, new_dir):\n     @checkHandleAndSynchronize()\n     def get_save_path(self):\n         if not isinstance(self.tdef, TorrentDefNoMetainfo):\n+            # torrent_handle.save_path() is deprecated in newer versions of Libtorrent. We should use\n+            # self.handle.status().save_path to query the save path of a torrent. However, this attribute\n+            # is only included in libtorrent 1.0.9+\n+            if hasattr(self.handle.status(), 'save_path'):","path":"Tribler/Core/Libtorrent/LibtorrentDownloadImpl.py","position":143,"original_position":134,"commit_id":"8c458a928f1ce1bb5f4d61a57a34482ad1a637ba","original_commit_id":"e6479eec4d2621051eb7a909669bce47322d2137","user":{"login":"whirm","id":529494,"avatar_url":"https://avatars.githubusercontent.com/u/529494?v=3","gravatar_id":"","url":"https://api.github.com/users/whirm","html_url":"https://github.com/whirm","followers_url":"https://api.github.com/users/whirm/followers","following_url":"https://api.github.com/users/whirm/following{/other_user}","gists_url":"https://api.github.com/users/whirm/gists{/gist_id}","starred_url":"https://api.github.com/users/whirm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whirm/subscriptions","organizations_url":"https://api.github.com/users/whirm/orgs","repos_url":"https://api.github.com/users/whirm/repos","events_url":"https://api.github.com/users/whirm/events{/privacy}","received_events_url":"https://api.github.com/users/whirm/received_events","type":"User","site_admin":false},"body":"status=self.handle.status()\r\n...","created_at":"2016-03-02T14:04:22Z","updated_at":"2016-03-02T14:04:22Z","html_url":"https://github.com/Tribler/tribler/pull/1990#discussion_r54725867","pull_request_url":"https://api.github.com/repos/Tribler/tribler/pulls/1990","_links":{"self":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/comments/54725867"},"html":{"href":"https://github.com/Tribler/tribler/pull/1990#discussion_r54725867"},"pull_request":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/1990"}}},"pull_request":{"url":"https://api.github.com/repos/Tribler/tribler/pulls/1990","id":60857131,"html_url":"https://github.com/Tribler/tribler/pull/1990","diff_url":"https://github.com/Tribler/tribler/pull/1990.diff","patch_url":"https://github.com/Tribler/tribler/pull/1990.patch","issue_url":"https://api.github.com/repos/Tribler/tribler/issues/1990","number":1990,"state":"open","locked":false,"title":"Updated deprecated calls in libtorrent","user":{"login":"devos50","id":1707075,"avatar_url":"https://avatars.githubusercontent.com/u/1707075?v=3","gravatar_id":"","url":"https://api.github.com/users/devos50","html_url":"https://github.com/devos50","followers_url":"https://api.github.com/users/devos50/followers","following_url":"https://api.github.com/users/devos50/following{/other_user}","gists_url":"https://api.github.com/users/devos50/gists{/gist_id}","starred_url":"https://api.github.com/users/devos50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devos50/subscriptions","organizations_url":"https://api.github.com/users/devos50/orgs","repos_url":"https://api.github.com/users/devos50/repos","events_url":"https://api.github.com/users/devos50/events{/privacy}","received_events_url":"https://api.github.com/users/devos50/received_events","type":"User","site_admin":false},"body":"In order to increase the stability of Tribler and the tests, the deprecated calls to libtorrent in Tribler (and there are many) should be replaced by newer calls.\r\n\r\nTo find these deprecated methods, I compiled libtorrent without deprecated methods and ran Tribler and the tests to see where it crashes.","created_at":"2016-02-26T15:24:19Z","updated_at":"2016-03-02T14:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5658394ffad90e83f953037c2462de422800d58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Tribler/tribler/pulls/1990/commits","review_comments_url":"https://api.github.com/repos/Tribler/tribler/pulls/1990/comments","review_comment_url":"https://api.github.com/repos/Tribler/tribler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tribler/tribler/issues/1990/comments","statuses_url":"https://api.github.com/repos/Tribler/tribler/statuses/8c458a928f1ce1bb5f4d61a57a34482ad1a637ba","head":{"label":"devos50:libtorrent_deprecated_fix","ref":"libtorrent_deprecated_fix","sha":"8c458a928f1ce1bb5f4d61a57a34482ad1a637ba","user":{"login":"devos50","id":1707075,"avatar_url":"https://avatars.githubusercontent.com/u/1707075?v=3","gravatar_id":"","url":"https://api.github.com/users/devos50","html_url":"https://github.com/devos50","followers_url":"https://api.github.com/users/devos50/followers","following_url":"https://api.github.com/users/devos50/following{/other_user}","gists_url":"https://api.github.com/users/devos50/gists{/gist_id}","starred_url":"https://api.github.com/users/devos50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devos50/subscriptions","organizations_url":"https://api.github.com/users/devos50/orgs","repos_url":"https://api.github.com/users/devos50/repos","events_url":"https://api.github.com/users/devos50/events{/privacy}","received_events_url":"https://api.github.com/users/devos50/received_events","type":"User","site_admin":false},"repo":{"id":45194074,"name":"tribler","full_name":"devos50/tribler","owner":{"login":"devos50","id":1707075,"avatar_url":"https://avatars.githubusercontent.com/u/1707075?v=3","gravatar_id":"","url":"https://api.github.com/users/devos50","html_url":"https://github.com/devos50","followers_url":"https://api.github.com/users/devos50/followers","following_url":"https://api.github.com/users/devos50/following{/other_user}","gists_url":"https://api.github.com/users/devos50/gists{/gist_id}","starred_url":"https://api.github.com/users/devos50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devos50/subscriptions","organizations_url":"https://api.github.com/users/devos50/orgs","repos_url":"https://api.github.com/users/devos50/repos","events_url":"https://api.github.com/users/devos50/events{/privacy}","received_events_url":"https://api.github.com/users/devos50/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devos50/tribler","description":"Privacy with BitTorrent and resilient to shut down","fork":true,"url":"https://api.github.com/repos/devos50/tribler","forks_url":"https://api.github.com/repos/devos50/tribler/forks","keys_url":"https://api.github.com/repos/devos50/tribler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devos50/tribler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devos50/tribler/teams","hooks_url":"https://api.github.com/repos/devos50/tribler/hooks","issue_events_url":"https://api.github.com/repos/devos50/tribler/issues/events{/number}","events_url":"https://api.github.com/repos/devos50/tribler/events","assignees_url":"https://api.github.com/repos/devos50/tribler/assignees{/user}","branches_url":"https://api.github.com/repos/devos50/tribler/branches{/branch}","tags_url":"https://api.github.com/repos/devos50/tribler/tags","blobs_url":"https://api.github.com/repos/devos50/tribler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devos50/tribler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devos50/tribler/git/refs{/sha}","trees_url":"https://api.github.com/repos/devos50/tribler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devos50/tribler/statuses/{sha}","languages_url":"https://api.github.com/repos/devos50/tribler/languages","stargazers_url":"https://api.github.com/repos/devos50/tribler/stargazers","contributors_url":"https://api.github.com/repos/devos50/tribler/contributors","subscribers_url":"https://api.github.com/repos/devos50/tribler/subscribers","subscription_url":"https://api.github.com/repos/devos50/tribler/subscription","commits_url":"https://api.github.com/repos/devos50/tribler/commits{/sha}","git_commits_url":"https://api.github.com/repos/devos50/tribler/git/commits{/sha}","comments_url":"https://api.github.com/repos/devos50/tribler/comments{/number}","issue_comment_url":"https://api.github.com/repos/devos50/tribler/issues/comments{/number}","contents_url":"https://api.github.com/repos/devos50/tribler/contents/{+path}","compare_url":"https://api.github.com/repos/devos50/tribler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devos50/tribler/merges","archive_url":"https://api.github.com/repos/devos50/tribler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devos50/tribler/downloads","issues_url":"https://api.github.com/repos/devos50/tribler/issues{/number}","pulls_url":"https://api.github.com/repos/devos50/tribler/pulls{/number}","milestones_url":"https://api.github.com/repos/devos50/tribler/milestones{/number}","notifications_url":"https://api.github.com/repos/devos50/tribler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devos50/tribler/labels{/name}","releases_url":"https://api.github.com/repos/devos50/tribler/releases{/id}","deployments_url":"https://api.github.com/repos/devos50/tribler/deployments","created_at":"2015-10-29T15:57:50Z","updated_at":"2015-11-20T16:00:03Z","pushed_at":"2016-03-02T13:17:05Z","git_url":"git://github.com/devos50/tribler.git","ssh_url":"git@github.com:devos50/tribler.git","clone_url":"https://github.com/devos50/tribler.git","svn_url":"https://github.com/devos50/tribler","homepage":"http://www.tribler.org","size":110842,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"devel"}},"base":{"label":"Tribler:devel","ref":"devel","sha":"c236b8d56d2ec00efa64491308b4f71666d7aaa9","user":{"login":"Tribler","id":2913489,"avatar_url":"https://avatars.githubusercontent.com/u/2913489?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"repo":{"id":8411137,"name":"tribler","full_name":"Tribler/tribler","owner":{"login":"Tribler","id":2913489,"avatar_url":"https://avatars.githubusercontent.com/u/2913489?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tribler/tribler","description":"Privacy with BitTorrent and resilient to shut down","fork":false,"url":"https://api.github.com/repos/Tribler/tribler","forks_url":"https://api.github.com/repos/Tribler/tribler/forks","keys_url":"https://api.github.com/repos/Tribler/tribler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tribler/tribler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tribler/tribler/teams","hooks_url":"https://api.github.com/repos/Tribler/tribler/hooks","issue_events_url":"https://api.github.com/repos/Tribler/tribler/issues/events{/number}","events_url":"https://api.github.com/repos/Tribler/tribler/events","assignees_url":"https://api.github.com/repos/Tribler/tribler/assignees{/user}","branches_url":"https://api.github.com/repos/Tribler/tribler/branches{/branch}","tags_url":"https://api.github.com/repos/Tribler/tribler/tags","blobs_url":"https://api.github.com/repos/Tribler/tribler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tribler/tribler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tribler/tribler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tribler/tribler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tribler/tribler/statuses/{sha}","languages_url":"https://api.github.com/repos/Tribler/tribler/languages","stargazers_url":"https://api.github.com/repos/Tribler/tribler/stargazers","contributors_url":"https://api.github.com/repos/Tribler/tribler/contributors","subscribers_url":"https://api.github.com/repos/Tribler/tribler/subscribers","subscription_url":"https://api.github.com/repos/Tribler/tribler/subscription","commits_url":"https://api.github.com/repos/Tribler/tribler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tribler/tribler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tribler/tribler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tribler/tribler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tribler/tribler/contents/{+path}","compare_url":"https://api.github.com/repos/Tribler/tribler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tribler/tribler/merges","archive_url":"https://api.github.com/repos/Tribler/tribler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tribler/tribler/downloads","issues_url":"https://api.github.com/repos/Tribler/tribler/issues{/number}","pulls_url":"https://api.github.com/repos/Tribler/tribler/pulls{/number}","milestones_url":"https://api.github.com/repos/Tribler/tribler/milestones{/number}","notifications_url":"https://api.github.com/repos/Tribler/tribler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tribler/tribler/labels{/name}","releases_url":"https://api.github.com/repos/Tribler/tribler/releases{/id}","deployments_url":"https://api.github.com/repos/Tribler/tribler/deployments","created_at":"2013-02-25T14:51:58Z","updated_at":"2016-02-29T20:36:54Z","pushed_at":"2016-03-02T14:01:30Z","git_url":"git://github.com/Tribler/tribler.git","ssh_url":"git@github.com:Tribler/tribler.git","clone_url":"https://github.com/Tribler/tribler.git","svn_url":"https://github.com/Tribler/tribler","homepage":"http://www.tribler.org","size":123392,"stargazers_count":1813,"watchers_count":1813,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":240,"forks":190,"open_issues":240,"watchers":1813,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/1990"},"html":{"href":"https://github.com/Tribler/tribler/pull/1990"},"issue":{"href":"https://api.github.com/repos/Tribler/tribler/issues/1990"},"comments":{"href":"https://api.github.com/repos/Tribler/tribler/issues/1990/comments"},"review_comments":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/1990/comments"},"review_comment":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/1990/commits"},"statuses":{"href":"https://api.github.com/repos/Tribler/tribler/statuses/8c458a928f1ce1bb5f4d61a57a34482ad1a637ba"}}}}