{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/aruba/issues/387","repository_url":"https://api.github.com/repos/cucumber/aruba","labels_url":"https://api.github.com/repos/cucumber/aruba/issues/387/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/aruba/issues/387/comments","events_url":"https://api.github.com/repos/cucumber/aruba/issues/387/events","html_url":"https://github.com/cucumber/aruba/issues/387","id":153591448,"number":387,"title":"Running commands on Windows is broken","user":{"login":"maxmeyer","id":114236,"avatar_url":"https://avatars.githubusercontent.com/u/114236?v=3","gravatar_id":"","url":"https://api.github.com/users/maxmeyer","html_url":"https://github.com/maxmeyer","followers_url":"https://api.github.com/users/maxmeyer/followers","following_url":"https://api.github.com/users/maxmeyer/following{/other_user}","gists_url":"https://api.github.com/users/maxmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmeyer/subscriptions","organizations_url":"https://api.github.com/users/maxmeyer/orgs","repos_url":"https://api.github.com/users/maxmeyer/repos","events_url":"https://api.github.com/users/maxmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/maxmeyer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cucumber/aruba/labels/platform/windows","name":"platform/windows","color":"eb6420"},{"url":"https://api.github.com/repos/cucumber/aruba/labels/type-of-issue/bug","name":"type-of-issue/bug","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cucumber/aruba/milestones/4","html_url":"https://github.com/cucumber/aruba/milestones/1.0.0","labels_url":"https://api.github.com/repos/cucumber/aruba/milestones/4/labels","id":1184376,"number":4,"title":"1.0.0","description":"Major clean up of API","creator":{"login":"maxmeyer","id":114236,"avatar_url":"https://avatars.githubusercontent.com/u/114236?v=3","gravatar_id":"","url":"https://api.github.com/users/maxmeyer","html_url":"https://github.com/maxmeyer","followers_url":"https://api.github.com/users/maxmeyer/followers","following_url":"https://api.github.com/users/maxmeyer/following{/other_user}","gists_url":"https://api.github.com/users/maxmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmeyer/subscriptions","organizations_url":"https://api.github.com/users/maxmeyer/orgs","repos_url":"https://api.github.com/users/maxmeyer/repos","events_url":"https://api.github.com/users/maxmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/maxmeyer/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":4,"state":"open","created_at":"2015-06-28T20:24:52Z","updated_at":"2016-05-10T08:13:43Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-05-07T12:08:53Z","updated_at":"2016-05-12T09:38:32Z","closed_at":null,"body":"## Summary\r\n\r\nRunning commands on windows seems to be broken. Have look at this [build](https://ci.appveyor.com/project/cucumberbdd/aruba/build/461/job/5u82fqffagc4f72o#L273). **Anyone using Ruby on Windows is welcome to help us fixing this.**\r\n<!-- This sections are meant as guidance for you. If some doesn't fit, skip them. In general: Please provide as much information as you can to help us solving your problem -->\r\n\r\n<!--- Provide a general summary of the issue in the Title above -->\r\n\r\n## Expected Behavior\r\n\r\nCommands should be run on Windows.\r\n\r\n<!--- If you're describing a bug, tell us what should happen -->\r\n<!--- If you're suggesting a change/improvement, tell us how it should work -->\r\n\r\n## Current Behavior\r\n\r\nRunning commands fails on AppVeyor CI.\r\n\r\n<!--- If describing a bug, tell us what happens instead of the expected behavior -->\r\n<!--- If suggesting a change/improvement, explain the difference from current behavior -->\r\n\r\n<!--- If you have got some output place it in the code block below. Otherwise remove it. -->\r\n~~~\r\n~~~\r\n\r\n## Possible Solution\r\n\r\nFix code to run commands.\r\n\r\n<!--- Not obligatory, but suggest a fix/reason for the bug, -->\r\n<!--- or ideas how to implement the addition or change -->\r\n\r\n## Steps to Reproduce (for bugs)\r\n\r\nSee [CI Build](https://ci.appveyor.com/project/cucumberbdd/aruba/build/461/job/5u82fqffagc4f72o#L273)\r\n\r\n<!--- Provide a link to a live example, or an unambiguous set of steps to -->\r\n<!--- reproduce this bug. Include code to reproduce, if relevant -->\r\n\r\n## Context\r\n\r\n<!--- How has this issue affected you? What are you trying to accomplish? -->\r\n<!--- Providing context helps us come up with a solution that is most useful in the real world -->\r\n\r\n## Your Environment\r\n\r\n<!--- Include as many relevant details about the environment you experienced the bug in -->\r\n* Version used: latest\r\n* Operating System and version: AppVeyor CI\r\n"},"comment":{"url":"https://api.github.com/repos/cucumber/aruba/issues/comments/218708206","html_url":"https://github.com/cucumber/aruba/issues/387#issuecomment-218708206","issue_url":"https://api.github.com/repos/cucumber/aruba/issues/387","id":218708206,"user":{"login":"dg-ratiodata","id":1267524,"avatar_url":"https://avatars.githubusercontent.com/u/1267524?v=3","gravatar_id":"","url":"https://api.github.com/users/dg-ratiodata","html_url":"https://github.com/dg-ratiodata","followers_url":"https://api.github.com/users/dg-ratiodata/followers","following_url":"https://api.github.com/users/dg-ratiodata/following{/other_user}","gists_url":"https://api.github.com/users/dg-ratiodata/gists{/gist_id}","starred_url":"https://api.github.com/users/dg-ratiodata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg-ratiodata/subscriptions","organizations_url":"https://api.github.com/users/dg-ratiodata/orgs","repos_url":"https://api.github.com/users/dg-ratiodata/repos","events_url":"https://api.github.com/users/dg-ratiodata/events{/privacy}","received_events_url":"https://api.github.com/users/dg-ratiodata/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T09:38:32Z","updated_at":"2016-05-12T09:38:32Z","body":"> I am not so familiar with the code base, but my guess is that Aruba tries to save the output oof a command to a file. \r\n\r\nNo problem, I can guide you.\r\n\r\n> AFAIU Shellwords should/can only be used for bash\r\n\r\nAh. Ok. \r\n\r\n> Not sure whether it is worth introducing a new dependency, but if all that's needed is the split functionality it could be taken from there!?\r\n\r\nI would prefer to take over the bits we need. The gem is MIT-licensed so we don't have a problem here.\r\n\r\n> https://github.com/cucumber/aruba/issues/387#issuecomment-218690403\r\n\r\nThat was fixed for the Unix/Linux part already with https://github.com/cucumber/aruba/pull/357. So we forgot this bit.\r\n\r\n> Calling to_s on this and passing it to File.read \r\n\r\nMmmh... Sure. That's a problem. Do you have a good idea how to implement it in a nice way? I would like to see Windows and Unix CommandString to be implemented quite similar. Maybe just add a `#raw` method to CommandString?\r\n\r\n> he problem is File.read command_string.to_s. I am not so familiar with the code base, but my guess is that Aruba tries to save the output of a command to a file.\r\n\r\nYes, it reads the script and output its for debugging purposes when the correct announcer is given. I think it was `announce-command-content`.\r\n\r\n> Not sure whether there are more problems still. \r\n\r\nMaybe. The windows support is still quite \"brittle\".\r\n"}}