{"action":"created","issue":{"url":"https://api.github.com/repos/MichMich/MagicMirror/issues/470","repository_url":"https://api.github.com/repos/MichMich/MagicMirror","labels_url":"https://api.github.com/repos/MichMich/MagicMirror/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/MichMich/MagicMirror/issues/470/comments","events_url":"https://api.github.com/repos/MichMich/MagicMirror/issues/470/events","html_url":"https://github.com/MichMich/MagicMirror/pull/470","id":183273357,"number":470,"title":"Change position from absolute to fixed","user":{"login":"Jopyth","id":564777,"avatar_url":"https://avatars.githubusercontent.com/u/564777?v=3","gravatar_id":"","url":"https://api.github.com/users/Jopyth","html_url":"https://github.com/Jopyth","followers_url":"https://api.github.com/users/Jopyth/followers","following_url":"https://api.github.com/users/Jopyth/following{/other_user}","gists_url":"https://api.github.com/users/Jopyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Jopyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jopyth/subscriptions","organizations_url":"https://api.github.com/users/Jopyth/orgs","repos_url":"https://api.github.com/users/Jopyth/repos","events_url":"https://api.github.com/users/Jopyth/events{/privacy}","received_events_url":"https://api.github.com/users/Jopyth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-16T15:38:13Z","updated_at":"2016-10-16T15:44:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MichMich/MagicMirror/pulls/470","html_url":"https://github.com/MichMich/MagicMirror/pull/470","diff_url":"https://github.com/MichMich/MagicMirror/pull/470.diff","patch_url":"https://github.com/MichMich/MagicMirror/pull/470.patch"},"body":"* Does the pull request solve a **related** issue?\r\n\r\nNo.\r\n\r\n* What does the pull request accomplish?\r\n\r\nFixes visual display on chrome. Does not change anything when displaying with electron. Hopefully also does not change anything on other browsers.\r\n\r\n* If it includes major visual changes please add screenshots.\r\n\r\nWith the `absolute` position of a hidden module (opacity is manually changed to 1)\r\nother modules move into weird position because of the extra margin:\r\n![absolute](https://cloud.githubusercontent.com/assets/564777/19418550/89bee198-93c6-11e6-9b84-8a13be96e553.png)\r\nWith the `fixed` position (opacity is manually changed to 1), the module itself moves out of the window:\r\n![fixed](https://cloud.githubusercontent.com/assets/564777/19418552/8b3e5922-93c6-11e6-9c01-c5eaa43ae7c6.png)\r\n\r\nChrome is on newest Ubuntu version: Version 54.0.2840.59 (64-bit)."},"comment":{"url":"https://api.github.com/repos/MichMich/MagicMirror/issues/comments/254054437","html_url":"https://github.com/MichMich/MagicMirror/pull/470#issuecomment-254054437","issue_url":"https://api.github.com/repos/MichMich/MagicMirror/issues/470","id":254054437,"user":{"login":"MichMich","id":210954,"avatar_url":"https://avatars.githubusercontent.com/u/210954?v=3","gravatar_id":"","url":"https://api.github.com/users/MichMich","html_url":"https://github.com/MichMich","followers_url":"https://api.github.com/users/MichMich/followers","following_url":"https://api.github.com/users/MichMich/following{/other_user}","gists_url":"https://api.github.com/users/MichMich/gists{/gist_id}","starred_url":"https://api.github.com/users/MichMich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichMich/subscriptions","organizations_url":"https://api.github.com/users/MichMich/orgs","repos_url":"https://api.github.com/users/MichMich/repos","events_url":"https://api.github.com/users/MichMich/events{/privacy}","received_events_url":"https://api.github.com/users/MichMich/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T15:44:42Z","updated_at":"2016-10-16T15:44:42Z","body":"The modules switched to absolute so that they didn't take up any space (eg. other modules would move up). Is that still the case?"}}
{"actor":{"display_login":"MichMich"}}