{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/comments/73498653","id":73498653,"diff_hunk":"@@ -25,7 +25,13 @@\n     }\n     'RedHat': {\n       $package          = 'tftp-server'\n-      $daemon           = false\n+      if $::operatingsystemrelease =~ /^7/ {\n+        $daemon           = true\n+        $service          = 'tftp.socket'\n+        $service_provider = 'systemd'","path":"manifests/params.pp","position":8,"original_position":8,"commit_id":"23ede940b232162d217e963c9986e61a55428b31","original_commit_id":"23ede940b232162d217e963c9986e61a55428b31","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"Isn't this what Puppet does by default on EL7 (and Fedora)?","created_at":"2016-08-04T10:33:13Z","updated_at":"2016-08-04T10:33:13Z","html_url":"https://github.com/theforeman/puppet-tftp/pull/45#discussion_r73498653","pull_request_url":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/comments/73498653"},"html":{"href":"https://github.com/theforeman/puppet-tftp/pull/45#discussion_r73498653"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/45","id":80054941,"html_url":"https://github.com/theforeman/puppet-tftp/pull/45","diff_url":"https://github.com/theforeman/puppet-tftp/pull/45.diff","patch_url":"https://github.com/theforeman/puppet-tftp/pull/45.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-tftp/issues/45","number":45,"state":"open","locked":false,"title":"Centos 7: use systemd socket activation instead of xinetd.","user":{"login":"afics","id":948407,"avatar_url":"https://avatars.githubusercontent.com/u/948407?v=3","gravatar_id":"","url":"https://api.github.com/users/afics","html_url":"https://github.com/afics","followers_url":"https://api.github.com/users/afics/followers","following_url":"https://api.github.com/users/afics/following{/other_user}","gists_url":"https://api.github.com/users/afics/gists{/gist_id}","starred_url":"https://api.github.com/users/afics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afics/subscriptions","organizations_url":"https://api.github.com/users/afics/orgs","repos_url":"https://api.github.com/users/afics/repos","events_url":"https://api.github.com/users/afics/events{/privacy}","received_events_url":"https://api.github.com/users/afics/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-04T10:27:48Z","updated_at":"2016-08-04T10:33:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a01f04757aa544ac1f5dfbe8887f0a1be374a719","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/45/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/45/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-tftp/issues/45/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-tftp/statuses/23ede940b232162d217e963c9986e61a55428b31","head":{"label":"afics:master","ref":"master","sha":"23ede940b232162d217e963c9986e61a55428b31","user":{"login":"afics","id":948407,"avatar_url":"https://avatars.githubusercontent.com/u/948407?v=3","gravatar_id":"","url":"https://api.github.com/users/afics","html_url":"https://github.com/afics","followers_url":"https://api.github.com/users/afics/followers","following_url":"https://api.github.com/users/afics/following{/other_user}","gists_url":"https://api.github.com/users/afics/gists{/gist_id}","starred_url":"https://api.github.com/users/afics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afics/subscriptions","organizations_url":"https://api.github.com/users/afics/orgs","repos_url":"https://api.github.com/users/afics/repos","events_url":"https://api.github.com/users/afics/events{/privacy}","received_events_url":"https://api.github.com/users/afics/received_events","type":"User","site_admin":false},"repo":{"id":64925611,"name":"puppet-tftp","full_name":"afics/puppet-tftp","owner":{"login":"afics","id":948407,"avatar_url":"https://avatars.githubusercontent.com/u/948407?v=3","gravatar_id":"","url":"https://api.github.com/users/afics","html_url":"https://github.com/afics","followers_url":"https://api.github.com/users/afics/followers","following_url":"https://api.github.com/users/afics/following{/other_user}","gists_url":"https://api.github.com/users/afics/gists{/gist_id}","starred_url":"https://api.github.com/users/afics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afics/subscriptions","organizations_url":"https://api.github.com/users/afics/orgs","repos_url":"https://api.github.com/users/afics/repos","events_url":"https://api.github.com/users/afics/events{/privacy}","received_events_url":"https://api.github.com/users/afics/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afics/puppet-tftp","description":"Puppet module for managing tftp","fork":true,"url":"https://api.github.com/repos/afics/puppet-tftp","forks_url":"https://api.github.com/repos/afics/puppet-tftp/forks","keys_url":"https://api.github.com/repos/afics/puppet-tftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afics/puppet-tftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afics/puppet-tftp/teams","hooks_url":"https://api.github.com/repos/afics/puppet-tftp/hooks","issue_events_url":"https://api.github.com/repos/afics/puppet-tftp/issues/events{/number}","events_url":"https://api.github.com/repos/afics/puppet-tftp/events","assignees_url":"https://api.github.com/repos/afics/puppet-tftp/assignees{/user}","branches_url":"https://api.github.com/repos/afics/puppet-tftp/branches{/branch}","tags_url":"https://api.github.com/repos/afics/puppet-tftp/tags","blobs_url":"https://api.github.com/repos/afics/puppet-tftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afics/puppet-tftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afics/puppet-tftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/afics/puppet-tftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afics/puppet-tftp/statuses/{sha}","languages_url":"https://api.github.com/repos/afics/puppet-tftp/languages","stargazers_url":"https://api.github.com/repos/afics/puppet-tftp/stargazers","contributors_url":"https://api.github.com/repos/afics/puppet-tftp/contributors","subscribers_url":"https://api.github.com/repos/afics/puppet-tftp/subscribers","subscription_url":"https://api.github.com/repos/afics/puppet-tftp/subscription","commits_url":"https://api.github.com/repos/afics/puppet-tftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/afics/puppet-tftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/afics/puppet-tftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/afics/puppet-tftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/afics/puppet-tftp/contents/{+path}","compare_url":"https://api.github.com/repos/afics/puppet-tftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afics/puppet-tftp/merges","archive_url":"https://api.github.com/repos/afics/puppet-tftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afics/puppet-tftp/downloads","issues_url":"https://api.github.com/repos/afics/puppet-tftp/issues{/number}","pulls_url":"https://api.github.com/repos/afics/puppet-tftp/pulls{/number}","milestones_url":"https://api.github.com/repos/afics/puppet-tftp/milestones{/number}","notifications_url":"https://api.github.com/repos/afics/puppet-tftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afics/puppet-tftp/labels{/name}","releases_url":"https://api.github.com/repos/afics/puppet-tftp/releases{/id}","deployments_url":"https://api.github.com/repos/afics/puppet-tftp/deployments","created_at":"2016-08-04T10:25:30Z","updated_at":"2016-08-04T10:25:31Z","pushed_at":"2016-08-04T10:26:16Z","git_url":"git://github.com/afics/puppet-tftp.git","ssh_url":"git@github.com:afics/puppet-tftp.git","clone_url":"https://github.com/afics/puppet-tftp.git","svn_url":"https://github.com/afics/puppet-tftp","homepage":"","size":87,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"23f4e3910605e37e8818507fed6f69f7d78f8ef6","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449625,"name":"puppet-tftp","full_name":"theforeman/puppet-tftp","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-tftp","description":"Puppet module for managing tftp","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-tftp","forks_url":"https://api.github.com/repos/theforeman/puppet-tftp/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-tftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-tftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-tftp/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-tftp/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-tftp/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-tftp/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-tftp/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-tftp/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-tftp/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-tftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-tftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-tftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-tftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-tftp/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-tftp/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-tftp/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-tftp/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-tftp/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-tftp/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-tftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-tftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-tftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-tftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-tftp/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-tftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-tftp/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-tftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-tftp/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-tftp/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-tftp/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-tftp/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-tftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-tftp/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-tftp/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-tftp/deployments","created_at":"2012-02-15T13:22:33Z","updated_at":"2016-06-17T10:17:28Z","pushed_at":"2016-08-04T10:27:49Z","git_url":"git://github.com/theforeman/puppet-tftp.git","ssh_url":"git@github.com:theforeman/puppet-tftp.git","clone_url":"https://github.com/theforeman/puppet-tftp.git","svn_url":"https://github.com/theforeman/puppet-tftp","homepage":"","size":87,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":1,"forks":29,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/45"},"html":{"href":"https://github.com/theforeman/puppet-tftp/pull/45"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/issues/45"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-tftp/statuses/23ede940b232162d217e963c9986e61a55428b31"}}}}
{"actor":{"display_login":"ekohl"}}