{"action":"closed","number":10991,"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/10991","id":97142056,"html_url":"https://github.com/CartoDB/cartodb/pull/10991","diff_url":"https://github.com/CartoDB/cartodb/pull/10991.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/10991.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/10991","number":10991,"state":"closed","locked":false,"title":"WIP: Working SAML auth in VM against a test endpoint","user":{"login":"CloudNiner","id":1818302,"avatar_url":"https://avatars.githubusercontent.com/u/1818302?v=3","gravatar_id":"","url":"https://api.github.com/users/CloudNiner","html_url":"https://github.com/CloudNiner","followers_url":"https://api.github.com/users/CloudNiner/followers","following_url":"https://api.github.com/users/CloudNiner/following{/other_user}","gists_url":"https://api.github.com/users/CloudNiner/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudNiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudNiner/subscriptions","organizations_url":"https://api.github.com/users/CloudNiner/orgs","repos_url":"https://api.github.com/users/CloudNiner/repos","events_url":"https://api.github.com/users/CloudNiner/events{/privacy}","received_events_url":"https://api.github.com/users/CloudNiner/received_events","type":"User","site_admin":false},"body":"This PR allows SAML authentication in Carto. Configured via a new `saml_authentication` property in app_config.yml. Generally, if configured, SAML authentication takes precedence over other methods.\r\n\r\nThese are the basics required for a specific client and works with their SAML authentication scheme. Additional TODOs are noted below, some of which are not necessary for the client, but should be strongly considered now that this feature is moving out of a Carto fork.\r\n\r\nInstructions to setup a development environment to test this were provided to @javisantana via the #cartodb-azavea slack channel.\r\n\r\nAdditional TODOs:\r\n - Autocreate users if the user doesn't exist yet in\r\n   cartodb on login. Should be quite straightforward to do\r\n   this in the same way as for http_header_authentication.\r\n - Come up with a way to test this code in isolation\r\n - Clean up a bit so that SAML is more compatible with\r\n   other auth providers\r\n - Come up with a more extensible way to convert the SAML\r\n   name_id to a username/subdomain\r\n - Handle subdomainless urls\r\n - Implement SAML logout. This was not part of the original feature\r\n   request for us. But should be relatively straightforward:\r\n   https://github.com/onelogin/ruby-saml#single-log-out","created_at":"2016-12-08T15:25:44Z","updated_at":"2016-12-22T12:27:48Z","closed_at":"2016-12-22T12:27:48Z","merged_at":"2016-12-22T12:27:48Z","merge_commit_sha":"84b68c232607299161d1e27fac990c61cbbe1ef2","assignee":{"login":"juanignaciosl","id":932968,"avatar_url":"https://avatars.githubusercontent.com/u/932968?v=3","gravatar_id":"","url":"https://api.github.com/users/juanignaciosl","html_url":"https://github.com/juanignaciosl","followers_url":"https://api.github.com/users/juanignaciosl/followers","following_url":"https://api.github.com/users/juanignaciosl/following{/other_user}","gists_url":"https://api.github.com/users/juanignaciosl/gists{/gist_id}","starred_url":"https://api.github.com/users/juanignaciosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanignaciosl/subscriptions","organizations_url":"https://api.github.com/users/juanignaciosl/orgs","repos_url":"https://api.github.com/users/juanignaciosl/repos","events_url":"https://api.github.com/users/juanignaciosl/events{/privacy}","received_events_url":"https://api.github.com/users/juanignaciosl/received_events","type":"User","site_admin":false},"assignees":[{"login":"juanignaciosl","id":932968,"avatar_url":"https://avatars.githubusercontent.com/u/932968?v=3","gravatar_id":"","url":"https://api.github.com/users/juanignaciosl","html_url":"https://github.com/juanignaciosl","followers_url":"https://api.github.com/users/juanignaciosl/followers","following_url":"https://api.github.com/users/juanignaciosl/following{/other_user}","gists_url":"https://api.github.com/users/juanignaciosl/gists{/gist_id}","starred_url":"https://api.github.com/users/juanignaciosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanignaciosl/subscriptions","organizations_url":"https://api.github.com/users/juanignaciosl/orgs","repos_url":"https://api.github.com/users/juanignaciosl/repos","events_url":"https://api.github.com/users/juanignaciosl/events{/privacy}","received_events_url":"https://api.github.com/users/juanignaciosl/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/10991/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/10991/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/10991/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/84b68c232607299161d1e27fac990c61cbbe1ef2","head":{"label":"azavea:feature/cloudniner/saml-authentication","ref":"feature/cloudniner/saml-authentication","sha":"84b68c232607299161d1e27fac990c61cbbe1ef2","user":{"login":"azavea","id":595231,"avatar_url":"https://avatars.githubusercontent.com/u/595231?v=3","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"repo":{"id":23315402,"name":"cartodb","full_name":"azavea/cartodb","owner":{"login":"azavea","id":595231,"avatar_url":"https://avatars.githubusercontent.com/u/595231?v=3","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azavea/cartodb","description":"Geospatial database for the cloud","fork":true,"url":"https://api.github.com/repos/azavea/cartodb","forks_url":"https://api.github.com/repos/azavea/cartodb/forks","keys_url":"https://api.github.com/repos/azavea/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azavea/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azavea/cartodb/teams","hooks_url":"https://api.github.com/repos/azavea/cartodb/hooks","issue_events_url":"https://api.github.com/repos/azavea/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/azavea/cartodb/events","assignees_url":"https://api.github.com/repos/azavea/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/azavea/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/azavea/cartodb/tags","blobs_url":"https://api.github.com/repos/azavea/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azavea/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azavea/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/azavea/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azavea/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/azavea/cartodb/languages","stargazers_url":"https://api.github.com/repos/azavea/cartodb/stargazers","contributors_url":"https://api.github.com/repos/azavea/cartodb/contributors","subscribers_url":"https://api.github.com/repos/azavea/cartodb/subscribers","subscription_url":"https://api.github.com/repos/azavea/cartodb/subscription","commits_url":"https://api.github.com/repos/azavea/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/azavea/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/azavea/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/azavea/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/azavea/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/azavea/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azavea/cartodb/merges","archive_url":"https://api.github.com/repos/azavea/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azavea/cartodb/downloads","issues_url":"https://api.github.com/repos/azavea/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/azavea/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/azavea/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/azavea/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azavea/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/azavea/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/azavea/cartodb/deployments","created_at":"2014-08-25T13:54:41Z","updated_at":"2014-08-23T18:23:45Z","pushed_at":"2016-12-08T14:57:25Z","git_url":"git://github.com/azavea/cartodb.git","ssh_url":"git@github.com:azavea/cartodb.git","clone_url":"https://github.com/azavea/cartodb.git","svn_url":"https://github.com/azavea/cartodb","homepage":"www.cartodb.com","size":334460,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"8a1ba3ca2fb8e15f5629f0d7d8a70ccdd27ccc55","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2016-12-21T23:18:07Z","pushed_at":"2016-12-22T12:27:46Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":343843,"stargazers_count":1356,"watchers_count":1356,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"open_issues_count":585,"forks":359,"open_issues":585,"watchers":1356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/10991"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/10991"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/10991"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/10991/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/10991/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/10991/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/84b68c232607299161d1e27fac990c61cbbe1ef2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"javitonino","id":7569673,"avatar_url":"https://avatars.githubusercontent.com/u/7569673?v=3","gravatar_id":"","url":"https://api.github.com/users/javitonino","html_url":"https://github.com/javitonino","followers_url":"https://api.github.com/users/javitonino/followers","following_url":"https://api.github.com/users/javitonino/following{/other_user}","gists_url":"https://api.github.com/users/javitonino/gists{/gist_id}","starred_url":"https://api.github.com/users/javitonino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javitonino/subscriptions","organizations_url":"https://api.github.com/users/javitonino/orgs","repos_url":"https://api.github.com/users/javitonino/repos","events_url":"https://api.github.com/users/javitonino/events{/privacy}","received_events_url":"https://api.github.com/users/javitonino/received_events","type":"User","site_admin":false},"comments":4,"review_comments":7,"commits":1,"additions":115,"deletions":1,"changed_files":9}}
{"actor":{"display_login":"javitonino"}}