{"action":"closed","number":4896,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/4896","id":97478185,"html_url":"https://github.com/minetest/minetest/pull/4896","diff_url":"https://github.com/minetest/minetest/pull/4896.diff","patch_url":"https://github.com/minetest/minetest/pull/4896.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/4896","number":4896,"state":"closed","locked":false,"title":"Should have platform-independent line breaking","user":{"login":"mafagafogigante","id":8271090,"avatar_url":"https://avatars.githubusercontent.com/u/8271090?v=3","gravatar_id":"","url":"https://api.github.com/users/mafagafogigante","html_url":"https://github.com/mafagafogigante","followers_url":"https://api.github.com/users/mafagafogigante/followers","following_url":"https://api.github.com/users/mafagafogigante/following{/other_user}","gists_url":"https://api.github.com/users/mafagafogigante/gists{/gist_id}","starred_url":"https://api.github.com/users/mafagafogigante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mafagafogigante/subscriptions","organizations_url":"https://api.github.com/users/mafagafogigante/orgs","repos_url":"https://api.github.com/users/mafagafogigante/repos","events_url":"https://api.github.com/users/mafagafogigante/events{/privacy}","received_events_url":"https://api.github.com/users/mafagafogigante/received_events","type":"User","site_admin":false},"body":"This fixes a bug existing in modmgr.lua as reported by @Wuzzy2 which\r\ncaused the mod dependency list to glitch if input was using a line\r\nterminator different than the OS default.\r\n\r\nAlso fixed the corresponding C++ code, which worked based on widen('\\n')\r\nand now works with all of '\\r', '\\r\\n', and '\\n', everywhere.\r\n\r\nTaken into account the size of the depends.txt files used, this should\r\nnot introduce a noticeable performance regression.\r\n\r\nFixes #4720","created_at":"2016-12-11T23:32:09Z","updated_at":"2016-12-12T07:34:03Z","closed_at":"2016-12-12T07:34:03Z","merged_at":null,"merge_commit_sha":"8439c99a7db636d689762813c199798cfddc9ea6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/4896/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/4896/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/4896/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/0e1db351645acaaf61507ef7a7f0e080d332d112","head":{"label":"mafagafogigante:lua-line-fix","ref":"lua-line-fix","sha":"0e1db351645acaaf61507ef7a7f0e080d332d112","user":{"login":"mafagafogigante","id":8271090,"avatar_url":"https://avatars.githubusercontent.com/u/8271090?v=3","gravatar_id":"","url":"https://api.github.com/users/mafagafogigante","html_url":"https://github.com/mafagafogigante","followers_url":"https://api.github.com/users/mafagafogigante/followers","following_url":"https://api.github.com/users/mafagafogigante/following{/other_user}","gists_url":"https://api.github.com/users/mafagafogigante/gists{/gist_id}","starred_url":"https://api.github.com/users/mafagafogigante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mafagafogigante/subscriptions","organizations_url":"https://api.github.com/users/mafagafogigante/orgs","repos_url":"https://api.github.com/users/mafagafogigante/repos","events_url":"https://api.github.com/users/mafagafogigante/events{/privacy}","received_events_url":"https://api.github.com/users/mafagafogigante/received_events","type":"User","site_admin":false},"repo":{"id":76189605,"name":"minetest","full_name":"mafagafogigante/minetest","owner":{"login":"mafagafogigante","id":8271090,"avatar_url":"https://avatars.githubusercontent.com/u/8271090?v=3","gravatar_id":"","url":"https://api.github.com/users/mafagafogigante","html_url":"https://github.com/mafagafogigante","followers_url":"https://api.github.com/users/mafagafogigante/followers","following_url":"https://api.github.com/users/mafagafogigante/following{/other_user}","gists_url":"https://api.github.com/users/mafagafogigante/gists{/gist_id}","starred_url":"https://api.github.com/users/mafagafogigante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mafagafogigante/subscriptions","organizations_url":"https://api.github.com/users/mafagafogigante/orgs","repos_url":"https://api.github.com/users/mafagafogigante/repos","events_url":"https://api.github.com/users/mafagafogigante/events{/privacy}","received_events_url":"https://api.github.com/users/mafagafogigante/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mafagafogigante/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/mafagafogigante/minetest","forks_url":"https://api.github.com/repos/mafagafogigante/minetest/forks","keys_url":"https://api.github.com/repos/mafagafogigante/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mafagafogigante/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mafagafogigante/minetest/teams","hooks_url":"https://api.github.com/repos/mafagafogigante/minetest/hooks","issue_events_url":"https://api.github.com/repos/mafagafogigante/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/mafagafogigante/minetest/events","assignees_url":"https://api.github.com/repos/mafagafogigante/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/mafagafogigante/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/mafagafogigante/minetest/tags","blobs_url":"https://api.github.com/repos/mafagafogigante/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mafagafogigante/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mafagafogigante/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/mafagafogigante/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mafagafogigante/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/mafagafogigante/minetest/languages","stargazers_url":"https://api.github.com/repos/mafagafogigante/minetest/stargazers","contributors_url":"https://api.github.com/repos/mafagafogigante/minetest/contributors","subscribers_url":"https://api.github.com/repos/mafagafogigante/minetest/subscribers","subscription_url":"https://api.github.com/repos/mafagafogigante/minetest/subscription","commits_url":"https://api.github.com/repos/mafagafogigante/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/mafagafogigante/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/mafagafogigante/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/mafagafogigante/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/mafagafogigante/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/mafagafogigante/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mafagafogigante/minetest/merges","archive_url":"https://api.github.com/repos/mafagafogigante/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mafagafogigante/minetest/downloads","issues_url":"https://api.github.com/repos/mafagafogigante/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/mafagafogigante/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/mafagafogigante/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/mafagafogigante/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mafagafogigante/minetest/labels{/name}","releases_url":"https://api.github.com/repos/mafagafogigante/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/mafagafogigante/minetest/deployments","created_at":"2016-12-11T17:40:26Z","updated_at":"2016-12-11T17:40:31Z","pushed_at":"2016-12-12T02:41:12Z","git_url":"git://github.com/mafagafogigante/minetest.git","ssh_url":"git@github.com:mafagafogigante/minetest.git","clone_url":"https://github.com/mafagafogigante/minetest.git","svn_url":"https://github.com/mafagafogigante/minetest","homepage":"http://minetest.net/","size":43508,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"60772071e9b63c24a939078c706b713f46bf3279","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2016-12-11T20:04:09Z","pushed_at":"2016-12-12T07:30:54Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":119068,"stargazers_count":2314,"watchers_count":2314,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":709,"mirror_url":null,"open_issues_count":929,"forks":709,"open_issues":929,"watchers":2314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4896"},"html":{"href":"https://github.com/minetest/minetest/pull/4896"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/4896"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/4896/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4896/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4896/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/0e1db351645acaaf61507ef7a7f0e080d332d112"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":9,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"paramat"}}