{"action":"closed","number":124,"pull_request":{"url":"https://api.github.com/repos/julianstorer/JUCE/pulls/124","id":92585980,"html_url":"https://github.com/julianstorer/JUCE/pull/124","diff_url":"https://github.com/julianstorer/JUCE/pull/124.diff","patch_url":"https://github.com/julianstorer/JUCE/pull/124.patch","issue_url":"https://api.github.com/repos/julianstorer/JUCE/issues/124","number":124,"state":"closed","locked":false,"title":"Some fixes from the Debian packaging of juce","user":{"login":"umlaeute","id":214034,"avatar_url":"https://avatars.githubusercontent.com/u/214034?v=3","gravatar_id":"","url":"https://api.github.com/users/umlaeute","html_url":"https://github.com/umlaeute","followers_url":"https://api.github.com/users/umlaeute/followers","following_url":"https://api.github.com/users/umlaeute/following{/other_user}","gists_url":"https://api.github.com/users/umlaeute/gists{/gist_id}","starred_url":"https://api.github.com/users/umlaeute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umlaeute/subscriptions","organizations_url":"https://api.github.com/users/umlaeute/orgs","repos_url":"https://api.github.com/users/umlaeute/repos","events_url":"https://api.github.com/users/umlaeute/events{/privacy}","received_events_url":"https://api.github.com/users/umlaeute/received_events","type":"User","site_admin":false},"body":"here's a number of patches from the Debian  ['juce'](https://tracker.debian.org/pkg/juce) package.\r\n\r\n# fix building with system-provided libraries\r\n- the `z_uInt` and `png16` patches are needed to build juce without the bundled libraries.\r\n  (please note that the `png16` patch has not really been tested against compatibility with older libpngs)\r\n\r\n# CPP/C/CXX/LDFLAGS\r\nit's great that juce now uses `JUCE_CFLAGS` (and similar) instead of `CFLAGS`.\r\nit's even better that you include `CFLAGS`, so the build-process can inject additional flags.\r\nhowever, it would be best if those flags were *appended* rather than *prepended*, as this would allow to override some of these FLAGS (provided the builder knows what they are doing).\r\n\r\ne.g. if the builder policy is to build all packages with `-O0`, the usual way would be to run\r\n\r\n    make CFLAGS=\"-O0\"\r\n\r\nhowever, since currently the CFLAGS are prepended,  this could expand to some actual compiler flags like `[...] -O0 [...] -fPIC -O3`, effectively disabling the builder's `-O0` flag (since later flags of the\r\n same kind will override earlier one, in this case `-O3` is used)\r\n\r\n# silent builds\r\nusing the \"@\" prefix to silence builds is often great.\r\nsometimes it can be annoying, e.g. when running automated builds on remote server where we don't have direct access to (think: continuous integration).\r\n    \r\nthis patch uses the logic from autotools silent builds, which can be disabled when run as \r\n\r\n    make V=1\r\n\r\n(`V=1` is used by autotools; CMake uses `VERBOSE=1`)\r\n\r\n# reproducible builds\r\nin Debian we would like to make sure that building the source code multiple times, gives the same results **bit for bit**.\r\nThis obviously won't work if the resulting binaries include things like the current date (at time of building).\r\nTherefore we would like to include a patch that allows overriding of the current build time from the cmdline.\r\n\r\nSee also https://reproducible-builds.org/","created_at":"2016-11-07T13:48:29Z","updated_at":"2016-12-19T15:37:50Z","closed_at":"2016-12-19T15:37:50Z","merged_at":null,"merge_commit_sha":"5f007dcf8450c076768ea71b06f9eeae0d3a2146","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/julianstorer/JUCE/pulls/124/commits","review_comments_url":"https://api.github.com/repos/julianstorer/JUCE/pulls/124/comments","review_comment_url":"https://api.github.com/repos/julianstorer/JUCE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/julianstorer/JUCE/issues/124/comments","statuses_url":"https://api.github.com/repos/julianstorer/JUCE/statuses/cc744948ffd739d845806f1650763d93d53a25fb","head":{"label":"umlaeute:debian-fixes","ref":"debian-fixes","sha":"cc744948ffd739d845806f1650763d93d53a25fb","user":{"login":"umlaeute","id":214034,"avatar_url":"https://avatars.githubusercontent.com/u/214034?v=3","gravatar_id":"","url":"https://api.github.com/users/umlaeute","html_url":"https://github.com/umlaeute","followers_url":"https://api.github.com/users/umlaeute/followers","following_url":"https://api.github.com/users/umlaeute/following{/other_user}","gists_url":"https://api.github.com/users/umlaeute/gists{/gist_id}","starred_url":"https://api.github.com/users/umlaeute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umlaeute/subscriptions","organizations_url":"https://api.github.com/users/umlaeute/orgs","repos_url":"https://api.github.com/users/umlaeute/repos","events_url":"https://api.github.com/users/umlaeute/events{/privacy}","received_events_url":"https://api.github.com/users/umlaeute/received_events","type":"User","site_admin":false},"repo":{"id":51378407,"name":"JUCE","full_name":"umlaeute/JUCE","owner":{"login":"umlaeute","id":214034,"avatar_url":"https://avatars.githubusercontent.com/u/214034?v=3","gravatar_id":"","url":"https://api.github.com/users/umlaeute","html_url":"https://github.com/umlaeute","followers_url":"https://api.github.com/users/umlaeute/followers","following_url":"https://api.github.com/users/umlaeute/following{/other_user}","gists_url":"https://api.github.com/users/umlaeute/gists{/gist_id}","starred_url":"https://api.github.com/users/umlaeute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umlaeute/subscriptions","organizations_url":"https://api.github.com/users/umlaeute/orgs","repos_url":"https://api.github.com/users/umlaeute/repos","events_url":"https://api.github.com/users/umlaeute/events{/privacy}","received_events_url":"https://api.github.com/users/umlaeute/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/umlaeute/JUCE","description":"The JUCE cross-platform C++ framework.","fork":true,"url":"https://api.github.com/repos/umlaeute/JUCE","forks_url":"https://api.github.com/repos/umlaeute/JUCE/forks","keys_url":"https://api.github.com/repos/umlaeute/JUCE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umlaeute/JUCE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umlaeute/JUCE/teams","hooks_url":"https://api.github.com/repos/umlaeute/JUCE/hooks","issue_events_url":"https://api.github.com/repos/umlaeute/JUCE/issues/events{/number}","events_url":"https://api.github.com/repos/umlaeute/JUCE/events","assignees_url":"https://api.github.com/repos/umlaeute/JUCE/assignees{/user}","branches_url":"https://api.github.com/repos/umlaeute/JUCE/branches{/branch}","tags_url":"https://api.github.com/repos/umlaeute/JUCE/tags","blobs_url":"https://api.github.com/repos/umlaeute/JUCE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umlaeute/JUCE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umlaeute/JUCE/git/refs{/sha}","trees_url":"https://api.github.com/repos/umlaeute/JUCE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umlaeute/JUCE/statuses/{sha}","languages_url":"https://api.github.com/repos/umlaeute/JUCE/languages","stargazers_url":"https://api.github.com/repos/umlaeute/JUCE/stargazers","contributors_url":"https://api.github.com/repos/umlaeute/JUCE/contributors","subscribers_url":"https://api.github.com/repos/umlaeute/JUCE/subscribers","subscription_url":"https://api.github.com/repos/umlaeute/JUCE/subscription","commits_url":"https://api.github.com/repos/umlaeute/JUCE/commits{/sha}","git_commits_url":"https://api.github.com/repos/umlaeute/JUCE/git/commits{/sha}","comments_url":"https://api.github.com/repos/umlaeute/JUCE/comments{/number}","issue_comment_url":"https://api.github.com/repos/umlaeute/JUCE/issues/comments{/number}","contents_url":"https://api.github.com/repos/umlaeute/JUCE/contents/{+path}","compare_url":"https://api.github.com/repos/umlaeute/JUCE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umlaeute/JUCE/merges","archive_url":"https://api.github.com/repos/umlaeute/JUCE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umlaeute/JUCE/downloads","issues_url":"https://api.github.com/repos/umlaeute/JUCE/issues{/number}","pulls_url":"https://api.github.com/repos/umlaeute/JUCE/pulls{/number}","milestones_url":"https://api.github.com/repos/umlaeute/JUCE/milestones{/number}","notifications_url":"https://api.github.com/repos/umlaeute/JUCE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umlaeute/JUCE/labels{/name}","releases_url":"https://api.github.com/repos/umlaeute/JUCE/releases{/id}","deployments_url":"https://api.github.com/repos/umlaeute/JUCE/deployments","created_at":"2016-02-09T16:10:14Z","updated_at":"2016-02-09T16:10:24Z","pushed_at":"2016-11-07T13:34:59Z","git_url":"git://github.com/umlaeute/JUCE.git","ssh_url":"git@github.com:umlaeute/JUCE.git","clone_url":"https://github.com/umlaeute/JUCE.git","svn_url":"https://github.com/umlaeute/JUCE","homepage":"www.juce.com","size":166018,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"julianstorer:master","ref":"master","sha":"169b5ede01cd407c8726f66475050c90dc4b8a16","user":{"login":"julianstorer","id":249953,"avatar_url":"https://avatars.githubusercontent.com/u/249953?v=3","gravatar_id":"","url":"https://api.github.com/users/julianstorer","html_url":"https://github.com/julianstorer","followers_url":"https://api.github.com/users/julianstorer/followers","following_url":"https://api.github.com/users/julianstorer/following{/other_user}","gists_url":"https://api.github.com/users/julianstorer/gists{/gist_id}","starred_url":"https://api.github.com/users/julianstorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianstorer/subscriptions","organizations_url":"https://api.github.com/users/julianstorer/orgs","repos_url":"https://api.github.com/users/julianstorer/repos","events_url":"https://api.github.com/users/julianstorer/events{/privacy}","received_events_url":"https://api.github.com/users/julianstorer/received_events","type":"User","site_admin":false},"repo":{"id":3884981,"name":"JUCE","full_name":"julianstorer/JUCE","owner":{"login":"julianstorer","id":249953,"avatar_url":"https://avatars.githubusercontent.com/u/249953?v=3","gravatar_id":"","url":"https://api.github.com/users/julianstorer","html_url":"https://github.com/julianstorer","followers_url":"https://api.github.com/users/julianstorer/followers","following_url":"https://api.github.com/users/julianstorer/following{/other_user}","gists_url":"https://api.github.com/users/julianstorer/gists{/gist_id}","starred_url":"https://api.github.com/users/julianstorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianstorer/subscriptions","organizations_url":"https://api.github.com/users/julianstorer/orgs","repos_url":"https://api.github.com/users/julianstorer/repos","events_url":"https://api.github.com/users/julianstorer/events{/privacy}","received_events_url":"https://api.github.com/users/julianstorer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julianstorer/JUCE","description":"The JUCE cross-platform C++ framework.","fork":false,"url":"https://api.github.com/repos/julianstorer/JUCE","forks_url":"https://api.github.com/repos/julianstorer/JUCE/forks","keys_url":"https://api.github.com/repos/julianstorer/JUCE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julianstorer/JUCE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julianstorer/JUCE/teams","hooks_url":"https://api.github.com/repos/julianstorer/JUCE/hooks","issue_events_url":"https://api.github.com/repos/julianstorer/JUCE/issues/events{/number}","events_url":"https://api.github.com/repos/julianstorer/JUCE/events","assignees_url":"https://api.github.com/repos/julianstorer/JUCE/assignees{/user}","branches_url":"https://api.github.com/repos/julianstorer/JUCE/branches{/branch}","tags_url":"https://api.github.com/repos/julianstorer/JUCE/tags","blobs_url":"https://api.github.com/repos/julianstorer/JUCE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julianstorer/JUCE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julianstorer/JUCE/git/refs{/sha}","trees_url":"https://api.github.com/repos/julianstorer/JUCE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julianstorer/JUCE/statuses/{sha}","languages_url":"https://api.github.com/repos/julianstorer/JUCE/languages","stargazers_url":"https://api.github.com/repos/julianstorer/JUCE/stargazers","contributors_url":"https://api.github.com/repos/julianstorer/JUCE/contributors","subscribers_url":"https://api.github.com/repos/julianstorer/JUCE/subscribers","subscription_url":"https://api.github.com/repos/julianstorer/JUCE/subscription","commits_url":"https://api.github.com/repos/julianstorer/JUCE/commits{/sha}","git_commits_url":"https://api.github.com/repos/julianstorer/JUCE/git/commits{/sha}","comments_url":"https://api.github.com/repos/julianstorer/JUCE/comments{/number}","issue_comment_url":"https://api.github.com/repos/julianstorer/JUCE/issues/comments{/number}","contents_url":"https://api.github.com/repos/julianstorer/JUCE/contents/{+path}","compare_url":"https://api.github.com/repos/julianstorer/JUCE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julianstorer/JUCE/merges","archive_url":"https://api.github.com/repos/julianstorer/JUCE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julianstorer/JUCE/downloads","issues_url":"https://api.github.com/repos/julianstorer/JUCE/issues{/number}","pulls_url":"https://api.github.com/repos/julianstorer/JUCE/pulls{/number}","milestones_url":"https://api.github.com/repos/julianstorer/JUCE/milestones{/number}","notifications_url":"https://api.github.com/repos/julianstorer/JUCE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julianstorer/JUCE/labels{/name}","releases_url":"https://api.github.com/repos/julianstorer/JUCE/releases{/id}","deployments_url":"https://api.github.com/repos/julianstorer/JUCE/deployments","created_at":"2012-03-31T11:19:43Z","updated_at":"2016-12-18T23:42:15Z","pushed_at":"2016-12-19T12:28:37Z","git_url":"git://github.com/julianstorer/JUCE.git","ssh_url":"git@github.com:julianstorer/JUCE.git","clone_url":"https://github.com/julianstorer/JUCE.git","svn_url":"https://github.com/julianstorer/JUCE","homepage":"www.juce.com","size":168546,"stargazers_count":553,"watchers_count":553,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":373,"mirror_url":null,"open_issues_count":28,"forks":373,"open_issues":28,"watchers":553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/julianstorer/JUCE/pulls/124"},"html":{"href":"https://github.com/julianstorer/JUCE/pull/124"},"issue":{"href":"https://api.github.com/repos/julianstorer/JUCE/issues/124"},"comments":{"href":"https://api.github.com/repos/julianstorer/JUCE/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/julianstorer/JUCE/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/julianstorer/JUCE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/julianstorer/JUCE/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/julianstorer/JUCE/statuses/cc744948ffd739d845806f1650763d93d53a25fb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":5,"additions":42,"deletions":14,"changed_files":5}}
{"actor":{"display_login":"hogliux"}}