{"push_id":1142293984,"size":9,"distinct_size":9,"ref":"refs/heads/master","head":"409506933ab0ef4c69707a80f78539593218b4d8","before":"3e87b4858f8839ddd19afe43732db097dfb64246","commits":[{"sha":"b0677aa29410e0f902879bf85fd3638e3ab988ad","author":{"name":"Justin Stoller","email":"0712ea314b2d9aa98e9a06fb9318e8d900638d2d@gmail.com"},"message":"Revert \"Revert \"(PUP-3827) Return errors matching schema from indirected routes\"\"\n\nThis reverts commit 60764d23e46107a89a646b1c31844a1ed8764430.","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/b0677aa29410e0f902879bf85fd3638e3ab988ad"},{"sha":"03535e6dd2f1dc57adcd8f2aec19eee296a3eab2","author":{"name":"Justin Stoller","email":"0712ea314b2d9aa98e9a06fb9318e8d900638d2d@gmail.com"},"message":"(PUP-3827) Throw proper HTTP errors from indirected routes\n\nPreviously we threw ArgumentErrors when we received a malformed request\nfor the IndirectedRoutes class. This conflated an error in calling a\nRuby method and an error by the consumer calling an api endpoint, and\nconsequently always returned 400 statuses for internal errors.\n\nAs part of PUP-3827, higher level middleware now handles the response\nformatting for errors. The higher level middleware, however, makes the\ndistinction between ArgumentErrors to Ruby functions and BadRequests to\nthe API endpoint (and expects throwers to as well).\n\nSince IndirectedRoutes did not make this distinction all invalid\nenvironment requests were then being treated as ServerErrors, and\nreturning 500 statuses.\n\nThis patch updates IndirectedRoutes to throw proper HTTPErrors instead\nof ArguemntErrors when a client has submitted a BadRequest, used a\nMethodNotAllowed, or the environment is NotFound.","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/03535e6dd2f1dc57adcd8f2aec19eee296a3eab2"},{"sha":"741d776f06be9f4c53e6de59919f2d6504885ccb","author":{"name":"Justin Stoller","email":"0712ea314b2d9aa98e9a06fb9318e8d900638d2d@gmail.com"},"message":"(PUP-3827) Update acceptance tests","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/741d776f06be9f4c53e6de59919f2d6504885ccb"},{"sha":"b91ac0865ba6839cdb516542dd931f3001912dc6","author":{"name":"Justin Stoller","email":"0712ea314b2d9aa98e9a06fb9318e8d900638d2d@gmail.com"},"message":"(PUP-3827) Ensure indirector face properly handles JSON serialized API errors","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/b91ac0865ba6839cdb516542dd931f3001912dc6"},{"sha":"7e6ea4aa61aa43f5483b5e7920f5457522e5acca","author":{"name":"Henrik Lindberg","email":"84c6afaba0f0b7074a7a49470da8211284cb60c2@puppetlabs.com"},"message":"(PUP-6279) Fix problem with method call to the 'type' function\n\nBefore this it was not possible to call the type function using\nmethod call syntax.\n\nThis was caused by 'type' also being a keyword and a grammar rule was\nmissing for the method call rule.","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/7e6ea4aa61aa43f5483b5e7920f5457522e5acca"},{"sha":"534356e3749bf6a6573c47e7ce9665fcffc76874","author":{"name":"Peter Huene","email":"fe2b3a17333aca0a8dfc49d853070549245e8321@protonmail.com"},"message":"Merge pull request #5000 from hlindberg/PUP-6279_postfix-type-call\n\n(PUP-6279) Fix problem with method call to the 'type' function","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/534356e3749bf6a6573c47e7ce9665fcffc76874"},{"sha":"d037b1acb2bece316b265bd21566baa23ca02824","author":{"name":"Kylo Ginsberg","email":"79d41944aa6f15234b5d4145c5fba17c391a77cc@puppet.com"},"message":"Merge pull request #4957 from justinstoller/PUP-3827-this-time-with-feeling\n\n(PUP-3827) Return errors matching schema from indirected routes","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/d037b1acb2bece316b265bd21566baa23ca02824"},{"sha":"eb1e95e57f95eaae0f1c8c3a47da0ceb4cadba2a","author":{"name":"Will Hopper","email":"35e0797305765f2bc6cee3d871f29d2a24ca376f@puppetlabs.com"},"message":"(maint) Update version to 4.5.2","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/eb1e95e57f95eaae0f1c8c3a47da0ceb4cadba2a"},{"sha":"409506933ab0ef4c69707a80f78539593218b4d8","author":{"name":"Will Hopper","email":"35e0797305765f2bc6cee3d871f29d2a24ca376f@puppetlabs.com"},"message":"Merge branch 'stable'\n\n* stable:\n  (maint) Update version to 4.5.2\n  (PUP-6279) Fix problem with method call to the 'type' function","distinct":true,"url":"https://api.github.com/repos/rlugojr/puppet/commits/409506933ab0ef4c69707a80f78539593218b4d8"}]}
{"actor":{"display_login":"rlugojr"}}