{"action":"opened","number":91,"pull_request":{"url":"https://api.github.com/repos/goldibex/targaryen/pulls/91","id":96010618,"html_url":"https://github.com/goldibex/targaryen/pull/91","diff_url":"https://github.com/goldibex/targaryen/pull/91.diff","patch_url":"https://github.com/goldibex/targaryen/pull/91.patch","issue_url":"https://api.github.com/repos/goldibex/targaryen/issues/91","number":91,"state":"open","locked":false,"title":"Refactor rule parser","user":{"login":"dinoboff","id":6830,"avatar_url":"https://avatars.githubusercontent.com/u/6830?v=3","gravatar_id":"","url":"https://api.github.com/users/dinoboff","html_url":"https://github.com/dinoboff","followers_url":"https://api.github.com/users/dinoboff/followers","following_url":"https://api.github.com/users/dinoboff/following{/other_user}","gists_url":"https://api.github.com/users/dinoboff/gists{/gist_id}","starred_url":"https://api.github.com/users/dinoboff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinoboff/subscriptions","organizations_url":"https://api.github.com/users/dinoboff/orgs","repos_url":"https://api.github.com/users/dinoboff/repos","events_url":"https://api.github.com/users/dinoboff/events{/privacy}","received_events_url":"https://api.github.com/users/dinoboff/received_events","type":"User","site_admin":false},"body":"All type inferring was grouped in \"scope.js\" and most evaluation code was grouped in \"rule.js\". Now that type inferring is some times delayed until runtime evaluation, it doesn't make sense to separate them; they have been merged.\r\n\r\nThe parser code have been split by expression type instead; it would have been too long in one script.\r\n\r\nTo update the parser/evaluator rules against Firebase specs, it also a script to record rule parsing and evaluation on Firebase. Each rule get deployed; it then attempt to read a path that will trigger the rule evaluation and save the result. If the result is false it will insure it didn't evaluate to false because of a runtime error.\r\n\r\nFix #89 #63","created_at":"2016-12-01T01:40:43Z","updated_at":"2016-12-01T01:40:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/goldibex/targaryen/milestones/3","html_url":"https://github.com/goldibex/targaryen/milestones/3.0","labels_url":"https://api.github.com/repos/goldibex/targaryen/milestones/3/labels","id":2088670,"number":3,"title":"3.0","description":"","creator":{"login":"dinoboff","id":6830,"avatar_url":"https://avatars.githubusercontent.com/u/6830?v=3","gravatar_id":"","url":"https://api.github.com/users/dinoboff","html_url":"https://github.com/dinoboff","followers_url":"https://api.github.com/users/dinoboff/followers","following_url":"https://api.github.com/users/dinoboff/following{/other_user}","gists_url":"https://api.github.com/users/dinoboff/gists{/gist_id}","starred_url":"https://api.github.com/users/dinoboff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinoboff/subscriptions","organizations_url":"https://api.github.com/users/dinoboff/orgs","repos_url":"https://api.github.com/users/dinoboff/repos","events_url":"https://api.github.com/users/dinoboff/events{/privacy}","received_events_url":"https://api.github.com/users/dinoboff/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":11,"state":"open","created_at":"2016-10-24T10:31:28Z","updated_at":"2016-12-01T01:40:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/goldibex/targaryen/pulls/91/commits","review_comments_url":"https://api.github.com/repos/goldibex/targaryen/pulls/91/comments","review_comment_url":"https://api.github.com/repos/goldibex/targaryen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goldibex/targaryen/issues/91/comments","statuses_url":"https://api.github.com/repos/goldibex/targaryen/statuses/e1a382b691efd301e0ff2858d80df384970caa94","head":{"label":"dinoboff:refactor-parser","ref":"refactor-parser","sha":"e1a382b691efd301e0ff2858d80df384970caa94","user":{"login":"dinoboff","id":6830,"avatar_url":"https://avatars.githubusercontent.com/u/6830?v=3","gravatar_id":"","url":"https://api.github.com/users/dinoboff","html_url":"https://github.com/dinoboff","followers_url":"https://api.github.com/users/dinoboff/followers","following_url":"https://api.github.com/users/dinoboff/following{/other_user}","gists_url":"https://api.github.com/users/dinoboff/gists{/gist_id}","starred_url":"https://api.github.com/users/dinoboff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinoboff/subscriptions","organizations_url":"https://api.github.com/users/dinoboff/orgs","repos_url":"https://api.github.com/users/dinoboff/repos","events_url":"https://api.github.com/users/dinoboff/events{/privacy}","received_events_url":"https://api.github.com/users/dinoboff/received_events","type":"User","site_admin":false},"repo":{"id":64474640,"name":"targaryen","full_name":"dinoboff/targaryen","owner":{"login":"dinoboff","id":6830,"avatar_url":"https://avatars.githubusercontent.com/u/6830?v=3","gravatar_id":"","url":"https://api.github.com/users/dinoboff","html_url":"https://github.com/dinoboff","followers_url":"https://api.github.com/users/dinoboff/followers","following_url":"https://api.github.com/users/dinoboff/following{/other_user}","gists_url":"https://api.github.com/users/dinoboff/gists{/gist_id}","starred_url":"https://api.github.com/users/dinoboff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinoboff/subscriptions","organizations_url":"https://api.github.com/users/dinoboff/orgs","repos_url":"https://api.github.com/users/dinoboff/repos","events_url":"https://api.github.com/users/dinoboff/events{/privacy}","received_events_url":"https://api.github.com/users/dinoboff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dinoboff/targaryen","description":"Test Firebase security rules without connecting to Firebase.","fork":true,"url":"https://api.github.com/repos/dinoboff/targaryen","forks_url":"https://api.github.com/repos/dinoboff/targaryen/forks","keys_url":"https://api.github.com/repos/dinoboff/targaryen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dinoboff/targaryen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dinoboff/targaryen/teams","hooks_url":"https://api.github.com/repos/dinoboff/targaryen/hooks","issue_events_url":"https://api.github.com/repos/dinoboff/targaryen/issues/events{/number}","events_url":"https://api.github.com/repos/dinoboff/targaryen/events","assignees_url":"https://api.github.com/repos/dinoboff/targaryen/assignees{/user}","branches_url":"https://api.github.com/repos/dinoboff/targaryen/branches{/branch}","tags_url":"https://api.github.com/repos/dinoboff/targaryen/tags","blobs_url":"https://api.github.com/repos/dinoboff/targaryen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dinoboff/targaryen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dinoboff/targaryen/git/refs{/sha}","trees_url":"https://api.github.com/repos/dinoboff/targaryen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dinoboff/targaryen/statuses/{sha}","languages_url":"https://api.github.com/repos/dinoboff/targaryen/languages","stargazers_url":"https://api.github.com/repos/dinoboff/targaryen/stargazers","contributors_url":"https://api.github.com/repos/dinoboff/targaryen/contributors","subscribers_url":"https://api.github.com/repos/dinoboff/targaryen/subscribers","subscription_url":"https://api.github.com/repos/dinoboff/targaryen/subscription","commits_url":"https://api.github.com/repos/dinoboff/targaryen/commits{/sha}","git_commits_url":"https://api.github.com/repos/dinoboff/targaryen/git/commits{/sha}","comments_url":"https://api.github.com/repos/dinoboff/targaryen/comments{/number}","issue_comment_url":"https://api.github.com/repos/dinoboff/targaryen/issues/comments{/number}","contents_url":"https://api.github.com/repos/dinoboff/targaryen/contents/{+path}","compare_url":"https://api.github.com/repos/dinoboff/targaryen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dinoboff/targaryen/merges","archive_url":"https://api.github.com/repos/dinoboff/targaryen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dinoboff/targaryen/downloads","issues_url":"https://api.github.com/repos/dinoboff/targaryen/issues{/number}","pulls_url":"https://api.github.com/repos/dinoboff/targaryen/pulls{/number}","milestones_url":"https://api.github.com/repos/dinoboff/targaryen/milestones{/number}","notifications_url":"https://api.github.com/repos/dinoboff/targaryen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dinoboff/targaryen/labels{/name}","releases_url":"https://api.github.com/repos/dinoboff/targaryen/releases{/id}","deployments_url":"https://api.github.com/repos/dinoboff/targaryen/deployments","created_at":"2016-07-29T11:08:24Z","updated_at":"2016-07-29T11:08:25Z","pushed_at":"2016-12-01T01:29:44Z","git_url":"git://github.com/dinoboff/targaryen.git","ssh_url":"git@github.com:dinoboff/targaryen.git","clone_url":"https://github.com/dinoboff/targaryen.git","svn_url":"https://github.com/dinoboff/targaryen","homepage":null,"size":302,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"goldibex:next","ref":"next","sha":"bf0151af193b2ae2ebb8059340651b3950ab980c","user":{"login":"goldibex","id":179067,"avatar_url":"https://avatars.githubusercontent.com/u/179067?v=3","gravatar_id":"","url":"https://api.github.com/users/goldibex","html_url":"https://github.com/goldibex","followers_url":"https://api.github.com/users/goldibex/followers","following_url":"https://api.github.com/users/goldibex/following{/other_user}","gists_url":"https://api.github.com/users/goldibex/gists{/gist_id}","starred_url":"https://api.github.com/users/goldibex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldibex/subscriptions","organizations_url":"https://api.github.com/users/goldibex/orgs","repos_url":"https://api.github.com/users/goldibex/repos","events_url":"https://api.github.com/users/goldibex/events{/privacy}","received_events_url":"https://api.github.com/users/goldibex/received_events","type":"User","site_admin":false},"repo":{"id":28493986,"name":"targaryen","full_name":"goldibex/targaryen","owner":{"login":"goldibex","id":179067,"avatar_url":"https://avatars.githubusercontent.com/u/179067?v=3","gravatar_id":"","url":"https://api.github.com/users/goldibex","html_url":"https://github.com/goldibex","followers_url":"https://api.github.com/users/goldibex/followers","following_url":"https://api.github.com/users/goldibex/following{/other_user}","gists_url":"https://api.github.com/users/goldibex/gists{/gist_id}","starred_url":"https://api.github.com/users/goldibex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldibex/subscriptions","organizations_url":"https://api.github.com/users/goldibex/orgs","repos_url":"https://api.github.com/users/goldibex/repos","events_url":"https://api.github.com/users/goldibex/events{/privacy}","received_events_url":"https://api.github.com/users/goldibex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goldibex/targaryen","description":"Test Firebase security rules without connecting to Firebase.","fork":false,"url":"https://api.github.com/repos/goldibex/targaryen","forks_url":"https://api.github.com/repos/goldibex/targaryen/forks","keys_url":"https://api.github.com/repos/goldibex/targaryen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goldibex/targaryen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goldibex/targaryen/teams","hooks_url":"https://api.github.com/repos/goldibex/targaryen/hooks","issue_events_url":"https://api.github.com/repos/goldibex/targaryen/issues/events{/number}","events_url":"https://api.github.com/repos/goldibex/targaryen/events","assignees_url":"https://api.github.com/repos/goldibex/targaryen/assignees{/user}","branches_url":"https://api.github.com/repos/goldibex/targaryen/branches{/branch}","tags_url":"https://api.github.com/repos/goldibex/targaryen/tags","blobs_url":"https://api.github.com/repos/goldibex/targaryen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goldibex/targaryen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goldibex/targaryen/git/refs{/sha}","trees_url":"https://api.github.com/repos/goldibex/targaryen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goldibex/targaryen/statuses/{sha}","languages_url":"https://api.github.com/repos/goldibex/targaryen/languages","stargazers_url":"https://api.github.com/repos/goldibex/targaryen/stargazers","contributors_url":"https://api.github.com/repos/goldibex/targaryen/contributors","subscribers_url":"https://api.github.com/repos/goldibex/targaryen/subscribers","subscription_url":"https://api.github.com/repos/goldibex/targaryen/subscription","commits_url":"https://api.github.com/repos/goldibex/targaryen/commits{/sha}","git_commits_url":"https://api.github.com/repos/goldibex/targaryen/git/commits{/sha}","comments_url":"https://api.github.com/repos/goldibex/targaryen/comments{/number}","issue_comment_url":"https://api.github.com/repos/goldibex/targaryen/issues/comments{/number}","contents_url":"https://api.github.com/repos/goldibex/targaryen/contents/{+path}","compare_url":"https://api.github.com/repos/goldibex/targaryen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goldibex/targaryen/merges","archive_url":"https://api.github.com/repos/goldibex/targaryen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goldibex/targaryen/downloads","issues_url":"https://api.github.com/repos/goldibex/targaryen/issues{/number}","pulls_url":"https://api.github.com/repos/goldibex/targaryen/pulls{/number}","milestones_url":"https://api.github.com/repos/goldibex/targaryen/milestones{/number}","notifications_url":"https://api.github.com/repos/goldibex/targaryen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goldibex/targaryen/labels{/name}","releases_url":"https://api.github.com/repos/goldibex/targaryen/releases{/id}","deployments_url":"https://api.github.com/repos/goldibex/targaryen/deployments","created_at":"2014-12-25T23:50:20Z","updated_at":"2016-11-20T23:21:21Z","pushed_at":"2016-12-01T01:40:43Z","git_url":"git://github.com/goldibex/targaryen.git","ssh_url":"git@github.com:goldibex/targaryen.git","clone_url":"https://github.com/goldibex/targaryen.git","svn_url":"https://github.com/goldibex/targaryen","homepage":null,"size":320,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":12,"forks":25,"open_issues":12,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goldibex/targaryen/pulls/91"},"html":{"href":"https://github.com/goldibex/targaryen/pull/91"},"issue":{"href":"https://api.github.com/repos/goldibex/targaryen/issues/91"},"comments":{"href":"https://api.github.com/repos/goldibex/targaryen/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/goldibex/targaryen/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/goldibex/targaryen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goldibex/targaryen/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/goldibex/targaryen/statuses/e1a382b691efd301e0ff2858d80df384970caa94"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":2827,"deletions":1096,"changed_files":29}}
{"actor":{"display_login":"dinoboff"}}