{"action":"closed","number":46,"pull_request":{"url":"https://api.github.com/repos/ublaboo/datagrid/pulls/46","id":58161016,"html_url":"https://github.com/ublaboo/datagrid/pull/46","diff_url":"https://github.com/ublaboo/datagrid/pull/46.diff","patch_url":"https://github.com/ublaboo/datagrid/pull/46.patch","issue_url":"https://api.github.com/repos/ublaboo/datagrid/issues/46","number":46,"state":"closed","locked":false,"title":"Sortable - renamed parameter 'id' to 'item_id'","user":{"login":"DavidZadrazil","id":1330026,"avatar_url":"https://avatars.githubusercontent.com/u/1330026?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidZadrazil","html_url":"https://github.com/DavidZadrazil","followers_url":"https://api.github.com/users/DavidZadrazil/followers","following_url":"https://api.github.com/users/DavidZadrazil/following{/other_user}","gists_url":"https://api.github.com/users/DavidZadrazil/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidZadrazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidZadrazil/subscriptions","organizations_url":"https://api.github.com/users/DavidZadrazil/orgs","repos_url":"https://api.github.com/users/DavidZadrazil/repos","events_url":"https://api.github.com/users/DavidZadrazil/events{/privacy}","received_events_url":"https://api.github.com/users/DavidZadrazil/received_events","type":"User","site_admin":false},"body":"When you have for example renderDetail($id) and you are recieving GET parameter $id from that render method, signal handleSort($id, ...) does not work right. So I renamed **id** parameter in JS files to **item_id**. \r\n\r\nPrecompile standalone.min.js is needed.","created_at":"2016-02-03T16:21:30Z","updated_at":"2016-02-03T16:29:52Z","closed_at":"2016-02-03T16:29:52Z","merged_at":"2016-02-03T16:29:52Z","merge_commit_sha":"c78a45ef618a8283f18fb18f30e88ad7813dc8ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ublaboo/datagrid/pulls/46/commits","review_comments_url":"https://api.github.com/repos/ublaboo/datagrid/pulls/46/comments","review_comment_url":"https://api.github.com/repos/ublaboo/datagrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ublaboo/datagrid/issues/46/comments","statuses_url":"https://api.github.com/repos/ublaboo/datagrid/statuses/bf2c0e7f072c805793e905fa60e6c308fb7dd6c2","head":{"label":"DavidZadrazil:sorting-parameters","ref":"sorting-parameters","sha":"bf2c0e7f072c805793e905fa60e6c308fb7dd6c2","user":{"login":"DavidZadrazil","id":1330026,"avatar_url":"https://avatars.githubusercontent.com/u/1330026?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidZadrazil","html_url":"https://github.com/DavidZadrazil","followers_url":"https://api.github.com/users/DavidZadrazil/followers","following_url":"https://api.github.com/users/DavidZadrazil/following{/other_user}","gists_url":"https://api.github.com/users/DavidZadrazil/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidZadrazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidZadrazil/subscriptions","organizations_url":"https://api.github.com/users/DavidZadrazil/orgs","repos_url":"https://api.github.com/users/DavidZadrazil/repos","events_url":"https://api.github.com/users/DavidZadrazil/events{/privacy}","received_events_url":"https://api.github.com/users/DavidZadrazil/received_events","type":"User","site_admin":false},"repo":{"id":51011421,"name":"datagrid","full_name":"DavidZadrazil/datagrid","owner":{"login":"DavidZadrazil","id":1330026,"avatar_url":"https://avatars.githubusercontent.com/u/1330026?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidZadrazil","html_url":"https://github.com/DavidZadrazil","followers_url":"https://api.github.com/users/DavidZadrazil/followers","following_url":"https://api.github.com/users/DavidZadrazil/following{/other_user}","gists_url":"https://api.github.com/users/DavidZadrazil/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidZadrazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidZadrazil/subscriptions","organizations_url":"https://api.github.com/users/DavidZadrazil/orgs","repos_url":"https://api.github.com/users/DavidZadrazil/repos","events_url":"https://api.github.com/users/DavidZadrazil/events{/privacy}","received_events_url":"https://api.github.com/users/DavidZadrazil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavidZadrazil/datagrid","description":"DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc","fork":true,"url":"https://api.github.com/repos/DavidZadrazil/datagrid","forks_url":"https://api.github.com/repos/DavidZadrazil/datagrid/forks","keys_url":"https://api.github.com/repos/DavidZadrazil/datagrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidZadrazil/datagrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidZadrazil/datagrid/teams","hooks_url":"https://api.github.com/repos/DavidZadrazil/datagrid/hooks","issue_events_url":"https://api.github.com/repos/DavidZadrazil/datagrid/issues/events{/number}","events_url":"https://api.github.com/repos/DavidZadrazil/datagrid/events","assignees_url":"https://api.github.com/repos/DavidZadrazil/datagrid/assignees{/user}","branches_url":"https://api.github.com/repos/DavidZadrazil/datagrid/branches{/branch}","tags_url":"https://api.github.com/repos/DavidZadrazil/datagrid/tags","blobs_url":"https://api.github.com/repos/DavidZadrazil/datagrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidZadrazil/datagrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidZadrazil/datagrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidZadrazil/datagrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidZadrazil/datagrid/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidZadrazil/datagrid/languages","stargazers_url":"https://api.github.com/repos/DavidZadrazil/datagrid/stargazers","contributors_url":"https://api.github.com/repos/DavidZadrazil/datagrid/contributors","subscribers_url":"https://api.github.com/repos/DavidZadrazil/datagrid/subscribers","subscription_url":"https://api.github.com/repos/DavidZadrazil/datagrid/subscription","commits_url":"https://api.github.com/repos/DavidZadrazil/datagrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidZadrazil/datagrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidZadrazil/datagrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidZadrazil/datagrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavidZadrazil/datagrid/contents/{+path}","compare_url":"https://api.github.com/repos/DavidZadrazil/datagrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidZadrazil/datagrid/merges","archive_url":"https://api.github.com/repos/DavidZadrazil/datagrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidZadrazil/datagrid/downloads","issues_url":"https://api.github.com/repos/DavidZadrazil/datagrid/issues{/number}","pulls_url":"https://api.github.com/repos/DavidZadrazil/datagrid/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidZadrazil/datagrid/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidZadrazil/datagrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidZadrazil/datagrid/labels{/name}","releases_url":"https://api.github.com/repos/DavidZadrazil/datagrid/releases{/id}","deployments_url":"https://api.github.com/repos/DavidZadrazil/datagrid/deployments","created_at":"2016-02-03T16:04:46Z","updated_at":"2016-02-03T16:04:47Z","pushed_at":"2016-02-03T16:18:08Z","git_url":"git://github.com/DavidZadrazil/datagrid.git","ssh_url":"git@github.com:DavidZadrazil/datagrid.git","clone_url":"https://github.com/DavidZadrazil/datagrid.git","svn_url":"https://github.com/DavidZadrazil/datagrid","homepage":"http://ublaboo.paveljanda.com/datagrid/","size":316,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ublaboo:master","ref":"master","sha":"7c6e4641711864a1518bbb72ef770d031b2d5638","user":{"login":"ublaboo","id":16239501,"avatar_url":"https://avatars.githubusercontent.com/u/16239501?v=3","gravatar_id":"","url":"https://api.github.com/users/ublaboo","html_url":"https://github.com/ublaboo","followers_url":"https://api.github.com/users/ublaboo/followers","following_url":"https://api.github.com/users/ublaboo/following{/other_user}","gists_url":"https://api.github.com/users/ublaboo/gists{/gist_id}","starred_url":"https://api.github.com/users/ublaboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ublaboo/subscriptions","organizations_url":"https://api.github.com/users/ublaboo/orgs","repos_url":"https://api.github.com/users/ublaboo/repos","events_url":"https://api.github.com/users/ublaboo/events{/privacy}","received_events_url":"https://api.github.com/users/ublaboo/received_events","type":"Organization","site_admin":false},"repo":{"id":47787070,"name":"datagrid","full_name":"ublaboo/datagrid","owner":{"login":"ublaboo","id":16239501,"avatar_url":"https://avatars.githubusercontent.com/u/16239501?v=3","gravatar_id":"","url":"https://api.github.com/users/ublaboo","html_url":"https://github.com/ublaboo","followers_url":"https://api.github.com/users/ublaboo/followers","following_url":"https://api.github.com/users/ublaboo/following{/other_user}","gists_url":"https://api.github.com/users/ublaboo/gists{/gist_id}","starred_url":"https://api.github.com/users/ublaboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ublaboo/subscriptions","organizations_url":"https://api.github.com/users/ublaboo/orgs","repos_url":"https://api.github.com/users/ublaboo/repos","events_url":"https://api.github.com/users/ublaboo/events{/privacy}","received_events_url":"https://api.github.com/users/ublaboo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ublaboo/datagrid","description":"DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc","fork":false,"url":"https://api.github.com/repos/ublaboo/datagrid","forks_url":"https://api.github.com/repos/ublaboo/datagrid/forks","keys_url":"https://api.github.com/repos/ublaboo/datagrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ublaboo/datagrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ublaboo/datagrid/teams","hooks_url":"https://api.github.com/repos/ublaboo/datagrid/hooks","issue_events_url":"https://api.github.com/repos/ublaboo/datagrid/issues/events{/number}","events_url":"https://api.github.com/repos/ublaboo/datagrid/events","assignees_url":"https://api.github.com/repos/ublaboo/datagrid/assignees{/user}","branches_url":"https://api.github.com/repos/ublaboo/datagrid/branches{/branch}","tags_url":"https://api.github.com/repos/ublaboo/datagrid/tags","blobs_url":"https://api.github.com/repos/ublaboo/datagrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ublaboo/datagrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ublaboo/datagrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ublaboo/datagrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ublaboo/datagrid/statuses/{sha}","languages_url":"https://api.github.com/repos/ublaboo/datagrid/languages","stargazers_url":"https://api.github.com/repos/ublaboo/datagrid/stargazers","contributors_url":"https://api.github.com/repos/ublaboo/datagrid/contributors","subscribers_url":"https://api.github.com/repos/ublaboo/datagrid/subscribers","subscription_url":"https://api.github.com/repos/ublaboo/datagrid/subscription","commits_url":"https://api.github.com/repos/ublaboo/datagrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ublaboo/datagrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ublaboo/datagrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ublaboo/datagrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ublaboo/datagrid/contents/{+path}","compare_url":"https://api.github.com/repos/ublaboo/datagrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ublaboo/datagrid/merges","archive_url":"https://api.github.com/repos/ublaboo/datagrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ublaboo/datagrid/downloads","issues_url":"https://api.github.com/repos/ublaboo/datagrid/issues{/number}","pulls_url":"https://api.github.com/repos/ublaboo/datagrid/pulls{/number}","milestones_url":"https://api.github.com/repos/ublaboo/datagrid/milestones{/number}","notifications_url":"https://api.github.com/repos/ublaboo/datagrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ublaboo/datagrid/labels{/name}","releases_url":"https://api.github.com/repos/ublaboo/datagrid/releases{/id}","deployments_url":"https://api.github.com/repos/ublaboo/datagrid/deployments","created_at":"2015-12-10T20:59:02Z","updated_at":"2016-02-02T06:26:54Z","pushed_at":"2016-02-03T16:29:52Z","git_url":"git://github.com/ublaboo/datagrid.git","ssh_url":"git@github.com:ublaboo/datagrid.git","clone_url":"https://github.com/ublaboo/datagrid.git","svn_url":"https://github.com/ublaboo/datagrid","homepage":"http://ublaboo.paveljanda.com/datagrid/","size":316,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ublaboo/datagrid/pulls/46"},"html":{"href":"https://github.com/ublaboo/datagrid/pull/46"},"issue":{"href":"https://api.github.com/repos/ublaboo/datagrid/issues/46"},"comments":{"href":"https://api.github.com/repos/ublaboo/datagrid/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/ublaboo/datagrid/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/ublaboo/datagrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ublaboo/datagrid/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/ublaboo/datagrid/statuses/bf2c0e7f072c805793e905fa60e6c308fb7dd6c2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"paveljanda","id":1488874,"avatar_url":"https://avatars.githubusercontent.com/u/1488874?v=3","gravatar_id":"","url":"https://api.github.com/users/paveljanda","html_url":"https://github.com/paveljanda","followers_url":"https://api.github.com/users/paveljanda/followers","following_url":"https://api.github.com/users/paveljanda/following{/other_user}","gists_url":"https://api.github.com/users/paveljanda/gists{/gist_id}","starred_url":"https://api.github.com/users/paveljanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paveljanda/subscriptions","organizations_url":"https://api.github.com/users/paveljanda/orgs","repos_url":"https://api.github.com/users/paveljanda/repos","events_url":"https://api.github.com/users/paveljanda/events{/privacy}","received_events_url":"https://api.github.com/users/paveljanda/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":13,"changed_files":3}}