{"action":"opened","issue":{"url":"https://api.github.com/repos/ros-planning/moveit_ros/issues/725","repository_url":"https://api.github.com/repos/ros-planning/moveit_ros","labels_url":"https://api.github.com/repos/ros-planning/moveit_ros/issues/725/labels{/name}","comments_url":"https://api.github.com/repos/ros-planning/moveit_ros/issues/725/comments","events_url":"https://api.github.com/repos/ros-planning/moveit_ros/issues/725/events","html_url":"https://github.com/ros-planning/moveit_ros/issues/725","id":166912215,"number":725,"title":"Proposal: Refactor and Rename ControllerManager to ControllerInterface","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-21T20:38:39Z","updated_at":"2016-07-21T20:38:39Z","closed_at":null,"body":"I'd like to continue the discussion started [here](https://github.com/ros-planning/moveit_plugins/pull/20#issuecomment-233427660) about the potential to fix the confusing concept of ControllerManager (CM) to simply ControllerInterface in MoveIt!. Almost all MoveIt! users we know of only use the CM as a pass-through to a lower level controller manager, such as ros_control's [ControllerManager](http://wiki.ros.org/controller_manager). The pass-through is done using @mikeferguson's [moveit_simple_controller_manager](https://github.com/ros-planning/moveit_plugins/tree/jade-devel/moveit_simple_controller_manager) that just sends ROS Actions to different node. \r\n\r\nHowever, the current CM in MoveIt! is not entirely inaptly named because it does in fact have the ability to switch controllers via ``switchControllers()``, ``getActiveControllers()`` [etc](https://github.com/ros-planning/moveit_core/blob/kinetic-devel/controller_manager/include/moveit/controller_manager/controller_manager.h#L167). In order to rename this part of MoveIt!, we would want to strip out those features too. I imagine instead of changing the CM class though, we create a new class along side it and simply deprecate the CM for the next MoveIt! version.\r\n\r\nAs @v4hn pointed out: \"ros_control does its job quite well, so we could give up on that concept within MoveIt entirely\". MoveIt! does suffer from some feature creep, so we could offload this part of MoveIt!\r\n\r\nI'd be very interested in hearing @isucan's opinion on this."}}
{"actor":{"display_login":"davetcoleman"}}