{"action":"created","comment":{"url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/comments/85653267","pull_request_review_id":6358348,"id":85653267,"diff_hunk":"@@ -126,44 +130,51 @@\n         sign_in jobseeker\n       end\n \n-      context \"successful initial résumé upload\" do\n+      context 'successful initial résumé upload' do\n         it 'saves the first resume record' do\n-          expect{ patch :update, id: jobseeker,\n-              job_seeker: FactoryGirl.attributes_for(:job_seeker,\n-                resume: fixture_file_upload('files/Janitor-Resume.doc')) }.\n-            to change(Resume, :count).by(+1)\n-          expect(flash[:notice]).to eq \"Jobseeker was updated successfully.\"\n+          expect do\n+            patch :update,\n+                  id: jobseeker,\n+                  job_seeker: FactoryGirl.attributes_for(:job_seeker,\n+                    resume: fixture_file_upload('files/Janitor-Resume.doc'))\n+          end\n+            .to change(Resume, :count).by(+1)\n+          expect(flash[:notice]).to eq 'Jobseeker was updated successfully.'\n         end\n       end\n \n-      context \"valid attributes without password change\" do \n+      context 'valid attributes without password change' do\n         before(:each) do\n-          FactoryGirl.create(:resume, file_name: 'Janitor-Resume.doc',\n-            file: fixture_file_upload('files/Janitor-Resume.doc'), \n+          FactoryGirl.create(:resume, \n+            file_name: 'Janitor-Resume.doc',\n+            file: fixture_file_upload('files/Janitor-Resume.doc'),\n             job_seeker: jobseeker)\n-          patch :update, id: jobseeker,\n-            job_seeker: FactoryGirl.attributes_for(:job_seeker, \n-              year_of_birth: '1980', first_name: 'John', \n-              last_name: 'Smith', password: '', \n+          patch :update,\n+            id: jobseeker,\n+            job_seeker: FactoryGirl.attributes_for(:job_seeker,\n+              year_of_birth: '1980', first_name: 'John',\n+              last_name: 'Smith', password: '',\n               password_confirmation: '', phone: '780-890-8976',\n-              resume: fixture_file_upload('files/Admin-Assistant-Resume.pdf')).\n-            merge({ :job_seeker_status_id => js_status.id }).\n-            merge({ address_attributes: FactoryGirl.attributes_for(:address, zipcode: '12346') })\n+              resume: fixture_file_upload('files/Admin-Assistant-Resume.pdf'))\n+              .merge(job_seeker_status_id: js_status.id)\n+              .merge(address_attributes: FactoryGirl.attributes_for(:address,\n+                zipcode: '12346'))\n           jobseeker.reload\n         end\n         it 'sets the valid attributes' do\n-          expect(jobseeker.first_name).to eq (\"John\")\n-          expect(jobseeker.last_name).to eq (\"Smith\")\n-          expect(jobseeker.year_of_birth).to eq (\"1980\")\n-          expect(jobseeker.status.id) == (js_status.id)\n+          expect(jobseeker.first_name).to eq 'John'\n+          expect(jobseeker.last_name).to eq 'Smith'\n+          expect(jobseeker.year_of_birth).to eq '1980'\n+          expect(jobseeker.status.id) == js_status.id","path":"spec/controllers/job_seekers_controller_spec.rb","position":265,"original_position":265,"commit_id":"bcf46779eebdfc5168e453e7216762ac4100b986","original_commit_id":"bcf46779eebdfc5168e453e7216762ac4100b986","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Operator == used in void context.","created_at":"2016-10-30T05:05:13Z","updated_at":"2016-10-30T05:05:13Z","html_url":"https://github.com/AgileVentures/MetPlus_PETS/pull/400#discussion_r85653267","pull_request_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/400","_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/comments/85653267"},"html":{"href":"https://github.com/AgileVentures/MetPlus_PETS/pull/400#discussion_r85653267"},"pull_request":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/400"}}},"pull_request":{"url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/400","id":88209577,"html_url":"https://github.com/AgileVentures/MetPlus_PETS/pull/400","diff_url":"https://github.com/AgileVentures/MetPlus_PETS/pull/400.diff","patch_url":"https://github.com/AgileVentures/MetPlus_PETS/pull/400.patch","issue_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/issues/400","number":400,"state":"open","locked":false,"title":"Closes AgileVentures/MetPlus_tracker#440","user":{"login":"jeanwei","id":16623014,"avatar_url":"https://avatars.githubusercontent.com/u/16623014?v=3","gravatar_id":"","url":"https://api.github.com/users/jeanwei","html_url":"https://github.com/jeanwei","followers_url":"https://api.github.com/users/jeanwei/followers","following_url":"https://api.github.com/users/jeanwei/following{/other_user}","gists_url":"https://api.github.com/users/jeanwei/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanwei/subscriptions","organizations_url":"https://api.github.com/users/jeanwei/orgs","repos_url":"https://api.github.com/users/jeanwei/repos","events_url":"https://api.github.com/users/jeanwei/events{/privacy}","received_events_url":"https://api.github.com/users/jeanwei/received_events","type":"User","site_admin":false},"body":"Conflicts:\r\nIn job_seekers_controller.rb, authorize actions consistent with auth matrix\r\n                              auth matrix                         |            current implementation\r\n-  edit / update:     jd + cm + js                       |      cm + js\r\n- destroy:                   js                                  |          aa + js ( there is aa destroy js in feature test)\r\n- applied_job :     moved to job_applications controller\r\n- preview_info:     not include in auth matrix  |    jd\r\n\r\nAction #applied_job is moved to job_applications_controller because it can be reused by jobs_controller when implemented with JobApplicationsViewer (existed). \r\n\r\nQuestion:\r\n1. how should the address behave for job seeker? because currently 'job_seeker belongs_to address' but there is no 'address has_many job_seekers'. it seems that the form will not pop out the address field if the job seeker's address field is empty. refer to job seeker registration form.","created_at":"2016-10-06T07:16:58Z","updated_at":"2016-10-30T05:05:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"333b07851af4cd048300fb5a61a9881e1e51c7f8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/400/commits","review_comments_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/400/comments","review_comment_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/issues/400/comments","statuses_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/statuses/bcf46779eebdfc5168e453e7216762ac4100b986","head":{"label":"jeanwei:authorize-js-controller-#440","ref":"authorize-js-controller-#440","sha":"bcf46779eebdfc5168e453e7216762ac4100b986","user":{"login":"jeanwei","id":16623014,"avatar_url":"https://avatars.githubusercontent.com/u/16623014?v=3","gravatar_id":"","url":"https://api.github.com/users/jeanwei","html_url":"https://github.com/jeanwei","followers_url":"https://api.github.com/users/jeanwei/followers","following_url":"https://api.github.com/users/jeanwei/following{/other_user}","gists_url":"https://api.github.com/users/jeanwei/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanwei/subscriptions","organizations_url":"https://api.github.com/users/jeanwei/orgs","repos_url":"https://api.github.com/users/jeanwei/repos","events_url":"https://api.github.com/users/jeanwei/events{/privacy}","received_events_url":"https://api.github.com/users/jeanwei/received_events","type":"User","site_admin":false},"repo":{"id":63299745,"name":"MetPlus_PETS","full_name":"jeanwei/MetPlus_PETS","owner":{"login":"jeanwei","id":16623014,"avatar_url":"https://avatars.githubusercontent.com/u/16623014?v=3","gravatar_id":"","url":"https://api.github.com/users/jeanwei","html_url":"https://github.com/jeanwei","followers_url":"https://api.github.com/users/jeanwei/followers","following_url":"https://api.github.com/users/jeanwei/following{/other_user}","gists_url":"https://api.github.com/users/jeanwei/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanwei/subscriptions","organizations_url":"https://api.github.com/users/jeanwei/orgs","repos_url":"https://api.github.com/users/jeanwei/repos","events_url":"https://api.github.com/users/jeanwei/events{/privacy}","received_events_url":"https://api.github.com/users/jeanwei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeanwei/MetPlus_PETS","description":"Front End for the MetPlus project","fork":true,"url":"https://api.github.com/repos/jeanwei/MetPlus_PETS","forks_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/forks","keys_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/teams","hooks_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/hooks","issue_events_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/issues/events{/number}","events_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/events","assignees_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/assignees{/user}","branches_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/branches{/branch}","tags_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/tags","blobs_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/statuses/{sha}","languages_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/languages","stargazers_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/stargazers","contributors_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/contributors","subscribers_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/subscribers","subscription_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/subscription","commits_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/contents/{+path}","compare_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/merges","archive_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/downloads","issues_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/issues{/number}","pulls_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/pulls{/number}","milestones_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/milestones{/number}","notifications_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/labels{/name}","releases_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/releases{/id}","deployments_url":"https://api.github.com/repos/jeanwei/MetPlus_PETS/deployments","created_at":"2016-07-14T03:40:51Z","updated_at":"2016-07-14T03:40:52Z","pushed_at":"2016-10-30T05:04:52Z","git_url":"git://github.com/jeanwei/MetPlus_PETS.git","ssh_url":"git@github.com:jeanwei/MetPlus_PETS.git","clone_url":"https://github.com/jeanwei/MetPlus_PETS.git","svn_url":"https://github.com/jeanwei/MetPlus_PETS","homepage":null,"size":2174,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"AgileVentures:development","ref":"development","sha":"957493f2d447c54607dbbbe9f5833b8d7bbefd87","user":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"repo":{"id":41921394,"name":"MetPlus_PETS","full_name":"AgileVentures/MetPlus_PETS","owner":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AgileVentures/MetPlus_PETS","description":"Front End for the MetPlus project","fork":false,"url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS","forks_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/forks","keys_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/teams","hooks_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/hooks","issue_events_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/issues/events{/number}","events_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/events","assignees_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/assignees{/user}","branches_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/branches{/branch}","tags_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/tags","blobs_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/statuses/{sha}","languages_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/languages","stargazers_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/stargazers","contributors_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/contributors","subscribers_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/subscribers","subscription_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/subscription","commits_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/issues/comments{/number}","contents_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/contents/{+path}","compare_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/merges","archive_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/downloads","issues_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/issues{/number}","pulls_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls{/number}","milestones_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/milestones{/number}","notifications_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/labels{/name}","releases_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/releases{/id}","deployments_url":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/deployments","created_at":"2015-09-04T14:51:35Z","updated_at":"2016-10-23T02:06:36Z","pushed_at":"2016-10-30T05:04:52Z","git_url":"git://github.com/AgileVentures/MetPlus_PETS.git","ssh_url":"git@github.com:AgileVentures/MetPlus_PETS.git","clone_url":"https://github.com/AgileVentures/MetPlus_PETS.git","svn_url":"https://github.com/AgileVentures/MetPlus_PETS","homepage":null,"size":2759,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":5,"forks":32,"open_issues":5,"watchers":4,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/400"},"html":{"href":"https://github.com/AgileVentures/MetPlus_PETS/pull/400"},"issue":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/issues/400"},"comments":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/AgileVentures/MetPlus_PETS/statuses/bcf46779eebdfc5168e453e7216762ac4100b986"}}}}
{"actor":{"display_login":"houndci-bot"}}