{"action":"closed","issue":{"url":"https://api.github.com/repos/jtblin/angular-chart.js/issues/440","repository_url":"https://api.github.com/repos/jtblin/angular-chart.js","labels_url":"https://api.github.com/repos/jtblin/angular-chart.js/issues/440/labels{/name}","comments_url":"https://api.github.com/repos/jtblin/angular-chart.js/issues/440/comments","events_url":"https://api.github.com/repos/jtblin/angular-chart.js/issues/440/events","html_url":"https://github.com/jtblin/angular-chart.js/issues/440","id":166387768,"number":440,"title":"Argument 'module' is not a function(For whom might have similar situation like me)","user":{"login":"w4-steve","id":8544969,"avatar_url":"https://avatars.githubusercontent.com/u/8544969?v=3","gravatar_id":"","url":"https://api.github.com/users/w4-steve","html_url":"https://github.com/w4-steve","followers_url":"https://api.github.com/users/w4-steve/followers","following_url":"https://api.github.com/users/w4-steve/following{/other_user}","gists_url":"https://api.github.com/users/w4-steve/gists{/gist_id}","starred_url":"https://api.github.com/users/w4-steve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w4-steve/subscriptions","organizations_url":"https://api.github.com/users/w4-steve/orgs","repos_url":"https://api.github.com/users/w4-steve/repos","events_url":"https://api.github.com/users/w4-steve/events{/privacy}","received_events_url":"https://api.github.com/users/w4-steve/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-19T17:26:29Z","updated_at":"2016-07-19T22:23:22Z","closed_at":"2016-07-19T22:23:22Z","body":"From 1.0.0-beta, when you 'require' module, it exports name directly.\r\nSo if you wrote code like this before with alpha version:\r\n```\r\nangular.module('something', [\r\n  require('angular-chart.js').name,\r\n]);\r\n```\r\nYour code may work well before updating your node packages, but will break in CI or next update.\r\nSo plz make sure remove '.name' and update package.js to 1.0.0\r\nI visited npm every single day to check if it becomes beta, but suddenly it turns to release version :)\r\nThough I woke up since CI was broken(actually it is my fault that I used alpha version in production), I really appreciate the project owner's effort. I hope someday I could distribute even a small code.\r\nThanks!\r\n\r\np.s I am so newbie to open source world and also github, do not know how to write an article for other people. If it is not right place to write, so sorry. But it could be an open issue since you need to announce what module exports from now not like before."}}
{"actor":{"display_login":"jtblin"}}