{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/753","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/753/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/753/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/753/events","html_url":"https://github.com/solidusio/solidus/pull/753","id":129299261,"number":753,"title":"Use attribute translations for country forms","user":{"login":"Murph33","id":12613649,"avatar_url":"https://avatars.githubusercontent.com/u/12613649?v=3","gravatar_id":"","url":"https://api.github.com/users/Murph33","html_url":"https://github.com/Murph33","followers_url":"https://api.github.com/users/Murph33/followers","following_url":"https://api.github.com/users/Murph33/following{/other_user}","gists_url":"https://api.github.com/users/Murph33/gists{/gist_id}","starred_url":"https://api.github.com/users/Murph33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Murph33/subscriptions","organizations_url":"https://api.github.com/users/Murph33/orgs","repos_url":"https://api.github.com/users/Murph33/repos","events_url":"https://api.github.com/users/Murph33/events{/privacy}","received_events_url":"https://api.github.com/users/Murph33/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-27T23:12:53Z","updated_at":"2016-01-28T20:05:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/753","html_url":"https://github.com/solidusio/solidus/pull/753","diff_url":"https://github.com/solidusio/solidus/pull/753.diff","patch_url":"https://github.com/solidusio/solidus/pull/753.patch"},"body":"This is to better utilize I18n with more verbosity to make it clear and easier to translate. \r\n\r\nThis is cherry-picked from #549 with a minor change to a spec that had been written to use an incorrect translation which was also removed (`iso_name: Iso Name`)\r\n\r\nThis is part of an ongoing chain of PRs to implement #549 as discussed in #735.  "},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/176378920","html_url":"https://github.com/solidusio/solidus/pull/753#issuecomment-176378920","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/753","id":176378920,"user":{"login":"tvdeyen","id":42868,"avatar_url":"https://avatars.githubusercontent.com/u/42868?v=3","gravatar_id":"","url":"https://api.github.com/users/tvdeyen","html_url":"https://github.com/tvdeyen","followers_url":"https://api.github.com/users/tvdeyen/followers","following_url":"https://api.github.com/users/tvdeyen/following{/other_user}","gists_url":"https://api.github.com/users/tvdeyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tvdeyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvdeyen/subscriptions","organizations_url":"https://api.github.com/users/tvdeyen/orgs","repos_url":"https://api.github.com/users/tvdeyen/repos","events_url":"https://api.github.com/users/tvdeyen/events{/privacy}","received_events_url":"https://api.github.com/users/tvdeyen/received_events","type":"User","site_admin":false},"created_at":"2016-01-28T20:05:16Z","updated_at":"2016-01-28T20:05:16Z","body":"I totally agree with avoiding computed expectations, **except** for translated strings. Translated strings are just static constants living in other files. Like fixtures. \n\nThe test will break if you change the translation or, happened to me many times, the browser you test against has different locale settings. \n\nI'm fine with leaving it, but you've been warned. \n\nThere is a German saying: \"I've seen horses throw up\" ;)"}}