{"action":"created","comment":{"url":"https://api.github.com/repos/pybind/pybind11/pulls/comments/64571102","id":64571102,"diff_hunk":"@@ -491,7 +491,7 @@ class tuple : public object {\n         if (!m_ptr) pybind11_fail(\"Could not allocate tuple object!\");\n     }\n     size_t size() const { return (size_t) PyTuple_Size(m_ptr); }\n-    detail::tuple_accessor operator[](size_t index) const { return detail::tuple_accessor(ptr(), index); }","path":"include/pybind11/pytypes.h","position":4,"original_position":4,"commit_id":"114bfeb762e623330b3f1efa9d53b090782e7765","original_commit_id":"114bfeb762e623330b3f1efa9d53b090782e7765","user":{"login":"wjakob","id":1203629,"avatar_url":"https://avatars.githubusercontent.com/u/1203629?v=3","gravatar_id":"","url":"https://api.github.com/users/wjakob","html_url":"https://github.com/wjakob","followers_url":"https://api.github.com/users/wjakob/followers","following_url":"https://api.github.com/users/wjakob/following{/other_user}","gists_url":"https://api.github.com/users/wjakob/gists{/gist_id}","starred_url":"https://api.github.com/users/wjakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjakob/subscriptions","organizations_url":"https://api.github.com/users/wjakob/orgs","repos_url":"https://api.github.com/users/wjakob/repos","events_url":"https://api.github.com/users/wjakob/events{/privacy}","received_events_url":"https://api.github.com/users/wjakob/received_events","type":"User","site_admin":false},"body":"Is this line needed?","created_at":"2016-05-25T13:24:59Z","updated_at":"2016-05-25T13:24:59Z","html_url":"https://github.com/pybind/pybind11/pull/213#discussion_r64571102","pull_request_url":"https://api.github.com/repos/pybind/pybind11/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/comments/64571102"},"html":{"href":"https://github.com/pybind/pybind11/pull/213#discussion_r64571102"},"pull_request":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/pybind/pybind11/pulls/213","id":71390005,"html_url":"https://github.com/pybind/pybind11/pull/213","diff_url":"https://github.com/pybind/pybind11/pull/213.diff","patch_url":"https://github.com/pybind/pybind11/pull/213.patch","issue_url":"https://api.github.com/repos/pybind/pybind11/issues/213","number":213,"state":"open","locked":false,"title":"pybind11::args should have been derived from tuple","user":{"login":"yungyuc","id":399122,"avatar_url":"https://avatars.githubusercontent.com/u/399122?v=3","gravatar_id":"","url":"https://api.github.com/users/yungyuc","html_url":"https://github.com/yungyuc","followers_url":"https://api.github.com/users/yungyuc/followers","following_url":"https://api.github.com/users/yungyuc/following{/other_user}","gists_url":"https://api.github.com/users/yungyuc/gists{/gist_id}","starred_url":"https://api.github.com/users/yungyuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungyuc/subscriptions","organizations_url":"https://api.github.com/users/yungyuc/orgs","repos_url":"https://api.github.com/users/yungyuc/repos","events_url":"https://api.github.com/users/yungyuc/events{/privacy}","received_events_url":"https://api.github.com/users/yungyuc/received_events","type":"User","site_admin":false},"body":"args was derived from list, but cpp_function::dispatcher sends a tuple to it->impl (line [#346](https://github.com/pybind/pybind11/blob/1e3be73a521d6c888e09e554b8a239ce28fbf5a8/include/pybind11/pybind11.h#L346) and [#392](https://github.com/pybind/pybind11/blob/1e3be73a521d6c888e09e554b8a239ce28fbf5a8/include/pybind11/pybind11.h#L392) in pybind11.h).  As a result args::size() and args::operator[] don't work at all.  On my mac args::size() returns -1.  Making args a subclass of tuple fixes it.","created_at":"2016-05-25T13:23:13Z","updated_at":"2016-05-25T13:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c3d669f3642063e3616754d761b2aff06de591","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pybind/pybind11/pulls/213/commits","review_comments_url":"https://api.github.com/repos/pybind/pybind11/pulls/213/comments","review_comment_url":"https://api.github.com/repos/pybind/pybind11/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pybind/pybind11/issues/213/comments","statuses_url":"https://api.github.com/repos/pybind/pybind11/statuses/114bfeb762e623330b3f1efa9d53b090782e7765","head":{"label":"yungyuc:yyc-args","ref":"yyc-args","sha":"114bfeb762e623330b3f1efa9d53b090782e7765","user":{"login":"yungyuc","id":399122,"avatar_url":"https://avatars.githubusercontent.com/u/399122?v=3","gravatar_id":"","url":"https://api.github.com/users/yungyuc","html_url":"https://github.com/yungyuc","followers_url":"https://api.github.com/users/yungyuc/followers","following_url":"https://api.github.com/users/yungyuc/following{/other_user}","gists_url":"https://api.github.com/users/yungyuc/gists{/gist_id}","starred_url":"https://api.github.com/users/yungyuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungyuc/subscriptions","organizations_url":"https://api.github.com/users/yungyuc/orgs","repos_url":"https://api.github.com/users/yungyuc/repos","events_url":"https://api.github.com/users/yungyuc/events{/privacy}","received_events_url":"https://api.github.com/users/yungyuc/received_events","type":"User","site_admin":false},"repo":{"id":59664594,"name":"pybind11","full_name":"yungyuc/pybind11","owner":{"login":"yungyuc","id":399122,"avatar_url":"https://avatars.githubusercontent.com/u/399122?v=3","gravatar_id":"","url":"https://api.github.com/users/yungyuc","html_url":"https://github.com/yungyuc","followers_url":"https://api.github.com/users/yungyuc/followers","following_url":"https://api.github.com/users/yungyuc/following{/other_user}","gists_url":"https://api.github.com/users/yungyuc/gists{/gist_id}","starred_url":"https://api.github.com/users/yungyuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungyuc/subscriptions","organizations_url":"https://api.github.com/users/yungyuc/orgs","repos_url":"https://api.github.com/users/yungyuc/repos","events_url":"https://api.github.com/users/yungyuc/events{/privacy}","received_events_url":"https://api.github.com/users/yungyuc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yungyuc/pybind11","description":"Seamless operability between C++11 and Python","fork":true,"url":"https://api.github.com/repos/yungyuc/pybind11","forks_url":"https://api.github.com/repos/yungyuc/pybind11/forks","keys_url":"https://api.github.com/repos/yungyuc/pybind11/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yungyuc/pybind11/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yungyuc/pybind11/teams","hooks_url":"https://api.github.com/repos/yungyuc/pybind11/hooks","issue_events_url":"https://api.github.com/repos/yungyuc/pybind11/issues/events{/number}","events_url":"https://api.github.com/repos/yungyuc/pybind11/events","assignees_url":"https://api.github.com/repos/yungyuc/pybind11/assignees{/user}","branches_url":"https://api.github.com/repos/yungyuc/pybind11/branches{/branch}","tags_url":"https://api.github.com/repos/yungyuc/pybind11/tags","blobs_url":"https://api.github.com/repos/yungyuc/pybind11/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yungyuc/pybind11/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yungyuc/pybind11/git/refs{/sha}","trees_url":"https://api.github.com/repos/yungyuc/pybind11/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yungyuc/pybind11/statuses/{sha}","languages_url":"https://api.github.com/repos/yungyuc/pybind11/languages","stargazers_url":"https://api.github.com/repos/yungyuc/pybind11/stargazers","contributors_url":"https://api.github.com/repos/yungyuc/pybind11/contributors","subscribers_url":"https://api.github.com/repos/yungyuc/pybind11/subscribers","subscription_url":"https://api.github.com/repos/yungyuc/pybind11/subscription","commits_url":"https://api.github.com/repos/yungyuc/pybind11/commits{/sha}","git_commits_url":"https://api.github.com/repos/yungyuc/pybind11/git/commits{/sha}","comments_url":"https://api.github.com/repos/yungyuc/pybind11/comments{/number}","issue_comment_url":"https://api.github.com/repos/yungyuc/pybind11/issues/comments{/number}","contents_url":"https://api.github.com/repos/yungyuc/pybind11/contents/{+path}","compare_url":"https://api.github.com/repos/yungyuc/pybind11/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yungyuc/pybind11/merges","archive_url":"https://api.github.com/repos/yungyuc/pybind11/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yungyuc/pybind11/downloads","issues_url":"https://api.github.com/repos/yungyuc/pybind11/issues{/number}","pulls_url":"https://api.github.com/repos/yungyuc/pybind11/pulls{/number}","milestones_url":"https://api.github.com/repos/yungyuc/pybind11/milestones{/number}","notifications_url":"https://api.github.com/repos/yungyuc/pybind11/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yungyuc/pybind11/labels{/name}","releases_url":"https://api.github.com/repos/yungyuc/pybind11/releases{/id}","deployments_url":"https://api.github.com/repos/yungyuc/pybind11/deployments","created_at":"2016-05-25T13:17:13Z","updated_at":"2016-05-25T13:17:14Z","pushed_at":"2016-05-25T13:17:50Z","git_url":"git://github.com/yungyuc/pybind11.git","ssh_url":"git@github.com:yungyuc/pybind11.git","clone_url":"https://github.com/yungyuc/pybind11.git","svn_url":"https://github.com/yungyuc/pybind11","homepage":null,"size":910,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pybind:master","ref":"master","sha":"1e3be73a521d6c888e09e554b8a239ce28fbf5a8","user":{"login":"pybind","id":17565521,"avatar_url":"https://avatars.githubusercontent.com/u/17565521?v=3","gravatar_id":"","url":"https://api.github.com/users/pybind","html_url":"https://github.com/pybind","followers_url":"https://api.github.com/users/pybind/followers","following_url":"https://api.github.com/users/pybind/following{/other_user}","gists_url":"https://api.github.com/users/pybind/gists{/gist_id}","starred_url":"https://api.github.com/users/pybind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybind/subscriptions","organizations_url":"https://api.github.com/users/pybind/orgs","repos_url":"https://api.github.com/users/pybind/repos","events_url":"https://api.github.com/users/pybind/events{/privacy}","received_events_url":"https://api.github.com/users/pybind/received_events","type":"Organization","site_admin":false},"repo":{"id":38581626,"name":"pybind11","full_name":"pybind/pybind11","owner":{"login":"pybind","id":17565521,"avatar_url":"https://avatars.githubusercontent.com/u/17565521?v=3","gravatar_id":"","url":"https://api.github.com/users/pybind","html_url":"https://github.com/pybind","followers_url":"https://api.github.com/users/pybind/followers","following_url":"https://api.github.com/users/pybind/following{/other_user}","gists_url":"https://api.github.com/users/pybind/gists{/gist_id}","starred_url":"https://api.github.com/users/pybind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybind/subscriptions","organizations_url":"https://api.github.com/users/pybind/orgs","repos_url":"https://api.github.com/users/pybind/repos","events_url":"https://api.github.com/users/pybind/events{/privacy}","received_events_url":"https://api.github.com/users/pybind/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pybind/pybind11","description":"Seamless operability between C++11 and Python","fork":false,"url":"https://api.github.com/repos/pybind/pybind11","forks_url":"https://api.github.com/repos/pybind/pybind11/forks","keys_url":"https://api.github.com/repos/pybind/pybind11/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pybind/pybind11/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pybind/pybind11/teams","hooks_url":"https://api.github.com/repos/pybind/pybind11/hooks","issue_events_url":"https://api.github.com/repos/pybind/pybind11/issues/events{/number}","events_url":"https://api.github.com/repos/pybind/pybind11/events","assignees_url":"https://api.github.com/repos/pybind/pybind11/assignees{/user}","branches_url":"https://api.github.com/repos/pybind/pybind11/branches{/branch}","tags_url":"https://api.github.com/repos/pybind/pybind11/tags","blobs_url":"https://api.github.com/repos/pybind/pybind11/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pybind/pybind11/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pybind/pybind11/git/refs{/sha}","trees_url":"https://api.github.com/repos/pybind/pybind11/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pybind/pybind11/statuses/{sha}","languages_url":"https://api.github.com/repos/pybind/pybind11/languages","stargazers_url":"https://api.github.com/repos/pybind/pybind11/stargazers","contributors_url":"https://api.github.com/repos/pybind/pybind11/contributors","subscribers_url":"https://api.github.com/repos/pybind/pybind11/subscribers","subscription_url":"https://api.github.com/repos/pybind/pybind11/subscription","commits_url":"https://api.github.com/repos/pybind/pybind11/commits{/sha}","git_commits_url":"https://api.github.com/repos/pybind/pybind11/git/commits{/sha}","comments_url":"https://api.github.com/repos/pybind/pybind11/comments{/number}","issue_comment_url":"https://api.github.com/repos/pybind/pybind11/issues/comments{/number}","contents_url":"https://api.github.com/repos/pybind/pybind11/contents/{+path}","compare_url":"https://api.github.com/repos/pybind/pybind11/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pybind/pybind11/merges","archive_url":"https://api.github.com/repos/pybind/pybind11/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pybind/pybind11/downloads","issues_url":"https://api.github.com/repos/pybind/pybind11/issues{/number}","pulls_url":"https://api.github.com/repos/pybind/pybind11/pulls{/number}","milestones_url":"https://api.github.com/repos/pybind/pybind11/milestones{/number}","notifications_url":"https://api.github.com/repos/pybind/pybind11/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pybind/pybind11/labels{/name}","releases_url":"https://api.github.com/repos/pybind/pybind11/releases{/id}","deployments_url":"https://api.github.com/repos/pybind/pybind11/deployments","created_at":"2015-07-05T19:46:48Z","updated_at":"2016-05-25T07:55:07Z","pushed_at":"2016-05-25T13:23:14Z","git_url":"git://github.com/pybind/pybind11.git","ssh_url":"git@github.com:pybind/pybind11.git","clone_url":"https://github.com/pybind/pybind11.git","svn_url":"https://github.com/pybind/pybind11","homepage":null,"size":1387,"stargazers_count":1293,"watchers_count":1293,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":4,"forks":105,"open_issues":4,"watchers":1293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/213"},"html":{"href":"https://github.com/pybind/pybind11/pull/213"},"issue":{"href":"https://api.github.com/repos/pybind/pybind11/issues/213"},"comments":{"href":"https://api.github.com/repos/pybind/pybind11/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/pybind/pybind11/statuses/114bfeb762e623330b3f1efa9d53b090782e7765"}}}}
{"actor":{"display_login":"wjakob"}}