{"action":"created","comment":{"url":"https://api.github.com/repos/acquia/df/pulls/comments/64931406","id":64931406,"diff_hunk":"@@ -88,7 +88,6 @@\n         \"drupal/migrate_tools\": \"8.2.0-beta1\",\n         \"drupal/oauth\": \"8.1.x-dev\",\n         \"drupal/page_manager\": \"8.1.0-alpha23\",\n-        \"drupal/panels\": \"8.3.x-dev\",","path":"composer.json","position":12,"original_position":4,"commit_id":"3c1468e26c2dc984031ffea57a46903e2b9f8dfb","original_commit_id":"e82fbc2b7760146a021ca853e8716fcac9527441","user":{"login":"balsama","id":1536654,"avatar_url":"https://avatars.githubusercontent.com/u/1536654?v=3","gravatar_id":"","url":"https://api.github.com/users/balsama","html_url":"https://github.com/balsama","followers_url":"https://api.github.com/users/balsama/followers","following_url":"https://api.github.com/users/balsama/following{/other_user}","gists_url":"https://api.github.com/users/balsama/gists{/gist_id}","starred_url":"https://api.github.com/users/balsama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balsama/subscriptions","organizations_url":"https://api.github.com/users/balsama/orgs","repos_url":"https://api.github.com/users/balsama/repos","events_url":"https://api.github.com/users/balsama/events{/privacy}","received_events_url":"https://api.github.com/users/balsama/received_events","type":"User","site_admin":false},"body":"Yeah - and it was in conflict with the tag that Lightning uses.\r\n\r\nI think it's best practice to declare your dependencies as well though to avoid surprises. So this should probably be:\r\n\r\n    - \"drupal/panels\": \"8.3.x-dev\",\r\n    + \"drupal/panels\": \"8.3.0-beta4\",\r\n\r\nIf there's something in head that DF needs, we can patch it in the extras section.","created_at":"2016-05-27T16:28:22Z","updated_at":"2016-05-27T16:28:22Z","html_url":"https://github.com/acquia/df/pull/11#discussion_r64931406","pull_request_url":"https://api.github.com/repos/acquia/df/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/acquia/df/pulls/comments/64931406"},"html":{"href":"https://github.com/acquia/df/pull/11#discussion_r64931406"},"pull_request":{"href":"https://api.github.com/repos/acquia/df/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/acquia/df/pulls/11","id":71282502,"html_url":"https://github.com/acquia/df/pull/11","diff_url":"https://github.com/acquia/df/pull/11.diff","patch_url":"https://github.com/acquia/df/pull/11.patch","issue_url":"https://api.github.com/repos/acquia/df/issues/11","number":11,"state":"open","locked":false,"title":"8.x lightning","user":{"login":"balsama","id":1536654,"avatar_url":"https://avatars.githubusercontent.com/u/1536654?v=3","gravatar_id":"","url":"https://api.github.com/users/balsama","html_url":"https://github.com/balsama","followers_url":"https://api.github.com/users/balsama/followers","following_url":"https://api.github.com/users/balsama/following{/other_user}","gists_url":"https://api.github.com/users/balsama/gists{/gist_id}","starred_url":"https://api.github.com/users/balsama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balsama/subscriptions","organizations_url":"https://api.github.com/users/balsama/orgs","repos_url":"https://api.github.com/users/balsama/repos","events_url":"https://api.github.com/users/balsama/events{/privacy}","received_events_url":"https://api.github.com/users/balsama/received_events","type":"User","site_admin":false},"body":"I made the following changes to make DF play nice enough with lightning to install lightning and run through the behat tests (behat tests for DF are obviously failing because DF isn't actually installed, but I honestly don't think we're that far off). I'm not sure if you'll want to blindly merge this, but there should be some good info in what changed:\r\n\r\n- added composer.lock to VCS\r\n- ignored the core and profiles directories\r\n- Removed panels and IEF as dependencies because Lightning provides them and the versions conflicted. (If there's something you need in HEAD it should be easy to patch those modules)\r\n- removed composer_manager as a dependency of df_admin\r\n\r\nYou can get a version of this here: https://github.com/balsama/lightning_and_df\r\n\r\nTravis: https://travis-ci.org/balsama/lightning_and_df/builds/132656323","created_at":"2016-05-24T19:56:44Z","updated_at":"2016-05-27T16:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ca3364aa0ef058a0f0fe4d16047af9a43bd320c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/acquia/df/pulls/11/commits","review_comments_url":"https://api.github.com/repos/acquia/df/pulls/11/comments","review_comment_url":"https://api.github.com/repos/acquia/df/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquia/df/issues/11/comments","statuses_url":"https://api.github.com/repos/acquia/df/statuses/3c1468e26c2dc984031ffea57a46903e2b9f8dfb","head":{"label":"balsama:8.x-lightning","ref":"8.x-lightning","sha":"3c1468e26c2dc984031ffea57a46903e2b9f8dfb","user":{"login":"balsama","id":1536654,"avatar_url":"https://avatars.githubusercontent.com/u/1536654?v=3","gravatar_id":"","url":"https://api.github.com/users/balsama","html_url":"https://github.com/balsama","followers_url":"https://api.github.com/users/balsama/followers","following_url":"https://api.github.com/users/balsama/following{/other_user}","gists_url":"https://api.github.com/users/balsama/gists{/gist_id}","starred_url":"https://api.github.com/users/balsama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balsama/subscriptions","organizations_url":"https://api.github.com/users/balsama/orgs","repos_url":"https://api.github.com/users/balsama/repos","events_url":"https://api.github.com/users/balsama/events{/privacy}","received_events_url":"https://api.github.com/users/balsama/received_events","type":"User","site_admin":false},"repo":{"id":59582341,"name":"df","full_name":"balsama/df","owner":{"login":"balsama","id":1536654,"avatar_url":"https://avatars.githubusercontent.com/u/1536654?v=3","gravatar_id":"","url":"https://api.github.com/users/balsama","html_url":"https://github.com/balsama","followers_url":"https://api.github.com/users/balsama/followers","following_url":"https://api.github.com/users/balsama/following{/other_user}","gists_url":"https://api.github.com/users/balsama/gists{/gist_id}","starred_url":"https://api.github.com/users/balsama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balsama/subscriptions","organizations_url":"https://api.github.com/users/balsama/orgs","repos_url":"https://api.github.com/users/balsama/repos","events_url":"https://api.github.com/users/balsama/events{/privacy}","received_events_url":"https://api.github.com/users/balsama/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/balsama/df","description":"Mirror of https://git.drupal.org/project/df.git","fork":true,"url":"https://api.github.com/repos/balsama/df","forks_url":"https://api.github.com/repos/balsama/df/forks","keys_url":"https://api.github.com/repos/balsama/df/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balsama/df/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balsama/df/teams","hooks_url":"https://api.github.com/repos/balsama/df/hooks","issue_events_url":"https://api.github.com/repos/balsama/df/issues/events{/number}","events_url":"https://api.github.com/repos/balsama/df/events","assignees_url":"https://api.github.com/repos/balsama/df/assignees{/user}","branches_url":"https://api.github.com/repos/balsama/df/branches{/branch}","tags_url":"https://api.github.com/repos/balsama/df/tags","blobs_url":"https://api.github.com/repos/balsama/df/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balsama/df/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balsama/df/git/refs{/sha}","trees_url":"https://api.github.com/repos/balsama/df/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balsama/df/statuses/{sha}","languages_url":"https://api.github.com/repos/balsama/df/languages","stargazers_url":"https://api.github.com/repos/balsama/df/stargazers","contributors_url":"https://api.github.com/repos/balsama/df/contributors","subscribers_url":"https://api.github.com/repos/balsama/df/subscribers","subscription_url":"https://api.github.com/repos/balsama/df/subscription","commits_url":"https://api.github.com/repos/balsama/df/commits{/sha}","git_commits_url":"https://api.github.com/repos/balsama/df/git/commits{/sha}","comments_url":"https://api.github.com/repos/balsama/df/comments{/number}","issue_comment_url":"https://api.github.com/repos/balsama/df/issues/comments{/number}","contents_url":"https://api.github.com/repos/balsama/df/contents/{+path}","compare_url":"https://api.github.com/repos/balsama/df/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balsama/df/merges","archive_url":"https://api.github.com/repos/balsama/df/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balsama/df/downloads","issues_url":"https://api.github.com/repos/balsama/df/issues{/number}","pulls_url":"https://api.github.com/repos/balsama/df/pulls{/number}","milestones_url":"https://api.github.com/repos/balsama/df/milestones{/number}","notifications_url":"https://api.github.com/repos/balsama/df/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balsama/df/labels{/name}","releases_url":"https://api.github.com/repos/balsama/df/releases{/id}","deployments_url":"https://api.github.com/repos/balsama/df/deployments","created_at":"2016-05-24T14:53:07Z","updated_at":"2016-05-24T14:53:09Z","pushed_at":"2016-05-24T19:31:30Z","git_url":"git://github.com/balsama/df.git","ssh_url":"git@github.com:balsama/df.git","clone_url":"https://github.com/balsama/df.git","svn_url":"https://github.com/balsama/df","homepage":"https://www.drupal.org/project/df","size":37872,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"acquia:8.x-lightning","ref":"8.x-lightning","sha":"ab5ba67568b883b421138a8e4fcd51e53efdcc4c","user":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"repo":{"id":52994153,"name":"df","full_name":"acquia/df","owner":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquia/df","description":"Mirror of https://git.drupal.org/project/df.git","fork":false,"url":"https://api.github.com/repos/acquia/df","forks_url":"https://api.github.com/repos/acquia/df/forks","keys_url":"https://api.github.com/repos/acquia/df/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquia/df/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquia/df/teams","hooks_url":"https://api.github.com/repos/acquia/df/hooks","issue_events_url":"https://api.github.com/repos/acquia/df/issues/events{/number}","events_url":"https://api.github.com/repos/acquia/df/events","assignees_url":"https://api.github.com/repos/acquia/df/assignees{/user}","branches_url":"https://api.github.com/repos/acquia/df/branches{/branch}","tags_url":"https://api.github.com/repos/acquia/df/tags","blobs_url":"https://api.github.com/repos/acquia/df/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquia/df/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquia/df/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquia/df/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquia/df/statuses/{sha}","languages_url":"https://api.github.com/repos/acquia/df/languages","stargazers_url":"https://api.github.com/repos/acquia/df/stargazers","contributors_url":"https://api.github.com/repos/acquia/df/contributors","subscribers_url":"https://api.github.com/repos/acquia/df/subscribers","subscription_url":"https://api.github.com/repos/acquia/df/subscription","commits_url":"https://api.github.com/repos/acquia/df/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquia/df/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquia/df/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquia/df/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquia/df/contents/{+path}","compare_url":"https://api.github.com/repos/acquia/df/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquia/df/merges","archive_url":"https://api.github.com/repos/acquia/df/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquia/df/downloads","issues_url":"https://api.github.com/repos/acquia/df/issues{/number}","pulls_url":"https://api.github.com/repos/acquia/df/pulls{/number}","milestones_url":"https://api.github.com/repos/acquia/df/milestones{/number}","notifications_url":"https://api.github.com/repos/acquia/df/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquia/df/labels{/name}","releases_url":"https://api.github.com/repos/acquia/df/releases{/id}","deployments_url":"https://api.github.com/repos/acquia/df/deployments","created_at":"2016-03-02T20:28:22Z","updated_at":"2016-04-13T17:32:36Z","pushed_at":"2016-05-27T15:59:16Z","git_url":"git://github.com/acquia/df.git","ssh_url":"git@github.com:acquia/df.git","clone_url":"https://github.com/acquia/df.git","svn_url":"https://github.com/acquia/df","homepage":"https://www.drupal.org/project/df","size":37773,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":0,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/acquia/df/pulls/11"},"html":{"href":"https://github.com/acquia/df/pull/11"},"issue":{"href":"https://api.github.com/repos/acquia/df/issues/11"},"comments":{"href":"https://api.github.com/repos/acquia/df/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/acquia/df/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/acquia/df/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquia/df/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/acquia/df/statuses/3c1468e26c2dc984031ffea57a46903e2b9f8dfb"}}}}
{"actor":{"display_login":"balsama"}}