{"push_id":1009854001,"size":30,"distinct_size":30,"ref":"refs/heads/master","head":"a0c6ab4bd61a0e801b0850f90d00798f69d86844","before":"4162c69502bfd6e1db2a9d3fb645b535837522fe","commits":[{"sha":"fc0dc02bb92d8d11259cab2a2dbfd68990d1c9ea","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Allow Drydock blueprints to be tagged and searched, and give types some little icons\n\nSummary:\nRef T10457.\n\n  - Let blueprints be tagged so you can search and annotate them a little more easily.\n  - Give each blueprint type an optional icon to make things a little easier to parse visually.\n\nTest Plan:\n  - Tagged blueprints.\n  - Searched by tags.\n  - Looked at nice little icons.\n\n{F1139712}\n\nReviewers: chad\n\nReviewed By: chad\n\nSubscribers: yelirekim\n\nManiphest Tasks: T10457\n\nDifferential Revision: https://secure.phabricator.com/D15392","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/fc0dc02bb92d8d11259cab2a2dbfd68990d1c9ea"},{"sha":"e6158391d27d7c7c04f67e10a81e89b83fb6f05f","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Make Drydock repository operations a little more modern and consistent\n\nSummary: Ref T10457. Use modern controller and UI tech to build the list view and actions.\n\nTest Plan:\n  - Viewed operation list.\n  - Viewed operation detail.\n  - Checked menus on mobile.\n\n{F1139757}\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10457\n\nDifferential Revision: https://secure.phabricator.com/D15393","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/e6158391d27d7c7c04f67e10a81e89b83fb6f05f"},{"sha":"13813d226847cd5bebc3aec2dd21c3975a3c1ed8","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Minor Ponder spacing updates\n\nSummary: Fix an issue where you've already answered, moved the summary section.\n\nTest Plan: Review an answer with a wiki that i've already answered\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15395","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/13813d226847cd5bebc3aec2dd21c3975a3c1ed8"},{"sha":"167da4ec525e27514966aaaa8e5b72cd274487b8","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Move Almanac Services to EditEngine\n\nSummary: Ref T10449. This modernizes the service creation/editing flow and updates the list view code a little bit.\n\nTest Plan:\n  - Created a service.\n  - Edited a service.\n  - Browsed services.\n  - Hit policy exception for editing cluster services with no permission.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10449\n\nDifferential Revision: https://secure.phabricator.com/D15398","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/167da4ec525e27514966aaaa8e5b72cd274487b8"},{"sha":"85bf04ea0292290ad821665436e24d22810d9fae","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Use EditEngine for AlmanacDevice\n\nSummary: Ref T10449. Modernize the AlmanacDevice code a bit.\n\nTest Plan:\n  - Created a device.\n  - Edited a device.\n  - Listed devices.\n  - Viewed a device.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10449\n\nDifferential Revision: https://secure.phabricator.com/D15399","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/85bf04ea0292290ad821665436e24d22810d9fae"},{"sha":"809646c8d2e962bea958fcd7e2b2a70034e947cf","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Unprototype Almanac\n\nSummary: Fixes T10449. Almanac doesn't do a whole lot for the average user, but is in good shape technically and works well, and exposing it in the cluster won't let installs destroy themselves now.\n\nTest Plan: Re-read documentation; grepped for `TODO` (there are a couple, but reasonable to push off); browsed around all the UI things (new two-column looks great), called API methods.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10449\n\nDifferential Revision: https://secure.phabricator.com/D15400","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/809646c8d2e962bea958fcd7e2b2a70034e947cf"},{"sha":"2f14a59b1d818b88afd5ca41da2be0806e27ffa6","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Unprototype Drydock\n\nSummary:\nRef T10246. Drydock still has a few outstanding issues, but it's mostly minor UI stuff and the documentation has reasonable caveats about it.\n\nBroadly, I don't expect to make any major changes to Drydock in the future (i.e., all the fundamentals seem sound at this point) and it doesn't have any major technical debt or, like, obsolete APIs or anything.\n\nTest Plan: Saw \"Drydock\" as not-a-prototype in Applications.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10246\n\nDifferential Revision: https://secure.phabricator.com/D15401","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/2f14a59b1d818b88afd5ca41da2be0806e27ffa6"},{"sha":"2b1ac4fcec820c56decbfdd3228f0a39a03b5bd9","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Update Maniphest for PHUITwoColumnView\n\nSummary: Reworks Maniphest into a two column view. Moves priority and color to header, assignee to sidebar. quest points to header, and author to gutter. may be some confusion since priority only displays on open tickets.\n\nTest Plan: with and without description, custom fields, points, tablet, mobile and desktop.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15396","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/2b1ac4fcec820c56decbfdd3228f0a39a03b5bd9"},{"sha":"fec1a154d54c6af72af0b76c386863e8da6c4826","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Expand scope of addActionItem in PHUIHeaderView\n\nSummary: Gives a bit more flexibility to add anything to the right side of PHUIHeaderView.\n\nTest Plan: Test Maniphest, Workboards, Project Home, Differential. Grep for `addActionIcon` use. Fixes T10518\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nManiphest Tasks: T10518\n\nDifferential Revision: https://secure.phabricator.com/D15402","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/fec1a154d54c6af72af0b76c386863e8da6c4826"},{"sha":"5a43e2040eeb1fa7c9f5006c57fad50aa72a1c23","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Fix header tag on Hovercards\n\nSummary: Switch to new method.\n\nTest Plan: Hover over task, see tag in correct place.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15403","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/5a43e2040eeb1fa7c9f5006c57fad50aa72a1c23"},{"sha":"f6127f5835dae398d691216eec6919049fef8364","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Convert Almanac Binding View to two columns\n\nSummary: Moves over to the new layout. Fixes T10521\n\nTest Plan: Make a binding, view page, add some properties.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nManiphest Tasks: T10521\n\nDifferential Revision: https://secure.phabricator.com/D15404","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/f6127f5835dae398d691216eec6919049fef8364"},{"sha":"010b7811b44fc935ff7bd27a05cf2975caae0ef8","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Convert Applications to two column view\n\nSummary: Converts the meta applications application view layout to two column\n\nTest Plan: click through \"Configure\" on each application, set up some emails. uninstall Phrequent\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15405","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/010b7811b44fc935ff7bd27a05cf2975caae0ef8"},{"sha":"090252a89e2bb1af9b555d13c72867c44f462f2b","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Clean up Macro view page\n\nSummary: Sets a header icon, makes \"Details\" not show if empty, simplifies title.\n\nTest Plan: Review a few Macro pages for changes with and without audio.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15406","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/090252a89e2bb1af9b555d13c72867c44f462f2b"},{"sha":"0569919eab545806c1632a1ab49cde4f91266950","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Fix some visibility issues with inline comments in Diffusion\n\nSummary:\nFixes T10519. Two issues:\n\nFirst, the acting user wasn't explicitly included in the mail. This usually didn't matter, but could matter if you unsubscribed and then interacted.\n\nSecond, we had some logic which tried to hide redundant \"added inline comment\" transactions, but could hide them inappropriately. In particular, if another action (like a subscribe) was present in the same group, we could hide the inlines because of that other transaction, then //also// hide the subscribe. This particular issue is likely an unintended consequence of hiding self-subscribes.\n\nInstead of hiding inlines if //anything else// happened, hide them only if:\n\n  - there is another \"added a comment\" transaction; or\n  - there is another \"added an inline comment\" transaction.\n\nThis prevents the root issue in T10519 (incorrectly hiding every transaction, and thus not sending the mail) and should generally make behavior a little more consistent and future-proof.\n\nTest Plan:\n  - Submitted //only// an inline comment on a commit I had not previously interacted with.\n  - Before patch: no mail was generated (entire mail was improperly hidden).\n  - After patch: got some mail with my comment.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10519\n\nDifferential Revision: https://secure.phabricator.com/D15407","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/0569919eab545806c1632a1ab49cde4f91266950"},{"sha":"6084b7a20160822eaed807e0fc3c13c02cbd61ab","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Update Owners for PHUITwoColumn\n\nSummary: Clean up owners a bit, move to two columns.\n\nTest Plan:\nReview a package, edit paths, remove all paths. Archive.\n\n{F1139351}\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15388","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/6084b7a20160822eaed807e0fc3c13c02cbd61ab"},{"sha":"5a28bff9873930cade73a2498d0356e19c5d64fa","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Fix variable in StandardPageView\n\nSummary: Found this grepping for `contne`\n\nTest Plan: render any standard page\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15411","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/5a28bff9873930cade73a2498d0356e19c5d64fa"},{"sha":"220230e08c8d2416ffe560ade66c4da06724e4de","author":{"email":"c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","name":"Chad Little"},"message":"Fix typo in Phriction contne\n\nSummary: Fix typo in infoview. Fixes T10524\n\nTest Plan: Read.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nManiphest Tasks: T10524\n\nDifferential Revision: https://secure.phabricator.com/D15410","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/220230e08c8d2416ffe560ade66c4da06724e4de"},{"sha":"abb4c03b476d4159ebff62ed44009c0e4fec3be1","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Remove shouldShowSubscribersProperty() from SubscribableInterface\n\nSummary:\nEvery caller returns `true`. This was added a long time ago for Projects, but projects are no longer subscribable.\n\nI don't anticipate needing this in the future.\n\nTest Plan: Grepped for this method.\n\nReviewers: chad\n\nReviewed By: chad\n\nDifferential Revision: https://secure.phabricator.com/D15409","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/abb4c03b476d4159ebff62ed44009c0e4fec3be1"},{"sha":"aaab1011e5a464ea94c182001a7fe867b19bae5a","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Give AphrontTagView a `getViewer()`, deprecate `getUser()`\n\nSummary:\nTwo minor changes here:\n\n  - Replace `get/setUser()` with `get/setViewer()` for consistency with everything else.\n  - `getViewer()` now throws if no viewer is set. We had a lot of code that either \"should\" check this but didn't, or did check it in an identical way, duplicating work. In contrast, very little code checks for a viewer but works if one is not present.\n\nTest Plan:\n  - Grepped for `->user`.\n  - Attempted to fix all callsites inside `*View` classes.\n  - Browsed around a bunch of applications, particularly Calendar, Differential and Diffusion, which seemed most heavily affected.\n\nReviewers: chad\n\nReviewed By: chad\n\nDifferential Revision: https://secure.phabricator.com/D15412","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/aaab1011e5a464ea94c182001a7fe867b19bae5a"},{"sha":"61f82bb97b8a2fe45cdf7628cc1646f07a065671","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Introduce \"Curtain\" views, panels, and extensions\n\nSummary:\nThis opens up the new action column to have specialized rendering and behavior. Briefly:\n\n  - Converted applications (right now, only Paste) render a `CurtainView` to build the column content.\n  - This view uses new extensions to build panels (projects, subscribers, tokens).\n  - The panel extension code and rendering can be changed without breaking old stuff.\n\nMinor changes:\n\n  - Token awards now load their tokens, for consistency/simplicity.\n  - Removed the rest of the \"fork of\" / \"forked from\" UI in Paste -- I essentially removed these features a while ago, and no one has complained.\n\nTest Plan:\nUI is a bit rough, but works, and it's going to get changed now anyway:\n\n{F1160550}\n\n{F1160551}\n\nReviewers: chad\n\nReviewed By: chad\n\nDifferential Revision: https://secure.phabricator.com/D15414","distinct":true,"url":"https://api.github.com/repos/hach-que/phabricator/commits/61f82bb97b8a2fe45cdf7628cc1646f07a065671"}]}