{"action":"created","issue":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1599","repository_url":"https://api.github.com/repos/PointCloudLibrary/pcl","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1599/labels{/name}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1599/comments","events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1599/events","html_url":"https://github.com/PointCloudLibrary/pcl/pull/1599","id":151501388,"number":1599,"title":"Fix reflectivity parameters parsing in loadOBJFile","user":{"login":"SergioRAgostinho","id":1709142,"avatar_url":"https://avatars.githubusercontent.com/u/1709142?v=3","gravatar_id":"","url":"https://api.github.com/users/SergioRAgostinho","html_url":"https://github.com/SergioRAgostinho","followers_url":"https://api.github.com/users/SergioRAgostinho/followers","following_url":"https://api.github.com/users/SergioRAgostinho/following{/other_user}","gists_url":"https://api.github.com/users/SergioRAgostinho/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioRAgostinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioRAgostinho/subscriptions","organizations_url":"https://api.github.com/users/SergioRAgostinho/orgs","repos_url":"https://api.github.com/users/SergioRAgostinho/repos","events_url":"https://api.github.com/users/SergioRAgostinho/events{/privacy}","received_events_url":"https://api.github.com/users/SergioRAgostinho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-27T21:59:55Z","updated_at":"2016-06-21T21:37:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1599","html_url":"https://github.com/PointCloudLibrary/pcl/pull/1599","diff_url":"https://github.com/PointCloudLibrary/pcl/pull/1599.diff","patch_url":"https://github.com/PointCloudLibrary/pcl/pull/1599.patch"},"body":"There was a bug, attempting to make a reassignment to a reference, on the reflectivity parameters parsing stage.\r\nI also added support to the \"Tr\" tag, used by meshlab, which apparently is simply the complement of the \"d\" dissolve parameter."},"comment":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/comments/227580357","html_url":"https://github.com/PointCloudLibrary/pcl/pull/1599#issuecomment-227580357","issue_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1599","id":227580357,"user":{"login":"SergioRAgostinho","id":1709142,"avatar_url":"https://avatars.githubusercontent.com/u/1709142?v=3","gravatar_id":"","url":"https://api.github.com/users/SergioRAgostinho","html_url":"https://github.com/SergioRAgostinho","followers_url":"https://api.github.com/users/SergioRAgostinho/followers","following_url":"https://api.github.com/users/SergioRAgostinho/following{/other_user}","gists_url":"https://api.github.com/users/SergioRAgostinho/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioRAgostinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioRAgostinho/subscriptions","organizations_url":"https://api.github.com/users/SergioRAgostinho/orgs","repos_url":"https://api.github.com/users/SergioRAgostinho/repos","events_url":"https://api.github.com/users/SergioRAgostinho/events{/privacy}","received_events_url":"https://api.github.com/users/SergioRAgostinho/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T21:37:41Z","updated_at":"2016-06-21T21:37:41Z","body":"Just figured out what we were overlooking in our discussion. So notice that in my fix, ```rgb``` is actually a pointer and depending on the material tag, it gets assigned a different address, e.g. to ```tex_Ka```, ```tex_Kd``` or  ```tex_Ks```. Then in  ```fillRGBfromXYZ``` and ```fillRGBfromRGB```, rgb is passed by reference, so I'm actually changing ```tex_Ka```, ```tex_Kd``` or  ```tex_Ks```, respectively. "}}
{"actor":{"display_login":"SergioRAgostinho"}}