{"action":"created","comment":{"url":"https://api.github.com/repos/vperron/systematic/pulls/comments/55696848","id":55696848,"diff_hunk":"@@ -1,20 +1,37 @@\n default: help\n \n PATH := node_modules/.bin:$(PATH)\n+NODE_BINDIR ?= ./node_modules/.bin/\n SHELL ?= /bin/bash -o pipefail\n+SYSTEMATIC_PATH ?= node_modules/systematic\n+\n+CONF_INI ?= systematic.ini\n+READINI ?= $(NODE_BINDIR)readini\n \n export NODE_PATH := $(shell pwd):$(NODE_PATH)\n \n # Customizable variables\n-#\n-IS_APP ?= no\n+\n+BUILD_TYPE ?= $(shell $(READINI) $(CONF_INI) build.type 2> /dev/null)\n+SYSTEMATIC_PROFILE ?= $(shell $(READINI) $(CONF_INI) build.profile 2> /dev/null)\n+PACKAGE ?= $(shell $(READINI) $(CONF_INI) package.name 2> /dev/null)\n+\n+ifeq ($(BUILD_TYPE),)\n+$(error Define a build type in $(CONF_INI))\n+endif\n+ifeq ($(SYSTEMATIC_PROFILE),)\n+$(error Define a build profile in $(SYSTEMATIC_PROFILE))\n+endif\n+ifeq ($(PACKAGE),)\n+$(error Define a package name in $(SYSTEMATIC_PROFILE))\n+endif","path":"mk/js.mk","position":29,"original_position":29,"commit_id":"6311cbb1ce8fa5522b9f4e446f2455319485ba48","original_commit_id":"6311cbb1ce8fa5522b9f4e446f2455319485ba48","user":{"login":"vperron","id":88618,"avatar_url":"https://avatars.githubusercontent.com/u/88618?v=3","gravatar_id":"","url":"https://api.github.com/users/vperron","html_url":"https://github.com/vperron","followers_url":"https://api.github.com/users/vperron/followers","following_url":"https://api.github.com/users/vperron/following{/other_user}","gists_url":"https://api.github.com/users/vperron/gists{/gist_id}","starred_url":"https://api.github.com/users/vperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vperron/subscriptions","organizations_url":"https://api.github.com/users/vperron/orgs","repos_url":"https://api.github.com/users/vperron/repos","events_url":"https://api.github.com/users/vperron/events{/privacy}","received_events_url":"https://api.github.com/users/vperron/received_events","type":"User","site_admin":false},"body":"on est d'accord, mais ça semble good enough pour l'instant.","created_at":"2016-03-10T15:35:24Z","updated_at":"2016-03-10T15:35:24Z","html_url":"https://github.com/vperron/systematic/pull/1#discussion_r55696848","pull_request_url":"https://api.github.com/repos/vperron/systematic/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/vperron/systematic/pulls/comments/55696848"},"html":{"href":"https://github.com/vperron/systematic/pull/1#discussion_r55696848"},"pull_request":{"href":"https://api.github.com/repos/vperron/systematic/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/vperron/systematic/pulls/1","id":61278412,"html_url":"https://github.com/vperron/systematic/pull/1","diff_url":"https://github.com/vperron/systematic/pull/1.diff","patch_url":"https://github.com/vperron/systematic/pull/1.patch","issue_url":"https://api.github.com/repos/vperron/systematic/issues/1","number":1,"state":"open","locked":false,"title":"Improve webpack config","user":{"login":"raphael-boucher","id":3764018,"avatar_url":"https://avatars.githubusercontent.com/u/3764018?v=3","gravatar_id":"","url":"https://api.github.com/users/raphael-boucher","html_url":"https://github.com/raphael-boucher","followers_url":"https://api.github.com/users/raphael-boucher/followers","following_url":"https://api.github.com/users/raphael-boucher/following{/other_user}","gists_url":"https://api.github.com/users/raphael-boucher/gists{/gist_id}","starred_url":"https://api.github.com/users/raphael-boucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphael-boucher/subscriptions","organizations_url":"https://api.github.com/users/raphael-boucher/orgs","repos_url":"https://api.github.com/users/raphael-boucher/repos","events_url":"https://api.github.com/users/raphael-boucher/events{/privacy}","received_events_url":"https://api.github.com/users/raphael-boucher/received_events","type":"User","site_admin":false},"body":"Add sass, jade, angular template loader, html-dist plugin, and ng annotate with angular and react flags","created_at":"2016-03-01T17:32:32Z","updated_at":"2016-03-10T15:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51b19fd5e02fb2f36adb201ee1daad7a97c54397","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vperron/systematic/pulls/1/commits","review_comments_url":"https://api.github.com/repos/vperron/systematic/pulls/1/comments","review_comment_url":"https://api.github.com/repos/vperron/systematic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vperron/systematic/issues/1/comments","statuses_url":"https://api.github.com/repos/vperron/systematic/statuses/6311cbb1ce8fa5522b9f4e446f2455319485ba48","head":{"label":"vperron:rboucher/webpack_config","ref":"rboucher/webpack_config","sha":"6311cbb1ce8fa5522b9f4e446f2455319485ba48","user":{"login":"vperron","id":88618,"avatar_url":"https://avatars.githubusercontent.com/u/88618?v=3","gravatar_id":"","url":"https://api.github.com/users/vperron","html_url":"https://github.com/vperron","followers_url":"https://api.github.com/users/vperron/followers","following_url":"https://api.github.com/users/vperron/following{/other_user}","gists_url":"https://api.github.com/users/vperron/gists{/gist_id}","starred_url":"https://api.github.com/users/vperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vperron/subscriptions","organizations_url":"https://api.github.com/users/vperron/orgs","repos_url":"https://api.github.com/users/vperron/repos","events_url":"https://api.github.com/users/vperron/events{/privacy}","received_events_url":"https://api.github.com/users/vperron/received_events","type":"User","site_admin":false},"repo":{"id":51448901,"name":"systematic","full_name":"vperron/systematic","owner":{"login":"vperron","id":88618,"avatar_url":"https://avatars.githubusercontent.com/u/88618?v=3","gravatar_id":"","url":"https://api.github.com/users/vperron","html_url":"https://github.com/vperron","followers_url":"https://api.github.com/users/vperron/followers","following_url":"https://api.github.com/users/vperron/following{/other_user}","gists_url":"https://api.github.com/users/vperron/gists{/gist_id}","starred_url":"https://api.github.com/users/vperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vperron/subscriptions","organizations_url":"https://api.github.com/users/vperron/orgs","repos_url":"https://api.github.com/users/vperron/repos","events_url":"https://api.github.com/users/vperron/events{/privacy}","received_events_url":"https://api.github.com/users/vperron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vperron/systematic","description":"Just a test.","fork":false,"url":"https://api.github.com/repos/vperron/systematic","forks_url":"https://api.github.com/repos/vperron/systematic/forks","keys_url":"https://api.github.com/repos/vperron/systematic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vperron/systematic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vperron/systematic/teams","hooks_url":"https://api.github.com/repos/vperron/systematic/hooks","issue_events_url":"https://api.github.com/repos/vperron/systematic/issues/events{/number}","events_url":"https://api.github.com/repos/vperron/systematic/events","assignees_url":"https://api.github.com/repos/vperron/systematic/assignees{/user}","branches_url":"https://api.github.com/repos/vperron/systematic/branches{/branch}","tags_url":"https://api.github.com/repos/vperron/systematic/tags","blobs_url":"https://api.github.com/repos/vperron/systematic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vperron/systematic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vperron/systematic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vperron/systematic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vperron/systematic/statuses/{sha}","languages_url":"https://api.github.com/repos/vperron/systematic/languages","stargazers_url":"https://api.github.com/repos/vperron/systematic/stargazers","contributors_url":"https://api.github.com/repos/vperron/systematic/contributors","subscribers_url":"https://api.github.com/repos/vperron/systematic/subscribers","subscription_url":"https://api.github.com/repos/vperron/systematic/subscription","commits_url":"https://api.github.com/repos/vperron/systematic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vperron/systematic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vperron/systematic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vperron/systematic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vperron/systematic/contents/{+path}","compare_url":"https://api.github.com/repos/vperron/systematic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vperron/systematic/merges","archive_url":"https://api.github.com/repos/vperron/systematic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vperron/systematic/downloads","issues_url":"https://api.github.com/repos/vperron/systematic/issues{/number}","pulls_url":"https://api.github.com/repos/vperron/systematic/pulls{/number}","milestones_url":"https://api.github.com/repos/vperron/systematic/milestones{/number}","notifications_url":"https://api.github.com/repos/vperron/systematic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vperron/systematic/labels{/name}","releases_url":"https://api.github.com/repos/vperron/systematic/releases{/id}","deployments_url":"https://api.github.com/repos/vperron/systematic/deployments","created_at":"2016-02-10T15:15:07Z","updated_at":"2016-02-10T15:15:21Z","pushed_at":"2016-03-10T14:59:08Z","git_url":"git://github.com/vperron/systematic.git","ssh_url":"git@github.com:vperron/systematic.git","clone_url":"https://github.com/vperron/systematic.git","svn_url":"https://github.com/vperron/systematic","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vperron:master","ref":"master","sha":"fab31b00da76115fbac07cbf31826fe55502a263","user":{"login":"vperron","id":88618,"avatar_url":"https://avatars.githubusercontent.com/u/88618?v=3","gravatar_id":"","url":"https://api.github.com/users/vperron","html_url":"https://github.com/vperron","followers_url":"https://api.github.com/users/vperron/followers","following_url":"https://api.github.com/users/vperron/following{/other_user}","gists_url":"https://api.github.com/users/vperron/gists{/gist_id}","starred_url":"https://api.github.com/users/vperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vperron/subscriptions","organizations_url":"https://api.github.com/users/vperron/orgs","repos_url":"https://api.github.com/users/vperron/repos","events_url":"https://api.github.com/users/vperron/events{/privacy}","received_events_url":"https://api.github.com/users/vperron/received_events","type":"User","site_admin":false},"repo":{"id":51448901,"name":"systematic","full_name":"vperron/systematic","owner":{"login":"vperron","id":88618,"avatar_url":"https://avatars.githubusercontent.com/u/88618?v=3","gravatar_id":"","url":"https://api.github.com/users/vperron","html_url":"https://github.com/vperron","followers_url":"https://api.github.com/users/vperron/followers","following_url":"https://api.github.com/users/vperron/following{/other_user}","gists_url":"https://api.github.com/users/vperron/gists{/gist_id}","starred_url":"https://api.github.com/users/vperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vperron/subscriptions","organizations_url":"https://api.github.com/users/vperron/orgs","repos_url":"https://api.github.com/users/vperron/repos","events_url":"https://api.github.com/users/vperron/events{/privacy}","received_events_url":"https://api.github.com/users/vperron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vperron/systematic","description":"Just a test.","fork":false,"url":"https://api.github.com/repos/vperron/systematic","forks_url":"https://api.github.com/repos/vperron/systematic/forks","keys_url":"https://api.github.com/repos/vperron/systematic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vperron/systematic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vperron/systematic/teams","hooks_url":"https://api.github.com/repos/vperron/systematic/hooks","issue_events_url":"https://api.github.com/repos/vperron/systematic/issues/events{/number}","events_url":"https://api.github.com/repos/vperron/systematic/events","assignees_url":"https://api.github.com/repos/vperron/systematic/assignees{/user}","branches_url":"https://api.github.com/repos/vperron/systematic/branches{/branch}","tags_url":"https://api.github.com/repos/vperron/systematic/tags","blobs_url":"https://api.github.com/repos/vperron/systematic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vperron/systematic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vperron/systematic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vperron/systematic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vperron/systematic/statuses/{sha}","languages_url":"https://api.github.com/repos/vperron/systematic/languages","stargazers_url":"https://api.github.com/repos/vperron/systematic/stargazers","contributors_url":"https://api.github.com/repos/vperron/systematic/contributors","subscribers_url":"https://api.github.com/repos/vperron/systematic/subscribers","subscription_url":"https://api.github.com/repos/vperron/systematic/subscription","commits_url":"https://api.github.com/repos/vperron/systematic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vperron/systematic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vperron/systematic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vperron/systematic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vperron/systematic/contents/{+path}","compare_url":"https://api.github.com/repos/vperron/systematic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vperron/systematic/merges","archive_url":"https://api.github.com/repos/vperron/systematic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vperron/systematic/downloads","issues_url":"https://api.github.com/repos/vperron/systematic/issues{/number}","pulls_url":"https://api.github.com/repos/vperron/systematic/pulls{/number}","milestones_url":"https://api.github.com/repos/vperron/systematic/milestones{/number}","notifications_url":"https://api.github.com/repos/vperron/systematic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vperron/systematic/labels{/name}","releases_url":"https://api.github.com/repos/vperron/systematic/releases{/id}","deployments_url":"https://api.github.com/repos/vperron/systematic/deployments","created_at":"2016-02-10T15:15:07Z","updated_at":"2016-02-10T15:15:21Z","pushed_at":"2016-03-10T14:59:08Z","git_url":"git://github.com/vperron/systematic.git","ssh_url":"git@github.com:vperron/systematic.git","clone_url":"https://github.com/vperron/systematic.git","svn_url":"https://github.com/vperron/systematic","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vperron/systematic/pulls/1"},"html":{"href":"https://github.com/vperron/systematic/pull/1"},"issue":{"href":"https://api.github.com/repos/vperron/systematic/issues/1"},"comments":{"href":"https://api.github.com/repos/vperron/systematic/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/vperron/systematic/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/vperron/systematic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vperron/systematic/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/vperron/systematic/statuses/6311cbb1ce8fa5522b9f4e446f2455319485ba48"}}}}