{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/67580143","id":67580143,"diff_hunk":"@@ -164,7 +164,10 @@ func (d *Dispatcher) Run(ctx context.Context) error {\n \t\t\t\treturn err\n \t\t\t}\n \t\t\tif err == nil && len(clusters) == 1 {\n-\t\t\t\td.config.HeartbeatPeriod = time.Duration(clusters[0].Spec.Dispatcher.HeartbeatPeriod)\n+\t\t\t\theartbeatPeriod, err := ptypes.Duration(clusters[0].Spec.Dispatcher.HeartbeatPeriod)","path":"manager/dispatcher/dispatcher.go","position":5,"original_position":5,"commit_id":"7fab666d98c5b886a654c213ccf93180551e17dc","original_commit_id":"9bb66e377dac525a22e06aec6d0694030b6377ba","user":{"login":"runshenzhu","id":7114218,"avatar_url":"https://avatars.githubusercontent.com/u/7114218?v=3","gravatar_id":"","url":"https://api.github.com/users/runshenzhu","html_url":"https://github.com/runshenzhu","followers_url":"https://api.github.com/users/runshenzhu/followers","following_url":"https://api.github.com/users/runshenzhu/following{/other_user}","gists_url":"https://api.github.com/users/runshenzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/runshenzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runshenzhu/subscriptions","organizations_url":"https://api.github.com/users/runshenzhu/orgs","repos_url":"https://api.github.com/users/runshenzhu/repos","events_url":"https://api.github.com/users/runshenzhu/events{/privacy}","received_events_url":"https://api.github.com/users/runshenzhu/received_events","type":"User","site_admin":false},"body":"If it's `nil`, `ptypes.Duration` will throw an error.","created_at":"2016-06-17T21:47:07Z","updated_at":"2016-06-17T21:47:07Z","html_url":"https://github.com/docker/swarmkit/pull/1020#discussion_r67580143","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/1020","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/67580143"},"html":{"href":"https://github.com/docker/swarmkit/pull/1020#discussion_r67580143"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1020"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/1020","id":74308901,"html_url":"https://github.com/docker/swarmkit/pull/1020","diff_url":"https://github.com/docker/swarmkit/pull/1020.diff","patch_url":"https://github.com/docker/swarmkit/pull/1020.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/1020","number":1020,"state":"open","locked":false,"title":"dispatcher: change heartbeat time period from uint to duration","user":{"login":"runshenzhu","id":7114218,"avatar_url":"https://avatars.githubusercontent.com/u/7114218?v=3","gravatar_id":"","url":"https://api.github.com/users/runshenzhu","html_url":"https://github.com/runshenzhu","followers_url":"https://api.github.com/users/runshenzhu/followers","following_url":"https://api.github.com/users/runshenzhu/following{/other_user}","gists_url":"https://api.github.com/users/runshenzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/runshenzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runshenzhu/subscriptions","organizations_url":"https://api.github.com/users/runshenzhu/orgs","repos_url":"https://api.github.com/users/runshenzhu/repos","events_url":"https://api.github.com/users/runshenzhu/events{/privacy}","received_events_url":"https://api.github.com/users/runshenzhu/received_events","type":"User","site_admin":false},"body":"fix #1018 \r\nping @stevvooe @aaronlehmann \r\nSigned-off-by: runshenzhu <runshen.zhu@gmail.com>","created_at":"2016-06-17T21:38:49Z","updated_at":"2016-06-17T21:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"445bd37d3b07934f71493083d4b80567299825f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/1020/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/1020/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/1020/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/7fab666d98c5b886a654c213ccf93180551e17dc","head":{"label":"runshenzhu:time-to-duration","ref":"time-to-duration","sha":"7fab666d98c5b886a654c213ccf93180551e17dc","user":{"login":"runshenzhu","id":7114218,"avatar_url":"https://avatars.githubusercontent.com/u/7114218?v=3","gravatar_id":"","url":"https://api.github.com/users/runshenzhu","html_url":"https://github.com/runshenzhu","followers_url":"https://api.github.com/users/runshenzhu/followers","following_url":"https://api.github.com/users/runshenzhu/following{/other_user}","gists_url":"https://api.github.com/users/runshenzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/runshenzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runshenzhu/subscriptions","organizations_url":"https://api.github.com/users/runshenzhu/orgs","repos_url":"https://api.github.com/users/runshenzhu/repos","events_url":"https://api.github.com/users/runshenzhu/events{/privacy}","received_events_url":"https://api.github.com/users/runshenzhu/received_events","type":"User","site_admin":false},"repo":{"id":60800342,"name":"swarmkit","full_name":"runshenzhu/swarmkit","owner":{"login":"runshenzhu","id":7114218,"avatar_url":"https://avatars.githubusercontent.com/u/7114218?v=3","gravatar_id":"","url":"https://api.github.com/users/runshenzhu","html_url":"https://github.com/runshenzhu","followers_url":"https://api.github.com/users/runshenzhu/followers","following_url":"https://api.github.com/users/runshenzhu/following{/other_user}","gists_url":"https://api.github.com/users/runshenzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/runshenzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runshenzhu/subscriptions","organizations_url":"https://api.github.com/users/runshenzhu/orgs","repos_url":"https://api.github.com/users/runshenzhu/repos","events_url":"https://api.github.com/users/runshenzhu/events{/privacy}","received_events_url":"https://api.github.com/users/runshenzhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runshenzhu/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":true,"url":"https://api.github.com/repos/runshenzhu/swarmkit","forks_url":"https://api.github.com/repos/runshenzhu/swarmkit/forks","keys_url":"https://api.github.com/repos/runshenzhu/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runshenzhu/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runshenzhu/swarmkit/teams","hooks_url":"https://api.github.com/repos/runshenzhu/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/runshenzhu/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/runshenzhu/swarmkit/events","assignees_url":"https://api.github.com/repos/runshenzhu/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/runshenzhu/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/runshenzhu/swarmkit/tags","blobs_url":"https://api.github.com/repos/runshenzhu/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runshenzhu/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runshenzhu/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runshenzhu/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runshenzhu/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/runshenzhu/swarmkit/languages","stargazers_url":"https://api.github.com/repos/runshenzhu/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/runshenzhu/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/runshenzhu/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/runshenzhu/swarmkit/subscription","commits_url":"https://api.github.com/repos/runshenzhu/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runshenzhu/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runshenzhu/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runshenzhu/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runshenzhu/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/runshenzhu/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runshenzhu/swarmkit/merges","archive_url":"https://api.github.com/repos/runshenzhu/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runshenzhu/swarmkit/downloads","issues_url":"https://api.github.com/repos/runshenzhu/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/runshenzhu/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/runshenzhu/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/runshenzhu/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runshenzhu/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/runshenzhu/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/runshenzhu/swarmkit/deployments","created_at":"2016-06-09T19:14:11Z","updated_at":"2016-06-09T19:14:13Z","pushed_at":"2016-06-17T21:45:23Z","git_url":"git://github.com/runshenzhu/swarmkit.git","ssh_url":"git@github.com:runshenzhu/swarmkit.git","clone_url":"https://github.com/runshenzhu/swarmkit.git","svn_url":"https://github.com/runshenzhu/swarmkit","homepage":"","size":7804,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"dc1e82a713ad5cfe36cae02ed508f9b1f557cbe4","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"name":"swarmkit","full_name":"docker/swarmkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2016-06-17T16:09:57Z","pushed_at":"2016-06-17T21:46:07Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":17578,"stargazers_count":636,"watchers_count":636,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":123,"forks":80,"open_issues":123,"watchers":636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1020"},"html":{"href":"https://github.com/docker/swarmkit/pull/1020"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1020"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1020/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1020/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1020/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/7fab666d98c5b886a654c213ccf93180551e17dc"}}}}
{"actor":{"display_login":"runshenzhu"}}