{"action":"created","comment":{"url":"https://api.github.com/repos/google/apitools/pulls/comments/64585361","id":64585361,"diff_hunk":"@@ -43,34 +43,43 @@ def testHelp_NotEnoughArguments(self):\n                 self.assertIn('usage:', err_output)\n                 self.assertIn('error: too few arguments', err_output)\n \n-    def testGenClient_SimpleDoc(self):\n+    def _CheckGeneratedFiles(self, api_name):\n         with test_utils.TempDir() as tmp_dir_path:\n             gen_client.main([\n                 gen_client.__file__,\n                 '--generate_cli',\n                 '--init-file', 'empty',\n-                '--infile', GetTestDataPath('dns', 'dns_v1.json'),\n+                '--infile',\n+                GetTestDataPath(api_name, api_name + '_v1.json'),","path":"apitools/gen/gen_client_test.py","position":null,"original_position":13,"commit_id":"6e81406d56799ed2e676c894502433adfe37f8f8","original_commit_id":"61459a77095d537d3f982034164ad17d3e92f6f1","user":{"login":"cherba","id":11074390,"avatar_url":"https://avatars.githubusercontent.com/u/11074390?v=3","gravatar_id":"","url":"https://api.github.com/users/cherba","html_url":"https://github.com/cherba","followers_url":"https://api.github.com/users/cherba/followers","following_url":"https://api.github.com/users/cherba/following{/other_user}","gists_url":"https://api.github.com/users/cherba/gists{/gist_id}","starred_url":"https://api.github.com/users/cherba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherba/subscriptions","organizations_url":"https://api.github.com/users/cherba/orgs","repos_url":"https://api.github.com/users/cherba/repos","events_url":"https://api.github.com/users/cherba/events{/privacy}","received_events_url":"https://api.github.com/users/cherba/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-05-25T14:42:50Z","updated_at":"2016-05-25T14:42:50Z","html_url":"https://github.com/google/apitools/pull/110#discussion_r64585361","pull_request_url":"https://api.github.com/repos/google/apitools/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/google/apitools/pulls/comments/64585361"},"html":{"href":"https://github.com/google/apitools/pull/110#discussion_r64585361"},"pull_request":{"href":"https://api.github.com/repos/google/apitools/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/google/apitools/pulls/110","id":71293375,"html_url":"https://github.com/google/apitools/pull/110","diff_url":"https://github.com/google/apitools/pull/110.diff","patch_url":"https://github.com/google/apitools/pull/110.patch","issue_url":"https://api.github.com/repos/google/apitools/issues/110","number":110,"state":"open","locked":false,"title":"Add generated client test sample with atomic names.","user":{"login":"cherba","id":11074390,"avatar_url":"https://avatars.githubusercontent.com/u/11074390?v=3","gravatar_id":"","url":"https://api.github.com/users/cherba","html_url":"https://github.com/cherba","followers_url":"https://api.github.com/users/cherba/followers","following_url":"https://api.github.com/users/cherba/following{/other_user}","gists_url":"https://api.github.com/users/cherba/gists{/gist_id}","starred_url":"https://api.github.com/users/cherba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherba/subscriptions","organizations_url":"https://api.github.com/users/cherba/orgs","repos_url":"https://api.github.com/users/cherba/repos","events_url":"https://api.github.com/users/cherba/events{/privacy}","received_events_url":"https://api.github.com/users/cherba/received_events","type":"User","site_admin":false},"body":"This discovery doc uses atomic names, which is different from what we have supported so far. By checking in the discovery doc and its generated client, will allow in follow ups to make changes to generation so that names structure is exposed.\r\n","created_at":"2016-05-24T21:11:00Z","updated_at":"2016-05-25T14:42:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88fb4f73f4595fbecb63777d9529e5fed4814cd9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/apitools/pulls/110/commits","review_comments_url":"https://api.github.com/repos/google/apitools/pulls/110/comments","review_comment_url":"https://api.github.com/repos/google/apitools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/apitools/issues/110/comments","statuses_url":"https://api.github.com/repos/google/apitools/statuses/6e81406d56799ed2e676c894502433adfe37f8f8","head":{"label":"cherba:iam_client","ref":"iam_client","sha":"6e81406d56799ed2e676c894502433adfe37f8f8","user":{"login":"cherba","id":11074390,"avatar_url":"https://avatars.githubusercontent.com/u/11074390?v=3","gravatar_id":"","url":"https://api.github.com/users/cherba","html_url":"https://github.com/cherba","followers_url":"https://api.github.com/users/cherba/followers","following_url":"https://api.github.com/users/cherba/following{/other_user}","gists_url":"https://api.github.com/users/cherba/gists{/gist_id}","starred_url":"https://api.github.com/users/cherba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherba/subscriptions","organizations_url":"https://api.github.com/users/cherba/orgs","repos_url":"https://api.github.com/users/cherba/repos","events_url":"https://api.github.com/users/cherba/events{/privacy}","received_events_url":"https://api.github.com/users/cherba/received_events","type":"User","site_admin":false},"repo":{"id":41913231,"name":"apitools","full_name":"cherba/apitools","owner":{"login":"cherba","id":11074390,"avatar_url":"https://avatars.githubusercontent.com/u/11074390?v=3","gravatar_id":"","url":"https://api.github.com/users/cherba","html_url":"https://github.com/cherba","followers_url":"https://api.github.com/users/cherba/followers","following_url":"https://api.github.com/users/cherba/following{/other_user}","gists_url":"https://api.github.com/users/cherba/gists{/gist_id}","starred_url":"https://api.github.com/users/cherba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherba/subscriptions","organizations_url":"https://api.github.com/users/cherba/orgs","repos_url":"https://api.github.com/users/cherba/repos","events_url":"https://api.github.com/users/cherba/events{/privacy}","received_events_url":"https://api.github.com/users/cherba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cherba/apitools","description":null,"fork":true,"url":"https://api.github.com/repos/cherba/apitools","forks_url":"https://api.github.com/repos/cherba/apitools/forks","keys_url":"https://api.github.com/repos/cherba/apitools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cherba/apitools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cherba/apitools/teams","hooks_url":"https://api.github.com/repos/cherba/apitools/hooks","issue_events_url":"https://api.github.com/repos/cherba/apitools/issues/events{/number}","events_url":"https://api.github.com/repos/cherba/apitools/events","assignees_url":"https://api.github.com/repos/cherba/apitools/assignees{/user}","branches_url":"https://api.github.com/repos/cherba/apitools/branches{/branch}","tags_url":"https://api.github.com/repos/cherba/apitools/tags","blobs_url":"https://api.github.com/repos/cherba/apitools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cherba/apitools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cherba/apitools/git/refs{/sha}","trees_url":"https://api.github.com/repos/cherba/apitools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cherba/apitools/statuses/{sha}","languages_url":"https://api.github.com/repos/cherba/apitools/languages","stargazers_url":"https://api.github.com/repos/cherba/apitools/stargazers","contributors_url":"https://api.github.com/repos/cherba/apitools/contributors","subscribers_url":"https://api.github.com/repos/cherba/apitools/subscribers","subscription_url":"https://api.github.com/repos/cherba/apitools/subscription","commits_url":"https://api.github.com/repos/cherba/apitools/commits{/sha}","git_commits_url":"https://api.github.com/repos/cherba/apitools/git/commits{/sha}","comments_url":"https://api.github.com/repos/cherba/apitools/comments{/number}","issue_comment_url":"https://api.github.com/repos/cherba/apitools/issues/comments{/number}","contents_url":"https://api.github.com/repos/cherba/apitools/contents/{+path}","compare_url":"https://api.github.com/repos/cherba/apitools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cherba/apitools/merges","archive_url":"https://api.github.com/repos/cherba/apitools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cherba/apitools/downloads","issues_url":"https://api.github.com/repos/cherba/apitools/issues{/number}","pulls_url":"https://api.github.com/repos/cherba/apitools/pulls{/number}","milestones_url":"https://api.github.com/repos/cherba/apitools/milestones{/number}","notifications_url":"https://api.github.com/repos/cherba/apitools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cherba/apitools/labels{/name}","releases_url":"https://api.github.com/repos/cherba/apitools/releases{/id}","deployments_url":"https://api.github.com/repos/cherba/apitools/deployments","created_at":"2015-09-04T11:55:24Z","updated_at":"2016-04-08T12:19:06Z","pushed_at":"2016-05-25T14:06:51Z","git_url":"git://github.com/cherba/apitools.git","ssh_url":"git@github.com:cherba/apitools.git","clone_url":"https://github.com/cherba/apitools.git","svn_url":"https://github.com/cherba/apitools","homepage":null,"size":880,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"ca041cad239c339e3bdb31219139db2ef7ae65d0","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":30675223,"name":"apitools","full_name":"google/apitools","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/apitools","description":null,"fork":false,"url":"https://api.github.com/repos/google/apitools","forks_url":"https://api.github.com/repos/google/apitools/forks","keys_url":"https://api.github.com/repos/google/apitools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/apitools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/apitools/teams","hooks_url":"https://api.github.com/repos/google/apitools/hooks","issue_events_url":"https://api.github.com/repos/google/apitools/issues/events{/number}","events_url":"https://api.github.com/repos/google/apitools/events","assignees_url":"https://api.github.com/repos/google/apitools/assignees{/user}","branches_url":"https://api.github.com/repos/google/apitools/branches{/branch}","tags_url":"https://api.github.com/repos/google/apitools/tags","blobs_url":"https://api.github.com/repos/google/apitools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/apitools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/apitools/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/apitools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/apitools/statuses/{sha}","languages_url":"https://api.github.com/repos/google/apitools/languages","stargazers_url":"https://api.github.com/repos/google/apitools/stargazers","contributors_url":"https://api.github.com/repos/google/apitools/contributors","subscribers_url":"https://api.github.com/repos/google/apitools/subscribers","subscription_url":"https://api.github.com/repos/google/apitools/subscription","commits_url":"https://api.github.com/repos/google/apitools/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/apitools/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/apitools/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/apitools/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/apitools/contents/{+path}","compare_url":"https://api.github.com/repos/google/apitools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/apitools/merges","archive_url":"https://api.github.com/repos/google/apitools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/apitools/downloads","issues_url":"https://api.github.com/repos/google/apitools/issues{/number}","pulls_url":"https://api.github.com/repos/google/apitools/pulls{/number}","milestones_url":"https://api.github.com/repos/google/apitools/milestones{/number}","notifications_url":"https://api.github.com/repos/google/apitools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/apitools/labels{/name}","releases_url":"https://api.github.com/repos/google/apitools/releases{/id}","deployments_url":"https://api.github.com/repos/google/apitools/deployments","created_at":"2015-02-11T23:27:13Z","updated_at":"2016-05-23T02:37:57Z","pushed_at":"2016-05-25T14:06:52Z","git_url":"git://github.com/google/apitools.git","ssh_url":"git@github.com:google/apitools.git","clone_url":"https://github.com/google/apitools.git","svn_url":"https://github.com/google/apitools","homepage":null,"size":870,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":16,"forks":37,"open_issues":16,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/apitools/pulls/110"},"html":{"href":"https://github.com/google/apitools/pull/110"},"issue":{"href":"https://api.github.com/repos/google/apitools/issues/110"},"comments":{"href":"https://api.github.com/repos/google/apitools/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/google/apitools/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/google/apitools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/apitools/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/google/apitools/statuses/6e81406d56799ed2e676c894502433adfe37f8f8"}}}}
{"actor":{"display_login":"cherba"}}