{"action":"created","comment":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/92305177","pull_request_review_id":12817890,"id":92305177,"diff_hunk":"@@ -1067,7 +1076,9 @@ def add_ca_cert(self, cacert_fname, cacert_name=''):\n         self.stop()\n \n         dirname = config_dirname(installutils.realm_to_serverid(self.realm))\n-        certdb = certs.CertDB(self.realm, nssdir=dirname, subject_base=self.subject_base)\n+        certdb = certs.CertDB(\n+                self.realm, nssdir=dirname,\n+                subject_base=self.subject_base, ca_subject=self.subject)","path":"ipaserver/install/dsinstance.py","position":89,"original_position":89,"commit_id":"382bbff12af5607f879d8e838e2c9947276d0168","original_commit_id":"382bbff12af5607f879d8e838e2c9947276d0168","user":{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars.githubusercontent.com/u/2331938?v=3","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false},"body":"Agreed.  (Disagree with first approach though; what if we rename var `certdb`, module `certs` or class `CertDB` and length changes?  You don't want to realign `N` extra lines for all the arguments :)","created_at":"2016-12-14T01:21:12Z","updated_at":"2016-12-14T01:21:12Z","html_url":"https://github.com/freeipa/freeipa/pull/245#discussion_r92305177","pull_request_url":"https://api.github.com/repos/freeipa/freeipa/pulls/245","_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/92305177"},"html":{"href":"https://github.com/freeipa/freeipa/pull/245#discussion_r92305177"},"pull_request":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/245"}}},"pull_request":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/245","id":93945205,"html_url":"https://github.com/freeipa/freeipa/pull/245","diff_url":"https://github.com/freeipa/freeipa/pull/245.diff","patch_url":"https://github.com/freeipa/freeipa/pull/245.patch","issue_url":"https://api.github.com/repos/freeipa/freeipa/issues/245","number":245,"state":"open","locked":false,"title":"Allow full customisability of IPA CA subject DN","user":{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars.githubusercontent.com/u/2331938?v=3","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false},"body":"This patchset adds full customisability of CA subject DN apart from\nsubject base, via the ipa-server-install `--ca-subject` option.  It\nalso renames ipa-server-install `--subject` option to\n`--subject-base`, and adds `--ca-subject` and `--subject-base`\noptions to ipa-ca-install.\n\nEarlier version of this patchset was previously reviewed by\n@jcholast on freeipa-devel:\nhttps://www.redhat.com/archives/freeipa-devel/2016-August/msg00570.html\n\nAll review items have been addressed, except for item 9.  The\nsuggestion will not work because a fair bit of code besides\nwhat's in `ipaserver.install.ca` requires knowing the CA Subject DN\nand/or subject base.  So the defaults must be applied close to the\n\"entry points\".\n\nI also carved a few smaller commits out of the main patch (but it is\nstill pretty big and hairy to review).\n\nhttps://fedorahosted.org/freeipa/ticket/2614","created_at":"2016-11-16T11:08:13Z","updated_at":"2016-12-14T01:21:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"359821c97ff8363136b9c551386ed8ee9efee0c0","assignee":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/freeipa/freeipa/pulls/245/commits","review_comments_url":"https://api.github.com/repos/freeipa/freeipa/pulls/245/comments","review_comment_url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeipa/freeipa/issues/245/comments","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/382bbff12af5607f879d8e838e2c9947276d0168","head":{"label":"frasertweedale:feature/2614-enhanced-ca-subject","ref":"feature/2614-enhanced-ca-subject","sha":"382bbff12af5607f879d8e838e2c9947276d0168","user":{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars.githubusercontent.com/u/2331938?v=3","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false},"repo":{"id":68566265,"name":"freeipa","full_name":"frasertweedale/freeipa","owner":{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars.githubusercontent.com/u/2331938?v=3","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frasertweedale/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":true,"url":"https://api.github.com/repos/frasertweedale/freeipa","forks_url":"https://api.github.com/repos/frasertweedale/freeipa/forks","keys_url":"https://api.github.com/repos/frasertweedale/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frasertweedale/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frasertweedale/freeipa/teams","hooks_url":"https://api.github.com/repos/frasertweedale/freeipa/hooks","issue_events_url":"https://api.github.com/repos/frasertweedale/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/frasertweedale/freeipa/events","assignees_url":"https://api.github.com/repos/frasertweedale/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/frasertweedale/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/frasertweedale/freeipa/tags","blobs_url":"https://api.github.com/repos/frasertweedale/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frasertweedale/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frasertweedale/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/frasertweedale/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frasertweedale/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/frasertweedale/freeipa/languages","stargazers_url":"https://api.github.com/repos/frasertweedale/freeipa/stargazers","contributors_url":"https://api.github.com/repos/frasertweedale/freeipa/contributors","subscribers_url":"https://api.github.com/repos/frasertweedale/freeipa/subscribers","subscription_url":"https://api.github.com/repos/frasertweedale/freeipa/subscription","commits_url":"https://api.github.com/repos/frasertweedale/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/frasertweedale/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/frasertweedale/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/frasertweedale/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/frasertweedale/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/frasertweedale/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frasertweedale/freeipa/merges","archive_url":"https://api.github.com/repos/frasertweedale/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frasertweedale/freeipa/downloads","issues_url":"https://api.github.com/repos/frasertweedale/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/frasertweedale/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/frasertweedale/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/frasertweedale/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frasertweedale/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/frasertweedale/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/frasertweedale/freeipa/deployments","created_at":"2016-09-19T03:33:25Z","updated_at":"2016-09-19T03:33:31Z","pushed_at":"2016-12-13T21:47:28Z","git_url":"git://github.com/frasertweedale/freeipa.git","ssh_url":"git@github.com:frasertweedale/freeipa.git","clone_url":"https://github.com/frasertweedale/freeipa.git","svn_url":"https://github.com/frasertweedale/freeipa","homepage":"http://www.freeipa.org","size":38457,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeipa:master","ref":"master","sha":"ca4e6c1fdfac9b545b26f885dc4865f22ca36ae6","user":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars.githubusercontent.com/u/10979201?v=3","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"repo":{"id":4340318,"name":"freeipa","full_name":"freeipa/freeipa","owner":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars.githubusercontent.com/u/10979201?v=3","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeipa/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":false,"url":"https://api.github.com/repos/freeipa/freeipa","forks_url":"https://api.github.com/repos/freeipa/freeipa/forks","keys_url":"https://api.github.com/repos/freeipa/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeipa/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeipa/freeipa/teams","hooks_url":"https://api.github.com/repos/freeipa/freeipa/hooks","issue_events_url":"https://api.github.com/repos/freeipa/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/freeipa/freeipa/events","assignees_url":"https://api.github.com/repos/freeipa/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/freeipa/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/freeipa/freeipa/tags","blobs_url":"https://api.github.com/repos/freeipa/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeipa/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeipa/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeipa/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/freeipa/freeipa/languages","stargazers_url":"https://api.github.com/repos/freeipa/freeipa/stargazers","contributors_url":"https://api.github.com/repos/freeipa/freeipa/contributors","subscribers_url":"https://api.github.com/repos/freeipa/freeipa/subscribers","subscription_url":"https://api.github.com/repos/freeipa/freeipa/subscription","commits_url":"https://api.github.com/repos/freeipa/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeipa/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeipa/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeipa/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeipa/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/freeipa/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeipa/freeipa/merges","archive_url":"https://api.github.com/repos/freeipa/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeipa/freeipa/downloads","issues_url":"https://api.github.com/repos/freeipa/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/freeipa/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/freeipa/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/freeipa/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeipa/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/freeipa/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/freeipa/freeipa/deployments","created_at":"2012-05-15T20:34:40Z","updated_at":"2016-12-13T20:39:00Z","pushed_at":"2016-12-13T22:57:27Z","git_url":"git://github.com/freeipa/freeipa.git","ssh_url":"git@github.com:freeipa/freeipa.git","clone_url":"https://github.com/freeipa/freeipa.git","svn_url":"https://github.com/freeipa/freeipa","homepage":"http://www.freeipa.org","size":38552,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":30,"forks":56,"open_issues":30,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/245"},"html":{"href":"https://github.com/freeipa/freeipa/pull/245"},"issue":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/245"},"comments":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/freeipa/freeipa/statuses/382bbff12af5607f879d8e838e2c9947276d0168"}}}}
{"actor":{"display_login":"frasertweedale"}}