{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls/1","id":90711599,"html_url":"https://github.com/cwstra/roll20-character-sheets/pull/1","diff_url":"https://github.com/cwstra/roll20-character-sheets/pull/1.diff","patch_url":"https://github.com/cwstra/roll20-character-sheets/pull/1.patch","issue_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/issues/1","number":1,"state":"open","locked":false,"title":"Adding support for critical hit highlighting","user":{"login":"KingMarth","id":11747427,"avatar_url":"https://avatars.githubusercontent.com/u/11747427?v=3","gravatar_id":"","url":"https://api.github.com/users/KingMarth","html_url":"https://github.com/KingMarth","followers_url":"https://api.github.com/users/KingMarth/followers","following_url":"https://api.github.com/users/KingMarth/following{/other_user}","gists_url":"https://api.github.com/users/KingMarth/gists{/gist_id}","starred_url":"https://api.github.com/users/KingMarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingMarth/subscriptions","organizations_url":"https://api.github.com/users/KingMarth/orgs","repos_url":"https://api.github.com/users/KingMarth/repos","events_url":"https://api.github.com/users/KingMarth/events{/privacy}","received_events_url":"https://api.github.com/users/KingMarth/received_events","type":"User","site_admin":false},"body":"While I'm up to date on this repo... I noticed the \"Crits On\" field isn't used as anything other than a visible reference field on the sheet, which is a shame since Roll20 supports adjusting the range of values which trigger the critical green-border highlighting. This should handle that.\r\n\r\nI've tested the expression I used here in my personal macros, though it'd be best to test the full sheet first. For reference, this is the sed script I used to add the critical success list:\r\nsed -e \"s/AR=..1d20+@{Acc}..}} {{AC=@{Move\\(.\\)/AR={{1d20cs>@{Move\\1_critsOn}}} {{AC=@{Move\\1/\" ptu.html -i\r\n\r\nI think it's best to drop the Crits On field from the roll template if it's being evaluated here. I separated that commit out though, so if you've a reason to keep it (possibly a technical one) that should be easy.","created_at":"2016-10-24T23:20:34Z","updated_at":"2016-10-24T23:20:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/issues/1/comments","statuses_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/statuses/09d364cb3987fe3541d8f967b93bd1da8da39f61","head":{"label":"KingMarth:additions","ref":"additions","sha":"09d364cb3987fe3541d8f967b93bd1da8da39f61","user":{"login":"KingMarth","id":11747427,"avatar_url":"https://avatars.githubusercontent.com/u/11747427?v=3","gravatar_id":"","url":"https://api.github.com/users/KingMarth","html_url":"https://github.com/KingMarth","followers_url":"https://api.github.com/users/KingMarth/followers","following_url":"https://api.github.com/users/KingMarth/following{/other_user}","gists_url":"https://api.github.com/users/KingMarth/gists{/gist_id}","starred_url":"https://api.github.com/users/KingMarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingMarth/subscriptions","organizations_url":"https://api.github.com/users/KingMarth/orgs","repos_url":"https://api.github.com/users/KingMarth/repos","events_url":"https://api.github.com/users/KingMarth/events{/privacy}","received_events_url":"https://api.github.com/users/KingMarth/received_events","type":"User","site_admin":false},"repo":{"id":33223442,"name":"roll20-character-sheets","full_name":"KingMarth/roll20-character-sheets","owner":{"login":"KingMarth","id":11747427,"avatar_url":"https://avatars.githubusercontent.com/u/11747427?v=3","gravatar_id":"","url":"https://api.github.com/users/KingMarth","html_url":"https://github.com/KingMarth","followers_url":"https://api.github.com/users/KingMarth/followers","following_url":"https://api.github.com/users/KingMarth/following{/other_user}","gists_url":"https://api.github.com/users/KingMarth/gists{/gist_id}","starred_url":"https://api.github.com/users/KingMarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingMarth/subscriptions","organizations_url":"https://api.github.com/users/KingMarth/orgs","repos_url":"https://api.github.com/users/KingMarth/repos","events_url":"https://api.github.com/users/KingMarth/events{/privacy}","received_events_url":"https://api.github.com/users/KingMarth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KingMarth/roll20-character-sheets","description":"Character sheet templates created by the community for use in Roll20.","fork":true,"url":"https://api.github.com/repos/KingMarth/roll20-character-sheets","forks_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/forks","keys_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/teams","hooks_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/hooks","issue_events_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/issues/events{/number}","events_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/events","assignees_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/assignees{/user}","branches_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/branches{/branch}","tags_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/tags","blobs_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/git/refs{/sha}","trees_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/statuses/{sha}","languages_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/languages","stargazers_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/stargazers","contributors_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/contributors","subscribers_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/subscribers","subscription_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/subscription","commits_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/commits{/sha}","git_commits_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/git/commits{/sha}","comments_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/comments{/number}","issue_comment_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/issues/comments{/number}","contents_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/contents/{+path}","compare_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/merges","archive_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/downloads","issues_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/issues{/number}","pulls_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/pulls{/number}","milestones_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/milestones{/number}","notifications_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/labels{/name}","releases_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/releases{/id}","deployments_url":"https://api.github.com/repos/KingMarth/roll20-character-sheets/deployments","created_at":"2015-04-01T03:01:08Z","updated_at":"2016-10-24T19:33:59Z","pushed_at":"2016-10-24T23:19:52Z","git_url":"git://github.com/KingMarth/roll20-character-sheets.git","ssh_url":"git@github.com:KingMarth/roll20-character-sheets.git","clone_url":"https://github.com/KingMarth/roll20-character-sheets.git","svn_url":"https://github.com/KingMarth/roll20-character-sheets","homepage":null,"size":185986,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cwstra:master","ref":"master","sha":"26924ae512e83cdaf7807a27a0aa7d560715ad6c","user":{"login":"cwstra","id":10345377,"avatar_url":"https://avatars.githubusercontent.com/u/10345377?v=3","gravatar_id":"","url":"https://api.github.com/users/cwstra","html_url":"https://github.com/cwstra","followers_url":"https://api.github.com/users/cwstra/followers","following_url":"https://api.github.com/users/cwstra/following{/other_user}","gists_url":"https://api.github.com/users/cwstra/gists{/gist_id}","starred_url":"https://api.github.com/users/cwstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwstra/subscriptions","organizations_url":"https://api.github.com/users/cwstra/orgs","repos_url":"https://api.github.com/users/cwstra/repos","events_url":"https://api.github.com/users/cwstra/events{/privacy}","received_events_url":"https://api.github.com/users/cwstra/received_events","type":"User","site_admin":false},"repo":{"id":68171074,"name":"roll20-character-sheets","full_name":"cwstra/roll20-character-sheets","owner":{"login":"cwstra","id":10345377,"avatar_url":"https://avatars.githubusercontent.com/u/10345377?v=3","gravatar_id":"","url":"https://api.github.com/users/cwstra","html_url":"https://github.com/cwstra","followers_url":"https://api.github.com/users/cwstra/followers","following_url":"https://api.github.com/users/cwstra/following{/other_user}","gists_url":"https://api.github.com/users/cwstra/gists{/gist_id}","starred_url":"https://api.github.com/users/cwstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwstra/subscriptions","organizations_url":"https://api.github.com/users/cwstra/orgs","repos_url":"https://api.github.com/users/cwstra/repos","events_url":"https://api.github.com/users/cwstra/events{/privacy}","received_events_url":"https://api.github.com/users/cwstra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwstra/roll20-character-sheets","description":"Character sheet templates created by the community for use in Roll20.","fork":true,"url":"https://api.github.com/repos/cwstra/roll20-character-sheets","forks_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/forks","keys_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/teams","hooks_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/hooks","issue_events_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/issues/events{/number}","events_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/events","assignees_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/assignees{/user}","branches_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/branches{/branch}","tags_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/tags","blobs_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/statuses/{sha}","languages_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/languages","stargazers_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/stargazers","contributors_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/contributors","subscribers_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/subscribers","subscription_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/subscription","commits_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/contents/{+path}","compare_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/merges","archive_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/downloads","issues_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/issues{/number}","pulls_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls{/number}","milestones_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/milestones{/number}","notifications_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/labels{/name}","releases_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/releases{/id}","deployments_url":"https://api.github.com/repos/cwstra/roll20-character-sheets/deployments","created_at":"2016-09-14T03:43:28Z","updated_at":"2016-09-14T03:43:36Z","pushed_at":"2016-09-14T03:44:20Z","git_url":"git://github.com/cwstra/roll20-character-sheets.git","ssh_url":"git@github.com:cwstra/roll20-character-sheets.git","clone_url":"https://github.com/cwstra/roll20-character-sheets.git","svn_url":"https://github.com/cwstra/roll20-character-sheets","homepage":null,"size":180266,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls/1"},"html":{"href":"https://github.com/cwstra/roll20-character-sheets/pull/1"},"issue":{"href":"https://api.github.com/repos/cwstra/roll20-character-sheets/issues/1"},"comments":{"href":"https://api.github.com/repos/cwstra/roll20-character-sheets/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cwstra/roll20-character-sheets/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cwstra/roll20-character-sheets/statuses/09d364cb3987fe3541d8f967b93bd1da8da39f61"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":136,"deletions":137,"changed_files":1}}
{"actor":{"display_login":"KingMarth"}}