{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/5444","repository_url":"https://api.github.com/repos/hashicorp/terraform","labels_url":"https://api.github.com/repos/hashicorp/terraform/issues/5444/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/5444/comments","events_url":"https://api.github.com/repos/hashicorp/terraform/issues/5444/events","html_url":"https://github.com/hashicorp/terraform/pull/5444","id":138128947,"number":5444,"title":"provider/aws: Add support for CloudWatch Log Metric Filter","user":{"login":"radeksimko","id":287584,"avatar_url":"https://avatars.githubusercontent.com/u/287584?v=3","gravatar_id":"","url":"https://api.github.com/users/radeksimko","html_url":"https://github.com/radeksimko","followers_url":"https://api.github.com/users/radeksimko/followers","following_url":"https://api.github.com/users/radeksimko/following{/other_user}","gists_url":"https://api.github.com/users/radeksimko/gists{/gist_id}","starred_url":"https://api.github.com/users/radeksimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radeksimko/subscriptions","organizations_url":"https://api.github.com/users/radeksimko/orgs","repos_url":"https://api.github.com/users/radeksimko/repos","events_url":"https://api.github.com/users/radeksimko/events{/privacy}","received_events_url":"https://api.github.com/users/radeksimko/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hashicorp/terraform/labels/enhancement","name":"enhancement","color":"d4c5f9"},{"url":"https://api.github.com/repos/hashicorp/terraform/labels/new-resource","name":"new-resource","color":"d4c5f9"},{"url":"https://api.github.com/repos/hashicorp/terraform/labels/provider/aws","name":"provider/aws","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-03T09:44:29Z","updated_at":"2016-03-21T16:43:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/5444","html_url":"https://github.com/hashicorp/terraform/pull/5444","diff_url":"https://github.com/hashicorp/terraform/pull/5444.diff","patch_url":"https://github.com/hashicorp/terraform/pull/5444.patch"},"body":"### TODO\r\n\r\n - [x] Basic CRUD functionality\r\n - [x] Documentation\r\n - [x] Acceptance test\r\n - [x] Add field validation per [AWS API Docs](http://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_PutMetricFilter.html)\r\n - [x] Try out the new `schema` parameter `MaxItems` instead of `len()` function in `Create()`\r\n - [x] Be able to recover from filter deleted outside of Terraform\r\n - [x] Improve acceptance tests by adding checks of the actual `cloudwatchlogs.MetricFilter` type\r\n - [x] Mention [link to filter and pattern syntax](https://docs.aws.amazon.com/AmazonCloudWatch/latest/DeveloperGuide/FilterAndPatternSyntax.html) in docs\r\n - [x] Figure out if raising `awserr.Error` is the best way to deal with missing resource\r\n\r\n### Test plan\r\n\r\n```\r\nmake testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSCloudWatchLogMetricFilter'\r\n```\r\n```\r\nTF_ACC=1 go test ./builtin/providers/aws -v -run=AWSCloudWatchLogMetricFilter -timeout 120m\r\n=== RUN   TestAccAWSCloudWatchLogMetricFilter_basic\r\n--- PASS: TestAccAWSCloudWatchLogMetricFilter_basic (17.98s)\r\nPASS\r\nok  \tgithub.com/hashicorp/terraform/builtin/providers/aws\t18.004s\r\n```"},"comment":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/comments/199371829","html_url":"https://github.com/hashicorp/terraform/pull/5444#issuecomment-199371829","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/5444","id":199371829,"user":{"login":"jen20","id":548524,"avatar_url":"https://avatars.githubusercontent.com/u/548524?v=3","gravatar_id":"","url":"https://api.github.com/users/jen20","html_url":"https://github.com/jen20","followers_url":"https://api.github.com/users/jen20/followers","following_url":"https://api.github.com/users/jen20/following{/other_user}","gists_url":"https://api.github.com/users/jen20/gists{/gist_id}","starred_url":"https://api.github.com/users/jen20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jen20/subscriptions","organizations_url":"https://api.github.com/users/jen20/orgs","repos_url":"https://api.github.com/users/jen20/repos","events_url":"https://api.github.com/users/jen20/events{/privacy}","received_events_url":"https://api.github.com/users/jen20/received_events","type":"User","site_admin":false},"created_at":"2016-03-21T16:43:36Z","updated_at":"2016-03-21T16:43:36Z","body":"Thanks @radeksimko! This LGTM!"}}