{"action":"created","issue":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/issues/19","repository_url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor","labels_url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/issues/19/comments","events_url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/issues/19/events","html_url":"https://github.com/ipld/js-ipld-dag-cbor/issues/19","id":163428115,"number":19,"title":"Ensure that CBOR always produces the same objects (sort map keys)","user":{"login":"dignifiedquire","id":790842,"avatar_url":"https://avatars.githubusercontent.com/u/790842?v=3","gravatar_id":"","url":"https://api.github.com/users/dignifiedquire","html_url":"https://github.com/dignifiedquire","followers_url":"https://api.github.com/users/dignifiedquire/followers","following_url":"https://api.github.com/users/dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/dignifiedquire/orgs","repos_url":"https://api.github.com/users/dignifiedquire/repos","events_url":"https://api.github.com/users/dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/dignifiedquire/received_events","type":"User","site_admin":false},"labels":[{"id":253100638,"url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/labels/bug","name":"bug","color":"fc2929","default":true},{"id":253100641,"url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/labels/help%20wanted","name":"help wanted","color":"0e8a16","default":true},{"id":419602075,"url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-07-01T16:13:48Z","updated_at":"2016-11-22T18:28:00Z","closed_at":"2016-11-22T18:27:59Z","body":"According to https://tools.ietf.org/html/rfc7049#section-3.9\n\n> The keys in every map must be sorted lowest value to highest.\n>       Sorting is performed on the bytes of the representation of the key\n>       data items without paying attention to the 3/5 bit splitting for\n>       major types.  (Note that this rule allows maps that have keys of\n>       different types, even though that is probably a bad practice that\n>       could lead to errors in some canonicalization implementations.)\n>       The sorting rules are:\n\n```\n  *  If two keys have different lengths, the shorter one sorts\n     earlier;\n\n  *  If two keys have the same length, the one with the lower value\n     in (byte-wise) lexical order sorts earlier.\n```\n\nall keys in maps need to be sorted. Looking at https://github.com/hildjj/node-cbor/blob/master/src/encoder.coffee#L238-L260 it does not look like this is currently happening.\n"},"comment":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/issues/comments/262323779","html_url":"https://github.com/ipld/js-ipld-dag-cbor/issues/19#issuecomment-262323779","issue_url":"https://api.github.com/repos/ipld/js-ipld-dag-cbor/issues/19","id":262323779,"user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T18:27:59Z","updated_at":"2016-11-22T18:27:59Z","body":"closing this one as it is solved now. Thank you @hildjj :D "}}
{"actor":{"display_login":"diasdavid"}}