{"action":"closed","number":47,"pull_request":{"url":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls/47","id":60159925,"html_url":"https://github.com/airbrake/airbrake-ruby/pull/47","diff_url":"https://github.com/airbrake/airbrake-ruby/pull/47.diff","patch_url":"https://github.com/airbrake/airbrake-ruby/pull/47.patch","issue_url":"https://api.github.com/repos/airbrake/airbrake-ruby/issues/47","number":47,"state":"closed","locked":false,"title":"Asynchronous notifier shouldn't block if queue full","user":{"login":"crunis","id":1515768,"avatar_url":"https://avatars.githubusercontent.com/u/1515768?v=3","gravatar_id":"","url":"https://api.github.com/users/crunis","html_url":"https://github.com/crunis","followers_url":"https://api.github.com/users/crunis/followers","following_url":"https://api.github.com/users/crunis/following{/other_user}","gists_url":"https://api.github.com/users/crunis/gists{/gist_id}","starred_url":"https://api.github.com/users/crunis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crunis/subscriptions","organizations_url":"https://api.github.com/users/crunis/orgs","repos_url":"https://api.github.com/users/crunis/repos","events_url":"https://api.github.com/users/crunis/events{/privacy}","received_events_url":"https://api.github.com/users/crunis/received_events","type":"User","site_admin":false},"body":"SizedQueue blocks if the queue is full. I think this behaviour is completely unexpected in an asynchronous component.\r\n\r\nI think it would be better to drop the error in this situation. I can picture 2 scenarios where this could happen and dropping the extra errors would make sense:\r\n\r\n1. **The app is sending errors faster than Airbrake server can process them**. It may be due to a bug in the app or because the app is being flooded by some sort of bogus request, we don't want the app to block for this reason, we would like, if possible, to keep providing service even if it's with degraded performance. In this situation, still many errors will make it to the Airbrake server so we won't miss that something is wrong.\r\n2. **The Airbrake server has a problem and is not accepting errors**. In this situation we also don't want our app to block and stop providing service. If the Airbrake server is not working we will notice at some point, the async workers will notify the timeout, and we can fix the problem without interrupting our application's service.\r\n\r\nI have fixed the specs accordingly","created_at":"2016-02-22T11:34:16Z","updated_at":"2016-02-23T20:52:00Z","closed_at":"2016-02-23T20:52:00Z","merged_at":"2016-02-23T20:52:00Z","merge_commit_sha":"9907b3213d4b6746d5f48f53ef17e0947f6a6d67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls/47/commits","review_comments_url":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls/47/comments","review_comment_url":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbrake/airbrake-ruby/issues/47/comments","statuses_url":"https://api.github.com/repos/airbrake/airbrake-ruby/statuses/5df2c2bcf617bdb09ac3dfa27ca08f997026f631","head":{"label":"crunis:async_drop_error_if_queue_full","ref":"async_drop_error_if_queue_full","sha":"5df2c2bcf617bdb09ac3dfa27ca08f997026f631","user":{"login":"crunis","id":1515768,"avatar_url":"https://avatars.githubusercontent.com/u/1515768?v=3","gravatar_id":"","url":"https://api.github.com/users/crunis","html_url":"https://github.com/crunis","followers_url":"https://api.github.com/users/crunis/followers","following_url":"https://api.github.com/users/crunis/following{/other_user}","gists_url":"https://api.github.com/users/crunis/gists{/gist_id}","starred_url":"https://api.github.com/users/crunis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crunis/subscriptions","organizations_url":"https://api.github.com/users/crunis/orgs","repos_url":"https://api.github.com/users/crunis/repos","events_url":"https://api.github.com/users/crunis/events{/privacy}","received_events_url":"https://api.github.com/users/crunis/received_events","type":"User","site_admin":false},"repo":{"id":52267716,"name":"airbrake-ruby","full_name":"crunis/airbrake-ruby","owner":{"login":"crunis","id":1515768,"avatar_url":"https://avatars.githubusercontent.com/u/1515768?v=3","gravatar_id":"","url":"https://api.github.com/users/crunis","html_url":"https://github.com/crunis","followers_url":"https://api.github.com/users/crunis/followers","following_url":"https://api.github.com/users/crunis/following{/other_user}","gists_url":"https://api.github.com/users/crunis/gists{/gist_id}","starred_url":"https://api.github.com/users/crunis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crunis/subscriptions","organizations_url":"https://api.github.com/users/crunis/orgs","repos_url":"https://api.github.com/users/crunis/repos","events_url":"https://api.github.com/users/crunis/events{/privacy}","received_events_url":"https://api.github.com/users/crunis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crunis/airbrake-ruby","description":"A plain Ruby Airbrake notifier","fork":true,"url":"https://api.github.com/repos/crunis/airbrake-ruby","forks_url":"https://api.github.com/repos/crunis/airbrake-ruby/forks","keys_url":"https://api.github.com/repos/crunis/airbrake-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crunis/airbrake-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crunis/airbrake-ruby/teams","hooks_url":"https://api.github.com/repos/crunis/airbrake-ruby/hooks","issue_events_url":"https://api.github.com/repos/crunis/airbrake-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/crunis/airbrake-ruby/events","assignees_url":"https://api.github.com/repos/crunis/airbrake-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/crunis/airbrake-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/crunis/airbrake-ruby/tags","blobs_url":"https://api.github.com/repos/crunis/airbrake-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crunis/airbrake-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crunis/airbrake-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/crunis/airbrake-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crunis/airbrake-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/crunis/airbrake-ruby/languages","stargazers_url":"https://api.github.com/repos/crunis/airbrake-ruby/stargazers","contributors_url":"https://api.github.com/repos/crunis/airbrake-ruby/contributors","subscribers_url":"https://api.github.com/repos/crunis/airbrake-ruby/subscribers","subscription_url":"https://api.github.com/repos/crunis/airbrake-ruby/subscription","commits_url":"https://api.github.com/repos/crunis/airbrake-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/crunis/airbrake-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/crunis/airbrake-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/crunis/airbrake-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/crunis/airbrake-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/crunis/airbrake-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crunis/airbrake-ruby/merges","archive_url":"https://api.github.com/repos/crunis/airbrake-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crunis/airbrake-ruby/downloads","issues_url":"https://api.github.com/repos/crunis/airbrake-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/crunis/airbrake-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/crunis/airbrake-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/crunis/airbrake-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crunis/airbrake-ruby/labels{/name}","releases_url":"https://api.github.com/repos/crunis/airbrake-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/crunis/airbrake-ruby/deployments","created_at":"2016-02-22T11:06:44Z","updated_at":"2016-02-22T11:06:45Z","pushed_at":"2016-02-23T09:18:53Z","git_url":"git://github.com/crunis/airbrake-ruby.git","ssh_url":"git@github.com:crunis/airbrake-ruby.git","clone_url":"https://github.com/crunis/airbrake-ruby.git","svn_url":"https://github.com/crunis/airbrake-ruby","homepage":"https://airbrake.io/","size":85,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbrake:master","ref":"master","sha":"f48ea788eeeb4a3d7f2cc6db5b6433c5fb6bcd90","user":{"login":"airbrake","id":1015434,"avatar_url":"https://avatars.githubusercontent.com/u/1015434?v=3","gravatar_id":"","url":"https://api.github.com/users/airbrake","html_url":"https://github.com/airbrake","followers_url":"https://api.github.com/users/airbrake/followers","following_url":"https://api.github.com/users/airbrake/following{/other_user}","gists_url":"https://api.github.com/users/airbrake/gists{/gist_id}","starred_url":"https://api.github.com/users/airbrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbrake/subscriptions","organizations_url":"https://api.github.com/users/airbrake/orgs","repos_url":"https://api.github.com/users/airbrake/repos","events_url":"https://api.github.com/users/airbrake/events{/privacy}","received_events_url":"https://api.github.com/users/airbrake/received_events","type":"Organization","site_admin":false},"repo":{"id":47778822,"name":"airbrake-ruby","full_name":"airbrake/airbrake-ruby","owner":{"login":"airbrake","id":1015434,"avatar_url":"https://avatars.githubusercontent.com/u/1015434?v=3","gravatar_id":"","url":"https://api.github.com/users/airbrake","html_url":"https://github.com/airbrake","followers_url":"https://api.github.com/users/airbrake/followers","following_url":"https://api.github.com/users/airbrake/following{/other_user}","gists_url":"https://api.github.com/users/airbrake/gists{/gist_id}","starred_url":"https://api.github.com/users/airbrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbrake/subscriptions","organizations_url":"https://api.github.com/users/airbrake/orgs","repos_url":"https://api.github.com/users/airbrake/repos","events_url":"https://api.github.com/users/airbrake/events{/privacy}","received_events_url":"https://api.github.com/users/airbrake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbrake/airbrake-ruby","description":"A plain Ruby Airbrake notifier","fork":false,"url":"https://api.github.com/repos/airbrake/airbrake-ruby","forks_url":"https://api.github.com/repos/airbrake/airbrake-ruby/forks","keys_url":"https://api.github.com/repos/airbrake/airbrake-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbrake/airbrake-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbrake/airbrake-ruby/teams","hooks_url":"https://api.github.com/repos/airbrake/airbrake-ruby/hooks","issue_events_url":"https://api.github.com/repos/airbrake/airbrake-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/airbrake/airbrake-ruby/events","assignees_url":"https://api.github.com/repos/airbrake/airbrake-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/airbrake/airbrake-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/airbrake/airbrake-ruby/tags","blobs_url":"https://api.github.com/repos/airbrake/airbrake-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbrake/airbrake-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbrake/airbrake-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbrake/airbrake-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbrake/airbrake-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/airbrake/airbrake-ruby/languages","stargazers_url":"https://api.github.com/repos/airbrake/airbrake-ruby/stargazers","contributors_url":"https://api.github.com/repos/airbrake/airbrake-ruby/contributors","subscribers_url":"https://api.github.com/repos/airbrake/airbrake-ruby/subscribers","subscription_url":"https://api.github.com/repos/airbrake/airbrake-ruby/subscription","commits_url":"https://api.github.com/repos/airbrake/airbrake-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbrake/airbrake-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbrake/airbrake-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbrake/airbrake-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbrake/airbrake-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/airbrake/airbrake-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbrake/airbrake-ruby/merges","archive_url":"https://api.github.com/repos/airbrake/airbrake-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbrake/airbrake-ruby/downloads","issues_url":"https://api.github.com/repos/airbrake/airbrake-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/airbrake/airbrake-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/airbrake/airbrake-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbrake/airbrake-ruby/labels{/name}","releases_url":"https://api.github.com/repos/airbrake/airbrake-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/airbrake/airbrake-ruby/deployments","created_at":"2015-12-10T18:05:25Z","updated_at":"2016-02-08T22:21:26Z","pushed_at":"2016-02-23T20:52:00Z","git_url":"git://github.com/airbrake/airbrake-ruby.git","ssh_url":"git@github.com:airbrake/airbrake-ruby.git","clone_url":"https://github.com/airbrake/airbrake-ruby.git","svn_url":"https://github.com/airbrake/airbrake-ruby","homepage":"https://airbrake.io/","size":84,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls/47"},"html":{"href":"https://github.com/airbrake/airbrake-ruby/pull/47"},"issue":{"href":"https://api.github.com/repos/airbrake/airbrake-ruby/issues/47"},"comments":{"href":"https://api.github.com/repos/airbrake/airbrake-ruby/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbrake/airbrake-ruby/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/airbrake/airbrake-ruby/statuses/5df2c2bcf617bdb09ac3dfa27ca08f997026f631"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kyrylo","id":1079123,"avatar_url":"https://avatars.githubusercontent.com/u/1079123?v=3","gravatar_id":"","url":"https://api.github.com/users/kyrylo","html_url":"https://github.com/kyrylo","followers_url":"https://api.github.com/users/kyrylo/followers","following_url":"https://api.github.com/users/kyrylo/following{/other_user}","gists_url":"https://api.github.com/users/kyrylo/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrylo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrylo/subscriptions","organizations_url":"https://api.github.com/users/kyrylo/orgs","repos_url":"https://api.github.com/users/kyrylo/repos","events_url":"https://api.github.com/users/kyrylo/events{/privacy}","received_events_url":"https://api.github.com/users/kyrylo/received_events","type":"User","site_admin":false},"comments":6,"review_comments":7,"commits":1,"additions":30,"deletions":7,"changed_files":2}}