{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/7149","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/7149/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/7149/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/7149/events","html_url":"https://github.com/highfidelity/hifi/pull/7149","id":135007979,"number":7149,"title":"Make Overlay API usable from QML","user":{"login":"jherico","id":1533642,"avatar_url":"https://avatars.githubusercontent.com/u/1533642?v=3","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-02-20T00:12:01Z","updated_at":"2016-03-04T21:04:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/7149","html_url":"https://github.com/highfidelity/hifi/pull/7149","diff_url":"https://github.com/highfidelity/hifi/pull/7149.diff","patch_url":"https://github.com/highfidelity/hifi/pull/7149.patch"},"body":"Right now many of our scripting interfaces are usable only from JS, even though there's little reason they shouldn't also be accessible from QML.  The primary blocker is that QML uses QJSEngine, not QScriptEngine, and therefore can't call any scripting function that is decorated with a type that can't be converted to or from a QJSValue or QVariant.  This means any function that takes arbitrary properties as a QScriptValue, or any function that includes a GLM type in the signature.\r\n\r\nThis PR modifies the Overlays scripting interface to use QVariant everywhere it was previously using QScriptValue.  This should enable overlays to be created by QML as well as JS.\r\n\r\nThis PR isn't critical for MVP nor associated with any Asana task, but is a stepping stone towards some overlay animation functionality I want to create in my personal domain."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/192466216","html_url":"https://github.com/highfidelity/hifi/pull/7149#issuecomment-192466216","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/7149","id":192466216,"user":{"login":"jherico","id":1533642,"avatar_url":"https://avatars.githubusercontent.com/u/1533642?v=3","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T21:04:28Z","updated_at":"2016-03-04T21:04:28Z","body":"@OmegaHeron whoops... that's my bad... I had code in the QML that would delete all the overlays from 1-1000 because I had some earlier issues with cleaning up.  I've updated the QML... but I'm not sure if it gets cached on the client side.  "}}