{"action":"opened","number":1249,"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/1249","id":63991338,"html_url":"https://github.com/aframevr/aframe/pull/1249","diff_url":"https://github.com/aframevr/aframe/pull/1249.diff","patch_url":"https://github.com/aframevr/aframe/pull/1249.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/1249","number":1249,"state":"open","locked":false,"title":"Removing function binds","user":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"body":"Functions bound with the method .bind are slow. there was a very big overhead when parsing/stringifying component properties. It was specially noticeable at startup when all the components are initialized. With these changes scenes load twice as fast. In the included stress test loading time for 4000 entities prior to this patch was 8s on my computer. This patch improves it to 4s","created_at":"2016-03-24T05:21:17Z","updated_at":"2016-03-24T05:21:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/1249/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/1249/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/1249/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/bd1f0010b6243745d862dd93ef924a4063b5dedc","head":{"label":"dmarcos:removeBinds","ref":"removeBinds","sha":"bd1f0010b6243745d862dd93ef924a4063b5dedc","user":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"repo":{"id":49595885,"name":"aframe","full_name":"dmarcos/aframe","owner":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmarcos/aframe","description":"Building Blocks for the VR Web","fork":true,"url":"https://api.github.com/repos/dmarcos/aframe","forks_url":"https://api.github.com/repos/dmarcos/aframe/forks","keys_url":"https://api.github.com/repos/dmarcos/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmarcos/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmarcos/aframe/teams","hooks_url":"https://api.github.com/repos/dmarcos/aframe/hooks","issue_events_url":"https://api.github.com/repos/dmarcos/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/dmarcos/aframe/events","assignees_url":"https://api.github.com/repos/dmarcos/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/dmarcos/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/dmarcos/aframe/tags","blobs_url":"https://api.github.com/repos/dmarcos/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmarcos/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmarcos/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmarcos/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmarcos/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/dmarcos/aframe/languages","stargazers_url":"https://api.github.com/repos/dmarcos/aframe/stargazers","contributors_url":"https://api.github.com/repos/dmarcos/aframe/contributors","subscribers_url":"https://api.github.com/repos/dmarcos/aframe/subscribers","subscription_url":"https://api.github.com/repos/dmarcos/aframe/subscription","commits_url":"https://api.github.com/repos/dmarcos/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmarcos/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmarcos/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmarcos/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmarcos/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/dmarcos/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmarcos/aframe/merges","archive_url":"https://api.github.com/repos/dmarcos/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmarcos/aframe/downloads","issues_url":"https://api.github.com/repos/dmarcos/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/dmarcos/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/dmarcos/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/dmarcos/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmarcos/aframe/labels{/name}","releases_url":"https://api.github.com/repos/dmarcos/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/dmarcos/aframe/deployments","created_at":"2016-01-13T19:17:26Z","updated_at":"2016-01-13T19:17:26Z","pushed_at":"2016-03-24T05:21:10Z","git_url":"git://github.com/dmarcos/aframe.git","ssh_url":"git@github.com:dmarcos/aframe.git","clone_url":"https://github.com/dmarcos/aframe.git","svn_url":"https://github.com/dmarcos/aframe","homepage":"https://aframe.io/","size":85806,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"690e116d4a2394c0a0e8355dac1533e214ca2ffd","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"Building Blocks for the VR Web","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2016-03-24T04:53:46Z","pushed_at":"2016-03-24T05:18:45Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":102062,"stargazers_count":1504,"watchers_count":1504,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":196,"mirror_url":null,"open_issues_count":191,"forks":196,"open_issues":191,"watchers":1504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1249"},"html":{"href":"https://github.com/aframevr/aframe/pull/1249"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1249"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1249/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1249/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1249/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/bd1f0010b6243745d862dd93ef924a4063b5dedc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":74,"deletions":12,"changed_files":3}}