{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9024","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9024/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9024/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9024/events","html_url":"https://github.com/civicrm/civicrm-core/pull/9024","id":176637350,"number":9024,"title":"CRM-17789 - foreach fix in PHP 7","user":{"login":"jitendrapurohit","id":5929648,"avatar_url":"https://avatars.githubusercontent.com/u/5929648?v=3","gravatar_id":"","url":"https://api.github.com/users/jitendrapurohit","html_url":"https://github.com/jitendrapurohit","followers_url":"https://api.github.com/users/jitendrapurohit/followers","following_url":"https://api.github.com/users/jitendrapurohit/following{/other_user}","gists_url":"https://api.github.com/users/jitendrapurohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jitendrapurohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitendrapurohit/subscriptions","organizations_url":"https://api.github.com/users/jitendrapurohit/orgs","repos_url":"https://api.github.com/users/jitendrapurohit/repos","events_url":"https://api.github.com/users/jitendrapurohit/events{/privacy}","received_events_url":"https://api.github.com/users/jitendrapurohit/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-13T13:16:16Z","updated_at":"2016-09-14T13:17:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9024","html_url":"https://github.com/civicrm/civicrm-core/pull/9024","diff_url":"https://github.com/civicrm/civicrm-core/pull/9024.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/9024.patch"},"body":"* [CRM-17789: Support PHP 7](https://issues.civicrm.org/jira/browse/CRM-17789)\r\n\r\n>Notice: Undefined index: 9_a_b in CRM_Custom_Form_Group::getFormattedList() (line 547 of /home/web/civi_master/civicrm/CRM/Custom/Form/Group.php).\r\nNotice: Undefined index: 1_a_b in CRM_Custom_Form_Group::getFormattedList() (line 547 of /home/web/civi_master/civicrm/CRM/Custom/Form/Group.php).\r\nNotice: Undefined index: 10_a_b in CRM_Custom_Form_Group::getFormattedList() (line 547 of /home/web/civi_master/civicrm/CRM/Custom/Form/Group.php).\r\nNotice: Undefined index: 5_a_b in CRM_Custom_Form_Group::getFormattedList() (line 547 of /home/web/civi_master/civicrm/CRM/Custom/Form/Group.php).\r\nNotice: Undefined index: 6_a_b in CRM_Custom_Form_Group::getFormattedList() (line 547 of /home/web/civi_master/civicrm/CRM/Custom/Form/Group.php).\r\nNotice: Undefined index: 7_a_b in CRM_Custom_Form_Group::getFormattedList() (line 547 of /home/web/civi_master/civicrm/CRM/Custom/Form/Group.php).\r\nNotice: Undefined index: 8_a_b in CRM_Custom_Form_Group::getFormattedList() (line 547 of /home/web/civi_master/civicrm/CRM/Custom/Form/Group.php)."},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/247009241","html_url":"https://github.com/civicrm/civicrm-core/pull/9024#issuecomment-247009241","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9024","id":247009241,"user":{"login":"jitendrapurohit","id":5929648,"avatar_url":"https://avatars.githubusercontent.com/u/5929648?v=3","gravatar_id":"","url":"https://api.github.com/users/jitendrapurohit","html_url":"https://github.com/jitendrapurohit","followers_url":"https://api.github.com/users/jitendrapurohit/followers","following_url":"https://api.github.com/users/jitendrapurohit/following{/other_user}","gists_url":"https://api.github.com/users/jitendrapurohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jitendrapurohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitendrapurohit/subscriptions","organizations_url":"https://api.github.com/users/jitendrapurohit/orgs","repos_url":"https://api.github.com/users/jitendrapurohit/repos","events_url":"https://api.github.com/users/jitendrapurohit/events{/privacy}","received_events_url":"https://api.github.com/users/jitendrapurohit/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T13:17:16Z","updated_at":"2016-09-14T13:17:16Z","body":"There may be different places where this need to be handled. I've found another similar use-case at [convertFormValues()](https://github.com/civicrm/civicrm-core/blob/master/CRM/Contact/BAO/Query.php#L1541) function where `$formValues` is passed-by-ref to this function, gets modified in loop and is assigned to `$params`. One which is not assigned is the `relative_date` filter for contribution where `date_low` and `date_high` is updated [at this point](https://github.com/civicrm/civicrm-core/blob/master/CRM/Contact/BAO/Query.php#L1620) and finally assigned to $params at #L1634.\r\n\r\nSo, search on `contribution_relative_date` filter fails on Advanced Search for PHP 7 users."}}
{"actor":{"display_login":"jitendrapurohit"}}