{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/3976","repository_url":"https://api.github.com/repos/systemd/systemd","labels_url":"https://api.github.com/repos/systemd/systemd/issues/3976/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/3976/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/3976/events","html_url":"https://github.com/systemd/systemd/pull/3976","id":171667578,"number":3976,"title":"udev/path_id: introduce support for NVMe devices","user":{"login":"msekletar","id":719023,"avatar_url":"https://avatars.githubusercontent.com/u/719023?v=3","gravatar_id":"","url":"https://api.github.com/users/msekletar","html_url":"https://github.com/msekletar","followers_url":"https://api.github.com/users/msekletar/followers","following_url":"https://api.github.com/users/msekletar/following{/other_user}","gists_url":"https://api.github.com/users/msekletar/gists{/gist_id}","starred_url":"https://api.github.com/users/msekletar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msekletar/subscriptions","organizations_url":"https://api.github.com/users/msekletar/orgs","repos_url":"https://api.github.com/users/msekletar/repos","events_url":"https://api.github.com/users/msekletar/events{/privacy}","received_events_url":"https://api.github.com/users/msekletar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/systemd/systemd/labels/needs-discussion","name":"needs-discussion","color":"fbca04"},{"url":"https://api.github.com/repos/systemd/systemd/labels/udev","name":"udev","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-17T14:10:43Z","updated_at":"2016-08-17T14:43:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/3976","html_url":"https://github.com/systemd/systemd/pull/3976","diff_url":"https://github.com/systemd/systemd/pull/3976.diff","patch_url":"https://github.com/systemd/systemd/pull/3976.patch"},"body":"As a consequence of this change, following symlinks are now present,\r\n\r\n$ ls -l /dev/disk/by-path/*nvme*\r\nlrwxrwxrwx. 1 root root 13 Aug 17 04:25 /dev/disk/by-path/pci-0001:01:00.0-nvme-nvme0 -> ../../nvme0n1\r\nlrwxrwxrwx. 1 root root 15 Aug 17 04:25 /dev/disk/by-path/pci-0001:01:00.0-nvme-nvme0-part1 -> ../../nvme0n1p1"},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/240434334","html_url":"https://github.com/systemd/systemd/pull/3976#issuecomment-240434334","issue_url":"https://api.github.com/repos/systemd/systemd/issues/3976","id":240434334,"user":{"login":"keithbusch","id":4249494,"avatar_url":"https://avatars.githubusercontent.com/u/4249494?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbusch","html_url":"https://github.com/keithbusch","followers_url":"https://api.github.com/users/keithbusch/followers","following_url":"https://api.github.com/users/keithbusch/following{/other_user}","gists_url":"https://api.github.com/users/keithbusch/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbusch/subscriptions","organizations_url":"https://api.github.com/users/keithbusch/orgs","repos_url":"https://api.github.com/users/keithbusch/repos","events_url":"https://api.github.com/users/keithbusch/events{/privacy}","received_events_url":"https://api.github.com/users/keithbusch/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T14:43:37Z","updated_at":"2016-08-17T14:43:37Z","body":"These paths would be stable across reboots only if the pci enumeration doesn't change. A different enumeration could happen from adding/removing hardware, or maybe a BIOS update pads bus resources differently. But that's true for any storage accessed through a PCI controller.\r\n\r\nI'm not sure why udev_device_get_sysname is returning \"nvme0\" for the device \"nvme0n1\" in your example,, though. Why is it missing the \"n1\"? And probably useful to append \"nvme-\" to the path name since \"nvme\" is repeated in the block device's name.\r\n\r\nIf you need persistent paths, the NVMe block device's wwid attribute can be used to make entries in /dev/disk/by-id/."}}
{"actor":{"display_login":"keithbusch"}}