{"action":"created","comment":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/comments/71659368","id":71659368,"diff_hunk":"@@ -114,6 +118,10 @@ def _create_editor_widget(self, model_index, style_options, parent):\n         \"\"\"\n         # the default implementation just calls _create_widget for backwards\n         # compatibility.\n+\n+        if not model_index.isValid():\n+            return None","path":"python/views/widget_delegate.py","position":null,"original_position":17,"commit_id":"07131374edde93b650b2e2e1cbfbdd8a749ef23c","original_commit_id":"1727c592d2e11476ffbcdf5d01087587058453a0","user":{"login":"manneohrstrom","id":337710,"avatar_url":"https://avatars.githubusercontent.com/u/337710?v=3","gravatar_id":"","url":"https://api.github.com/users/manneohrstrom","html_url":"https://github.com/manneohrstrom","followers_url":"https://api.github.com/users/manneohrstrom/followers","following_url":"https://api.github.com/users/manneohrstrom/following{/other_user}","gists_url":"https://api.github.com/users/manneohrstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/manneohrstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manneohrstrom/subscriptions","organizations_url":"https://api.github.com/users/manneohrstrom/orgs","repos_url":"https://api.github.com/users/manneohrstrom/repos","events_url":"https://api.github.com/users/manneohrstrom/events{/privacy}","received_events_url":"https://api.github.com/users/manneohrstrom/received_events","type":"User","site_admin":false},"body":"that sounds great - personally, i think it's good to be overly cautios - that's how i tend to code too - recently, i found myself going back to code i had previously written thinking \"did i put this in just because i am overly cautious or is it addressing a specific use case?\". For that sort of situation, it's really great to have a quick comment to help explain.","created_at":"2016-07-21T07:37:27Z","updated_at":"2016-07-21T07:37:27Z","html_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/27#discussion_r71659368","pull_request_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/comments/71659368"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/27#discussion_r71659368"},"pull_request":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/27","id":75551103,"html_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/27","diff_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/27.diff","patch_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/27.patch","issue_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/27","number":27,"state":"closed","locked":false,"title":"#35963 Allows editor widgets to be used as delegates with the shotgunmodel","user":{"login":"josh-t","id":2604646,"avatar_url":"https://avatars.githubusercontent.com/u/2604646?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-t","html_url":"https://github.com/josh-t","followers_url":"https://api.github.com/users/josh-t/followers","following_url":"https://api.github.com/users/josh-t/following{/other_user}","gists_url":"https://api.github.com/users/josh-t/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-t/subscriptions","organizations_url":"https://api.github.com/users/josh-t/orgs","repos_url":"https://api.github.com/users/josh-t/repos","events_url":"https://api.github.com/users/josh-t/events{/privacy}","received_events_url":"https://api.github.com/users/josh-t/received_events","type":"User","site_admin":false},"body":"This change fleshes out the use of field widgets as delegates with a SG model backed view. Changes include:\r\n\r\n- editable views (such as sg tree view) can now edit SG model via field widget delegates\r\n- delegates pull data from model to display in editors and update model properly when closed\r\n- clicking on painted display delegate forwards click to underlying \"real\" widget. this allows urls to be clicked on to view entity/link fields in browser\r\n- field widgets are now aware when they're being used as delegates. this allows them to be a little smarter about how they process data when necessary. \r\n","created_at":"2016-06-28T21:10:37Z","updated_at":"2016-07-21T07:37:27Z","closed_at":"2016-07-19T13:23:21Z","merged_at":null,"merge_commit_sha":"5f5fb60b6985f781fbd7604531e9af4545a9c459","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/27/commits","review_comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/27/comments","review_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/27/comments","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/statuses/07131374edde93b650b2e2e1cbfbdd8a749ef23c","head":{"label":"shotgunsoftware:35963_sgmodel_widgets","ref":"35963_sgmodel_widgets","sha":"07131374edde93b650b2e2e1cbfbdd8a749ef23c","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":19910716,"name":"tk-framework-qtwidgets","full_name":"shotgunsoftware/tk-framework-qtwidgets","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets","description":"A collection of Toolkit related QT Widgets","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/deployments","created_at":"2014-05-18T13:12:00Z","updated_at":"2016-03-07T00:35:48Z","pushed_at":"2016-07-21T01:31:43Z","git_url":"git://github.com/shotgunsoftware/tk-framework-qtwidgets.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-qtwidgets.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets","homepage":"","size":51133,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"shotgunsoftware:master","ref":"master","sha":"69532ce73d08fcec5ef6f1739916b0a40aaa77e9","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":19910716,"name":"tk-framework-qtwidgets","full_name":"shotgunsoftware/tk-framework-qtwidgets","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets","description":"A collection of Toolkit related QT Widgets","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/deployments","created_at":"2014-05-18T13:12:00Z","updated_at":"2016-03-07T00:35:48Z","pushed_at":"2016-07-21T01:31:43Z","git_url":"git://github.com/shotgunsoftware/tk-framework-qtwidgets.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-qtwidgets.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-qtwidgets","homepage":"","size":51133,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/27"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-qtwidgets/pull/27"},"issue":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/27"},"comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-qtwidgets/statuses/07131374edde93b650b2e2e1cbfbdd8a749ef23c"}}}}
{"actor":{"display_login":"manneohrstrom"}}