{"action":"created","issue":{"url":"https://api.github.com/repos/mamedev/mame/issues/752","repository_url":"https://api.github.com/repos/mamedev/mame","labels_url":"https://api.github.com/repos/mamedev/mame/issues/752/labels{/name}","comments_url":"https://api.github.com/repos/mamedev/mame/issues/752/comments","events_url":"https://api.github.com/repos/mamedev/mame/issues/752/events","html_url":"https://github.com/mamedev/mame/issues/752","id":143898124,"number":752,"title":"request to add Donkey Kong variation (with patch :) )","user":{"login":"2011","id":550150,"avatar_url":"https://avatars.githubusercontent.com/u/550150?v=3","gravatar_id":"","url":"https://api.github.com/users/2011","html_url":"https://github.com/2011","followers_url":"https://api.github.com/users/2011/followers","following_url":"https://api.github.com/users/2011/following{/other_user}","gists_url":"https://api.github.com/users/2011/gists{/gist_id}","starred_url":"https://api.github.com/users/2011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2011/subscriptions","organizations_url":"https://api.github.com/users/2011/orgs","repos_url":"https://api.github.com/users/2011/repos","events_url":"https://api.github.com/users/2011/events{/privacy}","received_events_url":"https://api.github.com/users/2011/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-28T05:38:15Z","updated_at":"2016-03-29T11:22:15Z","closed_at":null,"body":"Hi,\r\n\r\nHope this is the right place for this.\r\n\r\nOn Jeff's Rom Hack, there is a page (actually can't find it from the site, but search engines list it) that describes how user actions affect whether or not a barrel comes down a ladder.\r\n\r\nhttp://jeffsromhack.com/products/donkeykong_tech.htm\r\n\r\nHe has edited a ROM (that he will send upon request) that changes the color of barrels that the player has caused to come down a ladder. This is mostly a demonstration / learning tool, but I actually enjoy playing with it, and do so frequently. For a long time, I just ignored the ROM mismatch error in MAME, but then the checking became strict, and I actually had to go in and patch the source code. I have a reasonable aptitude for that, but I am not an expert by any means (I don't work with code or in technology).\r\n\r\nAfter I recently upgraded MAME (to 0.168), I thought about seeing if I could ask to have this hack included in the regular source code (so I wouldn't have to patch it myself every time :) ). I have never submitted a real patch to an open source project before, so this is my first go at it. I have nicknamed this hack dkongbcc (for something like Donkey Kong with barrel control coloring).\r\n\r\nHope that somebody else finds this worthwhile.\r\n\r\n```\r\n--- src/mame/arcade.lst  2015-11-25 10:01:04.000000000 +0000\r\n+++ src/mame/arcade.lst  2016-02-15 00:00:00.000000000 +0000\r\n@@ -1233,6 +1233,7 @@\r\n dkongj          // (c) 1981 Nintendo\r\n dkongjo         // (c) 1981 Nintendo\r\n dkongjo1        // (c) 1981 Nintendo\r\n+dkongbcc        // hack from Jeff's Romhack (barrel control color)\r\n dkongf          // hack from Jeff's Romhack\r\n dkongpe         // hack Pauline Edition\r\n dkongx          // hack\r\n--- src/mame/drivers/dkong.cpp  2015-11-25 10:01:06.000000000 +0000\r\n+++ src/mame/drivers/dkong.cpp  2016-02-15 00:00:00.000000000 +0000\r\n@@ -2013,7 +2013,36 @@\r\n        ROM_LOAD( \"c-2j.bpr\",     0x0100, 0x0100, CRC(d6412358) SHA1(f9c872da2fe8e800574ae3bf483fb3ccacc92eb3) ) /* palette high 4 bits (inverted) */\r\n        ROM_LOAD( \"v-5e.bpr\",     0x0200, 0x0100, CRC(b869b8f5) SHA1(c2bdccbf2654b64ea55cd589fd21323a9178a660) ) /* character color codes on a per-column basis */\r\n ROM_END\r\n-\r\n+\r\n+ROM_START( dkongbcc )\r\n+       ROM_REGION( 0x10000, \"maincpu\", 0 )\r\n+       ROM_LOAD( \"c_5et_g.bin\",  0x0000, 0x1000, CRC(eec71586) SHA1(8c9c05c919265d6b930e5088e869c4b44264ded4) )\r\n+       ROM_LOAD( \"c_5ct_g.bin\",  0x1000, 0x1000, CRC(49200edb) SHA1(e40a19700196dc7b2ae766cbef51867856c986aa) )\r\n+       ROM_LOAD( \"c_5bt_g.bin\",  0x2000, 0x1000, CRC(56f7c409) SHA1(265817ce17951d49b95a2361c5cc3032620aae96) )\r\n+       ROM_LOAD( \"c_5at_g.bin\",  0x3000, 0x1000, CRC(03b56372) SHA1(fea19bb4c46c88c26943ccd910b560cecd5dc44c) )\r\n+       /* space for diagnostic ROM */\r\n+\r\n+       ROM_REGION( 0x1800, \"soundcpu\", 0 ) /* sound */\r\n+       ROM_LOAD( \"s_3i_b.bin\",   0x0000, 0x0800, CRC(45a4ed06) SHA1(144d24464c1f9f01894eb12f846952290e6e32ef) )\r\n+       ROM_RELOAD(               0x0800, 0x0800 )\r\n+       ROM_LOAD( \"s_3j_b.bin\",   0x1000, 0x0800, CRC(4743fe92) SHA1(6c82b57637c0212a580591397e6a5a1718f19fd2) )\r\n+\r\n+       ROM_REGION( 0x1000, \"gfx1\", 0 )\r\n+       ROM_LOAD( \"v_5h_b.bin\",   0x0000, 0x0800, CRC(12c8c95d) SHA1(a57ff5a231c45252a63b354137c920a1379b70a3) )\r\n+       ROM_LOAD( \"v_3pt.bin\",    0x0800, 0x0800, CRC(15e9c5e9) SHA1(976eb1e18c74018193a35aa86cff482ebfc5cc4e) )\r\n+\r\n+       ROM_REGION( 0x2000, \"gfx2\", 0 )\r\n+       ROM_LOAD( \"l_4m_b.bin\",   0x0000, 0x0800, CRC(59f8054d) SHA1(793dba9bf5a5fe76328acdfb90815c243d2a65f1) )\r\n+       ROM_LOAD( \"l_4n_b.bin\",   0x0800, 0x0800, CRC(672e4714) SHA1(92e5d379f4838ac1fa44d448ce7d142dae42102f) )\r\n+       ROM_LOAD( \"l_4r_b.bin\",   0x1000, 0x0800, CRC(feaa59ee) SHA1(ecf95db5a20098804fc8bd59232c66e2e0ed3db4) )\r\n+       ROM_LOAD( \"l_4s_b.bin\",   0x1800, 0x0800, CRC(20f2ef7e) SHA1(3bc482a38bf579033f50082748ee95205b0f673d) )\r\n+\r\n+       ROM_REGION( 0x0300, \"proms\", 0 )\r\n+       ROM_LOAD( \"c-2k.bpr\",     0x0000, 0x0100, CRC(e273ede5) SHA1(b50ec9e1837c00c20fb2a4369ec7dd0358321127) ) /* palette low 4 bits (inverted) */\r\n+       ROM_LOAD( \"c-2j.bpr\",     0x0100, 0x0100, CRC(d6412358) SHA1(f9c872da2fe8e800574ae3bf483fb3ccacc92eb3) ) /* palette high 4 bits (inverted) */\r\n+       ROM_LOAD( \"v-5e.bpr\",     0x0200, 0x0100, CRC(b869b8f5) SHA1(c2bdccbf2654b64ea55cd589fd21323a9178a660) ) /* character color codes on a per-column basis */\r\n+ROM_END\r\n+\r\n ROM_START( dkongo )\r\n        ROM_REGION( 0x10000, \"maincpu\", 0 )\r\n        ROM_LOAD( \"c_5f_b.bin\",   0x0000, 0x1000, CRC(424f2b11) SHA1(e4f096f2bbd37281f42a5f8e083738f55c07f3dd) )    /* tkg3c.5f */\r\n@@ -3315,6 +3344,7 @@\r\n \r\n GAME( 1981, dkong,     0,        dkong2b,   dkong,    driver_device, 0,        ROT90,  \"Nintendo of America\", \"Donkey Kong (US set 1)\", MACHINE_SUPPORTS_SAVE )\r\n GAME( 1981, dkonghrd,  dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  \"Nintendo of America\", \"Donkey Kong (hard kit)\", MACHINE_SUPPORTS_SAVE ) // not sure if original or bootleg (see notes on top of driver file)\r\n+GAME( 1981, dkongbcc, dkong,    dkong2b,  dkong, driver_device,          0,  ROT90, \"hack\", \"Donkey Kong (US set 1 with barrel control coloring)\", MACHINE_SUPPORTS_SAVE )\r\n GAME( 1981, dkongo,    dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  \"Nintendo\", \"Donkey Kong (US set 2)\", MACHINE_SUPPORTS_SAVE )\r\n GAME( 1981, dkongj,    dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  \"Nintendo\", \"Donkey Kong (Japan set 1)\", MACHINE_SUPPORTS_SAVE )\r\n GAME( 1981, dkongjo,   dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  \"Nintendo\", \"Donkey Kong (Japan set 2)\", MACHINE_SUPPORTS_SAVE )\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mamedev/mame/issues/comments/202837726","html_url":"https://github.com/mamedev/mame/issues/752#issuecomment-202837726","issue_url":"https://api.github.com/repos/mamedev/mame/issues/752","id":202837726,"user":{"login":"NULUSIOS","id":6065886,"avatar_url":"https://avatars.githubusercontent.com/u/6065886?v=3","gravatar_id":"","url":"https://api.github.com/users/NULUSIOS","html_url":"https://github.com/NULUSIOS","followers_url":"https://api.github.com/users/NULUSIOS/followers","following_url":"https://api.github.com/users/NULUSIOS/following{/other_user}","gists_url":"https://api.github.com/users/NULUSIOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NULUSIOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NULUSIOS/subscriptions","organizations_url":"https://api.github.com/users/NULUSIOS/orgs","repos_url":"https://api.github.com/users/NULUSIOS/repos","events_url":"https://api.github.com/users/NULUSIOS/events{/privacy}","received_events_url":"https://api.github.com/users/NULUSIOS/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T11:22:15Z","updated_at":"2016-03-29T11:22:15Z","body":"This is indeed something for HBMAME.\r\n"}}