{"action":"closed","number":354,"pull_request":{"url":"https://api.github.com/repos/luin/ioredis/pulls/354","id":79869923,"html_url":"https://github.com/luin/ioredis/pull/354","diff_url":"https://github.com/luin/ioredis/pull/354.diff","patch_url":"https://github.com/luin/ioredis/pull/354.patch","issue_url":"https://api.github.com/repos/luin/ioredis/issues/354","number":354,"state":"closed","locked":false,"title":"Reject with general error in Redis#connect","user":{"login":"Gerhut","id":2500247,"avatar_url":"https://avatars.githubusercontent.com/u/2500247?v=3","gravatar_id":"","url":"https://api.github.com/users/Gerhut","html_url":"https://github.com/Gerhut","followers_url":"https://api.github.com/users/Gerhut/followers","following_url":"https://api.github.com/users/Gerhut/following{/other_user}","gists_url":"https://api.github.com/users/Gerhut/gists{/gist_id}","starred_url":"https://api.github.com/users/Gerhut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gerhut/subscriptions","organizations_url":"https://api.github.com/users/Gerhut/orgs","repos_url":"https://api.github.com/users/Gerhut/repos","events_url":"https://api.github.com/users/Gerhut/events{/privacy}","received_events_url":"https://api.github.com/users/Gerhut/received_events","type":"User","site_admin":false},"body":"Now it rejects with an `undefined`, which will cause warnings.","created_at":"2016-08-03T08:55:59Z","updated_at":"2016-08-08T02:41:43Z","closed_at":"2016-08-08T02:41:43Z","merged_at":"2016-08-08T02:41:43Z","merge_commit_sha":"8f7a436e99e697fc8da13be954e8c10db0671110","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/luin/ioredis/pulls/354/commits","review_comments_url":"https://api.github.com/repos/luin/ioredis/pulls/354/comments","review_comment_url":"https://api.github.com/repos/luin/ioredis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luin/ioredis/issues/354/comments","statuses_url":"https://api.github.com/repos/luin/ioredis/statuses/b68887af0bad39e65cd2e81f04143e53006c1275","head":{"label":"SyaOS:master","ref":"master","sha":"b68887af0bad39e65cd2e81f04143e53006c1275","user":{"login":"SyaOS","id":11691494,"avatar_url":"https://avatars.githubusercontent.com/u/11691494?v=3","gravatar_id":"","url":"https://api.github.com/users/SyaOS","html_url":"https://github.com/SyaOS","followers_url":"https://api.github.com/users/SyaOS/followers","following_url":"https://api.github.com/users/SyaOS/following{/other_user}","gists_url":"https://api.github.com/users/SyaOS/gists{/gist_id}","starred_url":"https://api.github.com/users/SyaOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyaOS/subscriptions","organizations_url":"https://api.github.com/users/SyaOS/orgs","repos_url":"https://api.github.com/users/SyaOS/repos","events_url":"https://api.github.com/users/SyaOS/events{/privacy}","received_events_url":"https://api.github.com/users/SyaOS/received_events","type":"Organization","site_admin":false},"repo":{"id":64829546,"name":"ioredis","full_name":"SyaOS/ioredis","owner":{"login":"SyaOS","id":11691494,"avatar_url":"https://avatars.githubusercontent.com/u/11691494?v=3","gravatar_id":"","url":"https://api.github.com/users/SyaOS","html_url":"https://github.com/SyaOS","followers_url":"https://api.github.com/users/SyaOS/followers","following_url":"https://api.github.com/users/SyaOS/following{/other_user}","gists_url":"https://api.github.com/users/SyaOS/gists{/gist_id}","starred_url":"https://api.github.com/users/SyaOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyaOS/subscriptions","organizations_url":"https://api.github.com/users/SyaOS/orgs","repos_url":"https://api.github.com/users/SyaOS/repos","events_url":"https://api.github.com/users/SyaOS/events{/privacy}","received_events_url":"https://api.github.com/users/SyaOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SyaOS/ioredis","description":"A robust, performance-focused and full-featured Redis client for Node and io.js.","fork":true,"url":"https://api.github.com/repos/SyaOS/ioredis","forks_url":"https://api.github.com/repos/SyaOS/ioredis/forks","keys_url":"https://api.github.com/repos/SyaOS/ioredis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SyaOS/ioredis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SyaOS/ioredis/teams","hooks_url":"https://api.github.com/repos/SyaOS/ioredis/hooks","issue_events_url":"https://api.github.com/repos/SyaOS/ioredis/issues/events{/number}","events_url":"https://api.github.com/repos/SyaOS/ioredis/events","assignees_url":"https://api.github.com/repos/SyaOS/ioredis/assignees{/user}","branches_url":"https://api.github.com/repos/SyaOS/ioredis/branches{/branch}","tags_url":"https://api.github.com/repos/SyaOS/ioredis/tags","blobs_url":"https://api.github.com/repos/SyaOS/ioredis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SyaOS/ioredis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SyaOS/ioredis/git/refs{/sha}","trees_url":"https://api.github.com/repos/SyaOS/ioredis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SyaOS/ioredis/statuses/{sha}","languages_url":"https://api.github.com/repos/SyaOS/ioredis/languages","stargazers_url":"https://api.github.com/repos/SyaOS/ioredis/stargazers","contributors_url":"https://api.github.com/repos/SyaOS/ioredis/contributors","subscribers_url":"https://api.github.com/repos/SyaOS/ioredis/subscribers","subscription_url":"https://api.github.com/repos/SyaOS/ioredis/subscription","commits_url":"https://api.github.com/repos/SyaOS/ioredis/commits{/sha}","git_commits_url":"https://api.github.com/repos/SyaOS/ioredis/git/commits{/sha}","comments_url":"https://api.github.com/repos/SyaOS/ioredis/comments{/number}","issue_comment_url":"https://api.github.com/repos/SyaOS/ioredis/issues/comments{/number}","contents_url":"https://api.github.com/repos/SyaOS/ioredis/contents/{+path}","compare_url":"https://api.github.com/repos/SyaOS/ioredis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SyaOS/ioredis/merges","archive_url":"https://api.github.com/repos/SyaOS/ioredis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SyaOS/ioredis/downloads","issues_url":"https://api.github.com/repos/SyaOS/ioredis/issues{/number}","pulls_url":"https://api.github.com/repos/SyaOS/ioredis/pulls{/number}","milestones_url":"https://api.github.com/repos/SyaOS/ioredis/milestones{/number}","notifications_url":"https://api.github.com/repos/SyaOS/ioredis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SyaOS/ioredis/labels{/name}","releases_url":"https://api.github.com/repos/SyaOS/ioredis/releases{/id}","deployments_url":"https://api.github.com/repos/SyaOS/ioredis/deployments","created_at":"2016-08-03T08:34:37Z","updated_at":"2016-08-03T08:34:38Z","pushed_at":"2016-08-04T06:50:19Z","git_url":"git://github.com/SyaOS/ioredis.git","ssh_url":"git@github.com:SyaOS/ioredis.git","clone_url":"https://github.com/SyaOS/ioredis.git","svn_url":"https://github.com/SyaOS/ioredis","homepage":"","size":1161,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"luin:master","ref":"master","sha":"f1cadffc39f745caab4d6f636412799a8a2749d7","user":{"login":"luin","id":635902,"avatar_url":"https://avatars.githubusercontent.com/u/635902?v=3","gravatar_id":"","url":"https://api.github.com/users/luin","html_url":"https://github.com/luin","followers_url":"https://api.github.com/users/luin/followers","following_url":"https://api.github.com/users/luin/following{/other_user}","gists_url":"https://api.github.com/users/luin/gists{/gist_id}","starred_url":"https://api.github.com/users/luin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luin/subscriptions","organizations_url":"https://api.github.com/users/luin/orgs","repos_url":"https://api.github.com/users/luin/repos","events_url":"https://api.github.com/users/luin/events{/privacy}","received_events_url":"https://api.github.com/users/luin/received_events","type":"User","site_admin":false},"repo":{"id":33293613,"name":"ioredis","full_name":"luin/ioredis","owner":{"login":"luin","id":635902,"avatar_url":"https://avatars.githubusercontent.com/u/635902?v=3","gravatar_id":"","url":"https://api.github.com/users/luin","html_url":"https://github.com/luin","followers_url":"https://api.github.com/users/luin/followers","following_url":"https://api.github.com/users/luin/following{/other_user}","gists_url":"https://api.github.com/users/luin/gists{/gist_id}","starred_url":"https://api.github.com/users/luin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luin/subscriptions","organizations_url":"https://api.github.com/users/luin/orgs","repos_url":"https://api.github.com/users/luin/repos","events_url":"https://api.github.com/users/luin/events{/privacy}","received_events_url":"https://api.github.com/users/luin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luin/ioredis","description":"A robust, performance-focused and full-featured Redis client for Node and io.js.","fork":false,"url":"https://api.github.com/repos/luin/ioredis","forks_url":"https://api.github.com/repos/luin/ioredis/forks","keys_url":"https://api.github.com/repos/luin/ioredis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luin/ioredis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luin/ioredis/teams","hooks_url":"https://api.github.com/repos/luin/ioredis/hooks","issue_events_url":"https://api.github.com/repos/luin/ioredis/issues/events{/number}","events_url":"https://api.github.com/repos/luin/ioredis/events","assignees_url":"https://api.github.com/repos/luin/ioredis/assignees{/user}","branches_url":"https://api.github.com/repos/luin/ioredis/branches{/branch}","tags_url":"https://api.github.com/repos/luin/ioredis/tags","blobs_url":"https://api.github.com/repos/luin/ioredis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luin/ioredis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luin/ioredis/git/refs{/sha}","trees_url":"https://api.github.com/repos/luin/ioredis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luin/ioredis/statuses/{sha}","languages_url":"https://api.github.com/repos/luin/ioredis/languages","stargazers_url":"https://api.github.com/repos/luin/ioredis/stargazers","contributors_url":"https://api.github.com/repos/luin/ioredis/contributors","subscribers_url":"https://api.github.com/repos/luin/ioredis/subscribers","subscription_url":"https://api.github.com/repos/luin/ioredis/subscription","commits_url":"https://api.github.com/repos/luin/ioredis/commits{/sha}","git_commits_url":"https://api.github.com/repos/luin/ioredis/git/commits{/sha}","comments_url":"https://api.github.com/repos/luin/ioredis/comments{/number}","issue_comment_url":"https://api.github.com/repos/luin/ioredis/issues/comments{/number}","contents_url":"https://api.github.com/repos/luin/ioredis/contents/{+path}","compare_url":"https://api.github.com/repos/luin/ioredis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luin/ioredis/merges","archive_url":"https://api.github.com/repos/luin/ioredis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luin/ioredis/downloads","issues_url":"https://api.github.com/repos/luin/ioredis/issues{/number}","pulls_url":"https://api.github.com/repos/luin/ioredis/pulls{/number}","milestones_url":"https://api.github.com/repos/luin/ioredis/milestones{/number}","notifications_url":"https://api.github.com/repos/luin/ioredis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luin/ioredis/labels{/name}","releases_url":"https://api.github.com/repos/luin/ioredis/releases{/id}","deployments_url":"https://api.github.com/repos/luin/ioredis/deployments","created_at":"2015-04-02T06:42:46Z","updated_at":"2016-08-08T00:02:36Z","pushed_at":"2016-08-08T02:41:43Z","git_url":"git://github.com/luin/ioredis.git","ssh_url":"git@github.com:luin/ioredis.git","clone_url":"https://github.com/luin/ioredis.git","svn_url":"https://github.com/luin/ioredis","homepage":"","size":1491,"stargazers_count":2094,"watchers_count":2094,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":176,"mirror_url":null,"open_issues_count":25,"forks":176,"open_issues":25,"watchers":2094,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luin/ioredis/pulls/354"},"html":{"href":"https://github.com/luin/ioredis/pull/354"},"issue":{"href":"https://api.github.com/repos/luin/ioredis/issues/354"},"comments":{"href":"https://api.github.com/repos/luin/ioredis/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/luin/ioredis/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/luin/ioredis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luin/ioredis/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/luin/ioredis/statuses/b68887af0bad39e65cd2e81f04143e53006c1275"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"luin","id":635902,"avatar_url":"https://avatars.githubusercontent.com/u/635902?v=3","gravatar_id":"","url":"https://api.github.com/users/luin","html_url":"https://github.com/luin","followers_url":"https://api.github.com/users/luin/followers","following_url":"https://api.github.com/users/luin/following{/other_user}","gists_url":"https://api.github.com/users/luin/gists{/gist_id}","starred_url":"https://api.github.com/users/luin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luin/subscriptions","organizations_url":"https://api.github.com/users/luin/orgs","repos_url":"https://api.github.com/users/luin/repos","events_url":"https://api.github.com/users/luin/events{/privacy}","received_events_url":"https://api.github.com/users/luin/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"luin"}}