{"action":"created","issue":{"url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/5667","repository_url":"https://api.github.com/repos/linuxmint/Cinnamon","labels_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/5667/labels{/name}","comments_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/5667/comments","events_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/5667/events","html_url":"https://github.com/linuxmint/Cinnamon/issues/5667","id":176154878,"number":5667,"title":"Dangerous get_file_contents_utf8_sync vs we have not other good option.","user":{"login":"lestcape","id":1389572,"avatar_url":"https://avatars.githubusercontent.com/u/1389572?v=3","gravatar_id":"","url":"https://api.github.com/users/lestcape","html_url":"https://github.com/lestcape","followers_url":"https://api.github.com/users/lestcape/followers","following_url":"https://api.github.com/users/lestcape/following{/other_user}","gists_url":"https://api.github.com/users/lestcape/gists{/gist_id}","starred_url":"https://api.github.com/users/lestcape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lestcape/subscriptions","organizations_url":"https://api.github.com/users/lestcape/orgs","repos_url":"https://api.github.com/users/lestcape/repos","events_url":"https://api.github.com/users/lestcape/events{/privacy}","received_events_url":"https://api.github.com/users/lestcape/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-10T03:56:04Z","updated_at":"2016-09-14T02:21:56Z","closed_at":"2016-09-14T01:16:30Z","body":"There are not an asynchronous version of: get_file_contents_utf8\r\n\r\nI think that will be good provide one, also get_file_contents_utf8_sync is used  inside the cinnamon code. I know there are a big difference of where get_file_contents_utf8_sync is used in one place or in another. And it's not a big deal when is used for example when the applet is loading, but could be a big problem if it' used to load a file when the file content is changed."},"comment":{"url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/comments/246886448","html_url":"https://github.com/linuxmint/Cinnamon/issues/5667#issuecomment-246886448","issue_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/5667","id":246886448,"user":{"login":"lestcape","id":1389572,"avatar_url":"https://avatars.githubusercontent.com/u/1389572?v=3","gravatar_id":"","url":"https://api.github.com/users/lestcape","html_url":"https://github.com/lestcape","followers_url":"https://api.github.com/users/lestcape/followers","following_url":"https://api.github.com/users/lestcape/following{/other_user}","gists_url":"https://api.github.com/users/lestcape/gists{/gist_id}","starred_url":"https://api.github.com/users/lestcape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lestcape/subscriptions","organizations_url":"https://api.github.com/users/lestcape/orgs","repos_url":"https://api.github.com/users/lestcape/repos","events_url":"https://api.github.com/users/lestcape/events{/privacy}","received_events_url":"https://api.github.com/users/lestcape/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T02:21:56Z","updated_at":"2016-09-14T02:21:56Z","body":"Well, i don't think that will be common load more than 1mb. Yes i agree which you, transfer the data to the javascript objects maybe it`s the problem, like this is not an asynchronous operation.\r\n\r\nAnyway, you can test the same to compare your solution which the gnome one:\r\nhttps://people.gnome.org/~gcampagna/docs/Gio-2.0/Gio.DataInputStream.read_until_async.html\r\n\r\nThe problem with the gnome one, it's how decode the string from the utf-8 encode inside cjs."}}
{"actor":{"display_login":"lestcape"}}