{"action":"created","issue":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11088","repository_url":"https://api.github.com/repos/dimagi/commcare-hq","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11088/labels{/name}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11088/comments","events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11088/events","html_url":"https://github.com/dimagi/commcare-hq/pull/11088","id":145791666,"number":11088,"title":"Inline editing","user":{"login":"orangejenny","id":1486591,"avatar_url":"https://avatars.githubusercontent.com/u/1486591?v=3","gravatar_id":"","url":"https://api.github.com/users/orangejenny","html_url":"https://github.com/orangejenny","followers_url":"https://api.github.com/users/orangejenny/followers","following_url":"https://api.github.com/users/orangejenny/following{/other_user}","gists_url":"https://api.github.com/users/orangejenny/gists{/gist_id}","starred_url":"https://api.github.com/users/orangejenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangejenny/subscriptions","organizations_url":"https://api.github.com/users/orangejenny/orgs","repos_url":"https://api.github.com/users/orangejenny/repos","events_url":"https://api.github.com/users/orangejenny/events{/privacy}","received_events_url":"https://api.github.com/users/orangejenny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dimagi/commcare-hq/labels/Open%20for%20review:%20hold%20off%20on%20merge","name":"Open for review: hold off on merge","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-04T20:14:53Z","updated_at":"2016-04-05T14:46:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11088","html_url":"https://github.com/dimagi/commcare-hq/pull/11088","diff_url":"https://github.com/dimagi/commcare-hq/pull/11088.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/11088.patch"},"body":"Opening for feedback from @dimagi/js-team and @dimagi/product  Won't be ready to merge until\r\n- [ ] Knockout gets upgraded to 3.3 (currently on staging: https://github.com/dimagi/commcare-hq/pull/11003)\r\n- [ ] Widget supports multiple languages, so that app/module/form names can use it\r\n- [ ] App/module/form name and comment get moved to the top of those pages, above the accordions, as described in spec (https://docs.google.com/document/d/1BkHdxoTAd66wr23eFHJb_b5ZT1ZzDzjK8MO5E6VyfOs/edit)\r\n- [ ] switch app/form/module names & comments to ajax save (?)\r\n- [ ] QA/UAT also likely a good idea\r\n\r\nRead only view:\r\n<img width=\"476\" alt=\"screen shot 2016-04-04 at 4 06 31 pm\" src=\"https://cloud.githubusercontent.com/assets/1486591/14261712/f1b67896-fa7f-11e5-9b67-7f01c013a3e2.png\">\r\n\r\nOn hover:\r\n<img width=\"481\" alt=\"screen shot 2016-04-04 at 4 06 36 pm\" src=\"https://cloud.githubusercontent.com/assets/1486591/14261718/f91e82ea-fa7f-11e5-9afc-7114391d28db.png\">\r\n\r\nOn click:\r\n<img width=\"474\" alt=\"screen shot 2016-04-04 at 4 06 45 pm\" src=\"https://cloud.githubusercontent.com/assets/1486591/14261725/fe5f822c-fa7f-11e5-85f7-27d5f406e83f.png\">\r\n\r\nWhen text is blank (there's also an option for placeholder text):\r\n<img width=\"472\" alt=\"screen shot 2016-04-04 at 4 06 55 pm\" src=\"https://cloud.githubusercontent.com/assets/1486591/14261731/0529061e-fa80-11e5-8d6a-86d087e67dbc.png\">\r\n\r\nRead-only on deploy page:\r\n<img width=\"222\" alt=\"screen shot 2016-04-04 at 4 07 17 pm\" src=\"https://cloud.githubusercontent.com/assets/1486591/14261758/24773856-fa80-11e5-80ea-d05e56ff182f.png\">\r\n\r\nEditing on deploy page:\r\n<img width=\"352\" alt=\"screen shot 2016-04-04 at 4 07 29 pm\" src=\"https://cloud.githubusercontent.com/assets/1486591/14261767/2b71c022-fa80-11e5-9dfc-450c78dd3ac8.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments/205839868","html_url":"https://github.com/dimagi/commcare-hq/pull/11088#issuecomment-205839868","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11088","id":205839868,"user":{"login":"dimagimon","id":1179034,"avatar_url":"https://avatars.githubusercontent.com/u/1179034?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagimon","html_url":"https://github.com/dimagimon","followers_url":"https://api.github.com/users/dimagimon/followers","following_url":"https://api.github.com/users/dimagimon/following{/other_user}","gists_url":"https://api.github.com/users/dimagimon/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagimon/subscriptions","organizations_url":"https://api.github.com/users/dimagimon/orgs","repos_url":"https://api.github.com/users/dimagimon/repos","events_url":"https://api.github.com/users/dimagimon/events{/privacy}","received_events_url":"https://api.github.com/users/dimagimon/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T14:46:34Z","updated_at":"2016-04-05T14:46:34Z","body":"There are 27 errors:\n\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 126 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 115 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 122 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 111 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 118 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 125 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 107 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 114 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 121 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 110 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 130 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 117 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 124 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 106 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 113 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 120 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 109 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 129 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 116 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 105 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 112 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 127 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 108 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 128 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 123 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 104 - Bad escaping of EOL. Use option multistr if needed.\n* corehq/apps/style/static/style/ko/components/inline_edit.js, line 119 - Bad escaping of EOL. Use option multistr if needed.\n"}}