{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/91335704","pull_request_review_id":11844492,"id":91335704,"diff_hunk":"@@ -46,32 +46,59 @@\n \n include_recipe \"neutron::common_config\"\n \n+directory '/etc/neutron/neutron-server.conf.d' do\n+  owner node[:neutron][:user]\n+  group node[:neutron][:group]\n+  mode '0755'\n+  recursive true\n+  action :create\n+end\n+\n+# enable/disable nsx.ini or ml2_conf for neutron-server\n if node[:neutron][:networking_plugin] == \"vmware\"\n-  plugin_cfg_path = \"/etc/neutron/plugins/vmware/nsx.ini\"\n+  vmware_link_action = 'create'\n+  ml2_conf_link_action = 'delete'\n else\n-  plugin_cfg_path = \"/etc/neutron/plugins/ml2/ml2_conf.ini\"\n+  vmware_link_action = 'delete'\n+  ml2_conf_link_action = 'create'\n end\n \n-template \"/etc/sysconfig/neutron\" do\n-  source \"sysconfig.neutron.erb\"\n-  owner \"root\"\n-  group \"root\"\n-  mode 0640\n-  # whenever changing plugin_config_file here, keep in mind to change the call\n-  # to neutron-db-manage too\n-  plugin_cfgs = plugin_cfg_path\n-  if node[:neutron][:networking_plugin] == \"ml2\"\n-    if node[:neutron][:ml2_mechanism_drivers].include?(\"cisco_nexus\")\n-      plugin_cfgs += \" /etc/neutron/plugins/ml2/ml2_conf_cisco.ini\"\n-    elsif node[:neutron][:ml2_mechanism_drivers].include?(\"cisco_apic_ml2\") ||\n-        node[:neutron][:ml2_mechanism_drivers].include?(\"apic_gbp\")\n-      plugin_cfgs += \" /etc/neutron/plugins/ml2/ml2_conf_cisco_apic.ini\"\n-    end\n-  end\n-  variables(\n-    plugin_config_file: plugin_cfgs\n-  )\n-  only_if { node[:platform_family] == \"suse\" }\n+link '/etc/neutron/neutron-server.conf.d/ml2_conf.ini.conf' do","path":"chef/cookbooks/neutron/recipes/server.rb","position":43,"original_position":43,"commit_id":"f553b93fa240bdd1c260d5815b51e0a31bc2677f","original_commit_id":"f553b93fa240bdd1c260d5815b51e0a31bc2677f","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)","created_at":"2016-12-07T16:51:56Z","updated_at":"2016-12-07T16:51:56Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/643#discussion_r91335704","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/643","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/91335704"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/643#discussion_r91335704"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/643"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/643","id":96962598,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/643","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/643.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/643.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/643","number":643,"state":"open","locked":false,"title":"neutron: Replace /etc/sysconfig/neutron usage with links","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"body":"/etc/sysconfig/neutron is no longer supported. Instead use symlinks\r\nto enable/disable specific configs for the neutron-server.","created_at":"2016-12-07T16:51:43Z","updated_at":"2016-12-07T16:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"400b492c3e990819f131ed418f6a126f2c0f9df9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/643/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/643/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/643/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/f553b93fa240bdd1c260d5815b51e0a31bc2677f","head":{"label":"toabctl:systemd-neutron","ref":"systemd-neutron","sha":"f553b93fa240bdd1c260d5815b51e0a31bc2677f","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"repo":{"id":40896453,"name":"crowbar-openstack","full_name":"toabctl/crowbar-openstack","owner":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toabctl/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/toabctl/crowbar-openstack","forks_url":"https://api.github.com/repos/toabctl/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/toabctl/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toabctl/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toabctl/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/toabctl/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/toabctl/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/toabctl/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/toabctl/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/toabctl/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toabctl/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/toabctl/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/toabctl/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/toabctl/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/toabctl/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/toabctl/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/toabctl/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/toabctl/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/toabctl/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/toabctl/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toabctl/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/toabctl/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toabctl/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/toabctl/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/toabctl/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/toabctl/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toabctl/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/toabctl/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/toabctl/crowbar-openstack/deployments","created_at":"2015-08-17T13:21:21Z","updated_at":"2016-01-18T17:32:04Z","pushed_at":"2016-12-07T16:51:24Z","git_url":"git://github.com/toabctl/crowbar-openstack.git","ssh_url":"git@github.com:toabctl/crowbar-openstack.git","clone_url":"https://github.com/toabctl/crowbar-openstack.git","svn_url":"https://github.com/toabctl/crowbar-openstack","homepage":null,"size":17759,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"f846fa225ae81d3e436f50e5c48e1469c50a7a12","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2016-12-01T06:22:55Z","pushed_at":"2016-12-07T16:51:44Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":18504,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":40,"forks":42,"open_issues":40,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/643"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/643"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/643"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/f553b93fa240bdd1c260d5815b51e0a31bc2677f"}}}}
{"actor":{"display_login":"houndci-bot"}}