{"action":"created","issue":{"url":"https://api.github.com/repos/zalmoxisus/mobx-remotedev/issues/5","repository_url":"https://api.github.com/repos/zalmoxisus/mobx-remotedev","labels_url":"https://api.github.com/repos/zalmoxisus/mobx-remotedev/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/zalmoxisus/mobx-remotedev/issues/5/comments","events_url":"https://api.github.com/repos/zalmoxisus/mobx-remotedev/issues/5/events","html_url":"https://github.com/zalmoxisus/mobx-remotedev/pull/5","id":168963349,"number":5,"title":"[RFC] Track nested changes with full path","user":{"login":"zalmoxisus","id":7957859,"avatar_url":"https://avatars.githubusercontent.com/u/7957859?v=3","gravatar_id":"","url":"https://api.github.com/users/zalmoxisus","html_url":"https://github.com/zalmoxisus","followers_url":"https://api.github.com/users/zalmoxisus/followers","following_url":"https://api.github.com/users/zalmoxisus/following{/other_user}","gists_url":"https://api.github.com/users/zalmoxisus/gists{/gist_id}","starred_url":"https://api.github.com/users/zalmoxisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalmoxisus/subscriptions","organizations_url":"https://api.github.com/users/zalmoxisus/orgs","repos_url":"https://api.github.com/users/zalmoxisus/repos","events_url":"https://api.github.com/users/zalmoxisus/events{/privacy}","received_events_url":"https://api.github.com/users/zalmoxisus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-02T19:05:58Z","updated_at":"2016-08-23T18:52:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zalmoxisus/mobx-remotedev/pulls/5","html_url":"https://github.com/zalmoxisus/mobx-remotedev/pull/5","diff_url":"https://github.com/zalmoxisus/mobx-remotedev/pull/5.diff","patch_url":"https://github.com/zalmoxisus/mobx-remotedev/pull/5.patch"},"body":"As discussed in #2 and #3, we want to track nested changes without explicitly wrapping them in `remotedev()`. In order to help debugging, to cancel (skip) actions and to autogenerates tests, we also want to add the path to the action name like following:\r\n\r\n<img width=\"740\" alt=\"screen shot 2016-08-02 at 9 54 33 pm\" src=\"https://cloud.githubusercontent.com/assets/7957859/17341218/419318da-58fc-11e6-952c-4ed2e8b066a5.png\">\r\n\r\nThis PR is just a proof of concept, it works only for arrays added with `splice`. We need to handle other observable types and update types. There's a lot of work, so feedback is welcome. Maybe we could get some information directly from MobX?\r\n"},"comment":{"url":"https://api.github.com/repos/zalmoxisus/mobx-remotedev/issues/comments/241838275","html_url":"https://github.com/zalmoxisus/mobx-remotedev/pull/5#issuecomment-241838275","issue_url":"https://api.github.com/repos/zalmoxisus/mobx-remotedev/issues/5","id":241838275,"user":{"login":"zalmoxisus","id":7957859,"avatar_url":"https://avatars.githubusercontent.com/u/7957859?v=3","gravatar_id":"","url":"https://api.github.com/users/zalmoxisus","html_url":"https://github.com/zalmoxisus","followers_url":"https://api.github.com/users/zalmoxisus/followers","following_url":"https://api.github.com/users/zalmoxisus/following{/other_user}","gists_url":"https://api.github.com/users/zalmoxisus/gists{/gist_id}","starred_url":"https://api.github.com/users/zalmoxisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalmoxisus/subscriptions","organizations_url":"https://api.github.com/users/zalmoxisus/orgs","repos_url":"https://api.github.com/users/zalmoxisus/repos","events_url":"https://api.github.com/users/zalmoxisus/events{/privacy}","received_events_url":"https://api.github.com/users/zalmoxisus/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T18:52:50Z","updated_at":"2016-08-23T18:52:50Z","body":"@antitoxic, I don't get it. We have only this information:\r\n```js\r\n{type: \"action\", name: \"toggleStatus\", target: undefined, arguments: Array[1], spyReportStart: true}\r\n```\r\n\r\nI added you as a collaborators, you can change this branch, so we can test it together.\r\n\r\nHonestly, as discussed with @mweststrate, I don't see any advantages of nested observables / classes, and don't use them. However, it would be great to get it work, so we can prove we can control everything in MobX as in Redux."}}
{"actor":{"display_login":"zalmoxisus"}}