{"action":"created","issue":{"url":"https://api.github.com/repos/ReactTraining/react-router/issues/4024","repository_url":"https://api.github.com/repos/ReactTraining/react-router","labels_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4024/labels{/name}","comments_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4024/comments","events_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4024/events","html_url":"https://github.com/ReactTraining/react-router/pull/4024","id":182045061,"number":4024,"title":"provided HashRouter with own createHref implementation","user":{"login":"herrkris","id":9323,"avatar_url":"https://avatars.githubusercontent.com/u/9323?v=3","gravatar_id":"","url":"https://api.github.com/users/herrkris","html_url":"https://github.com/herrkris","followers_url":"https://api.github.com/users/herrkris/followers","following_url":"https://api.github.com/users/herrkris/following{/other_user}","gists_url":"https://api.github.com/users/herrkris/gists{/gist_id}","starred_url":"https://api.github.com/users/herrkris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herrkris/subscriptions","organizations_url":"https://api.github.com/users/herrkris/orgs","repos_url":"https://api.github.com/users/herrkris/repos","events_url":"https://api.github.com/users/herrkris/events{/privacy}","received_events_url":"https://api.github.com/users/herrkris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-10T15:31:43Z","updated_at":"2016-10-12T11:22:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4024","html_url":"https://github.com/ReactTraining/react-router/pull/4024","diff_url":"https://github.com/ReactTraining/react-router/pull/4024.diff","patch_url":"https://github.com/ReactTraining/react-router/pull/4024.patch"},"body":"I added an extra function since the link looks different when using `hashType` `hashbang`.\r\n\r\nThis is a fix for #4022. I hope I'm doing it the right way, since this is more or less my first PR.\r\nHelp appreciated, especially if it needs tests  :)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ReactTraining/react-router/issues/comments/253187148","html_url":"https://github.com/ReactTraining/react-router/pull/4024#issuecomment-253187148","issue_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4024","id":253187148,"user":{"login":"herrkris","id":9323,"avatar_url":"https://avatars.githubusercontent.com/u/9323?v=3","gravatar_id":"","url":"https://api.github.com/users/herrkris","html_url":"https://github.com/herrkris","followers_url":"https://api.github.com/users/herrkris/followers","following_url":"https://api.github.com/users/herrkris/following{/other_user}","gists_url":"https://api.github.com/users/herrkris/gists{/gist_id}","starred_url":"https://api.github.com/users/herrkris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herrkris/subscriptions","organizations_url":"https://api.github.com/users/herrkris/orgs","repos_url":"https://api.github.com/users/herrkris/repos","events_url":"https://api.github.com/users/herrkris/events{/privacy}","received_events_url":"https://api.github.com/users/herrkris/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T11:22:32Z","updated_at":"2016-10-12T11:22:32Z","body":"I imported two functions from the [history/PathUtils](https://github.com/mjackson/history/blob/master/modules/PathUtils.js) : `stripLeadingSlash` and `addLeadingSlash`.\r\n\r\nI don't know if this is the best solution since the [LocationUtils.js](https://github.com/ReactTraining/react-router/blob/v4.0.0-alpha.4/modules/LocationUtils.js#L1) imports two functions from [react-history/PathUtils](https://github.com/ReactTraining/react-history/blob/master/modules/PathUtils.js) which itself just exports `parsePath` and `createPath` from [history/PathUtils](https://github.com/mjackson/history/blob/master/modules/PathUtils.js).\r\n\r\nPerhaps we can also add the two methods to `react-history/PathUtils` export?\r\n\r\nI hope that makes sense somehow ..."}}
{"actor":{"display_login":"herrkris"}}