{"action":"created","comment":{"url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/comments/82067561","pull_request_review_id":2997730,"id":82067561,"diff_hunk":"@@ -0,0 +1,35 @@\n+class window.Alchemy.InternalLinksSelect\n+  constructor: (options) ->\n+    @$frame = options.frame\n+    @$selectField = options.selectField\n+    @$onChange = options.onChange\n+\n+    @initInternalAnchors()\n+\n+  # Find Alchemy Elements presents on DOM and populate the select with them\n+  selectElementsInternalIds: (elements) =>\n+    if elements.elements.length > 0\n+      $.each elements.elements, (_, element) =>\n+        DOMElement = @$frame.contents().find(\"[data-alchemy-element=\\\"#{element.id}\\\"]\")","path":"app/assets/javascripts/alchemy/alchemy.internal_links_select.js.coffee","position":13,"original_position":13,"commit_id":"a7a9f917722f74263da7dffe915f915fdc79c505","original_commit_id":"a7a9f917722f74263da7dffe915f915fdc79c505","user":{"login":"tvdeyen","id":42868,"avatar_url":"https://avatars.githubusercontent.com/u/42868?v=3","gravatar_id":"","url":"https://api.github.com/users/tvdeyen","html_url":"https://github.com/tvdeyen","followers_url":"https://api.github.com/users/tvdeyen/followers","following_url":"https://api.github.com/users/tvdeyen/following{/other_user}","gists_url":"https://api.github.com/users/tvdeyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tvdeyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvdeyen/subscriptions","organizations_url":"https://api.github.com/users/tvdeyen/orgs","repos_url":"https://api.github.com/users/tvdeyen/repos","events_url":"https://api.github.com/users/tvdeyen/events{/privacy}","received_events_url":"https://api.github.com/users/tvdeyen/received_events","type":"User","site_admin":false},"body":"Uppercase variables should be avoided as they could be confused with \"class\" names. Also I prefer to use `$` prefixed variables if a jQuery object are stored into them ","created_at":"2016-10-05T20:50:59Z","updated_at":"2016-10-05T20:50:59Z","html_url":"https://github.com/AlchemyCMS/alchemy_cms/pull/1144#discussion_r82067561","pull_request_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/1144","_links":{"self":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/comments/82067561"},"html":{"href":"https://github.com/AlchemyCMS/alchemy_cms/pull/1144#discussion_r82067561"},"pull_request":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/1144"}}},"pull_request":{"url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/1144","id":87168119,"html_url":"https://github.com/AlchemyCMS/alchemy_cms/pull/1144","diff_url":"https://github.com/AlchemyCMS/alchemy_cms/pull/1144.diff","patch_url":"https://github.com/AlchemyCMS/alchemy_cms/pull/1144.patch","issue_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues/1144","number":1144,"state":"open","locked":false,"title":"Dividing internal links into Elements and Page Anchors","user":{"login":"josetonyp","id":86254,"avatar_url":"https://avatars.githubusercontent.com/u/86254?v=3","gravatar_id":"","url":"https://api.github.com/users/josetonyp","html_url":"https://github.com/josetonyp","followers_url":"https://api.github.com/users/josetonyp/followers","following_url":"https://api.github.com/users/josetonyp/following{/other_user}","gists_url":"https://api.github.com/users/josetonyp/gists{/gist_id}","starred_url":"https://api.github.com/users/josetonyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josetonyp/subscriptions","organizations_url":"https://api.github.com/users/josetonyp/orgs","repos_url":"https://api.github.com/users/josetonyp/repos","events_url":"https://api.github.com/users/josetonyp/events{/privacy}","received_events_url":"https://api.github.com/users/josetonyp/received_events","type":"User","site_admin":false},"body":"- [x] Adding son response to Admin Elements list\r\n- [x] Showing the Internal ids of the elements in 2 groups \"Alchemy Elements\" and \"Page Anchors\"\r\n\r\n\r\n![alchemy cms - index 2016-09-28 19-48-23](https://cloud.githubusercontent.com/assets/86254/18925621/fcb2a998-85b4-11e6-9916-9164cc098d35.png)\r\n","created_at":"2016-09-28T17:52:13Z","updated_at":"2016-10-05T20:53:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16aa4cc4536760e6068ef7052568fb7ea0d3471d","assignee":{"login":"tvdeyen","id":42868,"avatar_url":"https://avatars.githubusercontent.com/u/42868?v=3","gravatar_id":"","url":"https://api.github.com/users/tvdeyen","html_url":"https://github.com/tvdeyen","followers_url":"https://api.github.com/users/tvdeyen/followers","following_url":"https://api.github.com/users/tvdeyen/following{/other_user}","gists_url":"https://api.github.com/users/tvdeyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tvdeyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvdeyen/subscriptions","organizations_url":"https://api.github.com/users/tvdeyen/orgs","repos_url":"https://api.github.com/users/tvdeyen/repos","events_url":"https://api.github.com/users/tvdeyen/events{/privacy}","received_events_url":"https://api.github.com/users/tvdeyen/received_events","type":"User","site_admin":false},"assignees":[{"login":"tvdeyen","id":42868,"avatar_url":"https://avatars.githubusercontent.com/u/42868?v=3","gravatar_id":"","url":"https://api.github.com/users/tvdeyen","html_url":"https://github.com/tvdeyen","followers_url":"https://api.github.com/users/tvdeyen/followers","following_url":"https://api.github.com/users/tvdeyen/following{/other_user}","gists_url":"https://api.github.com/users/tvdeyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tvdeyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvdeyen/subscriptions","organizations_url":"https://api.github.com/users/tvdeyen/orgs","repos_url":"https://api.github.com/users/tvdeyen/repos","events_url":"https://api.github.com/users/tvdeyen/events{/privacy}","received_events_url":"https://api.github.com/users/tvdeyen/received_events","type":"User","site_admin":false},{"login":"josetonyp","id":86254,"avatar_url":"https://avatars.githubusercontent.com/u/86254?v=3","gravatar_id":"","url":"https://api.github.com/users/josetonyp","html_url":"https://github.com/josetonyp","followers_url":"https://api.github.com/users/josetonyp/followers","following_url":"https://api.github.com/users/josetonyp/following{/other_user}","gists_url":"https://api.github.com/users/josetonyp/gists{/gist_id}","starred_url":"https://api.github.com/users/josetonyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josetonyp/subscriptions","organizations_url":"https://api.github.com/users/josetonyp/orgs","repos_url":"https://api.github.com/users/josetonyp/repos","events_url":"https://api.github.com/users/josetonyp/events{/privacy}","received_events_url":"https://api.github.com/users/josetonyp/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/milestones/18","html_url":"https://github.com/AlchemyCMS/alchemy_cms/milestones/3.5","labels_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/milestones/18/labels","id":1828587,"number":18,"title":"3.5","description":"","creator":{"login":"tvdeyen","id":42868,"avatar_url":"https://avatars.githubusercontent.com/u/42868?v=3","gravatar_id":"","url":"https://api.github.com/users/tvdeyen","html_url":"https://github.com/tvdeyen","followers_url":"https://api.github.com/users/tvdeyen/followers","following_url":"https://api.github.com/users/tvdeyen/following{/other_user}","gists_url":"https://api.github.com/users/tvdeyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tvdeyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvdeyen/subscriptions","organizations_url":"https://api.github.com/users/tvdeyen/orgs","repos_url":"https://api.github.com/users/tvdeyen/repos","events_url":"https://api.github.com/users/tvdeyen/events{/privacy}","received_events_url":"https://api.github.com/users/tvdeyen/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":40,"state":"open","created_at":"2016-06-15T09:51:27Z","updated_at":"2016-10-05T16:54:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/1144/commits","review_comments_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/1144/comments","review_comment_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues/1144/comments","statuses_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/statuses/a7a9f917722f74263da7dffe915f915fdc79c505","head":{"label":"AlchemyCMS:fix-internal-links","ref":"fix-internal-links","sha":"a7a9f917722f74263da7dffe915f915fdc79c505","user":{"login":"AlchemyCMS","id":6218554,"avatar_url":"https://avatars.githubusercontent.com/u/6218554?v=3","gravatar_id":"","url":"https://api.github.com/users/AlchemyCMS","html_url":"https://github.com/AlchemyCMS","followers_url":"https://api.github.com/users/AlchemyCMS/followers","following_url":"https://api.github.com/users/AlchemyCMS/following{/other_user}","gists_url":"https://api.github.com/users/AlchemyCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlchemyCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlchemyCMS/subscriptions","organizations_url":"https://api.github.com/users/AlchemyCMS/orgs","repos_url":"https://api.github.com/users/AlchemyCMS/repos","events_url":"https://api.github.com/users/AlchemyCMS/events{/privacy}","received_events_url":"https://api.github.com/users/AlchemyCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":1581769,"name":"alchemy_cms","full_name":"AlchemyCMS/alchemy_cms","owner":{"login":"AlchemyCMS","id":6218554,"avatar_url":"https://avatars.githubusercontent.com/u/6218554?v=3","gravatar_id":"","url":"https://api.github.com/users/AlchemyCMS","html_url":"https://github.com/AlchemyCMS","followers_url":"https://api.github.com/users/AlchemyCMS/followers","following_url":"https://api.github.com/users/AlchemyCMS/following{/other_user}","gists_url":"https://api.github.com/users/AlchemyCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlchemyCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlchemyCMS/subscriptions","organizations_url":"https://api.github.com/users/AlchemyCMS/orgs","repos_url":"https://api.github.com/users/AlchemyCMS/repos","events_url":"https://api.github.com/users/AlchemyCMS/events{/privacy}","received_events_url":"https://api.github.com/users/AlchemyCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AlchemyCMS/alchemy_cms","description":"Alchemy is a powerful, flexible and user centric Rails CMS.","fork":false,"url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms","forks_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/forks","keys_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/teams","hooks_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/hooks","issue_events_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues/events{/number}","events_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/events","assignees_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/assignees{/user}","branches_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/branches{/branch}","tags_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/tags","blobs_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/statuses/{sha}","languages_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/languages","stargazers_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/stargazers","contributors_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/contributors","subscribers_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/subscribers","subscription_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/subscription","commits_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/contents/{+path}","compare_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/merges","archive_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/downloads","issues_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues{/number}","pulls_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls{/number}","milestones_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/milestones{/number}","notifications_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/labels{/name}","releases_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/releases{/id}","deployments_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/deployments","created_at":"2011-04-07T10:37:01Z","updated_at":"2016-09-28T05:31:22Z","pushed_at":"2016-10-05T18:04:36Z","git_url":"git://github.com/AlchemyCMS/alchemy_cms.git","ssh_url":"git@github.com:AlchemyCMS/alchemy_cms.git","clone_url":"https://github.com/AlchemyCMS/alchemy_cms.git","svn_url":"https://github.com/AlchemyCMS/alchemy_cms","homepage":"http://alchemy-cms.com","size":18490,"stargazers_count":429,"watchers_count":429,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":20,"forks":194,"open_issues":20,"watchers":429,"default_branch":"master"}},"base":{"label":"AlchemyCMS:master","ref":"master","sha":"237522aea8dab69c04ec20dae1c284aa291e3a69","user":{"login":"AlchemyCMS","id":6218554,"avatar_url":"https://avatars.githubusercontent.com/u/6218554?v=3","gravatar_id":"","url":"https://api.github.com/users/AlchemyCMS","html_url":"https://github.com/AlchemyCMS","followers_url":"https://api.github.com/users/AlchemyCMS/followers","following_url":"https://api.github.com/users/AlchemyCMS/following{/other_user}","gists_url":"https://api.github.com/users/AlchemyCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlchemyCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlchemyCMS/subscriptions","organizations_url":"https://api.github.com/users/AlchemyCMS/orgs","repos_url":"https://api.github.com/users/AlchemyCMS/repos","events_url":"https://api.github.com/users/AlchemyCMS/events{/privacy}","received_events_url":"https://api.github.com/users/AlchemyCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":1581769,"name":"alchemy_cms","full_name":"AlchemyCMS/alchemy_cms","owner":{"login":"AlchemyCMS","id":6218554,"avatar_url":"https://avatars.githubusercontent.com/u/6218554?v=3","gravatar_id":"","url":"https://api.github.com/users/AlchemyCMS","html_url":"https://github.com/AlchemyCMS","followers_url":"https://api.github.com/users/AlchemyCMS/followers","following_url":"https://api.github.com/users/AlchemyCMS/following{/other_user}","gists_url":"https://api.github.com/users/AlchemyCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlchemyCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlchemyCMS/subscriptions","organizations_url":"https://api.github.com/users/AlchemyCMS/orgs","repos_url":"https://api.github.com/users/AlchemyCMS/repos","events_url":"https://api.github.com/users/AlchemyCMS/events{/privacy}","received_events_url":"https://api.github.com/users/AlchemyCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AlchemyCMS/alchemy_cms","description":"Alchemy is a powerful, flexible and user centric Rails CMS.","fork":false,"url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms","forks_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/forks","keys_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/teams","hooks_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/hooks","issue_events_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues/events{/number}","events_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/events","assignees_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/assignees{/user}","branches_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/branches{/branch}","tags_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/tags","blobs_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/statuses/{sha}","languages_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/languages","stargazers_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/stargazers","contributors_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/contributors","subscribers_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/subscribers","subscription_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/subscription","commits_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/contents/{+path}","compare_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/merges","archive_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/downloads","issues_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues{/number}","pulls_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls{/number}","milestones_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/milestones{/number}","notifications_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/labels{/name}","releases_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/releases{/id}","deployments_url":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/deployments","created_at":"2011-04-07T10:37:01Z","updated_at":"2016-09-28T05:31:22Z","pushed_at":"2016-10-05T18:04:36Z","git_url":"git://github.com/AlchemyCMS/alchemy_cms.git","ssh_url":"git@github.com:AlchemyCMS/alchemy_cms.git","clone_url":"https://github.com/AlchemyCMS/alchemy_cms.git","svn_url":"https://github.com/AlchemyCMS/alchemy_cms","homepage":"http://alchemy-cms.com","size":18490,"stargazers_count":429,"watchers_count":429,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":20,"forks":194,"open_issues":20,"watchers":429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/1144"},"html":{"href":"https://github.com/AlchemyCMS/alchemy_cms/pull/1144"},"issue":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues/1144"},"comments":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/issues/1144/comments"},"review_comments":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/1144/comments"},"review_comment":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/pulls/1144/commits"},"statuses":{"href":"https://api.github.com/repos/AlchemyCMS/alchemy_cms/statuses/a7a9f917722f74263da7dffe915f915fdc79c505"}}}}
{"actor":{"display_login":"tvdeyen"}}