{"action":"created","comment":{"url":"https://api.github.com/repos/meganz/sdk/pulls/comments/92390617","pull_request_review_id":12901156,"id":92390617,"diff_hunk":"@@ -660,6 +656,47 @@ bool HttpReqUL::prepare(FileAccess* fa, const char* tempurl, SymmCipher* key,\n     // unpad for POSTing\n     out->resize(size);\n \n+\n+    const char *data = out->data();\n+    byte c[12];\n+    memset(c, 0, 12);\n+\n+#ifndef ALLOW_UNALIGNED_MEMORY_ACCESS\n+    for (int l = size; l--;)\n+    {\n+        c[l % 12] ^= data[l];\n+    }\n+#else","path":"src/http.cpp","position":25,"original_position":25,"commit_id":"13a0b50936c20a861cacd64dc6c1f2a807b2c06e","original_commit_id":"13a0b50936c20a861cacd64dc6c1f2a807b2c06e","user":{"login":"sergiohs84","id":11694066,"avatar_url":"https://avatars.githubusercontent.com/u/11694066?v=3","gravatar_id":"","url":"https://api.github.com/users/sergiohs84","html_url":"https://github.com/sergiohs84","followers_url":"https://api.github.com/users/sergiohs84/followers","following_url":"https://api.github.com/users/sergiohs84/following{/other_user}","gists_url":"https://api.github.com/users/sergiohs84/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiohs84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiohs84/subscriptions","organizations_url":"https://api.github.com/users/sergiohs84/orgs","repos_url":"https://api.github.com/users/sergiohs84/repos","events_url":"https://api.github.com/users/sergiohs84/events{/privacy}","received_events_url":"https://api.github.com/users/sergiohs84/received_events","type":"User","site_admin":false},"body":"It could be interesting to perform a benchmarking to check if the code below is actually much faster than the version above.","created_at":"2016-12-14T13:20:36Z","updated_at":"2016-12-14T13:20:36Z","html_url":"https://github.com/meganz/sdk/pull/479#discussion_r92390617","pull_request_url":"https://api.github.com/repos/meganz/sdk/pulls/479","_links":{"self":{"href":"https://api.github.com/repos/meganz/sdk/pulls/comments/92390617"},"html":{"href":"https://github.com/meganz/sdk/pull/479#discussion_r92390617"},"pull_request":{"href":"https://api.github.com/repos/meganz/sdk/pulls/479"}}},"pull_request":{"url":"https://api.github.com/repos/meganz/sdk/pulls/479","id":96762835,"html_url":"https://github.com/meganz/sdk/pull/479","diff_url":"https://github.com/meganz/sdk/pull/479.diff","patch_url":"https://github.com/meganz/sdk/pull/479.patch","issue_url":"https://api.github.com/repos/meganz/sdk/issues/479","number":479,"state":"open","locked":false,"title":"Better management of integrity checks","user":{"login":"javiserrano","id":5003542,"avatar_url":"https://avatars.githubusercontent.com/u/5003542?v=3","gravatar_id":"","url":"https://api.github.com/users/javiserrano","html_url":"https://github.com/javiserrano","followers_url":"https://api.github.com/users/javiserrano/followers","following_url":"https://api.github.com/users/javiserrano/following{/other_user}","gists_url":"https://api.github.com/users/javiserrano/gists{/gist_id}","starred_url":"https://api.github.com/users/javiserrano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiserrano/subscriptions","organizations_url":"https://api.github.com/users/javiserrano/orgs","repos_url":"https://api.github.com/users/javiserrano/repos","events_url":"https://api.github.com/users/javiserrano/events{/privacy}","received_events_url":"https://api.github.com/users/javiserrano/received_events","type":"User","site_admin":false},"body":"- CRC for uploads\r\n- Provide the last error in transfers to apps\r\n- Retry the upload of chunks that fails due to the CRC\r\n- Repeat wrong downloads to check if the file is really corrupt\r\n- Move corrupt files to SyncDebris\r\n- Reorganized the management of the variables \"progresscompleted\", \"errorcount\" and \"failcount\"","created_at":"2016-12-06T16:54:49Z","updated_at":"2016-12-14T13:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5516957a9d0928372c4848768755bfd93f9311e3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/meganz/sdk/pulls/479/commits","review_comments_url":"https://api.github.com/repos/meganz/sdk/pulls/479/comments","review_comment_url":"https://api.github.com/repos/meganz/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meganz/sdk/issues/479/comments","statuses_url":"https://api.github.com/repos/meganz/sdk/statuses/13a0b50936c20a861cacd64dc6c1f2a807b2c06e","head":{"label":"meganz:feature/crc-uploads","ref":"feature/crc-uploads","sha":"13a0b50936c20a861cacd64dc6c1f2a807b2c06e","user":{"login":"meganz","id":4920706,"avatar_url":"https://avatars.githubusercontent.com/u/4920706?v=3","gravatar_id":"","url":"https://api.github.com/users/meganz","html_url":"https://github.com/meganz","followers_url":"https://api.github.com/users/meganz/followers","following_url":"https://api.github.com/users/meganz/following{/other_user}","gists_url":"https://api.github.com/users/meganz/gists{/gist_id}","starred_url":"https://api.github.com/users/meganz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganz/subscriptions","organizations_url":"https://api.github.com/users/meganz/orgs","repos_url":"https://api.github.com/users/meganz/repos","events_url":"https://api.github.com/users/meganz/events{/privacy}","received_events_url":"https://api.github.com/users/meganz/received_events","type":"Organization","site_admin":false},"repo":{"id":14556029,"name":"sdk","full_name":"meganz/sdk","owner":{"login":"meganz","id":4920706,"avatar_url":"https://avatars.githubusercontent.com/u/4920706?v=3","gravatar_id":"","url":"https://api.github.com/users/meganz","html_url":"https://github.com/meganz","followers_url":"https://api.github.com/users/meganz/followers","following_url":"https://api.github.com/users/meganz/following{/other_user}","gists_url":"https://api.github.com/users/meganz/gists{/gist_id}","starred_url":"https://api.github.com/users/meganz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganz/subscriptions","organizations_url":"https://api.github.com/users/meganz/orgs","repos_url":"https://api.github.com/users/meganz/repos","events_url":"https://api.github.com/users/meganz/events{/privacy}","received_events_url":"https://api.github.com/users/meganz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meganz/sdk","description":"MEGA C++ SDK","fork":false,"url":"https://api.github.com/repos/meganz/sdk","forks_url":"https://api.github.com/repos/meganz/sdk/forks","keys_url":"https://api.github.com/repos/meganz/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meganz/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meganz/sdk/teams","hooks_url":"https://api.github.com/repos/meganz/sdk/hooks","issue_events_url":"https://api.github.com/repos/meganz/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/meganz/sdk/events","assignees_url":"https://api.github.com/repos/meganz/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/meganz/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/meganz/sdk/tags","blobs_url":"https://api.github.com/repos/meganz/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meganz/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meganz/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/meganz/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meganz/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/meganz/sdk/languages","stargazers_url":"https://api.github.com/repos/meganz/sdk/stargazers","contributors_url":"https://api.github.com/repos/meganz/sdk/contributors","subscribers_url":"https://api.github.com/repos/meganz/sdk/subscribers","subscription_url":"https://api.github.com/repos/meganz/sdk/subscription","commits_url":"https://api.github.com/repos/meganz/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/meganz/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/meganz/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/meganz/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/meganz/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/meganz/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meganz/sdk/merges","archive_url":"https://api.github.com/repos/meganz/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meganz/sdk/downloads","issues_url":"https://api.github.com/repos/meganz/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/meganz/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/meganz/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/meganz/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meganz/sdk/labels{/name}","releases_url":"https://api.github.com/repos/meganz/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/meganz/sdk/deployments","created_at":"2013-11-20T12:33:53Z","updated_at":"2016-12-09T21:06:43Z","pushed_at":"2016-12-14T13:23:19Z","git_url":"git://github.com/meganz/sdk.git","ssh_url":"git@github.com:meganz/sdk.git","clone_url":"https://github.com/meganz/sdk.git","svn_url":"https://github.com/meganz/sdk","homepage":"","size":13976,"stargazers_count":368,"watchers_count":368,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":16,"forks":148,"open_issues":16,"watchers":368,"default_branch":"master"}},"base":{"label":"meganz:develop","ref":"develop","sha":"e8b67894d353a6a296caf5ab80b2464306505814","user":{"login":"meganz","id":4920706,"avatar_url":"https://avatars.githubusercontent.com/u/4920706?v=3","gravatar_id":"","url":"https://api.github.com/users/meganz","html_url":"https://github.com/meganz","followers_url":"https://api.github.com/users/meganz/followers","following_url":"https://api.github.com/users/meganz/following{/other_user}","gists_url":"https://api.github.com/users/meganz/gists{/gist_id}","starred_url":"https://api.github.com/users/meganz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganz/subscriptions","organizations_url":"https://api.github.com/users/meganz/orgs","repos_url":"https://api.github.com/users/meganz/repos","events_url":"https://api.github.com/users/meganz/events{/privacy}","received_events_url":"https://api.github.com/users/meganz/received_events","type":"Organization","site_admin":false},"repo":{"id":14556029,"name":"sdk","full_name":"meganz/sdk","owner":{"login":"meganz","id":4920706,"avatar_url":"https://avatars.githubusercontent.com/u/4920706?v=3","gravatar_id":"","url":"https://api.github.com/users/meganz","html_url":"https://github.com/meganz","followers_url":"https://api.github.com/users/meganz/followers","following_url":"https://api.github.com/users/meganz/following{/other_user}","gists_url":"https://api.github.com/users/meganz/gists{/gist_id}","starred_url":"https://api.github.com/users/meganz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganz/subscriptions","organizations_url":"https://api.github.com/users/meganz/orgs","repos_url":"https://api.github.com/users/meganz/repos","events_url":"https://api.github.com/users/meganz/events{/privacy}","received_events_url":"https://api.github.com/users/meganz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meganz/sdk","description":"MEGA C++ SDK","fork":false,"url":"https://api.github.com/repos/meganz/sdk","forks_url":"https://api.github.com/repos/meganz/sdk/forks","keys_url":"https://api.github.com/repos/meganz/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meganz/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meganz/sdk/teams","hooks_url":"https://api.github.com/repos/meganz/sdk/hooks","issue_events_url":"https://api.github.com/repos/meganz/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/meganz/sdk/events","assignees_url":"https://api.github.com/repos/meganz/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/meganz/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/meganz/sdk/tags","blobs_url":"https://api.github.com/repos/meganz/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meganz/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meganz/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/meganz/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meganz/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/meganz/sdk/languages","stargazers_url":"https://api.github.com/repos/meganz/sdk/stargazers","contributors_url":"https://api.github.com/repos/meganz/sdk/contributors","subscribers_url":"https://api.github.com/repos/meganz/sdk/subscribers","subscription_url":"https://api.github.com/repos/meganz/sdk/subscription","commits_url":"https://api.github.com/repos/meganz/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/meganz/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/meganz/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/meganz/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/meganz/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/meganz/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meganz/sdk/merges","archive_url":"https://api.github.com/repos/meganz/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meganz/sdk/downloads","issues_url":"https://api.github.com/repos/meganz/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/meganz/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/meganz/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/meganz/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meganz/sdk/labels{/name}","releases_url":"https://api.github.com/repos/meganz/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/meganz/sdk/deployments","created_at":"2013-11-20T12:33:53Z","updated_at":"2016-12-09T21:06:43Z","pushed_at":"2016-12-14T13:23:19Z","git_url":"git://github.com/meganz/sdk.git","ssh_url":"git@github.com:meganz/sdk.git","clone_url":"https://github.com/meganz/sdk.git","svn_url":"https://github.com/meganz/sdk","homepage":"","size":13976,"stargazers_count":368,"watchers_count":368,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":16,"forks":148,"open_issues":16,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meganz/sdk/pulls/479"},"html":{"href":"https://github.com/meganz/sdk/pull/479"},"issue":{"href":"https://api.github.com/repos/meganz/sdk/issues/479"},"comments":{"href":"https://api.github.com/repos/meganz/sdk/issues/479/comments"},"review_comments":{"href":"https://api.github.com/repos/meganz/sdk/pulls/479/comments"},"review_comment":{"href":"https://api.github.com/repos/meganz/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meganz/sdk/pulls/479/commits"},"statuses":{"href":"https://api.github.com/repos/meganz/sdk/statuses/13a0b50936c20a861cacd64dc6c1f2a807b2c06e"}}}}
{"actor":{"display_login":"sergiohs84"}}