{"action":"created","issue":{"url":"https://api.github.com/repos/makerdao/simplecoin/issues/26","repository_url":"https://api.github.com/repos/makerdao/simplecoin","labels_url":"https://api.github.com/repos/makerdao/simplecoin/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/makerdao/simplecoin/issues/26/comments","events_url":"https://api.github.com/repos/makerdao/simplecoin/issues/26/events","html_url":"https://github.com/makerdao/simplecoin/pull/26","id":174883394,"number":26,"title":"[wip] replace whitelists with role auth","user":{"login":"rainbeam","id":18486361,"avatar_url":"https://avatars.githubusercontent.com/u/18486361?v=3","gravatar_id":"","url":"https://api.github.com/users/rainbeam","html_url":"https://github.com/rainbeam","followers_url":"https://api.github.com/users/rainbeam/followers","following_url":"https://api.github.com/users/rainbeam/following{/other_user}","gists_url":"https://api.github.com/users/rainbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/rainbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainbeam/subscriptions","organizations_url":"https://api.github.com/users/rainbeam/orgs","repos_url":"https://api.github.com/users/rainbeam/repos","events_url":"https://api.github.com/users/rainbeam/events{/privacy}","received_events_url":"https://api.github.com/users/rainbeam/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/makerdao/simplecoin/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-03T07:01:46Z","updated_at":"2016-09-04T11:26:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/makerdao/simplecoin/pulls/26","html_url":"https://github.com/makerdao/simplecoin/pull/26","diff_url":"https://github.com/makerdao/simplecoin/pull/26.diff","patch_url":"https://github.com/makerdao/simplecoin/pull/26.patch"},"body":"Pull out the whitelists and replace them with [ds-roles], fixing #8.\r\n\r\n[ds-roles]: https://github.com/nexusdev/ds-roles \r\n\r\nThis allows the owner fine grained access control via DSAuth, whilst providing a pre-configured default authority (via the factory) that follows the admin-issuer-holder pattern.\r\n\r\nHowever, it doesn't entirely move function access into the `auth` modifier as `auth` isn't conditional on arguments: we still need e.g. `auth_recipient(address to)` to restrict holders from transferring to non-holders, which limits the configurability of the contract.\r\n\r\nThis isn't completely elegant - ideally we'd like to specify all access via the `auth` modifier. One solution to this is some hack by deserializing `msg.data` and using an internal lookup table. But that's not elegant either.\r\n\r\nTODO:\r\n- [x] tests\r\n- [x] re-add modifier to prevent non holder transfer"},"comment":{"url":"https://api.github.com/repos/makerdao/simplecoin/issues/comments/244597808","html_url":"https://github.com/makerdao/simplecoin/pull/26#issuecomment-244597808","issue_url":"https://api.github.com/repos/makerdao/simplecoin/issues/26","id":244597808,"user":{"login":"dbrock","id":14032,"avatar_url":"https://avatars.githubusercontent.com/u/14032?v=3","gravatar_id":"","url":"https://api.github.com/users/dbrock","html_url":"https://github.com/dbrock","followers_url":"https://api.github.com/users/dbrock/followers","following_url":"https://api.github.com/users/dbrock/following{/other_user}","gists_url":"https://api.github.com/users/dbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrock/subscriptions","organizations_url":"https://api.github.com/users/dbrock/orgs","repos_url":"https://api.github.com/users/dbrock/repos","events_url":"https://api.github.com/users/dbrock/events{/privacy}","received_events_url":"https://api.github.com/users/dbrock/received_events","type":"User","site_admin":false},"created_at":"2016-09-04T11:26:16Z","updated_at":"2016-09-04T11:26:16Z","body":"I'm sorry, I pushed some stuff that conflicts with this (#25). I'm pretty sure we should just go with your version for the conflicting parts."}}
{"actor":{"display_login":"dbrock"}}