{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/77861276","id":77861276,"diff_hunk":"@@ -0,0 +1,191 @@\n+<!--\n+\n+/*\n+** Copyright (c) 2016 The Khronos Group Inc.\n+**\n+** Permission is hereby granted, free of charge, to any person obtaining a\n+** copy of this software and/or associated documentation files (the\n+** \"Materials\"), to deal in the Materials without restriction, including\n+** without limitation the rights to use, copy, modify, merge, publish,\n+** distribute, sublicense, and/or sell copies of the Materials, and to\n+** permit persons to whom the Materials are furnished to do so, subject to\n+** the following conditions:\n+**\n+** The above copyright notice and this permission notice shall be included\n+** in all copies or substantial portions of the Materials.\n+**\n+** THE MATERIALS ARE PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+** EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+** MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.\n+** IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY\n+** CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,\n+** TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE\n+** MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.\n+*/\n+\n+-->\n+\n+<!DOCTYPE html>\n+<html>\n+<head>\n+<meta charset=\"utf-8\">\n+<title>WebGL BlitFramebuffer Tests</title>\n+<link rel=\"stylesheet\" href=\"../../resources/js-test-style.css\"/>\n+<script src=\"../../js/js-test-pre.js\"></script>\n+<script src=\"../../js/webgl-test-utils.js\"></script>\n+</head>\n+<body>\n+<canvas id=\"example\" width=\"8\" height=\"8\"></canvas>\n+<div id=\"description\"></div>\n+<div id=\"console\"></div>\n+<script>\n+\"use strict\";\n+\n+var wtu = WebGLTestUtils;\n+description(\"This test verifies the functionality of blitFramebuffer for some corner cases.\");\n+\n+var gl = wtu.create3DContext(\"example\", undefined, 2);\n+\n+function blit_framebuffer_test() {\n+    var width = 8;\n+    var height = 8;\n+\n+    // Create read fbo and its color attachment.\n+    var tex_2d = gl.createTexture();\n+    gl.bindTexture(gl.TEXTURE_2D, tex_2d);\n+    var m_data0 = new Uint8Array(width * height * 4);\n+    for (var ii = 0; ii < width * height; ++ii) {\n+        for (var jj = 0; jj < 3; ++jj) {\n+            m_data0[ii * 4 + jj] = 0x10;\n+        }\n+        m_data0[ii * 4 + 3] = 0xff;\n+    }\n+    gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA8, width, height, 0, gl.RGBA, gl.UNSIGNED_BYTE, m_data0);\n+    gl.generateMipmap(gl.TEXTURE_2D);\n+\n+    var fb0 = gl.createFramebuffer();\n+    gl.bindFramebuffer(gl.READ_FRAMEBUFFER, fb0);\n+    gl.framebufferTexture2D(gl.READ_FRAMEBUFFER, gl.COLOR_ATTACHMENT0, gl.TEXTURE_2D, tex_2d, 0);\n+    if (gl.checkFramebufferStatus(gl.READ_FRAMEBUFFER) != gl.FRAMEBUFFER_COMPLETE) {\n+        testFailed(\"Read framebuffer incomplete. Fail reason: \" + wtu.glEnumToString(gl, status));\n+        return;\n+    }\n+\n+    // Create draw fbo and its color attachment.\n+    var rb0 = gl.createRenderbuffer();\n+    gl.bindRenderbuffer(gl.RENDERBUFFER, rb0);\n+    gl.renderbufferStorage(gl.RENDERBUFFER, gl.RGBA8, width, height);\n+\n+    var fb1 = gl.createFramebuffer();\n+    gl.bindFramebuffer(gl.DRAW_FRAMEBUFFER, fb1);\n+    gl.framebufferRenderbuffer(gl.DRAW_FRAMEBUFFER, gl.COLOR_ATTACHMENT0, gl.RENDERBUFFER, rb0);\n+    if (gl.checkFramebufferStatus(gl.DRAW_FRAMEBUFFER) != gl.FRAMEBUFFER_COMPLETE) {\n+        testFailed(\"Draw framebuffer incomplete. Fail reason: \" + wtu.glEnumToString(gl, status));","path":"sdk/tests/conformance2/rendering/blitframebuffer-test.html","position":83,"original_position":83,"commit_id":"ab218bc250b5d8d42b46346b455f918042c526cb","original_commit_id":"ab218bc250b5d8d42b46346b455f918042c526cb","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"body":"status is undefined.","created_at":"2016-09-07T16:49:17Z","updated_at":"2016-09-07T16:49:17Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/2015#discussion_r77861276","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2015","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/77861276"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2015#discussion_r77861276"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2015"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2015","id":84267980,"html_url":"https://github.com/KhronosGroup/WebGL/pull/2015","diff_url":"https://github.com/KhronosGroup/WebGL/pull/2015.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/2015.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2015","number":2015,"state":"open","locked":false,"title":"Add test cases for blitFramebuffe to cover more corner cases.","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"body":"If the src buffer and dst buffer are identical, generates INVALID_OPERATION.\r\nSee the gles 3.0.4 spec about this at https://www.khronos.org/registry/gles/specs/3.0/es_spec_3.0.4.pdf#nameddest=section-4.3.3. It is at the middle on page 198.\r\n \r\nOn the gles3 man page of blitFramebuffer at https://www.khronos.org/opengles/sdk/docs/man3/html/glBlitFramebuffer.xhtml. It says that this behavior is not defined. However, gles3 man page is not always updated. Moreover, to be undefined is not a good definition.\r\n\r\nPTAL. Thanks a lot!\r\n\r\n","created_at":"2016-09-07T09:42:31Z","updated_at":"2016-09-07T16:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"234ac439e70bc4de43d219f9a9fa0c13f05d4e75","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2015/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2015/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2015/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/ab218bc250b5d8d42b46346b455f918042c526cb","head":{"label":"Richard-Yunchao:blitframebuffer-misc","ref":"blitframebuffer-misc","sha":"ab218bc250b5d8d42b46346b455f918042c526cb","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"repo":{"id":32059852,"name":"WebGL","full_name":"Richard-Yunchao/WebGL","owner":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Richard-Yunchao/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/Richard-Yunchao/WebGL","forks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/forks","keys_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/teams","hooks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/hooks","issue_events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/events","assignees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/tags","blobs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/languages","stargazers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/stargazers","contributors_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contributors","subscribers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscribers","subscription_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscription","commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/merges","archive_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/downloads","issues_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/deployments","created_at":"2015-03-12T05:57:15Z","updated_at":"2015-03-16T06:06:31Z","pushed_at":"2016-09-07T09:51:33Z","git_url":"git://github.com/Richard-Yunchao/WebGL.git","ssh_url":"git@github.com:Richard-Yunchao/WebGL.git","clone_url":"https://github.com/Richard-Yunchao/WebGL.git","svn_url":"https://github.com/Richard-Yunchao/WebGL","homepage":null,"size":22797,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"2e13422646f5a621968c30bffb9536b48ddd0d12","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2016-09-07T01:38:33Z","pushed_at":"2016-09-07T09:51:34Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":29717,"stargazers_count":666,"watchers_count":666,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":324,"mirror_url":null,"open_issues_count":78,"forks":324,"open_issues":78,"watchers":666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2015"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2015"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2015"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2015/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2015/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2015/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/ab218bc250b5d8d42b46346b455f918042c526cb"}}}}
{"actor":{"display_login":"zhenyao"}}