{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/77783302","id":77783302,"diff_hunk":"@@ -184,32 +187,46 @@ public CommunicationDetails processOneToOne(String tenantId, Trace item) throws\n      * This method initialises the outbound information from the consumer's nodes in the supplied\n      * communication details.\n      *\n-     * @param consumerNodes The consumer nodes\n+     * @param n The node\n      * @param baseTime The fragment's base time (ns)\n      * @param cd The communication details\n+     * @param nodeId The path id for the node\n      */\n-    protected static void initialiseOutbound(List<Node> consumerNodes, long baseTime, CommunicationDetails cd) {\n-        for (int i = 0; i < consumerNodes.size(); i++) {\n-            Node n = consumerNodes.get(i);\n-            if (n.getClass() == Producer.class) {\n-                CommunicationDetails.Outbound ob = new CommunicationDetails.Outbound();\n-                for (int j = 0; j < ((Producer) n).getCorrelationIds().size(); j++) {\n-                    CorrelationIdentifier ci = ((Producer) n).getCorrelationIds().get(j);\n-                    if (ci.getScope() == Scope.Interaction) {\n-                        ob.getIds().add(ci.getValue());\n-                    }\n-                }\n-                // Only record if outbound ids found\n-                if (!ob.getIds().isEmpty()) {\n-                    // Check if pub/sub\n-                    ob.setMultiConsumer(((Producer) n).multipleConsumers());\n-\n-                    ob.setProducerOffset(TimeUnit.MILLISECONDS.convert((n.getBaseTime() - baseTime),\n-                            TimeUnit.NANOSECONDS));\n-                    cd.getOutbound().add(ob);\n+    protected static void initialiseOutbound(Node n, long baseTime, CommunicationDetails cd,\n+            StringBuilder nodeId) {\n+        CommunicationDetails.Outbound ob = new CommunicationDetails.Outbound();\n+        ob.getIds().add(nodeId.toString());\n+        ob.setMultiConsumer(true);\n+        ob.setProducerOffset(TimeUnit.MILLISECONDS.convert((n.getBaseTime() - baseTime),\n+                    TimeUnit.NANOSECONDS));\n+        cd.getOutbound().add(ob);\n+\n+        if (n.getClass() == Producer.class) {\n+            ob = new CommunicationDetails.Outbound();\n+            for (int j = 0; j < ((Producer) n).getCorrelationIds().size(); j++) {","path":"processors/communicationdetails-deriver/src/main/java/org/hawkular/apm/processor/communicationdetails/CommunicationDetailsDeriver.java","position":52,"original_position":52,"commit_id":"aa6d598239595411f85ddbad1e54986573679411","original_commit_id":"aa6d598239595411f85ddbad1e54986573679411","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"Casting to producer is not necessary.","created_at":"2016-09-07T08:54:51Z","updated_at":"2016-09-07T08:54:51Z","html_url":"https://github.com/hawkular/hawkular-apm/pull/556#discussion_r77783302","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/556","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/77783302"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/556#discussion_r77783302"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/556"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/556","id":84149380,"html_url":"https://github.com/hawkular/hawkular-apm/pull/556","diff_url":"https://github.com/hawkular/hawkular-apm/pull/556.diff","patch_url":"https://github.com/hawkular/hawkular-apm/pull/556.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/556","number":556,"state":"open","locked":false,"title":"HWKAPM-604 Add outbound connections in communication details to suppo…","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"…rt 'CausedBy' relationships, and HWKAPM-605 create integration tests to verify completion time being calculated correctly for all types of links","created_at":"2016-09-06T15:58:52Z","updated_at":"2016-09-07T08:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ad49690f56217185bc601f2b4530e0ccbb92594","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/556/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/556/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/556/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/aa6d598239595411f85ddbad1e54986573679411","head":{"label":"objectiser:HWKAPM-604","ref":"HWKAPM-604","sha":"aa6d598239595411f85ddbad1e54986573679411","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"repo":{"id":34446762,"name":"hawkular-apm","full_name":"objectiser/hawkular-apm","owner":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/objectiser/hawkular-apm","description":"Application Performance Management for Hawkular","fork":true,"url":"https://api.github.com/repos/objectiser/hawkular-apm","forks_url":"https://api.github.com/repos/objectiser/hawkular-apm/forks","keys_url":"https://api.github.com/repos/objectiser/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objectiser/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objectiser/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/objectiser/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/objectiser/hawkular-apm/events","assignees_url":"https://api.github.com/repos/objectiser/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/objectiser/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/objectiser/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objectiser/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/objectiser/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/objectiser/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/objectiser/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/objectiser/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/objectiser/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/objectiser/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/objectiser/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/objectiser/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/objectiser/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objectiser/hawkular-apm/merges","archive_url":"https://api.github.com/repos/objectiser/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objectiser/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/objectiser/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/objectiser/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/objectiser/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objectiser/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/objectiser/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/objectiser/hawkular-apm/deployments","created_at":"2015-04-23T09:26:55Z","updated_at":"2016-06-03T10:47:39Z","pushed_at":"2016-09-06T16:17:17Z","git_url":"git://github.com/objectiser/hawkular-apm.git","ssh_url":"git@github.com:objectiser/hawkular-apm.git","clone_url":"https://github.com/objectiser/hawkular-apm.git","svn_url":"https://github.com/objectiser/hawkular-apm","homepage":"","size":5951,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"69eb0ad8332e6a830277084e3e2b4e74b3ff1364","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":34446334,"name":"hawkular-apm","full_name":"hawkular/hawkular-apm","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-apm","description":"Distributed Tracing and Application Performance Management","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-apm","forks_url":"https://api.github.com/repos/hawkular/hawkular-apm/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-apm/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-apm/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-apm/deployments","created_at":"2015-04-23T09:17:50Z","updated_at":"2016-09-07T08:47:49Z","pushed_at":"2016-09-06T16:17:17Z","git_url":"git://github.com/hawkular/hawkular-apm.git","ssh_url":"git@github.com:hawkular/hawkular-apm.git","clone_url":"https://github.com/hawkular/hawkular-apm.git","svn_url":"https://github.com/hawkular/hawkular-apm","homepage":"","size":6063,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":4,"forks":15,"open_issues":4,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/556"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/556"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/556"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/aa6d598239595411f85ddbad1e54986573679411"}}}}
{"actor":{"display_login":"pavolloffay"}}