{"action":"created","issue":{"url":"https://api.github.com/repos/marcelstoer/docker-nodemcu-build/issues/6","repository_url":"https://api.github.com/repos/marcelstoer/docker-nodemcu-build","labels_url":"https://api.github.com/repos/marcelstoer/docker-nodemcu-build/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/marcelstoer/docker-nodemcu-build/issues/6/comments","events_url":"https://api.github.com/repos/marcelstoer/docker-nodemcu-build/issues/6/events","html_url":"https://github.com/marcelstoer/docker-nodemcu-build/issues/6","id":134837515,"number":6,"title":"Allowing an uploadable config for Docker images","user":{"login":"TerryE","id":690173,"avatar_url":"https://avatars.githubusercontent.com/u/690173?v=3","gravatar_id":"","url":"https://api.github.com/users/TerryE","html_url":"https://github.com/TerryE","followers_url":"https://api.github.com/users/TerryE/followers","following_url":"https://api.github.com/users/TerryE/following{/other_user}","gists_url":"https://api.github.com/users/TerryE/gists{/gist_id}","starred_url":"https://api.github.com/users/TerryE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerryE/subscriptions","organizations_url":"https://api.github.com/users/TerryE/orgs","repos_url":"https://api.github.com/users/TerryE/repos","events_url":"https://api.github.com/users/TerryE/events{/privacy}","received_events_url":"https://api.github.com/users/TerryE/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-19T11:02:21Z","updated_at":"2016-03-06T15:14:47Z","closed_at":null,"body":"I know we've touched on this on a firmware issue but I use a config script to build my `user_*.h` files and it is really just so much easier than having to mess around tweaking this -- or in the case fo a cloud build services the potential vulnerabilities / exploits that allowing the direct upload of these files would introduce and an alternative to have to extended the GUI.  We could leave the GUI for novice use but allow uploaded configs for advanced configuration.  So this is my default config:\r\n```\r\n;\r\n; ESP-01 512KB Module config\r\n;\r\nflash_size       = 512K\r\nbit_rate         = 115200\r\nclient_ssl       = disable\r\ngpio_interrupt   = enable\r\nspiffs_cache     = enable\r\nsha2             = disable\r\nbuiltin = string,table,coroutine,math,debug_minimal\r\nmodules = node,file,gpio,wifi,net,i2c,tmr,uart,ow,bit\r\n```\r\nThe source is [here](https://gist.github.com/TerryE/c1343be7c39cef6b3bc7) on gist. I chose Lua because this is a Lua project and I need Lua on my host for `luac.cross` anyway, but this given that docker images don't have Lua installed as standard, we could easily reimplement in Python or even bash."},"comment":{"url":"https://api.github.com/repos/marcelstoer/docker-nodemcu-build/issues/comments/192912520","html_url":"https://github.com/marcelstoer/docker-nodemcu-build/issues/6#issuecomment-192912520","issue_url":"https://api.github.com/repos/marcelstoer/docker-nodemcu-build/issues/6","id":192912520,"user":{"login":"marcelstoer","id":624195,"avatar_url":"https://avatars.githubusercontent.com/u/624195?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"created_at":"2016-03-06T15:14:47Z","updated_at":"2016-03-06T15:14:47Z","body":"Sorry Terry, I didn't ignore it on purpose...it must have drowned in a sea of NodeMCU-related messages.\r\n\r\nI remember we've touched on this on a firmware issue and I'd very much welcome if the relevant firmware `.h` files for the firmware would be generated / augmented as you propose. It'd also greatly simplify my cloud builder implementation. However, I don't really understand what this, the term \"upload\" and the cloud builder has got to do with the Docker image. Can you please clarify that?\r\n\r\nThe Docker image and the cloud builder have got nothing to do with each other (i.e. they're not dependent on each other). And you're right, I won't allow uploading a config file through the cloud builder UI. It would IMO also defeat its purpose to a certain extent. It's got a graphical UI to lower the barrier for novices as much as possible. I believe those who feel comfortable enough tinkering with config files might as well use the Docker image. As I said, it'd be great if those building the firmware themselves (NodeMCU collaborators / contributors and others) could configure it in a more concise way rather than editing several header files. However, it would IMO be rather odd if such a comfortable mechanism were offered by a 3rd party Docker image instead of being built into the firmware build process itself.\r\n\r\nDoes that sound logical or is this a great misunderstanding?"}}