{"action":"created","issue":{"url":"https://api.github.com/repos/dmbates/FLAC.jl/issues/3","repository_url":"https://api.github.com/repos/dmbates/FLAC.jl","labels_url":"https://api.github.com/repos/dmbates/FLAC.jl/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/dmbates/FLAC.jl/issues/3/comments","events_url":"https://api.github.com/repos/dmbates/FLAC.jl/issues/3/events","html_url":"https://github.com/dmbates/FLAC.jl/pull/3","id":150223298,"number":3,"title":"[WIP] Complete `FileIO` integration, remove wav-related functionality add tests","user":{"login":"staticfloat","id":130920,"avatar_url":"https://avatars.githubusercontent.com/u/130920?v=3","gravatar_id":"","url":"https://api.github.com/users/staticfloat","html_url":"https://github.com/staticfloat","followers_url":"https://api.github.com/users/staticfloat/followers","following_url":"https://api.github.com/users/staticfloat/following{/other_user}","gists_url":"https://api.github.com/users/staticfloat/gists{/gist_id}","starred_url":"https://api.github.com/users/staticfloat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staticfloat/subscriptions","organizations_url":"https://api.github.com/users/staticfloat/orgs","repos_url":"https://api.github.com/users/staticfloat/repos","events_url":"https://api.github.com/users/staticfloat/events{/privacy}","received_events_url":"https://api.github.com/users/staticfloat/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-22T00:02:42Z","updated_at":"2016-04-22T18:59:46Z","closed_at":"2016-04-22T18:33:14Z","pull_request":{"url":"https://api.github.com/repos/dmbates/FLAC.jl/pulls/3","html_url":"https://github.com/dmbates/FLAC.jl/pull/3","diff_url":"https://github.com/dmbates/FLAC.jl/pull/3.diff","patch_url":"https://github.com/dmbates/FLAC.jl/pull/3.patch"},"body":"Hey @dmbates; I figured out the usage of decoding, so I went ahead and added the necessary hooks for `FileIO`, including removing `fileio.jl`, as it wasn't doing anything (apparently you need to get it included in [the `FileIO` registry](https://github.com/JuliaIO/FileIO.jl/blob/e10242de106c8c27823fb920fad787beef5aff26/src/registry.jl#L112) before that integration is doing anything), and while I was at it I removed the `WAV` reading/writing parts of this in favor of the more feature-complete `WAV.jl` that I hope to get integrated with `FileIO` soon.\r\n\r\nAfter getting `load()` working properly, I added some tests to ensure that things are on the up-and-up and it looks good.  I plan on getting `save()` working through the encoding API next.\r\n\r\nWhat are your thoughts on these changes? The main thing I worry about is removing the wav-related functionality, as your code did have a nice property in that it would `mmap()` the wav into julia's address space, but it failed to open any of the wave files I had lying around due to extra metadata in them, so I figured it would be better to add `mmap()` functionality into `WAV.jl` than to continue reinventing the wheel in this package."},"comment":{"url":"https://api.github.com/repos/dmbates/FLAC.jl/issues/comments/213553441","html_url":"https://github.com/dmbates/FLAC.jl/pull/3#issuecomment-213553441","issue_url":"https://api.github.com/repos/dmbates/FLAC.jl/issues/3","id":213553441,"user":{"login":"staticfloat","id":130920,"avatar_url":"https://avatars.githubusercontent.com/u/130920?v=3","gravatar_id":"","url":"https://api.github.com/users/staticfloat","html_url":"https://github.com/staticfloat","followers_url":"https://api.github.com/users/staticfloat/followers","following_url":"https://api.github.com/users/staticfloat/following{/other_user}","gists_url":"https://api.github.com/users/staticfloat/gists{/gist_id}","starred_url":"https://api.github.com/users/staticfloat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staticfloat/subscriptions","organizations_url":"https://api.github.com/users/staticfloat/orgs","repos_url":"https://api.github.com/users/staticfloat/repos","events_url":"https://api.github.com/users/staticfloat/events{/privacy}","received_events_url":"https://api.github.com/users/staticfloat/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T18:59:46Z","updated_at":"2016-04-22T18:59:46Z","body":"No problem!  Thank _you_ for doing all the hard work; I need FLAC reading/writing ability in my research, so I was very happy to find something 95% of the way there."}}