{"action":"created","issue":{"url":"https://api.github.com/repos/bnjbvr/kresus/issues/323","labels_url":"https://api.github.com/repos/bnjbvr/kresus/issues/323/labels{/name}","comments_url":"https://api.github.com/repos/bnjbvr/kresus/issues/323/comments","events_url":"https://api.github.com/repos/bnjbvr/kresus/issues/323/events","html_url":"https://github.com/bnjbvr/kresus/pull/323","id":125498006,"number":323,"title":"Update banks + integration","user":{"login":"ZeHiro","id":7999082,"avatar_url":"https://avatars.githubusercontent.com/u/7999082?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeHiro","html_url":"https://github.com/ZeHiro","followers_url":"https://api.github.com/users/ZeHiro/followers","following_url":"https://api.github.com/users/ZeHiro/following{/other_user}","gists_url":"https://api.github.com/users/ZeHiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeHiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeHiro/subscriptions","organizations_url":"https://api.github.com/users/ZeHiro/orgs","repos_url":"https://api.github.com/users/ZeHiro/repos","events_url":"https://api.github.com/users/ZeHiro/events{/privacy}","received_events_url":"https://api.github.com/users/ZeHiro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-07T22:21:12Z","updated_at":"2016-01-09T00:25:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bnjbvr/kresus/pulls/323","html_url":"https://github.com/bnjbvr/kresus/pull/323","diff_url":"https://github.com/bnjbvr/kresus/pull/323.diff","patch_url":"https://github.com/bnjbvr/kresus/pull/323.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/bnjbvr/kresus/323)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/bnjbvr/kresus/issues/comments/170167767","html_url":"https://github.com/bnjbvr/kresus/pull/323#issuecomment-170167767","issue_url":"https://api.github.com/repos/bnjbvr/kresus/issues/323","id":170167767,"user":{"login":"ZeHiro","id":7999082,"avatar_url":"https://avatars.githubusercontent.com/u/7999082?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeHiro","html_url":"https://github.com/ZeHiro","followers_url":"https://api.github.com/users/ZeHiro/followers","following_url":"https://api.github.com/users/ZeHiro/following{/other_user}","gists_url":"https://api.github.com/users/ZeHiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeHiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeHiro/subscriptions","organizations_url":"https://api.github.com/users/ZeHiro/orgs","repos_url":"https://api.github.com/users/ZeHiro/repos","events_url":"https://api.github.com/users/ZeHiro/events{/privacy}","received_events_url":"https://api.github.com/users/ZeHiro/received_events","type":"User","site_admin":false},"created_at":"2016-01-09T00:25:03Z","updated_at":"2016-01-09T00:25:03Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 8 unresolved discussions.\n\n---\n\n*[client/components/CustomBankField.js, line 40 \\[r1\\]](https://reviewable.io:443/reviews/bnjbvr/kresus/323#-K7YYebyojht7HvPCB4H:-K7YkSa1vs177IXthnkz:-1357479498) ([raw file](https://github.com/bnjbvr/kresus/blob/bc2cf91f17751183d90f898c75c520d3e335bf04/client/components/CustomBankField.js#L40)):*\nPlaceholders should be kept until there is a proper check and validation of value using weboob regexps\n\n---\n\n*[server/models/bank.js, line 45 \\[r1\\]](https://reviewable.io:443/reviews/bnjbvr/kresus/323#-K7YZ84K-nB9XMUbHVP3:-K7Ykgz58qhqXYFxhXpH:1802939572) ([raw file](https://github.com/bnjbvr/kresus/blob/bc2cf91f17751183d90f898c75c520d3e335bf04/server/models/bank.js#L45)):*\ncustomFieldAreEqual  does not manage the case where after an upgrade, customFields appear, like with this big bank.json upgrade\n\n---\n\n*[shared/banks.json, line 14 \\[r1\\]](https://reviewable.io:443/reviews/bnjbvr/kresus/323#-K7YW3K6s_uoDSfE-IbE:-K7YjrYKI8sP59laTENA:-2120437675) ([raw file](https://github.com/bnjbvr/kresus/blob/bc2cf91f17751183d90f898c75c520d3e335bf04/shared/banks.json#L14)):*\nWeboob says so, the script just parses this\n\n---\n\n*[shared/banks.json, line 55 \\[r1\\]](https://reviewable.io:443/reviews/bnjbvr/kresus/323#-K7YWDDEdfBbDio7l812:-K7YjveqmSpnYvs0n2Mv:-23059817) ([raw file](https://github.com/bnjbvr/kresus/blob/bc2cf91f17751183d90f898c75c520d3e335bf04/shared/banks.json#L55)):*\nI would use labels in case a new module appears ans we didn  integrate it well. I could help\n\n---\n\n*[shared/banks.json, line 596 \\[r1\\]](https://reviewable.io:443/reviews/bnjbvr/kresus/323#-K7YXyQ5_Luvr9toBY5s:-K7Yk8RbzfYiSuVbnltj:-618606815) ([raw file](https://github.com/bnjbvr/kresus/blob/bc2cf91f17751183d90f898c75c520d3e335bf04/shared/banks.json#L596)):*\nweboob's fault\n\n---\n\n*[shared/banks.json, line 806 \\[r1\\]](https://reviewable.io:443/reviews/bnjbvr/kresus/323#-K7YYHOtJH5MdIW2YiOj:-K7YkDLk5h10OL5xJUrf:2049589426) ([raw file](https://github.com/bnjbvr/kresus/blob/bc2cf91f17751183d90f898c75c520d3e335bf04/shared/banks.json#L806)):*\nweboob's fauls as well.\n\n---\n\n*[shared/banks.json, line 866 \\[r1\\]](https://reviewable.io:443/reviews/bnjbvr/kresus/323#-K7YYQEOe44hqb59wX0Y:-K7YkIriB87Vy6EGJ9mO:1275517632) ([raw file](https://github.com/bnjbvr/kresus/blob/bc2cf91f17751183d90f898c75c520d3e335bf04/shared/banks.json#L866)):*\nwell nano and gedit are not here\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/bnjbvr/kresus/323)*\n<!-- Sent from Reviewable.io -->\n"}}