{"action":"created","comment":{"url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/comments/78969920","id":78969920,"diff_hunk":"@@ -189,21 +194,22 @@ def __init__(self, options, test_file=None, test_string=None,\n \n     def getTestDetails(self):\n         return {\n-            'probe_asn': config.probe_ip.geodata['asn'],\n-            'probe_cc': config.probe_ip.geodata['countrycode'],\n-            'probe_ip': config.probe_ip.geodata['ip'],\n-            'probe_city': config.probe_ip.geodata['city'],\n+            'probe_asn': probe_ip.geodata['asn'],\n+            'probe_cc': probe_ip.geodata['countrycode'],\n+            'probe_ip': probe_ip.geodata['ip'],\n+            'probe_city': probe_ip.geodata['city'],\n             'software_name': 'ooniprobe',\n             'software_version': ooniprobe_version,\n+            # XXX only sanitize the input files","path":"ooni/nettest.py","position":94,"original_position":94,"commit_id":"45993baf6bf0ae5377dcc9f99d9bf1c19a050b0b","original_commit_id":"45993baf6bf0ae5377dcc9f99d9bf1c19a050b0b","user":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars.githubusercontent.com/u/337298?v=3","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"body":"I do not fully understand this comment","created_at":"2016-09-15T14:00:09Z","updated_at":"2016-09-15T14:00:09Z","html_url":"https://github.com/TheTorProject/ooni-probe/pull/582#discussion_r78969920","pull_request_url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/582","_links":{"self":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/comments/78969920"},"html":{"href":"https://github.com/TheTorProject/ooni-probe/pull/582#discussion_r78969920"},"pull_request":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/582"}}},"pull_request":{"url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/582","id":79924226,"html_url":"https://github.com/TheTorProject/ooni-probe/pull/582","diff_url":"https://github.com/TheTorProject/ooni-probe/pull/582.diff","patch_url":"https://github.com/TheTorProject/ooni-probe/pull/582.patch","issue_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/582","number":582,"state":"open","locked":false,"title":"V2.0.0 alpha","user":{"login":"hellais","id":424620,"avatar_url":"https://avatars.githubusercontent.com/u/424620?v=3","gravatar_id":"","url":"https://api.github.com/users/hellais","html_url":"https://github.com/hellais","followers_url":"https://api.github.com/users/hellais/followers","following_url":"https://api.github.com/users/hellais/following{/other_user}","gists_url":"https://api.github.com/users/hellais/gists{/gist_id}","starred_url":"https://api.github.com/users/hellais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellais/subscriptions","organizations_url":"https://api.github.com/users/hellais/orgs","repos_url":"https://api.github.com/users/hellais/repos","events_url":"https://api.github.com/users/hellais/events{/privacy}","received_events_url":"https://api.github.com/users/hellais/received_events","type":"User","site_admin":false},"body":"This is the work in progress branch to keep track of the status of ooniprobe alpha.\r\n\r\nWe are probably not going to be integrating this into master sooner than end of August, early September. So the purpose of this is give people a tip that they can use to test ooniprobe 2.0.0 and keep track of when it's ready to be finally integrated into master.","created_at":"2016-08-03T15:12:55Z","updated_at":"2016-09-15T14:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52b6c14dd486d043aa3858d331e6821c9a223db4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/582/commits","review_comments_url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/582/comments","review_comment_url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/582/comments","statuses_url":"https://api.github.com/repos/TheTorProject/ooni-probe/statuses/45993baf6bf0ae5377dcc9f99d9bf1c19a050b0b","head":{"label":"TheTorProject:v2.0.0-alpha","ref":"v2.0.0-alpha","sha":"45993baf6bf0ae5377dcc9f99d9bf1c19a050b0b","user":{"login":"TheTorProject","id":3301912,"avatar_url":"https://avatars.githubusercontent.com/u/3301912?v=3","gravatar_id":"","url":"https://api.github.com/users/TheTorProject","html_url":"https://github.com/TheTorProject","followers_url":"https://api.github.com/users/TheTorProject/followers","following_url":"https://api.github.com/users/TheTorProject/following{/other_user}","gists_url":"https://api.github.com/users/TheTorProject/gists{/gist_id}","starred_url":"https://api.github.com/users/TheTorProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheTorProject/subscriptions","organizations_url":"https://api.github.com/users/TheTorProject/orgs","repos_url":"https://api.github.com/users/TheTorProject/repos","events_url":"https://api.github.com/users/TheTorProject/events{/privacy}","received_events_url":"https://api.github.com/users/TheTorProject/received_events","type":"Organization","site_admin":false},"repo":{"id":3944100,"name":"ooni-probe","full_name":"TheTorProject/ooni-probe","owner":{"login":"TheTorProject","id":3301912,"avatar_url":"https://avatars.githubusercontent.com/u/3301912?v=3","gravatar_id":"","url":"https://api.github.com/users/TheTorProject","html_url":"https://github.com/TheTorProject","followers_url":"https://api.github.com/users/TheTorProject/followers","following_url":"https://api.github.com/users/TheTorProject/following{/other_user}","gists_url":"https://api.github.com/users/TheTorProject/gists{/gist_id}","starred_url":"https://api.github.com/users/TheTorProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheTorProject/subscriptions","organizations_url":"https://api.github.com/users/TheTorProject/orgs","repos_url":"https://api.github.com/users/TheTorProject/repos","events_url":"https://api.github.com/users/TheTorProject/events{/privacy}","received_events_url":"https://api.github.com/users/TheTorProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheTorProject/ooni-probe","description":"ooni-probe: network measurement writing framework aimed at detecting network interference.","fork":false,"url":"https://api.github.com/repos/TheTorProject/ooni-probe","forks_url":"https://api.github.com/repos/TheTorProject/ooni-probe/forks","keys_url":"https://api.github.com/repos/TheTorProject/ooni-probe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheTorProject/ooni-probe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheTorProject/ooni-probe/teams","hooks_url":"https://api.github.com/repos/TheTorProject/ooni-probe/hooks","issue_events_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/events{/number}","events_url":"https://api.github.com/repos/TheTorProject/ooni-probe/events","assignees_url":"https://api.github.com/repos/TheTorProject/ooni-probe/assignees{/user}","branches_url":"https://api.github.com/repos/TheTorProject/ooni-probe/branches{/branch}","tags_url":"https://api.github.com/repos/TheTorProject/ooni-probe/tags","blobs_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheTorProject/ooni-probe/statuses/{sha}","languages_url":"https://api.github.com/repos/TheTorProject/ooni-probe/languages","stargazers_url":"https://api.github.com/repos/TheTorProject/ooni-probe/stargazers","contributors_url":"https://api.github.com/repos/TheTorProject/ooni-probe/contributors","subscribers_url":"https://api.github.com/repos/TheTorProject/ooni-probe/subscribers","subscription_url":"https://api.github.com/repos/TheTorProject/ooni-probe/subscription","commits_url":"https://api.github.com/repos/TheTorProject/ooni-probe/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheTorProject/ooni-probe/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheTorProject/ooni-probe/contents/{+path}","compare_url":"https://api.github.com/repos/TheTorProject/ooni-probe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheTorProject/ooni-probe/merges","archive_url":"https://api.github.com/repos/TheTorProject/ooni-probe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheTorProject/ooni-probe/downloads","issues_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues{/number}","pulls_url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls{/number}","milestones_url":"https://api.github.com/repos/TheTorProject/ooni-probe/milestones{/number}","notifications_url":"https://api.github.com/repos/TheTorProject/ooni-probe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheTorProject/ooni-probe/labels{/name}","releases_url":"https://api.github.com/repos/TheTorProject/ooni-probe/releases{/id}","deployments_url":"https://api.github.com/repos/TheTorProject/ooni-probe/deployments","created_at":"2012-04-05T20:59:23Z","updated_at":"2016-09-15T06:59:15Z","pushed_at":"2016-09-15T10:42:15Z","git_url":"git://github.com/TheTorProject/ooni-probe.git","ssh_url":"git@github.com:TheTorProject/ooni-probe.git","clone_url":"https://github.com/TheTorProject/ooni-probe.git","svn_url":"https://github.com/TheTorProject/ooni-probe","homepage":"https://ooni.torproject.org","size":6766,"stargazers_count":267,"watchers_count":267,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":59,"forks":94,"open_issues":59,"watchers":267,"default_branch":"master"}},"base":{"label":"TheTorProject:master","ref":"master","sha":"da00195094cdf22678d42608cdbc3bb22b9d757e","user":{"login":"TheTorProject","id":3301912,"avatar_url":"https://avatars.githubusercontent.com/u/3301912?v=3","gravatar_id":"","url":"https://api.github.com/users/TheTorProject","html_url":"https://github.com/TheTorProject","followers_url":"https://api.github.com/users/TheTorProject/followers","following_url":"https://api.github.com/users/TheTorProject/following{/other_user}","gists_url":"https://api.github.com/users/TheTorProject/gists{/gist_id}","starred_url":"https://api.github.com/users/TheTorProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheTorProject/subscriptions","organizations_url":"https://api.github.com/users/TheTorProject/orgs","repos_url":"https://api.github.com/users/TheTorProject/repos","events_url":"https://api.github.com/users/TheTorProject/events{/privacy}","received_events_url":"https://api.github.com/users/TheTorProject/received_events","type":"Organization","site_admin":false},"repo":{"id":3944100,"name":"ooni-probe","full_name":"TheTorProject/ooni-probe","owner":{"login":"TheTorProject","id":3301912,"avatar_url":"https://avatars.githubusercontent.com/u/3301912?v=3","gravatar_id":"","url":"https://api.github.com/users/TheTorProject","html_url":"https://github.com/TheTorProject","followers_url":"https://api.github.com/users/TheTorProject/followers","following_url":"https://api.github.com/users/TheTorProject/following{/other_user}","gists_url":"https://api.github.com/users/TheTorProject/gists{/gist_id}","starred_url":"https://api.github.com/users/TheTorProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheTorProject/subscriptions","organizations_url":"https://api.github.com/users/TheTorProject/orgs","repos_url":"https://api.github.com/users/TheTorProject/repos","events_url":"https://api.github.com/users/TheTorProject/events{/privacy}","received_events_url":"https://api.github.com/users/TheTorProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheTorProject/ooni-probe","description":"ooni-probe: network measurement writing framework aimed at detecting network interference.","fork":false,"url":"https://api.github.com/repos/TheTorProject/ooni-probe","forks_url":"https://api.github.com/repos/TheTorProject/ooni-probe/forks","keys_url":"https://api.github.com/repos/TheTorProject/ooni-probe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheTorProject/ooni-probe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheTorProject/ooni-probe/teams","hooks_url":"https://api.github.com/repos/TheTorProject/ooni-probe/hooks","issue_events_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/events{/number}","events_url":"https://api.github.com/repos/TheTorProject/ooni-probe/events","assignees_url":"https://api.github.com/repos/TheTorProject/ooni-probe/assignees{/user}","branches_url":"https://api.github.com/repos/TheTorProject/ooni-probe/branches{/branch}","tags_url":"https://api.github.com/repos/TheTorProject/ooni-probe/tags","blobs_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheTorProject/ooni-probe/statuses/{sha}","languages_url":"https://api.github.com/repos/TheTorProject/ooni-probe/languages","stargazers_url":"https://api.github.com/repos/TheTorProject/ooni-probe/stargazers","contributors_url":"https://api.github.com/repos/TheTorProject/ooni-probe/contributors","subscribers_url":"https://api.github.com/repos/TheTorProject/ooni-probe/subscribers","subscription_url":"https://api.github.com/repos/TheTorProject/ooni-probe/subscription","commits_url":"https://api.github.com/repos/TheTorProject/ooni-probe/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheTorProject/ooni-probe/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheTorProject/ooni-probe/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheTorProject/ooni-probe/contents/{+path}","compare_url":"https://api.github.com/repos/TheTorProject/ooni-probe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheTorProject/ooni-probe/merges","archive_url":"https://api.github.com/repos/TheTorProject/ooni-probe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheTorProject/ooni-probe/downloads","issues_url":"https://api.github.com/repos/TheTorProject/ooni-probe/issues{/number}","pulls_url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls{/number}","milestones_url":"https://api.github.com/repos/TheTorProject/ooni-probe/milestones{/number}","notifications_url":"https://api.github.com/repos/TheTorProject/ooni-probe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheTorProject/ooni-probe/labels{/name}","releases_url":"https://api.github.com/repos/TheTorProject/ooni-probe/releases{/id}","deployments_url":"https://api.github.com/repos/TheTorProject/ooni-probe/deployments","created_at":"2012-04-05T20:59:23Z","updated_at":"2016-09-15T06:59:15Z","pushed_at":"2016-09-15T10:42:15Z","git_url":"git://github.com/TheTorProject/ooni-probe.git","ssh_url":"git@github.com:TheTorProject/ooni-probe.git","clone_url":"https://github.com/TheTorProject/ooni-probe.git","svn_url":"https://github.com/TheTorProject/ooni-probe","homepage":"https://ooni.torproject.org","size":6766,"stargazers_count":267,"watchers_count":267,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":59,"forks":94,"open_issues":59,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/582"},"html":{"href":"https://github.com/TheTorProject/ooni-probe/pull/582"},"issue":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/582"},"comments":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/statuses/45993baf6bf0ae5377dcc9f99d9bf1c19a050b0b"}}}}
{"actor":{"display_login":"bassosimone"}}