{"action":"created","comment":{"url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/comments/54124719","id":54124719,"diff_hunk":"@@ -6,24 +6,25 @@\n \n This project provides a number of libraries to facilitate [ConductR](http://typesafe.com/products/conductr)'s status service and its service lookup service. Note that usage of the libraries in your code is entirely benign when used outside of the context of ConductR i.e. you will find that your applications and services will continue to function normally when used without ConductR. We have also designed the libraries to be a convenience to ConductR's REST and environment variable based APIs, and to have a very low impact on your code.\n \n-For the current production release of ConductR (1.0), the libraries use Akka streams/http 1.0 and are structured as follows:\n-\n-* `\"com.typesafe.conductr\" %  \"conductr-bundle-lib\"        % \"1.0.2\"`\n-* `\"com.typesafe.conductr\" %% \"scala-conductr-bundle-lib\"  % \"1.0.2\"`\n-* `\"com.typesafe.conductr\" %% \"akka23-conductr-bundle-lib\" % \"1.0.2\"`\n-* `\"com.typesafe.conductr\" %% \"play23-conductr-bundle-lib\" % \"1.0.2\"`\n-* `\"com.typesafe.conductr\" %% \"play24-conductr-bundle-lib\" % \"1.0.2\"`\n-\n-For ConductR 1.1 and above, the libraries use Akka streams/http 2.0 and will be:\n-\n-* `\"com.typesafe.conductr\" %  \"conductr-bundle-lib\"        % \"1.2.0\"`\n-* `\"com.typesafe.conductr\" %% \"java-conductr-bundle-lib\"   % \"1.2.0\"`\n-* `\"com.typesafe.conductr\" %% \"scala-conductr-bundle-lib\"  % \"1.2.0\"`\n-* `\"com.typesafe.conductr\" %% \"akka23-conductr-bundle-lib\" % \"1.2.0\"`\n-* `\"com.typesafe.conductr\" %% \"akka24-conductr-bundle-lib\" % \"1.2.0\"`\n-* `\"com.typesafe.conductr\" %% \"play23-conductr-bundle-lib\" % \"1.2.0\"`\n-* `\"com.typesafe.conductr\" %% \"play24-conductr-bundle-lib\" % \"1.2.0\"`\n-* `\"com.typesafe.conductr\" %% \"play25-conductr-bundle-lib\" % \"1.2.0\"`\n+For the current production release of ConductR (1.0), the libraries use Akka streams/http 1.x and are structured as follows:\n+\n+* `\"com.typesafe.conductr\" %  \"conductr-bundle-lib\"         % \"1.0.2\"`\n+* `\"com.typesafe.conductr\" %% \"scala-conductr-bundle-lib\"   % \"1.0.2\"`\n+* `\"com.typesafe.conductr\" %% \"akka23-conductr-bundle-lib\"  % \"1.0.2\"`\n+* `\"com.typesafe.conductr\" %% \"play23-conductr-bundle-lib\"  % \"1.0.2\"`\n+* `\"com.typesafe.conductr\" %% \"play24-conductr-bundle-lib\"  % \"1.0.2\"`\n+\n+For ConductR 1.1 and above, the libraries use Akka streams/http 2.x and will be:\n+\n+* `\"com.typesafe.conductr\" %  \"conductr-bundle-lib\"         % \"1.2.0\"`\n+* `\"com.typesafe.conductr\" %% \"java-conductr-bundle-lib\"    % \"1.2.0\"`\n+* `\"com.typesafe.conductr\" %% \"scala-conductr-bundle-lib\"   % \"1.2.0\"`\n+* `\"com.typesafe.conductr\" %% \"akka23-conductr-bundle-lib\"  % \"1.2.0\"`\n+* `\"com.typesafe.conductr\" %% \"akka24-conductr-bundle-lib\"  % \"1.2.0\"`\n+* `\"com.typesafe.conductr\" %% \"play23-conductr-bundle-lib\"  % \"1.2.0\"`\n+* `\"com.typesafe.conductr\" %% \"play24-conductr-bundle-lib\"  % \"1.2.0\"`\n+* `\"com.typesafe.conductr\" %% \"play25-conductr-bundle-lib\"  % \"1.2.0\"`\n+* `\"com.typesafe.conductr\" %% \"lagom10-conductr-bundle-lib\" % \"1.2.0\"`","path":"README.md","position":40,"original_position":40,"commit_id":"fd67b42da6d5ffb8661c8b9eb105d58a65c0afa6","original_commit_id":"fd67b42da6d5ffb8661c8b9eb105d58a65c0afa6","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"Isn't Lagom targeting ConductR 1.2?","created_at":"2016-02-25T16:45:07Z","updated_at":"2016-02-25T16:45:07Z","html_url":"https://github.com/typesafehub/conductr-lib/pull/87#discussion_r54124719","pull_request_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/comments/54124719"},"html":{"href":"https://github.com/typesafehub/conductr-lib/pull/87#discussion_r54124719"},"pull_request":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/87","id":60649755,"html_url":"https://github.com/typesafehub/conductr-lib/pull/87","diff_url":"https://github.com/typesafehub/conductr-lib/pull/87.diff","patch_url":"https://github.com/typesafehub/conductr-lib/pull/87.patch","issue_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues/87","number":87,"state":"open","locked":false,"title":"Lagom bundle lib","user":{"login":"markusjura","id":1832216,"avatar_url":"https://avatars.githubusercontent.com/u/1832216?v=3","gravatar_id":"","url":"https://api.github.com/users/markusjura","html_url":"https://github.com/markusjura","followers_url":"https://api.github.com/users/markusjura/followers","following_url":"https://api.github.com/users/markusjura/following{/other_user}","gists_url":"https://api.github.com/users/markusjura/gists{/gist_id}","starred_url":"https://api.github.com/users/markusjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusjura/subscriptions","organizations_url":"https://api.github.com/users/markusjura/orgs","repos_url":"https://api.github.com/users/markusjura/repos","events_url":"https://api.github.com/users/markusjura/events{/privacy}","received_events_url":"https://api.github.com/users/markusjura/received_events","type":"User","site_admin":false},"body":"Lagom conductr-bundle-lib implements `com.lightbend.lagom.javadsl.api.ServiceLocator` by making use of the `com.typesafe.conductr.bundlelib.play.api.LocationService`.","created_at":"2016-02-25T09:39:40Z","updated_at":"2016-02-25T16:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49dd817d73f9c5015672b9da1d9ced37a0552eb0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/87/commits","review_comments_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/87/comments","review_comment_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues/87/comments","statuses_url":"https://api.github.com/repos/typesafehub/conductr-lib/statuses/fd67b42da6d5ffb8661c8b9eb105d58a65c0afa6","head":{"label":"markusjura:lagom-bundle-lib","ref":"lagom-bundle-lib","sha":"fd67b42da6d5ffb8661c8b9eb105d58a65c0afa6","user":{"login":"markusjura","id":1832216,"avatar_url":"https://avatars.githubusercontent.com/u/1832216?v=3","gravatar_id":"","url":"https://api.github.com/users/markusjura","html_url":"https://github.com/markusjura","followers_url":"https://api.github.com/users/markusjura/followers","following_url":"https://api.github.com/users/markusjura/following{/other_user}","gists_url":"https://api.github.com/users/markusjura/gists{/gist_id}","starred_url":"https://api.github.com/users/markusjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusjura/subscriptions","organizations_url":"https://api.github.com/users/markusjura/orgs","repos_url":"https://api.github.com/users/markusjura/repos","events_url":"https://api.github.com/users/markusjura/events{/privacy}","received_events_url":"https://api.github.com/users/markusjura/received_events","type":"User","site_admin":false},"repo":{"id":40005667,"name":"conductr-lib","full_name":"markusjura/conductr-lib","owner":{"login":"markusjura","id":1832216,"avatar_url":"https://avatars.githubusercontent.com/u/1832216?v=3","gravatar_id":"","url":"https://api.github.com/users/markusjura","html_url":"https://github.com/markusjura","followers_url":"https://api.github.com/users/markusjura/followers","following_url":"https://api.github.com/users/markusjura/following{/other_user}","gists_url":"https://api.github.com/users/markusjura/gists{/gist_id}","starred_url":"https://api.github.com/users/markusjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusjura/subscriptions","organizations_url":"https://api.github.com/users/markusjura/orgs","repos_url":"https://api.github.com/users/markusjura/repos","events_url":"https://api.github.com/users/markusjura/events{/privacy}","received_events_url":"https://api.github.com/users/markusjura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markusjura/conductr-lib","description":null,"fork":true,"url":"https://api.github.com/repos/markusjura/conductr-lib","forks_url":"https://api.github.com/repos/markusjura/conductr-lib/forks","keys_url":"https://api.github.com/repos/markusjura/conductr-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markusjura/conductr-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markusjura/conductr-lib/teams","hooks_url":"https://api.github.com/repos/markusjura/conductr-lib/hooks","issue_events_url":"https://api.github.com/repos/markusjura/conductr-lib/issues/events{/number}","events_url":"https://api.github.com/repos/markusjura/conductr-lib/events","assignees_url":"https://api.github.com/repos/markusjura/conductr-lib/assignees{/user}","branches_url":"https://api.github.com/repos/markusjura/conductr-lib/branches{/branch}","tags_url":"https://api.github.com/repos/markusjura/conductr-lib/tags","blobs_url":"https://api.github.com/repos/markusjura/conductr-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markusjura/conductr-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markusjura/conductr-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/markusjura/conductr-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markusjura/conductr-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/markusjura/conductr-lib/languages","stargazers_url":"https://api.github.com/repos/markusjura/conductr-lib/stargazers","contributors_url":"https://api.github.com/repos/markusjura/conductr-lib/contributors","subscribers_url":"https://api.github.com/repos/markusjura/conductr-lib/subscribers","subscription_url":"https://api.github.com/repos/markusjura/conductr-lib/subscription","commits_url":"https://api.github.com/repos/markusjura/conductr-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/markusjura/conductr-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/markusjura/conductr-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/markusjura/conductr-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/markusjura/conductr-lib/contents/{+path}","compare_url":"https://api.github.com/repos/markusjura/conductr-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markusjura/conductr-lib/merges","archive_url":"https://api.github.com/repos/markusjura/conductr-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markusjura/conductr-lib/downloads","issues_url":"https://api.github.com/repos/markusjura/conductr-lib/issues{/number}","pulls_url":"https://api.github.com/repos/markusjura/conductr-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/markusjura/conductr-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/markusjura/conductr-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markusjura/conductr-lib/labels{/name}","releases_url":"https://api.github.com/repos/markusjura/conductr-lib/releases{/id}","deployments_url":"https://api.github.com/repos/markusjura/conductr-lib/deployments","created_at":"2015-07-31T13:04:59Z","updated_at":"2016-01-15T11:24:28Z","pushed_at":"2016-02-25T15:31:35Z","git_url":"git://github.com/markusjura/conductr-lib.git","ssh_url":"git@github.com:markusjura/conductr-lib.git","clone_url":"https://github.com/markusjura/conductr-lib.git","svn_url":"https://github.com/markusjura/conductr-lib","homepage":null,"size":388,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesafehub:master","ref":"master","sha":"adadcb1b28ac0aed731b90151432bfaa5decc3eb","user":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"repo":{"id":30228350,"name":"conductr-lib","full_name":"typesafehub/conductr-lib","owner":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typesafehub/conductr-lib","description":null,"fork":false,"url":"https://api.github.com/repos/typesafehub/conductr-lib","forks_url":"https://api.github.com/repos/typesafehub/conductr-lib/forks","keys_url":"https://api.github.com/repos/typesafehub/conductr-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesafehub/conductr-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesafehub/conductr-lib/teams","hooks_url":"https://api.github.com/repos/typesafehub/conductr-lib/hooks","issue_events_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues/events{/number}","events_url":"https://api.github.com/repos/typesafehub/conductr-lib/events","assignees_url":"https://api.github.com/repos/typesafehub/conductr-lib/assignees{/user}","branches_url":"https://api.github.com/repos/typesafehub/conductr-lib/branches{/branch}","tags_url":"https://api.github.com/repos/typesafehub/conductr-lib/tags","blobs_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesafehub/conductr-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/typesafehub/conductr-lib/languages","stargazers_url":"https://api.github.com/repos/typesafehub/conductr-lib/stargazers","contributors_url":"https://api.github.com/repos/typesafehub/conductr-lib/contributors","subscribers_url":"https://api.github.com/repos/typesafehub/conductr-lib/subscribers","subscription_url":"https://api.github.com/repos/typesafehub/conductr-lib/subscription","commits_url":"https://api.github.com/repos/typesafehub/conductr-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesafehub/conductr-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/typesafehub/conductr-lib/contents/{+path}","compare_url":"https://api.github.com/repos/typesafehub/conductr-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesafehub/conductr-lib/merges","archive_url":"https://api.github.com/repos/typesafehub/conductr-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesafehub/conductr-lib/downloads","issues_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues{/number}","pulls_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/typesafehub/conductr-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/typesafehub/conductr-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesafehub/conductr-lib/labels{/name}","releases_url":"https://api.github.com/repos/typesafehub/conductr-lib/releases{/id}","deployments_url":"https://api.github.com/repos/typesafehub/conductr-lib/deployments","created_at":"2015-02-03T06:16:58Z","updated_at":"2016-02-10T18:38:21Z","pushed_at":"2016-02-25T15:31:35Z","git_url":"git://github.com/typesafehub/conductr-lib.git","ssh_url":"git@github.com:typesafehub/conductr-lib.git","clone_url":"https://github.com/typesafehub/conductr-lib.git","svn_url":"https://github.com/typesafehub/conductr-lib","homepage":null,"size":383,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/87"},"html":{"href":"https://github.com/typesafehub/conductr-lib/pull/87"},"issue":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/issues/87"},"comments":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/statuses/fd67b42da6d5ffb8661c8b9eb105d58a65c0afa6"}}}}