{"action":"created","comment":{"url":"https://api.github.com/repos/nagisa/rust/pulls/comments/63344138","id":63344138,"diff_hunk":"@@ -168,12 +134,14 @@ impl<F: Lattice> ::std::ops::IndexMut<BasicBlock> for Facts<F> {\n }\n \n /// Analyse and rewrite using dataflow in the forward direction\n-pub fn ar_forward<'tcx, T, P>(cfg: &CFG<'tcx>, fs: Facts<P::Lattice>, mut queue: BitVector)\n--> (CFG<'tcx>, Facts<P::Lattice>)\n-// FIXME: shouldn’t need that T generic.\n-where T: Transfer<'tcx, P::Lattice, TerminatorOut=Vec<P::Lattice>>,\n-      P: DataflowPass<'tcx, Transfer=T>\n+pub fn ar_forward<'tcx, T, R>(cfg: &CFG<'tcx>, fs: Facts<T::Lattice>, transfer: T, rewrite: R)\n+-> (CFG<'tcx>, Facts<T::Lattice>)\n+where T: Transfer<'tcx>,\n+      R: Rewrite<'tcx, T::Lattice>\n {\n+    let mut queue = BitVector::new(cfg.len());\n+    queue.insert(START_BLOCK.index());","path":"src/librustc/mir/transform/dataflow.rs","position":152,"original_position":152,"commit_id":"ca5258657a9e9f952cd9d0a380d4480a2f879477","original_commit_id":"ca5258657a9e9f952cd9d0a380d4480a2f879477","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"body":"Similarly here, I do not believe that beginning at the start block is always correct/desired/etc.","created_at":"2016-05-16T12:12:11Z","updated_at":"2016-05-16T12:12:11Z","html_url":"https://github.com/nagisa/rust/pull/1#discussion_r63344138","pull_request_url":"https://api.github.com/repos/nagisa/rust/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/nagisa/rust/pulls/comments/63344138"},"html":{"href":"https://github.com/nagisa/rust/pull/1#discussion_r63344138"},"pull_request":{"href":"https://api.github.com/repos/nagisa/rust/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/nagisa/rust/pulls/1","id":70187320,"html_url":"https://github.com/nagisa/rust/pull/1","diff_url":"https://github.com/nagisa/rust/pull/1.diff","patch_url":"https://github.com/nagisa/rust/pull/1.patch","issue_url":"https://api.github.com/repos/nagisa/rust/issues/1","number":1,"state":"open","locked":false,"title":"Various fixes and improvements to the MIR Dataflow framework","user":{"login":"gereeter","id":2328242,"avatar_url":"https://avatars.githubusercontent.com/u/2328242?v=3","gravatar_id":"","url":"https://api.github.com/users/gereeter","html_url":"https://github.com/gereeter","followers_url":"https://api.github.com/users/gereeter/followers","following_url":"https://api.github.com/users/gereeter/following{/other_user}","gists_url":"https://api.github.com/users/gereeter/gists{/gist_id}","starred_url":"https://api.github.com/users/gereeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gereeter/subscriptions","organizations_url":"https://api.github.com/users/gereeter/orgs","repos_url":"https://api.github.com/users/gereeter/repos","events_url":"https://api.github.com/users/gereeter/events{/privacy}","received_events_url":"https://api.github.com/users/gereeter/received_events","type":"User","site_admin":false},"body":"Since you mentioned that you were too busy to work much on your PR, I thought I would do some work myself.","created_at":"2016-05-16T12:05:20Z","updated_at":"2016-05-16T12:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8906b5a528b9cde8a56565e77963e2d59e6379fe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nagisa/rust/pulls/1/commits","review_comments_url":"https://api.github.com/repos/nagisa/rust/pulls/1/comments","review_comment_url":"https://api.github.com/repos/nagisa/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nagisa/rust/issues/1/comments","statuses_url":"https://api.github.com/repos/nagisa/rust/statuses/ca5258657a9e9f952cd9d0a380d4480a2f879477","head":{"label":"gereeter:mir-dflow","ref":"mir-dflow","sha":"ca5258657a9e9f952cd9d0a380d4480a2f879477","user":{"login":"gereeter","id":2328242,"avatar_url":"https://avatars.githubusercontent.com/u/2328242?v=3","gravatar_id":"","url":"https://api.github.com/users/gereeter","html_url":"https://github.com/gereeter","followers_url":"https://api.github.com/users/gereeter/followers","following_url":"https://api.github.com/users/gereeter/following{/other_user}","gists_url":"https://api.github.com/users/gereeter/gists{/gist_id}","starred_url":"https://api.github.com/users/gereeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gereeter/subscriptions","organizations_url":"https://api.github.com/users/gereeter/orgs","repos_url":"https://api.github.com/users/gereeter/repos","events_url":"https://api.github.com/users/gereeter/events{/privacy}","received_events_url":"https://api.github.com/users/gereeter/received_events","type":"User","site_admin":false},"repo":{"id":17634944,"name":"rust","full_name":"gereeter/rust","owner":{"login":"gereeter","id":2328242,"avatar_url":"https://avatars.githubusercontent.com/u/2328242?v=3","gravatar_id":"","url":"https://api.github.com/users/gereeter","html_url":"https://github.com/gereeter","followers_url":"https://api.github.com/users/gereeter/followers","following_url":"https://api.github.com/users/gereeter/following{/other_user}","gists_url":"https://api.github.com/users/gereeter/gists{/gist_id}","starred_url":"https://api.github.com/users/gereeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gereeter/subscriptions","organizations_url":"https://api.github.com/users/gereeter/orgs","repos_url":"https://api.github.com/users/gereeter/repos","events_url":"https://api.github.com/users/gereeter/events{/privacy}","received_events_url":"https://api.github.com/users/gereeter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gereeter/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/gereeter/rust","forks_url":"https://api.github.com/repos/gereeter/rust/forks","keys_url":"https://api.github.com/repos/gereeter/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gereeter/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gereeter/rust/teams","hooks_url":"https://api.github.com/repos/gereeter/rust/hooks","issue_events_url":"https://api.github.com/repos/gereeter/rust/issues/events{/number}","events_url":"https://api.github.com/repos/gereeter/rust/events","assignees_url":"https://api.github.com/repos/gereeter/rust/assignees{/user}","branches_url":"https://api.github.com/repos/gereeter/rust/branches{/branch}","tags_url":"https://api.github.com/repos/gereeter/rust/tags","blobs_url":"https://api.github.com/repos/gereeter/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gereeter/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gereeter/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/gereeter/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gereeter/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/gereeter/rust/languages","stargazers_url":"https://api.github.com/repos/gereeter/rust/stargazers","contributors_url":"https://api.github.com/repos/gereeter/rust/contributors","subscribers_url":"https://api.github.com/repos/gereeter/rust/subscribers","subscription_url":"https://api.github.com/repos/gereeter/rust/subscription","commits_url":"https://api.github.com/repos/gereeter/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/gereeter/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/gereeter/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/gereeter/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/gereeter/rust/contents/{+path}","compare_url":"https://api.github.com/repos/gereeter/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gereeter/rust/merges","archive_url":"https://api.github.com/repos/gereeter/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gereeter/rust/downloads","issues_url":"https://api.github.com/repos/gereeter/rust/issues{/number}","pulls_url":"https://api.github.com/repos/gereeter/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/gereeter/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/gereeter/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gereeter/rust/labels{/name}","releases_url":"https://api.github.com/repos/gereeter/rust/releases{/id}","deployments_url":"https://api.github.com/repos/gereeter/rust/deployments","created_at":"2014-03-11T15:13:15Z","updated_at":"2016-01-16T19:52:10Z","pushed_at":"2016-05-16T12:02:01Z","git_url":"git://github.com/gereeter/rust.git","ssh_url":"git@github.com:gereeter/rust.git","clone_url":"https://github.com/gereeter/rust.git","svn_url":"https://github.com/gereeter/rust","homepage":"http://www.rust-lang.org","size":291719,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nagisa:mir-dflow","ref":"mir-dflow","sha":"ee4a7c39e84237756fd453356eaec0921356873f","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"repo":{"id":28332501,"name":"rust","full_name":"nagisa/rust","owner":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nagisa/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/nagisa/rust","forks_url":"https://api.github.com/repos/nagisa/rust/forks","keys_url":"https://api.github.com/repos/nagisa/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nagisa/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nagisa/rust/teams","hooks_url":"https://api.github.com/repos/nagisa/rust/hooks","issue_events_url":"https://api.github.com/repos/nagisa/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nagisa/rust/events","assignees_url":"https://api.github.com/repos/nagisa/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nagisa/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nagisa/rust/tags","blobs_url":"https://api.github.com/repos/nagisa/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nagisa/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nagisa/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nagisa/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nagisa/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nagisa/rust/languages","stargazers_url":"https://api.github.com/repos/nagisa/rust/stargazers","contributors_url":"https://api.github.com/repos/nagisa/rust/contributors","subscribers_url":"https://api.github.com/repos/nagisa/rust/subscribers","subscription_url":"https://api.github.com/repos/nagisa/rust/subscription","commits_url":"https://api.github.com/repos/nagisa/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nagisa/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nagisa/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nagisa/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/nagisa/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nagisa/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nagisa/rust/merges","archive_url":"https://api.github.com/repos/nagisa/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nagisa/rust/downloads","issues_url":"https://api.github.com/repos/nagisa/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nagisa/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nagisa/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nagisa/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nagisa/rust/labels{/name}","releases_url":"https://api.github.com/repos/nagisa/rust/releases{/id}","deployments_url":"https://api.github.com/repos/nagisa/rust/deployments","created_at":"2014-12-22T09:30:51Z","updated_at":"2015-01-13T13:18:02Z","pushed_at":"2016-05-16T12:05:20Z","git_url":"git://github.com/nagisa/rust.git","ssh_url":"git@github.com:nagisa/rust.git","clone_url":"https://github.com/nagisa/rust.git","svn_url":"https://github.com/nagisa/rust","homepage":"http://www.rust-lang.org","size":291720,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nagisa/rust/pulls/1"},"html":{"href":"https://github.com/nagisa/rust/pull/1"},"issue":{"href":"https://api.github.com/repos/nagisa/rust/issues/1"},"comments":{"href":"https://api.github.com/repos/nagisa/rust/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/nagisa/rust/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/nagisa/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nagisa/rust/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/nagisa/rust/statuses/ca5258657a9e9f952cd9d0a380d4480a2f879477"}}}}