{"action":"created","issue":{"url":"https://api.github.com/repos/esp8266/Arduino/issues/2639","repository_url":"https://api.github.com/repos/esp8266/Arduino","labels_url":"https://api.github.com/repos/esp8266/Arduino/issues/2639/labels{/name}","comments_url":"https://api.github.com/repos/esp8266/Arduino/issues/2639/comments","events_url":"https://api.github.com/repos/esp8266/Arduino/issues/2639/events","html_url":"https://github.com/esp8266/Arduino/pull/2639","id":185306225,"number":2639,"title":"Set SPI_HAS_TRANSACTION to 1 and implement buffer transfer","user":{"login":"Lauszus","id":1098847,"avatar_url":"https://avatars.githubusercontent.com/u/1098847?v=3","gravatar_id":"","url":"https://api.github.com/users/Lauszus","html_url":"https://github.com/Lauszus","followers_url":"https://api.github.com/users/Lauszus/followers","following_url":"https://api.github.com/users/Lauszus/following{/other_user}","gists_url":"https://api.github.com/users/Lauszus/gists{/gist_id}","starred_url":"https://api.github.com/users/Lauszus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lauszus/subscriptions","organizations_url":"https://api.github.com/users/Lauszus/orgs","repos_url":"https://api.github.com/users/Lauszus/repos","events_url":"https://api.github.com/users/Lauszus/events{/privacy}","received_events_url":"https://api.github.com/users/Lauszus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-26T06:16:57Z","updated_at":"2016-10-26T06:51:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/esp8266/Arduino/pulls/2639","html_url":"https://github.com/esp8266/Arduino/pull/2639","diff_url":"https://github.com/esp8266/Arduino/pull/2639.diff","patch_url":"https://github.com/esp8266/Arduino/pull/2639.patch"},"body":"When implementing support for the ESP8266 in the USB Host library: https://github.com/felis/USB_Host_Shield_2.0/pull/263 I noticed some differences compared to the standard Arduino core. These commits fixes that.\r\n\r\nNote the data pointer is decreased by the data size in the buffer transfer, as transferBytes increments the pointer every time data is read: https://github.com/esp8266/Arduino/blob/master/libraries/SPI/SPI.cpp#L481.\r\n\r\nSince I do not have a ESP8266 at hand I haven't tested these changes.\r\n\r\nAlso see: https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/libraries/SPI/src/SPI.h#L21, https://www.arduino.cc/en/Reference/SPITransfer, and https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/libraries/SPI/src/SPI.h#L244-L257 for reference."},"comment":{"url":"https://api.github.com/repos/esp8266/Arduino/issues/comments/256263849","html_url":"https://github.com/esp8266/Arduino/pull/2639#issuecomment-256263849","issue_url":"https://api.github.com/repos/esp8266/Arduino/issues/2639","id":256263849,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T06:51:22Z","updated_at":"2016-10-26T06:51:22Z","body":"## [Current coverage](https://codecov.io/gh/esp8266/Arduino/pull/2639?src=pr) is 27.80% (diff: 100%)\n> Merging [#2639](https://codecov.io/gh/esp8266/Arduino/pull/2639?src=pr) into [master](https://codecov.io/gh/esp8266/Arduino/branch/master?src=pr) will not change coverage\n\n```diff\n@@             master      #2639   diff @@\n==========================================\n  Files            20         20          \n  Lines          3625       3625          \n  Methods         335        335          \n  Messages          0          0          \n  Branches        656        656          \n==========================================\n  Hits           1008       1008          \n  Misses         2441       2441          \n  Partials        176        176          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [4897e00...04cfaf8](https://codecov.io/gh/esp8266/Arduino/compare/4897e0006b5b0123a2fa31f67b14a3fff65ce561...04cfaf85be5f01bf3d55d73f82b4020198465748?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}