{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/15792","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/15792/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/15792/comments","events_url":"https://api.github.com/repos/golang/go/issues/15792/events","html_url":"https://github.com/golang/go/issues/15792","id":156170180,"number":15792,"title":"cmd/trace,cmd/pprof: should error out when both symbols and binary are missing","user":{"login":"FiloSottile","id":1225294,"avatar_url":"https://avatars.githubusercontent.com/u/1225294?v=3","gravatar_id":"","url":"https://api.github.com/users/FiloSottile","html_url":"https://github.com/FiloSottile","followers_url":"https://api.github.com/users/FiloSottile/followers","following_url":"https://api.github.com/users/FiloSottile/following{/other_user}","gists_url":"https://api.github.com/users/FiloSottile/gists{/gist_id}","starred_url":"https://api.github.com/users/FiloSottile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FiloSottile/subscriptions","organizations_url":"https://api.github.com/users/FiloSottile/orgs","repos_url":"https://api.github.com/users/FiloSottile/repos","events_url":"https://api.github.com/users/FiloSottile/events{/privacy}","received_events_url":"https://api.github.com/users/FiloSottile/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-22T20:11:00Z","updated_at":"2016-05-22T20:11:47Z","closed_at":null,"body":"Go 1.7 added the option to generate trace/pprof files with symbols annotations, so the `trace` help reads:\r\n\r\n```\r\n[pkg.test] argument is required for traces produced by Go 1.6 and below.\r\nGo 1.7 does not require the binary argument.\r\n```\r\n\r\nHowever, if a trace/pprof generated with Go 1.6 and no binary are supplied to the tool, no error is shown. Instead, the output is simply broken (the profiles are all one empty node, for example).\r\n\r\ncmd/trace and cmd/pprof should check if the trace/pprof has annotations, and if not require the binary to be supplied."},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/220853407","html_url":"https://github.com/golang/go/issues/15792#issuecomment-220853407","issue_url":"https://api.github.com/repos/golang/go/issues/15792","id":220853407,"user":{"login":"FiloSottile","id":1225294,"avatar_url":"https://avatars.githubusercontent.com/u/1225294?v=3","gravatar_id":"","url":"https://api.github.com/users/FiloSottile","html_url":"https://github.com/FiloSottile","followers_url":"https://api.github.com/users/FiloSottile/followers","following_url":"https://api.github.com/users/FiloSottile/following{/other_user}","gists_url":"https://api.github.com/users/FiloSottile/gists{/gist_id}","starred_url":"https://api.github.com/users/FiloSottile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FiloSottile/subscriptions","organizations_url":"https://api.github.com/users/FiloSottile/orgs","repos_url":"https://api.github.com/users/FiloSottile/repos","events_url":"https://api.github.com/users/FiloSottile/events{/privacy}","received_events_url":"https://api.github.com/users/FiloSottile/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T20:11:47Z","updated_at":"2016-05-22T20:11:47Z","body":"cc: @dvyukov"}}
{"actor":{"display_login":"FiloSottile"}}