{"action":"created","comment":{"url":"https://api.github.com/repos/koding/koding/pulls/comments/79160289","id":79160289,"diff_hunk":"@@ -21,6 +21,10 @@ import (\n \t\"gopkg.in/mgo.v2/bson\"\n )\n \n+// All is a global lookup map used ny kloud to register\n+// available stack providers.\n+var All = make(map[string]func(*BaseProvider) stack.Provider)","path":"go/src/koding/kites/kloud/provider/provider.go","position":6,"original_position":6,"commit_id":"d8a52f8bb7474402701652236ff7329cd2d99c40","original_commit_id":"d8a52f8bb7474402701652236ff7329cd2d99c40","user":{"login":"cihangir","id":879660,"avatar_url":"https://avatars.githubusercontent.com/u/879660?v=3","gravatar_id":"","url":"https://api.github.com/users/cihangir","html_url":"https://github.com/cihangir","followers_url":"https://api.github.com/users/cihangir/followers","following_url":"https://api.github.com/users/cihangir/following{/other_user}","gists_url":"https://api.github.com/users/cihangir/gists{/gist_id}","starred_url":"https://api.github.com/users/cihangir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cihangir/subscriptions","organizations_url":"https://api.github.com/users/cihangir/orgs","repos_url":"https://api.github.com/users/cihangir/repos","events_url":"https://api.github.com/users/cihangir/events{/privacy}","received_events_url":"https://api.github.com/users/cihangir/received_events","type":"User","site_admin":false},"body":"instead of exposing the var, i would expose a function \r\nsmth like\r\n\r\n```\r\ntype Stacker interface {\r\n  Provide(*provider.BaseProvider) stack.Provider\r\n}\r\n\r\nfunc MustRegister(name string, s Stacker) {\r\n  if _, ok := provider.All[name]; ok {\r\n    panic(\"...\")\r\n  }\r\n\r\n  all[name] = s  \r\n}\r\n```\r\n\r\nit is not a problem, just a taste of my being on the safe side :)","created_at":"2016-09-16T12:37:53Z","updated_at":"2016-09-16T12:37:53Z","html_url":"https://github.com/koding/koding/pull/9004#discussion_r79160289","pull_request_url":"https://api.github.com/repos/koding/koding/pulls/9004","_links":{"self":{"href":"https://api.github.com/repos/koding/koding/pulls/comments/79160289"},"html":{"href":"https://github.com/koding/koding/pull/9004#discussion_r79160289"},"pull_request":{"href":"https://api.github.com/repos/koding/koding/pulls/9004"}}},"pull_request":{"url":"https://api.github.com/repos/koding/koding/pulls/9004","id":84999246,"html_url":"https://github.com/koding/koding/pull/9004","diff_url":"https://github.com/koding/koding/pull/9004.diff","patch_url":"https://github.com/koding/koding/pull/9004.patch","issue_url":"https://api.github.com/repos/koding/koding/issues/9004","number":9004,"state":"open","locked":false,"title":"kloud: cleanup providers / enable providers as plugins","user":{"login":"rjeczalik","id":1162017,"avatar_url":"https://avatars.githubusercontent.com/u/1162017?v=3","gravatar_id":"","url":"https://api.github.com/users/rjeczalik","html_url":"https://github.com/rjeczalik","followers_url":"https://api.github.com/users/rjeczalik/followers","following_url":"https://api.github.com/users/rjeczalik/following{/other_user}","gists_url":"https://api.github.com/users/rjeczalik/gists{/gist_id}","starred_url":"https://api.github.com/users/rjeczalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjeczalik/subscriptions","organizations_url":"https://api.github.com/users/rjeczalik/orgs","repos_url":"https://api.github.com/users/rjeczalik/repos","events_url":"https://api.github.com/users/rjeczalik/events{/privacy}","received_events_url":"https://api.github.com/users/rjeczalik/received_events","type":"User","site_admin":false},"body":"This PR cleans up providers and introduces common interface for a kloud provider (vs previous `interface{}`). This is to enable internal providers and documenting writing a custom one. \r\n","created_at":"2016-09-13T07:41:43Z","updated_at":"2016-09-16T12:37:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a544f8d6e27963252c4993fd2a0addd854a58e9","assignee":{"login":"cihangir","id":879660,"avatar_url":"https://avatars.githubusercontent.com/u/879660?v=3","gravatar_id":"","url":"https://api.github.com/users/cihangir","html_url":"https://github.com/cihangir","followers_url":"https://api.github.com/users/cihangir/followers","following_url":"https://api.github.com/users/cihangir/following{/other_user}","gists_url":"https://api.github.com/users/cihangir/gists{/gist_id}","starred_url":"https://api.github.com/users/cihangir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cihangir/subscriptions","organizations_url":"https://api.github.com/users/cihangir/orgs","repos_url":"https://api.github.com/users/cihangir/repos","events_url":"https://api.github.com/users/cihangir/events{/privacy}","received_events_url":"https://api.github.com/users/cihangir/received_events","type":"User","site_admin":false},"assignees":[{"login":"cihangir","id":879660,"avatar_url":"https://avatars.githubusercontent.com/u/879660?v=3","gravatar_id":"","url":"https://api.github.com/users/cihangir","html_url":"https://github.com/cihangir","followers_url":"https://api.github.com/users/cihangir/followers","following_url":"https://api.github.com/users/cihangir/following{/other_user}","gists_url":"https://api.github.com/users/cihangir/gists{/gist_id}","starred_url":"https://api.github.com/users/cihangir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cihangir/subscriptions","organizations_url":"https://api.github.com/users/cihangir/orgs","repos_url":"https://api.github.com/users/cihangir/repos","events_url":"https://api.github.com/users/cihangir/events{/privacy}","received_events_url":"https://api.github.com/users/cihangir/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/koding/koding/pulls/9004/commits","review_comments_url":"https://api.github.com/repos/koding/koding/pulls/9004/comments","review_comment_url":"https://api.github.com/repos/koding/koding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koding/koding/issues/9004/comments","statuses_url":"https://api.github.com/repos/koding/koding/statuses/d8a52f8bb7474402701652236ff7329cd2d99c40","head":{"label":"koding:provider","ref":"provider","sha":"d8a52f8bb7474402701652236ff7329cd2d99c40","user":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=3","gravatar_id":"","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"repo":{"id":21317360,"name":"koding","full_name":"koding/koding","owner":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=3","gravatar_id":"","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koding/koding","description":"KODING IS NOW OPEN SOURCE!","fork":false,"url":"https://api.github.com/repos/koding/koding","forks_url":"https://api.github.com/repos/koding/koding/forks","keys_url":"https://api.github.com/repos/koding/koding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koding/koding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koding/koding/teams","hooks_url":"https://api.github.com/repos/koding/koding/hooks","issue_events_url":"https://api.github.com/repos/koding/koding/issues/events{/number}","events_url":"https://api.github.com/repos/koding/koding/events","assignees_url":"https://api.github.com/repos/koding/koding/assignees{/user}","branches_url":"https://api.github.com/repos/koding/koding/branches{/branch}","tags_url":"https://api.github.com/repos/koding/koding/tags","blobs_url":"https://api.github.com/repos/koding/koding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koding/koding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koding/koding/git/refs{/sha}","trees_url":"https://api.github.com/repos/koding/koding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koding/koding/statuses/{sha}","languages_url":"https://api.github.com/repos/koding/koding/languages","stargazers_url":"https://api.github.com/repos/koding/koding/stargazers","contributors_url":"https://api.github.com/repos/koding/koding/contributors","subscribers_url":"https://api.github.com/repos/koding/koding/subscribers","subscription_url":"https://api.github.com/repos/koding/koding/subscription","commits_url":"https://api.github.com/repos/koding/koding/commits{/sha}","git_commits_url":"https://api.github.com/repos/koding/koding/git/commits{/sha}","comments_url":"https://api.github.com/repos/koding/koding/comments{/number}","issue_comment_url":"https://api.github.com/repos/koding/koding/issues/comments{/number}","contents_url":"https://api.github.com/repos/koding/koding/contents/{+path}","compare_url":"https://api.github.com/repos/koding/koding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koding/koding/merges","archive_url":"https://api.github.com/repos/koding/koding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koding/koding/downloads","issues_url":"https://api.github.com/repos/koding/koding/issues{/number}","pulls_url":"https://api.github.com/repos/koding/koding/pulls{/number}","milestones_url":"https://api.github.com/repos/koding/koding/milestones{/number}","notifications_url":"https://api.github.com/repos/koding/koding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koding/koding/labels{/name}","releases_url":"https://api.github.com/repos/koding/koding/releases{/id}","deployments_url":"https://api.github.com/repos/koding/koding/deployments","created_at":"2014-06-29T05:46:24Z","updated_at":"2016-09-16T09:34:36Z","pushed_at":"2016-09-16T12:22:20Z","git_url":"git://github.com/koding/koding.git","ssh_url":"git@github.com:koding/koding.git","clone_url":"https://github.com/koding/koding.git","svn_url":"https://github.com/koding/koding","homepage":"http://venturebeat.com/2016/07/26/koding-gitlab/","size":614618,"stargazers_count":413,"watchers_count":413,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":151,"forks":39,"open_issues":151,"watchers":413,"default_branch":"master"}},"base":{"label":"koding:master","ref":"master","sha":"40571c4799cfef362e438e4ea5eba6e7a8481f9b","user":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=3","gravatar_id":"","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"repo":{"id":21317360,"name":"koding","full_name":"koding/koding","owner":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=3","gravatar_id":"","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koding/koding","description":"KODING IS NOW OPEN SOURCE!","fork":false,"url":"https://api.github.com/repos/koding/koding","forks_url":"https://api.github.com/repos/koding/koding/forks","keys_url":"https://api.github.com/repos/koding/koding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koding/koding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koding/koding/teams","hooks_url":"https://api.github.com/repos/koding/koding/hooks","issue_events_url":"https://api.github.com/repos/koding/koding/issues/events{/number}","events_url":"https://api.github.com/repos/koding/koding/events","assignees_url":"https://api.github.com/repos/koding/koding/assignees{/user}","branches_url":"https://api.github.com/repos/koding/koding/branches{/branch}","tags_url":"https://api.github.com/repos/koding/koding/tags","blobs_url":"https://api.github.com/repos/koding/koding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koding/koding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koding/koding/git/refs{/sha}","trees_url":"https://api.github.com/repos/koding/koding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koding/koding/statuses/{sha}","languages_url":"https://api.github.com/repos/koding/koding/languages","stargazers_url":"https://api.github.com/repos/koding/koding/stargazers","contributors_url":"https://api.github.com/repos/koding/koding/contributors","subscribers_url":"https://api.github.com/repos/koding/koding/subscribers","subscription_url":"https://api.github.com/repos/koding/koding/subscription","commits_url":"https://api.github.com/repos/koding/koding/commits{/sha}","git_commits_url":"https://api.github.com/repos/koding/koding/git/commits{/sha}","comments_url":"https://api.github.com/repos/koding/koding/comments{/number}","issue_comment_url":"https://api.github.com/repos/koding/koding/issues/comments{/number}","contents_url":"https://api.github.com/repos/koding/koding/contents/{+path}","compare_url":"https://api.github.com/repos/koding/koding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koding/koding/merges","archive_url":"https://api.github.com/repos/koding/koding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koding/koding/downloads","issues_url":"https://api.github.com/repos/koding/koding/issues{/number}","pulls_url":"https://api.github.com/repos/koding/koding/pulls{/number}","milestones_url":"https://api.github.com/repos/koding/koding/milestones{/number}","notifications_url":"https://api.github.com/repos/koding/koding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koding/koding/labels{/name}","releases_url":"https://api.github.com/repos/koding/koding/releases{/id}","deployments_url":"https://api.github.com/repos/koding/koding/deployments","created_at":"2014-06-29T05:46:24Z","updated_at":"2016-09-16T09:34:36Z","pushed_at":"2016-09-16T12:22:20Z","git_url":"git://github.com/koding/koding.git","ssh_url":"git@github.com:koding/koding.git","clone_url":"https://github.com/koding/koding.git","svn_url":"https://github.com/koding/koding","homepage":"http://venturebeat.com/2016/07/26/koding-gitlab/","size":614618,"stargazers_count":413,"watchers_count":413,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":151,"forks":39,"open_issues":151,"watchers":413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koding/koding/pulls/9004"},"html":{"href":"https://github.com/koding/koding/pull/9004"},"issue":{"href":"https://api.github.com/repos/koding/koding/issues/9004"},"comments":{"href":"https://api.github.com/repos/koding/koding/issues/9004/comments"},"review_comments":{"href":"https://api.github.com/repos/koding/koding/pulls/9004/comments"},"review_comment":{"href":"https://api.github.com/repos/koding/koding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koding/koding/pulls/9004/commits"},"statuses":{"href":"https://api.github.com/repos/koding/koding/statuses/d8a52f8bb7474402701652236ff7329cd2d99c40"}}}}
{"actor":{"display_login":"cihangir"}}