{"action":"created","issue":{"url":"https://api.github.com/repos/GitTools/GitLink/issues/110","repository_url":"https://api.github.com/repos/GitTools/GitLink","labels_url":"https://api.github.com/repos/GitTools/GitLink/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/GitTools/GitLink/issues/110/comments","events_url":"https://api.github.com/repos/GitTools/GitLink/issues/110/events","html_url":"https://github.com/GitTools/GitLink/pull/110","id":181865711,"number":110,"title":"Simpler, more automatic GitLink","user":{"login":"AArnott","id":3548,"avatar_url":"https://avatars.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-10-09T04:47:31Z","updated_at":"2016-11-15T06:02:31Z","closed_at":"2016-11-14T01:48:48Z","pull_request":{"url":"https://api.github.com/repos/GitTools/GitLink/pulls/110","html_url":"https://github.com/GitTools/GitLink/pull/110","diff_url":"https://github.com/GitTools/GitLink/pull/110.diff","patch_url":"https://github.com/GitTools/GitLink/pull/110.patch"},"body":"This PR is a significant refactoring of both code and how functionality is exposed. This includes:\n1. Installing the GitLink nuget package into a project automatically activates GitLink in that project's build. The README instructions are updated to reflect just how easy it is now compared to before.\n2. gitlink.exe is now focused on the PDB instead of Visual Studio solutions. The only argument required is the PDB file. Everything else is automatic.\n3. pdb file information always has the canonical capitalization expected by the web server.\n4. added support for PDBs that carry SHA1 hashes instead of MD5. I don't know who still uses MD5, but csc.exe seems to always produce SHA1 hashes.\n5. packages.config have been migrated to project.json, resulting in cleaner, simpler build authoring that's easier to manage.\n6. packages and assemblies versioned with git information.\n7. NuGet package builds with the same MSBuild invocation that builds the solution. And if the NuProj extension for VS is installed, it builds within VS as well.\n8. Builds on appveyor. Once this PR is accepted, appveyor should be added to this repo and the README badge can be updated to point to your appveyor build instead of mine.\n9. Print out how many files ended up getting indexed into the PDB, to make noticing issues easier.\n10. Tests are upgraded to NUnit 3, and the NUnit test adapter for VS is added so that tests automatically run in VS even for folks who haven't installed the NUnit extension.\n11. Recognize and report failure even when pdbstr.exe fails with a 0 exit code.\n12. README file is reordered to emphasize benefits and usage instructions over troubleshooting and how it works internally.\n13. GitLink NuPkg is ready for chocolatey. That is, the same package for nuget.org also works on chocolatey directly. \n14. nupkg license points at the exact license that produced the package rather than the tip of 'develop', which may have diverged from what the package was built with. (mostly theoretical, but sound).\n\n**Noteworthy other changes**\n1. The command line tool no longer accepts a 'solution directory', configuration/platform, or anything else MSBuild-related.\n2. The project and NuGet package are currently optimized for _consumption_ rather than extensibility. This is based on the belief that most people who are interested in GitLink want to use it on their projects to benefit their users. If the refactored form of GitLink is not applicable enough for some people's scenarios that they still want a way to consume it programmatically, we can revisit this decision.\n3. The GitLinkTask nuget package is removed. It's all about the GitLink package now.\n4. gitlink.exe doesn't contain all its dependencies as embedded resources. I consider this a feature. It builds with a much more recognizable toolset now, and can be invoked many times in a row with higher performance due to all files being ready for use instead of having to be extracted for every invocation.\n5. Notice the count of added and removed lines in this diff. This makes the project overall significantly smaller, yet more adaptable and easy to use. :)\n\n**Remaining work**\n- [x] Re-enable StyleCop, but using StyleCop.Analyzers instead.\n- [ ] Write new unit tests to cover the new entrypoints. No new test holes were created in this PR, but I think we can improve our test coverage here.\n\nCloses #104 \n"},"comment":{"url":"https://api.github.com/repos/GitTools/GitLink/issues/comments/260555258","html_url":"https://github.com/GitTools/GitLink/pull/110#issuecomment-260555258","issue_url":"https://api.github.com/repos/GitTools/GitLink/issues/110","id":260555258,"user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T06:02:31Z","updated_at":"2016-11-15T06:02:31Z","body":"I did do a bit of review. I have to ask @AArnott - when do you sleep? :D "}}
{"actor":{"display_login":"ferventcoder"}}