{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/9060","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/9060/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9060/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/9060/events","html_url":"https://github.com/xbmc/xbmc/pull/9060","id":131746446,"number":9060,"title":"AESinkAudiotrack: Fixups","user":{"login":"fritsch","id":1089309,"avatar_url":"https://avatars.githubusercontent.com/u/1089309?v=3","gravatar_id":"","url":"https://api.github.com/users/fritsch","html_url":"https://github.com/fritsch","followers_url":"https://api.github.com/users/fritsch/followers","following_url":"https://api.github.com/users/fritsch/following{/other_user}","gists_url":"https://api.github.com/users/fritsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fritsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritsch/subscriptions","organizations_url":"https://api.github.com/users/fritsch/orgs","repos_url":"https://api.github.com/users/fritsch/repos","events_url":"https://api.github.com/users/fritsch/events{/privacy}","received_events_url":"https://api.github.com/users/fritsch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-02-05T20:23:13Z","updated_at":"2016-02-06T08:21:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9060","html_url":"https://github.com/xbmc/xbmc/pull/9060","diff_url":"https://github.com/xbmc/xbmc/pull/9060.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9060.patch"},"body":"- Use a deque for delay, saves us the recration time of the vector while access is still constant O(1)\r\n- When filling the first packages after AddPause, we only slept the pause away, but did not incorporate the blocking behaviour of the sink. This reduces playback start while properly syncing\r\n- getBufferSizeInFrames can be used with v23 to see how many frames or in PT case Buffers AT uses internally\r\n- TrueHD 96 khz does not open - works fine when telling it is 48 khz\r\n- After intensive study of GetPlaybackHeadPosition it seems that it does not block n-1 times and blocks once at the end. This is evil for delay. So help AT sleeping a bit.\r\n\r\nThe latter commit I tried before during development but did not see a real good effect. In combination with the properly computed delay it is okay."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/180718502","html_url":"https://github.com/xbmc/xbmc/pull/9060#issuecomment-180718502","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9060","id":180718502,"user":{"login":"koying","id":164740,"avatar_url":"https://avatars.githubusercontent.com/u/164740?v=3","gravatar_id":"","url":"https://api.github.com/users/koying","html_url":"https://github.com/koying","followers_url":"https://api.github.com/users/koying/followers","following_url":"https://api.github.com/users/koying/following{/other_user}","gists_url":"https://api.github.com/users/koying/gists{/gist_id}","starred_url":"https://api.github.com/users/koying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koying/subscriptions","organizations_url":"https://api.github.com/users/koying/orgs","repos_url":"https://api.github.com/users/koying/repos","events_url":"https://api.github.com/users/koying/events{/privacy}","received_events_url":"https://api.github.com/users/koying/received_events","type":"User","site_admin":false},"created_at":"2016-02-06T08:21:33Z","updated_at":"2016-02-06T08:21:33Z","body":"It's a \"production\" build, so the only confirmation I have is\r\n`09:11:18 T:1406134576   DEBUG: CAESinkAUDIOTRACK::Initialize returned: m_sampleRate 3072000; format:UNKNOWN(65300); min_buffer_size 61440; m_frames 61440; m_frameSize 1; channels: 8; m_audiotrackbuffer_sec(0.640000), m_sink_saplerate(96000)`\r\n\r\nSee m_sink_samplerate"}}