{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/orleans/issues/2534","repository_url":"https://api.github.com/repos/dotnet/orleans","labels_url":"https://api.github.com/repos/dotnet/orleans/issues/2534/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/2534/comments","events_url":"https://api.github.com/repos/dotnet/orleans/issues/2534/events","html_url":"https://github.com/dotnet/orleans/pull/2534","id":196791059,"number":2534,"title":"Removed unused ClientType from GrainServiceConfiguration","user":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars.githubusercontent.com/u/8248806?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"labels":[{"id":197713633,"url":"https://api.github.com/repos/dotnet/orleans/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars.githubusercontent.com/u/203839?v=3","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"assignees":[{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars.githubusercontent.com/u/203839?v=3","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/orleans/milestones/14","html_url":"https://github.com/dotnet/orleans/milestone/14","labels_url":"https://api.github.com/repos/dotnet/orleans/milestones/14/labels","id":2017852,"number":14,"title":"1.4.0","description":"","creator":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars.githubusercontent.com/u/8248806?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":40,"state":"open","created_at":"2016-09-20T23:16:17Z","updated_at":"2016-12-20T21:54:51Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-12-20T21:54:51Z","updated_at":"2016-12-20T22:28:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/2534","html_url":"https://github.com/dotnet/orleans/pull/2534","diff_url":"https://github.com/dotnet/orleans/pull/2534.diff","patch_url":"https://github.com/dotnet/orleans/pull/2534.patch"},"body":"A follow-up to #2459 and #2531. Removed unused ClientType property from GrainServiceConfiguration.\r\n\r\n@jamescarter-le, any objections?"},"comment":{"url":"https://api.github.com/repos/dotnet/orleans/issues/comments/268377824","html_url":"https://github.com/dotnet/orleans/pull/2534#issuecomment-268377824","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/2534","id":268377824,"user":{"login":"jamescarter-le","id":1643692,"avatar_url":"https://avatars.githubusercontent.com/u/1643692?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescarter-le","html_url":"https://github.com/jamescarter-le","followers_url":"https://api.github.com/users/jamescarter-le/followers","following_url":"https://api.github.com/users/jamescarter-le/following{/other_user}","gists_url":"https://api.github.com/users/jamescarter-le/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescarter-le/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescarter-le/subscriptions","organizations_url":"https://api.github.com/users/jamescarter-le/orgs","repos_url":"https://api.github.com/users/jamescarter-le/repos","events_url":"https://api.github.com/users/jamescarter-le/events{/privacy}","received_events_url":"https://api.github.com/users/jamescarter-le/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T22:28:36Z","updated_at":"2016-12-20T22:28:36Z","body":"The intention was someone should be able to have multiple services with\ndifferent names of the same type.\n\nI was not able to finish the implementation in time. I had intended to set\nup the ServiceProvider to register the IGrainServiceClient but at the point\nthe Grain Services are constructed there is no access to register types.\n\nHappy to remove it for now and I can modify it later on, or skip that if\nit's not useful.\n\nOn Tue, 20 Dec 2016, 22:17 Reuben Bond, <notifications@github.com> wrote:\n\n> We should also remove serviceName and replace its usage with ServiceType.\n> It might otherwise give the impression that a consumer can have multiple\n> services with identical types but different names\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/dotnet/orleans/pull/2534#issuecomment-268375363>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/ABkUrHtxwwhqmlxLqfPuShkvqIi6_Ts1ks5rKFPrgaJpZM4LSV4J>\n> .\n>\n"}}
{"actor":{"display_login":"jamescarter-le"}}