{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/4852","repository_url":"https://api.github.com/repos/Automattic/jetpack","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/4852/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/4852/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/4852/events","html_url":"https://github.com/Automattic/jetpack/pull/4852","id":171687013,"number":4852,"title":"Add WPML support to the sitemaps module","user":{"login":"vukvukovich","id":7383476,"avatar_url":"https://avatars.githubusercontent.com/u/7383476?v=3","gravatar_id":"","url":"https://api.github.com/users/vukvukovich","html_url":"https://github.com/vukvukovich","followers_url":"https://api.github.com/users/vukvukovich/followers","following_url":"https://api.github.com/users/vukvukovich/following{/other_user}","gists_url":"https://api.github.com/users/vukvukovich/gists{/gist_id}","starred_url":"https://api.github.com/users/vukvukovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vukvukovich/subscriptions","organizations_url":"https://api.github.com/users/vukvukovich/orgs","repos_url":"https://api.github.com/users/vukvukovich/repos","events_url":"https://api.github.com/users/vukvukovich/events{/privacy}","received_events_url":"https://api.github.com/users/vukvukovich/received_events","type":"User","site_admin":false},"labels":[{"id":306719875,"url":"https://api.github.com/repos/Automattic/jetpack/labels/Sitemaps","name":"Sitemaps","color":"006b75","default":false},{"id":71000503,"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20Needs%20Author%20Reply","name":"[Status] Needs Author Reply","color":"e11d21","default":false},{"id":199076921,"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":70896534,"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"eliorivero","id":1041600,"avatar_url":"https://avatars.githubusercontent.com/u/1041600?v=3","gravatar_id":"","url":"https://api.github.com/users/eliorivero","html_url":"https://github.com/eliorivero","followers_url":"https://api.github.com/users/eliorivero/followers","following_url":"https://api.github.com/users/eliorivero/following{/other_user}","gists_url":"https://api.github.com/users/eliorivero/gists{/gist_id}","starred_url":"https://api.github.com/users/eliorivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliorivero/subscriptions","organizations_url":"https://api.github.com/users/eliorivero/orgs","repos_url":"https://api.github.com/users/eliorivero/repos","events_url":"https://api.github.com/users/eliorivero/events{/privacy}","received_events_url":"https://api.github.com/users/eliorivero/received_events","type":"User","site_admin":false},"assignees":[{"login":"eliorivero","id":1041600,"avatar_url":"https://avatars.githubusercontent.com/u/1041600?v=3","gravatar_id":"","url":"https://api.github.com/users/eliorivero","html_url":"https://github.com/eliorivero","followers_url":"https://api.github.com/users/eliorivero/followers","following_url":"https://api.github.com/users/eliorivero/following{/other_user}","gists_url":"https://api.github.com/users/eliorivero/gists{/gist_id}","starred_url":"https://api.github.com/users/eliorivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliorivero/subscriptions","organizations_url":"https://api.github.com/users/eliorivero/orgs","repos_url":"https://api.github.com/users/eliorivero/repos","events_url":"https://api.github.com/users/eliorivero/events{/privacy}","received_events_url":"https://api.github.com/users/eliorivero/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/67","html_url":"https://github.com/Automattic/jetpack/milestone/67","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/67/labels","id":2163955,"number":67,"title":"4.6","description":"Settings UI ","creator":{"login":"dereksmart","id":7129409,"avatar_url":"https://avatars.githubusercontent.com/u/7129409?v=3","gravatar_id":"","url":"https://api.github.com/users/dereksmart","html_url":"https://github.com/dereksmart","followers_url":"https://api.github.com/users/dereksmart/followers","following_url":"https://api.github.com/users/dereksmart/following{/other_user}","gists_url":"https://api.github.com/users/dereksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/dereksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereksmart/subscriptions","organizations_url":"https://api.github.com/users/dereksmart/orgs","repos_url":"https://api.github.com/users/dereksmart/repos","events_url":"https://api.github.com/users/dereksmart/events{/privacy}","received_events_url":"https://api.github.com/users/dereksmart/received_events","type":"User","site_admin":false},"open_issues":58,"closed_issues":3,"state":"open","created_at":"2016-11-29T15:53:42Z","updated_at":"2016-12-26T12:46:20Z","due_on":"2017-02-08T08:00:00Z","closed_at":null},"comments":10,"created_at":"2016-08-17T15:26:18Z","updated_at":"2016-12-27T12:39:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/4852","html_url":"https://github.com/Automattic/jetpack/pull/4852","diff_url":"https://github.com/Automattic/jetpack/pull/4852.diff","patch_url":"https://github.com/Automattic/jetpack/pull/4852.patch"},"body":"Fixes # .\n#### Changes proposed in this Pull Request:\n\nSitemaps are now cached per language if WPML is active. \nAlso, post permalinks are now generated properly according post language.\n#### Testing instructions:\n1. Install and activate **WP,** **WPML (whole bundle)** and **Jetpack**\n2. Set up few languages, finish WPML configuration & enable Jetpack sitemaps module\n3. Translate \"Hello World\" post to all languages\n4. Scan Jetpack plugin for strings in **WPML > Theme and plugins localization**\n5. Go to **WPML > String translation** and translate strings related to the sitemaps module. (you can find them by visiting _http://example.com/sitemap.xml_ or _http://example.com/news-sitemap.xml_)\n6. Generate sitemaps for all languages by visiting _http://example.com/sitemap.xml_, _http://example.com/de/sitemap.xml_, etc...\n\n**\\- All strings should appear translated.** \n**\\- All posts and its translations should be generated with proper permalinks.**\n\n![screen shot 2016-08-17 at 5 20 08 pm](https://cloud.githubusercontent.com/assets/7383476/17742096/f03ecb7e-649e-11e6-8c21-2c15e78e0451.png)\n![screen shot 2016-08-17 at 5 20 21 pm](https://cloud.githubusercontent.com/assets/7383476/17742097/f040fa34-649e-11e6-87b1-f8b861a80e63.png)\n![screen shot 2016-08-17 at 5 20 32 pm](https://cloud.githubusercontent.com/assets/7383476/17742095/f01596e6-649e-11e6-9308-21629507b794.png)\n\n---\n- [ ] Make sure your changes respect [WordPress' coding standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/).\n- [ ] Did you make changes, or create a **new .js file**? If [Gulp](http://gulpjs.com/) is installed on your testing environment, run `gulp js:hint` before to commit your changes. It will allow you to [detect errors in Javascript files](http://jshint.com/about/).\n- [ ] Did you create a **new action or filter**? [Add inline documentation](https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#4-hooks-actions-and-filters) to help others understand how to use the action or the filter.\n- [ ] Create **[unit tests](https://github.com/Automattic/jetpack/tree/master/tests)** if you can. If you're not familiar with Unit Testing, you can check [this tutorial](https://pippinsplugins.com/series/unit-tests-wordpress-plugins/).\n"},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/269320849","html_url":"https://github.com/Automattic/jetpack/pull/4852#issuecomment-269320849","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/4852","id":269320849,"user":{"login":"vukvukovich","id":7383476,"avatar_url":"https://avatars.githubusercontent.com/u/7383476?v=3","gravatar_id":"","url":"https://api.github.com/users/vukvukovich","html_url":"https://github.com/vukvukovich","followers_url":"https://api.github.com/users/vukvukovich/followers","following_url":"https://api.github.com/users/vukvukovich/following{/other_user}","gists_url":"https://api.github.com/users/vukvukovich/gists{/gist_id}","starred_url":"https://api.github.com/users/vukvukovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vukvukovich/subscriptions","organizations_url":"https://api.github.com/users/vukvukovich/orgs","repos_url":"https://api.github.com/users/vukvukovich/repos","events_url":"https://api.github.com/users/vukvukovich/events{/privacy}","received_events_url":"https://api.github.com/users/vukvukovich/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T12:39:41Z","updated_at":"2016-12-27T12:39:41Z","body":"@jeherve Any update on this proposed fix? Thanks!"}}
{"actor":{"display_login":"vukvukovich"}}