{"action":"created","issue":{"url":"https://api.github.com/repos/Instagram/IGListKit/issues/270","repository_url":"https://api.github.com/repos/Instagram/IGListKit","labels_url":"https://api.github.com/repos/Instagram/IGListKit/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/Instagram/IGListKit/issues/270/comments","events_url":"https://api.github.com/repos/Instagram/IGListKit/issues/270/events","html_url":"https://github.com/Instagram/IGListKit/issues/270","id":192619853,"number":270,"title":"macOS support follow-up work from #235","user":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"labels":[{"id":438144353,"url":"https://api.github.com/repos/Instagram/IGListKit/labels/enhancement","name":"enhancement","color":"3897F0","default":true}],"state":"open","locked":false,"assignee":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Instagram/IGListKit/milestones/2","html_url":"https://github.com/Instagram/IGListKit/milestones/2.1.0","labels_url":"https://api.github.com/repos/Instagram/IGListKit/milestones/2/labels","id":2166819,"number":2,"title":"2.1.0","description":"macOS support","creator":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-11-30T16:54:10Z","updated_at":"2016-11-30T16:54:36Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-11-30T16:54:23Z","updated_at":"2016-11-30T16:59:13Z","closed_at":null,"body":"We added basic macOS support in #235.\r\n\r\nOnce it's merged, we need to do a few more things:\r\n\r\n- [ ] Add a test target, `IGListKit-macOSTests` and existing tests that apply\r\n- [ ] Update `.travis.yml` to build and run the macOS targets on travis-ci\r\n- [ ] Add an example project in `Examples/Examples-macOS/`\r\n- [ ] Create a macro for the following imports, so we don't have to copy-paste:\r\n\r\n```objc\r\n#import <TargetConditionals.h>\r\n\r\n#if TARGET_OS_EMBEDDED || TARGET_OS_SIMULATOR\r\n    #import <UIKit/UIKit.h>\r\n#else\r\n    #import <Cocoa/Cocoa.h>\r\n#endif\r\n```\r\n\r\n- [ ] The `.podspec` currently lists files manually which is cumbersome. Let's move common files to `Source/Common/` so that `spec.osx.source_files` can become: `'Source/Common/*.{h,m,mm}'`. We'll also need to do the same for `Source/Internal/Common/`. "},"comment":{"url":"https://api.github.com/repos/Instagram/IGListKit/issues/comments/263929694","html_url":"https://github.com/Instagram/IGListKit/issues/270#issuecomment-263929694","issue_url":"https://api.github.com/repos/Instagram/IGListKit/issues/270","id":263929694,"user":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T16:59:13Z","updated_at":"2016-11-30T16:59:13Z","body":"Thanks @insidegui !\r\n\r\nBecause of how our syncing system works, we'll have to setup the basic project internally and push it. After that, we can have contributors help."}}
{"actor":{"display_login":"jessesquires"}}