{"action":"created","comment":{"url":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/comments/84552355","pull_request_review_id":5327079,"id":84552355,"diff_hunk":"@@ -26,18 +26,44 @@ const (\n // the slave knows from which string permutation to start and at which string\n // permutation to stop.\n type Task struct {\n-\tID        int\n-\tJobID     int\n-\tAlgorithm string\n-\tSalt      string\n-\tDigest    string\n-\tCharSet   string\n-\tLength    int\n-\tStart     string\n-\tEnd       string\n+\tJob","path":"lib/common.go","position":24,"original_position":13,"commit_id":"c49085d51c4ba88b8118beac2b226611a0fc52b8","original_commit_id":"43d5957dd13a2dd76860af7c7ae8fa8249089c3d","user":{"login":"kc1212","id":1093806,"avatar_url":"https://avatars.githubusercontent.com/u/1093806?v=3","gravatar_id":"","url":"https://api.github.com/users/kc1212","html_url":"https://github.com/kc1212","followers_url":"https://api.github.com/users/kc1212/followers","following_url":"https://api.github.com/users/kc1212/following{/other_user}","gists_url":"https://api.github.com/users/kc1212/gists{/gist_id}","starred_url":"https://api.github.com/users/kc1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc1212/subscriptions","organizations_url":"https://api.github.com/users/kc1212/orgs","repos_url":"https://api.github.com/users/kc1212/repos","events_url":"https://api.github.com/users/kc1212/events{/privacy}","received_events_url":"https://api.github.com/users/kc1212/received_events","type":"User","site_admin":false},"body":"I added a `JobID`","created_at":"2016-10-21T22:05:30Z","updated_at":"2016-10-21T22:05:31Z","html_url":"https://github.com/aaronang/cong-the-ripper/pull/16#discussion_r84552355","pull_request_url":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/comments/84552355"},"html":{"href":"https://github.com/aaronang/cong-the-ripper/pull/16#discussion_r84552355"},"pull_request":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/16","id":90388759,"html_url":"https://github.com/aaronang/cong-the-ripper/pull/16","diff_url":"https://github.com/aaronang/cong-the-ripper/pull/16.diff","patch_url":"https://github.com/aaronang/cong-the-ripper/pull/16.patch","issue_url":"https://api.github.com/repos/aaronang/cong-the-ripper/issues/16","number":16,"state":"open","locked":false,"title":"Feature split job","user":{"login":"kc1212","id":1093806,"avatar_url":"https://avatars.githubusercontent.com/u/1093806?v=3","gravatar_id":"","url":"https://api.github.com/users/kc1212","html_url":"https://github.com/kc1212","followers_url":"https://api.github.com/users/kc1212/followers","following_url":"https://api.github.com/users/kc1212/following{/other_user}","gists_url":"https://api.github.com/users/kc1212/gists{/gist_id}","starred_url":"https://api.github.com/users/kc1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc1212/subscriptions","organizations_url":"https://api.github.com/users/kc1212/orgs","repos_url":"https://api.github.com/users/kc1212/repos","events_url":"https://api.github.com/users/kc1212/events{/privacy}","received_events_url":"https://api.github.com/users/kc1212/received_events","type":"User","site_admin":false},"body":"The basic idea is: first we convert the binary string into a number that has a base with respect to the character set. Then we perform arithmetic on that number to do the chunking. \r\n\r\nI didn't use the method here https://github.com/dieyushi/golang-brutedict/blob/master/brutedict.go (recursively call `bd.list`) because that would require us to iterate a lot more iterations, e.g. 36^6 for 6 character alpha numerical passwords. But this technique is useful in the slave.\r\n\r\nI also changed the types to match what is used in https://godoc.org/golang.org/x/crypto/pbkdf2\r\n\r\nfixes #5 ","created_at":"2016-10-21T14:01:49Z","updated_at":"2016-10-21T22:05:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9c981c699db5ca9c28a185dfbd1bb00f22ab625","assignee":{"login":"victor-li","id":2921756,"avatar_url":"https://avatars.githubusercontent.com/u/2921756?v=3","gravatar_id":"","url":"https://api.github.com/users/victor-li","html_url":"https://github.com/victor-li","followers_url":"https://api.github.com/users/victor-li/followers","following_url":"https://api.github.com/users/victor-li/following{/other_user}","gists_url":"https://api.github.com/users/victor-li/gists{/gist_id}","starred_url":"https://api.github.com/users/victor-li/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victor-li/subscriptions","organizations_url":"https://api.github.com/users/victor-li/orgs","repos_url":"https://api.github.com/users/victor-li/repos","events_url":"https://api.github.com/users/victor-li/events{/privacy}","received_events_url":"https://api.github.com/users/victor-li/received_events","type":"User","site_admin":false},"assignees":[{"login":"victor-li","id":2921756,"avatar_url":"https://avatars.githubusercontent.com/u/2921756?v=3","gravatar_id":"","url":"https://api.github.com/users/victor-li","html_url":"https://github.com/victor-li","followers_url":"https://api.github.com/users/victor-li/followers","following_url":"https://api.github.com/users/victor-li/following{/other_user}","gists_url":"https://api.github.com/users/victor-li/gists{/gist_id}","starred_url":"https://api.github.com/users/victor-li/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victor-li/subscriptions","organizations_url":"https://api.github.com/users/victor-li/orgs","repos_url":"https://api.github.com/users/victor-li/repos","events_url":"https://api.github.com/users/victor-li/events{/privacy}","received_events_url":"https://api.github.com/users/victor-li/received_events","type":"User","site_admin":false},{"login":"aaronang","id":7579804,"avatar_url":"https://avatars.githubusercontent.com/u/7579804?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronang","html_url":"https://github.com/aaronang","followers_url":"https://api.github.com/users/aaronang/followers","following_url":"https://api.github.com/users/aaronang/following{/other_user}","gists_url":"https://api.github.com/users/aaronang/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronang/subscriptions","organizations_url":"https://api.github.com/users/aaronang/orgs","repos_url":"https://api.github.com/users/aaronang/repos","events_url":"https://api.github.com/users/aaronang/events{/privacy}","received_events_url":"https://api.github.com/users/aaronang/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/aaronang/cong-the-ripper/milestones/1","html_url":"https://github.com/aaronang/cong-the-ripper/milestones/System%20Implementation","labels_url":"https://api.github.com/repos/aaronang/cong-the-ripper/milestones/1/labels","id":2081030,"number":1,"title":"System Implementation","description":"","creator":{"login":"aaronang","id":7579804,"avatar_url":"https://avatars.githubusercontent.com/u/7579804?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronang","html_url":"https://github.com/aaronang","followers_url":"https://api.github.com/users/aaronang/followers","following_url":"https://api.github.com/users/aaronang/following{/other_user}","gists_url":"https://api.github.com/users/aaronang/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronang/subscriptions","organizations_url":"https://api.github.com/users/aaronang/orgs","repos_url":"https://api.github.com/users/aaronang/repos","events_url":"https://api.github.com/users/aaronang/events{/privacy}","received_events_url":"https://api.github.com/users/aaronang/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":7,"state":"open","created_at":"2016-10-19T21:03:52Z","updated_at":"2016-10-21T14:01:49Z","due_on":"2016-10-28T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/16/commits","review_comments_url":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/16/comments","review_comment_url":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aaronang/cong-the-ripper/issues/16/comments","statuses_url":"https://api.github.com/repos/aaronang/cong-the-ripper/statuses/c49085d51c4ba88b8118beac2b226611a0fc52b8","head":{"label":"aaronang:feature/split-job","ref":"feature/split-job","sha":"c49085d51c4ba88b8118beac2b226611a0fc52b8","user":{"login":"aaronang","id":7579804,"avatar_url":"https://avatars.githubusercontent.com/u/7579804?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronang","html_url":"https://github.com/aaronang","followers_url":"https://api.github.com/users/aaronang/followers","following_url":"https://api.github.com/users/aaronang/following{/other_user}","gists_url":"https://api.github.com/users/aaronang/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronang/subscriptions","organizations_url":"https://api.github.com/users/aaronang/orgs","repos_url":"https://api.github.com/users/aaronang/repos","events_url":"https://api.github.com/users/aaronang/events{/privacy}","received_events_url":"https://api.github.com/users/aaronang/received_events","type":"User","site_admin":false},"repo":{"id":70912538,"name":"cong-the-ripper","full_name":"aaronang/cong-the-ripper","owner":{"login":"aaronang","id":7579804,"avatar_url":"https://avatars.githubusercontent.com/u/7579804?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronang","html_url":"https://github.com/aaronang","followers_url":"https://api.github.com/users/aaronang/followers","following_url":"https://api.github.com/users/aaronang/following{/other_user}","gists_url":"https://api.github.com/users/aaronang/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronang/subscriptions","organizations_url":"https://api.github.com/users/aaronang/orgs","repos_url":"https://api.github.com/users/aaronang/repos","events_url":"https://api.github.com/users/aaronang/events{/privacy}","received_events_url":"https://api.github.com/users/aaronang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaronang/cong-the-ripper","description":"Cong the Ripper is a *state-of-the-art* cloud-based password cracker","fork":false,"url":"https://api.github.com/repos/aaronang/cong-the-ripper","forks_url":"https://api.github.com/repos/aaronang/cong-the-ripper/forks","keys_url":"https://api.github.com/repos/aaronang/cong-the-ripper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronang/cong-the-ripper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronang/cong-the-ripper/teams","hooks_url":"https://api.github.com/repos/aaronang/cong-the-ripper/hooks","issue_events_url":"https://api.github.com/repos/aaronang/cong-the-ripper/issues/events{/number}","events_url":"https://api.github.com/repos/aaronang/cong-the-ripper/events","assignees_url":"https://api.github.com/repos/aaronang/cong-the-ripper/assignees{/user}","branches_url":"https://api.github.com/repos/aaronang/cong-the-ripper/branches{/branch}","tags_url":"https://api.github.com/repos/aaronang/cong-the-ripper/tags","blobs_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronang/cong-the-ripper/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronang/cong-the-ripper/languages","stargazers_url":"https://api.github.com/repos/aaronang/cong-the-ripper/stargazers","contributors_url":"https://api.github.com/repos/aaronang/cong-the-ripper/contributors","subscribers_url":"https://api.github.com/repos/aaronang/cong-the-ripper/subscribers","subscription_url":"https://api.github.com/repos/aaronang/cong-the-ripper/subscription","commits_url":"https://api.github.com/repos/aaronang/cong-the-ripper/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronang/cong-the-ripper/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronang/cong-the-ripper/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronang/cong-the-ripper/contents/{+path}","compare_url":"https://api.github.com/repos/aaronang/cong-the-ripper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronang/cong-the-ripper/merges","archive_url":"https://api.github.com/repos/aaronang/cong-the-ripper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronang/cong-the-ripper/downloads","issues_url":"https://api.github.com/repos/aaronang/cong-the-ripper/issues{/number}","pulls_url":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronang/cong-the-ripper/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronang/cong-the-ripper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronang/cong-the-ripper/labels{/name}","releases_url":"https://api.github.com/repos/aaronang/cong-the-ripper/releases{/id}","deployments_url":"https://api.github.com/repos/aaronang/cong-the-ripper/deployments","created_at":"2016-10-14T13:26:11Z","updated_at":"2016-10-19T21:13:21Z","pushed_at":"2016-10-21T22:01:33Z","git_url":"git://github.com/aaronang/cong-the-ripper.git","ssh_url":"git@github.com:aaronang/cong-the-ripper.git","clone_url":"https://github.com/aaronang/cong-the-ripper.git","svn_url":"https://github.com/aaronang/cong-the-ripper","homepage":"","size":30,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"aaronang:master","ref":"master","sha":"25de9954485ab38a464388e6890989f38101b987","user":{"login":"aaronang","id":7579804,"avatar_url":"https://avatars.githubusercontent.com/u/7579804?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronang","html_url":"https://github.com/aaronang","followers_url":"https://api.github.com/users/aaronang/followers","following_url":"https://api.github.com/users/aaronang/following{/other_user}","gists_url":"https://api.github.com/users/aaronang/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronang/subscriptions","organizations_url":"https://api.github.com/users/aaronang/orgs","repos_url":"https://api.github.com/users/aaronang/repos","events_url":"https://api.github.com/users/aaronang/events{/privacy}","received_events_url":"https://api.github.com/users/aaronang/received_events","type":"User","site_admin":false},"repo":{"id":70912538,"name":"cong-the-ripper","full_name":"aaronang/cong-the-ripper","owner":{"login":"aaronang","id":7579804,"avatar_url":"https://avatars.githubusercontent.com/u/7579804?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronang","html_url":"https://github.com/aaronang","followers_url":"https://api.github.com/users/aaronang/followers","following_url":"https://api.github.com/users/aaronang/following{/other_user}","gists_url":"https://api.github.com/users/aaronang/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronang/subscriptions","organizations_url":"https://api.github.com/users/aaronang/orgs","repos_url":"https://api.github.com/users/aaronang/repos","events_url":"https://api.github.com/users/aaronang/events{/privacy}","received_events_url":"https://api.github.com/users/aaronang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaronang/cong-the-ripper","description":"Cong the Ripper is a *state-of-the-art* cloud-based password cracker","fork":false,"url":"https://api.github.com/repos/aaronang/cong-the-ripper","forks_url":"https://api.github.com/repos/aaronang/cong-the-ripper/forks","keys_url":"https://api.github.com/repos/aaronang/cong-the-ripper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronang/cong-the-ripper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronang/cong-the-ripper/teams","hooks_url":"https://api.github.com/repos/aaronang/cong-the-ripper/hooks","issue_events_url":"https://api.github.com/repos/aaronang/cong-the-ripper/issues/events{/number}","events_url":"https://api.github.com/repos/aaronang/cong-the-ripper/events","assignees_url":"https://api.github.com/repos/aaronang/cong-the-ripper/assignees{/user}","branches_url":"https://api.github.com/repos/aaronang/cong-the-ripper/branches{/branch}","tags_url":"https://api.github.com/repos/aaronang/cong-the-ripper/tags","blobs_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronang/cong-the-ripper/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronang/cong-the-ripper/languages","stargazers_url":"https://api.github.com/repos/aaronang/cong-the-ripper/stargazers","contributors_url":"https://api.github.com/repos/aaronang/cong-the-ripper/contributors","subscribers_url":"https://api.github.com/repos/aaronang/cong-the-ripper/subscribers","subscription_url":"https://api.github.com/repos/aaronang/cong-the-ripper/subscription","commits_url":"https://api.github.com/repos/aaronang/cong-the-ripper/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronang/cong-the-ripper/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronang/cong-the-ripper/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronang/cong-the-ripper/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronang/cong-the-ripper/contents/{+path}","compare_url":"https://api.github.com/repos/aaronang/cong-the-ripper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronang/cong-the-ripper/merges","archive_url":"https://api.github.com/repos/aaronang/cong-the-ripper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronang/cong-the-ripper/downloads","issues_url":"https://api.github.com/repos/aaronang/cong-the-ripper/issues{/number}","pulls_url":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronang/cong-the-ripper/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronang/cong-the-ripper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronang/cong-the-ripper/labels{/name}","releases_url":"https://api.github.com/repos/aaronang/cong-the-ripper/releases{/id}","deployments_url":"https://api.github.com/repos/aaronang/cong-the-ripper/deployments","created_at":"2016-10-14T13:26:11Z","updated_at":"2016-10-19T21:13:21Z","pushed_at":"2016-10-21T22:01:33Z","git_url":"git://github.com/aaronang/cong-the-ripper.git","ssh_url":"git@github.com:aaronang/cong-the-ripper.git","clone_url":"https://github.com/aaronang/cong-the-ripper.git","svn_url":"https://github.com/aaronang/cong-the-ripper","homepage":"","size":30,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/16"},"html":{"href":"https://github.com/aaronang/cong-the-ripper/pull/16"},"issue":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/issues/16"},"comments":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/aaronang/cong-the-ripper/statuses/c49085d51c4ba88b8118beac2b226611a0fc52b8"}}}}
{"actor":{"display_login":"kc1212"}}