{"action":"created","issue":{"url":"https://api.github.com/repos/cweagans/composer-patches/issues/40","repository_url":"https://api.github.com/repos/cweagans/composer-patches","labels_url":"https://api.github.com/repos/cweagans/composer-patches/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/cweagans/composer-patches/issues/40/comments","events_url":"https://api.github.com/repos/cweagans/composer-patches/issues/40/events","html_url":"https://github.com/cweagans/composer-patches/issues/40","id":148006408,"number":40,"title":"Fail when patches cannot be applied","user":{"login":"bartfeenstra","id":376735,"avatar_url":"https://avatars.githubusercontent.com/u/376735?v=3","gravatar_id":"","url":"https://api.github.com/users/bartfeenstra","html_url":"https://github.com/bartfeenstra","followers_url":"https://api.github.com/users/bartfeenstra/followers","following_url":"https://api.github.com/users/bartfeenstra/following{/other_user}","gists_url":"https://api.github.com/users/bartfeenstra/gists{/gist_id}","starred_url":"https://api.github.com/users/bartfeenstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartfeenstra/subscriptions","organizations_url":"https://api.github.com/users/bartfeenstra/orgs","repos_url":"https://api.github.com/users/bartfeenstra/repos","events_url":"https://api.github.com/users/bartfeenstra/events{/privacy}","received_events_url":"https://api.github.com/users/bartfeenstra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-13T09:47:35Z","updated_at":"2016-04-13T15:18:50Z","closed_at":null,"body":"When a patch cannot be applied, the build simply continues with a warning being output. On automated systems, this is hard to catch. This is a critical issue, as these patches can be used to fix security problems, for instance. Instead, in case of failures, the process should exit with a non-zero error code."},"comment":{"url":"https://api.github.com/repos/cweagans/composer-patches/issues/comments/209505126","html_url":"https://github.com/cweagans/composer-patches/issues/40#issuecomment-209505126","issue_url":"https://api.github.com/repos/cweagans/composer-patches/issues/40","id":209505126,"user":{"login":"bartfeenstra","id":376735,"avatar_url":"https://avatars.githubusercontent.com/u/376735?v=3","gravatar_id":"","url":"https://api.github.com/users/bartfeenstra","html_url":"https://github.com/bartfeenstra","followers_url":"https://api.github.com/users/bartfeenstra/followers","following_url":"https://api.github.com/users/bartfeenstra/following{/other_user}","gists_url":"https://api.github.com/users/bartfeenstra/gists{/gist_id}","starred_url":"https://api.github.com/users/bartfeenstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartfeenstra/subscriptions","organizations_url":"https://api.github.com/users/bartfeenstra/orgs","repos_url":"https://api.github.com/users/bartfeenstra/repos","events_url":"https://api.github.com/users/bartfeenstra/events{/privacy}","received_events_url":"https://api.github.com/users/bartfeenstra/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T15:18:50Z","updated_at":"2016-04-13T15:18:50Z","body":"I did not say security releases; I gave examples of problems the current behavior can cause, including those that compromise security.\r\n\r\nAdding additional messages will still not solve this problem for automated builds. If a CLI tool does not exit with a non-zero code on failure, it basically fails to tell its executing shell about the failure, which means any non-human observer (build tools) will not be able to take the necessary precautions to prevent worse failures, such as deploying a broken system to production."}}