{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/49170543","id":49170543,"diff_hunk":"@@ -16,17 +21,58 @@ class FeaturesFilter\n public:\n   FeaturesFilter();\n \n-  FeaturesFilter(unique_ptr<coding::CompressedBitVector> filter, uint32_t threshold);\n+  FeaturesFilter(coding::CompressedBitVector const & filter, uint32_t threshold);\n+\n+  inline void SetFilter(coding::CompressedBitVector const * filter) { m_filter = filter; }\n \n-  inline void SetFilter(unique_ptr<coding::CompressedBitVector> filter) { m_filter = move(filter); }\n   inline void SetThreshold(uint32_t threshold) { m_threshold = threshold; }\n \n   bool NeedToFilter(coding::CompressedBitVector const & features) const;\n   unique_ptr<coding::CompressedBitVector> Filter(coding::CompressedBitVector const & cbv) const;\n \n private:\n-  unique_ptr<coding::CompressedBitVector> m_filter;\n+  coding::CompressedBitVector const * m_filter;\n   uint32_t m_threshold;\n };\n+\n+\n+/// CompressedBitVector pointer class that incapsulates\n+/// binary operators logic and takes ownership if needed.\n+class CBVPtr","path":"search/v2/features_filter.hpp","position":40,"original_position":40,"commit_id":"ee14d22863ea743b746a7a610bea802aa98de3ea","original_commit_id":"ee14d22863ea743b746a7a610bea802aa98de3ea","user":{"login":"ygorshenin","id":454567,"avatar_url":"https://avatars.githubusercontent.com/u/454567?v=3","gravatar_id":"","url":"https://api.github.com/users/ygorshenin","html_url":"https://github.com/ygorshenin","followers_url":"https://api.github.com/users/ygorshenin/followers","following_url":"https://api.github.com/users/ygorshenin/following{/other_user}","gists_url":"https://api.github.com/users/ygorshenin/gists{/gist_id}","starred_url":"https://api.github.com/users/ygorshenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ygorshenin/subscriptions","organizations_url":"https://api.github.com/users/ygorshenin/orgs","repos_url":"https://api.github.com/users/ygorshenin/repos","events_url":"https://api.github.com/users/ygorshenin/events{/privacy}","received_events_url":"https://api.github.com/users/ygorshenin/received_events","type":"User","site_admin":false},"body":"In any case, have you considered to use shared_ptr instead of new custom smart pointer? They have overhead on atomics (~100ns on modern CPUs), but do not require new code.","created_at":"2016-01-08T09:27:34Z","updated_at":"2016-01-08T09:27:34Z","html_url":"https://github.com/mapsme/omim/pull/1283#discussion_r49170543","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/1283","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/49170543"},"html":{"href":"https://github.com/mapsme/omim/pull/1283#discussion_r49170543"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/1283"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/1283","id":55360756,"html_url":"https://github.com/mapsme/omim/pull/1283","diff_url":"https://github.com/mapsme/omim/pull/1283.diff","patch_url":"https://github.com/mapsme/omim/pull/1283.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/1283","number":1283,"state":"open","locked":false,"title":"[DO NOT MERGE] Basic CBV cache implementation for many search rects.","user":{"login":"vng","id":175612,"avatar_url":"https://avatars.githubusercontent.com/u/175612?v=3","gravatar_id":"","url":"https://api.github.com/users/vng","html_url":"https://github.com/vng","followers_url":"https://api.github.com/users/vng/followers","following_url":"https://api.github.com/users/vng/following{/other_user}","gists_url":"https://api.github.com/users/vng/gists{/gist_id}","starred_url":"https://api.github.com/users/vng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vng/subscriptions","organizations_url":"https://api.github.com/users/vng/orgs","repos_url":"https://api.github.com/users/vng/repos","events_url":"https://api.github.com/users/vng/events{/privacy}","received_events_url":"https://api.github.com/users/vng/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-07T16:50:10Z","updated_at":"2016-01-08T09:27:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dbd252b8f46f63d7e1261a12ebf3ab9aba6b1ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/1283/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/1283/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/1283/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/ee14d22863ea743b746a7a610bea802aa98de3ea","head":{"label":"vng:rects-cache","ref":"rects-cache","sha":"ee14d22863ea743b746a7a610bea802aa98de3ea","user":{"login":"vng","id":175612,"avatar_url":"https://avatars.githubusercontent.com/u/175612?v=3","gravatar_id":"","url":"https://api.github.com/users/vng","html_url":"https://github.com/vng","followers_url":"https://api.github.com/users/vng/followers","following_url":"https://api.github.com/users/vng/following{/other_user}","gists_url":"https://api.github.com/users/vng/gists{/gist_id}","starred_url":"https://api.github.com/users/vng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vng/subscriptions","organizations_url":"https://api.github.com/users/vng/orgs","repos_url":"https://api.github.com/users/vng/repos","events_url":"https://api.github.com/users/vng/events{/privacy}","received_events_url":"https://api.github.com/users/vng/received_events","type":"User","site_admin":false},"repo":{"id":43431189,"name":"omim","full_name":"vng/omim","owner":{"login":"vng","id":175612,"avatar_url":"https://avatars.githubusercontent.com/u/175612?v=3","gravatar_id":"","url":"https://api.github.com/users/vng","html_url":"https://github.com/vng","followers_url":"https://api.github.com/users/vng/followers","following_url":"https://api.github.com/users/vng/following{/other_user}","gists_url":"https://api.github.com/users/vng/gists{/gist_id}","starred_url":"https://api.github.com/users/vng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vng/subscriptions","organizations_url":"https://api.github.com/users/vng/orgs","repos_url":"https://api.github.com/users/vng/repos","events_url":"https://api.github.com/users/vng/events{/privacy}","received_events_url":"https://api.github.com/users/vng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vng/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/vng/omim","forks_url":"https://api.github.com/repos/vng/omim/forks","keys_url":"https://api.github.com/repos/vng/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vng/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vng/omim/teams","hooks_url":"https://api.github.com/repos/vng/omim/hooks","issue_events_url":"https://api.github.com/repos/vng/omim/issues/events{/number}","events_url":"https://api.github.com/repos/vng/omim/events","assignees_url":"https://api.github.com/repos/vng/omim/assignees{/user}","branches_url":"https://api.github.com/repos/vng/omim/branches{/branch}","tags_url":"https://api.github.com/repos/vng/omim/tags","blobs_url":"https://api.github.com/repos/vng/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vng/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vng/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/vng/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vng/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/vng/omim/languages","stargazers_url":"https://api.github.com/repos/vng/omim/stargazers","contributors_url":"https://api.github.com/repos/vng/omim/contributors","subscribers_url":"https://api.github.com/repos/vng/omim/subscribers","subscription_url":"https://api.github.com/repos/vng/omim/subscription","commits_url":"https://api.github.com/repos/vng/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/vng/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/vng/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/vng/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/vng/omim/contents/{+path}","compare_url":"https://api.github.com/repos/vng/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vng/omim/merges","archive_url":"https://api.github.com/repos/vng/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vng/omim/downloads","issues_url":"https://api.github.com/repos/vng/omim/issues{/number}","pulls_url":"https://api.github.com/repos/vng/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/vng/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/vng/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vng/omim/labels{/name}","releases_url":"https://api.github.com/repos/vng/omim/releases{/id}","created_at":"2015-09-30T12:19:26Z","updated_at":"2015-09-30T12:21:35Z","pushed_at":"2016-01-07T18:20:44Z","git_url":"git://github.com/vng/omim.git","ssh_url":"git@github.com:vng/omim.git","clone_url":"https://github.com/vng/omim.git","svn_url":"https://github.com/vng/omim","homepage":null,"size":1953708,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:new-search","ref":"new-search","sha":"1bdc35582c65e4a2e5d5b95cb4e949ff8139670a","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","created_at":"2015-09-20T02:57:13Z","updated_at":"2016-01-07T06:11:16Z","pushed_at":"2016-01-08T05:37:17Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":1996153,"stargazers_count":1567,"watchers_count":1567,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":106,"forks":202,"open_issues":106,"watchers":1567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/1283"},"html":{"href":"https://github.com/mapsme/omim/pull/1283"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/1283"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/1283/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/1283/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/1283/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/ee14d22863ea743b746a7a610bea802aa98de3ea"}}}}