{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/builder/pulls/comments/78960419","id":78960419,"diff_hunk":"@@ -1,15 +1,15 @@\n #!/bin/bash\n set -e\n-module=''\n-if [ ! -z \"$@\" ]; then\n-    module=\".$@\"\n+modules='tests'\n+if [ ! -z \"$*\" ]; then\n+    modules=\"$*\"\n fi\n \n export PYTHONPATH=\"src\"\n-green --run-coverage tests\"$module\"\n+green --run-coverage $modules\n \n # only report coverage if we're running a complete set of tests\n-if [ -z \"$module\" ]; then\n+if [ \"tests integrations_tests\" = \"$modules\" ]; then","path":".run-tests.sh","position":17,"original_position":17,"commit_id":"90d047f6bfa601cefdd7d67b6496119df538202a","original_commit_id":"90d047f6bfa601cefdd7d67b6496119df538202a","user":{"login":"lsh-0","id":2142748,"avatar_url":"https://avatars.githubusercontent.com/u/2142748?v=3","gravatar_id":"","url":"https://api.github.com/users/lsh-0","html_url":"https://github.com/lsh-0","followers_url":"https://api.github.com/users/lsh-0/followers","following_url":"https://api.github.com/users/lsh-0/following{/other_user}","gists_url":"https://api.github.com/users/lsh-0/gists{/gist_id}","starred_url":"https://api.github.com/users/lsh-0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsh-0/subscriptions","organizations_url":"https://api.github.com/users/lsh-0/orgs","repos_url":"https://api.github.com/users/lsh-0/repos","events_url":"https://api.github.com/users/lsh-0/events{/privacy}","received_events_url":"https://api.github.com/users/lsh-0/received_events","type":"User","site_admin":false},"body":"not sure if this line is behaving as expected, but it's not a deal-breaking to merging.","created_at":"2016-09-15T13:17:55Z","updated_at":"2016-09-15T13:17:55Z","html_url":"https://github.com/elifesciences/builder/pull/49#discussion_r78960419","pull_request_url":"https://api.github.com/repos/elifesciences/builder/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/comments/78960419"},"html":{"href":"https://github.com/elifesciences/builder/pull/49#discussion_r78960419"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/elifesciences/builder/pulls/49","id":84865560,"html_url":"https://github.com/elifesciences/builder/pull/49","diff_url":"https://github.com/elifesciences/builder/pull/49.diff","patch_url":"https://github.com/elifesciences/builder/pull/49.patch","issue_url":"https://api.github.com/repos/elifesciences/builder/issues/49","number":49,"state":"open","locked":false,"title":"Clusters of ec2 instances","user":{"login":"giorgiosironi","id":160299,"avatar_url":"https://avatars.githubusercontent.com/u/160299?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"Tentative specification:\r\n- we want multiple nodes serving a project, e.g. `journal` will need to scale out and balance traffic between the instances.\r\n- All these nodes should be identical in software, code version and configuration.\r\n- Nodes can be distinguished through a numerical id to suffix to the stackname, which can be used as the Salt minion id.\r\n\r\nThe first step is to implement a fixed number of copies of the same server. These nodes do not have an actual (internal nor external) hostname which will be adopted by a load balancer when there is one.\r\n\r\nThis code is able to create two node into a `medium--clustered` stackname (could have been called `medium--prod`).","created_at":"2016-09-12T12:51:46Z","updated_at":"2016-09-15T13:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31b88a47ddec4b95b212d89dac86774e47c5d4fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/builder/pulls/49/commits","review_comments_url":"https://api.github.com/repos/elifesciences/builder/pulls/49/comments","review_comment_url":"https://api.github.com/repos/elifesciences/builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/builder/issues/49/comments","statuses_url":"https://api.github.com/repos/elifesciences/builder/statuses/90d047f6bfa601cefdd7d67b6496119df538202a","head":{"label":"elifesciences:clusters_of_ec2_instances","ref":"clusters_of_ec2_instances","sha":"90d047f6bfa601cefdd7d67b6496119df538202a","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":56778863,"name":"builder","full_name":"elifesciences/builder","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/builder","description":"","fork":false,"url":"https://api.github.com/repos/elifesciences/builder","forks_url":"https://api.github.com/repos/elifesciences/builder/forks","keys_url":"https://api.github.com/repos/elifesciences/builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/builder/teams","hooks_url":"https://api.github.com/repos/elifesciences/builder/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/builder/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/builder/events","assignees_url":"https://api.github.com/repos/elifesciences/builder/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/builder/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/builder/tags","blobs_url":"https://api.github.com/repos/elifesciences/builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/builder/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/builder/languages","stargazers_url":"https://api.github.com/repos/elifesciences/builder/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/builder/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/builder/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/builder/subscription","commits_url":"https://api.github.com/repos/elifesciences/builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/builder/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/builder/merges","archive_url":"https://api.github.com/repos/elifesciences/builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/builder/downloads","issues_url":"https://api.github.com/repos/elifesciences/builder/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/builder/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/builder/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/builder/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/builder/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/builder/deployments","created_at":"2016-04-21T14:08:05Z","updated_at":"2016-07-04T11:43:06Z","pushed_at":"2016-09-15T11:28:51Z","git_url":"git://github.com/elifesciences/builder.git","ssh_url":"git@github.com:elifesciences/builder.git","clone_url":"https://github.com/elifesciences/builder.git","svn_url":"https://github.com/elifesciences/builder","homepage":null,"size":633,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"elifesciences:master","ref":"master","sha":"d2b7719e9ce2bc8597d880d59f4e0bb952c44678","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":56778863,"name":"builder","full_name":"elifesciences/builder","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/builder","description":"","fork":false,"url":"https://api.github.com/repos/elifesciences/builder","forks_url":"https://api.github.com/repos/elifesciences/builder/forks","keys_url":"https://api.github.com/repos/elifesciences/builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/builder/teams","hooks_url":"https://api.github.com/repos/elifesciences/builder/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/builder/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/builder/events","assignees_url":"https://api.github.com/repos/elifesciences/builder/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/builder/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/builder/tags","blobs_url":"https://api.github.com/repos/elifesciences/builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/builder/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/builder/languages","stargazers_url":"https://api.github.com/repos/elifesciences/builder/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/builder/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/builder/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/builder/subscription","commits_url":"https://api.github.com/repos/elifesciences/builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/builder/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/builder/merges","archive_url":"https://api.github.com/repos/elifesciences/builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/builder/downloads","issues_url":"https://api.github.com/repos/elifesciences/builder/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/builder/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/builder/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/builder/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/builder/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/builder/deployments","created_at":"2016-04-21T14:08:05Z","updated_at":"2016-07-04T11:43:06Z","pushed_at":"2016-09-15T11:28:51Z","git_url":"git://github.com/elifesciences/builder.git","ssh_url":"git@github.com:elifesciences/builder.git","clone_url":"https://github.com/elifesciences/builder.git","svn_url":"https://github.com/elifesciences/builder","homepage":null,"size":633,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/49"},"html":{"href":"https://github.com/elifesciences/builder/pull/49"},"issue":{"href":"https://api.github.com/repos/elifesciences/builder/issues/49"},"comments":{"href":"https://api.github.com/repos/elifesciences/builder/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/builder/statuses/90d047f6bfa601cefdd7d67b6496119df538202a"}}}}
{"actor":{"display_login":"lsh-0"}}