{"action":"created","issue":{"url":"https://api.github.com/repos/openaps/oref0/issues/198","repository_url":"https://api.github.com/repos/openaps/oref0","labels_url":"https://api.github.com/repos/openaps/oref0/issues/198/labels{/name}","comments_url":"https://api.github.com/repos/openaps/oref0/issues/198/comments","events_url":"https://api.github.com/repos/openaps/oref0/issues/198/events","html_url":"https://github.com/openaps/oref0/pull/198","id":173169367,"number":198,"title":"Wip/accoutforbasalprofile","user":{"login":"sulkaharo","id":1001330,"avatar_url":"https://avatars.githubusercontent.com/u/1001330?v=3","gravatar_id":"","url":"https://api.github.com/users/sulkaharo","html_url":"https://github.com/sulkaharo","followers_url":"https://api.github.com/users/sulkaharo/followers","following_url":"https://api.github.com/users/sulkaharo/following{/other_user}","gists_url":"https://api.github.com/users/sulkaharo/gists{/gist_id}","starred_url":"https://api.github.com/users/sulkaharo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulkaharo/subscriptions","organizations_url":"https://api.github.com/users/sulkaharo/orgs","repos_url":"https://api.github.com/users/sulkaharo/repos","events_url":"https://api.github.com/users/sulkaharo/events{/privacy}","received_events_url":"https://api.github.com/users/sulkaharo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-25T10:36:36Z","updated_at":"2016-08-25T12:42:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openaps/oref0/pulls/198","html_url":"https://github.com/openaps/oref0/pull/198","diff_url":"https://github.com/openaps/oref0/pull/198.diff","patch_url":"https://github.com/openaps/oref0/pull/198.patch"},"body":"Changes IOB calculation take full basal profile into account. Fixes potential issues with fetching the basal rate (previous code was relying on the basal profile data being sorted, when it wasn't actually guaranteed)."},"comment":{"url":"https://api.github.com/repos/openaps/oref0/issues/comments/242372327","html_url":"https://github.com/openaps/oref0/pull/198#issuecomment-242372327","issue_url":"https://api.github.com/repos/openaps/oref0/issues/198","id":242372327,"user":{"login":"thebookins","id":12263040,"avatar_url":"https://avatars.githubusercontent.com/u/12263040?v=3","gravatar_id":"","url":"https://api.github.com/users/thebookins","html_url":"https://github.com/thebookins","followers_url":"https://api.github.com/users/thebookins/followers","following_url":"https://api.github.com/users/thebookins/following{/other_user}","gists_url":"https://api.github.com/users/thebookins/gists{/gist_id}","starred_url":"https://api.github.com/users/thebookins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebookins/subscriptions","organizations_url":"https://api.github.com/users/thebookins/orgs","repos_url":"https://api.github.com/users/thebookins/repos","events_url":"https://api.github.com/users/thebookins/events{/privacy}","received_events_url":"https://api.github.com/users/thebookins/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T12:42:22Z","updated_at":"2016-08-25T12:42:22Z","body":"While we are at it, it wouldn't hurt to fix the sorting function at the end of history.js:\r\n`     all_data.sort(function (a, b) { return a.date > b.date });`\r\nSince `a.date` and `b.date` are integers, it's sufficient to write `return a.date - b.date` (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort). The current code doesn't sort properly. I'm not sure any of the downstream code depends on sorted data, but it may in the future.\r\n"}}
{"actor":{"display_login":"thebookins"}}