{"action":"created","issue":{"url":"https://api.github.com/repos/TOMOTON/gwt-dagger2/issues/1","repository_url":"https://api.github.com/repos/TOMOTON/gwt-dagger2","labels_url":"https://api.github.com/repos/TOMOTON/gwt-dagger2/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/TOMOTON/gwt-dagger2/issues/1/comments","events_url":"https://api.github.com/repos/TOMOTON/gwt-dagger2/issues/1/events","html_url":"https://github.com/TOMOTON/gwt-dagger2/pull/1","id":174888005,"number":1,"title":"Apply new generation gwt-maven-plugin","user":{"login":"ibaca","id":1042225,"avatar_url":"https://avatars.githubusercontent.com/u/1042225?v=3","gravatar_id":"","url":"https://api.github.com/users/ibaca","html_url":"https://github.com/ibaca","followers_url":"https://api.github.com/users/ibaca/followers","following_url":"https://api.github.com/users/ibaca/following{/other_user}","gists_url":"https://api.github.com/users/ibaca/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaca/subscriptions","organizations_url":"https://api.github.com/users/ibaca/orgs","repos_url":"https://api.github.com/users/ibaca/repos","events_url":"https://api.github.com/users/ibaca/events{/privacy}","received_events_url":"https://api.github.com/users/ibaca/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-03T09:18:24Z","updated_at":"2016-09-03T20:40:18Z","closed_at":"2016-09-03T12:50:45Z","pull_request":{"url":"https://api.github.com/repos/TOMOTON/gwt-dagger2/pulls/1","html_url":"https://github.com/TOMOTON/gwt-dagger2/pull/1","diff_url":"https://github.com/TOMOTON/gwt-dagger2/pull/1.diff","patch_url":"https://github.com/TOMOTON/gwt-dagger2/pull/1.patch"},"body":"I have changed too many things 😞. If you don't like it just close the pull request.\r\n\r\nI think that you should NOT use generators in example projects, you should help the community to migrate to APT, not to go back to generators 😛. I have changed the strategy to load you POM version using `System.getProperty` and the `-setProperty` GWT compiler argument.\r\n\r\nAlso I have moved every static resource into the module public folder, this makes things even easier because the module contains 100% of the resources. Now when you package the project, it will generate a `gwt-dagger2-coffee.war` which contains the module result into one folder `coffee` (you can unzip the war), and when you are developing you can just use devmode and open the module directly."},"comment":{"url":"https://api.github.com/repos/TOMOTON/gwt-dagger2/issues/comments/244568597","html_url":"https://github.com/TOMOTON/gwt-dagger2/pull/1#issuecomment-244568597","issue_url":"https://api.github.com/repos/TOMOTON/gwt-dagger2/issues/1","id":244568597,"user":{"login":"ibaca","id":1042225,"avatar_url":"https://avatars.githubusercontent.com/u/1042225?v=3","gravatar_id":"","url":"https://api.github.com/users/ibaca","html_url":"https://github.com/ibaca","followers_url":"https://api.github.com/users/ibaca/followers","following_url":"https://api.github.com/users/ibaca/following{/other_user}","gists_url":"https://api.github.com/users/ibaca/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaca/subscriptions","organizations_url":"https://api.github.com/users/ibaca/orgs","repos_url":"https://api.github.com/users/ibaca/repos","events_url":"https://api.github.com/users/ibaca/events{/privacy}","received_events_url":"https://api.github.com/users/ibaca/received_events","type":"User","site_admin":false},"created_at":"2016-09-03T20:40:18Z","updated_at":"2016-09-03T20:40:18Z","body":"Yep, I know that it is too different to merge this pull request. Maven sell\nitself as a system based on convention, but in my opinion is a system\nrestricted by its conventions, if you have your own ideas (and looks like\nin your company you know exactly how the project should be cobfigured)\nmaven is just a hell.\n\nEl sáb., 3 de septiembre de 2016 14:50, Dann Martens <\nnotifications@github.com> escribió:\n\n> Our version policy has nothing to do with Maven and I don't think it\n> affects Maven in any way. Maven will build fine with 0.0.0-DEV. It's the\n> responsibility of the CI infrastructure to put in the right version. No\n> manual builds allowed. Also be aware that -SNAPSHOT is considered a\n> terrible anti-pattern. But then again, I consider using Maven an\n> anti-pattern in its own right.\n> It's hard to cherry-pick from your pull request, as you have even changed\n> the package structure of the regular source code. Ironically, you have\n> shortened that package hierarchy, yet reverted to the Maven directory\n> structure, adding pointless directories.\n> I like what you did with the version property, though.\n> Your Maven-centric development model will simply not work if you want to\n> exploit some of the productivity features of an IDE: I've noticed many\n> interoperability problems just for this project, combining the Google\n> Eclipse plug-in with the Maven integration.\n> So, thanks for the useful feedback and your demonstration of an\n> alternative approach, but I have to close this because it doesn't address\n> the Eclipse problem!\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/TOMOTON/gwt-dagger2/pull/1#issuecomment-244544622>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AA_nMRDaD2BuoQg7-mW8LmrHGDeeL_Vsks5qmW0lgaJpZM4J0Q4Y>\n> .\n>\n"}}
{"actor":{"display_login":"ibaca"}}