{"action":"created","comment":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/comments/60959732","id":60959732,"diff_hunk":"@@ -147,3 +148,24 @@ sol_cert_get_filename(const struct sol_cert *cert)\n \n     return cert->filename;\n }\n+\n+SOL_API struct sol_blob *\n+sol_cert_get_contents(const struct sol_cert *cert)\n+{\n+    struct sol_blob *blob;\n+    char *data;\n+\n+    SOL_NULL_CHECK(cert, NULL);\n+\n+    data = sol_util_load_file_string(cert->filename, NULL);","path":"src/lib/common/sol-certificate-impl-linux.c","position":21,"original_position":21,"commit_id":"5b1bc4f0d48f4b3534024d398901aba76324f0a8","original_commit_id":"8df061487477bb6b1377ffbee393f8024eb2766c","user":{"login":"edersondisouza","id":3177551,"avatar_url":"https://avatars.githubusercontent.com/u/3177551?v=3","gravatar_id":"","url":"https://api.github.com/users/edersondisouza","html_url":"https://github.com/edersondisouza","followers_url":"https://api.github.com/users/edersondisouza/followers","following_url":"https://api.github.com/users/edersondisouza/following{/other_user}","gists_url":"https://api.github.com/users/edersondisouza/gists{/gist_id}","starred_url":"https://api.github.com/users/edersondisouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edersondisouza/subscriptions","organizations_url":"https://api.github.com/users/edersondisouza/orgs","repos_url":"https://api.github.com/users/edersondisouza/repos","events_url":"https://api.github.com/users/edersondisouza/events{/privacy}","received_events_url":"https://api.github.com/users/edersondisouza/received_events","type":"User","site_admin":false},"body":"Why don't you use second parameter to get `data` size instead of doing a `strlen`?","created_at":"2016-04-25T18:08:23Z","updated_at":"2016-04-25T18:08:23Z","html_url":"https://github.com/solettaproject/soletta/pull/1932#discussion_r60959732","pull_request_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1932","_links":{"self":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/comments/60959732"},"html":{"href":"https://github.com/solettaproject/soletta/pull/1932#discussion_r60959732"},"pull_request":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1932"}}},"pull_request":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/1932","id":67760069,"html_url":"https://github.com/solettaproject/soletta/pull/1932","diff_url":"https://github.com/solettaproject/soletta/pull/1932.diff","patch_url":"https://github.com/solettaproject/soletta/pull/1932.patch","issue_url":"https://api.github.com/repos/solettaproject/soletta/issues/1932","number":1932,"state":"open","locked":false,"title":"HTTPS v2","user":{"login":"ceolin","id":882919,"avatar_url":"https://avatars.githubusercontent.com/u/882919?v=3","gravatar_id":"","url":"https://api.github.com/users/ceolin","html_url":"https://github.com/ceolin","followers_url":"https://api.github.com/users/ceolin/followers","following_url":"https://api.github.com/users/ceolin/following{/other_user}","gists_url":"https://api.github.com/users/ceolin/gists{/gist_id}","starred_url":"https://api.github.com/users/ceolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceolin/subscriptions","organizations_url":"https://api.github.com/users/ceolin/orgs","repos_url":"https://api.github.com/users/ceolin/repos","events_url":"https://api.github.com/users/ceolin/events{/privacy}","received_events_url":"https://api.github.com/users/ceolin/received_events","type":"User","site_admin":false},"body":"from v1:\r\n- add sol_http_server_config (avoid two functions to create a server)\r\n- Added better explanation about how to test the sample","created_at":"2016-04-25T17:48:16Z","updated_at":"2016-04-25T18:08:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed395476c236ff7c4fa1529bfe27db52c9b90208","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1932/commits","review_comments_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1932/comments","review_comment_url":"https://api.github.com/repos/solettaproject/soletta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solettaproject/soletta/issues/1932/comments","statuses_url":"https://api.github.com/repos/solettaproject/soletta/statuses/5b1bc4f0d48f4b3534024d398901aba76324f0a8","head":{"label":"ceolin:https-v2","ref":"https-v2","sha":"5b1bc4f0d48f4b3534024d398901aba76324f0a8","user":{"login":"ceolin","id":882919,"avatar_url":"https://avatars.githubusercontent.com/u/882919?v=3","gravatar_id":"","url":"https://api.github.com/users/ceolin","html_url":"https://github.com/ceolin","followers_url":"https://api.github.com/users/ceolin/followers","following_url":"https://api.github.com/users/ceolin/following{/other_user}","gists_url":"https://api.github.com/users/ceolin/gists{/gist_id}","starred_url":"https://api.github.com/users/ceolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceolin/subscriptions","organizations_url":"https://api.github.com/users/ceolin/orgs","repos_url":"https://api.github.com/users/ceolin/repos","events_url":"https://api.github.com/users/ceolin/events{/privacy}","received_events_url":"https://api.github.com/users/ceolin/received_events","type":"User","site_admin":false},"repo":{"id":37607073,"name":"soletta","full_name":"ceolin/soletta","owner":{"login":"ceolin","id":882919,"avatar_url":"https://avatars.githubusercontent.com/u/882919?v=3","gravatar_id":"","url":"https://api.github.com/users/ceolin","html_url":"https://github.com/ceolin","followers_url":"https://api.github.com/users/ceolin/followers","following_url":"https://api.github.com/users/ceolin/following{/other_user}","gists_url":"https://api.github.com/users/ceolin/gists{/gist_id}","starred_url":"https://api.github.com/users/ceolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceolin/subscriptions","organizations_url":"https://api.github.com/users/ceolin/orgs","repos_url":"https://api.github.com/users/ceolin/repos","events_url":"https://api.github.com/users/ceolin/events{/privacy}","received_events_url":"https://api.github.com/users/ceolin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ceolin/soletta","description":"Soletta Project is a framework for making IoT devices.  With Soletta Project's libraries developers can easily write software for devices that control actuators/sensors and communicate using standard technologies. It enables adding smartness even on the smallest edge devices.  Portable and scalable, it abstracts details of hardware and OS, enabling developers to reuse their code and knowledge on different targets.","fork":true,"url":"https://api.github.com/repos/ceolin/soletta","forks_url":"https://api.github.com/repos/ceolin/soletta/forks","keys_url":"https://api.github.com/repos/ceolin/soletta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceolin/soletta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceolin/soletta/teams","hooks_url":"https://api.github.com/repos/ceolin/soletta/hooks","issue_events_url":"https://api.github.com/repos/ceolin/soletta/issues/events{/number}","events_url":"https://api.github.com/repos/ceolin/soletta/events","assignees_url":"https://api.github.com/repos/ceolin/soletta/assignees{/user}","branches_url":"https://api.github.com/repos/ceolin/soletta/branches{/branch}","tags_url":"https://api.github.com/repos/ceolin/soletta/tags","blobs_url":"https://api.github.com/repos/ceolin/soletta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceolin/soletta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceolin/soletta/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceolin/soletta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceolin/soletta/statuses/{sha}","languages_url":"https://api.github.com/repos/ceolin/soletta/languages","stargazers_url":"https://api.github.com/repos/ceolin/soletta/stargazers","contributors_url":"https://api.github.com/repos/ceolin/soletta/contributors","subscribers_url":"https://api.github.com/repos/ceolin/soletta/subscribers","subscription_url":"https://api.github.com/repos/ceolin/soletta/subscription","commits_url":"https://api.github.com/repos/ceolin/soletta/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceolin/soletta/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceolin/soletta/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceolin/soletta/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceolin/soletta/contents/{+path}","compare_url":"https://api.github.com/repos/ceolin/soletta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceolin/soletta/merges","archive_url":"https://api.github.com/repos/ceolin/soletta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceolin/soletta/downloads","issues_url":"https://api.github.com/repos/ceolin/soletta/issues{/number}","pulls_url":"https://api.github.com/repos/ceolin/soletta/pulls{/number}","milestones_url":"https://api.github.com/repos/ceolin/soletta/milestones{/number}","notifications_url":"https://api.github.com/repos/ceolin/soletta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceolin/soletta/labels{/name}","releases_url":"https://api.github.com/repos/ceolin/soletta/releases{/id}","deployments_url":"https://api.github.com/repos/ceolin/soletta/deployments","created_at":"2015-06-17T16:33:08Z","updated_at":"2015-06-17T16:33:10Z","pushed_at":"2016-04-25T17:46:02Z","git_url":"git://github.com/ceolin/soletta.git","ssh_url":"git@github.com:ceolin/soletta.git","clone_url":"https://github.com/ceolin/soletta.git","svn_url":"https://github.com/ceolin/soletta","homepage":"","size":18614,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solettaproject:master","ref":"master","sha":"7cc996324671d26c5d6ef080b5c633076935e6d6","user":{"login":"solettaproject","id":12736897,"avatar_url":"https://avatars.githubusercontent.com/u/12736897?v=3","gravatar_id":"","url":"https://api.github.com/users/solettaproject","html_url":"https://github.com/solettaproject","followers_url":"https://api.github.com/users/solettaproject/followers","following_url":"https://api.github.com/users/solettaproject/following{/other_user}","gists_url":"https://api.github.com/users/solettaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/solettaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solettaproject/subscriptions","organizations_url":"https://api.github.com/users/solettaproject/orgs","repos_url":"https://api.github.com/users/solettaproject/repos","events_url":"https://api.github.com/users/solettaproject/events{/privacy}","received_events_url":"https://api.github.com/users/solettaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":37087063,"name":"soletta","full_name":"solettaproject/soletta","owner":{"login":"solettaproject","id":12736897,"avatar_url":"https://avatars.githubusercontent.com/u/12736897?v=3","gravatar_id":"","url":"https://api.github.com/users/solettaproject","html_url":"https://github.com/solettaproject","followers_url":"https://api.github.com/users/solettaproject/followers","following_url":"https://api.github.com/users/solettaproject/following{/other_user}","gists_url":"https://api.github.com/users/solettaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/solettaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solettaproject/subscriptions","organizations_url":"https://api.github.com/users/solettaproject/orgs","repos_url":"https://api.github.com/users/solettaproject/repos","events_url":"https://api.github.com/users/solettaproject/events{/privacy}","received_events_url":"https://api.github.com/users/solettaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solettaproject/soletta","description":"Soletta Project is a framework for making IoT devices.  With Soletta Project's libraries developers can easily write software for devices that control actuators/sensors and communicate using standard technologies. It enables adding smartness even on the smallest edge devices.  ","fork":false,"url":"https://api.github.com/repos/solettaproject/soletta","forks_url":"https://api.github.com/repos/solettaproject/soletta/forks","keys_url":"https://api.github.com/repos/solettaproject/soletta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solettaproject/soletta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solettaproject/soletta/teams","hooks_url":"https://api.github.com/repos/solettaproject/soletta/hooks","issue_events_url":"https://api.github.com/repos/solettaproject/soletta/issues/events{/number}","events_url":"https://api.github.com/repos/solettaproject/soletta/events","assignees_url":"https://api.github.com/repos/solettaproject/soletta/assignees{/user}","branches_url":"https://api.github.com/repos/solettaproject/soletta/branches{/branch}","tags_url":"https://api.github.com/repos/solettaproject/soletta/tags","blobs_url":"https://api.github.com/repos/solettaproject/soletta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solettaproject/soletta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solettaproject/soletta/git/refs{/sha}","trees_url":"https://api.github.com/repos/solettaproject/soletta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solettaproject/soletta/statuses/{sha}","languages_url":"https://api.github.com/repos/solettaproject/soletta/languages","stargazers_url":"https://api.github.com/repos/solettaproject/soletta/stargazers","contributors_url":"https://api.github.com/repos/solettaproject/soletta/contributors","subscribers_url":"https://api.github.com/repos/solettaproject/soletta/subscribers","subscription_url":"https://api.github.com/repos/solettaproject/soletta/subscription","commits_url":"https://api.github.com/repos/solettaproject/soletta/commits{/sha}","git_commits_url":"https://api.github.com/repos/solettaproject/soletta/git/commits{/sha}","comments_url":"https://api.github.com/repos/solettaproject/soletta/comments{/number}","issue_comment_url":"https://api.github.com/repos/solettaproject/soletta/issues/comments{/number}","contents_url":"https://api.github.com/repos/solettaproject/soletta/contents/{+path}","compare_url":"https://api.github.com/repos/solettaproject/soletta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solettaproject/soletta/merges","archive_url":"https://api.github.com/repos/solettaproject/soletta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solettaproject/soletta/downloads","issues_url":"https://api.github.com/repos/solettaproject/soletta/issues{/number}","pulls_url":"https://api.github.com/repos/solettaproject/soletta/pulls{/number}","milestones_url":"https://api.github.com/repos/solettaproject/soletta/milestones{/number}","notifications_url":"https://api.github.com/repos/solettaproject/soletta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solettaproject/soletta/labels{/name}","releases_url":"https://api.github.com/repos/solettaproject/soletta/releases{/id}","deployments_url":"https://api.github.com/repos/solettaproject/soletta/deployments","created_at":"2015-06-08T19:13:18Z","updated_at":"2016-04-25T14:52:03Z","pushed_at":"2016-04-25T17:58:57Z","git_url":"git://github.com/solettaproject/soletta.git","ssh_url":"git@github.com:solettaproject/soletta.git","clone_url":"https://github.com/solettaproject/soletta.git","svn_url":"https://github.com/solettaproject/soletta","homepage":"http://solettaproject.org","size":25845,"stargazers_count":86,"watchers_count":86,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":187,"forks":73,"open_issues":187,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1932"},"html":{"href":"https://github.com/solettaproject/soletta/pull/1932"},"issue":{"href":"https://api.github.com/repos/solettaproject/soletta/issues/1932"},"comments":{"href":"https://api.github.com/repos/solettaproject/soletta/issues/1932/comments"},"review_comments":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1932/comments"},"review_comment":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1932/commits"},"statuses":{"href":"https://api.github.com/repos/solettaproject/soletta/statuses/5b1bc4f0d48f4b3534024d398901aba76324f0a8"}}}}