{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/92943131","pull_request_review_id":13465773,"id":92943131,"diff_hunk":"@@ -624,7 +624,7 @@ public function tempnam($dir, $prefix)\n      * @param string $filename The file to be written to\n      * @param string $content  The data to write into the file","path":"src/Symfony/Component/Filesystem/Filesystem.php","position":2,"original_position":2,"commit_id":"286de841bdf758ee267f1a0abed8550e70c82df5","original_commit_id":"ec7c144d2bc49acc66948a41dc63d698bdb2a849","user":{"login":"ro0NL","id":1047696,"avatar_url":"https://avatars.githubusercontent.com/u/1047696?v=3","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"body":"Agree.","created_at":"2016-12-18T15:00:40Z","updated_at":"2016-12-18T15:00:40Z","html_url":"https://github.com/symfony/symfony/pull/20612#discussion_r92943131","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/20612","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/92943131"},"html":{"href":"https://github.com/symfony/symfony/pull/20612#discussion_r92943131"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20612"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20612","id":95079452,"html_url":"https://github.com/symfony/symfony/pull/20612","diff_url":"https://github.com/symfony/symfony/pull/20612.diff","patch_url":"https://github.com/symfony/symfony/pull/20612.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20612","number":20612,"state":"open","locked":false,"title":"[Filesystem] Add appendToFile()","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | todo\r\n\r\nSo we could atomically append content to a file:\r\n\r\n```php\r\n(new Filesystem)->appendToFile($file, 'bar');\r\n```\r\n\r\ninstead of doing it in two steps:\r\n\r\n```php\r\nif (false === $content = @file_get_contents($file)) {\r\n    throw new \\Exception();\r\n}\r\n\r\n(new Filesystem)->dumpFile($file, $content.'bar');\r\n```\r\n\r\nDoing it opt-in using `dumpFile(..., $append = false)` would have been enough but not possible for BC.","created_at":"2016-11-23T21:06:43Z","updated_at":"2016-12-18T15:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa6afca077461ca550b2aaef37bff88083ae2975","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.x","description":"New features and deprecations go here. Since Symfony versions are time based, this milestone has no due date.","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":140,"closed_issues":32,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2016-12-17T17:00:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20612/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20612/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20612/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/286de841bdf758ee267f1a0abed8550e70c82df5","head":{"label":"chalasr:filesystem/append_to_file","ref":"filesystem/append_to_file","sha":"286de841bdf758ee267f1a0abed8550e70c82df5","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"repo":{"id":56510160,"name":"symfony","full_name":"chalasr/symfony","owner":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chalasr/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/chalasr/symfony","forks_url":"https://api.github.com/repos/chalasr/symfony/forks","keys_url":"https://api.github.com/repos/chalasr/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chalasr/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chalasr/symfony/teams","hooks_url":"https://api.github.com/repos/chalasr/symfony/hooks","issue_events_url":"https://api.github.com/repos/chalasr/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/chalasr/symfony/events","assignees_url":"https://api.github.com/repos/chalasr/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/chalasr/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/chalasr/symfony/tags","blobs_url":"https://api.github.com/repos/chalasr/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chalasr/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chalasr/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/chalasr/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chalasr/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/chalasr/symfony/languages","stargazers_url":"https://api.github.com/repos/chalasr/symfony/stargazers","contributors_url":"https://api.github.com/repos/chalasr/symfony/contributors","subscribers_url":"https://api.github.com/repos/chalasr/symfony/subscribers","subscription_url":"https://api.github.com/repos/chalasr/symfony/subscription","commits_url":"https://api.github.com/repos/chalasr/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/chalasr/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/chalasr/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/chalasr/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/chalasr/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/chalasr/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chalasr/symfony/merges","archive_url":"https://api.github.com/repos/chalasr/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chalasr/symfony/downloads","issues_url":"https://api.github.com/repos/chalasr/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/chalasr/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/chalasr/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/chalasr/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chalasr/symfony/labels{/name}","releases_url":"https://api.github.com/repos/chalasr/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/chalasr/symfony/deployments","created_at":"2016-04-18T13:30:14Z","updated_at":"2016-04-18T13:30:30Z","pushed_at":"2016-12-18T14:59:35Z","git_url":"git://github.com/chalasr/symfony.git","ssh_url":"git@github.com:chalasr/symfony.git","clone_url":"https://github.com/chalasr/symfony.git","svn_url":"https://github.com/chalasr/symfony","homepage":"symfony.com","size":78409,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"0ab662843132a4ede35a2fa7fce4e3d59c27fa15","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-12-18T14:57:53Z","pushed_at":"2016-12-18T15:00:20Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":81445,"stargazers_count":13480,"watchers_count":13480,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5232,"mirror_url":null,"open_issues_count":858,"forks":5232,"open_issues":858,"watchers":13480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20612"},"html":{"href":"https://github.com/symfony/symfony/pull/20612"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20612"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20612/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20612/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20612/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/286de841bdf758ee267f1a0abed8550e70c82df5"}}}}
{"actor":{"display_login":"ro0NL"}}