{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32449","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32449/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32449/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32449/events","html_url":"https://github.com/kubernetes/kubernetes/pull/32449","id":176207748,"number":32449,"title":"Unwrap aggregates of size 1 when writing errors","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"closed","locked":false,"assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2016-09-10T22:42:04Z","updated_at":"2016-09-27T13:59:30Z","closed_at":"2016-09-27T10:09:00Z","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32449","html_url":"https://github.com/kubernetes/kubernetes/pull/32449","diff_url":"https://github.com/kubernetes/kubernetes/pull/32449.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/32449.patch"},"body":"Our special error logic was being defeated by aggregates.\n\nAlso, only use aggregate in get when we actually are dealing with\nmultiple errors.\n\n@kubernetes/kubectl\n\nFor other kubectl reviewers - no one should use an aggregate unless you are ranging over a list, and even then ask yourself whether you really care about returning all errors.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/32449)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/249873105","html_url":"https://github.com/kubernetes/kubernetes/pull/32449#issuecomment-249873105","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32449","id":249873105,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T13:59:30Z","updated_at":"2016-09-27T13:59:30Z","body":"If you are creating an aggregate, you need to think about whether it's an\naggregate.  Also, just because you implement Errors() []error doesn't mean\nthat the Error() method on your object isn't important for giving context.\nThe configuration invalid errors actually provide an additional bit of\ndescriptive text even though they are aggregates.  That's why reduction of\naggregates is not automatic.\n\nOn Tue, Sep 27, 2016 at 9:55 AM, Maciej Szulik <notifications@github.com>\nwrote:\n\n> I think you would use Flatten in your use case.\n>\n> But you'd have to check if manually everywhere you suspect this might\n> happen, and here we could have it done automatically when creating an\n> aggregate. Aggregates tend to spread in multiple places in the code.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kubernetes/kubernetes/pull/32449#issuecomment-249871718>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABG_py2PZn3qKQiIeYxQlt6zktvHJBTVks5quSA7gaJpZM4J52Wx>\n> .\n>\n"}}
{"actor":{"display_login":"smarterclayton"}}