{"action":"created","comment":{"url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments/92714719","pull_request_review_id":13236099,"id":92714719,"diff_hunk":"@@ -1453,7 +1453,7 @@ const windowIsDefined = (typeof window === \"object\");\n \t\t\t\tthis._setDataVal(newValue);\n \t\t\t\tthis.setValue(newValue, false, true);\n \n-\t\t\t\tthis._pauseEvent(ev);\n+\t\t\t\tev.returnValue = false;","path":"src/js/bootstrap-slider.js","position":5,"original_position":5,"commit_id":"aeb0ed866ccf1b29cd48c25eabe4fef0a6bc0d88","original_commit_id":"aeb0ed866ccf1b29cd48c25eabe4fef0a6bc0d88","user":{"login":"rovolution","id":437318,"avatar_url":"https://avatars.githubusercontent.com/u/437318?v=3","gravatar_id":"","url":"https://api.github.com/users/rovolution","html_url":"https://github.com/rovolution","followers_url":"https://api.github.com/users/rovolution/followers","following_url":"https://api.github.com/users/rovolution/following{/other_user}","gists_url":"https://api.github.com/users/rovolution/gists{/gist_id}","starred_url":"https://api.github.com/users/rovolution/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovolution/subscriptions","organizations_url":"https://api.github.com/users/rovolution/orgs","repos_url":"https://api.github.com/users/rovolution/repos","events_url":"https://api.github.com/users/rovolution/events{/privacy}","received_events_url":"https://api.github.com/users/rovolution/received_events","type":"User","site_admin":false},"body":"what happens if we stick `this._pauseEvent(ev);` after `ev.returnValue = false;`? Does it still resolve your issue?\r\n\r\nsomething like:\r\n```js\r\nthis._pauseEvent(ev);\r\nev.returnValue = false;\r\n```","created_at":"2016-12-15T22:31:36Z","updated_at":"2016-12-15T22:31:49Z","html_url":"https://github.com/seiyria/bootstrap-slider/pull/672#discussion_r92714719","pull_request_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/672","_links":{"self":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments/92714719"},"html":{"href":"https://github.com/seiyria/bootstrap-slider/pull/672#discussion_r92714719"},"pull_request":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/672","id":97844664,"html_url":"https://github.com/seiyria/bootstrap-slider/pull/672","diff_url":"https://github.com/seiyria/bootstrap-slider/pull/672.diff","patch_url":"https://github.com/seiyria/bootstrap-slider/pull/672.patch","issue_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/672","number":672,"state":"open","locked":false,"title":"Prevent bootstrap modal hiding","user":{"login":"ZeVS777","id":5712526,"avatar_url":"https://avatars.githubusercontent.com/u/5712526?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeVS777","html_url":"https://github.com/ZeVS777","followers_url":"https://api.github.com/users/ZeVS777/followers","following_url":"https://api.github.com/users/ZeVS777/following{/other_user}","gists_url":"https://api.github.com/users/ZeVS777/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeVS777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeVS777/subscriptions","organizations_url":"https://api.github.com/users/ZeVS777/orgs","repos_url":"https://api.github.com/users/ZeVS777/repos","events_url":"https://api.github.com/users/ZeVS777/events{/privacy}","received_events_url":"https://api.github.com/users/ZeVS777/received_events","type":"User","site_admin":false},"body":"Issue #339: Modal dialog closes when dragging and releasing mouse button outside dialog.\r\nBootstrap modal needs a mousedown event to check the modal needs to be closed. When you release the mouse, if mouse was on modal, there will be no exit. But in our situation bootstrap-slider prevents bubbling mousedown event to modal, so it closes when you finished mouse movement outside modal.\r\n\r\nbefore:\r\n\r\n![cameringo_20161214_013451](https://cloud.githubusercontent.com/assets/5712526/21162333/efe103ac-c19d-11e6-9373-b8aa6104bace.gif)\r\n\r\nafter:\r\n\r\n![cameringo_20161214_013311](https://cloud.githubusercontent.com/assets/5712526/21162354/06b41204-c19e-11e6-9714-92ec8737f9a7.gif)\r\n","created_at":"2016-12-13T22:00:53Z","updated_at":"2016-12-15T22:31:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7188662f65da1798d8201e4e120d9e6b5e1d1d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/672/commits","review_comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/672/comments","review_comment_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/672/comments","statuses_url":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/aeb0ed866ccf1b29cd48c25eabe4fef0a6bc0d88","head":{"label":"ZeVS777:master","ref":"master","sha":"aeb0ed866ccf1b29cd48c25eabe4fef0a6bc0d88","user":{"login":"ZeVS777","id":5712526,"avatar_url":"https://avatars.githubusercontent.com/u/5712526?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeVS777","html_url":"https://github.com/ZeVS777","followers_url":"https://api.github.com/users/ZeVS777/followers","following_url":"https://api.github.com/users/ZeVS777/following{/other_user}","gists_url":"https://api.github.com/users/ZeVS777/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeVS777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeVS777/subscriptions","organizations_url":"https://api.github.com/users/ZeVS777/orgs","repos_url":"https://api.github.com/users/ZeVS777/repos","events_url":"https://api.github.com/users/ZeVS777/events{/privacy}","received_events_url":"https://api.github.com/users/ZeVS777/received_events","type":"User","site_admin":false},"repo":{"id":76400762,"name":"bootstrap-slider","full_name":"ZeVS777/bootstrap-slider","owner":{"login":"ZeVS777","id":5712526,"avatar_url":"https://avatars.githubusercontent.com/u/5712526?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeVS777","html_url":"https://github.com/ZeVS777","followers_url":"https://api.github.com/users/ZeVS777/followers","following_url":"https://api.github.com/users/ZeVS777/following{/other_user}","gists_url":"https://api.github.com/users/ZeVS777/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeVS777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeVS777/subscriptions","organizations_url":"https://api.github.com/users/ZeVS777/orgs","repos_url":"https://api.github.com/users/ZeVS777/repos","events_url":"https://api.github.com/users/ZeVS777/events{/privacy}","received_events_url":"https://api.github.com/users/ZeVS777/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZeVS777/bootstrap-slider","description":"A complete rewrite of the original bootstrap-slider by Stefan Petre.","fork":true,"url":"https://api.github.com/repos/ZeVS777/bootstrap-slider","forks_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/forks","keys_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/teams","hooks_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/hooks","issue_events_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/issues/events{/number}","events_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/events","assignees_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/assignees{/user}","branches_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/branches{/branch}","tags_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/tags","blobs_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/languages","stargazers_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/stargazers","contributors_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/contributors","subscribers_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/subscribers","subscription_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/subscription","commits_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/contents/{+path}","compare_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/merges","archive_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/downloads","issues_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/issues{/number}","pulls_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/labels{/name}","releases_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/releases{/id}","deployments_url":"https://api.github.com/repos/ZeVS777/bootstrap-slider/deployments","created_at":"2016-12-13T21:40:40Z","updated_at":"2016-12-13T21:40:42Z","pushed_at":"2016-12-14T08:06:31Z","git_url":"git://github.com/ZeVS777/bootstrap-slider.git","ssh_url":"git@github.com:ZeVS777/bootstrap-slider.git","clone_url":"https://github.com/ZeVS777/bootstrap-slider.git","svn_url":"https://github.com/ZeVS777/bootstrap-slider","homepage":"http://seiyria.github.io/bootstrap-slider/","size":17074,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seiyria:master","ref":"master","sha":"45e320050a065bcb6e494e4d5b747eb911ab87f3","user":{"login":"seiyria","id":763609,"avatar_url":"https://avatars.githubusercontent.com/u/763609?v=3","gravatar_id":"","url":"https://api.github.com/users/seiyria","html_url":"https://github.com/seiyria","followers_url":"https://api.github.com/users/seiyria/followers","following_url":"https://api.github.com/users/seiyria/following{/other_user}","gists_url":"https://api.github.com/users/seiyria/gists{/gist_id}","starred_url":"https://api.github.com/users/seiyria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiyria/subscriptions","organizations_url":"https://api.github.com/users/seiyria/orgs","repos_url":"https://api.github.com/users/seiyria/repos","events_url":"https://api.github.com/users/seiyria/events{/privacy}","received_events_url":"https://api.github.com/users/seiyria/received_events","type":"User","site_admin":false},"repo":{"id":11111023,"name":"bootstrap-slider","full_name":"seiyria/bootstrap-slider","owner":{"login":"seiyria","id":763609,"avatar_url":"https://avatars.githubusercontent.com/u/763609?v=3","gravatar_id":"","url":"https://api.github.com/users/seiyria","html_url":"https://github.com/seiyria","followers_url":"https://api.github.com/users/seiyria/followers","following_url":"https://api.github.com/users/seiyria/following{/other_user}","gists_url":"https://api.github.com/users/seiyria/gists{/gist_id}","starred_url":"https://api.github.com/users/seiyria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiyria/subscriptions","organizations_url":"https://api.github.com/users/seiyria/orgs","repos_url":"https://api.github.com/users/seiyria/repos","events_url":"https://api.github.com/users/seiyria/events{/privacy}","received_events_url":"https://api.github.com/users/seiyria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seiyria/bootstrap-slider","description":"A complete rewrite of the original bootstrap-slider by Stefan Petre.","fork":false,"url":"https://api.github.com/repos/seiyria/bootstrap-slider","forks_url":"https://api.github.com/repos/seiyria/bootstrap-slider/forks","keys_url":"https://api.github.com/repos/seiyria/bootstrap-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seiyria/bootstrap-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seiyria/bootstrap-slider/teams","hooks_url":"https://api.github.com/repos/seiyria/bootstrap-slider/hooks","issue_events_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/events{/number}","events_url":"https://api.github.com/repos/seiyria/bootstrap-slider/events","assignees_url":"https://api.github.com/repos/seiyria/bootstrap-slider/assignees{/user}","branches_url":"https://api.github.com/repos/seiyria/bootstrap-slider/branches{/branch}","tags_url":"https://api.github.com/repos/seiyria/bootstrap-slider/tags","blobs_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/seiyria/bootstrap-slider/languages","stargazers_url":"https://api.github.com/repos/seiyria/bootstrap-slider/stargazers","contributors_url":"https://api.github.com/repos/seiyria/bootstrap-slider/contributors","subscribers_url":"https://api.github.com/repos/seiyria/bootstrap-slider/subscribers","subscription_url":"https://api.github.com/repos/seiyria/bootstrap-slider/subscription","commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/seiyria/bootstrap-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/seiyria/bootstrap-slider/contents/{+path}","compare_url":"https://api.github.com/repos/seiyria/bootstrap-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seiyria/bootstrap-slider/merges","archive_url":"https://api.github.com/repos/seiyria/bootstrap-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seiyria/bootstrap-slider/downloads","issues_url":"https://api.github.com/repos/seiyria/bootstrap-slider/issues{/number}","pulls_url":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/seiyria/bootstrap-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/seiyria/bootstrap-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seiyria/bootstrap-slider/labels{/name}","releases_url":"https://api.github.com/repos/seiyria/bootstrap-slider/releases{/id}","deployments_url":"https://api.github.com/repos/seiyria/bootstrap-slider/deployments","created_at":"2013-07-02T00:25:54Z","updated_at":"2016-12-15T09:57:47Z","pushed_at":"2016-12-14T08:06:33Z","git_url":"git://github.com/seiyria/bootstrap-slider.git","ssh_url":"git@github.com:seiyria/bootstrap-slider.git","clone_url":"https://github.com/seiyria/bootstrap-slider.git","svn_url":"https://github.com/seiyria/bootstrap-slider","homepage":"http://seiyria.github.io/bootstrap-slider/","size":17057,"stargazers_count":1829,"watchers_count":1829,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":696,"mirror_url":null,"open_issues_count":52,"forks":696,"open_issues":52,"watchers":1829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/672"},"html":{"href":"https://github.com/seiyria/bootstrap-slider/pull/672"},"issue":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/672"},"comments":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/seiyria/bootstrap-slider/statuses/aeb0ed866ccf1b29cd48c25eabe4fef0a6bc0d88"}}}}
{"actor":{"display_login":"rovolution"}}