{"action":"created","issue":{"url":"https://api.github.com/repos/ocedo/mstpd/issues/19","repository_url":"https://api.github.com/repos/ocedo/mstpd","labels_url":"https://api.github.com/repos/ocedo/mstpd/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/ocedo/mstpd/issues/19/comments","events_url":"https://api.github.com/repos/ocedo/mstpd/issues/19/events","html_url":"https://github.com/ocedo/mstpd/pull/19","id":144482264,"number":19,"title":"bridge_track: do not process packets that do not meet BPDU validation","user":{"login":"commodo","id":2766732,"avatar_url":"https://avatars.githubusercontent.com/u/2766732?v=3","gravatar_id":"","url":"https://api.github.com/users/commodo","html_url":"https://github.com/commodo","followers_url":"https://api.github.com/users/commodo/followers","following_url":"https://api.github.com/users/commodo/following{/other_user}","gists_url":"https://api.github.com/users/commodo/gists{/gist_id}","starred_url":"https://api.github.com/users/commodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commodo/subscriptions","organizations_url":"https://api.github.com/users/commodo/orgs","repos_url":"https://api.github.com/users/commodo/repos","events_url":"https://api.github.com/users/commodo/events{/privacy}","received_events_url":"https://api.github.com/users/commodo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-30T07:02:49Z","updated_at":"2016-03-30T08:07:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ocedo/mstpd/pulls/19","html_url":"https://github.com/ocedo/mstpd/pull/19","diff_url":"https://github.com/ocedo/mstpd/pull/19.diff","patch_url":"https://github.com/ocedo/mstpd/pull/19.patch"},"body":"We seem to be getting packets with MAC 01:80:c2:00:00:XX, where XX is\r\none of the other MACs in this list:\r\n http://www.ieee802.org/1/files/public/docs2007/admin-jeffree-standard-group-mac-address-assignments-0307.pdf\r\n\r\nIt could be that the bpf filter did not install properly\r\nin the packet.c module.\r\n\r\nMaybe this could confuse the internal state machine of mstpd.\r\nHowever, what we're seeing is mostly log spam.\r\n\r\nIn any case, mstpd's state machine should not run for packets\r\nother than the ones addressed to 01:80:c2:00:00:00.\r\n\r\nSo, the proper fix looks like turning on all checks in bridge_bpdu_rcv()\r\nto exit the call if some validation did not meet BPDU requirements.\r\n\r\nSigned-off-by: Alexandru Ardelean <aardelean@riverbed.com>"},"comment":{"url":"https://api.github.com/repos/ocedo/mstpd/issues/comments/203310141","html_url":"https://github.com/ocedo/mstpd/pull/19#issuecomment-203310141","issue_url":"https://api.github.com/repos/ocedo/mstpd/issues/19","id":203310141,"user":{"login":"commodo","id":2766732,"avatar_url":"https://avatars.githubusercontent.com/u/2766732?v=3","gravatar_id":"","url":"https://api.github.com/users/commodo","html_url":"https://github.com/commodo","followers_url":"https://api.github.com/users/commodo/followers","following_url":"https://api.github.com/users/commodo/following{/other_user}","gists_url":"https://api.github.com/users/commodo/gists{/gist_id}","starred_url":"https://api.github.com/users/commodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commodo/subscriptions","organizations_url":"https://api.github.com/users/commodo/orgs","repos_url":"https://api.github.com/users/commodo/repos","events_url":"https://api.github.com/users/commodo/events{/privacy}","received_events_url":"https://api.github.com/users/commodo/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T08:07:01Z","updated_at":"2016-03-30T08:07:01Z","body":"all good"}}