{"action":"created","issue":{"url":"https://api.github.com/repos/php-cache/integration-tests/issues/55","repository_url":"https://api.github.com/repos/php-cache/integration-tests","labels_url":"https://api.github.com/repos/php-cache/integration-tests/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/php-cache/integration-tests/issues/55/comments","events_url":"https://api.github.com/repos/php-cache/integration-tests/issues/55/events","html_url":"https://github.com/php-cache/integration-tests/pull/55","id":158949153,"number":55,"title":"Speedup tests with clock mock","user":{"login":"jakzal","id":190447,"avatar_url":"https://avatars.githubusercontent.com/u/190447?v=3","gravatar_id":"","url":"https://api.github.com/users/jakzal","html_url":"https://github.com/jakzal","followers_url":"https://api.github.com/users/jakzal/followers","following_url":"https://api.github.com/users/jakzal/following{/other_user}","gists_url":"https://api.github.com/users/jakzal/gists{/gist_id}","starred_url":"https://api.github.com/users/jakzal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakzal/subscriptions","organizations_url":"https://api.github.com/users/jakzal/orgs","repos_url":"https://api.github.com/users/jakzal/repos","events_url":"https://api.github.com/users/jakzal/events{/privacy}","received_events_url":"https://api.github.com/users/jakzal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-07T15:13:53Z","updated_at":"2016-06-10T07:14:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/php-cache/integration-tests/pulls/55","html_url":"https://github.com/php-cache/integration-tests/pull/55","diff_url":"https://github.com/php-cache/integration-tests/pull/55.diff","patch_url":"https://github.com/php-cache/integration-tests/pull/55.patch"},"body":"Replaces #49\r\n\r\nSince the class under test is in a different namespace than the test case, both need to be registered manually.\r\n\r\nNote that [one of your tests in php-cache/cache will still fail](https://github.com/php-cache/cache/blob/61e4d4939db308f506f143fa05350bc29f33b854/src/Adapter/Filesystem/Tests/FilesystemCachePoolTest.php#L31-L46) as it doesn't use the setup from tests cases here. That project needs to configure clockmock on its own."},"comment":{"url":"https://api.github.com/repos/php-cache/integration-tests/issues/comments/225110253","html_url":"https://github.com/php-cache/integration-tests/pull/55#issuecomment-225110253","issue_url":"https://api.github.com/repos/php-cache/integration-tests/issues/55","id":225110253,"user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T07:14:59Z","updated_at":"2016-06-10T07:14:59Z","body":"Thank you for this. But is seams like the testExpiration test [still fails](https://travis-ci.org/php-cache/cache/jobs/136619107). \r\n\r\nI cant seams to figure out why. The Symfony cache does also fail with this PR. \r\n\r\nI think the error is because: \r\n1) we save something to redis we say TTL=5\r\n2) we call sleep(10) which take no time since we mock the clock\r\n3) we ask redis if there is any value in the cache, and of course it is because redis does not know of the clock mock. "}}
{"actor":{"display_login":"Nyholm"}}