{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/70368229","id":70368229,"diff_hunk":"@@ -676,6 +676,10 @@ def audit_text\n     if text =~ /def plist/ && text !~ /plist_options/\n       problem \"Please set plist_options when using a formula-defined plist.\"\n     end\n+\n+    if text =~ %r{require \"language/go\"} && text !~ /go_resource/","path":"Library/Homebrew/cmd/audit.rb","position":5,"original_position":5,"commit_id":"e1ee58bf58c75f13a3f0969f461418dc87535595","original_commit_id":"a96dd751f2349a58dc04c6f6806f23b7eb2fbca8","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"It's 3am, so I could be in idiot mode. I probably am, to be fair. But `text.include?` is vomiting some errors for me in audit:\r\n```ruby\r\nif text.include?(\"def plist\") && !text.include?(\"plist_options\")\r\n  problem \"Please set plist_options when using a formula-defined plist.\"\r\nend\r\n```\r\n```\r\n~> brew audit a2ps\r\nError: undefined method `include?' for #<FormulaText:0x007ff6a21512d8>\r\nPlease report this bug:\r\n    https://git.io/brew-troubleshooting\r\n/usr/local/Library/Homebrew/cmd/audit.rb:682:in `audit_text'\r\n/usr/local/Library/Homebrew/cmd/audit.rb:1006:in `audit'\r\n/usr/local/Library/Homebrew/cmd/audit.rb:69:in `block in audit'\r\n/usr/local/Library/Homebrew/cmd/audit.rb:65:in `each'\r\n/usr/local/Library/Homebrew/cmd/audit.rb:65:in `audit'\r\n/usr/local/Library/brew.rb:87:in `<main>'\r\n```\r\n\r\nIt works outside of `audit` though if I drop into `brew irb`:\r\n```ruby\r\ntext = \"blob\"\r\ntext.include?(\"blob\") && !text.include?(\"blos\")\r\n=> true\r\n```\r\n\r\nIn which way am I missing something obvious here?","created_at":"2016-07-12T02:14:27Z","updated_at":"2016-07-12T02:14:27Z","html_url":"https://github.com/Homebrew/brew/pull/488#discussion_r70368229","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/488","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/70368229"},"html":{"href":"https://github.com/Homebrew/brew/pull/488#discussion_r70368229"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/488"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/488","id":76873159,"html_url":"https://github.com/Homebrew/brew/pull/488","diff_url":"https://github.com/Homebrew/brew/pull/488.diff","patch_url":"https://github.com/Homebrew/brew/pull/488.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/488","number":488,"state":"closed","locked":false,"title":"Go Language Tweaks.","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nI'm so tired of having to catch this stuff in post or us leaving it there forever because nobody sees or bothers to not ignore the existing `oppo` warning.\r\n\r\nLet's punch harder on the empty arrays when `HOMEBREW_DEVELOPER` is set so we can start killing code that isn't necessary. User impact should be limited given the `HOMEBREW_DEVELOPER` couching, mostly means we can catch this with CI more than anything.\r\n\r\nYou only need to use `require \"language/go` if you're using `go_resource`s, which we'll be doing less & less over time as upstream pressure to adopt the vendor system comes to bear. That is the _only_ purpose of the Go language module in Homebrew. Let's insert an `audit` warning about using `require \"language/go` unnecessarily.","created_at":"2016-07-10T13:22:27Z","updated_at":"2016-07-12T02:14:27Z","closed_at":"2016-07-10T20:27:23Z","merged_at":null,"merge_commit_sha":"b6d02658bd5129a421169c667c18d6cc43b3ce56","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/488/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/488/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/488/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/e1ee58bf58c75f13a3f0969f461418dc87535595","head":{"label":"DomT4:go_sigh","ref":"go_sigh","sha":"e1ee58bf58c75f13a3f0969f461418dc87535595","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"repo":{"id":55303613,"name":"brew","full_name":"DomT4/brew","owner":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DomT4/brew","description":":beer: The missing package manager for OS X [Experimental]","fork":true,"url":"https://api.github.com/repos/DomT4/brew","forks_url":"https://api.github.com/repos/DomT4/brew/forks","keys_url":"https://api.github.com/repos/DomT4/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DomT4/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DomT4/brew/teams","hooks_url":"https://api.github.com/repos/DomT4/brew/hooks","issue_events_url":"https://api.github.com/repos/DomT4/brew/issues/events{/number}","events_url":"https://api.github.com/repos/DomT4/brew/events","assignees_url":"https://api.github.com/repos/DomT4/brew/assignees{/user}","branches_url":"https://api.github.com/repos/DomT4/brew/branches{/branch}","tags_url":"https://api.github.com/repos/DomT4/brew/tags","blobs_url":"https://api.github.com/repos/DomT4/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DomT4/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DomT4/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/DomT4/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DomT4/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/DomT4/brew/languages","stargazers_url":"https://api.github.com/repos/DomT4/brew/stargazers","contributors_url":"https://api.github.com/repos/DomT4/brew/contributors","subscribers_url":"https://api.github.com/repos/DomT4/brew/subscribers","subscription_url":"https://api.github.com/repos/DomT4/brew/subscription","commits_url":"https://api.github.com/repos/DomT4/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/DomT4/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/DomT4/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/DomT4/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/DomT4/brew/contents/{+path}","compare_url":"https://api.github.com/repos/DomT4/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DomT4/brew/merges","archive_url":"https://api.github.com/repos/DomT4/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DomT4/brew/downloads","issues_url":"https://api.github.com/repos/DomT4/brew/issues{/number}","pulls_url":"https://api.github.com/repos/DomT4/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/DomT4/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/DomT4/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DomT4/brew/labels{/name}","releases_url":"https://api.github.com/repos/DomT4/brew/releases{/id}","deployments_url":"https://api.github.com/repos/DomT4/brew/deployments","created_at":"2016-04-02T16:09:20Z","updated_at":"2016-04-02T16:09:21Z","pushed_at":"2016-07-10T20:30:31Z","git_url":"git://github.com/DomT4/brew.git","ssh_url":"git@github.com:DomT4/brew.git","clone_url":"https://github.com/DomT4/brew.git","svn_url":"https://github.com/DomT4/brew","homepage":null,"size":10236,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"ecc329e33fe7c4ebacb9965aae61ad6a9e332983","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":":beer: The missing package manager for OS X","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2016-07-12T01:24:10Z","pushed_at":"2016-07-12T00:14:11Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"http://brew.sh","size":10684,"stargazers_count":1923,"watchers_count":1923,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":562,"mirror_url":null,"open_issues_count":54,"forks":562,"open_issues":54,"watchers":1923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/488"},"html":{"href":"https://github.com/Homebrew/brew/pull/488"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/488"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/e1ee58bf58c75f13a3f0969f461418dc87535595"}}}}
{"actor":{"display_login":"DomT4"}}