{"action":"closed","issue":{"url":"https://api.github.com/repos/SCOREC/core/issues/54","repository_url":"https://api.github.com/repos/SCOREC/core","labels_url":"https://api.github.com/repos/SCOREC/core/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/SCOREC/core/issues/54/comments","events_url":"https://api.github.com/repos/SCOREC/core/issues/54/events","html_url":"https://github.com/SCOREC/core/issues/54","id":187166979,"number":54,"title":"Add optional delete argument to apf::makeGlobal","user":{"login":"bgranzow","id":5702945,"avatar_url":"https://avatars.githubusercontent.com/u/5702945?v=3","gravatar_id":"","url":"https://api.github.com/users/bgranzow","html_url":"https://github.com/bgranzow","followers_url":"https://api.github.com/users/bgranzow/followers","following_url":"https://api.github.com/users/bgranzow/following{/other_user}","gists_url":"https://api.github.com/users/bgranzow/gists{/gist_id}","starred_url":"https://api.github.com/users/bgranzow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgranzow/subscriptions","organizations_url":"https://api.github.com/users/bgranzow/orgs","repos_url":"https://api.github.com/users/bgranzow/repos","events_url":"https://api.github.com/users/bgranzow/events{/privacy}","received_events_url":"https://api.github.com/users/bgranzow/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-03T19:27:18Z","updated_at":"2016-11-03T23:25:21Z","closed_at":"2016-11-03T23:25:21Z","body":"I would like to modify the function makeGlobal():\r\nhttps://github.com/SCOREC/core/blob/master/apf/apfNumbering.h#L195\r\n\r\nfrom\r\nGlobalNumbering* makeGlobal(Numbering* n);\r\n\r\nto\r\nGlobalNumbering* makeGlobal(Numbering* n, bool delete=true);\r\n\r\nwhere the delete argument specifies whether or not to delete the input Numbering*. The default value of delete=true would retain previous behavior.\r\n\r\nAny objections?"}}
{"actor":{"display_login":"bgranzow"}}