{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments/93644695","pull_request_review_id":14176802,"id":93644695,"diff_hunk":"@@ -349,6 +349,12 @@ function libvirt_do_setuplonelynodes()\n         local lonely_disk\n         lonely_disk=\"$vdisk_dir/${cloud}.node$i\"\n \n+        lvdisplay $lonely_disk\n+        if [ $? -ne 0 ]; then\n+            hdd_size=${lonelynode_hdd_size}\n+            _lvcreate ${cloud}.node$i $hdd_size $cloudvg","path":"scripts/lib/mkcloud-libvirt.sh","position":7,"original_position":7,"commit_id":"764dac8ad89030b289c87b7b79983ed71af88103","original_commit_id":"764dac8ad89030b289c87b7b79983ed71af88103","user":{"login":"bmwiedemann","id":637990,"avatar_url":"https://avatars.githubusercontent.com/u/637990?v=3","gravatar_id":"","url":"https://api.github.com/users/bmwiedemann","html_url":"https://github.com/bmwiedemann","followers_url":"https://api.github.com/users/bmwiedemann/followers","following_url":"https://api.github.com/users/bmwiedemann/following{/other_user}","gists_url":"https://api.github.com/users/bmwiedemann/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwiedemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwiedemann/subscriptions","organizations_url":"https://api.github.com/users/bmwiedemann/orgs","repos_url":"https://api.github.com/users/bmwiedemann/repos","events_url":"https://api.github.com/users/bmwiedemann/events{/privacy}","received_events_url":"https://api.github.com/users/bmwiedemann/received_events","type":"User","site_admin":false},"body":"it normally should have been created in the prepare step via libvirt_do_create_cloud_lvm\r\nbut this might still be useful to do here, when you want to add nodes later. Or we move it here altogether, so that volumes are not created before needed (same for normal cloud nodes)","created_at":"2016-12-22T15:41:39Z","updated_at":"2016-12-22T15:41:40Z","html_url":"https://github.com/SUSE-Cloud/automation/pull/1549#discussion_r93644695","pull_request_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1549","_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments/93644695"},"html":{"href":"https://github.com/SUSE-Cloud/automation/pull/1549#discussion_r93644695"},"pull_request":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1549"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1549","id":99093835,"html_url":"https://github.com/SUSE-Cloud/automation/pull/1549","diff_url":"https://github.com/SUSE-Cloud/automation/pull/1549.diff","patch_url":"https://github.com/SUSE-Cloud/automation/pull/1549.patch","issue_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1549","number":1549,"state":"open","locked":false,"title":"Create lonely node disk if does not exist already","user":{"login":"matrixik","id":201930,"avatar_url":"https://avatars.githubusercontent.com/u/201930?v=3","gravatar_id":"","url":"https://api.github.com/users/matrixik","html_url":"https://github.com/matrixik","followers_url":"https://api.github.com/users/matrixik/followers","following_url":"https://api.github.com/users/matrixik/following{/other_user}","gists_url":"https://api.github.com/users/matrixik/gists{/gist_id}","starred_url":"https://api.github.com/users/matrixik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrixik/subscriptions","organizations_url":"https://api.github.com/users/matrixik/orgs","repos_url":"https://api.github.com/users/matrixik/repos","events_url":"https://api.github.com/users/matrixik/events{/privacy}","received_events_url":"https://api.github.com/users/matrixik/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-22T12:05:40Z","updated_at":"2016-12-22T15:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9415a47d8382f6b469b796395fceb4e9959c2d1d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1549/commits","review_comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1549/comments","review_comment_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1549/comments","statuses_url":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/764dac8ad89030b289c87b7b79983ed71af88103","head":{"label":"matrixik:lonely-node-disk","ref":"lonely-node-disk","sha":"764dac8ad89030b289c87b7b79983ed71af88103","user":{"login":"matrixik","id":201930,"avatar_url":"https://avatars.githubusercontent.com/u/201930?v=3","gravatar_id":"","url":"https://api.github.com/users/matrixik","html_url":"https://github.com/matrixik","followers_url":"https://api.github.com/users/matrixik/followers","following_url":"https://api.github.com/users/matrixik/following{/other_user}","gists_url":"https://api.github.com/users/matrixik/gists{/gist_id}","starred_url":"https://api.github.com/users/matrixik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrixik/subscriptions","organizations_url":"https://api.github.com/users/matrixik/orgs","repos_url":"https://api.github.com/users/matrixik/repos","events_url":"https://api.github.com/users/matrixik/events{/privacy}","received_events_url":"https://api.github.com/users/matrixik/received_events","type":"User","site_admin":false},"repo":{"id":77140386,"name":"automation","full_name":"matrixik/automation","owner":{"login":"matrixik","id":201930,"avatar_url":"https://avatars.githubusercontent.com/u/201930?v=3","gravatar_id":"","url":"https://api.github.com/users/matrixik","html_url":"https://github.com/matrixik","followers_url":"https://api.github.com/users/matrixik/followers","following_url":"https://api.github.com/users/matrixik/following{/other_user}","gists_url":"https://api.github.com/users/matrixik/gists{/gist_id}","starred_url":"https://api.github.com/users/matrixik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrixik/subscriptions","organizations_url":"https://api.github.com/users/matrixik/orgs","repos_url":"https://api.github.com/users/matrixik/repos","events_url":"https://api.github.com/users/matrixik/events{/privacy}","received_events_url":"https://api.github.com/users/matrixik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matrixik/automation","description":"Automation scripts for development, testing, and CI","fork":true,"url":"https://api.github.com/repos/matrixik/automation","forks_url":"https://api.github.com/repos/matrixik/automation/forks","keys_url":"https://api.github.com/repos/matrixik/automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrixik/automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrixik/automation/teams","hooks_url":"https://api.github.com/repos/matrixik/automation/hooks","issue_events_url":"https://api.github.com/repos/matrixik/automation/issues/events{/number}","events_url":"https://api.github.com/repos/matrixik/automation/events","assignees_url":"https://api.github.com/repos/matrixik/automation/assignees{/user}","branches_url":"https://api.github.com/repos/matrixik/automation/branches{/branch}","tags_url":"https://api.github.com/repos/matrixik/automation/tags","blobs_url":"https://api.github.com/repos/matrixik/automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrixik/automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrixik/automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrixik/automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrixik/automation/statuses/{sha}","languages_url":"https://api.github.com/repos/matrixik/automation/languages","stargazers_url":"https://api.github.com/repos/matrixik/automation/stargazers","contributors_url":"https://api.github.com/repos/matrixik/automation/contributors","subscribers_url":"https://api.github.com/repos/matrixik/automation/subscribers","subscription_url":"https://api.github.com/repos/matrixik/automation/subscription","commits_url":"https://api.github.com/repos/matrixik/automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrixik/automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrixik/automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrixik/automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrixik/automation/contents/{+path}","compare_url":"https://api.github.com/repos/matrixik/automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrixik/automation/merges","archive_url":"https://api.github.com/repos/matrixik/automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrixik/automation/downloads","issues_url":"https://api.github.com/repos/matrixik/automation/issues{/number}","pulls_url":"https://api.github.com/repos/matrixik/automation/pulls{/number}","milestones_url":"https://api.github.com/repos/matrixik/automation/milestones{/number}","notifications_url":"https://api.github.com/repos/matrixik/automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrixik/automation/labels{/name}","releases_url":"https://api.github.com/repos/matrixik/automation/releases{/id}","deployments_url":"https://api.github.com/repos/matrixik/automation/deployments","created_at":"2016-12-22T11:49:56Z","updated_at":"2016-12-22T11:49:59Z","pushed_at":"2016-12-22T12:04:35Z","git_url":"git://github.com/matrixik/automation.git","ssh_url":"git@github.com:matrixik/automation.git","clone_url":"https://github.com/matrixik/automation.git","svn_url":"https://github.com/matrixik/automation","homepage":"","size":8885,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE-Cloud:master","ref":"master","sha":"023485961465536988b4ff5698204f44e047bd9f","user":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6384356,"name":"automation","full_name":"SUSE-Cloud/automation","owner":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE-Cloud/automation","description":"Automation scripts for development, testing, and CI","fork":false,"url":"https://api.github.com/repos/SUSE-Cloud/automation","forks_url":"https://api.github.com/repos/SUSE-Cloud/automation/forks","keys_url":"https://api.github.com/repos/SUSE-Cloud/automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE-Cloud/automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE-Cloud/automation/teams","hooks_url":"https://api.github.com/repos/SUSE-Cloud/automation/hooks","issue_events_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE-Cloud/automation/events","assignees_url":"https://api.github.com/repos/SUSE-Cloud/automation/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE-Cloud/automation/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE-Cloud/automation/tags","blobs_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE-Cloud/automation/languages","stargazers_url":"https://api.github.com/repos/SUSE-Cloud/automation/stargazers","contributors_url":"https://api.github.com/repos/SUSE-Cloud/automation/contributors","subscribers_url":"https://api.github.com/repos/SUSE-Cloud/automation/subscribers","subscription_url":"https://api.github.com/repos/SUSE-Cloud/automation/subscription","commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE-Cloud/automation/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE-Cloud/automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE-Cloud/automation/merges","archive_url":"https://api.github.com/repos/SUSE-Cloud/automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE-Cloud/automation/downloads","issues_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE-Cloud/automation/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE-Cloud/automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE-Cloud/automation/labels{/name}","releases_url":"https://api.github.com/repos/SUSE-Cloud/automation/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE-Cloud/automation/deployments","created_at":"2012-10-25T08:45:31Z","updated_at":"2016-12-09T07:19:31Z","pushed_at":"2016-12-22T14:00:13Z","git_url":"git://github.com/SUSE-Cloud/automation.git","ssh_url":"git@github.com:SUSE-Cloud/automation.git","clone_url":"https://github.com/SUSE-Cloud/automation.git","svn_url":"https://github.com/SUSE-Cloud/automation","homepage":"","size":8899,"stargazers_count":20,"watchers_count":20,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":32,"forks":66,"open_issues":32,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1549"},"html":{"href":"https://github.com/SUSE-Cloud/automation/pull/1549"},"issue":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1549"},"comments":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1549/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1549/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1549/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/764dac8ad89030b289c87b7b79983ed71af88103"}}}}
{"actor":{"display_login":"bmwiedemann"}}