{"action":"created","comment":{"url":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/comments/52723113","id":52723113,"diff_hunk":"@@ -83,28 +88,27 @@ public function getElementForTable($table, $uid, $overlay_ids = TRUE) {\n \t\t\t\t\tif (is_array($DS)) {\n \t\t\t\t\t\tif ($DS['meta']['langDisable'] == 1 && $DS['meta']['langDatabaseOverlay'] == 1) {\n \t\t\t\t\t\t\t\t// handle as special FCE with normal tt_content overlay:\n-\t\t\t\t\t\t\t$element = \\TYPO3\\CMS\\Core\\Utility\\GeneralUtility::makeInstance('tx_languagevisibility_fceoverlayelement', $row);\n+\t\t\t\t\t\t\t$element = GeneralUtility::makeInstance('AOE\\\\Languagevisibility\\\\FceOverlayElement', $row);\n \t\t\t\t\t\t} else {\n-\t\t\t\t\t\t\t$element = \\TYPO3\\CMS\\Core\\Utility\\GeneralUtility::makeInstance('tx_languagevisibility_fceelement', $row, $DS);\n+\t\t\t\t\t\t\t$element = GeneralUtility::makeInstance('AOE\\\\Languagevisibility\\\\FceElement', $row, $DS);\n \t\t\t\t\t\t}\n \t\t\t\t\t} else {\n-\t\t\t\t\t\tthrow new UnexpectedValueException($table . ' uid:' . $row['uid'] . ' has no valid Datastructure ', 1195039394);\n+\t\t\t\t\t\tthrow new \\UnexpectedValueException($table . ' uid:' . $row['uid'] . ' has no valid Datastructure ', 1195039394);\n \t\t\t\t\t}\n \t\t\t\t} else {\n-\t\t\t\t\t$element = \\TYPO3\\CMS\\Core\\Utility\\GeneralUtility::makeInstance('tx_languagevisibility_celement', $row, $table);\n+\t\t\t\t\t$element = GeneralUtility::makeInstance('AOE\\\\Languagevisibility\\\\CElement', $row, $table);\n \t\t\t\t}\n \t\t\t\tbreak;\n \t\t\tdefault:\n-\n \t\t\t\tif (isset ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['languagevisibility']['getElementForTable'][$table])) {\n-\t\t\t\t\t$hookObj = \\TYPO3\\CMS\\Core\\Utility\\GeneralUtility::getUserObj($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['languagevisibility']['getElementForTable'][$table]);\n+\t\t\t\t\t$hookObj = GeneralUtility::getUserObj($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['languagevisibility']['getElementForTable'][$table]);\n \t\t\t\t\tif (method_exists($hookObj, 'getElementForTable')) {\n \t\t\t\t\t\t$element = $hookObj->getElementForTable($table, $uid, $row, $overlay_ids);\n \t\t\t\t\t}\n \t\t\t\t} elseif (isset($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['languagevisibility']['recordElementSupportedTables'][$table])) {\n-\t\t\t\t\t$element = $this->getElementInstance('tx_languagevisibility_recordelement', $row, $table);\n+\t\t\t\t\t$element = $this->getElementInstance('\\\\AOE\\\\Languagevisibility\\\\RecordElement', $row, $table);","path":"Classes/ElementFactory.php","position":98,"original_position":98,"commit_id":"32b2da963fb40e94c777126d32f455924beaf2e4","original_commit_id":"32b2da963fb40e94c777126d32f455924beaf2e4","user":{"login":"srotsch","id":1445999,"avatar_url":"https://avatars.githubusercontent.com/u/1445999?v=3","gravatar_id":"","url":"https://api.github.com/users/srotsch","html_url":"https://github.com/srotsch","followers_url":"https://api.github.com/users/srotsch/followers","following_url":"https://api.github.com/users/srotsch/following{/other_user}","gists_url":"https://api.github.com/users/srotsch/gists{/gist_id}","starred_url":"https://api.github.com/users/srotsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srotsch/subscriptions","organizations_url":"https://api.github.com/users/srotsch/orgs","repos_url":"https://api.github.com/users/srotsch/repos","events_url":"https://api.github.com/users/srotsch/events{/privacy}","received_events_url":"https://api.github.com/users/srotsch/received_events","type":"User","site_admin":false},"body":"AOE\\\\Languagevisibility\\\\RecordElement","created_at":"2016-02-12T10:03:36Z","updated_at":"2016-02-12T10:03:36Z","html_url":"https://github.com/AOEpeople/languagevisibility/pull/34#discussion_r52723113","pull_request_url":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/comments/52723113"},"html":{"href":"https://github.com/AOEpeople/languagevisibility/pull/34#discussion_r52723113"},"pull_request":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/34","id":59035824,"html_url":"https://github.com/AOEpeople/languagevisibility/pull/34","diff_url":"https://github.com/AOEpeople/languagevisibility/pull/34.diff","patch_url":"https://github.com/AOEpeople/languagevisibility/pull/34.patch","issue_url":"https://api.github.com/repos/AOEpeople/languagevisibility/issues/34","number":34,"state":"open","locked":false,"title":"[TASK] #79769 Make 7LTS Compatible","user":{"login":"tomasnorre","id":1212481,"avatar_url":"https://avatars.githubusercontent.com/u/1212481?v=3","gravatar_id":"","url":"https://api.github.com/users/tomasnorre","html_url":"https://github.com/tomasnorre","followers_url":"https://api.github.com/users/tomasnorre/followers","following_url":"https://api.github.com/users/tomasnorre/following{/other_user}","gists_url":"https://api.github.com/users/tomasnorre/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasnorre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasnorre/subscriptions","organizations_url":"https://api.github.com/users/tomasnorre/orgs","repos_url":"https://api.github.com/users/tomasnorre/repos","events_url":"https://api.github.com/users/tomasnorre/events{/privacy}","received_events_url":"https://api.github.com/users/tomasnorre/received_events","type":"User","site_admin":false},"body":"Resolves #26 + makes it 7LTS compatible","created_at":"2016-02-11T14:15:28Z","updated_at":"2016-02-12T10:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8845d4ebb609b70ffda7f7d1dfd75d69425897e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/34/commits","review_comments_url":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/34/comments","review_comment_url":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AOEpeople/languagevisibility/issues/34/comments","statuses_url":"https://api.github.com/repos/AOEpeople/languagevisibility/statuses/32b2da963fb40e94c777126d32f455924beaf2e4","head":{"label":"AOEpeople:7LTS_compatible","ref":"7LTS_compatible","sha":"32b2da963fb40e94c777126d32f455924beaf2e4","user":{"login":"AOEpeople","id":6331769,"avatar_url":"https://avatars.githubusercontent.com/u/6331769?v=3","gravatar_id":"","url":"https://api.github.com/users/AOEpeople","html_url":"https://github.com/AOEpeople","followers_url":"https://api.github.com/users/AOEpeople/followers","following_url":"https://api.github.com/users/AOEpeople/following{/other_user}","gists_url":"https://api.github.com/users/AOEpeople/gists{/gist_id}","starred_url":"https://api.github.com/users/AOEpeople/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AOEpeople/subscriptions","organizations_url":"https://api.github.com/users/AOEpeople/orgs","repos_url":"https://api.github.com/users/AOEpeople/repos","events_url":"https://api.github.com/users/AOEpeople/events{/privacy}","received_events_url":"https://api.github.com/users/AOEpeople/received_events","type":"Organization","site_admin":false},"repo":{"id":25632820,"name":"languagevisibility","full_name":"AOEpeople/languagevisibility","owner":{"login":"AOEpeople","id":6331769,"avatar_url":"https://avatars.githubusercontent.com/u/6331769?v=3","gravatar_id":"","url":"https://api.github.com/users/AOEpeople","html_url":"https://github.com/AOEpeople","followers_url":"https://api.github.com/users/AOEpeople/followers","following_url":"https://api.github.com/users/AOEpeople/following{/other_user}","gists_url":"https://api.github.com/users/AOEpeople/gists{/gist_id}","starred_url":"https://api.github.com/users/AOEpeople/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AOEpeople/subscriptions","organizations_url":"https://api.github.com/users/AOEpeople/orgs","repos_url":"https://api.github.com/users/AOEpeople/repos","events_url":"https://api.github.com/users/AOEpeople/events{/privacy}","received_events_url":"https://api.github.com/users/AOEpeople/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AOEpeople/languagevisibility","description":"Multi level language fallback for TYPO3 projects","fork":false,"url":"https://api.github.com/repos/AOEpeople/languagevisibility","forks_url":"https://api.github.com/repos/AOEpeople/languagevisibility/forks","keys_url":"https://api.github.com/repos/AOEpeople/languagevisibility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AOEpeople/languagevisibility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AOEpeople/languagevisibility/teams","hooks_url":"https://api.github.com/repos/AOEpeople/languagevisibility/hooks","issue_events_url":"https://api.github.com/repos/AOEpeople/languagevisibility/issues/events{/number}","events_url":"https://api.github.com/repos/AOEpeople/languagevisibility/events","assignees_url":"https://api.github.com/repos/AOEpeople/languagevisibility/assignees{/user}","branches_url":"https://api.github.com/repos/AOEpeople/languagevisibility/branches{/branch}","tags_url":"https://api.github.com/repos/AOEpeople/languagevisibility/tags","blobs_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/refs{/sha}","trees_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AOEpeople/languagevisibility/statuses/{sha}","languages_url":"https://api.github.com/repos/AOEpeople/languagevisibility/languages","stargazers_url":"https://api.github.com/repos/AOEpeople/languagevisibility/stargazers","contributors_url":"https://api.github.com/repos/AOEpeople/languagevisibility/contributors","subscribers_url":"https://api.github.com/repos/AOEpeople/languagevisibility/subscribers","subscription_url":"https://api.github.com/repos/AOEpeople/languagevisibility/subscription","commits_url":"https://api.github.com/repos/AOEpeople/languagevisibility/commits{/sha}","git_commits_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/commits{/sha}","comments_url":"https://api.github.com/repos/AOEpeople/languagevisibility/comments{/number}","issue_comment_url":"https://api.github.com/repos/AOEpeople/languagevisibility/issues/comments{/number}","contents_url":"https://api.github.com/repos/AOEpeople/languagevisibility/contents/{+path}","compare_url":"https://api.github.com/repos/AOEpeople/languagevisibility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AOEpeople/languagevisibility/merges","archive_url":"https://api.github.com/repos/AOEpeople/languagevisibility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AOEpeople/languagevisibility/downloads","issues_url":"https://api.github.com/repos/AOEpeople/languagevisibility/issues{/number}","pulls_url":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls{/number}","milestones_url":"https://api.github.com/repos/AOEpeople/languagevisibility/milestones{/number}","notifications_url":"https://api.github.com/repos/AOEpeople/languagevisibility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AOEpeople/languagevisibility/labels{/name}","releases_url":"https://api.github.com/repos/AOEpeople/languagevisibility/releases{/id}","deployments_url":"https://api.github.com/repos/AOEpeople/languagevisibility/deployments","created_at":"2014-10-23T11:05:27Z","updated_at":"2015-09-05T09:07:10Z","pushed_at":"2016-02-12T09:45:34Z","git_url":"git://github.com/AOEpeople/languagevisibility.git","ssh_url":"git@github.com:AOEpeople/languagevisibility.git","clone_url":"https://github.com/AOEpeople/languagevisibility.git","svn_url":"https://github.com/AOEpeople/languagevisibility","homepage":"","size":884,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"AOEpeople:master","ref":"master","sha":"c9ea4dd2a0969a4ed2a34d31d3631d0047e1bcda","user":{"login":"AOEpeople","id":6331769,"avatar_url":"https://avatars.githubusercontent.com/u/6331769?v=3","gravatar_id":"","url":"https://api.github.com/users/AOEpeople","html_url":"https://github.com/AOEpeople","followers_url":"https://api.github.com/users/AOEpeople/followers","following_url":"https://api.github.com/users/AOEpeople/following{/other_user}","gists_url":"https://api.github.com/users/AOEpeople/gists{/gist_id}","starred_url":"https://api.github.com/users/AOEpeople/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AOEpeople/subscriptions","organizations_url":"https://api.github.com/users/AOEpeople/orgs","repos_url":"https://api.github.com/users/AOEpeople/repos","events_url":"https://api.github.com/users/AOEpeople/events{/privacy}","received_events_url":"https://api.github.com/users/AOEpeople/received_events","type":"Organization","site_admin":false},"repo":{"id":25632820,"name":"languagevisibility","full_name":"AOEpeople/languagevisibility","owner":{"login":"AOEpeople","id":6331769,"avatar_url":"https://avatars.githubusercontent.com/u/6331769?v=3","gravatar_id":"","url":"https://api.github.com/users/AOEpeople","html_url":"https://github.com/AOEpeople","followers_url":"https://api.github.com/users/AOEpeople/followers","following_url":"https://api.github.com/users/AOEpeople/following{/other_user}","gists_url":"https://api.github.com/users/AOEpeople/gists{/gist_id}","starred_url":"https://api.github.com/users/AOEpeople/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AOEpeople/subscriptions","organizations_url":"https://api.github.com/users/AOEpeople/orgs","repos_url":"https://api.github.com/users/AOEpeople/repos","events_url":"https://api.github.com/users/AOEpeople/events{/privacy}","received_events_url":"https://api.github.com/users/AOEpeople/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AOEpeople/languagevisibility","description":"Multi level language fallback for TYPO3 projects","fork":false,"url":"https://api.github.com/repos/AOEpeople/languagevisibility","forks_url":"https://api.github.com/repos/AOEpeople/languagevisibility/forks","keys_url":"https://api.github.com/repos/AOEpeople/languagevisibility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AOEpeople/languagevisibility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AOEpeople/languagevisibility/teams","hooks_url":"https://api.github.com/repos/AOEpeople/languagevisibility/hooks","issue_events_url":"https://api.github.com/repos/AOEpeople/languagevisibility/issues/events{/number}","events_url":"https://api.github.com/repos/AOEpeople/languagevisibility/events","assignees_url":"https://api.github.com/repos/AOEpeople/languagevisibility/assignees{/user}","branches_url":"https://api.github.com/repos/AOEpeople/languagevisibility/branches{/branch}","tags_url":"https://api.github.com/repos/AOEpeople/languagevisibility/tags","blobs_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/refs{/sha}","trees_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AOEpeople/languagevisibility/statuses/{sha}","languages_url":"https://api.github.com/repos/AOEpeople/languagevisibility/languages","stargazers_url":"https://api.github.com/repos/AOEpeople/languagevisibility/stargazers","contributors_url":"https://api.github.com/repos/AOEpeople/languagevisibility/contributors","subscribers_url":"https://api.github.com/repos/AOEpeople/languagevisibility/subscribers","subscription_url":"https://api.github.com/repos/AOEpeople/languagevisibility/subscription","commits_url":"https://api.github.com/repos/AOEpeople/languagevisibility/commits{/sha}","git_commits_url":"https://api.github.com/repos/AOEpeople/languagevisibility/git/commits{/sha}","comments_url":"https://api.github.com/repos/AOEpeople/languagevisibility/comments{/number}","issue_comment_url":"https://api.github.com/repos/AOEpeople/languagevisibility/issues/comments{/number}","contents_url":"https://api.github.com/repos/AOEpeople/languagevisibility/contents/{+path}","compare_url":"https://api.github.com/repos/AOEpeople/languagevisibility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AOEpeople/languagevisibility/merges","archive_url":"https://api.github.com/repos/AOEpeople/languagevisibility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AOEpeople/languagevisibility/downloads","issues_url":"https://api.github.com/repos/AOEpeople/languagevisibility/issues{/number}","pulls_url":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls{/number}","milestones_url":"https://api.github.com/repos/AOEpeople/languagevisibility/milestones{/number}","notifications_url":"https://api.github.com/repos/AOEpeople/languagevisibility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AOEpeople/languagevisibility/labels{/name}","releases_url":"https://api.github.com/repos/AOEpeople/languagevisibility/releases{/id}","deployments_url":"https://api.github.com/repos/AOEpeople/languagevisibility/deployments","created_at":"2014-10-23T11:05:27Z","updated_at":"2015-09-05T09:07:10Z","pushed_at":"2016-02-12T09:45:34Z","git_url":"git://github.com/AOEpeople/languagevisibility.git","ssh_url":"git@github.com:AOEpeople/languagevisibility.git","clone_url":"https://github.com/AOEpeople/languagevisibility.git","svn_url":"https://github.com/AOEpeople/languagevisibility","homepage":"","size":884,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/34"},"html":{"href":"https://github.com/AOEpeople/languagevisibility/pull/34"},"issue":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/issues/34"},"comments":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/AOEpeople/languagevisibility/statuses/32b2da963fb40e94c777126d32f455924beaf2e4"}}}}