{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments/85028408","pull_request_review_id":5768750,"id":85028408,"diff_hunk":"@@ -67,7 +67,7 @@ export interface AjaxCreationMethod {\n   post(url: string, body?: any, headers?: Object): Observable<AjaxResponse>;\n   put(url: string, body?: any, headers?: Object): Observable<AjaxResponse>;\n   delete(url: string, headers?: Object): Observable<AjaxResponse>;\n-  getJSON<T, R>(url: string, headers?: Object): Observable<R>;\n+  getJSON<R>(url: string, headers?: Object): Observable<R>;","path":"src/observable/dom/AjaxObservable.ts","position":5,"original_position":5,"commit_id":"af37b131072d0b661898eb89a2db4f8bcc22b4b7","original_commit_id":"af37b131072d0b661898eb89a2db4f8bcc22b4b7","user":{"login":"blesh","id":1540597,"avatar_url":"https://avatars.githubusercontent.com/u/1540597?v=3","gravatar_id":"","url":"https://api.github.com/users/blesh","html_url":"https://github.com/blesh","followers_url":"https://api.github.com/users/blesh/followers","following_url":"https://api.github.com/users/blesh/following{/other_user}","gists_url":"https://api.github.com/users/blesh/gists{/gist_id}","starred_url":"https://api.github.com/users/blesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blesh/subscriptions","organizations_url":"https://api.github.com/users/blesh/orgs","repos_url":"https://api.github.com/users/blesh/repos","events_url":"https://api.github.com/users/blesh/events{/privacy}","received_events_url":"https://api.github.com/users/blesh/received_events","type":"User","site_admin":false},"body":"should probably just be `T`... that's what we do everywhere else.","created_at":"2016-10-26T00:10:17Z","updated_at":"2016-10-26T00:10:26Z","html_url":"https://github.com/ReactiveX/rxjs/pull/2069#discussion_r85028408","pull_request_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2069","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments/85028408"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/2069#discussion_r85028408"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2069"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2069","id":90764093,"html_url":"https://github.com/ReactiveX/rxjs/pull/2069","diff_url":"https://github.com/ReactiveX/rxjs/pull/2069.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/2069.patch","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2069","number":2069,"state":"open","locked":false,"title":"refactor(AjaxObservable): remove needles type param T from AjaxObservable.getJSON()","user":{"login":"saneyuki","id":180104,"avatar_url":"https://avatars.githubusercontent.com/u/180104?v=3","gravatar_id":"","url":"https://api.github.com/users/saneyuki","html_url":"https://github.com/saneyuki","followers_url":"https://api.github.com/users/saneyuki/followers","following_url":"https://api.github.com/users/saneyuki/following{/other_user}","gists_url":"https://api.github.com/users/saneyuki/gists{/gist_id}","starred_url":"https://api.github.com/users/saneyuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneyuki/subscriptions","organizations_url":"https://api.github.com/users/saneyuki/orgs","repos_url":"https://api.github.com/users/saneyuki/repos","events_url":"https://api.github.com/users/saneyuki/events{/privacy}","received_events_url":"https://api.github.com/users/saneyuki/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you very much for your pull request!\r\n\r\nIf your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:\r\n\r\n- [ ] Add the operator to Rx\r\n- [ ] It must have a `-spec.ts` tests file covering the canonical corner cases, with marble diagram tests\r\n- [ ] If possible, write a `asDiagram` test case too, for PNG diagram generation purposes\r\n- [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases\r\n- [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image\r\n- [ ] The operator should be listed in `doc/operators.md` in a category of operators\r\n- [ ] It should also be inserted in the operator decision tree file `doc/decision-tree-widget/tree.yml`\r\n- [ ] You may need to update `MIGRATION.md` if the operator differs from the corresponding one in RxJS v4\r\n-->\r\n\r\n**Description:**\r\n\r\nBREAKING CHANGE: \r\n\r\n- Remove the unused type parameter `T`\r\n  - By this change, the user does not have to specify needless type parameter.\r\n\r\n**Related issue (if exists):**\r\n\r\n","created_at":"2016-10-25T08:51:43Z","updated_at":"2016-10-26T00:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcba056a30219ca4270053d8848f4b9c40f01844","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2069/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2069/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2069/comments","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/af37b131072d0b661898eb89a2db4f8bcc22b4b7","head":{"label":"saneyuki:unused-type-param-of-AjaxObservable","ref":"unused-type-param-of-AjaxObservable","sha":"af37b131072d0b661898eb89a2db4f8bcc22b4b7","user":{"login":"saneyuki","id":180104,"avatar_url":"https://avatars.githubusercontent.com/u/180104?v=3","gravatar_id":"","url":"https://api.github.com/users/saneyuki","html_url":"https://github.com/saneyuki","followers_url":"https://api.github.com/users/saneyuki/followers","following_url":"https://api.github.com/users/saneyuki/following{/other_user}","gists_url":"https://api.github.com/users/saneyuki/gists{/gist_id}","starred_url":"https://api.github.com/users/saneyuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneyuki/subscriptions","organizations_url":"https://api.github.com/users/saneyuki/orgs","repos_url":"https://api.github.com/users/saneyuki/repos","events_url":"https://api.github.com/users/saneyuki/events{/privacy}","received_events_url":"https://api.github.com/users/saneyuki/received_events","type":"User","site_admin":false},"repo":{"id":63222078,"name":"rxjs","full_name":"saneyuki/rxjs","owner":{"login":"saneyuki","id":180104,"avatar_url":"https://avatars.githubusercontent.com/u/180104?v=3","gravatar_id":"","url":"https://api.github.com/users/saneyuki","html_url":"https://github.com/saneyuki","followers_url":"https://api.github.com/users/saneyuki/followers","following_url":"https://api.github.com/users/saneyuki/following{/other_user}","gists_url":"https://api.github.com/users/saneyuki/gists{/gist_id}","starred_url":"https://api.github.com/users/saneyuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneyuki/subscriptions","organizations_url":"https://api.github.com/users/saneyuki/orgs","repos_url":"https://api.github.com/users/saneyuki/repos","events_url":"https://api.github.com/users/saneyuki/events{/privacy}","received_events_url":"https://api.github.com/users/saneyuki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saneyuki/rxjs","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/saneyuki/rxjs","forks_url":"https://api.github.com/repos/saneyuki/rxjs/forks","keys_url":"https://api.github.com/repos/saneyuki/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saneyuki/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saneyuki/rxjs/teams","hooks_url":"https://api.github.com/repos/saneyuki/rxjs/hooks","issue_events_url":"https://api.github.com/repos/saneyuki/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/saneyuki/rxjs/events","assignees_url":"https://api.github.com/repos/saneyuki/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/saneyuki/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/saneyuki/rxjs/tags","blobs_url":"https://api.github.com/repos/saneyuki/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saneyuki/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saneyuki/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/saneyuki/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saneyuki/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/saneyuki/rxjs/languages","stargazers_url":"https://api.github.com/repos/saneyuki/rxjs/stargazers","contributors_url":"https://api.github.com/repos/saneyuki/rxjs/contributors","subscribers_url":"https://api.github.com/repos/saneyuki/rxjs/subscribers","subscription_url":"https://api.github.com/repos/saneyuki/rxjs/subscription","commits_url":"https://api.github.com/repos/saneyuki/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/saneyuki/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/saneyuki/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/saneyuki/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/saneyuki/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/saneyuki/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saneyuki/rxjs/merges","archive_url":"https://api.github.com/repos/saneyuki/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saneyuki/rxjs/downloads","issues_url":"https://api.github.com/repos/saneyuki/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/saneyuki/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/saneyuki/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/saneyuki/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saneyuki/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/saneyuki/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/saneyuki/rxjs/deployments","created_at":"2016-07-13T06:53:24Z","updated_at":"2016-07-13T06:53:55Z","pushed_at":"2016-10-25T20:40:22Z","git_url":"git://github.com/saneyuki/rxjs.git","ssh_url":"git@github.com:saneyuki/rxjs.git","clone_url":"https://github.com/saneyuki/rxjs.git","svn_url":"https://github.com/saneyuki/rxjs","homepage":"http://reactivex.io/rxjs","size":47282,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:master","ref":"master","sha":"260d335f497a2de223b164ea9705699e7f306d7d","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"name":"rxjs","full_name":"ReactiveX/rxjs","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/rxjs","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/rxjs","forks_url":"https://api.github.com/repos/ReactiveX/rxjs/forks","keys_url":"https://api.github.com/repos/ReactiveX/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/rxjs/teams","hooks_url":"https://api.github.com/repos/ReactiveX/rxjs/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/rxjs/events","assignees_url":"https://api.github.com/repos/ReactiveX/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/rxjs/tags","blobs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/rxjs/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/rxjs/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/rxjs/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/rxjs/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/rxjs/subscription","commits_url":"https://api.github.com/repos/ReactiveX/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/rxjs/merges","archive_url":"https://api.github.com/repos/ReactiveX/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/rxjs/downloads","issues_url":"https://api.github.com/repos/ReactiveX/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/rxjs/deployments","created_at":"2015-03-15T06:17:10Z","updated_at":"2016-10-25T21:53:47Z","pushed_at":"2016-10-25T23:41:57Z","git_url":"git://github.com/ReactiveX/rxjs.git","ssh_url":"git@github.com:ReactiveX/rxjs.git","clone_url":"https://github.com/ReactiveX/rxjs.git","svn_url":"https://github.com/ReactiveX/rxjs","homepage":"http://reactivex.io/rxjs","size":48543,"stargazers_count":3581,"watchers_count":3581,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":331,"mirror_url":null,"open_issues_count":142,"forks":331,"open_issues":142,"watchers":3581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2069"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/2069"},"issue":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/2069"},"comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/2069/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2069/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2069/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/rxjs/statuses/af37b131072d0b661898eb89a2db4f8bcc22b4b7"}}}}
{"actor":{"display_login":"blesh"}}