{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/94143130","pull_request_review_id":14673720,"id":94143130,"diff_hunk":"@@ -44,24 +45,32 @@ def odie(error)\n   exit 1\n end\n \n-def odeprecated(method, replacement = nil, options = {})\n-  verb = if options[:die]\n-    \"disabled\"\n-  else\n-    \"deprecated\"\n-  end\n-\n+def odeprecated(method, replacement = nil, disable: false, disable_on: nil, caller: send(:caller))\n   replacement_message = if replacement\n     \"Use #{replacement} instead.\"\n   else\n     \"There is no replacement.\"\n   end\n \n+  unless disable_on.nil?\n+    if disable_on > Time.now\n+      will_be_disabled_message = \" and will be disabled on #{disable_on.strftime(\"%B %-d, %Y\")}\"\n+    else\n+      disable = true\n+    end\n+  end\n+\n+  verb = if disable\n+    \"disabled\"\n+  else\n+    \"deprecated\".concat(will_be_disabled_message.to_s)","path":"Library/Homebrew/utils.rb","position":37,"original_position":37,"commit_id":"bd64507f74dde13e160a693d7e9678692c8edd2d","original_commit_id":"bd64507f74dde13e160a693d7e9678692c8edd2d","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"body":"Just interpolate this I think.","created_at":"2016-12-29T14:51:44Z","updated_at":"2016-12-29T14:51:51Z","html_url":"https://github.com/Homebrew/brew/pull/1690#discussion_r94143130","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/1690","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/94143130"},"html":{"href":"https://github.com/Homebrew/brew/pull/1690#discussion_r94143130"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1690"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/1690","id":98383794,"html_url":"https://github.com/Homebrew/brew/pull/1690","diff_url":"https://github.com/Homebrew/brew/pull/1690.diff","patch_url":"https://github.com/Homebrew/brew/pull/1690.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/1690","number":1690,"state":"open","locked":false,"title":"Deprecate `brew cask update`.","user":{"login":"reitermarkus","id":1309829,"avatar_url":"https://avatars.githubusercontent.com/u/1309829?v=3","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nIn addition to deprecating `brew cask update` I also added a new option to `odeprecated` which allows us to specify a date after which a given method will be disabled.\r\n\r\n---\r\n\r\nCloses https://github.com/caskroom/homebrew-cask/issues/26921.","created_at":"2016-12-16T18:46:57Z","updated_at":"2016-12-29T14:51:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81650eeda21097c0ae8521677f939116c12a997c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/1690/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/1690/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/1690/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/bd64507f74dde13e160a693d7e9678692c8edd2d","head":{"label":"reitermarkus:brew-cask-update","ref":"brew-cask-update","sha":"bd64507f74dde13e160a693d7e9678692c8edd2d","user":{"login":"reitermarkus","id":1309829,"avatar_url":"https://avatars.githubusercontent.com/u/1309829?v=3","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"repo":{"id":63458821,"name":"brew","full_name":"reitermarkus/brew","owner":{"login":"reitermarkus","id":1309829,"avatar_url":"https://avatars.githubusercontent.com/u/1309829?v=3","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reitermarkus/brew","description":":beer: The missing package manager for OS X","fork":true,"url":"https://api.github.com/repos/reitermarkus/brew","forks_url":"https://api.github.com/repos/reitermarkus/brew/forks","keys_url":"https://api.github.com/repos/reitermarkus/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reitermarkus/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reitermarkus/brew/teams","hooks_url":"https://api.github.com/repos/reitermarkus/brew/hooks","issue_events_url":"https://api.github.com/repos/reitermarkus/brew/issues/events{/number}","events_url":"https://api.github.com/repos/reitermarkus/brew/events","assignees_url":"https://api.github.com/repos/reitermarkus/brew/assignees{/user}","branches_url":"https://api.github.com/repos/reitermarkus/brew/branches{/branch}","tags_url":"https://api.github.com/repos/reitermarkus/brew/tags","blobs_url":"https://api.github.com/repos/reitermarkus/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reitermarkus/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reitermarkus/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/reitermarkus/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reitermarkus/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/reitermarkus/brew/languages","stargazers_url":"https://api.github.com/repos/reitermarkus/brew/stargazers","contributors_url":"https://api.github.com/repos/reitermarkus/brew/contributors","subscribers_url":"https://api.github.com/repos/reitermarkus/brew/subscribers","subscription_url":"https://api.github.com/repos/reitermarkus/brew/subscription","commits_url":"https://api.github.com/repos/reitermarkus/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/reitermarkus/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/reitermarkus/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/reitermarkus/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/reitermarkus/brew/contents/{+path}","compare_url":"https://api.github.com/repos/reitermarkus/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reitermarkus/brew/merges","archive_url":"https://api.github.com/repos/reitermarkus/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reitermarkus/brew/downloads","issues_url":"https://api.github.com/repos/reitermarkus/brew/issues{/number}","pulls_url":"https://api.github.com/repos/reitermarkus/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/reitermarkus/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/reitermarkus/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reitermarkus/brew/labels{/name}","releases_url":"https://api.github.com/repos/reitermarkus/brew/releases{/id}","deployments_url":"https://api.github.com/repos/reitermarkus/brew/deployments","created_at":"2016-07-16T00:59:33Z","updated_at":"2016-07-16T00:59:35Z","pushed_at":"2016-12-17T18:44:31Z","git_url":"git://github.com/reitermarkus/brew.git","ssh_url":"git@github.com:reitermarkus/brew.git","clone_url":"https://github.com/reitermarkus/brew.git","svn_url":"https://github.com/reitermarkus/brew","homepage":"http://brew.sh","size":18009,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"60d63965f2ea8e413002238fa7b12d206407a725","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":":beer: The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2016-12-29T13:50:24Z","pushed_at":"2016-12-29T14:44:12Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"http://brew.sh","size":18054,"stargazers_count":5407,"watchers_count":5407,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1477,"mirror_url":null,"open_issues_count":54,"forks":1477,"open_issues":54,"watchers":5407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1690"},"html":{"href":"https://github.com/Homebrew/brew/pull/1690"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/1690"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/1690/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1690/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1690/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/bd64507f74dde13e160a693d7e9678692c8edd2d"}}}}
{"actor":{"display_login":"MikeMcQuaid"}}