{"action":"closed","number":946,"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/946","id":94276916,"html_url":"https://github.com/Samsung/GearVRf/pull/946","diff_url":"https://github.com/Samsung/GearVRf/pull/946.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/946.patch","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/946","number":946,"state":"closed","locked":false,"title":"X3D Scripting to GVRMaterial, Lights, Transform","user":{"login":"mwitchwilliams","id":18128830,"avatar_url":"https://avatars.githubusercontent.com/u/18128830?v=3","gravatar_id":"","url":"https://api.github.com/users/mwitchwilliams","html_url":"https://github.com/mwitchwilliams","followers_url":"https://api.github.com/users/mwitchwilliams/followers","following_url":"https://api.github.com/users/mwitchwilliams/following{/other_user}","gists_url":"https://api.github.com/users/mwitchwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/mwitchwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwitchwilliams/subscriptions","organizations_url":"https://api.github.com/users/mwitchwilliams/orgs","repos_url":"https://api.github.com/users/mwitchwilliams/repos","events_url":"https://api.github.com/users/mwitchwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/mwitchwilliams/received_events","type":"User","site_admin":false},"body":"Squashed commit of the following:\r\n\r\ncommit c75346b35cc1e224edb9672c31622f5a1ec0bd3f\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Thu Nov 17 15:03:13 2016 -0800\r\n\r\n    Regresion tests, removed commented-out code and log commands.\r\n\r\ncommit 5fb1104d1519bce81b0c4a68e774e0a89b801375\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Wed Nov 16 11:25:20 2016 -0800\r\n\r\n    SFBool SFFloat added as variables initiated with new Scripts.\r\n    Near ready release for internal testing.  Next push will\r\n    have comments and log files removed.\r\n\r\ncommit 3d5fee7f04780f3593d610ced7a2a23db02541ec\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Tue Nov 15 16:24:53 2016 -0800\r\n\r\n    Implemented initialize() method, a method that constructs\r\n    X3D data types in SCRIPT and setting arguments to pass\r\n    to Mozilla Rhino.\r\n\r\ncommit 0ca17b2e2d4915952b5e2a298c9dbe9340d94771\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Mon Nov 14 16:37:01 2016 -0800\r\n\r\n    Fixed issue with rotations.  Validated demo's work with\r\n    constructing X3D data type objects in GearVRinitJavaScript.\r\n\r\ncommit 1ad6a5f090e8c13c9d882f570a49f85966fc81cc\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Fri Nov 11 16:19:54 2016 -0800\r\n\r\n    Moved ConvertVectorToQuaternion from X3Dobject to\r\n    AnimationInteractivityMgr so it can be shared.\r\n    Developing GearVRinitJavaScript function to be embedded\r\n    into the Script method to construct objects needed to\r\n    run Scripts.  Broke a few things.  Will fix Mon. Nov. 14\r\n\r\ncommit 88ef13f38b8730f3ef2aae0f3a5e36a7273335d3\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Wed Nov 9 16:08:00 2016 -0800\r\n\r\n    Added code for SFRotation\r\n\r\ncommit e050325c66508c6f6d0e14117edab3b20f2af22b\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Mon Nov 7 14:03:04 2016 -0800\r\n\r\n    New data structure for fields of Script Object.\r\n    Added SFloat and SFTime X3D data structures\r\n\r\ncommit 139e547317db5992837509bfd65cc02b86c010b7\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Fri Nov 4 16:24:54 2016 -0700\r\n\r\n    Script object fields now handle connections to\r\n    defined objects.  Thus, only one ScriptObject per\r\n    Script tags.\r\n\r\ncommit 2b936de7b3e617eba20f711237a12881e984f1c8\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Mon Oct 31 16:10:51 2016 -0700\r\n\r\n    Added initialize() method to Scripting, requiring some code\r\n    to be reorganized.  Added SFBool, modified other X3D data types.\r\n\r\ncommit 4f406d46f9b77729a6b49a1fb43c68a6d1c236e0\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Fri Oct 28 16:05:02 2016 -0700\r\n\r\n    Added SFVec3f and SFRotation X3D data type classes.\r\n    Supporting transformations through Script node.\r\n\r\ncommit 4907ac3c189908d3eb26818088ad3f6b03d616d3\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Thu Oct 27 16:38:09 2016 -0700\r\n\r\n    Script code fixes to allow multiple scripts in .x3d file\r\n    and Script to set multiple values.\r\n\r\ncommit 53f7e5ea9543213d0faad194659ad6d5a8699d9d\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Wed Oct 26 15:13:47 2016 -0700\r\n\r\n    Script changes multiple objects from a single script.\r\n\r\ncommit d36975faaec282a7102042fe5a49a47a31b1b123\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Tue Oct 25 16:02:54 2016 -0700\r\n\r\n    isOver and isActive working for an SFColor data type\r\n\r\ncommit 0f90d092b611c2679a2dfc00e7dc17a3d2b076dd\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Mon Oct 24 12:17:36 2016 -0700\r\n\r\n    Added public getBindings() to GVRScriptFile to view values passed to\r\n    and modified in the JavaScript file.\r\n\r\ncommit 98786012d657c0c528889bd8d3b7b795877baee2\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Fri Oct 21 16:30:29 2016 -0700\r\n\r\n    Work-in-progress added scripting to the AnimationManager.\r\n    Calling the script from AnimationManager upon TouchSensor.\r\n\r\ncommit d37e9d993460fac582b1836253e7266b49249c94\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Wed Oct 19 14:05:15 2016 -0700\r\n\r\n    Work-in-progress for X3D script node and calling Mozilla Rhino\r\n\r\ncommit e0e2d373c10f710056dda4d9a885808759932105\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Tue Oct 11 15:33:23 2016 -0700\r\n\r\n    Fix to enable ROUTE with TouchSensor to come before or after other ROUTEs\r\n    in this animation and interactivity.\r\n\r\ncommit b21e0faf727247b6114750a47cbc48fb555f3989\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Fri Oct 7 16:06:12 2016 -0700\r\n\r\n    Added the isOver functionality to BooleanToggle controlled by\r\n    a Touch Sensor.\r\n\r\ncommit 0d18349db8b5fd79efd922a200c138f7d3654c97\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Fri Oct 7 12:58:35 2016 -0700\r\n\r\n    Saving version of BooleanToggle that works for isOver events from\r\n    Touch Sensor\r\n\r\ncommit 4e989877dee6462f8ae3cad9bf4da504bfe1e445\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Thu Oct 6 11:50:37 2016 -0700\r\n\r\n    Turning on / off lights with TouchSensor\r\n\r\ncommit f3b0589aa996a2ac36dbc5cf15444e5bbc84c1f7\r\nAuthor: mwilliamsSamsung <m1.williams@partner.samsung.com>\r\nDate:   Wed Oct 5 14:39:38 2016 -0700\r\n\r\n    Work-in-progress development of sensor turning on a light","created_at":"2016-11-17T23:52:42Z","updated_at":"2016-12-05T17:58:46Z","closed_at":"2016-12-05T17:58:46Z","merged_at":"2016-12-05T17:58:46Z","merge_commit_sha":"b8edd486410fd4b2451275245183b8e240d6dc2b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/946/commits","review_comments_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/946/comments","review_comment_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/946/comments","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/ae0000ff1b44a299814954f15f6be99f2928243f","head":{"label":"mwitchwilliams:scripting2jsPR","ref":"scripting2jsPR","sha":"ae0000ff1b44a299814954f15f6be99f2928243f","user":{"login":"mwitchwilliams","id":18128830,"avatar_url":"https://avatars.githubusercontent.com/u/18128830?v=3","gravatar_id":"","url":"https://api.github.com/users/mwitchwilliams","html_url":"https://github.com/mwitchwilliams","followers_url":"https://api.github.com/users/mwitchwilliams/followers","following_url":"https://api.github.com/users/mwitchwilliams/following{/other_user}","gists_url":"https://api.github.com/users/mwitchwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/mwitchwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwitchwilliams/subscriptions","organizations_url":"https://api.github.com/users/mwitchwilliams/orgs","repos_url":"https://api.github.com/users/mwitchwilliams/repos","events_url":"https://api.github.com/users/mwitchwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/mwitchwilliams/received_events","type":"User","site_admin":false},"repo":{"id":54930995,"name":"GearVRf","full_name":"mwitchwilliams/GearVRf","owner":{"login":"mwitchwilliams","id":18128830,"avatar_url":"https://avatars.githubusercontent.com/u/18128830?v=3","gravatar_id":"","url":"https://api.github.com/users/mwitchwilliams","html_url":"https://github.com/mwitchwilliams","followers_url":"https://api.github.com/users/mwitchwilliams/followers","following_url":"https://api.github.com/users/mwitchwilliams/following{/other_user}","gists_url":"https://api.github.com/users/mwitchwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/mwitchwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwitchwilliams/subscriptions","organizations_url":"https://api.github.com/users/mwitchwilliams/orgs","repos_url":"https://api.github.com/users/mwitchwilliams/repos","events_url":"https://api.github.com/users/mwitchwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/mwitchwilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwitchwilliams/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":true,"url":"https://api.github.com/repos/mwitchwilliams/GearVRf","forks_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/forks","keys_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/teams","hooks_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/events","assignees_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/tags","blobs_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/languages","stargazers_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/subscription","commits_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/merges","archive_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/downloads","issues_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/releases{/id}","deployments_url":"https://api.github.com/repos/mwitchwilliams/GearVRf/deployments","created_at":"2016-03-28T23:33:48Z","updated_at":"2016-03-28T23:33:52Z","pushed_at":"2016-12-02T23:50:41Z","git_url":"git://github.com/mwitchwilliams/GearVRf.git","ssh_url":"git@github.com:mwitchwilliams/GearVRf.git","clone_url":"https://github.com/mwitchwilliams/GearVRf.git","svn_url":"https://github.com/mwitchwilliams/GearVRf","homepage":"http://www.gearvrf.org","size":684397,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"f2982dce75719275d66934be07ba9b73bb419586","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":32836701,"name":"GearVRf","full_name":"Samsung/GearVRf","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":false,"url":"https://api.github.com/repos/Samsung/GearVRf","forks_url":"https://api.github.com/repos/Samsung/GearVRf/forks","keys_url":"https://api.github.com/repos/Samsung/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/GearVRf/teams","hooks_url":"https://api.github.com/repos/Samsung/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/GearVRf/events","assignees_url":"https://api.github.com/repos/Samsung/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/GearVRf/tags","blobs_url":"https://api.github.com/repos/Samsung/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/GearVRf/languages","stargazers_url":"https://api.github.com/repos/Samsung/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/Samsung/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/Samsung/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/Samsung/GearVRf/subscription","commits_url":"https://api.github.com/repos/Samsung/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/GearVRf/merges","archive_url":"https://api.github.com/repos/Samsung/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/GearVRf/downloads","issues_url":"https://api.github.com/repos/Samsung/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/GearVRf/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/GearVRf/deployments","created_at":"2015-03-25T02:02:18Z","updated_at":"2016-12-03T15:54:42Z","pushed_at":"2016-12-05T17:58:46Z","git_url":"git://github.com/Samsung/GearVRf.git","ssh_url":"git@github.com:Samsung/GearVRf.git","clone_url":"https://github.com/Samsung/GearVRf.git","svn_url":"https://github.com/Samsung/GearVRf","homepage":"http://www.gearvrf.org","size":775092,"stargazers_count":258,"watchers_count":258,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":84,"forks":167,"open_issues":84,"watchers":258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/946"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/946"},"issue":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/946"},"comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/946/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/946/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/946/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/GearVRf/statuses/ae0000ff1b44a299814954f15f6be99f2928243f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thomasflynn","id":9667914,"avatar_url":"https://avatars.githubusercontent.com/u/9667914?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasflynn","html_url":"https://github.com/thomasflynn","followers_url":"https://api.github.com/users/thomasflynn/followers","following_url":"https://api.github.com/users/thomasflynn/following{/other_user}","gists_url":"https://api.github.com/users/thomasflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasflynn/subscriptions","organizations_url":"https://api.github.com/users/thomasflynn/orgs","repos_url":"https://api.github.com/users/thomasflynn/repos","events_url":"https://api.github.com/users/thomasflynn/events{/privacy}","received_events_url":"https://api.github.com/users/thomasflynn/received_events","type":"User","site_admin":false},"comments":6,"review_comments":1,"commits":2,"additions":5377,"deletions":4443,"changed_files":12}}
{"actor":{"display_login":"thomasflynn"}}