{"action":"created","issue":{"url":"https://api.github.com/repos/helm/helm/issues/457","repository_url":"https://api.github.com/repos/helm/helm","labels_url":"https://api.github.com/repos/helm/helm/issues/457/labels{/name}","comments_url":"https://api.github.com/repos/helm/helm/issues/457/comments","events_url":"https://api.github.com/repos/helm/helm/issues/457/events","html_url":"https://github.com/helm/helm/pull/457","id":152830553,"number":457,"title":"fix(Makefile): Fix error in dev target","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/helm/helm/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/helm/helm/labels/LGTM1","name":"LGTM1","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/helm/helm/milestones/6","html_url":"https://github.com/helm/helm/milestones/0.7.0","labels_url":"https://api.github.com/repos/helm/helm/milestones/6/labels","id":1740116,"number":6,"title":"0.7.0","description":"","creator":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":4,"state":"open","created_at":"2016-04-30T17:04:50Z","updated_at":"2016-05-03T17:29:31Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-05-03T17:29:31Z","updated_at":"2016-05-03T22:08:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/helm/helm/pulls/457","html_url":"https://github.com/helm/helm/pull/457","diff_url":"https://github.com/helm/helm/pull/457.diff","patch_url":"https://github.com/helm/helm/pull/457.patch"},"body":"This error somehow made it past code reviews for #445.\r\n\r\nThis snippet of code, once upon a time was at the very top of the Makefile.  #445 initially meant to remove that.  @mboersma said it should stay and @chaitanyaenr agreed to that, but somehow, it _moved_ down to here where it broke the `dev` target (which allows contributors to step interactively into the containerized development environment).\r\n\r\nAs for where this snippet actually belongs... the whole point of the containerized development environment is that no one should _need_ Go installed and set up on their local machine-- and this would include not needing to have the `GOPATH` env var defined.\r\n\r\nWhat I have done in this PR is _moved_ this check to the `native-build` target, which is the target that contributors can _optionally_ invoke to build helm for their native OS/architecture if they really want to.  This is a more appropriate place for this check."},"comment":{"url":"https://api.github.com/repos/helm/helm/issues/comments/216679568","html_url":"https://github.com/helm/helm/pull/457#issuecomment-216679568","issue_url":"https://api.github.com/repos/helm/helm/issues/457","id":216679568,"user":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T22:08:24Z","updated_at":"2016-05-03T22:08:24Z","body":"Travis is still complaining:\r\n```console\r\n$ make bootstrap\r\nMakefile:46: *** No GOPATH set.  Stop.\r\n```"}}