{"action":"closed","number":7456,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7456","id":63627674,"html_url":"https://github.com/ManageIQ/manageiq/pull/7456","diff_url":"https://github.com/ManageIQ/manageiq/pull/7456.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7456.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7456","number":7456,"state":"closed","locked":false,"title":"Miq expression specs housekeeping","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"body":"I'm going to start adding specs for `MiqExpression#to_sql` in preparation for https://trello.com/c/Vje3DjhW so wanted to bring some order to the existing ones. This change moves all the `#to_sql` specs under the one describe block. It also moves/removes some lets/befores which had an unnecessarily large scope.\r\n\r\n/cc @gtanzillo \r\n@miq-bot add-label test","created_at":"2016-03-21T20:33:30Z","updated_at":"2016-03-21T22:04:17Z","closed_at":"2016-03-21T22:04:16Z","merged_at":"2016-03-21T22:04:16Z","merge_commit_sha":"787e229c813237a1995be65104f1a0fb7006972e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7456/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7456/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7456/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/99d978538a0dcf2555164ec7f33f2759c1b9f801","head":{"label":"imtayadeway:miq-expression-specs-housekeeping","ref":"miq-expression-specs-housekeeping","sha":"99d978538a0dcf2555164ec7f33f2759c1b9f801","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"repo":{"id":34932503,"name":"manageiq","full_name":"imtayadeway/manageiq","owner":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imtayadeway/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/imtayadeway/manageiq","forks_url":"https://api.github.com/repos/imtayadeway/manageiq/forks","keys_url":"https://api.github.com/repos/imtayadeway/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imtayadeway/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imtayadeway/manageiq/teams","hooks_url":"https://api.github.com/repos/imtayadeway/manageiq/hooks","issue_events_url":"https://api.github.com/repos/imtayadeway/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/imtayadeway/manageiq/events","assignees_url":"https://api.github.com/repos/imtayadeway/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/imtayadeway/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/imtayadeway/manageiq/tags","blobs_url":"https://api.github.com/repos/imtayadeway/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imtayadeway/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imtayadeway/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/imtayadeway/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imtayadeway/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/imtayadeway/manageiq/languages","stargazers_url":"https://api.github.com/repos/imtayadeway/manageiq/stargazers","contributors_url":"https://api.github.com/repos/imtayadeway/manageiq/contributors","subscribers_url":"https://api.github.com/repos/imtayadeway/manageiq/subscribers","subscription_url":"https://api.github.com/repos/imtayadeway/manageiq/subscription","commits_url":"https://api.github.com/repos/imtayadeway/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/imtayadeway/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/imtayadeway/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/imtayadeway/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/imtayadeway/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/imtayadeway/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imtayadeway/manageiq/merges","archive_url":"https://api.github.com/repos/imtayadeway/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imtayadeway/manageiq/downloads","issues_url":"https://api.github.com/repos/imtayadeway/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/imtayadeway/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/imtayadeway/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/imtayadeway/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imtayadeway/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/imtayadeway/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/imtayadeway/manageiq/deployments","created_at":"2015-05-02T02:08:43Z","updated_at":"2016-01-11T19:09:23Z","pushed_at":"2016-03-21T20:52:01Z","git_url":"git://github.com/imtayadeway/manageiq.git","ssh_url":"git@github.com:imtayadeway/manageiq.git","clone_url":"https://github.com/imtayadeway/manageiq.git","svn_url":"https://github.com/imtayadeway/manageiq","homepage":"manageiq.org","size":130932,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"22cf82a2d039a72a672093840c0bdcd690575cf6","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-03-19T13:38:08Z","pushed_at":"2016-03-21T22:04:16Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":148462,"stargazers_count":239,"watchers_count":239,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":638,"forks":259,"open_issues":638,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7456"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7456"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7456"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7456/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7456/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7456/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/99d978538a0dcf2555164ec7f33f2759c1b9f801"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":208,"deletions":200,"changed_files":1}}