{"action":"opened","number":16766,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16766","id":70759995,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16766","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16766.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16766.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16766","number":16766,"state":"open","locked":false,"title":"[WIP] Partially refactor drop code and resolve a couple of issues along the way","user":{"login":"codemime","id":11905613,"avatar_url":"https://avatars.githubusercontent.com/u/11905613?v=3","gravatar_id":"","url":"https://api.github.com/users/codemime","html_url":"https://github.com/codemime","followers_url":"https://api.github.com/users/codemime/followers","following_url":"https://api.github.com/users/codemime/following{/other_user}","gists_url":"https://api.github.com/users/codemime/gists{/gist_id}","starred_url":"https://api.github.com/users/codemime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemime/subscriptions","organizations_url":"https://api.github.com/users/codemime/orgs","repos_url":"https://api.github.com/users/codemime/repos","events_url":"https://api.github.com/users/codemime/events{/privacy}","received_events_url":"https://api.github.com/users/codemime/received_events","type":"User","site_admin":false},"body":"Rationale: make drop code simpler and more maintainable. The current implementation does rather simple thing by tangled means using wrong indirection. I'm gonna mitigate the complexity so that issues (#14035 is one of them) could be resolved without ugly workarounds. \r\n\r\nThis PR is pretty much WIP (just a start actually) so it's too early to criticise the intermediate changes, but I want to share the intent.","created_at":"2016-05-19T20:30:50Z","updated_at":"2016-05-19T20:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16766/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16766/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16766/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/c5e57dc818aba1b9e59614b6e1c1b686d9e06104","head":{"label":"codemime:refactor_drop_code","ref":"refactor_drop_code","sha":"c5e57dc818aba1b9e59614b6e1c1b686d9e06104","user":{"login":"codemime","id":11905613,"avatar_url":"https://avatars.githubusercontent.com/u/11905613?v=3","gravatar_id":"","url":"https://api.github.com/users/codemime","html_url":"https://github.com/codemime","followers_url":"https://api.github.com/users/codemime/followers","following_url":"https://api.github.com/users/codemime/following{/other_user}","gists_url":"https://api.github.com/users/codemime/gists{/gist_id}","starred_url":"https://api.github.com/users/codemime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemime/subscriptions","organizations_url":"https://api.github.com/users/codemime/orgs","repos_url":"https://api.github.com/users/codemime/repos","events_url":"https://api.github.com/users/codemime/events{/privacy}","received_events_url":"https://api.github.com/users/codemime/received_events","type":"User","site_admin":false},"repo":{"id":50468318,"name":"Cataclysm-DDA","full_name":"codemime/Cataclysm-DDA","owner":{"login":"codemime","id":11905613,"avatar_url":"https://avatars.githubusercontent.com/u/11905613?v=3","gravatar_id":"","url":"https://api.github.com/users/codemime","html_url":"https://github.com/codemime","followers_url":"https://api.github.com/users/codemime/followers","following_url":"https://api.github.com/users/codemime/following{/other_user}","gists_url":"https://api.github.com/users/codemime/gists{/gist_id}","starred_url":"https://api.github.com/users/codemime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemime/subscriptions","organizations_url":"https://api.github.com/users/codemime/orgs","repos_url":"https://api.github.com/users/codemime/repos","events_url":"https://api.github.com/users/codemime/events{/privacy}","received_events_url":"https://api.github.com/users/codemime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codemime/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/codemime/Cataclysm-DDA","forks_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/deployments","created_at":"2016-01-27T00:03:47Z","updated_at":"2016-01-27T00:03:54Z","pushed_at":"2016-05-19T20:26:27Z","git_url":"git://github.com/codemime/Cataclysm-DDA.git","ssh_url":"git@github.com:codemime/Cataclysm-DDA.git","clone_url":"https://github.com/codemime/Cataclysm-DDA.git","svn_url":"https://github.com/codemime/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":766673,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"7f3020a1473972e922f9f5a354a566e9ff18f252","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2016-05-18T08:38:39Z","pushed_at":"2016-05-19T20:25:29Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1031422,"stargazers_count":954,"watchers_count":954,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":881,"mirror_url":null,"open_issues_count":1237,"forks":881,"open_issues":1237,"watchers":954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16766"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16766"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16766"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16766/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16766/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16766/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/c5e57dc818aba1b9e59614b6e1c1b686d9e06104"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":11,"additions":54,"deletions":120,"changed_files":5}}