{"action":"opened","number":19,"pull_request":{"url":"https://api.github.com/repos/cloudflare/react-gateway/pulls/19","id":98376597,"html_url":"https://github.com/cloudflare/react-gateway/pull/19","diff_url":"https://github.com/cloudflare/react-gateway/pull/19.diff","patch_url":"https://github.com/cloudflare/react-gateway/pull/19.patch","issue_url":"https://api.github.com/repos/cloudflare/react-gateway/issues/19","number":19,"state":"open","locked":false,"title":"Child Order Consistency","user":{"login":"hturan","id":65447,"avatar_url":"https://avatars.githubusercontent.com/u/65447?v=3","gravatar_id":"","url":"https://api.github.com/users/hturan","html_url":"https://github.com/hturan","followers_url":"https://api.github.com/users/hturan/followers","following_url":"https://api.github.com/users/hturan/following{/other_user}","gists_url":"https://api.github.com/users/hturan/gists{/gist_id}","starred_url":"https://api.github.com/users/hturan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hturan/subscriptions","organizations_url":"https://api.github.com/users/hturan/orgs","repos_url":"https://api.github.com/users/hturan/repos","events_url":"https://api.github.com/users/hturan/events{/privacy}","received_events_url":"https://api.github.com/users/hturan/received_events","type":"User","site_admin":false},"body":"When rendering multiple`Gateway`s into the same `GatewayDestination` the order of the child components isn't enforced, meaning that whenever the `Gateway` receives props there's a chance that the component tree will change.\r\n\r\nWe ran into this issue when rendering multiple `cf-ui` `cf-component-modal`s on the same page, as they each render into the same `GatewayDestination`. Whenever props changed, the order of the components would switch, causing `ReactCSSTransitionGroup` flickering and `ref` losses.","created_at":"2016-12-16T17:54:17Z","updated_at":"2016-12-16T17:54:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/react-gateway/pulls/19/commits","review_comments_url":"https://api.github.com/repos/cloudflare/react-gateway/pulls/19/comments","review_comment_url":"https://api.github.com/repos/cloudflare/react-gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/react-gateway/issues/19/comments","statuses_url":"https://api.github.com/repos/cloudflare/react-gateway/statuses/71e99ea02e70d38ef457c337af7afbd5129943dc","head":{"label":"hturan:child-order-consistency","ref":"child-order-consistency","sha":"71e99ea02e70d38ef457c337af7afbd5129943dc","user":{"login":"hturan","id":65447,"avatar_url":"https://avatars.githubusercontent.com/u/65447?v=3","gravatar_id":"","url":"https://api.github.com/users/hturan","html_url":"https://github.com/hturan","followers_url":"https://api.github.com/users/hturan/followers","following_url":"https://api.github.com/users/hturan/following{/other_user}","gists_url":"https://api.github.com/users/hturan/gists{/gist_id}","starred_url":"https://api.github.com/users/hturan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hturan/subscriptions","organizations_url":"https://api.github.com/users/hturan/orgs","repos_url":"https://api.github.com/users/hturan/repos","events_url":"https://api.github.com/users/hturan/events{/privacy}","received_events_url":"https://api.github.com/users/hturan/received_events","type":"User","site_admin":false},"repo":{"id":76576794,"name":"react-gateway","full_name":"hturan/react-gateway","owner":{"login":"hturan","id":65447,"avatar_url":"https://avatars.githubusercontent.com/u/65447?v=3","gravatar_id":"","url":"https://api.github.com/users/hturan","html_url":"https://github.com/hturan","followers_url":"https://api.github.com/users/hturan/followers","following_url":"https://api.github.com/users/hturan/following{/other_user}","gists_url":"https://api.github.com/users/hturan/gists{/gist_id}","starred_url":"https://api.github.com/users/hturan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hturan/subscriptions","organizations_url":"https://api.github.com/users/hturan/orgs","repos_url":"https://api.github.com/users/hturan/repos","events_url":"https://api.github.com/users/hturan/events{/privacy}","received_events_url":"https://api.github.com/users/hturan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hturan/react-gateway","description":"Render React DOM into a new context (aka \"Portal\")","fork":true,"url":"https://api.github.com/repos/hturan/react-gateway","forks_url":"https://api.github.com/repos/hturan/react-gateway/forks","keys_url":"https://api.github.com/repos/hturan/react-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hturan/react-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hturan/react-gateway/teams","hooks_url":"https://api.github.com/repos/hturan/react-gateway/hooks","issue_events_url":"https://api.github.com/repos/hturan/react-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/hturan/react-gateway/events","assignees_url":"https://api.github.com/repos/hturan/react-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/hturan/react-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/hturan/react-gateway/tags","blobs_url":"https://api.github.com/repos/hturan/react-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hturan/react-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hturan/react-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/hturan/react-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hturan/react-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/hturan/react-gateway/languages","stargazers_url":"https://api.github.com/repos/hturan/react-gateway/stargazers","contributors_url":"https://api.github.com/repos/hturan/react-gateway/contributors","subscribers_url":"https://api.github.com/repos/hturan/react-gateway/subscribers","subscription_url":"https://api.github.com/repos/hturan/react-gateway/subscription","commits_url":"https://api.github.com/repos/hturan/react-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/hturan/react-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/hturan/react-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/hturan/react-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/hturan/react-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/hturan/react-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hturan/react-gateway/merges","archive_url":"https://api.github.com/repos/hturan/react-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hturan/react-gateway/downloads","issues_url":"https://api.github.com/repos/hturan/react-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/hturan/react-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/hturan/react-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/hturan/react-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hturan/react-gateway/labels{/name}","releases_url":"https://api.github.com/repos/hturan/react-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/hturan/react-gateway/deployments","created_at":"2016-12-15T16:31:42Z","updated_at":"2016-12-15T16:31:44Z","pushed_at":"2016-12-16T15:34:09Z","git_url":"git://github.com/hturan/react-gateway.git","ssh_url":"git@github.com:hturan/react-gateway.git","clone_url":"https://github.com/hturan/react-gateway.git","svn_url":"https://github.com/hturan/react-gateway","homepage":"","size":36,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"f21774d34bf055dd47a0d88ca4cd06a0225c6197","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":45500296,"name":"react-gateway","full_name":"cloudflare/react-gateway","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/react-gateway","description":"Render React DOM into a new context (aka \"Portal\")","fork":false,"url":"https://api.github.com/repos/cloudflare/react-gateway","forks_url":"https://api.github.com/repos/cloudflare/react-gateway/forks","keys_url":"https://api.github.com/repos/cloudflare/react-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/react-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/react-gateway/teams","hooks_url":"https://api.github.com/repos/cloudflare/react-gateway/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/react-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/react-gateway/events","assignees_url":"https://api.github.com/repos/cloudflare/react-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/react-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/react-gateway/tags","blobs_url":"https://api.github.com/repos/cloudflare/react-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/react-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/react-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/react-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/react-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/react-gateway/languages","stargazers_url":"https://api.github.com/repos/cloudflare/react-gateway/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/react-gateway/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/react-gateway/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/react-gateway/subscription","commits_url":"https://api.github.com/repos/cloudflare/react-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/react-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/react-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/react-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/react-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/react-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/react-gateway/merges","archive_url":"https://api.github.com/repos/cloudflare/react-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/react-gateway/downloads","issues_url":"https://api.github.com/repos/cloudflare/react-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/react-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/react-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/react-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/react-gateway/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/react-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/react-gateway/deployments","created_at":"2015-11-03T22:36:06Z","updated_at":"2016-12-16T03:53:40Z","pushed_at":"2016-12-13T14:14:04Z","git_url":"git://github.com/cloudflare/react-gateway.git","ssh_url":"git@github.com:cloudflare/react-gateway.git","clone_url":"https://github.com/cloudflare/react-gateway.git","svn_url":"https://github.com/cloudflare/react-gateway","homepage":"","size":33,"stargazers_count":249,"watchers_count":249,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":5,"forks":23,"open_issues":5,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/react-gateway/pulls/19"},"html":{"href":"https://github.com/cloudflare/react-gateway/pull/19"},"issue":{"href":"https://api.github.com/repos/cloudflare/react-gateway/issues/19"},"comments":{"href":"https://api.github.com/repos/cloudflare/react-gateway/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/react-gateway/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/react-gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/react-gateway/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/react-gateway/statuses/71e99ea02e70d38ef457c337af7afbd5129943dc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":77,"deletions":13,"changed_files":3}}
{"actor":{"display_login":"hturan"}}