{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/76356121","id":76356121,"diff_hunk":"@@ -636,29 +694,31 @@ public void clearLang() {\n          */\n         RequestBody body();\n \n+        Request withBody(RequestBody body);\n+\n+        <T> T attr(TypedKey<T> key);\n+        <T> Optional<T> getAttr(TypedKey<T> key);\n+        boolean containsAttr(TypedKey<?> key);\n+        <T> Request withAttr(TypedKey<T> key, T value);\n+        Request withAttrs(TypedEntry<?> ...entries);\n+\n         /**\n          * The user name for this request, if defined.\n          * This is usually set by annotating your Action with <code>@Authenticated</code>.\n          *\n          * @return the username\n+         * @deprecated As of release 2.6, use <code>attr(Security.USERNAME)</code> or <code>getAttr(Security.USERNAME)</code>.\n          */\n-        String username();\n-\n-        /**\n-         * Defines the user name for this request.\n-         *\n-         * @deprecated As of release 2.4, use {@link #withUsername}\n-         * @param username Deprecated\n-         */\n-        @Deprecated void setUsername(String username);","path":"framework/src/play/src/main/java/play/mvc/Http.java","position":107,"original_position":107,"commit_id":"c2ea97268416112b0e9601f37262a74f2335ce8c","original_commit_id":"c2ea97268416112b0e9601f37262a74f2335ce8c","user":{"login":"richdougherty","id":14750,"avatar_url":"https://avatars.githubusercontent.com/u/14750?v=3","gravatar_id":"","url":"https://api.github.com/users/richdougherty","html_url":"https://github.com/richdougherty","followers_url":"https://api.github.com/users/richdougherty/followers","following_url":"https://api.github.com/users/richdougherty/following{/other_user}","gists_url":"https://api.github.com/users/richdougherty/gists{/gist_id}","starred_url":"https://api.github.com/users/richdougherty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richdougherty/subscriptions","organizations_url":"https://api.github.com/users/richdougherty/orgs","repos_url":"https://api.github.com/users/richdougherty/repos","events_url":"https://api.github.com/users/richdougherty/events{/privacy}","received_events_url":"https://api.github.com/users/richdougherty/received_events","type":"User","site_admin":false},"body":"Removed previously deprecated API.","created_at":"2016-08-26T02:25:51Z","updated_at":"2016-08-26T02:25:51Z","html_url":"https://github.com/playframework/playframework/pull/6321#discussion_r76356121","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/6321","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/76356121"},"html":{"href":"https://github.com/playframework/playframework/pull/6321#discussion_r76356121"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6321"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6321","id":77379991,"html_url":"https://github.com/playframework/playframework/pull/6321","diff_url":"https://github.com/playframework/playframework/pull/6321.diff","patch_url":"https://github.com/playframework/playframework/pull/6321.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6321","number":6321,"state":"open","locked":false,"title":"Add custom typed properties to requests","user":{"login":"richdougherty","id":14750,"avatar_url":"https://avatars.githubusercontent.com/u/14750?v=3","gravatar_id":"","url":"https://api.github.com/users/richdougherty","html_url":"https://github.com/richdougherty","followers_url":"https://api.github.com/users/richdougherty/followers","following_url":"https://api.github.com/users/richdougherty/following{/other_user}","gists_url":"https://api.github.com/users/richdougherty/gists{/gist_id}","starred_url":"https://api.github.com/users/richdougherty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richdougherty/subscriptions","organizations_url":"https://api.github.com/users/richdougherty/orgs","repos_url":"https://api.github.com/users/richdougherty/repos","events_url":"https://api.github.com/users/richdougherty/events{/privacy}","received_events_url":"https://api.github.com/users/richdougherty/received_events","type":"User","site_admin":false},"body":"RequestHeader and Request can now have custom properties added to\r\nthem. This lets plugins and users add their own data to requests.\r\nAdding custom properties was sort of possible by using tags, but tag\r\nvalues could only be strings. The new API adds support for typed\r\nproperties.\r\n\r\nTyped properties are accessed using methods similar to Maps. For\r\nexample, the `+` method adds a new property and `apply` or `get` can\r\nbe used to retrieve a property.\r\n\r\nI have intentionally restricted the API to hide internal details of\r\nhow properties are implemented. This is because I want to make it\r\npossible to change the underlying implementation later if we want to\r\nsupport more complicated features. For example, I've avoided exposing\r\nthe underlying map that's used to store the properties. This is\r\nbecause we might want to support lazy or dynamic properties later, and\r\nthese might not be implemented by storing them in a simple map.\r\n\r\nFixes #5814.\r\n\r\nTODO:\r\n\r\n- [x] Scaladoc\r\n- [x] Java API\r\n- [x] More tests\r\n- [x] Use typed tags for router","created_at":"2016-07-13T23:44:21Z","updated_at":"2016-08-26T02:25:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71901d81504cbfc829960f55e7ccb9c1ef9441e9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/6321/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/6321/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6321/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/c2ea97268416112b0e9601f37262a74f2335ce8c","head":{"label":"richdougherty:custom-request-props","ref":"custom-request-props","sha":"c2ea97268416112b0e9601f37262a74f2335ce8c","user":{"login":"richdougherty","id":14750,"avatar_url":"https://avatars.githubusercontent.com/u/14750?v=3","gravatar_id":"","url":"https://api.github.com/users/richdougherty","html_url":"https://github.com/richdougherty","followers_url":"https://api.github.com/users/richdougherty/followers","following_url":"https://api.github.com/users/richdougherty/following{/other_user}","gists_url":"https://api.github.com/users/richdougherty/gists{/gist_id}","starred_url":"https://api.github.com/users/richdougherty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richdougherty/subscriptions","organizations_url":"https://api.github.com/users/richdougherty/orgs","repos_url":"https://api.github.com/users/richdougherty/repos","events_url":"https://api.github.com/users/richdougherty/events{/privacy}","received_events_url":"https://api.github.com/users/richdougherty/received_events","type":"User","site_admin":false},"repo":{"id":8997972,"name":"playframework","full_name":"richdougherty/playframework","owner":{"login":"richdougherty","id":14750,"avatar_url":"https://avatars.githubusercontent.com/u/14750?v=3","gravatar_id":"","url":"https://api.github.com/users/richdougherty","html_url":"https://github.com/richdougherty","followers_url":"https://api.github.com/users/richdougherty/followers","following_url":"https://api.github.com/users/richdougherty/following{/other_user}","gists_url":"https://api.github.com/users/richdougherty/gists{/gist_id}","starred_url":"https://api.github.com/users/richdougherty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richdougherty/subscriptions","organizations_url":"https://api.github.com/users/richdougherty/orgs","repos_url":"https://api.github.com/users/richdougherty/repos","events_url":"https://api.github.com/users/richdougherty/events{/privacy}","received_events_url":"https://api.github.com/users/richdougherty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richdougherty/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/richdougherty/playframework","forks_url":"https://api.github.com/repos/richdougherty/playframework/forks","keys_url":"https://api.github.com/repos/richdougherty/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richdougherty/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richdougherty/playframework/teams","hooks_url":"https://api.github.com/repos/richdougherty/playframework/hooks","issue_events_url":"https://api.github.com/repos/richdougherty/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/richdougherty/playframework/events","assignees_url":"https://api.github.com/repos/richdougherty/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/richdougherty/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/richdougherty/playframework/tags","blobs_url":"https://api.github.com/repos/richdougherty/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richdougherty/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richdougherty/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/richdougherty/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richdougherty/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/richdougherty/playframework/languages","stargazers_url":"https://api.github.com/repos/richdougherty/playframework/stargazers","contributors_url":"https://api.github.com/repos/richdougherty/playframework/contributors","subscribers_url":"https://api.github.com/repos/richdougherty/playframework/subscribers","subscription_url":"https://api.github.com/repos/richdougherty/playframework/subscription","commits_url":"https://api.github.com/repos/richdougherty/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/richdougherty/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/richdougherty/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/richdougherty/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/richdougherty/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/richdougherty/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richdougherty/playframework/merges","archive_url":"https://api.github.com/repos/richdougherty/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richdougherty/playframework/downloads","issues_url":"https://api.github.com/repos/richdougherty/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/richdougherty/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/richdougherty/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/richdougherty/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richdougherty/playframework/labels{/name}","releases_url":"https://api.github.com/repos/richdougherty/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/richdougherty/playframework/deployments","created_at":"2013-03-25T03:20:47Z","updated_at":"2015-04-30T04:45:17Z","pushed_at":"2016-08-26T00:25:24Z","git_url":"git://github.com/richdougherty/playframework.git","ssh_url":"git@github.com:richdougherty/playframework.git","clone_url":"https://github.com/richdougherty/playframework.git","svn_url":"https://github.com/richdougherty/playframework","homepage":"http://www.playframework.org/","size":83268,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"695938f5ec367b35c7ed3e8f1cd68c644d22b1bc","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2016-08-25T23:25:44Z","pushed_at":"2016-08-26T00:25:26Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":95447,"stargazers_count":8304,"watchers_count":8304,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2870,"mirror_url":null,"open_issues_count":286,"forks":2870,"open_issues":286,"watchers":8304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6321"},"html":{"href":"https://github.com/playframework/playframework/pull/6321"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/6321"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/6321/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6321/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6321/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/c2ea97268416112b0e9601f37262a74f2335ce8c"}}}}
{"actor":{"display_login":"richdougherty"}}