{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/framework8-demo/issues/19","repository_url":"https://api.github.com/repos/vaadin/framework8-demo","labels_url":"https://api.github.com/repos/vaadin/framework8-demo/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/framework8-demo/issues/19/comments","events_url":"https://api.github.com/repos/vaadin/framework8-demo/issues/19/events","html_url":"https://github.com/vaadin/framework8-demo/pull/19","id":175025171,"number":19,"title":"Disable validation when adding a new contact","user":{"login":"ahie","id":6600210,"avatar_url":"https://avatars.githubusercontent.com/u/6600210?v=3","gravatar_id":"","url":"https://api.github.com/users/ahie","html_url":"https://github.com/ahie","followers_url":"https://api.github.com/users/ahie/followers","following_url":"https://api.github.com/users/ahie/following{/other_user}","gists_url":"https://api.github.com/users/ahie/gists{/gist_id}","starred_url":"https://api.github.com/users/ahie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahie/subscriptions","organizations_url":"https://api.github.com/users/ahie/orgs","repos_url":"https://api.github.com/users/ahie/repos","events_url":"https://api.github.com/users/ahie/events{/privacy}","received_events_url":"https://api.github.com/users/ahie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-05T08:56:16Z","updated_at":"2016-09-13T10:22:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/framework8-demo/pulls/19","html_url":"https://github.com/vaadin/framework8-demo/pull/19","diff_url":"https://github.com/vaadin/framework8-demo/pull/19.diff","patch_url":"https://github.com/vaadin/framework8-demo/pull/19.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/framework8-demo/19)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/framework8-demo/issues/comments/246638970","html_url":"https://github.com/vaadin/framework8-demo/pull/19#issuecomment-246638970","issue_url":"https://api.github.com/repos/vaadin/framework8-demo/issues/19","id":246638970,"user":{"login":"pleku","id":1478381,"avatar_url":"https://avatars.githubusercontent.com/u/1478381?v=3","gravatar_id":"","url":"https://api.github.com/users/pleku","html_url":"https://github.com/pleku","followers_url":"https://api.github.com/users/pleku/followers","following_url":"https://api.github.com/users/pleku/following{/other_user}","gists_url":"https://api.github.com/users/pleku/gists{/gist_id}","starred_url":"https://api.github.com/users/pleku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleku/subscriptions","organizations_url":"https://api.github.com/users/pleku/orgs","repos_url":"https://api.github.com/users/pleku/repos","events_url":"https://api.github.com/users/pleku/events{/privacy}","received_events_url":"https://api.github.com/users/pleku/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T10:22:14Z","updated_at":"2016-09-13T10:22:14Z","body":"\n\n\n\nReview status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[addressbook/src/main/java/com/vaadin/tutorial/addressbook/ContactForm.java, line 66 at r1](https://reviewable.io:443/reviews/vaadin/framework8-demo/19#-KQt_ei3Bqk_b6gjFfG2:-KRY3AFIUsrE_Dz0BR5o:b-9uw5h) ([raw file](https://github.com/vaadin/framework8-demo/blob/e3ec129746177dd0db2d408fc49fa2e1cf93e943/addressbook/src/main/java/com/vaadin/tutorial/addressbook/ContactForm.java#L66)):*\n<details><summary><i>Previously, pleku (Pekka Hyvönen) wrote…</i></summary>\n> Can you please test against the current master branch ?\n> \n> Either this form is not working the way it should be (by calling `binder.validate()` on `valueChange`) or we need to fix something more.\n> \n> Why does this even call binder.validate() since all field value changes trigger the validation (for that field and bean level if those pass) automatically ?\n</details>\nOh right, cross field validation ...\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/framework8-demo/19)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"pleku"}}