{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/92281101","pull_request_review_id":12793983,"id":92281101,"diff_hunk":"@@ -661,10 +741,10 @@ namespace WEX\n ///    }\n /// \\endcode\n #define TEST_METHOD(methodName) \\\n-    TAEF_TEST_METHOD(methodName) TAEF_TERMINATOR\n+    TAEF_TEST_METHOD(methodName)\n \n #define TAEF_TEST_METHOD_METADATA_START \\\n-    TAEF_PIN_FUNCTION_SYMBOL __declspec(allocate(\"testdata$h_TMM\")) \\\n+    TAEF_PIN_FUNCTION_SYMBOL TAEF_ATTRIBUTE_SECTION(\"testdata$h_TMM\") \\\n     static WEX::TestPropertyMetadata s_Metadata[] = { {WEX::TAEF_Identifier::TestMethodMetadata, L\"Name\", TAEF__WFUNCTION__}, \\","path":"deps/prebuilt/include/TAEF/WexTestClass.h","position":181,"original_position":181,"commit_id":"1337ca7b7e3c3d32ce53d6e7ab1f7b0baafbf47e","original_commit_id":"1337ca7b7e3c3d32ce53d6e7ab1f7b0baafbf47e","user":{"login":"jaredhms","id":13719817,"avatar_url":"https://avatars.githubusercontent.com/u/13719817?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredhms","html_url":"https://github.com/jaredhms","followers_url":"https://api.github.com/users/jaredhms/followers","following_url":"https://api.github.com/users/jaredhms/following{/other_user}","gists_url":"https://api.github.com/users/jaredhms/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredhms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredhms/subscriptions","organizations_url":"https://api.github.com/users/jaredhms/orgs","repos_url":"https://api.github.com/users/jaredhms/repos","events_url":"https://api.github.com/users/jaredhms/events{/privacy}","received_events_url":"https://api.github.com/users/jaredhms/received_events","type":"User","site_admin":false},"body":">L\"Name\", TAEF__WFUNCTION__}, \\ [](start = 97, length = 30)\r\n\r\ndo we need to also fix this up for method metadata?","created_at":"2016-12-13T22:25:18Z","updated_at":"2016-12-13T22:25:18Z","html_url":"https://github.com/Microsoft/WinObjC/pull/1523#discussion_r92281101","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1523","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/92281101"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/1523#discussion_r92281101"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1523"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1523","id":97658169,"html_url":"https://github.com/Microsoft/WinObjC/pull/1523","diff_url":"https://github.com/Microsoft/WinObjC/pull/1523.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/1523.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1523","number":1523,"state":"open","locked":false,"title":"Move functional tests to use TAEF directly. This removes the need for…","user":{"login":"bbowman","id":15642573,"avatar_url":"https://avatars.githubusercontent.com/u/15642573?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowman","html_url":"https://github.com/bbowman","followers_url":"https://api.github.com/users/bbowman/followers","following_url":"https://api.github.com/users/bbowman/following{/other_user}","gists_url":"https://api.github.com/users/bbowman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowman/subscriptions","organizations_url":"https://api.github.com/users/bbowman/orgs","repos_url":"https://api.github.com/users/bbowman/repos","events_url":"https://api.github.com/users/bbowman/events{/privacy}","received_events_url":"https://api.github.com/users/bbowman/received_events","type":"User","site_admin":false},"body":"… trampoline functions and paves the way for other ObjC tests to use the RunAs:UAP functionality that the test framework provies.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/microsoft/winobjc/1523)\n<!-- Reviewable:end -->\n","created_at":"2016-12-12T23:39:45Z","updated_at":"2016-12-13T22:25:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b59d366ef6517f30367a1d733bf06c0319cb807a","assignee":{"login":"jaredhms","id":13719817,"avatar_url":"https://avatars.githubusercontent.com/u/13719817?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredhms","html_url":"https://github.com/jaredhms","followers_url":"https://api.github.com/users/jaredhms/followers","following_url":"https://api.github.com/users/jaredhms/following{/other_user}","gists_url":"https://api.github.com/users/jaredhms/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredhms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredhms/subscriptions","organizations_url":"https://api.github.com/users/jaredhms/orgs","repos_url":"https://api.github.com/users/jaredhms/repos","events_url":"https://api.github.com/users/jaredhms/events{/privacy}","received_events_url":"https://api.github.com/users/jaredhms/received_events","type":"User","site_admin":false},"assignees":[{"login":"jaredhms","id":13719817,"avatar_url":"https://avatars.githubusercontent.com/u/13719817?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredhms","html_url":"https://github.com/jaredhms","followers_url":"https://api.github.com/users/jaredhms/followers","following_url":"https://api.github.com/users/jaredhms/following{/other_user}","gists_url":"https://api.github.com/users/jaredhms/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredhms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredhms/subscriptions","organizations_url":"https://api.github.com/users/jaredhms/orgs","repos_url":"https://api.github.com/users/jaredhms/repos","events_url":"https://api.github.com/users/jaredhms/events{/privacy}","received_events_url":"https://api.github.com/users/jaredhms/received_events","type":"User","site_admin":false},{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},{"login":"yiyang-msft","id":16788183,"avatar_url":"https://avatars.githubusercontent.com/u/16788183?v=3","gravatar_id":"","url":"https://api.github.com/users/yiyang-msft","html_url":"https://github.com/yiyang-msft","followers_url":"https://api.github.com/users/yiyang-msft/followers","following_url":"https://api.github.com/users/yiyang-msft/following{/other_user}","gists_url":"https://api.github.com/users/yiyang-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiyang-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiyang-msft/subscriptions","organizations_url":"https://api.github.com/users/yiyang-msft/orgs","repos_url":"https://api.github.com/users/yiyang-msft/repos","events_url":"https://api.github.com/users/yiyang-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yiyang-msft/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1523/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1523/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1523/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/1337ca7b7e3c3d32ce53d6e7ab1f7b0baafbf47e","head":{"label":"bbowman:bbowman/TAEF_FunctionalTests","ref":"bbowman/TAEF_FunctionalTests","sha":"1337ca7b7e3c3d32ce53d6e7ab1f7b0baafbf47e","user":{"login":"bbowman","id":15642573,"avatar_url":"https://avatars.githubusercontent.com/u/15642573?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowman","html_url":"https://github.com/bbowman","followers_url":"https://api.github.com/users/bbowman/followers","following_url":"https://api.github.com/users/bbowman/following{/other_user}","gists_url":"https://api.github.com/users/bbowman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowman/subscriptions","organizations_url":"https://api.github.com/users/bbowman/orgs","repos_url":"https://api.github.com/users/bbowman/repos","events_url":"https://api.github.com/users/bbowman/events{/privacy}","received_events_url":"https://api.github.com/users/bbowman/received_events","type":"User","site_admin":false},"repo":{"id":70117942,"name":"WinObjC","full_name":"bbowman/WinObjC","owner":{"login":"bbowman","id":15642573,"avatar_url":"https://avatars.githubusercontent.com/u/15642573?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowman","html_url":"https://github.com/bbowman","followers_url":"https://api.github.com/users/bbowman/followers","following_url":"https://api.github.com/users/bbowman/following{/other_user}","gists_url":"https://api.github.com/users/bbowman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowman/subscriptions","organizations_url":"https://api.github.com/users/bbowman/orgs","repos_url":"https://api.github.com/users/bbowman/repos","events_url":"https://api.github.com/users/bbowman/events{/privacy}","received_events_url":"https://api.github.com/users/bbowman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbowman/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/bbowman/WinObjC","forks_url":"https://api.github.com/repos/bbowman/WinObjC/forks","keys_url":"https://api.github.com/repos/bbowman/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbowman/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbowman/WinObjC/teams","hooks_url":"https://api.github.com/repos/bbowman/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/bbowman/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/bbowman/WinObjC/events","assignees_url":"https://api.github.com/repos/bbowman/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/bbowman/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/bbowman/WinObjC/tags","blobs_url":"https://api.github.com/repos/bbowman/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbowman/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbowman/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbowman/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbowman/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/bbowman/WinObjC/languages","stargazers_url":"https://api.github.com/repos/bbowman/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/bbowman/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/bbowman/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/bbowman/WinObjC/subscription","commits_url":"https://api.github.com/repos/bbowman/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbowman/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbowman/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbowman/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbowman/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/bbowman/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbowman/WinObjC/merges","archive_url":"https://api.github.com/repos/bbowman/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbowman/WinObjC/downloads","issues_url":"https://api.github.com/repos/bbowman/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/bbowman/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/bbowman/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/bbowman/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbowman/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/bbowman/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/bbowman/WinObjC/deployments","created_at":"2016-10-06T02:57:29Z","updated_at":"2016-10-06T02:57:49Z","pushed_at":"2016-12-12T23:23:59Z","git_url":"git://github.com/bbowman/WinObjC.git","ssh_url":"git@github.com:bbowman/WinObjC.git","clone_url":"https://github.com/bbowman/WinObjC.git","svn_url":"https://github.com/bbowman/WinObjC","homepage":"","size":343125,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"f00c6ffb8d6ad2f9cdfd43bb223897af480eaf42","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-12-13T03:08:14Z","pushed_at":"2016-12-13T21:49:49Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":375099,"stargazers_count":5548,"watchers_count":5548,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":737,"mirror_url":null,"open_issues_count":285,"forks":737,"open_issues":285,"watchers":5548,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1523"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/1523"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1523"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1523/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1523/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1523/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/1337ca7b7e3c3d32ce53d6e7ab1f7b0baafbf47e"}}}}
{"actor":{"display_login":"jaredhms"}}