{"action":"closed","number":133,"pull_request":{"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/133","id":66258094,"html_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/133","diff_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/133.diff","patch_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/133.patch","issue_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/133","number":133,"state":"closed","locked":false,"title":"Better initial vertexing","user":{"login":"mccumbermike","id":12105552,"avatar_url":"https://avatars.githubusercontent.com/u/12105552?v=3","gravatar_id":"","url":"https://api.github.com/users/mccumbermike","html_url":"https://github.com/mccumbermike","followers_url":"https://api.github.com/users/mccumbermike/followers","following_url":"https://api.github.com/users/mccumbermike/following{/other_user}","gists_url":"https://api.github.com/users/mccumbermike/gists{/gist_id}","starred_url":"https://api.github.com/users/mccumbermike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccumbermike/subscriptions","organizations_url":"https://api.github.com/users/mccumbermike/orgs","repos_url":"https://api.github.com/users/mccumbermike/repos","events_url":"https://api.github.com/users/mccumbermike/events{/privacy}","received_events_url":"https://api.github.com/users/mccumbermike/received_events","type":"User","site_admin":false},"body":"Ok, here is the follow up pull request I discussed this morning. I've decided to initialize the vertex with the simulated BBC vertex, catch this with an initial patterning reco code, fit that quick vertex, and pass it into the final tracking and vertexing code. The first two stages are setup to work with a BBC resolution in p+p and the tracker populated by a HIJING event---so it should satisfy both ends of the spectrum. Anyhow, the speed in central events is about the same as before so I'm not so far off on the CPU optimization.\r\n\r\nHere is a look at getting the vertex guessing problem fixed for vertexes smeared throughout the beam diamond in the same way as shown this morning, solid points are this pull request.\r\n![crosscheck](https://cloud.githubusercontent.com/assets/12105552/14481144/66e6f76c-00ed-11e6-9a32-b9833f6f47d7.png)\r\nYou can see I've largely solved the 20% failure in the initial vertex guessing code.\r\n\r\nI will toy around with replacing the BBC input with SVTX only code which I think should be workable for most of the trackers and satisfy my philosophical desire for a tracking code base that doesn't critically rely on other detectors---but I'm a little worried about designs with lots of fakes, confusion could run rampant in those cases. But practical demands to get us moving forward won the day today.\r\n\r\nTo build watchers: The BBC code previously resided in the g4vertex library with the composite global vertex. Since the g4hough needed to link against that without a circular dependency, I split g4vertex into g4bcc and g4vertex libraries. So I will need to make a pull request on the build utility and on the macros to prepare those things for these changes and the merges will need to happen at roughly the same times to avoid the worst aspects of the disruption.\r\n\r\nI haven't ported any of these things into the TPC code base...  who is running support on that these days?","created_at":"2016-04-13T02:41:32Z","updated_at":"2016-04-26T15:41:28Z","closed_at":"2016-04-26T15:41:28Z","merged_at":"2016-04-26T15:41:28Z","merge_commit_sha":"371b35c380907e7992b7fe2c02e2480f063b6c7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/133/commits","review_comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/133/comments","review_comment_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/133/comments","statuses_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/e16b3a7631f63876b11e3fad1d09a757b93e6075","head":{"label":"mccumbermike:better_initial_vertexing","ref":"better_initial_vertexing","sha":"e16b3a7631f63876b11e3fad1d09a757b93e6075","user":{"login":"mccumbermike","id":12105552,"avatar_url":"https://avatars.githubusercontent.com/u/12105552?v=3","gravatar_id":"","url":"https://api.github.com/users/mccumbermike","html_url":"https://github.com/mccumbermike","followers_url":"https://api.github.com/users/mccumbermike/followers","following_url":"https://api.github.com/users/mccumbermike/following{/other_user}","gists_url":"https://api.github.com/users/mccumbermike/gists{/gist_id}","starred_url":"https://api.github.com/users/mccumbermike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccumbermike/subscriptions","organizations_url":"https://api.github.com/users/mccumbermike/orgs","repos_url":"https://api.github.com/users/mccumbermike/repos","events_url":"https://api.github.com/users/mccumbermike/events{/privacy}","received_events_url":"https://api.github.com/users/mccumbermike/received_events","type":"User","site_admin":false},"repo":{"id":41013413,"name":"coresoftware","full_name":"mccumbermike/coresoftware","owner":{"login":"mccumbermike","id":12105552,"avatar_url":"https://avatars.githubusercontent.com/u/12105552?v=3","gravatar_id":"","url":"https://api.github.com/users/mccumbermike","html_url":"https://github.com/mccumbermike","followers_url":"https://api.github.com/users/mccumbermike/followers","following_url":"https://api.github.com/users/mccumbermike/following{/other_user}","gists_url":"https://api.github.com/users/mccumbermike/gists{/gist_id}","starred_url":"https://api.github.com/users/mccumbermike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccumbermike/subscriptions","organizations_url":"https://api.github.com/users/mccumbermike/orgs","repos_url":"https://api.github.com/users/mccumbermike/repos","events_url":"https://api.github.com/users/mccumbermike/events{/privacy}","received_events_url":"https://api.github.com/users/mccumbermike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mccumbermike/coresoftware","description":"Our big core software repository","fork":true,"url":"https://api.github.com/repos/mccumbermike/coresoftware","forks_url":"https://api.github.com/repos/mccumbermike/coresoftware/forks","keys_url":"https://api.github.com/repos/mccumbermike/coresoftware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mccumbermike/coresoftware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mccumbermike/coresoftware/teams","hooks_url":"https://api.github.com/repos/mccumbermike/coresoftware/hooks","issue_events_url":"https://api.github.com/repos/mccumbermike/coresoftware/issues/events{/number}","events_url":"https://api.github.com/repos/mccumbermike/coresoftware/events","assignees_url":"https://api.github.com/repos/mccumbermike/coresoftware/assignees{/user}","branches_url":"https://api.github.com/repos/mccumbermike/coresoftware/branches{/branch}","tags_url":"https://api.github.com/repos/mccumbermike/coresoftware/tags","blobs_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/refs{/sha}","trees_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mccumbermike/coresoftware/statuses/{sha}","languages_url":"https://api.github.com/repos/mccumbermike/coresoftware/languages","stargazers_url":"https://api.github.com/repos/mccumbermike/coresoftware/stargazers","contributors_url":"https://api.github.com/repos/mccumbermike/coresoftware/contributors","subscribers_url":"https://api.github.com/repos/mccumbermike/coresoftware/subscribers","subscription_url":"https://api.github.com/repos/mccumbermike/coresoftware/subscription","commits_url":"https://api.github.com/repos/mccumbermike/coresoftware/commits{/sha}","git_commits_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/commits{/sha}","comments_url":"https://api.github.com/repos/mccumbermike/coresoftware/comments{/number}","issue_comment_url":"https://api.github.com/repos/mccumbermike/coresoftware/issues/comments{/number}","contents_url":"https://api.github.com/repos/mccumbermike/coresoftware/contents/{+path}","compare_url":"https://api.github.com/repos/mccumbermike/coresoftware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mccumbermike/coresoftware/merges","archive_url":"https://api.github.com/repos/mccumbermike/coresoftware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mccumbermike/coresoftware/downloads","issues_url":"https://api.github.com/repos/mccumbermike/coresoftware/issues{/number}","pulls_url":"https://api.github.com/repos/mccumbermike/coresoftware/pulls{/number}","milestones_url":"https://api.github.com/repos/mccumbermike/coresoftware/milestones{/number}","notifications_url":"https://api.github.com/repos/mccumbermike/coresoftware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mccumbermike/coresoftware/labels{/name}","releases_url":"https://api.github.com/repos/mccumbermike/coresoftware/releases{/id}","deployments_url":"https://api.github.com/repos/mccumbermike/coresoftware/deployments","created_at":"2015-08-19T04:33:04Z","updated_at":"2016-01-15T04:21:51Z","pushed_at":"2016-04-19T03:45:49Z","git_url":"git://github.com/mccumbermike/coresoftware.git","ssh_url":"git@github.com:mccumbermike/coresoftware.git","clone_url":"https://github.com/mccumbermike/coresoftware.git","svn_url":"https://github.com/mccumbermike/coresoftware","homepage":null,"size":4414,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sPHENIX-Collaboration:master","ref":"master","sha":"5ccceebc09362696f05b9fbe0184265bcd248202","user":{"login":"sPHENIX-Collaboration","id":12069843,"avatar_url":"https://avatars.githubusercontent.com/u/12069843?v=3","gravatar_id":"","url":"https://api.github.com/users/sPHENIX-Collaboration","html_url":"https://github.com/sPHENIX-Collaboration","followers_url":"https://api.github.com/users/sPHENIX-Collaboration/followers","following_url":"https://api.github.com/users/sPHENIX-Collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sPHENIX-Collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sPHENIX-Collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sPHENIX-Collaboration/subscriptions","organizations_url":"https://api.github.com/users/sPHENIX-Collaboration/orgs","repos_url":"https://api.github.com/users/sPHENIX-Collaboration/repos","events_url":"https://api.github.com/users/sPHENIX-Collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sPHENIX-Collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":34742432,"name":"coresoftware","full_name":"sPHENIX-Collaboration/coresoftware","owner":{"login":"sPHENIX-Collaboration","id":12069843,"avatar_url":"https://avatars.githubusercontent.com/u/12069843?v=3","gravatar_id":"","url":"https://api.github.com/users/sPHENIX-Collaboration","html_url":"https://github.com/sPHENIX-Collaboration","followers_url":"https://api.github.com/users/sPHENIX-Collaboration/followers","following_url":"https://api.github.com/users/sPHENIX-Collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sPHENIX-Collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sPHENIX-Collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sPHENIX-Collaboration/subscriptions","organizations_url":"https://api.github.com/users/sPHENIX-Collaboration/orgs","repos_url":"https://api.github.com/users/sPHENIX-Collaboration/repos","events_url":"https://api.github.com/users/sPHENIX-Collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sPHENIX-Collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sPHENIX-Collaboration/coresoftware","description":"Our big core software repository","fork":false,"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware","forks_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/forks","keys_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/teams","hooks_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/hooks","issue_events_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/events{/number}","events_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/events","assignees_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/assignees{/user}","branches_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/branches{/branch}","tags_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/tags","blobs_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/refs{/sha}","trees_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/{sha}","languages_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/languages","stargazers_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/stargazers","contributors_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/contributors","subscribers_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/subscribers","subscription_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/subscription","commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/commits{/sha}","git_commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/commits{/sha}","comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/comments{/number}","issue_comment_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/comments{/number}","contents_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/contents/{+path}","compare_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/merges","archive_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/downloads","issues_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues{/number}","pulls_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls{/number}","milestones_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/milestones{/number}","notifications_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/labels{/name}","releases_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/releases{/id}","deployments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/deployments","created_at":"2015-04-28T16:29:55Z","updated_at":"2016-01-12T15:29:14Z","pushed_at":"2016-04-26T15:41:28Z","git_url":"git://github.com/sPHENIX-Collaboration/coresoftware.git","ssh_url":"git@github.com:sPHENIX-Collaboration/coresoftware.git","clone_url":"https://github.com/sPHENIX-Collaboration/coresoftware.git","svn_url":"https://github.com/sPHENIX-Collaboration/coresoftware","homepage":"https://wiki.bnl.gov/sPHENIX/index.php/Main_Page","size":4741,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":1,"forks":20,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/133"},"html":{"href":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/133"},"issue":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/133"},"comments":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/e16b3a7631f63876b11e3fad1d09a757b93e6075"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"blackcathj","id":7947083,"avatar_url":"https://avatars.githubusercontent.com/u/7947083?v=3","gravatar_id":"","url":"https://api.github.com/users/blackcathj","html_url":"https://github.com/blackcathj","followers_url":"https://api.github.com/users/blackcathj/followers","following_url":"https://api.github.com/users/blackcathj/following{/other_user}","gists_url":"https://api.github.com/users/blackcathj/gists{/gist_id}","starred_url":"https://api.github.com/users/blackcathj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackcathj/subscriptions","organizations_url":"https://api.github.com/users/blackcathj/orgs","repos_url":"https://api.github.com/users/blackcathj/repos","events_url":"https://api.github.com/users/blackcathj/events{/privacy}","received_events_url":"https://api.github.com/users/blackcathj/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":25,"additions":1513,"deletions":1084,"changed_files":25}}