{"action":"created","comment":{"url":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/comments/89970885","pull_request_review_id":10496689,"id":89970885,"diff_hunk":"@@ -39,6 +40,9 @@\n     private final EventLoopGroup eventLoopGroup;\n     private final NSQConfig config;\n \n+    public static final long HEARTBEAT_MAX_INTERVAL = 1L*60L*1000L;//default one minute","path":"src/main/java/com/github/brainlag/nsq/Connection.java","position":12,"original_position":12,"commit_id":"269fafe7db61184682f0e194229dcd33426e7323","original_commit_id":"269fafe7db61184682f0e194229dcd33426e7323","user":{"login":"esiqveland","id":105188,"avatar_url":"https://avatars.githubusercontent.com/u/105188?v=3","gravatar_id":"","url":"https://api.github.com/users/esiqveland","html_url":"https://github.com/esiqveland","followers_url":"https://api.github.com/users/esiqveland/followers","following_url":"https://api.github.com/users/esiqveland/following{/other_user}","gists_url":"https://api.github.com/users/esiqveland/gists{/gist_id}","starred_url":"https://api.github.com/users/esiqveland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esiqveland/subscriptions","organizations_url":"https://api.github.com/users/esiqveland/orgs","repos_url":"https://api.github.com/users/esiqveland/repos","events_url":"https://api.github.com/users/esiqveland/events{/privacy}","received_events_url":"https://api.github.com/users/esiqveland/received_events","type":"User","site_admin":false},"body":"Maybe HEARTBEAT_MAX_INTERVAL should be set relative to `heartbeatInterval` in `NSQConfig`?","created_at":"2016-11-29T09:35:40Z","updated_at":"2016-11-29T09:35:40Z","html_url":"https://github.com/brainlag/JavaNSQClient/pull/28#discussion_r89970885","pull_request_url":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/comments/89970885"},"html":{"href":"https://github.com/brainlag/JavaNSQClient/pull/28#discussion_r89970885"},"pull_request":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/28","id":84282513,"html_url":"https://github.com/brainlag/JavaNSQClient/pull/28","diff_url":"https://github.com/brainlag/JavaNSQClient/pull/28.diff","patch_url":"https://github.com/brainlag/JavaNSQClient/pull/28.patch","issue_url":"https://api.github.com/repos/brainlag/JavaNSQClient/issues/28","number":28,"state":"open","locked":false,"title":"add heartbeat interval exceeded check","user":{"login":"icanfly","id":1010797,"avatar_url":"https://avatars.githubusercontent.com/u/1010797?v=3","gravatar_id":"","url":"https://api.github.com/users/icanfly","html_url":"https://github.com/icanfly","followers_url":"https://api.github.com/users/icanfly/followers","following_url":"https://api.github.com/users/icanfly/following{/other_user}","gists_url":"https://api.github.com/users/icanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/icanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icanfly/subscriptions","organizations_url":"https://api.github.com/users/icanfly/orgs","repos_url":"https://api.github.com/users/icanfly/repos","events_url":"https://api.github.com/users/icanfly/events{/privacy}","received_events_url":"https://api.github.com/users/icanfly/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-07T11:25:40Z","updated_at":"2016-11-29T09:35:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15de343fdac53174b2aa32d45b057eb0a854a424","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/28/commits","review_comments_url":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/28/comments","review_comment_url":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brainlag/JavaNSQClient/issues/28/comments","statuses_url":"https://api.github.com/repos/brainlag/JavaNSQClient/statuses/269fafe7db61184682f0e194229dcd33426e7323","head":{"label":"icanfly:master","ref":"master","sha":"269fafe7db61184682f0e194229dcd33426e7323","user":{"login":"icanfly","id":1010797,"avatar_url":"https://avatars.githubusercontent.com/u/1010797?v=3","gravatar_id":"","url":"https://api.github.com/users/icanfly","html_url":"https://github.com/icanfly","followers_url":"https://api.github.com/users/icanfly/followers","following_url":"https://api.github.com/users/icanfly/following{/other_user}","gists_url":"https://api.github.com/users/icanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/icanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icanfly/subscriptions","organizations_url":"https://api.github.com/users/icanfly/orgs","repos_url":"https://api.github.com/users/icanfly/repos","events_url":"https://api.github.com/users/icanfly/events{/privacy}","received_events_url":"https://api.github.com/users/icanfly/received_events","type":"User","site_admin":false},"repo":{"id":59011249,"name":"JavaNSQClient","full_name":"icanfly/JavaNSQClient","owner":{"login":"icanfly","id":1010797,"avatar_url":"https://avatars.githubusercontent.com/u/1010797?v=3","gravatar_id":"","url":"https://api.github.com/users/icanfly","html_url":"https://github.com/icanfly","followers_url":"https://api.github.com/users/icanfly/followers","following_url":"https://api.github.com/users/icanfly/following{/other_user}","gists_url":"https://api.github.com/users/icanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/icanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icanfly/subscriptions","organizations_url":"https://api.github.com/users/icanfly/orgs","repos_url":"https://api.github.com/users/icanfly/repos","events_url":"https://api.github.com/users/icanfly/events{/privacy}","received_events_url":"https://api.github.com/users/icanfly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/icanfly/JavaNSQClient","description":"Fast Java client for NSQ","fork":true,"url":"https://api.github.com/repos/icanfly/JavaNSQClient","forks_url":"https://api.github.com/repos/icanfly/JavaNSQClient/forks","keys_url":"https://api.github.com/repos/icanfly/JavaNSQClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icanfly/JavaNSQClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icanfly/JavaNSQClient/teams","hooks_url":"https://api.github.com/repos/icanfly/JavaNSQClient/hooks","issue_events_url":"https://api.github.com/repos/icanfly/JavaNSQClient/issues/events{/number}","events_url":"https://api.github.com/repos/icanfly/JavaNSQClient/events","assignees_url":"https://api.github.com/repos/icanfly/JavaNSQClient/assignees{/user}","branches_url":"https://api.github.com/repos/icanfly/JavaNSQClient/branches{/branch}","tags_url":"https://api.github.com/repos/icanfly/JavaNSQClient/tags","blobs_url":"https://api.github.com/repos/icanfly/JavaNSQClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icanfly/JavaNSQClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icanfly/JavaNSQClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/icanfly/JavaNSQClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icanfly/JavaNSQClient/statuses/{sha}","languages_url":"https://api.github.com/repos/icanfly/JavaNSQClient/languages","stargazers_url":"https://api.github.com/repos/icanfly/JavaNSQClient/stargazers","contributors_url":"https://api.github.com/repos/icanfly/JavaNSQClient/contributors","subscribers_url":"https://api.github.com/repos/icanfly/JavaNSQClient/subscribers","subscription_url":"https://api.github.com/repos/icanfly/JavaNSQClient/subscription","commits_url":"https://api.github.com/repos/icanfly/JavaNSQClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/icanfly/JavaNSQClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/icanfly/JavaNSQClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/icanfly/JavaNSQClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/icanfly/JavaNSQClient/contents/{+path}","compare_url":"https://api.github.com/repos/icanfly/JavaNSQClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icanfly/JavaNSQClient/merges","archive_url":"https://api.github.com/repos/icanfly/JavaNSQClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icanfly/JavaNSQClient/downloads","issues_url":"https://api.github.com/repos/icanfly/JavaNSQClient/issues{/number}","pulls_url":"https://api.github.com/repos/icanfly/JavaNSQClient/pulls{/number}","milestones_url":"https://api.github.com/repos/icanfly/JavaNSQClient/milestones{/number}","notifications_url":"https://api.github.com/repos/icanfly/JavaNSQClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icanfly/JavaNSQClient/labels{/name}","releases_url":"https://api.github.com/repos/icanfly/JavaNSQClient/releases{/id}","deployments_url":"https://api.github.com/repos/icanfly/JavaNSQClient/deployments","created_at":"2016-05-17T09:59:58Z","updated_at":"2016-05-17T09:59:59Z","pushed_at":"2016-09-07T11:23:27Z","git_url":"git://github.com/icanfly/JavaNSQClient.git","ssh_url":"git@github.com:icanfly/JavaNSQClient.git","clone_url":"https://github.com/icanfly/JavaNSQClient.git","svn_url":"https://github.com/icanfly/JavaNSQClient","homepage":"","size":2490,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brainlag:master","ref":"master","sha":"4849b02a95f61ad56bdb6c5028247fd2ad261090","user":{"login":"brainlag","id":8015,"avatar_url":"https://avatars.githubusercontent.com/u/8015?v=3","gravatar_id":"","url":"https://api.github.com/users/brainlag","html_url":"https://github.com/brainlag","followers_url":"https://api.github.com/users/brainlag/followers","following_url":"https://api.github.com/users/brainlag/following{/other_user}","gists_url":"https://api.github.com/users/brainlag/gists{/gist_id}","starred_url":"https://api.github.com/users/brainlag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainlag/subscriptions","organizations_url":"https://api.github.com/users/brainlag/orgs","repos_url":"https://api.github.com/users/brainlag/repos","events_url":"https://api.github.com/users/brainlag/events{/privacy}","received_events_url":"https://api.github.com/users/brainlag/received_events","type":"User","site_admin":false},"repo":{"id":31466036,"name":"JavaNSQClient","full_name":"brainlag/JavaNSQClient","owner":{"login":"brainlag","id":8015,"avatar_url":"https://avatars.githubusercontent.com/u/8015?v=3","gravatar_id":"","url":"https://api.github.com/users/brainlag","html_url":"https://github.com/brainlag","followers_url":"https://api.github.com/users/brainlag/followers","following_url":"https://api.github.com/users/brainlag/following{/other_user}","gists_url":"https://api.github.com/users/brainlag/gists{/gist_id}","starred_url":"https://api.github.com/users/brainlag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainlag/subscriptions","organizations_url":"https://api.github.com/users/brainlag/orgs","repos_url":"https://api.github.com/users/brainlag/repos","events_url":"https://api.github.com/users/brainlag/events{/privacy}","received_events_url":"https://api.github.com/users/brainlag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brainlag/JavaNSQClient","description":"Fast Java client for NSQ","fork":true,"url":"https://api.github.com/repos/brainlag/JavaNSQClient","forks_url":"https://api.github.com/repos/brainlag/JavaNSQClient/forks","keys_url":"https://api.github.com/repos/brainlag/JavaNSQClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brainlag/JavaNSQClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brainlag/JavaNSQClient/teams","hooks_url":"https://api.github.com/repos/brainlag/JavaNSQClient/hooks","issue_events_url":"https://api.github.com/repos/brainlag/JavaNSQClient/issues/events{/number}","events_url":"https://api.github.com/repos/brainlag/JavaNSQClient/events","assignees_url":"https://api.github.com/repos/brainlag/JavaNSQClient/assignees{/user}","branches_url":"https://api.github.com/repos/brainlag/JavaNSQClient/branches{/branch}","tags_url":"https://api.github.com/repos/brainlag/JavaNSQClient/tags","blobs_url":"https://api.github.com/repos/brainlag/JavaNSQClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brainlag/JavaNSQClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brainlag/JavaNSQClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/brainlag/JavaNSQClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brainlag/JavaNSQClient/statuses/{sha}","languages_url":"https://api.github.com/repos/brainlag/JavaNSQClient/languages","stargazers_url":"https://api.github.com/repos/brainlag/JavaNSQClient/stargazers","contributors_url":"https://api.github.com/repos/brainlag/JavaNSQClient/contributors","subscribers_url":"https://api.github.com/repos/brainlag/JavaNSQClient/subscribers","subscription_url":"https://api.github.com/repos/brainlag/JavaNSQClient/subscription","commits_url":"https://api.github.com/repos/brainlag/JavaNSQClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/brainlag/JavaNSQClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/brainlag/JavaNSQClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/brainlag/JavaNSQClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/brainlag/JavaNSQClient/contents/{+path}","compare_url":"https://api.github.com/repos/brainlag/JavaNSQClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brainlag/JavaNSQClient/merges","archive_url":"https://api.github.com/repos/brainlag/JavaNSQClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brainlag/JavaNSQClient/downloads","issues_url":"https://api.github.com/repos/brainlag/JavaNSQClient/issues{/number}","pulls_url":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls{/number}","milestones_url":"https://api.github.com/repos/brainlag/JavaNSQClient/milestones{/number}","notifications_url":"https://api.github.com/repos/brainlag/JavaNSQClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brainlag/JavaNSQClient/labels{/name}","releases_url":"https://api.github.com/repos/brainlag/JavaNSQClient/releases{/id}","deployments_url":"https://api.github.com/repos/brainlag/JavaNSQClient/deployments","created_at":"2015-02-28T15:11:39Z","updated_at":"2016-11-10T06:59:14Z","pushed_at":"2016-10-03T18:26:38Z","git_url":"git://github.com/brainlag/JavaNSQClient.git","ssh_url":"git@github.com:brainlag/JavaNSQClient.git","clone_url":"https://github.com/brainlag/JavaNSQClient.git","svn_url":"https://github.com/brainlag/JavaNSQClient","homepage":"","size":2540,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":9,"forks":24,"open_issues":9,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/28"},"html":{"href":"https://github.com/brainlag/JavaNSQClient/pull/28"},"issue":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/issues/28"},"comments":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/brainlag/JavaNSQClient/statuses/269fafe7db61184682f0e194229dcd33426e7323"}}}}
{"actor":{"display_login":"esiqveland"}}