{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/75680429","id":75680429,"diff_hunk":"@@ -2411,6 +2411,67 @@ then\n fi\n # }}}\n \n+# --with-libdpdk {{{\n+AC_ARG_WITH(libdpdk, [AS_HELP_STRING([--with-libdpdk@<:@=PREFIX@:>@], [Path to the DPDK build directory.])],\n+[\n+\tif test \"x$withval\" != \"xno\" && test \"x$withval\" != \"xyes\"\n+\tthen\n+\t\twith_dpdk_path=\"$withval\"\n+\t\twith_libdpdk=\"yes\"\n+\telse\n+\t\tif test \"x$withval\" = \"xno\"\n+\t\tthen\n+\t\t\twith_libdpdk=\"no (disabled)\"\n+\t\tfi\n+\tfi\n+], [with_libdpdk=\"no\"])\n+\n+if test \"x$with_libdpdk\" = \"xyes\"\n+then\n+\tRTE_BUILD=\"$with_dpdk_path\"\n+\tDPDK_INCLUDE=\"$RTE_BUILD/include\"\n+\tAC_CHECK_FILE([$DPDK_INCLUDE/rte_config.h], [LOCAL_DPDK_INSTALL=true],","path":"configure.ac","position":null,"original_position":23,"commit_id":"dbc37ea39ffde66b9bf6f389a7a8f65ab6d7f8f5","original_commit_id":"fc4f5dc7512b5fb7413561766ba8b508b248712c","user":{"login":"kimmariejones","id":19489876,"avatar_url":"https://avatars.githubusercontent.com/u/19489876?v=3","gravatar_id":"","url":"https://api.github.com/users/kimmariejones","html_url":"https://github.com/kimmariejones","followers_url":"https://api.github.com/users/kimmariejones/followers","following_url":"https://api.github.com/users/kimmariejones/following{/other_user}","gists_url":"https://api.github.com/users/kimmariejones/gists{/gist_id}","starred_url":"https://api.github.com/users/kimmariejones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimmariejones/subscriptions","organizations_url":"https://api.github.com/users/kimmariejones/orgs","repos_url":"https://api.github.com/users/kimmariejones/repos","events_url":"https://api.github.com/users/kimmariejones/events{/privacy}","received_events_url":"https://api.github.com/users/kimmariejones/received_events","type":"User","site_admin":false},"body":"Done; no more true & false","created_at":"2016-08-22T13:50:57Z","updated_at":"2016-08-22T13:50:57Z","html_url":"https://github.com/collectd/collectd/pull/1649#discussion_r75680429","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/1649","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/75680429"},"html":{"href":"https://github.com/collectd/collectd/pull/1649#discussion_r75680429"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1649"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/1649","id":65036798,"html_url":"https://github.com/collectd/collectd/pull/1649","diff_url":"https://github.com/collectd/collectd/pull/1649.diff","patch_url":"https://github.com/collectd/collectd/pull/1649.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/1649","number":1649,"state":"open","locked":false,"title":"dpdkstat: enable a plugin for DPDK stats","user":{"login":"maryamtahhan","id":5012288,"avatar_url":"https://avatars.githubusercontent.com/u/5012288?v=3","gravatar_id":"","url":"https://api.github.com/users/maryamtahhan","html_url":"https://github.com/maryamtahhan","followers_url":"https://api.github.com/users/maryamtahhan/followers","following_url":"https://api.github.com/users/maryamtahhan/following{/other_user}","gists_url":"https://api.github.com/users/maryamtahhan/gists{/gist_id}","starred_url":"https://api.github.com/users/maryamtahhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryamtahhan/subscriptions","organizations_url":"https://api.github.com/users/maryamtahhan/orgs","repos_url":"https://api.github.com/users/maryamtahhan/repos","events_url":"https://api.github.com/users/maryamtahhan/events{/privacy}","received_events_url":"https://api.github.com/users/maryamtahhan/received_events","type":"User","site_admin":false},"body":"This patch enables support to retrieve statistics for DPDK interfaces. An overview of the threading is as follows:\r\n\r\n1.  collectd `init()` or `read()` calls `dpdk_helper_spawn()` to retrieve the required size of xstats to allocate.\r\n    1.  DPDK counts ports, stats and length, writing them to shared-memory (SHM).\r\n    2.  DPDK helper (secondary) process quits, allowing cleanup of the shared memory.\r\n2.  collectd resizes shared-memory to size of stats as provided by DPDK.\r\n3.  collectd respawns the DPDK helper.\r\n    1. Helper blocks on a semaphore until told to read the stats from DPDK and write them to SHM.\r\n4.  collectd dispatches statistics\r\n    1.  Thread blocks on semaphore until stats are available.\r\n\r\nThis threading model is required to allow the plugin to detect when the DPDK primary process/application has been killed/reset, and to avoid the plugin from stopping another DPDK primary process from starting. Some extra housekeeping is in place to ensure collectd is never stalled by using `sem_timedwait()` with a timeout. If collectd dies, the helper process will automatically quit after a timeout, as it detects its ppid has changed.\r\n\r\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\r\nSigned-off-by: Maryam Tahhan <maryam.tahhan@intel.com>","created_at":"2016-04-02T12:31:42Z","updated_at":"2016-08-22T13:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a5bbe916369861465dcd76d36631d3a22d152c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/1649/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/1649/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/1649/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/dbc37ea39ffde66b9bf6f389a7a8f65ab6d7f8f5","head":{"label":"maryamtahhan:dpdkstat","ref":"dpdkstat","sha":"dbc37ea39ffde66b9bf6f389a7a8f65ab6d7f8f5","user":{"login":"maryamtahhan","id":5012288,"avatar_url":"https://avatars.githubusercontent.com/u/5012288?v=3","gravatar_id":"","url":"https://api.github.com/users/maryamtahhan","html_url":"https://github.com/maryamtahhan","followers_url":"https://api.github.com/users/maryamtahhan/followers","following_url":"https://api.github.com/users/maryamtahhan/following{/other_user}","gists_url":"https://api.github.com/users/maryamtahhan/gists{/gist_id}","starred_url":"https://api.github.com/users/maryamtahhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryamtahhan/subscriptions","organizations_url":"https://api.github.com/users/maryamtahhan/orgs","repos_url":"https://api.github.com/users/maryamtahhan/repos","events_url":"https://api.github.com/users/maryamtahhan/events{/privacy}","received_events_url":"https://api.github.com/users/maryamtahhan/received_events","type":"User","site_admin":false},"repo":{"id":55240614,"name":"collectd-with-DPDK","full_name":"maryamtahhan/collectd-with-DPDK","owner":{"login":"maryamtahhan","id":5012288,"avatar_url":"https://avatars.githubusercontent.com/u/5012288?v=3","gravatar_id":"","url":"https://api.github.com/users/maryamtahhan","html_url":"https://github.com/maryamtahhan","followers_url":"https://api.github.com/users/maryamtahhan/followers","following_url":"https://api.github.com/users/maryamtahhan/following{/other_user}","gists_url":"https://api.github.com/users/maryamtahhan/gists{/gist_id}","starred_url":"https://api.github.com/users/maryamtahhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryamtahhan/subscriptions","organizations_url":"https://api.github.com/users/maryamtahhan/orgs","repos_url":"https://api.github.com/users/maryamtahhan/repos","events_url":"https://api.github.com/users/maryamtahhan/events{/privacy}","received_events_url":"https://api.github.com/users/maryamtahhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maryamtahhan/collectd-with-DPDK","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":true,"url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK","forks_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/forks","keys_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/teams","hooks_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/hooks","issue_events_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/issues/events{/number}","events_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/events","assignees_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/assignees{/user}","branches_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/branches{/branch}","tags_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/tags","blobs_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/statuses/{sha}","languages_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/languages","stargazers_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/stargazers","contributors_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/contributors","subscribers_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/subscribers","subscription_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/subscription","commits_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/contents/{+path}","compare_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/merges","archive_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/downloads","issues_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/issues{/number}","pulls_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/pulls{/number}","milestones_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/milestones{/number}","notifications_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/labels{/name}","releases_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/releases{/id}","deployments_url":"https://api.github.com/repos/maryamtahhan/collectd-with-DPDK/deployments","created_at":"2016-04-01T15:03:06Z","updated_at":"2016-04-04T10:51:27Z","pushed_at":"2016-08-22T13:46:27Z","git_url":"git://github.com/maryamtahhan/collectd-with-DPDK.git","ssh_url":"git@github.com:maryamtahhan/collectd-with-DPDK.git","clone_url":"https://github.com/maryamtahhan/collectd-with-DPDK.git","svn_url":"https://github.com/maryamtahhan/collectd-with-DPDK","homepage":"http://collectd.org/","size":13913,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"42c129f80a181553ac08b6e8d3484a845c674a07","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2016-08-21T21:18:18Z","pushed_at":"2016-08-22T13:46:28Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":27152,"stargazers_count":1232,"watchers_count":1232,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":698,"mirror_url":null,"open_issues_count":303,"forks":698,"open_issues":303,"watchers":1232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1649"},"html":{"href":"https://github.com/collectd/collectd/pull/1649"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/1649"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/1649/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1649/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1649/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/dbc37ea39ffde66b9bf6f389a7a8f65ab6d7f8f5"}}}}
{"actor":{"display_login":"kimmariejones"}}