{"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/comments/78823634","id":78823634,"diff_hunk":"@@ -49,15 +46,11 @@ public AlignmentController(AlignmentRepository alignmentRepository, EnsemblRepos\n     @RequestMapping(value = \"/StructureMappingQuery\", method = RequestMethod.GET, produces = \"application/json\")\n     @ResponseBody\n     @ResponseStatus(HttpStatus.OK)\n-    public List<Alignment> getPdbAlignmentByEnsemblId(\n+    public List<Alignment> getPdbAlignmentByEnsemblId (\n             @RequestParam @ApiParam(value = \"Input ensembl id. For example ENSP00000483207.2\", required = true, allowMultiple = true) String ensemblId) {\n-        List<Alignment> list = new ArrayList();\n-        try {\n-            List<Alignment> it = alignmentRepository.findByEnsemblId(ensemblId);\n-            list.addAll(it);\n-        } catch (Exception ex) {\n-            ex.printStackTrace();\n-        }\n+        List<Alignment> it = alignmentRepository.findByEnsemblId(ensemblId);","path":"pdb-alignment-api/src/main/java/org/cbioportal/pdb_annotation/web/controllers/AlignmentController.java","position":42,"original_position":42,"commit_id":"9a8b9aa3b0f15e76b0f3d393d5588ad4a222cd75","original_commit_id":"9a8b9aa3b0f15e76b0f3d393d5588ad4a222cd75","user":{"login":"onursumer","id":3604198,"avatar_url":"https://avatars.githubusercontent.com/u/3604198?v=3","gravatar_id":"","url":"https://api.github.com/users/onursumer","html_url":"https://github.com/onursumer","followers_url":"https://api.github.com/users/onursumer/followers","following_url":"https://api.github.com/users/onursumer/following{/other_user}","gists_url":"https://api.github.com/users/onursumer/gists{/gist_id}","starred_url":"https://api.github.com/users/onursumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onursumer/subscriptions","organizations_url":"https://api.github.com/users/onursumer/orgs","repos_url":"https://api.github.com/users/onursumer/repos","events_url":"https://api.github.com/users/onursumer/events{/privacy}","received_events_url":"https://api.github.com/users/onursumer/received_events","type":"User","site_admin":false},"body":"Why do we create another list instead of simply returning the one obtained from the repository? Is it to make sure that we return an `ArrayList`?","created_at":"2016-09-14T19:43:22Z","updated_at":"2016-09-14T19:45:53Z","html_url":"https://github.com/cBioPortal/pdb-annotation/pull/40#discussion_r78823634","pull_request_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/comments/78823634"},"html":{"href":"https://github.com/cBioPortal/pdb-annotation/pull/40#discussion_r78823634"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/40","id":85284270,"html_url":"https://github.com/cBioPortal/pdb-annotation/pull/40","diff_url":"https://github.com/cBioPortal/pdb-annotation/pull/40.diff","patch_url":"https://github.com/cBioPortal/pdb-annotation/pull/40.patch","issue_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/issues/40","number":40,"state":"open","locked":false,"title":"Fix getPdbAlignmentByEnsemblId, plus codestyle update","user":{"login":"sheridancbio","id":7747489,"avatar_url":"https://avatars.githubusercontent.com/u/7747489?v=3","gravatar_id":"","url":"https://api.github.com/users/sheridancbio","html_url":"https://github.com/sheridancbio","followers_url":"https://api.github.com/users/sheridancbio/followers","following_url":"https://api.github.com/users/sheridancbio/following{/other_user}","gists_url":"https://api.github.com/users/sheridancbio/gists{/gist_id}","starred_url":"https://api.github.com/users/sheridancbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheridancbio/subscriptions","organizations_url":"https://api.github.com/users/sheridancbio/orgs","repos_url":"https://api.github.com/users/sheridancbio/repos","events_url":"https://api.github.com/users/sheridancbio/events{/privacy}","received_events_url":"https://api.github.com/users/sheridancbio/received_events","type":"User","site_admin":false},"body":"Correction to service to handle api endpoint getPdbAlignmentByEnsemblId\r\n- controller now queries the ensembl table directly (rather than alignment table)\r\n- move the Autowire annotation to data members rather than having a class constructor\r\n- do not catch/log/bypass exceptions thrown in the controller. Generated exceptions are presented to user instead.\r\nAlso updated code style in a few classes","created_at":"2016-09-14T18:52:32Z","updated_at":"2016-09-14T19:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"095830af5a59a7f017498985ec0ade4c717de385","assignee":{"login":"onursumer","id":3604198,"avatar_url":"https://avatars.githubusercontent.com/u/3604198?v=3","gravatar_id":"","url":"https://api.github.com/users/onursumer","html_url":"https://github.com/onursumer","followers_url":"https://api.github.com/users/onursumer/followers","following_url":"https://api.github.com/users/onursumer/following{/other_user}","gists_url":"https://api.github.com/users/onursumer/gists{/gist_id}","starred_url":"https://api.github.com/users/onursumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onursumer/subscriptions","organizations_url":"https://api.github.com/users/onursumer/orgs","repos_url":"https://api.github.com/users/onursumer/repos","events_url":"https://api.github.com/users/onursumer/events{/privacy}","received_events_url":"https://api.github.com/users/onursumer/received_events","type":"User","site_admin":false},"assignees":[{"login":"onursumer","id":3604198,"avatar_url":"https://avatars.githubusercontent.com/u/3604198?v=3","gravatar_id":"","url":"https://api.github.com/users/onursumer","html_url":"https://github.com/onursumer","followers_url":"https://api.github.com/users/onursumer/followers","following_url":"https://api.github.com/users/onursumer/following{/other_user}","gists_url":"https://api.github.com/users/onursumer/gists{/gist_id}","starred_url":"https://api.github.com/users/onursumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onursumer/subscriptions","organizations_url":"https://api.github.com/users/onursumer/orgs","repos_url":"https://api.github.com/users/onursumer/repos","events_url":"https://api.github.com/users/onursumer/events{/privacy}","received_events_url":"https://api.github.com/users/onursumer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/40/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/40/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/issues/40/comments","statuses_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/statuses/9a8b9aa3b0f15e76b0f3d393d5588ad4a222cd75","head":{"label":"sheridancbio:fix-to-alignmentcontroller","ref":"fix-to-alignmentcontroller","sha":"9a8b9aa3b0f15e76b0f3d393d5588ad4a222cd75","user":{"login":"sheridancbio","id":7747489,"avatar_url":"https://avatars.githubusercontent.com/u/7747489?v=3","gravatar_id":"","url":"https://api.github.com/users/sheridancbio","html_url":"https://github.com/sheridancbio","followers_url":"https://api.github.com/users/sheridancbio/followers","following_url":"https://api.github.com/users/sheridancbio/following{/other_user}","gists_url":"https://api.github.com/users/sheridancbio/gists{/gist_id}","starred_url":"https://api.github.com/users/sheridancbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheridancbio/subscriptions","organizations_url":"https://api.github.com/users/sheridancbio/orgs","repos_url":"https://api.github.com/users/sheridancbio/repos","events_url":"https://api.github.com/users/sheridancbio/events{/privacy}","received_events_url":"https://api.github.com/users/sheridancbio/received_events","type":"User","site_admin":false},"repo":{"id":58162779,"name":"pdb-annotation","full_name":"sheridancbio/pdb-annotation","owner":{"login":"sheridancbio","id":7747489,"avatar_url":"https://avatars.githubusercontent.com/u/7747489?v=3","gravatar_id":"","url":"https://api.github.com/users/sheridancbio","html_url":"https://github.com/sheridancbio","followers_url":"https://api.github.com/users/sheridancbio/followers","following_url":"https://api.github.com/users/sheridancbio/following{/other_user}","gists_url":"https://api.github.com/users/sheridancbio/gists{/gist_id}","starred_url":"https://api.github.com/users/sheridancbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheridancbio/subscriptions","organizations_url":"https://api.github.com/users/sheridancbio/orgs","repos_url":"https://api.github.com/users/sheridancbio/repos","events_url":"https://api.github.com/users/sheridancbio/events{/privacy}","received_events_url":"https://api.github.com/users/sheridancbio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sheridancbio/pdb-annotation","description":"","fork":true,"url":"https://api.github.com/repos/sheridancbio/pdb-annotation","forks_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/forks","keys_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/teams","hooks_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/hooks","issue_events_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/issues/events{/number}","events_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/events","assignees_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/assignees{/user}","branches_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/branches{/branch}","tags_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/tags","blobs_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/git/refs{/sha}","trees_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/statuses/{sha}","languages_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/languages","stargazers_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/stargazers","contributors_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/contributors","subscribers_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/subscribers","subscription_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/subscription","commits_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/commits{/sha}","git_commits_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/git/commits{/sha}","comments_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/comments{/number}","issue_comment_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/issues/comments{/number}","contents_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/contents/{+path}","compare_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/merges","archive_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/downloads","issues_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/issues{/number}","pulls_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/pulls{/number}","milestones_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/milestones{/number}","notifications_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/labels{/name}","releases_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/releases{/id}","deployments_url":"https://api.github.com/repos/sheridancbio/pdb-annotation/deployments","created_at":"2016-05-05T21:50:23Z","updated_at":"2016-05-05T21:50:24Z","pushed_at":"2016-09-14T18:50:20Z","git_url":"git://github.com/sheridancbio/pdb-annotation.git","ssh_url":"git@github.com:sheridancbio/pdb-annotation.git","clone_url":"https://github.com/sheridancbio/pdb-annotation.git","svn_url":"https://github.com/sheridancbio/pdb-annotation","homepage":null,"size":203,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:master","ref":"master","sha":"cff31ea61349be15b66af28200d76d2966bafd78","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":55248861,"name":"pdb-annotation","full_name":"cBioPortal/pdb-annotation","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/pdb-annotation","description":"A standalone component to provide mappings between protein sequence positions and PDB 3D protein structure models","fork":false,"url":"https://api.github.com/repos/cBioPortal/pdb-annotation","forks_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/forks","keys_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/teams","hooks_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/events","assignees_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/tags","blobs_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/subscription","commits_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/merges","archive_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/downloads","issues_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/pdb-annotation/deployments","created_at":"2016-04-01T17:05:41Z","updated_at":"2016-08-18T16:10:06Z","pushed_at":"2016-09-14T18:52:32Z","git_url":"git://github.com/cBioPortal/pdb-annotation.git","ssh_url":"git@github.com:cBioPortal/pdb-annotation.git","clone_url":"https://github.com/cBioPortal/pdb-annotation.git","svn_url":"https://github.com/cBioPortal/pdb-annotation","homepage":"","size":201,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/40"},"html":{"href":"https://github.com/cBioPortal/pdb-annotation/pull/40"},"issue":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/issues/40"},"comments":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/pdb-annotation/statuses/9a8b9aa3b0f15e76b0f3d393d5588ad4a222cd75"}}}}
{"actor":{"display_login":"onursumer"}}