{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/992","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/992/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/992/comments","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/992/events","html_url":"https://github.com/CartoDB/cartodb.js/pull/992","id":126164477,"number":992,"title":"Fix image load infowindow","user":{"login":"javierarce","id":4933,"avatar_url":"https://avatars.githubusercontent.com/u/4933?v=3","gravatar_id":"","url":"https://api.github.com/users/javierarce","html_url":"https://github.com/javierarce","followers_url":"https://api.github.com/users/javierarce/followers","following_url":"https://api.github.com/users/javierarce/following{/other_user}","gists_url":"https://api.github.com/users/javierarce/gists{/gist_id}","starred_url":"https://api.github.com/users/javierarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierarce/subscriptions","organizations_url":"https://api.github.com/users/javierarce/orgs","repos_url":"https://api.github.com/users/javierarce/repos","events_url":"https://api.github.com/users/javierarce/events{/privacy}","received_events_url":"https://api.github.com/users/javierarce/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"javierarce","id":4933,"avatar_url":"https://avatars.githubusercontent.com/u/4933?v=3","gravatar_id":"","url":"https://api.github.com/users/javierarce","html_url":"https://github.com/javierarce","followers_url":"https://api.github.com/users/javierarce/followers","following_url":"https://api.github.com/users/javierarce/following{/other_user}","gists_url":"https://api.github.com/users/javierarce/gists{/gist_id}","starred_url":"https://api.github.com/users/javierarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierarce/subscriptions","organizations_url":"https://api.github.com/users/javierarce/orgs","repos_url":"https://api.github.com/users/javierarce/repos","events_url":"https://api.github.com/users/javierarce/events{/privacy}","received_events_url":"https://api.github.com/users/javierarce/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-01-12T12:00:58Z","updated_at":"2016-01-12T13:43:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/992","html_url":"https://github.com/CartoDB/cartodb.js/pull/992","diff_url":"https://github.com/CartoDB/cartodb.js/pull/992.diff","patch_url":"https://github.com/CartoDB/cartodb.js/pull/992.patch"},"body":"This PR fixes a problem loading custom infowindow templates with images. It also refactor some of the infowindow.js code, makes the loading of the image more pleasant and reviews the infowindow specs.\r\n\r\n\r\nA sample template used to do some of the testing:\r\n\r\n```\r\ntemplate: \"<div class=\\\"CDB-infowindow CDB-infowindow--light js-infowindow has-title has-header-image\\\" data-cover=\\\"true\\\"><div class=\\\"CDB-infowindow-container\\\"><div class=\\\"CDB-infowindow-header CDB-infowindow-headerMedia js-cover\\\"><div class=\\\"CDB-infowindow-mediaTitle\\\"><h4 class=\\\"CDB-infowindow-title\\\"><span>My title</span></h4></div><img src=\\\"https://dl.dropboxusercontent.com/u/24085/infowindow_squared.png\\\"></div><div class=\\\"CDB-hook-image\\\"> <div class=\\\"CDB-hook-image-inner js-hook\\\"></div></div></div></div>\"\r\n```\r\n\r\n```\r\n template: \"<div class=\\\"CDB-infowindow CDB-infowindow--light js-infowindow has-title has-header-image\\\"><div class=\\\"CDB-infowindow-container\\\"><div class=\\\"CDB-infowindow-header CDB-infowindow-headerMedia js-cover\\\"><div class=\\\"CDB-infowindow-mediaTitle\\\"><h4 class=\\\"CDB-infowindow-title\\\"><span>My title</span></h4></div><img src=\\\"https://dl.dropboxusercontent.com/u/24085/infowindow_big.png\\\"></div><div class=\\\"CDB-hook-image\\\"> <div class=\\\"CDB-hook-image-inner js-hook\\\"></div></div></div></div>\"\r\n```"},"comment":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments/170915083","html_url":"https://github.com/CartoDB/cartodb.js/pull/992#issuecomment-170915083","issue_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/992","id":170915083,"user":{"login":"xavijam","id":132146,"avatar_url":"https://avatars.githubusercontent.com/u/132146?v=3","gravatar_id":"","url":"https://api.github.com/users/xavijam","html_url":"https://github.com/xavijam","followers_url":"https://api.github.com/users/xavijam/followers","following_url":"https://api.github.com/users/xavijam/following{/other_user}","gists_url":"https://api.github.com/users/xavijam/gists{/gist_id}","starred_url":"https://api.github.com/users/xavijam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavijam/subscriptions","organizations_url":"https://api.github.com/users/xavijam/orgs","repos_url":"https://api.github.com/users/xavijam/repos","events_url":"https://api.github.com/users/xavijam/events{/privacy}","received_events_url":"https://api.github.com/users/xavijam/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T13:43:44Z","updated_at":"2016-01-12T13:43:44Z","body":"Could we add an example in the v4 branch for testing porpuses? please :)"}}