{"action":"created","issue":{"url":"https://api.github.com/repos/explosion/spaCy/issues/658","repository_url":"https://api.github.com/repos/explosion/spaCy","labels_url":"https://api.github.com/repos/explosion/spaCy/issues/658/labels{/name}","comments_url":"https://api.github.com/repos/explosion/spaCy/issues/658/comments","events_url":"https://api.github.com/repos/explosion/spaCy/issues/658/events","html_url":"https://github.com/explosion/spaCy/pull/658","id":191489020,"number":658,"title":"Add noun_chunks to Span","user":{"login":"pokey","id":755842,"avatar_url":"https://avatars.githubusercontent.com/u/755842?v=3","gravatar_id":"","url":"https://api.github.com/users/pokey","html_url":"https://github.com/pokey","followers_url":"https://api.github.com/users/pokey/followers","following_url":"https://api.github.com/users/pokey/following{/other_user}","gists_url":"https://api.github.com/users/pokey/gists{/gist_id}","starred_url":"https://api.github.com/users/pokey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pokey/subscriptions","organizations_url":"https://api.github.com/users/pokey/orgs","repos_url":"https://api.github.com/users/pokey/repos","events_url":"https://api.github.com/users/pokey/events{/privacy}","received_events_url":"https://api.github.com/users/pokey/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-24T10:50:45Z","updated_at":"2016-11-24T14:39:03Z","closed_at":"2016-11-24T12:33:58Z","pull_request":{"url":"https://api.github.com/repos/explosion/spaCy/pulls/658","html_url":"https://github.com/explosion/spaCy/pull/658","diff_url":"https://github.com/explosion/spaCy/pull/658.diff","patch_url":"https://github.com/explosion/spaCy/pull/658.patch"},"body":"Add noun_chunks to Span\r\n\r\n## Description\r\nSupport iterating noun_chunks of a Span.  Also add `doc` attribute to `Doc`class for uniformity.  Wasn't sure the best way to remove code duplication between `noun_chunks` in `Doc` and `noun_chunks` in `Span`.\r\n\r\n## Motivation and Context\r\nUseful to be able to find noun_chunks in a span, rather than the whole doc.  Eg all noun_chunks in a sentence.\r\n\r\n## How Has This Been Tested?\r\n\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change fixing an issue)\r\n- [x] New feature (non-breaking change adding functionality to spaCy)\r\n- [ ] Breaking change (fix or feature causing change to spaCy's existing functionality)\r\n- [ ] Documentation (Addition to documentation of spaCy)\r\n\r\n## Checklist:\r\n- [x] My code follows spaCy's code style.\r\n- [ ] My change requires a change to spaCy's documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/explosion/spaCy/issues/comments/262790715","html_url":"https://github.com/explosion/spaCy/pull/658#issuecomment-262790715","issue_url":"https://api.github.com/repos/explosion/spaCy/issues/658","id":262790715,"user":{"login":"pokey","id":755842,"avatar_url":"https://avatars.githubusercontent.com/u/755842?v=3","gravatar_id":"","url":"https://api.github.com/users/pokey","html_url":"https://github.com/pokey","followers_url":"https://api.github.com/users/pokey/followers","following_url":"https://api.github.com/users/pokey/following{/other_user}","gists_url":"https://api.github.com/users/pokey/gists{/gist_id}","starred_url":"https://api.github.com/users/pokey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pokey/subscriptions","organizations_url":"https://api.github.com/users/pokey/orgs","repos_url":"https://api.github.com/users/pokey/repos","events_url":"https://api.github.com/users/pokey/events{/privacy}","received_events_url":"https://api.github.com/users/pokey/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T14:39:03Z","updated_at":"2016-11-24T14:39:03Z","body":"Also, why do we use `doc.vocab.strings` at all?  Why not just import the symbols from spacy.symbols?  Then we wouldn't need to access the doc object."}}
{"actor":{"display_login":"pokey"}}