{"action":"opened","issue":{"url":"https://api.github.com/repos/pfnet/chainer/issues/1419","repository_url":"https://api.github.com/repos/pfnet/chainer","labels_url":"https://api.github.com/repos/pfnet/chainer/issues/1419/labels{/name}","comments_url":"https://api.github.com/repos/pfnet/chainer/issues/1419/comments","events_url":"https://api.github.com/repos/pfnet/chainer/issues/1419/events","html_url":"https://github.com/pfnet/chainer/issues/1419","id":167287335,"number":1419,"title":"Errors in numpy-cupy comparison tests are ignored if accept_error=True by default","user":{"login":"muupan","id":815970,"avatar_url":"https://avatars.githubusercontent.com/u/815970?v=3","gravatar_id":"","url":"https://api.github.com/users/muupan","html_url":"https://github.com/muupan","followers_url":"https://api.github.com/users/muupan/followers","following_url":"https://api.github.com/users/muupan/following{/other_user}","gists_url":"https://api.github.com/users/muupan/gists{/gist_id}","starred_url":"https://api.github.com/users/muupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muupan/subscriptions","organizations_url":"https://api.github.com/users/muupan/orgs","repos_url":"https://api.github.com/users/muupan/repos","events_url":"https://api.github.com/users/muupan/events{/privacy}","received_events_url":"https://api.github.com/users/muupan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-25T05:49:17Z","updated_at":"2016-07-25T05:49:17Z","closed_at":null,"body":"`cupy.testing` has decorators for comparing results from numpy and cupy functions such as `numpy_cupy_array_equal`. In these decorators, `accept_error=True` by default, so even if test code has typo or access to undefined names, they would pass. Such decorators are used everywhere without specifying `accept_error=False`: https://github.com/pfnet/chainer/search?utf8=%E2%9C%93&q=numpy_cupy_array_equal&type=Code \r\n\r\nFor example, https://github.com/pfnet/chainer/pull/1404 has typo in test code, calling `xp.fill_diag` instead of `xp.fill_diagonal`, but the tests pass. I suppose errors should not be ignored by default."}}
{"actor":{"display_login":"muupan"}}