{"comment":{"url":"https://api.github.com/repos/bosilca/ompi/comments/19209625","html_url":"https://github.com/bosilca/ompi/commit/3f0bacdfaa2bf52a67a448972a43d0a330df0ed5#commitcomment-19209625","id":19209625,"user":{"login":"bosilca","id":642701,"avatar_url":"https://avatars.githubusercontent.com/u/642701?v=3","gravatar_id":"","url":"https://api.github.com/users/bosilca","html_url":"https://github.com/bosilca","followers_url":"https://api.github.com/users/bosilca/followers","following_url":"https://api.github.com/users/bosilca/following{/other_user}","gists_url":"https://api.github.com/users/bosilca/gists{/gist_id}","starred_url":"https://api.github.com/users/bosilca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosilca/subscriptions","organizations_url":"https://api.github.com/users/bosilca/orgs","repos_url":"https://api.github.com/users/bosilca/repos","events_url":"https://api.github.com/users/bosilca/events{/privacy}","received_events_url":"https://api.github.com/users/bosilca/received_events","type":"User","site_admin":false},"position":151,"line":286,"path":"ompi/mca/pml/monitoring/pml_monitoring_component.c","commit_id":"3f0bacdfaa2bf52a67a448972a43d0a330df0ed5","created_at":"2016-09-28T15:46:22Z","updated_at":"2016-09-28T15:46:22Z","body":"Yes, this prevents a segfault because the MCA variable when freed will free the string associated with it. Thus, whatever is in the mca_pml_monitoring_current_filename upn return from mca_base_var_register, will be freed automatically for us. One might think that this is a good thing, and I have to say that in the most general case it is. However, the way we use the PML monitoring (by preventing the system from doing a dlclose but we don't prevent the system from cleaning things up), led to our MCA variables being released upon the first call to _close. If that happens we segfault."}}
{"actor":{"display_login":"bosilca"}}