{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/70013425","id":70013425,"diff_hunk":"@@ -0,0 +1,113 @@\n+/*\n+ * Copyright © 2016 Cask Data, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+\n+package co.cask.cdap.gateway.handlers;\n+\n+import co.cask.cdap.api.security.store.SecureStore;\n+import co.cask.cdap.api.security.store.SecureStoreData;\n+import co.cask.cdap.api.security.store.SecureStoreManager;\n+import co.cask.cdap.common.BadRequestException;\n+import co.cask.cdap.common.conf.Constants;\n+import co.cask.cdap.gateway.handlers.util.AbstractAppFabricHttpHandler;\n+import co.cask.cdap.proto.security.SecureStoreCreateRequest;\n+import co.cask.http.HttpResponder;\n+import com.google.inject.Inject;\n+import org.jboss.netty.handler.codec.http.HttpRequest;\n+import org.jboss.netty.handler.codec.http.HttpResponseStatus;\n+\n+import java.io.IOException;\n+import javax.ws.rs.DELETE;\n+import javax.ws.rs.GET;\n+import javax.ws.rs.PUT;\n+import javax.ws.rs.Path;\n+import javax.ws.rs.PathParam;\n+\n+/**\n+ * Exposes REST APIs for {@link co.cask.cdap.api.security.store.SecureStore} and\n+ * {@link co.cask.cdap.api.security.store.SecureStoreManager}.\n+ */\n+@Path(Constants.Gateway.API_VERSION_3 + \"/security/store/namespaces/{namespace-id}\")\n+public class SecureStoreHandler extends AbstractAppFabricHttpHandler {\n+\n+  private final SecureStore secureStore;\n+  private final SecureStoreManager secureStoreManager;\n+\n+  @Inject\n+  public SecureStoreHandler(SecureStore secureStore, SecureStoreManager secureStoreManager) {\n+    this.secureStore = secureStore;\n+    this.secureStoreManager = secureStoreManager;\n+  }\n+\n+  @Path(\"/key\")\n+  @PUT\n+  public void create(HttpRequest httpRequest, HttpResponder httpResponder) throws BadRequestException {\n+    // Check authentication\n+    SecureStoreCreateRequest secureStoreCreateRequest = parseBody(httpRequest, SecureStoreCreateRequest.class);\n+\n+    if (secureStoreCreateRequest == null) {\n+      throw new BadRequestException(\"Unable to parse the request.\");\n+    }\n+\n+    String name = secureStoreCreateRequest.getName();\n+    String description = secureStoreCreateRequest.getDescription();\n+    byte[] data = secureStoreCreateRequest.getData();\n+    if (name == null || data == null) {\n+      throw new BadRequestException(\"Name or data empty.\");\n+    }\n+    try {\n+      secureStoreManager.put(name, data, description, secureStoreCreateRequest.getProperties());\n+    } catch (IOException e) {\n+      httpResponder.sendString(HttpResponseStatus.INTERNAL_SERVER_ERROR, \"Failed to store the item in the store.\");\n+      return;\n+    }\n+    httpResponder.sendStatus(HttpResponseStatus.OK);\n+  }\n+\n+  @Path(\"/keys/{key-name}\")\n+  @DELETE\n+  public void delete(HttpRequest httpRequest, HttpResponder httpResponder, @PathParam(\"key-name\") String name) {\n+    try {\n+      secureStoreManager.delete(name);\n+    } catch (IOException e) {\n+      httpResponder.sendString(HttpResponseStatus.INTERNAL_SERVER_ERROR, \"Failed to delete the key.\");\n+      return;\n+    }\n+    httpResponder.sendStatus(HttpResponseStatus.OK);\n+  }\n+\n+  @Path(\"/keys/{key-name}\")\n+  @GET\n+  public void get(HttpRequest httpRequest, HttpResponder httpResponder, @PathParam(\"key-name\") String name) {\n+    SecureStoreData secureStoreData;\n+    try {\n+      secureStoreData = secureStore.get(name);\n+    } catch (IOException e) {\n+      httpResponder.sendString(HttpResponseStatus.INTERNAL_SERVER_ERROR, \"Failed to get the key.\");\n+      return;\n+    }\n+    httpResponder.sendJson(HttpResponseStatus.OK, secureStoreData.get());","path":"cdap-app-fabric/src/main/java/co/cask/cdap/gateway/handlers/SecureStoreHandler.java","position":101,"original_position":101,"commit_id":"22f9a66a82e14f5d01cfc78193b1f12b1a3e3605","original_commit_id":"22f9a66a82e14f5d01cfc78193b1f12b1a3e3605","user":{"login":"anwar6953","id":2440977,"avatar_url":"https://avatars.githubusercontent.com/u/2440977?v=3","gravatar_id":"","url":"https://api.github.com/users/anwar6953","html_url":"https://github.com/anwar6953","followers_url":"https://api.github.com/users/anwar6953/followers","following_url":"https://api.github.com/users/anwar6953/following{/other_user}","gists_url":"https://api.github.com/users/anwar6953/gists{/gist_id}","starred_url":"https://api.github.com/users/anwar6953/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anwar6953/subscriptions","organizations_url":"https://api.github.com/users/anwar6953/orgs","repos_url":"https://api.github.com/users/anwar6953/repos","events_url":"https://api.github.com/users/anwar6953/events{/privacy}","received_events_url":"https://api.github.com/users/anwar6953/received_events","type":"User","site_admin":false},"body":"the `OK` code can be removed (its implicit)","created_at":"2016-07-08T01:09:01Z","updated_at":"2016-07-08T01:09:01Z","html_url":"https://github.com/caskdata/cdap/pull/5991#discussion_r70013425","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/5991","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/70013425"},"html":{"href":"https://github.com/caskdata/cdap/pull/5991#discussion_r70013425"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/5991"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/5991","id":76687087,"html_url":"https://github.com/caskdata/cdap/pull/5991","diff_url":"https://github.com/caskdata/cdap/pull/5991.diff","patch_url":"https://github.com/caskdata/cdap/pull/5991.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/5991","number":5991,"state":"open","locked":false,"title":"Feature/secure storage 2","user":{"login":"Nishith","id":83603,"avatar_url":"https://avatars.githubusercontent.com/u/83603?v=3","gravatar_id":"","url":"https://api.github.com/users/Nishith","html_url":"https://github.com/Nishith","followers_url":"https://api.github.com/users/Nishith/followers","following_url":"https://api.github.com/users/Nishith/following{/other_user}","gists_url":"https://api.github.com/users/Nishith/gists{/gist_id}","starred_url":"https://api.github.com/users/Nishith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nishith/subscriptions","organizations_url":"https://api.github.com/users/Nishith/orgs","repos_url":"https://api.github.com/users/Nishith/repos","events_url":"https://api.github.com/users/Nishith/events{/privacy}","received_events_url":"https://api.github.com/users/Nishith/received_events","type":"User","site_admin":false},"body":"Adds a handler for secure store REST APIs.","created_at":"2016-07-08T00:39:26Z","updated_at":"2016-07-08T01:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b626287585c31904d25ae42fefac0ccf9359d236","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/5991/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/5991/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/5991/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/22f9a66a82e14f5d01cfc78193b1f12b1a3e3605","head":{"label":"caskdata:feature/secure-storage-2","ref":"feature/secure-storage-2","sha":"22f9a66a82e14f5d01cfc78193b1f12b1a3e3605","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-03T08:27:44Z","pushed_at":"2016-07-08T01:08:53Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":620785,"stargazers_count":132,"watchers_count":132,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":17,"forks":45,"open_issues":17,"watchers":132,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"683ea1eead7ae12e6c46d57d2c37feead2b83363","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-03T08:27:44Z","pushed_at":"2016-07-08T01:08:53Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":620785,"stargazers_count":132,"watchers_count":132,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":17,"forks":45,"open_issues":17,"watchers":132,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/5991"},"html":{"href":"https://github.com/caskdata/cdap/pull/5991"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/5991"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/5991/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/5991/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/5991/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/22f9a66a82e14f5d01cfc78193b1f12b1a3e3605"}}}}
{"actor":{"display_login":"anwar6953"}}