{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular.io/issues/2233","repository_url":"https://api.github.com/repos/angular/angular.io","labels_url":"https://api.github.com/repos/angular/angular.io/issues/2233/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular.io/issues/2233/comments","events_url":"https://api.github.com/repos/angular/angular.io/issues/2233/events","html_url":"https://github.com/angular/angular.io/pull/2233","id":174317402,"number":2233,"title":"chore(test): add protractor4","user":{"login":"filipesilva","id":4172079,"avatar_url":"https://avatars.githubusercontent.com/u/4172079?v=3","gravatar_id":"","url":"https://api.github.com/users/filipesilva","html_url":"https://github.com/filipesilva","followers_url":"https://api.github.com/users/filipesilva/followers","following_url":"https://api.github.com/users/filipesilva/following{/other_user}","gists_url":"https://api.github.com/users/filipesilva/gists{/gist_id}","starred_url":"https://api.github.com/users/filipesilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipesilva/subscriptions","organizations_url":"https://api.github.com/users/filipesilva/orgs","repos_url":"https://api.github.com/users/filipesilva/repos","events_url":"https://api.github.com/users/filipesilva/events{/privacy}","received_events_url":"https://api.github.com/users/filipesilva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular.io/labels/CLA:%20yes","name":"CLA: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-31T16:22:01Z","updated_at":"2016-10-06T19:10:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular.io/pulls/2233","html_url":"https://github.com/angular/angular.io/pull/2233","diff_url":"https://github.com/angular/angular.io/pull/2233.diff","patch_url":"https://github.com/angular/angular.io/pull/2233.patch"},"body":"This PR updates Protractor to from version 3 to 4, which is made inTypescript and includes typings.\r\n\r\nSince Protractor4 includes typings, this solves an issue we had with the Upgrade Adapter chapter where Jquery's `$` typings conflicted with Protractors `$`. This issue prevented us from having them in the same node package and was the main motivator for the `_protractor` folder.\r\n\r\nThus, this PR removes the `_protractor` folder and adds Protractor configuration and helpers directly to `_examples`, which solves some editor tooling issues we had because of the indirect path structure for e2e tests.\r\n\r\nBoilerplate files were moved from `_examples` to `_examples/_boilerplate` as well, so that they are contained there and also to be able to use a `tsconfig.json` for Protractor in `_examples` (this was needed for editor tooling purposes). Gulp tasks and plunker generation were adjusted to use this directory.\r\n\r\nSome of the custom logic we had in `protractor.config.js` was moved into `protractor-helpers.ts` since we were attaching it to the `browser` variable, which is now typed and thus threw errors when accessing these custom members. Our custom `sendKeys` was also removed since it's not needed anymore.\r\n\r\nEnd result is that we should have full type safety and editor tooling support in Protractor.\r\n\r\nNote: previous tooling added a git ignored `tsconfig.json` besides each `e2e-spec.ts` file, which should now be removed otherwise editor tooling will not work properly. Overall, after this PR it is a good to run `git clean -fdx` to 'reset' the repo and re-setup our infrastructure.\r\n\r\n/cc @wardbell @chalin @Foxandxss this PR includes some structural changes that I'd like you to look at and see if you approve."},"comment":{"url":"https://api.github.com/repos/angular/angular.io/issues/comments/252059817","html_url":"https://github.com/angular/angular.io/pull/2233#issuecomment-252059817","issue_url":"https://api.github.com/repos/angular/angular.io/issues/2233","id":252059817,"user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T19:10:13Z","updated_at":"2016-10-06T19:10:13Z","body":"So to summarize for @wardbell, we are creating a `_boilerplate` folder where we have everything we share across al the examples.\r\n\r\nThe important bit in here is that the package.json that we are spreading right now only have the npm scripts (just what we need) and there is a package.json at `_examples` that is the one with all the dependencies but not script tags.\r\n\r\nWe now have a less cluttered _examples folder."}}
{"actor":{"display_login":"Foxandxss"}}