{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/core-notes/pulls/comments/91094986","pull_request_review_id":11604618,"id":91094986,"diff_hunk":"@@ -0,0 +1,79 @@\n+# ember-cli Meeting Notes - 2016-12-01\n+\n+## Attendees\n+\n+- Nathan Hammond\n+- Jake Bixby\n+- Tobias Bieniek\n+- Alex Navasardyan\n+- Trent Willis\n+- Gavin Joyce\n+- Kelly Selden\n+- Katie Gengler\n+- Chad Hietala\n+- David Hamilton\n+- Robert Jackson\n+- Miguel Madero\n+ \n+## Actions\n+\n+- [x] Nathan - Land RFC #50.\n+- [x] Nathan - Get access to ember-cli npm user from Stef.\n+- [x] Nathan - [Respond on `ember-cli-release`](https://github.com/ember-cli/ember-cli/issues/6462#issuecomment-264322357)\n+ \n+## Discussion Notes\n+\n+### [RFC #50 Production Code Stripping](https://github.com/ember-cli/rfcs/pull/50)\n+\n+- Given no additional comments in the FCP, this was merged.\n+- Excited to make it happen.\n+- Thanks to @gavinjoyce for bringing it home!\n+ \n+### 2.11.0-beta.1 Postmortem\n+\n+- CI was broken for two weeks leading up to the 2.11.0-beta.1 release.\n+- [This is the fix to what broke us.](https://github.com/stefanpenner/capture-exit/pull/7)\n+  - We threw away the exit code because it was an async exit, but you can't run\n+    async code on top-level exit.","path":"ember-cli/2016-12/december-01.md","position":37,"original_position":37,"commit_id":"bca28f0f9c30b615211ae6683a27cc1fa0d81f3e","original_commit_id":"bca28f0f9c30b615211ae6683a27cc1fa0d81f3e","user":{"login":"hjdivad","id":17980,"avatar_url":"https://avatars.githubusercontent.com/u/17980?v=3","gravatar_id":"","url":"https://api.github.com/users/hjdivad","html_url":"https://github.com/hjdivad","followers_url":"https://api.github.com/users/hjdivad/followers","following_url":"https://api.github.com/users/hjdivad/following{/other_user}","gists_url":"https://api.github.com/users/hjdivad/gists{/gist_id}","starred_url":"https://api.github.com/users/hjdivad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjdivad/subscriptions","organizations_url":"https://api.github.com/users/hjdivad/orgs","repos_url":"https://api.github.com/users/hjdivad/repos","events_url":"https://api.github.com/users/hjdivad/events{/privacy}","received_events_url":"https://api.github.com/users/hjdivad/received_events","type":"User","site_admin":false},"body":"This is not quite correct.\r\n\r\nWe threw away the exit code because we tried to defer exiting after async work during `process.on('exit')`, in which async work is explicitly disallowed.\r\n\r\n\r\nYou actually *can* run async on top-level exit, and we've added support for this in ember-cli/capture-exit#7","created_at":"2016-12-06T15:02:33Z","updated_at":"2016-12-06T15:02:33Z","html_url":"https://github.com/emberjs/core-notes/pull/121#discussion_r91094986","pull_request_url":"https://api.github.com/repos/emberjs/core-notes/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/emberjs/core-notes/pulls/comments/91094986"},"html":{"href":"https://github.com/emberjs/core-notes/pull/121#discussion_r91094986"},"pull_request":{"href":"https://api.github.com/repos/emberjs/core-notes/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/core-notes/pulls/121","id":96657172,"html_url":"https://github.com/emberjs/core-notes/pull/121","diff_url":"https://github.com/emberjs/core-notes/pull/121.diff","patch_url":"https://github.com/emberjs/core-notes/pull/121.patch","issue_url":"https://api.github.com/repos/emberjs/core-notes/issues/121","number":121,"state":"open","locked":false,"title":"Ember CLI 2016-12-01","user":{"login":"nathanhammond","id":20542,"avatar_url":"https://avatars.githubusercontent.com/u/20542?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhammond","html_url":"https://github.com/nathanhammond","followers_url":"https://api.github.com/users/nathanhammond/followers","following_url":"https://api.github.com/users/nathanhammond/following{/other_user}","gists_url":"https://api.github.com/users/nathanhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhammond/subscriptions","organizations_url":"https://api.github.com/users/nathanhammond/orgs","repos_url":"https://api.github.com/users/nathanhammond/repos","events_url":"https://api.github.com/users/nathanhammond/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhammond/received_events","type":"User","site_admin":false},"body":"Reactions for approval, comments for corrections.\r\n\r\n/cc @nathanhammond @trabus @Turbo87 @twokul @trentmwillis @gavinjoyce @kellyselden @kategengler @chadhietala @hjdivad @rwjblue @miguelmadero","created_at":"2016-12-06T04:00:17Z","updated_at":"2016-12-06T15:02:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a70bc361dd31b785da6d99f3c48e8da504b93398","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/core-notes/pulls/121/commits","review_comments_url":"https://api.github.com/repos/emberjs/core-notes/pulls/121/comments","review_comment_url":"https://api.github.com/repos/emberjs/core-notes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/core-notes/issues/121/comments","statuses_url":"https://api.github.com/repos/emberjs/core-notes/statuses/bca28f0f9c30b615211ae6683a27cc1fa0d81f3e","head":{"label":"nathanhammond:ember-cli-2016-12-01","ref":"ember-cli-2016-12-01","sha":"bca28f0f9c30b615211ae6683a27cc1fa0d81f3e","user":{"login":"nathanhammond","id":20542,"avatar_url":"https://avatars.githubusercontent.com/u/20542?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhammond","html_url":"https://github.com/nathanhammond","followers_url":"https://api.github.com/users/nathanhammond/followers","following_url":"https://api.github.com/users/nathanhammond/following{/other_user}","gists_url":"https://api.github.com/users/nathanhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhammond/subscriptions","organizations_url":"https://api.github.com/users/nathanhammond/orgs","repos_url":"https://api.github.com/users/nathanhammond/repos","events_url":"https://api.github.com/users/nathanhammond/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhammond/received_events","type":"User","site_admin":false},"repo":{"id":51551725,"name":"core-notes","full_name":"nathanhammond/core-notes","owner":{"login":"nathanhammond","id":20542,"avatar_url":"https://avatars.githubusercontent.com/u/20542?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhammond","html_url":"https://github.com/nathanhammond","followers_url":"https://api.github.com/users/nathanhammond/followers","following_url":"https://api.github.com/users/nathanhammond/following{/other_user}","gists_url":"https://api.github.com/users/nathanhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhammond/subscriptions","organizations_url":"https://api.github.com/users/nathanhammond/orgs","repos_url":"https://api.github.com/users/nathanhammond/repos","events_url":"https://api.github.com/users/nathanhammond/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhammond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanhammond/core-notes","description":"Meeting minutes from the Ember.js core teams","fork":true,"url":"https://api.github.com/repos/nathanhammond/core-notes","forks_url":"https://api.github.com/repos/nathanhammond/core-notes/forks","keys_url":"https://api.github.com/repos/nathanhammond/core-notes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanhammond/core-notes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanhammond/core-notes/teams","hooks_url":"https://api.github.com/repos/nathanhammond/core-notes/hooks","issue_events_url":"https://api.github.com/repos/nathanhammond/core-notes/issues/events{/number}","events_url":"https://api.github.com/repos/nathanhammond/core-notes/events","assignees_url":"https://api.github.com/repos/nathanhammond/core-notes/assignees{/user}","branches_url":"https://api.github.com/repos/nathanhammond/core-notes/branches{/branch}","tags_url":"https://api.github.com/repos/nathanhammond/core-notes/tags","blobs_url":"https://api.github.com/repos/nathanhammond/core-notes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanhammond/core-notes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanhammond/core-notes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanhammond/core-notes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanhammond/core-notes/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanhammond/core-notes/languages","stargazers_url":"https://api.github.com/repos/nathanhammond/core-notes/stargazers","contributors_url":"https://api.github.com/repos/nathanhammond/core-notes/contributors","subscribers_url":"https://api.github.com/repos/nathanhammond/core-notes/subscribers","subscription_url":"https://api.github.com/repos/nathanhammond/core-notes/subscription","commits_url":"https://api.github.com/repos/nathanhammond/core-notes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanhammond/core-notes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanhammond/core-notes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanhammond/core-notes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathanhammond/core-notes/contents/{+path}","compare_url":"https://api.github.com/repos/nathanhammond/core-notes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanhammond/core-notes/merges","archive_url":"https://api.github.com/repos/nathanhammond/core-notes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanhammond/core-notes/downloads","issues_url":"https://api.github.com/repos/nathanhammond/core-notes/issues{/number}","pulls_url":"https://api.github.com/repos/nathanhammond/core-notes/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanhammond/core-notes/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanhammond/core-notes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanhammond/core-notes/labels{/name}","releases_url":"https://api.github.com/repos/nathanhammond/core-notes/releases{/id}","deployments_url":"https://api.github.com/repos/nathanhammond/core-notes/deployments","created_at":"2016-02-11T22:27:06Z","updated_at":"2016-02-11T06:38:38Z","pushed_at":"2016-12-06T04:00:49Z","git_url":"git://github.com/nathanhammond/core-notes.git","ssh_url":"git@github.com:nathanhammond/core-notes.git","clone_url":"https://github.com/nathanhammond/core-notes.git","svn_url":"https://github.com/nathanhammond/core-notes","homepage":null,"size":377,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"df0dd5917ee96ceea5b9a90b3867e7d8fda29c13","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":38132301,"name":"core-notes","full_name":"emberjs/core-notes","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/core-notes","description":"Meeting minutes from the Ember.js core teams","fork":false,"url":"https://api.github.com/repos/emberjs/core-notes","forks_url":"https://api.github.com/repos/emberjs/core-notes/forks","keys_url":"https://api.github.com/repos/emberjs/core-notes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/core-notes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/core-notes/teams","hooks_url":"https://api.github.com/repos/emberjs/core-notes/hooks","issue_events_url":"https://api.github.com/repos/emberjs/core-notes/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/core-notes/events","assignees_url":"https://api.github.com/repos/emberjs/core-notes/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/core-notes/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/core-notes/tags","blobs_url":"https://api.github.com/repos/emberjs/core-notes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/core-notes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/core-notes/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/core-notes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/core-notes/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/core-notes/languages","stargazers_url":"https://api.github.com/repos/emberjs/core-notes/stargazers","contributors_url":"https://api.github.com/repos/emberjs/core-notes/contributors","subscribers_url":"https://api.github.com/repos/emberjs/core-notes/subscribers","subscription_url":"https://api.github.com/repos/emberjs/core-notes/subscription","commits_url":"https://api.github.com/repos/emberjs/core-notes/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/core-notes/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/core-notes/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/core-notes/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/core-notes/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/core-notes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/core-notes/merges","archive_url":"https://api.github.com/repos/emberjs/core-notes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/core-notes/downloads","issues_url":"https://api.github.com/repos/emberjs/core-notes/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/core-notes/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/core-notes/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/core-notes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/core-notes/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/core-notes/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/core-notes/deployments","created_at":"2015-06-26T20:32:50Z","updated_at":"2016-11-26T23:44:56Z","pushed_at":"2016-12-06T04:00:49Z","git_url":"git://github.com/emberjs/core-notes.git","ssh_url":"git@github.com:emberjs/core-notes.git","clone_url":"https://github.com/emberjs/core-notes.git","svn_url":"https://github.com/emberjs/core-notes","homepage":null,"size":368,"stargazers_count":100,"watchers_count":100,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":2,"forks":21,"open_issues":2,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/core-notes/pulls/121"},"html":{"href":"https://github.com/emberjs/core-notes/pull/121"},"issue":{"href":"https://api.github.com/repos/emberjs/core-notes/issues/121"},"comments":{"href":"https://api.github.com/repos/emberjs/core-notes/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/core-notes/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/core-notes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/core-notes/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/core-notes/statuses/bca28f0f9c30b615211ae6683a27cc1fa0d81f3e"}}}}
{"actor":{"display_login":"hjdivad"}}