{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/vert.x/issues/1602","repository_url":"https://api.github.com/repos/eclipse/vert.x","labels_url":"https://api.github.com/repos/eclipse/vert.x/issues/1602/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/vert.x/issues/1602/comments","events_url":"https://api.github.com/repos/eclipse/vert.x/issues/1602/events","html_url":"https://github.com/eclipse/vert.x/issues/1602","id":174651732,"number":1602,"title":"NetClient with SOCKS Proxy checks wrong hostname on upgradeToSsl()","user":{"login":"alexlehm","id":156144,"avatar_url":"https://avatars.githubusercontent.com/u/156144?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlehm","html_url":"https://github.com/alexlehm","followers_url":"https://api.github.com/users/alexlehm/followers","following_url":"https://api.github.com/users/alexlehm/following{/other_user}","gists_url":"https://api.github.com/users/alexlehm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlehm/subscriptions","organizations_url":"https://api.github.com/users/alexlehm/orgs","repos_url":"https://api.github.com/users/alexlehm/repos","events_url":"https://api.github.com/users/alexlehm/events{/privacy}","received_events_url":"https://api.github.com/users/alexlehm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-01T23:50:14Z","updated_at":"2016-09-03T13:25:34Z","closed_at":null,"body":"When using a NetClient with SOCKS Proxy, the upgradeToSsl() checks the ssl cert against the name of the proxy, not the name of the target server.\r\n\r\nI created a unit test that shows the issue by setting the proxy hostname to 127.0.0.1 and connecting to a server at localhost, this way it fails with \"No subject alternative names matching IP address 127.0.0.1 found\".\r\n\r\nA unlikely usecase, however I got the error when trying to send a mail via smtp with starttls over TOR, which uses SOCKS5 to connect.\r\n"},"comment":{"url":"https://api.github.com/repos/eclipse/vert.x/issues/comments/244546413","html_url":"https://github.com/eclipse/vert.x/issues/1602#issuecomment-244546413","issue_url":"https://api.github.com/repos/eclipse/vert.x/issues/1602","id":244546413,"user":{"login":"alexlehm","id":156144,"avatar_url":"https://avatars.githubusercontent.com/u/156144?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlehm","html_url":"https://github.com/alexlehm","followers_url":"https://api.github.com/users/alexlehm/followers","following_url":"https://api.github.com/users/alexlehm/following{/other_user}","gists_url":"https://api.github.com/users/alexlehm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlehm/subscriptions","organizations_url":"https://api.github.com/users/alexlehm/orgs","repos_url":"https://api.github.com/users/alexlehm/repos","events_url":"https://api.github.com/users/alexlehm/events{/privacy}","received_events_url":"https://api.github.com/users/alexlehm/received_events","type":"User","site_admin":false},"created_at":"2016-09-03T13:25:34Z","updated_at":"2016-09-03T13:25:34Z","body":"https://github.com/eclipse/vert.x/pull/1604"}}
{"actor":{"display_login":"alexlehm"}}