{"action":"created","comment":{"url":"https://api.github.com/repos/jez/vim-better-sml/pulls/comments/55482568","id":55482568,"diff_hunk":"@@ -13,24 +13,20 @@ setlocal iskeyword+='\n setlocal commentstring=(*%s*)\n \n \" ----- Raimondi/delimitMate -----\n-let b:delimitMate_quotes = \"\\\"\"\n+let b:delimitMate_quotes = '\"'\n \n \" ----- scrooloose/syntastic -----\n \" Attempt to detect CM files in SML/NJ checker\n-function! s:DetectCM(fname) abort\n-  let cm = syntastic#util#findGlobInParent('*.cm', fnamemodify(a:fname, ':p:h'))\n-  if cm !=# ''\n-    let buf = bufnr(fnameescape(a:fname))\n-    call setbufvar(buf, 'syntastic_sml_smlnj_args', '-m ' . syntastic#util#shescape(cm))\n-    call setbufvar(buf, 'syntastic_sml_smlnj_fname', '')\n-  endif\n-endfunction\n-\n-call s:DetectCM(expand('<amatch>', 1))","path":"ftplugin/sml.vim","position":18,"original_position":18,"commit_id":"0de8db14133903ffe502524e15a412ced02b9d89","original_commit_id":"0de8db14133903ffe502524e15a412ced02b9d89","user":{"login":"jez","id":5544532,"avatar_url":"https://avatars.githubusercontent.com/u/5544532?v=3","gravatar_id":"","url":"https://api.github.com/users/jez","html_url":"https://github.com/jez","followers_url":"https://api.github.com/users/jez/followers","following_url":"https://api.github.com/users/jez/following{/other_user}","gists_url":"https://api.github.com/users/jez/gists{/gist_id}","starred_url":"https://api.github.com/users/jez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jez/subscriptions","organizations_url":"https://api.github.com/users/jez/orgs","repos_url":"https://api.github.com/users/jez/repos","events_url":"https://api.github.com/users/jez/events{/privacy}","received_events_url":"https://api.github.com/users/jez/received_events","type":"User","site_admin":false},"body":"Do you have an intuitive explanation for what the purpose of `<amatch>` was here? When I looked it up, it said that, \"When executing autocommands, is replaced with the match which this autocommand was executed.\" Here, it looks like you've just replaced it with the filename, which is more similar to what it looked like when I implemented it at first.","created_at":"2016-03-09T08:00:43Z","updated_at":"2016-03-09T08:00:43Z","html_url":"https://github.com/jez/vim-better-sml/pull/2#discussion_r55482568","pull_request_url":"https://api.github.com/repos/jez/vim-better-sml/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/jez/vim-better-sml/pulls/comments/55482568"},"html":{"href":"https://github.com/jez/vim-better-sml/pull/2#discussion_r55482568"},"pull_request":{"href":"https://api.github.com/repos/jez/vim-better-sml/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/jez/vim-better-sml/pulls/2","id":62190378,"html_url":"https://github.com/jez/vim-better-sml/pull/2","diff_url":"https://github.com/jez/vim-better-sml/pull/2.diff","patch_url":"https://github.com/jez/vim-better-sml/pull/2.patch","issue_url":"https://api.github.com/repos/jez/vim-better-sml/issues/2","number":2,"state":"open","locked":false,"title":"Minor cleanup.","user":{"login":"lcd047","id":1281736,"avatar_url":"https://avatars.githubusercontent.com/u/1281736?v=3","gravatar_id":"","url":"https://api.github.com/users/lcd047","html_url":"https://github.com/lcd047","followers_url":"https://api.github.com/users/lcd047/followers","following_url":"https://api.github.com/users/lcd047/following{/other_user}","gists_url":"https://api.github.com/users/lcd047/gists{/gist_id}","starred_url":"https://api.github.com/users/lcd047/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcd047/subscriptions","organizations_url":"https://api.github.com/users/lcd047/orgs","repos_url":"https://api.github.com/users/lcd047/repos","events_url":"https://api.github.com/users/lcd047/events{/privacy}","received_events_url":"https://api.github.com/users/lcd047/received_events","type":"User","site_admin":false},"body":"* `<amatch>` makes sense only in `autocmd`s\r\n* `autocmd`s should be kept from piling up.","created_at":"2016-03-09T07:41:19Z","updated_at":"2016-03-09T08:00:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b710dbc9d2804b836207544d8a639989b8d40fd9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jez/vim-better-sml/pulls/2/commits","review_comments_url":"https://api.github.com/repos/jez/vim-better-sml/pulls/2/comments","review_comment_url":"https://api.github.com/repos/jez/vim-better-sml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jez/vim-better-sml/issues/2/comments","statuses_url":"https://api.github.com/repos/jez/vim-better-sml/statuses/0de8db14133903ffe502524e15a412ced02b9d89","head":{"label":"lcd047:cleanup","ref":"cleanup","sha":"0de8db14133903ffe502524e15a412ced02b9d89","user":{"login":"lcd047","id":1281736,"avatar_url":"https://avatars.githubusercontent.com/u/1281736?v=3","gravatar_id":"","url":"https://api.github.com/users/lcd047","html_url":"https://github.com/lcd047","followers_url":"https://api.github.com/users/lcd047/followers","following_url":"https://api.github.com/users/lcd047/following{/other_user}","gists_url":"https://api.github.com/users/lcd047/gists{/gist_id}","starred_url":"https://api.github.com/users/lcd047/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcd047/subscriptions","organizations_url":"https://api.github.com/users/lcd047/orgs","repos_url":"https://api.github.com/users/lcd047/repos","events_url":"https://api.github.com/users/lcd047/events{/privacy}","received_events_url":"https://api.github.com/users/lcd047/received_events","type":"User","site_admin":false},"repo":{"id":53476915,"name":"vim-better-sml","full_name":"lcd047/vim-better-sml","owner":{"login":"lcd047","id":1281736,"avatar_url":"https://avatars.githubusercontent.com/u/1281736?v=3","gravatar_id":"","url":"https://api.github.com/users/lcd047","html_url":"https://github.com/lcd047","followers_url":"https://api.github.com/users/lcd047/followers","following_url":"https://api.github.com/users/lcd047/following{/other_user}","gists_url":"https://api.github.com/users/lcd047/gists{/gist_id}","starred_url":"https://api.github.com/users/lcd047/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcd047/subscriptions","organizations_url":"https://api.github.com/users/lcd047/orgs","repos_url":"https://api.github.com/users/lcd047/repos","events_url":"https://api.github.com/users/lcd047/events{/privacy}","received_events_url":"https://api.github.com/users/lcd047/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lcd047/vim-better-sml","description":null,"fork":true,"url":"https://api.github.com/repos/lcd047/vim-better-sml","forks_url":"https://api.github.com/repos/lcd047/vim-better-sml/forks","keys_url":"https://api.github.com/repos/lcd047/vim-better-sml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lcd047/vim-better-sml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lcd047/vim-better-sml/teams","hooks_url":"https://api.github.com/repos/lcd047/vim-better-sml/hooks","issue_events_url":"https://api.github.com/repos/lcd047/vim-better-sml/issues/events{/number}","events_url":"https://api.github.com/repos/lcd047/vim-better-sml/events","assignees_url":"https://api.github.com/repos/lcd047/vim-better-sml/assignees{/user}","branches_url":"https://api.github.com/repos/lcd047/vim-better-sml/branches{/branch}","tags_url":"https://api.github.com/repos/lcd047/vim-better-sml/tags","blobs_url":"https://api.github.com/repos/lcd047/vim-better-sml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lcd047/vim-better-sml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lcd047/vim-better-sml/git/refs{/sha}","trees_url":"https://api.github.com/repos/lcd047/vim-better-sml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lcd047/vim-better-sml/statuses/{sha}","languages_url":"https://api.github.com/repos/lcd047/vim-better-sml/languages","stargazers_url":"https://api.github.com/repos/lcd047/vim-better-sml/stargazers","contributors_url":"https://api.github.com/repos/lcd047/vim-better-sml/contributors","subscribers_url":"https://api.github.com/repos/lcd047/vim-better-sml/subscribers","subscription_url":"https://api.github.com/repos/lcd047/vim-better-sml/subscription","commits_url":"https://api.github.com/repos/lcd047/vim-better-sml/commits{/sha}","git_commits_url":"https://api.github.com/repos/lcd047/vim-better-sml/git/commits{/sha}","comments_url":"https://api.github.com/repos/lcd047/vim-better-sml/comments{/number}","issue_comment_url":"https://api.github.com/repos/lcd047/vim-better-sml/issues/comments{/number}","contents_url":"https://api.github.com/repos/lcd047/vim-better-sml/contents/{+path}","compare_url":"https://api.github.com/repos/lcd047/vim-better-sml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lcd047/vim-better-sml/merges","archive_url":"https://api.github.com/repos/lcd047/vim-better-sml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lcd047/vim-better-sml/downloads","issues_url":"https://api.github.com/repos/lcd047/vim-better-sml/issues{/number}","pulls_url":"https://api.github.com/repos/lcd047/vim-better-sml/pulls{/number}","milestones_url":"https://api.github.com/repos/lcd047/vim-better-sml/milestones{/number}","notifications_url":"https://api.github.com/repos/lcd047/vim-better-sml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lcd047/vim-better-sml/labels{/name}","releases_url":"https://api.github.com/repos/lcd047/vim-better-sml/releases{/id}","deployments_url":"https://api.github.com/repos/lcd047/vim-better-sml/deployments","created_at":"2016-03-09T07:20:12Z","updated_at":"2016-03-09T07:20:13Z","pushed_at":"2016-03-09T07:38:04Z","git_url":"git://github.com/lcd047/vim-better-sml.git","ssh_url":"git@github.com:lcd047/vim-better-sml.git","clone_url":"https://github.com/lcd047/vim-better-sml.git","svn_url":"https://github.com/lcd047/vim-better-sml","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jez:master","ref":"master","sha":"6722b3479f84a00115f81d9d4601c1bd73fd4f4f","user":{"login":"jez","id":5544532,"avatar_url":"https://avatars.githubusercontent.com/u/5544532?v=3","gravatar_id":"","url":"https://api.github.com/users/jez","html_url":"https://github.com/jez","followers_url":"https://api.github.com/users/jez/followers","following_url":"https://api.github.com/users/jez/following{/other_user}","gists_url":"https://api.github.com/users/jez/gists{/gist_id}","starred_url":"https://api.github.com/users/jez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jez/subscriptions","organizations_url":"https://api.github.com/users/jez/orgs","repos_url":"https://api.github.com/users/jez/repos","events_url":"https://api.github.com/users/jez/events{/privacy}","received_events_url":"https://api.github.com/users/jez/received_events","type":"User","site_admin":false},"repo":{"id":53469584,"name":"vim-better-sml","full_name":"jez/vim-better-sml","owner":{"login":"jez","id":5544532,"avatar_url":"https://avatars.githubusercontent.com/u/5544532?v=3","gravatar_id":"","url":"https://api.github.com/users/jez","html_url":"https://github.com/jez","followers_url":"https://api.github.com/users/jez/followers","following_url":"https://api.github.com/users/jez/following{/other_user}","gists_url":"https://api.github.com/users/jez/gists{/gist_id}","starred_url":"https://api.github.com/users/jez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jez/subscriptions","organizations_url":"https://api.github.com/users/jez/orgs","repos_url":"https://api.github.com/users/jez/repos","events_url":"https://api.github.com/users/jez/events{/privacy}","received_events_url":"https://api.github.com/users/jez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jez/vim-better-sml","description":null,"fork":false,"url":"https://api.github.com/repos/jez/vim-better-sml","forks_url":"https://api.github.com/repos/jez/vim-better-sml/forks","keys_url":"https://api.github.com/repos/jez/vim-better-sml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jez/vim-better-sml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jez/vim-better-sml/teams","hooks_url":"https://api.github.com/repos/jez/vim-better-sml/hooks","issue_events_url":"https://api.github.com/repos/jez/vim-better-sml/issues/events{/number}","events_url":"https://api.github.com/repos/jez/vim-better-sml/events","assignees_url":"https://api.github.com/repos/jez/vim-better-sml/assignees{/user}","branches_url":"https://api.github.com/repos/jez/vim-better-sml/branches{/branch}","tags_url":"https://api.github.com/repos/jez/vim-better-sml/tags","blobs_url":"https://api.github.com/repos/jez/vim-better-sml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jez/vim-better-sml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jez/vim-better-sml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jez/vim-better-sml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jez/vim-better-sml/statuses/{sha}","languages_url":"https://api.github.com/repos/jez/vim-better-sml/languages","stargazers_url":"https://api.github.com/repos/jez/vim-better-sml/stargazers","contributors_url":"https://api.github.com/repos/jez/vim-better-sml/contributors","subscribers_url":"https://api.github.com/repos/jez/vim-better-sml/subscribers","subscription_url":"https://api.github.com/repos/jez/vim-better-sml/subscription","commits_url":"https://api.github.com/repos/jez/vim-better-sml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jez/vim-better-sml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jez/vim-better-sml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jez/vim-better-sml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jez/vim-better-sml/contents/{+path}","compare_url":"https://api.github.com/repos/jez/vim-better-sml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jez/vim-better-sml/merges","archive_url":"https://api.github.com/repos/jez/vim-better-sml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jez/vim-better-sml/downloads","issues_url":"https://api.github.com/repos/jez/vim-better-sml/issues{/number}","pulls_url":"https://api.github.com/repos/jez/vim-better-sml/pulls{/number}","milestones_url":"https://api.github.com/repos/jez/vim-better-sml/milestones{/number}","notifications_url":"https://api.github.com/repos/jez/vim-better-sml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jez/vim-better-sml/labels{/name}","releases_url":"https://api.github.com/repos/jez/vim-better-sml/releases{/id}","deployments_url":"https://api.github.com/repos/jez/vim-better-sml/deployments","created_at":"2016-03-09T05:02:19Z","updated_at":"2016-03-09T05:14:12Z","pushed_at":"2016-03-09T07:41:19Z","git_url":"git://github.com/jez/vim-better-sml.git","ssh_url":"git@github.com:jez/vim-better-sml.git","clone_url":"https://github.com/jez/vim-better-sml.git","svn_url":"https://github.com/jez/vim-better-sml","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jez/vim-better-sml/pulls/2"},"html":{"href":"https://github.com/jez/vim-better-sml/pull/2"},"issue":{"href":"https://api.github.com/repos/jez/vim-better-sml/issues/2"},"comments":{"href":"https://api.github.com/repos/jez/vim-better-sml/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/jez/vim-better-sml/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/jez/vim-better-sml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jez/vim-better-sml/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/jez/vim-better-sml/statuses/0de8db14133903ffe502524e15a412ced02b9d89"}}}}