{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/83752234","pull_request_review_id":4575112,"id":83752234,"diff_hunk":"@@ -37,9 +37,9 @@ void\n ComputeReturnMappingStress::initialSetup()\n {\n   std::vector<MaterialName> models = getParam<std::vector<MaterialName> >(\"return_mapping_models\");\n-  for (unsigned i = 0; i < models.size(); ++i)\n+  for (unsigned int i = 0; i < models.size(); ++i)\n   {\n-    MooseSharedPointer<RecomputeRadialReturn> rrr = MooseSharedNamespace::dynamic_pointer_cast<RecomputeRadialReturn>(getMaterialSharedPointerByName(models[i]));\n+    StressUpdateBase * rrr = dynamic_cast<StressUpdateBase *>(&getMaterialByName(models[i]));\n     if (rrr)","path":"modules/tensor_mechanics/src/materials/ComputeReturnMappingStress.C","position":32,"original_position":32,"commit_id":"def62d1fe1e39e74809fb205b9797b7e2dbfa8b9","original_commit_id":"def62d1fe1e39e74809fb205b9797b7e2dbfa8b9","user":{"login":"sapitts","id":9342949,"avatar_url":"https://avatars.githubusercontent.com/u/9342949?v=3","gravatar_id":"","url":"https://api.github.com/users/sapitts","html_url":"https://github.com/sapitts","followers_url":"https://api.github.com/users/sapitts/followers","following_url":"https://api.github.com/users/sapitts/following{/other_user}","gists_url":"https://api.github.com/users/sapitts/gists{/gist_id}","starred_url":"https://api.github.com/users/sapitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapitts/subscriptions","organizations_url":"https://api.github.com/users/sapitts/orgs","repos_url":"https://api.github.com/users/sapitts/repos","events_url":"https://api.github.com/users/sapitts/events{/privacy}","received_events_url":"https://api.github.com/users/sapitts/received_events","type":"User","site_admin":false},"body":"oh phew, one thing done correctly today.  Thank you both for the help.  With any luck this will be ready to merge tomorrow morning.","created_at":"2016-10-17T22:57:19Z","updated_at":"2016-10-17T22:57:20Z","html_url":"https://github.com/idaholab/moose/pull/7853#discussion_r83752234","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/7853","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/83752234"},"html":{"href":"https://github.com/idaholab/moose/pull/7853#discussion_r83752234"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7853"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/7853","id":88903298,"html_url":"https://github.com/idaholab/moose/pull/7853","diff_url":"https://github.com/idaholab/moose/pull/7853.diff","patch_url":"https://github.com/idaholab/moose/pull/7853.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/7853","number":7853,"state":"open","locked":false,"title":"New base class for discrete/recompute stress materials","user":{"login":"sapitts","id":9342949,"avatar_url":"https://avatars.githubusercontent.com/u/9342949?v=3","gravatar_id":"","url":"https://api.github.com/users/sapitts","html_url":"https://github.com/sapitts","followers_url":"https://api.github.com/users/sapitts/followers","following_url":"https://api.github.com/users/sapitts/following{/other_user}","gists_url":"https://api.github.com/users/sapitts/gists{/gist_id}","starred_url":"https://api.github.com/users/sapitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapitts/subscriptions","organizations_url":"https://api.github.com/users/sapitts/orgs","repos_url":"https://api.github.com/users/sapitts/repos","events_url":"https://api.github.com/users/sapitts/events{/privacy}","received_events_url":"https://api.github.com/users/sapitts/received_events","type":"User","site_admin":false},"body":"### Relevant design information\r\nLimiting the use of the recompute (`compute = false`) materials to just radial return mapping was too restrictive; this commit adds a new base class for the recompute materials, named `UpdateReturnMappingStressBase`.  The existing radial return material inherits from this new base class, and new non-radial return materials can also inherit from this base class.\r\n\r\n### Test cases\r\n~~No test cases are modified in this commit.~~ Updated the inheriting classes and the class names in the tests folders; no tests were regolded.\r\n\r\n@bwspenc and/or @dschwen  please review so that @acasagran can use this class in his open pore compression model.\r\n\r\nCloses #7847","created_at":"2016-10-11T20:19:01Z","updated_at":"2016-10-17T22:57:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cfa348e075f097352d4b738f768bd3314a28a2c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/7853/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/7853/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/7853/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/def62d1fe1e39e74809fb205b9797b7e2dbfa8b9","head":{"label":"sapitts:recomputeUpdateStress_baseClass_7847","ref":"recomputeUpdateStress_baseClass_7847","sha":"def62d1fe1e39e74809fb205b9797b7e2dbfa8b9","user":{"login":"sapitts","id":9342949,"avatar_url":"https://avatars.githubusercontent.com/u/9342949?v=3","gravatar_id":"","url":"https://api.github.com/users/sapitts","html_url":"https://github.com/sapitts","followers_url":"https://api.github.com/users/sapitts/followers","following_url":"https://api.github.com/users/sapitts/following{/other_user}","gists_url":"https://api.github.com/users/sapitts/gists{/gist_id}","starred_url":"https://api.github.com/users/sapitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapitts/subscriptions","organizations_url":"https://api.github.com/users/sapitts/orgs","repos_url":"https://api.github.com/users/sapitts/repos","events_url":"https://api.github.com/users/sapitts/events{/privacy}","received_events_url":"https://api.github.com/users/sapitts/received_events","type":"User","site_admin":false},"repo":{"id":30090565,"name":"moose","full_name":"sapitts/moose","owner":{"login":"sapitts","id":9342949,"avatar_url":"https://avatars.githubusercontent.com/u/9342949?v=3","gravatar_id":"","url":"https://api.github.com/users/sapitts","html_url":"https://github.com/sapitts","followers_url":"https://api.github.com/users/sapitts/followers","following_url":"https://api.github.com/users/sapitts/following{/other_user}","gists_url":"https://api.github.com/users/sapitts/gists{/gist_id}","starred_url":"https://api.github.com/users/sapitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapitts/subscriptions","organizations_url":"https://api.github.com/users/sapitts/orgs","repos_url":"https://api.github.com/users/sapitts/repos","events_url":"https://api.github.com/users/sapitts/events{/privacy}","received_events_url":"https://api.github.com/users/sapitts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sapitts/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/sapitts/moose","forks_url":"https://api.github.com/repos/sapitts/moose/forks","keys_url":"https://api.github.com/repos/sapitts/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sapitts/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sapitts/moose/teams","hooks_url":"https://api.github.com/repos/sapitts/moose/hooks","issue_events_url":"https://api.github.com/repos/sapitts/moose/issues/events{/number}","events_url":"https://api.github.com/repos/sapitts/moose/events","assignees_url":"https://api.github.com/repos/sapitts/moose/assignees{/user}","branches_url":"https://api.github.com/repos/sapitts/moose/branches{/branch}","tags_url":"https://api.github.com/repos/sapitts/moose/tags","blobs_url":"https://api.github.com/repos/sapitts/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sapitts/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sapitts/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/sapitts/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sapitts/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/sapitts/moose/languages","stargazers_url":"https://api.github.com/repos/sapitts/moose/stargazers","contributors_url":"https://api.github.com/repos/sapitts/moose/contributors","subscribers_url":"https://api.github.com/repos/sapitts/moose/subscribers","subscription_url":"https://api.github.com/repos/sapitts/moose/subscription","commits_url":"https://api.github.com/repos/sapitts/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/sapitts/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/sapitts/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/sapitts/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/sapitts/moose/contents/{+path}","compare_url":"https://api.github.com/repos/sapitts/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sapitts/moose/merges","archive_url":"https://api.github.com/repos/sapitts/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sapitts/moose/downloads","issues_url":"https://api.github.com/repos/sapitts/moose/issues{/number}","pulls_url":"https://api.github.com/repos/sapitts/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/sapitts/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/sapitts/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sapitts/moose/labels{/name}","releases_url":"https://api.github.com/repos/sapitts/moose/releases{/id}","deployments_url":"https://api.github.com/repos/sapitts/moose/deployments","created_at":"2015-01-30T21:01:05Z","updated_at":"2016-02-17T22:22:37Z","pushed_at":"2016-10-17T21:49:36Z","git_url":"git://github.com/sapitts/moose.git","ssh_url":"git@github.com:sapitts/moose.git","clone_url":"https://github.com/sapitts/moose.git","svn_url":"https://github.com/sapitts/moose","homepage":null,"size":147330,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"c9bc94932793e5022cc6ae6b18315d2e7b66e2ec","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2016-10-13T18:10:17Z","pushed_at":"2016-10-17T21:49:36Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":163802,"stargazers_count":172,"watchers_count":172,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"open_issues_count":694,"forks":280,"open_issues":694,"watchers":172,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7853"},"html":{"href":"https://github.com/idaholab/moose/pull/7853"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/7853"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/7853/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7853/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7853/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/def62d1fe1e39e74809fb205b9797b7e2dbfa8b9"}}}}
{"actor":{"display_login":"sapitts"}}