{"action":"created","issue":{"url":"https://api.github.com/repos/WaterfallMC/Waterfall/issues/20","repository_url":"https://api.github.com/repos/WaterfallMC/Waterfall","labels_url":"https://api.github.com/repos/WaterfallMC/Waterfall/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/WaterfallMC/Waterfall/issues/20/comments","events_url":"https://api.github.com/repos/WaterfallMC/Waterfall/issues/20/events","html_url":"https://github.com/WaterfallMC/Waterfall/issues/20","id":130061111,"number":20,"title":"Handle empty packets","user":{"login":"Techcable","id":4615889,"avatar_url":"https://avatars.githubusercontent.com/u/4615889?v=3","gravatar_id":"","url":"https://api.github.com/users/Techcable","html_url":"https://github.com/Techcable","followers_url":"https://api.github.com/users/Techcable/followers","following_url":"https://api.github.com/users/Techcable/following{/other_user}","gists_url":"https://api.github.com/users/Techcable/gists{/gist_id}","starred_url":"https://api.github.com/users/Techcable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Techcable/subscriptions","organizations_url":"https://api.github.com/users/Techcable/orgs","repos_url":"https://api.github.com/users/Techcable/repos","events_url":"https://api.github.com/users/Techcable/events{/privacy}","received_events_url":"https://api.github.com/users/Techcable/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/WaterfallMC/Waterfall/labels/bug","name":"bug","color":"d10800"}],"state":"open","locked":false,"assignee":{"login":"Techcable","id":4615889,"avatar_url":"https://avatars.githubusercontent.com/u/4615889?v=3","gravatar_id":"","url":"https://api.github.com/users/Techcable","html_url":"https://github.com/Techcable","followers_url":"https://api.github.com/users/Techcable/followers","following_url":"https://api.github.com/users/Techcable/following{/other_user}","gists_url":"https://api.github.com/users/Techcable/gists{/gist_id}","starred_url":"https://api.github.com/users/Techcable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Techcable/subscriptions","organizations_url":"https://api.github.com/users/Techcable/orgs","repos_url":"https://api.github.com/users/Techcable/repos","events_url":"https://api.github.com/users/Techcable/events{/privacy}","received_events_url":"https://api.github.com/users/Techcable/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-01-31T01:25:43Z","updated_at":"2016-02-11T23:31:50Z","closed_at":null,"body":"According to @Byteflux 1.7 clients sometimes send empty packets.\r\n[This line](https://github.com/WaterfallMC/Waterfall/blob/master/protocol/src/main/java/net/md_5/bungee/protocol/Varint21FrameDecoder.java#L34) causes the client to be kicked when they do.\r\n\r\nSince its a valid packet, we shouldn't kick the client.\r\n\r\nWe can't just ignore the packets, as that would allow a denial of service attack.\r\n\r\nI think i'm going to limit the number of empty packets that can be sent to about 5 a second.\r\nApparently they don't send them that often."},"comment":{"url":"https://api.github.com/repos/WaterfallMC/Waterfall/issues/comments/183103553","html_url":"https://github.com/WaterfallMC/Waterfall/issues/20#issuecomment-183103553","issue_url":"https://api.github.com/repos/WaterfallMC/Waterfall/issues/20","id":183103553,"user":{"login":"Techcable","id":4615889,"avatar_url":"https://avatars.githubusercontent.com/u/4615889?v=3","gravatar_id":"","url":"https://api.github.com/users/Techcable","html_url":"https://github.com/Techcable","followers_url":"https://api.github.com/users/Techcable/followers","following_url":"https://api.github.com/users/Techcable/following{/other_user}","gists_url":"https://api.github.com/users/Techcable/gists{/gist_id}","starred_url":"https://api.github.com/users/Techcable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Techcable/subscriptions","organizations_url":"https://api.github.com/users/Techcable/orgs","repos_url":"https://api.github.com/users/Techcable/repos","events_url":"https://api.github.com/users/Techcable/events{/privacy}","received_events_url":"https://api.github.com/users/Techcable/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T23:31:50Z","updated_at":"2016-02-11T23:31:50Z","body":"This has been un-fixed by ab461f3"}}