{"action":"created","issue":{"url":"https://api.github.com/repos/magfest/ubersystem/issues/1593","repository_url":"https://api.github.com/repos/magfest/ubersystem","labels_url":"https://api.github.com/repos/magfest/ubersystem/issues/1593/labels{/name}","comments_url":"https://api.github.com/repos/magfest/ubersystem/issues/1593/comments","events_url":"https://api.github.com/repos/magfest/ubersystem/issues/1593/events","html_url":"https://github.com/magfest/ubersystem/pull/1593","id":119216377,"number":1593,"title":"Add date to some email subjects","user":{"login":"binary1230","id":5413064,"avatar_url":"https://avatars.githubusercontent.com/u/5413064?v=3","gravatar_id":"","url":"https://api.github.com/users/binary1230","html_url":"https://github.com/binary1230","followers_url":"https://api.github.com/users/binary1230/followers","following_url":"https://api.github.com/users/binary1230/following{/other_user}","gists_url":"https://api.github.com/users/binary1230/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1230/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1230/subscriptions","organizations_url":"https://api.github.com/users/binary1230/orgs","repos_url":"https://api.github.com/users/binary1230/repos","events_url":"https://api.github.com/users/binary1230/events{/privacy}","received_events_url":"https://api.github.com/users/binary1230/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-11-27T15:53:40Z","updated_at":"2016-02-25T22:49:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/magfest/ubersystem/pulls/1593","html_url":"https://github.com/magfest/ubersystem/pull/1593","diff_url":"https://github.com/magfest/ubersystem/pull/1593.diff","patch_url":"https://github.com/magfest/ubersystem/pull/1593.patch"},"body":"this is most of the work in fixing https://github.com/magfest/ubersystem/issues/1494\r\nChange subject lines for various emails to not just say \"Magfest\" but say \"Magfest Feb 18 2016\"\r\n\r\nbefore: \"Magfest shifts available\"\r\nafter: \"Magfest Feb 18 2016 shifts available\"\r\n\r\nI only changed the subject lines of emails that (I think) aren't already sent.  this will need to be checked very carefully.  After mag2016 is done, we can change the other ones (though will have to be careful about anthrocon merging in this stuff by accident).\r\n\r\nThis brings up a slightly different question of, if there's a better way to uniquely ID emails instead of by subject line, so that we can change the subject lines without having to be really careful about it.  I have an idea I'll open a ticket for.\r\n\r\nI definitely want @kitsuta and @EliAndrewC to look at this, and before it's merged we need to triple-check it's not going to re-send any existing emails."},"comment":{"url":"https://api.github.com/repos/magfest/ubersystem/issues/comments/189018297","html_url":"https://github.com/magfest/ubersystem/pull/1593#issuecomment-189018297","issue_url":"https://api.github.com/repos/magfest/ubersystem/issues/1593","id":189018297,"user":{"login":"EliAndrewC","id":651592,"avatar_url":"https://avatars.githubusercontent.com/u/651592?v=3","gravatar_id":"","url":"https://api.github.com/users/EliAndrewC","html_url":"https://github.com/EliAndrewC","followers_url":"https://api.github.com/users/EliAndrewC/followers","following_url":"https://api.github.com/users/EliAndrewC/following{/other_user}","gists_url":"https://api.github.com/users/EliAndrewC/gists{/gist_id}","starred_url":"https://api.github.com/users/EliAndrewC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EliAndrewC/subscriptions","organizations_url":"https://api.github.com/users/EliAndrewC/orgs","repos_url":"https://api.github.com/users/EliAndrewC/repos","events_url":"https://api.github.com/users/EliAndrewC/events{/privacy}","received_events_url":"https://api.github.com/users/EliAndrewC/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T22:49:38Z","updated_at":"2016-02-25T22:49:38Z","body":"> Yes, so can we just use EVENT_NAME_AND_YEAR instead of hard-coding the date like in this PR?\r\n\r\nI'm tentatively okay with using ``c.EVENT_NAME_AND_YEAR`` if we do the following:\r\n\r\n1) Make {{year}} a required, non-blank option; at present it can be blank.  In fact it WAS blank for MAGFest this year!  Seriously - we noticed while coding that it was never set, so a bunch of places where we'd have expected to see \"MAGFest 2016\" just said \"MAGFest\".\r\n\r\n2) Change the documentation in ``configspec.ini`` for ``year`` to indicate that it's intended to refer to the calendar year.  At present, the idea is that you could either use the calendar year or the name of the event, e.g. next MAGFest could be either ``2017`` or ``15``, according to the intention of the ``year`` config setting."}}