{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments/70707990","id":70707990,"diff_hunk":"@@ -0,0 +1,431 @@\n+/**\n+ * Copyright 2015 Red Hat, Inc. and/or its affiliates.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+*/\n+\n+// Parts of this file are modified code from org.exolab.castor.builder.SourceGenerator.","path":"drools-compiler/src/main/java/org/drools/compiler/runtime/pipeline/impl/castor/DroolsExtendedSourceGenerator.java","position":16,"original_position":16,"commit_id":"63e247ee438a6c18baf5321f831348d660744c98","original_commit_id":"63e247ee438a6c18baf5321f831348d660744c98","user":{"login":"mrietveld","id":783550,"avatar_url":"https://avatars.githubusercontent.com/u/783550?v=3","gravatar_id":"","url":"https://api.github.com/users/mrietveld","html_url":"https://github.com/mrietveld","followers_url":"https://api.github.com/users/mrietveld/followers","following_url":"https://api.github.com/users/mrietveld/following{/other_user}","gists_url":"https://api.github.com/users/mrietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/mrietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrietveld/subscriptions","organizations_url":"https://api.github.com/users/mrietveld/orgs","repos_url":"https://api.github.com/users/mrietveld/repos","events_url":"https://api.github.com/users/mrietveld/events{/privacy}","received_events_url":"https://api.github.com/users/mrietveld/received_events","type":"User","site_admin":false},"body":"Below is the Intalio license that's added.","created_at":"2016-07-13T21:01:54Z","updated_at":"2016-07-13T21:01:54Z","html_url":"https://github.com/droolsjbpm/drools/pull/836#discussion_r70707990","pull_request_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/836","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments/70707990"},"html":{"href":"https://github.com/droolsjbpm/drools/pull/836#discussion_r70707990"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/836"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/836","id":77358271,"html_url":"https://github.com/droolsjbpm/drools/pull/836","diff_url":"https://github.com/droolsjbpm/drools/pull/836.diff","patch_url":"https://github.com/droolsjbpm/drools/pull/836.patch","issue_url":"https://api.github.com/repos/droolsjbpm/drools/issues/836","number":836,"state":"open","locked":false,"title":"DROOLS-355 - Migrating DroolsJaxbHelperImpl from XJC/CodeModel code to a different framework","user":{"login":"mrietveld","id":783550,"avatar_url":"https://avatars.githubusercontent.com/u/783550?v=3","gravatar_id":"","url":"https://api.github.com/users/mrietveld","html_url":"https://github.com/mrietveld","followers_url":"https://api.github.com/users/mrietveld/followers","following_url":"https://api.github.com/users/mrietveld/following{/other_user}","gists_url":"https://api.github.com/users/mrietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/mrietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrietveld/subscriptions","organizations_url":"https://api.github.com/users/mrietveld/orgs","repos_url":"https://api.github.com/users/mrietveld/repos","events_url":"https://api.github.com/users/mrietveld/events{/privacy}","received_events_url":"https://api.github.com/users/mrietveld/received_events","type":"User","site_admin":false},"body":"Related PR's: \r\n- https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/239\r\n- https://github.com/droolsjbpm/droolsjbpm-knowledge/pull/149\r\n- https://github.com/droolsjbpm/drools/pull/836\r\n\r\nThere are several downsides to this pull request: see below. \r\n\r\n## TL;DR: \r\n\r\nThis works, but if @mariofusco or @mdproctor think that the downsides are too large, I'm willing to look further at other libraries that could fix this. (But I'm not completely sure that they exist.. )\r\n\r\n## Actual downsides\r\n\r\n1. Castor will *always* create a directory tree in the (Java process) working directory that mirrors the package structure. This is hardcoded into the Castor code here:   \r\n  -  https://github.com/castor-data-binding/castor/blob/master/codegen/src/main/java/org/exolab/javasource/JStructure.java#L440\r\n  - The actual (generated Java class) files are of course not created, but stored into `ByteArrayInputStream`s so that they can be converted to `Resource`s. \r\n2. This introduces 2 (new?) licenses to the drools project\r\n  -  The Intalio license\r\n    - See [here](https://github.com/droolsjbpm/drools/pull/836/files#diff-aa4aaa5a6c8bc037eaaab52112e298beR16).\r\n  - The Oracle (GPLv2) license\r\n    - See [here](https://github.com/droolsjbpm/drools/pull/836/files#diff-c089fd078b54c0e1301355529e268eecR4)\r\n3. While the functionality is _almost_ identical, I've noticed some minor changes with regards to how the classes are generated. \r\n  - Luckily, IMHO, the changes are better. For example generated class field names and methods are \"better\"/correspond more to what a user might expect. \r\n\r\n\r\n","created_at":"2016-07-13T20:43:06Z","updated_at":"2016-07-13T21:01:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb81328ca3a0f22750f858ce9065a4e3e959939f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/836/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/836/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/issues/836/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/drools/statuses/63e247ee438a6c18baf5321f831348d660744c98","head":{"label":"mrietveld:pr-DROOLS-355","ref":"pr-DROOLS-355","sha":"63e247ee438a6c18baf5321f831348d660744c98","user":{"login":"mrietveld","id":783550,"avatar_url":"https://avatars.githubusercontent.com/u/783550?v=3","gravatar_id":"","url":"https://api.github.com/users/mrietveld","html_url":"https://github.com/mrietveld","followers_url":"https://api.github.com/users/mrietveld/followers","following_url":"https://api.github.com/users/mrietveld/following{/other_user}","gists_url":"https://api.github.com/users/mrietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/mrietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrietveld/subscriptions","organizations_url":"https://api.github.com/users/mrietveld/orgs","repos_url":"https://api.github.com/users/mrietveld/repos","events_url":"https://api.github.com/users/mrietveld/events{/privacy}","received_events_url":"https://api.github.com/users/mrietveld/received_events","type":"User","site_admin":false},"repo":{"id":2085924,"name":"drools","full_name":"mrietveld/drools","owner":{"login":"mrietveld","id":783550,"avatar_url":"https://avatars.githubusercontent.com/u/783550?v=3","gravatar_id":"","url":"https://api.github.com/users/mrietveld","html_url":"https://github.com/mrietveld","followers_url":"https://api.github.com/users/mrietveld/followers","following_url":"https://api.github.com/users/mrietveld/following{/other_user}","gists_url":"https://api.github.com/users/mrietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/mrietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrietveld/subscriptions","organizations_url":"https://api.github.com/users/mrietveld/orgs","repos_url":"https://api.github.com/users/mrietveld/repos","events_url":"https://api.github.com/users/mrietveld/events{/privacy}","received_events_url":"https://api.github.com/users/mrietveld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrietveld/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":true,"url":"https://api.github.com/repos/mrietveld/drools","forks_url":"https://api.github.com/repos/mrietveld/drools/forks","keys_url":"https://api.github.com/repos/mrietveld/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrietveld/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrietveld/drools/teams","hooks_url":"https://api.github.com/repos/mrietveld/drools/hooks","issue_events_url":"https://api.github.com/repos/mrietveld/drools/issues/events{/number}","events_url":"https://api.github.com/repos/mrietveld/drools/events","assignees_url":"https://api.github.com/repos/mrietveld/drools/assignees{/user}","branches_url":"https://api.github.com/repos/mrietveld/drools/branches{/branch}","tags_url":"https://api.github.com/repos/mrietveld/drools/tags","blobs_url":"https://api.github.com/repos/mrietveld/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrietveld/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrietveld/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrietveld/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrietveld/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/mrietveld/drools/languages","stargazers_url":"https://api.github.com/repos/mrietveld/drools/stargazers","contributors_url":"https://api.github.com/repos/mrietveld/drools/contributors","subscribers_url":"https://api.github.com/repos/mrietveld/drools/subscribers","subscription_url":"https://api.github.com/repos/mrietveld/drools/subscription","commits_url":"https://api.github.com/repos/mrietveld/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrietveld/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrietveld/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrietveld/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrietveld/drools/contents/{+path}","compare_url":"https://api.github.com/repos/mrietveld/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrietveld/drools/merges","archive_url":"https://api.github.com/repos/mrietveld/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrietveld/drools/downloads","issues_url":"https://api.github.com/repos/mrietveld/drools/issues{/number}","pulls_url":"https://api.github.com/repos/mrietveld/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/mrietveld/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/mrietveld/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrietveld/drools/labels{/name}","releases_url":"https://api.github.com/repos/mrietveld/drools/releases{/id}","deployments_url":"https://api.github.com/repos/mrietveld/drools/deployments","created_at":"2011-07-21T21:53:00Z","updated_at":"2016-02-26T18:42:01Z","pushed_at":"2016-07-13T20:59:21Z","git_url":"git://github.com/mrietveld/drools.git","ssh_url":"git@github.com:mrietveld/drools.git","clone_url":"https://github.com/mrietveld/drools.git","svn_url":"https://github.com/mrietveld/drools","homepage":"http://www.jboss.org/drools","size":133659,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"27d5023c50e1eb0179878a32b61a4582f8ad5bc7","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":1381673,"name":"drools","full_name":"droolsjbpm/drools","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":false,"url":"https://api.github.com/repos/droolsjbpm/drools","forks_url":"https://api.github.com/repos/droolsjbpm/drools/forks","keys_url":"https://api.github.com/repos/droolsjbpm/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/drools/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/drools/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/drools/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/drools/events","assignees_url":"https://api.github.com/repos/droolsjbpm/drools/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/drools/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/drools/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/drools/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/drools/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/drools/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/drools/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/drools/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/drools/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/drools/merges","archive_url":"https://api.github.com/repos/droolsjbpm/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/drools/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/drools/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/drools/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/drools/releases{/id}","deployments_url":"https://api.github.com/repos/droolsjbpm/drools/deployments","created_at":"2011-02-18T08:37:05Z","updated_at":"2016-07-13T11:00:07Z","pushed_at":"2016-07-13T20:59:21Z","git_url":"git://github.com/droolsjbpm/drools.git","ssh_url":"git@github.com:droolsjbpm/drools.git","clone_url":"https://github.com/droolsjbpm/drools.git","svn_url":"https://github.com/droolsjbpm/drools","homepage":"http://www.drools.org","size":239846,"stargazers_count":652,"watchers_count":652,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":895,"mirror_url":null,"open_issues_count":12,"forks":895,"open_issues":12,"watchers":652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/836"},"html":{"href":"https://github.com/droolsjbpm/drools/pull/836"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/drools/issues/836"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/drools/issues/836/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/836/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/836/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/drools/statuses/63e247ee438a6c18baf5321f831348d660744c98"}}}}
{"actor":{"display_login":"mrietveld"}}