{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/comments/86764948","pull_request_review_id":7396988,"id":86764948,"diff_hunk":"@@ -250,15 +306,24 @@ impl SignedMessage {\n         &self.content\n     }\n \n-    /// The `PublicId` associated with the signed message\n-    pub fn public_id(&self) -> &PublicId {\n-        &self.public_id\n-    }\n-\n     /// The priority Crust should send this message with.\n     pub fn priority(&self) -> u8 {\n         self.content.priority()\n     }\n+\n+    /// Returns whether there are enough valid signatures from the sender.\n+    pub fn is_fully_signed(&self) -> bool {\n+        if self.content.src.is_client() {","path":"src/messages.rs","position":191,"original_position":191,"commit_id":"78d9e70d6bf4406c050bb47c4564a770a384431d","original_commit_id":"78d9e70d6bf4406c050bb47c4564a770a384431d","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"body":"Why do we have this separate check (with a more stringent condition requiring `len() == 1`) for clients?","created_at":"2016-11-07T12:23:28Z","updated_at":"2016-11-07T12:59:21Z","html_url":"https://github.com/maidsafe/routing/pull/1200#discussion_r86764948","pull_request_url":"https://api.github.com/repos/maidsafe/routing/pulls/1200","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments/86764948"},"html":{"href":"https://github.com/maidsafe/routing/pull/1200#discussion_r86764948"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1200"}}},"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1200","id":92450980,"html_url":"https://github.com/maidsafe/routing/pull/1200","diff_url":"https://github.com/maidsafe/routing/pull/1200.diff","patch_url":"https://github.com/maidsafe/routing/pull/1200.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1200","number":1200,"state":"open","locked":false,"title":"MAID-1675 Accumulate messages in the first hop","user":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-05T11:47:47Z","updated_at":"2016-11-07T12:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc3c35077526874aacf8622bbc977c313776840f","assignee":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/1200/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/1200/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1200/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/78d9e70d6bf4406c050bb47c4564a770a384431d","head":{"label":"afck:new_acc","ref":"new_acc","sha":"78d9e70d6bf4406c050bb47c4564a770a384431d","user":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"repo":{"id":49193846,"name":"routing","full_name":"afck/routing","owner":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afck/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/afck/routing","forks_url":"https://api.github.com/repos/afck/routing/forks","keys_url":"https://api.github.com/repos/afck/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afck/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afck/routing/teams","hooks_url":"https://api.github.com/repos/afck/routing/hooks","issue_events_url":"https://api.github.com/repos/afck/routing/issues/events{/number}","events_url":"https://api.github.com/repos/afck/routing/events","assignees_url":"https://api.github.com/repos/afck/routing/assignees{/user}","branches_url":"https://api.github.com/repos/afck/routing/branches{/branch}","tags_url":"https://api.github.com/repos/afck/routing/tags","blobs_url":"https://api.github.com/repos/afck/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afck/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afck/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/afck/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afck/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/afck/routing/languages","stargazers_url":"https://api.github.com/repos/afck/routing/stargazers","contributors_url":"https://api.github.com/repos/afck/routing/contributors","subscribers_url":"https://api.github.com/repos/afck/routing/subscribers","subscription_url":"https://api.github.com/repos/afck/routing/subscription","commits_url":"https://api.github.com/repos/afck/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/afck/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/afck/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/afck/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/afck/routing/contents/{+path}","compare_url":"https://api.github.com/repos/afck/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afck/routing/merges","archive_url":"https://api.github.com/repos/afck/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afck/routing/downloads","issues_url":"https://api.github.com/repos/afck/routing/issues{/number}","pulls_url":"https://api.github.com/repos/afck/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/afck/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/afck/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afck/routing/labels{/name}","releases_url":"https://api.github.com/repos/afck/routing/releases{/id}","deployments_url":"https://api.github.com/repos/afck/routing/deployments","created_at":"2016-01-07T09:06:48Z","updated_at":"2016-01-11T08:55:20Z","pushed_at":"2016-11-05T11:46:55Z","git_url":"git://github.com/afck/routing.git","ssh_url":"git@github.com:afck/routing.git","clone_url":"https://github.com/afck/routing.git","svn_url":"https://github.com/afck/routing","homepage":null,"size":34889,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"d4ce7d055b7721e6077330a38772054ec61d9d04","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"name":"routing","full_name":"maidsafe/routing","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/routing/deployments","created_at":"2015-02-24T16:52:53Z","updated_at":"2016-11-06T21:08:28Z","pushed_at":"2016-11-07T12:48:35Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":106170,"stargazers_count":106,"watchers_count":106,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":10,"forks":37,"open_issues":10,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1200"},"html":{"href":"https://github.com/maidsafe/routing/pull/1200"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1200"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1200/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1200/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1200/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/78d9e70d6bf4406c050bb47c4564a770a384431d"}}}}
{"actor":{"display_login":"Fraser999"}}