{"push_id":1027916958,"size":4,"distinct_size":4,"ref":"refs/heads/auto","head":"ba07b349c831ea14ec3dba8c1f7f689044d7462b","before":"debce07d1bed66f94cc9d4a97272ac838e33612b","commits":[{"sha":"7c27f3d70240fc639cd81789ecaea353443166e0","author":{"email":"0c4ef17994f82486b6796a3c46585026e0b2f05d@users.sf.net","name":"Olaf Buddenhagen"},"message":"Linux: Fix error check for mktemp()\n\nThe man page says that on error the name is set to an empty string. That\nmeans it's \"\", i.e. a pointer to '\\0' -- *not* a NULL pointer!\n\nThis prevented errors in mktemp() from being detected; resulting in\nother failures later on, when trying to use the empty string as a socket\naddress...","distinct":true,"url":"https://api.github.com/repos/servo/ipc-channel/commits/7c27f3d70240fc639cd81789ecaea353443166e0"},{"sha":"8e2357604f7af8869b489b9682a2cf8b58177637","author":{"email":"0c4ef17994f82486b6796a3c46585026e0b2f05d@users.sf.net","name":"Olaf Buddenhagen"},"message":"Linux: Use correct function to obtain '\\0'-terminated C string\n\nCString::as_bytes() yields a slice that does *not* include the\nterminating '\\0' byte; while the surrounding code subsequently copied\nthe (unterminated) sequence, and passed the result to various libc\nfunction expecting a terminated string.\n\nThis is a serious bug, causing random failure depending on unrelated\nmemory contents following the copied vector. It triggered more or less\nfrequent intermittent failures in the test suite (frequency depending on\nvarious other circumstances randomly causing changes in memory\nlayout/contents); and it seems very likely that similar intermittent\nfailures were triggered in actual application usage.","distinct":true,"url":"https://api.github.com/repos/servo/ipc-channel/commits/8e2357604f7af8869b489b9682a2cf8b58177637"},{"sha":"b99cd1a7f987e26c5d5e6843f5c5256c414b193b","author":{"email":"0c4ef17994f82486b6796a3c46585026e0b2f05d@users.sf.net","name":"Olaf Buddenhagen"},"message":"Linux: Make sure sockaddr.sun_path is always '\\0'-terminated\n\nNever fill the last byte of the buffer, so the string always stays\nterminated.\n\nWhile not all implementation strictly need that, the man page strongly\nrecommends it.\n\nThis shouldn't actually make a difference for our present use case, as\nthe (constant) string we are using is much shorter anyways. Still,\nbetter to have it correct -- who knows where this code ends up down the\nline...","distinct":true,"url":"https://api.github.com/repos/servo/ipc-channel/commits/b99cd1a7f987e26c5d5e6843f5c5256c414b193b"},{"sha":"ba07b349c831ea14ec3dba8c1f7f689044d7462b","author":{"email":"1d30da7446c147361b50ba946a7897e87cc888f4@mozilla.com","name":"bors-servo"},"message":"Auto merge of #52 - antrik:fix-sockaddr, r=pcwalton\n\nFix bugs in handling of socket addresses\n\nThe main commit (the third one, about obtaining '\\0'-terminated C strings) addresses a pretty serious bug, which is quite likely causing some intermittent failures. The others are minor.\n\nThis also includes a commit with general improvement to some existing test cases, which is not strictly related to the issue at hand, but helped debugging it.","distinct":true,"url":"https://api.github.com/repos/servo/ipc-channel/commits/ba07b349c831ea14ec3dba8c1f7f689044d7462b"}]}