{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/72875552","id":72875552,"diff_hunk":"@@ -554,6 +554,7 @@ func TestServerContextCanceledOnClosedConnection(t *testing.T) {\n \tcase <-time.After(5 * time.Second):\n \t\tt.Fatalf(\"Failed to cancel the context of the sever side stream.\")\n \t}\n+\tserver.stop()","path":"transport/transport_test.go","position":4,"original_position":4,"commit_id":"e844ad054edc52f5a3365068fccb75d2aba03b17","original_commit_id":"e844ad054edc52f5a3365068fccb75d2aba03b17","user":{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false},"body":"revert this? This has been checked in by another pr.","created_at":"2016-07-29T23:45:36Z","updated_at":"2016-07-29T23:45:36Z","html_url":"https://github.com/grpc/grpc-go/pull/768#discussion_r72875552","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/768","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/72875552"},"html":{"href":"https://github.com/grpc/grpc-go/pull/768#discussion_r72875552"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/768"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/768","id":77692037,"html_url":"https://github.com/grpc/grpc-go/pull/768","diff_url":"https://github.com/grpc/grpc-go/pull/768.diff","patch_url":"https://github.com/grpc/grpc-go/pull/768.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/768","number":768,"state":"open","locked":false,"title":"Return error on bad certificates","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"body":"fixes #622 \r\n - `Dial()` with `withblock()` will return error.\r\n  - In the case of bad certificates, it will return the original error received from creds\r\n - `FailFast` RPCs will return an RPC error (containing error string received from creds)\r\n - `Non-FailFast` RPCs\r\n  - If balancer is not provided, will return an RPC error (containing error string received from creds)\r\n  - If balancer is provided, will block until timeout","created_at":"2016-07-15T23:36:25Z","updated_at":"2016-07-29T23:45:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"345061b34af750e4a68414105e25b7cc356ede35","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/768/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/768/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/768/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/e844ad054edc52f5a3365068fccb75d2aba03b17","head":{"label":"menghanl:fatal_on_bad_certificates","ref":"fatal_on_bad_certificates","sha":"e844ad054edc52f5a3365068fccb75d2aba03b17","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"repo":{"id":54156883,"name":"grpc-go","full_name":"menghanl/grpc-go","owner":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/menghanl/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/menghanl/grpc-go","forks_url":"https://api.github.com/repos/menghanl/grpc-go/forks","keys_url":"https://api.github.com/repos/menghanl/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menghanl/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menghanl/grpc-go/teams","hooks_url":"https://api.github.com/repos/menghanl/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/menghanl/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/menghanl/grpc-go/events","assignees_url":"https://api.github.com/repos/menghanl/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/menghanl/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/menghanl/grpc-go/tags","blobs_url":"https://api.github.com/repos/menghanl/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menghanl/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menghanl/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/menghanl/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menghanl/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/menghanl/grpc-go/languages","stargazers_url":"https://api.github.com/repos/menghanl/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/menghanl/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/menghanl/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/menghanl/grpc-go/subscription","commits_url":"https://api.github.com/repos/menghanl/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/menghanl/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/menghanl/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/menghanl/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/menghanl/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/menghanl/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menghanl/grpc-go/merges","archive_url":"https://api.github.com/repos/menghanl/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menghanl/grpc-go/downloads","issues_url":"https://api.github.com/repos/menghanl/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/menghanl/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/menghanl/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/menghanl/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menghanl/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/menghanl/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/menghanl/grpc-go/deployments","created_at":"2016-03-17T22:55:39Z","updated_at":"2016-03-17T22:55:40Z","pushed_at":"2016-07-29T23:07:01Z","git_url":"git://github.com/menghanl/grpc-go.git","ssh_url":"git@github.com:menghanl/grpc-go.git","clone_url":"https://github.com/menghanl/grpc-go.git","svn_url":"https://github.com/menghanl/grpc-go","homepage":"","size":2227,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"06d68ef15155a5e5f7f1f6e298dfcfb47e002f4e","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-07-29T21:23:21Z","pushed_at":"2016-07-29T23:20:32Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":3173,"stargazers_count":2000,"watchers_count":2000,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":312,"mirror_url":null,"open_issues_count":77,"forks":312,"open_issues":77,"watchers":2000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/768"},"html":{"href":"https://github.com/grpc/grpc-go/pull/768"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/768"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/e844ad054edc52f5a3365068fccb75d2aba03b17"}}}}
{"actor":{"display_login":"iamqizhao"}}