{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/ServiceInsight/issues/648","repository_url":"https://api.github.com/repos/Particular/ServiceInsight","labels_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/648/labels{/name}","comments_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/648/comments","events_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/648/events","html_url":"https://github.com/Particular/ServiceInsight/pull/648","id":191415520,"number":648,"title":"[WIP] Displaying <Null> for empty/null property values in SagaView. ","user":{"login":"HEskandari","id":132117,"avatar_url":"https://avatars.githubusercontent.com/u/132117?v=3","gravatar_id":"","url":"https://api.github.com/users/HEskandari","html_url":"https://github.com/HEskandari","followers_url":"https://api.github.com/users/HEskandari/followers","following_url":"https://api.github.com/users/HEskandari/following{/other_user}","gists_url":"https://api.github.com/users/HEskandari/gists{/gist_id}","starred_url":"https://api.github.com/users/HEskandari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEskandari/subscriptions","organizations_url":"https://api.github.com/users/HEskandari/orgs","repos_url":"https://api.github.com/users/HEskandari/repos","events_url":"https://api.github.com/users/HEskandari/events{/privacy}","received_events_url":"https://api.github.com/users/HEskandari/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-11-24T01:38:56Z","updated_at":"2016-12-06T09:57:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/648","html_url":"https://github.com/Particular/ServiceInsight/pull/648","diff_url":"https://github.com/Particular/ServiceInsight/pull/648.diff","patch_url":"https://github.com/Particular/ServiceInsight/pull/648.patch"},"body":"Resolves #642\r\n\r\nThe saga data values are are stored as serialized json objects without types information. All the primitive values are received in SI as a string. The lack of value were signified with an empty string, which is now displayed as \"<Null>\" instead. Given the lack of type information, I think this is the best that could be done.\r\n\r\nHere's how it looks now:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/132117/20584030/f0a6a41e-b242-11e6-8633-26603a2cadb0.png)\r\n\r\n@Particular/serviceinsight-maintainers please review at your convenience. "},"comment":{"url":"https://api.github.com/repos/Particular/ServiceInsight/issues/comments/265108147","html_url":"https://github.com/Particular/ServiceInsight/pull/648#issuecomment-265108147","issue_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/648","id":265108147,"user":{"login":"HEskandari","id":132117,"avatar_url":"https://avatars.githubusercontent.com/u/132117?v=3","gravatar_id":"","url":"https://api.github.com/users/HEskandari","html_url":"https://github.com/HEskandari","followers_url":"https://api.github.com/users/HEskandari/followers","following_url":"https://api.github.com/users/HEskandari/following{/other_user}","gists_url":"https://api.github.com/users/HEskandari/gists{/gist_id}","starred_url":"https://api.github.com/users/HEskandari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEskandari/subscriptions","organizations_url":"https://api.github.com/users/HEskandari/orgs","repos_url":"https://api.github.com/users/HEskandari/repos","events_url":"https://api.github.com/users/HEskandari/events{/privacy}","received_events_url":"https://api.github.com/users/HEskandari/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T09:57:01Z","updated_at":"2016-12-06T09:57:01Z","body":"We've decided to keep the scope of this PR to fix the bug only. The styling part will be done separately as a part of issue #666. I'll update the PR accordingly."}}
{"actor":{"display_login":"HEskandari"}}