{"action":"created","issue":{"url":"https://api.github.com/repos/KC3Kai/KC3Kai/issues/1249","repository_url":"https://api.github.com/repos/KC3Kai/KC3Kai","labels_url":"https://api.github.com/repos/KC3Kai/KC3Kai/issues/1249/labels{/name}","comments_url":"https://api.github.com/repos/KC3Kai/KC3Kai/issues/1249/comments","events_url":"https://api.github.com/repos/KC3Kai/KC3Kai/issues/1249/events","html_url":"https://github.com/KC3Kai/KC3Kai/issues/1249","id":144987747,"number":1249,"title":"subtitle quotes translation support","user":{"login":"Javran","id":1096354,"avatar_url":"https://avatars.githubusercontent.com/u/1096354?v=3","gravatar_id":"","url":"https://api.github.com/users/Javran","html_url":"https://github.com/Javran","followers_url":"https://api.github.com/users/Javran/followers","following_url":"https://api.github.com/users/Javran/following{/other_user}","gists_url":"https://api.github.com/users/Javran/gists{/gist_id}","starred_url":"https://api.github.com/users/Javran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Javran/subscriptions","organizations_url":"https://api.github.com/users/Javran/orgs","repos_url":"https://api.github.com/users/Javran/repos","events_url":"https://api.github.com/users/Javran/events{/privacy}","received_events_url":"https://api.github.com/users/Javran/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/KC3Kai/KC3Kai/labels/discussing","name":"discussing","color":"cc317c"},{"url":"https://api.github.com/repos/KC3Kai/KC3Kai/labels/enhancement","name":"enhancement","color":"bfe5bf"},{"url":"https://api.github.com/repos/KC3Kai/KC3Kai/labels/rework","name":"rework","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-31T18:57:21Z","updated_at":"2016-04-09T03:30:59Z","closed_at":null,"body":"now subtitle supports have been pushed to master branch, lots of translations are needed.\r\nhere are some ideas about adding better support for translators:\r\n\r\n- use descriptions as line keys rather than using the number\r\n\r\ncurrent keys are numbers\r\n```javascript\r\n...\r\n   \"80\": {\r\n        \"1\": \"I am Battleship Nagato, pleased to meet you. Leave the enemy battleships to me.\",\r\n        \"25\": \"Born as the first battleship of the 8-8 fleet programme, the nameship of the Nagato-class battleships, Nagato. Until Yamato was commissioned, I served as the flagship of the Combined Fleet. I was called one of the 'Big 7'.\",\r\n        \"2\": \"What is it?\",\r\n...\r\n```\r\n\r\nit could be easier for translators if the keys are more descriptive:\r\n```javascript\r\n...\r\n   \"80\": {\r\n        \"Intro\": \"I am Battleship Nagato, pleased to meet you. Leave the enemy battleships to me.\",\r\n        \"Library\": \"Born as the first battleship of the 8-8 fleet programme, the nameship of the Nagato-class battleships, Nagato. Until Yamato was commissioned, I served as the flagship of the Combined Fleet. I was called one of the 'Big 7'.\",\r\n        \"Poke(1)\": \"What is it?\",\r\n...\r\n```\r\n\r\nthe mapping between numbers and descriptions has been established in:\r\nhttps://github.com/KC3Kai/KC3Kai/blob/master/src/pages/strategy/tabs/mstship/mstship.js#L12-L66\r\n\r\nso we can either change numbers to descriptions or having some helper program to allow translators to write out \"descriptive-key\" version and convert to the current one.\r\n\r\n- reuse pre-remodel ship quotes\r\n\r\nas many ships are just reusing quotes of their pre-remodel version, in `quotes.json` we can just add quotes that are different or missing from their pre-remodel version. and we can use https://github.com/KC3Kai/KC3Kai/blob/master/src/library/modules/RemodelDb.js to figure out ship id before remodeling, so there is no need to put pre-remodel relation into quotes.json\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KC3Kai/KC3Kai/issues/comments/207693828","html_url":"https://github.com/KC3Kai/KC3Kai/issues/1249#issuecomment-207693828","issue_url":"https://api.github.com/repos/KC3Kai/KC3Kai/issues/1249","id":207693828,"user":{"login":"Javran","id":1096354,"avatar_url":"https://avatars.githubusercontent.com/u/1096354?v=3","gravatar_id":"","url":"https://api.github.com/users/Javran","html_url":"https://github.com/Javran","followers_url":"https://api.github.com/users/Javran/followers","following_url":"https://api.github.com/users/Javran/following{/other_user}","gists_url":"https://api.github.com/users/Javran/gists{/gist_id}","starred_url":"https://api.github.com/users/Javran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Javran/subscriptions","organizations_url":"https://api.github.com/users/Javran/orgs","repos_url":"https://api.github.com/users/Javran/repos","events_url":"https://api.github.com/users/Javran/events{/privacy}","received_events_url":"https://api.github.com/users/Javran/received_events","type":"User","site_admin":false},"created_at":"2016-04-09T03:30:59Z","updated_at":"2016-04-09T03:30:59Z","body":"All done:\r\n\r\n- no special handling on English version, as it'll be used as the last resort if anything is missing.\r\n- #1264 implements both features as described in OP\r\n- a tool for converting to use descriptive key: KC3Kai/kc3-translations/pull/98\r\n    - note that if both numeric key and descriptive key are used, the latter will be used, so I'd suggest converting all `quotes.json` (except for English version) using this tool after PRs being merged."}}