{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/10464","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10464/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10464/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10464/events","html_url":"https://github.com/joomla/joomla-cms/pull/10464","id":154877278,"number":10464,"title":"[plg_system_sef] Add sef URI when using srcset attribute","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-14T21:46:46Z","updated_at":"2016-05-18T07:46:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10464","html_url":"https://github.com/joomla/joomla-cms/pull/10464","diff_url":"https://github.com/joomla/joomla-cms/pull/10464.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10464.patch"},"body":"Pull Request for Issue https://github.com/joomla/joomla-cms/issues/10463.\r\n\r\n#### Summary of Changes\r\n\r\nSee https://github.com/joomla/joomla-cms/issues/10463\r\n\r\n#### Testing Instructions\r\n\r\n- Use SEF URL (global config + sef system plugin)\r\n- Add an image in an article with this html (or equivalent)\r\n```html\r\n<img src=\"images/sampledata/parks/banner_cradle.jpg\" srcset=\"images/sampledata/parks/banner_cradle.jpg\" alt=\"yyy\" />\r\n```\r\n- Check in the frontend the srcset attribute URL is NOT converted to SEF URL (misses the base path).\r\n- Apply patch\r\n- Check in the frontend the srcset attribute URL is converted to SEF URL (in this example, should be `/images/sampledata/parks/banner_cradle.jpg` or `/<sitepath>/images/sampledata/parks/banner_cradle.jpg`)\r\n\r\nPlease note this will not solve all `srcset` possibilities, only for cases like the one described in the issue (path to one image)."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/219951081","html_url":"https://github.com/joomla/joomla-cms/pull/10464#issuecomment-219951081","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10464","id":219951081,"user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T07:46:18Z","updated_at":"2016-05-18T07:46:18Z","body":"I have tested this item :white_check_mark: successfully on 84743103b45937f64fe194a035c4961cc83d2a16<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/10464\">issues.joomla.org/joomla-cms/10464</a>.</sub>"}}