{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/DscResources/issues/182","repository_url":"https://api.github.com/repos/PowerShell/DscResources","labels_url":"https://api.github.com/repos/PowerShell/DscResources/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/DscResources/issues/182/comments","events_url":"https://api.github.com/repos/PowerShell/DscResources/issues/182/events","html_url":"https://github.com/PowerShell/DscResources/pull/182","id":174412382,"number":182,"title":"Large update to contributing doc","user":{"login":"kwirkykat","id":6372220,"avatar_url":"https://avatars.githubusercontent.com/u/6372220?v=3","gravatar_id":"","url":"https://api.github.com/users/kwirkykat","html_url":"https://github.com/kwirkykat","followers_url":"https://api.github.com/users/kwirkykat/followers","following_url":"https://api.github.com/users/kwirkykat/following{/other_user}","gists_url":"https://api.github.com/users/kwirkykat/gists{/gist_id}","starred_url":"https://api.github.com/users/kwirkykat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwirkykat/subscriptions","organizations_url":"https://api.github.com/users/kwirkykat/orgs","repos_url":"https://api.github.com/users/kwirkykat/repos","events_url":"https://api.github.com/users/kwirkykat/events{/privacy}","received_events_url":"https://api.github.com/users/kwirkykat/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PowerShell/DscResources/labels/cla-not-required","name":"cla-not-required","color":"009800"},{"url":"https://api.github.com/repos/PowerShell/DscResources/labels/needs%20review","name":"needs review","color":"99ff33"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-01T00:50:42Z","updated_at":"2016-09-01T18:25:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PowerShell/DscResources/pulls/182","html_url":"https://github.com/PowerShell/DscResources/pull/182","diff_url":"https://github.com/PowerShell/DscResources/pull/182.diff","patch_url":"https://github.com/PowerShell/DscResources/pull/182.patch"},"body":"I updated the contributor instructions document to include sections on how to submit an issue and how to review a pull request with Reviewable.\r\n\r\nI also updated the other sections on fixing an issue, submitting a pull request, writing documentation, and submitting new resources/resource modules.\r\n\r\nProbably easier to view the rendered markdown file in my fork [here](https://github.com/kwirkykat/DscResources/blob/UpdateContributingDoc/CONTRIBUTING.md).\r\n\r\nThis update purposefully does not include more specific instructions surrounding writing tests as both a new testing document and updates to the testing templates are currently in progress. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/DscResources/issues/comments/244168063","html_url":"https://github.com/PowerShell/DscResources/pull/182#issuecomment-244168063","issue_url":"https://api.github.com/repos/PowerShell/DscResources/issues/182","id":244168063,"user":{"login":"mbreakey3","id":18012846,"avatar_url":"https://avatars.githubusercontent.com/u/18012846?v=3","gravatar_id":"","url":"https://api.github.com/users/mbreakey3","html_url":"https://github.com/mbreakey3","followers_url":"https://api.github.com/users/mbreakey3/followers","following_url":"https://api.github.com/users/mbreakey3/following{/other_user}","gists_url":"https://api.github.com/users/mbreakey3/gists{/gist_id}","starred_url":"https://api.github.com/users/mbreakey3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbreakey3/subscriptions","organizations_url":"https://api.github.com/users/mbreakey3/orgs","repos_url":"https://api.github.com/users/mbreakey3/repos","events_url":"https://api.github.com/users/mbreakey3/events{/privacy}","received_events_url":"https://api.github.com/users/mbreakey3/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T18:25:53Z","updated_at":"2016-09-01T18:25:53Z","body":"\n\n\n\nReview status: 0 of 24 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[CONTRIBUTING.md, line 14 \\[r2\\]](https://reviewable.io:443/reviews/powershell/dscresources/182#-KQarpyisF7ORDFnP9k5:-KQarpyisF7ORDFnP9k6:b-2r2d6m) ([raw file](https://github.com/powershell/dscresources/blob/c3891f5bcdf19e149dfc97e86d2ad8b19007cf36/CONTRIBUTING.md#L14)):*\n> ```Markdown\n> * [Review pull requests](#reviewing-pull-requests) \n> \n> If you're just starting out with GitHub, start by reading our [guide to getting started with GitHub](GettingStartedWithGitHub.md).\n> ```\n\nRight now this links to the doc in your fork - will this change when it gets merged?\n\n---\n\n*[CONTRIBUTING.md, line 37 \\[r2\\]](https://reviewable.io:443/reviews/powershell/dscresources/182#-KQastkgm4z7Z0XRWIb3:-KQastkgm4z7Z0XRWIb4:bwsoelr) ([raw file](https://github.com/powershell/dscresources/blob/c3891f5bcdf19e149dfc97e86d2ad8b19007cf36/CONTRIBUTING.md#L37)):*\n> ```Markdown\n> | <ul><li> Common tests </li><li> Meta-fixers </li></ul> | [DscResource.Tests](https://github.com/PowerShell/DscResource.Tests)\n> | <ul><li> Specific resource </li><li> Resource proposal </li></ul> | The repository of the resource module that contains/should contain the resource. |\n> | <ul><li> Specific resource module </li></ul> | The repository of that resource module |\n> ```\n\nMake this a little more specific like: Any bugs, enhancements, etc. to a specific resource or module\n\n---\n\n*[CONTRIBUTING.md, line 48 \\[r2\\]](https://reviewable.io:443/reviews/powershell/dscresources/182#-KQatTR6NCaqQa0F70CW:-KQatTR6NCaqQa0F70CX:b37f2v5) ([raw file](https://github.com/powershell/dscresources/blob/c3891f5bcdf19e149dfc97e86d2ad8b19007cf36/CONTRIBUTING.md#L48)):*\n> ```Markdown\n> ```\n> \n> All DSC resource modules are also listed as submodules of this repository under the [xDscResources](xDscResources) and [DscResources](DscResources) folders.\n> ```\n\nThis link to the DscResources isn't working currently either\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/powershell/dscresources/182)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mbreakey3"}}