{"action":"created","issue":{"url":"https://api.github.com/repos/sethvargo/go-fastly/issues/11","repository_url":"https://api.github.com/repos/sethvargo/go-fastly","labels_url":"https://api.github.com/repos/sethvargo/go-fastly/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/sethvargo/go-fastly/issues/11/comments","events_url":"https://api.github.com/repos/sethvargo/go-fastly/issues/11/events","html_url":"https://github.com/sethvargo/go-fastly/issues/11","id":162461013,"number":11,"title":"client.RequestForm clobbers intentional uses of '\\.'","user":{"login":"alienth","id":218431,"avatar_url":"https://avatars.githubusercontent.com/u/218431?v=3","gravatar_id":"","url":"https://api.github.com/users/alienth","html_url":"https://github.com/alienth","followers_url":"https://api.github.com/users/alienth/followers","following_url":"https://api.github.com/users/alienth/following{/other_user}","gists_url":"https://api.github.com/users/alienth/gists{/gist_id}","starred_url":"https://api.github.com/users/alienth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alienth/subscriptions","organizations_url":"https://api.github.com/users/alienth/orgs","repos_url":"https://api.github.com/users/alienth/repos","events_url":"https://api.github.com/users/alienth/events{/privacy}","received_events_url":"https://api.github.com/users/alienth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-27T14:09:40Z","updated_at":"2016-06-27T15:18:01Z","closed_at":null,"body":"This function attempts to workaround a quirk of the form library where cases of `.` characters are replaced with `%5C.`. \r\n\r\nhttps://github.com/sethvargo/go-fastly/blob/master/client.go#L164\r\n\r\nProblem is when it does this, it replaces intentional cases of `\\.`. For example, a VCL I'm uploading has a `\\.` within a regex, which this code clobbers and replaces with a bare `.`."},"comment":{"url":"https://api.github.com/repos/sethvargo/go-fastly/issues/comments/228777515","html_url":"https://github.com/sethvargo/go-fastly/issues/11#issuecomment-228777515","issue_url":"https://api.github.com/repos/sethvargo/go-fastly/issues/11","id":228777515,"user":{"login":"alienth","id":218431,"avatar_url":"https://avatars.githubusercontent.com/u/218431?v=3","gravatar_id":"","url":"https://api.github.com/users/alienth","html_url":"https://github.com/alienth","followers_url":"https://api.github.com/users/alienth/followers","following_url":"https://api.github.com/users/alienth/following{/other_user}","gists_url":"https://api.github.com/users/alienth/gists{/gist_id}","starred_url":"https://api.github.com/users/alienth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alienth/subscriptions","organizations_url":"https://api.github.com/users/alienth/orgs","repos_url":"https://api.github.com/users/alienth/repos","events_url":"https://api.github.com/users/alienth/events{/privacy}","received_events_url":"https://api.github.com/users/alienth/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T15:18:01Z","updated_at":"2016-06-27T15:18:01Z","body":"What is happening is that form is appropriately escaping my backslash, which turns it into `%5E`. From there, `client.RequestCode()` rips out the `%5E`, which I actually want to have, along with any unwanted `%5E`s.\r\n\r\nWith some testing I've verified that the form lib is only doing the unwanted escaping that you're trying to compensate for on form keys. The values are untouched."}}
{"actor":{"display_login":"alienth"}}