{"action":"created","issue":{"url":"https://api.github.com/repos/lgatto/MSnbase/issues/154","repository_url":"https://api.github.com/repos/lgatto/MSnbase","labels_url":"https://api.github.com/repos/lgatto/MSnbase/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/lgatto/MSnbase/issues/154/comments","events_url":"https://api.github.com/repos/lgatto/MSnbase/issues/154/events","html_url":"https://github.com/lgatto/MSnbase/issues/154","id":174089035,"number":154,"title":"Committing to Bioc svn","user":{"login":"lgatto","id":384198,"avatar_url":"https://avatars.githubusercontent.com/u/384198?v=3","gravatar_id":"","url":"https://api.github.com/users/lgatto","html_url":"https://github.com/lgatto","followers_url":"https://api.github.com/users/lgatto/followers","following_url":"https://api.github.com/users/lgatto/following{/other_user}","gists_url":"https://api.github.com/users/lgatto/gists{/gist_id}","starred_url":"https://api.github.com/users/lgatto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgatto/subscriptions","organizations_url":"https://api.github.com/users/lgatto/orgs","repos_url":"https://api.github.com/users/lgatto/repos","events_url":"https://api.github.com/users/lgatto/events{/privacy}","received_events_url":"https://api.github.com/users/lgatto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-30T18:19:54Z","updated_at":"2016-08-30T18:29:00Z","closed_at":null,"body":"Hi @jotsetung,\r\n\r\nThe latest `MSnbase` checks fine on my computer. As a celebration, I am going to commit to Biocconductor svn, to make version 1.99 official. \r\n\r\nI suggest we stop using the `MSnbase2` branch now (I might delete it at some point) and push to master or create feature branches for more substantial changes.\r\n\r\nThank you for all your work so far! "},"comment":{"url":"https://api.github.com/repos/lgatto/MSnbase/issues/comments/243534679","html_url":"https://github.com/lgatto/MSnbase/issues/154#issuecomment-243534679","issue_url":"https://api.github.com/repos/lgatto/MSnbase/issues/154","id":243534679,"user":{"login":"lgatto","id":384198,"avatar_url":"https://avatars.githubusercontent.com/u/384198?v=3","gravatar_id":"","url":"https://api.github.com/users/lgatto","html_url":"https://github.com/lgatto","followers_url":"https://api.github.com/users/lgatto/followers","following_url":"https://api.github.com/users/lgatto/following{/other_user}","gists_url":"https://api.github.com/users/lgatto/gists{/gist_id}","starred_url":"https://api.github.com/users/lgatto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgatto/subscriptions","organizations_url":"https://api.github.com/users/lgatto/orgs","repos_url":"https://api.github.com/users/lgatto/repos","events_url":"https://api.github.com/users/lgatto/events{/privacy}","received_events_url":"https://api.github.com/users/lgatto/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T18:29:00Z","updated_at":"2016-08-30T18:29:00Z","body":"From `svn log`\r\n\r\n```\r\n------------------------------------------------------------------------\r\nr120585 | l.gatto | 2016-08-30 19:26:33 +0100 (Tue, 30 Aug 2016) | 26 lines\r\n\r\nMerge branch 'master' into devel\r\n\r\n* master: (312 commits)\r\n  close #153: update low/highMZ checks in validateOnDiskMSnSet\r\n  suggest microbenchmark and suppress message in benchark vig\r\n  Add unit test for issue #118\r\n  Fix failing tests and example due to r120413 in Biobase\r\n  Fix for loop that iterates over spectra to work with empty objects\r\n  Spectra import without need to read mzML header\r\n  Intermediate fix for issue #151\r\n  add unit test for extractMgfSpectrum2Info\r\n  fix warning in readMgfData if TITLE contains multiple =\r\n  split MSnExp tests and new [[ error test\r\n  fix OnDiskMSnExp [[ subsetting - closes issue 152\r\n  coding style\r\n  add gc to readMSData2 - (hopefully) closes #151\r\n  coding style\r\n  use centroided argument in plot.Spectrum.Spectrum example; see issue #150\r\n  coding style\r\n  set mode in calculateFragments example\r\n  remove expecting warning when peak picking centroided spectrum, not silently returns object\r\n  fix centoided test in spectrum functions - see issue #150\r\n  centroided accessor with na.fail unit test\r\n  ...\r\n```"}}
{"actor":{"display_login":"lgatto"}}