{"action":"created","comment":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/comments/59022550","id":59022550,"diff_hunk":"@@ -8,8 +8,10 @@ add_library(VersionControlUI SHARED\n \tsrc/VersionControlUIException.h\n \tsrc/versioncontrolui_api.h\n \tsrc/VersionControlUIPlugin.h\n+\tsrc/DiffManager.h\n \tsrc/VersionControlUIException.cpp\n \tsrc/VersionControlUIPlugin.cpp\n+\tsrc/DiffManager.cpp\n \ttest/SimpleTest.cpp\n )\n-envision_plugin(VersionControlUI InteractionBase)\n+envision_plugin(VersionControlUI InteractionBase oomodel)","path":"VersionControlUI/CMakeLists.txt","position":null,"original_position":11,"commit_id":"9ee9617b894ada041ea78c6366e1e0364e02ab3a","original_commit_id":"806b09db3c4755603569f87ef51c429fdac9f7af","user":{"login":"dimitar-asenov","id":1152976,"avatar_url":"https://avatars.githubusercontent.com/u/1152976?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitar-asenov","html_url":"https://github.com/dimitar-asenov","followers_url":"https://api.github.com/users/dimitar-asenov/followers","following_url":"https://api.github.com/users/dimitar-asenov/following{/other_user}","gists_url":"https://api.github.com/users/dimitar-asenov/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitar-asenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitar-asenov/subscriptions","organizations_url":"https://api.github.com/users/dimitar-asenov/orgs","repos_url":"https://api.github.com/users/dimitar-asenov/repos","events_url":"https://api.github.com/users/dimitar-asenov/events{/privacy}","received_events_url":"https://api.github.com/users/dimitar-asenov/received_events","type":"User","site_admin":false},"body":"We talked about keeping the VersionControl UI at the generic level. Why did you introduce a dependency on oomodel?","created_at":"2016-04-08T13:16:44Z","updated_at":"2016-04-08T13:16:44Z","html_url":"https://github.com/dimitar-asenov/Envision/pull/365#discussion_r59022550","pull_request_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/comments/59022550"},"html":{"href":"https://github.com/dimitar-asenov/Envision/pull/365#discussion_r59022550"},"pull_request":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/365","id":65765715,"html_url":"https://github.com/dimitar-asenov/Envision/pull/365","diff_url":"https://github.com/dimitar-asenov/Envision/pull/365.diff","patch_url":"https://github.com/dimitar-asenov/Envision/pull/365.patch","issue_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/365","number":365,"state":"open","locked":false,"title":"Diff visualization","user":{"login":"mgalbier","id":17177211,"avatar_url":"https://avatars.githubusercontent.com/u/17177211?v=3","gravatar_id":"","url":"https://api.github.com/users/mgalbier","html_url":"https://github.com/mgalbier","followers_url":"https://api.github.com/users/mgalbier/followers","following_url":"https://api.github.com/users/mgalbier/following{/other_user}","gists_url":"https://api.github.com/users/mgalbier/gists{/gist_id}","starred_url":"https://api.github.com/users/mgalbier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgalbier/subscriptions","organizations_url":"https://api.github.com/users/mgalbier/orgs","repos_url":"https://api.github.com/users/mgalbier/repos","events_url":"https://api.github.com/users/mgalbier/events{/privacy}","received_events_url":"https://api.github.com/users/mgalbier/received_events","type":"User","site_admin":false},"body":"<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/dimitar-asenov/Envision/pull/365%23discussion_r59022325%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/365%23discussion_r59022463%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%20806b09db3c4755603569f87ef51c429fdac9f7af%20VersionControlUI/CMakeLists.txt%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov/Envision/pull/365%23discussion_r59022325%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Each%20commit%20should%20at%20a%20minimum%20compile%20on%20its%20own.%20Here%20you%20add%20some%20source%20files%20in%20the%20CMakeLists.txt%20but%20don%27t%20add%20the%20actual%20files%20to%20the%20commit.%20This%20will%20fail%20to%20compile.%22%2C%20%22created_at%22%3A%20%222016-04-08T13%3A14%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%2C%20%7B%22body%22%3A%20%22This%20commit%20is%20supposed%20to%20add%20a%20dependency%2C%20but%20you%20are%20adding%20here%20additional%20source%20files.%20This%20is%20not%20right%2C%20adding%20these%20files%20should%20have%20been%20done%20in%20a%20different%20commit%20or%20you%20should%20have%20named%20the%20commit%20appropriately.%22%2C%20%22created_at%22%3A%20%222016-04-08T13%3A16%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20VersionControlUI/CMakeLists.txt%3AL8-18%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull 806b09db3c4755603569f87ef51c429fdac9f7af VersionControlUI/CMakeLists.txt 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/dimitar-asenov/Envision/pull/365#discussion_r59022325'>File: VersionControlUI/CMakeLists.txt:L8-18</a></b>\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> Each commit should at a minimum compile on its own. Here you add some source files in the CMakeLists.txt but don't add the actual files to the commit. This will fail to compile.\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> This commit is supposed to add a dependency, but you are adding here additional source files. This is not right, adding these files should have been done in a different commit or you should have named the commit appropriately.\n\n\n<a href='https://www.codereviewhub.com/dimitar-asenov/Envision/pull/365?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/dimitar-asenov/Envision/pull/365?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/dimitar-asenov/Envision/pull/365'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-04-08T10:22:44Z","updated_at":"2016-04-08T13:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bec12a1730365a842e7951eab5b037ec0c86523","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/365/commits","review_comments_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/365/comments","review_comment_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/365/comments","statuses_url":"https://api.github.com/repos/dimitar-asenov/Envision/statuses/9ee9617b894ada041ea78c6366e1e0364e02ab3a","head":{"label":"mgalbier:gm-diff-manager","ref":"gm-diff-manager","sha":"9ee9617b894ada041ea78c6366e1e0364e02ab3a","user":{"login":"mgalbier","id":17177211,"avatar_url":"https://avatars.githubusercontent.com/u/17177211?v=3","gravatar_id":"","url":"https://api.github.com/users/mgalbier","html_url":"https://github.com/mgalbier","followers_url":"https://api.github.com/users/mgalbier/followers","following_url":"https://api.github.com/users/mgalbier/following{/other_user}","gists_url":"https://api.github.com/users/mgalbier/gists{/gist_id}","starred_url":"https://api.github.com/users/mgalbier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgalbier/subscriptions","organizations_url":"https://api.github.com/users/mgalbier/orgs","repos_url":"https://api.github.com/users/mgalbier/repos","events_url":"https://api.github.com/users/mgalbier/events{/privacy}","received_events_url":"https://api.github.com/users/mgalbier/received_events","type":"User","site_admin":false},"repo":{"id":53584127,"name":"Envision","full_name":"mgalbier/Envision","owner":{"login":"mgalbier","id":17177211,"avatar_url":"https://avatars.githubusercontent.com/u/17177211?v=3","gravatar_id":"","url":"https://api.github.com/users/mgalbier","html_url":"https://github.com/mgalbier","followers_url":"https://api.github.com/users/mgalbier/followers","following_url":"https://api.github.com/users/mgalbier/following{/other_user}","gists_url":"https://api.github.com/users/mgalbier/gists{/gist_id}","starred_url":"https://api.github.com/users/mgalbier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgalbier/subscriptions","organizations_url":"https://api.github.com/users/mgalbier/orgs","repos_url":"https://api.github.com/users/mgalbier/repos","events_url":"https://api.github.com/users/mgalbier/events{/privacy}","received_events_url":"https://api.github.com/users/mgalbier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgalbier/Envision","description":"A next generation IDE with a visual programming interface","fork":true,"url":"https://api.github.com/repos/mgalbier/Envision","forks_url":"https://api.github.com/repos/mgalbier/Envision/forks","keys_url":"https://api.github.com/repos/mgalbier/Envision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgalbier/Envision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgalbier/Envision/teams","hooks_url":"https://api.github.com/repos/mgalbier/Envision/hooks","issue_events_url":"https://api.github.com/repos/mgalbier/Envision/issues/events{/number}","events_url":"https://api.github.com/repos/mgalbier/Envision/events","assignees_url":"https://api.github.com/repos/mgalbier/Envision/assignees{/user}","branches_url":"https://api.github.com/repos/mgalbier/Envision/branches{/branch}","tags_url":"https://api.github.com/repos/mgalbier/Envision/tags","blobs_url":"https://api.github.com/repos/mgalbier/Envision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgalbier/Envision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgalbier/Envision/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgalbier/Envision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgalbier/Envision/statuses/{sha}","languages_url":"https://api.github.com/repos/mgalbier/Envision/languages","stargazers_url":"https://api.github.com/repos/mgalbier/Envision/stargazers","contributors_url":"https://api.github.com/repos/mgalbier/Envision/contributors","subscribers_url":"https://api.github.com/repos/mgalbier/Envision/subscribers","subscription_url":"https://api.github.com/repos/mgalbier/Envision/subscription","commits_url":"https://api.github.com/repos/mgalbier/Envision/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgalbier/Envision/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgalbier/Envision/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgalbier/Envision/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgalbier/Envision/contents/{+path}","compare_url":"https://api.github.com/repos/mgalbier/Envision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgalbier/Envision/merges","archive_url":"https://api.github.com/repos/mgalbier/Envision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgalbier/Envision/downloads","issues_url":"https://api.github.com/repos/mgalbier/Envision/issues{/number}","pulls_url":"https://api.github.com/repos/mgalbier/Envision/pulls{/number}","milestones_url":"https://api.github.com/repos/mgalbier/Envision/milestones{/number}","notifications_url":"https://api.github.com/repos/mgalbier/Envision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgalbier/Envision/labels{/name}","releases_url":"https://api.github.com/repos/mgalbier/Envision/releases{/id}","deployments_url":"https://api.github.com/repos/mgalbier/Envision/deployments","created_at":"2016-03-10T12:51:01Z","updated_at":"2016-03-10T12:51:08Z","pushed_at":"2016-04-08T11:14:05Z","git_url":"git://github.com/mgalbier/Envision.git","ssh_url":"git@github.com:mgalbier/Envision.git","clone_url":"https://github.com/mgalbier/Envision.git","svn_url":"https://github.com/mgalbier/Envision","homepage":"http://dimitar-asenov.github.com/Envision/","size":63516,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"dimitar-asenov:development","ref":"development","sha":"54d534202cfc4389b055775bd2c78a939d4e3055","user":{"login":"dimitar-asenov","id":1152976,"avatar_url":"https://avatars.githubusercontent.com/u/1152976?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitar-asenov","html_url":"https://github.com/dimitar-asenov","followers_url":"https://api.github.com/users/dimitar-asenov/followers","following_url":"https://api.github.com/users/dimitar-asenov/following{/other_user}","gists_url":"https://api.github.com/users/dimitar-asenov/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitar-asenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitar-asenov/subscriptions","organizations_url":"https://api.github.com/users/dimitar-asenov/orgs","repos_url":"https://api.github.com/users/dimitar-asenov/repos","events_url":"https://api.github.com/users/dimitar-asenov/events{/privacy}","received_events_url":"https://api.github.com/users/dimitar-asenov/received_events","type":"User","site_admin":false},"repo":{"id":2650576,"name":"Envision","full_name":"dimitar-asenov/Envision","owner":{"login":"dimitar-asenov","id":1152976,"avatar_url":"https://avatars.githubusercontent.com/u/1152976?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitar-asenov","html_url":"https://github.com/dimitar-asenov","followers_url":"https://api.github.com/users/dimitar-asenov/followers","following_url":"https://api.github.com/users/dimitar-asenov/following{/other_user}","gists_url":"https://api.github.com/users/dimitar-asenov/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitar-asenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitar-asenov/subscriptions","organizations_url":"https://api.github.com/users/dimitar-asenov/orgs","repos_url":"https://api.github.com/users/dimitar-asenov/repos","events_url":"https://api.github.com/users/dimitar-asenov/events{/privacy}","received_events_url":"https://api.github.com/users/dimitar-asenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimitar-asenov/Envision","description":"A next generation IDE with a visual programming interface","fork":false,"url":"https://api.github.com/repos/dimitar-asenov/Envision","forks_url":"https://api.github.com/repos/dimitar-asenov/Envision/forks","keys_url":"https://api.github.com/repos/dimitar-asenov/Envision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimitar-asenov/Envision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimitar-asenov/Envision/teams","hooks_url":"https://api.github.com/repos/dimitar-asenov/Envision/hooks","issue_events_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/events{/number}","events_url":"https://api.github.com/repos/dimitar-asenov/Envision/events","assignees_url":"https://api.github.com/repos/dimitar-asenov/Envision/assignees{/user}","branches_url":"https://api.github.com/repos/dimitar-asenov/Envision/branches{/branch}","tags_url":"https://api.github.com/repos/dimitar-asenov/Envision/tags","blobs_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimitar-asenov/Envision/statuses/{sha}","languages_url":"https://api.github.com/repos/dimitar-asenov/Envision/languages","stargazers_url":"https://api.github.com/repos/dimitar-asenov/Envision/stargazers","contributors_url":"https://api.github.com/repos/dimitar-asenov/Envision/contributors","subscribers_url":"https://api.github.com/repos/dimitar-asenov/Envision/subscribers","subscription_url":"https://api.github.com/repos/dimitar-asenov/Envision/subscription","commits_url":"https://api.github.com/repos/dimitar-asenov/Envision/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimitar-asenov/Envision/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimitar-asenov/Envision/contents/{+path}","compare_url":"https://api.github.com/repos/dimitar-asenov/Envision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimitar-asenov/Envision/merges","archive_url":"https://api.github.com/repos/dimitar-asenov/Envision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimitar-asenov/Envision/downloads","issues_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues{/number}","pulls_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls{/number}","milestones_url":"https://api.github.com/repos/dimitar-asenov/Envision/milestones{/number}","notifications_url":"https://api.github.com/repos/dimitar-asenov/Envision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimitar-asenov/Envision/labels{/name}","releases_url":"https://api.github.com/repos/dimitar-asenov/Envision/releases{/id}","deployments_url":"https://api.github.com/repos/dimitar-asenov/Envision/deployments","created_at":"2011-10-26T12:03:58Z","updated_at":"2016-04-02T07:40:14Z","pushed_at":"2016-04-08T11:14:06Z","git_url":"git://github.com/dimitar-asenov/Envision.git","ssh_url":"git@github.com:dimitar-asenov/Envision.git","clone_url":"https://github.com/dimitar-asenov/Envision.git","svn_url":"https://github.com/dimitar-asenov/Envision","homepage":"http://dimitar-asenov.github.com/Envision/","size":64712,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":32,"forks":15,"open_issues":32,"watchers":26,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/365"},"html":{"href":"https://github.com/dimitar-asenov/Envision/pull/365"},"issue":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/issues/365"},"comments":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/statuses/9ee9617b894ada041ea78c6366e1e0364e02ab3a"}}}}