{"action":"closed","number":66,"pull_request":{"url":"https://api.github.com/repos/quamotion/madb/pulls/66","id":96512402,"html_url":"https://github.com/quamotion/madb/pull/66","diff_url":"https://github.com/quamotion/madb/pull/66.diff","patch_url":"https://github.com/quamotion/madb/pull/66.patch","issue_url":"https://api.github.com/repos/quamotion/madb/issues/66","number":66,"state":"closed","locked":false,"title":"Make the RunLogServiceAsync method truly async","user":{"login":"qmfrederik","id":9918129,"avatar_url":"https://avatars.githubusercontent.com/u/9918129?v=3","gravatar_id":"","url":"https://api.github.com/users/qmfrederik","html_url":"https://github.com/qmfrederik","followers_url":"https://api.github.com/users/qmfrederik/followers","following_url":"https://api.github.com/users/qmfrederik/following{/other_user}","gists_url":"https://api.github.com/users/qmfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/qmfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmfrederik/subscriptions","organizations_url":"https://api.github.com/users/qmfrederik/orgs","repos_url":"https://api.github.com/users/qmfrederik/repos","events_url":"https://api.github.com/users/qmfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/qmfrederik/received_events","type":"User","site_admin":false},"body":"Currently, RunLogService would check whether a cancellation was requested every time a message is received. However, if there is a large delay between two subsequent messages (say, multiple seconds or even minutes), the cancellation would never be processed.\r\n\r\nThis PR makes sure that the network I/O can also be cancelled, so the cancellation works correctly even if the loop is stuck waiting for network I/O for a long period of time.\r\n\r\n/cc @bartsaintgermain ","created_at":"2016-12-05T11:32:47Z","updated_at":"2016-12-05T11:33:51Z","closed_at":"2016-12-05T11:33:51Z","merged_at":"2016-12-05T11:33:51Z","merge_commit_sha":"8844fc2e5f894346009da44e9e19356abfdce281","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/quamotion/madb/pulls/66/commits","review_comments_url":"https://api.github.com/repos/quamotion/madb/pulls/66/comments","review_comment_url":"https://api.github.com/repos/quamotion/madb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quamotion/madb/issues/66/comments","statuses_url":"https://api.github.com/repos/quamotion/madb/statuses/3d9061e8bbfde6d4e7a733ffaf5b3729b6136192","head":{"label":"quamotion:fixes/runlogservice-cts","ref":"fixes/runlogservice-cts","sha":"3d9061e8bbfde6d4e7a733ffaf5b3729b6136192","user":{"login":"quamotion","id":9918157,"avatar_url":"https://avatars.githubusercontent.com/u/9918157?v=3","gravatar_id":"","url":"https://api.github.com/users/quamotion","html_url":"https://github.com/quamotion","followers_url":"https://api.github.com/users/quamotion/followers","following_url":"https://api.github.com/users/quamotion/following{/other_user}","gists_url":"https://api.github.com/users/quamotion/gists{/gist_id}","starred_url":"https://api.github.com/users/quamotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quamotion/subscriptions","organizations_url":"https://api.github.com/users/quamotion/orgs","repos_url":"https://api.github.com/users/quamotion/repos","events_url":"https://api.github.com/users/quamotion/events{/privacy}","received_events_url":"https://api.github.com/users/quamotion/received_events","type":"Organization","site_admin":false},"repo":{"id":36613134,"name":"madb","full_name":"quamotion/madb","owner":{"login":"quamotion","id":9918157,"avatar_url":"https://avatars.githubusercontent.com/u/9918157?v=3","gravatar_id":"","url":"https://api.github.com/users/quamotion","html_url":"https://github.com/quamotion","followers_url":"https://api.github.com/users/quamotion/followers","following_url":"https://api.github.com/users/quamotion/following{/other_user}","gists_url":"https://api.github.com/users/quamotion/gists{/gist_id}","starred_url":"https://api.github.com/users/quamotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quamotion/subscriptions","organizations_url":"https://api.github.com/users/quamotion/orgs","repos_url":"https://api.github.com/users/quamotion/repos","events_url":"https://api.github.com/users/quamotion/events{/privacy}","received_events_url":"https://api.github.com/users/quamotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quamotion/madb","description":"SharpAdbClient is a .NET library that allows .NET applications to communicate with Android devices. It provides a .NET implementation of the adb protocol, giving more flexibility to the developer than launching an adb.exe process and parsing the console output.","fork":false,"url":"https://api.github.com/repos/quamotion/madb","forks_url":"https://api.github.com/repos/quamotion/madb/forks","keys_url":"https://api.github.com/repos/quamotion/madb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quamotion/madb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quamotion/madb/teams","hooks_url":"https://api.github.com/repos/quamotion/madb/hooks","issue_events_url":"https://api.github.com/repos/quamotion/madb/issues/events{/number}","events_url":"https://api.github.com/repos/quamotion/madb/events","assignees_url":"https://api.github.com/repos/quamotion/madb/assignees{/user}","branches_url":"https://api.github.com/repos/quamotion/madb/branches{/branch}","tags_url":"https://api.github.com/repos/quamotion/madb/tags","blobs_url":"https://api.github.com/repos/quamotion/madb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quamotion/madb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quamotion/madb/git/refs{/sha}","trees_url":"https://api.github.com/repos/quamotion/madb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quamotion/madb/statuses/{sha}","languages_url":"https://api.github.com/repos/quamotion/madb/languages","stargazers_url":"https://api.github.com/repos/quamotion/madb/stargazers","contributors_url":"https://api.github.com/repos/quamotion/madb/contributors","subscribers_url":"https://api.github.com/repos/quamotion/madb/subscribers","subscription_url":"https://api.github.com/repos/quamotion/madb/subscription","commits_url":"https://api.github.com/repos/quamotion/madb/commits{/sha}","git_commits_url":"https://api.github.com/repos/quamotion/madb/git/commits{/sha}","comments_url":"https://api.github.com/repos/quamotion/madb/comments{/number}","issue_comment_url":"https://api.github.com/repos/quamotion/madb/issues/comments{/number}","contents_url":"https://api.github.com/repos/quamotion/madb/contents/{+path}","compare_url":"https://api.github.com/repos/quamotion/madb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quamotion/madb/merges","archive_url":"https://api.github.com/repos/quamotion/madb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quamotion/madb/downloads","issues_url":"https://api.github.com/repos/quamotion/madb/issues{/number}","pulls_url":"https://api.github.com/repos/quamotion/madb/pulls{/number}","milestones_url":"https://api.github.com/repos/quamotion/madb/milestones{/number}","notifications_url":"https://api.github.com/repos/quamotion/madb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quamotion/madb/labels{/name}","releases_url":"https://api.github.com/repos/quamotion/madb/releases{/id}","deployments_url":"https://api.github.com/repos/quamotion/madb/deployments","created_at":"2015-05-31T17:05:23Z","updated_at":"2016-11-28T11:10:57Z","pushed_at":"2016-12-05T11:33:51Z","git_url":"git://github.com/quamotion/madb.git","ssh_url":"git@github.com:quamotion/madb.git","clone_url":"https://github.com/quamotion/madb.git","svn_url":"https://github.com/quamotion/madb","homepage":"","size":4350,"stargazers_count":30,"watchers_count":30,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":30,"default_branch":"master"}},"base":{"label":"quamotion:master","ref":"master","sha":"0080ad8abec53268ce195f09ea977c706bddfa09","user":{"login":"quamotion","id":9918157,"avatar_url":"https://avatars.githubusercontent.com/u/9918157?v=3","gravatar_id":"","url":"https://api.github.com/users/quamotion","html_url":"https://github.com/quamotion","followers_url":"https://api.github.com/users/quamotion/followers","following_url":"https://api.github.com/users/quamotion/following{/other_user}","gists_url":"https://api.github.com/users/quamotion/gists{/gist_id}","starred_url":"https://api.github.com/users/quamotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quamotion/subscriptions","organizations_url":"https://api.github.com/users/quamotion/orgs","repos_url":"https://api.github.com/users/quamotion/repos","events_url":"https://api.github.com/users/quamotion/events{/privacy}","received_events_url":"https://api.github.com/users/quamotion/received_events","type":"Organization","site_admin":false},"repo":{"id":36613134,"name":"madb","full_name":"quamotion/madb","owner":{"login":"quamotion","id":9918157,"avatar_url":"https://avatars.githubusercontent.com/u/9918157?v=3","gravatar_id":"","url":"https://api.github.com/users/quamotion","html_url":"https://github.com/quamotion","followers_url":"https://api.github.com/users/quamotion/followers","following_url":"https://api.github.com/users/quamotion/following{/other_user}","gists_url":"https://api.github.com/users/quamotion/gists{/gist_id}","starred_url":"https://api.github.com/users/quamotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quamotion/subscriptions","organizations_url":"https://api.github.com/users/quamotion/orgs","repos_url":"https://api.github.com/users/quamotion/repos","events_url":"https://api.github.com/users/quamotion/events{/privacy}","received_events_url":"https://api.github.com/users/quamotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quamotion/madb","description":"SharpAdbClient is a .NET library that allows .NET applications to communicate with Android devices. It provides a .NET implementation of the adb protocol, giving more flexibility to the developer than launching an adb.exe process and parsing the console output.","fork":false,"url":"https://api.github.com/repos/quamotion/madb","forks_url":"https://api.github.com/repos/quamotion/madb/forks","keys_url":"https://api.github.com/repos/quamotion/madb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quamotion/madb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quamotion/madb/teams","hooks_url":"https://api.github.com/repos/quamotion/madb/hooks","issue_events_url":"https://api.github.com/repos/quamotion/madb/issues/events{/number}","events_url":"https://api.github.com/repos/quamotion/madb/events","assignees_url":"https://api.github.com/repos/quamotion/madb/assignees{/user}","branches_url":"https://api.github.com/repos/quamotion/madb/branches{/branch}","tags_url":"https://api.github.com/repos/quamotion/madb/tags","blobs_url":"https://api.github.com/repos/quamotion/madb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quamotion/madb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quamotion/madb/git/refs{/sha}","trees_url":"https://api.github.com/repos/quamotion/madb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quamotion/madb/statuses/{sha}","languages_url":"https://api.github.com/repos/quamotion/madb/languages","stargazers_url":"https://api.github.com/repos/quamotion/madb/stargazers","contributors_url":"https://api.github.com/repos/quamotion/madb/contributors","subscribers_url":"https://api.github.com/repos/quamotion/madb/subscribers","subscription_url":"https://api.github.com/repos/quamotion/madb/subscription","commits_url":"https://api.github.com/repos/quamotion/madb/commits{/sha}","git_commits_url":"https://api.github.com/repos/quamotion/madb/git/commits{/sha}","comments_url":"https://api.github.com/repos/quamotion/madb/comments{/number}","issue_comment_url":"https://api.github.com/repos/quamotion/madb/issues/comments{/number}","contents_url":"https://api.github.com/repos/quamotion/madb/contents/{+path}","compare_url":"https://api.github.com/repos/quamotion/madb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quamotion/madb/merges","archive_url":"https://api.github.com/repos/quamotion/madb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quamotion/madb/downloads","issues_url":"https://api.github.com/repos/quamotion/madb/issues{/number}","pulls_url":"https://api.github.com/repos/quamotion/madb/pulls{/number}","milestones_url":"https://api.github.com/repos/quamotion/madb/milestones{/number}","notifications_url":"https://api.github.com/repos/quamotion/madb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quamotion/madb/labels{/name}","releases_url":"https://api.github.com/repos/quamotion/madb/releases{/id}","deployments_url":"https://api.github.com/repos/quamotion/madb/deployments","created_at":"2015-05-31T17:05:23Z","updated_at":"2016-11-28T11:10:57Z","pushed_at":"2016-12-05T11:33:51Z","git_url":"git://github.com/quamotion/madb.git","ssh_url":"git@github.com:quamotion/madb.git","clone_url":"https://github.com/quamotion/madb.git","svn_url":"https://github.com/quamotion/madb","homepage":"","size":4350,"stargazers_count":30,"watchers_count":30,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quamotion/madb/pulls/66"},"html":{"href":"https://github.com/quamotion/madb/pull/66"},"issue":{"href":"https://api.github.com/repos/quamotion/madb/issues/66"},"comments":{"href":"https://api.github.com/repos/quamotion/madb/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/quamotion/madb/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/quamotion/madb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quamotion/madb/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/quamotion/madb/statuses/3d9061e8bbfde6d4e7a733ffaf5b3729b6136192"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"qmfrederik","id":9918129,"avatar_url":"https://avatars.githubusercontent.com/u/9918129?v=3","gravatar_id":"","url":"https://api.github.com/users/qmfrederik","html_url":"https://github.com/qmfrederik","followers_url":"https://api.github.com/users/qmfrederik/followers","following_url":"https://api.github.com/users/qmfrederik/following{/other_user}","gists_url":"https://api.github.com/users/qmfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/qmfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmfrederik/subscriptions","organizations_url":"https://api.github.com/users/qmfrederik/orgs","repos_url":"https://api.github.com/users/qmfrederik/repos","events_url":"https://api.github.com/users/qmfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/qmfrederik/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":165,"deletions":52,"changed_files":11}}
{"actor":{"display_login":"qmfrederik"}}