{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/54157760","id":54157760,"diff_hunk":"@@ -107,9 +107,8 @@ class BasicAmazonDeployHandler implements DeployHandler<BasicAmazonDeployDescrip\n         }\n       }\n \n-      def blockDeviceMappingForInstanceType = BlockDeviceConfig.blockDevicesByInstanceType[description.instanceType]\n-      if (blockDeviceMappingForInstanceType) {\n-        description.blockDevices = blockDeviceMappingForInstanceType\n+      if (!description.blockDevices) {","path":"clouddriver-aws/src/main/groovy/com/netflix/spinnaker/clouddriver/aws/deploy/handlers/BasicAmazonDeployHandler.groovy","position":7,"original_position":7,"commit_id":"ab16f31af2eb759b9b828e8a8bc433bd80b0cc10","original_commit_id":"ab16f31af2eb759b9b828e8a8bc433bd80b0cc10","user":{"login":"duftler","id":8437718,"avatar_url":"https://avatars.githubusercontent.com/u/8437718?v=3","gravatar_id":"","url":"https://api.github.com/users/duftler","html_url":"https://github.com/duftler","followers_url":"https://api.github.com/users/duftler/followers","following_url":"https://api.github.com/users/duftler/following{/other_user}","gists_url":"https://api.github.com/users/duftler/gists{/gist_id}","starred_url":"https://api.github.com/users/duftler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duftler/subscriptions","organizations_url":"https://api.github.com/users/duftler/orgs","repos_url":"https://api.github.com/users/duftler/repos","events_url":"https://api.github.com/users/duftler/events{/privacy}","received_events_url":"https://api.github.com/users/duftler/received_events","type":"User","site_admin":false},"body":"Does this allow for an explicitly-empty set of block devices (not an aws expert, but wouldn't it be a reasonable use-case for one to request a server group whose instances won't be associated with any additional block devices)?\r\n\r\nIf this is a reasonable use-case, this should probably be `if (description.blockDevices == null)`.\r\n\r\nIf not reasonable, feel free to disregard this comment.","created_at":"2016-02-25T20:20:33Z","updated_at":"2016-02-25T20:20:33Z","html_url":"https://github.com/spinnaker/clouddriver/pull/334#discussion_r54157760","pull_request_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/334","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/54157760"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/334#discussion_r54157760"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/334"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/334","id":60005769,"html_url":"https://github.com/spinnaker/clouddriver/pull/334","diff_url":"https://github.com/spinnaker/clouddriver/pull/334.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/334.patch","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/334","number":334,"state":"open","locked":false,"title":"Allow for customizing block devices","user":{"login":"riltsken","id":180066,"avatar_url":"https://avatars.githubusercontent.com/u/180066?v=3","gravatar_id":"","url":"https://api.github.com/users/riltsken","html_url":"https://github.com/riltsken","followers_url":"https://api.github.com/users/riltsken/followers","following_url":"https://api.github.com/users/riltsken/following{/other_user}","gists_url":"https://api.github.com/users/riltsken/gists{/gist_id}","starred_url":"https://api.github.com/users/riltsken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riltsken/subscriptions","organizations_url":"https://api.github.com/users/riltsken/orgs","repos_url":"https://api.github.com/users/riltsken/repos","events_url":"https://api.github.com/users/riltsken/events{/privacy}","received_events_url":"https://api.github.com/users/riltsken/received_events","type":"User","site_admin":false},"body":"Related to https://github.com/spinnaker/spinnaker/issues/721\r\n\r\nCurrently the defaults are hardcoded and unable to be bypassed. This commit allows for passing down custom block devices if they are specified in the pipeline json description.","created_at":"2016-02-19T20:52:48Z","updated_at":"2016-02-25T20:20:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54575ad76ad457171b5be18cd27aada0cb0efae4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/334/commits","review_comments_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/334/comments","review_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/334/comments","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/ab16f31af2eb759b9b828e8a8bc433bd80b0cc10","head":{"label":"riltsken:advanced-block-devices","ref":"advanced-block-devices","sha":"ab16f31af2eb759b9b828e8a8bc433bd80b0cc10","user":{"login":"riltsken","id":180066,"avatar_url":"https://avatars.githubusercontent.com/u/180066?v=3","gravatar_id":"","url":"https://api.github.com/users/riltsken","html_url":"https://github.com/riltsken","followers_url":"https://api.github.com/users/riltsken/followers","following_url":"https://api.github.com/users/riltsken/following{/other_user}","gists_url":"https://api.github.com/users/riltsken/gists{/gist_id}","starred_url":"https://api.github.com/users/riltsken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riltsken/subscriptions","organizations_url":"https://api.github.com/users/riltsken/orgs","repos_url":"https://api.github.com/users/riltsken/repos","events_url":"https://api.github.com/users/riltsken/events{/privacy}","received_events_url":"https://api.github.com/users/riltsken/received_events","type":"User","site_admin":false},"repo":{"id":48395996,"name":"clouddriver","full_name":"riltsken/clouddriver","owner":{"login":"riltsken","id":180066,"avatar_url":"https://avatars.githubusercontent.com/u/180066?v=3","gravatar_id":"","url":"https://api.github.com/users/riltsken","html_url":"https://github.com/riltsken","followers_url":"https://api.github.com/users/riltsken/followers","following_url":"https://api.github.com/users/riltsken/following{/other_user}","gists_url":"https://api.github.com/users/riltsken/gists{/gist_id}","starred_url":"https://api.github.com/users/riltsken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riltsken/subscriptions","organizations_url":"https://api.github.com/users/riltsken/orgs","repos_url":"https://api.github.com/users/riltsken/repos","events_url":"https://api.github.com/users/riltsken/events{/privacy}","received_events_url":"https://api.github.com/users/riltsken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/riltsken/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/riltsken/clouddriver","forks_url":"https://api.github.com/repos/riltsken/clouddriver/forks","keys_url":"https://api.github.com/repos/riltsken/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riltsken/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riltsken/clouddriver/teams","hooks_url":"https://api.github.com/repos/riltsken/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/riltsken/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/riltsken/clouddriver/events","assignees_url":"https://api.github.com/repos/riltsken/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/riltsken/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/riltsken/clouddriver/tags","blobs_url":"https://api.github.com/repos/riltsken/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riltsken/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riltsken/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/riltsken/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riltsken/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/riltsken/clouddriver/languages","stargazers_url":"https://api.github.com/repos/riltsken/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/riltsken/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/riltsken/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/riltsken/clouddriver/subscription","commits_url":"https://api.github.com/repos/riltsken/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/riltsken/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/riltsken/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/riltsken/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/riltsken/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/riltsken/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riltsken/clouddriver/merges","archive_url":"https://api.github.com/repos/riltsken/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riltsken/clouddriver/downloads","issues_url":"https://api.github.com/repos/riltsken/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/riltsken/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/riltsken/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/riltsken/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riltsken/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/riltsken/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/riltsken/clouddriver/deployments","created_at":"2015-12-21T21:50:43Z","updated_at":"2015-12-21T21:50:47Z","pushed_at":"2016-02-19T20:51:53Z","git_url":"git://github.com/riltsken/clouddriver.git","ssh_url":"git@github.com:riltsken/clouddriver.git","clone_url":"https://github.com/riltsken/clouddriver.git","svn_url":"https://github.com/riltsken/clouddriver","homepage":null,"size":24564,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"3caf17fddcb23b1812d064fde86d283f258456b3","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":37556951,"name":"clouddriver","full_name":"spinnaker/clouddriver","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/clouddriver","description":"read and write operations across cloud providers","fork":false,"url":"https://api.github.com/repos/spinnaker/clouddriver","forks_url":"https://api.github.com/repos/spinnaker/clouddriver/forks","keys_url":"https://api.github.com/repos/spinnaker/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/clouddriver/teams","hooks_url":"https://api.github.com/repos/spinnaker/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/clouddriver/events","assignees_url":"https://api.github.com/repos/spinnaker/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/clouddriver/tags","blobs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/clouddriver/languages","stargazers_url":"https://api.github.com/repos/spinnaker/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/clouddriver/subscription","commits_url":"https://api.github.com/repos/spinnaker/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/clouddriver/merges","archive_url":"https://api.github.com/repos/spinnaker/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/clouddriver/downloads","issues_url":"https://api.github.com/repos/spinnaker/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/clouddriver/deployments","created_at":"2015-06-16T21:26:02Z","updated_at":"2016-02-20T11:19:24Z","pushed_at":"2016-02-25T20:08:01Z","git_url":"git://github.com/spinnaker/clouddriver.git","ssh_url":"git@github.com:spinnaker/clouddriver.git","clone_url":"https://github.com/spinnaker/clouddriver.git","svn_url":"https://github.com/spinnaker/clouddriver","homepage":null,"size":26755,"stargazers_count":33,"watchers_count":33,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":9,"forks":40,"open_issues":9,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/334"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/334"},"issue":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/334"},"comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/clouddriver/statuses/ab16f31af2eb759b9b828e8a8bc433bd80b0cc10"}}}}