{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/comments/86602249","pull_request_review_id":7255419,"id":86602249,"diff_hunk":"@@ -243,7 +243,7 @@ private void incrementPropertyTx(final Key key, final String prop,\n                     \"You may need more shards. Consider adding more shards.\");\n             LOG.log(Level.WARNING, e.toString(), e);\n             \n-            if(getShardCount() <= ATMOST_SHARDS){\n+            if(getShardCount() <= MAX_SHARDS){\n                 LOG.log(Level.INFO,\n                        \"Doubling Shade, for this process\");\n                 addShards(getShardCount()); //double the shade by adding the number of shade again","path":"src/com/google/appengine/demos/shardedcounter/java/v2/ShardedCounter.java","position":null,"original_position":17,"commit_id":"fc97e94c9a9bd6e80d086f262610894e6cb741df","original_commit_id":"fc97e94c9a9bd6e80d086f262610894e6cb741df","user":{"login":"theo4u","id":10440327,"avatar_url":"https://avatars.githubusercontent.com/u/10440327?v=3","gravatar_id":"","url":"https://api.github.com/users/theo4u","html_url":"https://github.com/theo4u","followers_url":"https://api.github.com/users/theo4u/followers","following_url":"https://api.github.com/users/theo4u/following{/other_user}","gists_url":"https://api.github.com/users/theo4u/gists{/gist_id}","starred_url":"https://api.github.com/users/theo4u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theo4u/subscriptions","organizations_url":"https://api.github.com/users/theo4u/orgs","repos_url":"https://api.github.com/users/theo4u/repos","events_url":"https://api.github.com/users/theo4u/events{/privacy}","received_events_url":"https://api.github.com/users/theo4u/received_events","type":"User","site_admin":false},"body":"yes, but the MAX_SHARDS won't allow it to add more than MAX_SHARDS, so the shards won't accumulate with time when you encounter concurrent exception","created_at":"2016-11-04T18:06:33Z","updated_at":"2016-11-04T18:06:33Z","html_url":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java/pull/2#discussion_r86602249","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/comments/86602249"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java/pull/2#discussion_r86602249"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/2","id":92153429,"html_url":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java/pull/2","diff_url":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java/pull/2.diff","patch_url":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java/pull/2.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/issues/2","number":2,"state":"open","locked":false,"title":"Updating the number of shard dynamically","user":{"login":"theo4u","id":10440327,"avatar_url":"https://avatars.githubusercontent.com/u/10440327?v=3","gravatar_id":"","url":"https://api.github.com/users/theo4u","html_url":"https://github.com/theo4u","followers_url":"https://api.github.com/users/theo4u/followers","following_url":"https://api.github.com/users/theo4u/following{/other_user}","gists_url":"https://api.github.com/users/theo4u/gists{/gist_id}","starred_url":"https://api.github.com/users/theo4u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theo4u/subscriptions","organizations_url":"https://api.github.com/users/theo4u/orgs","repos_url":"https://api.github.com/users/theo4u/repos","events_url":"https://api.github.com/users/theo4u/events{/privacy}","received_events_url":"https://api.github.com/users/theo4u/received_events","type":"User","site_admin":false},"body":"Doubling the total number of shards, using the initial shard to add to the current shard, so we double up our shard automatically. There is a limit to which the update of the shards can take which is specified in ATMOST_SHARDS variable","created_at":"2016-11-03T13:32:19Z","updated_at":"2016-11-04T18:06:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e45dfe3a2a796b53404e23031d2db7fefec79762","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/2/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/2/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/issues/2/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/statuses/fc97e94c9a9bd6e80d086f262610894e6cb741df","head":{"label":"theo4u:patch-1","ref":"patch-1","sha":"fc97e94c9a9bd6e80d086f262610894e6cb741df","user":{"login":"theo4u","id":10440327,"avatar_url":"https://avatars.githubusercontent.com/u/10440327?v=3","gravatar_id":"","url":"https://api.github.com/users/theo4u","html_url":"https://github.com/theo4u","followers_url":"https://api.github.com/users/theo4u/followers","following_url":"https://api.github.com/users/theo4u/following{/other_user}","gists_url":"https://api.github.com/users/theo4u/gists{/gist_id}","starred_url":"https://api.github.com/users/theo4u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theo4u/subscriptions","organizations_url":"https://api.github.com/users/theo4u/orgs","repos_url":"https://api.github.com/users/theo4u/repos","events_url":"https://api.github.com/users/theo4u/events{/privacy}","received_events_url":"https://api.github.com/users/theo4u/received_events","type":"User","site_admin":false},"repo":{"id":72747476,"name":"appengine-sharded-counters-java","full_name":"theo4u/appengine-sharded-counters-java","owner":{"login":"theo4u","id":10440327,"avatar_url":"https://avatars.githubusercontent.com/u/10440327?v=3","gravatar_id":"","url":"https://api.github.com/users/theo4u","html_url":"https://github.com/theo4u","followers_url":"https://api.github.com/users/theo4u/followers","following_url":"https://api.github.com/users/theo4u/following{/other_user}","gists_url":"https://api.github.com/users/theo4u/gists{/gist_id}","starred_url":"https://api.github.com/users/theo4u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theo4u/subscriptions","organizations_url":"https://api.github.com/users/theo4u/orgs","repos_url":"https://api.github.com/users/theo4u/repos","events_url":"https://api.github.com/users/theo4u/events{/privacy}","received_events_url":"https://api.github.com/users/theo4u/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theo4u/appengine-sharded-counters-java","description":"A simple application that demonstrates two approaches to sharding counters in Java.","fork":true,"url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java","forks_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/forks","keys_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/teams","hooks_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/hooks","issue_events_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/issues/events{/number}","events_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/events","assignees_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/assignees{/user}","branches_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/branches{/branch}","tags_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/tags","blobs_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/statuses/{sha}","languages_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/languages","stargazers_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/stargazers","contributors_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/contributors","subscribers_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/subscribers","subscription_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/subscription","commits_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/contents/{+path}","compare_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/merges","archive_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/downloads","issues_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/issues{/number}","pulls_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/pulls{/number}","milestones_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/milestones{/number}","notifications_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/labels{/name}","releases_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/releases{/id}","deployments_url":"https://api.github.com/repos/theo4u/appengine-sharded-counters-java/deployments","created_at":"2016-11-03T13:22:29Z","updated_at":"2016-11-03T13:22:30Z","pushed_at":"2016-11-04T08:32:45Z","git_url":"git://github.com/theo4u/appengine-sharded-counters-java.git","ssh_url":"git@github.com:theo4u/appengine-sharded-counters-java.git","clone_url":"https://github.com/theo4u/appengine-sharded-counters-java.git","svn_url":"https://github.com/theo4u/appengine-sharded-counters-java","homepage":"","size":19,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"26762a9d39b58097d49de1766bf7f2b942f35439","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":7635972,"name":"appengine-sharded-counters-java","full_name":"GoogleCloudPlatform/appengine-sharded-counters-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java","description":"A simple application that demonstrates two approaches to sharding counters in Java.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/deployments","created_at":"2013-01-16T00:12:01Z","updated_at":"2016-11-03T13:51:37Z","pushed_at":"2016-11-04T08:32:45Z","git_url":"git://github.com/GoogleCloudPlatform/appengine-sharded-counters-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/appengine-sharded-counters-java.git","clone_url":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java.git","svn_url":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java","homepage":"","size":133,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/2"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-sharded-counters-java/pull/2"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/issues/2"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-sharded-counters-java/statuses/fc97e94c9a9bd6e80d086f262610894e6cb741df"}}}}
{"actor":{"display_login":"theo4u"}}