{"action":"created","comment":{"url":"https://api.github.com/repos/toddproject/todd/pulls/comments/89696201","pull_request_review_id":10235519,"id":89696201,"diff_hunk":"@@ -683,19 +683,19 @@ func (rmq rabbitMQComms) ListenForGroupTasks(groupName string, dereg chan bool)\n \t\tfor d := range msgs {\n \n \t\t\t// Unmarshal into BaseTaskMessage to determine type\n-\t\t\tvar base_msg tasks.BaseTask\n-\t\t\terr = json.Unmarshal(d.Body, &base_msg)\n+\t\t\tvar baseMsg tasks.BaseTask\n+\t\t\terr = json.Unmarshal(d.Body, &baseMsg)\n \t\t\t// TODO(mierdin): Need to handle this error\n \n \t\t\tlog.Debugf(\"Agent task received: %s\", d.Body)\n \n \t\t\t// call agent task method based on type\n-\t\t\tswitch base_msg.Type {\n+\t\t\tswitch baseMsg.Type { // TODO: remove switch?\n \n \t\t\t// This has been removed, as I am moving away from using queues that use the group name.","path":"comms/rabbitmq.go","position":323,"original_position":323,"commit_id":"5e4b520a541ca6bbd3d1da726b4e043f1e3af51b","original_commit_id":"5e4b520a541ca6bbd3d1da726b4e043f1e3af51b","user":{"login":"vcabbage","id":10789027,"avatar_url":"https://avatars.githubusercontent.com/u/10789027?v=3","gravatar_id":"","url":"https://api.github.com/users/vcabbage","html_url":"https://github.com/vcabbage","followers_url":"https://api.github.com/users/vcabbage/followers","following_url":"https://api.github.com/users/vcabbage/following{/other_user}","gists_url":"https://api.github.com/users/vcabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/vcabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcabbage/subscriptions","organizations_url":"https://api.github.com/users/vcabbage/orgs","repos_url":"https://api.github.com/users/vcabbage/repos","events_url":"https://api.github.com/users/vcabbage/events{/privacy}","received_events_url":"https://api.github.com/users/vcabbage/received_events","type":"User","site_admin":false},"body":"I didn't look very closely at the contents of this method before. Is it unused? My .02 would be to remove it entirely and put it back if needed. Dead code, commented out code, etc should always be pruned, IMO.\r\n\r\nIf you don't want to go that route, what should the new comment say? `May want to reuse this mechanism in the future`?","created_at":"2016-11-27T18:35:08Z","updated_at":"2016-11-27T18:35:08Z","html_url":"https://github.com/toddproject/todd/pull/124#discussion_r89696201","pull_request_url":"https://api.github.com/repos/toddproject/todd/pulls/124","_links":{"self":{"href":"https://api.github.com/repos/toddproject/todd/pulls/comments/89696201"},"html":{"href":"https://github.com/toddproject/todd/pull/124#discussion_r89696201"},"pull_request":{"href":"https://api.github.com/repos/toddproject/todd/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/toddproject/todd/pulls/124","id":95350869,"html_url":"https://github.com/toddproject/todd/pull/124","diff_url":"https://github.com/toddproject/todd/pull/124.diff","patch_url":"https://github.com/toddproject/todd/pull/124.patch","issue_url":"https://api.github.com/repos/toddproject/todd/issues/124","number":124,"state":"open","locked":false,"title":"Clean up linting warnings","user":{"login":"vcabbage","id":10789027,"avatar_url":"https://avatars.githubusercontent.com/u/10789027?v=3","gravatar_id":"","url":"https://api.github.com/users/vcabbage","html_url":"https://github.com/vcabbage","followers_url":"https://api.github.com/users/vcabbage/followers","following_url":"https://api.github.com/users/vcabbage/following{/other_user}","gists_url":"https://api.github.com/users/vcabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/vcabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcabbage/subscriptions","organizations_url":"https://api.github.com/users/vcabbage/orgs","repos_url":"https://api.github.com/users/vcabbage/repos","events_url":"https://api.github.com/users/vcabbage/events{/privacy}","received_events_url":"https://api.github.com/users/vcabbage/received_events","type":"User","site_admin":false},"body":"Mostly removes underscores from variable names and capitalizing acronyms, along with a handful of other fixes.\r\n\r\nAlso added a few TODOs for items that may need fixing but aren't directly related to linting warnings.","created_at":"2016-11-25T22:18:12Z","updated_at":"2016-11-27T18:35:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"839e81a7be506ea5479fbcb68661f319964d6f4d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/toddproject/todd/pulls/124/commits","review_comments_url":"https://api.github.com/repos/toddproject/todd/pulls/124/comments","review_comment_url":"https://api.github.com/repos/toddproject/todd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toddproject/todd/issues/124/comments","statuses_url":"https://api.github.com/repos/toddproject/todd/statuses/5e4b520a541ca6bbd3d1da726b4e043f1e3af51b","head":{"label":"vcabbage:linting-cleanup","ref":"linting-cleanup","sha":"5e4b520a541ca6bbd3d1da726b4e043f1e3af51b","user":{"login":"vcabbage","id":10789027,"avatar_url":"https://avatars.githubusercontent.com/u/10789027?v=3","gravatar_id":"","url":"https://api.github.com/users/vcabbage","html_url":"https://github.com/vcabbage","followers_url":"https://api.github.com/users/vcabbage/followers","following_url":"https://api.github.com/users/vcabbage/following{/other_user}","gists_url":"https://api.github.com/users/vcabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/vcabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcabbage/subscriptions","organizations_url":"https://api.github.com/users/vcabbage/orgs","repos_url":"https://api.github.com/users/vcabbage/repos","events_url":"https://api.github.com/users/vcabbage/events{/privacy}","received_events_url":"https://api.github.com/users/vcabbage/received_events","type":"User","site_admin":false},"repo":{"id":53991243,"name":"todd","full_name":"vcabbage/todd","owner":{"login":"vcabbage","id":10789027,"avatar_url":"https://avatars.githubusercontent.com/u/10789027?v=3","gravatar_id":"","url":"https://api.github.com/users/vcabbage","html_url":"https://github.com/vcabbage","followers_url":"https://api.github.com/users/vcabbage/followers","following_url":"https://api.github.com/users/vcabbage/following{/other_user}","gists_url":"https://api.github.com/users/vcabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/vcabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcabbage/subscriptions","organizations_url":"https://api.github.com/users/vcabbage/orgs","repos_url":"https://api.github.com/users/vcabbage/repos","events_url":"https://api.github.com/users/vcabbage/events{/privacy}","received_events_url":"https://api.github.com/users/vcabbage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vcabbage/todd","description":"A highly extensible framework for distributed capacity and connectivity testing (Testing on Demand....Distributed!)","fork":true,"url":"https://api.github.com/repos/vcabbage/todd","forks_url":"https://api.github.com/repos/vcabbage/todd/forks","keys_url":"https://api.github.com/repos/vcabbage/todd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcabbage/todd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcabbage/todd/teams","hooks_url":"https://api.github.com/repos/vcabbage/todd/hooks","issue_events_url":"https://api.github.com/repos/vcabbage/todd/issues/events{/number}","events_url":"https://api.github.com/repos/vcabbage/todd/events","assignees_url":"https://api.github.com/repos/vcabbage/todd/assignees{/user}","branches_url":"https://api.github.com/repos/vcabbage/todd/branches{/branch}","tags_url":"https://api.github.com/repos/vcabbage/todd/tags","blobs_url":"https://api.github.com/repos/vcabbage/todd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcabbage/todd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcabbage/todd/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcabbage/todd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcabbage/todd/statuses/{sha}","languages_url":"https://api.github.com/repos/vcabbage/todd/languages","stargazers_url":"https://api.github.com/repos/vcabbage/todd/stargazers","contributors_url":"https://api.github.com/repos/vcabbage/todd/contributors","subscribers_url":"https://api.github.com/repos/vcabbage/todd/subscribers","subscription_url":"https://api.github.com/repos/vcabbage/todd/subscription","commits_url":"https://api.github.com/repos/vcabbage/todd/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcabbage/todd/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcabbage/todd/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcabbage/todd/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcabbage/todd/contents/{+path}","compare_url":"https://api.github.com/repos/vcabbage/todd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcabbage/todd/merges","archive_url":"https://api.github.com/repos/vcabbage/todd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcabbage/todd/downloads","issues_url":"https://api.github.com/repos/vcabbage/todd/issues{/number}","pulls_url":"https://api.github.com/repos/vcabbage/todd/pulls{/number}","milestones_url":"https://api.github.com/repos/vcabbage/todd/milestones{/number}","notifications_url":"https://api.github.com/repos/vcabbage/todd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcabbage/todd/labels{/name}","releases_url":"https://api.github.com/repos/vcabbage/todd/releases{/id}","deployments_url":"https://api.github.com/repos/vcabbage/todd/deployments","created_at":"2016-03-16T01:32:26Z","updated_at":"2016-03-16T01:32:27Z","pushed_at":"2016-11-27T00:07:43Z","git_url":"git://github.com/vcabbage/todd.git","ssh_url":"git@github.com:vcabbage/todd.git","clone_url":"https://github.com/vcabbage/todd.git","svn_url":"https://github.com/vcabbage/todd","homepage":null,"size":7082,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"toddproject:master","ref":"master","sha":"97ff88985ac26f97ab12631f872b078a3b15c406","user":{"login":"toddproject","id":21033436,"avatar_url":"https://avatars.githubusercontent.com/u/21033436?v=3","gravatar_id":"","url":"https://api.github.com/users/toddproject","html_url":"https://github.com/toddproject","followers_url":"https://api.github.com/users/toddproject/followers","following_url":"https://api.github.com/users/toddproject/following{/other_user}","gists_url":"https://api.github.com/users/toddproject/gists{/gist_id}","starred_url":"https://api.github.com/users/toddproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddproject/subscriptions","organizations_url":"https://api.github.com/users/toddproject/orgs","repos_url":"https://api.github.com/users/toddproject/repos","events_url":"https://api.github.com/users/toddproject/events{/privacy}","received_events_url":"https://api.github.com/users/toddproject/received_events","type":"Organization","site_admin":false},"repo":{"id":53824369,"name":"todd","full_name":"toddproject/todd","owner":{"login":"toddproject","id":21033436,"avatar_url":"https://avatars.githubusercontent.com/u/21033436?v=3","gravatar_id":"","url":"https://api.github.com/users/toddproject","html_url":"https://github.com/toddproject","followers_url":"https://api.github.com/users/toddproject/followers","following_url":"https://api.github.com/users/toddproject/following{/other_user}","gists_url":"https://api.github.com/users/toddproject/gists{/gist_id}","starred_url":"https://api.github.com/users/toddproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddproject/subscriptions","organizations_url":"https://api.github.com/users/toddproject/orgs","repos_url":"https://api.github.com/users/toddproject/repos","events_url":"https://api.github.com/users/toddproject/events{/privacy}","received_events_url":"https://api.github.com/users/toddproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toddproject/todd","description":"A highly extensible framework for distributed capacity and connectivity testing (Testing on Demand....Distributed!)","fork":false,"url":"https://api.github.com/repos/toddproject/todd","forks_url":"https://api.github.com/repos/toddproject/todd/forks","keys_url":"https://api.github.com/repos/toddproject/todd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toddproject/todd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toddproject/todd/teams","hooks_url":"https://api.github.com/repos/toddproject/todd/hooks","issue_events_url":"https://api.github.com/repos/toddproject/todd/issues/events{/number}","events_url":"https://api.github.com/repos/toddproject/todd/events","assignees_url":"https://api.github.com/repos/toddproject/todd/assignees{/user}","branches_url":"https://api.github.com/repos/toddproject/todd/branches{/branch}","tags_url":"https://api.github.com/repos/toddproject/todd/tags","blobs_url":"https://api.github.com/repos/toddproject/todd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toddproject/todd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toddproject/todd/git/refs{/sha}","trees_url":"https://api.github.com/repos/toddproject/todd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toddproject/todd/statuses/{sha}","languages_url":"https://api.github.com/repos/toddproject/todd/languages","stargazers_url":"https://api.github.com/repos/toddproject/todd/stargazers","contributors_url":"https://api.github.com/repos/toddproject/todd/contributors","subscribers_url":"https://api.github.com/repos/toddproject/todd/subscribers","subscription_url":"https://api.github.com/repos/toddproject/todd/subscription","commits_url":"https://api.github.com/repos/toddproject/todd/commits{/sha}","git_commits_url":"https://api.github.com/repos/toddproject/todd/git/commits{/sha}","comments_url":"https://api.github.com/repos/toddproject/todd/comments{/number}","issue_comment_url":"https://api.github.com/repos/toddproject/todd/issues/comments{/number}","contents_url":"https://api.github.com/repos/toddproject/todd/contents/{+path}","compare_url":"https://api.github.com/repos/toddproject/todd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toddproject/todd/merges","archive_url":"https://api.github.com/repos/toddproject/todd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toddproject/todd/downloads","issues_url":"https://api.github.com/repos/toddproject/todd/issues{/number}","pulls_url":"https://api.github.com/repos/toddproject/todd/pulls{/number}","milestones_url":"https://api.github.com/repos/toddproject/todd/milestones{/number}","notifications_url":"https://api.github.com/repos/toddproject/todd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toddproject/todd/labels{/name}","releases_url":"https://api.github.com/repos/toddproject/todd/releases{/id}","deployments_url":"https://api.github.com/repos/toddproject/todd/deployments","created_at":"2016-03-14T03:32:32Z","updated_at":"2016-11-25T21:37:43Z","pushed_at":"2016-11-26T01:23:07Z","git_url":"git://github.com/toddproject/todd.git","ssh_url":"git@github.com:toddproject/todd.git","clone_url":"https://github.com/toddproject/todd.git","svn_url":"https://github.com/toddproject/todd","homepage":null,"size":8517,"stargazers_count":134,"watchers_count":134,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":52,"forks":15,"open_issues":52,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toddproject/todd/pulls/124"},"html":{"href":"https://github.com/toddproject/todd/pull/124"},"issue":{"href":"https://api.github.com/repos/toddproject/todd/issues/124"},"comments":{"href":"https://api.github.com/repos/toddproject/todd/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/toddproject/todd/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/toddproject/todd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toddproject/todd/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/toddproject/todd/statuses/5e4b520a541ca6bbd3d1da726b4e043f1e3af51b"}}}}
{"actor":{"display_login":"vcabbage"}}