{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/ds2/pulls/comments/66368897","id":66368897,"diff_hunk":"@@ -104,10 +122,52 @@ ErrorCode Process::detach() {\n   return kSuccess;\n }\n \n+BOOL Process::writeDebugBreakCode(uint64_t address) {\n+  FARPROC exitThreadAddress =\n+      GetProcAddress(GetModuleHandleA(\"ntdll\"), \"RtlExitUserThread\");","path":"Sources/Target/Windows/Process.cpp","position":38,"original_position":38,"commit_id":"8566858575787ec14d250e633fe8287141c330ac","original_commit_id":"8566858575787ec14d250e633fe8287141c330ac","user":{"login":"a20012251","id":1613874,"avatar_url":"https://avatars.githubusercontent.com/u/1613874?v=3","gravatar_id":"","url":"https://api.github.com/users/a20012251","html_url":"https://github.com/a20012251","followers_url":"https://api.github.com/users/a20012251/followers","following_url":"https://api.github.com/users/a20012251/following{/other_user}","gists_url":"https://api.github.com/users/a20012251/gists{/gist_id}","starred_url":"https://api.github.com/users/a20012251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a20012251/subscriptions","organizations_url":"https://api.github.com/users/a20012251/orgs","repos_url":"https://api.github.com/users/a20012251/repos","events_url":"https://api.github.com/users/a20012251/events{/privacy}","received_events_url":"https://api.github.com/users/a20012251/received_events","type":"User","site_admin":false},"body":"if any of these functions fail exitThreadAddress will be NULL anyway\r\n","created_at":"2016-06-09T01:14:13Z","updated_at":"2016-06-09T01:14:13Z","html_url":"https://github.com/facebook/ds2/pull/365#discussion_r66368897","pull_request_url":"https://api.github.com/repos/facebook/ds2/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/facebook/ds2/pulls/comments/66368897"},"html":{"href":"https://github.com/facebook/ds2/pull/365#discussion_r66368897"},"pull_request":{"href":"https://api.github.com/repos/facebook/ds2/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/ds2/pulls/365","id":72961942,"html_url":"https://github.com/facebook/ds2/pull/365","diff_url":"https://github.com/facebook/ds2/pull/365.diff","patch_url":"https://github.com/facebook/ds2/pull/365.patch","issue_url":"https://api.github.com/repos/facebook/ds2/issues/365","number":365,"state":"open","locked":false,"title":"Implement a custom DebugBreakProcess","user":{"login":"a20012251","id":1613874,"avatar_url":"https://avatars.githubusercontent.com/u/1613874?v=3","gravatar_id":"","url":"https://api.github.com/users/a20012251","html_url":"https://github.com/a20012251","followers_url":"https://api.github.com/users/a20012251/followers","following_url":"https://api.github.com/users/a20012251/following{/other_user}","gists_url":"https://api.github.com/users/a20012251/gists{/gist_id}","starred_url":"https://api.github.com/users/a20012251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a20012251/subscriptions","organizations_url":"https://api.github.com/users/a20012251/orgs","repos_url":"https://api.github.com/users/a20012251/repos","events_url":"https://api.github.com/users/a20012251/events{/privacy}","received_events_url":"https://api.github.com/users/a20012251/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-07T22:53:06Z","updated_at":"2016-06-09T01:14:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b19994d1e01031c51a7ba391721b0a26c3dc694a","assignee":{"login":"sas","id":51052,"avatar_url":"https://avatars.githubusercontent.com/u/51052?v=3","gravatar_id":"","url":"https://api.github.com/users/sas","html_url":"https://github.com/sas","followers_url":"https://api.github.com/users/sas/followers","following_url":"https://api.github.com/users/sas/following{/other_user}","gists_url":"https://api.github.com/users/sas/gists{/gist_id}","starred_url":"https://api.github.com/users/sas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sas/subscriptions","organizations_url":"https://api.github.com/users/sas/orgs","repos_url":"https://api.github.com/users/sas/repos","events_url":"https://api.github.com/users/sas/events{/privacy}","received_events_url":"https://api.github.com/users/sas/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/ds2/pulls/365/commits","review_comments_url":"https://api.github.com/repos/facebook/ds2/pulls/365/comments","review_comment_url":"https://api.github.com/repos/facebook/ds2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/ds2/issues/365/comments","statuses_url":"https://api.github.com/repos/facebook/ds2/statuses/8566858575787ec14d250e633fe8287141c330ac","head":{"label":"a20012251:debugbreak_arm","ref":"debugbreak_arm","sha":"8566858575787ec14d250e633fe8287141c330ac","user":{"login":"a20012251","id":1613874,"avatar_url":"https://avatars.githubusercontent.com/u/1613874?v=3","gravatar_id":"","url":"https://api.github.com/users/a20012251","html_url":"https://github.com/a20012251","followers_url":"https://api.github.com/users/a20012251/followers","following_url":"https://api.github.com/users/a20012251/following{/other_user}","gists_url":"https://api.github.com/users/a20012251/gists{/gist_id}","starred_url":"https://api.github.com/users/a20012251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a20012251/subscriptions","organizations_url":"https://api.github.com/users/a20012251/orgs","repos_url":"https://api.github.com/users/a20012251/repos","events_url":"https://api.github.com/users/a20012251/events{/privacy}","received_events_url":"https://api.github.com/users/a20012251/received_events","type":"User","site_admin":false},"repo":{"id":50541549,"name":"ds2","full_name":"a20012251/ds2","owner":{"login":"a20012251","id":1613874,"avatar_url":"https://avatars.githubusercontent.com/u/1613874?v=3","gravatar_id":"","url":"https://api.github.com/users/a20012251","html_url":"https://github.com/a20012251","followers_url":"https://api.github.com/users/a20012251/followers","following_url":"https://api.github.com/users/a20012251/following{/other_user}","gists_url":"https://api.github.com/users/a20012251/gists{/gist_id}","starred_url":"https://api.github.com/users/a20012251/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a20012251/subscriptions","organizations_url":"https://api.github.com/users/a20012251/orgs","repos_url":"https://api.github.com/users/a20012251/repos","events_url":"https://api.github.com/users/a20012251/events{/privacy}","received_events_url":"https://api.github.com/users/a20012251/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a20012251/ds2","description":"Debug server for lldb.","fork":true,"url":"https://api.github.com/repos/a20012251/ds2","forks_url":"https://api.github.com/repos/a20012251/ds2/forks","keys_url":"https://api.github.com/repos/a20012251/ds2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a20012251/ds2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a20012251/ds2/teams","hooks_url":"https://api.github.com/repos/a20012251/ds2/hooks","issue_events_url":"https://api.github.com/repos/a20012251/ds2/issues/events{/number}","events_url":"https://api.github.com/repos/a20012251/ds2/events","assignees_url":"https://api.github.com/repos/a20012251/ds2/assignees{/user}","branches_url":"https://api.github.com/repos/a20012251/ds2/branches{/branch}","tags_url":"https://api.github.com/repos/a20012251/ds2/tags","blobs_url":"https://api.github.com/repos/a20012251/ds2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a20012251/ds2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a20012251/ds2/git/refs{/sha}","trees_url":"https://api.github.com/repos/a20012251/ds2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a20012251/ds2/statuses/{sha}","languages_url":"https://api.github.com/repos/a20012251/ds2/languages","stargazers_url":"https://api.github.com/repos/a20012251/ds2/stargazers","contributors_url":"https://api.github.com/repos/a20012251/ds2/contributors","subscribers_url":"https://api.github.com/repos/a20012251/ds2/subscribers","subscription_url":"https://api.github.com/repos/a20012251/ds2/subscription","commits_url":"https://api.github.com/repos/a20012251/ds2/commits{/sha}","git_commits_url":"https://api.github.com/repos/a20012251/ds2/git/commits{/sha}","comments_url":"https://api.github.com/repos/a20012251/ds2/comments{/number}","issue_comment_url":"https://api.github.com/repos/a20012251/ds2/issues/comments{/number}","contents_url":"https://api.github.com/repos/a20012251/ds2/contents/{+path}","compare_url":"https://api.github.com/repos/a20012251/ds2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a20012251/ds2/merges","archive_url":"https://api.github.com/repos/a20012251/ds2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a20012251/ds2/downloads","issues_url":"https://api.github.com/repos/a20012251/ds2/issues{/number}","pulls_url":"https://api.github.com/repos/a20012251/ds2/pulls{/number}","milestones_url":"https://api.github.com/repos/a20012251/ds2/milestones{/number}","notifications_url":"https://api.github.com/repos/a20012251/ds2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a20012251/ds2/labels{/name}","releases_url":"https://api.github.com/repos/a20012251/ds2/releases{/id}","deployments_url":"https://api.github.com/repos/a20012251/ds2/deployments","created_at":"2016-01-27T22:11:09Z","updated_at":"2016-01-27T22:11:12Z","pushed_at":"2016-06-08T21:22:42Z","git_url":"git://github.com/a20012251/ds2.git","ssh_url":"git@github.com:a20012251/ds2.git","clone_url":"https://github.com/a20012251/ds2.git","svn_url":"https://github.com/a20012251/ds2","homepage":null,"size":1892,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"77f97d424867dd08a49312abeda19181bfe70dc3","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":25325140,"name":"ds2","full_name":"facebook/ds2","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/ds2","description":"Debug server for lldb.","fork":false,"url":"https://api.github.com/repos/facebook/ds2","forks_url":"https://api.github.com/repos/facebook/ds2/forks","keys_url":"https://api.github.com/repos/facebook/ds2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/ds2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/ds2/teams","hooks_url":"https://api.github.com/repos/facebook/ds2/hooks","issue_events_url":"https://api.github.com/repos/facebook/ds2/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/ds2/events","assignees_url":"https://api.github.com/repos/facebook/ds2/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/ds2/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/ds2/tags","blobs_url":"https://api.github.com/repos/facebook/ds2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/ds2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/ds2/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/ds2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/ds2/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/ds2/languages","stargazers_url":"https://api.github.com/repos/facebook/ds2/stargazers","contributors_url":"https://api.github.com/repos/facebook/ds2/contributors","subscribers_url":"https://api.github.com/repos/facebook/ds2/subscribers","subscription_url":"https://api.github.com/repos/facebook/ds2/subscription","commits_url":"https://api.github.com/repos/facebook/ds2/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/ds2/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/ds2/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/ds2/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/ds2/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/ds2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/ds2/merges","archive_url":"https://api.github.com/repos/facebook/ds2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/ds2/downloads","issues_url":"https://api.github.com/repos/facebook/ds2/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/ds2/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/ds2/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/ds2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/ds2/labels{/name}","releases_url":"https://api.github.com/repos/facebook/ds2/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/ds2/deployments","created_at":"2014-10-16T22:32:52Z","updated_at":"2016-06-06T21:06:05Z","pushed_at":"2016-06-08T23:58:33Z","git_url":"git://github.com/facebook/ds2.git","ssh_url":"git@github.com:facebook/ds2.git","clone_url":"https://github.com/facebook/ds2.git","svn_url":"https://github.com/facebook/ds2","homepage":null,"size":93422,"stargazers_count":134,"watchers_count":134,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":18,"forks":33,"open_issues":18,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/ds2/pulls/365"},"html":{"href":"https://github.com/facebook/ds2/pull/365"},"issue":{"href":"https://api.github.com/repos/facebook/ds2/issues/365"},"comments":{"href":"https://api.github.com/repos/facebook/ds2/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/ds2/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/ds2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/ds2/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/ds2/statuses/8566858575787ec14d250e633fe8287141c330ac"}}}}
{"actor":{"display_login":"a20012251"}}