{"action":"created","comment":{"url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/comments/84228346","pull_request_review_id":5017642,"id":84228346,"diff_hunk":"@@ -1,46 +1,11 @@\n-Disclaimer\n-==========\n-The code in here is currently in an early preview state following the principle of 'First make it work, then make it beautiful'*[]: \n-__It has not yet been optimized for performance and contains a lot of boilerplate.__\n-\n-\n-Using it\n-========\n-\n-After building this project you can start using it with the following prototype:\n-\n-[Vert.x Scala Lang SBT-starter](https://github.com/codepitbull/vertx-scala-sbt)\n-\n-If you want to play with Vert.x-web and the security modules check out and build:\n-\n-[Vert.x Scala Lang Stack](https://github.com/codepitbull/vertx-lang-scala-stack)\n-\n-Diversions from Vert.x-API\n-==========================\n-\n-Futures, Promises and the VertxExecutionContext\n-===============================================\n-Scala has built in Promises/Futures. They're a perfect replacement for completionHandlers and so on.\n-To use them we needed an _implicit VertxExectionContext_ which is available inside every Verticle deriving from \n- ScalaVerticle.\n- \n-Using Scala-Futures removes the need for the Vert.x-CompositeFuture and makes for a more fluent programming experience:  \n-```\n-class PromiseTestVerticle extends ScalaVerticle {\n-\n-  override def start(startFuture: Future[Void]): Unit = {\n-    val f1 = vertx.eventBus().consumer[String](\"asd\").handler(a => println(a)).completionFuture()\n-    val f2 = vertx.eventBus().consumer[String](\"asd2\").handler(a => println(a)).completionFuture()\n-    val res = for {\n-      a1 <- f1\n-      a2 <- f2\n-    } yield (a1 + \" \" + a2)\n-    res.map(a => startFuture.complete())\n-  }\n-}\n-```\n-\n-Next Steps\n-==========\n-- get rid of unneeded imports\n-- replace references to original Java-classes with types\n\\ No newline at end of file\n+vertx-lang-scala\n+================\n+## CI\n+\n+  [![Build Status](https://vertx.ci.cloudbees.com/buildStatus/icon?job=vert.x3-lang-scala)](https://vertx.ci.cloudbees.com/view/vert.x-3/job/vert.x3-lang-scala/)\n+  \n+## Structure\n+- vertx-lang-scala: The main module containign the actual language implementation\n+- vertx-lang-scala-stack: All currently available modules\n+- vertx-lang-scala-on-the-fly: A compiler-implementationt that allows to compile Scala-code from source/classpath. ","path":"README.md","position":57,"original_position":57,"commit_id":"27536fd43bcbbce6d3d2dac847c3bb7a9b3e0943","original_commit_id":"27536fd43bcbbce6d3d2dac847c3bb7a9b3e0943","user":{"login":"jponge","id":25961,"avatar_url":"https://avatars.githubusercontent.com/u/25961?v=3","gravatar_id":"","url":"https://api.github.com/users/jponge","html_url":"https://github.com/jponge","followers_url":"https://api.github.com/users/jponge/followers","following_url":"https://api.github.com/users/jponge/following{/other_user}","gists_url":"https://api.github.com/users/jponge/gists{/gist_id}","starred_url":"https://api.github.com/users/jponge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jponge/subscriptions","organizations_url":"https://api.github.com/users/jponge/orgs","repos_url":"https://api.github.com/users/jponge/repos","events_url":"https://api.github.com/users/jponge/events{/privacy}","received_events_url":"https://api.github.com/users/jponge/received_events","type":"User","site_admin":false},"body":"Typo: implementation*t* 😉 ","created_at":"2016-10-20T07:50:48Z","updated_at":"2016-10-20T07:55:26Z","html_url":"https://github.com/vert-x3/vertx-lang-scala/pull/13#discussion_r84228346","pull_request_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/comments/84228346"},"html":{"href":"https://github.com/vert-x3/vertx-lang-scala/pull/13#discussion_r84228346"},"pull_request":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/13","id":90097068,"html_url":"https://github.com/vert-x3/vertx-lang-scala/pull/13","diff_url":"https://github.com/vert-x3/vertx-lang-scala/pull/13.diff","patch_url":"https://github.com/vert-x3/vertx-lang-scala/pull/13.patch","issue_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/issues/13","number":13,"state":"open","locked":false,"title":"Build-restructuring, new modules and a compile","user":{"login":"codepitbull","id":1409931,"avatar_url":"https://avatars.githubusercontent.com/u/1409931?v=3","gravatar_id":"","url":"https://api.github.com/users/codepitbull","html_url":"https://github.com/codepitbull","followers_url":"https://api.github.com/users/codepitbull/followers","following_url":"https://api.github.com/users/codepitbull/following{/other_user}","gists_url":"https://api.github.com/users/codepitbull/gists{/gist_id}","starred_url":"https://api.github.com/users/codepitbull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepitbull/subscriptions","organizations_url":"https://api.github.com/users/codepitbull/orgs","repos_url":"https://api.github.com/users/codepitbull/repos","events_url":"https://api.github.com/users/codepitbull/events{/privacy}","received_events_url":"https://api.github.com/users/codepitbull/received_events","type":"User","site_admin":false},"body":"- Build is now a multi module build\r\n- added vertx-lang-scala-stack that contains all currently supported modules\r\n- added vertx-lang-scala-on-the-fly containing a compiler to build code from source-strings and classpath","created_at":"2016-10-19T21:47:14Z","updated_at":"2016-10-20T07:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"885e1b6a2cfc1a595ce9f6f3f2d405d3eade7fd4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/13/commits","review_comments_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/13/comments","review_comment_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/issues/13/comments","statuses_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/statuses/27536fd43bcbbce6d3d2dac847c3bb7a9b3e0943","head":{"label":"codepitbull:master","ref":"master","sha":"27536fd43bcbbce6d3d2dac847c3bb7a9b3e0943","user":{"login":"codepitbull","id":1409931,"avatar_url":"https://avatars.githubusercontent.com/u/1409931?v=3","gravatar_id":"","url":"https://api.github.com/users/codepitbull","html_url":"https://github.com/codepitbull","followers_url":"https://api.github.com/users/codepitbull/followers","following_url":"https://api.github.com/users/codepitbull/following{/other_user}","gists_url":"https://api.github.com/users/codepitbull/gists{/gist_id}","starred_url":"https://api.github.com/users/codepitbull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepitbull/subscriptions","organizations_url":"https://api.github.com/users/codepitbull/orgs","repos_url":"https://api.github.com/users/codepitbull/repos","events_url":"https://api.github.com/users/codepitbull/events{/privacy}","received_events_url":"https://api.github.com/users/codepitbull/received_events","type":"User","site_admin":false},"repo":{"id":63055867,"name":"vertx-lang-scala","full_name":"codepitbull/vertx-lang-scala","owner":{"login":"codepitbull","id":1409931,"avatar_url":"https://avatars.githubusercontent.com/u/1409931?v=3","gravatar_id":"","url":"https://api.github.com/users/codepitbull","html_url":"https://github.com/codepitbull","followers_url":"https://api.github.com/users/codepitbull/followers","following_url":"https://api.github.com/users/codepitbull/following{/other_user}","gists_url":"https://api.github.com/users/codepitbull/gists{/gist_id}","starred_url":"https://api.github.com/users/codepitbull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepitbull/subscriptions","organizations_url":"https://api.github.com/users/codepitbull/orgs","repos_url":"https://api.github.com/users/codepitbull/repos","events_url":"https://api.github.com/users/codepitbull/events{/privacy}","received_events_url":"https://api.github.com/users/codepitbull/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codepitbull/vertx-lang-scala","description":null,"fork":true,"url":"https://api.github.com/repos/codepitbull/vertx-lang-scala","forks_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/forks","keys_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/teams","hooks_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/hooks","issue_events_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/issues/events{/number}","events_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/events","assignees_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/assignees{/user}","branches_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/branches{/branch}","tags_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/tags","blobs_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/languages","stargazers_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/stargazers","contributors_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/contributors","subscribers_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/subscribers","subscription_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/subscription","commits_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/contents/{+path}","compare_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/merges","archive_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/downloads","issues_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/issues{/number}","pulls_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/labels{/name}","releases_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/releases{/id}","deployments_url":"https://api.github.com/repos/codepitbull/vertx-lang-scala/deployments","created_at":"2016-07-11T09:42:19Z","updated_at":"2016-07-11T09:42:20Z","pushed_at":"2016-10-19T21:44:08Z","git_url":"git://github.com/codepitbull/vertx-lang-scala.git","ssh_url":"git@github.com:codepitbull/vertx-lang-scala.git","clone_url":"https://github.com/codepitbull/vertx-lang-scala.git","svn_url":"https://github.com/codepitbull/vertx-lang-scala","homepage":null,"size":1335,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vert-x3:master","ref":"master","sha":"b749b97f41962cbbbdadd64c646e884766e46da5","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":26167102,"name":"vertx-lang-scala","full_name":"vert-x3/vertx-lang-scala","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-lang-scala","description":null,"fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-lang-scala","forks_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-lang-scala/deployments","created_at":"2014-11-04T12:04:52Z","updated_at":"2016-10-17T18:28:23Z","pushed_at":"2016-10-19T21:47:14Z","git_url":"git://github.com/vert-x3/vertx-lang-scala.git","ssh_url":"git@github.com:vert-x3/vertx-lang-scala.git","clone_url":"https://github.com/vert-x3/vertx-lang-scala.git","svn_url":"https://github.com/vert-x3/vertx-lang-scala","homepage":null,"size":849,"stargazers_count":25,"watchers_count":25,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/13"},"html":{"href":"https://github.com/vert-x3/vertx-lang-scala/pull/13"},"issue":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/issues/13"},"comments":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/vert-x3/vertx-lang-scala/statuses/27536fd43bcbbce6d3d2dac847c3bb7a9b3e0943"}}}}
{"actor":{"display_login":"jponge"}}