{"action":"created","comment":{"url":"https://api.github.com/repos/dtan4/terraforming/pulls/comments/70004241","id":70004241,"diff_hunk":"@@ -44,11 +44,11 @@ def tfstate\n       private\n \n       def group_members_of(group)\n-        @client.get_group(group_name: group.group_name).users.map { |user| user.user_name }\n+        @client.get_group(group_name: group.group_name).map(&:users).flatten.map { |user| user.user_name }","path":"lib/terraforming/resource/iam_group_membership.rb","position":5,"original_position":5,"commit_id":"1cc15b3fa9dfe6999984614e3ca4a89e1f17eab0","original_commit_id":"1cc15b3fa9dfe6999984614e3ca4a89e1f17eab0","user":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"body":"__[rubocop]__\n* Line is too long. [93/80] [:ref](https://github.com/bbatsov/ruby-style-guide#80-character-limits)\n* Pass `&:user_name` as an argument to `map` instead of a block.","created_at":"2016-07-07T23:16:50Z","updated_at":"2016-07-07T23:16:50Z","html_url":"https://github.com/dtan4/terraforming/pull/236#discussion_r70004241","pull_request_url":"https://api.github.com/repos/dtan4/terraforming/pulls/236","_links":{"self":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/comments/70004241"},"html":{"href":"https://github.com/dtan4/terraforming/pull/236#discussion_r70004241"},"pull_request":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/dtan4/terraforming/pulls/236","id":74702344,"html_url":"https://github.com/dtan4/terraforming/pull/236","diff_url":"https://github.com/dtan4/terraforming/pull/236.diff","patch_url":"https://github.com/dtan4/terraforming/pull/236.patch","issue_url":"https://api.github.com/repos/dtan4/terraforming/issues/236","number":236,"state":"open","locked":false,"title":"add pagination to iam_ resources","user":{"login":"philsnow","id":297781,"avatar_url":"https://avatars.githubusercontent.com/u/297781?v=3","gravatar_id":"","url":"https://api.github.com/users/philsnow","html_url":"https://github.com/philsnow","followers_url":"https://api.github.com/users/philsnow/followers","following_url":"https://api.github.com/users/philsnow/following{/other_user}","gists_url":"https://api.github.com/users/philsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/philsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsnow/subscriptions","organizations_url":"https://api.github.com/users/philsnow/orgs","repos_url":"https://api.github.com/users/philsnow/repos","events_url":"https://api.github.com/users/philsnow/events{/privacy}","received_events_url":"https://api.github.com/users/philsnow/received_events","type":"User","site_admin":false},"body":"The resources API has a super clean way of enumerating without tons of\r\nboilerplate `while resp.is_truncated` loops.\r\n\r\nI only did this for a few resource types because I wanted to check in with @dtan4 about using the resources API and didn't want to do the same work x20 if it's not mergeable.","created_at":"2016-06-21T23:25:19Z","updated_at":"2016-07-07T23:16:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0507e118c0561fe0493092dccbb8bbafc1245b88","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dtan4/terraforming/pulls/236/commits","review_comments_url":"https://api.github.com/repos/dtan4/terraforming/pulls/236/comments","review_comment_url":"https://api.github.com/repos/dtan4/terraforming/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dtan4/terraforming/issues/236/comments","statuses_url":"https://api.github.com/repos/dtan4/terraforming/statuses/1cc15b3fa9dfe6999984614e3ca4a89e1f17eab0","head":{"label":"philsnow:philsnow/pagination","ref":"philsnow/pagination","sha":"1cc15b3fa9dfe6999984614e3ca4a89e1f17eab0","user":{"login":"philsnow","id":297781,"avatar_url":"https://avatars.githubusercontent.com/u/297781?v=3","gravatar_id":"","url":"https://api.github.com/users/philsnow","html_url":"https://github.com/philsnow","followers_url":"https://api.github.com/users/philsnow/followers","following_url":"https://api.github.com/users/philsnow/following{/other_user}","gists_url":"https://api.github.com/users/philsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/philsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsnow/subscriptions","organizations_url":"https://api.github.com/users/philsnow/orgs","repos_url":"https://api.github.com/users/philsnow/repos","events_url":"https://api.github.com/users/philsnow/events{/privacy}","received_events_url":"https://api.github.com/users/philsnow/received_events","type":"User","site_admin":false},"repo":{"id":61673864,"name":"terraforming","full_name":"philsnow/terraforming","owner":{"login":"philsnow","id":297781,"avatar_url":"https://avatars.githubusercontent.com/u/297781?v=3","gravatar_id":"","url":"https://api.github.com/users/philsnow","html_url":"https://github.com/philsnow","followers_url":"https://api.github.com/users/philsnow/followers","following_url":"https://api.github.com/users/philsnow/following{/other_user}","gists_url":"https://api.github.com/users/philsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/philsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsnow/subscriptions","organizations_url":"https://api.github.com/users/philsnow/orgs","repos_url":"https://api.github.com/users/philsnow/repos","events_url":"https://api.github.com/users/philsnow/events{/privacy}","received_events_url":"https://api.github.com/users/philsnow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philsnow/terraforming","description":"Export existing AWS resources to Terraform style (tf, tfstate)","fork":true,"url":"https://api.github.com/repos/philsnow/terraforming","forks_url":"https://api.github.com/repos/philsnow/terraforming/forks","keys_url":"https://api.github.com/repos/philsnow/terraforming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philsnow/terraforming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philsnow/terraforming/teams","hooks_url":"https://api.github.com/repos/philsnow/terraforming/hooks","issue_events_url":"https://api.github.com/repos/philsnow/terraforming/issues/events{/number}","events_url":"https://api.github.com/repos/philsnow/terraforming/events","assignees_url":"https://api.github.com/repos/philsnow/terraforming/assignees{/user}","branches_url":"https://api.github.com/repos/philsnow/terraforming/branches{/branch}","tags_url":"https://api.github.com/repos/philsnow/terraforming/tags","blobs_url":"https://api.github.com/repos/philsnow/terraforming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philsnow/terraforming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philsnow/terraforming/git/refs{/sha}","trees_url":"https://api.github.com/repos/philsnow/terraforming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philsnow/terraforming/statuses/{sha}","languages_url":"https://api.github.com/repos/philsnow/terraforming/languages","stargazers_url":"https://api.github.com/repos/philsnow/terraforming/stargazers","contributors_url":"https://api.github.com/repos/philsnow/terraforming/contributors","subscribers_url":"https://api.github.com/repos/philsnow/terraforming/subscribers","subscription_url":"https://api.github.com/repos/philsnow/terraforming/subscription","commits_url":"https://api.github.com/repos/philsnow/terraforming/commits{/sha}","git_commits_url":"https://api.github.com/repos/philsnow/terraforming/git/commits{/sha}","comments_url":"https://api.github.com/repos/philsnow/terraforming/comments{/number}","issue_comment_url":"https://api.github.com/repos/philsnow/terraforming/issues/comments{/number}","contents_url":"https://api.github.com/repos/philsnow/terraforming/contents/{+path}","compare_url":"https://api.github.com/repos/philsnow/terraforming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philsnow/terraforming/merges","archive_url":"https://api.github.com/repos/philsnow/terraforming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philsnow/terraforming/downloads","issues_url":"https://api.github.com/repos/philsnow/terraforming/issues{/number}","pulls_url":"https://api.github.com/repos/philsnow/terraforming/pulls{/number}","milestones_url":"https://api.github.com/repos/philsnow/terraforming/milestones{/number}","notifications_url":"https://api.github.com/repos/philsnow/terraforming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philsnow/terraforming/labels{/name}","releases_url":"https://api.github.com/repos/philsnow/terraforming/releases{/id}","deployments_url":"https://api.github.com/repos/philsnow/terraforming/deployments","created_at":"2016-06-21T23:22:45Z","updated_at":"2016-06-21T23:22:46Z","pushed_at":"2016-07-07T23:16:11Z","git_url":"git://github.com/philsnow/terraforming.git","ssh_url":"git@github.com:philsnow/terraforming.git","clone_url":"https://github.com/philsnow/terraforming.git","svn_url":"https://github.com/philsnow/terraforming","homepage":"http://terraforming.dtan4.net/","size":786,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dtan4:master","ref":"master","sha":"e049e0077d5671f4bcca1a5a1050b37422748eda","user":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"repo":{"id":32841259,"name":"terraforming","full_name":"dtan4/terraforming","owner":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtan4/terraforming","description":"Export existing AWS resources to Terraform style (tf, tfstate)","fork":false,"url":"https://api.github.com/repos/dtan4/terraforming","forks_url":"https://api.github.com/repos/dtan4/terraforming/forks","keys_url":"https://api.github.com/repos/dtan4/terraforming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtan4/terraforming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtan4/terraforming/teams","hooks_url":"https://api.github.com/repos/dtan4/terraforming/hooks","issue_events_url":"https://api.github.com/repos/dtan4/terraforming/issues/events{/number}","events_url":"https://api.github.com/repos/dtan4/terraforming/events","assignees_url":"https://api.github.com/repos/dtan4/terraforming/assignees{/user}","branches_url":"https://api.github.com/repos/dtan4/terraforming/branches{/branch}","tags_url":"https://api.github.com/repos/dtan4/terraforming/tags","blobs_url":"https://api.github.com/repos/dtan4/terraforming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtan4/terraforming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtan4/terraforming/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtan4/terraforming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtan4/terraforming/statuses/{sha}","languages_url":"https://api.github.com/repos/dtan4/terraforming/languages","stargazers_url":"https://api.github.com/repos/dtan4/terraforming/stargazers","contributors_url":"https://api.github.com/repos/dtan4/terraforming/contributors","subscribers_url":"https://api.github.com/repos/dtan4/terraforming/subscribers","subscription_url":"https://api.github.com/repos/dtan4/terraforming/subscription","commits_url":"https://api.github.com/repos/dtan4/terraforming/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtan4/terraforming/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtan4/terraforming/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtan4/terraforming/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtan4/terraforming/contents/{+path}","compare_url":"https://api.github.com/repos/dtan4/terraforming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtan4/terraforming/merges","archive_url":"https://api.github.com/repos/dtan4/terraforming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtan4/terraforming/downloads","issues_url":"https://api.github.com/repos/dtan4/terraforming/issues{/number}","pulls_url":"https://api.github.com/repos/dtan4/terraforming/pulls{/number}","milestones_url":"https://api.github.com/repos/dtan4/terraforming/milestones{/number}","notifications_url":"https://api.github.com/repos/dtan4/terraforming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtan4/terraforming/labels{/name}","releases_url":"https://api.github.com/repos/dtan4/terraforming/releases{/id}","deployments_url":"https://api.github.com/repos/dtan4/terraforming/deployments","created_at":"2015-03-25T03:50:06Z","updated_at":"2016-07-07T10:28:18Z","pushed_at":"2016-07-07T23:16:12Z","git_url":"git://github.com/dtan4/terraforming.git","ssh_url":"git@github.com:dtan4/terraforming.git","clone_url":"https://github.com/dtan4/terraforming.git","svn_url":"https://github.com/dtan4/terraforming","homepage":"http://terraforming.dtan4.net/","size":850,"stargazers_count":619,"watchers_count":619,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":36,"forks":95,"open_issues":36,"watchers":619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/236"},"html":{"href":"https://github.com/dtan4/terraforming/pull/236"},"issue":{"href":"https://api.github.com/repos/dtan4/terraforming/issues/236"},"comments":{"href":"https://api.github.com/repos/dtan4/terraforming/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/dtan4/terraforming/statuses/1cc15b3fa9dfe6999984614e3ca4a89e1f17eab0"}}}}
{"actor":{"display_login":"dtan4"}}