{"action":"created","comment":{"url":"https://api.github.com/repos/tangrams/tangram/pulls/comments/60083404","id":60083404,"diff_hunk":"@@ -9,13 +9,17 @@ import {buildPolylines} from '../../builders/polylines';\n import Geo from '../../geo';\n import Utils from '../../utils/utils';\n \n+let fs = require('fs');\n+let shaderSrc_polygonsVertex = fs.readFileSync(__dirname + '/../polygons/polygons_vertex.glsl', 'utf8');","path":"src/styles/lines/lines.js","position":5,"original_position":5,"commit_id":"8b6f32554793ea4df2f790afd6e11ee9c3724ce9","original_commit_id":"b579388894cbe6dcec7340df73ca7453ae1135ba","user":{"login":"dmvaldman","id":796394,"avatar_url":"https://avatars.githubusercontent.com/u/796394?v=3","gravatar_id":"","url":"https://api.github.com/users/dmvaldman","html_url":"https://github.com/dmvaldman","followers_url":"https://api.github.com/users/dmvaldman/followers","following_url":"https://api.github.com/users/dmvaldman/following{/other_user}","gists_url":"https://api.github.com/users/dmvaldman/gists{/gist_id}","starred_url":"https://api.github.com/users/dmvaldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmvaldman/subscriptions","organizations_url":"https://api.github.com/users/dmvaldman/orgs","repos_url":"https://api.github.com/users/dmvaldman/repos","events_url":"https://api.github.com/users/dmvaldman/events{/privacy}","received_events_url":"https://api.github.com/users/dmvaldman/received_events","type":"User","site_admin":false},"body":"Yeah. It's more of a bikeshedding philosophical choice, as `lines` shouldn't depend on `polygons` so it shouldn't import it.","created_at":"2016-04-18T15:51:18Z","updated_at":"2016-04-18T15:51:18Z","html_url":"https://github.com/tangrams/tangram/pull/291#discussion_r60083404","pull_request_url":"https://api.github.com/repos/tangrams/tangram/pulls/291","_links":{"self":{"href":"https://api.github.com/repos/tangrams/tangram/pulls/comments/60083404"},"html":{"href":"https://github.com/tangrams/tangram/pull/291#discussion_r60083404"},"pull_request":{"href":"https://api.github.com/repos/tangrams/tangram/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/tangrams/tangram/pulls/291","id":66227793,"html_url":"https://github.com/tangrams/tangram/pull/291","diff_url":"https://github.com/tangrams/tangram/pull/291.diff","patch_url":"https://github.com/tangrams/tangram/pull/291.patch","issue_url":"https://api.github.com/repos/tangrams/tangram/issues/291","number":291,"state":"open","locked":false,"title":"Watchify + BRFS","user":{"login":"dmvaldman","id":796394,"avatar_url":"https://avatars.githubusercontent.com/u/796394?v=3","gravatar_id":"","url":"https://api.github.com/users/dmvaldman","html_url":"https://github.com/dmvaldman","followers_url":"https://api.github.com/users/dmvaldman/followers","following_url":"https://api.github.com/users/dmvaldman/following{/other_user}","gists_url":"https://api.github.com/users/dmvaldman/gists{/gist_id}","starred_url":"https://api.github.com/users/dmvaldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmvaldman/subscriptions","organizations_url":"https://api.github.com/users/dmvaldman/orgs","repos_url":"https://api.github.com/users/dmvaldman/repos","events_url":"https://api.github.com/users/dmvaldman/events{/privacy}","received_events_url":"https://api.github.com/users/dmvaldman/received_events","type":"User","site_admin":false},"body":"Not ready to merge yet, but wanted to create a place for discussion. This current PR includes the (rebased onto master) `brfs` branch, in addition to a `watchify` workflow.\r\n\r\nI've changed `module.js` to avoid explicitly providing `Tangram` on the `window` object, favoring using browserify's standalone bundling process which creates a UMD build (which implicitly creates the window object). We can also decide whether we want `Tangram` set on the worker instances as well.\r\n\r\nTo be decided on how this should work in tandem with the makefile. As mentioned in an email, I would suggest moving away from the makefile and towards simple npm scripts, so a developer can run\r\n\r\n```\r\nnpm run dev // for bundling and watchify\r\nnpm run bundle // for bundling, minifying\r\nnpm run test // calls your Karma test suite\r\n```\r\n\r\nCurrently I've avoided this issue by putting the build in a separate script, `build_dev.js`","created_at":"2016-04-12T21:04:14Z","updated_at":"2016-04-18T15:51:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2accfe11621cf72f9df6a7aca751983f20d076ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tangrams/tangram/pulls/291/commits","review_comments_url":"https://api.github.com/repos/tangrams/tangram/pulls/291/comments","review_comment_url":"https://api.github.com/repos/tangrams/tangram/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tangrams/tangram/issues/291/comments","statuses_url":"https://api.github.com/repos/tangrams/tangram/statuses/8b6f32554793ea4df2f790afd6e11ee9c3724ce9","head":{"label":"tangrams:brfs-valdman","ref":"brfs-valdman","sha":"8b6f32554793ea4df2f790afd6e11ee9c3724ce9","user":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":13203894,"name":"tangram","full_name":"tangrams/tangram","owner":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangrams/tangram","description":"Real-Time WebGL Maps","fork":false,"url":"https://api.github.com/repos/tangrams/tangram","forks_url":"https://api.github.com/repos/tangrams/tangram/forks","keys_url":"https://api.github.com/repos/tangrams/tangram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/tangram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/tangram/teams","hooks_url":"https://api.github.com/repos/tangrams/tangram/hooks","issue_events_url":"https://api.github.com/repos/tangrams/tangram/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/tangram/events","assignees_url":"https://api.github.com/repos/tangrams/tangram/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/tangram/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/tangram/tags","blobs_url":"https://api.github.com/repos/tangrams/tangram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/tangram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/tangram/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/tangram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/tangram/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/tangram/languages","stargazers_url":"https://api.github.com/repos/tangrams/tangram/stargazers","contributors_url":"https://api.github.com/repos/tangrams/tangram/contributors","subscribers_url":"https://api.github.com/repos/tangrams/tangram/subscribers","subscription_url":"https://api.github.com/repos/tangrams/tangram/subscription","commits_url":"https://api.github.com/repos/tangrams/tangram/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/tangram/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/tangram/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/tangram/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/tangram/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/tangram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/tangram/merges","archive_url":"https://api.github.com/repos/tangrams/tangram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/tangram/downloads","issues_url":"https://api.github.com/repos/tangrams/tangram/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/tangram/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/tangram/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/tangram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/tangram/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/tangram/releases{/id}","deployments_url":"https://api.github.com/repos/tangrams/tangram/deployments","created_at":"2013-09-30T01:59:45Z","updated_at":"2016-04-16T12:35:09Z","pushed_at":"2016-04-18T15:43:18Z","git_url":"git://github.com/tangrams/tangram.git","ssh_url":"git@github.com:tangrams/tangram.git","clone_url":"https://github.com/tangrams/tangram.git","svn_url":"https://github.com/tangrams/tangram","homepage":"http://tangrams.github.io/tangram","size":118031,"stargazers_count":661,"watchers_count":661,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":23,"forks":90,"open_issues":23,"watchers":661,"default_branch":"master"}},"base":{"label":"tangrams:master","ref":"master","sha":"c48a1c4473fcd0ac3bf4192f28f550a43e751cea","user":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":13203894,"name":"tangram","full_name":"tangrams/tangram","owner":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangrams/tangram","description":"Real-Time WebGL Maps","fork":false,"url":"https://api.github.com/repos/tangrams/tangram","forks_url":"https://api.github.com/repos/tangrams/tangram/forks","keys_url":"https://api.github.com/repos/tangrams/tangram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/tangram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/tangram/teams","hooks_url":"https://api.github.com/repos/tangrams/tangram/hooks","issue_events_url":"https://api.github.com/repos/tangrams/tangram/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/tangram/events","assignees_url":"https://api.github.com/repos/tangrams/tangram/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/tangram/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/tangram/tags","blobs_url":"https://api.github.com/repos/tangrams/tangram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/tangram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/tangram/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/tangram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/tangram/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/tangram/languages","stargazers_url":"https://api.github.com/repos/tangrams/tangram/stargazers","contributors_url":"https://api.github.com/repos/tangrams/tangram/contributors","subscribers_url":"https://api.github.com/repos/tangrams/tangram/subscribers","subscription_url":"https://api.github.com/repos/tangrams/tangram/subscription","commits_url":"https://api.github.com/repos/tangrams/tangram/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/tangram/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/tangram/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/tangram/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/tangram/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/tangram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/tangram/merges","archive_url":"https://api.github.com/repos/tangrams/tangram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/tangram/downloads","issues_url":"https://api.github.com/repos/tangrams/tangram/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/tangram/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/tangram/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/tangram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/tangram/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/tangram/releases{/id}","deployments_url":"https://api.github.com/repos/tangrams/tangram/deployments","created_at":"2013-09-30T01:59:45Z","updated_at":"2016-04-16T12:35:09Z","pushed_at":"2016-04-18T15:43:18Z","git_url":"git://github.com/tangrams/tangram.git","ssh_url":"git@github.com:tangrams/tangram.git","clone_url":"https://github.com/tangrams/tangram.git","svn_url":"https://github.com/tangrams/tangram","homepage":"http://tangrams.github.io/tangram","size":118031,"stargazers_count":661,"watchers_count":661,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":23,"forks":90,"open_issues":23,"watchers":661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tangrams/tangram/pulls/291"},"html":{"href":"https://github.com/tangrams/tangram/pull/291"},"issue":{"href":"https://api.github.com/repos/tangrams/tangram/issues/291"},"comments":{"href":"https://api.github.com/repos/tangrams/tangram/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/tangrams/tangram/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/tangrams/tangram/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tangrams/tangram/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/tangrams/tangram/statuses/8b6f32554793ea4df2f790afd6e11ee9c3724ce9"}}}}