{"action":"created","comment":{"url":"https://api.github.com/repos/scipy/scipy/pulls/comments/73878241","id":73878241,"diff_hunk":"@@ -80,7 +80,7 @@ def test_cheb_odd_high_attenuation(self):\n     def test_cheb_even_high_attenuation(self):\n         with warnings.catch_warnings():\n             warnings.simplefilter(\"ignore\", UserWarning)\n-            cheb_even = signal.chebwin(54, at=-40)\n+            cheb_even = signal.chebwin(54, at=40)","path":"scipy/signal/tests/test_windows.py","position":16,"original_position":16,"commit_id":"0ae5aae246d28e732afdf2d85c0c70656281dcb9","original_commit_id":"0ae5aae246d28e732afdf2d85c0c70656281dcb9","user":{"login":"endolith","id":58611,"avatar_url":"https://avatars.githubusercontent.com/u/58611?v=3","gravatar_id":"","url":"https://api.github.com/users/endolith","html_url":"https://github.com/endolith","followers_url":"https://api.github.com/users/endolith/followers","following_url":"https://api.github.com/users/endolith/following{/other_user}","gists_url":"https://api.github.com/users/endolith/gists{/gist_id}","starred_url":"https://api.github.com/users/endolith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endolith/subscriptions","organizations_url":"https://api.github.com/users/endolith/orgs","repos_url":"https://api.github.com/users/endolith/repos","events_url":"https://api.github.com/users/endolith/events{/privacy}","received_events_url":"https://api.github.com/users/endolith/received_events","type":"User","site_admin":false},"body":"For codecov, the line calls `abs(at)` and positive values of `at` weren't being tested.","created_at":"2016-08-08T13:52:51Z","updated_at":"2016-08-08T13:52:51Z","html_url":"https://github.com/scipy/scipy/pull/6465#discussion_r73878241","pull_request_url":"https://api.github.com/repos/scipy/scipy/pulls/6465","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/73878241"},"html":{"href":"https://github.com/scipy/scipy/pull/6465#discussion_r73878241"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6465"}}},"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/6465","id":80393347,"html_url":"https://github.com/scipy/scipy/pull/6465","diff_url":"https://github.com/scipy/scipy/pull/6465.diff","patch_url":"https://github.com/scipy/scipy/pull/6465.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/6465","number":6465,"state":"open","locked":false,"title":"TST DOC Window docs, tests, etc.","user":{"login":"endolith","id":58611,"avatar_url":"https://avatars.githubusercontent.com/u/58611?v=3","gravatar_id":"","url":"https://api.github.com/users/endolith","html_url":"https://github.com/endolith","followers_url":"https://api.github.com/users/endolith/followers","following_url":"https://api.github.com/users/endolith/following{/other_user}","gists_url":"https://api.github.com/users/endolith/gists{/gist_id}","starred_url":"https://api.github.com/users/endolith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endolith/subscriptions","organizations_url":"https://api.github.com/users/endolith/orgs","repos_url":"https://api.github.com/users/endolith/repos","events_url":"https://api.github.com/users/endolith/events{/privacy}","received_events_url":"https://api.github.com/users/endolith/received_events","type":"User","site_admin":false},"body":"This should fix https://github.com/scipy/scipy/issues/4234 and improve coverage of exceptions, etc. shown by codecov.\r\n\r\nCombined several window functions into a generic sum-of-cosines function, since that's how most references describe the different functions anyway:\r\n\r\n> This kind of optimization leads to the definition of the so-called flat-top windows. If a\r\nthird order window is considered, this optimization yields the following coefficients: A<sub>0</sub> = 0.2811, A<sub>1</sub> = -0.5209, A<sub>2</sub> = 0.1980.\r\n\r\nSo now you can reproduce this window with  `_cos_win(M, [0.2811, 0.5209, 0.1980])`.","created_at":"2016-08-08T04:30:02Z","updated_at":"2016-08-08T13:52:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad7b4ddee0b11c2180964d896ffa80369de802cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/6465/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/6465/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/6465/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/0ae5aae246d28e732afdf2d85c0c70656281dcb9","head":{"label":"endolith:window_docs_tests","ref":"window_docs_tests","sha":"0ae5aae246d28e732afdf2d85c0c70656281dcb9","user":{"login":"endolith","id":58611,"avatar_url":"https://avatars.githubusercontent.com/u/58611?v=3","gravatar_id":"","url":"https://api.github.com/users/endolith","html_url":"https://github.com/endolith","followers_url":"https://api.github.com/users/endolith/followers","following_url":"https://api.github.com/users/endolith/following{/other_user}","gists_url":"https://api.github.com/users/endolith/gists{/gist_id}","starred_url":"https://api.github.com/users/endolith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endolith/subscriptions","organizations_url":"https://api.github.com/users/endolith/orgs","repos_url":"https://api.github.com/users/endolith/repos","events_url":"https://api.github.com/users/endolith/events{/privacy}","received_events_url":"https://api.github.com/users/endolith/received_events","type":"User","site_admin":false},"repo":{"id":4451843,"name":"scipy","full_name":"endolith/scipy","owner":{"login":"endolith","id":58611,"avatar_url":"https://avatars.githubusercontent.com/u/58611?v=3","gravatar_id":"","url":"https://api.github.com/users/endolith","html_url":"https://github.com/endolith","followers_url":"https://api.github.com/users/endolith/followers","following_url":"https://api.github.com/users/endolith/following{/other_user}","gists_url":"https://api.github.com/users/endolith/gists{/gist_id}","starred_url":"https://api.github.com/users/endolith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endolith/subscriptions","organizations_url":"https://api.github.com/users/endolith/orgs","repos_url":"https://api.github.com/users/endolith/repos","events_url":"https://api.github.com/users/endolith/events{/privacy}","received_events_url":"https://api.github.com/users/endolith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endolith/scipy","description":"Scipy main repository","fork":true,"url":"https://api.github.com/repos/endolith/scipy","forks_url":"https://api.github.com/repos/endolith/scipy/forks","keys_url":"https://api.github.com/repos/endolith/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endolith/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endolith/scipy/teams","hooks_url":"https://api.github.com/repos/endolith/scipy/hooks","issue_events_url":"https://api.github.com/repos/endolith/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/endolith/scipy/events","assignees_url":"https://api.github.com/repos/endolith/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/endolith/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/endolith/scipy/tags","blobs_url":"https://api.github.com/repos/endolith/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endolith/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endolith/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/endolith/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endolith/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/endolith/scipy/languages","stargazers_url":"https://api.github.com/repos/endolith/scipy/stargazers","contributors_url":"https://api.github.com/repos/endolith/scipy/contributors","subscribers_url":"https://api.github.com/repos/endolith/scipy/subscribers","subscription_url":"https://api.github.com/repos/endolith/scipy/subscription","commits_url":"https://api.github.com/repos/endolith/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/endolith/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/endolith/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/endolith/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/endolith/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/endolith/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endolith/scipy/merges","archive_url":"https://api.github.com/repos/endolith/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endolith/scipy/downloads","issues_url":"https://api.github.com/repos/endolith/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/endolith/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/endolith/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/endolith/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endolith/scipy/labels{/name}","releases_url":"https://api.github.com/repos/endolith/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/endolith/scipy/deployments","created_at":"2012-05-26T01:41:09Z","updated_at":"2015-05-01T02:16:32Z","pushed_at":"2016-08-08T11:48:53Z","git_url":"git://github.com/endolith/scipy.git","ssh_url":"git@github.com:endolith/scipy.git","clone_url":"https://github.com/endolith/scipy.git","svn_url":"https://github.com/endolith/scipy","homepage":"http://scipy.org/","size":59128,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"990a1284312b83e1ad3ea99d5263f253125879f5","user":{"login":"scipy","id":288277,"avatar_url":"https://avatars.githubusercontent.com/u/288277?v=3","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"avatar_url":"https://avatars.githubusercontent.com/u/288277?v=3","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2016-08-08T08:13:02Z","pushed_at":"2016-08-08T11:48:54Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"http://scipy.org/scipylib/","size":75816,"stargazers_count":2500,"watchers_count":2500,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1450,"mirror_url":null,"open_issues_count":939,"forks":1450,"open_issues":939,"watchers":2500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6465"},"html":{"href":"https://github.com/scipy/scipy/pull/6465"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/6465"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/6465/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6465/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6465/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/0ae5aae246d28e732afdf2d85c0c70656281dcb9"}}}}
{"actor":{"display_login":"endolith"}}