{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/90085450","pull_request_review_id":10610078,"id":90085450,"diff_hunk":"@@ -1643,6 +1650,16 @@ class BackendTkAgg(OptionalBackendPackage):\n     def check(self):\n         return \"installing; run-time loading from Python Tcl / Tk\"\n \n+    def runtime_check(self):\n+        \"\"\" Checks whether TkAgg runtime dependencies are met\n+        \"\"\"\n+        pkg_name = 'tkinter' if PY3min else 'Tkinter'\n+        try:\n+            __import__(pkg_name)","path":"setupext.py","position":34,"original_position":34,"commit_id":"603f06f90651f4333eadf09ece5adb90a86868db","original_commit_id":"603f06f90651f4333eadf09ece5adb90a86868db","user":{"login":"matthew-brett","id":67612,"avatar_url":"https://avatars.githubusercontent.com/u/67612?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-brett","html_url":"https://github.com/matthew-brett","followers_url":"https://api.github.com/users/matthew-brett/followers","following_url":"https://api.github.com/users/matthew-brett/following{/other_user}","gists_url":"https://api.github.com/users/matthew-brett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-brett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-brett/subscriptions","organizations_url":"https://api.github.com/users/matthew-brett/orgs","repos_url":"https://api.github.com/users/matthew-brett/repos","events_url":"https://api.github.com/users/matthew-brett/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-brett/received_events","type":"User","site_admin":false},"body":"`__import__` available in 2.6, I just checked.","created_at":"2016-11-29T19:12:19Z","updated_at":"2016-11-29T19:12:19Z","html_url":"https://github.com/matplotlib/matplotlib/pull/7530#discussion_r90085450","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7530","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/90085450"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/7530#discussion_r90085450"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7530"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7530","id":95751867,"html_url":"https://github.com/matplotlib/matplotlib/pull/7530","diff_url":"https://github.com/matplotlib/matplotlib/pull/7530.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/7530.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7530","number":7530,"state":"open","locked":false,"title":"[MRG+1] MAINT: TkAgg default backend depends on tkinter","user":{"login":"matthew-brett","id":67612,"avatar_url":"https://avatars.githubusercontent.com/u/67612?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-brett","html_url":"https://github.com/matthew-brett","followers_url":"https://api.github.com/users/matthew-brett/followers","following_url":"https://api.github.com/users/matthew-brett/following{/other_user}","gists_url":"https://api.github.com/users/matthew-brett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-brett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-brett/subscriptions","organizations_url":"https://api.github.com/users/matthew-brett/orgs","repos_url":"https://api.github.com/users/matthew-brett/repos","events_url":"https://api.github.com/users/matthew-brett/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-brett/received_events","type":"User","site_admin":false},"body":"We now always build the TkAgg backend, because it does not depend on the\nTk libraries being on the building system.\n\nThis had the unwanted effect of making the TkAgg backend be the default\neven if Python tkinter libraries were not installed.\n\nMake a `runtime_check` function for the optional packages, that gives\nTrue if the package can be used at run time, and use that to reject\nTkAgg as default backend when tkinter not available.","created_at":"2016-11-29T18:49:11Z","updated_at":"2016-11-29T19:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b354468307bb0681177555444eb408ac1376eff","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/20","html_url":"https://github.com/matplotlib/matplotlib/milestones/2.0.1%20(next%20bug%20fix%20release)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/20/labels","id":1306895,"number":20,"title":"2.0.1 (next bug fix release)","description":"","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":186,"closed_issues":142,"state":"open","created_at":"2015-09-15T17:47:44Z","updated_at":"2016-11-29T19:09:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7530/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7530/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7530/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/603f06f90651f4333eadf09ece5adb90a86868db","head":{"label":"matthew-brett:tkagg-depends-on-tkinter","ref":"tkagg-depends-on-tkinter","sha":"603f06f90651f4333eadf09ece5adb90a86868db","user":{"login":"matthew-brett","id":67612,"avatar_url":"https://avatars.githubusercontent.com/u/67612?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-brett","html_url":"https://github.com/matthew-brett","followers_url":"https://api.github.com/users/matthew-brett/followers","following_url":"https://api.github.com/users/matthew-brett/following{/other_user}","gists_url":"https://api.github.com/users/matthew-brett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-brett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-brett/subscriptions","organizations_url":"https://api.github.com/users/matthew-brett/orgs","repos_url":"https://api.github.com/users/matthew-brett/repos","events_url":"https://api.github.com/users/matthew-brett/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-brett/received_events","type":"User","site_admin":false},"repo":{"id":1387093,"name":"matplotlib","full_name":"matthew-brett/matplotlib","owner":{"login":"matthew-brett","id":67612,"avatar_url":"https://avatars.githubusercontent.com/u/67612?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-brett","html_url":"https://github.com/matthew-brett","followers_url":"https://api.github.com/users/matthew-brett/followers","following_url":"https://api.github.com/users/matthew-brett/following{/other_user}","gists_url":"https://api.github.com/users/matthew-brett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-brett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-brett/subscriptions","organizations_url":"https://api.github.com/users/matthew-brett/orgs","repos_url":"https://api.github.com/users/matthew-brett/repos","events_url":"https://api.github.com/users/matthew-brett/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-brett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthew-brett/matplotlib","description":null,"fork":true,"url":"https://api.github.com/repos/matthew-brett/matplotlib","forks_url":"https://api.github.com/repos/matthew-brett/matplotlib/forks","keys_url":"https://api.github.com/repos/matthew-brett/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthew-brett/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthew-brett/matplotlib/teams","hooks_url":"https://api.github.com/repos/matthew-brett/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matthew-brett/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matthew-brett/matplotlib/events","assignees_url":"https://api.github.com/repos/matthew-brett/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matthew-brett/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matthew-brett/matplotlib/tags","blobs_url":"https://api.github.com/repos/matthew-brett/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthew-brett/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthew-brett/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthew-brett/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthew-brett/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matthew-brett/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matthew-brett/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matthew-brett/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matthew-brett/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matthew-brett/matplotlib/subscription","commits_url":"https://api.github.com/repos/matthew-brett/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthew-brett/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthew-brett/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthew-brett/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthew-brett/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matthew-brett/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthew-brett/matplotlib/merges","archive_url":"https://api.github.com/repos/matthew-brett/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthew-brett/matplotlib/downloads","issues_url":"https://api.github.com/repos/matthew-brett/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matthew-brett/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matthew-brett/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matthew-brett/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthew-brett/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matthew-brett/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matthew-brett/matplotlib/deployments","created_at":"2011-02-19T19:11:53Z","updated_at":"2015-02-21T03:06:52Z","pushed_at":"2016-11-29T18:48:17Z","git_url":"git://github.com/matthew-brett/matplotlib.git","ssh_url":"git@github.com:matthew-brett/matplotlib.git","clone_url":"https://github.com/matthew-brett/matplotlib.git","svn_url":"https://github.com/matthew-brett/matplotlib","homepage":"","size":289940,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"b9c3b6400bd13f8642be105c106564357c3e6602","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2016-11-29T14:34:41Z","pushed_at":"2016-11-29T19:03:37Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":406443,"stargazers_count":4392,"watchers_count":4392,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2169,"mirror_url":null,"open_issues_count":1036,"forks":2169,"open_issues":1036,"watchers":4392,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7530"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/7530"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/7530"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/7530/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7530/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7530/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/603f06f90651f4333eadf09ece5adb90a86868db"}}}}
{"actor":{"display_login":"matthew-brett"}}