{"action":"created","comment":{"url":"https://api.github.com/repos/RestComm/sip-servlets/pulls/comments/68157668","id":68157668,"diff_hunk":"@@ -60,7 +61,7 @@\n \t * @param uri the uri used to find the corresponding SipURI\n \t * @return the SipURI found through ENUM methods or the uri itself if the uri is already a SipURI without a user=phone param\n \t */\n-\tSipURI getSipURI(URI uri);\n+\tSipURI getSipURI(URI uri, SipSession sipSession);","path":"sip-servlets-client/src/main/java/org/mobicents/javax/servlet/sip/dns/DNSResolver.java","position":13,"original_position":13,"commit_id":"80fac53a2680274d75ce7f27da19ae5f4f488f82","original_commit_id":"80fac53a2680274d75ce7f27da19ae5f4f488f82","user":{"login":"xhoaluu","id":19316067,"avatar_url":"https://avatars.githubusercontent.com/u/19316067?v=3","gravatar_id":"","url":"https://api.github.com/users/xhoaluu","html_url":"https://github.com/xhoaluu","followers_url":"https://api.github.com/users/xhoaluu/followers","following_url":"https://api.github.com/users/xhoaluu/following{/other_user}","gists_url":"https://api.github.com/users/xhoaluu/gists{/gist_id}","starred_url":"https://api.github.com/users/xhoaluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhoaluu/subscriptions","organizations_url":"https://api.github.com/users/xhoaluu/orgs","repos_url":"https://api.github.com/users/xhoaluu/repos","events_url":"https://api.github.com/users/xhoaluu/events{/privacy}","received_events_url":"https://api.github.com/users/xhoaluu/received_events","type":"User","site_admin":false},"body":"it's really Perfect @jaimecasero ","created_at":"2016-06-23T00:10:14Z","updated_at":"2016-06-23T00:10:14Z","html_url":"https://github.com/RestComm/sip-servlets/pull/163#discussion_r68157668","pull_request_url":"https://api.github.com/repos/RestComm/sip-servlets/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/RestComm/sip-servlets/pulls/comments/68157668"},"html":{"href":"https://github.com/RestComm/sip-servlets/pull/163#discussion_r68157668"},"pull_request":{"href":"https://api.github.com/repos/RestComm/sip-servlets/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/RestComm/sip-servlets/pulls/163","id":73511707,"html_url":"https://github.com/RestComm/sip-servlets/pull/163","diff_url":"https://github.com/RestComm/sip-servlets/pull/163.diff","patch_url":"https://github.com/RestComm/sip-servlets/pull/163.patch","issue_url":"https://api.github.com/repos/RestComm/sip-servlets/issues/163","number":163,"state":"open","locked":false,"title":"#110 sipServlet enhencement for quoting parameter value","user":{"login":"xhoaluu","id":19316067,"avatar_url":"https://avatars.githubusercontent.com/u/19316067?v=3","gravatar_id":"","url":"https://api.github.com/users/xhoaluu","html_url":"https://github.com/xhoaluu","followers_url":"https://api.github.com/users/xhoaluu/followers","following_url":"https://api.github.com/users/xhoaluu/following{/other_user}","gists_url":"https://api.github.com/users/xhoaluu/gists{/gist_id}","starred_url":"https://api.github.com/users/xhoaluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhoaluu/subscriptions","organizations_url":"https://api.github.com/users/xhoaluu/orgs","repos_url":"https://api.github.com/users/xhoaluu/repos","events_url":"https://api.github.com/users/xhoaluu/events{/privacy}","received_events_url":"https://api.github.com/users/xhoaluu/received_events","type":"User","site_admin":false},"body":"#110 would want to have a enhencement for automatically recognize which parameter need to be quoted its value. the parameter name need to be specified in web descriptor.","created_at":"2016-06-13T00:08:14Z","updated_at":"2016-06-23T00:10:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3d58dd7bf80f0d6573fad87ef9a4b676ddfebfd","assignee":{"login":"jaimecasero","id":7847241,"avatar_url":"https://avatars.githubusercontent.com/u/7847241?v=3","gravatar_id":"","url":"https://api.github.com/users/jaimecasero","html_url":"https://github.com/jaimecasero","followers_url":"https://api.github.com/users/jaimecasero/followers","following_url":"https://api.github.com/users/jaimecasero/following{/other_user}","gists_url":"https://api.github.com/users/jaimecasero/gists{/gist_id}","starred_url":"https://api.github.com/users/jaimecasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaimecasero/subscriptions","organizations_url":"https://api.github.com/users/jaimecasero/orgs","repos_url":"https://api.github.com/users/jaimecasero/repos","events_url":"https://api.github.com/users/jaimecasero/events{/privacy}","received_events_url":"https://api.github.com/users/jaimecasero/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/RestComm/sip-servlets/milestones/3","html_url":"https://github.com/RestComm/sip-servlets/milestones/4.1","labels_url":"https://api.github.com/repos/RestComm/sip-servlets/milestones/3/labels","id":1405014,"number":3,"title":"4.1","description":"Infinispan Support + EAP7","creator":{"login":"deruelle","id":54279,"avatar_url":"https://avatars.githubusercontent.com/u/54279?v=3","gravatar_id":"","url":"https://api.github.com/users/deruelle","html_url":"https://github.com/deruelle","followers_url":"https://api.github.com/users/deruelle/followers","following_url":"https://api.github.com/users/deruelle/following{/other_user}","gists_url":"https://api.github.com/users/deruelle/gists{/gist_id}","starred_url":"https://api.github.com/users/deruelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deruelle/subscriptions","organizations_url":"https://api.github.com/users/deruelle/orgs","repos_url":"https://api.github.com/users/deruelle/repos","events_url":"https://api.github.com/users/deruelle/events{/privacy}","received_events_url":"https://api.github.com/users/deruelle/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":0,"state":"open","created_at":"2015-11-10T17:41:03Z","updated_at":"2016-06-13T04:46:45Z","due_on":"2016-09-29T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RestComm/sip-servlets/pulls/163/commits","review_comments_url":"https://api.github.com/repos/RestComm/sip-servlets/pulls/163/comments","review_comment_url":"https://api.github.com/repos/RestComm/sip-servlets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RestComm/sip-servlets/issues/163/comments","statuses_url":"https://api.github.com/repos/RestComm/sip-servlets/statuses/80fac53a2680274d75ce7f27da19ae5f4f488f82","head":{"label":"xhoaluu:master","ref":"master","sha":"80fac53a2680274d75ce7f27da19ae5f4f488f82","user":{"login":"xhoaluu","id":19316067,"avatar_url":"https://avatars.githubusercontent.com/u/19316067?v=3","gravatar_id":"","url":"https://api.github.com/users/xhoaluu","html_url":"https://github.com/xhoaluu","followers_url":"https://api.github.com/users/xhoaluu/followers","following_url":"https://api.github.com/users/xhoaluu/following{/other_user}","gists_url":"https://api.github.com/users/xhoaluu/gists{/gist_id}","starred_url":"https://api.github.com/users/xhoaluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhoaluu/subscriptions","organizations_url":"https://api.github.com/users/xhoaluu/orgs","repos_url":"https://api.github.com/users/xhoaluu/repos","events_url":"https://api.github.com/users/xhoaluu/events{/privacy}","received_events_url":"https://api.github.com/users/xhoaluu/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"RestComm:master","ref":"master","sha":"7a3e1eac5deaf27cbf656fc6ba1b3183faa63a79","user":{"login":"RestComm","id":667380,"avatar_url":"https://avatars.githubusercontent.com/u/667380?v=3","gravatar_id":"","url":"https://api.github.com/users/RestComm","html_url":"https://github.com/RestComm","followers_url":"https://api.github.com/users/RestComm/followers","following_url":"https://api.github.com/users/RestComm/following{/other_user}","gists_url":"https://api.github.com/users/RestComm/gists{/gist_id}","starred_url":"https://api.github.com/users/RestComm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RestComm/subscriptions","organizations_url":"https://api.github.com/users/RestComm/orgs","repos_url":"https://api.github.com/users/RestComm/repos","events_url":"https://api.github.com/users/RestComm/events{/privacy}","received_events_url":"https://api.github.com/users/RestComm/received_events","type":"Organization","site_admin":false},"repo":{"id":5453022,"name":"sip-servlets","full_name":"RestComm/sip-servlets","owner":{"login":"RestComm","id":667380,"avatar_url":"https://avatars.githubusercontent.com/u/667380?v=3","gravatar_id":"","url":"https://api.github.com/users/RestComm","html_url":"https://github.com/RestComm","followers_url":"https://api.github.com/users/RestComm/followers","following_url":"https://api.github.com/users/RestComm/following{/other_user}","gists_url":"https://api.github.com/users/RestComm/gists{/gist_id}","starred_url":"https://api.github.com/users/RestComm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RestComm/subscriptions","organizations_url":"https://api.github.com/users/RestComm/orgs","repos_url":"https://api.github.com/users/RestComm/repos","events_url":"https://api.github.com/users/RestComm/events{/privacy}","received_events_url":"https://api.github.com/users/RestComm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RestComm/sip-servlets","description":"Leading SIP - IMS - WebRTC Application Server","fork":false,"url":"https://api.github.com/repos/RestComm/sip-servlets","forks_url":"https://api.github.com/repos/RestComm/sip-servlets/forks","keys_url":"https://api.github.com/repos/RestComm/sip-servlets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RestComm/sip-servlets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RestComm/sip-servlets/teams","hooks_url":"https://api.github.com/repos/RestComm/sip-servlets/hooks","issue_events_url":"https://api.github.com/repos/RestComm/sip-servlets/issues/events{/number}","events_url":"https://api.github.com/repos/RestComm/sip-servlets/events","assignees_url":"https://api.github.com/repos/RestComm/sip-servlets/assignees{/user}","branches_url":"https://api.github.com/repos/RestComm/sip-servlets/branches{/branch}","tags_url":"https://api.github.com/repos/RestComm/sip-servlets/tags","blobs_url":"https://api.github.com/repos/RestComm/sip-servlets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RestComm/sip-servlets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RestComm/sip-servlets/git/refs{/sha}","trees_url":"https://api.github.com/repos/RestComm/sip-servlets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RestComm/sip-servlets/statuses/{sha}","languages_url":"https://api.github.com/repos/RestComm/sip-servlets/languages","stargazers_url":"https://api.github.com/repos/RestComm/sip-servlets/stargazers","contributors_url":"https://api.github.com/repos/RestComm/sip-servlets/contributors","subscribers_url":"https://api.github.com/repos/RestComm/sip-servlets/subscribers","subscription_url":"https://api.github.com/repos/RestComm/sip-servlets/subscription","commits_url":"https://api.github.com/repos/RestComm/sip-servlets/commits{/sha}","git_commits_url":"https://api.github.com/repos/RestComm/sip-servlets/git/commits{/sha}","comments_url":"https://api.github.com/repos/RestComm/sip-servlets/comments{/number}","issue_comment_url":"https://api.github.com/repos/RestComm/sip-servlets/issues/comments{/number}","contents_url":"https://api.github.com/repos/RestComm/sip-servlets/contents/{+path}","compare_url":"https://api.github.com/repos/RestComm/sip-servlets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RestComm/sip-servlets/merges","archive_url":"https://api.github.com/repos/RestComm/sip-servlets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RestComm/sip-servlets/downloads","issues_url":"https://api.github.com/repos/RestComm/sip-servlets/issues{/number}","pulls_url":"https://api.github.com/repos/RestComm/sip-servlets/pulls{/number}","milestones_url":"https://api.github.com/repos/RestComm/sip-servlets/milestones{/number}","notifications_url":"https://api.github.com/repos/RestComm/sip-servlets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RestComm/sip-servlets/labels{/name}","releases_url":"https://api.github.com/repos/RestComm/sip-servlets/releases{/id}","deployments_url":"https://api.github.com/repos/RestComm/sip-servlets/deployments","created_at":"2012-08-17T14:07:17Z","updated_at":"2016-06-14T05:55:10Z","pushed_at":"2016-06-22T13:15:17Z","git_url":"git://github.com/RestComm/sip-servlets.git","ssh_url":"git@github.com:RestComm/sip-servlets.git","clone_url":"https://github.com/RestComm/sip-servlets.git","svn_url":"https://github.com/RestComm/sip-servlets","homepage":"","size":163672,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":67,"forks":69,"open_issues":67,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RestComm/sip-servlets/pulls/163"},"html":{"href":"https://github.com/RestComm/sip-servlets/pull/163"},"issue":{"href":"https://api.github.com/repos/RestComm/sip-servlets/issues/163"},"comments":{"href":"https://api.github.com/repos/RestComm/sip-servlets/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/RestComm/sip-servlets/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/RestComm/sip-servlets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RestComm/sip-servlets/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/RestComm/sip-servlets/statuses/80fac53a2680274d75ce7f27da19ae5f4f488f82"}}}}
{"actor":{"display_login":"xhoaluu"}}