{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/matsim-org/matsim/pulls/43","id":90395337,"html_url":"https://github.com/matsim-org/matsim/pull/43","diff_url":"https://github.com/matsim-org/matsim/pull/43.diff","patch_url":"https://github.com/matsim-org/matsim/pull/43.patch","issue_url":"https://api.github.com/repos/matsim-org/matsim/issues/43","number":43,"state":"closed","locked":false,"title":"Freefloating car sharing service area","user":{"login":"paschke","id":506455,"avatar_url":"https://avatars.githubusercontent.com/u/506455?v=3","gravatar_id":"","url":"https://api.github.com/users/paschke","html_url":"https://github.com/paschke","followers_url":"https://api.github.com/users/paschke/followers","following_url":"https://api.github.com/users/paschke/following{/other_user}","gists_url":"https://api.github.com/users/paschke/gists{/gist_id}","starred_url":"https://api.github.com/users/paschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paschke/subscriptions","organizations_url":"https://api.github.com/users/paschke/orgs","repos_url":"https://api.github.com/users/paschke/repos","events_url":"https://api.github.com/users/paschke/events{/privacy}","received_events_url":"https://api.github.com/users/paschke/received_events","type":"User","site_admin":false},"body":"this PR introduces freefloating service areas as discussed with F. Ciari and M. Balac on 2016-08-16. This could be achieved easier than I expected by extending the FreeFloatingVehiclesContainer much like the OneWayContainer:\n- findClosestAvailableParkingLocation was implemented. The method now checks if the destinationLink is within the company's ff service area. If it is not, the closest link that is still within the service are is determined (The JTS Topology Suite has a convenience method for that), and the agent walks to the destination.\n- a maximum walking distance was not implemented. Long egress walks will score badly and be eliminated.\n- The FreefloatingAreas object is a map of MultiPolygon objects with carsharing provider names as keys. Each freefloating area can consist of several polygons, hence the MultiPolygon\n- The FreefloatingAreas object is loaded by a separate loader extending MatsimXmlParser. It must be present in CarsharingXmlReaderNew when the CompanyContainers are created, so it must be loaded in CarsharingSupplyContainer.\n- if FreefloatingAreas are not configured or loaded, the behaviour of the CarsharingSupplyContainer and of the VehiclesContainers should not be affected.\n- the FreefloatingAreas service does not prevent the initial placement of, or agent access to, freefloating vehicles outside of the service area. This is a configuration issue the user must resolve by himself. \n","created_at":"2016-10-21T14:39:25Z","updated_at":"2016-11-11T12:38:50Z","closed_at":"2016-11-11T12:38:50Z","merged_at":"2016-11-11T12:38:50Z","merge_commit_sha":"b57001fc3f9d41fdfca26ad88ec4ab83d508c123","assignee":{"login":"balacmi","id":11626951,"avatar_url":"https://avatars.githubusercontent.com/u/11626951?v=3","gravatar_id":"","url":"https://api.github.com/users/balacmi","html_url":"https://github.com/balacmi","followers_url":"https://api.github.com/users/balacmi/followers","following_url":"https://api.github.com/users/balacmi/following{/other_user}","gists_url":"https://api.github.com/users/balacmi/gists{/gist_id}","starred_url":"https://api.github.com/users/balacmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balacmi/subscriptions","organizations_url":"https://api.github.com/users/balacmi/orgs","repos_url":"https://api.github.com/users/balacmi/repos","events_url":"https://api.github.com/users/balacmi/events{/privacy}","received_events_url":"https://api.github.com/users/balacmi/received_events","type":"User","site_admin":false},"assignees":[{"login":"balacmi","id":11626951,"avatar_url":"https://avatars.githubusercontent.com/u/11626951?v=3","gravatar_id":"","url":"https://api.github.com/users/balacmi","html_url":"https://github.com/balacmi","followers_url":"https://api.github.com/users/balacmi/followers","following_url":"https://api.github.com/users/balacmi/following{/other_user}","gists_url":"https://api.github.com/users/balacmi/gists{/gist_id}","starred_url":"https://api.github.com/users/balacmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balacmi/subscriptions","organizations_url":"https://api.github.com/users/balacmi/orgs","repos_url":"https://api.github.com/users/balacmi/repos","events_url":"https://api.github.com/users/balacmi/events{/privacy}","received_events_url":"https://api.github.com/users/balacmi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/matsim-org/matsim/pulls/43/commits","review_comments_url":"https://api.github.com/repos/matsim-org/matsim/pulls/43/comments","review_comment_url":"https://api.github.com/repos/matsim-org/matsim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matsim-org/matsim/issues/43/comments","statuses_url":"https://api.github.com/repos/matsim-org/matsim/statuses/eed988c69e9eb85f599c2cf1bd70e979654391a1","head":{"label":"paschke:freefloating-service-area","ref":"freefloating-service-area","sha":"eed988c69e9eb85f599c2cf1bd70e979654391a1","user":{"login":"paschke","id":506455,"avatar_url":"https://avatars.githubusercontent.com/u/506455?v=3","gravatar_id":"","url":"https://api.github.com/users/paschke","html_url":"https://github.com/paschke","followers_url":"https://api.github.com/users/paschke/followers","following_url":"https://api.github.com/users/paschke/following{/other_user}","gists_url":"https://api.github.com/users/paschke/gists{/gist_id}","starred_url":"https://api.github.com/users/paschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paschke/subscriptions","organizations_url":"https://api.github.com/users/paschke/orgs","repos_url":"https://api.github.com/users/paschke/repos","events_url":"https://api.github.com/users/paschke/events{/privacy}","received_events_url":"https://api.github.com/users/paschke/received_events","type":"User","site_admin":false},"repo":{"id":71339784,"name":"matsim","full_name":"paschke/matsim","owner":{"login":"paschke","id":506455,"avatar_url":"https://avatars.githubusercontent.com/u/506455?v=3","gravatar_id":"","url":"https://api.github.com/users/paschke","html_url":"https://github.com/paschke","followers_url":"https://api.github.com/users/paschke/followers","following_url":"https://api.github.com/users/paschke/following{/other_user}","gists_url":"https://api.github.com/users/paschke/gists{/gist_id}","starred_url":"https://api.github.com/users/paschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paschke/subscriptions","organizations_url":"https://api.github.com/users/paschke/orgs","repos_url":"https://api.github.com/users/paschke/repos","events_url":"https://api.github.com/users/paschke/events{/privacy}","received_events_url":"https://api.github.com/users/paschke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paschke/matsim","description":"Multi-Agent Transport Simulation","fork":true,"url":"https://api.github.com/repos/paschke/matsim","forks_url":"https://api.github.com/repos/paschke/matsim/forks","keys_url":"https://api.github.com/repos/paschke/matsim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paschke/matsim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paschke/matsim/teams","hooks_url":"https://api.github.com/repos/paschke/matsim/hooks","issue_events_url":"https://api.github.com/repos/paschke/matsim/issues/events{/number}","events_url":"https://api.github.com/repos/paschke/matsim/events","assignees_url":"https://api.github.com/repos/paschke/matsim/assignees{/user}","branches_url":"https://api.github.com/repos/paschke/matsim/branches{/branch}","tags_url":"https://api.github.com/repos/paschke/matsim/tags","blobs_url":"https://api.github.com/repos/paschke/matsim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paschke/matsim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paschke/matsim/git/refs{/sha}","trees_url":"https://api.github.com/repos/paschke/matsim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paschke/matsim/statuses/{sha}","languages_url":"https://api.github.com/repos/paschke/matsim/languages","stargazers_url":"https://api.github.com/repos/paschke/matsim/stargazers","contributors_url":"https://api.github.com/repos/paschke/matsim/contributors","subscribers_url":"https://api.github.com/repos/paschke/matsim/subscribers","subscription_url":"https://api.github.com/repos/paschke/matsim/subscription","commits_url":"https://api.github.com/repos/paschke/matsim/commits{/sha}","git_commits_url":"https://api.github.com/repos/paschke/matsim/git/commits{/sha}","comments_url":"https://api.github.com/repos/paschke/matsim/comments{/number}","issue_comment_url":"https://api.github.com/repos/paschke/matsim/issues/comments{/number}","contents_url":"https://api.github.com/repos/paschke/matsim/contents/{+path}","compare_url":"https://api.github.com/repos/paschke/matsim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paschke/matsim/merges","archive_url":"https://api.github.com/repos/paschke/matsim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paschke/matsim/downloads","issues_url":"https://api.github.com/repos/paschke/matsim/issues{/number}","pulls_url":"https://api.github.com/repos/paschke/matsim/pulls{/number}","milestones_url":"https://api.github.com/repos/paschke/matsim/milestones{/number}","notifications_url":"https://api.github.com/repos/paschke/matsim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paschke/matsim/labels{/name}","releases_url":"https://api.github.com/repos/paschke/matsim/releases{/id}","deployments_url":"https://api.github.com/repos/paschke/matsim/deployments","created_at":"2016-10-19T09:15:35Z","updated_at":"2016-10-19T09:17:03Z","pushed_at":"2016-11-11T11:26:41Z","git_url":"git://github.com/paschke/matsim.git","ssh_url":"git@github.com:paschke/matsim.git","clone_url":"https://github.com/paschke/matsim.git","svn_url":"https://github.com/paschke/matsim","homepage":"www.matsim.org","size":745862,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matsim-org:master","ref":"master","sha":"e9e2df66698841e4c411af53286235a29cf57375","user":{"login":"matsim-org","id":1541281,"avatar_url":"https://avatars.githubusercontent.com/u/1541281?v=3","gravatar_id":"","url":"https://api.github.com/users/matsim-org","html_url":"https://github.com/matsim-org","followers_url":"https://api.github.com/users/matsim-org/followers","following_url":"https://api.github.com/users/matsim-org/following{/other_user}","gists_url":"https://api.github.com/users/matsim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matsim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsim-org/subscriptions","organizations_url":"https://api.github.com/users/matsim-org/orgs","repos_url":"https://api.github.com/users/matsim-org/repos","events_url":"https://api.github.com/users/matsim-org/events{/privacy}","received_events_url":"https://api.github.com/users/matsim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":39812341,"name":"matsim","full_name":"matsim-org/matsim","owner":{"login":"matsim-org","id":1541281,"avatar_url":"https://avatars.githubusercontent.com/u/1541281?v=3","gravatar_id":"","url":"https://api.github.com/users/matsim-org","html_url":"https://github.com/matsim-org","followers_url":"https://api.github.com/users/matsim-org/followers","following_url":"https://api.github.com/users/matsim-org/following{/other_user}","gists_url":"https://api.github.com/users/matsim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matsim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsim-org/subscriptions","organizations_url":"https://api.github.com/users/matsim-org/orgs","repos_url":"https://api.github.com/users/matsim-org/repos","events_url":"https://api.github.com/users/matsim-org/events{/privacy}","received_events_url":"https://api.github.com/users/matsim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matsim-org/matsim","description":"Multi-Agent Transport Simulation","fork":false,"url":"https://api.github.com/repos/matsim-org/matsim","forks_url":"https://api.github.com/repos/matsim-org/matsim/forks","keys_url":"https://api.github.com/repos/matsim-org/matsim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matsim-org/matsim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matsim-org/matsim/teams","hooks_url":"https://api.github.com/repos/matsim-org/matsim/hooks","issue_events_url":"https://api.github.com/repos/matsim-org/matsim/issues/events{/number}","events_url":"https://api.github.com/repos/matsim-org/matsim/events","assignees_url":"https://api.github.com/repos/matsim-org/matsim/assignees{/user}","branches_url":"https://api.github.com/repos/matsim-org/matsim/branches{/branch}","tags_url":"https://api.github.com/repos/matsim-org/matsim/tags","blobs_url":"https://api.github.com/repos/matsim-org/matsim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matsim-org/matsim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matsim-org/matsim/git/refs{/sha}","trees_url":"https://api.github.com/repos/matsim-org/matsim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matsim-org/matsim/statuses/{sha}","languages_url":"https://api.github.com/repos/matsim-org/matsim/languages","stargazers_url":"https://api.github.com/repos/matsim-org/matsim/stargazers","contributors_url":"https://api.github.com/repos/matsim-org/matsim/contributors","subscribers_url":"https://api.github.com/repos/matsim-org/matsim/subscribers","subscription_url":"https://api.github.com/repos/matsim-org/matsim/subscription","commits_url":"https://api.github.com/repos/matsim-org/matsim/commits{/sha}","git_commits_url":"https://api.github.com/repos/matsim-org/matsim/git/commits{/sha}","comments_url":"https://api.github.com/repos/matsim-org/matsim/comments{/number}","issue_comment_url":"https://api.github.com/repos/matsim-org/matsim/issues/comments{/number}","contents_url":"https://api.github.com/repos/matsim-org/matsim/contents/{+path}","compare_url":"https://api.github.com/repos/matsim-org/matsim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matsim-org/matsim/merges","archive_url":"https://api.github.com/repos/matsim-org/matsim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matsim-org/matsim/downloads","issues_url":"https://api.github.com/repos/matsim-org/matsim/issues{/number}","pulls_url":"https://api.github.com/repos/matsim-org/matsim/pulls{/number}","milestones_url":"https://api.github.com/repos/matsim-org/matsim/milestones{/number}","notifications_url":"https://api.github.com/repos/matsim-org/matsim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matsim-org/matsim/labels{/name}","releases_url":"https://api.github.com/repos/matsim-org/matsim/releases{/id}","deployments_url":"https://api.github.com/repos/matsim-org/matsim/deployments","created_at":"2015-07-28T04:03:23Z","updated_at":"2016-11-04T14:15:19Z","pushed_at":"2016-11-11T12:38:50Z","git_url":"git://github.com/matsim-org/matsim.git","ssh_url":"git@github.com:matsim-org/matsim.git","clone_url":"https://github.com/matsim-org/matsim.git","svn_url":"https://github.com/matsim-org/matsim","homepage":"www.matsim.org","size":763397,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":0,"forks":61,"open_issues":0,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matsim-org/matsim/pulls/43"},"html":{"href":"https://github.com/matsim-org/matsim/pull/43"},"issue":{"href":"https://api.github.com/repos/matsim-org/matsim/issues/43"},"comments":{"href":"https://api.github.com/repos/matsim-org/matsim/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/matsim-org/matsim/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/matsim-org/matsim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matsim-org/matsim/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/matsim-org/matsim/statuses/eed988c69e9eb85f599c2cf1bd70e979654391a1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"balacmi","id":11626951,"avatar_url":"https://avatars.githubusercontent.com/u/11626951?v=3","gravatar_id":"","url":"https://api.github.com/users/balacmi","html_url":"https://github.com/balacmi","followers_url":"https://api.github.com/users/balacmi/followers","following_url":"https://api.github.com/users/balacmi/following{/other_user}","gists_url":"https://api.github.com/users/balacmi/gists{/gist_id}","starred_url":"https://api.github.com/users/balacmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balacmi/subscriptions","organizations_url":"https://api.github.com/users/balacmi/orgs","repos_url":"https://api.github.com/users/balacmi/repos","events_url":"https://api.github.com/users/balacmi/events{/privacy}","received_events_url":"https://api.github.com/users/balacmi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":23,"additions":1286,"deletions":585,"changed_files":27}}
{"actor":{"display_login":"balacmi"}}