{"action":"created","comment":{"url":"https://api.github.com/repos/pyr/cyanite/pulls/comments/52139628","id":52139628,"diff_hunk":"@@ -1,17 +1,14 @@\n (ns io.cyanite.engine\n   \"The core of cyanite\"\n-  (:require [com.stuartsierra.component :as component]\n+  (:require [io.cyanite.engine          :as engine]","path":"src/io/cyanite/engine.clj","position":4,"original_position":4,"commit_id":"a091e21f6b8a1462d956b5da3c04a7cb98766657","original_commit_id":"a091e21f6b8a1462d956b5da3c04a7cb98766657","user":{"login":"pyr","id":110280,"avatar_url":"https://avatars.githubusercontent.com/u/110280?v=3","gravatar_id":"","url":"https://api.github.com/users/pyr","html_url":"https://github.com/pyr","followers_url":"https://api.github.com/users/pyr/followers","following_url":"https://api.github.com/users/pyr/following{/other_user}","gists_url":"https://api.github.com/users/pyr/gists{/gist_id}","starred_url":"https://api.github.com/users/pyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyr/subscriptions","organizations_url":"https://api.github.com/users/pyr/orgs","repos_url":"https://api.github.com/users/pyr/repos","events_url":"https://api.github.com/users/pyr/events{/privacy}","received_events_url":"https://api.github.com/users/pyr/received_events","type":"User","site_admin":false},"body":"this is weird.","created_at":"2016-02-08T07:53:43Z","updated_at":"2016-02-08T07:53:43Z","html_url":"https://github.com/pyr/cyanite/pull/179#discussion_r52139628","pull_request_url":"https://api.github.com/repos/pyr/cyanite/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/pyr/cyanite/pulls/comments/52139628"},"html":{"href":"https://github.com/pyr/cyanite/pull/179#discussion_r52139628"},"pull_request":{"href":"https://api.github.com/repos/pyr/cyanite/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/pyr/cyanite/pulls/179","id":58487319,"html_url":"https://github.com/pyr/cyanite/pull/179","diff_url":"https://github.com/pyr/cyanite/pull/179.diff","patch_url":"https://github.com/pyr/cyanite/pull/179.patch","issue_url":"https://api.github.com/repos/pyr/cyanite/issues/179","number":179,"state":"open","locked":false,"title":"Split Engine into Ingester and Writer.","user":{"login":"ifesdjeen","id":12669,"avatar_url":"https://avatars.githubusercontent.com/u/12669?v=3","gravatar_id":"","url":"https://api.github.com/users/ifesdjeen","html_url":"https://github.com/ifesdjeen","followers_url":"https://api.github.com/users/ifesdjeen/followers","following_url":"https://api.github.com/users/ifesdjeen/following{/other_user}","gists_url":"https://api.github.com/users/ifesdjeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ifesdjeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifesdjeen/subscriptions","organizations_url":"https://api.github.com/users/ifesdjeen/orgs","repos_url":"https://api.github.com/users/ifesdjeen/repos","events_url":"https://api.github.com/users/ifesdjeen/events{/privacy}","received_events_url":"https://api.github.com/users/ifesdjeen/received_events","type":"User","site_admin":false},"body":"Motivation: they use two different queues, and \r\nboth can benefit from a bit of modularity for \r\ntesting/maintenance.\r\n\r\nI'm not absolutely sure about the naming: ingester migt be a bit too strict or specific. It might be that what is currently called ingester can be called Engine, as it was before. For that cause, for instance, the configuration files wouldn't need to be changed.","created_at":"2016-02-05T21:32:30Z","updated_at":"2016-02-08T07:53:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61973824d39621eb0df1cc85660f10e3bbb1f4f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pyr/cyanite/pulls/179/commits","review_comments_url":"https://api.github.com/repos/pyr/cyanite/pulls/179/comments","review_comment_url":"https://api.github.com/repos/pyr/cyanite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyr/cyanite/issues/179/comments","statuses_url":"https://api.github.com/repos/pyr/cyanite/statuses/a091e21f6b8a1462d956b5da3c04a7cb98766657","head":{"label":"pyr:split-engine","ref":"split-engine","sha":"a091e21f6b8a1462d956b5da3c04a7cb98766657","user":{"login":"pyr","id":110280,"avatar_url":"https://avatars.githubusercontent.com/u/110280?v=3","gravatar_id":"","url":"https://api.github.com/users/pyr","html_url":"https://github.com/pyr","followers_url":"https://api.github.com/users/pyr/followers","following_url":"https://api.github.com/users/pyr/following{/other_user}","gists_url":"https://api.github.com/users/pyr/gists{/gist_id}","starred_url":"https://api.github.com/users/pyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyr/subscriptions","organizations_url":"https://api.github.com/users/pyr/orgs","repos_url":"https://api.github.com/users/pyr/repos","events_url":"https://api.github.com/users/pyr/events{/privacy}","received_events_url":"https://api.github.com/users/pyr/received_events","type":"User","site_admin":false},"repo":{"id":15025260,"name":"cyanite","full_name":"pyr/cyanite","owner":{"login":"pyr","id":110280,"avatar_url":"https://avatars.githubusercontent.com/u/110280?v=3","gravatar_id":"","url":"https://api.github.com/users/pyr","html_url":"https://github.com/pyr","followers_url":"https://api.github.com/users/pyr/followers","following_url":"https://api.github.com/users/pyr/following{/other_user}","gists_url":"https://api.github.com/users/pyr/gists{/gist_id}","starred_url":"https://api.github.com/users/pyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyr/subscriptions","organizations_url":"https://api.github.com/users/pyr/orgs","repos_url":"https://api.github.com/users/pyr/repos","events_url":"https://api.github.com/users/pyr/events{/privacy}","received_events_url":"https://api.github.com/users/pyr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pyr/cyanite","description":"cyanite stores your metrics","fork":false,"url":"https://api.github.com/repos/pyr/cyanite","forks_url":"https://api.github.com/repos/pyr/cyanite/forks","keys_url":"https://api.github.com/repos/pyr/cyanite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyr/cyanite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyr/cyanite/teams","hooks_url":"https://api.github.com/repos/pyr/cyanite/hooks","issue_events_url":"https://api.github.com/repos/pyr/cyanite/issues/events{/number}","events_url":"https://api.github.com/repos/pyr/cyanite/events","assignees_url":"https://api.github.com/repos/pyr/cyanite/assignees{/user}","branches_url":"https://api.github.com/repos/pyr/cyanite/branches{/branch}","tags_url":"https://api.github.com/repos/pyr/cyanite/tags","blobs_url":"https://api.github.com/repos/pyr/cyanite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyr/cyanite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyr/cyanite/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyr/cyanite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyr/cyanite/statuses/{sha}","languages_url":"https://api.github.com/repos/pyr/cyanite/languages","stargazers_url":"https://api.github.com/repos/pyr/cyanite/stargazers","contributors_url":"https://api.github.com/repos/pyr/cyanite/contributors","subscribers_url":"https://api.github.com/repos/pyr/cyanite/subscribers","subscription_url":"https://api.github.com/repos/pyr/cyanite/subscription","commits_url":"https://api.github.com/repos/pyr/cyanite/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyr/cyanite/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyr/cyanite/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyr/cyanite/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyr/cyanite/contents/{+path}","compare_url":"https://api.github.com/repos/pyr/cyanite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyr/cyanite/merges","archive_url":"https://api.github.com/repos/pyr/cyanite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyr/cyanite/downloads","issues_url":"https://api.github.com/repos/pyr/cyanite/issues{/number}","pulls_url":"https://api.github.com/repos/pyr/cyanite/pulls{/number}","milestones_url":"https://api.github.com/repos/pyr/cyanite/milestones{/number}","notifications_url":"https://api.github.com/repos/pyr/cyanite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyr/cyanite/labels{/name}","releases_url":"https://api.github.com/repos/pyr/cyanite/releases{/id}","deployments_url":"https://api.github.com/repos/pyr/cyanite/deployments","created_at":"2013-12-08T14:46:19Z","updated_at":"2016-02-07T16:54:56Z","pushed_at":"2016-02-07T21:23:06Z","git_url":"git://github.com/pyr/cyanite.git","ssh_url":"git@github.com:pyr/cyanite.git","clone_url":"https://github.com/pyr/cyanite.git","svn_url":"https://github.com/pyr/cyanite","homepage":"http://cyanite.io","size":1272,"stargazers_count":368,"watchers_count":368,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":14,"forks":59,"open_issues":14,"watchers":368,"default_branch":"master"}},"base":{"label":"pyr:master","ref":"master","sha":"33653858dd9fb51a60b84b1a7ceb6d4550c41795","user":{"login":"pyr","id":110280,"avatar_url":"https://avatars.githubusercontent.com/u/110280?v=3","gravatar_id":"","url":"https://api.github.com/users/pyr","html_url":"https://github.com/pyr","followers_url":"https://api.github.com/users/pyr/followers","following_url":"https://api.github.com/users/pyr/following{/other_user}","gists_url":"https://api.github.com/users/pyr/gists{/gist_id}","starred_url":"https://api.github.com/users/pyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyr/subscriptions","organizations_url":"https://api.github.com/users/pyr/orgs","repos_url":"https://api.github.com/users/pyr/repos","events_url":"https://api.github.com/users/pyr/events{/privacy}","received_events_url":"https://api.github.com/users/pyr/received_events","type":"User","site_admin":false},"repo":{"id":15025260,"name":"cyanite","full_name":"pyr/cyanite","owner":{"login":"pyr","id":110280,"avatar_url":"https://avatars.githubusercontent.com/u/110280?v=3","gravatar_id":"","url":"https://api.github.com/users/pyr","html_url":"https://github.com/pyr","followers_url":"https://api.github.com/users/pyr/followers","following_url":"https://api.github.com/users/pyr/following{/other_user}","gists_url":"https://api.github.com/users/pyr/gists{/gist_id}","starred_url":"https://api.github.com/users/pyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyr/subscriptions","organizations_url":"https://api.github.com/users/pyr/orgs","repos_url":"https://api.github.com/users/pyr/repos","events_url":"https://api.github.com/users/pyr/events{/privacy}","received_events_url":"https://api.github.com/users/pyr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pyr/cyanite","description":"cyanite stores your metrics","fork":false,"url":"https://api.github.com/repos/pyr/cyanite","forks_url":"https://api.github.com/repos/pyr/cyanite/forks","keys_url":"https://api.github.com/repos/pyr/cyanite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyr/cyanite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyr/cyanite/teams","hooks_url":"https://api.github.com/repos/pyr/cyanite/hooks","issue_events_url":"https://api.github.com/repos/pyr/cyanite/issues/events{/number}","events_url":"https://api.github.com/repos/pyr/cyanite/events","assignees_url":"https://api.github.com/repos/pyr/cyanite/assignees{/user}","branches_url":"https://api.github.com/repos/pyr/cyanite/branches{/branch}","tags_url":"https://api.github.com/repos/pyr/cyanite/tags","blobs_url":"https://api.github.com/repos/pyr/cyanite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyr/cyanite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyr/cyanite/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyr/cyanite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyr/cyanite/statuses/{sha}","languages_url":"https://api.github.com/repos/pyr/cyanite/languages","stargazers_url":"https://api.github.com/repos/pyr/cyanite/stargazers","contributors_url":"https://api.github.com/repos/pyr/cyanite/contributors","subscribers_url":"https://api.github.com/repos/pyr/cyanite/subscribers","subscription_url":"https://api.github.com/repos/pyr/cyanite/subscription","commits_url":"https://api.github.com/repos/pyr/cyanite/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyr/cyanite/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyr/cyanite/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyr/cyanite/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyr/cyanite/contents/{+path}","compare_url":"https://api.github.com/repos/pyr/cyanite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyr/cyanite/merges","archive_url":"https://api.github.com/repos/pyr/cyanite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyr/cyanite/downloads","issues_url":"https://api.github.com/repos/pyr/cyanite/issues{/number}","pulls_url":"https://api.github.com/repos/pyr/cyanite/pulls{/number}","milestones_url":"https://api.github.com/repos/pyr/cyanite/milestones{/number}","notifications_url":"https://api.github.com/repos/pyr/cyanite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyr/cyanite/labels{/name}","releases_url":"https://api.github.com/repos/pyr/cyanite/releases{/id}","deployments_url":"https://api.github.com/repos/pyr/cyanite/deployments","created_at":"2013-12-08T14:46:19Z","updated_at":"2016-02-07T16:54:56Z","pushed_at":"2016-02-07T21:23:06Z","git_url":"git://github.com/pyr/cyanite.git","ssh_url":"git@github.com:pyr/cyanite.git","clone_url":"https://github.com/pyr/cyanite.git","svn_url":"https://github.com/pyr/cyanite","homepage":"http://cyanite.io","size":1272,"stargazers_count":368,"watchers_count":368,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":14,"forks":59,"open_issues":14,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyr/cyanite/pulls/179"},"html":{"href":"https://github.com/pyr/cyanite/pull/179"},"issue":{"href":"https://api.github.com/repos/pyr/cyanite/issues/179"},"comments":{"href":"https://api.github.com/repos/pyr/cyanite/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/pyr/cyanite/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/pyr/cyanite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyr/cyanite/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/pyr/cyanite/statuses/a091e21f6b8a1462d956b5da3c04a7cb98766657"}}}}