{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/gax-java/issues/116","repository_url":"https://api.github.com/repos/googleapis/gax-java","labels_url":"https://api.github.com/repos/googleapis/gax-java/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/gax-java/issues/116/comments","events_url":"https://api.github.com/repos/googleapis/gax-java/issues/116/events","html_url":"https://github.com/googleapis/gax-java/issues/116","id":180618195,"number":116,"title":"ServiceApiSettings.applyToAllApiMethods always overrides retryable codes","user":{"login":"mziccard","id":450933,"avatar_url":"https://avatars.githubusercontent.com/u/450933?v=3","gravatar_id":"","url":"https://api.github.com/users/mziccard","html_url":"https://github.com/mziccard","followers_url":"https://api.github.com/users/mziccard/followers","following_url":"https://api.github.com/users/mziccard/following{/other_user}","gists_url":"https://api.github.com/users/mziccard/gists{/gist_id}","starred_url":"https://api.github.com/users/mziccard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mziccard/subscriptions","organizations_url":"https://api.github.com/users/mziccard/orgs","repos_url":"https://api.github.com/users/mziccard/repos","events_url":"https://api.github.com/users/mziccard/events{/privacy}","received_events_url":"https://api.github.com/users/mziccard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-03T11:29:45Z","updated_at":"2016-10-21T14:42:35Z","closed_at":null,"body":"`ServiceApiSettings.applyToAllApiMethods(Iterable<ApiCallSettings.Builder> methodSettingsBuilders, ApiCallSettings.Builder newSettingsBuilder)` sets `newSettingsBuilder.getRetryableCodes()` and `newSettingsBuilder.getRetrySettingsBuilder()` for all API method settings in `methodSettingsBuilders`.\r\n\r\n`applyToAllApiMethods` avoids using `newSettingsBuilder.getRetryableCodes()`  if its `null`, however, there's no way to create an `ApiCallSettings.Builder` with `null` retryable codes (always initialized to empty set).\r\n\r\nThe result is that if I want to use `applyToAllApiMethods` to set common `RetrySettings` I am forced to override also retryable codes. Could you add a way to just set `RetrySettings` for all methods?\r\n\r\n/cc @shinfan @garrettjonesgoogle "},"comment":{"url":"https://api.github.com/repos/googleapis/gax-java/issues/comments/255395868","html_url":"https://github.com/googleapis/gax-java/issues/116#issuecomment-255395868","issue_url":"https://api.github.com/repos/googleapis/gax-java/issues/116","id":255395868,"user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T14:42:35Z","updated_at":"2016-10-21T14:42:35Z","body":"It's not fixed yet :-("}}
{"actor":{"display_login":"garrettjonesgoogle"}}