{"action":"created","comment":{"url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/comments/82969120","pull_request_review_id":3838430,"id":82969120,"diff_hunk":"@@ -93,9 +97,17 @@ static void incoming(uv_pipe_t* stream,\n     } else {\n         struct FileNo_pvt* fileno = Identity_check((struct FileNo_pvt*) stream->data);\n         if (fileno->peer.accepted_fd != -1) {\n+            int oldFd = fileno->peer.accepted_fd;\n+            int newFd = 123;","path":"util/events/libuv/FileNo.c","position":null,"original_position":16,"commit_id":"05d35816ed11bcf1552879c0b03ae9457cbcc848","original_commit_id":"351d8d850e5ea1e0f360ecf43357e502a6c2c39e","user":{"login":"madafoo","id":5679341,"avatar_url":"https://avatars.githubusercontent.com/u/5679341?v=3","gravatar_id":"","url":"https://api.github.com/users/madafoo","html_url":"https://github.com/madafoo","followers_url":"https://api.github.com/users/madafoo/followers","following_url":"https://api.github.com/users/madafoo/following{/other_user}","gists_url":"https://api.github.com/users/madafoo/gists{/gist_id}","starred_url":"https://api.github.com/users/madafoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madafoo/subscriptions","organizations_url":"https://api.github.com/users/madafoo/orgs","repos_url":"https://api.github.com/users/madafoo/repos","events_url":"https://api.github.com/users/madafoo/events{/privacy}","received_events_url":"https://api.github.com/users/madafoo/received_events","type":"User","site_admin":false},"body":"Maybe the dup() is also useless, dup() a file description only used for I/O redirecting or close the shared fd after fork from the parent process. The dup2() used here I can only see it is just for debugging.","created_at":"2016-10-12T09:34:51Z","updated_at":"2016-10-12T09:34:51Z","html_url":"https://github.com/cjdelisle/cjdns/pull/971#discussion_r82969120","pull_request_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/971","_links":{"self":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/comments/82969120"},"html":{"href":"https://github.com/cjdelisle/cjdns/pull/971#discussion_r82969120"},"pull_request":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/971"}}},"pull_request":{"url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/971","id":88385411,"html_url":"https://github.com/cjdelisle/cjdns/pull/971","diff_url":"https://github.com/cjdelisle/cjdns/pull/971.diff","patch_url":"https://github.com/cjdelisle/cjdns/pull/971.patch","issue_url":"https://api.github.com/repos/cjdelisle/cjdns/issues/971","number":971,"state":"open","locked":false,"title":"Build binaries for Android app","user":{"login":"benhylau","id":2261308,"avatar_url":"https://avatars.githubusercontent.com/u/2261308?v=3","gravatar_id":"","url":"https://api.github.com/users/benhylau","html_url":"https://github.com/benhylau","followers_url":"https://api.github.com/users/benhylau/followers","following_url":"https://api.github.com/users/benhylau/following{/other_user}","gists_url":"https://api.github.com/users/benhylau/gists{/gist_id}","starred_url":"https://api.github.com/users/benhylau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhylau/subscriptions","organizations_url":"https://api.github.com/users/benhylau/orgs","repos_url":"https://api.github.com/users/benhylau/repos","events_url":"https://api.github.com/users/benhylau/events{/privacy}","received_events_url":"https://api.github.com/users/benhylau/received_events","type":"User","site_admin":false},"body":"Running **android_do** generates all the binaries for the Android APK:\r\n\r\n        /build_android/out/armeabi-v7a/cjdroute-init\r\n        /build_android/out/armeabi-v7a/cjdroute\r\n        /build_android/out/arm64-v8a/cjdroute-init\r\n        /build_android/out/arm64-v8a/cjdroute\r\n        /build_android/out/x86/cjdroute-init\r\n        /build_android/out/x86/cjdroute","created_at":"2016-10-07T06:08:48Z","updated_at":"2016-10-12T09:34:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ae243e2357772ad1c328310a467c8d7a2da8b64","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/971/commits","review_comments_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/971/comments","review_comment_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cjdelisle/cjdns/issues/971/comments","statuses_url":"https://api.github.com/repos/cjdelisle/cjdns/statuses/05d35816ed11bcf1552879c0b03ae9457cbcc848","head":{"label":"benhylau:android","ref":"android","sha":"05d35816ed11bcf1552879c0b03ae9457cbcc848","user":{"login":"benhylau","id":2261308,"avatar_url":"https://avatars.githubusercontent.com/u/2261308?v=3","gravatar_id":"","url":"https://api.github.com/users/benhylau","html_url":"https://github.com/benhylau","followers_url":"https://api.github.com/users/benhylau/followers","following_url":"https://api.github.com/users/benhylau/following{/other_user}","gists_url":"https://api.github.com/users/benhylau/gists{/gist_id}","starred_url":"https://api.github.com/users/benhylau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhylau/subscriptions","organizations_url":"https://api.github.com/users/benhylau/orgs","repos_url":"https://api.github.com/users/benhylau/repos","events_url":"https://api.github.com/users/benhylau/events{/privacy}","received_events_url":"https://api.github.com/users/benhylau/received_events","type":"User","site_admin":false},"repo":{"id":70030335,"name":"cjdns","full_name":"benhylau/cjdns","owner":{"login":"benhylau","id":2261308,"avatar_url":"https://avatars.githubusercontent.com/u/2261308?v=3","gravatar_id":"","url":"https://api.github.com/users/benhylau","html_url":"https://github.com/benhylau","followers_url":"https://api.github.com/users/benhylau/followers","following_url":"https://api.github.com/users/benhylau/following{/other_user}","gists_url":"https://api.github.com/users/benhylau/gists{/gist_id}","starred_url":"https://api.github.com/users/benhylau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhylau/subscriptions","organizations_url":"https://api.github.com/users/benhylau/orgs","repos_url":"https://api.github.com/users/benhylau/repos","events_url":"https://api.github.com/users/benhylau/events{/privacy}","received_events_url":"https://api.github.com/users/benhylau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benhylau/cjdns","description":null,"fork":true,"url":"https://api.github.com/repos/benhylau/cjdns","forks_url":"https://api.github.com/repos/benhylau/cjdns/forks","keys_url":"https://api.github.com/repos/benhylau/cjdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benhylau/cjdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benhylau/cjdns/teams","hooks_url":"https://api.github.com/repos/benhylau/cjdns/hooks","issue_events_url":"https://api.github.com/repos/benhylau/cjdns/issues/events{/number}","events_url":"https://api.github.com/repos/benhylau/cjdns/events","assignees_url":"https://api.github.com/repos/benhylau/cjdns/assignees{/user}","branches_url":"https://api.github.com/repos/benhylau/cjdns/branches{/branch}","tags_url":"https://api.github.com/repos/benhylau/cjdns/tags","blobs_url":"https://api.github.com/repos/benhylau/cjdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benhylau/cjdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benhylau/cjdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/benhylau/cjdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benhylau/cjdns/statuses/{sha}","languages_url":"https://api.github.com/repos/benhylau/cjdns/languages","stargazers_url":"https://api.github.com/repos/benhylau/cjdns/stargazers","contributors_url":"https://api.github.com/repos/benhylau/cjdns/contributors","subscribers_url":"https://api.github.com/repos/benhylau/cjdns/subscribers","subscription_url":"https://api.github.com/repos/benhylau/cjdns/subscription","commits_url":"https://api.github.com/repos/benhylau/cjdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/benhylau/cjdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/benhylau/cjdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/benhylau/cjdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/benhylau/cjdns/contents/{+path}","compare_url":"https://api.github.com/repos/benhylau/cjdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benhylau/cjdns/merges","archive_url":"https://api.github.com/repos/benhylau/cjdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benhylau/cjdns/downloads","issues_url":"https://api.github.com/repos/benhylau/cjdns/issues{/number}","pulls_url":"https://api.github.com/repos/benhylau/cjdns/pulls{/number}","milestones_url":"https://api.github.com/repos/benhylau/cjdns/milestones{/number}","notifications_url":"https://api.github.com/repos/benhylau/cjdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benhylau/cjdns/labels{/name}","releases_url":"https://api.github.com/repos/benhylau/cjdns/releases{/id}","deployments_url":"https://api.github.com/repos/benhylau/cjdns/deployments","created_at":"2016-10-05T04:37:38Z","updated_at":"2016-10-05T04:37:47Z","pushed_at":"2016-10-12T05:47:34Z","git_url":"git://github.com/benhylau/cjdns.git","ssh_url":"git@github.com:benhylau/cjdns.git","clone_url":"https://github.com/benhylau/cjdns.git","svn_url":"https://github.com/benhylau/cjdns","homepage":"","size":21587,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cjdelisle:crashey","ref":"crashey","sha":"b4c740e49e5f42d4c9e42cf5d301f38ecccf1fac","user":{"login":"cjdelisle","id":509047,"avatar_url":"https://avatars.githubusercontent.com/u/509047?v=3","gravatar_id":"","url":"https://api.github.com/users/cjdelisle","html_url":"https://github.com/cjdelisle","followers_url":"https://api.github.com/users/cjdelisle/followers","following_url":"https://api.github.com/users/cjdelisle/following{/other_user}","gists_url":"https://api.github.com/users/cjdelisle/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdelisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdelisle/subscriptions","organizations_url":"https://api.github.com/users/cjdelisle/orgs","repos_url":"https://api.github.com/users/cjdelisle/repos","events_url":"https://api.github.com/users/cjdelisle/events{/privacy}","received_events_url":"https://api.github.com/users/cjdelisle/received_events","type":"User","site_admin":false},"repo":{"id":1376101,"name":"cjdns","full_name":"cjdelisle/cjdns","owner":{"login":"cjdelisle","id":509047,"avatar_url":"https://avatars.githubusercontent.com/u/509047?v=3","gravatar_id":"","url":"https://api.github.com/users/cjdelisle","html_url":"https://github.com/cjdelisle","followers_url":"https://api.github.com/users/cjdelisle/followers","following_url":"https://api.github.com/users/cjdelisle/following{/other_user}","gists_url":"https://api.github.com/users/cjdelisle/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdelisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdelisle/subscriptions","organizations_url":"https://api.github.com/users/cjdelisle/orgs","repos_url":"https://api.github.com/users/cjdelisle/repos","events_url":"https://api.github.com/users/cjdelisle/events{/privacy}","received_events_url":"https://api.github.com/users/cjdelisle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjdelisle/cjdns","description":"","fork":false,"url":"https://api.github.com/repos/cjdelisle/cjdns","forks_url":"https://api.github.com/repos/cjdelisle/cjdns/forks","keys_url":"https://api.github.com/repos/cjdelisle/cjdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjdelisle/cjdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjdelisle/cjdns/teams","hooks_url":"https://api.github.com/repos/cjdelisle/cjdns/hooks","issue_events_url":"https://api.github.com/repos/cjdelisle/cjdns/issues/events{/number}","events_url":"https://api.github.com/repos/cjdelisle/cjdns/events","assignees_url":"https://api.github.com/repos/cjdelisle/cjdns/assignees{/user}","branches_url":"https://api.github.com/repos/cjdelisle/cjdns/branches{/branch}","tags_url":"https://api.github.com/repos/cjdelisle/cjdns/tags","blobs_url":"https://api.github.com/repos/cjdelisle/cjdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjdelisle/cjdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjdelisle/cjdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjdelisle/cjdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjdelisle/cjdns/statuses/{sha}","languages_url":"https://api.github.com/repos/cjdelisle/cjdns/languages","stargazers_url":"https://api.github.com/repos/cjdelisle/cjdns/stargazers","contributors_url":"https://api.github.com/repos/cjdelisle/cjdns/contributors","subscribers_url":"https://api.github.com/repos/cjdelisle/cjdns/subscribers","subscription_url":"https://api.github.com/repos/cjdelisle/cjdns/subscription","commits_url":"https://api.github.com/repos/cjdelisle/cjdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjdelisle/cjdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjdelisle/cjdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjdelisle/cjdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjdelisle/cjdns/contents/{+path}","compare_url":"https://api.github.com/repos/cjdelisle/cjdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjdelisle/cjdns/merges","archive_url":"https://api.github.com/repos/cjdelisle/cjdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjdelisle/cjdns/downloads","issues_url":"https://api.github.com/repos/cjdelisle/cjdns/issues{/number}","pulls_url":"https://api.github.com/repos/cjdelisle/cjdns/pulls{/number}","milestones_url":"https://api.github.com/repos/cjdelisle/cjdns/milestones{/number}","notifications_url":"https://api.github.com/repos/cjdelisle/cjdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjdelisle/cjdns/labels{/name}","releases_url":"https://api.github.com/repos/cjdelisle/cjdns/releases{/id}","deployments_url":"https://api.github.com/repos/cjdelisle/cjdns/deployments","created_at":"2011-02-16T23:03:45Z","updated_at":"2016-10-11T19:09:29Z","pushed_at":"2016-10-12T04:06:04Z","git_url":"git://github.com/cjdelisle/cjdns.git","ssh_url":"git@github.com:cjdelisle/cjdns.git","clone_url":"https://github.com/cjdelisle/cjdns.git","svn_url":"https://github.com/cjdelisle/cjdns","homepage":"","size":24350,"stargazers_count":2587,"watchers_count":2587,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":404,"mirror_url":null,"open_issues_count":106,"forks":404,"open_issues":106,"watchers":2587,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/971"},"html":{"href":"https://github.com/cjdelisle/cjdns/pull/971"},"issue":{"href":"https://api.github.com/repos/cjdelisle/cjdns/issues/971"},"comments":{"href":"https://api.github.com/repos/cjdelisle/cjdns/issues/971/comments"},"review_comments":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/971/comments"},"review_comment":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cjdelisle/cjdns/pulls/971/commits"},"statuses":{"href":"https://api.github.com/repos/cjdelisle/cjdns/statuses/05d35816ed11bcf1552879c0b03ae9457cbcc848"}}}}
{"actor":{"display_login":"madafoo"}}