{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments/89005037","pull_request_review_id":9558894,"id":89005037,"diff_hunk":"@@ -1,3 +1,3 @@\n {\n-    \"projects\": [\"src\"]","path":"global.json","position":2,"original_position":2,"commit_id":"24c044dd7c553c8b0df1737abb8d1fd1eee08b8c","original_commit_id":"24c044dd7c553c8b0df1737abb8d1fd1eee08b8c","user":{"login":"halter73","id":54385,"avatar_url":"https://avatars.githubusercontent.com/u/54385?v=3","gravatar_id":"","url":"https://api.github.com/users/halter73","html_url":"https://github.com/halter73","followers_url":"https://api.github.com/users/halter73/followers","following_url":"https://api.github.com/users/halter73/following{/other_user}","gists_url":"https://api.github.com/users/halter73/gists{/gist_id}","starred_url":"https://api.github.com/users/halter73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halter73/subscriptions","organizations_url":"https://api.github.com/users/halter73/orgs","repos_url":"https://api.github.com/users/halter73/repos","events_url":"https://api.github.com/users/halter73/events{/privacy}","received_events_url":"https://api.github.com/users/halter73/received_events","type":"User","site_admin":false},"body":"Nit: no need for whitespace changes in otherwise unedited files.","created_at":"2016-11-21T22:36:43Z","updated_at":"2016-11-21T22:36:43Z","html_url":"https://github.com/aspnet/KestrelHttpServer/pull/1138#discussion_r89005037","pull_request_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1138","_links":{"self":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments/89005037"},"html":{"href":"https://github.com/aspnet/KestrelHttpServer/pull/1138#discussion_r89005037"},"pull_request":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1138"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1138","id":87671135,"html_url":"https://github.com/aspnet/KestrelHttpServer/pull/1138","diff_url":"https://github.com/aspnet/KestrelHttpServer/pull/1138.diff","patch_url":"https://github.com/aspnet/KestrelHttpServer/pull/1138.patch","issue_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/1138","number":1138,"state":"open","locked":false,"title":"SuperCharged MemoryPoolIterator","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"Is a branchless cache-oblivious evaluation of the set byte; rather than the current multiple ternary operator quasi tree. Around x 2.8 faster than current for Seek operations.\r\n\r\nThe De Bruijn alternative improvement that was evaluated needs a table lookup of 8 \\* 8 \\* bytes = 512 bytes in the data cache to be fast - which is 8 cache lines on x64. (It can be compressed to 24 bytes with some extra per lookup ops).\r\n\r\nWhereas this uses a single 64bit const already in the instruction cache (which the De Bruijn also needs).\r\n\r\nAlso trims FindFirstEqualByte from 318 bytes of asm to 94 bytes of asm (before the final inline) so better for inlining which avoids the vector copy (Added inline due to issue dotnet/coreclr#7386)\r\n\r\nResolves https://github.com/aspnet/KestrelHttpServer/issues/1129\r\nResolves  #1141\r\nResolves https://github.com/aspnet/KestrelHttpServer/issues/1213","created_at":"2016-10-03T07:05:34Z","updated_at":"2016-11-21T22:36:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a5323a07165aebe3c717eb16a98ddf21c4532bf","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/milestones/20","html_url":"https://github.com/aspnet/KestrelHttpServer/milestones/1.2.0","labels_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/milestones/20/labels","id":2025164,"number":20,"title":"1.2.0","description":null,"creator":{"login":"muratg","id":1808428,"avatar_url":"https://avatars.githubusercontent.com/u/1808428?v=3","gravatar_id":"","url":"https://api.github.com/users/muratg","html_url":"https://github.com/muratg","followers_url":"https://api.github.com/users/muratg/followers","following_url":"https://api.github.com/users/muratg/following{/other_user}","gists_url":"https://api.github.com/users/muratg/gists{/gist_id}","starred_url":"https://api.github.com/users/muratg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratg/subscriptions","organizations_url":"https://api.github.com/users/muratg/orgs","repos_url":"https://api.github.com/users/muratg/repos","events_url":"https://api.github.com/users/muratg/events{/privacy}","received_events_url":"https://api.github.com/users/muratg/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":0,"state":"open","created_at":"2016-09-23T19:39:27Z","updated_at":"2016-11-04T23:10:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1138/commits","review_comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1138/comments","review_comment_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/1138/comments","statuses_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/24c044dd7c553c8b0df1737abb8d1fd1eee08b8c","head":{"label":"benaadams:bens-magic-number","ref":"bens-magic-number","sha":"24c044dd7c553c8b0df1737abb8d1fd1eee08b8c","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"repo":{"id":38999457,"name":"KestrelHttpServer","full_name":"benaadams/KestrelHttpServer","owner":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benaadams/KestrelHttpServer","description":"A development web server for ASP.NET vNext based on libuv.","fork":true,"url":"https://api.github.com/repos/benaadams/KestrelHttpServer","forks_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/forks","keys_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/teams","hooks_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/hooks","issue_events_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/issues/events{/number}","events_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/events","assignees_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/assignees{/user}","branches_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/branches{/branch}","tags_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/tags","blobs_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/statuses/{sha}","languages_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/languages","stargazers_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/stargazers","contributors_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/contributors","subscribers_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/subscribers","subscription_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/subscription","commits_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/contents/{+path}","compare_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/merges","archive_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/downloads","issues_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/issues{/number}","pulls_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/pulls{/number}","milestones_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/milestones{/number}","notifications_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/labels{/name}","releases_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/releases{/id}","deployments_url":"https://api.github.com/repos/benaadams/KestrelHttpServer/deployments","created_at":"2015-07-13T08:10:06Z","updated_at":"2016-05-10T10:57:21Z","pushed_at":"2016-11-21T22:18:28Z","git_url":"git://github.com/benaadams/KestrelHttpServer.git","ssh_url":"git@github.com:benaadams/KestrelHttpServer.git","clone_url":"https://github.com/benaadams/KestrelHttpServer.git","svn_url":"https://github.com/benaadams/KestrelHttpServer","homepage":"","size":3452,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"7bd027cb6b8e13a4533651636f23076a8575755e","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":20344662,"name":"KestrelHttpServer","full_name":"aspnet/KestrelHttpServer","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/KestrelHttpServer","description":"A web server for ASP.NET Core based on libuv.","fork":false,"url":"https://api.github.com/repos/aspnet/KestrelHttpServer","forks_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/forks","keys_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/teams","hooks_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/hooks","issue_events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/events","assignees_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/tags","blobs_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/languages","stargazers_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/stargazers","contributors_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/contributors","subscribers_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/subscribers","subscription_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/subscription","commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/merges","archive_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/downloads","issues_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/deployments","created_at":"2014-05-30T22:46:28Z","updated_at":"2016-11-21T07:10:21Z","pushed_at":"2016-11-21T22:18:30Z","git_url":"git://github.com/aspnet/KestrelHttpServer.git","ssh_url":"git@github.com:aspnet/KestrelHttpServer.git","clone_url":"https://github.com/aspnet/KestrelHttpServer.git","svn_url":"https://github.com/aspnet/KestrelHttpServer","homepage":"","size":7730,"stargazers_count":1226,"watchers_count":1226,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":68,"forks":262,"open_issues":68,"watchers":1226,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1138"},"html":{"href":"https://github.com/aspnet/KestrelHttpServer/pull/1138"},"issue":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/1138"},"comments":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/1138/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1138/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/1138/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/24c044dd7c553c8b0df1737abb8d1fd1eee08b8c"}}}}
{"actor":{"display_login":"halter73"}}