{"push_id":1206628276,"size":4,"distinct_size":4,"ref":"refs/heads/master","head":"b79c633e2258e03f82c6ab9da09cb1d614c620b2","before":"f22007390dce5ab2e11d97f2e496b0deea9ccae2","commits":[{"sha":"623c65c720e301c85e0dd9f9d637577cce2e0965","author":{"name":"Ben Alex","email":"ba268bd599585ece44711f034d547f3544294125@acegi.com.au"},"message":"Use external ByteUnit\n\nA few reasons for this:\n\n1. We cannot reassign the copyright automatically. While we could exclude\nthis compliation unit from copyright header handling, it's safer to simply\nnot include IP we didn't create or receive via an intentional, explicit\ncontribution (eg a pull request).\n\n2. There were no tests for ByteUnit, whereas upstream there are proper\ntests. This therefore required a coverage exclusion.\n\n3. Fixes and improvements made upstream to ByteUnit will be noticed via\nnew versions appearing in Maven Central and being detected via VersionEye or\nthe new Maven-based versions-maven-plugin. We therefore won't need to\nmerge into our source tree any fixes/improvements made upstream.\n\n4. I have removed the ByteUnit reference from Env. As such ByteUnit\nis effectively optional, but I've left it in place as a standard POM\ndependency given it's likely to be useful and the JAR is only 23 KB. If\nusers object in the future we can always make it an optional dependency\nwithout any further code changes.\n\n5. There are other units now present in ByteUnit, such as decimal, bit\nand binary units. Upstream also has other goodies like human-friendly\nstring rendering. An end user application is likely to find value in\nthese types for other purposes beyond LMDB. If users don't find value,\nthey can exclude the dependency entirely and LmdbJava will still work.\n\n6. If we prefer to ByteUnit shipped with LmdbJava, we can use the\nexisting Shade plugin to achieve most of the maintenance benefits\nabove. We don't need to maintain its compilation unit(s) in our repo.","distinct":true,"url":"https://api.github.com/repos/lmdbjava/lmdbjava/commits/623c65c720e301c85e0dd9f9d637577cce2e0965"},{"sha":"13b29ac0d3870bb8bc6af18419f73ef556e6e31f","author":{"name":"Ben Alex","email":"ba268bd599585ece44711f034d547f3544294125@acegi.com.au"},"message":"Move Coveralls Maven Plugin to Travis profile","distinct":true,"url":"https://api.github.com/repos/lmdbjava/lmdbjava/commits/13b29ac0d3870bb8bc6af18419f73ef556e6e31f"},{"sha":"621e8e25a96d55df59f257cf341ffe5542ee96e1","author":{"name":"Ben Alex","email":"ba268bd599585ece44711f034d547f3544294125@acegi.com.au"},"message":"Test LmdbException root cause retention","distinct":true,"url":"https://api.github.com/repos/lmdbjava/lmdbjava/commits/621e8e25a96d55df59f257cf341ffe5542ee96e1"},{"sha":"b79c633e2258e03f82c6ab9da09cb1d614c620b2","author":{"name":"Ben Alex","email":"ba268bd599585ece44711f034d547f3544294125@acegi.com.au"},"message":"Miscellaneous POM changes","distinct":true,"url":"https://api.github.com/repos/lmdbjava/lmdbjava/commits/b79c633e2258e03f82c6ab9da09cb1d614c620b2"}]}
{"actor":{"display_login":"benalexau"}}