{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-http/pulls/comments/60075322","id":60075322,"diff_hunk":"@@ -197,7 +197,7 @@ function httpServiceFactory(\n         });\n \n         // Parse request body. Limit set to 1MB\n-        app.use(bodyParser.json({limit: '1mb'}));\n+        app.use(bodyParser.json({limit: '2mb'}));","path":"lib/services/http-service.js","position":null,"original_position":5,"commit_id":"8600654727b44fa966c5c2944c5337317a813104","original_commit_id":"9a51b80bffb61c197cfcae0d0c2089bd98f2e278","user":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-04-18T15:07:15Z","updated_at":"2016-04-18T15:07:15Z","html_url":"https://github.com/RackHD/on-http/pull/233#discussion_r60075322","pull_request_url":"https://api.github.com/repos/RackHD/on-http/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/comments/60075322"},"html":{"href":"https://github.com/RackHD/on-http/pull/233#discussion_r60075322"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-http/pulls/233","id":66840376,"html_url":"https://github.com/RackHD/on-http/pull/233","diff_url":"https://github.com/RackHD/on-http/pull/233.diff","patch_url":"https://github.com/RackHD/on-http/pull/233.patch","issue_url":"https://api.github.com/repos/RackHD/on-http/issues/233","number":233,"state":"open","locked":false,"title":"Change body parser to allow post files upto 2MB","user":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"body":"Partial fix of ODR-620 about failure to update BIOS FW. In flash-quanta-bios-graph.js, after finishing FW update, the task POST the result (similar as stdout, >1M) to RackHD. In previous code, on-http refused this request, while the task is waiting for the response from nodes and never ends.\r\n\r\nIn current skupack implementation, there is no this problem since the output didn't return to RackHD. It is a fix for OnRack 1.2.0 who doesn't apply skupack and keeps using  flash-quanta-bios-graph.js\r\n\r\nRemoving the return value in on-tasks/ is also another solution, but enlarging the data size here can provide more flexibility for future usage.","created_at":"2016-04-18T11:51:59Z","updated_at":"2016-04-18T15:07:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bf461e3e5065bcaf4f279d738056d3b6aeb11f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-http/pulls/233/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-http/pulls/233/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-http/issues/233/comments","statuses_url":"https://api.github.com/repos/RackHD/on-http/statuses/8600654727b44fa966c5c2944c5337317a813104","head":{"label":"iceiilin:post-size","ref":"post-size","sha":"8600654727b44fa966c5c2944c5337317a813104","user":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"repo":{"id":45585896,"name":"on-http","full_name":"iceiilin/on-http","owner":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iceiilin/on-http","description":"","fork":true,"url":"https://api.github.com/repos/iceiilin/on-http","forks_url":"https://api.github.com/repos/iceiilin/on-http/forks","keys_url":"https://api.github.com/repos/iceiilin/on-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iceiilin/on-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iceiilin/on-http/teams","hooks_url":"https://api.github.com/repos/iceiilin/on-http/hooks","issue_events_url":"https://api.github.com/repos/iceiilin/on-http/issues/events{/number}","events_url":"https://api.github.com/repos/iceiilin/on-http/events","assignees_url":"https://api.github.com/repos/iceiilin/on-http/assignees{/user}","branches_url":"https://api.github.com/repos/iceiilin/on-http/branches{/branch}","tags_url":"https://api.github.com/repos/iceiilin/on-http/tags","blobs_url":"https://api.github.com/repos/iceiilin/on-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iceiilin/on-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iceiilin/on-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/iceiilin/on-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iceiilin/on-http/statuses/{sha}","languages_url":"https://api.github.com/repos/iceiilin/on-http/languages","stargazers_url":"https://api.github.com/repos/iceiilin/on-http/stargazers","contributors_url":"https://api.github.com/repos/iceiilin/on-http/contributors","subscribers_url":"https://api.github.com/repos/iceiilin/on-http/subscribers","subscription_url":"https://api.github.com/repos/iceiilin/on-http/subscription","commits_url":"https://api.github.com/repos/iceiilin/on-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/iceiilin/on-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/iceiilin/on-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/iceiilin/on-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/iceiilin/on-http/contents/{+path}","compare_url":"https://api.github.com/repos/iceiilin/on-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iceiilin/on-http/merges","archive_url":"https://api.github.com/repos/iceiilin/on-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iceiilin/on-http/downloads","issues_url":"https://api.github.com/repos/iceiilin/on-http/issues{/number}","pulls_url":"https://api.github.com/repos/iceiilin/on-http/pulls{/number}","milestones_url":"https://api.github.com/repos/iceiilin/on-http/milestones{/number}","notifications_url":"https://api.github.com/repos/iceiilin/on-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iceiilin/on-http/labels{/name}","releases_url":"https://api.github.com/repos/iceiilin/on-http/releases{/id}","deployments_url":"https://api.github.com/repos/iceiilin/on-http/deployments","created_at":"2015-11-05T03:47:26Z","updated_at":"2016-01-23T15:00:51Z","pushed_at":"2016-04-18T15:07:01Z","git_url":"git://github.com/iceiilin/on-http.git","ssh_url":"git@github.com:iceiilin/on-http.git","clone_url":"https://github.com/iceiilin/on-http.git","svn_url":"https://github.com/iceiilin/on-http","homepage":null,"size":2358,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"37b3c056b7204e873737cedb16144e3239485145","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690081,"name":"on-http","full_name":"RackHD/on-http","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-http","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-http","forks_url":"https://api.github.com/repos/RackHD/on-http/forks","keys_url":"https://api.github.com/repos/RackHD/on-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-http/teams","hooks_url":"https://api.github.com/repos/RackHD/on-http/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-http/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-http/events","assignees_url":"https://api.github.com/repos/RackHD/on-http/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-http/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-http/tags","blobs_url":"https://api.github.com/repos/RackHD/on-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-http/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-http/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-http/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-http/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-http/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-http/subscription","commits_url":"https://api.github.com/repos/RackHD/on-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-http/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-http/merges","archive_url":"https://api.github.com/repos/RackHD/on-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-http/downloads","issues_url":"https://api.github.com/repos/RackHD/on-http/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-http/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-http/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-http/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-http/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-http/deployments","created_at":"2015-08-31T17:29:08Z","updated_at":"2016-04-13T20:03:51Z","pushed_at":"2016-04-18T15:07:01Z","git_url":"git://github.com/RackHD/on-http.git","ssh_url":"git@github.com:RackHD/on-http.git","clone_url":"https://github.com/RackHD/on-http.git","svn_url":"https://github.com/RackHD/on-http","homepage":null,"size":2796,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":11,"forks":41,"open_issues":11,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/233"},"html":{"href":"https://github.com/RackHD/on-http/pull/233"},"issue":{"href":"https://api.github.com/repos/RackHD/on-http/issues/233"},"comments":{"href":"https://api.github.com/repos/RackHD/on-http/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-http/statuses/8600654727b44fa966c5c2944c5337317a813104"}}}}