{"action":"closed","number":926,"pull_request":{"url":"https://api.github.com/repos/IBM-Swift/Kitura/pulls/926","id":97342660,"html_url":"https://github.com/IBM-Swift/Kitura/pull/926","diff_url":"https://github.com/IBM-Swift/Kitura/pull/926.diff","patch_url":"https://github.com/IBM-Swift/Kitura/pull/926.patch","issue_url":"https://api.github.com/repos/IBM-Swift/Kitura/issues/926","number":926,"state":"closed","locked":false,"title":"Break request/response retain cycle. Intended to help #879","user":{"login":"carlbrown","id":67206,"avatar_url":"https://avatars.githubusercontent.com/u/67206?v=3","gravatar_id":"","url":"https://api.github.com/users/carlbrown","html_url":"https://github.com/carlbrown","followers_url":"https://api.github.com/users/carlbrown/followers","following_url":"https://api.github.com/users/carlbrown/following{/other_user}","gists_url":"https://api.github.com/users/carlbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/carlbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlbrown/subscriptions","organizations_url":"https://api.github.com/users/carlbrown/orgs","repos_url":"https://api.github.com/users/carlbrown/repos","events_url":"https://api.github.com/users/carlbrown/events{/privacy}","received_events_url":"https://api.github.com/users/carlbrown/received_events","type":"User","site_admin":false},"body":"Break strong retain cycles in the process() method\r\n\r\n## Description\r\nCode should be pretty self explanatory.\r\nGraph changes below generated with this fix and https://github.com/IBM-Swift/Kitura-Compression/pull/26 and https://github.com/IBM-Swift/Kitura-Session/pull/29\r\n\r\n## Motivation and Context\r\nSee leak graph posted in #879 \r\n\r\n## How Has This Been Tested?\r\nTest suite still passes.  In running on instruments, I get fewer leaks in \"Cycles and Roots\".\r\n\r\nBefore: \r\n![screen shot 2016-12-09 at 10 51 21 am](https://cloud.githubusercontent.com/assets/67206/21057003/79bf560e-bdfd-11e6-9c3c-8ac804543413.png)\r\n\r\nAfter:\r\n![screen shot 2016-12-09 at 10 51 06 am](https://cloud.githubusercontent.com/assets/67206/21057009/7f0a6db0-bdfd-11e6-9f71-1401ca891fc9.png)\r\n","created_at":"2016-12-09T16:54:34Z","updated_at":"2016-12-11T08:57:53Z","closed_at":"2016-12-11T08:57:53Z","merged_at":"2016-12-11T08:57:53Z","merge_commit_sha":"b92664290550f7015775131d29bbf6262921994a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IBM-Swift/Kitura/pulls/926/commits","review_comments_url":"https://api.github.com/repos/IBM-Swift/Kitura/pulls/926/comments","review_comment_url":"https://api.github.com/repos/IBM-Swift/Kitura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IBM-Swift/Kitura/issues/926/comments","statuses_url":"https://api.github.com/repos/IBM-Swift/Kitura/statuses/37333f8c76a5cb4247788413afc9e9e69d998553","head":{"label":"carlbrown:handleCycleBreaker","ref":"handleCycleBreaker","sha":"37333f8c76a5cb4247788413afc9e9e69d998553","user":{"login":"carlbrown","id":67206,"avatar_url":"https://avatars.githubusercontent.com/u/67206?v=3","gravatar_id":"","url":"https://api.github.com/users/carlbrown","html_url":"https://github.com/carlbrown","followers_url":"https://api.github.com/users/carlbrown/followers","following_url":"https://api.github.com/users/carlbrown/following{/other_user}","gists_url":"https://api.github.com/users/carlbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/carlbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlbrown/subscriptions","organizations_url":"https://api.github.com/users/carlbrown/orgs","repos_url":"https://api.github.com/users/carlbrown/repos","events_url":"https://api.github.com/users/carlbrown/events{/privacy}","received_events_url":"https://api.github.com/users/carlbrown/received_events","type":"User","site_admin":false},"repo":{"id":75015988,"name":"Kitura","full_name":"carlbrown/Kitura","owner":{"login":"carlbrown","id":67206,"avatar_url":"https://avatars.githubusercontent.com/u/67206?v=3","gravatar_id":"","url":"https://api.github.com/users/carlbrown","html_url":"https://github.com/carlbrown","followers_url":"https://api.github.com/users/carlbrown/followers","following_url":"https://api.github.com/users/carlbrown/following{/other_user}","gists_url":"https://api.github.com/users/carlbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/carlbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlbrown/subscriptions","organizations_url":"https://api.github.com/users/carlbrown/orgs","repos_url":"https://api.github.com/users/carlbrown/repos","events_url":"https://api.github.com/users/carlbrown/events{/privacy}","received_events_url":"https://api.github.com/users/carlbrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlbrown/Kitura","description":"A Swift web framework and HTTP server.","fork":true,"url":"https://api.github.com/repos/carlbrown/Kitura","forks_url":"https://api.github.com/repos/carlbrown/Kitura/forks","keys_url":"https://api.github.com/repos/carlbrown/Kitura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlbrown/Kitura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlbrown/Kitura/teams","hooks_url":"https://api.github.com/repos/carlbrown/Kitura/hooks","issue_events_url":"https://api.github.com/repos/carlbrown/Kitura/issues/events{/number}","events_url":"https://api.github.com/repos/carlbrown/Kitura/events","assignees_url":"https://api.github.com/repos/carlbrown/Kitura/assignees{/user}","branches_url":"https://api.github.com/repos/carlbrown/Kitura/branches{/branch}","tags_url":"https://api.github.com/repos/carlbrown/Kitura/tags","blobs_url":"https://api.github.com/repos/carlbrown/Kitura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlbrown/Kitura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlbrown/Kitura/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlbrown/Kitura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlbrown/Kitura/statuses/{sha}","languages_url":"https://api.github.com/repos/carlbrown/Kitura/languages","stargazers_url":"https://api.github.com/repos/carlbrown/Kitura/stargazers","contributors_url":"https://api.github.com/repos/carlbrown/Kitura/contributors","subscribers_url":"https://api.github.com/repos/carlbrown/Kitura/subscribers","subscription_url":"https://api.github.com/repos/carlbrown/Kitura/subscription","commits_url":"https://api.github.com/repos/carlbrown/Kitura/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlbrown/Kitura/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlbrown/Kitura/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlbrown/Kitura/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlbrown/Kitura/contents/{+path}","compare_url":"https://api.github.com/repos/carlbrown/Kitura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlbrown/Kitura/merges","archive_url":"https://api.github.com/repos/carlbrown/Kitura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlbrown/Kitura/downloads","issues_url":"https://api.github.com/repos/carlbrown/Kitura/issues{/number}","pulls_url":"https://api.github.com/repos/carlbrown/Kitura/pulls{/number}","milestones_url":"https://api.github.com/repos/carlbrown/Kitura/milestones{/number}","notifications_url":"https://api.github.com/repos/carlbrown/Kitura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlbrown/Kitura/labels{/name}","releases_url":"https://api.github.com/repos/carlbrown/Kitura/releases{/id}","deployments_url":"https://api.github.com/repos/carlbrown/Kitura/deployments","created_at":"2016-11-28T21:30:27Z","updated_at":"2016-11-28T21:30:30Z","pushed_at":"2016-12-09T17:13:20Z","git_url":"git://github.com/carlbrown/Kitura.git","ssh_url":"git@github.com:carlbrown/Kitura.git","clone_url":"https://github.com/carlbrown/Kitura.git","svn_url":"https://github.com/carlbrown/Kitura","homepage":"http://www.kitura.io","size":2515,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IBM-Swift:master","ref":"master","sha":"d5992f06a323366ab8277c5809562d2f994227fd","user":{"login":"IBM-Swift","id":16882981,"avatar_url":"https://avatars.githubusercontent.com/u/16882981?v=3","gravatar_id":"","url":"https://api.github.com/users/IBM-Swift","html_url":"https://github.com/IBM-Swift","followers_url":"https://api.github.com/users/IBM-Swift/followers","following_url":"https://api.github.com/users/IBM-Swift/following{/other_user}","gists_url":"https://api.github.com/users/IBM-Swift/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM-Swift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM-Swift/subscriptions","organizations_url":"https://api.github.com/users/IBM-Swift/orgs","repos_url":"https://api.github.com/users/IBM-Swift/repos","events_url":"https://api.github.com/users/IBM-Swift/events{/privacy}","received_events_url":"https://api.github.com/users/IBM-Swift/received_events","type":"Organization","site_admin":false},"repo":{"id":51308720,"name":"Kitura","full_name":"IBM-Swift/Kitura","owner":{"login":"IBM-Swift","id":16882981,"avatar_url":"https://avatars.githubusercontent.com/u/16882981?v=3","gravatar_id":"","url":"https://api.github.com/users/IBM-Swift","html_url":"https://github.com/IBM-Swift","followers_url":"https://api.github.com/users/IBM-Swift/followers","following_url":"https://api.github.com/users/IBM-Swift/following{/other_user}","gists_url":"https://api.github.com/users/IBM-Swift/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM-Swift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM-Swift/subscriptions","organizations_url":"https://api.github.com/users/IBM-Swift/orgs","repos_url":"https://api.github.com/users/IBM-Swift/repos","events_url":"https://api.github.com/users/IBM-Swift/events{/privacy}","received_events_url":"https://api.github.com/users/IBM-Swift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IBM-Swift/Kitura","description":"A Swift web framework and HTTP server.","fork":false,"url":"https://api.github.com/repos/IBM-Swift/Kitura","forks_url":"https://api.github.com/repos/IBM-Swift/Kitura/forks","keys_url":"https://api.github.com/repos/IBM-Swift/Kitura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBM-Swift/Kitura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBM-Swift/Kitura/teams","hooks_url":"https://api.github.com/repos/IBM-Swift/Kitura/hooks","issue_events_url":"https://api.github.com/repos/IBM-Swift/Kitura/issues/events{/number}","events_url":"https://api.github.com/repos/IBM-Swift/Kitura/events","assignees_url":"https://api.github.com/repos/IBM-Swift/Kitura/assignees{/user}","branches_url":"https://api.github.com/repos/IBM-Swift/Kitura/branches{/branch}","tags_url":"https://api.github.com/repos/IBM-Swift/Kitura/tags","blobs_url":"https://api.github.com/repos/IBM-Swift/Kitura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBM-Swift/Kitura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBM-Swift/Kitura/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBM-Swift/Kitura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBM-Swift/Kitura/statuses/{sha}","languages_url":"https://api.github.com/repos/IBM-Swift/Kitura/languages","stargazers_url":"https://api.github.com/repos/IBM-Swift/Kitura/stargazers","contributors_url":"https://api.github.com/repos/IBM-Swift/Kitura/contributors","subscribers_url":"https://api.github.com/repos/IBM-Swift/Kitura/subscribers","subscription_url":"https://api.github.com/repos/IBM-Swift/Kitura/subscription","commits_url":"https://api.github.com/repos/IBM-Swift/Kitura/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBM-Swift/Kitura/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBM-Swift/Kitura/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBM-Swift/Kitura/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBM-Swift/Kitura/contents/{+path}","compare_url":"https://api.github.com/repos/IBM-Swift/Kitura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBM-Swift/Kitura/merges","archive_url":"https://api.github.com/repos/IBM-Swift/Kitura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBM-Swift/Kitura/downloads","issues_url":"https://api.github.com/repos/IBM-Swift/Kitura/issues{/number}","pulls_url":"https://api.github.com/repos/IBM-Swift/Kitura/pulls{/number}","milestones_url":"https://api.github.com/repos/IBM-Swift/Kitura/milestones{/number}","notifications_url":"https://api.github.com/repos/IBM-Swift/Kitura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBM-Swift/Kitura/labels{/name}","releases_url":"https://api.github.com/repos/IBM-Swift/Kitura/releases{/id}","deployments_url":"https://api.github.com/repos/IBM-Swift/Kitura/deployments","created_at":"2016-02-08T16:12:21Z","updated_at":"2016-12-10T23:49:08Z","pushed_at":"2016-12-11T08:57:53Z","git_url":"git://github.com/IBM-Swift/Kitura.git","ssh_url":"git@github.com:IBM-Swift/Kitura.git","clone_url":"https://github.com/IBM-Swift/Kitura.git","svn_url":"https://github.com/IBM-Swift/Kitura","homepage":"http://www.kitura.io","size":3550,"stargazers_count":4993,"watchers_count":4993,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":310,"mirror_url":null,"open_issues_count":75,"forks":310,"open_issues":75,"watchers":4993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IBM-Swift/Kitura/pulls/926"},"html":{"href":"https://github.com/IBM-Swift/Kitura/pull/926"},"issue":{"href":"https://api.github.com/repos/IBM-Swift/Kitura/issues/926"},"comments":{"href":"https://api.github.com/repos/IBM-Swift/Kitura/issues/926/comments"},"review_comments":{"href":"https://api.github.com/repos/IBM-Swift/Kitura/pulls/926/comments"},"review_comment":{"href":"https://api.github.com/repos/IBM-Swift/Kitura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IBM-Swift/Kitura/pulls/926/commits"},"statuses":{"href":"https://api.github.com/repos/IBM-Swift/Kitura/statuses/37333f8c76a5cb4247788413afc9e9e69d998553"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"shmuelk","id":16103068,"avatar_url":"https://avatars.githubusercontent.com/u/16103068?v=3","gravatar_id":"","url":"https://api.github.com/users/shmuelk","html_url":"https://github.com/shmuelk","followers_url":"https://api.github.com/users/shmuelk/followers","following_url":"https://api.github.com/users/shmuelk/following{/other_user}","gists_url":"https://api.github.com/users/shmuelk/gists{/gist_id}","starred_url":"https://api.github.com/users/shmuelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmuelk/subscriptions","organizations_url":"https://api.github.com/users/shmuelk/orgs","repos_url":"https://api.github.com/users/shmuelk/repos","events_url":"https://api.github.com/users/shmuelk/events{/privacy}","received_events_url":"https://api.github.com/users/shmuelk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":2,"additions":14,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"shmuelk"}}