{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/71768998","id":71768998,"diff_hunk":"@@ -41,8 +41,12 @@ class ConsulConfig {\n       agentPort = 8500 // Default used by consul\n     }\n \n-    if (!servers) {\n-      throw new IllegalArgumentException(\"Consul servers must be provided.\")\n+    if (!agentEndpoint) {\n+      agentEndpoint = 'localhost'\n+    }\n+\n+    if (agentEndpoint.indexOf(\":\") == -1) {","path":"clouddriver-consul/src/main/groovy/com/netflix/spinnaker/clouddriver/consul/config/ConsulConfig.groovy","position":26,"original_position":26,"commit_id":"2f4072facf03422bafee64aefb71619acde193d8","original_commit_id":"2f4072facf03422bafee64aefb71619acde193d8","user":{"login":"duftler","id":8437718,"avatar_url":"https://avatars.githubusercontent.com/u/8437718?v=3","gravatar_id":"","url":"https://api.github.com/users/duftler","html_url":"https://github.com/duftler","followers_url":"https://api.github.com/users/duftler/followers","following_url":"https://api.github.com/users/duftler/following{/other_user}","gists_url":"https://api.github.com/users/duftler/gists{/gist_id}","starred_url":"https://api.github.com/users/duftler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duftler/subscriptions","organizations_url":"https://api.github.com/users/duftler/orgs","repos_url":"https://api.github.com/users/duftler/repos","events_url":"https://api.github.com/users/duftler/events{/privacy}","received_events_url":"https://api.github.com/users/duftler/received_events","type":"User","site_admin":false},"body":"`if (!agentEndpoint.contains(\":\"))`","created_at":"2016-07-21T19:15:26Z","updated_at":"2016-07-21T19:15:26Z","html_url":"https://github.com/spinnaker/clouddriver/pull/797#discussion_r71768998","pull_request_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/797","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/71768998"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/797#discussion_r71768998"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/797"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/797","id":78371034,"html_url":"https://github.com/spinnaker/clouddriver/pull/797","diff_url":"https://github.com/spinnaker/clouddriver/pull/797.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/797.patch","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/797","number":797,"state":"open","locked":false,"title":"provider/consul: Migrate to using on-host consul agent","user":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-21T19:12:48Z","updated_at":"2016-07-21T19:15:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89cd94b29c9aa7b0047a01d8de9fa256b27cc30b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/797/commits","review_comments_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/797/comments","review_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/797/comments","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/2f4072facf03422bafee64aefb71619acde193d8","head":{"label":"lwander:consul-on-host","ref":"consul-on-host","sha":"2f4072facf03422bafee64aefb71619acde193d8","user":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"repo":{"id":47214651,"name":"clouddriver","full_name":"lwander/clouddriver","owner":{"login":"lwander","id":4874941,"avatar_url":"https://avatars.githubusercontent.com/u/4874941?v=3","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lwander/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/lwander/clouddriver","forks_url":"https://api.github.com/repos/lwander/clouddriver/forks","keys_url":"https://api.github.com/repos/lwander/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lwander/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lwander/clouddriver/teams","hooks_url":"https://api.github.com/repos/lwander/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/lwander/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/lwander/clouddriver/events","assignees_url":"https://api.github.com/repos/lwander/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/lwander/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/lwander/clouddriver/tags","blobs_url":"https://api.github.com/repos/lwander/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lwander/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lwander/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/lwander/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lwander/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/lwander/clouddriver/languages","stargazers_url":"https://api.github.com/repos/lwander/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/lwander/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/lwander/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/lwander/clouddriver/subscription","commits_url":"https://api.github.com/repos/lwander/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/lwander/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/lwander/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/lwander/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/lwander/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/lwander/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lwander/clouddriver/merges","archive_url":"https://api.github.com/repos/lwander/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lwander/clouddriver/downloads","issues_url":"https://api.github.com/repos/lwander/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/lwander/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/lwander/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/lwander/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lwander/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/lwander/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/lwander/clouddriver/deployments","created_at":"2015-12-01T20:13:06Z","updated_at":"2016-01-19T21:43:58Z","pushed_at":"2016-07-21T19:12:28Z","git_url":"git://github.com/lwander/clouddriver.git","ssh_url":"git@github.com:lwander/clouddriver.git","clone_url":"https://github.com/lwander/clouddriver.git","svn_url":"https://github.com/lwander/clouddriver","homepage":null,"size":27299,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"4c939e5b412719e849d6791f801c9f375f676788","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":37556951,"name":"clouddriver","full_name":"spinnaker/clouddriver","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/clouddriver","description":"read and write operations across cloud providers","fork":false,"url":"https://api.github.com/repos/spinnaker/clouddriver","forks_url":"https://api.github.com/repos/spinnaker/clouddriver/forks","keys_url":"https://api.github.com/repos/spinnaker/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/clouddriver/teams","hooks_url":"https://api.github.com/repos/spinnaker/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/clouddriver/events","assignees_url":"https://api.github.com/repos/spinnaker/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/clouddriver/tags","blobs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/clouddriver/languages","stargazers_url":"https://api.github.com/repos/spinnaker/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/clouddriver/subscription","commits_url":"https://api.github.com/repos/spinnaker/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/clouddriver/merges","archive_url":"https://api.github.com/repos/spinnaker/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/clouddriver/downloads","issues_url":"https://api.github.com/repos/spinnaker/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/clouddriver/deployments","created_at":"2015-06-16T21:26:02Z","updated_at":"2016-07-21T09:49:02Z","pushed_at":"2016-07-21T19:12:48Z","git_url":"git://github.com/spinnaker/clouddriver.git","ssh_url":"git@github.com:spinnaker/clouddriver.git","clone_url":"https://github.com/spinnaker/clouddriver.git","svn_url":"https://github.com/spinnaker/clouddriver","homepage":null,"size":29688,"stargazers_count":58,"watchers_count":58,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":9,"forks":85,"open_issues":9,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/797"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/797"},"issue":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/797"},"comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/797/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/797/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/797/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/clouddriver/statuses/2f4072facf03422bafee64aefb71619acde193d8"}}}}
{"actor":{"display_login":"duftler"}}