{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/14389","repository_url":"https://api.github.com/repos/laravel/framework","labels_url":"https://api.github.com/repos/laravel/framework/issues/14389/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/14389/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/14389/events","html_url":"https://github.com/laravel/framework/pull/14389","id":166552177,"number":14389,"title":"[5.2] Fix pagination issue in the latest release","user":{"login":"themsaid","id":4332182,"avatar_url":"https://avatars.githubusercontent.com/u/4332182?v=3","gravatar_id":"","url":"https://api.github.com/users/themsaid","html_url":"https://github.com/themsaid","followers_url":"https://api.github.com/users/themsaid/followers","following_url":"https://api.github.com/users/themsaid/following{/other_user}","gists_url":"https://api.github.com/users/themsaid/gists{/gist_id}","starred_url":"https://api.github.com/users/themsaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themsaid/subscriptions","organizations_url":"https://api.github.com/users/themsaid/orgs","repos_url":"https://api.github.com/users/themsaid/repos","events_url":"https://api.github.com/users/themsaid/events{/privacy}","received_events_url":"https://api.github.com/users/themsaid/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-20T10:44:57Z","updated_at":"2016-07-22T20:49:52Z","closed_at":"2016-07-20T13:06:19Z","pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/14389","html_url":"https://github.com/laravel/framework/pull/14389","diff_url":"https://github.com/laravel/framework/pull/14389.diff","patch_url":"https://github.com/laravel/framework/pull/14389.patch"},"body":"Addressed in https://github.com/laravel/framework/issues/14387\r\n\r\nThe issue was caused by this change: https://github.com/laravel/framework/pull/14188/files\r\n\r\nif `$total` is evaluated as `false`, `$perPage = $perPage ?: $this->model->getPerPage()` will never be executed leaving `$perPage` equal to null if it wasn't provided in the method call.\r\n\r\nSo calling `->paginate()` without any arguments, if no results found `$perPage` will be equal to null causing a Division By Zero error in LengthAwarePaginator"},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/234652759","html_url":"https://github.com/laravel/framework/pull/14389#issuecomment-234652759","issue_url":"https://api.github.com/repos/laravel/framework/issues/14389","id":234652759,"user":{"login":"mnabialek","id":7656807,"avatar_url":"https://avatars.githubusercontent.com/u/7656807?v=3","gravatar_id":"","url":"https://api.github.com/users/mnabialek","html_url":"https://github.com/mnabialek","followers_url":"https://api.github.com/users/mnabialek/followers","following_url":"https://api.github.com/users/mnabialek/following{/other_user}","gists_url":"https://api.github.com/users/mnabialek/gists{/gist_id}","starred_url":"https://api.github.com/users/mnabialek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnabialek/subscriptions","organizations_url":"https://api.github.com/users/mnabialek/orgs","repos_url":"https://api.github.com/users/mnabialek/repos","events_url":"https://api.github.com/users/mnabialek/events{/privacy}","received_events_url":"https://api.github.com/users/mnabialek/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T20:49:52Z","updated_at":"2016-07-22T20:49:52Z","body":"@themsaid Thank you for quick fix for my PR :)"}}
{"actor":{"display_login":"mnabialek"}}