{"action":"created","issue":{"url":"https://api.github.com/repos/lsegal/yard/issues/1028","repository_url":"https://api.github.com/repos/lsegal/yard","labels_url":"https://api.github.com/repos/lsegal/yard/issues/1028/labels{/name}","comments_url":"https://api.github.com/repos/lsegal/yard/issues/1028/comments","events_url":"https://api.github.com/repos/lsegal/yard/issues/1028/events","html_url":"https://github.com/lsegal/yard/pull/1028","id":182818217,"number":1028,"title":"Replaced \"backport\" of `Gem.source_index` / `Gem::SourceIndex` with `Gem::Specification`","user":{"login":"benlangfeld","id":210221,"avatar_url":"https://avatars.githubusercontent.com/u/210221?v=3","gravatar_id":"","url":"https://api.github.com/users/benlangfeld","html_url":"https://github.com/benlangfeld","followers_url":"https://api.github.com/users/benlangfeld/followers","following_url":"https://api.github.com/users/benlangfeld/following{/other_user}","gists_url":"https://api.github.com/users/benlangfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/benlangfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlangfeld/subscriptions","organizations_url":"https://api.github.com/users/benlangfeld/orgs","repos_url":"https://api.github.com/users/benlangfeld/repos","events_url":"https://api.github.com/users/benlangfeld/events{/privacy}","received_events_url":"https://api.github.com/users/benlangfeld/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-10-13T15:13:52Z","updated_at":"2016-10-15T00:58:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lsegal/yard/pulls/1028","html_url":"https://github.com/lsegal/yard/pull/1028","diff_url":"https://github.com/lsegal/yard/pull/1028.diff","patch_url":"https://github.com/lsegal/yard/pull/1028.patch"},"body":"# Description\r\n\r\nBecause the former doesn't correctly load gems installed via `:path` or `:git` options in a Gemfile, meaning serving documentation for such gems via `yard server -G` throws silent errors (and spins infinitely in the UI).\r\n\r\nThe \"backport\" was introduced in https://github.com/lsegal/yard/commit/75e5aea51f149694269118ccd3ef6db09e7efc76 because RubyGems 1.8 removed SourceIndex and replaced it with Gem::Specification, but @lsegal didn't want to require YARD users to upgrade to Rubygems > 1.8. That was 5 years ago, and we should be able to move on now.\r\n\r\n# Completed Tasks\r\n\r\n* [x] I have read the [Contributing Guide][contrib].\r\n* [x] The pull request is complete (implemented / written).\r\n* [x] Git commits have been cleaned up (squash WIP / revert commits).\r\n* [x] I wrote tests and ran `bundle exec rake` locally (if code is attached to PR).\r\n\r\n[contrib]: https://github.com/lsegal/yard/blob/master/CONTRIBUTING.md"},"comment":{"url":"https://api.github.com/repos/lsegal/yard/issues/comments/253952081","html_url":"https://github.com/lsegal/yard/pull/1028#issuecomment-253952081","issue_url":"https://api.github.com/repos/lsegal/yard/issues/1028","id":253952081,"user":{"login":"benlangfeld","id":210221,"avatar_url":"https://avatars.githubusercontent.com/u/210221?v=3","gravatar_id":"","url":"https://api.github.com/users/benlangfeld","html_url":"https://github.com/benlangfeld","followers_url":"https://api.github.com/users/benlangfeld/followers","following_url":"https://api.github.com/users/benlangfeld/following{/other_user}","gists_url":"https://api.github.com/users/benlangfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/benlangfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlangfeld/subscriptions","organizations_url":"https://api.github.com/users/benlangfeld/orgs","repos_url":"https://api.github.com/users/benlangfeld/repos","events_url":"https://api.github.com/users/benlangfeld/events{/privacy}","received_events_url":"https://api.github.com/users/benlangfeld/received_events","type":"User","site_admin":false},"created_at":"2016-10-15T00:58:39Z","updated_at":"2016-10-15T00:58:39Z","body":"Took a wild guess; hope that's what you were after :)"}}
{"actor":{"display_login":"benlangfeld"}}