{"action":"created","issue":{"url":"https://api.github.com/repos/jlmakes/scrollreveal.js/issues/271","repository_url":"https://api.github.com/repos/jlmakes/scrollreveal.js","labels_url":"https://api.github.com/repos/jlmakes/scrollreveal.js/issues/271/labels{/name}","comments_url":"https://api.github.com/repos/jlmakes/scrollreveal.js/issues/271/comments","events_url":"https://api.github.com/repos/jlmakes/scrollreveal.js/issues/271/events","html_url":"https://github.com/jlmakes/scrollreveal.js/issues/271","id":164756188,"number":271,"title":"FYI:  Reason for why it never shows.","user":{"login":"ensemblebd","id":13471536,"avatar_url":"https://avatars.githubusercontent.com/u/13471536?v=3","gravatar_id":"","url":"https://api.github.com/users/ensemblebd","html_url":"https://github.com/ensemblebd","followers_url":"https://api.github.com/users/ensemblebd/followers","following_url":"https://api.github.com/users/ensemblebd/following{/other_user}","gists_url":"https://api.github.com/users/ensemblebd/gists{/gist_id}","starred_url":"https://api.github.com/users/ensemblebd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ensemblebd/subscriptions","organizations_url":"https://api.github.com/users/ensemblebd/orgs","repos_url":"https://api.github.com/users/ensemblebd/repos","events_url":"https://api.github.com/users/ensemblebd/events{/privacy}","received_events_url":"https://api.github.com/users/ensemblebd/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jlmakes/scrollreveal.js/labels/Improvement%20/%20Fix","name":"Improvement / Fix","color":"6aa208"},{"url":"https://api.github.com/repos/jlmakes/scrollreveal.js/labels/Unconfirmed","name":"Unconfirmed","color":"f9d0c4"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-11T03:59:49Z","updated_at":"2016-07-13T18:32:35Z","closed_at":"2016-07-13T18:32:35Z","body":"This is in reference to: https://github.com/jlmakes/scrollreveal.js/issues/125\r\nExact same issue, but completely different reason.\r\n\r\nPrimary cause is when the container element uses % height. Fluid layouts (basically any responsive framework now days), have a standard setup with `html, body {height: 100%}`\r\nTherefore the height of the document is the height of the screen (aka body has height of 800, but content goes well over 3000). \r\nTherefore **_isElemVisible** ALWAYS returns false for anything below the viewable region of the screen.\r\nWhich leads to an opacity always being zero.\r\n\r\nI stepped through it with the debugger, and determined that with interval not specified, the function to reveal or reset is never called.\r\nIf interval is specified, it instantly performs it's callback, causing and instantaneous reveal and reset, so fast the animation doesn't even take place - aka invisible.\r\n\r\nSo the correct thing to do in this scenario, is specify a container that actually has a size, via clearfix or what have you. That way the logic isn't broken in this script. The default value of document, or choosing body, isn't necessarily safe whatsoever.\r\n\r\nWhile I believe this is something you should fix as an improvement, I realize the easier solution would be to add some documentation on that front. Thanks for your consideration on this issue, as well as all your efforts on this great project\r\n\r\n\r\nSee Also:\r\n\r\n1. http://stackoverflow.com/questions/12788487/document-scrolltop-always-returns-0\r\n2. http://stackoverflow.com/questions/1830080/jquery-scrolltop-doesnt-seem-to-work-in-safari-or-chrome-windows"},"comment":{"url":"https://api.github.com/repos/jlmakes/scrollreveal.js/issues/comments/232446029","html_url":"https://github.com/jlmakes/scrollreveal.js/issues/271#issuecomment-232446029","issue_url":"https://api.github.com/repos/jlmakes/scrollreveal.js/issues/271","id":232446029,"user":{"login":"jlmakes","id":2044842,"avatar_url":"https://avatars.githubusercontent.com/u/2044842?v=3","gravatar_id":"","url":"https://api.github.com/users/jlmakes","html_url":"https://github.com/jlmakes","followers_url":"https://api.github.com/users/jlmakes/followers","following_url":"https://api.github.com/users/jlmakes/following{/other_user}","gists_url":"https://api.github.com/users/jlmakes/gists{/gist_id}","starred_url":"https://api.github.com/users/jlmakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlmakes/subscriptions","organizations_url":"https://api.github.com/users/jlmakes/orgs","repos_url":"https://api.github.com/users/jlmakes/repos","events_url":"https://api.github.com/users/jlmakes/events{/privacy}","received_events_url":"https://api.github.com/users/jlmakes/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T18:32:35Z","updated_at":"2016-07-13T18:32:35Z","body":"Cheers mate, thanks for all your effort. 👍🏾"}}
{"actor":{"display_login":"jlmakes"}}