{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/57745927","id":57745927,"diff_hunk":"@@ -5,8 +5,23 @@\n #include \"CommonCommonPch.h\"\n #include \"Common/Int64Math.h\"\n \n-#if defined(_M_X64) && defined(_MSC_VER)\n-#pragma intrinsic(_mul128)\n+#if defined(_M_X64)\n+#if defined(_MSC_VER)\n+    #pragma intrinsic(_mul128)\n+#else\n+    static int64 _mul128(const int64 left, const int64 right, int64 *high) noexcept\n+    {\n+        int64 low;\n+        __asm__\n+        (\n+            \"imulq %[right]\\n\"\n+            : \"=d\"(*high), \"=a\"(low)\n+            : [right]\"rm\"(right), \"1\"(left)","path":"lib/Common/Common/Int64Math.cpp","position":17,"original_position":17,"commit_id":"87ae5f56a9fda66624ec983f8414e1844208e3c0","original_commit_id":"87ae5f56a9fda66624ec983f8414e1844208e3c0","user":{"login":"curtisman","id":12101885,"avatar_url":"https://avatars.githubusercontent.com/u/12101885?v=3","gravatar_id":"","url":"https://api.github.com/users/curtisman","html_url":"https://github.com/curtisman","followers_url":"https://api.github.com/users/curtisman/followers","following_url":"https://api.github.com/users/curtisman/following{/other_user}","gists_url":"https://api.github.com/users/curtisman/gists{/gist_id}","starred_url":"https://api.github.com/users/curtisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curtisman/subscriptions","organizations_url":"https://api.github.com/users/curtisman/orgs","repos_url":"https://api.github.com/users/curtisman/repos","events_url":"https://api.github.com/users/curtisman/events{/privacy}","received_events_url":"https://api.github.com/users/curtisman/received_events","type":"User","site_admin":false},"body":"Oh.  I am going to answer my own question.  :)\r\nIt's because you are using the IMUL r/m64 (right) form of the instruction which does RDX (high):RAX (low) ← RAX (left) ∗ r/m64. (right)\r\n\r\nPlease add a comment.  But it looks good otherwise.","created_at":"2016-03-29T15:40:53Z","updated_at":"2016-03-29T15:40:53Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/668#discussion_r57745927","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/668","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/57745927"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/668#discussion_r57745927"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/668"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/668","id":64382427,"html_url":"https://github.com/Microsoft/ChakraCore/pull/668","diff_url":"https://github.com/Microsoft/ChakraCore/pull/668.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/668.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/668","number":668,"state":"open","locked":false,"title":"cross platform: Implement _mul128","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"body":"See https://github.com/Microsoft/ChakraCore/issues/217","created_at":"2016-03-28T21:54:21Z","updated_at":"2016-03-29T15:40:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e14492912b09edc09a4d32070b74494f148c3f46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/668/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/668/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/668/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/87ae5f56a9fda66624ec983f8414e1844208e3c0","head":{"label":"obastemur:fix_mul","ref":"fix_mul","sha":"87ae5f56a9fda66624ec983f8414e1844208e3c0","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"repo":{"id":53002057,"name":"ChakraCore","full_name":"obastemur/ChakraCore","owner":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obastemur/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/obastemur/ChakraCore","forks_url":"https://api.github.com/repos/obastemur/ChakraCore/forks","keys_url":"https://api.github.com/repos/obastemur/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obastemur/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obastemur/ChakraCore/teams","hooks_url":"https://api.github.com/repos/obastemur/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/obastemur/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/obastemur/ChakraCore/events","assignees_url":"https://api.github.com/repos/obastemur/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/obastemur/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/obastemur/ChakraCore/tags","blobs_url":"https://api.github.com/repos/obastemur/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obastemur/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obastemur/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/obastemur/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obastemur/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/obastemur/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/obastemur/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/obastemur/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/obastemur/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/obastemur/ChakraCore/subscription","commits_url":"https://api.github.com/repos/obastemur/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/obastemur/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/obastemur/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/obastemur/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/obastemur/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/obastemur/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obastemur/ChakraCore/merges","archive_url":"https://api.github.com/repos/obastemur/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obastemur/ChakraCore/downloads","issues_url":"https://api.github.com/repos/obastemur/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/obastemur/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/obastemur/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/obastemur/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obastemur/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/obastemur/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/obastemur/ChakraCore/deployments","created_at":"2016-03-02T22:43:37Z","updated_at":"2016-03-02T22:43:53Z","pushed_at":"2016-03-29T10:42:39Z","git_url":"git://github.com/obastemur/ChakraCore.git","ssh_url":"git@github.com:obastemur/ChakraCore.git","clone_url":"https://github.com/obastemur/ChakraCore.git","svn_url":"https://github.com/obastemur/ChakraCore","homepage":null,"size":24287,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master2"}},"base":{"label":"Microsoft:linux","ref":"linux","sha":"35732ee3a8f3db7dfd72b641cd15257ef0c2d133","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-03-29T12:59:57Z","pushed_at":"2016-03-29T12:18:22Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":28185,"stargazers_count":5023,"watchers_count":5023,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":536,"mirror_url":null,"open_issues_count":133,"forks":536,"open_issues":133,"watchers":5023,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/668"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/668"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/668"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/668/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/668/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/668/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/87ae5f56a9fda66624ec983f8414e1844208e3c0"}}}}