{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/93669644","pull_request_review_id":14202607,"id":93669644,"diff_hunk":"@@ -9,7 +9,7 @@\n \n defined('_JEXEC') or die;\n $class = ' class=\"first\"';\n-if (count($this->items[$this->parent->id]) > 0 && $this->maxLevelcat != 0) :\n+if (count($this->items[$this->parent->id]) > 0 && $this->maxLevelcat !== 0) :","path":"templates/beez3/html/com_contact/categories/default_items.php","position":5,"original_position":5,"commit_id":"1cf02cc917d9bfc248ddf35ccb2b9406170a0c15","original_commit_id":"1cf02cc917d9bfc248ddf35ccb2b9406170a0c15","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"body":"I have already done some thinking on that. Will do some prototyping in the next days.\r\n","created_at":"2016-12-22T18:01:48Z","updated_at":"2016-12-22T18:01:48Z","html_url":"https://github.com/joomla/joomla-cms/pull/13310#discussion_r93669644","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13310","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/93669644"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13310#discussion_r93669644"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13310"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13310","id":98810581,"html_url":"https://github.com/joomla/joomla-cms/pull/13310","diff_url":"https://github.com/joomla/joomla-cms/pull/13310.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13310.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13310","number":13310,"state":"open","locked":false,"title":"More type-safe comparisons in site/templates","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"body":"### Summary of Changes\r\n- More type-safe comparisons in site/templates\r\n\r\nThe changes in this PR should be fairly easy to review. They are only type safe `int` or `bool` comparisons. This PR is done, so the batch PR #12233 can become a little lighter and easier to review. In hope that this will get merged quickly so further work can be done without conflicting with other PRs. ;)\r\n\r\n### Testing Instructions\r\n\r\nNone, should not change behavior\r\n\r\n\r\n### Documentation Changes Required\r\n\r\nNone.\r\n","created_at":"2016-12-20T19:29:22Z","updated_at":"2016-12-22T18:01:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1fd11dc33fa7d078dc37e869000d3903b10ece1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13310/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13310/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13310/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/1cf02cc917d9bfc248ddf35ccb2b9406170a0c15","head":{"label":"frankmayer:more-type-safe-comparisons-in-site-templates","ref":"more-type-safe-comparisons-in-site-templates","sha":"1cf02cc917d9bfc248ddf35ccb2b9406170a0c15","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"repo":{"id":69169032,"name":"joomla-cms","full_name":"frankmayer/joomla-cms","owner":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frankmayer/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/frankmayer/joomla-cms","forks_url":"https://api.github.com/repos/frankmayer/joomla-cms/forks","keys_url":"https://api.github.com/repos/frankmayer/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frankmayer/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frankmayer/joomla-cms/teams","hooks_url":"https://api.github.com/repos/frankmayer/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/frankmayer/joomla-cms/events","assignees_url":"https://api.github.com/repos/frankmayer/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/frankmayer/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/frankmayer/joomla-cms/tags","blobs_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frankmayer/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/frankmayer/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/frankmayer/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/frankmayer/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/frankmayer/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/frankmayer/joomla-cms/subscription","commits_url":"https://api.github.com/repos/frankmayer/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/frankmayer/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/frankmayer/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/frankmayer/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frankmayer/joomla-cms/merges","archive_url":"https://api.github.com/repos/frankmayer/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frankmayer/joomla-cms/downloads","issues_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/frankmayer/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/frankmayer/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/frankmayer/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frankmayer/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/frankmayer/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/frankmayer/joomla-cms/deployments","created_at":"2016-09-25T14:24:41Z","updated_at":"2016-09-25T14:24:55Z","pushed_at":"2016-12-22T01:39:09Z","git_url":"git://github.com/frankmayer/joomla-cms.git","ssh_url":"git@github.com:frankmayer/joomla-cms.git","clone_url":"https://github.com/frankmayer/joomla-cms.git","svn_url":"https://github.com/frankmayer/joomla-cms","homepage":"https://www.joomla.org","size":168320,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"bda9ec13453f1d42f3277ad871ffd997a4fcc4f0","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-12-21T22:52:25Z","pushed_at":"2016-12-22T13:24:28Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":168893,"stargazers_count":2212,"watchers_count":2212,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2363,"mirror_url":null,"open_issues_count":557,"forks":2363,"open_issues":557,"watchers":2212,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13310"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13310"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13310"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13310/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13310/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13310/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/1cf02cc917d9bfc248ddf35ccb2b9406170a0c15"}}}}
{"actor":{"display_login":"frankmayer"}}