{"action":"created","comment":{"url":"https://api.github.com/repos/eladnava/mailgen/pulls/comments/66705617","id":66705617,"diff_hunk":"@@ -94,14 +94,23 @@ Mailgen.prototype.parseParams = function (params) {\n     if (!body || typeof body !== 'object') {\n         throw new Error('Please provide the `body` parameter as an object.');\n     }\n-    \n+\n     // Pass text direction to template\n     body.textDirection = this.textDirection;\n-    \n+\n     // Support for custom greeting/signature (fallback to sensible defaults)\n     body.greeting = body.greeting || 'Hi';\n     body.signature = body.signature || 'Yours truly';\n \n+    function convertToArray(data) {","path":"index.js","position":27,"original_position":27,"commit_id":"b5a4e0245f091d6b24b1002a33be14df569927c1","original_commit_id":"b5a4e0245f091d6b24b1002a33be14df569927c1","user":{"login":"eladnava","id":4394189,"avatar_url":"https://avatars.githubusercontent.com/u/4394189?v=3","gravatar_id":"","url":"https://api.github.com/users/eladnava","html_url":"https://github.com/eladnava","followers_url":"https://api.github.com/users/eladnava/followers","following_url":"https://api.github.com/users/eladnava/following{/other_user}","gists_url":"https://api.github.com/users/eladnava/gists{/gist_id}","starred_url":"https://api.github.com/users/eladnava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladnava/subscriptions","organizations_url":"https://api.github.com/users/eladnava/orgs","repos_url":"https://api.github.com/users/eladnava/repos","events_url":"https://api.github.com/users/eladnava/events{/privacy}","received_events_url":"https://api.github.com/users/eladnava/received_events","type":"User","site_admin":false},"body":"Looks good, can you please move the function declaration outside of the `parseParams` function?","created_at":"2016-06-11T12:56:41Z","updated_at":"2016-06-11T12:56:41Z","html_url":"https://github.com/eladnava/mailgen/pull/10#discussion_r66705617","pull_request_url":"https://api.github.com/repos/eladnava/mailgen/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/eladnava/mailgen/pulls/comments/66705617"},"html":{"href":"https://github.com/eladnava/mailgen/pull/10#discussion_r66705617"},"pull_request":{"href":"https://api.github.com/repos/eladnava/mailgen/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/eladnava/mailgen/pulls/10","id":73296048,"html_url":"https://github.com/eladnava/mailgen/pull/10","diff_url":"https://github.com/eladnava/mailgen/pull/10.diff","patch_url":"https://github.com/eladnava/mailgen/pull/10.patch","issue_url":"https://api.github.com/repos/eladnava/mailgen/issues/10","number":10,"state":"open","locked":false,"title":"Add Additional Properties","user":{"login":"AlecRust","id":247634,"avatar_url":"https://avatars.githubusercontent.com/u/247634?v=3","gravatar_id":"","url":"https://api.github.com/users/AlecRust","html_url":"https://github.com/AlecRust","followers_url":"https://api.github.com/users/AlecRust/followers","following_url":"https://api.github.com/users/AlecRust/following{/other_user}","gists_url":"https://api.github.com/users/AlecRust/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecRust/subscriptions","organizations_url":"https://api.github.com/users/AlecRust/orgs","repos_url":"https://api.github.com/users/AlecRust/repos","events_url":"https://api.github.com/users/AlecRust/events{/privacy}","received_events_url":"https://api.github.com/users/AlecRust/received_events","type":"User","site_admin":false},"body":"**See issue https://github.com/eladnava/mailgen/issues/9 for details.**\r\n\r\nI tried to do the minimal changes to achieve these three new features, my editor has stripped some dead whitespace though so apologies for the noise.\r\n\r\nI think there are further documentation updates in order, e.g. it'd be nice if all the properties were listed in a table in the main README perhaps? Here's a PR just to close #9 though so I can start using these 😃 \r\n\r\nNot a particular fan of how title vs greeting/intro works, but maybe centre aligning the title would help to differentiate the two?\r\n\r\nHere's an example of an email utilising these new features:\r\n\r\n![screenshot](https://i.imgur.com/lptDD89.png)","created_at":"2016-06-09T22:22:54Z","updated_at":"2016-06-11T12:56:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ed9820ac1a20a66941165304a085b6d41aad9e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eladnava/mailgen/pulls/10/commits","review_comments_url":"https://api.github.com/repos/eladnava/mailgen/pulls/10/comments","review_comment_url":"https://api.github.com/repos/eladnava/mailgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eladnava/mailgen/issues/10/comments","statuses_url":"https://api.github.com/repos/eladnava/mailgen/statuses/b5a4e0245f091d6b24b1002a33be14df569927c1","head":{"label":"AlecRust:additional-properties","ref":"additional-properties","sha":"b5a4e0245f091d6b24b1002a33be14df569927c1","user":{"login":"AlecRust","id":247634,"avatar_url":"https://avatars.githubusercontent.com/u/247634?v=3","gravatar_id":"","url":"https://api.github.com/users/AlecRust","html_url":"https://github.com/AlecRust","followers_url":"https://api.github.com/users/AlecRust/followers","following_url":"https://api.github.com/users/AlecRust/following{/other_user}","gists_url":"https://api.github.com/users/AlecRust/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecRust/subscriptions","organizations_url":"https://api.github.com/users/AlecRust/orgs","repos_url":"https://api.github.com/users/AlecRust/repos","events_url":"https://api.github.com/users/AlecRust/events{/privacy}","received_events_url":"https://api.github.com/users/AlecRust/received_events","type":"User","site_admin":false},"repo":{"id":60789320,"name":"mailgen","full_name":"AlecRust/mailgen","owner":{"login":"AlecRust","id":247634,"avatar_url":"https://avatars.githubusercontent.com/u/247634?v=3","gravatar_id":"","url":"https://api.github.com/users/AlecRust","html_url":"https://github.com/AlecRust","followers_url":"https://api.github.com/users/AlecRust/followers","following_url":"https://api.github.com/users/AlecRust/following{/other_user}","gists_url":"https://api.github.com/users/AlecRust/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecRust/subscriptions","organizations_url":"https://api.github.com/users/AlecRust/orgs","repos_url":"https://api.github.com/users/AlecRust/repos","events_url":"https://api.github.com/users/AlecRust/events{/privacy}","received_events_url":"https://api.github.com/users/AlecRust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlecRust/mailgen","description":"A Node.js package that generates clean, responsive HTML e-mails for sending transactional mail.","fork":true,"url":"https://api.github.com/repos/AlecRust/mailgen","forks_url":"https://api.github.com/repos/AlecRust/mailgen/forks","keys_url":"https://api.github.com/repos/AlecRust/mailgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlecRust/mailgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlecRust/mailgen/teams","hooks_url":"https://api.github.com/repos/AlecRust/mailgen/hooks","issue_events_url":"https://api.github.com/repos/AlecRust/mailgen/issues/events{/number}","events_url":"https://api.github.com/repos/AlecRust/mailgen/events","assignees_url":"https://api.github.com/repos/AlecRust/mailgen/assignees{/user}","branches_url":"https://api.github.com/repos/AlecRust/mailgen/branches{/branch}","tags_url":"https://api.github.com/repos/AlecRust/mailgen/tags","blobs_url":"https://api.github.com/repos/AlecRust/mailgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlecRust/mailgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlecRust/mailgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlecRust/mailgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlecRust/mailgen/statuses/{sha}","languages_url":"https://api.github.com/repos/AlecRust/mailgen/languages","stargazers_url":"https://api.github.com/repos/AlecRust/mailgen/stargazers","contributors_url":"https://api.github.com/repos/AlecRust/mailgen/contributors","subscribers_url":"https://api.github.com/repos/AlecRust/mailgen/subscribers","subscription_url":"https://api.github.com/repos/AlecRust/mailgen/subscription","commits_url":"https://api.github.com/repos/AlecRust/mailgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlecRust/mailgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlecRust/mailgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlecRust/mailgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlecRust/mailgen/contents/{+path}","compare_url":"https://api.github.com/repos/AlecRust/mailgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlecRust/mailgen/merges","archive_url":"https://api.github.com/repos/AlecRust/mailgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlecRust/mailgen/downloads","issues_url":"https://api.github.com/repos/AlecRust/mailgen/issues{/number}","pulls_url":"https://api.github.com/repos/AlecRust/mailgen/pulls{/number}","milestones_url":"https://api.github.com/repos/AlecRust/mailgen/milestones{/number}","notifications_url":"https://api.github.com/repos/AlecRust/mailgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlecRust/mailgen/labels{/name}","releases_url":"https://api.github.com/repos/AlecRust/mailgen/releases{/id}","deployments_url":"https://api.github.com/repos/AlecRust/mailgen/deployments","created_at":"2016-06-09T16:23:24Z","updated_at":"2016-06-09T16:23:25Z","pushed_at":"2016-06-09T22:12:53Z","git_url":"git://github.com/AlecRust/mailgen.git","ssh_url":"git@github.com:AlecRust/mailgen.git","clone_url":"https://github.com/AlecRust/mailgen.git","svn_url":"https://github.com/AlecRust/mailgen","homepage":null,"size":1187,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eladnava:master","ref":"master","sha":"4416c552aab6dc36b9d98e6d0627144af2f9e89a","user":{"login":"eladnava","id":4394189,"avatar_url":"https://avatars.githubusercontent.com/u/4394189?v=3","gravatar_id":"","url":"https://api.github.com/users/eladnava","html_url":"https://github.com/eladnava","followers_url":"https://api.github.com/users/eladnava/followers","following_url":"https://api.github.com/users/eladnava/following{/other_user}","gists_url":"https://api.github.com/users/eladnava/gists{/gist_id}","starred_url":"https://api.github.com/users/eladnava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladnava/subscriptions","organizations_url":"https://api.github.com/users/eladnava/orgs","repos_url":"https://api.github.com/users/eladnava/repos","events_url":"https://api.github.com/users/eladnava/events{/privacy}","received_events_url":"https://api.github.com/users/eladnava/received_events","type":"User","site_admin":false},"repo":{"id":59653935,"name":"mailgen","full_name":"eladnava/mailgen","owner":{"login":"eladnava","id":4394189,"avatar_url":"https://avatars.githubusercontent.com/u/4394189?v=3","gravatar_id":"","url":"https://api.github.com/users/eladnava","html_url":"https://github.com/eladnava","followers_url":"https://api.github.com/users/eladnava/followers","following_url":"https://api.github.com/users/eladnava/following{/other_user}","gists_url":"https://api.github.com/users/eladnava/gists{/gist_id}","starred_url":"https://api.github.com/users/eladnava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladnava/subscriptions","organizations_url":"https://api.github.com/users/eladnava/orgs","repos_url":"https://api.github.com/users/eladnava/repos","events_url":"https://api.github.com/users/eladnava/events{/privacy}","received_events_url":"https://api.github.com/users/eladnava/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eladnava/mailgen","description":"A Node.js package that generates clean, responsive HTML e-mails for sending transactional mail.","fork":false,"url":"https://api.github.com/repos/eladnava/mailgen","forks_url":"https://api.github.com/repos/eladnava/mailgen/forks","keys_url":"https://api.github.com/repos/eladnava/mailgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eladnava/mailgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eladnava/mailgen/teams","hooks_url":"https://api.github.com/repos/eladnava/mailgen/hooks","issue_events_url":"https://api.github.com/repos/eladnava/mailgen/issues/events{/number}","events_url":"https://api.github.com/repos/eladnava/mailgen/events","assignees_url":"https://api.github.com/repos/eladnava/mailgen/assignees{/user}","branches_url":"https://api.github.com/repos/eladnava/mailgen/branches{/branch}","tags_url":"https://api.github.com/repos/eladnava/mailgen/tags","blobs_url":"https://api.github.com/repos/eladnava/mailgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eladnava/mailgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eladnava/mailgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/eladnava/mailgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eladnava/mailgen/statuses/{sha}","languages_url":"https://api.github.com/repos/eladnava/mailgen/languages","stargazers_url":"https://api.github.com/repos/eladnava/mailgen/stargazers","contributors_url":"https://api.github.com/repos/eladnava/mailgen/contributors","subscribers_url":"https://api.github.com/repos/eladnava/mailgen/subscribers","subscription_url":"https://api.github.com/repos/eladnava/mailgen/subscription","commits_url":"https://api.github.com/repos/eladnava/mailgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/eladnava/mailgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/eladnava/mailgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/eladnava/mailgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/eladnava/mailgen/contents/{+path}","compare_url":"https://api.github.com/repos/eladnava/mailgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eladnava/mailgen/merges","archive_url":"https://api.github.com/repos/eladnava/mailgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eladnava/mailgen/downloads","issues_url":"https://api.github.com/repos/eladnava/mailgen/issues{/number}","pulls_url":"https://api.github.com/repos/eladnava/mailgen/pulls{/number}","milestones_url":"https://api.github.com/repos/eladnava/mailgen/milestones{/number}","notifications_url":"https://api.github.com/repos/eladnava/mailgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eladnava/mailgen/labels{/name}","releases_url":"https://api.github.com/repos/eladnava/mailgen/releases{/id}","deployments_url":"https://api.github.com/repos/eladnava/mailgen/deployments","created_at":"2016-05-25T10:25:41Z","updated_at":"2016-06-11T12:25:14Z","pushed_at":"2016-06-09T22:22:54Z","git_url":"git://github.com/eladnava/mailgen.git","ssh_url":"git@github.com:eladnava/mailgen.git","clone_url":"https://github.com/eladnava/mailgen.git","svn_url":"https://github.com/eladnava/mailgen","homepage":null,"size":1212,"stargazers_count":1658,"watchers_count":1658,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":2,"forks":52,"open_issues":2,"watchers":1658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eladnava/mailgen/pulls/10"},"html":{"href":"https://github.com/eladnava/mailgen/pull/10"},"issue":{"href":"https://api.github.com/repos/eladnava/mailgen/issues/10"},"comments":{"href":"https://api.github.com/repos/eladnava/mailgen/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/eladnava/mailgen/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/eladnava/mailgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eladnava/mailgen/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/eladnava/mailgen/statuses/b5a4e0245f091d6b24b1002a33be14df569927c1"}}}}
{"actor":{"display_login":"eladnava"}}