{"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/comments/89524973","pull_request_review_id":10070898,"id":89524973,"diff_hunk":"@@ -69,35 +73,47 @@\n \n    public static void main(String[] args) throws IOException {\n \n-      if (args.length < PARAMETERS)\n+      String provider;\n+      String identity;\n+      String credential;\n+      String containerName;\n+      String endpoint = null;\n+      boolean isSwiftv1 = Boolean.FALSE;\n+      \n+      List<String> parameters = Lists.newArrayList(args);\n+      if (parameters.size() < PARAMETERS)\n          throw new IllegalArgumentException(INVALID_SYNTAX);\n \n       // Args\n-\n-      String provider = args[0];\n-\n+      provider = parameters.get(0);\n       // note that you can check if a provider is present ahead of time\n       checkArgument(contains(allKeys, provider), \"provider %s not in supported list: %s\", provider, allKeys);\n-\n-      String identity = args[1];\n-      String credential = args[2];\n-      String containerName = args[3];\n+      identity = parameters.get(1);\n+      credential = parameters.get(2);\n+      containerName = parameters.get(3);\n+      if (parameters.size() > 4) endpoint = parameters.get(4);\n+      if (parameters.size() > 5) isSwiftv1 = Boolean.parseBoolean(parameters.get(5));","path":"blobstore-basics/src/main/java/org/jclouds/examples/blobstore/basics/MainApp.java","position":61,"original_position":61,"commit_id":"70f574af20bc8f30d5835d907411fe85ab259945","original_commit_id":"70f574af20bc8f30d5835d907411fe85ab259945","user":{"login":"demobox","id":223702,"avatar_url":"https://avatars.githubusercontent.com/u/223702?v=3","gravatar_id":"","url":"https://api.github.com/users/demobox","html_url":"https://github.com/demobox","followers_url":"https://api.github.com/users/demobox/followers","following_url":"https://api.github.com/users/demobox/following{/other_user}","gists_url":"https://api.github.com/users/demobox/gists{/gist_id}","starred_url":"https://api.github.com/users/demobox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demobox/subscriptions","organizations_url":"https://api.github.com/users/demobox/orgs","repos_url":"https://api.github.com/users/demobox/repos","events_url":"https://api.github.com/users/demobox/events{/privacy}","received_events_url":"https://api.github.com/users/demobox/received_events","type":"User","site_admin":false},"body":"Rather odd provider-specific argument here? Is there some other way we can get this information, e.g. from the provider name?","created_at":"2016-11-24T16:25:03Z","updated_at":"2016-11-24T16:25:03Z","html_url":"https://github.com/jclouds/jclouds-examples/pull/90#discussion_r89524973","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/comments/89524973"},"html":{"href":"https://github.com/jclouds/jclouds-examples/pull/90#discussion_r89524973"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/90","id":95156023,"html_url":"https://github.com/jclouds/jclouds-examples/pull/90","diff_url":"https://github.com/jclouds/jclouds-examples/pull/90.diff","patch_url":"https://github.com/jclouds/jclouds-examples/pull/90.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-examples/issues/90","number":90,"state":"open","locked":false,"title":"update blobstore-basics to use 2.0.0","user":{"login":"andreaturli","id":222887,"avatar_url":"https://avatars.githubusercontent.com/u/222887?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"body":"update README.md","created_at":"2016-11-24T10:52:13Z","updated_at":"2016-11-24T16:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e91372c04ed4f17749460487eb71b4680c4de0d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/90/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/90/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-examples/issues/90/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-examples/statuses/70f574af20bc8f30d5835d907411fe85ab259945","head":{"label":"andreaturli:master","ref":"master","sha":"70f574af20bc8f30d5835d907411fe85ab259945","user":{"login":"andreaturli","id":222887,"avatar_url":"https://avatars.githubusercontent.com/u/222887?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"repo":{"id":19708797,"name":"jclouds-examples","full_name":"andreaturli/jclouds-examples","owner":{"login":"andreaturli","id":222887,"avatar_url":"https://avatars.githubusercontent.com/u/222887?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreaturli/jclouds-examples","description":"Read-only mirror of ASF Git Repo for jclouds examples","fork":true,"url":"https://api.github.com/repos/andreaturli/jclouds-examples","forks_url":"https://api.github.com/repos/andreaturli/jclouds-examples/forks","keys_url":"https://api.github.com/repos/andreaturli/jclouds-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreaturli/jclouds-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreaturli/jclouds-examples/teams","hooks_url":"https://api.github.com/repos/andreaturli/jclouds-examples/hooks","issue_events_url":"https://api.github.com/repos/andreaturli/jclouds-examples/issues/events{/number}","events_url":"https://api.github.com/repos/andreaturli/jclouds-examples/events","assignees_url":"https://api.github.com/repos/andreaturli/jclouds-examples/assignees{/user}","branches_url":"https://api.github.com/repos/andreaturli/jclouds-examples/branches{/branch}","tags_url":"https://api.github.com/repos/andreaturli/jclouds-examples/tags","blobs_url":"https://api.github.com/repos/andreaturli/jclouds-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreaturli/jclouds-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreaturli/jclouds-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreaturli/jclouds-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreaturli/jclouds-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/andreaturli/jclouds-examples/languages","stargazers_url":"https://api.github.com/repos/andreaturli/jclouds-examples/stargazers","contributors_url":"https://api.github.com/repos/andreaturli/jclouds-examples/contributors","subscribers_url":"https://api.github.com/repos/andreaturli/jclouds-examples/subscribers","subscription_url":"https://api.github.com/repos/andreaturli/jclouds-examples/subscription","commits_url":"https://api.github.com/repos/andreaturli/jclouds-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreaturli/jclouds-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreaturli/jclouds-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreaturli/jclouds-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreaturli/jclouds-examples/contents/{+path}","compare_url":"https://api.github.com/repos/andreaturli/jclouds-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreaturli/jclouds-examples/merges","archive_url":"https://api.github.com/repos/andreaturli/jclouds-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreaturli/jclouds-examples/downloads","issues_url":"https://api.github.com/repos/andreaturli/jclouds-examples/issues{/number}","pulls_url":"https://api.github.com/repos/andreaturli/jclouds-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/andreaturli/jclouds-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/andreaturli/jclouds-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreaturli/jclouds-examples/labels{/name}","releases_url":"https://api.github.com/repos/andreaturli/jclouds-examples/releases{/id}","deployments_url":"https://api.github.com/repos/andreaturli/jclouds-examples/deployments","created_at":"2014-05-12T17:45:38Z","updated_at":"2016-08-09T10:44:14Z","pushed_at":"2016-11-24T10:51:43Z","git_url":"git://github.com/andreaturli/jclouds-examples.git","ssh_url":"git@github.com:andreaturli/jclouds-examples.git","clone_url":"https://github.com/andreaturli/jclouds-examples.git","svn_url":"https://github.com/andreaturli/jclouds-examples","homepage":null,"size":1297,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"ddb0cfbd40c8cd37a68a49b51adb8bb721f2b0c0","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10041016,"name":"jclouds-examples","full_name":"jclouds/jclouds-examples","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-examples","description":"Read-only mirror of ASF Git Repo for jclouds examples","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-examples","forks_url":"https://api.github.com/repos/jclouds/jclouds-examples/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-examples/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-examples/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-examples/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-examples/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-examples/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-examples/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-examples/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-examples/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-examples/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-examples/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-examples/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-examples/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-examples/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-examples/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-examples/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-examples/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-examples/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-examples/releases{/id}","deployments_url":"https://api.github.com/repos/jclouds/jclouds-examples/deployments","created_at":"2013-05-13T20:49:37Z","updated_at":"2016-11-06T06:23:55Z","pushed_at":"2016-11-24T10:52:13Z","git_url":"git://github.com/jclouds/jclouds-examples.git","ssh_url":"git@github.com:jclouds/jclouds-examples.git","clone_url":"https://github.com/jclouds/jclouds-examples.git","svn_url":"https://github.com/jclouds/jclouds-examples","homepage":null,"size":1425,"stargazers_count":83,"watchers_count":83,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":6,"forks":139,"open_issues":6,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/90"},"html":{"href":"https://github.com/jclouds/jclouds-examples/pull/90"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/issues/90"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-examples/statuses/70f574af20bc8f30d5835d907411fe85ab259945"}}}}
{"actor":{"display_login":"demobox"}}