{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/50804312","id":50804312,"diff_hunk":"@@ -1336,3 +1403,202 @@ class RenderMetaData extends RenderProxyBox {\n   /// Opaque meta data ignored by the render tree\n   dynamic metaData;\n }\n+\n+class RenderSemanticsGestureHandler extends RenderProxyBox implements SemanticActionHandler {\n+  RenderSemanticsGestureHandler({\n+    RenderBox child,\n+    GestureTapCallback onTap,\n+    GestureLongPressCallback onLongPress,\n+    GestureDragUpdateCallback onHorizontalDragUpdate,\n+    GestureDragUpdateCallback onVerticalDragUpdate,\n+    this.scrollFactor: 0.8\n+  }) : _onTap = onTap,\n+       _onLongPress = onLongPress,\n+       _onHorizontalDragUpdate = onHorizontalDragUpdate,\n+       _onVerticalDragUpdate = onVerticalDragUpdate,\n+       super(child);\n+\n+  GestureTapCallback get onTap => _onTap;\n+  GestureTapCallback _onTap;\n+  void set onTap(GestureTapCallback value) {\n+    if (_onTap == value)\n+      return;\n+    bool hadSemantics = hasSemantics;","path":"packages/flutter/lib/src/rendering/proxy_box.dart","position":163,"original_position":163,"commit_id":"5dca1f936ed99368eae9516b4ad89aafce68bba5","original_commit_id":"5dca1f936ed99368eae9516b4ad89aafce68bba5","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"had and has are pretty similar.  Easy to mis-read.  Maybe didHaveSemantics?","created_at":"2016-01-26T08:08:48Z","updated_at":"2016-01-26T08:08:48Z","html_url":"https://github.com/flutter/flutter/pull/1309#discussion_r50804312","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/1309","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/50804312"},"html":{"href":"https://github.com/flutter/flutter/pull/1309#discussion_r50804312"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/1309"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/1309","id":56557477,"html_url":"https://github.com/flutter/flutter/pull/1309","diff_url":"https://github.com/flutter/flutter/pull/1309.diff","patch_url":"https://github.com/flutter/flutter/pull/1309.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/1309","number":1309,"state":"open","locked":false,"title":"Semantics","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"The following open issues exist:\r\n - Sliders, drop-down buttons, and text input fields aren't accessible yet.\r\n - Time picker isn't accessible yet. This will require making it possible to create custom SemanticsNode subtrees.\r\n - The Java/Objective C sides here aren't done.\r\n - I need to add a few more tests still.\r\n\r\nSee https://github.com/flutter/engine/pull/2277 for the mojom used by this patch.","created_at":"2016-01-20T02:46:49Z","updated_at":"2016-01-26T08:08:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de5e7b73e405312c9b317ba73f57f1236f49c8e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/1309/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/1309/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/1309/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/5dca1f936ed99368eae9516b4ad89aafce68bba5","head":{"label":"Hixie:semantics-3","ref":"semantics-3","sha":"5dca1f936ed99368eae9516b4ad89aafce68bba5","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"repo":{"id":45635647,"name":"flutter","full_name":"Hixie/flutter","owner":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hixie/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/Hixie/flutter","forks_url":"https://api.github.com/repos/Hixie/flutter/forks","keys_url":"https://api.github.com/repos/Hixie/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hixie/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hixie/flutter/teams","hooks_url":"https://api.github.com/repos/Hixie/flutter/hooks","issue_events_url":"https://api.github.com/repos/Hixie/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/Hixie/flutter/events","assignees_url":"https://api.github.com/repos/Hixie/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/Hixie/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/Hixie/flutter/tags","blobs_url":"https://api.github.com/repos/Hixie/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hixie/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hixie/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hixie/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hixie/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/Hixie/flutter/languages","stargazers_url":"https://api.github.com/repos/Hixie/flutter/stargazers","contributors_url":"https://api.github.com/repos/Hixie/flutter/contributors","subscribers_url":"https://api.github.com/repos/Hixie/flutter/subscribers","subscription_url":"https://api.github.com/repos/Hixie/flutter/subscription","commits_url":"https://api.github.com/repos/Hixie/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hixie/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hixie/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hixie/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hixie/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/Hixie/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hixie/flutter/merges","archive_url":"https://api.github.com/repos/Hixie/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hixie/flutter/downloads","issues_url":"https://api.github.com/repos/Hixie/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/Hixie/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/Hixie/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/Hixie/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hixie/flutter/labels{/name}","releases_url":"https://api.github.com/repos/Hixie/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/Hixie/flutter/deployments","created_at":"2015-11-05T19:54:58Z","updated_at":"2015-11-05T19:54:59Z","pushed_at":"2016-01-26T01:32:01Z","git_url":"git://github.com/Hixie/flutter.git","ssh_url":"git@github.com:Hixie/flutter.git","clone_url":"https://github.com/Hixie/flutter.git","svn_url":"https://github.com/Hixie/flutter","homepage":"http://flutter.io","size":12291,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"b7396ba13ef57c17582ed263c61ee756e42d3056","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-01-26T00:09:23Z","pushed_at":"2016-01-26T04:48:47Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"http://flutter.io","size":104048,"stargazers_count":2579,"watchers_count":2579,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":426,"forks":246,"open_issues":426,"watchers":2579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/1309"},"html":{"href":"https://github.com/flutter/flutter/pull/1309"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/1309"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/1309/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/1309/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/1309/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/5dca1f936ed99368eae9516b4ad89aafce68bba5"}}}}