{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/56008638","id":56008638,"diff_hunk":"@@ -332,7 +332,7 @@ function copy!(dest::AbstractArray, doffs::Integer,\n     doffs+n-1 > length(dest) && throw(BoundsError(dest, doffs+n-1))\n     doffs < 1 && throw(BoundsError(dest, doffs))\n     soffs < 1 && throw(BoundsError(src, soffs))\n-    @inbounds for i = 0:(n-1)\n+    @inbounds for i = 0:(n-1) #Fixme iter","path":"base/abstractarray.jl","position":19,"original_position":19,"commit_id":"1c4c93743ee99ba66284a07a99ae17b17d40d270","original_commit_id":"1c4c93743ee99ba66284a07a99ae17b17d40d270","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=3","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"I wonder whether this function should be restricted to arrays...","created_at":"2016-03-14T14:30:44Z","updated_at":"2016-03-14T14:30:44Z","html_url":"https://github.com/JuliaLang/julia/pull/15497#discussion_r56008638","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/15497","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/56008638"},"html":{"href":"https://github.com/JuliaLang/julia/pull/15497#discussion_r56008638"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/15497"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/15497","id":62750776,"html_url":"https://github.com/JuliaLang/julia/pull/15497","diff_url":"https://github.com/JuliaLang/julia/pull/15497.diff","patch_url":"https://github.com/JuliaLang/julia/pull/15497.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/15497","number":15497,"state":"open","locked":false,"title":"fix for loop for array indexing","user":{"login":"meggart","id":2539563,"avatar_url":"https://avatars.githubusercontent.com/u/2539563?v=3","gravatar_id":"","url":"https://api.github.com/users/meggart","html_url":"https://github.com/meggart","followers_url":"https://api.github.com/users/meggart/followers","following_url":"https://api.github.com/users/meggart/following{/other_user}","gists_url":"https://api.github.com/users/meggart/gists{/gist_id}","starred_url":"https://api.github.com/users/meggart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meggart/subscriptions","organizations_url":"https://api.github.com/users/meggart/orgs","repos_url":"https://api.github.com/users/meggart/repos","events_url":"https://api.github.com/users/meggart/events{/privacy}","received_events_url":"https://api.github.com/users/meggart/received_events","type":"User","site_admin":false},"body":"This is the iteration fixes for the files abstractarray.jl ... arraymath.jl, see issue #15434 \r\n\r\nThere were quite a few cases where the fix was not obviuos because of one of these reasons:\r\n\r\n- there was an offset in the iteration e.g. (`for i=2:length(A)`)\r\n- iteration was done over certain dimensions of a matrix\r\n- changes were too non-trivial for this PR,  I did not want to touch (and possibly mess up) `map_n!` and `map_to_n!`\r\n\r\nHowever, `#Fixme iter` and `#Fixme comp` comments were added in these cases.\r\n\r\n","created_at":"2016-03-14T13:53:58Z","updated_at":"2016-03-14T14:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2163a739a24f8eacbb12f5fbd32a57a5a7294c80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/15497/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/15497/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/15497/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/1c4c93743ee99ba66284a07a99ae17b17d40d270","head":{"label":"meggart:iteration","ref":"iteration","sha":"1c4c93743ee99ba66284a07a99ae17b17d40d270","user":{"login":"meggart","id":2539563,"avatar_url":"https://avatars.githubusercontent.com/u/2539563?v=3","gravatar_id":"","url":"https://api.github.com/users/meggart","html_url":"https://github.com/meggart","followers_url":"https://api.github.com/users/meggart/followers","following_url":"https://api.github.com/users/meggart/following{/other_user}","gists_url":"https://api.github.com/users/meggart/gists{/gist_id}","starred_url":"https://api.github.com/users/meggart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meggart/subscriptions","organizations_url":"https://api.github.com/users/meggart/orgs","repos_url":"https://api.github.com/users/meggart/repos","events_url":"https://api.github.com/users/meggart/events{/privacy}","received_events_url":"https://api.github.com/users/meggart/received_events","type":"User","site_admin":false},"repo":{"id":26863248,"name":"julia","full_name":"meggart/julia","owner":{"login":"meggart","id":2539563,"avatar_url":"https://avatars.githubusercontent.com/u/2539563?v=3","gravatar_id":"","url":"https://api.github.com/users/meggart","html_url":"https://github.com/meggart","followers_url":"https://api.github.com/users/meggart/followers","following_url":"https://api.github.com/users/meggart/following{/other_user}","gists_url":"https://api.github.com/users/meggart/gists{/gist_id}","starred_url":"https://api.github.com/users/meggart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meggart/subscriptions","organizations_url":"https://api.github.com/users/meggart/orgs","repos_url":"https://api.github.com/users/meggart/repos","events_url":"https://api.github.com/users/meggart/events{/privacy}","received_events_url":"https://api.github.com/users/meggart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meggart/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/meggart/julia","forks_url":"https://api.github.com/repos/meggart/julia/forks","keys_url":"https://api.github.com/repos/meggart/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meggart/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meggart/julia/teams","hooks_url":"https://api.github.com/repos/meggart/julia/hooks","issue_events_url":"https://api.github.com/repos/meggart/julia/issues/events{/number}","events_url":"https://api.github.com/repos/meggart/julia/events","assignees_url":"https://api.github.com/repos/meggart/julia/assignees{/user}","branches_url":"https://api.github.com/repos/meggart/julia/branches{/branch}","tags_url":"https://api.github.com/repos/meggart/julia/tags","blobs_url":"https://api.github.com/repos/meggart/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meggart/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meggart/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/meggart/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meggart/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/meggart/julia/languages","stargazers_url":"https://api.github.com/repos/meggart/julia/stargazers","contributors_url":"https://api.github.com/repos/meggart/julia/contributors","subscribers_url":"https://api.github.com/repos/meggart/julia/subscribers","subscription_url":"https://api.github.com/repos/meggart/julia/subscription","commits_url":"https://api.github.com/repos/meggart/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/meggart/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/meggart/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/meggart/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/meggart/julia/contents/{+path}","compare_url":"https://api.github.com/repos/meggart/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meggart/julia/merges","archive_url":"https://api.github.com/repos/meggart/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meggart/julia/downloads","issues_url":"https://api.github.com/repos/meggart/julia/issues{/number}","pulls_url":"https://api.github.com/repos/meggart/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/meggart/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/meggart/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meggart/julia/labels{/name}","releases_url":"https://api.github.com/repos/meggart/julia/releases{/id}","deployments_url":"https://api.github.com/repos/meggart/julia/deployments","created_at":"2014-11-19T13:45:55Z","updated_at":"2014-11-19T13:46:00Z","pushed_at":"2016-03-14T13:29:56Z","git_url":"git://github.com/meggart/julia.git","ssh_url":"git@github.com:meggart/julia.git","clone_url":"https://github.com/meggart/julia.git","svn_url":"https://github.com/meggart/julia","homepage":"http://julialang.org/","size":93672,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"009dfd101273c0f62b16fe6f1ec14fa3529f9d5b","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-03-14T09:44:55Z","pushed_at":"2016-03-14T13:53:58Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":122626,"stargazers_count":6830,"watchers_count":6830,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1559,"mirror_url":null,"open_issues_count":1715,"forks":1559,"open_issues":1715,"watchers":6830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/15497"},"html":{"href":"https://github.com/JuliaLang/julia/pull/15497"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/15497"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/15497/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/15497/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/15497/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/1c4c93743ee99ba66284a07a99ae17b17d40d270"}}}}