{"push_id":1285811779,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"fd43b4b98dab6bdd565dad4a89e9baf341281f58","before":"27978e43e0901a0ecb13833f9987ae9522e94d24","commits":[{"sha":"2082aee94be65ebdcc86e5b6e667537564ac837b","author":{"name":"pfeldman","email":"235e260c3387232f567a0c5b9f55a964b6ec3b26@chromium.org"},"message":"Revert of DevTools: remove UISourceCodeFrame from context when switching panels. (patchset #2 id:20001 of https://codereview.chromium.org/2287713002/ )\n\nReason for revert:\nI'll have a better one for merge.\n\nOriginal issue's description:\n> DevTools: remove UISourceCodeFrame from context when switching panels.\n>\n> BUG=640375\n>\n> Committed: https://crrev.com/0cfac8a68fbabad4515c0a9f58c9e1dffd8c4a74\n> Cr-Commit-Position: refs/heads/master@{#415105}\n\nTBR=alph@chromium.org\n# Not skipping CQ checks because original CL landed more than 1 days ago.\nBUG=640375\n\nReview-Url: https://codereview.chromium.org/2311303002\nCr-Commit-Position: refs/heads/master@{#416753}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/2082aee94be65ebdcc86e5b6e667537564ac837b"},{"sha":"fd43b4b98dab6bdd565dad4a89e9baf341281f58","author":{"name":"maxbogue","email":"37fd2671d5e06787ef5883accc79b51049498e7a@chromium.org"},"message":"[Sync] Convert DTCs to be not RefCounted and NonThreadSafe.\n\nThis CL changes the sync DataTypeControllers to SupportWeakPtr instead\nof RefCountedDeleteOnMessageLoop, making them no longer thread safe.\n\n- DTCs are owned by the PSS map so they can no longer outlive PSS.\n- Remove the ui_thread parameter to DTC::ctors since it is no longer\n  needed by RefCountedDeleteOnMessageLoop or thread checks.\n- Add the type parameter to DTC::ctor since so many subclasses stored\n  it anyways; put it first because it's important.\n- All destructors become public.\n- All thread checks become DCHECK(CalledOnValidThread()); and many new\n  ones have been added.\n- All callbacks are bound with weakptrs to make them safe.\n- Remove the unused TypedUrlDataTypeController::SetBackend.\n- Remove NonBlockingDataTypeController::BelongsToUIThread and\n  ::RunOnUIThread as they are unnecessary.\n- Rename error_callback to dump_stack for clarity in the DTCs.\n\nThis CL also includes http://crrev.com/2269103003:\nSplitting error handling code out of DataTypeControllers.\n\n- Move DataTypeErrorHandler* to //components/sync/api\n- Add DataTypeErrorHandlerImpl\n- Add DataTypeController::CreateErrorHandler\n- Factor some shared logic out of DTCs into DTEHI\n- Pass DataTypeErrorHandler as a unique_ptr instead of raw pointer\n\nThese are going to be landed together because of a ref-cycle\nintroduced by the error handling change that the WeakPtr change fixes.\n\nBUG=638771\n\nReview-Url: https://codereview.chromium.org/2289143003\nCr-Commit-Position: refs/heads/master@{#416754}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/fd43b4b98dab6bdd565dad4a89e9baf341281f58"}]}
{"actor":{"display_login":"dstockwell"}}