{"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/89944338","pull_request_review_id":10471712,"id":89944338,"diff_hunk":"@@ -29,6 +29,7 @@ function version(){\n }\n \n function ver2num() {\n+  set -e","path":"paddle/scripts/submit_local.sh.in","position":4,"original_position":4,"commit_id":"1d8d9573225f44eb39a6af187b590b06d45dfb95","original_commit_id":"1d8d9573225f44eb39a6af187b590b06d45dfb95","user":{"login":"wangkuiyi","id":1548775,"avatar_url":"https://avatars.githubusercontent.com/u/1548775?v=3","gravatar_id":"","url":"https://api.github.com/users/wangkuiyi","html_url":"https://github.com/wangkuiyi","followers_url":"https://api.github.com/users/wangkuiyi/followers","following_url":"https://api.github.com/users/wangkuiyi/following{/other_user}","gists_url":"https://api.github.com/users/wangkuiyi/gists{/gist_id}","starred_url":"https://api.github.com/users/wangkuiyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangkuiyi/subscriptions","organizations_url":"https://api.github.com/users/wangkuiyi/orgs","repos_url":"https://api.github.com/users/wangkuiyi/repos","events_url":"https://api.github.com/users/wangkuiyi/events{/privacy}","received_events_url":"https://api.github.com/users/wangkuiyi/received_events","type":"User","site_admin":false},"body":"在cmake里写肯定不行啊。每个release branch里要改CMakeLists.txt文件里的编号。而且如果一旦写错了，又git push到remote去了，就几乎没法修改了。\r\n\r\n反过来，如果从git tag里derive，是标准的做法，也回避了上述潜在问题。目前的麻烦是，我们之前不应该假设tag一定是 v1.2.3的格式。在dockerhub.com里，有一个很聪明的方法来处理tag的各种形式——用户可以指定一个regexp，只有符合这个regexp的tag才被当做release tag。\r\n\r\n我们应该趁这个机会，删掉分散在我们各处源码中的不合理假设，而不能因陋就简呀。","created_at":"2016-11-29T05:43:55Z","updated_at":"2016-11-29T05:43:55Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/645#discussion_r89944338","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/645","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/89944338"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/645#discussion_r89944338"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/645","id":95620832,"html_url":"https://github.com/PaddlePaddle/Paddle/pull/645","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/645.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/645.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/645","number":645,"state":"open","locked":false,"title":"Add `set -e` for paddle boot up script.","user":{"login":"reyoung","id":728699,"avatar_url":"https://avatars.githubusercontent.com/u/728699?v=3","gravatar_id":"","url":"https://api.github.com/users/reyoung","html_url":"https://github.com/reyoung","followers_url":"https://api.github.com/users/reyoung/followers","following_url":"https://api.github.com/users/reyoung/following{/other_user}","gists_url":"https://api.github.com/users/reyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/reyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyoung/subscriptions","organizations_url":"https://api.github.com/users/reyoung/orgs","repos_url":"https://api.github.com/users/reyoung/repos","events_url":"https://api.github.com/users/reyoung/events{/privacy}","received_events_url":"https://api.github.com/users/reyoung/received_events","type":"User","site_admin":false},"body":"* error when paddle has a wrong version number.","created_at":"2016-11-29T03:34:22Z","updated_at":"2016-11-29T05:43:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cd052bbba1d5007dcef8fcd6d1db8ce2f189a0a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/645/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/645/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/645/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/1d8d9573225f44eb39a6af187b590b06d45dfb95","head":{"label":"reyoung:feature/improve_paddle_version_check","ref":"feature/improve_paddle_version_check","sha":"1d8d9573225f44eb39a6af187b590b06d45dfb95","user":{"login":"reyoung","id":728699,"avatar_url":"https://avatars.githubusercontent.com/u/728699?v=3","gravatar_id":"","url":"https://api.github.com/users/reyoung","html_url":"https://github.com/reyoung","followers_url":"https://api.github.com/users/reyoung/followers","following_url":"https://api.github.com/users/reyoung/following{/other_user}","gists_url":"https://api.github.com/users/reyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/reyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyoung/subscriptions","organizations_url":"https://api.github.com/users/reyoung/orgs","repos_url":"https://api.github.com/users/reyoung/repos","events_url":"https://api.github.com/users/reyoung/events{/privacy}","received_events_url":"https://api.github.com/users/reyoung/received_events","type":"User","site_admin":false},"repo":{"id":67185903,"name":"Paddle","full_name":"reyoung/Paddle","owner":{"login":"reyoung","id":728699,"avatar_url":"https://avatars.githubusercontent.com/u/728699?v=3","gravatar_id":"","url":"https://api.github.com/users/reyoung","html_url":"https://github.com/reyoung","followers_url":"https://api.github.com/users/reyoung/followers","following_url":"https://api.github.com/users/reyoung/following{/other_user}","gists_url":"https://api.github.com/users/reyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/reyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyoung/subscriptions","organizations_url":"https://api.github.com/users/reyoung/orgs","repos_url":"https://api.github.com/users/reyoung/repos","events_url":"https://api.github.com/users/reyoung/events{/privacy}","received_events_url":"https://api.github.com/users/reyoung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reyoung/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/reyoung/Paddle","forks_url":"https://api.github.com/repos/reyoung/Paddle/forks","keys_url":"https://api.github.com/repos/reyoung/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reyoung/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reyoung/Paddle/teams","hooks_url":"https://api.github.com/repos/reyoung/Paddle/hooks","issue_events_url":"https://api.github.com/repos/reyoung/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/reyoung/Paddle/events","assignees_url":"https://api.github.com/repos/reyoung/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/reyoung/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/reyoung/Paddle/tags","blobs_url":"https://api.github.com/repos/reyoung/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reyoung/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reyoung/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/reyoung/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reyoung/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/reyoung/Paddle/languages","stargazers_url":"https://api.github.com/repos/reyoung/Paddle/stargazers","contributors_url":"https://api.github.com/repos/reyoung/Paddle/contributors","subscribers_url":"https://api.github.com/repos/reyoung/Paddle/subscribers","subscription_url":"https://api.github.com/repos/reyoung/Paddle/subscription","commits_url":"https://api.github.com/repos/reyoung/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/reyoung/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/reyoung/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/reyoung/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/reyoung/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/reyoung/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reyoung/Paddle/merges","archive_url":"https://api.github.com/repos/reyoung/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reyoung/Paddle/downloads","issues_url":"https://api.github.com/repos/reyoung/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/reyoung/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/reyoung/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/reyoung/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reyoung/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/reyoung/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/reyoung/Paddle/deployments","created_at":"2016-09-02T03:14:43Z","updated_at":"2016-09-02T03:14:46Z","pushed_at":"2016-11-29T03:34:06Z","git_url":"git://github.com/reyoung/Paddle.git","ssh_url":"git@github.com:reyoung/Paddle.git","clone_url":"https://github.com/reyoung/Paddle.git","svn_url":"https://github.com/reyoung/Paddle","homepage":"http://www.paddlepaddle.org/","size":14866,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"fc32721f5c56438db941e1692b1351704265ba61","user":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars.githubusercontent.com/u/23534030?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"name":"Paddle","full_name":"PaddlePaddle/Paddle","owner":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars.githubusercontent.com/u/23534030?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2016-11-29T05:08:24Z","pushed_at":"2016-11-29T03:52:19Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"git@github.com:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":21475,"stargazers_count":3884,"watchers_count":3884,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":912,"mirror_url":null,"open_issues_count":118,"forks":912,"open_issues":118,"watchers":3884,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/645"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/645"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/645"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/1d8d9573225f44eb39a6af187b590b06d45dfb95"}}}}
{"actor":{"display_login":"wangkuiyi"}}