{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/nuclide/issues/891","repository_url":"https://api.github.com/repos/facebook/nuclide","labels_url":"https://api.github.com/repos/facebook/nuclide/issues/891/labels{/name}","comments_url":"https://api.github.com/repos/facebook/nuclide/issues/891/comments","events_url":"https://api.github.com/repos/facebook/nuclide/issues/891/events","html_url":"https://github.com/facebook/nuclide/pull/891","id":189441523,"number":891,"title":"Change RegExp dependency for url matching.","user":{"login":"Pangoraw","id":9824244,"avatar_url":"https://avatars.githubusercontent.com/u/9824244?v=3","gravatar_id":"","url":"https://api.github.com/users/Pangoraw","html_url":"https://github.com/Pangoraw","followers_url":"https://api.github.com/users/Pangoraw/followers","following_url":"https://api.github.com/users/Pangoraw/following{/other_user}","gists_url":"https://api.github.com/users/Pangoraw/gists{/gist_id}","starred_url":"https://api.github.com/users/Pangoraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pangoraw/subscriptions","organizations_url":"https://api.github.com/users/Pangoraw/orgs","repos_url":"https://api.github.com/users/Pangoraw/repos","events_url":"https://api.github.com/users/Pangoraw/events{/privacy}","received_events_url":"https://api.github.com/users/Pangoraw/received_events","type":"User","site_admin":false},"labels":[{"id":196858856,"url":"https://api.github.com/repos/facebook/nuclide/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-15T16:34:53Z","updated_at":"2016-11-16T18:38:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/nuclide/pulls/891","html_url":"https://github.com/facebook/nuclide/pull/891","diff_url":"https://github.com/facebook/nuclide/pull/891.diff","patch_url":"https://github.com/facebook/nuclide/pull/891.patch"},"body":"Hi,\r\nThe [current](https://www.npmjs.com/package/urlregexp) URL RegExp dependency doesn't find any url in text sample like `\"http://example.com\",` or if it does, it opens the URL `http://example.com\",` which is not what we want.\r\n\r\nSo instead of using this library which includes quotes in its matching (I don't know if it is a relevant feature), I replaced it with this [one](https://www.npmjs.com/package/url-regex)."},"comment":{"url":"https://api.github.com/repos/facebook/nuclide/issues/comments/261032628","html_url":"https://github.com/facebook/nuclide/pull/891#issuecomment-261032628","issue_url":"https://api.github.com/repos/facebook/nuclide/issues/891","id":261032628,"user":{"login":"nmote","id":7988361,"avatar_url":"https://avatars.githubusercontent.com/u/7988361?v=3","gravatar_id":"","url":"https://api.github.com/users/nmote","html_url":"https://github.com/nmote","followers_url":"https://api.github.com/users/nmote/followers","following_url":"https://api.github.com/users/nmote/following{/other_user}","gists_url":"https://api.github.com/users/nmote/gists{/gist_id}","starred_url":"https://api.github.com/users/nmote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmote/subscriptions","organizations_url":"https://api.github.com/users/nmote/orgs","repos_url":"https://api.github.com/users/nmote/repos","events_url":"https://api.github.com/users/nmote/events{/privacy}","received_events_url":"https://api.github.com/users/nmote/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T18:38:43Z","updated_at":"2016-11-16T18:38:43Z","body":"`urlregexp` already matches a ton of things that aren't likely to be URLs so I'm not too worried about that. As long as my inline comments are addressed I'm 👍."}}
{"actor":{"display_login":"nmote"}}