{"action":"created","issue":{"url":"https://api.github.com/repos/googlecartographer/cartographer/issues/37","repository_url":"https://api.github.com/repos/googlecartographer/cartographer","labels_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/37/comments","events_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/37/events","html_url":"https://github.com/googlecartographer/cartographer/pull/37","id":181513385,"number":37,"title":"fix #34: add Eigen::aligned_allocator to many necceary places","user":{"login":"catskul","id":375302,"avatar_url":"https://avatars.githubusercontent.com/u/375302?v=3","gravatar_id":"","url":"https://api.github.com/users/catskul","html_url":"https://github.com/catskul","followers_url":"https://api.github.com/users/catskul/followers","following_url":"https://api.github.com/users/catskul/following{/other_user}","gists_url":"https://api.github.com/users/catskul/gists{/gist_id}","starred_url":"https://api.github.com/users/catskul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catskul/subscriptions","organizations_url":"https://api.github.com/users/catskul/orgs","repos_url":"https://api.github.com/users/catskul/repos","events_url":"https://api.github.com/users/catskul/events{/privacy}","received_events_url":"https://api.github.com/users/catskul/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/googlecartographer/cartographer/labels/cla:%20no","name":"cla: no","color":"ee0701"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-06T20:10:54Z","updated_at":"2016-10-06T23:38:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/37","html_url":"https://github.com/googlecartographer/cartographer/pull/37","diff_url":"https://github.com/googlecartographer/cartographer/pull/37.diff","patch_url":"https://github.com/googlecartographer/cartographer/pull/37.patch"},"body":"Fixes #34 \r\n\r\nOnly handles those found by found by `grep -r \"std::\\w*<Eigen\"`\r\n\r\nbuilds and passes tests."},"comment":{"url":"https://api.github.com/repos/googlecartographer/cartographer/issues/comments/252117897","html_url":"https://github.com/googlecartographer/cartographer/pull/37#issuecomment-252117897","issue_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/37","id":252117897,"user":{"login":"catskul","id":375302,"avatar_url":"https://avatars.githubusercontent.com/u/375302?v=3","gravatar_id":"","url":"https://api.github.com/users/catskul","html_url":"https://github.com/catskul","followers_url":"https://api.github.com/users/catskul/followers","following_url":"https://api.github.com/users/catskul/following{/other_user}","gists_url":"https://api.github.com/users/catskul/gists{/gist_id}","starred_url":"https://api.github.com/users/catskul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catskul/subscriptions","organizations_url":"https://api.github.com/users/catskul/orgs","repos_url":"https://api.github.com/users/catskul/repos","events_url":"https://api.github.com/users/catskul/events{/privacy}","received_events_url":"https://api.github.com/users/catskul/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T23:38:24Z","updated_at":"2016-10-06T23:38:24Z","body":"Failing Travis CI build, though it works fine on my machine. \r\n\r\nInvestigating.\r\n\r\n```\r\nFAILED: /usr/bin/c++    -O3 -DNDEBUG -I. -I.. -isystem /usr/src/gmock/gtest/include -isystem /usr/include/eigen3 -isystem /usr/local/include -I../cartographer/common/{Boost_INCLUDE_DIRS} -isystem /usr/include/lua5.2     -O3 -DNDEBUG -std=c++11 -Wall -Wpedantic -Werror=format-security -Werror=return-type -Werror=uninitialized -MMD -MT cartographer/mapping_2d/CMakeFiles/mapping_2d_map_limits_test.dir/map_limits_test.cc.o -MF \"cartographer/mapping_2d/CMakeFiles/mapping_2d_map_limits_test.dir/map_limits_test.cc.o.d\" -o cartographer/mapping_2d/CMakeFiles/mapping_2d_map_limits_test.dir/map_limits_test.cc.o -c ../cartographer/mapping_2d/map_limits_test.cc\r\nIn file included from /usr/include/eigen3/Eigen/StdVector:23:0,\r\n                 from /usr/local/include/ceres/internal/numeric_diff.h:41,\r\n                 from /usr/local/include/ceres/dynamic_numeric_diff_cost_function.h:70,\r\n                 from /usr/local/include/ceres/ceres.h:44,\r\n                 from ../cartographer/common/math.h:25,\r\n                 from ../cartographer/mapping_2d/map_limits.h:25,\r\n                 from ../cartographer/mapping_2d/map_limits_test.cc:17:\r\n/usr/include/eigen3/Eigen/src/StlSupport/StdVector.h: In instantiation of 'std::vector<T, Eigen::aligned_allocator<T> >::vector(InputIterator, InputIterator, const allocator_type&) [with InputIterator = Eigen::Matrix<float, 2, 1>; T = Eigen::Matrix<float, 2, 1>; std::vector<T, Eigen::aligned_allocator<T> >::allocator_type = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]':\r\n../cartographer/mapping_2d/map_limits_test.cc:45:13:   required from here\r\n/usr/include/eigen3/Eigen/src/StlSupport/StdVector.h:75:3: error: no matching function for call to 'std::vector<Eigen::Matrix<float, 2, 1>, Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> > >::vector(Eigen::Matrix<float, 2, 1>&, Eigen::Matrix<float, 2, 1>&, const allocator_type&)'\r\n   EIGEN_STD_VECTOR_SPECIALIZATION_BODY\r\n   ^\r\n/usr/include/eigen3/Eigen/src/StlSupport/StdVector.h:75:3: note: candidates are:\r\nIn file included from /usr/include/c++/4.8/vector:64:0,\r\n                 from ../cartographer/mapping_2d/map_limits.h:21,\r\n                 from ../cartographer/mapping_2d/map_limits_test.cc:17:\r\n/usr/include/c++/4.8/bits/stl_vector.h:392:9: note: template<class _InputIterator, class> std::vector<_Tp, _Alloc>::vector(_InputIterator, _InputIterator, const allocator_type&)\r\n         vector(_InputIterator __first, _InputIterator __last,\r\n         ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:392:9: note:   template argument deduction/substitution failed:\r\n/usr/include/c++/4.8/bits/stl_vector.h:364:7: note: std::vector<_Tp, _Alloc>::vector(std::initializer_list<_Tp>, const allocator_type&) [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >; std::vector<_Tp, _Alloc>::allocator_type = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector(initializer_list<value_type> __l,\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:364:7: note:   candidate expects 2 arguments, 3 provided\r\n/usr/include/c++/4.8/bits/stl_vector.h:340:7: note: std::vector<_Tp, _Alloc>::vector(std::vector<_Tp, _Alloc>&&, const allocator_type&) [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >; std::vector<_Tp, _Alloc>::allocator_type = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector(vector&& __rv, const allocator_type& __m)\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:340:7: note:   candidate expects 2 arguments, 3 provided\r\n/usr/include/c++/4.8/bits/stl_vector.h:331:7: note: std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&, const allocator_type&) [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >; std::vector<_Tp, _Alloc>::allocator_type = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector(const vector& __x, const allocator_type& __a)\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:331:7: note:   candidate expects 2 arguments, 3 provided\r\n/usr/include/c++/4.8/bits/stl_vector.h:327:7: note: std::vector<_Tp, _Alloc>::vector(std::vector<_Tp, _Alloc>&&) [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector(vector&& __x) noexcept\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:327:7: note:   candidate expects 1 argument, 3 provided\r\n/usr/include/c++/4.8/bits/stl_vector.h:310:7: note: std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&) [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector(const vector& __x)\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:310:7: note:   candidate expects 1 argument, 3 provided\r\n/usr/include/c++/4.8/bits/stl_vector.h:281:7: note: std::vector<_Tp, _Alloc>::vector(std::vector<_Tp, _Alloc>::size_type, const value_type&, const allocator_type&) [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >; std::vector<_Tp, _Alloc>::size_type = long unsigned int; std::vector<_Tp, _Alloc>::value_type = Eigen::Matrix<float, 2, 1>; std::vector<_Tp, _Alloc>::allocator_type = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector(size_type __n, const value_type& __value,\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:281:7: note:   no known conversion for argument 1 from 'Eigen::Matrix<float, 2, 1>' to 'std::vector<Eigen::Matrix<float, 2, 1>, Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> > >::size_type {aka long unsigned int}'\r\n/usr/include/c++/4.8/bits/stl_vector.h:269:7: note: std::vector<_Tp, _Alloc>::vector(std::vector<_Tp, _Alloc>::size_type, const allocator_type&) [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >; std::vector<_Tp, _Alloc>::size_type = long unsigned int; std::vector<_Tp, _Alloc>::allocator_type = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector(size_type __n, const allocator_type& __a = allocator_type())\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:269:7: note:   candidate expects 2 arguments, 3 provided\r\n/usr/include/c++/4.8/bits/stl_vector.h:256:7: note: std::vector<_Tp, _Alloc>::vector(const allocator_type&) [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >; std::vector<_Tp, _Alloc>::allocator_type = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector(const allocator_type& __a)\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:256:7: note:   candidate expects 1 argument, 3 provided\r\n/usr/include/c++/4.8/bits/stl_vector.h:248:7: note: std::vector<_Tp, _Alloc>::vector() [with _Tp = Eigen::Matrix<float, 2, 1>; _Alloc = Eigen::aligned_allocator_indirection<Eigen::Matrix<float, 2, 1> >]\r\n       vector()\r\n       ^\r\n/usr/include/c++/4.8/bits/stl_vector.h:248:7: note:   candidate expects 0 arguments, 3 provided\r\nninja: build stopped: subcommand failed.\r\nThe command '/bin/sh -c cartographer/scripts/install_cartographer.sh && rm -rf cartographer' returned a non-zero code: 1\r\nThe command \"docker build ${TRAVIS_BUILD_DIR} -t cartographer\" exited with 1.\r\nDone. Your build exited with 1.\r\n```"}}
{"actor":{"display_login":"catskul"}}