{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/779","repository_url":"https://api.github.com/repos/Microsoft/msbuild","labels_url":"https://api.github.com/repos/Microsoft/msbuild/issues/779/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/779/comments","events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/779/events","html_url":"https://github.com/Microsoft/msbuild/pull/779","id":165451198,"number":779,"title":"Localized builds","user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/msbuild/labels/cla-already-signed","name":"cla-already-signed","color":"009800"},{"url":"https://api.github.com/repos/Microsoft/msbuild/labels/Needs%20Review","name":"Needs Review","color":"e6e6e6"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-14T00:27:59Z","updated_at":"2016-07-28T00:48:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/779","html_url":"https://github.com/Microsoft/msbuild/pull/779","diff_url":"https://github.com/Microsoft/msbuild/pull/779.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/779.patch"},"body":"- localized builds are enabled by setting the property `LocalizedBuild` to true\r\n- localization is done via Satellite Assemblies\r\n- localized resx files are generated on the fly in the intermediary output and not under version control\r\n- loc testing can be done by setting `LocalizedTestBuild` to true. This replaces all strings with `!{resource id}!{English resource}!{Translated resource}!`\r\n   - setting `LocalizedTestString` to some value replaces all resource strings with that value\r\n- CI does localized builds by default\r\n\r\nFuture work. I suggest doing these in future PRs:\r\n- xlab machines have a weird codepage set for their console (437, which is very USish). Because of that, [this method](https://github.com/Microsoft/msbuild/blob/f90dcff1db3b10c3b136bed1a23ce710f7c579cd/src/XMakeCommandLine/XMake.cs#L1216-L1247) resets the UI culture to en-US, which causes the English satellites to be picked up. I do not know whether normal windows installations have the same weird codepage. Contacted the world ready folks to ask them about that method, and what we should with it, if anything. To get localized satellites picked on xlab machines the workaround is doing `chcp 65001`\r\n- migrate xlf sync tasks to xliffparser repo\r\n- update our dependency to xliffparser when a new package is available, so we can use the `state=updated` xlf note for updated strings (as opposed to what happens now, where both new and updated resources get stamped with a \"new\" tag).\r\n\r\nTodo before merging:\r\n- [x] Write wiki on localization process and interaction with the localization team\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments/235765964","html_url":"https://github.com/Microsoft/msbuild/pull/779#issuecomment-235765964","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/779","id":235765964,"user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T00:48:07Z","updated_at":"2016-07-28T00:48:07Z","body":"Wrote localization documentation: https://github.com/Microsoft/msbuild/wiki/Dealing-With-Localization"}}
{"actor":{"display_login":"cdmihai"}}