{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/12344","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/12344/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12344/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/12344/events","html_url":"https://github.com/edx/edx-platform/pull/12344","id":152764375,"number":12344,"title":"Karma config improvements","user":{"login":"symbolist","id":5305552,"avatar_url":"https://avatars.githubusercontent.com/u/5305552?v=3","gravatar_id":"","url":"https://api.github.com/users/symbolist","html_url":"https://github.com/symbolist","followers_url":"https://api.github.com/users/symbolist/followers","following_url":"https://api.github.com/users/symbolist/following{/other_user}","gists_url":"https://api.github.com/users/symbolist/gists{/gist_id}","starred_url":"https://api.github.com/users/symbolist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symbolist/subscriptions","organizations_url":"https://api.github.com/users/symbolist/orgs","repos_url":"https://api.github.com/users/symbolist/repos","events_url":"https://api.github.com/users/symbolist/events{/privacy}","received_events_url":"https://api.github.com/users/symbolist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-03T12:44:43Z","updated_at":"2016-05-04T18:14:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12344","html_url":"https://github.com/edx/edx-platform/pull/12344","diff_url":"https://github.com/edx/edx-platform/pull/12344.diff","patch_url":"https://github.com/edx/edx-platform/pull/12344.patch"},"body":"https://openedx.atlassian.net/browse/TNL-4398\r\n\r\nThis PR contains the following changes:\r\n1. Moves all the logic from the individual Karma config files to `karma.common.conf.js`. The config files just declare a list of files now.\r\n2. When using RequireJS for running a suite, individual files do not need to be listed in the Karma config. If we just specify the directories, Karma will serve them correctly.\r\n3. Moves the jasmine addons to `common/js/spec_helpers` and if possible loads them via RequireJS before loading the spec files. Then the spec files can just assume those helpers exist. For suites which do not use RequireJS for running the specs, these addons are included via script tags in the html.\r\n4. Deletes the js-test-tool configuration files.\r\n5. Excludes the translation files from coverage tracking."},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/216953282","html_url":"https://github.com/edx/edx-platform/pull/12344#issuecomment-216953282","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12344","id":216953282,"user":{"login":"ehteshamkafeel","id":1213123,"avatar_url":"https://avatars.githubusercontent.com/u/1213123?v=3","gravatar_id":"","url":"https://api.github.com/users/ehteshamkafeel","html_url":"https://github.com/ehteshamkafeel","followers_url":"https://api.github.com/users/ehteshamkafeel/followers","following_url":"https://api.github.com/users/ehteshamkafeel/following{/other_user}","gists_url":"https://api.github.com/users/ehteshamkafeel/gists{/gist_id}","starred_url":"https://api.github.com/users/ehteshamkafeel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehteshamkafeel/subscriptions","organizations_url":"https://api.github.com/users/ehteshamkafeel/orgs","repos_url":"https://api.github.com/users/ehteshamkafeel/repos","events_url":"https://api.github.com/users/ehteshamkafeel/events{/privacy}","received_events_url":"https://api.github.com/users/ehteshamkafeel/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T18:14:05Z","updated_at":"2016-05-04T18:14:05Z","body":"@symbolist This looks great. Much cleaner no doubt. Just left few comments.\r\n\r\nInitially we decided to just copy files as is from `yml` files for karma config. The purpose to list individual files was that some files weren't needed for tests and they were included by karma. Of course there is no harm but using this pattern `js/**/*.js` crashed karma runner once."}}