{"action":"created","comment":{"url":"https://api.github.com/repos/attic-labs/noms/pulls/comments/86203338","pull_request_review_id":6873046,"id":86203338,"diff_hunk":"@@ -52,7 +53,8 @@ const readBatchOptions = {\n export default class HttpBatchStore extends RemoteBatchStore {\n   _rpc: RpcStrings;\n \n-  constructor(urlparam: string, maxReads: number = 5, fetchOptions: FetchOptions = {}) {\n+  constructor(","path":"js/noms/src/http-batch-store.js","position":13,"original_position":13,"commit_id":"f122b2de1c8214d1ae549efafd71af7c63482b4c","original_commit_id":"f122b2de1c8214d1ae549efafd71af7c63482b4c","user":{"login":"kalman","id":657134,"avatar_url":"https://avatars.githubusercontent.com/u/657134?v=3","gravatar_id":"","url":"https://api.github.com/users/kalman","html_url":"https://github.com/kalman","followers_url":"https://api.github.com/users/kalman/followers","following_url":"https://api.github.com/users/kalman/following{/other_user}","gists_url":"https://api.github.com/users/kalman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalman/subscriptions","organizations_url":"https://api.github.com/users/kalman/orgs","repos_url":"https://api.github.com/users/kalman/repos","events_url":"https://api.github.com/users/kalman/events{/privacy}","received_events_url":"https://api.github.com/users/kalman/received_events","type":"User","site_admin":false},"body":"Spec needs to set FetchOptions, and to pass that in it needs to pass through a maxReads value as well (just because of parameter ordering). This change is just exposing that `5` constant so that spec can pass in `5` itself.","created_at":"2016-11-02T17:51:54Z","updated_at":"2016-11-02T17:51:54Z","html_url":"https://github.com/attic-labs/noms/pull/2793#discussion_r86203338","pull_request_url":"https://api.github.com/repos/attic-labs/noms/pulls/2793","_links":{"self":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/comments/86203338"},"html":{"href":"https://github.com/attic-labs/noms/pull/2793#discussion_r86203338"},"pull_request":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2793"}}},"pull_request":{"url":"https://api.github.com/repos/attic-labs/noms/pulls/2793","id":91890498,"html_url":"https://github.com/attic-labs/noms/pull/2793","diff_url":"https://github.com/attic-labs/noms/pull/2793.diff","patch_url":"https://github.com/attic-labs/noms/pull/2793.patch","issue_url":"https://api.github.com/repos/attic-labs/noms/issues/2793","number":2793,"state":"open","locked":false,"title":"Noms, demo-server, and photos UI changes to support auth","user":{"login":"kalman","id":657134,"avatar_url":"https://avatars.githubusercontent.com/u/657134?v=3","gravatar_id":"","url":"https://api.github.com/users/kalman","html_url":"https://github.com/kalman","followers_url":"https://api.github.com/users/kalman/followers","following_url":"https://api.github.com/users/kalman/following{/other_user}","gists_url":"https://api.github.com/users/kalman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalman/subscriptions","organizations_url":"https://api.github.com/users/kalman/orgs","repos_url":"https://api.github.com/users/kalman/repos","events_url":"https://api.github.com/users/kalman/events{/privacy}","received_events_url":"https://api.github.com/users/kalman/received_events","type":"User","site_admin":false},"body":"The big change here is adding a new Spec class in spec.js. This replaces\r\nDatabaseSpec/DatasetSpec/PathSpec in specs.js, but I'm leaving those in\r\nand moving code over in a later patch. For now, only photos UI.\r\n\r\nThe photos UI change is to plumb through the authorization token through\r\nthe Spec code. For now, it's reading it from a URL parameter, but soon\r\nI'll make it session based (probably localStorage).\r\n\r\nThe demo-server change is to add the Authorization header into CORS.","created_at":"2016-11-02T00:33:20Z","updated_at":"2016-11-02T17:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c6569070e96c86e88548763365d0392eb097eec","assignee":{"login":"willhite","id":487362,"avatar_url":"https://avatars.githubusercontent.com/u/487362?v=3","gravatar_id":"","url":"https://api.github.com/users/willhite","html_url":"https://github.com/willhite","followers_url":"https://api.github.com/users/willhite/followers","following_url":"https://api.github.com/users/willhite/following{/other_user}","gists_url":"https://api.github.com/users/willhite/gists{/gist_id}","starred_url":"https://api.github.com/users/willhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhite/subscriptions","organizations_url":"https://api.github.com/users/willhite/orgs","repos_url":"https://api.github.com/users/willhite/repos","events_url":"https://api.github.com/users/willhite/events{/privacy}","received_events_url":"https://api.github.com/users/willhite/received_events","type":"User","site_admin":false},"assignees":[{"login":"willhite","id":487362,"avatar_url":"https://avatars.githubusercontent.com/u/487362?v=3","gravatar_id":"","url":"https://api.github.com/users/willhite","html_url":"https://github.com/willhite","followers_url":"https://api.github.com/users/willhite/followers","following_url":"https://api.github.com/users/willhite/following{/other_user}","gists_url":"https://api.github.com/users/willhite/gists{/gist_id}","starred_url":"https://api.github.com/users/willhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhite/subscriptions","organizations_url":"https://api.github.com/users/willhite/orgs","repos_url":"https://api.github.com/users/willhite/repos","events_url":"https://api.github.com/users/willhite/events{/privacy}","received_events_url":"https://api.github.com/users/willhite/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/attic-labs/noms/pulls/2793/commits","review_comments_url":"https://api.github.com/repos/attic-labs/noms/pulls/2793/comments","review_comment_url":"https://api.github.com/repos/attic-labs/noms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/attic-labs/noms/issues/2793/comments","statuses_url":"https://api.github.com/repos/attic-labs/noms/statuses/f122b2de1c8214d1ae549efafd71af7c63482b4c","head":{"label":"kalman:path-auth","ref":"path-auth","sha":"f122b2de1c8214d1ae549efafd71af7c63482b4c","user":{"login":"kalman","id":657134,"avatar_url":"https://avatars.githubusercontent.com/u/657134?v=3","gravatar_id":"","url":"https://api.github.com/users/kalman","html_url":"https://github.com/kalman","followers_url":"https://api.github.com/users/kalman/followers","following_url":"https://api.github.com/users/kalman/following{/other_user}","gists_url":"https://api.github.com/users/kalman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalman/subscriptions","organizations_url":"https://api.github.com/users/kalman/orgs","repos_url":"https://api.github.com/users/kalman/repos","events_url":"https://api.github.com/users/kalman/events{/privacy}","received_events_url":"https://api.github.com/users/kalman/received_events","type":"User","site_admin":false},"repo":{"id":64782667,"name":"noms","full_name":"kalman/noms","owner":{"login":"kalman","id":657134,"avatar_url":"https://avatars.githubusercontent.com/u/657134?v=3","gravatar_id":"","url":"https://api.github.com/users/kalman","html_url":"https://github.com/kalman","followers_url":"https://api.github.com/users/kalman/followers","following_url":"https://api.github.com/users/kalman/following{/other_user}","gists_url":"https://api.github.com/users/kalman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalman/subscriptions","organizations_url":"https://api.github.com/users/kalman/orgs","repos_url":"https://api.github.com/users/kalman/repos","events_url":"https://api.github.com/users/kalman/events{/privacy}","received_events_url":"https://api.github.com/users/kalman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalman/noms","description":"The versioned, forkable, syncable database","fork":true,"url":"https://api.github.com/repos/kalman/noms","forks_url":"https://api.github.com/repos/kalman/noms/forks","keys_url":"https://api.github.com/repos/kalman/noms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalman/noms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalman/noms/teams","hooks_url":"https://api.github.com/repos/kalman/noms/hooks","issue_events_url":"https://api.github.com/repos/kalman/noms/issues/events{/number}","events_url":"https://api.github.com/repos/kalman/noms/events","assignees_url":"https://api.github.com/repos/kalman/noms/assignees{/user}","branches_url":"https://api.github.com/repos/kalman/noms/branches{/branch}","tags_url":"https://api.github.com/repos/kalman/noms/tags","blobs_url":"https://api.github.com/repos/kalman/noms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalman/noms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalman/noms/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalman/noms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalman/noms/statuses/{sha}","languages_url":"https://api.github.com/repos/kalman/noms/languages","stargazers_url":"https://api.github.com/repos/kalman/noms/stargazers","contributors_url":"https://api.github.com/repos/kalman/noms/contributors","subscribers_url":"https://api.github.com/repos/kalman/noms/subscribers","subscription_url":"https://api.github.com/repos/kalman/noms/subscription","commits_url":"https://api.github.com/repos/kalman/noms/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalman/noms/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalman/noms/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalman/noms/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalman/noms/contents/{+path}","compare_url":"https://api.github.com/repos/kalman/noms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalman/noms/merges","archive_url":"https://api.github.com/repos/kalman/noms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalman/noms/downloads","issues_url":"https://api.github.com/repos/kalman/noms/issues{/number}","pulls_url":"https://api.github.com/repos/kalman/noms/pulls{/number}","milestones_url":"https://api.github.com/repos/kalman/noms/milestones{/number}","notifications_url":"https://api.github.com/repos/kalman/noms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalman/noms/labels{/name}","releases_url":"https://api.github.com/repos/kalman/noms/releases{/id}","deployments_url":"https://api.github.com/repos/kalman/noms/deployments","created_at":"2016-08-02T18:36:44Z","updated_at":"2016-08-02T18:36:46Z","pushed_at":"2016-11-02T00:33:10Z","git_url":"git://github.com/kalman/noms.git","ssh_url":"git@github.com:kalman/noms.git","clone_url":"https://github.com/kalman/noms.git","svn_url":"https://github.com/kalman/noms","homepage":"","size":27742,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"attic-labs:master","ref":"master","sha":"bbfc27d7fe487269d37c7729d8d864f7bbb28640","user":{"login":"attic-labs","id":12534679,"avatar_url":"https://avatars.githubusercontent.com/u/12534679?v=3","gravatar_id":"","url":"https://api.github.com/users/attic-labs","html_url":"https://github.com/attic-labs","followers_url":"https://api.github.com/users/attic-labs/followers","following_url":"https://api.github.com/users/attic-labs/following{/other_user}","gists_url":"https://api.github.com/users/attic-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/attic-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attic-labs/subscriptions","organizations_url":"https://api.github.com/users/attic-labs/orgs","repos_url":"https://api.github.com/users/attic-labs/repos","events_url":"https://api.github.com/users/attic-labs/events{/privacy}","received_events_url":"https://api.github.com/users/attic-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":36778364,"name":"noms","full_name":"attic-labs/noms","owner":{"login":"attic-labs","id":12534679,"avatar_url":"https://avatars.githubusercontent.com/u/12534679?v=3","gravatar_id":"","url":"https://api.github.com/users/attic-labs","html_url":"https://github.com/attic-labs","followers_url":"https://api.github.com/users/attic-labs/followers","following_url":"https://api.github.com/users/attic-labs/following{/other_user}","gists_url":"https://api.github.com/users/attic-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/attic-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attic-labs/subscriptions","organizations_url":"https://api.github.com/users/attic-labs/orgs","repos_url":"https://api.github.com/users/attic-labs/repos","events_url":"https://api.github.com/users/attic-labs/events{/privacy}","received_events_url":"https://api.github.com/users/attic-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/attic-labs/noms","description":"The versioned, forkable, syncable database","fork":false,"url":"https://api.github.com/repos/attic-labs/noms","forks_url":"https://api.github.com/repos/attic-labs/noms/forks","keys_url":"https://api.github.com/repos/attic-labs/noms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/attic-labs/noms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/attic-labs/noms/teams","hooks_url":"https://api.github.com/repos/attic-labs/noms/hooks","issue_events_url":"https://api.github.com/repos/attic-labs/noms/issues/events{/number}","events_url":"https://api.github.com/repos/attic-labs/noms/events","assignees_url":"https://api.github.com/repos/attic-labs/noms/assignees{/user}","branches_url":"https://api.github.com/repos/attic-labs/noms/branches{/branch}","tags_url":"https://api.github.com/repos/attic-labs/noms/tags","blobs_url":"https://api.github.com/repos/attic-labs/noms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/attic-labs/noms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/attic-labs/noms/git/refs{/sha}","trees_url":"https://api.github.com/repos/attic-labs/noms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/attic-labs/noms/statuses/{sha}","languages_url":"https://api.github.com/repos/attic-labs/noms/languages","stargazers_url":"https://api.github.com/repos/attic-labs/noms/stargazers","contributors_url":"https://api.github.com/repos/attic-labs/noms/contributors","subscribers_url":"https://api.github.com/repos/attic-labs/noms/subscribers","subscription_url":"https://api.github.com/repos/attic-labs/noms/subscription","commits_url":"https://api.github.com/repos/attic-labs/noms/commits{/sha}","git_commits_url":"https://api.github.com/repos/attic-labs/noms/git/commits{/sha}","comments_url":"https://api.github.com/repos/attic-labs/noms/comments{/number}","issue_comment_url":"https://api.github.com/repos/attic-labs/noms/issues/comments{/number}","contents_url":"https://api.github.com/repos/attic-labs/noms/contents/{+path}","compare_url":"https://api.github.com/repos/attic-labs/noms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/attic-labs/noms/merges","archive_url":"https://api.github.com/repos/attic-labs/noms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/attic-labs/noms/downloads","issues_url":"https://api.github.com/repos/attic-labs/noms/issues{/number}","pulls_url":"https://api.github.com/repos/attic-labs/noms/pulls{/number}","milestones_url":"https://api.github.com/repos/attic-labs/noms/milestones{/number}","notifications_url":"https://api.github.com/repos/attic-labs/noms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/attic-labs/noms/labels{/name}","releases_url":"https://api.github.com/repos/attic-labs/noms/releases{/id}","deployments_url":"https://api.github.com/repos/attic-labs/noms/deployments","created_at":"2015-06-03T03:44:49Z","updated_at":"2016-11-02T16:30:37Z","pushed_at":"2016-11-02T16:47:27Z","git_url":"git://github.com/attic-labs/noms.git","ssh_url":"git@github.com:attic-labs/noms.git","clone_url":"https://github.com/attic-labs/noms.git","svn_url":"https://github.com/attic-labs/noms","homepage":"","size":40274,"stargazers_count":5789,"watchers_count":5789,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":239,"forks":166,"open_issues":239,"watchers":5789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2793"},"html":{"href":"https://github.com/attic-labs/noms/pull/2793"},"issue":{"href":"https://api.github.com/repos/attic-labs/noms/issues/2793"},"comments":{"href":"https://api.github.com/repos/attic-labs/noms/issues/2793/comments"},"review_comments":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2793/comments"},"review_comment":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2793/commits"},"statuses":{"href":"https://api.github.com/repos/attic-labs/noms/statuses/f122b2de1c8214d1ae549efafd71af7c63482b4c"}}}}
{"actor":{"display_login":"kalman"}}