{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls/13","id":68798650,"html_url":"https://github.com/ztan-echo360/EchoLink-Moodle-Plugin/pull/13","diff_url":"https://github.com/ztan-echo360/EchoLink-Moodle-Plugin/pull/13.diff","patch_url":"https://github.com/ztan-echo360/EchoLink-Moodle-Plugin/pull/13.patch","issue_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/issues/13","number":13,"state":"closed","locked":false,"title":"Converting globals to constants","user":{"login":"donkeyx","id":132504,"avatar_url":"https://avatars.githubusercontent.com/u/132504?v=3","gravatar_id":"","url":"https://api.github.com/users/donkeyx","html_url":"https://github.com/donkeyx","followers_url":"https://api.github.com/users/donkeyx/followers","following_url":"https://api.github.com/users/donkeyx/following{/other_user}","gists_url":"https://api.github.com/users/donkeyx/gists{/gist_id}","starred_url":"https://api.github.com/users/donkeyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donkeyx/subscriptions","organizations_url":"https://api.github.com/users/donkeyx/orgs","repos_url":"https://api.github.com/users/donkeyx/repos","events_url":"https://api.github.com/users/donkeyx/events{/privacy}","received_events_url":"https://api.github.com/users/donkeyx/received_events","type":"User","site_admin":false},"body":"There have been ongoing issues with random, but consistent missing global variables. Basically for some users, the globals referenced in the locallib would become \"unset\". I have no idea what was causing this or why it was so random, but the solution was to use constants. This makes it a little more consistent with other moodle modules as well. ","created_at":"2016-05-04T01:00:53Z","updated_at":"2016-05-04T04:46:28Z","closed_at":"2016-05-04T04:46:28Z","merged_at":"2016-05-04T04:46:28Z","merge_commit_sha":"e919544bc47d0b3085f0ac5897ce30453f54a0e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls/13/commits","review_comments_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls/13/comments","review_comment_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/issues/13/comments","statuses_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/statuses/081ac4bd21949be259d36c7a3cbf986a0c783360","head":{"label":"central-queensland-uni:global_errors","ref":"global_errors","sha":"081ac4bd21949be259d36c7a3cbf986a0c783360","user":{"login":"central-queensland-uni","id":10123861,"avatar_url":"https://avatars.githubusercontent.com/u/10123861?v=3","gravatar_id":"","url":"https://api.github.com/users/central-queensland-uni","html_url":"https://github.com/central-queensland-uni","followers_url":"https://api.github.com/users/central-queensland-uni/followers","following_url":"https://api.github.com/users/central-queensland-uni/following{/other_user}","gists_url":"https://api.github.com/users/central-queensland-uni/gists{/gist_id}","starred_url":"https://api.github.com/users/central-queensland-uni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/central-queensland-uni/subscriptions","organizations_url":"https://api.github.com/users/central-queensland-uni/orgs","repos_url":"https://api.github.com/users/central-queensland-uni/repos","events_url":"https://api.github.com/users/central-queensland-uni/events{/privacy}","received_events_url":"https://api.github.com/users/central-queensland-uni/received_events","type":"Organization","site_admin":false},"repo":{"id":40529023,"name":"EchoLink-Moodle-Plugin","full_name":"central-queensland-uni/EchoLink-Moodle-Plugin","owner":{"login":"central-queensland-uni","id":10123861,"avatar_url":"https://avatars.githubusercontent.com/u/10123861?v=3","gravatar_id":"","url":"https://api.github.com/users/central-queensland-uni","html_url":"https://github.com/central-queensland-uni","followers_url":"https://api.github.com/users/central-queensland-uni/followers","following_url":"https://api.github.com/users/central-queensland-uni/following{/other_user}","gists_url":"https://api.github.com/users/central-queensland-uni/gists{/gist_id}","starred_url":"https://api.github.com/users/central-queensland-uni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/central-queensland-uni/subscriptions","organizations_url":"https://api.github.com/users/central-queensland-uni/orgs","repos_url":"https://api.github.com/users/central-queensland-uni/repos","events_url":"https://api.github.com/users/central-queensland-uni/events{/privacy}","received_events_url":"https://api.github.com/users/central-queensland-uni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/central-queensland-uni/EchoLink-Moodle-Plugin","description":"Echo360 Moodle Plugin to support end-user linkage of Echo360 content in Moodle LMS.","fork":true,"url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin","forks_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/forks","keys_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/teams","hooks_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/hooks","issue_events_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/issues/events{/number}","events_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/events","assignees_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/assignees{/user}","branches_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/branches{/branch}","tags_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/tags","blobs_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/languages","stargazers_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/stargazers","contributors_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/contributors","subscribers_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/subscribers","subscription_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/subscription","commits_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/contents/{+path}","compare_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/merges","archive_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/downloads","issues_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/issues{/number}","pulls_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/labels{/name}","releases_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/releases{/id}","deployments_url":"https://api.github.com/repos/central-queensland-uni/EchoLink-Moodle-Plugin/deployments","created_at":"2015-08-11T07:53:56Z","updated_at":"2016-05-04T00:34:46Z","pushed_at":"2016-05-04T00:56:17Z","git_url":"git://github.com/central-queensland-uni/EchoLink-Moodle-Plugin.git","ssh_url":"git@github.com:central-queensland-uni/EchoLink-Moodle-Plugin.git","clone_url":"https://github.com/central-queensland-uni/EchoLink-Moodle-Plugin.git","svn_url":"https://github.com/central-queensland-uni/EchoLink-Moodle-Plugin","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ztan-echo360:master","ref":"master","sha":"4c4528a7309ffa1b29765cb4a977fa91c4dde371","user":{"login":"ztan-echo360","id":4453912,"avatar_url":"https://avatars.githubusercontent.com/u/4453912?v=3","gravatar_id":"","url":"https://api.github.com/users/ztan-echo360","html_url":"https://github.com/ztan-echo360","followers_url":"https://api.github.com/users/ztan-echo360/followers","following_url":"https://api.github.com/users/ztan-echo360/following{/other_user}","gists_url":"https://api.github.com/users/ztan-echo360/gists{/gist_id}","starred_url":"https://api.github.com/users/ztan-echo360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztan-echo360/subscriptions","organizations_url":"https://api.github.com/users/ztan-echo360/orgs","repos_url":"https://api.github.com/users/ztan-echo360/repos","events_url":"https://api.github.com/users/ztan-echo360/events{/privacy}","received_events_url":"https://api.github.com/users/ztan-echo360/received_events","type":"User","site_admin":false},"repo":{"id":16089962,"name":"EchoLink-Moodle-Plugin","full_name":"ztan-echo360/EchoLink-Moodle-Plugin","owner":{"login":"ztan-echo360","id":4453912,"avatar_url":"https://avatars.githubusercontent.com/u/4453912?v=3","gravatar_id":"","url":"https://api.github.com/users/ztan-echo360","html_url":"https://github.com/ztan-echo360","followers_url":"https://api.github.com/users/ztan-echo360/followers","following_url":"https://api.github.com/users/ztan-echo360/following{/other_user}","gists_url":"https://api.github.com/users/ztan-echo360/gists{/gist_id}","starred_url":"https://api.github.com/users/ztan-echo360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztan-echo360/subscriptions","organizations_url":"https://api.github.com/users/ztan-echo360/orgs","repos_url":"https://api.github.com/users/ztan-echo360/repos","events_url":"https://api.github.com/users/ztan-echo360/events{/privacy}","received_events_url":"https://api.github.com/users/ztan-echo360/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ztan-echo360/EchoLink-Moodle-Plugin","description":"Echo360 Moodle Plugin to support end-user linkage of Echo360 content in Moodle LMS.","fork":false,"url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin","forks_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/forks","keys_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/teams","hooks_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/hooks","issue_events_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/events","assignees_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/tags","blobs_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/languages","stargazers_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/stargazers","contributors_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/contributors","subscribers_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/subscribers","subscription_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/subscription","commits_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/merges","archive_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/downloads","issues_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/labels{/name}","releases_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/releases{/id}","deployments_url":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/deployments","created_at":"2014-01-21T02:08:14Z","updated_at":"2016-02-10T02:10:25Z","pushed_at":"2016-05-04T04:46:28Z","git_url":"git://github.com/ztan-echo360/EchoLink-Moodle-Plugin.git","ssh_url":"git@github.com:ztan-echo360/EchoLink-Moodle-Plugin.git","clone_url":"https://github.com/ztan-echo360/EchoLink-Moodle-Plugin.git","svn_url":"https://github.com/ztan-echo360/EchoLink-Moodle-Plugin","homepage":null,"size":159,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls/13"},"html":{"href":"https://github.com/ztan-echo360/EchoLink-Moodle-Plugin/pull/13"},"issue":{"href":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/issues/13"},"comments":{"href":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/ztan-echo360/EchoLink-Moodle-Plugin/statuses/081ac4bd21949be259d36c7a3cbf986a0c783360"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ztan-echo360","id":4453912,"avatar_url":"https://avatars.githubusercontent.com/u/4453912?v=3","gravatar_id":"","url":"https://api.github.com/users/ztan-echo360","html_url":"https://github.com/ztan-echo360","followers_url":"https://api.github.com/users/ztan-echo360/followers","following_url":"https://api.github.com/users/ztan-echo360/following{/other_user}","gists_url":"https://api.github.com/users/ztan-echo360/gists{/gist_id}","starred_url":"https://api.github.com/users/ztan-echo360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztan-echo360/subscriptions","organizations_url":"https://api.github.com/users/ztan-echo360/orgs","repos_url":"https://api.github.com/users/ztan-echo360/repos","events_url":"https://api.github.com/users/ztan-echo360/events{/privacy}","received_events_url":"https://api.github.com/users/ztan-echo360/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":18,"deletions":25,"changed_files":1}}