{"action":"created","comment":{"url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/comments/89129093","pull_request_review_id":9677801,"id":89129093,"diff_hunk":"@@ -18,20 +18,22 @@ def call_file_on_server(filename, server)\n           web_server_port = domain_scheme == 'https' ? 443 : 80\n           # Use server configuration, if exists\n           web_server_port = server.fetch(:web_server_port) if server.properties.respond_to?(:web_server_port)\n+          ssl_verify_mode = server.properties.respond_to?(:ssl_verify_mode) ? server.fetch(:ssl_verify_mode) : OpenSSL::SSL::VERIFY_PEER\n \n           url = URI.parse(\"#{domain_scheme}://#{domain}\").merge(\"/#{filename}\")\n           url.port = web_server_port\n           info \"Call URL #{url}\"\n \n-          http_get_with_redirect url\n+          http_get_with_redirect url: url, verify_mode: ssl_verify_mode\n         end\n \n         # Sends a get request that handles redirects\n         #\n         # @param url [URI]\n         # @param limit [Integer] defines how many redirects are allowed\n+        # @param verify_mode [OpenSSL::SSL::verify_mode] ssl verify mode, setting to VERIFY_NONE disables certificate check\n         # @return [NET::HTTPResponse]\n-        def http_get_with_redirect(url, limit = 5)\n+        def http_get_with_redirect(url:, limit: 5, verify_mode: OpenSSL::SSL::VERIFY_PEER)","path":"lib/dkdeploy/php/helpers/http.rb","position":21,"original_position":21,"commit_id":"3e7d03a6c9c6f9bfd73f5f90d870fdaefe6ee656","original_commit_id":"3e7d03a6c9c6f9bfd73f5f90d870fdaefe6ee656","user":{"login":"klyonrad","id":1453955,"avatar_url":"https://avatars.githubusercontent.com/u/1453955?v=3","gravatar_id":"","url":"https://api.github.com/users/klyonrad","html_url":"https://github.com/klyonrad","followers_url":"https://api.github.com/users/klyonrad/followers","following_url":"https://api.github.com/users/klyonrad/following{/other_user}","gists_url":"https://api.github.com/users/klyonrad/gists{/gist_id}","starred_url":"https://api.github.com/users/klyonrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klyonrad/subscriptions","organizations_url":"https://api.github.com/users/klyonrad/orgs","repos_url":"https://api.github.com/users/klyonrad/repos","events_url":"https://api.github.com/users/klyonrad/events{/privacy}","received_events_url":"https://api.github.com/users/klyonrad/received_events","type":"User","site_admin":false},"body":"Uhm yes, breaking, I documented that in the changelog in the section _Changed_","created_at":"2016-11-22T14:43:59Z","updated_at":"2016-11-22T14:43:59Z","html_url":"https://github.com/dkdeploy/dkdeploy-php/pull/5#discussion_r89129093","pull_request_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/comments/89129093"},"html":{"href":"https://github.com/dkdeploy/dkdeploy-php/pull/5#discussion_r89129093"},"pull_request":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/5","id":89801241,"html_url":"https://github.com/dkdeploy/dkdeploy-php/pull/5","diff_url":"https://github.com/dkdeploy/dkdeploy-php/pull/5.diff","patch_url":"https://github.com/dkdeploy/dkdeploy-php/pull/5.patch","issue_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/issues/5","number":5,"state":"open","locked":false,"title":"Enable SSL certificate check in http helper","user":{"login":"klyonrad","id":1453955,"avatar_url":"https://avatars.githubusercontent.com/u/1453955?v=3","gravatar_id":"","url":"https://api.github.com/users/klyonrad","html_url":"https://github.com/klyonrad","followers_url":"https://api.github.com/users/klyonrad/followers","following_url":"https://api.github.com/users/klyonrad/following{/other_user}","gists_url":"https://api.github.com/users/klyonrad/gists{/gist_id}","starred_url":"https://api.github.com/users/klyonrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klyonrad/subscriptions","organizations_url":"https://api.github.com/users/klyonrad/orgs","repos_url":"https://api.github.com/users/klyonrad/repos","events_url":"https://api.github.com/users/klyonrad/events{/privacy}","received_events_url":"https://api.github.com/users/klyonrad/received_events","type":"User","site_admin":false},"body":"# Summary\n\nThis removes bypassing the SSL certificate check in the custom http helper.\n# Test Plan\n- `vagrant provision`\n- `cucumber`\n","created_at":"2016-10-18T12:04:19Z","updated_at":"2016-11-22T14:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9be57d3c1751014ae94debab4a6d207ee743750f","assignee":{"login":"websi","id":2857262,"avatar_url":"https://avatars.githubusercontent.com/u/2857262?v=3","gravatar_id":"","url":"https://api.github.com/users/websi","html_url":"https://github.com/websi","followers_url":"https://api.github.com/users/websi/followers","following_url":"https://api.github.com/users/websi/following{/other_user}","gists_url":"https://api.github.com/users/websi/gists{/gist_id}","starred_url":"https://api.github.com/users/websi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/websi/subscriptions","organizations_url":"https://api.github.com/users/websi/orgs","repos_url":"https://api.github.com/users/websi/repos","events_url":"https://api.github.com/users/websi/events{/privacy}","received_events_url":"https://api.github.com/users/websi/received_events","type":"User","site_admin":false},"assignees":[{"login":"websi","id":2857262,"avatar_url":"https://avatars.githubusercontent.com/u/2857262?v=3","gravatar_id":"","url":"https://api.github.com/users/websi","html_url":"https://github.com/websi","followers_url":"https://api.github.com/users/websi/followers","following_url":"https://api.github.com/users/websi/following{/other_user}","gists_url":"https://api.github.com/users/websi/gists{/gist_id}","starred_url":"https://api.github.com/users/websi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/websi/subscriptions","organizations_url":"https://api.github.com/users/websi/orgs","repos_url":"https://api.github.com/users/websi/repos","events_url":"https://api.github.com/users/websi/events{/privacy}","received_events_url":"https://api.github.com/users/websi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/5/commits","review_comments_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/5/comments","review_comment_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/issues/5/comments","statuses_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/statuses/3e7d03a6c9c6f9bfd73f5f90d870fdaefe6ee656","head":{"label":"klyonrad:feature/ssl-security-in-http-helper","ref":"feature/ssl-security-in-http-helper","sha":"3e7d03a6c9c6f9bfd73f5f90d870fdaefe6ee656","user":{"login":"klyonrad","id":1453955,"avatar_url":"https://avatars.githubusercontent.com/u/1453955?v=3","gravatar_id":"","url":"https://api.github.com/users/klyonrad","html_url":"https://github.com/klyonrad","followers_url":"https://api.github.com/users/klyonrad/followers","following_url":"https://api.github.com/users/klyonrad/following{/other_user}","gists_url":"https://api.github.com/users/klyonrad/gists{/gist_id}","starred_url":"https://api.github.com/users/klyonrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klyonrad/subscriptions","organizations_url":"https://api.github.com/users/klyonrad/orgs","repos_url":"https://api.github.com/users/klyonrad/repos","events_url":"https://api.github.com/users/klyonrad/events{/privacy}","received_events_url":"https://api.github.com/users/klyonrad/received_events","type":"User","site_admin":false},"repo":{"id":63256876,"name":"dkdeploy-php","full_name":"klyonrad/dkdeploy-php","owner":{"login":"klyonrad","id":1453955,"avatar_url":"https://avatars.githubusercontent.com/u/1453955?v=3","gravatar_id":"","url":"https://api.github.com/users/klyonrad","html_url":"https://github.com/klyonrad","followers_url":"https://api.github.com/users/klyonrad/followers","following_url":"https://api.github.com/users/klyonrad/following{/other_user}","gists_url":"https://api.github.com/users/klyonrad/gists{/gist_id}","starred_url":"https://api.github.com/users/klyonrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klyonrad/subscriptions","organizations_url":"https://api.github.com/users/klyonrad/orgs","repos_url":"https://api.github.com/users/klyonrad/repos","events_url":"https://api.github.com/users/klyonrad/events{/privacy}","received_events_url":"https://api.github.com/users/klyonrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klyonrad/dkdeploy-php","description":"Capistrano extension for advanced PHP deployments","fork":true,"url":"https://api.github.com/repos/klyonrad/dkdeploy-php","forks_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/forks","keys_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/teams","hooks_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/hooks","issue_events_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/issues/events{/number}","events_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/events","assignees_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/assignees{/user}","branches_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/branches{/branch}","tags_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/tags","blobs_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/statuses/{sha}","languages_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/languages","stargazers_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/stargazers","contributors_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/contributors","subscribers_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/subscribers","subscription_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/subscription","commits_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/contents/{+path}","compare_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/merges","archive_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/downloads","issues_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/issues{/number}","pulls_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/pulls{/number}","milestones_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/milestones{/number}","notifications_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/labels{/name}","releases_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/releases{/id}","deployments_url":"https://api.github.com/repos/klyonrad/dkdeploy-php/deployments","created_at":"2016-07-13T15:16:00Z","updated_at":"2016-07-13T15:16:01Z","pushed_at":"2016-11-04T12:22:12Z","git_url":"git://github.com/klyonrad/dkdeploy-php.git","ssh_url":"git@github.com:klyonrad/dkdeploy-php.git","clone_url":"https://github.com/klyonrad/dkdeploy-php.git","svn_url":"https://github.com/klyonrad/dkdeploy-php","homepage":"","size":1017,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dkdeploy:develop","ref":"develop","sha":"0322268cf4ade57bdc627093407e83bd434b6095","user":{"login":"dkdeploy","id":19567849,"avatar_url":"https://avatars.githubusercontent.com/u/19567849?v=3","gravatar_id":"","url":"https://api.github.com/users/dkdeploy","html_url":"https://github.com/dkdeploy","followers_url":"https://api.github.com/users/dkdeploy/followers","following_url":"https://api.github.com/users/dkdeploy/following{/other_user}","gists_url":"https://api.github.com/users/dkdeploy/gists{/gist_id}","starred_url":"https://api.github.com/users/dkdeploy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkdeploy/subscriptions","organizations_url":"https://api.github.com/users/dkdeploy/orgs","repos_url":"https://api.github.com/users/dkdeploy/repos","events_url":"https://api.github.com/users/dkdeploy/events{/privacy}","received_events_url":"https://api.github.com/users/dkdeploy/received_events","type":"Organization","site_admin":false},"repo":{"id":59646669,"name":"dkdeploy-php","full_name":"dkdeploy/dkdeploy-php","owner":{"login":"dkdeploy","id":19567849,"avatar_url":"https://avatars.githubusercontent.com/u/19567849?v=3","gravatar_id":"","url":"https://api.github.com/users/dkdeploy","html_url":"https://github.com/dkdeploy","followers_url":"https://api.github.com/users/dkdeploy/followers","following_url":"https://api.github.com/users/dkdeploy/following{/other_user}","gists_url":"https://api.github.com/users/dkdeploy/gists{/gist_id}","starred_url":"https://api.github.com/users/dkdeploy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkdeploy/subscriptions","organizations_url":"https://api.github.com/users/dkdeploy/orgs","repos_url":"https://api.github.com/users/dkdeploy/repos","events_url":"https://api.github.com/users/dkdeploy/events{/privacy}","received_events_url":"https://api.github.com/users/dkdeploy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dkdeploy/dkdeploy-php","description":"Capistrano extension for advanced PHP deployments","fork":false,"url":"https://api.github.com/repos/dkdeploy/dkdeploy-php","forks_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/forks","keys_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/teams","hooks_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/hooks","issue_events_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/issues/events{/number}","events_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/events","assignees_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/assignees{/user}","branches_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/branches{/branch}","tags_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/tags","blobs_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/statuses/{sha}","languages_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/languages","stargazers_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/stargazers","contributors_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/contributors","subscribers_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/subscribers","subscription_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/subscription","commits_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/contents/{+path}","compare_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/merges","archive_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/downloads","issues_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/issues{/number}","pulls_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls{/number}","milestones_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/milestones{/number}","notifications_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/labels{/name}","releases_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/releases{/id}","deployments_url":"https://api.github.com/repos/dkdeploy/dkdeploy-php/deployments","created_at":"2016-05-25T08:46:41Z","updated_at":"2016-07-07T06:59:35Z","pushed_at":"2016-11-04T12:22:13Z","git_url":"git://github.com/dkdeploy/dkdeploy-php.git","ssh_url":"git@github.com:dkdeploy/dkdeploy-php.git","clone_url":"https://github.com/dkdeploy/dkdeploy-php.git","svn_url":"https://github.com/dkdeploy/dkdeploy-php","homepage":"","size":634,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/5"},"html":{"href":"https://github.com/dkdeploy/dkdeploy-php/pull/5"},"issue":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/issues/5"},"comments":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/dkdeploy/dkdeploy-php/statuses/3e7d03a6c9c6f9bfd73f5f90d870fdaefe6ee656"}}}}
{"actor":{"display_login":"klyonrad"}}