{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/7460","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7460/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7460/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7460/events","html_url":"https://github.com/joomla/joomla-cms/pull/7460","id":95819670,"number":7460,"title":"JavaScript validation performance (2)","user":{"login":"Fedik","id":1568198,"avatar_url":"https://avatars.githubusercontent.com/u/1568198?v=3","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"},{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/RTC","name":"RTC","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.5.2","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14/labels","id":1659748,"number":14,"title":"Joomla 3.5.2","description":"","creator":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars.githubusercontent.com/u/1296369?v=3","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":179,"state":"open","created_at":"2016-03-22T13:52:19Z","updated_at":"2016-04-21T14:30:22Z","due_on":null,"closed_at":null},"comments":39,"created_at":"2015-07-18T12:18:21Z","updated_at":"2016-04-21T16:16:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7460","html_url":"https://github.com/joomla/joomla-cms/pull/7460","diff_url":"https://github.com/joomla/joomla-cms/pull/7460.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7460.patch"},"body":"This pull speed up the form validation by ignoring fields: `rules`, `filters`, `assigned` as they do not need to be validated anyway.\r\n\r\nResults on default test installation:\r\nBefore (in edit module form):\r\n![screen 2015-07-18 14 18 27 1064x359](https://cloud.githubusercontent.com/assets/1568198/8761537/d239225a-2d5e-11e5-9a8e-80b8344e5ea5.png)\r\nValidate take 4ms\r\n\r\nAfter (in edit module form):\r\n![screen 2015-07-18 14 18 46 1071x358](https://cloud.githubusercontent.com/assets/1568198/8761539/da5678d4-2d5e-11e5-932a-a1ed39ea3cd2.png)\r\nValidate take 2ms\r\n\r\nI count time between push Save button (validation start) and form submit (validation finished).\r\n\r\nIn result (on default test installation) I get 2 times faster validation, but main target is users who have hundreds of User groups.\r\n\r\n**Test**\r\nCreate 200 user groups and compare performance on save the Global Configuration and any Module form.\r\nAlso test other forms (on frontend also), whether they still work as expected\r\n\r\n**UPD**: Graph with the final result in that comment https://github.com/joomla/joomla-cms/pull/7460#issuecomment-122641687\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/212991675","html_url":"https://github.com/joomla/joomla-cms/pull/7460#issuecomment-212991675","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7460","id":212991675,"user":{"login":"Fedik","id":1568198,"avatar_url":"https://avatars.githubusercontent.com/u/1568198?v=3","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T16:16:44Z","updated_at":"2016-04-21T16:16:44Z","body":"yes, updated, was just a conflict between the minified script version "}}