{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/91395242","pull_request_review_id":11903624,"id":91395242,"diff_hunk":"@@ -0,0 +1,61 @@\n+require 'pxp-agent/test_helper.rb'\n+require 'puppet/acceptance/environment_utils'\n+\n+test_name 'C98237 - Run puppet with syntax significant characters in Puppet code' do\n+  extend Puppet::Acceptance::EnvironmentUtils\n+\n+  env_name = test_file_name = File.basename(__FILE__, '.*')\n+  environment_name = mk_tmp_environment(env_name)\n+\n+  step 'On master, create a new environment that includes syntax significant characters in resources and will result in Changed' do\n+    site_manifest = \"#{environmentpath}/#{environment_name}/manifests/site.pp\"\n+    create_remote_file(master, site_manifest, <<-SITEPP)\n+node default {\n+  notify {'\\\\'\\\\\"&+/\\\\()?,.#!@$_-~':}","path":"acceptance/tests/pxp-module-puppet/run_puppet_syntax_chars.rb","position":14,"original_position":14,"commit_id":"f38ec884429ceac8b3376db6aaaa998d91a4e4d6","original_commit_id":"f38ec884429ceac8b3376db6aaaa998d91a4e4d6","user":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"body":"Would it make sense to include some characters outside of ASCII? ☃? Or is this covered by some other test?","created_at":"2016-12-07T21:48:11Z","updated_at":"2016-12-07T21:48:21Z","html_url":"https://github.com/puppetlabs/pxp-agent/pull/523#discussion_r91395242","pull_request_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/523","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/91395242"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/523#discussion_r91395242"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/523"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/523","id":96945236,"html_url":"https://github.com/puppetlabs/pxp-agent/pull/523","diff_url":"https://github.com/puppetlabs/pxp-agent/pull/523.diff","patch_url":"https://github.com/puppetlabs/pxp-agent/pull/523.patch","issue_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/523","number":523,"state":"open","locked":false,"title":"(PCP-592) Add acceptance test for syntax significant characters","user":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"body":"Add an additional acceptance test that ensures that syntax significant characters are properly handled by PXP\r\n\r\n[skip ci]","created_at":"2016-12-07T15:28:57Z","updated_at":"2016-12-07T21:48:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15adcd1077f021568644029eb16efc2bc05f696c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/523/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/523/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/523/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/f38ec884429ceac8b3376db6aaaa998d91a4e4d6","head":{"label":"james-stocks:C98237","ref":"C98237","sha":"f38ec884429ceac8b3376db6aaaa998d91a4e4d6","user":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"repo":{"id":43741364,"name":"pxp-agent","full_name":"james-stocks/pxp-agent","owner":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/james-stocks/pxp-agent","description":"Puppet eXecution Protocol Agent","fork":true,"url":"https://api.github.com/repos/james-stocks/pxp-agent","forks_url":"https://api.github.com/repos/james-stocks/pxp-agent/forks","keys_url":"https://api.github.com/repos/james-stocks/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/james-stocks/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/james-stocks/pxp-agent/teams","hooks_url":"https://api.github.com/repos/james-stocks/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/james-stocks/pxp-agent/events","assignees_url":"https://api.github.com/repos/james-stocks/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/james-stocks/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/james-stocks/pxp-agent/tags","blobs_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/james-stocks/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/james-stocks/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/james-stocks/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/james-stocks/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/james-stocks/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/james-stocks/pxp-agent/subscription","commits_url":"https://api.github.com/repos/james-stocks/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/james-stocks/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/james-stocks/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/james-stocks/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/james-stocks/pxp-agent/merges","archive_url":"https://api.github.com/repos/james-stocks/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/james-stocks/pxp-agent/downloads","issues_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/james-stocks/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/james-stocks/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/james-stocks/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/james-stocks/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/james-stocks/pxp-agent/releases{/id}","deployments_url":"https://api.github.com/repos/james-stocks/pxp-agent/deployments","created_at":"2015-10-06T09:30:06Z","updated_at":"2016-03-30T10:09:50Z","pushed_at":"2016-12-07T16:59:31Z","git_url":"git://github.com/james-stocks/pxp-agent.git","ssh_url":"git@github.com:james-stocks/pxp-agent.git","clone_url":"https://github.com/james-stocks/pxp-agent.git","svn_url":"https://github.com/james-stocks/pxp-agent","homepage":"","size":9802,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"fa309696e007ff77f7d2dc86f24f4424fb4bb638","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23231786,"name":"pxp-agent","full_name":"puppetlabs/pxp-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pxp-agent","description":"PCP eXecution Protocol Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/pxp-agent","forks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pxp-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pxp-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pxp-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pxp-agent/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/deployments","created_at":"2014-08-22T16:25:01Z","updated_at":"2016-11-07T17:43:48Z","pushed_at":"2016-12-07T16:59:32Z","git_url":"git://github.com/puppetlabs/pxp-agent.git","ssh_url":"git@github.com:puppetlabs/pxp-agent.git","clone_url":"https://github.com/puppetlabs/pxp-agent.git","svn_url":"https://github.com/puppetlabs/pxp-agent","homepage":"","size":10028,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":4,"forks":25,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/523"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/523"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/523"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/f38ec884429ceac8b3376db6aaaa998d91a4e4d6"}}}}
{"actor":{"display_login":"mruzicka"}}