{"action":"created","comment":{"url":"https://api.github.com/repos/HabitRPG/habitica/pulls/comments/89936893","pull_request_review_id":10464416,"id":89936893,"diff_hunk":"@@ -780,6 +780,18 @@ describe('cron', () => {\n       expect(user.notifications[0].type).to.eql('LOGIN_INCENTIVE');\n     });\n \n+    it('replaces previous notifications', () => {\n+      cron({user, tasksByType, daysMissed, analytics});\n+      cron({user, tasksByType, daysMissed, analytics});\n+      cron({user, tasksByType, daysMissed, analytics});\n+\n+      let filteredNotifications = filter(user.notifications, function filterNotifications (notification) {","path":"test/api/v3/unit/libs/cron.test.js","position":18,"original_position":18,"commit_id":"1d2482f8bc288f1a31f82c91f0dd4e864fafaa7a","original_commit_id":"1d2482f8bc288f1a31f82c91f0dd4e864fafaa7a","user":{"login":"crookedneighbor","id":2916945,"avatar_url":"https://avatars.githubusercontent.com/u/2916945?v=3","gravatar_id":"","url":"https://api.github.com/users/crookedneighbor","html_url":"https://github.com/crookedneighbor","followers_url":"https://api.github.com/users/crookedneighbor/followers","following_url":"https://api.github.com/users/crookedneighbor/following{/other_user}","gists_url":"https://api.github.com/users/crookedneighbor/gists{/gist_id}","starred_url":"https://api.github.com/users/crookedneighbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crookedneighbor/subscriptions","organizations_url":"https://api.github.com/users/crookedneighbor/orgs","repos_url":"https://api.github.com/users/crookedneighbor/repos","events_url":"https://api.github.com/users/crookedneighbor/events{/privacy}","received_events_url":"https://api.github.com/users/crookedneighbor/received_events","type":"User","site_admin":false},"body":"Why not use the array filter method and an arrow function?","created_at":"2016-11-29T03:53:58Z","updated_at":"2016-11-29T03:54:29Z","html_url":"https://github.com/HabitRPG/habitica/pull/8242#discussion_r89936893","pull_request_url":"https://api.github.com/repos/HabitRPG/habitica/pulls/8242","_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitica/pulls/comments/89936893"},"html":{"href":"https://github.com/HabitRPG/habitica/pull/8242#discussion_r89936893"},"pull_request":{"href":"https://api.github.com/repos/HabitRPG/habitica/pulls/8242"}}},"pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitica/pulls/8242","id":95620135,"html_url":"https://github.com/HabitRPG/habitica/pull/8242","diff_url":"https://github.com/HabitRPG/habitica/pull/8242.diff","patch_url":"https://github.com/HabitRPG/habitica/pull/8242.patch","issue_url":"https://api.github.com/repos/HabitRPG/habitica/issues/8242","number":8242,"state":"open","locked":false,"title":"Login incentives remove multiple notifications","user":{"login":"TheHollidayInn","id":1253400,"avatar_url":"https://avatars.githubusercontent.com/u/1253400?v=3","gravatar_id":"","url":"https://api.github.com/users/TheHollidayInn","html_url":"https://github.com/TheHollidayInn","followers_url":"https://api.github.com/users/TheHollidayInn/followers","following_url":"https://api.github.com/users/TheHollidayInn/following{/other_user}","gists_url":"https://api.github.com/users/TheHollidayInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHollidayInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHollidayInn/subscriptions","organizations_url":"https://api.github.com/users/TheHollidayInn/orgs","repos_url":"https://api.github.com/users/TheHollidayInn/repos","events_url":"https://api.github.com/users/TheHollidayInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheHollidayInn/received_events","type":"User","site_admin":false},"body":"[//]: # (Note: See http://habitica.wikia.com/wiki/Using_Habitica_Git#Pull_Request for more info)\r\n\r\n[//]: # (Put Issue # or URL here, if applicable. This will automatically close the issue if your PR is merged in)\r\nFixes put_issue_url_here\r\n\r\n### Changes\r\n[//]: # (Describe the changes that were made in detail here. Include pictures if necessary)\r\nThis removes previous login incentive notifications so that there is always at max, one. \r\n\r\n[//]: # (Put User ID in here - found in Settings -> API)\r\n\r\n----\r\nUUID: \r\n","created_at":"2016-11-29T03:25:34Z","updated_at":"2016-11-29T03:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3d279480186487275f3f5d54c51c63d58362dfa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HabitRPG/habitica/pulls/8242/commits","review_comments_url":"https://api.github.com/repos/HabitRPG/habitica/pulls/8242/comments","review_comment_url":"https://api.github.com/repos/HabitRPG/habitica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HabitRPG/habitica/issues/8242/comments","statuses_url":"https://api.github.com/repos/HabitRPG/habitica/statuses/1d2482f8bc288f1a31f82c91f0dd4e864fafaa7a","head":{"label":"TheHollidayInn:login-incentives-remove-multiple-notifications","ref":"login-incentives-remove-multiple-notifications","sha":"1d2482f8bc288f1a31f82c91f0dd4e864fafaa7a","user":{"login":"TheHollidayInn","id":1253400,"avatar_url":"https://avatars.githubusercontent.com/u/1253400?v=3","gravatar_id":"","url":"https://api.github.com/users/TheHollidayInn","html_url":"https://github.com/TheHollidayInn","followers_url":"https://api.github.com/users/TheHollidayInn/followers","following_url":"https://api.github.com/users/TheHollidayInn/following{/other_user}","gists_url":"https://api.github.com/users/TheHollidayInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHollidayInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHollidayInn/subscriptions","organizations_url":"https://api.github.com/users/TheHollidayInn/orgs","repos_url":"https://api.github.com/users/TheHollidayInn/repos","events_url":"https://api.github.com/users/TheHollidayInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheHollidayInn/received_events","type":"User","site_admin":false},"repo":{"id":31106714,"name":"habitrpg","full_name":"TheHollidayInn/habitrpg","owner":{"login":"TheHollidayInn","id":1253400,"avatar_url":"https://avatars.githubusercontent.com/u/1253400?v=3","gravatar_id":"","url":"https://api.github.com/users/TheHollidayInn","html_url":"https://github.com/TheHollidayInn","followers_url":"https://api.github.com/users/TheHollidayInn/followers","following_url":"https://api.github.com/users/TheHollidayInn/following{/other_user}","gists_url":"https://api.github.com/users/TheHollidayInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHollidayInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHollidayInn/subscriptions","organizations_url":"https://api.github.com/users/TheHollidayInn/orgs","repos_url":"https://api.github.com/users/TheHollidayInn/repos","events_url":"https://api.github.com/users/TheHollidayInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheHollidayInn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheHollidayInn/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":true,"url":"https://api.github.com/repos/TheHollidayInn/habitrpg","forks_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/forks","keys_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/teams","hooks_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/events","assignees_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/tags","blobs_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/languages","stargazers_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/subscription","commits_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/merges","archive_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/downloads","issues_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/releases{/id}","deployments_url":"https://api.github.com/repos/TheHollidayInn/habitrpg/deployments","created_at":"2015-02-21T02:07:13Z","updated_at":"2016-01-11T18:43:21Z","pushed_at":"2016-11-29T03:24:48Z","git_url":"git://github.com/TheHollidayInn/habitrpg.git","ssh_url":"git@github.com:TheHollidayInn/habitrpg.git","clone_url":"https://github.com/TheHollidayInn/habitrpg.git","svn_url":"https://github.com/TheHollidayInn/habitrpg","homepage":"habitrpg.com","size":505809,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HabitRPG:develop","ref":"develop","sha":"559f9b18258131d29869ddc92890902c20168efb","user":{"login":"HabitRPG","id":3834775,"avatar_url":"https://avatars.githubusercontent.com/u/3834775?v=3","gravatar_id":"","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":4578898,"name":"habitica","full_name":"HabitRPG/habitica","owner":{"login":"HabitRPG","id":3834775,"avatar_url":"https://avatars.githubusercontent.com/u/3834775?v=3","gravatar_id":"","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HabitRPG/habitica","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":false,"url":"https://api.github.com/repos/HabitRPG/habitica","forks_url":"https://api.github.com/repos/HabitRPG/habitica/forks","keys_url":"https://api.github.com/repos/HabitRPG/habitica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HabitRPG/habitica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HabitRPG/habitica/teams","hooks_url":"https://api.github.com/repos/HabitRPG/habitica/hooks","issue_events_url":"https://api.github.com/repos/HabitRPG/habitica/issues/events{/number}","events_url":"https://api.github.com/repos/HabitRPG/habitica/events","assignees_url":"https://api.github.com/repos/HabitRPG/habitica/assignees{/user}","branches_url":"https://api.github.com/repos/HabitRPG/habitica/branches{/branch}","tags_url":"https://api.github.com/repos/HabitRPG/habitica/tags","blobs_url":"https://api.github.com/repos/HabitRPG/habitica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HabitRPG/habitica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HabitRPG/habitica/git/refs{/sha}","trees_url":"https://api.github.com/repos/HabitRPG/habitica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HabitRPG/habitica/statuses/{sha}","languages_url":"https://api.github.com/repos/HabitRPG/habitica/languages","stargazers_url":"https://api.github.com/repos/HabitRPG/habitica/stargazers","contributors_url":"https://api.github.com/repos/HabitRPG/habitica/contributors","subscribers_url":"https://api.github.com/repos/HabitRPG/habitica/subscribers","subscription_url":"https://api.github.com/repos/HabitRPG/habitica/subscription","commits_url":"https://api.github.com/repos/HabitRPG/habitica/commits{/sha}","git_commits_url":"https://api.github.com/repos/HabitRPG/habitica/git/commits{/sha}","comments_url":"https://api.github.com/repos/HabitRPG/habitica/comments{/number}","issue_comment_url":"https://api.github.com/repos/HabitRPG/habitica/issues/comments{/number}","contents_url":"https://api.github.com/repos/HabitRPG/habitica/contents/{+path}","compare_url":"https://api.github.com/repos/HabitRPG/habitica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HabitRPG/habitica/merges","archive_url":"https://api.github.com/repos/HabitRPG/habitica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HabitRPG/habitica/downloads","issues_url":"https://api.github.com/repos/HabitRPG/habitica/issues{/number}","pulls_url":"https://api.github.com/repos/HabitRPG/habitica/pulls{/number}","milestones_url":"https://api.github.com/repos/HabitRPG/habitica/milestones{/number}","notifications_url":"https://api.github.com/repos/HabitRPG/habitica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HabitRPG/habitica/labels{/name}","releases_url":"https://api.github.com/repos/HabitRPG/habitica/releases{/id}","deployments_url":"https://api.github.com/repos/HabitRPG/habitica/deployments","created_at":"2012-06-06T22:49:48Z","updated_at":"2016-11-28T01:51:03Z","pushed_at":"2016-11-29T03:40:33Z","git_url":"git://github.com/HabitRPG/habitica.git","ssh_url":"git@github.com:HabitRPG/habitica.git","clone_url":"https://github.com/HabitRPG/habitica.git","svn_url":"https://github.com/HabitRPG/habitica","homepage":"https://habitica.com","size":578833,"stargazers_count":4383,"watchers_count":4383,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1866,"mirror_url":null,"open_issues_count":360,"forks":1866,"open_issues":360,"watchers":4383,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitica/pulls/8242"},"html":{"href":"https://github.com/HabitRPG/habitica/pull/8242"},"issue":{"href":"https://api.github.com/repos/HabitRPG/habitica/issues/8242"},"comments":{"href":"https://api.github.com/repos/HabitRPG/habitica/issues/8242/comments"},"review_comments":{"href":"https://api.github.com/repos/HabitRPG/habitica/pulls/8242/comments"},"review_comment":{"href":"https://api.github.com/repos/HabitRPG/habitica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HabitRPG/habitica/pulls/8242/commits"},"statuses":{"href":"https://api.github.com/repos/HabitRPG/habitica/statuses/1d2482f8bc288f1a31f82c91f0dd4e864fafaa7a"}}}}
{"actor":{"display_login":"crookedneighbor"}}