{"action":"opened","number":163,"pull_request":{"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/163","id":75502246,"html_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/163","diff_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/163.diff","patch_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/163.patch","issue_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/163","number":163,"state":"open","locked":false,"title":"Fix trailing comma rule","user":{"login":"Invizory","id":1163295,"avatar_url":"https://avatars.githubusercontent.com/u/1163295?v=3","gravatar_id":"","url":"https://api.github.com/users/Invizory","html_url":"https://github.com/Invizory","followers_url":"https://api.github.com/users/Invizory/followers","following_url":"https://api.github.com/users/Invizory/following{/other_user}","gists_url":"https://api.github.com/users/Invizory/gists{/gist_id}","starred_url":"https://api.github.com/users/Invizory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Invizory/subscriptions","organizations_url":"https://api.github.com/users/Invizory/orgs","repos_url":"https://api.github.com/users/Invizory/repos","events_url":"https://api.github.com/users/Invizory/events{/privacy}","received_events_url":"https://api.github.com/users/Invizory/received_events","type":"User","site_admin":false},"body":"`recommended_ruleset.js` contains the following rule:\r\n\r\n```js\r\n\"trailing-comma\": true,\r\n```\r\n\r\nThis is actually a no-op because you should set `multiline` and `singleline` options in order to enable corresponding checks (see [trailing-comma rule doc](http://palantir.github.io/tslint/rules/trailing-comma/) and [recommended.ts](https://github.com/palantir/tslint/blob/master/src/configs/recommended.ts#L91)):\r\n\r\n```js\r\n\"trailing-comma\": [true, {\"singleline\": \"never\", \"multiline\": \"always\"}],\r\n```\r\n\r\nThe rationale behind enforcing trailing commas for multiline statements is covered by [this article](https://medium.com/@nikgraf/why-you-should-enforce-dangling-commas-for-multiline-statements-d034c98e36f8).\r\n\r\nHovewer, the established code style in `tslint-microsoft-contrib` assumes that trailing commas are disallowed so I've decided to set `\"multiline\": \"never\"` in `tslint.json` as a compromise and fix one redundant trailing comma.","created_at":"2016-06-28T15:50:50Z","updated_at":"2016-06-28T15:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/163/commits","review_comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/163/comments","review_comment_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/163/comments","statuses_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/a8719608713c0e4199b07fc08a4f1275800a8af3","head":{"label":"Invizory:fix-trailing-comma","ref":"fix-trailing-comma","sha":"a8719608713c0e4199b07fc08a4f1275800a8af3","user":{"login":"Invizory","id":1163295,"avatar_url":"https://avatars.githubusercontent.com/u/1163295?v=3","gravatar_id":"","url":"https://api.github.com/users/Invizory","html_url":"https://github.com/Invizory","followers_url":"https://api.github.com/users/Invizory/followers","following_url":"https://api.github.com/users/Invizory/following{/other_user}","gists_url":"https://api.github.com/users/Invizory/gists{/gist_id}","starred_url":"https://api.github.com/users/Invizory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Invizory/subscriptions","organizations_url":"https://api.github.com/users/Invizory/orgs","repos_url":"https://api.github.com/users/Invizory/repos","events_url":"https://api.github.com/users/Invizory/events{/privacy}","received_events_url":"https://api.github.com/users/Invizory/received_events","type":"User","site_admin":false},"repo":{"id":62150574,"name":"tslint-microsoft-contrib","full_name":"Invizory/tslint-microsoft-contrib","owner":{"login":"Invizory","id":1163295,"avatar_url":"https://avatars.githubusercontent.com/u/1163295?v=3","gravatar_id":"","url":"https://api.github.com/users/Invizory","html_url":"https://github.com/Invizory","followers_url":"https://api.github.com/users/Invizory/followers","following_url":"https://api.github.com/users/Invizory/following{/other_user}","gists_url":"https://api.github.com/users/Invizory/gists{/gist_id}","starred_url":"https://api.github.com/users/Invizory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Invizory/subscriptions","organizations_url":"https://api.github.com/users/Invizory/orgs","repos_url":"https://api.github.com/users/Invizory/repos","events_url":"https://api.github.com/users/Invizory/events{/privacy}","received_events_url":"https://api.github.com/users/Invizory/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Invizory/tslint-microsoft-contrib","description":"A set of TSLint rules used on some Microsoft projects.","fork":true,"url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib","forks_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/forks","keys_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/teams","hooks_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/hooks","issue_events_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/events","assignees_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/tags","blobs_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/languages","stargazers_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/stargazers","contributors_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/contributors","subscribers_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/subscribers","subscription_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/subscription","commits_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/merges","archive_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/downloads","issues_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/labels{/name}","releases_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/Invizory/tslint-microsoft-contrib/deployments","created_at":"2016-06-28T15:01:05Z","updated_at":"2016-06-28T15:01:06Z","pushed_at":"2016-06-28T15:29:29Z","git_url":"git://github.com/Invizory/tslint-microsoft-contrib.git","ssh_url":"git@github.com:Invizory/tslint-microsoft-contrib.git","clone_url":"https://github.com/Invizory/tslint-microsoft-contrib.git","svn_url":"https://github.com/Invizory/tslint-microsoft-contrib","homepage":null,"size":1141,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"797b436a9774cdc146a8ae63b38f0d800e0ffb53","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41095157,"name":"tslint-microsoft-contrib","full_name":"Microsoft/tslint-microsoft-contrib","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/tslint-microsoft-contrib","description":"A set of TSLint rules used on some Microsoft projects.","fork":false,"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib","forks_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/forks","keys_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/teams","hooks_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/events","assignees_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/tags","blobs_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/languages","stargazers_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/subscription","commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/merges","archive_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/downloads","issues_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/deployments","created_at":"2015-08-20T12:44:29Z","updated_at":"2016-06-28T12:13:10Z","pushed_at":"2016-06-28T15:50:50Z","git_url":"git://github.com/Microsoft/tslint-microsoft-contrib.git","ssh_url":"git@github.com:Microsoft/tslint-microsoft-contrib.git","clone_url":"https://github.com/Microsoft/tslint-microsoft-contrib.git","svn_url":"https://github.com/Microsoft/tslint-microsoft-contrib","homepage":null,"size":1141,"stargazers_count":55,"watchers_count":55,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":28,"forks":14,"open_issues":28,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/163"},"html":{"href":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/163"},"issue":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/163"},"comments":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/a8719608713c0e4199b07fc08a4f1275800a8af3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":3,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"Invizory"}}