{"action":"created","comment":{"url":"https://api.github.com/repos/NLog/NLog/pulls/comments/52030019","id":52030019,"diff_hunk":"@@ -44,7 +44,7 @@ public void InternalLoggingConfigTest1()\n             using (var scope = new InternalLoggerScope())\n             {\n                 CreateConfigurationFromString(@\"\n-<nlog internalLogFile='c:\\file.txt' internalLogLevel='Trace' internalLogToConsole='true' internalLogToConsoleError='true' globalThreshold='Warn' throwExceptions='true'>\n+<nlog internalLogFile='c:\\file.txt' internalLogLevel='Trace' internalLogToConsole='true' internalLogToConsoleError='true' globalThreshold='Warn' throwExceptions='true' internalWriteToDiagnostics='true'>","path":"tests/NLog.UnitTests/Config/InternalLoggingTests.cs","position":5,"original_position":5,"commit_id":"f942334c1a632bc982919a781628fa7c5213040f","original_commit_id":"f942334c1a632bc982919a781628fa7c5213040f","user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"body":"I'm aware that the current tests are not that good. Still I like to ask to write some more tests as we need more tests in the end (code coverage of 73-74% is not that good)\r\n\r\nYou can use https://github.com/NLog/NLog/blob/master/tests/NLog.UnitTests/NLogTraceListenerTests.cs#L64-L307 to check how-to read the trace. ","created_at":"2016-02-05T15:36:52Z","updated_at":"2016-02-05T15:36:52Z","html_url":"https://github.com/NLog/NLog/pull/1222#discussion_r52030019","pull_request_url":"https://api.github.com/repos/NLog/NLog/pulls/1222","_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments/52030019"},"html":{"href":"https://github.com/NLog/NLog/pull/1222#discussion_r52030019"},"pull_request":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1222"}}},"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/1222","id":58425086,"html_url":"https://github.com/NLog/NLog/pull/1222","diff_url":"https://github.com/NLog/NLog/pull/1222.diff","patch_url":"https://github.com/NLog/NLog/pull/1222.patch","issue_url":"https://api.github.com/repos/NLog/NLog/issues/1222","number":1222,"state":"open","locked":false,"title":"internalLogger, write to System.Diagnostics.Debug / System.Diagnostics.Trace #1217","user":{"login":"bryjamus","id":7079299,"avatar_url":"https://avatars.githubusercontent.com/u/7079299?v=3","gravatar_id":"","url":"https://api.github.com/users/bryjamus","html_url":"https://github.com/bryjamus","followers_url":"https://api.github.com/users/bryjamus/followers","following_url":"https://api.github.com/users/bryjamus/following{/other_user}","gists_url":"https://api.github.com/users/bryjamus/gists{/gist_id}","starred_url":"https://api.github.com/users/bryjamus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryjamus/subscriptions","organizations_url":"https://api.github.com/users/bryjamus/orgs","repos_url":"https://api.github.com/users/bryjamus/repos","events_url":"https://api.github.com/users/bryjamus/events{/privacy}","received_events_url":"https://api.github.com/users/bryjamus/received_events","type":"User","site_admin":false},"body":"fixes #1217","created_at":"2016-02-05T12:52:28Z","updated_at":"2016-02-05T15:36:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3829089162d0f7ef4bcefa78cebb01579a97a6f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NLog/NLog/pulls/1222/commits","review_comments_url":"https://api.github.com/repos/NLog/NLog/pulls/1222/comments","review_comment_url":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/1222/comments","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/f942334c1a632bc982919a781628fa7c5213040f","head":{"label":"bryjamus:master","ref":"master","sha":"f942334c1a632bc982919a781628fa7c5213040f","user":{"login":"bryjamus","id":7079299,"avatar_url":"https://avatars.githubusercontent.com/u/7079299?v=3","gravatar_id":"","url":"https://api.github.com/users/bryjamus","html_url":"https://github.com/bryjamus","followers_url":"https://api.github.com/users/bryjamus/followers","following_url":"https://api.github.com/users/bryjamus/following{/other_user}","gists_url":"https://api.github.com/users/bryjamus/gists{/gist_id}","starred_url":"https://api.github.com/users/bryjamus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryjamus/subscriptions","organizations_url":"https://api.github.com/users/bryjamus/orgs","repos_url":"https://api.github.com/users/bryjamus/repos","events_url":"https://api.github.com/users/bryjamus/events{/privacy}","received_events_url":"https://api.github.com/users/bryjamus/received_events","type":"User","site_admin":false},"repo":{"id":51138143,"name":"NLog","full_name":"bryjamus/NLog","owner":{"login":"bryjamus","id":7079299,"avatar_url":"https://avatars.githubusercontent.com/u/7079299?v=3","gravatar_id":"","url":"https://api.github.com/users/bryjamus","html_url":"https://github.com/bryjamus","followers_url":"https://api.github.com/users/bryjamus/followers","following_url":"https://api.github.com/users/bryjamus/following{/other_user}","gists_url":"https://api.github.com/users/bryjamus/gists{/gist_id}","starred_url":"https://api.github.com/users/bryjamus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryjamus/subscriptions","organizations_url":"https://api.github.com/users/bryjamus/orgs","repos_url":"https://api.github.com/users/bryjamus/repos","events_url":"https://api.github.com/users/bryjamus/events{/privacy}","received_events_url":"https://api.github.com/users/bryjamus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bryjamus/NLog","description":"NLog - Advanced .NET and Silverlight Logging","fork":true,"url":"https://api.github.com/repos/bryjamus/NLog","forks_url":"https://api.github.com/repos/bryjamus/NLog/forks","keys_url":"https://api.github.com/repos/bryjamus/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryjamus/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryjamus/NLog/teams","hooks_url":"https://api.github.com/repos/bryjamus/NLog/hooks","issue_events_url":"https://api.github.com/repos/bryjamus/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/bryjamus/NLog/events","assignees_url":"https://api.github.com/repos/bryjamus/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/bryjamus/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/bryjamus/NLog/tags","blobs_url":"https://api.github.com/repos/bryjamus/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryjamus/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryjamus/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryjamus/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryjamus/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/bryjamus/NLog/languages","stargazers_url":"https://api.github.com/repos/bryjamus/NLog/stargazers","contributors_url":"https://api.github.com/repos/bryjamus/NLog/contributors","subscribers_url":"https://api.github.com/repos/bryjamus/NLog/subscribers","subscription_url":"https://api.github.com/repos/bryjamus/NLog/subscription","commits_url":"https://api.github.com/repos/bryjamus/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryjamus/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryjamus/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryjamus/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryjamus/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/bryjamus/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryjamus/NLog/merges","archive_url":"https://api.github.com/repos/bryjamus/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryjamus/NLog/downloads","issues_url":"https://api.github.com/repos/bryjamus/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/bryjamus/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/bryjamus/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/bryjamus/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryjamus/NLog/labels{/name}","releases_url":"https://api.github.com/repos/bryjamus/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/bryjamus/NLog/deployments","created_at":"2016-02-05T09:41:41Z","updated_at":"2016-02-05T09:41:44Z","pushed_at":"2016-02-05T12:49:33Z","git_url":"git://github.com/bryjamus/NLog.git","ssh_url":"git@github.com:bryjamus/NLog.git","clone_url":"https://github.com/bryjamus/NLog.git","svn_url":"https://github.com/bryjamus/NLog","homepage":"http://nlog-project.org","size":114007,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NLog:master","ref":"master","sha":"1c6050e533399b1c434a087f2b9a4a0bfa02ab50","user":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced .NET and Silverlight Logging","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/NLog/NLog/deployments","created_at":"2012-09-12T13:49:29Z","updated_at":"2016-02-04T23:39:02Z","pushed_at":"2016-02-05T12:52:29Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":"http://nlog-project.org","size":121419,"stargazers_count":1449,"watchers_count":1449,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":526,"mirror_url":null,"open_issues_count":140,"forks":526,"open_issues":140,"watchers":1449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1222"},"html":{"href":"https://github.com/NLog/NLog/pull/1222"},"issue":{"href":"https://api.github.com/repos/NLog/NLog/issues/1222"},"comments":{"href":"https://api.github.com/repos/NLog/NLog/issues/1222/comments"},"review_comments":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1222/comments"},"review_comment":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1222/commits"},"statuses":{"href":"https://api.github.com/repos/NLog/NLog/statuses/f942334c1a632bc982919a781628fa7c5213040f"}}}}