{"action":"opened","number":6886,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6886","id":70772260,"html_url":"https://github.com/nodejs/node/pull/6886","diff_url":"https://github.com/nodejs/node/pull/6886.diff","patch_url":"https://github.com/nodejs/node/pull/6886.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6886","number":6886,"state":"open","locked":false,"title":"http: avoid obscure http parser error on CONNECT.","user":{"login":"bjouhier","id":415044,"avatar_url":"https://avatars.githubusercontent.com/u/415044?v=3","gravatar_id":"","url":"https://api.github.com/users/bjouhier","html_url":"https://github.com/bjouhier","followers_url":"https://api.github.com/users/bjouhier/followers","following_url":"https://api.github.com/users/bjouhier/following{/other_user}","gists_url":"https://api.github.com/users/bjouhier/gists{/gist_id}","starred_url":"https://api.github.com/users/bjouhier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjouhier/subscriptions","organizations_url":"https://api.github.com/users/bjouhier/orgs","repos_url":"https://api.github.com/users/bjouhier/repos","events_url":"https://api.github.com/users/bjouhier/events{/privacy}","received_events_url":"https://api.github.com/users/bjouhier/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements and walk\r\nthrough the checklist. You can 'tick' a box by using the letter \"x\": [x].\r\n\r\nRun the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on\r\nWindows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. If possible, include a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- remove lines that do not apply to you -->\r\n\r\n- [x] tests and code linting passes\r\n- [x] a test and/or benchmark is included\r\n- [ ] documentation is changed or added\r\n- [x] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\nhttp\r\n\r\n\r\n##### Description of change\r\n<!-- provide a description of the change below this comment -->\r\n\r\nSome proxies return a 403 when attempting SSL tunnelling through\r\na port other than 443. This is reported to the HTTP client as an\r\nobscure \"Parse Error\" / HPE_INVALID_CONSTANT, which is difficult to\r\ntroubleshoot.\r\n\r\nThis commit improves this by catching status codes >= 400 in CONNECT\r\nresponses and by emitting an ECONNREFUSED error with the status code\r\nincluded in the error message.","created_at":"2016-05-19T21:57:31Z","updated_at":"2016-05-19T21:57:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6886/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6886/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6886/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/803d2b070d70180b439ddeffd2ee1a618943cd3c","head":{"label":"Sage-ERP-X3:http-connect-error-master","ref":"http-connect-error-master","sha":"803d2b070d70180b439ddeffd2ee1a618943cd3c","user":{"login":"Sage-ERP-X3","id":1861602,"avatar_url":"https://avatars.githubusercontent.com/u/1861602?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-ERP-X3","html_url":"https://github.com/Sage-ERP-X3","followers_url":"https://api.github.com/users/Sage-ERP-X3/followers","following_url":"https://api.github.com/users/Sage-ERP-X3/following{/other_user}","gists_url":"https://api.github.com/users/Sage-ERP-X3/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-ERP-X3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-ERP-X3/subscriptions","organizations_url":"https://api.github.com/users/Sage-ERP-X3/orgs","repos_url":"https://api.github.com/users/Sage-ERP-X3/repos","events_url":"https://api.github.com/users/Sage-ERP-X3/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-ERP-X3/received_events","type":"Organization","site_admin":false},"repo":{"id":59192194,"name":"node","full_name":"Sage-ERP-X3/node","owner":{"login":"Sage-ERP-X3","id":1861602,"avatar_url":"https://avatars.githubusercontent.com/u/1861602?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-ERP-X3","html_url":"https://github.com/Sage-ERP-X3","followers_url":"https://api.github.com/users/Sage-ERP-X3/followers","following_url":"https://api.github.com/users/Sage-ERP-X3/following{/other_user}","gists_url":"https://api.github.com/users/Sage-ERP-X3/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-ERP-X3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-ERP-X3/subscriptions","organizations_url":"https://api.github.com/users/Sage-ERP-X3/orgs","repos_url":"https://api.github.com/users/Sage-ERP-X3/repos","events_url":"https://api.github.com/users/Sage-ERP-X3/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-ERP-X3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sage-ERP-X3/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/Sage-ERP-X3/node","forks_url":"https://api.github.com/repos/Sage-ERP-X3/node/forks","keys_url":"https://api.github.com/repos/Sage-ERP-X3/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage-ERP-X3/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage-ERP-X3/node/teams","hooks_url":"https://api.github.com/repos/Sage-ERP-X3/node/hooks","issue_events_url":"https://api.github.com/repos/Sage-ERP-X3/node/issues/events{/number}","events_url":"https://api.github.com/repos/Sage-ERP-X3/node/events","assignees_url":"https://api.github.com/repos/Sage-ERP-X3/node/assignees{/user}","branches_url":"https://api.github.com/repos/Sage-ERP-X3/node/branches{/branch}","tags_url":"https://api.github.com/repos/Sage-ERP-X3/node/tags","blobs_url":"https://api.github.com/repos/Sage-ERP-X3/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage-ERP-X3/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage-ERP-X3/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage-ERP-X3/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage-ERP-X3/node/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage-ERP-X3/node/languages","stargazers_url":"https://api.github.com/repos/Sage-ERP-X3/node/stargazers","contributors_url":"https://api.github.com/repos/Sage-ERP-X3/node/contributors","subscribers_url":"https://api.github.com/repos/Sage-ERP-X3/node/subscribers","subscription_url":"https://api.github.com/repos/Sage-ERP-X3/node/subscription","commits_url":"https://api.github.com/repos/Sage-ERP-X3/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage-ERP-X3/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage-ERP-X3/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage-ERP-X3/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sage-ERP-X3/node/contents/{+path}","compare_url":"https://api.github.com/repos/Sage-ERP-X3/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage-ERP-X3/node/merges","archive_url":"https://api.github.com/repos/Sage-ERP-X3/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage-ERP-X3/node/downloads","issues_url":"https://api.github.com/repos/Sage-ERP-X3/node/issues{/number}","pulls_url":"https://api.github.com/repos/Sage-ERP-X3/node/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage-ERP-X3/node/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage-ERP-X3/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage-ERP-X3/node/labels{/name}","releases_url":"https://api.github.com/repos/Sage-ERP-X3/node/releases{/id}","deployments_url":"https://api.github.com/repos/Sage-ERP-X3/node/deployments","created_at":"2016-05-19T09:21:06Z","updated_at":"2016-05-19T09:21:21Z","pushed_at":"2016-05-19T21:53:29Z","git_url":"git://github.com/Sage-ERP-X3/node.git","ssh_url":"git@github.com:Sage-ERP-X3/node.git","clone_url":"https://github.com/Sage-ERP-X3/node.git","svn_url":"https://github.com/Sage-ERP-X3/node","homepage":"https://nodejs.org","size":206570,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"395cc885f4eb21c2002dbfe405d31da275699aa8","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-05-19T20:57:22Z","pushed_at":"2016-05-19T21:51:12Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":266381,"stargazers_count":23306,"watchers_count":23306,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3313,"mirror_url":null,"open_issues_count":667,"forks":3313,"open_issues":667,"watchers":23306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6886"},"html":{"href":"https://github.com/nodejs/node/pull/6886"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6886"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6886/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6886/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6886/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/803d2b070d70180b439ddeffd2ee1a618943cd3c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":120,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"bjouhier"}}