{"action":"created","issue":{"url":"https://api.github.com/repos/pattern-lab/the-spec/issues/16","repository_url":"https://api.github.com/repos/pattern-lab/the-spec","labels_url":"https://api.github.com/repos/pattern-lab/the-spec/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/pattern-lab/the-spec/issues/16/comments","events_url":"https://api.github.com/repos/pattern-lab/the-spec/issues/16/events","html_url":"https://github.com/pattern-lab/the-spec/issues/16","id":157867828,"number":16,"title":"Discussion: Pattern State Declaration","user":{"login":"bmuenzenmeyer","id":298435,"avatar_url":"https://avatars.githubusercontent.com/u/298435?v=3","gravatar_id":"","url":"https://api.github.com/users/bmuenzenmeyer","html_url":"https://github.com/bmuenzenmeyer","followers_url":"https://api.github.com/users/bmuenzenmeyer/followers","following_url":"https://api.github.com/users/bmuenzenmeyer/following{/other_user}","gists_url":"https://api.github.com/users/bmuenzenmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuenzenmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuenzenmeyer/subscriptions","organizations_url":"https://api.github.com/users/bmuenzenmeyer/orgs","repos_url":"https://api.github.com/users/bmuenzenmeyer/repos","events_url":"https://api.github.com/users/bmuenzenmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/bmuenzenmeyer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pattern-lab/the-spec/labels/spec-question","name":"spec-question","color":"789abe"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-01T09:58:20Z","updated_at":"2016-06-01T14:43:17Z","closed_at":null,"body":"As a Pattern Lab Node user, I use a configuration json file to define pattern states. Am I compliant with the spec? \r\n\r\n-----\r\n\r\n[Pattern States in PL/Node](https://github.com/pattern-lab/patternlab-node#pattern-states) use a key/value object defined in `patternlab-config.json` instead of the [PHP filename approach](http://patternlab.io/docs/pattern-states.html), which uses filename suffixes.\r\n\r\nHere's an example from the docs:\r\n\r\n```\r\n\"patternStates\": {\r\n  \"molecules-single-comment\" : \"complete\",\r\n  \"organisms-sticky-comment\" : \"inreview\",\r\n  \"templates-article\" : \"complete\"\r\n}\r\n```\r\n\r\nThis was a conscious decision made at time of implementation, with the following benefits:\r\n\r\n* reduce fatigue with yet more regexes\r\n* I also thought it'd be simpler to change states in one place rather than have to rename files- an action, that, in my opinion, always feels costly from a UX perspective (just clicking through and editing) and results in a mess for version control systems.\r\n\r\nThis deviation would, however, make someone porting from PL/* to the other a bit more cumbersome. Though, pattern states might be low on their priority list when switching anyways.\r\n\r\n**What I am asking with this question is whether or not this deviation from PHP is in spec.**\r\n\r\nThe timeline for this feature is dependent on the outcome of this issue, as spec compliance is a goal of PL/Node. \r\n\r\nTagging spec-question because I need input regarding compliance, and am not proposing a change to PHP's strategy.\r\n\r\nThis issue does not require a vote in my opinion, but we should perhaps open a process question to determine how questions like this are handled officially in the future. I'll wait to create one until after this issue shakes out.\r\n\r\n/cc @pattern-lab/voting-members\r\n\r\n \r\n"},"comment":{"url":"https://api.github.com/repos/pattern-lab/the-spec/issues/comments/223014786","html_url":"https://github.com/pattern-lab/the-spec/issues/16#issuecomment-223014786","issue_url":"https://api.github.com/repos/pattern-lab/the-spec/issues/16","id":223014786,"user":{"login":"bmuenzenmeyer","id":298435,"avatar_url":"https://avatars.githubusercontent.com/u/298435?v=3","gravatar_id":"","url":"https://api.github.com/users/bmuenzenmeyer","html_url":"https://github.com/bmuenzenmeyer","followers_url":"https://api.github.com/users/bmuenzenmeyer/followers","following_url":"https://api.github.com/users/bmuenzenmeyer/following{/other_user}","gists_url":"https://api.github.com/users/bmuenzenmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuenzenmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuenzenmeyer/subscriptions","organizations_url":"https://api.github.com/users/bmuenzenmeyer/orgs","repos_url":"https://api.github.com/users/bmuenzenmeyer/repos","events_url":"https://api.github.com/users/bmuenzenmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/bmuenzenmeyer/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T14:43:17Z","updated_at":"2016-06-01T14:43:17Z","body":"As far as I know, some version control systems can recognize the rename while others cannot, which would result in delete/add's and loss of history.\r\n\r\nI am curious which method is preferred at scale, or if it matters, and both implementations could be considered _in spec_, the important part being the actual functionality, not the details.\r\n\r\nI envision that's exactly why we are having these discussions :dart: "}}
{"actor":{"display_login":"bmuenzenmeyer"}}