{"action":"closed","number":651,"pull_request":{"url":"https://api.github.com/repos/plone/mockup/pulls/651","id":63852765,"html_url":"https://github.com/plone/mockup/pull/651","diff_url":"https://github.com/plone/mockup/pull/651.diff","patch_url":"https://github.com/plone/mockup/pull/651.patch","issue_url":"https://api.github.com/repos/plone/mockup/issues/651","number":651,"state":"closed","locked":false,"title":"Structure pattern action items changes","user":{"login":"thet","id":170891,"avatar_url":"https://avatars.githubusercontent.com/u/170891?v=3","gravatar_id":"","url":"https://api.github.com/users/thet","html_url":"https://github.com/thet","followers_url":"https://api.github.com/users/thet/followers","following_url":"https://api.github.com/users/thet/following{/other_user}","gists_url":"https://api.github.com/users/thet/gists{/gist_id}","starred_url":"https://api.github.com/users/thet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thet/subscriptions","organizations_url":"https://api.github.com/users/thet/orgs","repos_url":"https://api.github.com/users/thet/repos","events_url":"https://api.github.com/users/thet/events{/privacy}","received_events_url":"https://api.github.com/users/thet/received_events","type":"User","site_admin":false},"body":"Here is a pull request with changes to structure pattern for some more config options (action menu, icon size), code cleanup, better view url support:\r\n\r\n- Allow definition of action menu items not only as dropdowns but also as buttons.\r\n- Add ``openItem`` and ``editItem`` actions as buttons and remove the open icon from the title column.\r\n- Open ``openItem`` links according to ``typeToViewAction`` instead of default with the ``/view`` postfix.\r\n- Open ``editItem`` under ``/@@edit`` instead ``/edit``.\r\n- Remove JS event handlers for externally opening simple URLs and use the href attribute instead.\r\n- Add ``iconCSS`` option for action menus items to add icons.\r\n- Add ``modal`` option for action menus items to allow links open in a modal.\r\n- Add ``iconSize`` option to set the icon size if a item has an image.\r\n- Use icons for all actionmenu entries.\r\n- Use the tooltip pattern for all actionmenu buttons.\r\n- Use pat-moment also for ``start``, ``end`` and ``last_comment_date`` columns.\r\n- For columns with date fields, show an empty column if the date value is 'None'.\r\n- Remove the checkbox and the actionmenu from the breadcrumbs bar for the current active folder to simplify the structure pattern.\r\n  The actionmenu contained redundant actions (cut, copy, paste) and selecting the current folder is possible one level up.\r\n\r\nThe ``typeToViewAction`` configuration option uses sane defaults - the same as in a standard Plone installation. ``File``, ``Image`` and ``Blob`` are all mapped to ``/view``. ``plone.app.z3cform`` et al has to be changed to spit out these config options according to the ``plone.types_use_view_action_in_listings`` registry entries.\r\n\r\n``typeToViewAction`` is an object in the form ``{'TYPE': 'VIEW_URL'}``, e.g. ``{'File': '/view'}``. Currently Plone uses only ``/view``. I thought making the view url configurable for each type makes the whole structure pattern a bit more generic. Maybe that's nonsense, comments welcome like for everything else.\r\n\r\nHere are two screenshots showing the difference between old and new default action items.\r\nOld:\r\n![folder_contents_old](https://cloud.githubusercontent.com/assets/170891/13986005/479914a0-f100-11e5-8eaa-389013b3ebdd.png)\r\n\r\nNew:\r\n![folder_contents_new](https://cloud.githubusercontent.com/assets/170891/13986013/4dba952a-f100-11e5-9600-a5f15ac84d01.png)\r\n","created_at":"2016-03-23T09:30:40Z","updated_at":"2016-04-04T22:08:16Z","closed_at":"2016-04-04T22:08:16Z","merged_at":"2016-04-04T22:08:16Z","merge_commit_sha":"324bf5d86e7af3f238731099f09333d7fe9d5a82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plone/mockup/pulls/651/commits","review_comments_url":"https://api.github.com/repos/plone/mockup/pulls/651/comments","review_comment_url":"https://api.github.com/repos/plone/mockup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plone/mockup/issues/651/comments","statuses_url":"https://api.github.com/repos/plone/mockup/statuses/b80a592c715bd3d28ec5edc0f774ae884f5d547c","head":{"label":"plone:thet-structure","ref":"thet-structure","sha":"b80a592c715bd3d28ec5edc0f774ae884f5d547c","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":6982635,"name":"mockup","full_name":"plone/mockup","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/mockup","description":"A collection of client side patterns for faster and easier web development","fork":false,"url":"https://api.github.com/repos/plone/mockup","forks_url":"https://api.github.com/repos/plone/mockup/forks","keys_url":"https://api.github.com/repos/plone/mockup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/mockup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/mockup/teams","hooks_url":"https://api.github.com/repos/plone/mockup/hooks","issue_events_url":"https://api.github.com/repos/plone/mockup/issues/events{/number}","events_url":"https://api.github.com/repos/plone/mockup/events","assignees_url":"https://api.github.com/repos/plone/mockup/assignees{/user}","branches_url":"https://api.github.com/repos/plone/mockup/branches{/branch}","tags_url":"https://api.github.com/repos/plone/mockup/tags","blobs_url":"https://api.github.com/repos/plone/mockup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/mockup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/mockup/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/mockup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/mockup/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/mockup/languages","stargazers_url":"https://api.github.com/repos/plone/mockup/stargazers","contributors_url":"https://api.github.com/repos/plone/mockup/contributors","subscribers_url":"https://api.github.com/repos/plone/mockup/subscribers","subscription_url":"https://api.github.com/repos/plone/mockup/subscription","commits_url":"https://api.github.com/repos/plone/mockup/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/mockup/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/mockup/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/mockup/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/mockup/contents/{+path}","compare_url":"https://api.github.com/repos/plone/mockup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/mockup/merges","archive_url":"https://api.github.com/repos/plone/mockup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/mockup/downloads","issues_url":"https://api.github.com/repos/plone/mockup/issues{/number}","pulls_url":"https://api.github.com/repos/plone/mockup/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/mockup/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/mockup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/mockup/labels{/name}","releases_url":"https://api.github.com/repos/plone/mockup/releases{/id}","deployments_url":"https://api.github.com/repos/plone/mockup/deployments","created_at":"2012-12-03T13:25:05Z","updated_at":"2016-03-29T13:41:25Z","pushed_at":"2016-04-04T22:08:16Z","git_url":"git://github.com/plone/mockup.git","ssh_url":"git@github.com:plone/mockup.git","clone_url":"https://github.com/plone/mockup.git","svn_url":"https://github.com/plone/mockup","homepage":"http://plone.github.io/mockup/dev/","size":46788,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":38,"forks":55,"open_issues":38,"watchers":33,"default_branch":"master"}},"base":{"label":"plone:master","ref":"master","sha":"b23fd52b66ba4dcb05e3a2fda40b3a70df3cc836","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":6982635,"name":"mockup","full_name":"plone/mockup","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/mockup","description":"A collection of client side patterns for faster and easier web development","fork":false,"url":"https://api.github.com/repos/plone/mockup","forks_url":"https://api.github.com/repos/plone/mockup/forks","keys_url":"https://api.github.com/repos/plone/mockup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/mockup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/mockup/teams","hooks_url":"https://api.github.com/repos/plone/mockup/hooks","issue_events_url":"https://api.github.com/repos/plone/mockup/issues/events{/number}","events_url":"https://api.github.com/repos/plone/mockup/events","assignees_url":"https://api.github.com/repos/plone/mockup/assignees{/user}","branches_url":"https://api.github.com/repos/plone/mockup/branches{/branch}","tags_url":"https://api.github.com/repos/plone/mockup/tags","blobs_url":"https://api.github.com/repos/plone/mockup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/mockup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/mockup/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/mockup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/mockup/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/mockup/languages","stargazers_url":"https://api.github.com/repos/plone/mockup/stargazers","contributors_url":"https://api.github.com/repos/plone/mockup/contributors","subscribers_url":"https://api.github.com/repos/plone/mockup/subscribers","subscription_url":"https://api.github.com/repos/plone/mockup/subscription","commits_url":"https://api.github.com/repos/plone/mockup/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/mockup/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/mockup/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/mockup/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/mockup/contents/{+path}","compare_url":"https://api.github.com/repos/plone/mockup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/mockup/merges","archive_url":"https://api.github.com/repos/plone/mockup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/mockup/downloads","issues_url":"https://api.github.com/repos/plone/mockup/issues{/number}","pulls_url":"https://api.github.com/repos/plone/mockup/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/mockup/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/mockup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/mockup/labels{/name}","releases_url":"https://api.github.com/repos/plone/mockup/releases{/id}","deployments_url":"https://api.github.com/repos/plone/mockup/deployments","created_at":"2012-12-03T13:25:05Z","updated_at":"2016-03-29T13:41:25Z","pushed_at":"2016-04-04T22:08:16Z","git_url":"git://github.com/plone/mockup.git","ssh_url":"git@github.com:plone/mockup.git","clone_url":"https://github.com/plone/mockup.git","svn_url":"https://github.com/plone/mockup","homepage":"http://plone.github.io/mockup/dev/","size":46788,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":38,"forks":55,"open_issues":38,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plone/mockup/pulls/651"},"html":{"href":"https://github.com/plone/mockup/pull/651"},"issue":{"href":"https://api.github.com/repos/plone/mockup/issues/651"},"comments":{"href":"https://api.github.com/repos/plone/mockup/issues/651/comments"},"review_comments":{"href":"https://api.github.com/repos/plone/mockup/pulls/651/comments"},"review_comment":{"href":"https://api.github.com/repos/plone/mockup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plone/mockup/pulls/651/commits"},"statuses":{"href":"https://api.github.com/repos/plone/mockup/statuses/b80a592c715bd3d28ec5edc0f774ae884f5d547c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jensens","id":157140,"avatar_url":"https://avatars.githubusercontent.com/u/157140?v=3","gravatar_id":"","url":"https://api.github.com/users/jensens","html_url":"https://github.com/jensens","followers_url":"https://api.github.com/users/jensens/followers","following_url":"https://api.github.com/users/jensens/following{/other_user}","gists_url":"https://api.github.com/users/jensens/gists{/gist_id}","starred_url":"https://api.github.com/users/jensens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensens/subscriptions","organizations_url":"https://api.github.com/users/jensens/orgs","repos_url":"https://api.github.com/users/jensens/repos","events_url":"https://api.github.com/users/jensens/events{/privacy}","received_events_url":"https://api.github.com/users/jensens/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"commits":16,"additions":834,"deletions":484,"changed_files":18}}