{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls/20","id":76713431,"html_url":"https://github.com/TakeScoop/SwiftyRSA/pull/20","diff_url":"https://github.com/TakeScoop/SwiftyRSA/pull/20.diff","patch_url":"https://github.com/TakeScoop/SwiftyRSA/pull/20.patch","issue_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues/20","number":20,"state":"closed","locked":false,"title":"Swift 3.0 changes","user":{"login":"ldiqual","id":941453,"avatar_url":"https://avatars.githubusercontent.com/u/941453?v=3","gravatar_id":"","url":"https://api.github.com/users/ldiqual","html_url":"https://github.com/ldiqual","followers_url":"https://api.github.com/users/ldiqual/followers","following_url":"https://api.github.com/users/ldiqual/following{/other_user}","gists_url":"https://api.github.com/users/ldiqual/gists{/gist_id}","starred_url":"https://api.github.com/users/ldiqual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldiqual/subscriptions","organizations_url":"https://api.github.com/users/ldiqual/orgs","repos_url":"https://api.github.com/users/ldiqual/repos","events_url":"https://api.github.com/users/ldiqual/events{/privacy}","received_events_url":"https://api.github.com/users/ldiqual/received_events","type":"User","site_admin":false},"body":"@paulw11 @quentinlesceller Please review\r\n\r\n### Checklist\r\n\r\n - [ ] Make tests pass on Xcode 8 beta\r\n - [ ] Change circle.yml to support Xcode 8 beta (not available yet)\r\n\r\n### Description\r\n\r\nThis fixes all the swift 3.0 errors for SwiftyRSA. It required adding a Data+SHA.swift bridge for our ObjC SHAx helpers.\r\n\r\n### Tests\r\n\r\nImportant note: none of the tests pass because of an iOS 10 or Xcode 8 bug:\r\n\r\n```\r\n...\r\nTest Case '-[SwiftyRSAObjcTests testDataEncryptDecrypt]' started.\r\n2016-07-08 00:38:24.079048 xctest[77869:1841902] [OSStatus] error:[-34018] Error Domain=NSOSStatusErrorDomain Code=-34018 \"client has neither application-identifier nor keychain-access-groups entitlements\" UserInfo={NSDescription=client has neither application-identifier nor keychain-access-groups entitlements}\r\n```\r\n\r\nRelated post on the Apple Dev forum: https://forums.developer.apple.com/thread/51071\r\n\r\n### Additional details\r\n\r\nAfter we merge this into `swift-3.0`, I'd like to start making the API feel more \"swifty\" by renaming most of the methods. A couple examples:\r\n\r\n```\r\n- encryptData(data)\r\n- encryptString(string)\r\n+ encrypt(data: data)\r\n+ encrypt(string: string)\r\n\r\n- verifySignatureData(data)\r\n+ verifySignature(data: data)\r\n\r\netc.\r\n```\r\n\r\nWhat do you think?","created_at":"2016-07-08T07:44:29Z","updated_at":"2016-09-15T16:26:16Z","closed_at":"2016-09-15T16:26:16Z","merged_at":"2016-09-15T16:26:16Z","merge_commit_sha":"ec8961648b2e78cd47b906a2f2e19d80e84ef899","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls/20/commits","review_comments_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls/20/comments","review_comment_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues/20/comments","statuses_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/statuses/1a10d968ca40cbfb6d4bf47e778fda9edbb7abda","head":{"label":"TakeScoop:lois-swift3","ref":"lois-swift3","sha":"1a10d968ca40cbfb6d4bf47e778fda9edbb7abda","user":{"login":"TakeScoop","id":11507053,"avatar_url":"https://avatars.githubusercontent.com/u/11507053?v=3","gravatar_id":"","url":"https://api.github.com/users/TakeScoop","html_url":"https://github.com/TakeScoop","followers_url":"https://api.github.com/users/TakeScoop/followers","following_url":"https://api.github.com/users/TakeScoop/following{/other_user}","gists_url":"https://api.github.com/users/TakeScoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TakeScoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TakeScoop/subscriptions","organizations_url":"https://api.github.com/users/TakeScoop/orgs","repos_url":"https://api.github.com/users/TakeScoop/repos","events_url":"https://api.github.com/users/TakeScoop/events{/privacy}","received_events_url":"https://api.github.com/users/TakeScoop/received_events","type":"Organization","site_admin":false},"repo":{"id":38462337,"name":"SwiftyRSA","full_name":"TakeScoop/SwiftyRSA","owner":{"login":"TakeScoop","id":11507053,"avatar_url":"https://avatars.githubusercontent.com/u/11507053?v=3","gravatar_id":"","url":"https://api.github.com/users/TakeScoop","html_url":"https://github.com/TakeScoop","followers_url":"https://api.github.com/users/TakeScoop/followers","following_url":"https://api.github.com/users/TakeScoop/following{/other_user}","gists_url":"https://api.github.com/users/TakeScoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TakeScoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TakeScoop/subscriptions","organizations_url":"https://api.github.com/users/TakeScoop/orgs","repos_url":"https://api.github.com/users/TakeScoop/repos","events_url":"https://api.github.com/users/TakeScoop/events{/privacy}","received_events_url":"https://api.github.com/users/TakeScoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TakeScoop/SwiftyRSA","description":"RSA public/private key encryption in Swift","fork":false,"url":"https://api.github.com/repos/TakeScoop/SwiftyRSA","forks_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/forks","keys_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/teams","hooks_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/hooks","issue_events_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues/events{/number}","events_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/events","assignees_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/assignees{/user}","branches_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/branches{/branch}","tags_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/tags","blobs_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/refs{/sha}","trees_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/statuses/{sha}","languages_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/languages","stargazers_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/stargazers","contributors_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/contributors","subscribers_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/subscribers","subscription_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/subscription","commits_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/commits{/sha}","git_commits_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/commits{/sha}","comments_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/comments{/number}","issue_comment_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues/comments{/number}","contents_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/contents/{+path}","compare_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/merges","archive_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/downloads","issues_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues{/number}","pulls_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls{/number}","milestones_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/milestones{/number}","notifications_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/labels{/name}","releases_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/releases{/id}","deployments_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/deployments","created_at":"2015-07-02T23:49:45Z","updated_at":"2016-09-13T19:08:02Z","pushed_at":"2016-09-15T16:26:18Z","git_url":"git://github.com/TakeScoop/SwiftyRSA.git","ssh_url":"git@github.com:TakeScoop/SwiftyRSA.git","clone_url":"https://github.com/TakeScoop/SwiftyRSA.git","svn_url":"https://github.com/TakeScoop/SwiftyRSA","homepage":null,"size":343,"stargazers_count":195,"watchers_count":195,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":195,"default_branch":"master"}},"base":{"label":"TakeScoop:swift-3.0","ref":"swift-3.0","sha":"8b01ef8d1cfdeb50dd2debf6560559c4418e9678","user":{"login":"TakeScoop","id":11507053,"avatar_url":"https://avatars.githubusercontent.com/u/11507053?v=3","gravatar_id":"","url":"https://api.github.com/users/TakeScoop","html_url":"https://github.com/TakeScoop","followers_url":"https://api.github.com/users/TakeScoop/followers","following_url":"https://api.github.com/users/TakeScoop/following{/other_user}","gists_url":"https://api.github.com/users/TakeScoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TakeScoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TakeScoop/subscriptions","organizations_url":"https://api.github.com/users/TakeScoop/orgs","repos_url":"https://api.github.com/users/TakeScoop/repos","events_url":"https://api.github.com/users/TakeScoop/events{/privacy}","received_events_url":"https://api.github.com/users/TakeScoop/received_events","type":"Organization","site_admin":false},"repo":{"id":38462337,"name":"SwiftyRSA","full_name":"TakeScoop/SwiftyRSA","owner":{"login":"TakeScoop","id":11507053,"avatar_url":"https://avatars.githubusercontent.com/u/11507053?v=3","gravatar_id":"","url":"https://api.github.com/users/TakeScoop","html_url":"https://github.com/TakeScoop","followers_url":"https://api.github.com/users/TakeScoop/followers","following_url":"https://api.github.com/users/TakeScoop/following{/other_user}","gists_url":"https://api.github.com/users/TakeScoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TakeScoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TakeScoop/subscriptions","organizations_url":"https://api.github.com/users/TakeScoop/orgs","repos_url":"https://api.github.com/users/TakeScoop/repos","events_url":"https://api.github.com/users/TakeScoop/events{/privacy}","received_events_url":"https://api.github.com/users/TakeScoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TakeScoop/SwiftyRSA","description":"RSA public/private key encryption in Swift","fork":false,"url":"https://api.github.com/repos/TakeScoop/SwiftyRSA","forks_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/forks","keys_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/teams","hooks_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/hooks","issue_events_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues/events{/number}","events_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/events","assignees_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/assignees{/user}","branches_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/branches{/branch}","tags_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/tags","blobs_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/refs{/sha}","trees_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/statuses/{sha}","languages_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/languages","stargazers_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/stargazers","contributors_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/contributors","subscribers_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/subscribers","subscription_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/subscription","commits_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/commits{/sha}","git_commits_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/git/commits{/sha}","comments_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/comments{/number}","issue_comment_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues/comments{/number}","contents_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/contents/{+path}","compare_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/merges","archive_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/downloads","issues_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues{/number}","pulls_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls{/number}","milestones_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/milestones{/number}","notifications_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/labels{/name}","releases_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/releases{/id}","deployments_url":"https://api.github.com/repos/TakeScoop/SwiftyRSA/deployments","created_at":"2015-07-02T23:49:45Z","updated_at":"2016-09-13T19:08:02Z","pushed_at":"2016-09-15T16:26:18Z","git_url":"git://github.com/TakeScoop/SwiftyRSA.git","ssh_url":"git@github.com:TakeScoop/SwiftyRSA.git","clone_url":"https://github.com/TakeScoop/SwiftyRSA.git","svn_url":"https://github.com/TakeScoop/SwiftyRSA","homepage":null,"size":343,"stargazers_count":195,"watchers_count":195,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls/20"},"html":{"href":"https://github.com/TakeScoop/SwiftyRSA/pull/20"},"issue":{"href":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues/20"},"comments":{"href":"https://api.github.com/repos/TakeScoop/SwiftyRSA/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TakeScoop/SwiftyRSA/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/TakeScoop/SwiftyRSA/statuses/1a10d968ca40cbfb6d4bf47e778fda9edbb7abda"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ldiqual","id":941453,"avatar_url":"https://avatars.githubusercontent.com/u/941453?v=3","gravatar_id":"","url":"https://api.github.com/users/ldiqual","html_url":"https://github.com/ldiqual","followers_url":"https://api.github.com/users/ldiqual/followers","following_url":"https://api.github.com/users/ldiqual/following{/other_user}","gists_url":"https://api.github.com/users/ldiqual/gists{/gist_id}","starred_url":"https://api.github.com/users/ldiqual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldiqual/subscriptions","organizations_url":"https://api.github.com/users/ldiqual/orgs","repos_url":"https://api.github.com/users/ldiqual/repos","events_url":"https://api.github.com/users/ldiqual/events{/privacy}","received_events_url":"https://api.github.com/users/ldiqual/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":14,"additions":3200,"deletions":422,"changed_files":24}}
{"actor":{"display_login":"ldiqual"}}