{"action":"created","comment":{"url":"https://api.github.com/repos/poparteu/openMVG/pulls/comments/61296786","id":61296786,"diff_hunk":"@@ -108,11 +108,13 @@ class Pinhole_Intrinsic : public IntrinsicBase\n   // Data wrapper for non linear optimization (update from data)\n   virtual bool updateFromParams(const std::vector<double> & params)\n   {\n-    if (params.size() == 3) {\n-      *this = Pinhole_Intrinsic(_w, _h, params[0], params[1], params[2]);\n+    if (params.size() == 3)\n+    {\n+      this->setK(params[0], params[1], params[2]);","path":"src/openMVG/cameras/Camera_Pinhole.hpp","position":8,"original_position":8,"commit_id":"fa1186c4f88297c69552412c2442fae682101373","original_commit_id":"fa1186c4f88297c69552412c2442fae682101373","user":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"body":"dunno, isn't that we are replicating code here, instead of calling the constructor?\r\nI mean, if for some reason we were to add another parameter one day we need to change the constructor AND here. But I don't know, it's true that it will be not likely the case ...","created_at":"2016-04-27T17:04:45Z","updated_at":"2016-04-27T17:04:45Z","html_url":"https://github.com/poparteu/openMVG/pull/151#discussion_r61296786","pull_request_url":"https://api.github.com/repos/poparteu/openMVG/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/comments/61296786"},"html":{"href":"https://github.com/poparteu/openMVG/pull/151#discussion_r61296786"},"pull_request":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/poparteu/openMVG/pulls/151","id":67178425,"html_url":"https://github.com/poparteu/openMVG/pull/151","diff_url":"https://github.com/poparteu/openMVG/pull/151.diff","patch_url":"https://github.com/poparteu/openMVG/pull/151.patch","issue_url":"https://api.github.com/repos/poparteu/openMVG/issues/151","number":151,"state":"open","locked":false,"title":"sequential SfM: performance improvements for large scale datasets","user":{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"body":"This PR mainly improve performances of incremental SfM for large datasets.\r\nMain changes:\r\n* optimize the data structures\r\n* improve the next best view search for performances\r\n* reduce the number of intermediate file save\r\n* remove the CCTag specific thresholds\r\n* use stronger thresholds to improve robustness\r\n\r\nThe impact of the optimizations are 5x faster for 800 images and 10x faster for 2800 images.\r\nThis is a performance comparison regarding the optimizations. The fact that we reduce the number of intermediate generated files further improve the performances.","created_at":"2016-04-20T12:34:12Z","updated_at":"2016-04-27T17:04:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0463833e77200bb04acf6d51ccb3d95c29afa5c5","assignee":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/poparteu/openMVG/pulls/151/commits","review_comments_url":"https://api.github.com/repos/poparteu/openMVG/pulls/151/comments","review_comment_url":"https://api.github.com/repos/poparteu/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poparteu/openMVG/issues/151/comments","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/fa1186c4f88297c69552412c2442fae682101373","head":{"label":"poparteu:dev_largescaledataset","ref":"dev_largescaledataset","sha":"fa1186c4f88297c69552412c2442fae682101373","user":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"poparteu/openMVG","owner":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poparteu/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/poparteu/openMVG","forks_url":"https://api.github.com/repos/poparteu/openMVG/forks","keys_url":"https://api.github.com/repos/poparteu/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poparteu/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poparteu/openMVG/teams","hooks_url":"https://api.github.com/repos/poparteu/openMVG/hooks","issue_events_url":"https://api.github.com/repos/poparteu/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/poparteu/openMVG/events","assignees_url":"https://api.github.com/repos/poparteu/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/poparteu/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/poparteu/openMVG/tags","blobs_url":"https://api.github.com/repos/poparteu/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poparteu/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poparteu/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/poparteu/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/poparteu/openMVG/languages","stargazers_url":"https://api.github.com/repos/poparteu/openMVG/stargazers","contributors_url":"https://api.github.com/repos/poparteu/openMVG/contributors","subscribers_url":"https://api.github.com/repos/poparteu/openMVG/subscribers","subscription_url":"https://api.github.com/repos/poparteu/openMVG/subscription","commits_url":"https://api.github.com/repos/poparteu/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/poparteu/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/poparteu/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/poparteu/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/poparteu/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/poparteu/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poparteu/openMVG/merges","archive_url":"https://api.github.com/repos/poparteu/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poparteu/openMVG/downloads","issues_url":"https://api.github.com/repos/poparteu/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/poparteu/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/poparteu/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/poparteu/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poparteu/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/poparteu/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/poparteu/openMVG/deployments","created_at":"2014-12-30T15:39:27Z","updated_at":"2016-01-28T19:18:10Z","pushed_at":"2016-04-26T14:37:45Z","git_url":"git://github.com/poparteu/openMVG.git","ssh_url":"git@github.com:poparteu/openMVG.git","clone_url":"https://github.com/poparteu/openMVG.git","svn_url":"https://github.com/poparteu/openMVG","homepage":"","size":22821,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":49,"forks":1,"open_issues":49,"watchers":1,"default_branch":"popart_develop"}},"base":{"label":"poparteu:popart_develop","ref":"popart_develop","sha":"fba9fe93b3dee08875ecafd92801d7d6e65ab9e8","user":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"poparteu/openMVG","owner":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poparteu/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/poparteu/openMVG","forks_url":"https://api.github.com/repos/poparteu/openMVG/forks","keys_url":"https://api.github.com/repos/poparteu/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poparteu/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poparteu/openMVG/teams","hooks_url":"https://api.github.com/repos/poparteu/openMVG/hooks","issue_events_url":"https://api.github.com/repos/poparteu/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/poparteu/openMVG/events","assignees_url":"https://api.github.com/repos/poparteu/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/poparteu/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/poparteu/openMVG/tags","blobs_url":"https://api.github.com/repos/poparteu/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poparteu/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poparteu/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/poparteu/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/poparteu/openMVG/languages","stargazers_url":"https://api.github.com/repos/poparteu/openMVG/stargazers","contributors_url":"https://api.github.com/repos/poparteu/openMVG/contributors","subscribers_url":"https://api.github.com/repos/poparteu/openMVG/subscribers","subscription_url":"https://api.github.com/repos/poparteu/openMVG/subscription","commits_url":"https://api.github.com/repos/poparteu/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/poparteu/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/poparteu/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/poparteu/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/poparteu/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/poparteu/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poparteu/openMVG/merges","archive_url":"https://api.github.com/repos/poparteu/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poparteu/openMVG/downloads","issues_url":"https://api.github.com/repos/poparteu/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/poparteu/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/poparteu/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/poparteu/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poparteu/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/poparteu/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/poparteu/openMVG/deployments","created_at":"2014-12-30T15:39:27Z","updated_at":"2016-01-28T19:18:10Z","pushed_at":"2016-04-26T14:37:45Z","git_url":"git://github.com/poparteu/openMVG.git","ssh_url":"git@github.com:poparteu/openMVG.git","clone_url":"https://github.com/poparteu/openMVG.git","svn_url":"https://github.com/poparteu/openMVG","homepage":"","size":22821,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":49,"forks":1,"open_issues":49,"watchers":1,"default_branch":"popart_develop"}},"_links":{"self":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/151"},"html":{"href":"https://github.com/poparteu/openMVG/pull/151"},"issue":{"href":"https://api.github.com/repos/poparteu/openMVG/issues/151"},"comments":{"href":"https://api.github.com/repos/poparteu/openMVG/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/poparteu/openMVG/statuses/fa1186c4f88297c69552412c2442fae682101373"}}}}