{"action":"created","comment":{"url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/comments/81262787","pull_request_review_id":2255701,"id":81262787,"diff_hunk":"@@ -66,7 +66,9 @@ macro_rules! mulo {\n     }\n }\n \n+#[cfg(not(all(feature = \"c\", target_arch = \"x86\")))]","path":"src/int/mul.rs","position":4,"original_position":4,"commit_id":"62258b5188e6f993f1f746fb616238309884dff3","original_commit_id":"62258b5188e6f993f1f746fb616238309884dff3","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"body":"There's a comment about this in src/lib.rs. We have generic implementations of some intrinsics written in Rust but for some of those intrinsics, compiler-rt has arch-optimized implementations written in assembly. We want to use compiler-rt arch optimized impls where available; in those cases, build.rs will compile them and these cfgs remove our Rust impl from the library so we don't end with duplicate symbols.","created_at":"2016-09-30T00:40:39Z","updated_at":"2016-09-30T00:40:39Z","html_url":"https://github.com/japaric/rustc-builtins/pull/74#discussion_r81262787","pull_request_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/comments/81262787"},"html":{"href":"https://github.com/japaric/rustc-builtins/pull/74#discussion_r81262787"},"pull_request":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/74","id":86818482,"html_url":"https://github.com/japaric/rustc-builtins/pull/74","diff_url":"https://github.com/japaric/rustc-builtins/pull/74.diff","patch_url":"https://github.com/japaric/rustc-builtins/pull/74.patch","issue_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/74","number":74,"state":"open","locked":false,"title":"add an opt-in cargo feature to build intrinsics from compiler-rt source","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"body":"closes #63\r\ncc #66 \r\n\r\nThis uses the build.rs version from rust-lang/rust#36512 minus the dependency on llvm-target being in `rustc --print cfg`\r\n\r\ncc @alexcrichton I forgot to ask before but how do you feel about using the `rustc-cfg` crate, which parses the output of `rustc --print cfg` and exposes the target specification as a Rust `struct`, in the build.rs? Its functionality overlaps with what you proposed in rust-lang/rfcs#1721 i.e. CARGO_CFG_TARGET_OS, etc.\r\n\r\nTODO stop compiling the C version of the intrinsics that we have already ported to Rust.\r\n","created_at":"2016-09-26T21:04:05Z","updated_at":"2016-09-30T00:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7962dd870b044f754c2db42ca810711499126285","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/74/commits","review_comments_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/74/comments","review_comment_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/74/comments","statuses_url":"https://api.github.com/repos/japaric/rustc-builtins/statuses/62258b5188e6f993f1f746fb616238309884dff3","head":{"label":"japaric:c","ref":"c","sha":"62258b5188e6f993f1f746fb616238309884dff3","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"repo":{"id":65153793,"name":"rustc-builtins","full_name":"japaric/rustc-builtins","owner":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/japaric/rustc-builtins","description":"[WIP] Porting `compiler-rt` intrinsics to Rust","fork":false,"url":"https://api.github.com/repos/japaric/rustc-builtins","forks_url":"https://api.github.com/repos/japaric/rustc-builtins/forks","keys_url":"https://api.github.com/repos/japaric/rustc-builtins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/japaric/rustc-builtins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/japaric/rustc-builtins/teams","hooks_url":"https://api.github.com/repos/japaric/rustc-builtins/hooks","issue_events_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/events{/number}","events_url":"https://api.github.com/repos/japaric/rustc-builtins/events","assignees_url":"https://api.github.com/repos/japaric/rustc-builtins/assignees{/user}","branches_url":"https://api.github.com/repos/japaric/rustc-builtins/branches{/branch}","tags_url":"https://api.github.com/repos/japaric/rustc-builtins/tags","blobs_url":"https://api.github.com/repos/japaric/rustc-builtins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/japaric/rustc-builtins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/japaric/rustc-builtins/git/refs{/sha}","trees_url":"https://api.github.com/repos/japaric/rustc-builtins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/japaric/rustc-builtins/statuses/{sha}","languages_url":"https://api.github.com/repos/japaric/rustc-builtins/languages","stargazers_url":"https://api.github.com/repos/japaric/rustc-builtins/stargazers","contributors_url":"https://api.github.com/repos/japaric/rustc-builtins/contributors","subscribers_url":"https://api.github.com/repos/japaric/rustc-builtins/subscribers","subscription_url":"https://api.github.com/repos/japaric/rustc-builtins/subscription","commits_url":"https://api.github.com/repos/japaric/rustc-builtins/commits{/sha}","git_commits_url":"https://api.github.com/repos/japaric/rustc-builtins/git/commits{/sha}","comments_url":"https://api.github.com/repos/japaric/rustc-builtins/comments{/number}","issue_comment_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/comments{/number}","contents_url":"https://api.github.com/repos/japaric/rustc-builtins/contents/{+path}","compare_url":"https://api.github.com/repos/japaric/rustc-builtins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/japaric/rustc-builtins/merges","archive_url":"https://api.github.com/repos/japaric/rustc-builtins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/japaric/rustc-builtins/downloads","issues_url":"https://api.github.com/repos/japaric/rustc-builtins/issues{/number}","pulls_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls{/number}","milestones_url":"https://api.github.com/repos/japaric/rustc-builtins/milestones{/number}","notifications_url":"https://api.github.com/repos/japaric/rustc-builtins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/japaric/rustc-builtins/labels{/name}","releases_url":"https://api.github.com/repos/japaric/rustc-builtins/releases{/id}","deployments_url":"https://api.github.com/repos/japaric/rustc-builtins/deployments","created_at":"2016-08-07T20:58:44Z","updated_at":"2016-09-27T18:32:48Z","pushed_at":"2016-09-30T00:21:43Z","git_url":"git://github.com/japaric/rustc-builtins.git","ssh_url":"git@github.com:japaric/rustc-builtins.git","clone_url":"https://github.com/japaric/rustc-builtins.git","svn_url":"https://github.com/japaric/rustc-builtins","homepage":"https://github.com/rust-lang/rust/issues/35437","size":165,"stargazers_count":16,"watchers_count":16,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":16,"default_branch":"master"}},"base":{"label":"japaric:master","ref":"master","sha":"69e93de9d9abd9ba1f59be1e921ee4bb95eb33fb","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"repo":{"id":65153793,"name":"rustc-builtins","full_name":"japaric/rustc-builtins","owner":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/japaric/rustc-builtins","description":"[WIP] Porting `compiler-rt` intrinsics to Rust","fork":false,"url":"https://api.github.com/repos/japaric/rustc-builtins","forks_url":"https://api.github.com/repos/japaric/rustc-builtins/forks","keys_url":"https://api.github.com/repos/japaric/rustc-builtins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/japaric/rustc-builtins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/japaric/rustc-builtins/teams","hooks_url":"https://api.github.com/repos/japaric/rustc-builtins/hooks","issue_events_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/events{/number}","events_url":"https://api.github.com/repos/japaric/rustc-builtins/events","assignees_url":"https://api.github.com/repos/japaric/rustc-builtins/assignees{/user}","branches_url":"https://api.github.com/repos/japaric/rustc-builtins/branches{/branch}","tags_url":"https://api.github.com/repos/japaric/rustc-builtins/tags","blobs_url":"https://api.github.com/repos/japaric/rustc-builtins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/japaric/rustc-builtins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/japaric/rustc-builtins/git/refs{/sha}","trees_url":"https://api.github.com/repos/japaric/rustc-builtins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/japaric/rustc-builtins/statuses/{sha}","languages_url":"https://api.github.com/repos/japaric/rustc-builtins/languages","stargazers_url":"https://api.github.com/repos/japaric/rustc-builtins/stargazers","contributors_url":"https://api.github.com/repos/japaric/rustc-builtins/contributors","subscribers_url":"https://api.github.com/repos/japaric/rustc-builtins/subscribers","subscription_url":"https://api.github.com/repos/japaric/rustc-builtins/subscription","commits_url":"https://api.github.com/repos/japaric/rustc-builtins/commits{/sha}","git_commits_url":"https://api.github.com/repos/japaric/rustc-builtins/git/commits{/sha}","comments_url":"https://api.github.com/repos/japaric/rustc-builtins/comments{/number}","issue_comment_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/comments{/number}","contents_url":"https://api.github.com/repos/japaric/rustc-builtins/contents/{+path}","compare_url":"https://api.github.com/repos/japaric/rustc-builtins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/japaric/rustc-builtins/merges","archive_url":"https://api.github.com/repos/japaric/rustc-builtins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/japaric/rustc-builtins/downloads","issues_url":"https://api.github.com/repos/japaric/rustc-builtins/issues{/number}","pulls_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls{/number}","milestones_url":"https://api.github.com/repos/japaric/rustc-builtins/milestones{/number}","notifications_url":"https://api.github.com/repos/japaric/rustc-builtins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/japaric/rustc-builtins/labels{/name}","releases_url":"https://api.github.com/repos/japaric/rustc-builtins/releases{/id}","deployments_url":"https://api.github.com/repos/japaric/rustc-builtins/deployments","created_at":"2016-08-07T20:58:44Z","updated_at":"2016-09-27T18:32:48Z","pushed_at":"2016-09-30T00:21:43Z","git_url":"git://github.com/japaric/rustc-builtins.git","ssh_url":"git@github.com:japaric/rustc-builtins.git","clone_url":"https://github.com/japaric/rustc-builtins.git","svn_url":"https://github.com/japaric/rustc-builtins","homepage":"https://github.com/rust-lang/rust/issues/35437","size":165,"stargazers_count":16,"watchers_count":16,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/74"},"html":{"href":"https://github.com/japaric/rustc-builtins/pull/74"},"issue":{"href":"https://api.github.com/repos/japaric/rustc-builtins/issues/74"},"comments":{"href":"https://api.github.com/repos/japaric/rustc-builtins/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/japaric/rustc-builtins/statuses/62258b5188e6f993f1f746fb616238309884dff3"}}}}
{"actor":{"display_login":"japaric"}}