{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments/79958986","id":79958986,"diff_hunk":"@@ -0,0 +1,138 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!--\n+  ~ Copyright 2016 Google Inc. All Rights Reserved.\n+  ~\n+  ~ Licensed under the Apache License, Version 2.0 (the \"License\");\n+  ~ you may not use this file except in compliance with the License.\n+  ~ You may obtain a copy of the License at\n+  ~\n+  ~       http://www.apache.org/licenses/LICENSE-2.0\n+  ~\n+  ~ Unless required by applicable law or agreed to in writing, software\n+  ~ distributed under the License is distributed on an \"AS IS\" BASIS,\n+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+  ~ See the License for the specific language governing permissions and\n+  ~ limitations under the License.\n+  -->\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd\">\n+  <modelVersion>4.0.0</modelVersion>\n+  <parent>\n+    <groupId>com.google.cloud.runtimes.jetty.tests</groupId>\n+    <artifactId>tests-parent</artifactId>\n+   <version>0.1.0-SNAPSHOT</version>\n+  </parent>\n+\n+  <artifactId>tests-webapps-parent</artifactId>\n+  <name>Jetty-Runtime :: Tests :: WebApps Parent</name>\n+  <packaging>pom</packaging>\n+\n+  <modules>\n+    <module>test-war-hello</module>\n+  </modules>\n+\n+  <dependencyManagement>\n+    <dependencies>\n+      <dependency>\n+        <groupId>org.eclipse.jetty.toolchain</groupId>\n+        <artifactId>jetty-test-helper</artifactId>\n+        <version>4.0</version>\n+        <scope>test</scope>\n+      </dependency>\n+    </dependencies>\n+  </dependencyManagement>\n+\n+  <build>\n+    <resources>\n+      <resource>\n+        <directory>src/main/docker</directory>\n+        <filtering>true</filtering>\n+        <targetPath>${project.build.directory}/docker</targetPath>\n+      </resource>\n+    </resources>\n+    <plugins>\n+      <plugin>\n+        <artifactId>maven-checkstyle-plugin</artifactId>\n+        <configuration>\n+          <!-- \n+             Tests cannot and should not be validated with checkstyle.\n+             these tests need to be flexible enough for good, bad, quirky\n+             and everything in between with regards to compliance and\n+             validity.\n+             Having them pass checkstyle makes them invalid for integration\n+             test cases\n+             -->\n+          <skip>true</skip>\n+        </configuration>\n+      </plugin>\n+      <plugin>\n+        <groupId>org.apache.maven.plugins</groupId>\n+        <artifactId>maven-failsafe-plugin</artifactId>\n+        <version>2.19.1</version>\n+        <dependencies>\n+          <dependency>\n+            <groupId>org.apache.maven.surefire</groupId>\n+            <artifactId>surefire-junit47</artifactId>\n+            <version>2.19.1</version>\n+          </dependency>\n+        </dependencies>\n+        <configuration>\n+          <systemPropertyVariables>\n+            <app.deploy.project>${app.deploy.project}</app.deploy.project>\n+            <app.deploy.version>${maven.build.timestamp}</app.deploy.version>\n+          </systemPropertyVariables>\n+        </configuration>\n+\n+      </plugin>\n+      <!-- This can be re-enabled when app-maven-plugin issue is fixed","path":"tests/webapps/pom.xml","position":86,"original_position":86,"commit_id":"3855a552bafa2903421a126d75e3c57fa37d9c88","original_commit_id":"3855a552bafa2903421a126d75e3c57fa37d9c88","user":{"login":"joakime","id":191721,"avatar_url":"https://avatars.githubusercontent.com/u/191721?v=3","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"body":"Done that already.  But this is a note (like others) for future refactoring once appengine-maven-plugin features catch up.","created_at":"2016-09-22T00:07:38Z","updated_at":"2016-09-22T00:12:40Z","html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/45#discussion_r79958986","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments/79958986"},"html":{"href":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/45#discussion_r79958986"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/45","id":85881224,"html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/45","diff_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/45.diff","patch_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/45.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/45","number":45,"state":"open","locked":false,"title":"Issue #8 - alternate /tests/ setup for 100% maven","user":{"login":"joakime","id":191721,"avatar_url":"https://avatars.githubusercontent.com/u/191721?v=3","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"body":"+ Deploys jetty9:testing (tagged) image in /jetty9/\r\n  module during integration-test phase\r\n+ Adds /tests/\r\n+ Adds /tests/webapps/\r\n+ Adds /tests/gcloud-testing-core/ for common testing lib","created_at":"2016-09-19T22:29:08Z","updated_at":"2016-09-22T00:12:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b2daf43af6c024226adac211aa02116ee4f1553","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/45/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/45/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/45/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/3855a552bafa2903421a126d75e3c57fa37d9c88","head":{"label":"joakime:issue-8-alt","ref":"issue-8-alt","sha":"3855a552bafa2903421a126d75e3c57fa37d9c88","user":{"login":"joakime","id":191721,"avatar_url":"https://avatars.githubusercontent.com/u/191721?v=3","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"repo":{"id":68043532,"name":"jetty-runtime","full_name":"joakime/jetty-runtime","owner":{"login":"joakime","id":191721,"avatar_url":"https://avatars.githubusercontent.com/u/191721?v=3","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joakime/jetty-runtime","description":null,"fork":true,"url":"https://api.github.com/repos/joakime/jetty-runtime","forks_url":"https://api.github.com/repos/joakime/jetty-runtime/forks","keys_url":"https://api.github.com/repos/joakime/jetty-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joakime/jetty-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joakime/jetty-runtime/teams","hooks_url":"https://api.github.com/repos/joakime/jetty-runtime/hooks","issue_events_url":"https://api.github.com/repos/joakime/jetty-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/joakime/jetty-runtime/events","assignees_url":"https://api.github.com/repos/joakime/jetty-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/joakime/jetty-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/joakime/jetty-runtime/tags","blobs_url":"https://api.github.com/repos/joakime/jetty-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joakime/jetty-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joakime/jetty-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/joakime/jetty-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joakime/jetty-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/joakime/jetty-runtime/languages","stargazers_url":"https://api.github.com/repos/joakime/jetty-runtime/stargazers","contributors_url":"https://api.github.com/repos/joakime/jetty-runtime/contributors","subscribers_url":"https://api.github.com/repos/joakime/jetty-runtime/subscribers","subscription_url":"https://api.github.com/repos/joakime/jetty-runtime/subscription","commits_url":"https://api.github.com/repos/joakime/jetty-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/joakime/jetty-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/joakime/jetty-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/joakime/jetty-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/joakime/jetty-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/joakime/jetty-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joakime/jetty-runtime/merges","archive_url":"https://api.github.com/repos/joakime/jetty-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joakime/jetty-runtime/downloads","issues_url":"https://api.github.com/repos/joakime/jetty-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/joakime/jetty-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/joakime/jetty-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/joakime/jetty-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joakime/jetty-runtime/labels{/name}","releases_url":"https://api.github.com/repos/joakime/jetty-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/joakime/jetty-runtime/deployments","created_at":"2016-09-12T20:07:50Z","updated_at":"2016-09-12T20:07:51Z","pushed_at":"2016-09-22T00:03:03Z","git_url":"git://github.com/joakime/jetty-runtime.git","ssh_url":"git@github.com:joakime/jetty-runtime.git","clone_url":"https://github.com/joakime/jetty-runtime.git","svn_url":"https://github.com/joakime/jetty-runtime","homepage":null,"size":2804,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"b29698e65c657a6f3c90aa895b6b090f189448f4","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":66016354,"name":"jetty-runtime","full_name":"GoogleCloudPlatform/jetty-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/deployments","created_at":"2016-08-18T17:14:04Z","updated_at":"2016-09-16T20:58:37Z","pushed_at":"2016-09-21T23:53:22Z","git_url":"git://github.com/GoogleCloudPlatform/jetty-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/jetty-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/jetty-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","homepage":null,"size":2742,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":39,"forks":2,"open_issues":39,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/45"},"html":{"href":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/45"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/45"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/3855a552bafa2903421a126d75e3c57fa37d9c88"}}}}
{"actor":{"display_login":"joakime"}}