{"action":"created","issue":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/1899","repository_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map","labels_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/1899/labels{/name}","comments_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/1899/comments","events_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/1899/events","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/1899","id":167257581,"number":1899,"title":"Add Rarity and Type info to data set and display rarity","user":{"login":"tim95030","id":3386549,"avatar_url":"https://avatars.githubusercontent.com/u/3386549?v=3","gravatar_id":"","url":"https://api.github.com/users/tim95030","html_url":"https://github.com/tim95030","followers_url":"https://api.github.com/users/tim95030/followers","following_url":"https://api.github.com/users/tim95030/following{/other_user}","gists_url":"https://api.github.com/users/tim95030/gists{/gist_id}","starred_url":"https://api.github.com/users/tim95030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim95030/subscriptions","organizations_url":"https://api.github.com/users/tim95030/orgs","repos_url":"https://api.github.com/users/tim95030/repos","events_url":"https://api.github.com/users/tim95030/events{/privacy}","received_events_url":"https://api.github.com/users/tim95030/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/labels/help%20wanted","name":"help wanted","color":"128A0C"},{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/labels/long%20term","name":"long term","color":"ddff7b"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-07-24T22:17:43Z","updated_at":"2016-07-25T21:59:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/pulls/1899","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/1899","diff_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/1899.diff","patch_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/1899.patch"},"body":"## Description\r\nThis feature adds a bunch of data collected from [Silph Road](https://thesilphroad.com/) that adds rarity, pokemon type, and spawn rate. This format also makes it easy to add new fields to this data. However, the current way the internationalization is done this isn't awesome.\r\n\r\n## Motivation and Context\r\nThis will add the ability to display the rarity for now. But also allows for future features to be easily added. Filter out all common drops with one click, show only pokemon of a certain type, etc.\r\n\r\n## How Has This Been Tested?\r\nI have currently only tested this on MacOS in Chrome, but the only real change is the data files and the display on the map so it seems unlikely to break other things. Extra testing for other locales would be appreciated and adding translations for the new fields is also needed before merging most likely. (Though currently it just displays an empty string for unknown field types like rarity)\r\n\r\n## Screenshots (if appropriate):\r\nNormal Pokemon\r\n<img width=\"324\" alt=\"screen shot 2016-07-24 at 3 16 13 pm\" src=\"https://cloud.githubusercontent.com/assets/3386549/17086863/b962c7e0-51b1-11e6-9330-2641ab3b02cc.png\">\r\nLured Pokemon\r\n<img width=\"315\" alt=\"screen shot 2016-07-24 at 4 59 11 pm\" src=\"https://cloud.githubusercontent.com/assets/3386549/17087468/faca948e-51bf-11e6-86d3-072f89465651.png\">\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n"},"comment":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/comments/235099117","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/1899#issuecomment-235099117","issue_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/1899","id":235099117,"user":{"login":"karezhest","id":20599458,"avatar_url":"https://avatars.githubusercontent.com/u/20599458?v=3","gravatar_id":"","url":"https://api.github.com/users/karezhest","html_url":"https://github.com/karezhest","followers_url":"https://api.github.com/users/karezhest/followers","following_url":"https://api.github.com/users/karezhest/following{/other_user}","gists_url":"https://api.github.com/users/karezhest/gists{/gist_id}","starred_url":"https://api.github.com/users/karezhest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karezhest/subscriptions","organizations_url":"https://api.github.com/users/karezhest/orgs","repos_url":"https://api.github.com/users/karezhest/repos","events_url":"https://api.github.com/users/karezhest/events{/privacy}","received_events_url":"https://api.github.com/users/karezhest/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T21:59:27Z","updated_at":"2016-07-25T21:59:27Z","body":"Do we want to add more languages? "}}
{"actor":{"display_login":"karezhest"}}