{"action":"created","comment":{"url":"https://api.github.com/repos/Expensify/Bedrock/pulls/comments/83742814","pull_request_review_id":4566571,"id":83742814,"diff_hunk":"@@ -265,7 +265,8 @@ bool BedrockPlugin_Jobs::processCommand(BedrockNode* node, SQLite& db, BedrockNo\n             SQResult result;\n             if (!db.read(\"SELECT 1 \"\n                          \"FROM jobs \"\n-                         \"WHERE jobID = \" + safeParentJobID + \";\",\n+                         \"WHERE jobID = \" +\n+                             safeParentJobID + \";\",","path":"plugins/Jobs.cpp","position":15,"original_position":15,"commit_id":"b991177317f05dc516b6be7f143180d9b0e27fa9","original_commit_id":"b991177317f05dc516b6be7f143180d9b0e27fa9","user":{"login":"tylerkaraszewski","id":705000,"avatar_url":"https://avatars.githubusercontent.com/u/705000?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerkaraszewski","html_url":"https://github.com/tylerkaraszewski","followers_url":"https://api.github.com/users/tylerkaraszewski/followers","following_url":"https://api.github.com/users/tylerkaraszewski/following{/other_user}","gists_url":"https://api.github.com/users/tylerkaraszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerkaraszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerkaraszewski/subscriptions","organizations_url":"https://api.github.com/users/tylerkaraszewski/orgs","repos_url":"https://api.github.com/users/tylerkaraszewski/repos","events_url":"https://api.github.com/users/tylerkaraszewski/events{/privacy}","received_events_url":"https://api.github.com/users/tylerkaraszewski/received_events","type":"User","site_admin":false},"body":"I'm confused. The difference in this file is only whitespace, correct? This is presumably from running this code through the auto-formatter (whichI did). I may not have even needed to do this, I don't see any other changes in this file, so I'm not sure how it got caught by the formatter to make any changes.\r\n\r\nIn your original PR the only difference was to change BedrockNode::Plugin to BedrockPlugin, but that was done separately in a different recent PR.","created_at":"2016-10-17T21:53:31Z","updated_at":"2016-10-17T21:53:31Z","html_url":"https://github.com/Expensify/Bedrock/pull/16#discussion_r83742814","pull_request_url":"https://api.github.com/repos/Expensify/Bedrock/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/comments/83742814"},"html":{"href":"https://github.com/Expensify/Bedrock/pull/16#discussion_r83742814"},"pull_request":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/Expensify/Bedrock/pulls/16","id":89438685,"html_url":"https://github.com/Expensify/Bedrock/pull/16","diff_url":"https://github.com/Expensify/Bedrock/pull/16.diff","patch_url":"https://github.com/Expensify/Bedrock/pull/16.patch","issue_url":"https://api.github.com/repos/Expensify/Bedrock/issues/16","number":16,"state":"open","locked":false,"title":"Move MySQL plugin to new repo.","user":{"login":"tylerkaraszewski","id":705000,"avatar_url":"https://avatars.githubusercontent.com/u/705000?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerkaraszewski","html_url":"https://github.com/tylerkaraszewski","followers_url":"https://api.github.com/users/tylerkaraszewski/followers","following_url":"https://api.github.com/users/tylerkaraszewski/following{/other_user}","gists_url":"https://api.github.com/users/tylerkaraszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerkaraszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerkaraszewski/subscriptions","organizations_url":"https://api.github.com/users/tylerkaraszewski/orgs","repos_url":"https://api.github.com/users/tylerkaraszewski/repos","events_url":"https://api.github.com/users/tylerkaraszewski/events{/privacy}","received_events_url":"https://api.github.com/users/tylerkaraszewski/received_events","type":"User","site_admin":false},"body":"So far, this builds and runs. One test is failing for me (Report_RewardUpdaterTest::testIgnoreCacheRecomputed in the integration test suite), but it seems to do that on master as well.\r\n\r\nI will look into that failure, and also try and verify that this actually works with the mysql client before removing the WIP flag.\r\n\r\ncc @quinthar @cead22 ","created_at":"2016-10-14T19:12:01Z","updated_at":"2016-10-17T21:53:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f65a8e888b42db08f60b31357f27a59c330dca0","assignee":{"login":"quinthar","id":575186,"avatar_url":"https://avatars.githubusercontent.com/u/575186?v=3","gravatar_id":"","url":"https://api.github.com/users/quinthar","html_url":"https://github.com/quinthar","followers_url":"https://api.github.com/users/quinthar/followers","following_url":"https://api.github.com/users/quinthar/following{/other_user}","gists_url":"https://api.github.com/users/quinthar/gists{/gist_id}","starred_url":"https://api.github.com/users/quinthar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinthar/subscriptions","organizations_url":"https://api.github.com/users/quinthar/orgs","repos_url":"https://api.github.com/users/quinthar/repos","events_url":"https://api.github.com/users/quinthar/events{/privacy}","received_events_url":"https://api.github.com/users/quinthar/received_events","type":"User","site_admin":false},"assignees":[{"login":"quinthar","id":575186,"avatar_url":"https://avatars.githubusercontent.com/u/575186?v=3","gravatar_id":"","url":"https://api.github.com/users/quinthar","html_url":"https://github.com/quinthar","followers_url":"https://api.github.com/users/quinthar/followers","following_url":"https://api.github.com/users/quinthar/following{/other_user}","gists_url":"https://api.github.com/users/quinthar/gists{/gist_id}","starred_url":"https://api.github.com/users/quinthar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinthar/subscriptions","organizations_url":"https://api.github.com/users/quinthar/orgs","repos_url":"https://api.github.com/users/quinthar/repos","events_url":"https://api.github.com/users/quinthar/events{/privacy}","received_events_url":"https://api.github.com/users/quinthar/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Expensify/Bedrock/pulls/16/commits","review_comments_url":"https://api.github.com/repos/Expensify/Bedrock/pulls/16/comments","review_comment_url":"https://api.github.com/repos/Expensify/Bedrock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Expensify/Bedrock/issues/16/comments","statuses_url":"https://api.github.com/repos/Expensify/Bedrock/statuses/b991177317f05dc516b6be7f143180d9b0e27fa9","head":{"label":"Expensify:tyler-migrate-mysql","ref":"tyler-migrate-mysql","sha":"b991177317f05dc516b6be7f143180d9b0e27fa9","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars.githubusercontent.com/u/476779?v=3","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":67904342,"name":"Bedrock","full_name":"Expensify/Bedrock","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars.githubusercontent.com/u/476779?v=3","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/Bedrock","description":null,"fork":false,"url":"https://api.github.com/repos/Expensify/Bedrock","forks_url":"https://api.github.com/repos/Expensify/Bedrock/forks","keys_url":"https://api.github.com/repos/Expensify/Bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/Bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/Bedrock/teams","hooks_url":"https://api.github.com/repos/Expensify/Bedrock/hooks","issue_events_url":"https://api.github.com/repos/Expensify/Bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/Bedrock/events","assignees_url":"https://api.github.com/repos/Expensify/Bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/Bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/Bedrock/tags","blobs_url":"https://api.github.com/repos/Expensify/Bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/Bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/Bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/Bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/Bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/Bedrock/languages","stargazers_url":"https://api.github.com/repos/Expensify/Bedrock/stargazers","contributors_url":"https://api.github.com/repos/Expensify/Bedrock/contributors","subscribers_url":"https://api.github.com/repos/Expensify/Bedrock/subscribers","subscription_url":"https://api.github.com/repos/Expensify/Bedrock/subscription","commits_url":"https://api.github.com/repos/Expensify/Bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/Bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/Bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/Bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/Bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/Bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/Bedrock/merges","archive_url":"https://api.github.com/repos/Expensify/Bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/Bedrock/downloads","issues_url":"https://api.github.com/repos/Expensify/Bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/Bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/Bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/Bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/Bedrock/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/Bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/Bedrock/deployments","created_at":"2016-09-11T01:55:45Z","updated_at":"2016-09-22T17:14:38Z","pushed_at":"2016-10-17T20:42:07Z","git_url":"git://github.com/Expensify/Bedrock.git","ssh_url":"git@github.com:Expensify/Bedrock.git","clone_url":"https://github.com/Expensify/Bedrock.git","svn_url":"https://github.com/Expensify/Bedrock","homepage":null,"size":2389,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"Expensify:master","ref":"master","sha":"587035835af3f73fa08a2a4765cc91c6bfa958f5","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars.githubusercontent.com/u/476779?v=3","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":67904342,"name":"Bedrock","full_name":"Expensify/Bedrock","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars.githubusercontent.com/u/476779?v=3","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/Bedrock","description":null,"fork":false,"url":"https://api.github.com/repos/Expensify/Bedrock","forks_url":"https://api.github.com/repos/Expensify/Bedrock/forks","keys_url":"https://api.github.com/repos/Expensify/Bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/Bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/Bedrock/teams","hooks_url":"https://api.github.com/repos/Expensify/Bedrock/hooks","issue_events_url":"https://api.github.com/repos/Expensify/Bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/Bedrock/events","assignees_url":"https://api.github.com/repos/Expensify/Bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/Bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/Bedrock/tags","blobs_url":"https://api.github.com/repos/Expensify/Bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/Bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/Bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/Bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/Bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/Bedrock/languages","stargazers_url":"https://api.github.com/repos/Expensify/Bedrock/stargazers","contributors_url":"https://api.github.com/repos/Expensify/Bedrock/contributors","subscribers_url":"https://api.github.com/repos/Expensify/Bedrock/subscribers","subscription_url":"https://api.github.com/repos/Expensify/Bedrock/subscription","commits_url":"https://api.github.com/repos/Expensify/Bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/Bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/Bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/Bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/Bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/Bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/Bedrock/merges","archive_url":"https://api.github.com/repos/Expensify/Bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/Bedrock/downloads","issues_url":"https://api.github.com/repos/Expensify/Bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/Bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/Bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/Bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/Bedrock/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/Bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/Bedrock/deployments","created_at":"2016-09-11T01:55:45Z","updated_at":"2016-09-22T17:14:38Z","pushed_at":"2016-10-17T20:42:07Z","git_url":"git://github.com/Expensify/Bedrock.git","ssh_url":"git@github.com:Expensify/Bedrock.git","clone_url":"https://github.com/Expensify/Bedrock.git","svn_url":"https://github.com/Expensify/Bedrock","homepage":null,"size":2389,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/16"},"html":{"href":"https://github.com/Expensify/Bedrock/pull/16"},"issue":{"href":"https://api.github.com/repos/Expensify/Bedrock/issues/16"},"comments":{"href":"https://api.github.com/repos/Expensify/Bedrock/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/Expensify/Bedrock/statuses/b991177317f05dc516b6be7f143180d9b0e27fa9"}}}}
{"actor":{"display_login":"tylerkaraszewski"}}