{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/buck/pulls/comments/90307024","pull_request_review_id":10827130,"id":90307024,"diff_hunk":"@@ -109,19 +116,51 @@ public void createCompileToJarStep(\n    * is buck-out/bin/java/abc/lib__abc__classes/, then a contained class abc.AbcModule\n    * should be at buck-out/bin/java/abc/lib__abc__classes/abc/AbcModule.class\n    *\n+   * @param context the build context.\n+   * @param filesystem the project filesystem.\n    * @param postprocessClassesCommands the list of commands to post-process .class files.\n    * @param outputDirectory the directory that will contain all the javac output.\n+   * @param declaredClasspathEntries the list of classpath entries.\n    */\n   @VisibleForTesting\n   static ImmutableList<Step> addPostprocessClassesCommands(\n-      Path workingDirectory,\n+      BuildContext context,\n+      ProjectFilesystem filesystem,\n       List<String> postprocessClassesCommands,\n-      Path outputDirectory) {\n+      Path outputDirectory,\n+      ImmutableSortedSet<Path> declaredClasspathEntries) {\n     ImmutableList.Builder<Step> commands = new ImmutableList.Builder<Step>();\n+\n+    ImmutableMap.Builder<String, String> envVarBuilder = ImmutableMap.builder();\n+    if (!postprocessClassesCommands.isEmpty()) {","path":"src/com/facebook/buck/jvm/java/BaseCompileToJarStepFactory.java","position":61,"original_position":61,"commit_id":"41080084a3ba344f44dd6e995deaa61752d28b33","original_commit_id":"41080084a3ba344f44dd6e995deaa61752d28b33","user":{"login":"dreiss","id":4121,"avatar_url":"https://avatars.githubusercontent.com/u/4121?v=3","gravatar_id":"","url":"https://api.github.com/users/dreiss","html_url":"https://github.com/dreiss","followers_url":"https://api.github.com/users/dreiss/followers","following_url":"https://api.github.com/users/dreiss/following{/other_user}","gists_url":"https://api.github.com/users/dreiss/gists{/gist_id}","starred_url":"https://api.github.com/users/dreiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreiss/subscriptions","organizations_url":"https://api.github.com/users/dreiss/orgs","repos_url":"https://api.github.com/users/dreiss/repos","events_url":"https://api.github.com/users/dreiss/events{/privacy}","received_events_url":"https://api.github.com/users/dreiss/received_events","type":"User","site_admin":false},"body":"Maybe just check this at the top and return an empty list?","created_at":"2016-11-30T19:22:11Z","updated_at":"2016-11-30T19:23:32Z","html_url":"https://github.com/facebook/buck/pull/1031#discussion_r90307024","pull_request_url":"https://api.github.com/repos/facebook/buck/pulls/1031","_links":{"self":{"href":"https://api.github.com/repos/facebook/buck/pulls/comments/90307024"},"html":{"href":"https://github.com/facebook/buck/pull/1031#discussion_r90307024"},"pull_request":{"href":"https://api.github.com/repos/facebook/buck/pulls/1031"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/buck/pulls/1031","id":95848989,"html_url":"https://github.com/facebook/buck/pull/1031","diff_url":"https://github.com/facebook/buck/pull/1031.diff","patch_url":"https://github.com/facebook/buck/pull/1031.patch","issue_url":"https://api.github.com/repos/facebook/buck/issues/1031","number":1031,"state":"open","locked":false,"title":"Enhance post process classes commands with additional env vars","user":{"login":"kageiit","id":291148,"avatar_url":"https://avatars.githubusercontent.com/u/291148?v=3","gravatar_id":"","url":"https://api.github.com/users/kageiit","html_url":"https://github.com/kageiit","followers_url":"https://api.github.com/users/kageiit/followers","following_url":"https://api.github.com/users/kageiit/following{/other_user}","gists_url":"https://api.github.com/users/kageiit/gists{/gist_id}","starred_url":"https://api.github.com/users/kageiit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kageiit/subscriptions","organizations_url":"https://api.github.com/users/kageiit/orgs","repos_url":"https://api.github.com/users/kageiit/repos","events_url":"https://api.github.com/users/kageiit/events{/privacy}","received_events_url":"https://api.github.com/users/kageiit/received_events","type":"User","site_admin":false},"body":"This makes the `classpath` and `android bootclasspath` (if available) of a jvm target available to `postProcessClassesCommands`. This is very useful to be able to do bytecode manipulation of the output classes with tools like retrolamdba etc.","created_at":"2016-11-30T08:44:03Z","updated_at":"2016-11-30T19:23:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7038a7fa9e4bbf0ecdfabf325788e69fcd6c9338","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/buck/pulls/1031/commits","review_comments_url":"https://api.github.com/repos/facebook/buck/pulls/1031/comments","review_comment_url":"https://api.github.com/repos/facebook/buck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/buck/issues/1031/comments","statuses_url":"https://api.github.com/repos/facebook/buck/statuses/41080084a3ba344f44dd6e995deaa61752d28b33","head":{"label":"kageiit:enhance_postprocess","ref":"enhance_postprocess","sha":"41080084a3ba344f44dd6e995deaa61752d28b33","user":{"login":"kageiit","id":291148,"avatar_url":"https://avatars.githubusercontent.com/u/291148?v=3","gravatar_id":"","url":"https://api.github.com/users/kageiit","html_url":"https://github.com/kageiit","followers_url":"https://api.github.com/users/kageiit/followers","following_url":"https://api.github.com/users/kageiit/following{/other_user}","gists_url":"https://api.github.com/users/kageiit/gists{/gist_id}","starred_url":"https://api.github.com/users/kageiit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kageiit/subscriptions","organizations_url":"https://api.github.com/users/kageiit/orgs","repos_url":"https://api.github.com/users/kageiit/repos","events_url":"https://api.github.com/users/kageiit/events{/privacy}","received_events_url":"https://api.github.com/users/kageiit/received_events","type":"User","site_admin":false},"repo":{"id":58605717,"name":"buck","full_name":"kageiit/buck","owner":{"login":"kageiit","id":291148,"avatar_url":"https://avatars.githubusercontent.com/u/291148?v=3","gravatar_id":"","url":"https://api.github.com/users/kageiit","html_url":"https://github.com/kageiit","followers_url":"https://api.github.com/users/kageiit/followers","following_url":"https://api.github.com/users/kageiit/following{/other_user}","gists_url":"https://api.github.com/users/kageiit/gists{/gist_id}","starred_url":"https://api.github.com/users/kageiit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kageiit/subscriptions","organizations_url":"https://api.github.com/users/kageiit/orgs","repos_url":"https://api.github.com/users/kageiit/repos","events_url":"https://api.github.com/users/kageiit/events{/privacy}","received_events_url":"https://api.github.com/users/kageiit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kageiit/buck","description":"A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.","fork":true,"url":"https://api.github.com/repos/kageiit/buck","forks_url":"https://api.github.com/repos/kageiit/buck/forks","keys_url":"https://api.github.com/repos/kageiit/buck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kageiit/buck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kageiit/buck/teams","hooks_url":"https://api.github.com/repos/kageiit/buck/hooks","issue_events_url":"https://api.github.com/repos/kageiit/buck/issues/events{/number}","events_url":"https://api.github.com/repos/kageiit/buck/events","assignees_url":"https://api.github.com/repos/kageiit/buck/assignees{/user}","branches_url":"https://api.github.com/repos/kageiit/buck/branches{/branch}","tags_url":"https://api.github.com/repos/kageiit/buck/tags","blobs_url":"https://api.github.com/repos/kageiit/buck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kageiit/buck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kageiit/buck/git/refs{/sha}","trees_url":"https://api.github.com/repos/kageiit/buck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kageiit/buck/statuses/{sha}","languages_url":"https://api.github.com/repos/kageiit/buck/languages","stargazers_url":"https://api.github.com/repos/kageiit/buck/stargazers","contributors_url":"https://api.github.com/repos/kageiit/buck/contributors","subscribers_url":"https://api.github.com/repos/kageiit/buck/subscribers","subscription_url":"https://api.github.com/repos/kageiit/buck/subscription","commits_url":"https://api.github.com/repos/kageiit/buck/commits{/sha}","git_commits_url":"https://api.github.com/repos/kageiit/buck/git/commits{/sha}","comments_url":"https://api.github.com/repos/kageiit/buck/comments{/number}","issue_comment_url":"https://api.github.com/repos/kageiit/buck/issues/comments{/number}","contents_url":"https://api.github.com/repos/kageiit/buck/contents/{+path}","compare_url":"https://api.github.com/repos/kageiit/buck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kageiit/buck/merges","archive_url":"https://api.github.com/repos/kageiit/buck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kageiit/buck/downloads","issues_url":"https://api.github.com/repos/kageiit/buck/issues{/number}","pulls_url":"https://api.github.com/repos/kageiit/buck/pulls{/number}","milestones_url":"https://api.github.com/repos/kageiit/buck/milestones{/number}","notifications_url":"https://api.github.com/repos/kageiit/buck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kageiit/buck/labels{/name}","releases_url":"https://api.github.com/repos/kageiit/buck/releases{/id}","deployments_url":"https://api.github.com/repos/kageiit/buck/deployments","created_at":"2016-05-12T03:51:50Z","updated_at":"2016-05-12T03:52:00Z","pushed_at":"2016-11-30T08:42:17Z","git_url":"git://github.com/kageiit/buck.git","ssh_url":"git@github.com:kageiit/buck.git","clone_url":"https://github.com/kageiit/buck.git","svn_url":"https://github.com/kageiit/buck","homepage":"https://buckbuild.com","size":453328,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"1d815707ece03c676d65021bd1a6b104b948882e","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":9504214,"name":"buck","full_name":"facebook/buck","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/buck","description":"A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.","fork":false,"url":"https://api.github.com/repos/facebook/buck","forks_url":"https://api.github.com/repos/facebook/buck/forks","keys_url":"https://api.github.com/repos/facebook/buck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/buck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/buck/teams","hooks_url":"https://api.github.com/repos/facebook/buck/hooks","issue_events_url":"https://api.github.com/repos/facebook/buck/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/buck/events","assignees_url":"https://api.github.com/repos/facebook/buck/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/buck/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/buck/tags","blobs_url":"https://api.github.com/repos/facebook/buck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/buck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/buck/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/buck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/buck/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/buck/languages","stargazers_url":"https://api.github.com/repos/facebook/buck/stargazers","contributors_url":"https://api.github.com/repos/facebook/buck/contributors","subscribers_url":"https://api.github.com/repos/facebook/buck/subscribers","subscription_url":"https://api.github.com/repos/facebook/buck/subscription","commits_url":"https://api.github.com/repos/facebook/buck/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/buck/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/buck/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/buck/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/buck/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/buck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/buck/merges","archive_url":"https://api.github.com/repos/facebook/buck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/buck/downloads","issues_url":"https://api.github.com/repos/facebook/buck/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/buck/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/buck/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/buck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/buck/labels{/name}","releases_url":"https://api.github.com/repos/facebook/buck/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/buck/deployments","created_at":"2013-04-17T18:12:18Z","updated_at":"2016-11-30T18:16:57Z","pushed_at":"2016-11-30T19:05:30Z","git_url":"git://github.com/facebook/buck.git","ssh_url":"git@github.com:facebook/buck.git","clone_url":"https://github.com/facebook/buck.git","svn_url":"https://github.com/facebook/buck","homepage":"https://buckbuild.com","size":494106,"stargazers_count":3329,"watchers_count":3329,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":583,"mirror_url":null,"open_issues_count":197,"forks":583,"open_issues":197,"watchers":3329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/buck/pulls/1031"},"html":{"href":"https://github.com/facebook/buck/pull/1031"},"issue":{"href":"https://api.github.com/repos/facebook/buck/issues/1031"},"comments":{"href":"https://api.github.com/repos/facebook/buck/issues/1031/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/buck/pulls/1031/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/buck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/buck/pulls/1031/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/buck/statuses/41080084a3ba344f44dd6e995deaa61752d28b33"}}}}
{"actor":{"display_login":"dreiss"}}