{"action":"created","issue":{"url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/935","repository_url":"https://api.github.com/repos/remotestorage/remotestorage.js","labels_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/935/labels{/name}","comments_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/935/comments","events_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/935/events","html_url":"https://github.com/remotestorage/remotestorage.js/pull/935","id":155216988,"number":935,"title":"Bugfix/934-unresolved promise","user":{"login":"esroyo","id":1025694,"avatar_url":"https://avatars.githubusercontent.com/u/1025694?v=3","gravatar_id":"","url":"https://api.github.com/users/esroyo","html_url":"https://github.com/esroyo","followers_url":"https://api.github.com/users/esroyo/followers","following_url":"https://api.github.com/users/esroyo/following{/other_user}","gists_url":"https://api.github.com/users/esroyo/gists{/gist_id}","starred_url":"https://api.github.com/users/esroyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esroyo/subscriptions","organizations_url":"https://api.github.com/users/esroyo/orgs","repos_url":"https://api.github.com/users/esroyo/repos","events_url":"https://api.github.com/users/esroyo/events{/privacy}","received_events_url":"https://api.github.com/users/esroyo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2016-05-17T09:40:34Z","updated_at":"2016-05-25T08:45:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/935","html_url":"https://github.com/remotestorage/remotestorage.js/pull/935","diff_url":"https://github.com/remotestorage/remotestorage.js/pull/935.diff","patch_url":"https://github.com/remotestorage/remotestorage.js/pull/935.patch"},"body":"fixes #934 \r\n\r\nThe problem appears when trying to get a remote unexisting file (on a subdirectory, with cache), then the associated promise is not resolved.\r\n\r\nThe reason is that the callback associated to the task is removed in the function ```deleteChildPathsFromTasks``` because a task to get the parent exists.\r\n\r\n[Edit] Forgot to comment the solution though it is obvious: before deleting the child paths from the tasks, we pick the associated callbacks and add them to the parent path.\r\n\r\nSeems to work fine now.\r\n\r\nAlso fixed what looks to me like a little slip in the ```_timeStarted``` assignment."},"comment":{"url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/comments/221510893","html_url":"https://github.com/remotestorage/remotestorage.js/pull/935#issuecomment-221510893","issue_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/935","id":221510893,"user":{"login":"esroyo","id":1025694,"avatar_url":"https://avatars.githubusercontent.com/u/1025694?v=3","gravatar_id":"","url":"https://api.github.com/users/esroyo","html_url":"https://github.com/esroyo","followers_url":"https://api.github.com/users/esroyo/followers","following_url":"https://api.github.com/users/esroyo/following{/other_user}","gists_url":"https://api.github.com/users/esroyo/gists{/gist_id}","starred_url":"https://api.github.com/users/esroyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esroyo/subscriptions","organizations_url":"https://api.github.com/users/esroyo/orgs","repos_url":"https://api.github.com/users/esroyo/repos","events_url":"https://api.github.com/users/esroyo/events{/privacy}","received_events_url":"https://api.github.com/users/esroyo/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T08:45:32Z","updated_at":"2016-05-25T08:45:32Z","body":"Thanks. PR updated. I've modified an already existing related test to include the check. It makes sense to me to test it there, but let me know if you prefer a separate test."}}
{"actor":{"display_login":"esroyo"}}