{"action":"created","issue":{"url":"https://api.github.com/repos/zanata/zanata-server/issues/1173","repository_url":"https://api.github.com/repos/zanata/zanata-server","labels_url":"https://api.github.com/repos/zanata/zanata-server/issues/1173/labels{/name}","comments_url":"https://api.github.com/repos/zanata/zanata-server/issues/1173/comments","events_url":"https://api.github.com/repos/zanata/zanata-server/issues/1173/events","html_url":"https://github.com/zanata/zanata-server/pull/1173","id":155646913,"number":1173,"title":"feat(username): System property for enforcing username","user":{"login":"aeng","id":766762,"avatar_url":"https://avatars.githubusercontent.com/u/766762?v=3","gravatar_id":"","url":"https://api.github.com/users/aeng","html_url":"https://github.com/aeng","followers_url":"https://api.github.com/users/aeng/followers","following_url":"https://api.github.com/users/aeng/following{/other_user}","gists_url":"https://api.github.com/users/aeng/gists{/gist_id}","starred_url":"https://api.github.com/users/aeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeng/subscriptions","organizations_url":"https://api.github.com/users/aeng/orgs","repos_url":"https://api.github.com/users/aeng/repos","events_url":"https://api.github.com/users/aeng/events{/privacy}","received_events_url":"https://api.github.com/users/aeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zanata/zanata-server/labels/Awaiting%20review","name":"Awaiting review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"seanf","id":54155,"avatar_url":"https://avatars.githubusercontent.com/u/54155?v=3","gravatar_id":"","url":"https://api.github.com/users/seanf","html_url":"https://github.com/seanf","followers_url":"https://api.github.com/users/seanf/followers","following_url":"https://api.github.com/users/seanf/following{/other_user}","gists_url":"https://api.github.com/users/seanf/gists{/gist_id}","starred_url":"https://api.github.com/users/seanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanf/subscriptions","organizations_url":"https://api.github.com/users/seanf/orgs","repos_url":"https://api.github.com/users/seanf/repos","events_url":"https://api.github.com/users/seanf/events{/privacy}","received_events_url":"https://api.github.com/users/seanf/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-19T03:24:55Z","updated_at":"2016-05-19T03:53:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-server/pulls/1173","html_url":"https://github.com/zanata/zanata-server/pull/1173","diff_url":"https://github.com/zanata/zanata-server/pull/1173.diff","patch_url":"https://github.com/zanata/zanata-server/pull/1173.patch"},"body":"https://zanata.atlassian.net/browse/ZNTA-855\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/zanata/zanata-server/1173)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/zanata/zanata-server/issues/comments/220221574","html_url":"https://github.com/zanata/zanata-server/pull/1173#issuecomment-220221574","issue_url":"https://api.github.com/repos/zanata/zanata-server/issues/1173","id":220221574,"user":{"login":"seanf","id":54155,"avatar_url":"https://avatars.githubusercontent.com/u/54155?v=3","gravatar_id":"","url":"https://api.github.com/users/seanf","html_url":"https://github.com/seanf","followers_url":"https://api.github.com/users/seanf/followers","following_url":"https://api.github.com/users/seanf/following{/other_user}","gists_url":"https://api.github.com/users/seanf/gists{/gist_id}","starred_url":"https://api.github.com/users/seanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanf/subscriptions","organizations_url":"https://api.github.com/users/seanf/orgs","repos_url":"https://api.github.com/users/seanf/repos","events_url":"https://api.github.com/users/seanf/events{/privacy}","received_events_url":"https://api.github.com/users/seanf/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T03:53:10Z","updated_at":"2016-05-19T03:53:10Z","body":"\n\n\n\n\n\nReview status: all files reviewed at latest revision, 6 unresolved discussions.\n\n---\n\n*[zanata-war/src/main/java/org/zanata/ApplicationConfiguration.java, line 143 \\[r1\\]](https://reviewable.io:443/reviews/zanata/zanata-server/1173#-KI681IoYGIfN6HXt9Go:-KI681IpfBnXlb2-Nxmw:1696234041) ([raw file](https://github.com/zanata/zanata-server/blob/b1a8c94b2cfce40ce4050012317f99d9e6ec1b65/zanata-war/src/main/java/org/zanata/ApplicationConfiguration.java#L143)):*\n> ```Java\n>      */\n>     @Getter\n>     private boolean enforceUsername;\n> ```\n\nI think a more meaningful name would be better, perhaps zanata.enforceMatchingUsernames or zanata.usernamesMustMatchExternal.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/zanata/zanata-server/1173)*\n<!-- Sent from Reviewable.io -->\n"}}