{"action":"created","comment":{"url":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/comments/81021980","pull_request_review_id":2032790,"id":81021980,"diff_hunk":"@@ -91,19 +92,35 @@\n     (f))\n   (server/stop!))\n \n+(defn- add-toplevel-objects!\n+  \"Adds top level entries, needed for testing, to the ldap server\"\n+  [connection]\n+  (ldap/add connection \"dc=alienscience,dc=org,dc=uk\"\n+            {:objectClass [\"top\" \"domain\" \"extensibleObject\"]\n+             :dc \"alienscience\"})\n+  (ldap/add connection \"ou=people,dc=alienscience,dc=org,dc=uk\"\n+            {:objectClass [\"top\" \"organizationalUnit\"]\n+             :ou \"people\"})\n+  (ldap/add connection\n+            \"cn=Saul Hazledine,ou=people,dc=alienscience,dc=org,dc=uk\"\n+            {:objectClass [\"top\" \"Person\"]\n+             :cn \"Saul Hazledine\"\n+             :sn \"Hazledine\"\n+             :description \"Creator of bugs\"}))\n+","path":"test/clj_ldap/test/client.clj","position":40,"original_position":40,"commit_id":"85028bfbba9742483cb1d812b190a704a274e45a","original_commit_id":"85028bfbba9742483cb1d812b190a704a274e45a","user":{"login":"bskinny","id":7344632,"avatar_url":"https://avatars.githubusercontent.com/u/7344632?v=3","gravatar_id":"","url":"https://api.github.com/users/bskinny","html_url":"https://github.com/bskinny","followers_url":"https://api.github.com/users/bskinny/followers","following_url":"https://api.github.com/users/bskinny/following{/other_user}","gists_url":"https://api.github.com/users/bskinny/gists{/gist_id}","starred_url":"https://api.github.com/users/bskinny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bskinny/subscriptions","organizations_url":"https://api.github.com/users/bskinny/orgs","repos_url":"https://api.github.com/users/bskinny/repos","events_url":"https://api.github.com/users/bskinny/events{/privacy}","received_events_url":"https://api.github.com/users/bskinny/received_events","type":"User","site_admin":false},"body":"Thanks for the test.","created_at":"2016-09-28T21:31:14Z","updated_at":"2016-09-28T21:32:24Z","html_url":"https://github.com/pauldorman/clj-ldap/pull/19#discussion_r81021980","pull_request_url":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/comments/81021980"},"html":{"href":"https://github.com/pauldorman/clj-ldap/pull/19#discussion_r81021980"},"pull_request":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/19","id":87121399,"html_url":"https://github.com/pauldorman/clj-ldap/pull/19","diff_url":"https://github.com/pauldorman/clj-ldap/pull/19.diff","patch_url":"https://github.com/pauldorman/clj-ldap/pull/19.patch","issue_url":"https://api.github.com/repos/pauldorman/clj-ldap/issues/19","number":19,"state":"open","locked":false,"title":"allow recursive deletion of an entire subtree","user":{"login":"tobowers","id":1274,"avatar_url":"https://avatars.githubusercontent.com/u/1274?v=3","gravatar_id":"","url":"https://api.github.com/users/tobowers","html_url":"https://github.com/tobowers","followers_url":"https://api.github.com/users/tobowers/followers","following_url":"https://api.github.com/users/tobowers/following{/other_user}","gists_url":"https://api.github.com/users/tobowers/gists{/gist_id}","starred_url":"https://api.github.com/users/tobowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobowers/subscriptions","organizations_url":"https://api.github.com/users/tobowers/orgs","repos_url":"https://api.github.com/users/tobowers/repos","events_url":"https://api.github.com/users/tobowers/events{/privacy}","received_events_url":"https://api.github.com/users/tobowers/received_events","type":"User","site_admin":false},"body":"This uses the [SubtreeDeleteRequestControl](https://docs.ldap.com/ldap-sdk/docs/javadoc/com/unboundid/ldap/sdk/controls/SubtreeDeleteRequestControl.html) by optionally specifying `{:recursive true}` on a delete.\r\n\r\nI moved around the toplevel entries from the server file in the tests to the client side (so that they get recreated for every test).","created_at":"2016-09-28T13:37:40Z","updated_at":"2016-09-28T21:32:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"568c838b8af85189cedfa367f00af85195d35bf2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/19/commits","review_comments_url":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/19/comments","review_comment_url":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pauldorman/clj-ldap/issues/19/comments","statuses_url":"https://api.github.com/repos/pauldorman/clj-ldap/statuses/85028bfbba9742483cb1d812b190a704a274e45a","head":{"label":"QuorumControl:feature/add-recursive-delete","ref":"feature/add-recursive-delete","sha":"85028bfbba9742483cb1d812b190a704a274e45a","user":{"login":"QuorumControl","id":17928959,"avatar_url":"https://avatars.githubusercontent.com/u/17928959?v=3","gravatar_id":"","url":"https://api.github.com/users/QuorumControl","html_url":"https://github.com/QuorumControl","followers_url":"https://api.github.com/users/QuorumControl/followers","following_url":"https://api.github.com/users/QuorumControl/following{/other_user}","gists_url":"https://api.github.com/users/QuorumControl/gists{/gist_id}","starred_url":"https://api.github.com/users/QuorumControl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuorumControl/subscriptions","organizations_url":"https://api.github.com/users/QuorumControl/orgs","repos_url":"https://api.github.com/users/QuorumControl/repos","events_url":"https://api.github.com/users/QuorumControl/events{/privacy}","received_events_url":"https://api.github.com/users/QuorumControl/received_events","type":"Organization","site_admin":false},"repo":{"id":69464784,"name":"clj-ldap","full_name":"QuorumControl/clj-ldap","owner":{"login":"QuorumControl","id":17928959,"avatar_url":"https://avatars.githubusercontent.com/u/17928959?v=3","gravatar_id":"","url":"https://api.github.com/users/QuorumControl","html_url":"https://github.com/QuorumControl","followers_url":"https://api.github.com/users/QuorumControl/followers","following_url":"https://api.github.com/users/QuorumControl/following{/other_user}","gists_url":"https://api.github.com/users/QuorumControl/gists{/gist_id}","starred_url":"https://api.github.com/users/QuorumControl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuorumControl/subscriptions","organizations_url":"https://api.github.com/users/QuorumControl/orgs","repos_url":"https://api.github.com/users/QuorumControl/repos","events_url":"https://api.github.com/users/QuorumControl/events{/privacy}","received_events_url":"https://api.github.com/users/QuorumControl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QuorumControl/clj-ldap","description":"Clojure LDAP client","fork":true,"url":"https://api.github.com/repos/QuorumControl/clj-ldap","forks_url":"https://api.github.com/repos/QuorumControl/clj-ldap/forks","keys_url":"https://api.github.com/repos/QuorumControl/clj-ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuorumControl/clj-ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuorumControl/clj-ldap/teams","hooks_url":"https://api.github.com/repos/QuorumControl/clj-ldap/hooks","issue_events_url":"https://api.github.com/repos/QuorumControl/clj-ldap/issues/events{/number}","events_url":"https://api.github.com/repos/QuorumControl/clj-ldap/events","assignees_url":"https://api.github.com/repos/QuorumControl/clj-ldap/assignees{/user}","branches_url":"https://api.github.com/repos/QuorumControl/clj-ldap/branches{/branch}","tags_url":"https://api.github.com/repos/QuorumControl/clj-ldap/tags","blobs_url":"https://api.github.com/repos/QuorumControl/clj-ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuorumControl/clj-ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuorumControl/clj-ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuorumControl/clj-ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuorumControl/clj-ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/QuorumControl/clj-ldap/languages","stargazers_url":"https://api.github.com/repos/QuorumControl/clj-ldap/stargazers","contributors_url":"https://api.github.com/repos/QuorumControl/clj-ldap/contributors","subscribers_url":"https://api.github.com/repos/QuorumControl/clj-ldap/subscribers","subscription_url":"https://api.github.com/repos/QuorumControl/clj-ldap/subscription","commits_url":"https://api.github.com/repos/QuorumControl/clj-ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuorumControl/clj-ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuorumControl/clj-ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuorumControl/clj-ldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuorumControl/clj-ldap/contents/{+path}","compare_url":"https://api.github.com/repos/QuorumControl/clj-ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuorumControl/clj-ldap/merges","archive_url":"https://api.github.com/repos/QuorumControl/clj-ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuorumControl/clj-ldap/downloads","issues_url":"https://api.github.com/repos/QuorumControl/clj-ldap/issues{/number}","pulls_url":"https://api.github.com/repos/QuorumControl/clj-ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/QuorumControl/clj-ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/QuorumControl/clj-ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuorumControl/clj-ldap/labels{/name}","releases_url":"https://api.github.com/repos/QuorumControl/clj-ldap/releases{/id}","deployments_url":"https://api.github.com/repos/QuorumControl/clj-ldap/deployments","created_at":"2016-09-28T13:14:30Z","updated_at":"2016-09-28T13:14:31Z","pushed_at":"2016-09-28T13:34:35Z","git_url":"git://github.com/QuorumControl/clj-ldap.git","ssh_url":"git@github.com:QuorumControl/clj-ldap.git","clone_url":"https://github.com/QuorumControl/clj-ldap.git","svn_url":"https://github.com/QuorumControl/clj-ldap","homepage":"","size":122,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pauldorman:master","ref":"master","sha":"08cc61c6427afb02d4a3a54598b98345fe6382a0","user":{"login":"pauldorman","id":177815,"avatar_url":"https://avatars.githubusercontent.com/u/177815?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldorman","html_url":"https://github.com/pauldorman","followers_url":"https://api.github.com/users/pauldorman/followers","following_url":"https://api.github.com/users/pauldorman/following{/other_user}","gists_url":"https://api.github.com/users/pauldorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldorman/subscriptions","organizations_url":"https://api.github.com/users/pauldorman/orgs","repos_url":"https://api.github.com/users/pauldorman/repos","events_url":"https://api.github.com/users/pauldorman/events{/privacy}","received_events_url":"https://api.github.com/users/pauldorman/received_events","type":"User","site_admin":false},"repo":{"id":1480503,"name":"clj-ldap","full_name":"pauldorman/clj-ldap","owner":{"login":"pauldorman","id":177815,"avatar_url":"https://avatars.githubusercontent.com/u/177815?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldorman","html_url":"https://github.com/pauldorman","followers_url":"https://api.github.com/users/pauldorman/followers","following_url":"https://api.github.com/users/pauldorman/following{/other_user}","gists_url":"https://api.github.com/users/pauldorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldorman/subscriptions","organizations_url":"https://api.github.com/users/pauldorman/orgs","repos_url":"https://api.github.com/users/pauldorman/repos","events_url":"https://api.github.com/users/pauldorman/events{/privacy}","received_events_url":"https://api.github.com/users/pauldorman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pauldorman/clj-ldap","description":"Clojure LDAP client","fork":true,"url":"https://api.github.com/repos/pauldorman/clj-ldap","forks_url":"https://api.github.com/repos/pauldorman/clj-ldap/forks","keys_url":"https://api.github.com/repos/pauldorman/clj-ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pauldorman/clj-ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pauldorman/clj-ldap/teams","hooks_url":"https://api.github.com/repos/pauldorman/clj-ldap/hooks","issue_events_url":"https://api.github.com/repos/pauldorman/clj-ldap/issues/events{/number}","events_url":"https://api.github.com/repos/pauldorman/clj-ldap/events","assignees_url":"https://api.github.com/repos/pauldorman/clj-ldap/assignees{/user}","branches_url":"https://api.github.com/repos/pauldorman/clj-ldap/branches{/branch}","tags_url":"https://api.github.com/repos/pauldorman/clj-ldap/tags","blobs_url":"https://api.github.com/repos/pauldorman/clj-ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pauldorman/clj-ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pauldorman/clj-ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/pauldorman/clj-ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pauldorman/clj-ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/pauldorman/clj-ldap/languages","stargazers_url":"https://api.github.com/repos/pauldorman/clj-ldap/stargazers","contributors_url":"https://api.github.com/repos/pauldorman/clj-ldap/contributors","subscribers_url":"https://api.github.com/repos/pauldorman/clj-ldap/subscribers","subscription_url":"https://api.github.com/repos/pauldorman/clj-ldap/subscription","commits_url":"https://api.github.com/repos/pauldorman/clj-ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/pauldorman/clj-ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/pauldorman/clj-ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/pauldorman/clj-ldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/pauldorman/clj-ldap/contents/{+path}","compare_url":"https://api.github.com/repos/pauldorman/clj-ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pauldorman/clj-ldap/merges","archive_url":"https://api.github.com/repos/pauldorman/clj-ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pauldorman/clj-ldap/downloads","issues_url":"https://api.github.com/repos/pauldorman/clj-ldap/issues{/number}","pulls_url":"https://api.github.com/repos/pauldorman/clj-ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/pauldorman/clj-ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/pauldorman/clj-ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pauldorman/clj-ldap/labels{/name}","releases_url":"https://api.github.com/repos/pauldorman/clj-ldap/releases{/id}","deployments_url":"https://api.github.com/repos/pauldorman/clj-ldap/deployments","created_at":"2011-03-14T22:59:28Z","updated_at":"2016-09-28T00:42:08Z","pushed_at":"2016-09-28T13:37:40Z","git_url":"git://github.com/pauldorman/clj-ldap.git","ssh_url":"git@github.com:pauldorman/clj-ldap.git","clone_url":"https://github.com/pauldorman/clj-ldap.git","svn_url":"https://github.com/pauldorman/clj-ldap","homepage":"","size":154,"stargazers_count":44,"watchers_count":44,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":2,"forks":21,"open_issues":2,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/19"},"html":{"href":"https://github.com/pauldorman/clj-ldap/pull/19"},"issue":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/issues/19"},"comments":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/pauldorman/clj-ldap/statuses/85028bfbba9742483cb1d812b190a704a274e45a"}}}}
{"actor":{"display_login":"bskinny"}}