{"action":"created","issue":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/301","repository_url":"https://api.github.com/repos/CorfuDB/CorfuDB","labels_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/301/labels{/name}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/301/comments","events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/301/events","html_url":"https://github.com/CorfuDB/CorfuDB/pull/301","id":190211866,"number":301,"title":"Resolving timing issue test","user":{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars.githubusercontent.com/u/10751367?v=3","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"labels":[{"id":214476411,"url":"https://api.github.com/repos/CorfuDB/CorfuDB/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-18T01:19:44Z","updated_at":"2016-11-18T04:06:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/301","html_url":"https://github.com/CorfuDB/CorfuDB/pull/301","diff_url":"https://github.com/CorfuDB/CorfuDB/pull/301.diff","patch_url":"https://github.com/CorfuDB/CorfuDB/pull/301.patch"},"body":"Giving more time and multiple to check if this was a timing issue and the failure persists.\r\n(Need to check multiple times on travis env so please do not merge)"},"comment":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/comments/261444069","html_url":"https://github.com/CorfuDB/CorfuDB/pull/301#issuecomment-261444069","issue_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/301","id":261444069,"user":{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars.githubusercontent.com/u/10751367?v=3","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T04:06:12Z","updated_at":"2016-11-18T04:06:12Z","body":"I've run this quite many times now and it doesn't fail on travis. So I feel its safe to say that the test was failing due to a timeout issue. This patch should fix it.\r\nResolving #287 \r\n\r\nInterestingly, the other test handleFailures in ManagementClientTest continues to fail transiently.\r\nI've narrowed down to the cause of the hanging of this test case:\r\nThis test has 2 statements -> bootstrap management server and then send failure msg.\r\nSo to recreate the scenario,\r\nThe bootstrap handler in Management Server needs to have a small sleep after sending the ack as follows:\r\n  ```\r\n  @ServerHandler(type = CorfuMsgType.MANAGEMENT_BOOTSTRAP)\r\n    public synchronized void handleManagementBootstrap(CorfuPayloadMsg<Layout> msg, ChannelHandlerContext ctx, IServerRouter r) {\r\n        log.info(\"Received Bootstrap Layout : {}\", msg.getPayload());\r\n        safeUpdateLayout(msg.getPayload());\r\n        r.sendResponse(ctx, msg, new CorfuMsg(CorfuMsgType.ACK));\r\n        try {\r\n            Thread.sleep(3000);\r\n        } catch (InterruptedException e) {\r\n            e.printStackTrace();\r\n        }\r\n    }\r\n```\r\nThe ack is received by the test case and it then sends the failure message which is somehow lost/blocked.\r\nThe server then gets busy in trying to connect to a layout server which doesn't exist at test:9000."}}
{"actor":{"display_login":"zalokhan"}}