{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/24578","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/24578/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/24578/comments","events_url":"https://api.github.com/repos/rails/rails/issues/24578/events","html_url":"https://github.com/rails/rails/pull/24578","id":148845347,"number":24578,"title":"fix scaffold.css","user":{"login":"mabras","id":9248917,"avatar_url":"https://avatars.githubusercontent.com/u/9248917?v=3","gravatar_id":"","url":"https://api.github.com/users/mabras","html_url":"https://github.com/mabras","followers_url":"https://api.github.com/users/mabras/followers","following_url":"https://api.github.com/users/mabras/following{/other_user}","gists_url":"https://api.github.com/users/mabras/gists{/gist_id}","starred_url":"https://api.github.com/users/mabras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mabras/subscriptions","organizations_url":"https://api.github.com/users/mabras/orgs","repos_url":"https://api.github.com/users/mabras/repos","events_url":"https://api.github.com/users/mabras/events{/privacy}","received_events_url":"https://api.github.com/users/mabras/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rails/rails/labels/railties","name":"railties","color":"8BE06E"}],"state":"open","locked":false,"assignee":{"login":"senny","id":5402,"avatar_url":"https://avatars.githubusercontent.com/u/5402?v=3","gravatar_id":"","url":"https://api.github.com/users/senny","html_url":"https://github.com/senny","followers_url":"https://api.github.com/users/senny/followers","following_url":"https://api.github.com/users/senny/following{/other_user}","gists_url":"https://api.github.com/users/senny/gists{/gist_id}","starred_url":"https://api.github.com/users/senny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senny/subscriptions","organizations_url":"https://api.github.com/users/senny/orgs","repos_url":"https://api.github.com/users/senny/repos","events_url":"https://api.github.com/users/senny/events{/privacy}","received_events_url":"https://api.github.com/users/senny/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-04-16T11:54:25Z","updated_at":"2016-04-20T09:26:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/24578","html_url":"https://github.com/rails/rails/pull/24578","diff_url":"https://github.com/rails/rails/pull/24578.diff","patch_url":"https://github.com/rails/rails/pull/24578.patch"},"body":"Do we need to repeat the styling?\r\n\r\nThe current scaffold generator generate:\r\n\r\n```css\r\nbody {                                               \r\n  background-color: #fff;                            \r\n  color: #333;                                       \r\n  font-family: verdana, arial, helvetica, sans-serif;\r\n  font-size: 13px;                                   \r\n  line-height: 18px;                                 \r\n  margin: 33px;                                      \r\n}                                                    \r\n                                                     \r\np, ol, ul, td {                                      \r\n  font-family: verdana, arial, helvetica, sans-serif;\r\n  font-size: 13px;                                   \r\n  line-height: 18px;                                 \r\n  margin: 33px;                                      \r\n}\r\n```\r\n\r\nNow:\r\n\r\n```css\r\nbody {                                               \r\n  background-color: #fff;                            \r\n  color: #333;                                       \r\n  font-family: verdana, arial, helvetica, sans-serif;\r\n  font-size: 13px;                                   \r\n  line-height: 18px;                                 \r\n  margin: 33px;                                      \r\n}                                                    \r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/212346949","html_url":"https://github.com/rails/rails/pull/24578#issuecomment-212346949","issue_url":"https://api.github.com/repos/rails/rails/issues/24578","id":212346949,"user":{"login":"mabras","id":9248917,"avatar_url":"https://avatars.githubusercontent.com/u/9248917?v=3","gravatar_id":"","url":"https://api.github.com/users/mabras","html_url":"https://github.com/mabras","followers_url":"https://api.github.com/users/mabras/followers","following_url":"https://api.github.com/users/mabras/following{/other_user}","gists_url":"https://api.github.com/users/mabras/gists{/gist_id}","starred_url":"https://api.github.com/users/mabras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mabras/subscriptions","organizations_url":"https://api.github.com/users/mabras/orgs","repos_url":"https://api.github.com/users/mabras/repos","events_url":"https://api.github.com/users/mabras/events{/privacy}","received_events_url":"https://api.github.com/users/mabras/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T09:26:03Z","updated_at":"2016-04-20T09:26:03Z","body":"> That's not how margins work - they are not inherited, they are applied to the specified element. Those paragraphs do not have a 33px margin on them.\r\n\r\n:+1: \r\n\r\nShould I close, @rafaelfranca"}}