{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/twentyseventeen/issues/277","repository_url":"https://api.github.com/repos/WordPress/twentyseventeen","labels_url":"https://api.github.com/repos/WordPress/twentyseventeen/issues/277/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/twentyseventeen/issues/277/comments","events_url":"https://api.github.com/repos/WordPress/twentyseventeen/issues/277/events","html_url":"https://github.com/WordPress/twentyseventeen/issues/277","id":182696439,"number":277,"title":"jQuery $ in variable names","user":{"login":"joshcummingsdesign","id":11913201,"avatar_url":"https://avatars.githubusercontent.com/u/11913201?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcummingsdesign","html_url":"https://github.com/joshcummingsdesign","followers_url":"https://api.github.com/users/joshcummingsdesign/followers","following_url":"https://api.github.com/users/joshcummingsdesign/following{/other_user}","gists_url":"https://api.github.com/users/joshcummingsdesign/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcummingsdesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcummingsdesign/subscriptions","organizations_url":"https://api.github.com/users/joshcummingsdesign/orgs","repos_url":"https://api.github.com/users/joshcummingsdesign/repos","events_url":"https://api.github.com/users/joshcummingsdesign/events{/privacy}","received_events_url":"https://api.github.com/users/joshcummingsdesign/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/WordPress/twentyseventeen/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-13T05:05:18Z","updated_at":"2016-10-14T08:49:13Z","closed_at":null,"body":"As a style, I would think that the dollar sign in javascript files would only be used for variables that store jQuery objects, not values.\r\n\r\nFor example you would write:\r\n```javascript\r\nvar $navigation = $( '.navigation-top' );\r\n```\r\n\r\nBut not:\r\n```javascript\r\n$navigationHeight = $navigation.outerHeight();\r\n```\r\n\r\nThe former is returning a collection of matched elements, and the latter is returning a float.\r\n\r\nTherefore it can be rewritten like so:\r\n```javascript\r\nnavigationHeight = $navigation.outerHeight();\r\n```\r\n\r\nA small detail and maybe a nice-to-have, but thought it would be good to discuss."},"comment":{"url":"https://api.github.com/repos/WordPress/twentyseventeen/issues/comments/253744080","html_url":"https://github.com/WordPress/twentyseventeen/issues/277#issuecomment-253744080","issue_url":"https://api.github.com/repos/WordPress/twentyseventeen/issues/277","id":253744080,"user":{"login":"joshcummingsdesign","id":11913201,"avatar_url":"https://avatars.githubusercontent.com/u/11913201?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcummingsdesign","html_url":"https://github.com/joshcummingsdesign","followers_url":"https://api.github.com/users/joshcummingsdesign/followers","following_url":"https://api.github.com/users/joshcummingsdesign/following{/other_user}","gists_url":"https://api.github.com/users/joshcummingsdesign/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcummingsdesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcummingsdesign/subscriptions","organizations_url":"https://api.github.com/users/joshcummingsdesign/orgs","repos_url":"https://api.github.com/users/joshcummingsdesign/repos","events_url":"https://api.github.com/users/joshcummingsdesign/events{/privacy}","received_events_url":"https://api.github.com/users/joshcummingsdesign/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T08:49:13Z","updated_at":"2016-10-14T08:49:13Z","body":"#306 Is an example of global.js refactored for optimization and addresses the jQuery '$' sign issue."}}
{"actor":{"display_login":"joshcummingsdesign"}}