{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/comments/86979495","pull_request_review_id":7609098,"id":86979495,"diff_hunk":"@@ -28,20 +31,20 @@ public function supportsDenormalization($data, $type, $format = null) : bool\n     public function normalize($object, $format = null, array $context = []) : array\n     {\n         $data = [\n-            'formatted' => $object->getFormatted(),\n+            'formatted' => $object->getFormatted()->toArray(),\n             'components' => [],\n         ];\n \n-        if ($object->getStreetAddress()) {\n-            $data['components']['streetAddress'] = $object->getStreetAddress();\n+        if (!$object->getStreetAddress()->isEmpty()) {","path":"src/Serializer/AddressNormalizer.php","position":34,"original_position":34,"commit_id":"45d6f6de019e10e403b4a5d2dd83818275837f98","original_commit_id":"45d6f6de019e10e403b4a5d2dd83818275837f98","user":{"login":"thewilkybarkid","id":1784740,"avatar_url":"https://avatars.githubusercontent.com/u/1784740?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"body":"If it were `if (!$streetAddress->isEmpty())` I'd say it's ok, but the `!` is a bit disconnected here. Maybe `notEmpty()`?","created_at":"2016-11-08T12:36:35Z","updated_at":"2016-11-08T12:36:35Z","html_url":"https://github.com/elifesciences/api-sdk-php/pull/49#discussion_r86979495","pull_request_url":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/comments/86979495"},"html":{"href":"https://github.com/elifesciences/api-sdk-php/pull/49#discussion_r86979495"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/49","id":92767534,"html_url":"https://github.com/elifesciences/api-sdk-php/pull/49","diff_url":"https://github.com/elifesciences/api-sdk-php/pull/49.diff","patch_url":"https://github.com/elifesciences/api-sdk-php/pull/49.patch","issue_url":"https://api.github.com/repos/elifesciences/api-sdk-php/issues/49","number":49,"state":"open","locked":false,"title":"[WIP] Address using ArraySequence objects instead of arrays","user":{"login":"giorgiosironi","id":160299,"avatar_url":"https://avatars.githubusercontent.com/u/160299?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"I only updated the tests of Address itself, to get some feedback. Is this the right direction?","created_at":"2016-11-08T12:20:54Z","updated_at":"2016-11-08T12:36:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df65d978455c98f9f2ab5503b428b9ad621d7c9d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/49/commits","review_comments_url":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/49/comments","review_comment_url":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/api-sdk-php/issues/49/comments","statuses_url":"https://api.github.com/repos/elifesciences/api-sdk-php/statuses/45d6f6de019e10e403b4a5d2dd83818275837f98","head":{"label":"elifesciences:address_sequences","ref":"address_sequences","sha":"45d6f6de019e10e403b4a5d2dd83818275837f98","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":67200839,"name":"api-sdk-php","full_name":"elifesciences/api-sdk-php","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/api-sdk-php","description":"PHP SDK for the eLife Sciences API [in development]","fork":false,"url":"https://api.github.com/repos/elifesciences/api-sdk-php","forks_url":"https://api.github.com/repos/elifesciences/api-sdk-php/forks","keys_url":"https://api.github.com/repos/elifesciences/api-sdk-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/api-sdk-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/api-sdk-php/teams","hooks_url":"https://api.github.com/repos/elifesciences/api-sdk-php/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/api-sdk-php/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/api-sdk-php/events","assignees_url":"https://api.github.com/repos/elifesciences/api-sdk-php/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/api-sdk-php/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/api-sdk-php/tags","blobs_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/api-sdk-php/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/api-sdk-php/languages","stargazers_url":"https://api.github.com/repos/elifesciences/api-sdk-php/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/api-sdk-php/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/api-sdk-php/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/api-sdk-php/subscription","commits_url":"https://api.github.com/repos/elifesciences/api-sdk-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/api-sdk-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/api-sdk-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/api-sdk-php/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/api-sdk-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/api-sdk-php/merges","archive_url":"https://api.github.com/repos/elifesciences/api-sdk-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/api-sdk-php/downloads","issues_url":"https://api.github.com/repos/elifesciences/api-sdk-php/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/api-sdk-php/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/api-sdk-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/api-sdk-php/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/api-sdk-php/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/api-sdk-php/deployments","created_at":"2016-09-02T07:30:40Z","updated_at":"2016-10-24T14:48:24Z","pushed_at":"2016-11-08T12:20:54Z","git_url":"git://github.com/elifesciences/api-sdk-php.git","ssh_url":"git@github.com:elifesciences/api-sdk-php.git","clone_url":"https://github.com/elifesciences/api-sdk-php.git","svn_url":"https://github.com/elifesciences/api-sdk-php","homepage":null,"size":587,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"elifesciences:master","ref":"master","sha":"05f1cbd520eedc18cd2ac6b034dda8393cc91cfe","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":67200839,"name":"api-sdk-php","full_name":"elifesciences/api-sdk-php","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/api-sdk-php","description":"PHP SDK for the eLife Sciences API [in development]","fork":false,"url":"https://api.github.com/repos/elifesciences/api-sdk-php","forks_url":"https://api.github.com/repos/elifesciences/api-sdk-php/forks","keys_url":"https://api.github.com/repos/elifesciences/api-sdk-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/api-sdk-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/api-sdk-php/teams","hooks_url":"https://api.github.com/repos/elifesciences/api-sdk-php/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/api-sdk-php/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/api-sdk-php/events","assignees_url":"https://api.github.com/repos/elifesciences/api-sdk-php/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/api-sdk-php/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/api-sdk-php/tags","blobs_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/api-sdk-php/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/api-sdk-php/languages","stargazers_url":"https://api.github.com/repos/elifesciences/api-sdk-php/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/api-sdk-php/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/api-sdk-php/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/api-sdk-php/subscription","commits_url":"https://api.github.com/repos/elifesciences/api-sdk-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/api-sdk-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/api-sdk-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/api-sdk-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/api-sdk-php/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/api-sdk-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/api-sdk-php/merges","archive_url":"https://api.github.com/repos/elifesciences/api-sdk-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/api-sdk-php/downloads","issues_url":"https://api.github.com/repos/elifesciences/api-sdk-php/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/api-sdk-php/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/api-sdk-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/api-sdk-php/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/api-sdk-php/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/api-sdk-php/deployments","created_at":"2016-09-02T07:30:40Z","updated_at":"2016-10-24T14:48:24Z","pushed_at":"2016-11-08T12:20:54Z","git_url":"git://github.com/elifesciences/api-sdk-php.git","ssh_url":"git@github.com:elifesciences/api-sdk-php.git","clone_url":"https://github.com/elifesciences/api-sdk-php.git","svn_url":"https://github.com/elifesciences/api-sdk-php","homepage":null,"size":587,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/49"},"html":{"href":"https://github.com/elifesciences/api-sdk-php/pull/49"},"issue":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/issues/49"},"comments":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/api-sdk-php/statuses/45d6f6de019e10e403b4a5d2dd83818275837f98"}}}}
{"actor":{"display_login":"thewilkybarkid"}}