{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material/pulls/comments/84572900","pull_request_review_id":5345625,"id":84572900,"diff_hunk":"@@ -2823,12 +2837,12 @@ describe('$mdPanel', function() {\n     attachedElements.push(element);\n   }\n \n-  function clickPanelContainer() {\n+  function clickPanelContainer(container) {\n     if (!panelRef) {\n       return;\n     }\n \n-    var container = panelRef.panelContainer;\n+    var container = container || panelRef.panelContainer;","path":"src/components/panel/panel.spec.js","position":32,"original_position":32,"commit_id":"f0ad663cc6aa7f11eba9312d813ad14cc7712fb1","original_commit_id":"f0ad663cc6aa7f11eba9312d813ad14cc7712fb1","user":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars.githubusercontent.com/u/4450522?v=3","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"body":"It's a bad practise to have variables with the same name as function arguments. ","created_at":"2016-10-22T08:38:38Z","updated_at":"2016-10-22T08:38:48Z","html_url":"https://github.com/angular/material/pull/9886#discussion_r84572900","pull_request_url":"https://api.github.com/repos/angular/material/pulls/9886","_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/comments/84572900"},"html":{"href":"https://github.com/angular/material/pull/9886#discussion_r84572900"},"pull_request":{"href":"https://api.github.com/repos/angular/material/pulls/9886"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material/pulls/9886","id":90426655,"html_url":"https://github.com/angular/material/pull/9886","diff_url":"https://github.com/angular/material/pull/9886.diff","patch_url":"https://github.com/angular/material/pull/9886.patch","issue_url":"https://api.github.com/repos/angular/material/issues/9886","number":9886,"state":"open","locked":false,"title":"fix(panel): clickOutsideToClose with propagateContainerEvents","user":{"login":"bradrich","id":3429878,"avatar_url":"https://avatars.githubusercontent.com/u/3429878?v=3","gravatar_id":"","url":"https://api.github.com/users/bradrich","html_url":"https://github.com/bradrich","followers_url":"https://api.github.com/users/bradrich/followers","following_url":"https://api.github.com/users/bradrich/following{/other_user}","gists_url":"https://api.github.com/users/bradrich/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich/subscriptions","organizations_url":"https://api.github.com/users/bradrich/orgs","repos_url":"https://api.github.com/users/bradrich/repos","events_url":"https://api.github.com/users/bradrich/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich/received_events","type":"User","site_admin":false},"body":"If both the `clickOutsideToClose` and `propagateContainerEvents` parameters are set to true within the panel configuration, then the panel will be closed when a click happens outside of the panel.\r\n\r\nFixes #9388","created_at":"2016-10-21T18:52:23Z","updated_at":"2016-10-22T08:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecf98a52663a42068aad245e3ac071f8f087b366","assignee":{"login":"DerekLouie","id":709204,"avatar_url":"https://avatars.githubusercontent.com/u/709204?v=3","gravatar_id":"","url":"https://api.github.com/users/DerekLouie","html_url":"https://github.com/DerekLouie","followers_url":"https://api.github.com/users/DerekLouie/followers","following_url":"https://api.github.com/users/DerekLouie/following{/other_user}","gists_url":"https://api.github.com/users/DerekLouie/gists{/gist_id}","starred_url":"https://api.github.com/users/DerekLouie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DerekLouie/subscriptions","organizations_url":"https://api.github.com/users/DerekLouie/orgs","repos_url":"https://api.github.com/users/DerekLouie/repos","events_url":"https://api.github.com/users/DerekLouie/events{/privacy}","received_events_url":"https://api.github.com/users/DerekLouie/received_events","type":"User","site_admin":false},"assignees":[{"login":"DerekLouie","id":709204,"avatar_url":"https://avatars.githubusercontent.com/u/709204?v=3","gravatar_id":"","url":"https://api.github.com/users/DerekLouie","html_url":"https://github.com/DerekLouie","followers_url":"https://api.github.com/users/DerekLouie/followers","following_url":"https://api.github.com/users/DerekLouie/following{/other_user}","gists_url":"https://api.github.com/users/DerekLouie/gists{/gist_id}","starred_url":"https://api.github.com/users/DerekLouie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DerekLouie/subscriptions","organizations_url":"https://api.github.com/users/DerekLouie/orgs","repos_url":"https://api.github.com/users/DerekLouie/repos","events_url":"https://api.github.com/users/DerekLouie/events{/privacy}","received_events_url":"https://api.github.com/users/DerekLouie/received_events","type":"User","site_admin":false},{"login":"ErinCoughlan","id":2660421,"avatar_url":"https://avatars.githubusercontent.com/u/2660421?v=3","gravatar_id":"","url":"https://api.github.com/users/ErinCoughlan","html_url":"https://github.com/ErinCoughlan","followers_url":"https://api.github.com/users/ErinCoughlan/followers","following_url":"https://api.github.com/users/ErinCoughlan/following{/other_user}","gists_url":"https://api.github.com/users/ErinCoughlan/gists{/gist_id}","starred_url":"https://api.github.com/users/ErinCoughlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErinCoughlan/subscriptions","organizations_url":"https://api.github.com/users/ErinCoughlan/orgs","repos_url":"https://api.github.com/users/ErinCoughlan/repos","events_url":"https://api.github.com/users/ErinCoughlan/events{/privacy}","received_events_url":"https://api.github.com/users/ErinCoughlan/received_events","type":"User","site_admin":false},{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars.githubusercontent.com/u/4450522?v=3","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material/pulls/9886/commits","review_comments_url":"https://api.github.com/repos/angular/material/pulls/9886/comments","review_comment_url":"https://api.github.com/repos/angular/material/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material/issues/9886/comments","statuses_url":"https://api.github.com/repos/angular/material/statuses/f0ad663cc6aa7f11eba9312d813ad14cc7712fb1","head":{"label":"bradrich:fix/clickOutsideToClose-with-propagateContainerEvents","ref":"fix/clickOutsideToClose-with-propagateContainerEvents","sha":"f0ad663cc6aa7f11eba9312d813ad14cc7712fb1","user":{"login":"bradrich","id":3429878,"avatar_url":"https://avatars.githubusercontent.com/u/3429878?v=3","gravatar_id":"","url":"https://api.github.com/users/bradrich","html_url":"https://github.com/bradrich","followers_url":"https://api.github.com/users/bradrich/followers","following_url":"https://api.github.com/users/bradrich/following{/other_user}","gists_url":"https://api.github.com/users/bradrich/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich/subscriptions","organizations_url":"https://api.github.com/users/bradrich/orgs","repos_url":"https://api.github.com/users/bradrich/repos","events_url":"https://api.github.com/users/bradrich/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich/received_events","type":"User","site_admin":false},"repo":{"id":61638631,"name":"material","full_name":"bradrich/material","owner":{"login":"bradrich","id":3429878,"avatar_url":"https://avatars.githubusercontent.com/u/3429878?v=3","gravatar_id":"","url":"https://api.github.com/users/bradrich","html_url":"https://github.com/bradrich","followers_url":"https://api.github.com/users/bradrich/followers","following_url":"https://api.github.com/users/bradrich/following{/other_user}","gists_url":"https://api.github.com/users/bradrich/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich/subscriptions","organizations_url":"https://api.github.com/users/bradrich/orgs","repos_url":"https://api.github.com/users/bradrich/repos","events_url":"https://api.github.com/users/bradrich/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradrich/material","description":"Material design for Angular","fork":true,"url":"https://api.github.com/repos/bradrich/material","forks_url":"https://api.github.com/repos/bradrich/material/forks","keys_url":"https://api.github.com/repos/bradrich/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradrich/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradrich/material/teams","hooks_url":"https://api.github.com/repos/bradrich/material/hooks","issue_events_url":"https://api.github.com/repos/bradrich/material/issues/events{/number}","events_url":"https://api.github.com/repos/bradrich/material/events","assignees_url":"https://api.github.com/repos/bradrich/material/assignees{/user}","branches_url":"https://api.github.com/repos/bradrich/material/branches{/branch}","tags_url":"https://api.github.com/repos/bradrich/material/tags","blobs_url":"https://api.github.com/repos/bradrich/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradrich/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradrich/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradrich/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradrich/material/statuses/{sha}","languages_url":"https://api.github.com/repos/bradrich/material/languages","stargazers_url":"https://api.github.com/repos/bradrich/material/stargazers","contributors_url":"https://api.github.com/repos/bradrich/material/contributors","subscribers_url":"https://api.github.com/repos/bradrich/material/subscribers","subscription_url":"https://api.github.com/repos/bradrich/material/subscription","commits_url":"https://api.github.com/repos/bradrich/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradrich/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradrich/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradrich/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradrich/material/contents/{+path}","compare_url":"https://api.github.com/repos/bradrich/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradrich/material/merges","archive_url":"https://api.github.com/repos/bradrich/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradrich/material/downloads","issues_url":"https://api.github.com/repos/bradrich/material/issues{/number}","pulls_url":"https://api.github.com/repos/bradrich/material/pulls{/number}","milestones_url":"https://api.github.com/repos/bradrich/material/milestones{/number}","notifications_url":"https://api.github.com/repos/bradrich/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradrich/material/labels{/name}","releases_url":"https://api.github.com/repos/bradrich/material/releases{/id}","deployments_url":"https://api.github.com/repos/bradrich/material/deployments","created_at":"2016-06-21T14:04:28Z","updated_at":"2016-06-21T14:04:32Z","pushed_at":"2016-10-21T20:31:21Z","git_url":"git://github.com/bradrich/material.git","ssh_url":"git@github.com:bradrich/material.git","clone_url":"https://github.com/bradrich/material.git","svn_url":"https://github.com/bradrich/material","homepage":"https://material.angularjs.org/","size":45163,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"e3619e6784e4b7d7ad32ea13421ff08967e2253c","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":21399598,"name":"material","full_name":"angular/material","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material","description":"Material design for Angular","fork":false,"url":"https://api.github.com/repos/angular/material","forks_url":"https://api.github.com/repos/angular/material/forks","keys_url":"https://api.github.com/repos/angular/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material/teams","hooks_url":"https://api.github.com/repos/angular/material/hooks","issue_events_url":"https://api.github.com/repos/angular/material/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material/events","assignees_url":"https://api.github.com/repos/angular/material/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material/tags","blobs_url":"https://api.github.com/repos/angular/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material/languages","stargazers_url":"https://api.github.com/repos/angular/material/stargazers","contributors_url":"https://api.github.com/repos/angular/material/contributors","subscribers_url":"https://api.github.com/repos/angular/material/subscribers","subscription_url":"https://api.github.com/repos/angular/material/subscription","commits_url":"https://api.github.com/repos/angular/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material/merges","archive_url":"https://api.github.com/repos/angular/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material/downloads","issues_url":"https://api.github.com/repos/angular/material/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material/labels{/name}","releases_url":"https://api.github.com/repos/angular/material/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material/deployments","created_at":"2014-07-01T19:20:06Z","updated_at":"2016-10-22T04:59:54Z","pushed_at":"2016-10-21T22:07:20Z","git_url":"git://github.com/angular/material.git","ssh_url":"git@github.com:angular/material.git","clone_url":"https://github.com/angular/material.git","svn_url":"https://github.com/angular/material","homepage":"https://material.angularjs.org/","size":82689,"stargazers_count":14693,"watchers_count":14693,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3110,"mirror_url":null,"open_issues_count":357,"forks":3110,"open_issues":357,"watchers":14693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/9886"},"html":{"href":"https://github.com/angular/material/pull/9886"},"issue":{"href":"https://api.github.com/repos/angular/material/issues/9886"},"comments":{"href":"https://api.github.com/repos/angular/material/issues/9886/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material/pulls/9886/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material/pulls/9886/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material/statuses/f0ad663cc6aa7f11eba9312d813ad14cc7712fb1"}}}}
{"actor":{"display_login":"crisbeto"}}