{"action":"created","comment":{"url":"https://api.github.com/repos/O-C-R/floodwatch/pulls/comments/91977005","pull_request_review_id":12328494,"id":91977005,"diff_hunk":"@@ -62,43 +86,84 @@ export class CompareContainer extends Component {\n \n   async componentDidMount(): any {\n     const AdBreakdown = await FWApiClient.get().getFilteredAdCounts({ filterA: {}, filterB: {} })\n+    const FilterATopic = d3.entries(AdBreakdown.filterA.categories).sort(function(a, b) {\n+      return d3.descending(a.value, b.value);\n+    })[0]\n+\n+    const UserData = await FWApiClient.get().getCurrentPerson()\n \n     this.setState({\n       leftData: AdBreakdown.filterA.categories,\n-      rightData: AdBreakdown.filterB.categories\n+      rightData: AdBreakdown.filterB.categories,\n+      currentTopic: FilterATopic.key,\n+      userData: UserData\n+    })\n+  }\n+\n+  updateMouseOver(newTopic: string): void {\n+    this.setState({\n+      currentTopic: newTopic\n     })\n   }\n \n-  createSentence(options: Object): string {\n-    let sentence = 'Floodwatch users';\n-    if (options.length == 0) {\n-      sentence = 'All ' + sentence;\n-      return sentence\n+  changeCategoriesCustom(side: string, mouse: Event, info: Filter, checked: boolean, event: any): void {","path":"floodwatch/src/js/components/Compare.js","position":116,"original_position":116,"commit_id":"3a0ad3eec3250431f8a886129378837c45699bd9","original_commit_id":"3a0ad3eec3250431f8a886129378837c45699bd9","user":{"login":"chanderson0","id":73099,"avatar_url":"https://avatars.githubusercontent.com/u/73099?v=3","gravatar_id":"","url":"https://api.github.com/users/chanderson0","html_url":"https://github.com/chanderson0","followers_url":"https://api.github.com/users/chanderson0/followers","following_url":"https://api.github.com/users/chanderson0/following{/other_user}","gists_url":"https://api.github.com/users/chanderson0/gists{/gist_id}","starred_url":"https://api.github.com/users/chanderson0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanderson0/subscriptions","organizations_url":"https://api.github.com/users/chanderson0/orgs","repos_url":"https://api.github.com/users/chanderson0/repos","events_url":"https://api.github.com/users/chanderson0/events{/privacy}","received_events_url":"https://api.github.com/users/chanderson0/received_events","type":"User","site_admin":false},"body":"Also I'm pretty sure you bound `this` to the far inner component... is that the intention? There's probably a cleaner way to get the options of that component. Will ask you.","created_at":"2016-12-12T16:04:30Z","updated_at":"2016-12-12T16:04:30Z","html_url":"https://github.com/O-C-R/floodwatch/pull/45#discussion_r91977005","pull_request_url":"https://api.github.com/repos/O-C-R/floodwatch/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/O-C-R/floodwatch/pulls/comments/91977005"},"html":{"href":"https://github.com/O-C-R/floodwatch/pull/45#discussion_r91977005"},"pull_request":{"href":"https://api.github.com/repos/O-C-R/floodwatch/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/O-C-R/floodwatch/pulls/45","id":97344105,"html_url":"https://github.com/O-C-R/floodwatch/pull/45","diff_url":"https://github.com/O-C-R/floodwatch/pull/45.diff","patch_url":"https://github.com/O-C-R/floodwatch/pull/45.patch","issue_url":"https://api.github.com/repos/O-C-R/floodwatch/issues/45","number":45,"state":"open","locked":false,"title":"Filters","user":{"login":"friej715","id":1028403,"avatar_url":"https://avatars.githubusercontent.com/u/1028403?v=3","gravatar_id":"","url":"https://api.github.com/users/friej715","html_url":"https://github.com/friej715","followers_url":"https://api.github.com/users/friej715/followers","following_url":"https://api.github.com/users/friej715/following{/other_user}","gists_url":"https://api.github.com/users/friej715/gists{/gist_id}","starred_url":"https://api.github.com/users/friej715/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friej715/subscriptions","organizations_url":"https://api.github.com/users/friej715/orgs","repos_url":"https://api.github.com/users/friej715/repos","events_url":"https://api.github.com/users/friej715/events{/privacy}","received_events_url":"https://api.github.com/users/friej715/received_events","type":"User","site_admin":false},"body":"Last PR: the graphs. This PR: the filters!\r\n\r\n![screen shot 2016-12-09 at 3 30 38 pm](https://cloud.githubusercontent.com/assets/1028403/21063606/7dc8a51c-be24-11e6-8de1-708582f9e756.png)\r\n\r\nHere's what this PR tackles:\r\n* Comparison modal popping up when you click it, and updates the main area when you select new options.\r\n* Modal pulls from the right demographic categories and reads demographics from the user object being returned by the API.\r\n* Modal knows what options should be disabled based on what the user has filled in.\r\n\r\nHere's some things TK:\r\n* Right now, if a custom filter is disabled, you just don't see it. (It should be grayed out and prompt you to fill in information.)\r\n* Right now, if you click a preset that's disabled, you don't get the 'fill your stuff in' popover. (You should.)\r\n* Right now, you can't choose the logic applied to your custom filters. (You should be able to.)\r\n\r\nYou'll notice big chunks of commented-out code in `CustomFilter.js` and `RequireOverlay.js`, which are related to the above TKs, and which you can ignore for now. Thought it'd be more important to review this pretty big PR first, and shunt that overlay into a later one.\r\n","created_at":"2016-12-09T17:02:16Z","updated_at":"2016-12-12T16:23:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f468c0a99d932d70a33246895f1fe0d992dde144","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/O-C-R/floodwatch/pulls/45/commits","review_comments_url":"https://api.github.com/repos/O-C-R/floodwatch/pulls/45/comments","review_comment_url":"https://api.github.com/repos/O-C-R/floodwatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/O-C-R/floodwatch/issues/45/comments","statuses_url":"https://api.github.com/repos/O-C-R/floodwatch/statuses/3a0ad3eec3250431f8a886129378837c45699bd9","head":{"label":"O-C-R:filters","ref":"filters","sha":"3a0ad3eec3250431f8a886129378837c45699bd9","user":{"login":"O-C-R","id":4283483,"avatar_url":"https://avatars.githubusercontent.com/u/4283483?v=3","gravatar_id":"","url":"https://api.github.com/users/O-C-R","html_url":"https://github.com/O-C-R","followers_url":"https://api.github.com/users/O-C-R/followers","following_url":"https://api.github.com/users/O-C-R/following{/other_user}","gists_url":"https://api.github.com/users/O-C-R/gists{/gist_id}","starred_url":"https://api.github.com/users/O-C-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/O-C-R/subscriptions","organizations_url":"https://api.github.com/users/O-C-R/orgs","repos_url":"https://api.github.com/users/O-C-R/repos","events_url":"https://api.github.com/users/O-C-R/events{/privacy}","received_events_url":"https://api.github.com/users/O-C-R/received_events","type":"Organization","site_admin":false},"repo":{"id":68646162,"name":"floodwatch","full_name":"O-C-R/floodwatch","owner":{"login":"O-C-R","id":4283483,"avatar_url":"https://avatars.githubusercontent.com/u/4283483?v=3","gravatar_id":"","url":"https://api.github.com/users/O-C-R","html_url":"https://github.com/O-C-R","followers_url":"https://api.github.com/users/O-C-R/followers","following_url":"https://api.github.com/users/O-C-R/following{/other_user}","gists_url":"https://api.github.com/users/O-C-R/gists{/gist_id}","starred_url":"https://api.github.com/users/O-C-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/O-C-R/subscriptions","organizations_url":"https://api.github.com/users/O-C-R/orgs","repos_url":"https://api.github.com/users/O-C-R/repos","events_url":"https://api.github.com/users/O-C-R/events{/privacy}","received_events_url":"https://api.github.com/users/O-C-R/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/O-C-R/floodwatch","description":null,"fork":false,"url":"https://api.github.com/repos/O-C-R/floodwatch","forks_url":"https://api.github.com/repos/O-C-R/floodwatch/forks","keys_url":"https://api.github.com/repos/O-C-R/floodwatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/O-C-R/floodwatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/O-C-R/floodwatch/teams","hooks_url":"https://api.github.com/repos/O-C-R/floodwatch/hooks","issue_events_url":"https://api.github.com/repos/O-C-R/floodwatch/issues/events{/number}","events_url":"https://api.github.com/repos/O-C-R/floodwatch/events","assignees_url":"https://api.github.com/repos/O-C-R/floodwatch/assignees{/user}","branches_url":"https://api.github.com/repos/O-C-R/floodwatch/branches{/branch}","tags_url":"https://api.github.com/repos/O-C-R/floodwatch/tags","blobs_url":"https://api.github.com/repos/O-C-R/floodwatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/O-C-R/floodwatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/O-C-R/floodwatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/O-C-R/floodwatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/O-C-R/floodwatch/statuses/{sha}","languages_url":"https://api.github.com/repos/O-C-R/floodwatch/languages","stargazers_url":"https://api.github.com/repos/O-C-R/floodwatch/stargazers","contributors_url":"https://api.github.com/repos/O-C-R/floodwatch/contributors","subscribers_url":"https://api.github.com/repos/O-C-R/floodwatch/subscribers","subscription_url":"https://api.github.com/repos/O-C-R/floodwatch/subscription","commits_url":"https://api.github.com/repos/O-C-R/floodwatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/O-C-R/floodwatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/O-C-R/floodwatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/O-C-R/floodwatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/O-C-R/floodwatch/contents/{+path}","compare_url":"https://api.github.com/repos/O-C-R/floodwatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/O-C-R/floodwatch/merges","archive_url":"https://api.github.com/repos/O-C-R/floodwatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/O-C-R/floodwatch/downloads","issues_url":"https://api.github.com/repos/O-C-R/floodwatch/issues{/number}","pulls_url":"https://api.github.com/repos/O-C-R/floodwatch/pulls{/number}","milestones_url":"https://api.github.com/repos/O-C-R/floodwatch/milestones{/number}","notifications_url":"https://api.github.com/repos/O-C-R/floodwatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/O-C-R/floodwatch/labels{/name}","releases_url":"https://api.github.com/repos/O-C-R/floodwatch/releases{/id}","deployments_url":"https://api.github.com/repos/O-C-R/floodwatch/deployments","created_at":"2016-09-19T20:59:09Z","updated_at":"2016-11-16T15:06:03Z","pushed_at":"2016-12-09T20:30:14Z","git_url":"git://github.com/O-C-R/floodwatch.git","ssh_url":"git@github.com:O-C-R/floodwatch.git","clone_url":"https://github.com/O-C-R/floodwatch.git","svn_url":"https://github.com/O-C-R/floodwatch","homepage":null,"size":90222,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":28,"forks":0,"open_issues":28,"watchers":0,"default_branch":"master"}},"base":{"label":"O-C-R:develop","ref":"develop","sha":"1966dbc62615a59f1a870c204098d4ee1757538c","user":{"login":"O-C-R","id":4283483,"avatar_url":"https://avatars.githubusercontent.com/u/4283483?v=3","gravatar_id":"","url":"https://api.github.com/users/O-C-R","html_url":"https://github.com/O-C-R","followers_url":"https://api.github.com/users/O-C-R/followers","following_url":"https://api.github.com/users/O-C-R/following{/other_user}","gists_url":"https://api.github.com/users/O-C-R/gists{/gist_id}","starred_url":"https://api.github.com/users/O-C-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/O-C-R/subscriptions","organizations_url":"https://api.github.com/users/O-C-R/orgs","repos_url":"https://api.github.com/users/O-C-R/repos","events_url":"https://api.github.com/users/O-C-R/events{/privacy}","received_events_url":"https://api.github.com/users/O-C-R/received_events","type":"Organization","site_admin":false},"repo":{"id":68646162,"name":"floodwatch","full_name":"O-C-R/floodwatch","owner":{"login":"O-C-R","id":4283483,"avatar_url":"https://avatars.githubusercontent.com/u/4283483?v=3","gravatar_id":"","url":"https://api.github.com/users/O-C-R","html_url":"https://github.com/O-C-R","followers_url":"https://api.github.com/users/O-C-R/followers","following_url":"https://api.github.com/users/O-C-R/following{/other_user}","gists_url":"https://api.github.com/users/O-C-R/gists{/gist_id}","starred_url":"https://api.github.com/users/O-C-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/O-C-R/subscriptions","organizations_url":"https://api.github.com/users/O-C-R/orgs","repos_url":"https://api.github.com/users/O-C-R/repos","events_url":"https://api.github.com/users/O-C-R/events{/privacy}","received_events_url":"https://api.github.com/users/O-C-R/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/O-C-R/floodwatch","description":null,"fork":false,"url":"https://api.github.com/repos/O-C-R/floodwatch","forks_url":"https://api.github.com/repos/O-C-R/floodwatch/forks","keys_url":"https://api.github.com/repos/O-C-R/floodwatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/O-C-R/floodwatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/O-C-R/floodwatch/teams","hooks_url":"https://api.github.com/repos/O-C-R/floodwatch/hooks","issue_events_url":"https://api.github.com/repos/O-C-R/floodwatch/issues/events{/number}","events_url":"https://api.github.com/repos/O-C-R/floodwatch/events","assignees_url":"https://api.github.com/repos/O-C-R/floodwatch/assignees{/user}","branches_url":"https://api.github.com/repos/O-C-R/floodwatch/branches{/branch}","tags_url":"https://api.github.com/repos/O-C-R/floodwatch/tags","blobs_url":"https://api.github.com/repos/O-C-R/floodwatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/O-C-R/floodwatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/O-C-R/floodwatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/O-C-R/floodwatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/O-C-R/floodwatch/statuses/{sha}","languages_url":"https://api.github.com/repos/O-C-R/floodwatch/languages","stargazers_url":"https://api.github.com/repos/O-C-R/floodwatch/stargazers","contributors_url":"https://api.github.com/repos/O-C-R/floodwatch/contributors","subscribers_url":"https://api.github.com/repos/O-C-R/floodwatch/subscribers","subscription_url":"https://api.github.com/repos/O-C-R/floodwatch/subscription","commits_url":"https://api.github.com/repos/O-C-R/floodwatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/O-C-R/floodwatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/O-C-R/floodwatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/O-C-R/floodwatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/O-C-R/floodwatch/contents/{+path}","compare_url":"https://api.github.com/repos/O-C-R/floodwatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/O-C-R/floodwatch/merges","archive_url":"https://api.github.com/repos/O-C-R/floodwatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/O-C-R/floodwatch/downloads","issues_url":"https://api.github.com/repos/O-C-R/floodwatch/issues{/number}","pulls_url":"https://api.github.com/repos/O-C-R/floodwatch/pulls{/number}","milestones_url":"https://api.github.com/repos/O-C-R/floodwatch/milestones{/number}","notifications_url":"https://api.github.com/repos/O-C-R/floodwatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/O-C-R/floodwatch/labels{/name}","releases_url":"https://api.github.com/repos/O-C-R/floodwatch/releases{/id}","deployments_url":"https://api.github.com/repos/O-C-R/floodwatch/deployments","created_at":"2016-09-19T20:59:09Z","updated_at":"2016-11-16T15:06:03Z","pushed_at":"2016-12-09T20:30:14Z","git_url":"git://github.com/O-C-R/floodwatch.git","ssh_url":"git@github.com:O-C-R/floodwatch.git","clone_url":"https://github.com/O-C-R/floodwatch.git","svn_url":"https://github.com/O-C-R/floodwatch","homepage":null,"size":90222,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":28,"forks":0,"open_issues":28,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/O-C-R/floodwatch/pulls/45"},"html":{"href":"https://github.com/O-C-R/floodwatch/pull/45"},"issue":{"href":"https://api.github.com/repos/O-C-R/floodwatch/issues/45"},"comments":{"href":"https://api.github.com/repos/O-C-R/floodwatch/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/O-C-R/floodwatch/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/O-C-R/floodwatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/O-C-R/floodwatch/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/O-C-R/floodwatch/statuses/3a0ad3eec3250431f8a886129378837c45699bd9"}}}}
{"actor":{"display_login":"chanderson0"}}