{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2747","repository_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa","labels_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2747/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2747/comments","events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2747/events","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2747","id":138323524,"number":2747,"title":"rac_notifications shouldn't strongly capture the observed object","user":{"login":"andymatuschak","id":2771,"avatar_url":"https://avatars.githubusercontent.com/u/2771?v=3","gravatar_id":"","url":"https://api.github.com/users/andymatuschak","html_url":"https://github.com/andymatuschak","followers_url":"https://api.github.com/users/andymatuschak/followers","following_url":"https://api.github.com/users/andymatuschak/following{/other_user}","gists_url":"https://api.github.com/users/andymatuschak/gists{/gist_id}","starred_url":"https://api.github.com/users/andymatuschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymatuschak/subscriptions","organizations_url":"https://api.github.com/users/andymatuschak/orgs","repos_url":"https://api.github.com/users/andymatuschak/repos","events_url":"https://api.github.com/users/andymatuschak/events{/privacy}","received_events_url":"https://api.github.com/users/andymatuschak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/milestones/6","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/milestones/4.1","labels_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/milestones/6/labels","id":1550215,"number":6,"title":"4.1","description":"","creator":{"login":"NachoSoto","id":685609,"avatar_url":"https://avatars.githubusercontent.com/u/685609?v=3","gravatar_id":"","url":"https://api.github.com/users/NachoSoto","html_url":"https://github.com/NachoSoto","followers_url":"https://api.github.com/users/NachoSoto/followers","following_url":"https://api.github.com/users/NachoSoto/following{/other_user}","gists_url":"https://api.github.com/users/NachoSoto/gists{/gist_id}","starred_url":"https://api.github.com/users/NachoSoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NachoSoto/subscriptions","organizations_url":"https://api.github.com/users/NachoSoto/orgs","repos_url":"https://api.github.com/users/NachoSoto/repos","events_url":"https://api.github.com/users/NachoSoto/events{/privacy}","received_events_url":"https://api.github.com/users/NachoSoto/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2016-01-28T23:30:57Z","updated_at":"2016-03-03T23:32:38Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-03-03T23:01:37Z","updated_at":"2016-03-04T18:10:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2747","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2747","diff_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2747.diff","patch_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2747.patch"},"body":"Other Observer-pattern-style APIs (e.g. `rac_valuesForKey`) weakly reference the observed object; I was surprised to find that `rac_notifications` extended its lifetime.\r\n\r\nAs an aside (not covered in this revision), I was surprised to find that the subscription wasn’t terminated when the observed object deallocated. I guess that’s because the API supports `AnyObject`, and we can’t observe any arbitrary object for deallocation? We could make a `Signal`-returning variant of this method—with a required `NSObject` observed object argument—which could automatically terminate the underlying effects correctly."},"comment":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/comments/192387434","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2747#issuecomment-192387434","issue_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2747","id":192387434,"user":{"login":"andymatuschak","id":2771,"avatar_url":"https://avatars.githubusercontent.com/u/2771?v=3","gravatar_id":"","url":"https://api.github.com/users/andymatuschak","html_url":"https://github.com/andymatuschak","followers_url":"https://api.github.com/users/andymatuschak/followers","following_url":"https://api.github.com/users/andymatuschak/following{/other_user}","gists_url":"https://api.github.com/users/andymatuschak/gists{/gist_id}","starred_url":"https://api.github.com/users/andymatuschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymatuschak/subscriptions","organizations_url":"https://api.github.com/users/andymatuschak/orgs","repos_url":"https://api.github.com/users/andymatuschak/repos","events_url":"https://api.github.com/users/andymatuschak/events{/privacy}","received_events_url":"https://api.github.com/users/andymatuschak/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T18:10:18Z","updated_at":"2016-03-04T18:10:18Z","body":"cc @ReactiveCocoa/reactivecocoa on API design discussion above"}}