{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/osquery/issues/2860","repository_url":"https://api.github.com/repos/facebook/osquery","labels_url":"https://api.github.com/repos/facebook/osquery/issues/2860/labels{/name}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/2860/comments","events_url":"https://api.github.com/repos/facebook/osquery/issues/2860/events","html_url":"https://github.com/facebook/osquery/pull/2860","id":194749909,"number":2860,"title":"C++ conformance fixes (MSVC /permissive-)","user":{"login":"Rastaban","id":6538528,"avatar_url":"https://avatars.githubusercontent.com/u/6538528?v=3","gravatar_id":"","url":"https://api.github.com/users/Rastaban","html_url":"https://github.com/Rastaban","followers_url":"https://api.github.com/users/Rastaban/followers","following_url":"https://api.github.com/users/Rastaban/following{/other_user}","gists_url":"https://api.github.com/users/Rastaban/gists{/gist_id}","starred_url":"https://api.github.com/users/Rastaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rastaban/subscriptions","organizations_url":"https://api.github.com/users/Rastaban/orgs","repos_url":"https://api.github.com/users/Rastaban/repos","events_url":"https://api.github.com/users/Rastaban/events{/privacy}","received_events_url":"https://api.github.com/users/Rastaban/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-10T07:00:53Z","updated_at":"2016-12-10T07:01:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/2860","html_url":"https://github.com/facebook/osquery/pull/2860","diff_url":"https://github.com/facebook/osquery/pull/2860.diff","patch_url":"https://github.com/facebook/osquery/pull/2860.patch"},"body":"We (the MSVC compiler team) use the OSQuery project as part of our\r\n\"Real world code\" tests.  I noticed a few places in your windows\r\nspecific code where your build would fail if you used the\r\n/permissive- switch because of language conformance issues.\r\nfor more information on /permissive- see our blogpost:\r\nhttps://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/\r\nI have not added/modified any tests because this does not change\r\nbehavior.\r\n\r\nThere are two types of language conformance issues fixed in this:\r\n\r\n1) Strict string conversion (this is also covered by the /Zc:strictStrings flag)\r\nThe 'const' is not implicitly dropped by string literals, which means the following is not allowed:\r\n\r\n    //BSTR is a wchar_t*\r\n    BSTR str = L\"const string literal\"; //error: cannot convert a 'const wchar_t*' to a 'wchar_t*'\r\n\r\nI preserved your current behavior by adding a cast to BSTR.  A better fix\r\nwould probably be to use SysAllocString (see the documentation for BSTR on MSDN).\r\nI did not make that change because of my limited testing capabilities.\r\n\r\n2)Fully qualified inline declarations members inside class\r\n\r\n    struct A {\r\n        void A::f() { } // Error: illegal qualified name in member declaration, remove redundant 'A::' to fix\r\n    };"},"comment":{"url":"https://api.github.com/repos/facebook/osquery/issues/comments/266183963","html_url":"https://github.com/facebook/osquery/pull/2860#issuecomment-266183963","issue_url":"https://api.github.com/repos/facebook/osquery/issues/2860","id":266183963,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-12-10T07:01:13Z","updated_at":"2016-12-10T07:01:13Z","body":"Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!\n\n**If you are contributing on behalf of someone else (eg your employer)**: the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions."}}
{"actor":{"display_login":"facebook-github-bot"}}