{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/71614465","id":71614465,"diff_hunk":"@@ -71,19 +74,61 @@ object ClusterShardingSettings {\n     if (role == \"\") None else Option(role)\n \n   class TuningParameters(\n-    val coordinatorFailureBackoff:                    FiniteDuration,\n-    val retryInterval:                                FiniteDuration,\n-    val bufferSize:                                   Int,\n-    val handOffTimeout:                               FiniteDuration,\n-    val shardStartTimeout:                            FiniteDuration,\n-    val shardFailureBackoff:                          FiniteDuration,\n-    val entityRestartBackoff:                         FiniteDuration,\n-    val rebalanceInterval:                            FiniteDuration,\n-    val snapshotAfter:                                Int,\n-    val leastShardAllocationRebalanceThreshold:       Int,\n-    val leastShardAllocationMaxSimultaneousRebalance: Int,\n-    val waitingForStateTimeout:                       FiniteDuration,\n-    val updatingStateTimeout:                         FiniteDuration)\n+    val coordinatorFailureBackoff:                          FiniteDuration,\n+    val retryInterval:                                      FiniteDuration,\n+    val bufferSize:                                         Int,\n+    val handOffTimeout:                                     FiniteDuration,\n+    val shardStartTimeout:                                  FiniteDuration,\n+    val shardFailureBackoff:                                FiniteDuration,\n+    val entityRestartBackoff:                               FiniteDuration,\n+    val rebalanceInterval:                                  FiniteDuration,\n+    val snapshotAfter:                                      Int,\n+    val leastShardAllocationRebalanceThreshold:             Int,\n+    val leastShardAllocationMaxSimultaneousRebalance:       Int,\n+    val waitingForStateTimeout:                             FiniteDuration,\n+    val updatingStateTimeout:                               FiniteDuration,\n+    val entityRecoveryStrategy:                             String,\n+    val entityRecoveryConstantRateStrategyFrequency:        FiniteDuration,\n+    val entityRecoveryConstantRateStrategyNumberOfEntities: Int) {\n+\n+    require(\n+      entityRecoveryStrategy == \"all\" || entityRecoveryStrategy == \"constant\",\n+      s\"Unknown 'entity-recovery-strategy' [$entityRecoveryStrategy], valid values are 'all' or 'constant'\")\n+\n+    def this(","path":"akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ClusterShardingSettings.scala","position":50,"original_position":50,"commit_id":"9b9ba46c440d76ff88d6107a81a37ffd578d241c","original_commit_id":"9b9ba46c440d76ff88d6107a81a37ffd578d241c","user":{"login":"pbarron","id":482389,"avatar_url":"https://avatars.githubusercontent.com/u/482389?v=3","gravatar_id":"","url":"https://api.github.com/users/pbarron","html_url":"https://github.com/pbarron","followers_url":"https://api.github.com/users/pbarron/followers","following_url":"https://api.github.com/users/pbarron/following{/other_user}","gists_url":"https://api.github.com/users/pbarron/gists{/gist_id}","starred_url":"https://api.github.com/users/pbarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbarron/subscriptions","organizations_url":"https://api.github.com/users/pbarron/orgs","repos_url":"https://api.github.com/users/pbarron/repos","events_url":"https://api.github.com/users/pbarron/events{/privacy}","received_events_url":"https://api.github.com/users/pbarron/received_events","type":"User","site_admin":false},"body":"done. ","created_at":"2016-07-20T21:58:05Z","updated_at":"2016-07-20T21:58:05Z","html_url":"https://github.com/akka/akka/pull/20745#discussion_r71614465","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/20745","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/71614465"},"html":{"href":"https://github.com/akka/akka/pull/20745#discussion_r71614465"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/20745"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/20745","id":72879279,"html_url":"https://github.com/akka/akka/pull/20745","diff_url":"https://github.com/akka/akka/pull/20745.diff","patch_url":"https://github.com/akka/akka/pull/20745.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/20745","number":20745,"state":"open","locked":false,"title":"WIP - #20744 - Cluster Sharding with remember-entity enabled fails to recover after restart.","user":{"login":"pbarron","id":482389,"avatar_url":"https://avatars.githubusercontent.com/u/482389?v=3","gravatar_id":"","url":"https://api.github.com/users/pbarron","html_url":"https://github.com/pbarron","followers_url":"https://api.github.com/users/pbarron/followers","following_url":"https://api.github.com/users/pbarron/following{/other_user}","gists_url":"https://api.github.com/users/pbarron/gists{/gist_id}","starred_url":"https://api.github.com/users/pbarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbarron/subscriptions","organizations_url":"https://api.github.com/users/pbarron/orgs","repos_url":"https://api.github.com/users/pbarron/repos","events_url":"https://api.github.com/users/pbarron/events{/privacy}","received_events_url":"https://api.github.com/users/pbarron/received_events","type":"User","site_admin":false},"body":"Initial approach for solving the herd effect when restarting or rebalance a cluster when remember-entity is enabled. The approach recovers the underlying actors at a certain defined rate rather than all a once. We've tested the approach and it considerably reduces the latency on the underlying storage medium (cassandra in this case). ","created_at":"2016-06-07T13:54:11Z","updated_at":"2016-07-20T21:58:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65fe6b50b3e09290ed09d2ce3d8d59ca9cdfa24a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/20745/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/20745/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/20745/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/9b9ba46c440d76ff88d6107a81a37ffd578d241c","head":{"label":"pbarron:master","ref":"master","sha":"9b9ba46c440d76ff88d6107a81a37ffd578d241c","user":{"login":"pbarron","id":482389,"avatar_url":"https://avatars.githubusercontent.com/u/482389?v=3","gravatar_id":"","url":"https://api.github.com/users/pbarron","html_url":"https://github.com/pbarron","followers_url":"https://api.github.com/users/pbarron/followers","following_url":"https://api.github.com/users/pbarron/following{/other_user}","gists_url":"https://api.github.com/users/pbarron/gists{/gist_id}","starred_url":"https://api.github.com/users/pbarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbarron/subscriptions","organizations_url":"https://api.github.com/users/pbarron/orgs","repos_url":"https://api.github.com/users/pbarron/repos","events_url":"https://api.github.com/users/pbarron/events{/privacy}","received_events_url":"https://api.github.com/users/pbarron/received_events","type":"User","site_admin":false},"repo":{"id":60269860,"name":"akka","full_name":"pbarron/akka","owner":{"login":"pbarron","id":482389,"avatar_url":"https://avatars.githubusercontent.com/u/482389?v=3","gravatar_id":"","url":"https://api.github.com/users/pbarron","html_url":"https://github.com/pbarron","followers_url":"https://api.github.com/users/pbarron/followers","following_url":"https://api.github.com/users/pbarron/following{/other_user}","gists_url":"https://api.github.com/users/pbarron/gists{/gist_id}","starred_url":"https://api.github.com/users/pbarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbarron/subscriptions","organizations_url":"https://api.github.com/users/pbarron/orgs","repos_url":"https://api.github.com/users/pbarron/repos","events_url":"https://api.github.com/users/pbarron/events{/privacy}","received_events_url":"https://api.github.com/users/pbarron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbarron/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/pbarron/akka","forks_url":"https://api.github.com/repos/pbarron/akka/forks","keys_url":"https://api.github.com/repos/pbarron/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbarron/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbarron/akka/teams","hooks_url":"https://api.github.com/repos/pbarron/akka/hooks","issue_events_url":"https://api.github.com/repos/pbarron/akka/issues/events{/number}","events_url":"https://api.github.com/repos/pbarron/akka/events","assignees_url":"https://api.github.com/repos/pbarron/akka/assignees{/user}","branches_url":"https://api.github.com/repos/pbarron/akka/branches{/branch}","tags_url":"https://api.github.com/repos/pbarron/akka/tags","blobs_url":"https://api.github.com/repos/pbarron/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbarron/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbarron/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbarron/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbarron/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/pbarron/akka/languages","stargazers_url":"https://api.github.com/repos/pbarron/akka/stargazers","contributors_url":"https://api.github.com/repos/pbarron/akka/contributors","subscribers_url":"https://api.github.com/repos/pbarron/akka/subscribers","subscription_url":"https://api.github.com/repos/pbarron/akka/subscription","commits_url":"https://api.github.com/repos/pbarron/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbarron/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbarron/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbarron/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbarron/akka/contents/{+path}","compare_url":"https://api.github.com/repos/pbarron/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbarron/akka/merges","archive_url":"https://api.github.com/repos/pbarron/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbarron/akka/downloads","issues_url":"https://api.github.com/repos/pbarron/akka/issues{/number}","pulls_url":"https://api.github.com/repos/pbarron/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/pbarron/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/pbarron/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbarron/akka/labels{/name}","releases_url":"https://api.github.com/repos/pbarron/akka/releases{/id}","deployments_url":"https://api.github.com/repos/pbarron/akka/deployments","created_at":"2016-06-02T14:15:18Z","updated_at":"2016-06-02T14:15:31Z","pushed_at":"2016-07-18T08:56:50Z","git_url":"git://github.com/pbarron/akka.git","ssh_url":"git@github.com:pbarron/akka.git","clone_url":"https://github.com/pbarron/akka.git","svn_url":"https://github.com/pbarron/akka","homepage":"http://akka.io","size":194565,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"b7567a5c5568d7752854c9d38f568aff712c2da1","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2016-07-20T21:44:25Z","pushed_at":"2016-07-20T16:24:45Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":236384,"stargazers_count":5787,"watchers_count":5787,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1823,"mirror_url":null,"open_issues_count":686,"forks":1823,"open_issues":686,"watchers":5787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/20745"},"html":{"href":"https://github.com/akka/akka/pull/20745"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/20745"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/20745/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/20745/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/20745/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/9b9ba46c440d76ff88d6107a81a37ffd578d241c"}}}}
{"actor":{"display_login":"pbarron"}}