{"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/13","id":73924880,"html_url":"https://github.com/bencripps/react-redux-grid/pull/13","diff_url":"https://github.com/bencripps/react-redux-grid/pull/13.diff","patch_url":"https://github.com/bencripps/react-redux-grid/pull/13.patch","issue_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/13","number":13,"state":"open","locked":false,"title":"feature/immutable-state","user":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"body":"This MR solidifies how the grid stores and and creates state through core and plugin reducers. Although the component has always used immutable.js, it was inconsistent from one reducer to the next. The changes in this MR ensure that state is always stored as an immutable object, which makes testing how state is stored and created much simpler. As such, this MR also includes full testing of all reducers.\r\n\r\nThe only breaking change will be if users of the component have been manually reading grid state from their store, because instead of retrieving plain javascript `objects`, they will now recieve `immutable objects`. \r\n\r\nThere is a simple fix for this scenario:\r\n\r\n```\r\n// previous to this MR\r\nconst gridState = store.getState()[GRID_REDUCER_KEY];\r\n\r\n// now\r\nconst gridState = store.getState()[GRID_REDUCER_KEY].toJS();\r\n```","created_at":"2016-06-15T14:45:55Z","updated_at":"2016-06-15T14:45:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"544dde2ed5e1899942fadf5b36905747b9773d7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/13/commits","review_comments_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/13/comments","review_comment_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/13/comments","statuses_url":"https://api.github.com/repos/bencripps/react-redux-grid/statuses/b26a51540d5cb8a118a878afee2978dce3990bf0","head":{"label":"bencripps:feature/immutable","ref":"feature/immutable","sha":"b26a51540d5cb8a118a878afee2978dce3990bf0","user":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"repo":{"id":49901310,"name":"react-redux-grid","full_name":"bencripps/react-redux-grid","owner":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bencripps/react-redux-grid","description":"A React Grid Component written in the Redux Pattern ","fork":false,"url":"https://api.github.com/repos/bencripps/react-redux-grid","forks_url":"https://api.github.com/repos/bencripps/react-redux-grid/forks","keys_url":"https://api.github.com/repos/bencripps/react-redux-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bencripps/react-redux-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bencripps/react-redux-grid/teams","hooks_url":"https://api.github.com/repos/bencripps/react-redux-grid/hooks","issue_events_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/events{/number}","events_url":"https://api.github.com/repos/bencripps/react-redux-grid/events","assignees_url":"https://api.github.com/repos/bencripps/react-redux-grid/assignees{/user}","branches_url":"https://api.github.com/repos/bencripps/react-redux-grid/branches{/branch}","tags_url":"https://api.github.com/repos/bencripps/react-redux-grid/tags","blobs_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bencripps/react-redux-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/bencripps/react-redux-grid/languages","stargazers_url":"https://api.github.com/repos/bencripps/react-redux-grid/stargazers","contributors_url":"https://api.github.com/repos/bencripps/react-redux-grid/contributors","subscribers_url":"https://api.github.com/repos/bencripps/react-redux-grid/subscribers","subscription_url":"https://api.github.com/repos/bencripps/react-redux-grid/subscription","commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/bencripps/react-redux-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/bencripps/react-redux-grid/contents/{+path}","compare_url":"https://api.github.com/repos/bencripps/react-redux-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bencripps/react-redux-grid/merges","archive_url":"https://api.github.com/repos/bencripps/react-redux-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bencripps/react-redux-grid/downloads","issues_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues{/number}","pulls_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/bencripps/react-redux-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/bencripps/react-redux-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bencripps/react-redux-grid/labels{/name}","releases_url":"https://api.github.com/repos/bencripps/react-redux-grid/releases{/id}","deployments_url":"https://api.github.com/repos/bencripps/react-redux-grid/deployments","created_at":"2016-01-18T19:54:56Z","updated_at":"2016-06-10T11:15:21Z","pushed_at":"2016-06-15T14:45:55Z","git_url":"git://github.com/bencripps/react-redux-grid.git","ssh_url":"git@github.com:bencripps/react-redux-grid.git","clone_url":"https://github.com/bencripps/react-redux-grid.git","svn_url":"https://github.com/bencripps/react-redux-grid","homepage":"","size":2462,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":16,"default_branch":"master"}},"base":{"label":"bencripps:master","ref":"master","sha":"d6bf02242db4086208da4a084fb85b885b545529","user":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"repo":{"id":49901310,"name":"react-redux-grid","full_name":"bencripps/react-redux-grid","owner":{"login":"bencripps","id":6272507,"avatar_url":"https://avatars.githubusercontent.com/u/6272507?v=3","gravatar_id":"","url":"https://api.github.com/users/bencripps","html_url":"https://github.com/bencripps","followers_url":"https://api.github.com/users/bencripps/followers","following_url":"https://api.github.com/users/bencripps/following{/other_user}","gists_url":"https://api.github.com/users/bencripps/gists{/gist_id}","starred_url":"https://api.github.com/users/bencripps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencripps/subscriptions","organizations_url":"https://api.github.com/users/bencripps/orgs","repos_url":"https://api.github.com/users/bencripps/repos","events_url":"https://api.github.com/users/bencripps/events{/privacy}","received_events_url":"https://api.github.com/users/bencripps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bencripps/react-redux-grid","description":"A React Grid Component written in the Redux Pattern ","fork":false,"url":"https://api.github.com/repos/bencripps/react-redux-grid","forks_url":"https://api.github.com/repos/bencripps/react-redux-grid/forks","keys_url":"https://api.github.com/repos/bencripps/react-redux-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bencripps/react-redux-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bencripps/react-redux-grid/teams","hooks_url":"https://api.github.com/repos/bencripps/react-redux-grid/hooks","issue_events_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/events{/number}","events_url":"https://api.github.com/repos/bencripps/react-redux-grid/events","assignees_url":"https://api.github.com/repos/bencripps/react-redux-grid/assignees{/user}","branches_url":"https://api.github.com/repos/bencripps/react-redux-grid/branches{/branch}","tags_url":"https://api.github.com/repos/bencripps/react-redux-grid/tags","blobs_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bencripps/react-redux-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/bencripps/react-redux-grid/languages","stargazers_url":"https://api.github.com/repos/bencripps/react-redux-grid/stargazers","contributors_url":"https://api.github.com/repos/bencripps/react-redux-grid/contributors","subscribers_url":"https://api.github.com/repos/bencripps/react-redux-grid/subscribers","subscription_url":"https://api.github.com/repos/bencripps/react-redux-grid/subscription","commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/bencripps/react-redux-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/bencripps/react-redux-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/bencripps/react-redux-grid/contents/{+path}","compare_url":"https://api.github.com/repos/bencripps/react-redux-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bencripps/react-redux-grid/merges","archive_url":"https://api.github.com/repos/bencripps/react-redux-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bencripps/react-redux-grid/downloads","issues_url":"https://api.github.com/repos/bencripps/react-redux-grid/issues{/number}","pulls_url":"https://api.github.com/repos/bencripps/react-redux-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/bencripps/react-redux-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/bencripps/react-redux-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bencripps/react-redux-grid/labels{/name}","releases_url":"https://api.github.com/repos/bencripps/react-redux-grid/releases{/id}","deployments_url":"https://api.github.com/repos/bencripps/react-redux-grid/deployments","created_at":"2016-01-18T19:54:56Z","updated_at":"2016-06-10T11:15:21Z","pushed_at":"2016-06-15T14:45:55Z","git_url":"git://github.com/bencripps/react-redux-grid.git","ssh_url":"git@github.com:bencripps/react-redux-grid.git","clone_url":"https://github.com/bencripps/react-redux-grid.git","svn_url":"https://github.com/bencripps/react-redux-grid","homepage":"","size":2462,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/13"},"html":{"href":"https://github.com/bencripps/react-redux-grid/pull/13"},"issue":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/issues/13"},"comments":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/bencripps/react-redux-grid/statuses/b26a51540d5cb8a118a878afee2978dce3990bf0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":1950,"deletions":187,"changed_files":26}}
{"actor":{"display_login":"bencripps"}}