{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/11739","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/11739/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/11739/comments","events_url":"https://api.github.com/repos/servo/servo/issues/11739/events","html_url":"https://github.com/servo/servo/pull/11739","id":159976953,"number":11739,"title":"constellation: Don't ignore inconsistent frame-tree states when determining when to take a screenshot.","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-answer","name":"S-awaiting-answer","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-tests-failed","name":"S-tests-failed","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"assignees":[{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":52,"created_at":"2016-06-13T15:23:22Z","updated_at":"2016-06-24T22:11:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/11739","html_url":"https://github.com/servo/servo/pull/11739","diff_url":"https://github.com/servo/servo/pull/11739.diff","patch_url":"https://github.com/servo/servo/pull/11739.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\nReturn a significative error instead.\r\n\r\nI think this is the cause of most iframe-related intermittents: we stop\r\niterating early, so we don't detect frames that aren't closed now.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/11739)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/228474773","html_url":"https://github.com/servo/servo/pull/11739#issuecomment-228474773","issue_url":"https://api.github.com/repos/servo/servo/issues/11739","id":228474773,"user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T22:11:03Z","updated_at":"2016-06-24T22:11:03Z","body":"Yes, so the point is to try tackling the intermittents where we have iframes that render nothing, presumably because we take the screenshot too early.\n\nAnd yes, *almost* everything is getting refiltered as before, except...\n\n---\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[components/constellation/constellation.rs, line 1864 \\[r4\\]](https://reviewable.io:443/reviews/servo/servo/11739#-KL3SbxZACBzqGpduudF:-KL3SbxZACBzqGpduudG:1212008436) ([raw file](https://github.com/servo/servo/blob/09866e39ad7dc242df794606b279ce41581dd834/components/constellation/constellation.rs#L1864)):*\n> ```Rust\n>                 FrameTreeIteratorItem::PipelineNotFound(frame_id, frame) => {\n>                     warn!(\"Pipeline {:?} for frame {:?} not found\", frame.current, frame_id);\n>                     return ReadyToSave::InconsistentFrameTreeState;\n> ```\n\nThese lines, where instead of skipping the frames and assuming everything is ok, we return a state that isn't `ReadyToSave::Ready`, so we don't take the screenshot yet.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/11739#-:-KL3SEw4diz46KYej55m:691530997)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"emilio"}}