{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/66895339","id":66895339,"diff_hunk":"@@ -201,8 +201,9 @@\n  *\n  * <p>See {@link BigQueryIO.Write} for details on how to specify if a write should\n  * append to an existing table, replace the table, or verify that the table is\n- * empty. Note that the dataset being written to must already exist. Write\n- * dispositions are not supported in streaming mode.\n+ * empty. Note that the dataset being written to must already exist. In streaming mode, the Write\n+ * disposition must be {@link WriteDisposition#WRITE_EMPTY empty} or","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/io/BigQueryIO.java","position":7,"original_position":7,"commit_id":"0a3ba4eccc45f8db89cb1973fe74f0f93da68a3e","original_commit_id":"0a3ba4eccc45f8db89cb1973fe74f0f93da68a3e","user":{"login":"bjchambers","id":35960,"avatar_url":"https://avatars.githubusercontent.com/u/35960?v=3","gravatar_id":"","url":"https://api.github.com/users/bjchambers","html_url":"https://github.com/bjchambers","followers_url":"https://api.github.com/users/bjchambers/followers","following_url":"https://api.github.com/users/bjchambers/following{/other_user}","gists_url":"https://api.github.com/users/bjchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/bjchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjchambers/subscriptions","organizations_url":"https://api.github.com/users/bjchambers/orgs","repos_url":"https://api.github.com/users/bjchambers/repos","events_url":"https://api.github.com/users/bjchambers/events{/privacy}","received_events_url":"https://api.github.com/users/bjchambers/received_events","type":"User","site_admin":false},"body":"I question whether WRITE_EMPTY ever makes sense when using the the streaming write API. Specifically, unless we're making sure we never attempt to write to a non-empty table, it will get a lot of errors. And it seems like the presence of late data, or additional data arriving, could lead to this problem happening.\r\n\r\n@dhalperi @dpmills Any thoughts?","created_at":"2016-06-14T01:10:17Z","updated_at":"2016-06-14T01:10:17Z","html_url":"https://github.com/apache/incubator-beam/pull/451#discussion_r66895339","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/451","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/66895339"},"html":{"href":"https://github.com/apache/incubator-beam/pull/451#discussion_r66895339"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/451"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/451","id":73618122,"html_url":"https://github.com/apache/incubator-beam/pull/451","diff_url":"https://github.com/apache/incubator-beam/pull/451.diff","patch_url":"https://github.com/apache/incubator-beam/pull/451.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/451","number":451,"state":"open","locked":false,"title":"Improve BigQueryIO validation for streaming WriteDisposition","user":{"login":"swegner","id":674021,"avatar_url":"https://avatars.githubusercontent.com/u/674021?v=3","gravatar_id":"","url":"https://api.github.com/users/swegner","html_url":"https://github.com/swegner","followers_url":"https://api.github.com/users/swegner/followers","following_url":"https://api.github.com/users/swegner/following{/other_user}","gists_url":"https://api.github.com/users/swegner/gists{/gist_id}","starred_url":"https://api.github.com/users/swegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swegner/subscriptions","organizations_url":"https://api.github.com/users/swegner/orgs","repos_url":"https://api.github.com/users/swegner/repos","events_url":"https://api.github.com/users/swegner/events{/privacy}","received_events_url":"https://api.github.com/users/swegner/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [ ] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\n","created_at":"2016-06-13T18:06:40Z","updated_at":"2016-06-14T01:10:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"595131868a3d84c97c3c92b5a9329221e631b718","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/451/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/451/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/451/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/0a3ba4eccc45f8db89cb1973fe74f0f93da68a3e","head":{"label":"swegner:bigqueryio-streaming","ref":"bigqueryio-streaming","sha":"0a3ba4eccc45f8db89cb1973fe74f0f93da68a3e","user":{"login":"swegner","id":674021,"avatar_url":"https://avatars.githubusercontent.com/u/674021?v=3","gravatar_id":"","url":"https://api.github.com/users/swegner","html_url":"https://github.com/swegner","followers_url":"https://api.github.com/users/swegner/followers","following_url":"https://api.github.com/users/swegner/following{/other_user}","gists_url":"https://api.github.com/users/swegner/gists{/gist_id}","starred_url":"https://api.github.com/users/swegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swegner/subscriptions","organizations_url":"https://api.github.com/users/swegner/orgs","repos_url":"https://api.github.com/users/swegner/repos","events_url":"https://api.github.com/users/swegner/events{/privacy}","received_events_url":"https://api.github.com/users/swegner/received_events","type":"User","site_admin":false},"repo":{"id":52832170,"name":"incubator-beam","full_name":"swegner/incubator-beam","owner":{"login":"swegner","id":674021,"avatar_url":"https://avatars.githubusercontent.com/u/674021?v=3","gravatar_id":"","url":"https://api.github.com/users/swegner","html_url":"https://github.com/swegner","followers_url":"https://api.github.com/users/swegner/followers","following_url":"https://api.github.com/users/swegner/following{/other_user}","gists_url":"https://api.github.com/users/swegner/gists{/gist_id}","starred_url":"https://api.github.com/users/swegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swegner/subscriptions","organizations_url":"https://api.github.com/users/swegner/orgs","repos_url":"https://api.github.com/users/swegner/repos","events_url":"https://api.github.com/users/swegner/events{/privacy}","received_events_url":"https://api.github.com/users/swegner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swegner/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/swegner/incubator-beam","forks_url":"https://api.github.com/repos/swegner/incubator-beam/forks","keys_url":"https://api.github.com/repos/swegner/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swegner/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swegner/incubator-beam/teams","hooks_url":"https://api.github.com/repos/swegner/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/swegner/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/swegner/incubator-beam/events","assignees_url":"https://api.github.com/repos/swegner/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/swegner/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/swegner/incubator-beam/tags","blobs_url":"https://api.github.com/repos/swegner/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swegner/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swegner/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/swegner/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swegner/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/swegner/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/swegner/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/swegner/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/swegner/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/swegner/incubator-beam/subscription","commits_url":"https://api.github.com/repos/swegner/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/swegner/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/swegner/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/swegner/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/swegner/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/swegner/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swegner/incubator-beam/merges","archive_url":"https://api.github.com/repos/swegner/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swegner/incubator-beam/downloads","issues_url":"https://api.github.com/repos/swegner/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/swegner/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/swegner/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/swegner/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swegner/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/swegner/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/swegner/incubator-beam/deployments","created_at":"2016-02-29T23:20:08Z","updated_at":"2016-02-29T23:20:11Z","pushed_at":"2016-06-13T21:26:34Z","git_url":"git://github.com/swegner/incubator-beam.git","ssh_url":"git@github.com:swegner/incubator-beam.git","clone_url":"https://github.com/swegner/incubator-beam.git","svn_url":"https://github.com/swegner/incubator-beam","homepage":null,"size":14815,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"dbddb9f3cda5b8052e5a0e5117a1d57508b229f9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-06-13T17:51:47Z","pushed_at":"2016-06-14T00:41:48Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":17748,"stargazers_count":219,"watchers_count":219,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":31,"forks":114,"open_issues":31,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/451"},"html":{"href":"https://github.com/apache/incubator-beam/pull/451"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/451"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/0a3ba4eccc45f8db89cb1973fe74f0f93da68a3e"}}}}
{"actor":{"display_login":"bjchambers"}}