{"action":"created","issue":{"url":"https://api.github.com/repos/ESMCI/cime/issues/668","repository_url":"https://api.github.com/repos/ESMCI/cime","labels_url":"https://api.github.com/repos/ESMCI/cime/issues/668/labels{/name}","comments_url":"https://api.github.com/repos/ESMCI/cime/issues/668/comments","events_url":"https://api.github.com/repos/ESMCI/cime/issues/668/events","html_url":"https://github.com/ESMCI/cime/pull/668","id":182619288,"number":668,"title":"Remove support for user setting CIMEROOT.","user":{"login":"jgfouca","id":7292036,"avatar_url":"https://avatars.githubusercontent.com/u/7292036?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ESMCI/cime/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"assignees":[{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},{"login":"billsacks","id":6266741,"avatar_url":"https://avatars.githubusercontent.com/u/6266741?v=3","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-12T19:59:30Z","updated_at":"2016-10-12T20:24:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/668","html_url":"https://github.com/ESMCI/cime/pull/668","diff_url":"https://github.com/ESMCI/cime/pull/668.diff","patch_url":"https://github.com/ESMCI/cime/pull/668.patch"},"body":"CIMEROOT will always be the home repo of where the tool lives.\r\n\r\nAlso, as I was scanning for usages of CIMEROOT, I found several files\r\nthat I strongly suspected are obsolete and I removed them.\r\n\r\nTest suite: scripts_regression_tests (both on batch system and desktop)\r\nTest baseline: \r\nTest namelist changes: \r\nTest status: bit for bit\r\n\r\nFixes #657\r\n\r\nUser interface changes?: CIMEROOT is no longer exposed to user\r\n\r\nCode review: jedwards billsacks\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ESMCI/cime/issues/comments/253328297","html_url":"https://github.com/ESMCI/cime/pull/668#issuecomment-253328297","issue_url":"https://api.github.com/repos/ESMCI/cime/issues/668","id":253328297,"user":{"login":"billsacks","id":6266741,"avatar_url":"https://avatars.githubusercontent.com/u/6266741?v=3","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T20:24:01Z","updated_at":"2016-10-12T20:24:01Z","body":"I don't feel a need to review this if Jim E is good with it. My one question is whether anything in any of the CESM (or ACME) components will need to be modified with this change. @jedwards4b , do you know? For example, I see various references to the CIMEROOT environment variable in CLM (components/clm), which @ekluzek should be aware of if he isn't already:\r\n\r\nAccessing CIMEROOT:\r\n\r\n```\r\n./cime_config/buildlib:8:_CIMEROOT = os.environ.get(\"CIMEROOT\")\r\n./cime_config/buildlib:9:if _CIMEROOT is None:\r\n./cime_config/buildlib:10:    raise SystemExit(\"ERROR: must set CIMEROOT environment variable\")\r\n```\r\n\r\n(There are other references via xmlquery, but I'm thinking that's still safe?)\r\n\r\nAs well as setting the CIMEROOT environment variable:\r\n\r\n```\r\n./test/tools/TCBCFGtools.sh:79:env       CIMEROOT=$CLM_ROOT/cime COMPILER=$CESM_COMP $config_string $CLM_ROOT/cime/tools/configure --macros-format Makefile --machine $CESM_MACH $TOOLS_CONF_STRING >> test.log 2>&1\r\n./test/tools/TCBtools.sh:88:         env CIMEROOT=${CLM_ROOT}/cime ${CLM_ROOT}/cime/tools/configure -mach bluefire >> test.log 2>&1\r\n```\r\n\r\n```\r\n./tools/shared/PTCLM/buildtools:107:      export CIMEROOT=$CESM_ROOT/cime\r\n```\r\n\r\nand various places in the tools documentation, in tools/README and tools/shared/gen_domain/INSTALL"}}
{"actor":{"display_login":"billsacks"}}