{"action":"created","issue":{"url":"https://api.github.com/repos/UV-CDAT/vcs-js/issues/2","repository_url":"https://api.github.com/repos/UV-CDAT/vcs-js","labels_url":"https://api.github.com/repos/UV-CDAT/vcs-js/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/UV-CDAT/vcs-js/issues/2/comments","events_url":"https://api.github.com/repos/UV-CDAT/vcs-js/issues/2/events","html_url":"https://github.com/UV-CDAT/vcs-js/pull/2","id":182914289,"number":2,"title":"API refactoring","user":{"login":"chaosphere2112","id":718512,"avatar_url":"https://avatars.githubusercontent.com/u/718512?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosphere2112","html_url":"https://github.com/chaosphere2112","followers_url":"https://api.github.com/users/chaosphere2112/followers","following_url":"https://api.github.com/users/chaosphere2112/following{/other_user}","gists_url":"https://api.github.com/users/chaosphere2112/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosphere2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosphere2112/subscriptions","organizations_url":"https://api.github.com/users/chaosphere2112/orgs","repos_url":"https://api.github.com/users/chaosphere2112/repos","events_url":"https://api.github.com/users/chaosphere2112/events{/privacy}","received_events_url":"https://api.github.com/users/chaosphere2112/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-13T21:58:19Z","updated_at":"2016-10-14T13:42:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/UV-CDAT/vcs-js/pulls/2","html_url":"https://github.com/UV-CDAT/vcs-js/pull/2","diff_url":"https://github.com/UV-CDAT/vcs-js/pull/2.diff","patch_url":"https://github.com/UV-CDAT/vcs-js/pull/2.patch"},"body":"This pull request removes some stuff, and updates the API to behave in the way we had discussed (JSON representations of graphics methods and CDMS provenance variables). To test it, you need to use [the `cdms_just_provenance` branch of CDMS](https://github.com/UV-CDAT/cdms/tree/cdms_just_provenance) in your conda environment.\r\n\r\nNotes on the dependency removals:\r\n\r\n- bluebird:\r\n  - All browsers that will can be run on computers that support VCS (i.e. not IE) support Promises natively, so I moved bluebird to a dev dependency.\r\n- plotly:\r\n  - The built version of vcs.js was 6.5 MB. I removed the Plotly code and now it's down to just under 2 MB. VCDAT is going to have a pretty large footprint on its own; I don't want to be waiting on vcs.js to arrive as well. Also, the plotly plot wasn't actually doing anything strictly relevant yet, so if we come up with a decent solution for the massive bloat, we can work on integrating that back in once we have a solution for client-side data.\r\n\r\nI couldn't get one of the tests to pass (vtkweb's dispatch test); I'm not very familiar with the JS testing environment, so I was having a lot of trouble figuring out how to debug that (since it was reporting the failure on a line that didn't have any code).\r\n"},"comment":{"url":"https://api.github.com/repos/UV-CDAT/vcs-js/issues/comments/253802244","html_url":"https://github.com/UV-CDAT/vcs-js/pull/2#issuecomment-253802244","issue_url":"https://api.github.com/repos/UV-CDAT/vcs-js/issues/2","id":253802244,"user":{"login":"danlipsa","id":6180727,"avatar_url":"https://avatars.githubusercontent.com/u/6180727?v=3","gravatar_id":"","url":"https://api.github.com/users/danlipsa","html_url":"https://github.com/danlipsa","followers_url":"https://api.github.com/users/danlipsa/followers","following_url":"https://api.github.com/users/danlipsa/following{/other_user}","gists_url":"https://api.github.com/users/danlipsa/gists{/gist_id}","starred_url":"https://api.github.com/users/danlipsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlipsa/subscriptions","organizations_url":"https://api.github.com/users/danlipsa/orgs","repos_url":"https://api.github.com/users/danlipsa/repos","events_url":"https://api.github.com/users/danlipsa/events{/privacy}","received_events_url":"https://api.github.com/users/danlipsa/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T13:42:57Z","updated_at":"2016-10-14T13:42:57Z","body":"@chaosphere2112 @aashish24 @jbeezley Looks cool! with one reservation regarding removing plotly. I was kind of excited to make the plotly plot work properly with data transferred from the server - to have a semi-complete client rendering solution as well. So I would leave that in for now. Is the bloat causing any problems? Do we have a alternate client plotting library that works better?\r\n\r\nWhen is the cdms branch going to be merged in?"}}
{"actor":{"display_login":"danlipsa"}}