{"action":"created","issue":{"url":"https://api.github.com/repos/meh2481/MSFHDEx/issues/3","repository_url":"https://api.github.com/repos/meh2481/MSFHDEx","labels_url":"https://api.github.com/repos/meh2481/MSFHDEx/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/meh2481/MSFHDEx/issues/3/comments","events_url":"https://api.github.com/repos/meh2481/MSFHDEx/issues/3/events","html_url":"https://github.com/meh2481/MSFHDEx/pull/3","id":180553752,"number":3,"title":"Fixes an underflow when loading rcImgs","user":{"login":"hufman","id":1592375,"avatar_url":"https://avatars.githubusercontent.com/u/1592375?v=3","gravatar_id":"","url":"https://api.github.com/users/hufman","html_url":"https://github.com/hufman","followers_url":"https://api.github.com/users/hufman/followers","following_url":"https://api.github.com/users/hufman/following{/other_user}","gists_url":"https://api.github.com/users/hufman/gists{/gist_id}","starred_url":"https://api.github.com/users/hufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hufman/subscriptions","organizations_url":"https://api.github.com/users/hufman/orgs","repos_url":"https://api.github.com/users/hufman/repos","events_url":"https://api.github.com/users/hufman/events{/privacy}","received_events_url":"https://api.github.com/users/hufman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-03T02:43:06Z","updated_at":"2016-10-03T02:48:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/meh2481/MSFHDEx/pulls/3","html_url":"https://github.com/meh2481/MSFHDEx/pull/3","diff_url":"https://github.com/meh2481/MSFHDEx/pull/3.diff","patch_url":"https://github.com/meh2481/MSFHDEx/pull/3.patch"},"body":"Some anim files, like Mermaid and Door, have the case where frameItem.numRects==0\r\nThis change checks for this case and doesn't try to iterate through them\r\n\r\nrcImgs.size() is unsigned, so the for loop that checks for rcImgs.size()-1 would underflow and try to iterate to MAX_INT\r\n\r\nAn alternative solution is to change the for loop to iterate from j=1;rcImgs.size();j++, and update the appropriate variables, but that might not be as clear of intent."},"comment":{"url":"https://api.github.com/repos/meh2481/MSFHDEx/issues/comments/251016553","html_url":"https://github.com/meh2481/MSFHDEx/pull/3#issuecomment-251016553","issue_url":"https://api.github.com/repos/meh2481/MSFHDEx/issues/3","id":251016553,"user":{"login":"hufman","id":1592375,"avatar_url":"https://avatars.githubusercontent.com/u/1592375?v=3","gravatar_id":"","url":"https://api.github.com/users/hufman","html_url":"https://github.com/hufman","followers_url":"https://api.github.com/users/hufman/followers","following_url":"https://api.github.com/users/hufman/following{/other_user}","gists_url":"https://api.github.com/users/hufman/gists{/gist_id}","starred_url":"https://api.github.com/users/hufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hufman/subscriptions","organizations_url":"https://api.github.com/users/hufman/orgs","repos_url":"https://api.github.com/users/hufman/repos","events_url":"https://api.github.com/users/hufman/events{/privacy}","received_events_url":"https://api.github.com/users/hufman/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T02:48:49Z","updated_at":"2016-10-03T02:48:49Z","body":"The alternative approach is [here](https://github.com/hufman/MSFHDEx/commit/dd267b13f1e889b4ea4668e48e862af8a54251c5), let me know if you would prefer to use that in a PR!\r\nThanks! :)"}}
{"actor":{"display_login":"hufman"}}