{"action":"opened","number":233,"pull_request":{"url":"https://api.github.com/repos/lanoxx/tilda/pulls/233","id":66794846,"html_url":"https://github.com/lanoxx/tilda/pull/233","diff_url":"https://github.com/lanoxx/tilda/pull/233.diff","patch_url":"https://github.com/lanoxx/tilda/pull/233.patch","issue_url":"https://api.github.com/repos/lanoxx/tilda/issues/233","number":233,"state":"open","locked":false,"title":"Bugfix for close-tab related issues (double-close / dialog close not working)","user":{"login":"pik","id":10236920,"avatar_url":"https://avatars.githubusercontent.com/u/10236920?v=3","gravatar_id":"","url":"https://api.github.com/users/pik","html_url":"https://github.com/pik","followers_url":"https://api.github.com/users/pik/followers","following_url":"https://api.github.com/users/pik/following{/other_user}","gists_url":"https://api.github.com/users/pik/gists{/gist_id}","starred_url":"https://api.github.com/users/pik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pik/subscriptions","organizations_url":"https://api.github.com/users/pik/orgs","repos_url":"https://api.github.com/users/pik/repos","events_url":"https://api.github.com/users/pik/events{/privacy}","received_events_url":"https://api.github.com/users/pik/received_events","type":"User","site_admin":false},"body":"Seems like we missed a `GDK_EVENT_STOP` since these accelerators technically get added twice ? https://github.com/lanoxx/tilda/blob/master/src%2Ftilda_terminal.c#L992 \r\n\r\nTo replicate the original issue open/close the preferences dialog, then the <close-tab key-press> will close two tabs at once and the <close-tab> on the menu will no longer work. \r\n\r\n#218 #229 #232 \r\n","created_at":"2016-04-18T03:31:32Z","updated_at":"2016-04-18T03:31:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lanoxx/tilda/pulls/233/commits","review_comments_url":"https://api.github.com/repos/lanoxx/tilda/pulls/233/comments","review_comment_url":"https://api.github.com/repos/lanoxx/tilda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lanoxx/tilda/issues/233/comments","statuses_url":"https://api.github.com/repos/lanoxx/tilda/statuses/9aaef101679025bb4d8bb0ae43abf9f2a0cd108f","head":{"label":"pik:master","ref":"master","sha":"9aaef101679025bb4d8bb0ae43abf9f2a0cd108f","user":{"login":"pik","id":10236920,"avatar_url":"https://avatars.githubusercontent.com/u/10236920?v=3","gravatar_id":"","url":"https://api.github.com/users/pik","html_url":"https://github.com/pik","followers_url":"https://api.github.com/users/pik/followers","following_url":"https://api.github.com/users/pik/following{/other_user}","gists_url":"https://api.github.com/users/pik/gists{/gist_id}","starred_url":"https://api.github.com/users/pik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pik/subscriptions","organizations_url":"https://api.github.com/users/pik/orgs","repos_url":"https://api.github.com/users/pik/repos","events_url":"https://api.github.com/users/pik/events{/privacy}","received_events_url":"https://api.github.com/users/pik/received_events","type":"User","site_admin":false},"repo":{"id":28542951,"name":"tilda","full_name":"pik/tilda","owner":{"login":"pik","id":10236920,"avatar_url":"https://avatars.githubusercontent.com/u/10236920?v=3","gravatar_id":"","url":"https://api.github.com/users/pik","html_url":"https://github.com/pik","followers_url":"https://api.github.com/users/pik/followers","following_url":"https://api.github.com/users/pik/following{/other_user}","gists_url":"https://api.github.com/users/pik/gists{/gist_id}","starred_url":"https://api.github.com/users/pik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pik/subscriptions","organizations_url":"https://api.github.com/users/pik/orgs","repos_url":"https://api.github.com/users/pik/repos","events_url":"https://api.github.com/users/pik/events{/privacy}","received_events_url":"https://api.github.com/users/pik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pik/tilda","description":"A Gtk based drop down terminal for Linux and Unix","fork":true,"url":"https://api.github.com/repos/pik/tilda","forks_url":"https://api.github.com/repos/pik/tilda/forks","keys_url":"https://api.github.com/repos/pik/tilda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pik/tilda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pik/tilda/teams","hooks_url":"https://api.github.com/repos/pik/tilda/hooks","issue_events_url":"https://api.github.com/repos/pik/tilda/issues/events{/number}","events_url":"https://api.github.com/repos/pik/tilda/events","assignees_url":"https://api.github.com/repos/pik/tilda/assignees{/user}","branches_url":"https://api.github.com/repos/pik/tilda/branches{/branch}","tags_url":"https://api.github.com/repos/pik/tilda/tags","blobs_url":"https://api.github.com/repos/pik/tilda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pik/tilda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pik/tilda/git/refs{/sha}","trees_url":"https://api.github.com/repos/pik/tilda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pik/tilda/statuses/{sha}","languages_url":"https://api.github.com/repos/pik/tilda/languages","stargazers_url":"https://api.github.com/repos/pik/tilda/stargazers","contributors_url":"https://api.github.com/repos/pik/tilda/contributors","subscribers_url":"https://api.github.com/repos/pik/tilda/subscribers","subscription_url":"https://api.github.com/repos/pik/tilda/subscription","commits_url":"https://api.github.com/repos/pik/tilda/commits{/sha}","git_commits_url":"https://api.github.com/repos/pik/tilda/git/commits{/sha}","comments_url":"https://api.github.com/repos/pik/tilda/comments{/number}","issue_comment_url":"https://api.github.com/repos/pik/tilda/issues/comments{/number}","contents_url":"https://api.github.com/repos/pik/tilda/contents/{+path}","compare_url":"https://api.github.com/repos/pik/tilda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pik/tilda/merges","archive_url":"https://api.github.com/repos/pik/tilda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pik/tilda/downloads","issues_url":"https://api.github.com/repos/pik/tilda/issues{/number}","pulls_url":"https://api.github.com/repos/pik/tilda/pulls{/number}","milestones_url":"https://api.github.com/repos/pik/tilda/milestones{/number}","notifications_url":"https://api.github.com/repos/pik/tilda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pik/tilda/labels{/name}","releases_url":"https://api.github.com/repos/pik/tilda/releases{/id}","deployments_url":"https://api.github.com/repos/pik/tilda/deployments","created_at":"2014-12-27T18:05:43Z","updated_at":"2016-04-18T03:27:10Z","pushed_at":"2016-04-18T03:27:05Z","git_url":"git://github.com/pik/tilda.git","ssh_url":"git@github.com:pik/tilda.git","clone_url":"https://github.com/pik/tilda.git","svn_url":"https://github.com/pik/tilda","homepage":"","size":3473,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lanoxx:master","ref":"master","sha":"e804f73ec8c6269e04635d63b0a1aaecda97da82","user":{"login":"lanoxx","id":691311,"avatar_url":"https://avatars.githubusercontent.com/u/691311?v=3","gravatar_id":"","url":"https://api.github.com/users/lanoxx","html_url":"https://github.com/lanoxx","followers_url":"https://api.github.com/users/lanoxx/followers","following_url":"https://api.github.com/users/lanoxx/following{/other_user}","gists_url":"https://api.github.com/users/lanoxx/gists{/gist_id}","starred_url":"https://api.github.com/users/lanoxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanoxx/subscriptions","organizations_url":"https://api.github.com/users/lanoxx/orgs","repos_url":"https://api.github.com/users/lanoxx/repos","events_url":"https://api.github.com/users/lanoxx/events{/privacy}","received_events_url":"https://api.github.com/users/lanoxx/received_events","type":"User","site_admin":false},"repo":{"id":3778418,"name":"tilda","full_name":"lanoxx/tilda","owner":{"login":"lanoxx","id":691311,"avatar_url":"https://avatars.githubusercontent.com/u/691311?v=3","gravatar_id":"","url":"https://api.github.com/users/lanoxx","html_url":"https://github.com/lanoxx","followers_url":"https://api.github.com/users/lanoxx/followers","following_url":"https://api.github.com/users/lanoxx/following{/other_user}","gists_url":"https://api.github.com/users/lanoxx/gists{/gist_id}","starred_url":"https://api.github.com/users/lanoxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanoxx/subscriptions","organizations_url":"https://api.github.com/users/lanoxx/orgs","repos_url":"https://api.github.com/users/lanoxx/repos","events_url":"https://api.github.com/users/lanoxx/events{/privacy}","received_events_url":"https://api.github.com/users/lanoxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lanoxx/tilda","description":"A Gtk based drop down terminal for Linux and Unix","fork":false,"url":"https://api.github.com/repos/lanoxx/tilda","forks_url":"https://api.github.com/repos/lanoxx/tilda/forks","keys_url":"https://api.github.com/repos/lanoxx/tilda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lanoxx/tilda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lanoxx/tilda/teams","hooks_url":"https://api.github.com/repos/lanoxx/tilda/hooks","issue_events_url":"https://api.github.com/repos/lanoxx/tilda/issues/events{/number}","events_url":"https://api.github.com/repos/lanoxx/tilda/events","assignees_url":"https://api.github.com/repos/lanoxx/tilda/assignees{/user}","branches_url":"https://api.github.com/repos/lanoxx/tilda/branches{/branch}","tags_url":"https://api.github.com/repos/lanoxx/tilda/tags","blobs_url":"https://api.github.com/repos/lanoxx/tilda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lanoxx/tilda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lanoxx/tilda/git/refs{/sha}","trees_url":"https://api.github.com/repos/lanoxx/tilda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lanoxx/tilda/statuses/{sha}","languages_url":"https://api.github.com/repos/lanoxx/tilda/languages","stargazers_url":"https://api.github.com/repos/lanoxx/tilda/stargazers","contributors_url":"https://api.github.com/repos/lanoxx/tilda/contributors","subscribers_url":"https://api.github.com/repos/lanoxx/tilda/subscribers","subscription_url":"https://api.github.com/repos/lanoxx/tilda/subscription","commits_url":"https://api.github.com/repos/lanoxx/tilda/commits{/sha}","git_commits_url":"https://api.github.com/repos/lanoxx/tilda/git/commits{/sha}","comments_url":"https://api.github.com/repos/lanoxx/tilda/comments{/number}","issue_comment_url":"https://api.github.com/repos/lanoxx/tilda/issues/comments{/number}","contents_url":"https://api.github.com/repos/lanoxx/tilda/contents/{+path}","compare_url":"https://api.github.com/repos/lanoxx/tilda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lanoxx/tilda/merges","archive_url":"https://api.github.com/repos/lanoxx/tilda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lanoxx/tilda/downloads","issues_url":"https://api.github.com/repos/lanoxx/tilda/issues{/number}","pulls_url":"https://api.github.com/repos/lanoxx/tilda/pulls{/number}","milestones_url":"https://api.github.com/repos/lanoxx/tilda/milestones{/number}","notifications_url":"https://api.github.com/repos/lanoxx/tilda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lanoxx/tilda/labels{/name}","releases_url":"https://api.github.com/repos/lanoxx/tilda/releases{/id}","deployments_url":"https://api.github.com/repos/lanoxx/tilda/deployments","created_at":"2012-03-20T18:18:03Z","updated_at":"2016-04-15T21:10:11Z","pushed_at":"2016-04-16T08:08:59Z","git_url":"git://github.com/lanoxx/tilda.git","ssh_url":"git@github.com:lanoxx/tilda.git","clone_url":"https://github.com/lanoxx/tilda.git","svn_url":"https://github.com/lanoxx/tilda","homepage":"","size":3637,"stargazers_count":255,"watchers_count":255,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":51,"forks":75,"open_issues":51,"watchers":255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lanoxx/tilda/pulls/233"},"html":{"href":"https://github.com/lanoxx/tilda/pull/233"},"issue":{"href":"https://api.github.com/repos/lanoxx/tilda/issues/233"},"comments":{"href":"https://api.github.com/repos/lanoxx/tilda/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/lanoxx/tilda/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/lanoxx/tilda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lanoxx/tilda/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/lanoxx/tilda/statuses/9aaef101679025bb4d8bb0ae43abf9f2a0cd108f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":5,"deletions":10,"changed_files":2}}