{"action":"created","comment":{"url":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/comments/52883524","id":52883524,"diff_hunk":"@@ -81,6 +81,23 @@ throws_ok {\n }\n qr/socket protocol must be tcp or udp/, 'invalid protocol';\n \n+throws_ok {\n+    Log::Dispatch->new(\n+        outputs => [\n+            [\n+                'Gelf',\n+                min_level => 'debug',\n+                'socket'  => {\n+                    host     => 'test',\n+                    port     => '111111',\n+                    protocol => 'xxx-udp',","path":"t/02_socket.t","position":13,"original_position":13,"commit_id":"73a8993b08436cde181c68e439d8e4c20a012223","original_commit_id":"73a8993b08436cde181c68e439d8e4c20a012223","user":{"login":"JaSei","id":3896847,"avatar_url":"https://avatars.githubusercontent.com/u/3896847?v=3","gravatar_id":"","url":"https://api.github.com/users/JaSei","html_url":"https://github.com/JaSei","followers_url":"https://api.github.com/users/JaSei/followers","following_url":"https://api.github.com/users/JaSei/following{/other_user}","gists_url":"https://api.github.com/users/JaSei/gists{/gist_id}","starred_url":"https://api.github.com/users/JaSei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaSei/subscriptions","organizations_url":"https://api.github.com/users/JaSei/orgs","repos_url":"https://api.github.com/users/JaSei/repos","events_url":"https://api.github.com/users/JaSei/events{/privacy}","received_events_url":"https://api.github.com/users/JaSei/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2016-02-15T10:45:34Z","updated_at":"2016-02-15T10:45:34Z","html_url":"https://github.com/avast/log-dispatch-gelf/pull/5#discussion_r52883524","pull_request_url":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/comments/52883524"},"html":{"href":"https://github.com/avast/log-dispatch-gelf/pull/5#discussion_r52883524"},"pull_request":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/5","id":59323727,"html_url":"https://github.com/avast/log-dispatch-gelf/pull/5","diff_url":"https://github.com/avast/log-dispatch-gelf/pull/5.diff","patch_url":"https://github.com/avast/log-dispatch-gelf/pull/5.patch","issue_url":"https://api.github.com/repos/avast/log-dispatch-gelf/issues/5","number":5,"state":"open","locked":false,"title":"Add GELF UDP chunking","user":{"login":"adamc00","id":212522,"avatar_url":"https://avatars.githubusercontent.com/u/212522?v=3","gravatar_id":"","url":"https://api.github.com/users/adamc00","html_url":"https://github.com/adamc00","followers_url":"https://api.github.com/users/adamc00/followers","following_url":"https://api.github.com/users/adamc00/following{/other_user}","gists_url":"https://api.github.com/users/adamc00/gists{/gist_id}","starred_url":"https://api.github.com/users/adamc00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamc00/subscriptions","organizations_url":"https://api.github.com/users/adamc00/orgs","repos_url":"https://api.github.com/users/adamc00/repos","events_url":"https://api.github.com/users/adamc00/events{/privacy}","received_events_url":"https://api.github.com/users/adamc00/received_events","type":"User","site_admin":false},"body":"Thanks for accepting my previous PR! This one adds GELF chunking for UDP sockets and associated tests. I have tested this against the GELF input of Logstash (latest stable and 1.5) and it works there perfectly.\r\n\r\nIt also contains a fix and test for a minor bug where a socket protocol of `xxx-udp` (for example) would pass the class initialisation argument checks.","created_at":"2016-02-15T05:56:25Z","updated_at":"2016-02-15T10:45:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c64a3e55b2ef7d2b6d60410e37f3c3f6bf692b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/5/commits","review_comments_url":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/5/comments","review_comment_url":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avast/log-dispatch-gelf/issues/5/comments","statuses_url":"https://api.github.com/repos/avast/log-dispatch-gelf/statuses/73a8993b08436cde181c68e439d8e4c20a012223","head":{"label":"strategicdata:feature/udp-chunking","ref":"feature/udp-chunking","sha":"73a8993b08436cde181c68e439d8e4c20a012223","user":{"login":"strategicdata","id":4394627,"avatar_url":"https://avatars.githubusercontent.com/u/4394627?v=3","gravatar_id":"","url":"https://api.github.com/users/strategicdata","html_url":"https://github.com/strategicdata","followers_url":"https://api.github.com/users/strategicdata/followers","following_url":"https://api.github.com/users/strategicdata/following{/other_user}","gists_url":"https://api.github.com/users/strategicdata/gists{/gist_id}","starred_url":"https://api.github.com/users/strategicdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strategicdata/subscriptions","organizations_url":"https://api.github.com/users/strategicdata/orgs","repos_url":"https://api.github.com/users/strategicdata/repos","events_url":"https://api.github.com/users/strategicdata/events{/privacy}","received_events_url":"https://api.github.com/users/strategicdata/received_events","type":"Organization","site_admin":false},"repo":{"id":51722875,"name":"log-dispatch-gelf","full_name":"strategicdata/log-dispatch-gelf","owner":{"login":"strategicdata","id":4394627,"avatar_url":"https://avatars.githubusercontent.com/u/4394627?v=3","gravatar_id":"","url":"https://api.github.com/users/strategicdata","html_url":"https://github.com/strategicdata","followers_url":"https://api.github.com/users/strategicdata/followers","following_url":"https://api.github.com/users/strategicdata/following{/other_user}","gists_url":"https://api.github.com/users/strategicdata/gists{/gist_id}","starred_url":"https://api.github.com/users/strategicdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strategicdata/subscriptions","organizations_url":"https://api.github.com/users/strategicdata/orgs","repos_url":"https://api.github.com/users/strategicdata/repos","events_url":"https://api.github.com/users/strategicdata/events{/privacy}","received_events_url":"https://api.github.com/users/strategicdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strategicdata/log-dispatch-gelf","description":"","fork":true,"url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf","forks_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/forks","keys_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/teams","hooks_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/hooks","issue_events_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/issues/events{/number}","events_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/events","assignees_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/assignees{/user}","branches_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/branches{/branch}","tags_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/tags","blobs_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/statuses/{sha}","languages_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/languages","stargazers_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/stargazers","contributors_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/contributors","subscribers_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/subscribers","subscription_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/subscription","commits_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/contents/{+path}","compare_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/merges","archive_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/downloads","issues_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/issues{/number}","pulls_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/pulls{/number}","milestones_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/milestones{/number}","notifications_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/labels{/name}","releases_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/releases{/id}","deployments_url":"https://api.github.com/repos/strategicdata/log-dispatch-gelf/deployments","created_at":"2016-02-15T01:20:14Z","updated_at":"2016-02-15T01:20:14Z","pushed_at":"2016-02-15T06:21:34Z","git_url":"git://github.com/strategicdata/log-dispatch-gelf.git","ssh_url":"git@github.com:strategicdata/log-dispatch-gelf.git","clone_url":"https://github.com/strategicdata/log-dispatch-gelf.git","svn_url":"https://github.com/strategicdata/log-dispatch-gelf","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avast:master","ref":"master","sha":"e44c62670337383b20b06a799fd95e9ea64cedfd","user":{"login":"avast","id":3996079,"avatar_url":"https://avatars.githubusercontent.com/u/3996079?v=3","gravatar_id":"","url":"https://api.github.com/users/avast","html_url":"https://github.com/avast","followers_url":"https://api.github.com/users/avast/followers","following_url":"https://api.github.com/users/avast/following{/other_user}","gists_url":"https://api.github.com/users/avast/gists{/gist_id}","starred_url":"https://api.github.com/users/avast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avast/subscriptions","organizations_url":"https://api.github.com/users/avast/orgs","repos_url":"https://api.github.com/users/avast/repos","events_url":"https://api.github.com/users/avast/events{/privacy}","received_events_url":"https://api.github.com/users/avast/received_events","type":"Organization","site_admin":false},"repo":{"id":34846552,"name":"log-dispatch-gelf","full_name":"avast/log-dispatch-gelf","owner":{"login":"avast","id":3996079,"avatar_url":"https://avatars.githubusercontent.com/u/3996079?v=3","gravatar_id":"","url":"https://api.github.com/users/avast","html_url":"https://github.com/avast","followers_url":"https://api.github.com/users/avast/followers","following_url":"https://api.github.com/users/avast/following{/other_user}","gists_url":"https://api.github.com/users/avast/gists{/gist_id}","starred_url":"https://api.github.com/users/avast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avast/subscriptions","organizations_url":"https://api.github.com/users/avast/orgs","repos_url":"https://api.github.com/users/avast/repos","events_url":"https://api.github.com/users/avast/events{/privacy}","received_events_url":"https://api.github.com/users/avast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avast/log-dispatch-gelf","description":"","fork":false,"url":"https://api.github.com/repos/avast/log-dispatch-gelf","forks_url":"https://api.github.com/repos/avast/log-dispatch-gelf/forks","keys_url":"https://api.github.com/repos/avast/log-dispatch-gelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avast/log-dispatch-gelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avast/log-dispatch-gelf/teams","hooks_url":"https://api.github.com/repos/avast/log-dispatch-gelf/hooks","issue_events_url":"https://api.github.com/repos/avast/log-dispatch-gelf/issues/events{/number}","events_url":"https://api.github.com/repos/avast/log-dispatch-gelf/events","assignees_url":"https://api.github.com/repos/avast/log-dispatch-gelf/assignees{/user}","branches_url":"https://api.github.com/repos/avast/log-dispatch-gelf/branches{/branch}","tags_url":"https://api.github.com/repos/avast/log-dispatch-gelf/tags","blobs_url":"https://api.github.com/repos/avast/log-dispatch-gelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avast/log-dispatch-gelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avast/log-dispatch-gelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/avast/log-dispatch-gelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avast/log-dispatch-gelf/statuses/{sha}","languages_url":"https://api.github.com/repos/avast/log-dispatch-gelf/languages","stargazers_url":"https://api.github.com/repos/avast/log-dispatch-gelf/stargazers","contributors_url":"https://api.github.com/repos/avast/log-dispatch-gelf/contributors","subscribers_url":"https://api.github.com/repos/avast/log-dispatch-gelf/subscribers","subscription_url":"https://api.github.com/repos/avast/log-dispatch-gelf/subscription","commits_url":"https://api.github.com/repos/avast/log-dispatch-gelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/avast/log-dispatch-gelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/avast/log-dispatch-gelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/avast/log-dispatch-gelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/avast/log-dispatch-gelf/contents/{+path}","compare_url":"https://api.github.com/repos/avast/log-dispatch-gelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avast/log-dispatch-gelf/merges","archive_url":"https://api.github.com/repos/avast/log-dispatch-gelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avast/log-dispatch-gelf/downloads","issues_url":"https://api.github.com/repos/avast/log-dispatch-gelf/issues{/number}","pulls_url":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls{/number}","milestones_url":"https://api.github.com/repos/avast/log-dispatch-gelf/milestones{/number}","notifications_url":"https://api.github.com/repos/avast/log-dispatch-gelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avast/log-dispatch-gelf/labels{/name}","releases_url":"https://api.github.com/repos/avast/log-dispatch-gelf/releases{/id}","deployments_url":"https://api.github.com/repos/avast/log-dispatch-gelf/deployments","created_at":"2015-04-30T09:35:09Z","updated_at":"2016-01-21T11:24:36Z","pushed_at":"2016-02-15T06:21:34Z","git_url":"git://github.com/avast/log-dispatch-gelf.git","ssh_url":"git@github.com:avast/log-dispatch-gelf.git","clone_url":"https://github.com/avast/log-dispatch-gelf.git","svn_url":"https://github.com/avast/log-dispatch-gelf","homepage":null,"size":32,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/5"},"html":{"href":"https://github.com/avast/log-dispatch-gelf/pull/5"},"issue":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/issues/5"},"comments":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/avast/log-dispatch-gelf/statuses/73a8993b08436cde181c68e439d8e4c20a012223"}}}}