{"action":"created","issue":{"url":"https://api.github.com/repos/danpalmer/flake8-commas/issues/1","repository_url":"https://api.github.com/repos/danpalmer/flake8-commas","labels_url":"https://api.github.com/repos/danpalmer/flake8-commas/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/danpalmer/flake8-commas/issues/1/comments","events_url":"https://api.github.com/repos/danpalmer/flake8-commas/issues/1/events","html_url":"https://github.com/danpalmer/flake8-commas/pull/1","id":146913460,"number":1,"title":"adding test for newly introduced false negative","user":{"login":"moritzpein","id":682686,"avatar_url":"https://avatars.githubusercontent.com/u/682686?v=3","gravatar_id":"","url":"https://api.github.com/users/moritzpein","html_url":"https://github.com/moritzpein","followers_url":"https://api.github.com/users/moritzpein/followers","following_url":"https://api.github.com/users/moritzpein/following{/other_user}","gists_url":"https://api.github.com/users/moritzpein/gists{/gist_id}","starred_url":"https://api.github.com/users/moritzpein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moritzpein/subscriptions","organizations_url":"https://api.github.com/users/moritzpein/orgs","repos_url":"https://api.github.com/users/moritzpein/repos","events_url":"https://api.github.com/users/moritzpein/events{/privacy}","received_events_url":"https://api.github.com/users/moritzpein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-08T12:17:28Z","updated_at":"2016-04-08T14:08:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/danpalmer/flake8-commas/pulls/1","html_url":"https://github.com/danpalmer/flake8-commas/pull/1","diff_url":"https://github.com/danpalmer/flake8-commas/pull/1.diff","patch_url":"https://github.com/danpalmer/flake8-commas/pull/1.patch"},"body":"Hi Dan,\r\n\r\nI had a look at your fix for the false positives with multi-line comprehensions and found a flaw. \r\n\r\nI wrote a test to demonstrate it. The actual data doesn't make any sense but I guess you get the point. Sorry that I didn't provide a fix with this pull request."},"comment":{"url":"https://api.github.com/repos/danpalmer/flake8-commas/issues/comments/207445893","html_url":"https://github.com/danpalmer/flake8-commas/pull/1#issuecomment-207445893","issue_url":"https://api.github.com/repos/danpalmer/flake8-commas/issues/1","id":207445893,"user":{"login":"danpalmer","id":202400,"avatar_url":"https://avatars.githubusercontent.com/u/202400?v=3","gravatar_id":"","url":"https://api.github.com/users/danpalmer","html_url":"https://github.com/danpalmer","followers_url":"https://api.github.com/users/danpalmer/followers","following_url":"https://api.github.com/users/danpalmer/following{/other_user}","gists_url":"https://api.github.com/users/danpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/danpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpalmer/subscriptions","organizations_url":"https://api.github.com/users/danpalmer/orgs","repos_url":"https://api.github.com/users/danpalmer/repos","events_url":"https://api.github.com/users/danpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/danpalmer/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T14:08:51Z","updated_at":"2016-04-08T14:08:51Z","body":"@moritzpein awesome, that's a great edge case I hadn't considered. You may have seen I have PRs open for a bunch more incorrect classifications, I'm beginning to think that a new approach might be needed, such as using the AST for filtering, and then the tokens for the rest. I'm not sure if the AST retains enough information to do this though.\r\n\r\nI'll merge this when I have a fix for it that I can add to the PR upstream."}}