{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls/5","id":87598432,"html_url":"https://github.com/jameshuynh/docsplit_images/pull/5","diff_url":"https://github.com/jameshuynh/docsplit_images/pull/5.diff","patch_url":"https://github.com/jameshuynh/docsplit_images/pull/5.patch","issue_url":"https://api.github.com/repos/jameshuynh/docsplit_images/issues/5","number":5,"state":"closed","locked":false,"title":"Fix generator for Rails 5 (compatible with older rails, just renaming of method)","user":{"login":"muhammadn","id":3349747,"avatar_url":"https://avatars.githubusercontent.com/u/3349747?v=3","gravatar_id":"","url":"https://api.github.com/users/muhammadn","html_url":"https://github.com/muhammadn","followers_url":"https://api.github.com/users/muhammadn/followers","following_url":"https://api.github.com/users/muhammadn/following{/other_user}","gists_url":"https://api.github.com/users/muhammadn/gists{/gist_id}","starred_url":"https://api.github.com/users/muhammadn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muhammadn/subscriptions","organizations_url":"https://api.github.com/users/muhammadn/orgs","repos_url":"https://api.github.com/users/muhammadn/repos","events_url":"https://api.github.com/users/muhammadn/events{/privacy}","received_events_url":"https://api.github.com/users/muhammadn/received_events","type":"User","site_admin":false},"body":"When running:\r\n\r\n`rails g docsplit_images <table_name> <attachment_field_name>`\r\n\r\nThere will be an error with:\r\n`'migration_file_name': protected method 'migration_file_name' called for #<DocsplitImagesGenerator:0x007ff373be6090> (NoMethodError)`\r\n\r\nIt seems that `migration_file_name` is a method reserved in rails 5. I had renamed the appropriate methods to use docsplit_images_ to make it unique. (for example `docsplit_images_migration_file_name`)\r\n","created_at":"2016-10-01T10:33:31Z","updated_at":"2016-10-03T01:50:12Z","closed_at":"2016-10-03T01:50:12Z","merged_at":"2016-10-03T01:50:12Z","merge_commit_sha":"0762b0ae998476afc26f8a80ba3f8d02adee01cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls/5/commits","review_comments_url":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls/5/comments","review_comment_url":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jameshuynh/docsplit_images/issues/5/comments","statuses_url":"https://api.github.com/repos/jameshuynh/docsplit_images/statuses/d1cca0bfb4545dd23c7419169980992993f191a9","head":{"label":"muhammadn:fix-generator","ref":"fix-generator","sha":"d1cca0bfb4545dd23c7419169980992993f191a9","user":{"login":"muhammadn","id":3349747,"avatar_url":"https://avatars.githubusercontent.com/u/3349747?v=3","gravatar_id":"","url":"https://api.github.com/users/muhammadn","html_url":"https://github.com/muhammadn","followers_url":"https://api.github.com/users/muhammadn/followers","following_url":"https://api.github.com/users/muhammadn/following{/other_user}","gists_url":"https://api.github.com/users/muhammadn/gists{/gist_id}","starred_url":"https://api.github.com/users/muhammadn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muhammadn/subscriptions","organizations_url":"https://api.github.com/users/muhammadn/orgs","repos_url":"https://api.github.com/users/muhammadn/repos","events_url":"https://api.github.com/users/muhammadn/events{/privacy}","received_events_url":"https://api.github.com/users/muhammadn/received_events","type":"User","site_admin":false},"repo":{"id":69108304,"name":"docsplit_images","full_name":"muhammadn/docsplit_images","owner":{"login":"muhammadn","id":3349747,"avatar_url":"https://avatars.githubusercontent.com/u/3349747?v=3","gravatar_id":"","url":"https://api.github.com/users/muhammadn","html_url":"https://github.com/muhammadn","followers_url":"https://api.github.com/users/muhammadn/followers","following_url":"https://api.github.com/users/muhammadn/following{/other_user}","gists_url":"https://api.github.com/users/muhammadn/gists{/gist_id}","starred_url":"https://api.github.com/users/muhammadn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muhammadn/subscriptions","organizations_url":"https://api.github.com/users/muhammadn/orgs","repos_url":"https://api.github.com/users/muhammadn/repos","events_url":"https://api.github.com/users/muhammadn/events{/privacy}","received_events_url":"https://api.github.com/users/muhammadn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muhammadn/docsplit_images","description":"An extension of Docsplit gem to convert uploaded document to images","fork":true,"url":"https://api.github.com/repos/muhammadn/docsplit_images","forks_url":"https://api.github.com/repos/muhammadn/docsplit_images/forks","keys_url":"https://api.github.com/repos/muhammadn/docsplit_images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muhammadn/docsplit_images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muhammadn/docsplit_images/teams","hooks_url":"https://api.github.com/repos/muhammadn/docsplit_images/hooks","issue_events_url":"https://api.github.com/repos/muhammadn/docsplit_images/issues/events{/number}","events_url":"https://api.github.com/repos/muhammadn/docsplit_images/events","assignees_url":"https://api.github.com/repos/muhammadn/docsplit_images/assignees{/user}","branches_url":"https://api.github.com/repos/muhammadn/docsplit_images/branches{/branch}","tags_url":"https://api.github.com/repos/muhammadn/docsplit_images/tags","blobs_url":"https://api.github.com/repos/muhammadn/docsplit_images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muhammadn/docsplit_images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muhammadn/docsplit_images/git/refs{/sha}","trees_url":"https://api.github.com/repos/muhammadn/docsplit_images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muhammadn/docsplit_images/statuses/{sha}","languages_url":"https://api.github.com/repos/muhammadn/docsplit_images/languages","stargazers_url":"https://api.github.com/repos/muhammadn/docsplit_images/stargazers","contributors_url":"https://api.github.com/repos/muhammadn/docsplit_images/contributors","subscribers_url":"https://api.github.com/repos/muhammadn/docsplit_images/subscribers","subscription_url":"https://api.github.com/repos/muhammadn/docsplit_images/subscription","commits_url":"https://api.github.com/repos/muhammadn/docsplit_images/commits{/sha}","git_commits_url":"https://api.github.com/repos/muhammadn/docsplit_images/git/commits{/sha}","comments_url":"https://api.github.com/repos/muhammadn/docsplit_images/comments{/number}","issue_comment_url":"https://api.github.com/repos/muhammadn/docsplit_images/issues/comments{/number}","contents_url":"https://api.github.com/repos/muhammadn/docsplit_images/contents/{+path}","compare_url":"https://api.github.com/repos/muhammadn/docsplit_images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muhammadn/docsplit_images/merges","archive_url":"https://api.github.com/repos/muhammadn/docsplit_images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muhammadn/docsplit_images/downloads","issues_url":"https://api.github.com/repos/muhammadn/docsplit_images/issues{/number}","pulls_url":"https://api.github.com/repos/muhammadn/docsplit_images/pulls{/number}","milestones_url":"https://api.github.com/repos/muhammadn/docsplit_images/milestones{/number}","notifications_url":"https://api.github.com/repos/muhammadn/docsplit_images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muhammadn/docsplit_images/labels{/name}","releases_url":"https://api.github.com/repos/muhammadn/docsplit_images/releases{/id}","deployments_url":"https://api.github.com/repos/muhammadn/docsplit_images/deployments","created_at":"2016-09-24T14:51:00Z","updated_at":"2016-09-24T14:51:01Z","pushed_at":"2016-10-01T10:29:35Z","git_url":"git://github.com/muhammadn/docsplit_images.git","ssh_url":"git@github.com:muhammadn/docsplit_images.git","clone_url":"https://github.com/muhammadn/docsplit_images.git","svn_url":"https://github.com/muhammadn/docsplit_images","homepage":"","size":34,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jameshuynh:master","ref":"master","sha":"c184791a8f5879db1ebf5f519d08ad664fe8f6c3","user":{"login":"jameshuynh","id":29207,"avatar_url":"https://avatars.githubusercontent.com/u/29207?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshuynh","html_url":"https://github.com/jameshuynh","followers_url":"https://api.github.com/users/jameshuynh/followers","following_url":"https://api.github.com/users/jameshuynh/following{/other_user}","gists_url":"https://api.github.com/users/jameshuynh/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshuynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshuynh/subscriptions","organizations_url":"https://api.github.com/users/jameshuynh/orgs","repos_url":"https://api.github.com/users/jameshuynh/repos","events_url":"https://api.github.com/users/jameshuynh/events{/privacy}","received_events_url":"https://api.github.com/users/jameshuynh/received_events","type":"User","site_admin":false},"repo":{"id":6805777,"name":"docsplit_images","full_name":"jameshuynh/docsplit_images","owner":{"login":"jameshuynh","id":29207,"avatar_url":"https://avatars.githubusercontent.com/u/29207?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshuynh","html_url":"https://github.com/jameshuynh","followers_url":"https://api.github.com/users/jameshuynh/followers","following_url":"https://api.github.com/users/jameshuynh/following{/other_user}","gists_url":"https://api.github.com/users/jameshuynh/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshuynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshuynh/subscriptions","organizations_url":"https://api.github.com/users/jameshuynh/orgs","repos_url":"https://api.github.com/users/jameshuynh/repos","events_url":"https://api.github.com/users/jameshuynh/events{/privacy}","received_events_url":"https://api.github.com/users/jameshuynh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jameshuynh/docsplit_images","description":"An extension of Docsplit gem to convert uploaded document to images","fork":false,"url":"https://api.github.com/repos/jameshuynh/docsplit_images","forks_url":"https://api.github.com/repos/jameshuynh/docsplit_images/forks","keys_url":"https://api.github.com/repos/jameshuynh/docsplit_images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jameshuynh/docsplit_images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jameshuynh/docsplit_images/teams","hooks_url":"https://api.github.com/repos/jameshuynh/docsplit_images/hooks","issue_events_url":"https://api.github.com/repos/jameshuynh/docsplit_images/issues/events{/number}","events_url":"https://api.github.com/repos/jameshuynh/docsplit_images/events","assignees_url":"https://api.github.com/repos/jameshuynh/docsplit_images/assignees{/user}","branches_url":"https://api.github.com/repos/jameshuynh/docsplit_images/branches{/branch}","tags_url":"https://api.github.com/repos/jameshuynh/docsplit_images/tags","blobs_url":"https://api.github.com/repos/jameshuynh/docsplit_images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jameshuynh/docsplit_images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jameshuynh/docsplit_images/git/refs{/sha}","trees_url":"https://api.github.com/repos/jameshuynh/docsplit_images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jameshuynh/docsplit_images/statuses/{sha}","languages_url":"https://api.github.com/repos/jameshuynh/docsplit_images/languages","stargazers_url":"https://api.github.com/repos/jameshuynh/docsplit_images/stargazers","contributors_url":"https://api.github.com/repos/jameshuynh/docsplit_images/contributors","subscribers_url":"https://api.github.com/repos/jameshuynh/docsplit_images/subscribers","subscription_url":"https://api.github.com/repos/jameshuynh/docsplit_images/subscription","commits_url":"https://api.github.com/repos/jameshuynh/docsplit_images/commits{/sha}","git_commits_url":"https://api.github.com/repos/jameshuynh/docsplit_images/git/commits{/sha}","comments_url":"https://api.github.com/repos/jameshuynh/docsplit_images/comments{/number}","issue_comment_url":"https://api.github.com/repos/jameshuynh/docsplit_images/issues/comments{/number}","contents_url":"https://api.github.com/repos/jameshuynh/docsplit_images/contents/{+path}","compare_url":"https://api.github.com/repos/jameshuynh/docsplit_images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jameshuynh/docsplit_images/merges","archive_url":"https://api.github.com/repos/jameshuynh/docsplit_images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jameshuynh/docsplit_images/downloads","issues_url":"https://api.github.com/repos/jameshuynh/docsplit_images/issues{/number}","pulls_url":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls{/number}","milestones_url":"https://api.github.com/repos/jameshuynh/docsplit_images/milestones{/number}","notifications_url":"https://api.github.com/repos/jameshuynh/docsplit_images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jameshuynh/docsplit_images/labels{/name}","releases_url":"https://api.github.com/repos/jameshuynh/docsplit_images/releases{/id}","deployments_url":"https://api.github.com/repos/jameshuynh/docsplit_images/deployments","created_at":"2012-11-22T00:46:54Z","updated_at":"2016-07-14T17:07:15Z","pushed_at":"2016-10-03T01:50:12Z","git_url":"git://github.com/jameshuynh/docsplit_images.git","ssh_url":"git@github.com:jameshuynh/docsplit_images.git","clone_url":"https://github.com/jameshuynh/docsplit_images.git","svn_url":"https://github.com/jameshuynh/docsplit_images","homepage":"","size":32,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls/5"},"html":{"href":"https://github.com/jameshuynh/docsplit_images/pull/5"},"issue":{"href":"https://api.github.com/repos/jameshuynh/docsplit_images/issues/5"},"comments":{"href":"https://api.github.com/repos/jameshuynh/docsplit_images/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jameshuynh/docsplit_images/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/jameshuynh/docsplit_images/statuses/d1cca0bfb4545dd23c7419169980992993f191a9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jameshuynh","id":29207,"avatar_url":"https://avatars.githubusercontent.com/u/29207?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshuynh","html_url":"https://github.com/jameshuynh","followers_url":"https://api.github.com/users/jameshuynh/followers","following_url":"https://api.github.com/users/jameshuynh/following{/other_user}","gists_url":"https://api.github.com/users/jameshuynh/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshuynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshuynh/subscriptions","organizations_url":"https://api.github.com/users/jameshuynh/orgs","repos_url":"https://api.github.com/users/jameshuynh/repos","events_url":"https://api.github.com/users/jameshuynh/events{/privacy}","received_events_url":"https://api.github.com/users/jameshuynh/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":5,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"jameshuynh"}}