{"action":"created","issue":{"url":"https://api.github.com/repos/NETMF/netmf-interpreter/issues/511","repository_url":"https://api.github.com/repos/NETMF/netmf-interpreter","labels_url":"https://api.github.com/repos/NETMF/netmf-interpreter/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/NETMF/netmf-interpreter/issues/511/comments","events_url":"https://api.github.com/repos/NETMF/netmf-interpreter/issues/511/events","html_url":"https://github.com/NETMF/netmf-interpreter/issues/511","id":175172147,"number":511,"title":"Remove obsolete code for native patching","user":{"login":"cw2","id":10730406,"avatar_url":"https://avatars.githubusercontent.com/u/10730406?v=3","gravatar_id":"","url":"https://api.github.com/users/cw2","html_url":"https://github.com/cw2","followers_url":"https://api.github.com/users/cw2/followers","following_url":"https://api.github.com/users/cw2/following{/other_user}","gists_url":"https://api.github.com/users/cw2/gists{/gist_id}","starred_url":"https://api.github.com/users/cw2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw2/subscriptions","organizations_url":"https://api.github.com/users/cw2/orgs","repos_url":"https://api.github.com/users/cw2/repos","events_url":"https://api.github.com/users/cw2/events{/privacy}","received_events_url":"https://api.github.com/users/cw2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-06T06:47:57Z","updated_at":"2016-09-06T19:10:48Z","closed_at":null,"body":"Unfortunately, I cannot find the original source (it could be either a CodePlex issue or a topic on the old netmf.com discussion forum), but IIRC the mechanism for native patching is obsolete since 4.x (and maybe even before that).\r\n\r\nI'd suggest removing this code, namely handling of `patch_*` parameters in `WatchAssemblyBuilder::Linker::Generate(...)` function and related command line arguments parsing in MetadataProcessor.cpp.\r\n\r\nAdditional benefit will be removal of three cryptolib function calls (`Crypto_GetHash`,`Crypto_PublicKeyFromModulus` and `Crypto_RSADecrypt`), significant reduction of crypto functions needed on the device side (they are then called only from stubs and/or _test_win_ test application)."},"comment":{"url":"https://api.github.com/repos/NETMF/netmf-interpreter/issues/comments/245057439","html_url":"https://github.com/NETMF/netmf-interpreter/issues/511#issuecomment-245057439","issue_url":"https://api.github.com/repos/NETMF/netmf-interpreter/issues/511","id":245057439,"user":{"login":"smaillet-ms","id":8934567,"avatar_url":"https://avatars.githubusercontent.com/u/8934567?v=3","gravatar_id":"","url":"https://api.github.com/users/smaillet-ms","html_url":"https://github.com/smaillet-ms","followers_url":"https://api.github.com/users/smaillet-ms/followers","following_url":"https://api.github.com/users/smaillet-ms/following{/other_user}","gists_url":"https://api.github.com/users/smaillet-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/smaillet-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaillet-ms/subscriptions","organizations_url":"https://api.github.com/users/smaillet-ms/orgs","repos_url":"https://api.github.com/users/smaillet-ms/repos","events_url":"https://api.github.com/users/smaillet-ms/events{/privacy}","received_events_url":"https://api.github.com/users/smaillet-ms/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T19:10:47Z","updated_at":"2016-09-06T19:10:47Z","body":"At this point it does no harm to leave it in and doesn't really add value to current users to remove.  My plan for MetadataProcessor is to actually swap out the version we have now for the C# version from the [Xamarin/Monkey robotics](https://github.com/xamarin/Monkey.Robotics/tree/master/Source/Xamarin%20Studio%20Microframework%20Add-in/MFMetaDataProcessor) version. As it will be easier to handle the additional functionality desired when it's all C#. This also means that MetadataProcessor won't be one big giant \"Swiss Army Knife\" tool anymore either. There, were a number of things like the signature generation and other crypto support in MetadataProcessor that had nothing to do with actually processing the metadata.\r\n\r\nGiven that - making changes to MetadataProcessor that aren't causing actual real problems doesn't make sense to me. "}}
{"actor":{"display_login":"smaillet-ms"}}