{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/7271","labels_url":"https://api.github.com/repos/ceph/ceph/issues/7271/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/7271/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/7271/events","html_url":"https://github.com/ceph/ceph/pull/7271","id":127307280,"number":7271,"title":"OSD: Deleting transaction object right after applying transaction","user":{"login":"somnathr","id":5751779,"avatar_url":"https://avatars.githubusercontent.com/u/5751779?v=3","gravatar_id":"","url":"https://api.github.com/users/somnathr","html_url":"https://github.com/somnathr","followers_url":"https://api.github.com/users/somnathr/followers","following_url":"https://api.github.com/users/somnathr/following{/other_user}","gists_url":"https://api.github.com/users/somnathr/gists{/gist_id}","starred_url":"https://api.github.com/users/somnathr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somnathr/subscriptions","organizations_url":"https://api.github.com/users/somnathr/orgs","repos_url":"https://api.github.com/users/somnathr/repos","events_url":"https://api.github.com/users/somnathr/events{/privacy}","received_events_url":"https://api.github.com/users/somnathr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0052cc"},{"url":"https://api.github.com/repos/ceph/ceph/labels/performance","name":"performance","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-01-18T20:43:34Z","updated_at":"2016-01-26T14:52:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/7271","html_url":"https://github.com/ceph/ceph/pull/7271","diff_url":"https://github.com/ceph/ceph/pull/7271.diff","patch_url":"https://github.com/ceph/ceph/pull/7271.patch"},"body":"Presently, the transaction object is been deleted by the Finisher\r\nthread asynchronously. In heavy load scenario specially if we\r\nunleash journal throttle more, we are seeing high memory usage by\r\nthe OSDs because of this. In this new scheme, with the help of\r\nmove semantics transaction objects will be deleted synchronously\r\nfrom the filestore worker threads. We are seeing very much\r\ncontrollable memory growth now as well as ~3 to 4% cpu usage\r\nbenefit because of some reduction of 'new' , 'delete' calls.\r\n\r\nSigned-off-by: Somnath Roy <somnath.roy@sandisk.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/175057064","html_url":"https://github.com/ceph/ceph/pull/7271#issuecomment-175057064","issue_url":"https://api.github.com/repos/ceph/ceph/issues/7271","id":175057064,"user":{"login":"cbodley","id":1928002,"avatar_url":"https://avatars.githubusercontent.com/u/1928002?v=3","gravatar_id":"","url":"https://api.github.com/users/cbodley","html_url":"https://github.com/cbodley","followers_url":"https://api.github.com/users/cbodley/followers","following_url":"https://api.github.com/users/cbodley/following{/other_user}","gists_url":"https://api.github.com/users/cbodley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbodley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbodley/subscriptions","organizations_url":"https://api.github.com/users/cbodley/orgs","repos_url":"https://api.github.com/users/cbodley/repos","events_url":"https://api.github.com/users/cbodley/events{/privacy}","received_events_url":"https://api.github.com/users/cbodley/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T14:52:53Z","updated_at":"2016-01-26T14:52:53Z","body":"@somnathr looks good to me, great work! have you had a chance to benchmark again?"}}