{"action":"created","comment":{"url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/comments/62831887","id":62831887,"diff_hunk":"@@ -1,27 +1,79 @@\n # Shown below are the defaults for configuration\n ReactOnRails.configure do |config|\n-  # Client bundles are configured in application.js\n-\n+  # Directory where your generated assets go. All generated assets must go to the same directory.\n+  # Configure this in your webpack config files. This relative to your Rails root directory.\n   config.generated_assets_dir = File.join(%w(app assets webpack))\n \n   # Define the files for we need to check for webpack compilation when running tests\n   config.webpack_generated_files = %w( app-bundle.js vendor-bundle.js app-bundle.css\n                                        vendor-bundle.css server-bundle.js )\n \n-  # Server bundle is a single file for all server rendering of components.\n-  # If you wish to use render_js in your views without any file, set this to \"\" to avoid warnings.\n-  # Note this is under app/assets/webpack/\n-  config.server_bundle_js_file = \"server-bundle.js\" # This is the default\n+  # This is the file used for server rendering of React when using `(prerender: true)`\n+  # If you are never using server rendering, you may set this to \"\".\n+  # If you are using the same file for client and server rendering, having this set probably does\n+  # not affect performance.\n+  config.server_bundle_js_file = \"server-bundle.js\"\n+\n+  # If you are using the ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)\n+  # with rspec then this controls what npm command is run\n+  # to automatically refresh your webpack assets on every test run.\n+  config.npm_build_test_command = \"npm run build:test\"\n+\n+  # This configures the script to run to build the production assets by webpack. Set this to nil\n+  # if you don't want react_on_rails building this file for you.\n+  config.npm_build_production_command = \"npm run build:production\"\n+\n+  ################################################################################\n+  # CLIENT RENDERING OPTIONS\n+  # Below options can be overriden by passing options to the react_on_rails\n+  # `render_component` view helper method.\n+  ################################################################################\n+  # default is false\n+  config.prerender = true\n+\n+  # default is true for development, off otherwise\n+  config.trace = Rails.env.development?\n+\n+  ################################################################################\n+  # SERVER RENDERING OPTIONS\n+  ################################################################################\n \n-  # Below options can be overriden by passing to the helper method.\n-  config.prerender = true # default is false\n-  config.trace = Rails.env.development? # default is true for development, off otherwise\n+  # If set to true, this forces Rails to reload the server bundle if it is modified\n+  config.development_mode = Rails.env.development?\n \n   # For server rendering. This can be set to false so that server side messages are discarded.\n-  config.replay_console = true # Default is true. Be cautious about turning this off.\n-  config.logging_on_server = true # Default is true. Logs server rendering messags to Rails.logger.info\n+  # Default is true. Be cautious about turning this off.\n+  config.replay_console = true\n+\n+  # Default is true. Logs server rendering messages to Rails.logger.info\n+  config.logging_on_server = true\n+\n+  config.raise_on_prerender_error = false # change to true to raise exception on server if the JS code throws\n+\n+  # Server rendering only (not for render_component helper)\n+  # You can configure your pool of JS virtual machines and specify where it should load code:\n+  # On MRI, use `therubyracer` for the best performance\n+  # (see [discussion](https://github.com/reactjs/react-rails/pull/290))\n+  # On MRI, you'll get a deadlock with `pool_size` > 1\n+  # If you're using JRuby, you can increase `pool_size` to have real multi-threaded rendering.\n+  config.server_renderer_pool_size = 1 # increase if you're on JRuby\n+  config.server_renderer_timeout = 20 # seconds\n+\n+  ################################################################################\n+  # MISCELLANEOUS OPTIONS\n+  ################################################################################\n+  # Default is false, enable if your content security policy doesn't include `style-src: 'unsafe-inline'`\n+  config.skip_display_none = false\n+\n+  # This allows you to add additional values to the Rails Context. Implement one static method\n+  # called `custom_context(view_context)` and return a Hash.\n+  config.rendering_extension = nil\n+\n+  # The server render method - either ExecJS or NodeJS\n+  config.server_render_method = \"ExecJS\"","path":"config/initializers/react_on_rails.rb","position":84,"original_position":84,"commit_id":"ccdeaea49a2f40c274e4dcd2e9389610aea3d996","original_commit_id":"ccdeaea49a2f40c274e4dcd2e9389610aea3d996","user":{"login":"justin808","id":1118459,"avatar_url":"https://avatars.githubusercontent.com/u/1118459?v=3","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"body":"NodeJS is a new feature for v6. Give it a try. See docs in [PR #380](https://github.com/shakacode/react_on_rails/pull/380) and [Node Server Rendering](https://github.com/shakacode/react_on_rails/blob/master/docs%2Fadditional-reading%2Fnode-server-rendering.md).","created_at":"2016-05-11T11:36:33Z","updated_at":"2016-05-11T11:36:33Z","html_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/287#discussion_r62831887","pull_request_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/comments/62831887"},"html":{"href":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/287#discussion_r62831887"},"pull_request":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/287","id":69479923,"html_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/287","diff_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/287.diff","patch_url":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/287.patch","issue_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/287","number":287,"state":"open","locked":false,"title":"WIP Update to React On Rails v6","user":{"login":"justin808","id":1118459,"avatar_url":"https://avatars.githubusercontent.com/u/1118459?v=3","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/shakacode/react-webpack-rails-tutorial/287)\n<!-- Reviewable:end -->\n","created_at":"2016-05-10T10:07:43Z","updated_at":"2016-05-11T11:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3704888190d2bc7f9562291e571cbe5be7ffe2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/287/commits","review_comments_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/287/comments","review_comment_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/287/comments","statuses_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/statuses/ccdeaea49a2f40c274e4dcd2e9389610aea3d996","head":{"label":"shakacode:update-to-ror-6","ref":"update-to-ror-6","sha":"ccdeaea49a2f40c274e4dcd2e9389610aea3d996","user":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"repo":{"id":24088847,"name":"react-webpack-rails-tutorial","full_name":"shakacode/react-webpack-rails-tutorial","owner":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shakacode/react-webpack-rails-tutorial","description":"Example of integration of Rails, react, redux, using the react_on_rails gem, webpack, enabling the es7 and jsx transpilers, and node integration. Live Demo:","fork":false,"url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial","forks_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/forks","keys_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/teams","hooks_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/hooks","issue_events_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/events{/number}","events_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/events","assignees_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/assignees{/user}","branches_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/branches{/branch}","tags_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/tags","blobs_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/statuses/{sha}","languages_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/languages","stargazers_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/stargazers","contributors_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/contributors","subscribers_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/subscribers","subscription_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/subscription","commits_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/contents/{+path}","compare_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/merges","archive_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/downloads","issues_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues{/number}","pulls_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls{/number}","milestones_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/milestones{/number}","notifications_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/labels{/name}","releases_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/releases{/id}","deployments_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/deployments","created_at":"2014-09-16T06:54:32Z","updated_at":"2016-05-11T05:05:23Z","pushed_at":"2016-05-11T11:30:07Z","git_url":"git://github.com/shakacode/react-webpack-rails-tutorial.git","ssh_url":"git@github.com:shakacode/react-webpack-rails-tutorial.git","clone_url":"https://github.com/shakacode/react-webpack-rails-tutorial.git","svn_url":"https://github.com/shakacode/react-webpack-rails-tutorial","homepage":"http://www.reactrails.com","size":1899,"stargazers_count":843,"watchers_count":843,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":19,"forks":159,"open_issues":19,"watchers":843,"default_branch":"master"}},"base":{"label":"shakacode:master","ref":"master","sha":"2fa2143803a674f2cb061114749c6e5cc24b613c","user":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"repo":{"id":24088847,"name":"react-webpack-rails-tutorial","full_name":"shakacode/react-webpack-rails-tutorial","owner":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shakacode/react-webpack-rails-tutorial","description":"Example of integration of Rails, react, redux, using the react_on_rails gem, webpack, enabling the es7 and jsx transpilers, and node integration. Live Demo:","fork":false,"url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial","forks_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/forks","keys_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/teams","hooks_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/hooks","issue_events_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/events{/number}","events_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/events","assignees_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/assignees{/user}","branches_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/branches{/branch}","tags_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/tags","blobs_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/statuses/{sha}","languages_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/languages","stargazers_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/stargazers","contributors_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/contributors","subscribers_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/subscribers","subscription_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/subscription","commits_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/contents/{+path}","compare_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/merges","archive_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/downloads","issues_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues{/number}","pulls_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls{/number}","milestones_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/milestones{/number}","notifications_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/labels{/name}","releases_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/releases{/id}","deployments_url":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/deployments","created_at":"2014-09-16T06:54:32Z","updated_at":"2016-05-11T05:05:23Z","pushed_at":"2016-05-11T11:30:07Z","git_url":"git://github.com/shakacode/react-webpack-rails-tutorial.git","ssh_url":"git@github.com:shakacode/react-webpack-rails-tutorial.git","clone_url":"https://github.com/shakacode/react-webpack-rails-tutorial.git","svn_url":"https://github.com/shakacode/react-webpack-rails-tutorial","homepage":"http://www.reactrails.com","size":1899,"stargazers_count":843,"watchers_count":843,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":19,"forks":159,"open_issues":19,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/287"},"html":{"href":"https://github.com/shakacode/react-webpack-rails-tutorial/pull/287"},"issue":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/287"},"comments":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/shakacode/react-webpack-rails-tutorial/statuses/ccdeaea49a2f40c274e4dcd2e9389610aea3d996"}}}}