{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/testing/pulls/comments/87603740","pull_request_review_id":8211996,"id":87603740,"diff_hunk":"@@ -27,97 +29,69 @@\n     <link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Source+Sans+Pro:400,600\">\n     <style>\n         #logo { margin-bottom: 1rem; }\n-        #graphs {\n-            overflow: hidden;\n-            clear: both;\n-            list-style-type: none;\n-            margin: 0;\n-            padding: 0;\n-        }\n-        #graphs li {\n-            float: left;\n-            border: 1px solid #999;\n-            margin-left: 1%;\n-            margin-bottom: 1rem;\n-            padding: 0.25rem;\n-            max-width: 48%;\n-        }\n-        #graphs li:nth-child(odd) {\n-            clear: both;\n-            margin-left: 0;\n-        }\n-        #graphs img {\n-            max-width: 100%;\n+        main { margin-bottom: 2rem; }\n+        .table-header,\n+        .table-row {\n+          display: flex;\n+          width: 100%;\n+          padding: 2px 10px;\n         }\n-        @media (max-width:850px) {\n-            #graphs li {\n-                float: none;\n-                margin-left: 0;\n-                max-width: 100%;\n-            }\n+        .table-header { font-weight: bold; }\n+        .table-header > div,\n+        .table-row > div {\n+          flex-grow: 1;\n+          width: 100px;\n         }\n+        .table-row:nth-child(even) { background-color: #eee; }\n     </style>\n   </head>\n   <body>\n   <header>\n-     <div class=\"container\" id=\"logo\">\n-         <img src=\"https://nodejs.org/static/images/logos/nodejs-new-white-pantone.png\" alt=\"node.js\">\n-     </div>\n+    <div class=\"container\" id=\"logo\">\n+      <img src=\"https://nodejs.org/static/images/logos/nodejs-new-white-pantone.png\" alt=\"node.js\">\n+    </div>\n   </header>\n-\n-\n   <div id=\"main\">\n-      <div class=\"container\">\n-\n-          <h1>Node.js Code Coverage</h1>\n-\n-  <div class=\"mdl-layout__drawer\">\n-    <nav class=\"mdl-navigation\">\n-        <a class=\"mdl-navigation__link\" href=\"https://github.com/nodejs/node\">Node.js Core</a>\n-    </nav>\n-  </div>\n-\n-  <main class=\"table-container mdl-layout__content\">\n-      <div class=\"page-content\">\n-      <table class=\"mdl-data-table mdl-js-data-table mdl-shadow--2dp\">\n-        <thead>\n-          <tr>\n-            <th>Date</th>\n-            <th>HEAD</th>\n-            <th>JS Coverage</th>\n-            <th>C++ Coverage</th>\n-          </tr>\n-        </thead>\n-      <tbody>\n+    <div class=\"container\">\n+      <h1>Node.js Nightly Code Coverage</h1>\n+      <h3>\n+        Node.js Core&nbsp;&nbsp;<a href=\"https://github.com/nodejs/node\">&rarr;</a>\n+      </h3>\n+      <main>\n+        <div class=\"page-content\">\n+          <div class=\"table\">\n+            <div class=\"table-header\">\n+              <div>Date</div>\n+              <div>HEAD</div>\n+              <div>JS Coverage</div>\n+              <div>C++ Coverage</div>\n+            </div>\n ''')\n   for line in reversed(index_csv):\n     jscov, cxxcov, date, sha = line.split(',')\n+    date = datetime.datetime.strptime(date, '%Y-%m-%dT%H:%M:%S%fZ').strftime(\"%d/%m/%Y %H:%M\")\n     out.write('''\n-          <tr>\n-            <td>{0}</td>\n-            <td><a href=\"https://github.com/nodejs/node/commit/{1}\">{1}</a></td>\n-            <td><a href=\"coverage-{1}/index.html\">{2:05.2f}&nbsp;%</a></td>\n-            <td><a href=\"coverage-{1}/cxxcoverage.html\">{3:05.2f}&nbsp;%</a></td>\n-          </tr>'''.format(date, sha, float(jscov), float(cxxcov)))\n+            <div class=\"table-row\">\n+              <div>{0}</div>\n+              <div><a href=\"https://github.com/nodejs/node/commit/{1}\">{1}</a></div>\n+              <div><a href=\"coverage-{1}/index.html\">{2:05.2f}&nbsp;%</a></div>\n+              <div><a href=\"coverage-{1}/cxxcoverage.html\">{3:05.2f}&nbsp;%</a></div>\n+            </div>'''.format(date, sha, float(jscov), float(cxxcov)))\n   out.write('''\n-          </tbody>\n-        </table>\n+          </div>\n+        </div>\n       </div>\n-   </div>\n- </div>\n-    <script defer src=\"https://code.getmdl.io/1.1.3/material.min.js\"></script>\n+    </div>\n     <footer class=\"no-margin-top\">\n-\n-        <div class=\"linuxfoundation-footer\">\n-            <div class=\"container\">\n-                <a class=\"linuxfoundation-logo\" href=\"http://collabprojects.linuxfoundation.org\">Linux Foundation Collaborative Projects</a>\n-\n-                <p>� 2016 Node.js Foundation. All Rights Reserved. Portions of this site originally � 2016 Joyent. </p>\n-                <p>Node.js is a trademark of Joyent, Inc. and is used with its permission. Please review the <a href=\"https://nodejs.org/static/documents/trademark-policy.pdf\">Trademark Guidelines of the Node.js Foundation</a>.</p>\n-                <p>Linux Foundation is a registered trademark of The Linux Foundation.</p>\n-                <p>Linux is a registered <a href=\"http://www.linuxfoundation.org/programs/legal/trademark\" title=\"Linux Mark Institute\">trademark</a> of Linus Torvalds.</p>\n-            </div>\n+      <div class=\"linuxfoundation-footer\">\n+        <div class=\"container\">\n+          <a class=\"linuxfoundation-logo\" href=\"http://collabprojects.linuxfoundation.org\">Linux Foundation Collaborative Projects</a>\n+          <p>&copy; 2016 Node.js Foundation. All Rights Reserved. Portions of this site originally &copy; 2016 Joyent. </p>","path":"coverage/generate-index-html.py","position":146,"original_position":145,"commit_id":"562885a35fdc1bb8e305ca322c975449324e2b88","original_commit_id":"261521831ab1877b7fae50444058406f3dd5a2fc","user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"body":"Seems though that the benchmarking page has the same header.  Looking at the files when I download them, the difference may be an extra character so what I think it happening is that some sort of escape is being lost since we print out the string as opposed to it just being in the file.  \r\n\r\nHaving said all that I think instead of figure out how to escape that character, the @copy; is much clearer when looking at the source so I'd prefer to go with that. ","created_at":"2016-11-11T15:18:09Z","updated_at":"2016-11-11T15:18:09Z","html_url":"https://github.com/nodejs/testing/pull/41#discussion_r87603740","pull_request_url":"https://api.github.com/repos/nodejs/testing/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/nodejs/testing/pulls/comments/87603740"},"html":{"href":"https://github.com/nodejs/testing/pull/41#discussion_r87603740"},"pull_request":{"href":"https://api.github.com/repos/nodejs/testing/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/testing/pulls/41","id":93244151,"html_url":"https://github.com/nodejs/testing/pull/41","diff_url":"https://github.com/nodejs/testing/pull/41.diff","patch_url":"https://github.com/nodejs/testing/pull/41.patch","issue_url":"https://api.github.com/repos/nodejs/testing/issues/41","number":41,"state":"open","locked":false,"title":"Update coverage page styles","user":{"login":"ryanmurakami","id":767105,"avatar_url":"https://avatars.githubusercontent.com/u/767105?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanmurakami","html_url":"https://github.com/ryanmurakami","followers_url":"https://api.github.com/users/ryanmurakami/followers","following_url":"https://api.github.com/users/ryanmurakami/following{/other_user}","gists_url":"https://api.github.com/users/ryanmurakami/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanmurakami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanmurakami/subscriptions","organizations_url":"https://api.github.com/users/ryanmurakami/orgs","repos_url":"https://api.github.com/users/ryanmurakami/repos","events_url":"https://api.github.com/users/ryanmurakami/events{/privacy}","received_events_url":"https://api.github.com/users/ryanmurakami/received_events","type":"User","site_admin":false},"body":"Updating some styling and formatting on the cover page. This is was suggested from https://github.com/nodejs/nodejs.org/issues/1019\r\n\r\nHere are some of the changes:\r\n- Changed \"Node.js Core\" header to non-link, increase the size, and have the link to the repo beside the title. Perhaps you could use an icon like [this](http://fontawesome.io/icon/external-link/).\r\n- Added \"Nightly\" to \"Node.js Code Coverage\"\r\n- Formatted the date/time to make it easier to read\r\n- Modified table to make it easier to read\r\n\r\nHere's a screenshot on Chrome:\r\n<img width=\"1142\" alt=\"screen shot 2016-11-10 at 2 10 17 pm\" src=\"https://cloud.githubusercontent.com/assets/767105/20197006/2b24fa10-a752-11e6-9131-3a8cbc50bd17.png\">\r\n","created_at":"2016-11-10T22:30:59Z","updated_at":"2016-11-11T15:18:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"607fc7f71fd8ee01d2d3f46b26742712b79896c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/testing/pulls/41/commits","review_comments_url":"https://api.github.com/repos/nodejs/testing/pulls/41/comments","review_comment_url":"https://api.github.com/repos/nodejs/testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/testing/issues/41/comments","statuses_url":"https://api.github.com/repos/nodejs/testing/statuses/562885a35fdc1bb8e305ca322c975449324e2b88","head":{"label":"ryanmurakami:master","ref":"master","sha":"562885a35fdc1bb8e305ca322c975449324e2b88","user":{"login":"ryanmurakami","id":767105,"avatar_url":"https://avatars.githubusercontent.com/u/767105?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanmurakami","html_url":"https://github.com/ryanmurakami","followers_url":"https://api.github.com/users/ryanmurakami/followers","following_url":"https://api.github.com/users/ryanmurakami/following{/other_user}","gists_url":"https://api.github.com/users/ryanmurakami/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanmurakami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanmurakami/subscriptions","organizations_url":"https://api.github.com/users/ryanmurakami/orgs","repos_url":"https://api.github.com/users/ryanmurakami/repos","events_url":"https://api.github.com/users/ryanmurakami/events{/privacy}","received_events_url":"https://api.github.com/users/ryanmurakami/received_events","type":"User","site_admin":false},"repo":{"id":73411964,"name":"testing","full_name":"ryanmurakami/testing","owner":{"login":"ryanmurakami","id":767105,"avatar_url":"https://avatars.githubusercontent.com/u/767105?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanmurakami","html_url":"https://github.com/ryanmurakami","followers_url":"https://api.github.com/users/ryanmurakami/followers","following_url":"https://api.github.com/users/ryanmurakami/following{/other_user}","gists_url":"https://api.github.com/users/ryanmurakami/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanmurakami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanmurakami/subscriptions","organizations_url":"https://api.github.com/users/ryanmurakami/orgs","repos_url":"https://api.github.com/users/ryanmurakami/repos","events_url":"https://api.github.com/users/ryanmurakami/events{/privacy}","received_events_url":"https://api.github.com/users/ryanmurakami/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanmurakami/testing","description":"Testing Working Group","fork":true,"url":"https://api.github.com/repos/ryanmurakami/testing","forks_url":"https://api.github.com/repos/ryanmurakami/testing/forks","keys_url":"https://api.github.com/repos/ryanmurakami/testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanmurakami/testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanmurakami/testing/teams","hooks_url":"https://api.github.com/repos/ryanmurakami/testing/hooks","issue_events_url":"https://api.github.com/repos/ryanmurakami/testing/issues/events{/number}","events_url":"https://api.github.com/repos/ryanmurakami/testing/events","assignees_url":"https://api.github.com/repos/ryanmurakami/testing/assignees{/user}","branches_url":"https://api.github.com/repos/ryanmurakami/testing/branches{/branch}","tags_url":"https://api.github.com/repos/ryanmurakami/testing/tags","blobs_url":"https://api.github.com/repos/ryanmurakami/testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanmurakami/testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanmurakami/testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanmurakami/testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanmurakami/testing/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanmurakami/testing/languages","stargazers_url":"https://api.github.com/repos/ryanmurakami/testing/stargazers","contributors_url":"https://api.github.com/repos/ryanmurakami/testing/contributors","subscribers_url":"https://api.github.com/repos/ryanmurakami/testing/subscribers","subscription_url":"https://api.github.com/repos/ryanmurakami/testing/subscription","commits_url":"https://api.github.com/repos/ryanmurakami/testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanmurakami/testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanmurakami/testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanmurakami/testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanmurakami/testing/contents/{+path}","compare_url":"https://api.github.com/repos/ryanmurakami/testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanmurakami/testing/merges","archive_url":"https://api.github.com/repos/ryanmurakami/testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanmurakami/testing/downloads","issues_url":"https://api.github.com/repos/ryanmurakami/testing/issues{/number}","pulls_url":"https://api.github.com/repos/ryanmurakami/testing/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanmurakami/testing/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanmurakami/testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanmurakami/testing/labels{/name}","releases_url":"https://api.github.com/repos/ryanmurakami/testing/releases{/id}","deployments_url":"https://api.github.com/repos/ryanmurakami/testing/deployments","created_at":"2016-11-10T18:58:52Z","updated_at":"2016-11-10T18:58:53Z","pushed_at":"2016-11-10T23:27:26Z","git_url":"git://github.com/ryanmurakami/testing.git","ssh_url":"git@github.com:ryanmurakami/testing.git","clone_url":"https://github.com/ryanmurakami/testing.git","svn_url":"https://github.com/ryanmurakami/testing","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"387677ce0af570e18917bc75432a78af87d241ce","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":49273232,"name":"testing","full_name":"nodejs/testing","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/testing","description":"Testing Working Group","fork":false,"url":"https://api.github.com/repos/nodejs/testing","forks_url":"https://api.github.com/repos/nodejs/testing/forks","keys_url":"https://api.github.com/repos/nodejs/testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/testing/teams","hooks_url":"https://api.github.com/repos/nodejs/testing/hooks","issue_events_url":"https://api.github.com/repos/nodejs/testing/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/testing/events","assignees_url":"https://api.github.com/repos/nodejs/testing/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/testing/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/testing/tags","blobs_url":"https://api.github.com/repos/nodejs/testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/testing/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/testing/languages","stargazers_url":"https://api.github.com/repos/nodejs/testing/stargazers","contributors_url":"https://api.github.com/repos/nodejs/testing/contributors","subscribers_url":"https://api.github.com/repos/nodejs/testing/subscribers","subscription_url":"https://api.github.com/repos/nodejs/testing/subscription","commits_url":"https://api.github.com/repos/nodejs/testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/testing/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/testing/merges","archive_url":"https://api.github.com/repos/nodejs/testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/testing/downloads","issues_url":"https://api.github.com/repos/nodejs/testing/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/testing/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/testing/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/testing/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/testing/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/testing/deployments","created_at":"2016-01-08T13:22:04Z","updated_at":"2016-11-01T01:14:00Z","pushed_at":"2016-11-10T23:27:27Z","git_url":"git://github.com/nodejs/testing.git","ssh_url":"git@github.com:nodejs/testing.git","clone_url":"https://github.com/nodejs/testing.git","svn_url":"https://github.com/nodejs/testing","homepage":null,"size":42,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":15,"forks":9,"open_issues":15,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/testing/pulls/41"},"html":{"href":"https://github.com/nodejs/testing/pull/41"},"issue":{"href":"https://api.github.com/repos/nodejs/testing/issues/41"},"comments":{"href":"https://api.github.com/repos/nodejs/testing/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/testing/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/testing/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/testing/statuses/562885a35fdc1bb8e305ca322c975449324e2b88"}}}}
{"actor":{"display_login":"mhdawson"}}