{"action":"created","comment":{"url":"https://api.github.com/repos/libqueso/queso/pulls/comments/92505850","pull_request_review_id":13023148,"id":92505850,"diff_hunk":"@@ -512,7 +511,6 @@ libqueso_include_HEADERS += contrib/getpot/getpot.h\n \n nodist_libqueso_include_HEADERS =\n nodist_libqueso_include_HEADERS += $(top_builddir)/config_queso.h\n-nodist_libqueso_include_HEADERS += $(top_builddir)/src/core/inc/queso.h","path":"src/Makefile.am","position":20,"original_position":20,"commit_id":"f5524c4e45c63e7e7658c82c1b72bb396e78bc8f","original_commit_id":"f5524c4e45c63e7e7658c82c1b72bb396e78bc8f","user":{"login":"dmcdougall","id":328518,"avatar_url":"https://avatars.githubusercontent.com/u/328518?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcdougall","html_url":"https://github.com/dmcdougall","followers_url":"https://api.github.com/users/dmcdougall/followers","following_url":"https://api.github.com/users/dmcdougall/following{/other_user}","gists_url":"https://api.github.com/users/dmcdougall/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcdougall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcdougall/subscriptions","organizations_url":"https://api.github.com/users/dmcdougall/orgs","repos_url":"https://api.github.com/users/dmcdougall/repos","events_url":"https://api.github.com/users/dmcdougall/events{/privacy}","received_events_url":"https://api.github.com/users/dmcdougall/received_events","type":"User","site_admin":false},"body":"Oh no, I misunderstood.  Of course we don't ship `config_queso.h` in our tarballs because it's generated by the build system when the user does `./configure && make install`.\r\n\r\nAs for `queso.h`, I can verify it *is* in the latest (v0.56.0) tarball, so it's not clear to me why the `nodist_` prefix had no effect.","created_at":"2016-12-14T22:35:34Z","updated_at":"2016-12-14T22:35:34Z","html_url":"https://github.com/libqueso/queso/pull/495#discussion_r92505850","pull_request_url":"https://api.github.com/repos/libqueso/queso/pulls/495","_links":{"self":{"href":"https://api.github.com/repos/libqueso/queso/pulls/comments/92505850"},"html":{"href":"https://github.com/libqueso/queso/pull/495#discussion_r92505850"},"pull_request":{"href":"https://api.github.com/repos/libqueso/queso/pulls/495"}}},"pull_request":{"url":"https://api.github.com/repos/libqueso/queso/pulls/495","id":97857553,"html_url":"https://github.com/libqueso/queso/pull/495","diff_url":"https://github.com/libqueso/queso/pull/495.diff","patch_url":"https://github.com/libqueso/queso/pull/495.patch","issue_url":"https://api.github.com/repos/libqueso/queso/issues/495","number":495,"state":"open","locked":false,"title":"Consolidate configured headers #494","user":{"login":"briadam","id":3729877,"avatar_url":"https://avatars.githubusercontent.com/u/3729877?v=3","gravatar_id":"","url":"https://api.github.com/users/briadam","html_url":"https://github.com/briadam","followers_url":"https://api.github.com/users/briadam/followers","following_url":"https://api.github.com/users/briadam/following{/other_user}","gists_url":"https://api.github.com/users/briadam/gists{/gist_id}","starred_url":"https://api.github.com/users/briadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briadam/subscriptions","organizations_url":"https://api.github.com/users/briadam/orgs","repos_url":"https://api.github.com/users/briadam/repos","events_url":"https://api.github.com/users/briadam/events{/privacy}","received_events_url":"https://api.github.com/users/briadam/received_events","type":"User","site_admin":false},"body":"Proposal to address #494.  Needs careful scrutiny as my autotools skills are super rusty.  I did verify that make install, and make dist all still work, but know my build environment isn't synced with yours, so will rely on Travis for builds.\r\n\r\nOne thing I wasn't sure of is if you want the TPL-specific AC_DEFINES in their .m4 macros vs in config_environment.m4; they seemed to kind of straddle TPL information vs. QUESO-specific defines.\r\n\r\nCommit log:\r\n\r\nMake queso.h a static, deprecated header that depends on a single\r\nconfigured config_queso.h.  For now, queso.h is still packaged and\r\ninstalled.  The various definitions in queso.h.in are dealt with as\r\nfollows:\r\n\r\n```\r\nQUESO_MAJOR_VERSION: def in config_queso.h in terms of GENERIC_MAJOR_VERSION\r\nQUESO_MINOR_VERSION: def in config_queso.h in terms of GENERIC_MINOR_VERSION\r\nQUESO_MICRO_VERSION: def in config_queso.h in terms of GENERIC_MICRO_VERSION\r\n\r\nQUESO_BUILD_USER: already defined in config_queso.h\r\nQUESO_BUILD_ARCH: already defined in config_queso.h\r\nQUESO_BUILD_HOST: already defined in config_queso.h\r\nQUESO_BUILD_DATE: already defined in config_queso.h\r\nQUESO_BUILD_VERSION: already defined in config_queso.h\r\n\r\nQUESO_LIB_VERSION: deprecated; use QUESO_VERSION instead\r\nQUESO_LIB_RELEASE: deprecated; use QUESO_BUILD_DEVSTATUS instead\r\n\r\nQUESO_CXX: def in config_queso.h in terms of CXX\r\nQUESO_CXXFLAGS: def in config_queso.h in terms of CXXFLAGS\r\n\r\nQUESO_TRILINOS_DIR: def in config_queso.h in terms of TRILINOS_HOME\r\nQUESO_GSL_DIR: def in config_queso.h in terms of GSL_LIBS\r\nQUESO_GRVY_DIR: def in config_queso.h in terms of GRVY_PREFIX\r\nQUESO_GLPK_DIR: def in config_queso.h in terms of GLPK_PREFIX\r\nQUESO_HDF5_DIR: def in config_queso.h in terms of HDF5_PREFIX\r\n```","created_at":"2016-12-13T23:25:55Z","updated_at":"2016-12-14T22:35:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d0cb94a01175354e43128bfccdce922e17ff9cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libqueso/queso/pulls/495/commits","review_comments_url":"https://api.github.com/repos/libqueso/queso/pulls/495/comments","review_comment_url":"https://api.github.com/repos/libqueso/queso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libqueso/queso/issues/495/comments","statuses_url":"https://api.github.com/repos/libqueso/queso/statuses/f5524c4e45c63e7e7658c82c1b72bb396e78bc8f","head":{"label":"briadam:conf_headers_494","ref":"conf_headers_494","sha":"f5524c4e45c63e7e7658c82c1b72bb396e78bc8f","user":{"login":"briadam","id":3729877,"avatar_url":"https://avatars.githubusercontent.com/u/3729877?v=3","gravatar_id":"","url":"https://api.github.com/users/briadam","html_url":"https://github.com/briadam","followers_url":"https://api.github.com/users/briadam/followers","following_url":"https://api.github.com/users/briadam/following{/other_user}","gists_url":"https://api.github.com/users/briadam/gists{/gist_id}","starred_url":"https://api.github.com/users/briadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briadam/subscriptions","organizations_url":"https://api.github.com/users/briadam/orgs","repos_url":"https://api.github.com/users/briadam/repos","events_url":"https://api.github.com/users/briadam/events{/privacy}","received_events_url":"https://api.github.com/users/briadam/received_events","type":"User","site_admin":false},"repo":{"id":31937808,"name":"queso","full_name":"briadam/queso","owner":{"login":"briadam","id":3729877,"avatar_url":"https://avatars.githubusercontent.com/u/3729877?v=3","gravatar_id":"","url":"https://api.github.com/users/briadam","html_url":"https://github.com/briadam","followers_url":"https://api.github.com/users/briadam/followers","following_url":"https://api.github.com/users/briadam/following{/other_user}","gists_url":"https://api.github.com/users/briadam/gists{/gist_id}","starred_url":"https://api.github.com/users/briadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briadam/subscriptions","organizations_url":"https://api.github.com/users/briadam/orgs","repos_url":"https://api.github.com/users/briadam/repos","events_url":"https://api.github.com/users/briadam/events{/privacy}","received_events_url":"https://api.github.com/users/briadam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briadam/queso","description":"QUESO is a C++ library for doing uncertainty quantification.  QUESO stands for Quantification of Uncertainty for Estimation, Simulation and Optimization.","fork":true,"url":"https://api.github.com/repos/briadam/queso","forks_url":"https://api.github.com/repos/briadam/queso/forks","keys_url":"https://api.github.com/repos/briadam/queso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briadam/queso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briadam/queso/teams","hooks_url":"https://api.github.com/repos/briadam/queso/hooks","issue_events_url":"https://api.github.com/repos/briadam/queso/issues/events{/number}","events_url":"https://api.github.com/repos/briadam/queso/events","assignees_url":"https://api.github.com/repos/briadam/queso/assignees{/user}","branches_url":"https://api.github.com/repos/briadam/queso/branches{/branch}","tags_url":"https://api.github.com/repos/briadam/queso/tags","blobs_url":"https://api.github.com/repos/briadam/queso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briadam/queso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briadam/queso/git/refs{/sha}","trees_url":"https://api.github.com/repos/briadam/queso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briadam/queso/statuses/{sha}","languages_url":"https://api.github.com/repos/briadam/queso/languages","stargazers_url":"https://api.github.com/repos/briadam/queso/stargazers","contributors_url":"https://api.github.com/repos/briadam/queso/contributors","subscribers_url":"https://api.github.com/repos/briadam/queso/subscribers","subscription_url":"https://api.github.com/repos/briadam/queso/subscription","commits_url":"https://api.github.com/repos/briadam/queso/commits{/sha}","git_commits_url":"https://api.github.com/repos/briadam/queso/git/commits{/sha}","comments_url":"https://api.github.com/repos/briadam/queso/comments{/number}","issue_comment_url":"https://api.github.com/repos/briadam/queso/issues/comments{/number}","contents_url":"https://api.github.com/repos/briadam/queso/contents/{+path}","compare_url":"https://api.github.com/repos/briadam/queso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briadam/queso/merges","archive_url":"https://api.github.com/repos/briadam/queso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briadam/queso/downloads","issues_url":"https://api.github.com/repos/briadam/queso/issues{/number}","pulls_url":"https://api.github.com/repos/briadam/queso/pulls{/number}","milestones_url":"https://api.github.com/repos/briadam/queso/milestones{/number}","notifications_url":"https://api.github.com/repos/briadam/queso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briadam/queso/labels{/name}","releases_url":"https://api.github.com/repos/briadam/queso/releases{/id}","deployments_url":"https://api.github.com/repos/briadam/queso/deployments","created_at":"2015-03-10T04:08:38Z","updated_at":"2015-04-15T06:56:52Z","pushed_at":"2016-12-13T23:12:14Z","git_url":"git://github.com/briadam/queso.git","ssh_url":"git@github.com:briadam/queso.git","clone_url":"https://github.com/briadam/queso.git","svn_url":"https://github.com/briadam/queso","homepage":"","size":227209,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"libqueso:hotfix-0.56.1","ref":"hotfix-0.56.1","sha":"38d33fbd316fd434119e2e45b33d787617dc16a0","user":{"login":"libqueso","id":5255874,"avatar_url":"https://avatars.githubusercontent.com/u/5255874?v=3","gravatar_id":"","url":"https://api.github.com/users/libqueso","html_url":"https://github.com/libqueso","followers_url":"https://api.github.com/users/libqueso/followers","following_url":"https://api.github.com/users/libqueso/following{/other_user}","gists_url":"https://api.github.com/users/libqueso/gists{/gist_id}","starred_url":"https://api.github.com/users/libqueso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libqueso/subscriptions","organizations_url":"https://api.github.com/users/libqueso/orgs","repos_url":"https://api.github.com/users/libqueso/repos","events_url":"https://api.github.com/users/libqueso/events{/privacy}","received_events_url":"https://api.github.com/users/libqueso/received_events","type":"Organization","site_admin":false},"repo":{"id":12491052,"name":"queso","full_name":"libqueso/queso","owner":{"login":"libqueso","id":5255874,"avatar_url":"https://avatars.githubusercontent.com/u/5255874?v=3","gravatar_id":"","url":"https://api.github.com/users/libqueso","html_url":"https://github.com/libqueso","followers_url":"https://api.github.com/users/libqueso/followers","following_url":"https://api.github.com/users/libqueso/following{/other_user}","gists_url":"https://api.github.com/users/libqueso/gists{/gist_id}","starred_url":"https://api.github.com/users/libqueso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libqueso/subscriptions","organizations_url":"https://api.github.com/users/libqueso/orgs","repos_url":"https://api.github.com/users/libqueso/repos","events_url":"https://api.github.com/users/libqueso/events{/privacy}","received_events_url":"https://api.github.com/users/libqueso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libqueso/queso","description":"QUESO is a C++ library for doing uncertainty quantification.  QUESO stands for Quantification of Uncertainty for Estimation, Simulation and Optimization.","fork":false,"url":"https://api.github.com/repos/libqueso/queso","forks_url":"https://api.github.com/repos/libqueso/queso/forks","keys_url":"https://api.github.com/repos/libqueso/queso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libqueso/queso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libqueso/queso/teams","hooks_url":"https://api.github.com/repos/libqueso/queso/hooks","issue_events_url":"https://api.github.com/repos/libqueso/queso/issues/events{/number}","events_url":"https://api.github.com/repos/libqueso/queso/events","assignees_url":"https://api.github.com/repos/libqueso/queso/assignees{/user}","branches_url":"https://api.github.com/repos/libqueso/queso/branches{/branch}","tags_url":"https://api.github.com/repos/libqueso/queso/tags","blobs_url":"https://api.github.com/repos/libqueso/queso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libqueso/queso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libqueso/queso/git/refs{/sha}","trees_url":"https://api.github.com/repos/libqueso/queso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libqueso/queso/statuses/{sha}","languages_url":"https://api.github.com/repos/libqueso/queso/languages","stargazers_url":"https://api.github.com/repos/libqueso/queso/stargazers","contributors_url":"https://api.github.com/repos/libqueso/queso/contributors","subscribers_url":"https://api.github.com/repos/libqueso/queso/subscribers","subscription_url":"https://api.github.com/repos/libqueso/queso/subscription","commits_url":"https://api.github.com/repos/libqueso/queso/commits{/sha}","git_commits_url":"https://api.github.com/repos/libqueso/queso/git/commits{/sha}","comments_url":"https://api.github.com/repos/libqueso/queso/comments{/number}","issue_comment_url":"https://api.github.com/repos/libqueso/queso/issues/comments{/number}","contents_url":"https://api.github.com/repos/libqueso/queso/contents/{+path}","compare_url":"https://api.github.com/repos/libqueso/queso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libqueso/queso/merges","archive_url":"https://api.github.com/repos/libqueso/queso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libqueso/queso/downloads","issues_url":"https://api.github.com/repos/libqueso/queso/issues{/number}","pulls_url":"https://api.github.com/repos/libqueso/queso/pulls{/number}","milestones_url":"https://api.github.com/repos/libqueso/queso/milestones{/number}","notifications_url":"https://api.github.com/repos/libqueso/queso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libqueso/queso/labels{/name}","releases_url":"https://api.github.com/repos/libqueso/queso/releases{/id}","deployments_url":"https://api.github.com/repos/libqueso/queso/deployments","created_at":"2013-08-30T16:47:00Z","updated_at":"2016-11-30T14:55:27Z","pushed_at":"2016-12-13T23:25:55Z","git_url":"git://github.com/libqueso/queso.git","ssh_url":"git@github.com:libqueso/queso.git","clone_url":"https://github.com/libqueso/queso.git","svn_url":"https://github.com/libqueso/queso","homepage":"","size":294960,"stargazers_count":32,"watchers_count":32,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":59,"forks":26,"open_issues":59,"watchers":32,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/libqueso/queso/pulls/495"},"html":{"href":"https://github.com/libqueso/queso/pull/495"},"issue":{"href":"https://api.github.com/repos/libqueso/queso/issues/495"},"comments":{"href":"https://api.github.com/repos/libqueso/queso/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/libqueso/queso/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/libqueso/queso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libqueso/queso/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/libqueso/queso/statuses/f5524c4e45c63e7e7658c82c1b72bb396e78bc8f"}}}}
{"actor":{"display_login":"dmcdougall"}}