{"action":"closed","issue":{"url":"https://api.github.com/repos/syncthing/syncthing/issues/3165","repository_url":"https://api.github.com/repos/syncthing/syncthing","labels_url":"https://api.github.com/repos/syncthing/syncthing/issues/3165/labels{/name}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/3165/comments","events_url":"https://api.github.com/repos/syncthing/syncthing/issues/3165/events","html_url":"https://github.com/syncthing/syncthing/issues/3165","id":156244088,"number":3165,"title":"Syncthing uses incorrect timezone for Last-Modified header","user":{"login":"canton7","id":568104,"avatar_url":"https://avatars.githubusercontent.com/u/568104?v=3","gravatar_id":"","url":"https://api.github.com/users/canton7","html_url":"https://github.com/canton7","followers_url":"https://api.github.com/users/canton7/followers","following_url":"https://api.github.com/users/canton7/following{/other_user}","gists_url":"https://api.github.com/users/canton7/gists{/gist_id}","starred_url":"https://api.github.com/users/canton7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canton7/subscriptions","organizations_url":"https://api.github.com/users/canton7/orgs","repos_url":"https://api.github.com/users/canton7/repos","events_url":"https://api.github.com/users/canton7/events{/privacy}","received_events_url":"https://api.github.com/users/canton7/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/syncthing/syncthing/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-23T10:03:42Z","updated_at":"2016-05-23T12:16:17Z","closed_at":"2016-05-23T12:16:17Z","body":"Syncthing sets the Last-Modified header on static assets to the time at which the config was last committed. However, it sets a local time, whereas the docs for `http.TimeFormat` specify that the time must be UTC.\r\n\r\nThis can result in a Last-Modified time in the future for timezones ahead of GMT, or a time before the config was committed for timezones behind GMT.\r\n\r\nThis is probably partially responsible for the reports of the UI showing \"Unknown Device\" with an empty folder list when people upgrade to 0.13. I say \"partially\" because I know there have been reports from people ahead of GMT, so something else is at play as well here....\r\n\r\nSee [here](https://github.com/syncthing/syncthing/blob/4bc2b3f3690c755a8ffb22862915e286bdc24702/cmd/syncthing/gui.go#L1257), [here](https://github.com/syncthing/syncthing/blob/4bc2b3f3690c755a8ffb22862915e286bdc24702/cmd/syncthing/gui.go#L1300), and [here](https://github.com/syncthing/syncthing/blob/4bc2b3f3690c755a8ffb22862915e286bdc24702/cmd/syncthing/gui.go#L301).\r\n"}}
{"actor":{"display_login":"st-review"}}