{"action":"created","comment":{"url":"https://api.github.com/repos/brkt/brkt-cli/pulls/comments/50163817","id":50163817,"diff_hunk":"@@ -972,6 +972,10 @@ def encrypt(aws_svc, enc_svc_cls, image_id, encryptor_ami, brkt_env=None,\n             log.warn(\"AMI must have root_device_name in block_device_mapping \"\n                     \"in order to preserve guest OS license information\")\n             legacy = True\n+    if (guest_image.root_device_name != \"/dev/sda1\"):\n+        log.warn(\"The root device for the guest AMI should be /dev/sda1 \"","path":"brkt_cli/encrypt_ami.py","position":5,"original_position":5,"commit_id":"f09e7e3225e539a849489cf400b546bdde095666","original_commit_id":"f09e7e3225e539a849489cf400b546bdde095666","user":{"login":"bburtin","id":5264133,"avatar_url":"https://avatars.githubusercontent.com/u/5264133?v=3","gravatar_id":"","url":"https://api.github.com/users/bburtin","html_url":"https://github.com/bburtin","followers_url":"https://api.github.com/users/bburtin/followers","following_url":"https://api.github.com/users/bburtin/following{/other_user}","gists_url":"https://api.github.com/users/bburtin/gists{/gist_id}","starred_url":"https://api.github.com/users/bburtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bburtin/subscriptions","organizations_url":"https://api.github.com/users/bburtin/orgs","repos_url":"https://api.github.com/users/bburtin/repos","events_url":"https://api.github.com/users/bburtin/events{/privacy}","received_events_url":"https://api.github.com/users/bburtin/received_events","type":"User","site_admin":false},"body":"I would word it like \"Operating system license information will not be preserved because the root disk is <root_device_name> instead of /dev/sda1.\"  The current wording makes me think \"something is wrong, but we're proceeding anyway.\"  That said, I'm anything but an expert in device mappings and building AMIs.","created_at":"2016-01-19T19:42:33Z","updated_at":"2016-01-19T19:42:33Z","html_url":"https://github.com/brkt/brkt-cli/pull/123#discussion_r50163817","pull_request_url":"https://api.github.com/repos/brkt/brkt-cli/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/brkt/brkt-cli/pulls/comments/50163817"},"html":{"href":"https://github.com/brkt/brkt-cli/pull/123#discussion_r50163817"},"pull_request":{"href":"https://api.github.com/repos/brkt/brkt-cli/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/brkt/brkt-cli/pulls/123","id":56510918,"html_url":"https://github.com/brkt/brkt-cli/pull/123","diff_url":"https://github.com/brkt/brkt-cli/pull/123.diff","patch_url":"https://github.com/brkt/brkt-cli/pull/123.patch","issue_url":"https://api.github.com/repos/brkt/brkt-cli/issues/123","number":123,"state":"open","locked":false,"title":"Metavisor requires the root disk to be attached at \"/dev/sda1\".","user":{"login":"apoorva-jindal","id":16783793,"avatar_url":"https://avatars.githubusercontent.com/u/16783793?v=3","gravatar_id":"","url":"https://api.github.com/users/apoorva-jindal","html_url":"https://github.com/apoorva-jindal","followers_url":"https://api.github.com/users/apoorva-jindal/followers","following_url":"https://api.github.com/users/apoorva-jindal/following{/other_user}","gists_url":"https://api.github.com/users/apoorva-jindal/gists{/gist_id}","starred_url":"https://api.github.com/users/apoorva-jindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoorva-jindal/subscriptions","organizations_url":"https://api.github.com/users/apoorva-jindal/orgs","repos_url":"https://api.github.com/users/apoorva-jindal/repos","events_url":"https://api.github.com/users/apoorva-jindal/events{/privacy}","received_events_url":"https://api.github.com/users/apoorva-jindal/received_events","type":"User","site_admin":false},"body":"If the guest AMI's root disk is attached at at different\r\nattach-point, then treat as legacy mode which will use\r\nthe metavisor instance to create the AMI instead of the guest\r\ninstance. However, for such AMIs, the guest license information\r\nwill be lost.\r\n\r\nTesting.\r\nWorks for Centos 7.1 AMI ami-7bc3f94b which attaches root disk\r\nat /dev/sda.","created_at":"2016-01-19T19:10:52Z","updated_at":"2016-01-19T19:42:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fde3e5237db6afea042d101667fd4fc856299c12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brkt/brkt-cli/pulls/123/commits","review_comments_url":"https://api.github.com/repos/brkt/brkt-cli/pulls/123/comments","review_comment_url":"https://api.github.com/repos/brkt/brkt-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brkt/brkt-cli/issues/123/comments","statuses_url":"https://api.github.com/repos/brkt/brkt-cli/statuses/f09e7e3225e539a849489cf400b546bdde095666","head":{"label":"brkt:different-root-attachment","ref":"different-root-attachment","sha":"f09e7e3225e539a849489cf400b546bdde095666","user":{"login":"brkt","id":2963083,"avatar_url":"https://avatars.githubusercontent.com/u/2963083?v=3","gravatar_id":"","url":"https://api.github.com/users/brkt","html_url":"https://github.com/brkt","followers_url":"https://api.github.com/users/brkt/followers","following_url":"https://api.github.com/users/brkt/following{/other_user}","gists_url":"https://api.github.com/users/brkt/gists{/gist_id}","starred_url":"https://api.github.com/users/brkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brkt/subscriptions","organizations_url":"https://api.github.com/users/brkt/orgs","repos_url":"https://api.github.com/users/brkt/repos","events_url":"https://api.github.com/users/brkt/events{/privacy}","received_events_url":"https://api.github.com/users/brkt/received_events","type":"Organization","site_admin":false},"repo":{"id":42469221,"name":"brkt-cli","full_name":"brkt/brkt-cli","owner":{"login":"brkt","id":2963083,"avatar_url":"https://avatars.githubusercontent.com/u/2963083?v=3","gravatar_id":"","url":"https://api.github.com/users/brkt","html_url":"https://github.com/brkt","followers_url":"https://api.github.com/users/brkt/followers","following_url":"https://api.github.com/users/brkt/following{/other_user}","gists_url":"https://api.github.com/users/brkt/gists{/gist_id}","starred_url":"https://api.github.com/users/brkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brkt/subscriptions","organizations_url":"https://api.github.com/users/brkt/orgs","repos_url":"https://api.github.com/users/brkt/repos","events_url":"https://api.github.com/users/brkt/events{/privacy}","received_events_url":"https://api.github.com/users/brkt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brkt/brkt-cli","description":"","fork":false,"url":"https://api.github.com/repos/brkt/brkt-cli","forks_url":"https://api.github.com/repos/brkt/brkt-cli/forks","keys_url":"https://api.github.com/repos/brkt/brkt-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brkt/brkt-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brkt/brkt-cli/teams","hooks_url":"https://api.github.com/repos/brkt/brkt-cli/hooks","issue_events_url":"https://api.github.com/repos/brkt/brkt-cli/issues/events{/number}","events_url":"https://api.github.com/repos/brkt/brkt-cli/events","assignees_url":"https://api.github.com/repos/brkt/brkt-cli/assignees{/user}","branches_url":"https://api.github.com/repos/brkt/brkt-cli/branches{/branch}","tags_url":"https://api.github.com/repos/brkt/brkt-cli/tags","blobs_url":"https://api.github.com/repos/brkt/brkt-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brkt/brkt-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brkt/brkt-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/brkt/brkt-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brkt/brkt-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/brkt/brkt-cli/languages","stargazers_url":"https://api.github.com/repos/brkt/brkt-cli/stargazers","contributors_url":"https://api.github.com/repos/brkt/brkt-cli/contributors","subscribers_url":"https://api.github.com/repos/brkt/brkt-cli/subscribers","subscription_url":"https://api.github.com/repos/brkt/brkt-cli/subscription","commits_url":"https://api.github.com/repos/brkt/brkt-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/brkt/brkt-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/brkt/brkt-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/brkt/brkt-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/brkt/brkt-cli/contents/{+path}","compare_url":"https://api.github.com/repos/brkt/brkt-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brkt/brkt-cli/merges","archive_url":"https://api.github.com/repos/brkt/brkt-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brkt/brkt-cli/downloads","issues_url":"https://api.github.com/repos/brkt/brkt-cli/issues{/number}","pulls_url":"https://api.github.com/repos/brkt/brkt-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/brkt/brkt-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/brkt/brkt-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brkt/brkt-cli/labels{/name}","releases_url":"https://api.github.com/repos/brkt/brkt-cli/releases{/id}","created_at":"2015-09-14T18:39:20Z","updated_at":"2016-01-11T22:20:48Z","pushed_at":"2016-01-19T19:10:53Z","git_url":"git://github.com/brkt/brkt-cli.git","ssh_url":"git@github.com:brkt/brkt-cli.git","clone_url":"https://github.com/brkt/brkt-cli.git","svn_url":"https://github.com/brkt/brkt-cli","homepage":null,"size":349,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"brkt:master","ref":"master","sha":"44da20c0b63f26a37edf77f44f7c877d6e6073af","user":{"login":"brkt","id":2963083,"avatar_url":"https://avatars.githubusercontent.com/u/2963083?v=3","gravatar_id":"","url":"https://api.github.com/users/brkt","html_url":"https://github.com/brkt","followers_url":"https://api.github.com/users/brkt/followers","following_url":"https://api.github.com/users/brkt/following{/other_user}","gists_url":"https://api.github.com/users/brkt/gists{/gist_id}","starred_url":"https://api.github.com/users/brkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brkt/subscriptions","organizations_url":"https://api.github.com/users/brkt/orgs","repos_url":"https://api.github.com/users/brkt/repos","events_url":"https://api.github.com/users/brkt/events{/privacy}","received_events_url":"https://api.github.com/users/brkt/received_events","type":"Organization","site_admin":false},"repo":{"id":42469221,"name":"brkt-cli","full_name":"brkt/brkt-cli","owner":{"login":"brkt","id":2963083,"avatar_url":"https://avatars.githubusercontent.com/u/2963083?v=3","gravatar_id":"","url":"https://api.github.com/users/brkt","html_url":"https://github.com/brkt","followers_url":"https://api.github.com/users/brkt/followers","following_url":"https://api.github.com/users/brkt/following{/other_user}","gists_url":"https://api.github.com/users/brkt/gists{/gist_id}","starred_url":"https://api.github.com/users/brkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brkt/subscriptions","organizations_url":"https://api.github.com/users/brkt/orgs","repos_url":"https://api.github.com/users/brkt/repos","events_url":"https://api.github.com/users/brkt/events{/privacy}","received_events_url":"https://api.github.com/users/brkt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brkt/brkt-cli","description":"","fork":false,"url":"https://api.github.com/repos/brkt/brkt-cli","forks_url":"https://api.github.com/repos/brkt/brkt-cli/forks","keys_url":"https://api.github.com/repos/brkt/brkt-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brkt/brkt-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brkt/brkt-cli/teams","hooks_url":"https://api.github.com/repos/brkt/brkt-cli/hooks","issue_events_url":"https://api.github.com/repos/brkt/brkt-cli/issues/events{/number}","events_url":"https://api.github.com/repos/brkt/brkt-cli/events","assignees_url":"https://api.github.com/repos/brkt/brkt-cli/assignees{/user}","branches_url":"https://api.github.com/repos/brkt/brkt-cli/branches{/branch}","tags_url":"https://api.github.com/repos/brkt/brkt-cli/tags","blobs_url":"https://api.github.com/repos/brkt/brkt-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brkt/brkt-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brkt/brkt-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/brkt/brkt-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brkt/brkt-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/brkt/brkt-cli/languages","stargazers_url":"https://api.github.com/repos/brkt/brkt-cli/stargazers","contributors_url":"https://api.github.com/repos/brkt/brkt-cli/contributors","subscribers_url":"https://api.github.com/repos/brkt/brkt-cli/subscribers","subscription_url":"https://api.github.com/repos/brkt/brkt-cli/subscription","commits_url":"https://api.github.com/repos/brkt/brkt-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/brkt/brkt-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/brkt/brkt-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/brkt/brkt-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/brkt/brkt-cli/contents/{+path}","compare_url":"https://api.github.com/repos/brkt/brkt-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brkt/brkt-cli/merges","archive_url":"https://api.github.com/repos/brkt/brkt-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brkt/brkt-cli/downloads","issues_url":"https://api.github.com/repos/brkt/brkt-cli/issues{/number}","pulls_url":"https://api.github.com/repos/brkt/brkt-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/brkt/brkt-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/brkt/brkt-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brkt/brkt-cli/labels{/name}","releases_url":"https://api.github.com/repos/brkt/brkt-cli/releases{/id}","created_at":"2015-09-14T18:39:20Z","updated_at":"2016-01-11T22:20:48Z","pushed_at":"2016-01-19T19:10:53Z","git_url":"git://github.com/brkt/brkt-cli.git","ssh_url":"git@github.com:brkt/brkt-cli.git","clone_url":"https://github.com/brkt/brkt-cli.git","svn_url":"https://github.com/brkt/brkt-cli","homepage":null,"size":349,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brkt/brkt-cli/pulls/123"},"html":{"href":"https://github.com/brkt/brkt-cli/pull/123"},"issue":{"href":"https://api.github.com/repos/brkt/brkt-cli/issues/123"},"comments":{"href":"https://api.github.com/repos/brkt/brkt-cli/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/brkt/brkt-cli/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/brkt/brkt-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brkt/brkt-cli/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/brkt/brkt-cli/statuses/f09e7e3225e539a849489cf400b546bdde095666"}}}}