{"action":"created","issue":{"url":"https://api.github.com/repos/jo/session25519/issues/2","repository_url":"https://api.github.com/repos/jo/session25519","labels_url":"https://api.github.com/repos/jo/session25519/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/jo/session25519/issues/2/comments","events_url":"https://api.github.com/repos/jo/session25519/issues/2/events","html_url":"https://github.com/jo/session25519/pull/2","id":142027521,"number":2,"title":"Upgrade to support higher security hashes and deriving encrypt AND signing keys","user":{"login":"grempe","id":117,"avatar_url":"https://avatars.githubusercontent.com/u/117?v=3","gravatar_id":"","url":"https://api.github.com/users/grempe","html_url":"https://github.com/grempe","followers_url":"https://api.github.com/users/grempe/followers","following_url":"https://api.github.com/users/grempe/following{/other_user}","gists_url":"https://api.github.com/users/grempe/gists{/gist_id}","starred_url":"https://api.github.com/users/grempe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grempe/subscriptions","organizations_url":"https://api.github.com/users/grempe/orgs","repos_url":"https://api.github.com/users/grempe/repos","events_url":"https://api.github.com/users/grempe/events{/privacy}","received_events_url":"https://api.github.com/users/grempe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-19T05:16:24Z","updated_at":"2016-03-20T18:01:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jo/session25519/pulls/2","html_url":"https://github.com/jo/session25519/pull/2","diff_url":"https://github.com/jo/session25519/pull/2.diff","patch_url":"https://github.com/jo/session25519/pull/2.patch"},"body":"Hi, I needed pretty much what you had built (thanks) but I also wanted to generate high quality signing keys as well as encryption keys.\r\n\r\nI have gone through the code, tests, and readme and made significant updates including the concept of `v1` and `v2` versions of the main function.  v1 is fully backward compatible and v2 provides higher security through as 64 byte BLAKE2b (vs. BLAKE2s) keyed hash and uses 64 bytes of scrypt output.  The 64 bytes of output is split in two to provide two different seeds, one for generating encryption keys, and one for signing keys.\r\n\r\nI also return the Base64 version of the keys for convenience. The tests vectors for v1are unmodified from your original and I've added new tests for the v2 version which is now the default. A user upgrade from the old version should only require adding the 'v1' version argument to their existing code block.\r\n\r\nI bumped the version of the package to 2.0.0 to fit with semver.\r\n\r\nI hope you can pull this changeset upstream and push a new version.\r\n\r\nThanks!\r\n\r\nGlenn "},"comment":{"url":"https://api.github.com/repos/jo/session25519/issues/comments/198974844","html_url":"https://github.com/jo/session25519/pull/2#issuecomment-198974844","issue_url":"https://api.github.com/repos/jo/session25519/issues/2","id":198974844,"user":{"login":"grempe","id":117,"avatar_url":"https://avatars.githubusercontent.com/u/117?v=3","gravatar_id":"","url":"https://api.github.com/users/grempe","html_url":"https://github.com/grempe","followers_url":"https://api.github.com/users/grempe/followers","following_url":"https://api.github.com/users/grempe/following{/other_user}","gists_url":"https://api.github.com/users/grempe/gists{/gist_id}","starred_url":"https://api.github.com/users/grempe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grempe/subscriptions","organizations_url":"https://api.github.com/users/grempe/orgs","repos_url":"https://api.github.com/users/grempe/repos","events_url":"https://api.github.com/users/grempe/events{/privacy}","received_events_url":"https://api.github.com/users/grempe/received_events","type":"User","site_admin":false},"created_at":"2016-03-20T18:01:30Z","updated_at":"2016-03-20T18:01:30Z","body":"@jo here are some new commits on the pull request that reflect your questions and the discussion on Twitter today with @dchest\r\n\r\nThe code is now a bit simpler, using BLAKE2s 32B hash as the scrypt input for both v1 and v2 as @dchest thought the use of the 64 Byte hash didn't really offer that much security wise.\r\n\r\nRegarding your file size question I suspect the increase is due to both the change in blake lib and in the use of the browserify --standalone flag which I needed to make it work in the browser for me.  I wasn't watching it too closely though.\r\n\r\nI had previously bumped the version string up to 2.0, I'll leave it up to you if that is ok or if you want to use 2.1 for these new commits even though 2.0 was never released.\r\n\r\nI added a shout-out to @dchest in the README.md as well. He deserves it. :-)\r\n\r\nCheers\r\n"}}