{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/89559420","pull_request_review_id":10104979,"id":89559420,"diff_hunk":"@@ -0,0 +1,96 @@\n+/*\n+ * Copyright (c) 2016, Linaro Ltd and Contributors. All rights reserved.\n+ * Copyright (c) 2016, Hisilicon Ltd and Contributors. All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * Redistributions of source code must retain the above copyright notice, this\n+ * list of conditions and the following disclaimer.\n+ *\n+ * Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following disclaimer in the documentation\n+ * and/or other materials provided with the distribution.\n+ *\n+ * Neither the name of ARM nor the names of its contributors may be used\n+ * to endorse or promote products derived from this software without specific\n+ * prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#ifndef __HIKEY_PERIPHERALS_H__\n+#define __HIKEY_PERIPHERALS_H__\n+\n+#include <types_ext.h>\n+\n+#define PMUSSI_BASE\t0xF8000000\n+#define PERI_BASE\t0xF7030000\n+#define PMX0_BASE\t0xF7010000\n+#define PMX1_BASE\t0xF7010800\n+#define GPIO6_BASE\t0xF7022000\n+#define\tSPI_BASE\t0xF7106000","path":"core/arch/arm/plat-hikey/hikey_peripherals.h","position":42,"original_position":42,"commit_id":"0c103c587d774494f27b1b1f7184197d837fa0b8","original_commit_id":"0c103c587d774494f27b1b1f7184197d837fa0b8","user":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"body":"@etienne-lms Ok, but the alignment/spacing/tabs seem almost impossible to get right because it looks one way in vim, another on github and something else via the IDE. I'll use vim as the 'ruler'.","created_at":"2016-11-25T02:49:55Z","updated_at":"2016-11-25T02:49:56Z","html_url":"https://github.com/OP-TEE/optee_os/pull/1161#discussion_r89559420","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/89559420"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/1161#discussion_r89559420"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161","id":92483214,"html_url":"https://github.com/OP-TEE/optee_os/pull/1161","diff_url":"https://github.com/OP-TEE/optee_os/pull/1161.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/1161.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1161","number":1161,"state":"open","locked":false,"title":"hikey: enable spi by default and add sample test code","user":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Victor Chong <victor.chong@linaro.org>\r\nTested-by: Victor Chong <victor.chong@linaro.org> (with CFG_SPI_TEST=y)","created_at":"2016-11-06T10:38:54Z","updated_at":"2016-11-25T02:49:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcdbbfaa0f6f0c3be089b632fc800fcc9be47bac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1161/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/0c103c587d774494f27b1b1f7184197d837fa0b8","head":{"label":"vchong:hikey_spi2","ref":"hikey_spi2","sha":"0c103c587d774494f27b1b1f7184197d837fa0b8","user":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"repo":{"id":32530410,"name":"optee_os","full_name":"vchong/optee_os","owner":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vchong/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/vchong/optee_os","forks_url":"https://api.github.com/repos/vchong/optee_os/forks","keys_url":"https://api.github.com/repos/vchong/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vchong/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vchong/optee_os/teams","hooks_url":"https://api.github.com/repos/vchong/optee_os/hooks","issue_events_url":"https://api.github.com/repos/vchong/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/vchong/optee_os/events","assignees_url":"https://api.github.com/repos/vchong/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/vchong/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/vchong/optee_os/tags","blobs_url":"https://api.github.com/repos/vchong/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vchong/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vchong/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/vchong/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vchong/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/vchong/optee_os/languages","stargazers_url":"https://api.github.com/repos/vchong/optee_os/stargazers","contributors_url":"https://api.github.com/repos/vchong/optee_os/contributors","subscribers_url":"https://api.github.com/repos/vchong/optee_os/subscribers","subscription_url":"https://api.github.com/repos/vchong/optee_os/subscription","commits_url":"https://api.github.com/repos/vchong/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/vchong/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/vchong/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/vchong/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/vchong/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/vchong/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vchong/optee_os/merges","archive_url":"https://api.github.com/repos/vchong/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vchong/optee_os/downloads","issues_url":"https://api.github.com/repos/vchong/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/vchong/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/vchong/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/vchong/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vchong/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/vchong/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/vchong/optee_os/deployments","created_at":"2015-03-19T15:38:15Z","updated_at":"2016-01-11T09:37:12Z","pushed_at":"2016-11-24T02:52:13Z","git_url":"git://github.com/vchong/optee_os.git","ssh_url":"git@github.com:vchong/optee_os.git","clone_url":"https://github.com/vchong/optee_os.git","svn_url":"https://github.com/vchong/optee_os","homepage":null,"size":7060,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"9eece61519d2c6a96989b5a85caeed9bd1a9c38a","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2016-11-20T18:57:58Z","pushed_at":"2016-11-25T02:34:16Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":11491,"stargazers_count":177,"watchers_count":177,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":42,"forks":177,"open_issues":42,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/1161"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/1161"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/1161/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/0c103c587d774494f27b1b1f7184197d837fa0b8"}}}}
{"actor":{"display_login":"vchong"}}