{"action":"created","issue":{"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/1554","repository_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup","labels_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/1554/labels{/name}","comments_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/1554/comments","events_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/1554/events","html_url":"https://github.com/RetroPie/RetroPie-Setup/pull/1554","id":163036972,"number":1554,"title":"Moved all advmame dirs to the right place. Turned smp on for multicor…","user":{"login":"dankcushions","id":13054748,"avatar_url":"https://avatars.githubusercontent.com/u/13054748?v=3","gravatar_id":"","url":"https://api.github.com/users/dankcushions","html_url":"https://github.com/dankcushions","followers_url":"https://api.github.com/users/dankcushions/followers","following_url":"https://api.github.com/users/dankcushions/following{/other_user}","gists_url":"https://api.github.com/users/dankcushions/gists{/gist_id}","starred_url":"https://api.github.com/users/dankcushions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankcushions/subscriptions","organizations_url":"https://api.github.com/users/dankcushions/orgs","repos_url":"https://api.github.com/users/dankcushions/repos","events_url":"https://api.github.com/users/dankcushions/events{/privacy}","received_events_url":"https://api.github.com/users/dankcushions/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-29T22:01:04Z","updated_at":"2016-07-14T12:59:48Z","closed_at":"2016-07-06T21:12:00Z","pull_request":{"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/1554","html_url":"https://github.com/RetroPie/RetroPie-Setup/pull/1554","diff_url":"https://github.com/RetroPie/RetroPie-Setup/pull/1554.diff","patch_url":"https://github.com/RetroPie/RetroPie-Setup/pull/1554.patch"},"body":"…s.\r\n\r\nthe smp option probably doesn't do anything massively useful. It just threads the GPU stuff, which according to their docs is only useful with lots of post-processing/scaling. Still, might aswell :)\r\n\r\nSome caveats:\r\n- if a user has an existing install, this won't do anything because iniSet doesn't change existing settings (at least, that's my understanding?), so all their existing files should be reachable as usual if they have an existing install.\r\n- things get a bit confusing with the dual directories in the .rc - from my testing it will read from both, but will only save into the first one (in this case /roms/mame-advmame/*/ as it is before /roms/arcade/advmame*/ in the .rc). Maybe it would be better to setup symlinks so that arcade sub folders are actually symlinked to the mame-advmame master?"},"comment":{"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/comments/232658277","html_url":"https://github.com/RetroPie/RetroPie-Setup/pull/1554#issuecomment-232658277","issue_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/1554","id":232658277,"user":{"login":"dankcushions","id":13054748,"avatar_url":"https://avatars.githubusercontent.com/u/13054748?v=3","gravatar_id":"","url":"https://api.github.com/users/dankcushions","html_url":"https://github.com/dankcushions","followers_url":"https://api.github.com/users/dankcushions/followers","following_url":"https://api.github.com/users/dankcushions/following{/other_user}","gists_url":"https://api.github.com/users/dankcushions/gists{/gist_id}","starred_url":"https://api.github.com/users/dankcushions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankcushions/subscriptions","organizations_url":"https://api.github.com/users/dankcushions/orgs","repos_url":"https://api.github.com/users/dankcushions/repos","events_url":"https://api.github.com/users/dankcushions/events{/privacy}","received_events_url":"https://api.github.com/users/dankcushions/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T12:59:48Z","updated_at":"2016-07-14T12:59:48Z","body":"yikes - something up with this: https://retropie.org.uk/forum/topic/2559/retropie-not-booting-after-total-update\r\n\r\ni can't test the symbolic link stuff right now but i don't see what's wrong:\r\n```\r\n    local mame_sub_dir\r\n    for mame_sub_dir in artwork diff hi inp memcard nvram sample snap sta\r\n    do\r\n         mkRomDir \"mame-advmame/$mame_sub_dir\"\r\n         ln -sf \"$romdir/mame-advmame/$mame_sub_dir\" \"$romdir/arcade/advmame/$mame_sub_dir\"\r\n    done\r\n```"}}
{"actor":{"display_login":"dankcushions"}}