{"action":"created","issue":{"url":"https://api.github.com/repos/broadinstitute/rawls/issues/395","repository_url":"https://api.github.com/repos/broadinstitute/rawls","labels_url":"https://api.github.com/repos/broadinstitute/rawls/issues/395/labels{/name}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/issues/395/comments","events_url":"https://api.github.com/repos/broadinstitute/rawls/issues/395/events","html_url":"https://github.com/broadinstitute/rawls/pull/395","id":151233308,"number":395,"title":"Use local docker mysql for running unit tests","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars.githubusercontent.com/u/116679?v=3","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rushtong","id":116679,"avatar_url":"https://avatars.githubusercontent.com/u/116679?v=3","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-04-26T20:38:15Z","updated_at":"2016-04-27T13:11:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/rawls/pulls/395","html_url":"https://github.com/broadinstitute/rawls/pull/395","diff_url":"https://github.com/broadinstitute/rawls/pull/395.diff","patch_url":"https://github.com/broadinstitute/rawls/pull/395.patch"},"body":"Addresses Jira ticket: https://broadinstitute.atlassian.net/browse/GAWB-542\r\n\r\nNotes:\r\n* This uses mysql 5.7. Our google instances are running 5.6, but when using that docker image, the tests run into timeout issues that I could not get around. Running against 5.7 is more reliable.\r\n* @dmohs - there is a lot of docker/shell script voodoo here - please give this some time.\r\n* Unfortunately, this increases travis testing time significantly, roughly doubling it.\r\n* See README for running tests under this framework.\r\n\r\n- [x] **Submitter**: Rebase to develop. DO NOT SQUASH\r\n- [x] **Submitter**: Make sure Swagger is updated if API changes\r\n- [x] **Submitter**: Make sure documentation for code is complete\r\n- [x] **Submitter**: Make sure liquibase is updated if appropriate\r\n- [x] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Add description or comments on the PR explaining the hows/whys (if not obvious)\r\n- [x] Tell ![](http://i.imgur.com/9dLzbPd.png) that the PR exists if he wants to look at it\r\n- [x] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n- [x] **LR**: Initial review by LR and others.\r\n- [ ] Comment / review / update cycle:\r\n  * Rest of team may comments on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter updates documentation as needed\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH. **Reassign to LR** for further feedback\r\n- [ ] ![](http://i.imgur.com/9dLzbPd.png) sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Squash commits, rebase if necessary\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Merge to develop \r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: Check configuration files in Jenkins in case they need changes\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev environment still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/broadinstitute/rawls/issues/comments/215076742","html_url":"https://github.com/broadinstitute/rawls/pull/395#issuecomment-215076742","issue_url":"https://api.github.com/repos/broadinstitute/rawls/issues/395","id":215076742,"user":{"login":"dvoet","id":1521333,"avatar_url":"https://avatars.githubusercontent.com/u/1521333?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoet","html_url":"https://github.com/dvoet","followers_url":"https://api.github.com/users/dvoet/followers","following_url":"https://api.github.com/users/dvoet/following{/other_user}","gists_url":"https://api.github.com/users/dvoet/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoet/subscriptions","organizations_url":"https://api.github.com/users/dvoet/orgs","repos_url":"https://api.github.com/users/dvoet/repos","events_url":"https://api.github.com/users/dvoet/events{/privacy}","received_events_url":"https://api.github.com/users/dvoet/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T13:11:06Z","updated_at":"2016-04-27T13:11:06Z","body":"down with h2"}}