{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3763","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-js","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3763/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3763/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3763/events","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/3763","id":194220300,"number":3763,"title":"Fix symbol rendering for multipoints","user":{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false},"labels":[{"id":481447185,"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/labels/under%20development","name":"under development","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-08T01:05:14Z","updated_at":"2016-12-09T00:33:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3763","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/3763","diff_url":"https://github.com/mapbox/mapbox-gl-js/pull/3763.diff","patch_url":"https://github.com/mapbox/mapbox-gl-js/pull/3763.patch"},"body":"Via a support request, @mapsam and I discovered that we do not render any symbols for multipoint geometries. This is inconsistent with our behaviour for circles in which we do render a circle at each point in the multipoint geometry (see https://github.com/mapbox/mapbox-gl-js/pull/2027). \r\n\r\nThis PR tries to differentiate multipoint geometries from polygons and perform the correct label placement in each case. \r\n\r\ncc @mourner @flippmoke @mapsam @jfirebaugh @colleenmcginnis \r\n\r\n## Open Questions\r\n\r\n - Is there a better way to differentiate between a multipoint and a polygon within GL JS?\r\n - Should we have a different `symbol-placement` modes for `point`, `line`, and `polygon` / `centroid`?\r\n - Are there other cases in which we don't handle multipoints properly?\r\n\r\n## Launch Checklist\r\n\r\n - [x] briefly describe the changes in this PR\r\n - [ ] write tests for all new functionality\r\n - [x] manually test the debug page\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/265898681","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/3763#issuecomment-265898681","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3763","id":265898681,"user":{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T00:33:53Z","updated_at":"2016-12-09T00:33:53Z","body":"Updated with new tests & use of the vector tile `type` field 😎 "}}
{"actor":{"display_login":"lucaswoj"}}