{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/comments/51022503","id":51022503,"diff_hunk":"@@ -0,0 +1,8 @@\n+<?xml version='1.0' encoding='windows-1252'?>\n+<Wix xmlns='http://schemas.microsoft.com/wix/2006/wi' xmlns:util=\"http://schemas.microsoft.com/wix/UtilExtension\">\n+\n+<!-- Some ERB Here to include the set of service files -->\n+\n+  <?include $(sys.SOURCEFILEDIR)include/puppet.wxi ?>","path":"resources/windows/msi/service.wxs.erb","position":6,"original_position":6,"commit_id":"18b8ae3764b9ed12018f138a3ebe4ea8291946a8","original_commit_id":"18b8ae3764b9ed12018f138a3ebe4ea8291946a8","user":{"login":"jcoconnor","id":13116231,"avatar_url":"https://avatars.githubusercontent.com/u/13116231?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"body":"Actually - @jpogran has pointed out that we might not even need this file.","created_at":"2016-01-27T18:00:14Z","updated_at":"2016-01-27T18:00:14Z","html_url":"https://github.com/puppetlabs/vanagon/pull/267#discussion_r51022503","pull_request_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/267","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/comments/51022503"},"html":{"href":"https://github.com/puppetlabs/vanagon/pull/267#discussion_r51022503"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/267"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/267","id":57254936,"html_url":"https://github.com/puppetlabs/vanagon/pull/267","diff_url":"https://github.com/puppetlabs/vanagon/pull/267.diff","patch_url":"https://github.com/puppetlabs/vanagon/pull/267.patch","issue_url":"https://api.github.com/repos/puppetlabs/vanagon/issues/267","number":267,"state":"closed","locked":false,"title":"(RE-6236) Add Service Handling Files to Vanagon","user":{"login":"jcoconnor","id":13116231,"avatar_url":"https://avatars.githubusercontent.com/u/13116231?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"body":"Add in configurable filter (XSLT) file to filter out service components\r\nfrom the main heat run in the build.\r\nRemove Service entries from main.wxs (top level Wix File) to move them\r\nto project specific service files.\r\nThe service.wxs.erb file will list and include these specific service\r\nfiles.","created_at":"2016-01-26T18:58:15Z","updated_at":"2016-01-27T18:00:14Z","closed_at":"2016-01-27T10:45:53Z","merged_at":null,"merge_commit_sha":"d74b0e6acfc64a589c3cc8ababe4ce1bfc1e7ea0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/267/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/267/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/vanagon/issues/267/comments","statuses_url":"https://api.github.com/repos/puppetlabs/vanagon/statuses/18b8ae3764b9ed12018f138a3ebe4ea8291946a8","head":{"label":"jcoconnor:ticket/master/RE-6236-Service-File","ref":"ticket/master/RE-6236-Service-File","sha":"18b8ae3764b9ed12018f138a3ebe4ea8291946a8","user":{"login":"jcoconnor","id":13116231,"avatar_url":"https://avatars.githubusercontent.com/u/13116231?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"repo":{"id":44818189,"name":"vanagon","full_name":"jcoconnor/vanagon","owner":{"login":"jcoconnor","id":13116231,"avatar_url":"https://avatars.githubusercontent.com/u/13116231?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcoconnor/vanagon","description":"All of your packages will fit into this van with this one simple trick.","fork":true,"url":"https://api.github.com/repos/jcoconnor/vanagon","forks_url":"https://api.github.com/repos/jcoconnor/vanagon/forks","keys_url":"https://api.github.com/repos/jcoconnor/vanagon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcoconnor/vanagon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcoconnor/vanagon/teams","hooks_url":"https://api.github.com/repos/jcoconnor/vanagon/hooks","issue_events_url":"https://api.github.com/repos/jcoconnor/vanagon/issues/events{/number}","events_url":"https://api.github.com/repos/jcoconnor/vanagon/events","assignees_url":"https://api.github.com/repos/jcoconnor/vanagon/assignees{/user}","branches_url":"https://api.github.com/repos/jcoconnor/vanagon/branches{/branch}","tags_url":"https://api.github.com/repos/jcoconnor/vanagon/tags","blobs_url":"https://api.github.com/repos/jcoconnor/vanagon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcoconnor/vanagon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcoconnor/vanagon/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcoconnor/vanagon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcoconnor/vanagon/statuses/{sha}","languages_url":"https://api.github.com/repos/jcoconnor/vanagon/languages","stargazers_url":"https://api.github.com/repos/jcoconnor/vanagon/stargazers","contributors_url":"https://api.github.com/repos/jcoconnor/vanagon/contributors","subscribers_url":"https://api.github.com/repos/jcoconnor/vanagon/subscribers","subscription_url":"https://api.github.com/repos/jcoconnor/vanagon/subscription","commits_url":"https://api.github.com/repos/jcoconnor/vanagon/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcoconnor/vanagon/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcoconnor/vanagon/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcoconnor/vanagon/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcoconnor/vanagon/contents/{+path}","compare_url":"https://api.github.com/repos/jcoconnor/vanagon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcoconnor/vanagon/merges","archive_url":"https://api.github.com/repos/jcoconnor/vanagon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcoconnor/vanagon/downloads","issues_url":"https://api.github.com/repos/jcoconnor/vanagon/issues{/number}","pulls_url":"https://api.github.com/repos/jcoconnor/vanagon/pulls{/number}","milestones_url":"https://api.github.com/repos/jcoconnor/vanagon/milestones{/number}","notifications_url":"https://api.github.com/repos/jcoconnor/vanagon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcoconnor/vanagon/labels{/name}","releases_url":"https://api.github.com/repos/jcoconnor/vanagon/releases{/id}","deployments_url":"https://api.github.com/repos/jcoconnor/vanagon/deployments","created_at":"2015-10-23T14:29:07Z","updated_at":"2016-01-27T10:46:40Z","pushed_at":"2016-01-27T14:16:39Z","git_url":"git://github.com/jcoconnor/vanagon.git","ssh_url":"git@github.com:jcoconnor/vanagon.git","clone_url":"https://github.com/jcoconnor/vanagon.git","svn_url":"https://github.com/jcoconnor/vanagon","homepage":null,"size":765,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:vanagon_for_the_win","ref":"vanagon_for_the_win","sha":"595ae8738417bdf36e65648549230ae9d3f879c0","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":26653553,"name":"vanagon","full_name":"puppetlabs/vanagon","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/vanagon","description":"All of your packages will fit into this van with this one simple trick.","fork":false,"url":"https://api.github.com/repos/puppetlabs/vanagon","forks_url":"https://api.github.com/repos/puppetlabs/vanagon/forks","keys_url":"https://api.github.com/repos/puppetlabs/vanagon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/vanagon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/vanagon/teams","hooks_url":"https://api.github.com/repos/puppetlabs/vanagon/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/vanagon/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/vanagon/events","assignees_url":"https://api.github.com/repos/puppetlabs/vanagon/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/vanagon/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/vanagon/tags","blobs_url":"https://api.github.com/repos/puppetlabs/vanagon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/vanagon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/vanagon/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/vanagon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/vanagon/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/vanagon/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/vanagon/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/vanagon/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/vanagon/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/vanagon/subscription","commits_url":"https://api.github.com/repos/puppetlabs/vanagon/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/vanagon/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/vanagon/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/vanagon/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/vanagon/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/vanagon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/vanagon/merges","archive_url":"https://api.github.com/repos/puppetlabs/vanagon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/vanagon/downloads","issues_url":"https://api.github.com/repos/puppetlabs/vanagon/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/vanagon/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/vanagon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/vanagon/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/vanagon/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/vanagon/deployments","created_at":"2014-11-14T19:17:18Z","updated_at":"2016-01-24T00:48:05Z","pushed_at":"2016-01-27T14:16:40Z","git_url":"git://github.com/puppetlabs/vanagon.git","ssh_url":"git@github.com:puppetlabs/vanagon.git","clone_url":"https://github.com/puppetlabs/vanagon.git","svn_url":"https://github.com/puppetlabs/vanagon","homepage":null,"size":884,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":2,"forks":17,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/267"},"html":{"href":"https://github.com/puppetlabs/vanagon/pull/267"},"issue":{"href":"https://api.github.com/repos/puppetlabs/vanagon/issues/267"},"comments":{"href":"https://api.github.com/repos/puppetlabs/vanagon/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/vanagon/statuses/18b8ae3764b9ed12018f138a3ebe4ea8291946a8"}}}}