{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/14356","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14356/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14356/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14356/events","html_url":"https://github.com/cms-sw/cmssw/pull/14356","id":152785674,"number":14356,"title":"Add pixel-only seed extension","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-pending","name":"hlt-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":77,"closed_issues":513,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-05-03T14:22:23Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-05-03T14:21:24Z","updated_at":"2016-05-03T14:28:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14356","html_url":"https://github.com/cms-sw/cmssw/pull/14356","diff_url":"https://github.com/cms-sw/cmssw/pull/14356.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14356.patch"},"body":"This PR adds a \"pixel-only\" flavour of the SeedExtensionTrajectoryFilter (one of the explored pixel-quadruplet approaches for phase1). As a prerequisite, Trajectory and TempTrajectory are extended to count also found pixel hits (which may have other uses too). \r\n\r\nThe SeedExtensionTrajectoryFilter is also extended to act as \"qualityFilter()\" in addition to \"toBeContinued()\". The point is that if seed extension decides that a propagation of a trajectory should be stopped, the trajectory should also be discarded (in my opinion). This way the assumption is enforced without relying on the value of `minimumNumberOfHits` (alternatively we would need `minimumNumberOfPixelHits`). The easiest way to communicate the \"trajectory was stopped because of seed extension\" from `toBeContinued()` to `qualityFilter()` was to use the existing `StoppingReason` enum, so I added a `SEED_EXTENSION` enumerator there.\r\n\r\nI updated the tracking DQM for the new `StoppingReason` (*), also adding a run-time check in case new StoppingReasons are added. (Maybe we should eventually abstract the string representation of StoppingReasons similarly to TrackBase::TrackAlgorithm?)\r\n\r\n(*) After the \"qualityFilter()\" change we expect to see zero tracks with `SEED_EXTENSION` stopping reason, so the DQM change serves mainly as a sanity check (seeing something there indicates a bug).\r\n\r\nTested in CMSSW_8_1_X_2016-05-01-2300, no changes expected in standard workflows (new functionality is added but not enabled).\r\n\r\n@rovere @VinInn @mtosi "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/216546243","html_url":"https://github.com/cms-sw/cmssw/pull/14356#issuecomment-216546243","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14356","id":216546243,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T14:28:05Z","updated_at":"2016-05-03T14:28:05Z","body":"There was an issue with git-cms-merge-topic you can see the log here: \nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14356/12795/git-merge-result"}}