{"action":"created","issue":{"url":"https://api.github.com/repos/tleunen/react-mdl/issues/105","labels_url":"https://api.github.com/repos/tleunen/react-mdl/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/tleunen/react-mdl/issues/105/comments","events_url":"https://api.github.com/repos/tleunen/react-mdl/issues/105/events","html_url":"https://github.com/tleunen/react-mdl/issues/105","id":115662212,"number":105,"title":"Possibly change: Refactor DataTable","user":{"login":"janpieterz","id":383634,"avatar_url":"https://avatars.githubusercontent.com/u/383634?v=3","gravatar_id":"","url":"https://api.github.com/users/janpieterz","html_url":"https://github.com/janpieterz","followers_url":"https://api.github.com/users/janpieterz/followers","following_url":"https://api.github.com/users/janpieterz/following{/other_user}","gists_url":"https://api.github.com/users/janpieterz/gists{/gist_id}","starred_url":"https://api.github.com/users/janpieterz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janpieterz/subscriptions","organizations_url":"https://api.github.com/users/janpieterz/orgs","repos_url":"https://api.github.com/users/janpieterz/repos","events_url":"https://api.github.com/users/janpieterz/events{/privacy}","received_events_url":"https://api.github.com/users/janpieterz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tleunen/react-mdl/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-11-07T12:14:52Z","updated_at":"2016-01-16T13:38:53Z","closed_at":null,"body":"Since the comment from Garbee on https://github.com/google/material-design-lite/issues/1210#issuecomment-149538160 and some troubles with how the table is setup currently I rewrote the DataTable to deliver more flexibility, for example having more interactivity with the checkbox'es, or giving specific widths to a column, I rewrote the DataTable.\r\n\r\nI think there are certainly some improvements to make to my implementation, but was wondering if you'd be up for me refactoring it. My current (rudimentary) implementation can be found in this gist:\r\nhttps://gist.github.com/janpieterz/6a74182debfaa61db7df"},"comment":{"url":"https://api.github.com/repos/tleunen/react-mdl/issues/comments/172207775","html_url":"https://github.com/tleunen/react-mdl/issues/105#issuecomment-172207775","issue_url":"https://api.github.com/repos/tleunen/react-mdl/issues/105","id":172207775,"user":{"login":"tleunen","id":1972567,"avatar_url":"https://avatars.githubusercontent.com/u/1972567?v=3","gravatar_id":"","url":"https://api.github.com/users/tleunen","html_url":"https://github.com/tleunen","followers_url":"https://api.github.com/users/tleunen/followers","following_url":"https://api.github.com/users/tleunen/following{/other_user}","gists_url":"https://api.github.com/users/tleunen/gists{/gist_id}","starred_url":"https://api.github.com/users/tleunen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tleunen/subscriptions","organizations_url":"https://api.github.com/users/tleunen/orgs","repos_url":"https://api.github.com/users/tleunen/repos","events_url":"https://api.github.com/users/tleunen/events{/privacy}","received_events_url":"https://api.github.com/users/tleunen/received_events","type":"User","site_admin":false},"created_at":"2016-01-16T13:38:53Z","updated_at":"2016-01-16T13:38:53Z","body":"@FoxxMD about onchange event, I suggest you to do it yourself, adds a Checkbox in the cell instead of using the selectable property. I'll deprecate it soon since it's deprecated in MDL. About using components in cells, it's already possible.\r\n\r\nHere's an example with an image:\r\n```jsx\r\n<DataTable\r\n    columns={[\r\n        { name: 'picture', label: '' },\r\n        { name: 'firstname', label: 'Firtname' },\r\n        { name: 'lastname', label: 'Lastname' },\r\n    ]}\r\n    data={[\r\n        { picture: <img src=\"http://placehold.it/100x100\" />, firstname: 'John', lastname: 'Doe' },\r\n        { picture: <img src=\"http://placehold.it/100x100\" />, name: 'Jane', lastname: 'Doe' },\r\n        { picture: <img src=\"http://placehold.it/100x100\" />, name: 'Janie', lastname: 'Doe' }\r\n    ]}\r\n/>\r\n```\r\n\r\n@janpieterz The more I think about it and the more I find the current implementation acceptable. We might add a few other \"properties\" to the columns so that we could easily customize them (for example `className`and `tooltip`).\r\nWhat do you think?"}}