{"action":"created","comment":{"url":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/comments/68310434","id":68310434,"diff_hunk":"@@ -50,35 +50,8 @@ def AppendSource(self, type_indicator, attributes):\n     if not type_indicator:\n       raise errors.FormatError(u'Missing type indicator.')\n \n-    source_type_class = None\n-    if type_indicator == definitions.TYPE_INDICATOR_ARTIFACT_GROUP:\n-      source_type_class = source_type.ArtifactGroupSourceType\n-\n-    elif type_indicator == definitions.TYPE_INDICATOR_COMMAND:\n-      source_type_class = source_type.CommandSourceType\n-\n-    elif type_indicator == definitions.TYPE_INDICATOR_COMMAND:\n-      source_type_class = source_type.CommandCollectorDefinition\n-\n-    elif type_indicator == definitions.TYPE_INDICATOR_DIRECTORY:\n-      source_type_class = source_type.DirectorySourceType\n-\n-    elif type_indicator == definitions.TYPE_INDICATOR_FILE:\n-      source_type_class = source_type.FileSourceType\n-\n-    elif type_indicator == definitions.TYPE_INDICATOR_PATH:\n-      source_type_class = source_type.PathSourceType\n-\n-    elif type_indicator == definitions.TYPE_INDICATOR_WINDOWS_REGISTRY_KEY:\n-      source_type_class = source_type.WindowsRegistryKeySourceType\n-\n-    elif type_indicator == definitions.TYPE_INDICATOR_WINDOWS_REGISTRY_VALUE:\n-      source_type_class = source_type.WindowsRegistryValueSourceType\n-\n-    elif type_indicator == definitions.TYPE_INDICATOR_WMI_QUERY:\n-      source_type_class = source_type.WMIQuerySourceType\n-\n-    else:\n+    source_type_class = source_type.SOURCE_TYPES.get(type_indicator)\n+    if source_type_class is None:","path":"artifacts/artifact.py","position":34,"original_position":34,"commit_id":"f49a8212c2a5e2f484b949accbde3c0b35c34eb0","original_commit_id":"f49a8212c2a5e2f484b949accbde3c0b35c34eb0","user":{"login":"joachimmetz","id":3888750,"avatar_url":"https://avatars.githubusercontent.com/u/3888750?v=3","gravatar_id":"","url":"https://api.github.com/users/joachimmetz","html_url":"https://github.com/joachimmetz","followers_url":"https://api.github.com/users/joachimmetz/followers","following_url":"https://api.github.com/users/joachimmetz/following{/other_user}","gists_url":"https://api.github.com/users/joachimmetz/gists{/gist_id}","starred_url":"https://api.github.com/users/joachimmetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachimmetz/subscriptions","organizations_url":"https://api.github.com/users/joachimmetz/orgs","repos_url":"https://api.github.com/users/joachimmetz/repos","events_url":"https://api.github.com/users/joachimmetz/events{/privacy}","received_events_url":"https://api.github.com/users/joachimmetz/received_events","type":"User","site_admin":false},"body":"if not source_type_class:","created_at":"2016-06-23T20:38:20Z","updated_at":"2016-06-23T20:38:20Z","html_url":"https://github.com/ForensicArtifacts/artifacts/pull/173#discussion_r68310434","pull_request_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/comments/68310434"},"html":{"href":"https://github.com/ForensicArtifacts/artifacts/pull/173#discussion_r68310434"},"pull_request":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/173","id":74912051,"html_url":"https://github.com/ForensicArtifacts/artifacts/pull/173","diff_url":"https://github.com/ForensicArtifacts/artifacts/pull/173.diff","patch_url":"https://github.com/ForensicArtifacts/artifacts/pull/173.patch","issue_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/issues/173","number":173,"state":"open","locked":false,"title":"Allow source types to be extended by library users","user":{"login":"scudette","id":3856546,"avatar_url":"https://avatars.githubusercontent.com/u/3856546?v=3","gravatar_id":"","url":"https://api.github.com/users/scudette","html_url":"https://github.com/scudette","followers_url":"https://api.github.com/users/scudette/followers","following_url":"https://api.github.com/users/scudette/following{/other_user}","gists_url":"https://api.github.com/users/scudette/gists{/gist_id}","starred_url":"https://api.github.com/users/scudette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scudette/subscriptions","organizations_url":"https://api.github.com/users/scudette/orgs","repos_url":"https://api.github.com/users/scudette/repos","events_url":"https://api.github.com/users/scudette/events{/privacy}","received_events_url":"https://api.github.com/users/scudette/received_events","type":"User","site_admin":false},"body":"This allows library users to add private source types by registering new handlers.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/forensicartifacts/artifacts/173)\n<!-- Reviewable:end -->\n","created_at":"2016-06-23T08:08:26Z","updated_at":"2016-06-23T20:38:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcff28f47d304b22b99c29e8b7ff7ecae426ce86","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/173/commits","review_comments_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/173/comments","review_comment_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/issues/173/comments","statuses_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/statuses/f49a8212c2a5e2f484b949accbde3c0b35c34eb0","head":{"label":"scudette:plugins","ref":"plugins","sha":"f49a8212c2a5e2f484b949accbde3c0b35c34eb0","user":{"login":"scudette","id":3856546,"avatar_url":"https://avatars.githubusercontent.com/u/3856546?v=3","gravatar_id":"","url":"https://api.github.com/users/scudette","html_url":"https://github.com/scudette","followers_url":"https://api.github.com/users/scudette/followers","following_url":"https://api.github.com/users/scudette/following{/other_user}","gists_url":"https://api.github.com/users/scudette/gists{/gist_id}","starred_url":"https://api.github.com/users/scudette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scudette/subscriptions","organizations_url":"https://api.github.com/users/scudette/orgs","repos_url":"https://api.github.com/users/scudette/repos","events_url":"https://api.github.com/users/scudette/events{/privacy}","received_events_url":"https://api.github.com/users/scudette/received_events","type":"User","site_admin":false},"repo":{"id":61786872,"name":"artifacts","full_name":"scudette/artifacts","owner":{"login":"scudette","id":3856546,"avatar_url":"https://avatars.githubusercontent.com/u/3856546?v=3","gravatar_id":"","url":"https://api.github.com/users/scudette","html_url":"https://github.com/scudette","followers_url":"https://api.github.com/users/scudette/followers","following_url":"https://api.github.com/users/scudette/following{/other_user}","gists_url":"https://api.github.com/users/scudette/gists{/gist_id}","starred_url":"https://api.github.com/users/scudette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scudette/subscriptions","organizations_url":"https://api.github.com/users/scudette/orgs","repos_url":"https://api.github.com/users/scudette/repos","events_url":"https://api.github.com/users/scudette/events{/privacy}","received_events_url":"https://api.github.com/users/scudette/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scudette/artifacts","description":"ForensicArtifacts.com Artifact Repository","fork":true,"url":"https://api.github.com/repos/scudette/artifacts","forks_url":"https://api.github.com/repos/scudette/artifacts/forks","keys_url":"https://api.github.com/repos/scudette/artifacts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scudette/artifacts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scudette/artifacts/teams","hooks_url":"https://api.github.com/repos/scudette/artifacts/hooks","issue_events_url":"https://api.github.com/repos/scudette/artifacts/issues/events{/number}","events_url":"https://api.github.com/repos/scudette/artifacts/events","assignees_url":"https://api.github.com/repos/scudette/artifacts/assignees{/user}","branches_url":"https://api.github.com/repos/scudette/artifacts/branches{/branch}","tags_url":"https://api.github.com/repos/scudette/artifacts/tags","blobs_url":"https://api.github.com/repos/scudette/artifacts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scudette/artifacts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scudette/artifacts/git/refs{/sha}","trees_url":"https://api.github.com/repos/scudette/artifacts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scudette/artifacts/statuses/{sha}","languages_url":"https://api.github.com/repos/scudette/artifacts/languages","stargazers_url":"https://api.github.com/repos/scudette/artifacts/stargazers","contributors_url":"https://api.github.com/repos/scudette/artifacts/contributors","subscribers_url":"https://api.github.com/repos/scudette/artifacts/subscribers","subscription_url":"https://api.github.com/repos/scudette/artifacts/subscription","commits_url":"https://api.github.com/repos/scudette/artifacts/commits{/sha}","git_commits_url":"https://api.github.com/repos/scudette/artifacts/git/commits{/sha}","comments_url":"https://api.github.com/repos/scudette/artifacts/comments{/number}","issue_comment_url":"https://api.github.com/repos/scudette/artifacts/issues/comments{/number}","contents_url":"https://api.github.com/repos/scudette/artifacts/contents/{+path}","compare_url":"https://api.github.com/repos/scudette/artifacts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scudette/artifacts/merges","archive_url":"https://api.github.com/repos/scudette/artifacts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scudette/artifacts/downloads","issues_url":"https://api.github.com/repos/scudette/artifacts/issues{/number}","pulls_url":"https://api.github.com/repos/scudette/artifacts/pulls{/number}","milestones_url":"https://api.github.com/repos/scudette/artifacts/milestones{/number}","notifications_url":"https://api.github.com/repos/scudette/artifacts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scudette/artifacts/labels{/name}","releases_url":"https://api.github.com/repos/scudette/artifacts/releases{/id}","deployments_url":"https://api.github.com/repos/scudette/artifacts/deployments","created_at":"2016-06-23T08:06:40Z","updated_at":"2016-06-23T08:06:40Z","pushed_at":"2016-06-23T08:07:18Z","git_url":"git://github.com/scudette/artifacts.git","ssh_url":"git@github.com:scudette/artifacts.git","clone_url":"https://github.com/scudette/artifacts.git","svn_url":"https://github.com/scudette/artifacts","homepage":"","size":457,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ForensicArtifacts:master","ref":"master","sha":"e175b3c3894a45bdd4c3990329995464ebce0ac1","user":{"login":"ForensicArtifacts","id":3381114,"avatar_url":"https://avatars.githubusercontent.com/u/3381114?v=3","gravatar_id":"","url":"https://api.github.com/users/ForensicArtifacts","html_url":"https://github.com/ForensicArtifacts","followers_url":"https://api.github.com/users/ForensicArtifacts/followers","following_url":"https://api.github.com/users/ForensicArtifacts/following{/other_user}","gists_url":"https://api.github.com/users/ForensicArtifacts/gists{/gist_id}","starred_url":"https://api.github.com/users/ForensicArtifacts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForensicArtifacts/subscriptions","organizations_url":"https://api.github.com/users/ForensicArtifacts/orgs","repos_url":"https://api.github.com/users/ForensicArtifacts/repos","events_url":"https://api.github.com/users/ForensicArtifacts/events{/privacy}","received_events_url":"https://api.github.com/users/ForensicArtifacts/received_events","type":"Organization","site_admin":false},"repo":{"id":26029828,"name":"artifacts","full_name":"ForensicArtifacts/artifacts","owner":{"login":"ForensicArtifacts","id":3381114,"avatar_url":"https://avatars.githubusercontent.com/u/3381114?v=3","gravatar_id":"","url":"https://api.github.com/users/ForensicArtifacts","html_url":"https://github.com/ForensicArtifacts","followers_url":"https://api.github.com/users/ForensicArtifacts/followers","following_url":"https://api.github.com/users/ForensicArtifacts/following{/other_user}","gists_url":"https://api.github.com/users/ForensicArtifacts/gists{/gist_id}","starred_url":"https://api.github.com/users/ForensicArtifacts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForensicArtifacts/subscriptions","organizations_url":"https://api.github.com/users/ForensicArtifacts/orgs","repos_url":"https://api.github.com/users/ForensicArtifacts/repos","events_url":"https://api.github.com/users/ForensicArtifacts/events{/privacy}","received_events_url":"https://api.github.com/users/ForensicArtifacts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ForensicArtifacts/artifacts","description":"ForensicArtifacts.com Artifact Repository","fork":false,"url":"https://api.github.com/repos/ForensicArtifacts/artifacts","forks_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/forks","keys_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/teams","hooks_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/hooks","issue_events_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/issues/events{/number}","events_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/events","assignees_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/assignees{/user}","branches_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/branches{/branch}","tags_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/tags","blobs_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/git/refs{/sha}","trees_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/statuses/{sha}","languages_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/languages","stargazers_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/stargazers","contributors_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/contributors","subscribers_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/subscribers","subscription_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/subscription","commits_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/commits{/sha}","git_commits_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/git/commits{/sha}","comments_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/comments{/number}","issue_comment_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/issues/comments{/number}","contents_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/contents/{+path}","compare_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/merges","archive_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/downloads","issues_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/issues{/number}","pulls_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls{/number}","milestones_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/milestones{/number}","notifications_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/labels{/name}","releases_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/releases{/id}","deployments_url":"https://api.github.com/repos/ForensicArtifacts/artifacts/deployments","created_at":"2014-10-31T19:13:44Z","updated_at":"2016-06-13T19:02:03Z","pushed_at":"2016-06-23T08:08:31Z","git_url":"git://github.com/ForensicArtifacts/artifacts.git","ssh_url":"git@github.com:ForensicArtifacts/artifacts.git","clone_url":"https://github.com/ForensicArtifacts/artifacts.git","svn_url":"https://github.com/ForensicArtifacts/artifacts","homepage":"","size":511,"stargazers_count":92,"watchers_count":92,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":11,"forks":36,"open_issues":11,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/173"},"html":{"href":"https://github.com/ForensicArtifacts/artifacts/pull/173"},"issue":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/issues/173"},"comments":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/ForensicArtifacts/artifacts/statuses/f49a8212c2a5e2f484b949accbde3c0b35c34eb0"}}}}
{"actor":{"display_login":"joachimmetz"}}