{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material2/issues/210","repository_url":"https://api.github.com/repos/angular/material2","labels_url":"https://api.github.com/repos/angular/material2/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/angular/material2/issues/210/comments","events_url":"https://api.github.com/repos/angular/material2/issues/210/events","html_url":"https://github.com/angular/material2/pull/210","id":142116197,"number":210,"title":"fix(ci): fix flakiness by inlining html & css","user":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars.githubusercontent.com/u/838736?v=3","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/material2/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/angular/material2/labels/pr:%20needs%20review","name":"pr: needs review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-20T01:00:06Z","updated_at":"2016-03-20T02:01:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/210","html_url":"https://github.com/angular/material2/pull/210","diff_url":"https://github.com/angular/material2/pull/210.diff","patch_url":"https://github.com/angular/material2/pull/210.patch"},"body":"I was eating empanadas and working on the overlay, which prompted me to look at the portal spec. A part of my brain said:\r\n\"You know, I've never seen this test flake.\"\r\nAnd another part responded:\r\n\"Of course it doesn't flake, it doesn't have a tem-\".\r\n\"Oh.\"\r\n\r\nSo I've fixed the flakiness by inlining all the templates and CSS. After I did this, one of the checkbox tests was actually failing, so I fixed that too. \r\n\r\nThis also has the pleasant side effect of making the tests in all browsers significantly faster.\r\n\r\nAlso, I removed firefox beta because all it does is make the SauceLabs optional task take forever to finish failing."},"comment":{"url":"https://api.github.com/repos/angular/material2/issues/comments/198826721","html_url":"https://github.com/angular/material2/pull/210#issuecomment-198826721","issue_url":"https://api.github.com/repos/angular/material2/issues/210","id":198826721,"user":{"login":"hansl","id":681969,"avatar_url":"https://avatars.githubusercontent.com/u/681969?v=3","gravatar_id":"","url":"https://api.github.com/users/hansl","html_url":"https://github.com/hansl","followers_url":"https://api.github.com/users/hansl/followers","following_url":"https://api.github.com/users/hansl/following{/other_user}","gists_url":"https://api.github.com/users/hansl/gists{/gist_id}","starred_url":"https://api.github.com/users/hansl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansl/subscriptions","organizations_url":"https://api.github.com/users/hansl/orgs","repos_url":"https://api.github.com/users/hansl/repos","events_url":"https://api.github.com/users/hansl/events{/privacy}","received_events_url":"https://api.github.com/users/hansl/received_events","type":"User","site_admin":false},"created_at":"2016-03-20T02:01:08Z","updated_at":"2016-03-20T02:01:08Z","body":"I don't see any change for karma to inline the changes. Did I miss a commit?"}}