{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21477","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21477/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21477/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21477/events","html_url":"https://github.com/kubernetes/kubernetes/pull/21477","id":134636792,"number":21477,"title":"Limit number of keys in Secret and ConfigMap","user":{"login":"sjenning","id":493891,"avatar_url":"https://avatars.githubusercontent.com/u/493891?v=3","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-breaking-change","name":"release-note-breaking-change","color":"db5a64"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"milestone":null,"comments":11,"created_at":"2016-02-18T17:01:23Z","updated_at":"2016-02-19T18:01:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21477","html_url":"https://github.com/kubernetes/kubernetes/pull/21477","diff_url":"https://github.com/kubernetes/kubernetes/pull/21477.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/21477.patch"},"body":"Puts a 1k limit on the number of keys and includes the key length, in addition to the value length, in the total size limit check\r\n\r\nFixes #19969"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/186333518","html_url":"https://github.com/kubernetes/kubernetes/pull/21477#issuecomment-186333518","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21477","id":186333518,"user":{"login":"sjenning","id":493891,"avatar_url":"https://avatars.githubusercontent.com/u/493891?v=3","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T18:01:47Z","updated_at":"2016-02-19T18:01:47Z","body":"@bgrant0607 so reserving a fixed space for the worst case serialization overhead doesn't look like it is going to work.  it eats up too much of the usable space in the normal case (where the user just has a few keys).\r\n\r\nOne idea was to (re)serialize the object and figure out the exact serialized size.  Would that work?"}}