{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8747","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8747/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8747/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8747/events","html_url":"https://github.com/bitcoin/bitcoin/pull/8747","id":177498094,"number":8747,"title":"[rpc] Fix transaction size comments and RPC help text.","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars.githubusercontent.com/u/1063656?v=3","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"labels":[{"id":148216,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Docs%20and%20Output","name":"Docs and Output","color":"02d7e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-09-16T19:07:33Z","updated_at":"2016-11-17T13:27:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8747","html_url":"https://github.com/bitcoin/bitcoin/pull/8747","diff_url":"https://github.com/bitcoin/bitcoin/pull/8747.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8747.patch"},"body":"As part of BIP 141, transaction sizes have been replaced by virtual size (with witness data discounted) as the metric for measuring the fee rate of a transaction. RPC now returns the virtual size of the transaction instead of the serialized size. However, code comments and RPC help text have not been updated everywhere to reflect this change.\n\nThis PR fixes various comments and RPC help text.\n"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/261245959","html_url":"https://github.com/bitcoin/bitcoin/pull/8747#issuecomment-261245959","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8747","id":261245959,"user":{"login":"morcos","id":4360349,"avatar_url":"https://avatars.githubusercontent.com/u/4360349?v=3","gravatar_id":"","url":"https://api.github.com/users/morcos","html_url":"https://github.com/morcos","followers_url":"https://api.github.com/users/morcos/followers","following_url":"https://api.github.com/users/morcos/following{/other_user}","gists_url":"https://api.github.com/users/morcos/gists{/gist_id}","starred_url":"https://api.github.com/users/morcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morcos/subscriptions","organizations_url":"https://api.github.com/users/morcos/orgs","repos_url":"https://api.github.com/users/morcos/repos","events_url":"https://api.github.com/users/morcos/events{/privacy}","received_events_url":"https://api.github.com/users/morcos/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T13:27:40Z","updated_at":"2016-11-17T13:27:40Z","body":"@luke-jr but that is not the choice at hand.  The choice presented by this PR is to document the existing behavior or leave it improperly documented.  Choosing to document it does not preclude changing it in the future.  Although I think most of us do not consider it a bug.\r\n\r\nI can't understand why this is even a question.  How can we argue against more clearly explaining to users what the behavior is?  We should always be willing to document existing behavior instead of stalling on that while arguing about whether to change the behavior."}}
{"actor":{"display_login":"morcos"}}