{"action":"created","issue":{"url":"https://api.github.com/repos/isiahmeadows/thallium/issues/8","repository_url":"https://api.github.com/repos/isiahmeadows/thallium","labels_url":"https://api.github.com/repos/isiahmeadows/thallium/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/isiahmeadows/thallium/issues/8/comments","events_url":"https://api.github.com/repos/isiahmeadows/thallium/issues/8/events","html_url":"https://github.com/isiahmeadows/thallium/issues/8","id":175629087,"number":8,"title":"Buffer() without new keyword?","user":{"login":"crazyhuggins","id":20595761,"avatar_url":"https://avatars.githubusercontent.com/u/20595761?v=3","gravatar_id":"","url":"https://api.github.com/users/crazyhuggins","html_url":"https://github.com/crazyhuggins","followers_url":"https://api.github.com/users/crazyhuggins/followers","following_url":"https://api.github.com/users/crazyhuggins/following{/other_user}","gists_url":"https://api.github.com/users/crazyhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/crazyhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazyhuggins/subscriptions","organizations_url":"https://api.github.com/users/crazyhuggins/orgs","repos_url":"https://api.github.com/users/crazyhuggins/repos","events_url":"https://api.github.com/users/crazyhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/crazyhuggins/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/isiahmeadows/thallium/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-09-07T23:17:29Z","updated_at":"2016-09-13T00:56:03Z","closed_at":null,"body":"Hi. Great work with this project! I really like it :+1: \r\n\r\nHowever I was looking at substack repo and discovered this: https://github.com/substack/node-deep-equal/issues/42"},"comment":{"url":"https://api.github.com/repos/isiahmeadows/thallium/issues/comments/246541599","html_url":"https://github.com/isiahmeadows/thallium/issues/8#issuecomment-246541599","issue_url":"https://api.github.com/repos/isiahmeadows/thallium/issues/8","id":246541599,"user":{"login":"isiahmeadows","id":4483844,"avatar_url":"https://avatars.githubusercontent.com/u/4483844?v=3","gravatar_id":"","url":"https://api.github.com/users/isiahmeadows","html_url":"https://github.com/isiahmeadows","followers_url":"https://api.github.com/users/isiahmeadows/followers","following_url":"https://api.github.com/users/isiahmeadows/following{/other_user}","gists_url":"https://api.github.com/users/isiahmeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/isiahmeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isiahmeadows/subscriptions","organizations_url":"https://api.github.com/users/isiahmeadows/orgs","repos_url":"https://api.github.com/users/isiahmeadows/repos","events_url":"https://api.github.com/users/isiahmeadows/events{/privacy}","received_events_url":"https://api.github.com/users/isiahmeadows/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T00:56:02Z","updated_at":"2016-09-13T00:56:02Z","body":"The double check for circular references is actually to check that each\nobject contains the equivalent reference for each. I didn't catch the set\nissue (maps have similar problems), though, so thanks for that.\n\nAs for `Object.is(0, -0) === false`, I intentionally deviated simply\nbecause I've yet to find a use case beyond formatting objects to strings\n(`util.inspect` does this). I'll admit my comparison was slightly off (it's\nactually strict equality, except NaNs are equal).\n\nI do suspect the primitive issue is because I abstracted too much (no\nengine AFAIK inlines highly polymorphic calls). To be honest, the CLI is\nwhere most of the optimization is needed, though, because it's doing way\ntoo much I/O for my liking (although this will help).\n\nOn Mon, Sep 12, 2016, 20:37 zubuzon <notifications@github.com> wrote:\n\n> Hi. I will just experiment a little regarding this. However you can speed\n> up the regEx and date comparison checks very easy refactor deepEqual to\n> be factory function you are calling when needed. And quickly bail out if\n> any match\n>\n> function deepEqual() {// do primitive check directly herereturn objMatch(matcher, deepEqual, a, b); // then this...\n> }\n> function objMatch(matcher, deepEqual, a, b) {}\n> .../ No need for strictIs etc now. Only use deepEqual\n>\n> That gave me improved performance. And for the keys you are checking, just\n> call the same deepEqual function again.\n>\n> I'm still experimenting on this, and I found issues with your Set()\n> implementation. Set() can actually have circular references, but in your\n> code this will break.\n>\n>  var set1 = new Set;\n>  var  set2 = new Set;\n>\n>         set1.add(set1);\n>         set2.add(set2);\n>\n>        //  set1 and set2 -> true\n>\n>         set1.add(1);\n>         set2.add(2);\n>\n>        //  set1 and set2 -> false\n>\n> And I'm not sure about transitive equivalence for circular references.\n>\n> In fact there are various stuff I have noticed so far, but I will look\n> into it. Just now I got a unforeseen meeting with a client so I have to\n> deal with that first.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/isiahmeadows/thallium/issues/8#issuecomment-246538816>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AERrBAzR85iMst_Zvi0hEqm8IOxuK8xcks5qpfBPgaJpZM4J3dEz>\n> .\n>\n"}}
{"actor":{"display_login":"isiahmeadows"}}