{"action":"created","issue":{"url":"https://api.github.com/repos/angular-macgyver/MacGyver/issues/38","repository_url":"https://api.github.com/repos/angular-macgyver/MacGyver","labels_url":"https://api.github.com/repos/angular-macgyver/MacGyver/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/angular-macgyver/MacGyver/issues/38/comments","events_url":"https://api.github.com/repos/angular-macgyver/MacGyver/issues/38/events","html_url":"https://github.com/angular-macgyver/MacGyver/issues/38","id":176093407,"number":38,"title":"mac-popover-refresh-on is not working for popover","user":{"login":"aeisenberg","id":363559,"avatar_url":"https://avatars.githubusercontent.com/u/363559?v=3","gravatar_id":"","url":"https://api.github.com/users/aeisenberg","html_url":"https://github.com/aeisenberg","followers_url":"https://api.github.com/users/aeisenberg/followers","following_url":"https://api.github.com/users/aeisenberg/following{/other_user}","gists_url":"https://api.github.com/users/aeisenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/aeisenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeisenberg/subscriptions","organizations_url":"https://api.github.com/users/aeisenberg/orgs","repos_url":"https://api.github.com/users/aeisenberg/repos","events_url":"https://api.github.com/users/aeisenberg/events{/privacy}","received_events_url":"https://api.github.com/users/aeisenberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-09T19:48:17Z","updated_at":"2016-09-12T08:31:19Z","closed_at":null,"body":"The documentation for `popover` mentions, `mac-popover-refresh-on` as a scope attribute, but that does not seem to work. Here is the template text I am using:\r\n\r\n```\r\n<mac-popover\r\n  mac-popover-direction=\"below right\"\r\n  mac-popover-refresh-on=\"collapsable-table-header-changed\"\r\n  id=\"{{::directiveDetailsPopup.popoverId}}\">\r\n  <div class=\"directive--tooltip\">\r\n    <pre>{{directiveDetailsPopup.format()}}</pre>\r\n  </div>\r\n</mac-popover>\r\n```\r\n\r\nI would expect that whenever the `collapsable-table-header-changed` event is emitted on $rootScope, then the location and size of this popover will be recalculated. However, that is not happening. \r\n\r\nLooking at the code. I think the problem has to do with the declaration of `macPopoverDefaults` constant:\r\n```\r\nconstant('macPopoverDefaults', {\r\n  trigger: {\r\n    offsetY: 0,\r\n    offsetX: 0,\r\n    trigger: 'click',\r\n    container: null\r\n  },\r\n  element: {\r\n    footer: false,\r\n    header: false,\r\n    title: '',\r\n    direction: 'above left'\r\n  },\r\n  template: \"<div class='mac-popover' ng-class='macPopoverClasses'>\\\r\n    <div class='tip'></div>\\\r\n    <div class='popover-header'>\\\r\n      <div class='title'>{{macPopoverTitle}}</div>\\\r\n    </div>\\\r\n    <div mac-popover-fill-content></div>\\\r\n  </div>\"\r\n}).\r\n```\r\nThere needs to explicitly be added a `refreshOn` property (set to null or undefined). It should be an easy fix."},"comment":{"url":"https://api.github.com/repos/angular-macgyver/MacGyver/issues/comments/246281845","html_url":"https://github.com/angular-macgyver/MacGyver/issues/38#issuecomment-246281845","issue_url":"https://api.github.com/repos/angular-macgyver/MacGyver/issues/38","id":246281845,"user":{"login":"adrianlee44","id":208855,"avatar_url":"https://avatars.githubusercontent.com/u/208855?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianlee44","html_url":"https://github.com/adrianlee44","followers_url":"https://api.github.com/users/adrianlee44/followers","following_url":"https://api.github.com/users/adrianlee44/following{/other_user}","gists_url":"https://api.github.com/users/adrianlee44/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianlee44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianlee44/subscriptions","organizations_url":"https://api.github.com/users/adrianlee44/orgs","repos_url":"https://api.github.com/users/adrianlee44/repos","events_url":"https://api.github.com/users/adrianlee44/events{/privacy}","received_events_url":"https://api.github.com/users/adrianlee44/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T08:31:19Z","updated_at":"2016-09-12T08:31:19Z","body":"Thanks for reporting this. Taking a look"}}
{"actor":{"display_login":"adrianlee44"}}