{"action":"opened","number":621,"pull_request":{"url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/621","id":67922517,"html_url":"https://github.com/brettwooldridge/HikariCP/pull/621","diff_url":"https://github.com/brettwooldridge/HikariCP/pull/621.diff","patch_url":"https://github.com/brettwooldridge/HikariCP/pull/621.patch","issue_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/621","number":621,"state":"open","locked":false,"title":"Shutdown will throw NPE if invoked from checkFailFast","user":{"login":"johnou","id":323497,"avatar_url":"https://avatars.githubusercontent.com/u/323497?v=3","gravatar_id":"","url":"https://api.github.com/users/johnou","html_url":"https://github.com/johnou","followers_url":"https://api.github.com/users/johnou/followers","following_url":"https://api.github.com/users/johnou/following{/other_user}","gists_url":"https://api.github.com/users/johnou/gists{/gist_id}","starred_url":"https://api.github.com/users/johnou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnou/subscriptions","organizations_url":"https://api.github.com/users/johnou/orgs","repos_url":"https://api.github.com/users/johnou/repos","events_url":"https://api.github.com/users/johnou/events{/privacy}","received_events_url":"https://api.github.com/users/johnou/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nShutdown may be invoked as a result of checkFailFast failing resulting in an NPE as the executors are setup later in the constructor.\r\n\r\nModifications:\r\n\r\nAdd null checks before trying to shutdown the executors.\r\n\r\nResult:\r\n\r\n\"Graceful\" shutdown.","created_at":"2016-04-26T17:05:59Z","updated_at":"2016-04-26T17:05:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/621/commits","review_comments_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/621/comments","review_comment_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/621/comments","statuses_url":"https://api.github.com/repos/brettwooldridge/HikariCP/statuses/b9f275cd0b825fa14cb77aeceed142a736581fba","head":{"label":"johnou:feature/fail_fast_npe","ref":"feature/fail_fast_npe","sha":"b9f275cd0b825fa14cb77aeceed142a736581fba","user":{"login":"johnou","id":323497,"avatar_url":"https://avatars.githubusercontent.com/u/323497?v=3","gravatar_id":"","url":"https://api.github.com/users/johnou","html_url":"https://github.com/johnou","followers_url":"https://api.github.com/users/johnou/followers","following_url":"https://api.github.com/users/johnou/following{/other_user}","gists_url":"https://api.github.com/users/johnou/gists{/gist_id}","starred_url":"https://api.github.com/users/johnou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnou/subscriptions","organizations_url":"https://api.github.com/users/johnou/orgs","repos_url":"https://api.github.com/users/johnou/repos","events_url":"https://api.github.com/users/johnou/events{/privacy}","received_events_url":"https://api.github.com/users/johnou/received_events","type":"User","site_admin":false},"repo":{"id":54729329,"name":"HikariCP","full_name":"johnou/HikariCP","owner":{"login":"johnou","id":323497,"avatar_url":"https://avatars.githubusercontent.com/u/323497?v=3","gravatar_id":"","url":"https://api.github.com/users/johnou","html_url":"https://github.com/johnou","followers_url":"https://api.github.com/users/johnou/followers","following_url":"https://api.github.com/users/johnou/following{/other_user}","gists_url":"https://api.github.com/users/johnou/gists{/gist_id}","starred_url":"https://api.github.com/users/johnou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnou/subscriptions","organizations_url":"https://api.github.com/users/johnou/orgs","repos_url":"https://api.github.com/users/johnou/repos","events_url":"https://api.github.com/users/johnou/events{/privacy}","received_events_url":"https://api.github.com/users/johnou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnou/HikariCP","description":"光 HikariCP・A solid high-performance JDBC connection pool at last.","fork":true,"url":"https://api.github.com/repos/johnou/HikariCP","forks_url":"https://api.github.com/repos/johnou/HikariCP/forks","keys_url":"https://api.github.com/repos/johnou/HikariCP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnou/HikariCP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnou/HikariCP/teams","hooks_url":"https://api.github.com/repos/johnou/HikariCP/hooks","issue_events_url":"https://api.github.com/repos/johnou/HikariCP/issues/events{/number}","events_url":"https://api.github.com/repos/johnou/HikariCP/events","assignees_url":"https://api.github.com/repos/johnou/HikariCP/assignees{/user}","branches_url":"https://api.github.com/repos/johnou/HikariCP/branches{/branch}","tags_url":"https://api.github.com/repos/johnou/HikariCP/tags","blobs_url":"https://api.github.com/repos/johnou/HikariCP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnou/HikariCP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnou/HikariCP/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnou/HikariCP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnou/HikariCP/statuses/{sha}","languages_url":"https://api.github.com/repos/johnou/HikariCP/languages","stargazers_url":"https://api.github.com/repos/johnou/HikariCP/stargazers","contributors_url":"https://api.github.com/repos/johnou/HikariCP/contributors","subscribers_url":"https://api.github.com/repos/johnou/HikariCP/subscribers","subscription_url":"https://api.github.com/repos/johnou/HikariCP/subscription","commits_url":"https://api.github.com/repos/johnou/HikariCP/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnou/HikariCP/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnou/HikariCP/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnou/HikariCP/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnou/HikariCP/contents/{+path}","compare_url":"https://api.github.com/repos/johnou/HikariCP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnou/HikariCP/merges","archive_url":"https://api.github.com/repos/johnou/HikariCP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnou/HikariCP/downloads","issues_url":"https://api.github.com/repos/johnou/HikariCP/issues{/number}","pulls_url":"https://api.github.com/repos/johnou/HikariCP/pulls{/number}","milestones_url":"https://api.github.com/repos/johnou/HikariCP/milestones{/number}","notifications_url":"https://api.github.com/repos/johnou/HikariCP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnou/HikariCP/labels{/name}","releases_url":"https://api.github.com/repos/johnou/HikariCP/releases{/id}","deployments_url":"https://api.github.com/repos/johnou/HikariCP/deployments","created_at":"2016-03-25T15:53:56Z","updated_at":"2016-03-25T15:53:58Z","pushed_at":"2016-04-26T17:04:10Z","git_url":"git://github.com/johnou/HikariCP.git","ssh_url":"git@github.com:johnou/HikariCP.git","clone_url":"https://github.com/johnou/HikariCP.git","svn_url":"https://github.com/johnou/HikariCP","homepage":"http://brettwooldridge.github.io/HikariCP","size":4080,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"brettwooldridge:dev","ref":"dev","sha":"8dde168adb70b1c3b2f18ae4bb2db7c79d859ecb","user":{"login":"brettwooldridge","id":1538661,"avatar_url":"https://avatars.githubusercontent.com/u/1538661?v=3","gravatar_id":"","url":"https://api.github.com/users/brettwooldridge","html_url":"https://github.com/brettwooldridge","followers_url":"https://api.github.com/users/brettwooldridge/followers","following_url":"https://api.github.com/users/brettwooldridge/following{/other_user}","gists_url":"https://api.github.com/users/brettwooldridge/gists{/gist_id}","starred_url":"https://api.github.com/users/brettwooldridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettwooldridge/subscriptions","organizations_url":"https://api.github.com/users/brettwooldridge/orgs","repos_url":"https://api.github.com/users/brettwooldridge/repos","events_url":"https://api.github.com/users/brettwooldridge/events{/privacy}","received_events_url":"https://api.github.com/users/brettwooldridge/received_events","type":"User","site_admin":false},"repo":{"id":13404515,"name":"HikariCP","full_name":"brettwooldridge/HikariCP","owner":{"login":"brettwooldridge","id":1538661,"avatar_url":"https://avatars.githubusercontent.com/u/1538661?v=3","gravatar_id":"","url":"https://api.github.com/users/brettwooldridge","html_url":"https://github.com/brettwooldridge","followers_url":"https://api.github.com/users/brettwooldridge/followers","following_url":"https://api.github.com/users/brettwooldridge/following{/other_user}","gists_url":"https://api.github.com/users/brettwooldridge/gists{/gist_id}","starred_url":"https://api.github.com/users/brettwooldridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettwooldridge/subscriptions","organizations_url":"https://api.github.com/users/brettwooldridge/orgs","repos_url":"https://api.github.com/users/brettwooldridge/repos","events_url":"https://api.github.com/users/brettwooldridge/events{/privacy}","received_events_url":"https://api.github.com/users/brettwooldridge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brettwooldridge/HikariCP","description":"光 HikariCP・A solid high-performance JDBC connection pool at last.","fork":false,"url":"https://api.github.com/repos/brettwooldridge/HikariCP","forks_url":"https://api.github.com/repos/brettwooldridge/HikariCP/forks","keys_url":"https://api.github.com/repos/brettwooldridge/HikariCP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brettwooldridge/HikariCP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brettwooldridge/HikariCP/teams","hooks_url":"https://api.github.com/repos/brettwooldridge/HikariCP/hooks","issue_events_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/events{/number}","events_url":"https://api.github.com/repos/brettwooldridge/HikariCP/events","assignees_url":"https://api.github.com/repos/brettwooldridge/HikariCP/assignees{/user}","branches_url":"https://api.github.com/repos/brettwooldridge/HikariCP/branches{/branch}","tags_url":"https://api.github.com/repos/brettwooldridge/HikariCP/tags","blobs_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/refs{/sha}","trees_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brettwooldridge/HikariCP/statuses/{sha}","languages_url":"https://api.github.com/repos/brettwooldridge/HikariCP/languages","stargazers_url":"https://api.github.com/repos/brettwooldridge/HikariCP/stargazers","contributors_url":"https://api.github.com/repos/brettwooldridge/HikariCP/contributors","subscribers_url":"https://api.github.com/repos/brettwooldridge/HikariCP/subscribers","subscription_url":"https://api.github.com/repos/brettwooldridge/HikariCP/subscription","commits_url":"https://api.github.com/repos/brettwooldridge/HikariCP/commits{/sha}","git_commits_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/commits{/sha}","comments_url":"https://api.github.com/repos/brettwooldridge/HikariCP/comments{/number}","issue_comment_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/comments{/number}","contents_url":"https://api.github.com/repos/brettwooldridge/HikariCP/contents/{+path}","compare_url":"https://api.github.com/repos/brettwooldridge/HikariCP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brettwooldridge/HikariCP/merges","archive_url":"https://api.github.com/repos/brettwooldridge/HikariCP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brettwooldridge/HikariCP/downloads","issues_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues{/number}","pulls_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls{/number}","milestones_url":"https://api.github.com/repos/brettwooldridge/HikariCP/milestones{/number}","notifications_url":"https://api.github.com/repos/brettwooldridge/HikariCP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brettwooldridge/HikariCP/labels{/name}","releases_url":"https://api.github.com/repos/brettwooldridge/HikariCP/releases{/id}","deployments_url":"https://api.github.com/repos/brettwooldridge/HikariCP/deployments","created_at":"2013-10-08T05:43:03Z","updated_at":"2016-04-26T08:50:32Z","pushed_at":"2016-04-26T16:55:26Z","git_url":"git://github.com/brettwooldridge/HikariCP.git","ssh_url":"git@github.com:brettwooldridge/HikariCP.git","clone_url":"https://github.com/brettwooldridge/HikariCP.git","svn_url":"https://github.com/brettwooldridge/HikariCP","homepage":"http://brettwooldridge.github.io/HikariCP","size":4257,"stargazers_count":2637,"watchers_count":2637,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":355,"mirror_url":null,"open_issues_count":29,"forks":355,"open_issues":29,"watchers":2637,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/621"},"html":{"href":"https://github.com/brettwooldridge/HikariCP/pull/621"},"issue":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/621"},"comments":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/621/comments"},"review_comments":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/621/comments"},"review_comment":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/621/commits"},"statuses":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/statuses/b9f275cd0b825fa14cb77aeceed142a736581fba"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":4,"changed_files":1}}