{"action":"created","issue":{"url":"https://api.github.com/repos/andrew-zentner/abmcmc/issues/25","repository_url":"https://api.github.com/repos/andrew-zentner/abmcmc","labels_url":"https://api.github.com/repos/andrew-zentner/abmcmc/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/andrew-zentner/abmcmc/issues/25/comments","events_url":"https://api.github.com/repos/andrew-zentner/abmcmc/issues/25/events","html_url":"https://github.com/andrew-zentner/abmcmc/issues/25","id":160730917,"number":25,"title":"Comments from Frank","user":{"login":"vdbosch69","id":8753905,"avatar_url":"https://avatars.githubusercontent.com/u/8753905?v=3","gravatar_id":"","url":"https://api.github.com/users/vdbosch69","html_url":"https://github.com/vdbosch69","followers_url":"https://api.github.com/users/vdbosch69/followers","following_url":"https://api.github.com/users/vdbosch69/following{/other_user}","gists_url":"https://api.github.com/users/vdbosch69/gists{/gist_id}","starred_url":"https://api.github.com/users/vdbosch69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdbosch69/subscriptions","organizations_url":"https://api.github.com/users/vdbosch69/orgs","repos_url":"https://api.github.com/users/vdbosch69/repos","events_url":"https://api.github.com/users/vdbosch69/events{/privacy}","received_events_url":"https://api.github.com/users/vdbosch69/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-16T18:39:39Z","updated_at":"2016-06-16T18:59:49Z","closed_at":null,"body":"\r\nSection 2.1.2.  I think we need to point out to the reader that our model is subtly different from that of Zehavi et al.  (in terms of us not multiplying <Nsat> with <Ncen>). We can simply mention why we do not include that term, and point out that this does not in any way cause a significant change of the results.\r\nIn my opinion we CANNOT say that we mimic the standard HOD of Zehavi et al. without mentioning this difference.\r\n\r\nSection 2.1.4. I think we should give a bit more detail as to the computation of w_p, beyond `as described in detail in http://halotools.readthedocs.io'.  I am a strong oponent of papers having to be self-containing as much as possible. I suggest we say a few words about how we construct the randoms.\r\n\r\nFor the same reason, I think the paper should also be a bit more explicit regarding the Decorated HOD model. I have included now, in section 2.2, an equation that makes it explicit how Acen and Asat modify the HOD (this is only valid for f_split =0.5, as I indicate). PLEASE CHECK TO MAKE SURE THAT THIS EQUATION IS CORRECT.\r\n\r\nI have added a summation sign to the first term in Eq. 4. If you don't like it, than please point out that we use Einstein summation convention....\r\n\r\nIn Section 3.1, first paragraph, you write that the 50 randomly selected models in Figs 2-4 are selected from the MCMC chains within Delta Chi2 < 1. However, in the caption of Fig 2 you write that you use Delta Chi2 < 5.89....This needs to be corrected. Also, when quoting such specific numbers, make sure \r\nthat they are consistent with a statement in captions of Figs 3 and 4 that state `same as fig 2....'\r\n\r\nCaption of Table 3.2 and Section 3.2, third paragraph. I do NOT understand what you mean by\r\n..`where the posterior on a parameter is monotonic within the physical parameter space'....Could you please rephrase this...\r\n\r\nFinally, I have corrected a few typos in the text."},"comment":{"url":"https://api.github.com/repos/andrew-zentner/abmcmc/issues/comments/226581100","html_url":"https://github.com/andrew-zentner/abmcmc/issues/25#issuecomment-226581100","issue_url":"https://api.github.com/repos/andrew-zentner/abmcmc/issues/25","id":226581100,"user":{"login":"aphearin","id":6951595,"avatar_url":"https://avatars.githubusercontent.com/u/6951595?v=3","gravatar_id":"","url":"https://api.github.com/users/aphearin","html_url":"https://github.com/aphearin","followers_url":"https://api.github.com/users/aphearin/followers","following_url":"https://api.github.com/users/aphearin/following{/other_user}","gists_url":"https://api.github.com/users/aphearin/gists{/gist_id}","starred_url":"https://api.github.com/users/aphearin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphearin/subscriptions","organizations_url":"https://api.github.com/users/aphearin/orgs","repos_url":"https://api.github.com/users/aphearin/repos","events_url":"https://api.github.com/users/aphearin/events{/privacy}","received_events_url":"https://api.github.com/users/aphearin/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T18:59:49Z","updated_at":"2016-06-16T18:59:49Z","body":"Ok @vdbosch69. I think we just disagree, but I also don't think this is worth arguing about, so if you already took the time to implement the change then I'm certainly fine with having this appear in the draft. "}}
{"actor":{"display_login":"aphearin"}}