{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/72193039","id":72193039,"diff_hunk":"@@ -75,6 +85,11 @@ def process_event(event)\n     case event_data[:kind]\n     when 'Node'\n       event_data[:container_node_name] = event_data[:name]\n+      # Workaround for missing/useless node UID (#9600, https://github.com/kubernetes/kubernetes/issues/29289)\n+      if event_data[:uid].nil? || event_data[:uid] == event_data[:name]\n+        node = ContainerNode.find_by(:ems_id => @ems.id, :name => event_data[:name])\n+        event_data[:uid] = node ? node.ems_ref : nil","path":"app/models/manageiq/providers/kubernetes/container_manager/event_catcher_mixin.rb","position":null,"original_position":33,"commit_id":"241d7d8f75867ff4aedd48ae9ca5123f4a822d23","original_commit_id":"3ff3ca38dffd69f9e14167cf7ace7471467ca650","user":{"login":"cben","id":273688,"avatar_url":"https://avatars.githubusercontent.com/u/273688?v=3","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-07-26T06:18:08Z","updated_at":"2016-07-26T06:18:08Z","html_url":"https://github.com/ManageIQ/manageiq/pull/9913#discussion_r72193039","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9913","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/72193039"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9913#discussion_r72193039"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9913"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9913","id":77984644,"html_url":"https://github.com/ManageIQ/manageiq/pull/9913","diff_url":"https://github.com/ManageIQ/manageiq/pull/9913.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9913.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9913","number":9913,"state":"open","locked":false,"title":"EmsEvent: set container_node_id by ems & name when event has no UID","user":{"login":"cben","id":273688,"avatar_url":"https://avatars.githubusercontent.com/u/273688?v=3","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"body":"Workaround for #9600, acknowledged as upsteam bug kubernetes/kubernetes#29289.\r\nEnsures later the EmsEvent's container_node_id is set (#9600), if we have the node in inventory at event arrival.\r\nCovers both missing involvedObject.uid and node name given as uid which I'm seeing in some events.\r\n\r\nIt's being fixed in Kubernetes but we need this anyway to support existing versions with this bug (at least v1.2.0 .. v1.4.0-alpha.1).\r\n\r\n#9600 doesn't currently have it's own BZ (not even sure it's user-visible, maybe in node Timeline?)\r\nbut this fix is important for node event -> policy support (#9601, #9813) whose BZs are:\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1341253 (master)\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1346057 (darga)\r\n\r\n@miq-bot add-label bug, providers/containers, darga/yes","created_at":"2016-07-19T14:21:12Z","updated_at":"2016-07-26T06:18:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ba90c1b060aeb4245c77b66a73f74c11f0f41df","assignee":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"assignees":[{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9913/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9913/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9913/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/241d7d8f75867ff4aedd48ae9ca5123f4a822d23","head":{"label":"cben:container_node_id","ref":"container_node_id","sha":"241d7d8f75867ff4aedd48ae9ca5123f4a822d23","user":{"login":"cben","id":273688,"avatar_url":"https://avatars.githubusercontent.com/u/273688?v=3","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"repo":{"id":51248694,"name":"manageiq","full_name":"cben/manageiq","owner":{"login":"cben","id":273688,"avatar_url":"https://avatars.githubusercontent.com/u/273688?v=3","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cben/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/cben/manageiq","forks_url":"https://api.github.com/repos/cben/manageiq/forks","keys_url":"https://api.github.com/repos/cben/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cben/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cben/manageiq/teams","hooks_url":"https://api.github.com/repos/cben/manageiq/hooks","issue_events_url":"https://api.github.com/repos/cben/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/cben/manageiq/events","assignees_url":"https://api.github.com/repos/cben/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/cben/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/cben/manageiq/tags","blobs_url":"https://api.github.com/repos/cben/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cben/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cben/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/cben/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cben/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/cben/manageiq/languages","stargazers_url":"https://api.github.com/repos/cben/manageiq/stargazers","contributors_url":"https://api.github.com/repos/cben/manageiq/contributors","subscribers_url":"https://api.github.com/repos/cben/manageiq/subscribers","subscription_url":"https://api.github.com/repos/cben/manageiq/subscription","commits_url":"https://api.github.com/repos/cben/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/cben/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/cben/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/cben/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/cben/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/cben/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cben/manageiq/merges","archive_url":"https://api.github.com/repos/cben/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cben/manageiq/downloads","issues_url":"https://api.github.com/repos/cben/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/cben/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/cben/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/cben/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cben/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/cben/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/cben/manageiq/deployments","created_at":"2016-02-07T13:36:17Z","updated_at":"2016-02-07T13:36:35Z","pushed_at":"2016-07-26T06:17:41Z","git_url":"git://github.com/cben/manageiq.git","ssh_url":"git@github.com:cben/manageiq.git","clone_url":"https://github.com/cben/manageiq.git","svn_url":"https://github.com/cben/manageiq","homepage":"manageiq.org","size":141293,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"3991cd545b7693a972f9df4cfeefc4c633a59428","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-07-13T16:26:10Z","pushed_at":"2016-07-26T06:17:42Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":182296,"stargazers_count":299,"watchers_count":299,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":748,"forks":328,"open_issues":748,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9913"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9913"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9913"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9913/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9913/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9913/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/241d7d8f75867ff4aedd48ae9ca5123f4a822d23"}}}}
{"actor":{"display_login":"cben"}}