{"action":"created","comment":{"url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/comments/68558631","id":68558631,"diff_hunk":"@@ -23,14 +23,14 @@ export default class Daily extends Component {\n         </div>\n         <div className=\"daily-itemlistwrapprt\">\n           <ul className=\"daily-itemlist\">\n-          { _.map(dailyTop, (a) => {\n+          { _.map(dailyTop, (a, idx) => {\n             const pubDate = date2yyyymmdd(a.publishedDate, '.')\n             if (a.state == 'published') {\n               let imageSet = imageComposer(a)\n               let thumbnail = imageSet.mobileImage\n               let url = '/a/' + a.slug\n               return (\n-                <li className=\"daily-item\" key={a._id}>\n+                <li className=\"daily-item\" key={idx}>","path":"src/components/Daily.js","position":13,"original_position":13,"commit_id":"9ffe38fc3a101f98154d7bca396ad85b8f14b8e4","original_commit_id":"9ffe38fc3a101f98154d7bca396ad85b8f14b8e4","user":{"login":"aqutw","id":7347009,"avatar_url":"https://avatars.githubusercontent.com/u/7347009?v=3","gravatar_id":"","url":"https://api.github.com/users/aqutw","html_url":"https://github.com/aqutw","followers_url":"https://api.github.com/users/aqutw/followers","following_url":"https://api.github.com/users/aqutw/following{/other_user}","gists_url":"https://api.github.com/users/aqutw/gists{/gist_id}","starred_url":"https://api.github.com/users/aqutw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqutw/subscriptions","organizations_url":"https://api.github.com/users/aqutw/orgs","repos_url":"https://api.github.com/users/aqutw/repos","events_url":"https://api.github.com/users/aqutw/events{/privacy}","received_events_url":"https://api.github.com/users/aqutw/received_events","type":"User","site_admin":false},"body":"1.\r\nAlthough `{a.id || idx}` is also a way, \r\nI first prefer that decoupling Frontend logic from Backend value when they are not related.\r\n\r\n2.\r\nSecondly, I prefer `{a.id}` because it make sure all DOM use value from Backend.\r\n\r\n3.\r\nI don't prefer use `{a.id || idx}`:\r\nFor the value of key, this way might be ambiguity.\r\n\r\nPS:\r\nSometimes, we need share the same value between Frontend & Backend parts together, \r\nbut here we are not.\r\n\r\n\r\n\r\n","created_at":"2016-06-27T11:07:26Z","updated_at":"2016-06-27T11:07:26Z","html_url":"https://github.com/twreporter/twreporter-react/pull/238#discussion_r68558631","pull_request_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/comments/68558631"},"html":{"href":"https://github.com/twreporter/twreporter-react/pull/238#discussion_r68558631"},"pull_request":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/238","id":75233308,"html_url":"https://github.com/twreporter/twreporter-react/pull/238","diff_url":"https://github.com/twreporter/twreporter-react/pull/238.diff","patch_url":"https://github.com/twreporter/twreporter-react/pull/238.patch","issue_url":"https://api.github.com/repos/twreporter/twreporter-react/issues/238","number":238,"state":"open","locked":false,"title":"mini-refine for revamp branch for component key","user":{"login":"aqutw","id":7347009,"avatar_url":"https://avatars.githubusercontent.com/u/7347009?v=3","gravatar_id":"","url":"https://api.github.com/users/aqutw","html_url":"https://github.com/aqutw","followers_url":"https://api.github.com/users/aqutw/followers","following_url":"https://api.github.com/users/aqutw/following{/other_user}","gists_url":"https://api.github.com/users/aqutw/gists{/gist_id}","starred_url":"https://api.github.com/users/aqutw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqutw/subscriptions","organizations_url":"https://api.github.com/users/aqutw/orgs","repos_url":"https://api.github.com/users/aqutw/repos","events_url":"https://api.github.com/users/aqutw/events{/privacy}","received_events_url":"https://api.github.com/users/aqutw/received_events","type":"User","site_admin":false},"body":"mini-refine for revamp branch for component key","created_at":"2016-06-26T16:03:45Z","updated_at":"2016-06-27T11:07:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27e4156383a8d83a3895fcf0763493c234e989ac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/238/commits","review_comments_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/238/comments","review_comment_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twreporter/twreporter-react/issues/238/comments","statuses_url":"https://api.github.com/repos/twreporter/twreporter-react/statuses/9ffe38fc3a101f98154d7bca396ad85b8f14b8e4","head":{"label":"aqutw:revampB","ref":"revampB","sha":"9ffe38fc3a101f98154d7bca396ad85b8f14b8e4","user":{"login":"aqutw","id":7347009,"avatar_url":"https://avatars.githubusercontent.com/u/7347009?v=3","gravatar_id":"","url":"https://api.github.com/users/aqutw","html_url":"https://github.com/aqutw","followers_url":"https://api.github.com/users/aqutw/followers","following_url":"https://api.github.com/users/aqutw/following{/other_user}","gists_url":"https://api.github.com/users/aqutw/gists{/gist_id}","starred_url":"https://api.github.com/users/aqutw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqutw/subscriptions","organizations_url":"https://api.github.com/users/aqutw/orgs","repos_url":"https://api.github.com/users/aqutw/repos","events_url":"https://api.github.com/users/aqutw/events{/privacy}","received_events_url":"https://api.github.com/users/aqutw/received_events","type":"User","site_admin":false},"repo":{"id":61996519,"name":"twreporter-react","full_name":"aqutw/twreporter-react","owner":{"login":"aqutw","id":7347009,"avatar_url":"https://avatars.githubusercontent.com/u/7347009?v=3","gravatar_id":"","url":"https://api.github.com/users/aqutw","html_url":"https://github.com/aqutw","followers_url":"https://api.github.com/users/aqutw/followers","following_url":"https://api.github.com/users/aqutw/following{/other_user}","gists_url":"https://api.github.com/users/aqutw/gists{/gist_id}","starred_url":"https://api.github.com/users/aqutw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqutw/subscriptions","organizations_url":"https://api.github.com/users/aqutw/orgs","repos_url":"https://api.github.com/users/aqutw/repos","events_url":"https://api.github.com/users/aqutw/events{/privacy}","received_events_url":"https://api.github.com/users/aqutw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aqutw/twreporter-react","description":"twreporter site with node.js","fork":true,"url":"https://api.github.com/repos/aqutw/twreporter-react","forks_url":"https://api.github.com/repos/aqutw/twreporter-react/forks","keys_url":"https://api.github.com/repos/aqutw/twreporter-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aqutw/twreporter-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aqutw/twreporter-react/teams","hooks_url":"https://api.github.com/repos/aqutw/twreporter-react/hooks","issue_events_url":"https://api.github.com/repos/aqutw/twreporter-react/issues/events{/number}","events_url":"https://api.github.com/repos/aqutw/twreporter-react/events","assignees_url":"https://api.github.com/repos/aqutw/twreporter-react/assignees{/user}","branches_url":"https://api.github.com/repos/aqutw/twreporter-react/branches{/branch}","tags_url":"https://api.github.com/repos/aqutw/twreporter-react/tags","blobs_url":"https://api.github.com/repos/aqutw/twreporter-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aqutw/twreporter-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aqutw/twreporter-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/aqutw/twreporter-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aqutw/twreporter-react/statuses/{sha}","languages_url":"https://api.github.com/repos/aqutw/twreporter-react/languages","stargazers_url":"https://api.github.com/repos/aqutw/twreporter-react/stargazers","contributors_url":"https://api.github.com/repos/aqutw/twreporter-react/contributors","subscribers_url":"https://api.github.com/repos/aqutw/twreporter-react/subscribers","subscription_url":"https://api.github.com/repos/aqutw/twreporter-react/subscription","commits_url":"https://api.github.com/repos/aqutw/twreporter-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/aqutw/twreporter-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/aqutw/twreporter-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/aqutw/twreporter-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/aqutw/twreporter-react/contents/{+path}","compare_url":"https://api.github.com/repos/aqutw/twreporter-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aqutw/twreporter-react/merges","archive_url":"https://api.github.com/repos/aqutw/twreporter-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aqutw/twreporter-react/downloads","issues_url":"https://api.github.com/repos/aqutw/twreporter-react/issues{/number}","pulls_url":"https://api.github.com/repos/aqutw/twreporter-react/pulls{/number}","milestones_url":"https://api.github.com/repos/aqutw/twreporter-react/milestones{/number}","notifications_url":"https://api.github.com/repos/aqutw/twreporter-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aqutw/twreporter-react/labels{/name}","releases_url":"https://api.github.com/repos/aqutw/twreporter-react/releases{/id}","deployments_url":"https://api.github.com/repos/aqutw/twreporter-react/deployments","created_at":"2016-06-26T15:55:02Z","updated_at":"2016-06-26T15:55:03Z","pushed_at":"2016-06-26T16:01:38Z","git_url":"git://github.com/aqutw/twreporter-react.git","ssh_url":"git@github.com:aqutw/twreporter-react.git","clone_url":"https://github.com/aqutw/twreporter-react.git","svn_url":"https://github.com/aqutw/twreporter-react","homepage":null,"size":6605,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twreporter:revamp","ref":"revamp","sha":"505cb1862d2c2c77bb0e3b9c69cf2f5dff2a3e49","user":{"login":"twreporter","id":13784512,"avatar_url":"https://avatars.githubusercontent.com/u/13784512?v=3","gravatar_id":"","url":"https://api.github.com/users/twreporter","html_url":"https://github.com/twreporter","followers_url":"https://api.github.com/users/twreporter/followers","following_url":"https://api.github.com/users/twreporter/following{/other_user}","gists_url":"https://api.github.com/users/twreporter/gists{/gist_id}","starred_url":"https://api.github.com/users/twreporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twreporter/subscriptions","organizations_url":"https://api.github.com/users/twreporter/orgs","repos_url":"https://api.github.com/users/twreporter/repos","events_url":"https://api.github.com/users/twreporter/events{/privacy}","received_events_url":"https://api.github.com/users/twreporter/received_events","type":"Organization","site_admin":false},"repo":{"id":43805497,"name":"twreporter-react","full_name":"twreporter/twreporter-react","owner":{"login":"twreporter","id":13784512,"avatar_url":"https://avatars.githubusercontent.com/u/13784512?v=3","gravatar_id":"","url":"https://api.github.com/users/twreporter","html_url":"https://github.com/twreporter","followers_url":"https://api.github.com/users/twreporter/followers","following_url":"https://api.github.com/users/twreporter/following{/other_user}","gists_url":"https://api.github.com/users/twreporter/gists{/gist_id}","starred_url":"https://api.github.com/users/twreporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twreporter/subscriptions","organizations_url":"https://api.github.com/users/twreporter/orgs","repos_url":"https://api.github.com/users/twreporter/repos","events_url":"https://api.github.com/users/twreporter/events{/privacy}","received_events_url":"https://api.github.com/users/twreporter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twreporter/twreporter-react","description":"twreporter site with node.js","fork":false,"url":"https://api.github.com/repos/twreporter/twreporter-react","forks_url":"https://api.github.com/repos/twreporter/twreporter-react/forks","keys_url":"https://api.github.com/repos/twreporter/twreporter-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twreporter/twreporter-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twreporter/twreporter-react/teams","hooks_url":"https://api.github.com/repos/twreporter/twreporter-react/hooks","issue_events_url":"https://api.github.com/repos/twreporter/twreporter-react/issues/events{/number}","events_url":"https://api.github.com/repos/twreporter/twreporter-react/events","assignees_url":"https://api.github.com/repos/twreporter/twreporter-react/assignees{/user}","branches_url":"https://api.github.com/repos/twreporter/twreporter-react/branches{/branch}","tags_url":"https://api.github.com/repos/twreporter/twreporter-react/tags","blobs_url":"https://api.github.com/repos/twreporter/twreporter-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twreporter/twreporter-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twreporter/twreporter-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/twreporter/twreporter-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twreporter/twreporter-react/statuses/{sha}","languages_url":"https://api.github.com/repos/twreporter/twreporter-react/languages","stargazers_url":"https://api.github.com/repos/twreporter/twreporter-react/stargazers","contributors_url":"https://api.github.com/repos/twreporter/twreporter-react/contributors","subscribers_url":"https://api.github.com/repos/twreporter/twreporter-react/subscribers","subscription_url":"https://api.github.com/repos/twreporter/twreporter-react/subscription","commits_url":"https://api.github.com/repos/twreporter/twreporter-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/twreporter/twreporter-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/twreporter/twreporter-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/twreporter/twreporter-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/twreporter/twreporter-react/contents/{+path}","compare_url":"https://api.github.com/repos/twreporter/twreporter-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twreporter/twreporter-react/merges","archive_url":"https://api.github.com/repos/twreporter/twreporter-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twreporter/twreporter-react/downloads","issues_url":"https://api.github.com/repos/twreporter/twreporter-react/issues{/number}","pulls_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls{/number}","milestones_url":"https://api.github.com/repos/twreporter/twreporter-react/milestones{/number}","notifications_url":"https://api.github.com/repos/twreporter/twreporter-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twreporter/twreporter-react/labels{/name}","releases_url":"https://api.github.com/repos/twreporter/twreporter-react/releases{/id}","deployments_url":"https://api.github.com/repos/twreporter/twreporter-react/deployments","created_at":"2015-10-07T09:12:39Z","updated_at":"2016-06-25T13:42:21Z","pushed_at":"2016-06-27T10:14:22Z","git_url":"git://github.com/twreporter/twreporter-react.git","ssh_url":"git@github.com:twreporter/twreporter-react.git","clone_url":"https://github.com/twreporter/twreporter-react.git","svn_url":"https://github.com/twreporter/twreporter-react","homepage":null,"size":6608,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":9,"forks":36,"open_issues":9,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/238"},"html":{"href":"https://github.com/twreporter/twreporter-react/pull/238"},"issue":{"href":"https://api.github.com/repos/twreporter/twreporter-react/issues/238"},"comments":{"href":"https://api.github.com/repos/twreporter/twreporter-react/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/twreporter/twreporter-react/statuses/9ffe38fc3a101f98154d7bca396ad85b8f14b8e4"}}}}
{"actor":{"display_login":"aqutw"}}