{"action":"closed","number":679,"pull_request":{"url":"https://api.github.com/repos/bkaradzic/bgfx/pulls/679","id":59302372,"html_url":"https://github.com/bkaradzic/bgfx/pull/679","diff_url":"https://github.com/bkaradzic/bgfx/pull/679.diff","patch_url":"https://github.com/bkaradzic/bgfx/pull/679.patch","issue_url":"https://api.github.com/repos/bkaradzic/bgfx/issues/679","number":679,"state":"closed","locked":false,"title":"Support for targeting different cubemap faces when creating framebuffers.","user":{"login":"andr3wmac","id":862932,"avatar_url":"https://avatars.githubusercontent.com/u/862932?v=3","gravatar_id":"","url":"https://api.github.com/users/andr3wmac","html_url":"https://github.com/andr3wmac","followers_url":"https://api.github.com/users/andr3wmac/followers","following_url":"https://api.github.com/users/andr3wmac/following{/other_user}","gists_url":"https://api.github.com/users/andr3wmac/gists{/gist_id}","starred_url":"https://api.github.com/users/andr3wmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andr3wmac/subscriptions","organizations_url":"https://api.github.com/users/andr3wmac/orgs","repos_url":"https://api.github.com/users/andr3wmac/repos","events_url":"https://api.github.com/users/andr3wmac/events{/privacy}","received_events_url":"https://api.github.com/users/andr3wmac/received_events","type":"User","site_admin":false},"body":"Adds a flags parameter to framebuffer creation that allows specifying a cubemap side to target. Tested and working well in D3D11 and OpenGL. Example usage:\r\n\r\n    fbh = bgfx::createFrameBuffer(1, &m_cubemap, false, BGFX_FRAMEBUFFER_CUBE_MAP_NEGATIVE_Y);\r\n\r\nI added the code for D3D9 but it doesn't appear to be working even though it looks like everything is in order. Maybe you can spot the issue. It seems to always target side 0. Missing support for D3D12 and Metal.","created_at":"2016-02-14T18:42:31Z","updated_at":"2016-02-14T19:26:06Z","closed_at":"2016-02-14T19:26:06Z","merged_at":null,"merge_commit_sha":"c12049a09e91c0f5621cc88f024d69e4c495ac7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bkaradzic/bgfx/pulls/679/commits","review_comments_url":"https://api.github.com/repos/bkaradzic/bgfx/pulls/679/comments","review_comment_url":"https://api.github.com/repos/bkaradzic/bgfx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bkaradzic/bgfx/issues/679/comments","statuses_url":"https://api.github.com/repos/bkaradzic/bgfx/statuses/0bb71a785048e5bc5d819cd9fc38f1e6e991d012","head":{"label":"andr3wmac:render_to_cubemap","ref":"render_to_cubemap","sha":"0bb71a785048e5bc5d819cd9fc38f1e6e991d012","user":{"login":"andr3wmac","id":862932,"avatar_url":"https://avatars.githubusercontent.com/u/862932?v=3","gravatar_id":"","url":"https://api.github.com/users/andr3wmac","html_url":"https://github.com/andr3wmac","followers_url":"https://api.github.com/users/andr3wmac/followers","following_url":"https://api.github.com/users/andr3wmac/following{/other_user}","gists_url":"https://api.github.com/users/andr3wmac/gists{/gist_id}","starred_url":"https://api.github.com/users/andr3wmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andr3wmac/subscriptions","organizations_url":"https://api.github.com/users/andr3wmac/orgs","repos_url":"https://api.github.com/users/andr3wmac/repos","events_url":"https://api.github.com/users/andr3wmac/events{/privacy}","received_events_url":"https://api.github.com/users/andr3wmac/received_events","type":"User","site_admin":false},"repo":{"id":40401901,"name":"bgfx","full_name":"andr3wmac/bgfx","owner":{"login":"andr3wmac","id":862932,"avatar_url":"https://avatars.githubusercontent.com/u/862932?v=3","gravatar_id":"","url":"https://api.github.com/users/andr3wmac","html_url":"https://github.com/andr3wmac","followers_url":"https://api.github.com/users/andr3wmac/followers","following_url":"https://api.github.com/users/andr3wmac/following{/other_user}","gists_url":"https://api.github.com/users/andr3wmac/gists{/gist_id}","starred_url":"https://api.github.com/users/andr3wmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andr3wmac/subscriptions","organizations_url":"https://api.github.com/users/andr3wmac/orgs","repos_url":"https://api.github.com/users/andr3wmac/repos","events_url":"https://api.github.com/users/andr3wmac/events{/privacy}","received_events_url":"https://api.github.com/users/andr3wmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andr3wmac/bgfx","description":"Cross-platform, graphics API agnostic, \"Bring Your Own Engine/Framework\" style rendering library.","fork":true,"url":"https://api.github.com/repos/andr3wmac/bgfx","forks_url":"https://api.github.com/repos/andr3wmac/bgfx/forks","keys_url":"https://api.github.com/repos/andr3wmac/bgfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andr3wmac/bgfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andr3wmac/bgfx/teams","hooks_url":"https://api.github.com/repos/andr3wmac/bgfx/hooks","issue_events_url":"https://api.github.com/repos/andr3wmac/bgfx/issues/events{/number}","events_url":"https://api.github.com/repos/andr3wmac/bgfx/events","assignees_url":"https://api.github.com/repos/andr3wmac/bgfx/assignees{/user}","branches_url":"https://api.github.com/repos/andr3wmac/bgfx/branches{/branch}","tags_url":"https://api.github.com/repos/andr3wmac/bgfx/tags","blobs_url":"https://api.github.com/repos/andr3wmac/bgfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andr3wmac/bgfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andr3wmac/bgfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/andr3wmac/bgfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andr3wmac/bgfx/statuses/{sha}","languages_url":"https://api.github.com/repos/andr3wmac/bgfx/languages","stargazers_url":"https://api.github.com/repos/andr3wmac/bgfx/stargazers","contributors_url":"https://api.github.com/repos/andr3wmac/bgfx/contributors","subscribers_url":"https://api.github.com/repos/andr3wmac/bgfx/subscribers","subscription_url":"https://api.github.com/repos/andr3wmac/bgfx/subscription","commits_url":"https://api.github.com/repos/andr3wmac/bgfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/andr3wmac/bgfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/andr3wmac/bgfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/andr3wmac/bgfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/andr3wmac/bgfx/contents/{+path}","compare_url":"https://api.github.com/repos/andr3wmac/bgfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andr3wmac/bgfx/merges","archive_url":"https://api.github.com/repos/andr3wmac/bgfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andr3wmac/bgfx/downloads","issues_url":"https://api.github.com/repos/andr3wmac/bgfx/issues{/number}","pulls_url":"https://api.github.com/repos/andr3wmac/bgfx/pulls{/number}","milestones_url":"https://api.github.com/repos/andr3wmac/bgfx/milestones{/number}","notifications_url":"https://api.github.com/repos/andr3wmac/bgfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andr3wmac/bgfx/labels{/name}","releases_url":"https://api.github.com/repos/andr3wmac/bgfx/releases{/id}","deployments_url":"https://api.github.com/repos/andr3wmac/bgfx/deployments","created_at":"2015-08-08T12:16:28Z","updated_at":"2016-02-14T18:02:01Z","pushed_at":"2016-02-14T18:52:14Z","git_url":"git://github.com/andr3wmac/bgfx.git","ssh_url":"git@github.com:andr3wmac/bgfx.git","clone_url":"https://github.com/andr3wmac/bgfx.git","svn_url":"https://github.com/andr3wmac/bgfx","homepage":"","size":80346,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bkaradzic:master","ref":"master","sha":"94b6e384a12f74621cbcfa62f1b8815b322110dc","user":{"login":"bkaradzic","id":814772,"avatar_url":"https://avatars.githubusercontent.com/u/814772?v=3","gravatar_id":"","url":"https://api.github.com/users/bkaradzic","html_url":"https://github.com/bkaradzic","followers_url":"https://api.github.com/users/bkaradzic/followers","following_url":"https://api.github.com/users/bkaradzic/following{/other_user}","gists_url":"https://api.github.com/users/bkaradzic/gists{/gist_id}","starred_url":"https://api.github.com/users/bkaradzic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkaradzic/subscriptions","organizations_url":"https://api.github.com/users/bkaradzic/orgs","repos_url":"https://api.github.com/users/bkaradzic/repos","events_url":"https://api.github.com/users/bkaradzic/events{/privacy}","received_events_url":"https://api.github.com/users/bkaradzic/received_events","type":"User","site_admin":false},"repo":{"id":3925242,"name":"bgfx","full_name":"bkaradzic/bgfx","owner":{"login":"bkaradzic","id":814772,"avatar_url":"https://avatars.githubusercontent.com/u/814772?v=3","gravatar_id":"","url":"https://api.github.com/users/bkaradzic","html_url":"https://github.com/bkaradzic","followers_url":"https://api.github.com/users/bkaradzic/followers","following_url":"https://api.github.com/users/bkaradzic/following{/other_user}","gists_url":"https://api.github.com/users/bkaradzic/gists{/gist_id}","starred_url":"https://api.github.com/users/bkaradzic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkaradzic/subscriptions","organizations_url":"https://api.github.com/users/bkaradzic/orgs","repos_url":"https://api.github.com/users/bkaradzic/repos","events_url":"https://api.github.com/users/bkaradzic/events{/privacy}","received_events_url":"https://api.github.com/users/bkaradzic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkaradzic/bgfx","description":"Cross-platform, graphics API agnostic, \"Bring Your Own Engine/Framework\" style rendering library.","fork":false,"url":"https://api.github.com/repos/bkaradzic/bgfx","forks_url":"https://api.github.com/repos/bkaradzic/bgfx/forks","keys_url":"https://api.github.com/repos/bkaradzic/bgfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkaradzic/bgfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkaradzic/bgfx/teams","hooks_url":"https://api.github.com/repos/bkaradzic/bgfx/hooks","issue_events_url":"https://api.github.com/repos/bkaradzic/bgfx/issues/events{/number}","events_url":"https://api.github.com/repos/bkaradzic/bgfx/events","assignees_url":"https://api.github.com/repos/bkaradzic/bgfx/assignees{/user}","branches_url":"https://api.github.com/repos/bkaradzic/bgfx/branches{/branch}","tags_url":"https://api.github.com/repos/bkaradzic/bgfx/tags","blobs_url":"https://api.github.com/repos/bkaradzic/bgfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkaradzic/bgfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkaradzic/bgfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkaradzic/bgfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkaradzic/bgfx/statuses/{sha}","languages_url":"https://api.github.com/repos/bkaradzic/bgfx/languages","stargazers_url":"https://api.github.com/repos/bkaradzic/bgfx/stargazers","contributors_url":"https://api.github.com/repos/bkaradzic/bgfx/contributors","subscribers_url":"https://api.github.com/repos/bkaradzic/bgfx/subscribers","subscription_url":"https://api.github.com/repos/bkaradzic/bgfx/subscription","commits_url":"https://api.github.com/repos/bkaradzic/bgfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkaradzic/bgfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkaradzic/bgfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkaradzic/bgfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkaradzic/bgfx/contents/{+path}","compare_url":"https://api.github.com/repos/bkaradzic/bgfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkaradzic/bgfx/merges","archive_url":"https://api.github.com/repos/bkaradzic/bgfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkaradzic/bgfx/downloads","issues_url":"https://api.github.com/repos/bkaradzic/bgfx/issues{/number}","pulls_url":"https://api.github.com/repos/bkaradzic/bgfx/pulls{/number}","milestones_url":"https://api.github.com/repos/bkaradzic/bgfx/milestones{/number}","notifications_url":"https://api.github.com/repos/bkaradzic/bgfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkaradzic/bgfx/labels{/name}","releases_url":"https://api.github.com/repos/bkaradzic/bgfx/releases{/id}","deployments_url":"https://api.github.com/repos/bkaradzic/bgfx/deployments","created_at":"2012-04-04T03:39:04Z","updated_at":"2016-02-14T18:57:15Z","pushed_at":"2016-02-14T18:52:14Z","git_url":"git://github.com/bkaradzic/bgfx.git","ssh_url":"git@github.com:bkaradzic/bgfx.git","clone_url":"https://github.com/bkaradzic/bgfx.git","svn_url":"https://github.com/bkaradzic/bgfx","homepage":"","size":83899,"stargazers_count":1630,"watchers_count":1630,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":279,"mirror_url":null,"open_issues_count":44,"forks":279,"open_issues":44,"watchers":1630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bkaradzic/bgfx/pulls/679"},"html":{"href":"https://github.com/bkaradzic/bgfx/pull/679"},"issue":{"href":"https://api.github.com/repos/bkaradzic/bgfx/issues/679"},"comments":{"href":"https://api.github.com/repos/bkaradzic/bgfx/issues/679/comments"},"review_comments":{"href":"https://api.github.com/repos/bkaradzic/bgfx/pulls/679/comments"},"review_comment":{"href":"https://api.github.com/repos/bkaradzic/bgfx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bkaradzic/bgfx/pulls/679/commits"},"statuses":{"href":"https://api.github.com/repos/bkaradzic/bgfx/statuses/0bb71a785048e5bc5d819cd9fc38f1e6e991d012"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":101,"deletions":60,"changed_files":14}}