{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls/30","id":92837055,"html_url":"https://github.com/eggheadio/egghead-instructor-center/pull/30","diff_url":"https://github.com/eggheadio/egghead-instructor-center/pull/30.diff","patch_url":"https://github.com/eggheadio/egghead-instructor-center/pull/30.patch","issue_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues/30","number":30,"state":"closed","locked":false,"title":"Prepare project for CI runs","user":{"login":"trevordmiller","id":5497885,"avatar_url":"https://avatars.githubusercontent.com/u/5497885?v=3","gravatar_id":"","url":"https://api.github.com/users/trevordmiller","html_url":"https://github.com/trevordmiller","followers_url":"https://api.github.com/users/trevordmiller/followers","following_url":"https://api.github.com/users/trevordmiller/following{/other_user}","gists_url":"https://api.github.com/users/trevordmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/trevordmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevordmiller/subscriptions","organizations_url":"https://api.github.com/users/trevordmiller/orgs","repos_url":"https://api.github.com/users/trevordmiller/repos","events_url":"https://api.github.com/users/trevordmiller/events{/privacy}","received_events_url":"https://api.github.com/users/trevordmiller/received_events","type":"User","site_admin":false},"body":"# Changes\r\n\r\n- Add node version in package.json `engines` for CI and other tools to know what node versions are supported.\r\n- Add `verify` script for CI to run; it ensures tests and builds execute without errors.\r\n- Update `README` with PR and CI info.\r\n- Update `.gitignore` with built living style guide dir.\r\n- Remove `App renders without crashing` test. Currently, [jsdom has issues with React Router](https://github.com/tmpvar/jsdom/issues/1378). There are workarounds, but I would prefer to add separate integration tests later using a real DOM and check that each route renders without errors.  The issues this test was catching before are already being caught by the `build` scripts for compile errors. For runtime errors, I see more value in a separate set of integration tests rather than mocking the DOM.\r\n- Add project to `Codeship` (uses cached `yarn` and `yarn verify` script).\r\n- Add protected `master` branch in GitHub (requires CI pass before merge, and merging to master only by admins).\r\n\r\n# Result For User\r\n\r\n![screen shot 2016-11-08 at 11 41 25 am](https://cloud.githubusercontent.com/assets/5497885/20112427/915efa38-a5a9-11e6-8540-eaf5fa868d2c.png)\r\n\r\n![screen shot 2016-11-08 at 11 40 15 am](https://cloud.githubusercontent.com/assets/5497885/20112426/915d1c86-a5a9-11e6-9164-ecf320dbc159.png)\r\n\r\n---\r\n\r\n![](http://i.giphy.com/jBLJuTezU5tra.gif)","created_at":"2016-11-08T18:52:39Z","updated_at":"2016-11-08T18:53:52Z","closed_at":"2016-11-08T18:53:52Z","merged_at":"2016-11-08T18:53:52Z","merge_commit_sha":"78201d09f89777b46e4bfbd16c3533cdfb1b363a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls/30/commits","review_comments_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls/30/comments","review_comment_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues/30/comments","statuses_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/statuses/579c5667ed2fe739c57d2070137b1de203a4da1c","head":{"label":"eggheadio:ci","ref":"ci","sha":"579c5667ed2fe739c57d2070137b1de203a4da1c","user":{"login":"eggheadio","id":5975001,"avatar_url":"https://avatars.githubusercontent.com/u/5975001?v=3","gravatar_id":"","url":"https://api.github.com/users/eggheadio","html_url":"https://github.com/eggheadio","followers_url":"https://api.github.com/users/eggheadio/followers","following_url":"https://api.github.com/users/eggheadio/following{/other_user}","gists_url":"https://api.github.com/users/eggheadio/gists{/gist_id}","starred_url":"https://api.github.com/users/eggheadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggheadio/subscriptions","organizations_url":"https://api.github.com/users/eggheadio/orgs","repos_url":"https://api.github.com/users/eggheadio/repos","events_url":"https://api.github.com/users/eggheadio/events{/privacy}","received_events_url":"https://api.github.com/users/eggheadio/received_events","type":"Organization","site_admin":false},"repo":{"id":70085883,"name":"egghead-instructor-center","full_name":"eggheadio/egghead-instructor-center","owner":{"login":"eggheadio","id":5975001,"avatar_url":"https://avatars.githubusercontent.com/u/5975001?v=3","gravatar_id":"","url":"https://api.github.com/users/eggheadio","html_url":"https://github.com/eggheadio","followers_url":"https://api.github.com/users/eggheadio/followers","following_url":"https://api.github.com/users/eggheadio/following{/other_user}","gists_url":"https://api.github.com/users/eggheadio/gists{/gist_id}","starred_url":"https://api.github.com/users/eggheadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggheadio/subscriptions","organizations_url":"https://api.github.com/users/eggheadio/orgs","repos_url":"https://api.github.com/users/eggheadio/repos","events_url":"https://api.github.com/users/eggheadio/events{/privacy}","received_events_url":"https://api.github.com/users/eggheadio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggheadio/egghead-instructor-center","description":"egghead.io instructor dashboard","fork":false,"url":"https://api.github.com/repos/eggheadio/egghead-instructor-center","forks_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/forks","keys_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/teams","hooks_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/hooks","issue_events_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues/events{/number}","events_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/events","assignees_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/assignees{/user}","branches_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/branches{/branch}","tags_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/tags","blobs_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/statuses/{sha}","languages_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/languages","stargazers_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/stargazers","contributors_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/contributors","subscribers_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/subscribers","subscription_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/subscription","commits_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/contents/{+path}","compare_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/merges","archive_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/downloads","issues_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues{/number}","pulls_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls{/number}","milestones_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/milestones{/number}","notifications_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/labels{/name}","releases_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/releases{/id}","deployments_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/deployments","created_at":"2016-10-05T18:05:46Z","updated_at":"2016-10-24T16:24:25Z","pushed_at":"2016-11-08T18:53:52Z","git_url":"git://github.com/eggheadio/egghead-instructor-center.git","ssh_url":"git@github.com:eggheadio/egghead-instructor-center.git","clone_url":"https://github.com/eggheadio/egghead-instructor-center.git","svn_url":"https://github.com/eggheadio/egghead-instructor-center","homepage":"https://egghead.io/instructor","size":277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eggheadio:master","ref":"master","sha":"ede1d97dfc38badeb7597e7f149ca4ff15658c18","user":{"login":"eggheadio","id":5975001,"avatar_url":"https://avatars.githubusercontent.com/u/5975001?v=3","gravatar_id":"","url":"https://api.github.com/users/eggheadio","html_url":"https://github.com/eggheadio","followers_url":"https://api.github.com/users/eggheadio/followers","following_url":"https://api.github.com/users/eggheadio/following{/other_user}","gists_url":"https://api.github.com/users/eggheadio/gists{/gist_id}","starred_url":"https://api.github.com/users/eggheadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggheadio/subscriptions","organizations_url":"https://api.github.com/users/eggheadio/orgs","repos_url":"https://api.github.com/users/eggheadio/repos","events_url":"https://api.github.com/users/eggheadio/events{/privacy}","received_events_url":"https://api.github.com/users/eggheadio/received_events","type":"Organization","site_admin":false},"repo":{"id":70085883,"name":"egghead-instructor-center","full_name":"eggheadio/egghead-instructor-center","owner":{"login":"eggheadio","id":5975001,"avatar_url":"https://avatars.githubusercontent.com/u/5975001?v=3","gravatar_id":"","url":"https://api.github.com/users/eggheadio","html_url":"https://github.com/eggheadio","followers_url":"https://api.github.com/users/eggheadio/followers","following_url":"https://api.github.com/users/eggheadio/following{/other_user}","gists_url":"https://api.github.com/users/eggheadio/gists{/gist_id}","starred_url":"https://api.github.com/users/eggheadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggheadio/subscriptions","organizations_url":"https://api.github.com/users/eggheadio/orgs","repos_url":"https://api.github.com/users/eggheadio/repos","events_url":"https://api.github.com/users/eggheadio/events{/privacy}","received_events_url":"https://api.github.com/users/eggheadio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggheadio/egghead-instructor-center","description":"egghead.io instructor dashboard","fork":false,"url":"https://api.github.com/repos/eggheadio/egghead-instructor-center","forks_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/forks","keys_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/teams","hooks_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/hooks","issue_events_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues/events{/number}","events_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/events","assignees_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/assignees{/user}","branches_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/branches{/branch}","tags_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/tags","blobs_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/statuses/{sha}","languages_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/languages","stargazers_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/stargazers","contributors_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/contributors","subscribers_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/subscribers","subscription_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/subscription","commits_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/contents/{+path}","compare_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/merges","archive_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/downloads","issues_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues{/number}","pulls_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls{/number}","milestones_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/milestones{/number}","notifications_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/labels{/name}","releases_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/releases{/id}","deployments_url":"https://api.github.com/repos/eggheadio/egghead-instructor-center/deployments","created_at":"2016-10-05T18:05:46Z","updated_at":"2016-10-24T16:24:25Z","pushed_at":"2016-11-08T18:53:52Z","git_url":"git://github.com/eggheadio/egghead-instructor-center.git","ssh_url":"git@github.com:eggheadio/egghead-instructor-center.git","clone_url":"https://github.com/eggheadio/egghead-instructor-center.git","svn_url":"https://github.com/eggheadio/egghead-instructor-center","homepage":"https://egghead.io/instructor","size":277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls/30"},"html":{"href":"https://github.com/eggheadio/egghead-instructor-center/pull/30"},"issue":{"href":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues/30"},"comments":{"href":"https://api.github.com/repos/eggheadio/egghead-instructor-center/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eggheadio/egghead-instructor-center/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/eggheadio/egghead-instructor-center/statuses/579c5667ed2fe739c57d2070137b1de203a4da1c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"trevordmiller","id":5497885,"avatar_url":"https://avatars.githubusercontent.com/u/5497885?v=3","gravatar_id":"","url":"https://api.github.com/users/trevordmiller","html_url":"https://github.com/trevordmiller","followers_url":"https://api.github.com/users/trevordmiller/followers","following_url":"https://api.github.com/users/trevordmiller/following{/other_user}","gists_url":"https://api.github.com/users/trevordmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/trevordmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevordmiller/subscriptions","organizations_url":"https://api.github.com/users/trevordmiller/orgs","repos_url":"https://api.github.com/users/trevordmiller/repos","events_url":"https://api.github.com/users/trevordmiller/events{/privacy}","received_events_url":"https://api.github.com/users/trevordmiller/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":9,"changed_files":4}}
{"actor":{"display_login":"trevordmiller"}}