{"action":"created","issue":{"url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/122","repository_url":"https://api.github.com/repos/lancaster-university/microbit-dal","labels_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/122/comments","events_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/122/events","html_url":"https://github.com/lancaster-university/microbit-dal/issues/122","id":148820652,"number":122,"title":"Custom configuration support","user":{"login":"pelikhan","id":4175913,"avatar_url":"https://avatars.githubusercontent.com/u/4175913?v=3","gravatar_id":"","url":"https://api.github.com/users/pelikhan","html_url":"https://github.com/pelikhan","followers_url":"https://api.github.com/users/pelikhan/followers","following_url":"https://api.github.com/users/pelikhan/following{/other_user}","gists_url":"https://api.github.com/users/pelikhan/gists{/gist_id}","starred_url":"https://api.github.com/users/pelikhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelikhan/subscriptions","organizations_url":"https://api.github.com/users/pelikhan/orgs","repos_url":"https://api.github.com/users/pelikhan/repos","events_url":"https://api.github.com/users/pelikhan/events{/privacy}","received_events_url":"https://api.github.com/users/pelikhan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/lancaster-university/microbit-dal/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"jamesadevine","id":4742697,"avatar_url":"https://avatars.githubusercontent.com/u/4742697?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesadevine","html_url":"https://github.com/jamesadevine","followers_url":"https://api.github.com/users/jamesadevine/followers","following_url":"https://api.github.com/users/jamesadevine/following{/other_user}","gists_url":"https://api.github.com/users/jamesadevine/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesadevine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesadevine/subscriptions","organizations_url":"https://api.github.com/users/jamesadevine/orgs","repos_url":"https://api.github.com/users/jamesadevine/repos","events_url":"https://api.github.com/users/jamesadevine/events{/privacy}","received_events_url":"https://api.github.com/users/jamesadevine/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-04-16T05:51:12Z","updated_at":"2016-04-18T03:05:16Z","closed_at":null,"body":"The instructions in sample state that one should change some header files from the DAL to get radio working. \r\n\r\nhttps://github.com/lancaster-university/microbit-samples/blob/master/source/MicroBitSamples.h#L53\r\n\r\nChaning files under the `yotta_modules/...` is probably not a great idea. Is there a better way to do this - the ``MicroBitCustomConfig.h`` file way?"},"comment":{"url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/comments/211167653","html_url":"https://github.com/lancaster-university/microbit-dal/issues/122#issuecomment-211167653","issue_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/122","id":211167653,"user":{"login":"pelikhan","id":4175913,"avatar_url":"https://avatars.githubusercontent.com/u/4175913?v=3","gravatar_id":"","url":"https://api.github.com/users/pelikhan","html_url":"https://github.com/pelikhan","followers_url":"https://api.github.com/users/pelikhan/followers","following_url":"https://api.github.com/users/pelikhan/following{/other_user}","gists_url":"https://api.github.com/users/pelikhan/gists{/gist_id}","starred_url":"https://api.github.com/users/pelikhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelikhan/subscriptions","organizations_url":"https://api.github.com/users/pelikhan/orgs","repos_url":"https://api.github.com/users/pelikhan/repos","events_url":"https://api.github.com/users/pelikhan/events{/privacy}","received_events_url":"https://api.github.com/users/pelikhan/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T03:05:15Z","updated_at":"2016-04-18T03:05:15Z","body":"Do you have a pointer to the docs about these global defines? IMO, this is quote important -- specially to disable BLE -- and the yotta approach is not obvious. An example in the samples would be great!\n\nSent from Outlook Mobile<https://aka.ms/djubve>\n\n________________________________\nFrom: Robert May <notifications@github.com>\nSent: Sunday, April 17, 2016 11:43:23 PM\nTo: lancaster-university/microbit-dal\nCc: Peli de Halleux\nSubject: Re: [lancaster-university/microbit-dal] Custom configuration support (#122)\n\n\nI'm not a yotta expert ... but I see a couple of benefits to using the yotta configuration system (at least for some of the configuration values):\n\n  1.  Parameters can be set in the targets. For example this would allow the standard (S110) target to specify different memory limits to the S130 target, allowing both to work without having to customise anything in a project.\n  2.  The yotta defines are globally available to all modules being built. The CustomConfig.h values were only available to the microbit-dal part of a build. (I ran into this in the old codebase when including microbit.h in my main.cpp and printing values for testing purposes. It didn't print the expected (customised values. I considered this surprising 'action at a distance') I suspect many people will fall for this.\n\n-\nYou are receiving this because you were mentioned.\nReply to this email directly or view it on GitHub<https://github.com/lancaster-university/microbit-dal/issues/122#issuecomment-211129719>\n"}}