{"action":"closed","number":20939,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20939","id":58828557,"html_url":"https://github.com/kubernetes/kubernetes/pull/20939","diff_url":"https://github.com/kubernetes/kubernetes/pull/20939.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/20939.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20939","number":20939,"state":"closed","locked":false,"title":"Make all e2e tests use Framework","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"A few e2e tests were not using `Framework` (as noticed in https://github.com/kubernetes/kubernetes/pull/20771/files#r52256471), probably because the tests predated it and were never updated. This gets everything up to spec with best practices.\r\n\r\n@kubernetes/sig-testing ","created_at":"2016-02-09T23:53:38Z","updated_at":"2016-02-11T13:18:39Z","closed_at":"2016-02-11T13:18:39Z","merged_at":"2016-02-11T13:18:39Z","merge_commit_sha":"9a08ee5cefd67d4b4ebd83d328a0b911d5585749","assignee":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20939/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20939/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20939/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/220b5e3e8e728671bb42e374f7a8e23dd0af9937","head":{"label":"ixdy:use-framework","ref":"use-framework","sha":"220b5e3e8e728671bb42e374f7a8e23dd0af9937","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"repo":{"id":30381779,"name":"kubernetes","full_name":"ixdy/kubernetes","owner":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ixdy/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ixdy/kubernetes","forks_url":"https://api.github.com/repos/ixdy/kubernetes/forks","keys_url":"https://api.github.com/repos/ixdy/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ixdy/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ixdy/kubernetes/teams","hooks_url":"https://api.github.com/repos/ixdy/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ixdy/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ixdy/kubernetes/events","assignees_url":"https://api.github.com/repos/ixdy/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ixdy/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ixdy/kubernetes/tags","blobs_url":"https://api.github.com/repos/ixdy/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ixdy/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ixdy/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ixdy/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ixdy/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ixdy/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ixdy/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ixdy/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ixdy/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ixdy/kubernetes/subscription","commits_url":"https://api.github.com/repos/ixdy/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ixdy/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ixdy/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ixdy/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ixdy/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ixdy/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ixdy/kubernetes/merges","archive_url":"https://api.github.com/repos/ixdy/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ixdy/kubernetes/downloads","issues_url":"https://api.github.com/repos/ixdy/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ixdy/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ixdy/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ixdy/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ixdy/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ixdy/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ixdy/kubernetes/deployments","created_at":"2015-02-05T22:25:25Z","updated_at":"2015-02-26T20:09:10Z","pushed_at":"2016-02-09T23:50:42Z","git_url":"git://github.com/ixdy/kubernetes.git","ssh_url":"git@github.com:ixdy/kubernetes.git","clone_url":"https://github.com/ixdy/kubernetes.git","svn_url":"https://github.com/ixdy/kubernetes","homepage":"http://kubernetes.io","size":159875,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c1e79e4264376edec1d12bccd8b34dba659ce8a5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-02-11T12:19:01Z","pushed_at":"2016-02-11T13:18:39Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":322590,"stargazers_count":12613,"watchers_count":12613,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3590,"mirror_url":null,"open_issues_count":2847,"forks":3590,"open_issues":2847,"watchers":12613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20939"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20939"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20939"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20939/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20939/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20939/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/220b5e3e8e728671bb42e374f7a8e23dd0af9937"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":18,"deletions":52,"changed_files":5}}