{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/comments/54101661","id":54101661,"diff_hunk":"@@ -44,41 +44,55 @@ class TestTooLongAlarm(unittest.TestCase):\n     def setUp(self):\n         pass\n \n-    @patch(\"metaswitch.clearwater.cluster_manager.alarms.issue_alarm\")\n-    def test_raising(self, mock_issue_alarm):\n+    @patch(\"metaswitch.clearwater.cluster_manager.alarms.alarm_manager\")\n+    def test_correct_alarm(self, mock_alarm_manager):\n+        alarm = TooLongAlarm(0.1)\n+        mock_get_alarm = mock_alarm_manager.get_alarm\n+        mock_get_alarm.assert_called_once_with('cluster-manager',\n+                                               TOO_LONG_CLUSTERING)\n+","path":"src/metaswitch/clearwater/cluster_manager/test/test_alarms.py","position":21,"original_position":21,"commit_id":"89537bca8b8dc3859af4501e5cd9f1ffbfa690e5","original_commit_id":"89537bca8b8dc3859af4501e5cd9f1ffbfa690e5","user":{"login":"chris-elford-metaswitch","id":2103471,"avatar_url":"https://avatars.githubusercontent.com/u/2103471?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-elford-metaswitch","html_url":"https://github.com/chris-elford-metaswitch","followers_url":"https://api.github.com/users/chris-elford-metaswitch/followers","following_url":"https://api.github.com/users/chris-elford-metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/chris-elford-metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-elford-metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-elford-metaswitch/subscriptions","organizations_url":"https://api.github.com/users/chris-elford-metaswitch/orgs","repos_url":"https://api.github.com/users/chris-elford-metaswitch/repos","events_url":"https://api.github.com/users/chris-elford-metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/chris-elford-metaswitch/received_events","type":"User","site_admin":false},"body":"I guess?","created_at":"2016-02-25T14:28:46Z","updated_at":"2016-02-25T14:28:46Z","html_url":"https://github.com/Metaswitch/clearwater-etcd/pull/263#discussion_r54101661","pull_request_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/comments/54101661"},"html":{"href":"https://github.com/Metaswitch/clearwater-etcd/pull/263#discussion_r54101661"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/263","id":60320089,"html_url":"https://github.com/Metaswitch/clearwater-etcd/pull/263","diff_url":"https://github.com/Metaswitch/clearwater-etcd/pull/263.diff","patch_url":"https://github.com/Metaswitch/clearwater-etcd/pull/263.patch","issue_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/263","number":263,"state":"open","locked":false,"title":"[Reviewer Adam] Reraise alarms","user":{"login":"chris-elford-metaswitch","id":2103471,"avatar_url":"https://avatars.githubusercontent.com/u/2103471?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-elford-metaswitch","html_url":"https://github.com/chris-elford-metaswitch","followers_url":"https://api.github.com/users/chris-elford-metaswitch/followers","following_url":"https://api.github.com/users/chris-elford-metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/chris-elford-metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-elford-metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-elford-metaswitch/subscriptions","organizations_url":"https://api.github.com/users/chris-elford-metaswitch/orgs","repos_url":"https://api.github.com/users/chris-elford-metaswitch/repos","events_url":"https://api.github.com/users/chris-elford-metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/chris-elford-metaswitch/received_events","type":"User","site_admin":false},"body":"This goes with python-common pull request #37.\r\n\r\n@eleanor-merry - see also.","created_at":"2016-02-23T10:45:41Z","updated_at":"2016-02-25T14:28:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"chris-elford-metaswitch","id":2103471,"avatar_url":"https://avatars.githubusercontent.com/u/2103471?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-elford-metaswitch","html_url":"https://github.com/chris-elford-metaswitch","followers_url":"https://api.github.com/users/chris-elford-metaswitch/followers","following_url":"https://api.github.com/users/chris-elford-metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/chris-elford-metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-elford-metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-elford-metaswitch/subscriptions","organizations_url":"https://api.github.com/users/chris-elford-metaswitch/orgs","repos_url":"https://api.github.com/users/chris-elford-metaswitch/repos","events_url":"https://api.github.com/users/chris-elford-metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/chris-elford-metaswitch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/263/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/263/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/263/comments","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/statuses/89537bca8b8dc3859af4501e5cd9f1ffbfa690e5","head":{"label":"Metaswitch:reraise_alarms","ref":"reraise_alarms","sha":"89537bca8b8dc3859af4501e5cd9f1ffbfa690e5","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":34358654,"name":"clearwater-etcd","full_name":"Metaswitch/clearwater-etcd","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-etcd","description":"Wrappers around etcd for ease of integration into Project Clearwater","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/deployments","created_at":"2015-04-22T00:03:08Z","updated_at":"2016-01-11T14:37:25Z","pushed_at":"2016-02-25T12:51:33Z","git_url":"git://github.com/Metaswitch/clearwater-etcd.git","ssh_url":"git@github.com:Metaswitch/clearwater-etcd.git","clone_url":"https://github.com/Metaswitch/clearwater-etcd.git","svn_url":"https://github.com/Metaswitch/clearwater-etcd","homepage":null,"size":10365,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":17,"forks":3,"open_issues":17,"watchers":0,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"06d93d85190901712a238db14a7cc7d2c3fb0851","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":34358654,"name":"clearwater-etcd","full_name":"Metaswitch/clearwater-etcd","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-etcd","description":"Wrappers around etcd for ease of integration into Project Clearwater","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/deployments","created_at":"2015-04-22T00:03:08Z","updated_at":"2016-01-11T14:37:25Z","pushed_at":"2016-02-25T12:51:33Z","git_url":"git://github.com/Metaswitch/clearwater-etcd.git","ssh_url":"git@github.com:Metaswitch/clearwater-etcd.git","clone_url":"https://github.com/Metaswitch/clearwater-etcd.git","svn_url":"https://github.com/Metaswitch/clearwater-etcd","homepage":null,"size":10365,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":17,"forks":3,"open_issues":17,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/263"},"html":{"href":"https://github.com/Metaswitch/clearwater-etcd/pull/263"},"issue":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/263"},"comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/statuses/89537bca8b8dc3859af4501e5cd9f1ffbfa690e5"}}}}