{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/12348","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/12348/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/12348/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/12348/events","html_url":"https://github.com/dotnet/corefx/pull/12348","id":180985066,"number":12348,"title":"Make PKGProj's restore the baseline project.json","user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-04T19:39:13Z","updated_at":"2016-10-06T15:20:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/12348","html_url":"https://github.com/dotnet/corefx/pull/12348","diff_url":"https://github.com/dotnet/corefx/pull/12348.diff","patch_url":"https://github.com/dotnet/corefx/pull/12348.patch"},"body":"PKGProj build depends on harvesting dlls from previously shipped\r\npackages.  Rather than force every package in the repo to declare the\r\nversion of the last-shipped package in project.json we have a central\r\ncopy listing everything.  The problem here is that if this project isn't\r\nrestored we'll just silently drop assets from the package, which can\r\ncause tests to fail or package build to fail validation.  This also\r\ncauses a problem for folks that want to just sync the repo and build\r\na single project without doing a full restore.\r\n\r\nTo ensure that we'll always have the baseline restored I set this as the\r\nProjectJson for the pkgproj and ensure that we run restore during\r\npackage build.\r\n\r\nFixes https://github.com/dotnet/corefx/issues/12058\r\n\r\nIf folks would prefer I could make this a little cleaner by putting some stuff in buildtools.\r\n\r\n/cc @weshaggard @hughbe @jamesqo "},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/251995511","html_url":"https://github.com/dotnet/corefx/pull/12348#issuecomment-251995511","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/12348","id":251995511,"user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T15:20:15Z","updated_at":"2016-10-06T15:20:15Z","body":"@weshaggard can you please have a look."}}
{"actor":{"display_login":"ericstj"}}