{"action":"created","comment":{"url":"https://api.github.com/repos/meganz/sdk/pulls/comments/93521176","pull_request_review_id":14050008,"id":93521176,"diff_hunk":"@@ -12425,6 +12455,22 @@ void MegaApiImpl::sendPendingRequests()\n \n             break;\n \t\t}\n+        case MegaRequest::TYPE_GET_USER_EMAIL:\n+        {\n+            handle uh = request->getNodeHandle();\n+            if (uh == INVALID_HANDLE)\n+            {\n+                e = API_EARGS;\n+                break;\n+            }\n+\n+            char uid[12];\n+            Base64::btoa((byte*)&uh, sizeof uh, uid);","path":"src/megaapi_impl.cpp","position":65,"original_position":65,"commit_id":"ff0c770ff8c31b6216aea4914b8a958fa450208b","original_commit_id":"ff0c770ff8c31b6216aea4914b8a958fa450208b","user":{"login":"javiserrano","id":5003542,"avatar_url":"https://avatars.githubusercontent.com/u/5003542?v=3","gravatar_id":"","url":"https://api.github.com/users/javiserrano","html_url":"https://github.com/javiserrano","followers_url":"https://api.github.com/users/javiserrano/followers","following_url":"https://api.github.com/users/javiserrano/following{/other_user}","gists_url":"https://api.github.com/users/javiserrano/gists{/gist_id}","starred_url":"https://api.github.com/users/javiserrano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiserrano/subscriptions","organizations_url":"https://api.github.com/users/javiserrano/orgs","repos_url":"https://api.github.com/users/javiserrano/repos","events_url":"https://api.github.com/users/javiserrano/events{/privacy}","received_events_url":"https://api.github.com/users/javiserrano/received_events","type":"User","site_admin":false},"body":"I think that the size should be `MegaClient::USERHANDLE` instead of `sizeof uh` despite in this case both are the same.","created_at":"2016-12-21T21:17:25Z","updated_at":"2016-12-21T21:17:25Z","html_url":"https://github.com/meganz/sdk/pull/489#discussion_r93521176","pull_request_url":"https://api.github.com/repos/meganz/sdk/pulls/489","_links":{"self":{"href":"https://api.github.com/repos/meganz/sdk/pulls/comments/93521176"},"html":{"href":"https://github.com/meganz/sdk/pull/489#discussion_r93521176"},"pull_request":{"href":"https://api.github.com/repos/meganz/sdk/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/meganz/sdk/pulls/489","id":98557931,"html_url":"https://github.com/meganz/sdk/pull/489","diff_url":"https://github.com/meganz/sdk/pull/489.diff","patch_url":"https://github.com/meganz/sdk/pull/489.patch","issue_url":"https://api.github.com/repos/meganz/sdk/issues/489","number":489,"state":"open","locked":false,"title":"Add command to get email from userhandle","user":{"login":"sergiohs84","id":11694066,"avatar_url":"https://avatars.githubusercontent.com/u/11694066?v=3","gravatar_id":"","url":"https://api.github.com/users/sergiohs84","html_url":"https://github.com/sergiohs84","followers_url":"https://api.github.com/users/sergiohs84/followers","following_url":"https://api.github.com/users/sergiohs84/following{/other_user}","gists_url":"https://api.github.com/users/sergiohs84/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiohs84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiohs84/subscriptions","organizations_url":"https://api.github.com/users/sergiohs84/orgs","repos_url":"https://api.github.com/users/sergiohs84/repos","events_url":"https://api.github.com/users/sergiohs84/events{/privacy}","received_events_url":"https://api.github.com/users/sergiohs84/received_events","type":"User","site_admin":false},"body":"even when the user doesn't have any relationship with you (like shares or groupchats)","created_at":"2016-12-19T12:35:35Z","updated_at":"2016-12-21T21:20:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dbb0305af0d8539e32b220dba3adb8b6052a616","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/meganz/sdk/pulls/489/commits","review_comments_url":"https://api.github.com/repos/meganz/sdk/pulls/489/comments","review_comment_url":"https://api.github.com/repos/meganz/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meganz/sdk/issues/489/comments","statuses_url":"https://api.github.com/repos/meganz/sdk/statuses/ff0c770ff8c31b6216aea4914b8a958fa450208b","head":{"label":"meganz:get-user-email","ref":"get-user-email","sha":"ff0c770ff8c31b6216aea4914b8a958fa450208b","user":{"login":"meganz","id":4920706,"avatar_url":"https://avatars.githubusercontent.com/u/4920706?v=3","gravatar_id":"","url":"https://api.github.com/users/meganz","html_url":"https://github.com/meganz","followers_url":"https://api.github.com/users/meganz/followers","following_url":"https://api.github.com/users/meganz/following{/other_user}","gists_url":"https://api.github.com/users/meganz/gists{/gist_id}","starred_url":"https://api.github.com/users/meganz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganz/subscriptions","organizations_url":"https://api.github.com/users/meganz/orgs","repos_url":"https://api.github.com/users/meganz/repos","events_url":"https://api.github.com/users/meganz/events{/privacy}","received_events_url":"https://api.github.com/users/meganz/received_events","type":"Organization","site_admin":false},"repo":{"id":14556029,"name":"sdk","full_name":"meganz/sdk","owner":{"login":"meganz","id":4920706,"avatar_url":"https://avatars.githubusercontent.com/u/4920706?v=3","gravatar_id":"","url":"https://api.github.com/users/meganz","html_url":"https://github.com/meganz","followers_url":"https://api.github.com/users/meganz/followers","following_url":"https://api.github.com/users/meganz/following{/other_user}","gists_url":"https://api.github.com/users/meganz/gists{/gist_id}","starred_url":"https://api.github.com/users/meganz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganz/subscriptions","organizations_url":"https://api.github.com/users/meganz/orgs","repos_url":"https://api.github.com/users/meganz/repos","events_url":"https://api.github.com/users/meganz/events{/privacy}","received_events_url":"https://api.github.com/users/meganz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meganz/sdk","description":"MEGA C++ SDK","fork":false,"url":"https://api.github.com/repos/meganz/sdk","forks_url":"https://api.github.com/repos/meganz/sdk/forks","keys_url":"https://api.github.com/repos/meganz/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meganz/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meganz/sdk/teams","hooks_url":"https://api.github.com/repos/meganz/sdk/hooks","issue_events_url":"https://api.github.com/repos/meganz/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/meganz/sdk/events","assignees_url":"https://api.github.com/repos/meganz/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/meganz/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/meganz/sdk/tags","blobs_url":"https://api.github.com/repos/meganz/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meganz/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meganz/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/meganz/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meganz/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/meganz/sdk/languages","stargazers_url":"https://api.github.com/repos/meganz/sdk/stargazers","contributors_url":"https://api.github.com/repos/meganz/sdk/contributors","subscribers_url":"https://api.github.com/repos/meganz/sdk/subscribers","subscription_url":"https://api.github.com/repos/meganz/sdk/subscription","commits_url":"https://api.github.com/repos/meganz/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/meganz/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/meganz/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/meganz/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/meganz/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/meganz/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meganz/sdk/merges","archive_url":"https://api.github.com/repos/meganz/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meganz/sdk/downloads","issues_url":"https://api.github.com/repos/meganz/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/meganz/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/meganz/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/meganz/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meganz/sdk/labels{/name}","releases_url":"https://api.github.com/repos/meganz/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/meganz/sdk/deployments","created_at":"2013-11-20T12:33:53Z","updated_at":"2016-12-19T17:22:33Z","pushed_at":"2016-12-21T20:29:46Z","git_url":"git://github.com/meganz/sdk.git","ssh_url":"git@github.com:meganz/sdk.git","clone_url":"https://github.com/meganz/sdk.git","svn_url":"https://github.com/meganz/sdk","homepage":"","size":13818,"stargazers_count":368,"watchers_count":368,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":14,"forks":150,"open_issues":14,"watchers":368,"default_branch":"master"}},"base":{"label":"meganz:develop","ref":"develop","sha":"5a7a79a5510334320d1f4dc66e4820a63e060177","user":{"login":"meganz","id":4920706,"avatar_url":"https://avatars.githubusercontent.com/u/4920706?v=3","gravatar_id":"","url":"https://api.github.com/users/meganz","html_url":"https://github.com/meganz","followers_url":"https://api.github.com/users/meganz/followers","following_url":"https://api.github.com/users/meganz/following{/other_user}","gists_url":"https://api.github.com/users/meganz/gists{/gist_id}","starred_url":"https://api.github.com/users/meganz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganz/subscriptions","organizations_url":"https://api.github.com/users/meganz/orgs","repos_url":"https://api.github.com/users/meganz/repos","events_url":"https://api.github.com/users/meganz/events{/privacy}","received_events_url":"https://api.github.com/users/meganz/received_events","type":"Organization","site_admin":false},"repo":{"id":14556029,"name":"sdk","full_name":"meganz/sdk","owner":{"login":"meganz","id":4920706,"avatar_url":"https://avatars.githubusercontent.com/u/4920706?v=3","gravatar_id":"","url":"https://api.github.com/users/meganz","html_url":"https://github.com/meganz","followers_url":"https://api.github.com/users/meganz/followers","following_url":"https://api.github.com/users/meganz/following{/other_user}","gists_url":"https://api.github.com/users/meganz/gists{/gist_id}","starred_url":"https://api.github.com/users/meganz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganz/subscriptions","organizations_url":"https://api.github.com/users/meganz/orgs","repos_url":"https://api.github.com/users/meganz/repos","events_url":"https://api.github.com/users/meganz/events{/privacy}","received_events_url":"https://api.github.com/users/meganz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meganz/sdk","description":"MEGA C++ SDK","fork":false,"url":"https://api.github.com/repos/meganz/sdk","forks_url":"https://api.github.com/repos/meganz/sdk/forks","keys_url":"https://api.github.com/repos/meganz/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meganz/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meganz/sdk/teams","hooks_url":"https://api.github.com/repos/meganz/sdk/hooks","issue_events_url":"https://api.github.com/repos/meganz/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/meganz/sdk/events","assignees_url":"https://api.github.com/repos/meganz/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/meganz/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/meganz/sdk/tags","blobs_url":"https://api.github.com/repos/meganz/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meganz/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meganz/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/meganz/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meganz/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/meganz/sdk/languages","stargazers_url":"https://api.github.com/repos/meganz/sdk/stargazers","contributors_url":"https://api.github.com/repos/meganz/sdk/contributors","subscribers_url":"https://api.github.com/repos/meganz/sdk/subscribers","subscription_url":"https://api.github.com/repos/meganz/sdk/subscription","commits_url":"https://api.github.com/repos/meganz/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/meganz/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/meganz/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/meganz/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/meganz/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/meganz/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meganz/sdk/merges","archive_url":"https://api.github.com/repos/meganz/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meganz/sdk/downloads","issues_url":"https://api.github.com/repos/meganz/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/meganz/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/meganz/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/meganz/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meganz/sdk/labels{/name}","releases_url":"https://api.github.com/repos/meganz/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/meganz/sdk/deployments","created_at":"2013-11-20T12:33:53Z","updated_at":"2016-12-19T17:22:33Z","pushed_at":"2016-12-21T20:29:46Z","git_url":"git://github.com/meganz/sdk.git","ssh_url":"git@github.com:meganz/sdk.git","clone_url":"https://github.com/meganz/sdk.git","svn_url":"https://github.com/meganz/sdk","homepage":"","size":13818,"stargazers_count":368,"watchers_count":368,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":14,"forks":150,"open_issues":14,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meganz/sdk/pulls/489"},"html":{"href":"https://github.com/meganz/sdk/pull/489"},"issue":{"href":"https://api.github.com/repos/meganz/sdk/issues/489"},"comments":{"href":"https://api.github.com/repos/meganz/sdk/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/meganz/sdk/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/meganz/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meganz/sdk/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/meganz/sdk/statuses/ff0c770ff8c31b6216aea4914b8a958fa450208b"}}}}
{"actor":{"display_login":"javiserrano"}}