{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/70831435","id":70831435,"diff_hunk":"@@ -362,6 +363,41 @@ public void setCommentToFulfiller(String commentToFulfiller) {\n \t}\n \t\n \t/**\n+\t * Convenience method to determine if the order is activated as of the current date\n+\t * \n+\t * @return boolean indicating whether the order was activated on the current date\n+\t * @since 2.0\n+\t * @should return true if an order was activated on the current date\n+\t * @should return true if an order was activated before the current date\n+\t * @should return false for an order not activated\n+\t * @should return false for an order activated after the current date","path":"api/src/main/java/org/openmrs/Order.java","position":32,"original_position":32,"commit_id":"b8347317027d62f97943562d499ff6e5ac1dcba9","original_commit_id":"b8347317027d62f97943562d499ff6e5ac1dcba9","user":{"login":"teleivo","id":4661144,"avatar_url":"https://avatars.githubusercontent.com/u/4661144?v=3","gravatar_id":"","url":"https://api.github.com/users/teleivo","html_url":"https://github.com/teleivo","followers_url":"https://api.github.com/users/teleivo/followers","following_url":"https://api.github.com/users/teleivo/following{/other_user}","gists_url":"https://api.github.com/users/teleivo/gists{/gist_id}","starred_url":"https://api.github.com/users/teleivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleivo/subscriptions","organizations_url":"https://api.github.com/users/teleivo/orgs","repos_url":"https://api.github.com/users/teleivo/repos","events_url":"https://api.github.com/users/teleivo/events{/privacy}","received_events_url":"https://api.github.com/users/teleivo/received_events","type":"User","site_admin":false},"body":"@wluyima tests case wher dateActivated is null","created_at":"2016-07-14T15:53:28Z","updated_at":"2016-07-14T15:53:28Z","html_url":"https://github.com/openmrs/openmrs-core/pull/1816#discussion_r70831435","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1816","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/70831435"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/1816#discussion_r70831435"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1816"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1816","id":77452126,"html_url":"https://github.com/openmrs/openmrs-core/pull/1816","diff_url":"https://github.com/openmrs/openmrs-core/pull/1816.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/1816.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1816","number":1816,"state":"open","locked":false,"title":"TRUNK-4901 Scheduled orders cannot be discontinued","user":{"login":"teleivo","id":4661144,"avatar_url":"https://avatars.githubusercontent.com/u/4661144?v=3","gravatar_id":"","url":"https://api.github.com/users/teleivo","html_url":"https://github.com/teleivo","followers_url":"https://api.github.com/users/teleivo/followers","following_url":"https://api.github.com/users/teleivo/following{/other_user}","gists_url":"https://api.github.com/users/teleivo/gists{/gist_id}","starred_url":"https://api.github.com/users/teleivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleivo/subscriptions","organizations_url":"https://api.github.com/users/teleivo/orgs","repos_url":"https://api.github.com/users/teleivo/repos","events_url":"https://api.github.com/users/teleivo/events{/privacy}","received_events_url":"https://api.github.com/users/teleivo/received_events","type":"User","site_admin":false},"body":"<!--- Provide PR Title above as: 'TRUNK-JiraIssueNumber JiraIssueTitle' -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n* add Order.isActivated()\r\n* add Order.isActivated(Date)\r\n* fix issues introduced by switching isFuture with isStarted/!isStarted for\r\norders scheduled in the future\r\n  * Order.isActive(Date) of stopped orders scheduled for the future were considered active\r\n  * Order.isDiscontinued(Date) of stopped orders scheduled for the future which were not considered discontinued\r\n* add OrderService tests to ensure we can revise orders scheduled in the\r\nfuture and that the original orders are considered discontinued\r\n* add OrderService tests to ensure we can discontinue orders scheduled in the\r\nfuture\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue\r\nfirst -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to\r\nreproduce -->\r\n<!--- Please link to the issue here: -->\r\nsee https://issues.openmrs.org/browse/TRUNK-4901\r\n\r\n\r\nexcuse the formatting noise, I did use the OpenMRS formatter in this repo, seems like it wasnt always used before\r\n","created_at":"2016-07-14T13:02:24Z","updated_at":"2016-07-14T15:53:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c6b4f34b40519bc3048210b9c622dc92b1fe887","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1816/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1816/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1816/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/b8347317027d62f97943562d499ff6e5ac1dcba9","head":{"label":"teleivo:TRUNK-4901","ref":"TRUNK-4901","sha":"b8347317027d62f97943562d499ff6e5ac1dcba9","user":{"login":"teleivo","id":4661144,"avatar_url":"https://avatars.githubusercontent.com/u/4661144?v=3","gravatar_id":"","url":"https://api.github.com/users/teleivo","html_url":"https://github.com/teleivo","followers_url":"https://api.github.com/users/teleivo/followers","following_url":"https://api.github.com/users/teleivo/following{/other_user}","gists_url":"https://api.github.com/users/teleivo/gists{/gist_id}","starred_url":"https://api.github.com/users/teleivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleivo/subscriptions","organizations_url":"https://api.github.com/users/teleivo/orgs","repos_url":"https://api.github.com/users/teleivo/repos","events_url":"https://api.github.com/users/teleivo/events{/privacy}","received_events_url":"https://api.github.com/users/teleivo/received_events","type":"User","site_admin":false},"repo":{"id":31653639,"name":"openmrs-core","full_name":"teleivo/openmrs-core","owner":{"login":"teleivo","id":4661144,"avatar_url":"https://avatars.githubusercontent.com/u/4661144?v=3","gravatar_id":"","url":"https://api.github.com/users/teleivo","html_url":"https://github.com/teleivo","followers_url":"https://api.github.com/users/teleivo/followers","following_url":"https://api.github.com/users/teleivo/following{/other_user}","gists_url":"https://api.github.com/users/teleivo/gists{/gist_id}","starred_url":"https://api.github.com/users/teleivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleivo/subscriptions","organizations_url":"https://api.github.com/users/teleivo/orgs","repos_url":"https://api.github.com/users/teleivo/repos","events_url":"https://api.github.com/users/teleivo/events{/privacy}","received_events_url":"https://api.github.com/users/teleivo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teleivo/openmrs-core","description":"OpenMRS API and web application code","fork":true,"url":"https://api.github.com/repos/teleivo/openmrs-core","forks_url":"https://api.github.com/repos/teleivo/openmrs-core/forks","keys_url":"https://api.github.com/repos/teleivo/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teleivo/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teleivo/openmrs-core/teams","hooks_url":"https://api.github.com/repos/teleivo/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/teleivo/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/teleivo/openmrs-core/events","assignees_url":"https://api.github.com/repos/teleivo/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/teleivo/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/teleivo/openmrs-core/tags","blobs_url":"https://api.github.com/repos/teleivo/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teleivo/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teleivo/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/teleivo/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teleivo/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/teleivo/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/teleivo/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/teleivo/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/teleivo/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/teleivo/openmrs-core/subscription","commits_url":"https://api.github.com/repos/teleivo/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/teleivo/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/teleivo/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/teleivo/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/teleivo/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/teleivo/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teleivo/openmrs-core/merges","archive_url":"https://api.github.com/repos/teleivo/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teleivo/openmrs-core/downloads","issues_url":"https://api.github.com/repos/teleivo/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/teleivo/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/teleivo/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/teleivo/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teleivo/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/teleivo/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/teleivo/openmrs-core/deployments","created_at":"2015-03-04T11:29:59Z","updated_at":"2016-04-26T09:38:26Z","pushed_at":"2016-07-14T13:00:29Z","git_url":"git://github.com/teleivo/openmrs-core.git","ssh_url":"git@github.com:teleivo/openmrs-core.git","clone_url":"https://github.com/teleivo/openmrs-core.git","svn_url":"https://github.com/teleivo/openmrs-core","homepage":"http://openmrs.org","size":218239,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:2.0.x","ref":"2.0.x","sha":"5bb15a6ff39ba50628327015107ed127ff656f5c","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":5187976,"name":"openmrs-core","full_name":"openmrs/openmrs-core","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-core","description":"OpenMRS API and web application code","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-core","forks_url":"https://api.github.com/repos/openmrs/openmrs-core/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-core/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-core/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-core/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-core/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-core/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-core/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-core/deployments","created_at":"2012-07-26T04:54:29Z","updated_at":"2016-07-14T07:32:08Z","pushed_at":"2016-07-14T13:02:25Z","git_url":"git://github.com/openmrs/openmrs-core.git","ssh_url":"git@github.com:openmrs/openmrs-core.git","clone_url":"https://github.com/openmrs/openmrs-core.git","svn_url":"https://github.com/openmrs/openmrs-core","homepage":"http://openmrs.org","size":239472,"stargazers_count":341,"watchers_count":341,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1488,"mirror_url":null,"open_issues_count":4,"forks":1488,"open_issues":4,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1816"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/1816"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/1816"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/1816/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1816/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1816/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-core/statuses/b8347317027d62f97943562d499ff6e5ac1dcba9"}}}}
{"actor":{"display_login":"teleivo"}}