{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/58286360","id":58286360,"diff_hunk":"@@ -159,19 +159,15 @@ public ChannelClosedHandler(C clientConnection, Channel channel) {\n     @Override\n     public void operationComplete(ChannelFuture future) throws Exception {\n       String msg;\n-      if(local!=null) {\n+      if(local != null) {\n         msg = String.format(\"Channel closed %s <--> %s.\", local, remote);\n       }else{\n         msg = String.format(\"Channel closed %s <--> %s.\", future.channel().localAddress(), future.channel().remoteAddress());\n       }\n \n-      if (RpcBus.this.isClient()) {\n-        if(local != null) {\n-          logger.info(String.format(msg));\n-        }\n-      } else {\n-        queue.channelClosed(new ChannelClosedException(msg));\n-      }\n+      logger.info(msg); // should we leave this at info level ?\n+\n+      queue.channelClosed(new ChannelClosedException(msg));","path":"exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java","position":20,"original_position":20,"commit_id":"cc66972b5d645c88b43408ea132418d45a1d74b4","original_commit_id":"cc66972b5d645c88b43408ea132418d45a1d74b4","user":{"login":"jacques-n","id":183350,"avatar_url":"https://avatars.githubusercontent.com/u/183350?v=3","gravatar_id":"","url":"https://api.github.com/users/jacques-n","html_url":"https://github.com/jacques-n","followers_url":"https://api.github.com/users/jacques-n/followers","following_url":"https://api.github.com/users/jacques-n/following{/other_user}","gists_url":"https://api.github.com/users/jacques-n/gists{/gist_id}","starred_url":"https://api.github.com/users/jacques-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacques-n/subscriptions","organizations_url":"https://api.github.com/users/jacques-n/orgs","repos_url":"https://api.github.com/users/jacques-n/repos","events_url":"https://api.github.com/users/jacques-n/events{/privacy}","received_events_url":"https://api.github.com/users/jacques-n/received_events","type":"User","site_admin":false},"body":"Nice catch Sudheesh.\r\n\r\nReflecting on this now, I think there is a much cleaner way to structure this than the current implementation. If we manage this at the connection level (new \"outstanding handler => rpc id mapping\" per connection), we can rely on Netty's RPC thread properties to have a trivial structure that doesn't need to be thread safe and is closed out on connection termination. Do one of you want to pick up that modification? I think that would make things much nicer.","created_at":"2016-04-02T01:47:48Z","updated_at":"2016-04-02T01:47:48Z","html_url":"https://github.com/apache/drill/pull/442#discussion_r58286360","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/442","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/58286360"},"html":{"href":"https://github.com/apache/drill/pull/442#discussion_r58286360"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/442"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/442","id":63935988,"html_url":"https://github.com/apache/drill/pull/442","diff_url":"https://github.com/apache/drill/pull/442.diff","patch_url":"https://github.com/apache/drill/pull/442.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/442","number":442,"state":"open","locked":false,"title":"DRILL-3714: Query runs out of memory and remains in CANCELLATION_REQU…","user":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"body":"…ESTED state until drillbit is restarted\r\n\r\nRpcBus.ChannelClosedHandler calls CoordinationQueue.channelClosed() on both server and client side","created_at":"2016-03-23T19:04:29Z","updated_at":"2016-04-02T01:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45efd1963c3c1a4df5a368f00612e24480f935d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/442/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/442/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/442/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/cc66972b5d645c88b43408ea132418d45a1d74b4","head":{"label":"adeneche:DRILL-3714","ref":"DRILL-3714","sha":"cc66972b5d645c88b43408ea132418d45a1d74b4","user":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"repo":{"id":25532970,"name":"incubator-drill","full_name":"adeneche/incubator-drill","owner":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adeneche/incubator-drill","description":"Mirror of Apache Drill (Incubating)","fork":true,"url":"https://api.github.com/repos/adeneche/incubator-drill","forks_url":"https://api.github.com/repos/adeneche/incubator-drill/forks","keys_url":"https://api.github.com/repos/adeneche/incubator-drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adeneche/incubator-drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adeneche/incubator-drill/teams","hooks_url":"https://api.github.com/repos/adeneche/incubator-drill/hooks","issue_events_url":"https://api.github.com/repos/adeneche/incubator-drill/issues/events{/number}","events_url":"https://api.github.com/repos/adeneche/incubator-drill/events","assignees_url":"https://api.github.com/repos/adeneche/incubator-drill/assignees{/user}","branches_url":"https://api.github.com/repos/adeneche/incubator-drill/branches{/branch}","tags_url":"https://api.github.com/repos/adeneche/incubator-drill/tags","blobs_url":"https://api.github.com/repos/adeneche/incubator-drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adeneche/incubator-drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adeneche/incubator-drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/adeneche/incubator-drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adeneche/incubator-drill/statuses/{sha}","languages_url":"https://api.github.com/repos/adeneche/incubator-drill/languages","stargazers_url":"https://api.github.com/repos/adeneche/incubator-drill/stargazers","contributors_url":"https://api.github.com/repos/adeneche/incubator-drill/contributors","subscribers_url":"https://api.github.com/repos/adeneche/incubator-drill/subscribers","subscription_url":"https://api.github.com/repos/adeneche/incubator-drill/subscription","commits_url":"https://api.github.com/repos/adeneche/incubator-drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/adeneche/incubator-drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/adeneche/incubator-drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/adeneche/incubator-drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/adeneche/incubator-drill/contents/{+path}","compare_url":"https://api.github.com/repos/adeneche/incubator-drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adeneche/incubator-drill/merges","archive_url":"https://api.github.com/repos/adeneche/incubator-drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adeneche/incubator-drill/downloads","issues_url":"https://api.github.com/repos/adeneche/incubator-drill/issues{/number}","pulls_url":"https://api.github.com/repos/adeneche/incubator-drill/pulls{/number}","milestones_url":"https://api.github.com/repos/adeneche/incubator-drill/milestones{/number}","notifications_url":"https://api.github.com/repos/adeneche/incubator-drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adeneche/incubator-drill/labels{/name}","releases_url":"https://api.github.com/repos/adeneche/incubator-drill/releases{/id}","deployments_url":"https://api.github.com/repos/adeneche/incubator-drill/deployments","created_at":"2014-10-21T16:25:02Z","updated_at":"2016-02-03T23:43:01Z","pushed_at":"2016-03-29T18:41:02Z","git_url":"git://github.com/adeneche/incubator-drill.git","ssh_url":"git@github.com:adeneche/incubator-drill.git","clone_url":"https://github.com/adeneche/incubator-drill.git","svn_url":"https://github.com/adeneche/incubator-drill","homepage":null,"size":35790,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5dbaafbe6651b0a284fef69d5c952d82ce506e20","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","deployments_url":"https://api.github.com/repos/apache/drill/deployments","created_at":"2012-09-05T07:00:26Z","updated_at":"2016-04-01T15:44:12Z","pushed_at":"2016-04-01T20:25:50Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":50602,"stargazers_count":593,"watchers_count":593,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":406,"mirror_url":"git://git.apache.org/drill.git","open_issues_count":97,"forks":406,"open_issues":97,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/442"},"html":{"href":"https://github.com/apache/drill/pull/442"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/442"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/442/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/442/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/442/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/cc66972b5d645c88b43408ea132418d45a1d74b4"}}}}