{"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/dojo/stores/pulls/24","id":88976777,"html_url":"https://github.com/dojo/stores/pull/24","diff_url":"https://github.com/dojo/stores/pull/24.diff","patch_url":"https://github.com/dojo/stores/pull/24.patch","issue_url":"https://api.github.com/repos/dojo/stores/issues/24","number":24,"state":"closed","locked":false,"title":"Review: changes for the new stores","user":{"login":"lzhoucs","id":1444104,"avatar_url":"https://avatars.githubusercontent.com/u/1444104?v=3","gravatar_id":"","url":"https://api.github.com/users/lzhoucs","html_url":"https://github.com/lzhoucs","followers_url":"https://api.github.com/users/lzhoucs/followers","following_url":"https://api.github.com/users/lzhoucs/following{/other_user}","gists_url":"https://api.github.com/users/lzhoucs/gists{/gist_id}","starred_url":"https://api.github.com/users/lzhoucs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzhoucs/subscriptions","organizations_url":"https://api.github.com/users/lzhoucs/orgs","repos_url":"https://api.github.com/users/lzhoucs/repos","events_url":"https://api.github.com/users/lzhoucs/events{/privacy}","received_events_url":"https://api.github.com/users/lzhoucs/received_events","type":"User","site_admin":false},"body":"**Type:** feature\r\n\r\n**Description:** \r\n\r\nThis is all the work that has done based on previous reviews. A few highlights:\r\n* Converted TS classes into [compose factories](/dojo/compose)\r\n* Separated functionality into mixins.\r\n* Test coverage is over 80%.\r\n\r\nMost work is done by @maier49.\r\n\r\nAll the commits in this PR are originally from [maier49/store](/maier49/store/tree/master), due to the two repositories are completely different - they don't have related history, to preserve history of all the work we have done, I did a bit research and came up with this PR. Please let me know if there's any issues.\r\n\r\nAny feedback/comments on anything we have done is  highly appreciated.\r\n\r\nPlease review this checklist before submitting your PR:\r\n\r\n* [ ] There is a related issue\r\n* [ ] All contributors have signed a CLA\r\n* [ ] All code matches the [style guide](https://github.com/dojo/meta/blob/master/STYLE.md)\r\n* [ ] The code passes the CI tests\r\n* [ ] Unit or Functional tests are included in the PR\r\n* [ ] The PR increases or maintains the overall unit test coverage percentage\r\n* [ ] The code is ready to be merged\r\n","created_at":"2016-10-12T08:54:35Z","updated_at":"2016-10-18T15:21:29Z","closed_at":"2016-10-18T15:21:29Z","merged_at":"2016-10-18T15:21:29Z","merge_commit_sha":"cdc2fe340fd79252a529808f1e58d3f0bfcd31a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojo/stores/pulls/24/commits","review_comments_url":"https://api.github.com/repos/dojo/stores/pulls/24/comments","review_comment_url":"https://api.github.com/repos/dojo/stores/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/stores/issues/24/comments","statuses_url":"https://api.github.com/repos/dojo/stores/statuses/325d670ec3177bb16673c7f1f7d6e876290b37df","head":{"label":"lzhoucs:feature-new-stores","ref":"feature-new-stores","sha":"325d670ec3177bb16673c7f1f7d6e876290b37df","user":{"login":"lzhoucs","id":1444104,"avatar_url":"https://avatars.githubusercontent.com/u/1444104?v=3","gravatar_id":"","url":"https://api.github.com/users/lzhoucs","html_url":"https://github.com/lzhoucs","followers_url":"https://api.github.com/users/lzhoucs/followers","following_url":"https://api.github.com/users/lzhoucs/following{/other_user}","gists_url":"https://api.github.com/users/lzhoucs/gists{/gist_id}","starred_url":"https://api.github.com/users/lzhoucs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzhoucs/subscriptions","organizations_url":"https://api.github.com/users/lzhoucs/orgs","repos_url":"https://api.github.com/users/lzhoucs/repos","events_url":"https://api.github.com/users/lzhoucs/events{/privacy}","received_events_url":"https://api.github.com/users/lzhoucs/received_events","type":"User","site_admin":false},"repo":{"id":70674150,"name":"stores","full_name":"lzhoucs/stores","owner":{"login":"lzhoucs","id":1444104,"avatar_url":"https://avatars.githubusercontent.com/u/1444104?v=3","gravatar_id":"","url":"https://api.github.com/users/lzhoucs","html_url":"https://github.com/lzhoucs","followers_url":"https://api.github.com/users/lzhoucs/followers","following_url":"https://api.github.com/users/lzhoucs/following{/other_user}","gists_url":"https://api.github.com/users/lzhoucs/gists{/gist_id}","starred_url":"https://api.github.com/users/lzhoucs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzhoucs/subscriptions","organizations_url":"https://api.github.com/users/lzhoucs/orgs","repos_url":"https://api.github.com/users/lzhoucs/repos","events_url":"https://api.github.com/users/lzhoucs/events{/privacy}","received_events_url":"https://api.github.com/users/lzhoucs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzhoucs/stores","description":":rocket: Data stores for Dojo 2.","fork":true,"url":"https://api.github.com/repos/lzhoucs/stores","forks_url":"https://api.github.com/repos/lzhoucs/stores/forks","keys_url":"https://api.github.com/repos/lzhoucs/stores/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzhoucs/stores/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzhoucs/stores/teams","hooks_url":"https://api.github.com/repos/lzhoucs/stores/hooks","issue_events_url":"https://api.github.com/repos/lzhoucs/stores/issues/events{/number}","events_url":"https://api.github.com/repos/lzhoucs/stores/events","assignees_url":"https://api.github.com/repos/lzhoucs/stores/assignees{/user}","branches_url":"https://api.github.com/repos/lzhoucs/stores/branches{/branch}","tags_url":"https://api.github.com/repos/lzhoucs/stores/tags","blobs_url":"https://api.github.com/repos/lzhoucs/stores/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzhoucs/stores/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzhoucs/stores/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzhoucs/stores/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzhoucs/stores/statuses/{sha}","languages_url":"https://api.github.com/repos/lzhoucs/stores/languages","stargazers_url":"https://api.github.com/repos/lzhoucs/stores/stargazers","contributors_url":"https://api.github.com/repos/lzhoucs/stores/contributors","subscribers_url":"https://api.github.com/repos/lzhoucs/stores/subscribers","subscription_url":"https://api.github.com/repos/lzhoucs/stores/subscription","commits_url":"https://api.github.com/repos/lzhoucs/stores/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzhoucs/stores/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzhoucs/stores/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzhoucs/stores/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzhoucs/stores/contents/{+path}","compare_url":"https://api.github.com/repos/lzhoucs/stores/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzhoucs/stores/merges","archive_url":"https://api.github.com/repos/lzhoucs/stores/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzhoucs/stores/downloads","issues_url":"https://api.github.com/repos/lzhoucs/stores/issues{/number}","pulls_url":"https://api.github.com/repos/lzhoucs/stores/pulls{/number}","milestones_url":"https://api.github.com/repos/lzhoucs/stores/milestones{/number}","notifications_url":"https://api.github.com/repos/lzhoucs/stores/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzhoucs/stores/labels{/name}","releases_url":"https://api.github.com/repos/lzhoucs/stores/releases{/id}","deployments_url":"https://api.github.com/repos/lzhoucs/stores/deployments","created_at":"2016-10-12T07:23:44Z","updated_at":"2016-10-12T07:23:45Z","pushed_at":"2016-10-18T07:35:35Z","git_url":"git://github.com/lzhoucs/stores.git","ssh_url":"git@github.com:lzhoucs/stores.git","clone_url":"https://github.com/lzhoucs/stores.git","svn_url":"https://github.com/lzhoucs/stores","homepage":"","size":227,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:feature-new-stores","ref":"feature-new-stores","sha":"f604208faffcae84e9f505df830fe00ba191b1fb","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":55952101,"name":"stores","full_name":"dojo/stores","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/stores","description":":rocket: Data stores for Dojo 2.","fork":false,"url":"https://api.github.com/repos/dojo/stores","forks_url":"https://api.github.com/repos/dojo/stores/forks","keys_url":"https://api.github.com/repos/dojo/stores/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/stores/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/stores/teams","hooks_url":"https://api.github.com/repos/dojo/stores/hooks","issue_events_url":"https://api.github.com/repos/dojo/stores/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/stores/events","assignees_url":"https://api.github.com/repos/dojo/stores/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/stores/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/stores/tags","blobs_url":"https://api.github.com/repos/dojo/stores/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/stores/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/stores/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/stores/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/stores/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/stores/languages","stargazers_url":"https://api.github.com/repos/dojo/stores/stargazers","contributors_url":"https://api.github.com/repos/dojo/stores/contributors","subscribers_url":"https://api.github.com/repos/dojo/stores/subscribers","subscription_url":"https://api.github.com/repos/dojo/stores/subscription","commits_url":"https://api.github.com/repos/dojo/stores/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/stores/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/stores/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/stores/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/stores/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/stores/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/stores/merges","archive_url":"https://api.github.com/repos/dojo/stores/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/stores/downloads","issues_url":"https://api.github.com/repos/dojo/stores/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/stores/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/stores/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/stores/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/stores/labels{/name}","releases_url":"https://api.github.com/repos/dojo/stores/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/stores/deployments","created_at":"2016-04-11T07:46:15Z","updated_at":"2016-10-03T11:42:46Z","pushed_at":"2016-10-18T15:21:29Z","git_url":"git://github.com/dojo/stores.git","ssh_url":"git@github.com:dojo/stores.git","clone_url":"https://github.com/dojo/stores.git","svn_url":"https://github.com/dojo/stores","homepage":"","size":77,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":17,"forks":6,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/stores/pulls/24"},"html":{"href":"https://github.com/dojo/stores/pull/24"},"issue":{"href":"https://api.github.com/repos/dojo/stores/issues/24"},"comments":{"href":"https://api.github.com/repos/dojo/stores/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/stores/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/stores/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/stores/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/stores/statuses/325d670ec3177bb16673c7f1f7d6e876290b37df"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"agubler","id":1982678,"avatar_url":"https://avatars.githubusercontent.com/u/1982678?v=3","gravatar_id":"","url":"https://api.github.com/users/agubler","html_url":"https://github.com/agubler","followers_url":"https://api.github.com/users/agubler/followers","following_url":"https://api.github.com/users/agubler/following{/other_user}","gists_url":"https://api.github.com/users/agubler/gists{/gist_id}","starred_url":"https://api.github.com/users/agubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agubler/subscriptions","organizations_url":"https://api.github.com/users/agubler/orgs","repos_url":"https://api.github.com/users/agubler/repos","events_url":"https://api.github.com/users/agubler/events{/privacy}","received_events_url":"https://api.github.com/users/agubler/received_events","type":"User","site_admin":false},"comments":2,"review_comments":14,"commits":58,"additions":5852,"deletions":796,"changed_files":54}}
{"actor":{"display_login":"agubler"}}