{"action":"created","issue":{"url":"https://api.github.com/repos/sdementen/piecash/issues/13","repository_url":"https://api.github.com/repos/sdementen/piecash","labels_url":"https://api.github.com/repos/sdementen/piecash/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/sdementen/piecash/issues/13/comments","events_url":"https://api.github.com/repos/sdementen/piecash/issues/13/events","html_url":"https://github.com/sdementen/piecash/pull/13","id":137070511,"number":13,"title":"Add unicode_literals to improve Python 2/3 compatibility","user":{"login":"geoffwright240","id":9195984,"avatar_url":"https://avatars.githubusercontent.com/u/9195984?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffwright240","html_url":"https://github.com/geoffwright240","followers_url":"https://api.github.com/users/geoffwright240/followers","following_url":"https://api.github.com/users/geoffwright240/following{/other_user}","gists_url":"https://api.github.com/users/geoffwright240/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffwright240/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffwright240/subscriptions","organizations_url":"https://api.github.com/users/geoffwright240/orgs","repos_url":"https://api.github.com/users/geoffwright240/repos","events_url":"https://api.github.com/users/geoffwright240/events{/privacy}","received_events_url":"https://api.github.com/users/geoffwright240/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-28T16:49:38Z","updated_at":"2016-02-29T01:49:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sdementen/piecash/pulls/13","html_url":"https://github.com/sdementen/piecash/pull/13","diff_url":"https://github.com/sdementen/piecash/pull/13.diff","patch_url":"https://github.com/sdementen/piecash/pull/13.patch"},"body":"Sebastien,\r\n\r\nJust learning how to create a pull request. Apologies if I screwed something up but hopefully this works.\r\n\r\nGeoff"},"comment":{"url":"https://api.github.com/repos/sdementen/piecash/issues/comments/189993652","html_url":"https://github.com/sdementen/piecash/pull/13#issuecomment-189993652","issue_url":"https://api.github.com/repos/sdementen/piecash/issues/13","id":189993652,"user":{"login":"geoffwright240","id":9195984,"avatar_url":"https://avatars.githubusercontent.com/u/9195984?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffwright240","html_url":"https://github.com/geoffwright240","followers_url":"https://api.github.com/users/geoffwright240/followers","following_url":"https://api.github.com/users/geoffwright240/following{/other_user}","gists_url":"https://api.github.com/users/geoffwright240/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffwright240/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffwright240/subscriptions","organizations_url":"https://api.github.com/users/geoffwright240/orgs","repos_url":"https://api.github.com/users/geoffwright240/repos","events_url":"https://api.github.com/users/geoffwright240/events{/privacy}","received_events_url":"https://api.github.com/users/geoffwright240/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T01:49:31Z","updated_at":"2016-02-29T01:49:31Z","body":"Hi Sebastien,\n\nI am happy to write a test but this is a first for me so please feel free to provide a bit of guidance. \n\nThe test is test_ledger.py and I have updated test_book.gnucash to include a few unicode characters as a new top-level account. The test fails in exactly the same way that I was observing prior to adding « unicode_literals » to the ledger.py file, and passes once it is added.\n\nWhile I have written the test to mirror exactly the issue that I was having, and admittedly do not have a lot of experience with writing tests, I wonder whether there is a more general test that could be written to ensure that unicode is handled correctly in all contexts. I am not too sure what this test would look like but will give it some thought — or, if you have some ideas, I would be happy to try to implement them.\n\nCheers,\n\nGeoff\n\n\n\nLe 2016-02-28 à 12:52, sdementen <notifications@github.com> a écrit :\n\n> Hello Geoff,\n> \n> It looks good ! \n> What would be great is to add a test in the test suite that test the case that was failing before your PR and that would work now with your PR. Up to you if you want to add this test. Otherwise, I'll merge your PR anyway.\n> \n> Sebastien\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n\n"}}