{"action":"created","comment":{"url":"https://api.github.com/repos/adelbertc/frameless/pulls/comments/54336601","id":54336601,"diff_hunk":"@@ -67,6 +83,52 @@ class TypedDataset[T](\n     ): GroupedByManyOps[T, K, Out0] = new GroupedByManyOps[T, K, Out0](self, groupedBy)\n   }\n \n+  def join[A: TypedEncoder, B](\n+    right: TypedDataset[A],\n+    leftCol: TypedColumn[T, B],","path":"dataset/src/main/scala/frameless/TypedDataset.scala","position":47,"original_position":47,"commit_id":"1138b353efd4f4e9bed6a9716e501643bc22311f","original_commit_id":"1138b353efd4f4e9bed6a9716e501643bc22311f","user":{"login":"OlivierBlanvillain","id":1085297,"avatar_url":"https://avatars.githubusercontent.com/u/1085297?v=3","gravatar_id":"","url":"https://api.github.com/users/OlivierBlanvillain","html_url":"https://github.com/OlivierBlanvillain","followers_url":"https://api.github.com/users/OlivierBlanvillain/followers","following_url":"https://api.github.com/users/OlivierBlanvillain/following{/other_user}","gists_url":"https://api.github.com/users/OlivierBlanvillain/gists{/gist_id}","starred_url":"https://api.github.com/users/OlivierBlanvillain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlivierBlanvillain/subscriptions","organizations_url":"https://api.github.com/users/OlivierBlanvillain/orgs","repos_url":"https://api.github.com/users/OlivierBlanvillain/repos","events_url":"https://api.github.com/users/OlivierBlanvillain/events{/privacy}","received_events_url":"https://api.github.com/users/OlivierBlanvillain/received_events","type":"User","site_admin":false},"body":"What's the advantage of doing this as opposed to defining a complete join expression, like\r\n\r\n    a.join(b)(a.col(`aa) === b.col(`bb))\r\n\r\n?","created_at":"2016-02-27T17:57:46Z","updated_at":"2016-02-27T17:57:46Z","html_url":"https://github.com/adelbertc/frameless/pull/7#discussion_r54336601","pull_request_url":"https://api.github.com/repos/adelbertc/frameless/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/comments/54336601"},"html":{"href":"https://github.com/adelbertc/frameless/pull/7#discussion_r54336601"},"pull_request":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/adelbertc/frameless/pulls/7","id":59273095,"html_url":"https://github.com/adelbertc/frameless/pull/7","diff_url":"https://github.com/adelbertc/frameless/pull/7.diff","patch_url":"https://github.com/adelbertc/frameless/pull/7.patch","issue_url":"https://api.github.com/repos/adelbertc/frameless/issues/7","number":7,"state":"open","locked":false,"title":"Add left and inner join","user":{"login":"kanterov","id":467927,"avatar_url":"https://avatars.githubusercontent.com/u/467927?v=3","gravatar_id":"","url":"https://api.github.com/users/kanterov","html_url":"https://github.com/kanterov","followers_url":"https://api.github.com/users/kanterov/followers","following_url":"https://api.github.com/users/kanterov/following{/other_user}","gists_url":"https://api.github.com/users/kanterov/gists{/gist_id}","starred_url":"https://api.github.com/users/kanterov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanterov/subscriptions","organizations_url":"https://api.github.com/users/kanterov/orgs","repos_url":"https://api.github.com/users/kanterov/repos","events_url":"https://api.github.com/users/kanterov/events{/privacy}","received_events_url":"https://api.github.com/users/kanterov/received_events","type":"User","site_admin":false},"body":"This pull request:\r\n\r\n- Adds left and inner joins for typed datasets\r\n- Adds `colMany` to access nested fields","created_at":"2016-02-13T17:55:41Z","updated_at":"2016-02-27T17:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20e089c9d6687e12e1506a9ebf3999fb1308026c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adelbertc/frameless/pulls/7/commits","review_comments_url":"https://api.github.com/repos/adelbertc/frameless/pulls/7/comments","review_comment_url":"https://api.github.com/repos/adelbertc/frameless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adelbertc/frameless/issues/7/comments","statuses_url":"https://api.github.com/repos/adelbertc/frameless/statuses/1138b353efd4f4e9bed6a9716e501643bc22311f","head":{"label":"kanterov:dataset-joins","ref":"dataset-joins","sha":"1138b353efd4f4e9bed6a9716e501643bc22311f","user":{"login":"kanterov","id":467927,"avatar_url":"https://avatars.githubusercontent.com/u/467927?v=3","gravatar_id":"","url":"https://api.github.com/users/kanterov","html_url":"https://github.com/kanterov","followers_url":"https://api.github.com/users/kanterov/followers","following_url":"https://api.github.com/users/kanterov/following{/other_user}","gists_url":"https://api.github.com/users/kanterov/gists{/gist_id}","starred_url":"https://api.github.com/users/kanterov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanterov/subscriptions","organizations_url":"https://api.github.com/users/kanterov/orgs","repos_url":"https://api.github.com/users/kanterov/repos","events_url":"https://api.github.com/users/kanterov/events{/privacy}","received_events_url":"https://api.github.com/users/kanterov/received_events","type":"User","site_admin":false},"repo":{"id":50376904,"name":"frameless","full_name":"kanterov/frameless","owner":{"login":"kanterov","id":467927,"avatar_url":"https://avatars.githubusercontent.com/u/467927?v=3","gravatar_id":"","url":"https://api.github.com/users/kanterov","html_url":"https://github.com/kanterov","followers_url":"https://api.github.com/users/kanterov/followers","following_url":"https://api.github.com/users/kanterov/following{/other_user}","gists_url":"https://api.github.com/users/kanterov/gists{/gist_id}","starred_url":"https://api.github.com/users/kanterov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanterov/subscriptions","organizations_url":"https://api.github.com/users/kanterov/orgs","repos_url":"https://api.github.com/users/kanterov/repos","events_url":"https://api.github.com/users/kanterov/events{/privacy}","received_events_url":"https://api.github.com/users/kanterov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kanterov/frameless","description":"Tracking Spark SQL schema with phantom types.","fork":true,"url":"https://api.github.com/repos/kanterov/frameless","forks_url":"https://api.github.com/repos/kanterov/frameless/forks","keys_url":"https://api.github.com/repos/kanterov/frameless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanterov/frameless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanterov/frameless/teams","hooks_url":"https://api.github.com/repos/kanterov/frameless/hooks","issue_events_url":"https://api.github.com/repos/kanterov/frameless/issues/events{/number}","events_url":"https://api.github.com/repos/kanterov/frameless/events","assignees_url":"https://api.github.com/repos/kanterov/frameless/assignees{/user}","branches_url":"https://api.github.com/repos/kanterov/frameless/branches{/branch}","tags_url":"https://api.github.com/repos/kanterov/frameless/tags","blobs_url":"https://api.github.com/repos/kanterov/frameless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanterov/frameless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanterov/frameless/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanterov/frameless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanterov/frameless/statuses/{sha}","languages_url":"https://api.github.com/repos/kanterov/frameless/languages","stargazers_url":"https://api.github.com/repos/kanterov/frameless/stargazers","contributors_url":"https://api.github.com/repos/kanterov/frameless/contributors","subscribers_url":"https://api.github.com/repos/kanterov/frameless/subscribers","subscription_url":"https://api.github.com/repos/kanterov/frameless/subscription","commits_url":"https://api.github.com/repos/kanterov/frameless/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanterov/frameless/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanterov/frameless/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanterov/frameless/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanterov/frameless/contents/{+path}","compare_url":"https://api.github.com/repos/kanterov/frameless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanterov/frameless/merges","archive_url":"https://api.github.com/repos/kanterov/frameless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanterov/frameless/downloads","issues_url":"https://api.github.com/repos/kanterov/frameless/issues{/number}","pulls_url":"https://api.github.com/repos/kanterov/frameless/pulls{/number}","milestones_url":"https://api.github.com/repos/kanterov/frameless/milestones{/number}","notifications_url":"https://api.github.com/repos/kanterov/frameless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanterov/frameless/labels{/name}","releases_url":"https://api.github.com/repos/kanterov/frameless/releases{/id}","deployments_url":"https://api.github.com/repos/kanterov/frameless/deployments","created_at":"2016-01-25T19:57:32Z","updated_at":"2016-01-25T19:57:33Z","pushed_at":"2016-02-23T05:42:51Z","git_url":"git://github.com/kanterov/frameless.git","ssh_url":"git@github.com:kanterov/frameless.git","clone_url":"https://github.com/kanterov/frameless.git","svn_url":"https://github.com/kanterov/frameless","homepage":"","size":140,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"adelbertc:master","ref":"master","sha":"3aaf838248196df1ab8686cbc2313c2f9335c2ab","user":{"login":"adelbertc","id":1332980,"avatar_url":"https://avatars.githubusercontent.com/u/1332980?v=3","gravatar_id":"","url":"https://api.github.com/users/adelbertc","html_url":"https://github.com/adelbertc","followers_url":"https://api.github.com/users/adelbertc/followers","following_url":"https://api.github.com/users/adelbertc/following{/other_user}","gists_url":"https://api.github.com/users/adelbertc/gists{/gist_id}","starred_url":"https://api.github.com/users/adelbertc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelbertc/subscriptions","organizations_url":"https://api.github.com/users/adelbertc/orgs","repos_url":"https://api.github.com/users/adelbertc/repos","events_url":"https://api.github.com/users/adelbertc/events{/privacy}","received_events_url":"https://api.github.com/users/adelbertc/received_events","type":"User","site_admin":false},"repo":{"id":33022955,"name":"frameless","full_name":"adelbertc/frameless","owner":{"login":"adelbertc","id":1332980,"avatar_url":"https://avatars.githubusercontent.com/u/1332980?v=3","gravatar_id":"","url":"https://api.github.com/users/adelbertc","html_url":"https://github.com/adelbertc","followers_url":"https://api.github.com/users/adelbertc/followers","following_url":"https://api.github.com/users/adelbertc/following{/other_user}","gists_url":"https://api.github.com/users/adelbertc/gists{/gist_id}","starred_url":"https://api.github.com/users/adelbertc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelbertc/subscriptions","organizations_url":"https://api.github.com/users/adelbertc/orgs","repos_url":"https://api.github.com/users/adelbertc/repos","events_url":"https://api.github.com/users/adelbertc/events{/privacy}","received_events_url":"https://api.github.com/users/adelbertc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adelbertc/frameless","description":"Tracking Spark SQL schema with phantom types.","fork":false,"url":"https://api.github.com/repos/adelbertc/frameless","forks_url":"https://api.github.com/repos/adelbertc/frameless/forks","keys_url":"https://api.github.com/repos/adelbertc/frameless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adelbertc/frameless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adelbertc/frameless/teams","hooks_url":"https://api.github.com/repos/adelbertc/frameless/hooks","issue_events_url":"https://api.github.com/repos/adelbertc/frameless/issues/events{/number}","events_url":"https://api.github.com/repos/adelbertc/frameless/events","assignees_url":"https://api.github.com/repos/adelbertc/frameless/assignees{/user}","branches_url":"https://api.github.com/repos/adelbertc/frameless/branches{/branch}","tags_url":"https://api.github.com/repos/adelbertc/frameless/tags","blobs_url":"https://api.github.com/repos/adelbertc/frameless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adelbertc/frameless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adelbertc/frameless/git/refs{/sha}","trees_url":"https://api.github.com/repos/adelbertc/frameless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adelbertc/frameless/statuses/{sha}","languages_url":"https://api.github.com/repos/adelbertc/frameless/languages","stargazers_url":"https://api.github.com/repos/adelbertc/frameless/stargazers","contributors_url":"https://api.github.com/repos/adelbertc/frameless/contributors","subscribers_url":"https://api.github.com/repos/adelbertc/frameless/subscribers","subscription_url":"https://api.github.com/repos/adelbertc/frameless/subscription","commits_url":"https://api.github.com/repos/adelbertc/frameless/commits{/sha}","git_commits_url":"https://api.github.com/repos/adelbertc/frameless/git/commits{/sha}","comments_url":"https://api.github.com/repos/adelbertc/frameless/comments{/number}","issue_comment_url":"https://api.github.com/repos/adelbertc/frameless/issues/comments{/number}","contents_url":"https://api.github.com/repos/adelbertc/frameless/contents/{+path}","compare_url":"https://api.github.com/repos/adelbertc/frameless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adelbertc/frameless/merges","archive_url":"https://api.github.com/repos/adelbertc/frameless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adelbertc/frameless/downloads","issues_url":"https://api.github.com/repos/adelbertc/frameless/issues{/number}","pulls_url":"https://api.github.com/repos/adelbertc/frameless/pulls{/number}","milestones_url":"https://api.github.com/repos/adelbertc/frameless/milestones{/number}","notifications_url":"https://api.github.com/repos/adelbertc/frameless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adelbertc/frameless/labels{/name}","releases_url":"https://api.github.com/repos/adelbertc/frameless/releases{/id}","deployments_url":"https://api.github.com/repos/adelbertc/frameless/deployments","created_at":"2015-03-28T06:03:10Z","updated_at":"2016-02-18T12:10:54Z","pushed_at":"2016-02-27T09:31:31Z","git_url":"git://github.com/adelbertc/frameless.git","ssh_url":"git@github.com:adelbertc/frameless.git","clone_url":"https://github.com/adelbertc/frameless.git","svn_url":"https://github.com/adelbertc/frameless","homepage":"","size":147,"stargazers_count":30,"watchers_count":30,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":9,"forks":6,"open_issues":9,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/7"},"html":{"href":"https://github.com/adelbertc/frameless/pull/7"},"issue":{"href":"https://api.github.com/repos/adelbertc/frameless/issues/7"},"comments":{"href":"https://api.github.com/repos/adelbertc/frameless/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adelbertc/frameless/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/adelbertc/frameless/statuses/1138b353efd4f4e9bed6a9716e501643bc22311f"}}}}