{"action":"opened","number":4638,"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/4638","id":90046473,"html_url":"https://github.com/kripken/emscripten/pull/4638","diff_url":"https://github.com/kripken/emscripten/pull/4638.diff","patch_url":"https://github.com/kripken/emscripten/pull/4638.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/4638","number":4638,"state":"open","locked":false,"title":"modularize feature : fix regression since commit c5af8f6 ","user":{"login":"anlambert","id":5493543,"avatar_url":"https://avatars.githubusercontent.com/u/5493543?v=3","gravatar_id":"","url":"https://api.github.com/users/anlambert","html_url":"https://github.com/anlambert","followers_url":"https://api.github.com/users/anlambert/followers","following_url":"https://api.github.com/users/anlambert/following{/other_user}","gists_url":"https://api.github.com/users/anlambert/gists{/gist_id}","starred_url":"https://api.github.com/users/anlambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anlambert/subscriptions","organizations_url":"https://api.github.com/users/anlambert/orgs","repos_url":"https://api.github.com/users/anlambert/repos","events_url":"https://api.github.com/users/anlambert/events{/privacy}","received_events_url":"https://api.github.com/users/anlambert/received_events","type":"User","site_admin":false},"body":"Ensure a local 'Module' variable exists in the scope of the function wrapping the module and points to the renamed module object when using the modularize feature.\r\n\r\nThat small fix prevents unwanted behaviours. For instance, when using the '--preload-file' option,\r\nsome code is added at the top of the generated module for loading the '.data' file containing resources.\r\nThat code begins with:\r\n\r\nvar Module;\r\nif (typeof Module === 'undefined') Module = {};\r\n\r\nBut when using the modularize feature and since commit c5af8f6, the Module variable is undefined so this will create a new one initialized to an empty object. We do not want that to happen as if we pass a non empty object to the module wrapping function (for instance specifying 'modulePrefixURL' or 'TOTAL_MEMORY' properties), its properties values will not be used by emscripten code who always use the 'Module' variable.\r\n\r\n","created_at":"2016-10-19T16:35:32Z","updated_at":"2016-10-19T16:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1de277a079fff36d6e32cd451acaf362c0ba458","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/4638/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/4638/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/4638/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/da69a577a32df1e00dd1d3f7a1ef59e95bdd7311","head":{"label":"anlambert:modularize_Module_fix","ref":"modularize_Module_fix","sha":"da69a577a32df1e00dd1d3f7a1ef59e95bdd7311","user":{"login":"anlambert","id":5493543,"avatar_url":"https://avatars.githubusercontent.com/u/5493543?v=3","gravatar_id":"","url":"https://api.github.com/users/anlambert","html_url":"https://github.com/anlambert","followers_url":"https://api.github.com/users/anlambert/followers","following_url":"https://api.github.com/users/anlambert/following{/other_user}","gists_url":"https://api.github.com/users/anlambert/gists{/gist_id}","starred_url":"https://api.github.com/users/anlambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anlambert/subscriptions","organizations_url":"https://api.github.com/users/anlambert/orgs","repos_url":"https://api.github.com/users/anlambert/repos","events_url":"https://api.github.com/users/anlambert/events{/privacy}","received_events_url":"https://api.github.com/users/anlambert/received_events","type":"User","site_admin":false},"repo":{"id":12946667,"name":"emscripten","full_name":"anlambert/emscripten","owner":{"login":"anlambert","id":5493543,"avatar_url":"https://avatars.githubusercontent.com/u/5493543?v=3","gravatar_id":"","url":"https://api.github.com/users/anlambert","html_url":"https://github.com/anlambert","followers_url":"https://api.github.com/users/anlambert/followers","following_url":"https://api.github.com/users/anlambert/following{/other_user}","gists_url":"https://api.github.com/users/anlambert/gists{/gist_id}","starred_url":"https://api.github.com/users/anlambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anlambert/subscriptions","organizations_url":"https://api.github.com/users/anlambert/orgs","repos_url":"https://api.github.com/users/anlambert/repos","events_url":"https://api.github.com/users/anlambert/events{/privacy}","received_events_url":"https://api.github.com/users/anlambert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anlambert/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/anlambert/emscripten","forks_url":"https://api.github.com/repos/anlambert/emscripten/forks","keys_url":"https://api.github.com/repos/anlambert/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anlambert/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anlambert/emscripten/teams","hooks_url":"https://api.github.com/repos/anlambert/emscripten/hooks","issue_events_url":"https://api.github.com/repos/anlambert/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/anlambert/emscripten/events","assignees_url":"https://api.github.com/repos/anlambert/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/anlambert/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/anlambert/emscripten/tags","blobs_url":"https://api.github.com/repos/anlambert/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anlambert/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anlambert/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/anlambert/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anlambert/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/anlambert/emscripten/languages","stargazers_url":"https://api.github.com/repos/anlambert/emscripten/stargazers","contributors_url":"https://api.github.com/repos/anlambert/emscripten/contributors","subscribers_url":"https://api.github.com/repos/anlambert/emscripten/subscribers","subscription_url":"https://api.github.com/repos/anlambert/emscripten/subscription","commits_url":"https://api.github.com/repos/anlambert/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/anlambert/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/anlambert/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/anlambert/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/anlambert/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/anlambert/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anlambert/emscripten/merges","archive_url":"https://api.github.com/repos/anlambert/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anlambert/emscripten/downloads","issues_url":"https://api.github.com/repos/anlambert/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/anlambert/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/anlambert/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/anlambert/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anlambert/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/anlambert/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/anlambert/emscripten/deployments","created_at":"2013-09-19T11:11:03Z","updated_at":"2015-07-01T13:30:39Z","pushed_at":"2016-10-19T16:13:12Z","git_url":"git://github.com/anlambert/emscripten.git","ssh_url":"git@github.com:anlambert/emscripten.git","clone_url":"https://github.com/anlambert/emscripten.git","svn_url":"https://github.com/anlambert/emscripten","homepage":"","size":133623,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"0bff6778989e235f05e9bf2186dde78daf78acd3","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/kripken/emscripten/deployments","created_at":"2011-02-12T05:23:30Z","updated_at":"2016-10-19T15:03:56Z","pushed_at":"2016-10-19T16:35:32Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":174048,"stargazers_count":10797,"watchers_count":10797,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1351,"mirror_url":null,"open_issues_count":871,"forks":1351,"open_issues":871,"watchers":10797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4638"},"html":{"href":"https://github.com/kripken/emscripten/pull/4638"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/4638"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/4638/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4638/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4638/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/da69a577a32df1e00dd1d3f7a1ef59e95bdd7311"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"anlambert"}}