{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/l10n-colombia/issues/1","repository_url":"https://api.github.com/repos/OCA/l10n-colombia","labels_url":"https://api.github.com/repos/OCA/l10n-colombia/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/OCA/l10n-colombia/issues/1/comments","events_url":"https://api.github.com/repos/OCA/l10n-colombia/issues/1/events","html_url":"https://github.com/OCA/l10n-colombia/pull/1","id":161205846,"number":1,"title":"Colombian Partner Module (Localization)","user":{"login":"dkrimmer84","id":19198899,"avatar_url":"https://avatars.githubusercontent.com/u/19198899?v=3","gravatar_id":"","url":"https://api.github.com/users/dkrimmer84","html_url":"https://github.com/dkrimmer84","followers_url":"https://api.github.com/users/dkrimmer84/followers","following_url":"https://api.github.com/users/dkrimmer84/following{/other_user}","gists_url":"https://api.github.com/users/dkrimmer84/gists{/gist_id}","starred_url":"https://api.github.com/users/dkrimmer84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkrimmer84/subscriptions","organizations_url":"https://api.github.com/users/dkrimmer84/orgs","repos_url":"https://api.github.com/users/dkrimmer84/repos","events_url":"https://api.github.com/users/dkrimmer84/events{/privacy}","received_events_url":"https://api.github.com/users/dkrimmer84/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2016-06-20T14:18:28Z","updated_at":"2016-07-16T22:36:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OCA/l10n-colombia/pulls/1","html_url":"https://github.com/OCA/l10n-colombia/pull/1","diff_url":"https://github.com/OCA/l10n-colombia/pull/1.diff","patch_url":"https://github.com/OCA/l10n-colombia/pull/1.patch"},"body":"Added: **Colombian Partner Module** (l10n_co_res_partner)\r\n\r\n- Redesign of the contact form due to some local rules that have to apply\r\n- Additional fields: first name, second name, last name, second last name\r\n- Additional fields: Type of Person, Document Type, Document Number, Tributate regime, CIIU Code\r\n- Handling all kind of identification types that are relevant in Colombia\r\n- Intelligent form: Fields will be checked for correctness and completeness\r\n- Identification Number added into Tree View\r\n- Identification Number added into KanBan View\r\n- Visual Identifier for incomplete contacts in Kanban- and Tree view\r\n- Auto-Complete of NIT: Type in the NIT and the Verification Digit will be calculated automatically\r\n- Description of economic activities (CIIU Code), including the entire list to maintain it\r\n- Maintain the CIIU list under this new menu point: Accounting/Configuration/Accounting/CIIU\r\n- Contacts can be found by Identification Number (e.g. NIT)\r\n- Added a complete list of all cities and departments in Colombia\r\n- Country, Department and Municipality Dependency Logic in order to avoid confusion of locations with the same name\r\n- Identification / Document-Type combination will be checked as it should be unique\r\n- All changes available in english (choose language: en_GB)\r\n\r\n**Kicked:** (Let’s kick useless stuff out of the README for now and make it awesome later)\r\n\r\n- Runbot does not work\r\n- Build status does not work.\r\n- Coverage not used, so it is useless right now\r\n- Code climate does not work"},"comment":{"url":"https://api.github.com/repos/OCA/l10n-colombia/issues/comments/233154602","html_url":"https://github.com/OCA/l10n-colombia/pull/1#issuecomment-233154602","issue_url":"https://api.github.com/repos/OCA/l10n-colombia/issues/1","id":233154602,"user":{"login":"dreispt","id":1246629,"avatar_url":"https://avatars.githubusercontent.com/u/1246629?v=3","gravatar_id":"","url":"https://api.github.com/users/dreispt","html_url":"https://github.com/dreispt","followers_url":"https://api.github.com/users/dreispt/followers","following_url":"https://api.github.com/users/dreispt/following{/other_user}","gists_url":"https://api.github.com/users/dreispt/gists{/gist_id}","starred_url":"https://api.github.com/users/dreispt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreispt/subscriptions","organizations_url":"https://api.github.com/users/dreispt/orgs","repos_url":"https://api.github.com/users/dreispt/repos","events_url":"https://api.github.com/users/dreispt/events{/privacy}","received_events_url":"https://api.github.com/users/dreispt/received_events","type":"User","site_admin":false},"created_at":"2016-07-16T22:36:29Z","updated_at":"2016-07-16T22:36:29Z","body":"> I contributed as a functional expert in this localization project, modifications are designed to be used by any company in Colombia, only in Colombia, this is a localization module.\r\n\r\nI'm aware that this is a localization project, and one that I'm not familiar with the local requirements.\r\nSo again, I'm the first to state that I can't have an authoritative opinion about the localization specifics.\r\n\r\n> The Odoo localization is aimed at a specific context, so it can not be evaluated in the same manner as a generic module. This is the first of several modules that are necessary to adapt Odoo to the Colombian context\r\n> The localization is much more than a list of accounts or tax\r\n> I appreciate the work done by OCA, by you, but in the case of modules localization the review should be limited to technical issues and to encourage local teams to continue to make contributions.\r\n\r\nReviews must be both functional and technical.\r\nProponents should be prepared to explain their choices, and sometimes reviewers can suggest better designs not thought bu the original authors. That is collaboration.\r\nAnd OCA Maintainers have the responsibility to prevent having the same feature implemented twice in the OCA codebase, and to make sure that all OCA modules stay compatible.\r\nThe is only possible if we do functional reviews.\r\n\r\n> In the functional aspects should be given freedom to users in the country to decide whether it is useful or not.\r\n\r\nAnd they have.\r\nIn my case I don't know your local requirements, but that doesn't prevent me from making questions.\r\n\r\n> Put barriers to this initiative by aspects different of technical, rather than helping, it makes motivation is lowered.\r\n\r\nThe mission of the OCA is to provide high quality modules.\r\nReviewers are here to help contributors improve their modules so that they meet top standards.\r\nPlease read again my comments: when I'm unsure about something, I ask \"why\". \r\nWhen I disagree with something I usually say \"X has this problem, have you considered Y\". In this case I make an effort to always be constructive and provide actionable advice.\r\nThis is different from destructively just putting barriers. \r\n\r\n> That's the reason for my negative reaction\r\n\r\nIt's OK to disagree with your reviewers comments.\r\nJust answer the questions made or counter-argument on the comments you don't agree.\r\nBut be sure that odds are that your original design is not the best.\r\nSometime a different person can point you at good solutions you didn't think or didn't know about.\r\n\r\nYou don't have a problem when  you get reviews with concerns about your code.\r\nYou have a problem when you have no reviewers for your code, and can't get it merged into the OCA.\r\nTwo independent reviews are needed, and I'm getting out of my way to help you get one.\r\n"}}
{"actor":{"display_login":"dreispt"}}