{"action":"closed","number":371,"pull_request":{"url":"https://api.github.com/repos/vimperator/vimperator-labs/pulls/371","id":55455897,"html_url":"https://github.com/vimperator/vimperator-labs/pull/371","diff_url":"https://github.com/vimperator/vimperator-labs/pull/371.diff","patch_url":"https://github.com/vimperator/vimperator-labs/pull/371.patch","issue_url":"https://api.github.com/repos/vimperator/vimperator-labs/issues/371","number":371,"state":"closed","locked":false,"title":"Closes #370 use findbar to find through the command line","user":{"login":"Quicksaver","id":802086,"avatar_url":"https://avatars.githubusercontent.com/u/802086?v=3","gravatar_id":"","url":"https://api.github.com/users/Quicksaver","html_url":"https://github.com/Quicksaver","followers_url":"https://api.github.com/users/Quicksaver/followers","following_url":"https://api.github.com/users/Quicksaver/following{/other_user}","gists_url":"https://api.github.com/users/Quicksaver/gists{/gist_id}","starred_url":"https://api.github.com/users/Quicksaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quicksaver/subscriptions","organizations_url":"https://api.github.com/users/Quicksaver/orgs","repos_url":"https://api.github.com/users/Quicksaver/repos","events_url":"https://api.github.com/users/Quicksaver/events{/privacy}","received_events_url":"https://api.github.com/users/Quicksaver/received_events","type":"User","site_admin":false},"body":"- Removed old and unnecessary bits, from before the findbar was per-tab.\r\n- Updated bits to reflect the current async nature of the findbar; please read the note I added at the top about how difficult it would be to implement the TODOs in there. In short, Vimperator would need to create its whole new system, which would make it incompatible with pretty much anything findbar-related out there, and would be hell to maintain.\r\n- Changed the behavior considerably: where before searches through the findbar and through the commandline would be independent, they are now pretty much the same since Vimperator now acts as more of a mediator between the user input in the commandline and the actual findbar.\r\n  - Easiest case to visualize is this: find in the commandline \"a\", then open findbar and find \"b\" in it, then back in normal mode press \"n\" to find the next match through Vimperator. **Before** it would find the next match for \"a\" because that's the last search run in Vimperator. **Now** it will find the next match for \"b\" because that's the last search run overall. If you then search for \"c\" in the commandline, then go back to normal mode and press the \"n\" key, it will find the next match for \"c\" as expected, since that's now the last search run overall.\r\n- Removed no longer necessary bits about focusing links and removing previous selections stuff (since Vimperator goes through Firefox's native methods, and they do this automatically), which means at least its find feature is now e10s-compatible.\r\n- Bonus: works with PDF.JS reader. :)\r\n- Anti-bonus: I did **not** test these changes in Thunderbird's Muttator, so it still warrants some testing there. But to be honest I don't foresee any problems there, since it uses the same find toolbar widget from toolkit as Firefox does.","created_at":"2016-01-08T12:21:14Z","updated_at":"2016-01-09T13:53:39Z","closed_at":"2016-01-09T13:53:39Z","merged_at":"2016-01-09T13:53:39Z","merge_commit_sha":"5486055ff0f85d6f9eb1500d2be0314d5f2ca873","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vimperator/vimperator-labs/pulls/371/commits","review_comments_url":"https://api.github.com/repos/vimperator/vimperator-labs/pulls/371/comments","review_comment_url":"https://api.github.com/repos/vimperator/vimperator-labs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vimperator/vimperator-labs/issues/371/comments","statuses_url":"https://api.github.com/repos/vimperator/vimperator-labs/statuses/9cce65339a4ab526ac9911a9c0b94a01185b6ee2","head":{"label":"Quicksaver:master","ref":"master","sha":"9cce65339a4ab526ac9911a9c0b94a01185b6ee2","user":{"login":"Quicksaver","id":802086,"avatar_url":"https://avatars.githubusercontent.com/u/802086?v=3","gravatar_id":"","url":"https://api.github.com/users/Quicksaver","html_url":"https://github.com/Quicksaver","followers_url":"https://api.github.com/users/Quicksaver/followers","following_url":"https://api.github.com/users/Quicksaver/following{/other_user}","gists_url":"https://api.github.com/users/Quicksaver/gists{/gist_id}","starred_url":"https://api.github.com/users/Quicksaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quicksaver/subscriptions","organizations_url":"https://api.github.com/users/Quicksaver/orgs","repos_url":"https://api.github.com/users/Quicksaver/repos","events_url":"https://api.github.com/users/Quicksaver/events{/privacy}","received_events_url":"https://api.github.com/users/Quicksaver/received_events","type":"User","site_admin":false},"repo":{"id":49155029,"name":"vimperator-labs","full_name":"Quicksaver/vimperator-labs","owner":{"login":"Quicksaver","id":802086,"avatar_url":"https://avatars.githubusercontent.com/u/802086?v=3","gravatar_id":"","url":"https://api.github.com/users/Quicksaver","html_url":"https://github.com/Quicksaver","followers_url":"https://api.github.com/users/Quicksaver/followers","following_url":"https://api.github.com/users/Quicksaver/following{/other_user}","gists_url":"https://api.github.com/users/Quicksaver/gists{/gist_id}","starred_url":"https://api.github.com/users/Quicksaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quicksaver/subscriptions","organizations_url":"https://api.github.com/users/Quicksaver/orgs","repos_url":"https://api.github.com/users/Quicksaver/repos","events_url":"https://api.github.com/users/Quicksaver/events{/privacy}","received_events_url":"https://api.github.com/users/Quicksaver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Quicksaver/vimperator-labs","description":"Vimperator","fork":true,"url":"https://api.github.com/repos/Quicksaver/vimperator-labs","forks_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/forks","keys_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/teams","hooks_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/hooks","issue_events_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/issues/events{/number}","events_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/events","assignees_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/assignees{/user}","branches_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/branches{/branch}","tags_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/tags","blobs_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/languages","stargazers_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/stargazers","contributors_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/contributors","subscribers_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/subscribers","subscription_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/subscription","commits_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/contents/{+path}","compare_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/merges","archive_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/downloads","issues_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/issues{/number}","pulls_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/labels{/name}","releases_url":"https://api.github.com/repos/Quicksaver/vimperator-labs/releases{/id}","created_at":"2016-01-06T18:55:30Z","updated_at":"2016-01-06T18:55:31Z","pushed_at":"2016-01-08T12:08:07Z","git_url":"git://github.com/Quicksaver/vimperator-labs.git","ssh_url":"git@github.com:Quicksaver/vimperator-labs.git","clone_url":"https://github.com/Quicksaver/vimperator-labs.git","svn_url":"https://github.com/Quicksaver/vimperator-labs","homepage":"http://code.google.com/p/vimperator-labs/","size":7142,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vimperator:master","ref":"master","sha":"51c04a95f33b694bcb1e7b61e3a8b22c3308fccb","user":{"login":"vimperator","id":7980684,"avatar_url":"https://avatars.githubusercontent.com/u/7980684?v=3","gravatar_id":"","url":"https://api.github.com/users/vimperator","html_url":"https://github.com/vimperator","followers_url":"https://api.github.com/users/vimperator/followers","following_url":"https://api.github.com/users/vimperator/following{/other_user}","gists_url":"https://api.github.com/users/vimperator/gists{/gist_id}","starred_url":"https://api.github.com/users/vimperator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimperator/subscriptions","organizations_url":"https://api.github.com/users/vimperator/orgs","repos_url":"https://api.github.com/users/vimperator/repos","events_url":"https://api.github.com/users/vimperator/events{/privacy}","received_events_url":"https://api.github.com/users/vimperator/received_events","type":"Organization","site_admin":false},"repo":{"id":10753240,"name":"vimperator-labs","full_name":"vimperator/vimperator-labs","owner":{"login":"vimperator","id":7980684,"avatar_url":"https://avatars.githubusercontent.com/u/7980684?v=3","gravatar_id":"","url":"https://api.github.com/users/vimperator","html_url":"https://github.com/vimperator","followers_url":"https://api.github.com/users/vimperator/followers","following_url":"https://api.github.com/users/vimperator/following{/other_user}","gists_url":"https://api.github.com/users/vimperator/gists{/gist_id}","starred_url":"https://api.github.com/users/vimperator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimperator/subscriptions","organizations_url":"https://api.github.com/users/vimperator/orgs","repos_url":"https://api.github.com/users/vimperator/repos","events_url":"https://api.github.com/users/vimperator/events{/privacy}","received_events_url":"https://api.github.com/users/vimperator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vimperator/vimperator-labs","description":"Vimperator","fork":false,"url":"https://api.github.com/repos/vimperator/vimperator-labs","forks_url":"https://api.github.com/repos/vimperator/vimperator-labs/forks","keys_url":"https://api.github.com/repos/vimperator/vimperator-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vimperator/vimperator-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vimperator/vimperator-labs/teams","hooks_url":"https://api.github.com/repos/vimperator/vimperator-labs/hooks","issue_events_url":"https://api.github.com/repos/vimperator/vimperator-labs/issues/events{/number}","events_url":"https://api.github.com/repos/vimperator/vimperator-labs/events","assignees_url":"https://api.github.com/repos/vimperator/vimperator-labs/assignees{/user}","branches_url":"https://api.github.com/repos/vimperator/vimperator-labs/branches{/branch}","tags_url":"https://api.github.com/repos/vimperator/vimperator-labs/tags","blobs_url":"https://api.github.com/repos/vimperator/vimperator-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vimperator/vimperator-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vimperator/vimperator-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/vimperator/vimperator-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vimperator/vimperator-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/vimperator/vimperator-labs/languages","stargazers_url":"https://api.github.com/repos/vimperator/vimperator-labs/stargazers","contributors_url":"https://api.github.com/repos/vimperator/vimperator-labs/contributors","subscribers_url":"https://api.github.com/repos/vimperator/vimperator-labs/subscribers","subscription_url":"https://api.github.com/repos/vimperator/vimperator-labs/subscription","commits_url":"https://api.github.com/repos/vimperator/vimperator-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/vimperator/vimperator-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/vimperator/vimperator-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/vimperator/vimperator-labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/vimperator/vimperator-labs/contents/{+path}","compare_url":"https://api.github.com/repos/vimperator/vimperator-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vimperator/vimperator-labs/merges","archive_url":"https://api.github.com/repos/vimperator/vimperator-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vimperator/vimperator-labs/downloads","issues_url":"https://api.github.com/repos/vimperator/vimperator-labs/issues{/number}","pulls_url":"https://api.github.com/repos/vimperator/vimperator-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/vimperator/vimperator-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/vimperator/vimperator-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vimperator/vimperator-labs/labels{/name}","releases_url":"https://api.github.com/repos/vimperator/vimperator-labs/releases{/id}","created_at":"2013-06-18T03:46:13Z","updated_at":"2016-01-08T03:01:42Z","pushed_at":"2016-01-09T13:53:40Z","git_url":"git://github.com/vimperator/vimperator-labs.git","ssh_url":"git@github.com:vimperator/vimperator-labs.git","clone_url":"https://github.com/vimperator/vimperator-labs.git","svn_url":"https://github.com/vimperator/vimperator-labs","homepage":"http://code.google.com/p/vimperator-labs/","size":7201,"stargazers_count":488,"watchers_count":488,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":155,"forks":110,"open_issues":155,"watchers":488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vimperator/vimperator-labs/pulls/371"},"html":{"href":"https://github.com/vimperator/vimperator-labs/pull/371"},"issue":{"href":"https://api.github.com/repos/vimperator/vimperator-labs/issues/371"},"comments":{"href":"https://api.github.com/repos/vimperator/vimperator-labs/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/vimperator/vimperator-labs/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/vimperator/vimperator-labs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vimperator/vimperator-labs/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/vimperator/vimperator-labs/statuses/9cce65339a4ab526ac9911a9c0b94a01185b6ee2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"maxauthority","id":5980591,"avatar_url":"https://avatars.githubusercontent.com/u/5980591?v=3","gravatar_id":"","url":"https://api.github.com/users/maxauthority","html_url":"https://github.com/maxauthority","followers_url":"https://api.github.com/users/maxauthority/followers","following_url":"https://api.github.com/users/maxauthority/following{/other_user}","gists_url":"https://api.github.com/users/maxauthority/gists{/gist_id}","starred_url":"https://api.github.com/users/maxauthority/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxauthority/subscriptions","organizations_url":"https://api.github.com/users/maxauthority/orgs","repos_url":"https://api.github.com/users/maxauthority/repos","events_url":"https://api.github.com/users/maxauthority/events{/privacy}","received_events_url":"https://api.github.com/users/maxauthority/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":138,"deletions":143,"changed_files":1}}