{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/4133","repository_url":"https://api.github.com/repos/astropy/astropy","labels_url":"https://api.github.com/repos/astropy/astropy/issues/4133/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4133/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/4133/events","html_url":"https://github.com/astropy/astropy/pull/4133","id":105383201,"number":4133,"title":"Doc build path varies between setup.py build_docs and make html","user":{"login":"saimn","id":311639,"avatar_url":"https://avatars.githubusercontent.com/u/311639?v=3","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/astropy/astropy/labels/astropy-helpers","name":"astropy-helpers","color":"eb6420"},{"url":"https://api.github.com/repos/astropy/astropy/labels/build","name":"build","color":"d4c5f9"},{"url":"https://api.github.com/repos/astropy/astropy/labels/Docs","name":"Docs","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2015-09-08T13:43:34Z","updated_at":"2016-07-05T20:59:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4133","html_url":"https://github.com/astropy/astropy/pull/4133","diff_url":"https://github.com/astropy/astropy/pull/4133.diff","patch_url":"https://github.com/astropy/astropy/pull/4133.patch"},"body":"When using a classic `make html` inside the doc directory, the doc is build in `docs/_build/html`.\r\nBut when using `python setup.py build_docs` as stated in the [install page](http://astropy.readthedocs.org/en/latest/install.html#builddocs) the output path is `build/sphinx/html` which is quite confusing. I had an old version of the doc in the first directory, which was not updated when running build_docs.\r\n\r\nThe `build/sphinx/` path seems to come from `sphinx.setup_command.BuildDoc`, maybe it could modified in `AstropyBuildSphinx` to `docs/_build/` and have the same output drectory as `make html` ?\r\n\r\nFuthermore `make html` is broken for me with Python 3.4. This is related to  #2532, but in my case, with python 3 and an install in develop mode, `import astropy_helpers` works because the astropy_helpers directory is inside the astropy one pointed by the .egg-link,  but it returns an invalid module:\r\n```\r\n~/lib/astropy/docs docs\r\n(astropy)❯ python -c 'import astropy_helpers; print(astropy_helpers)'\r\n<module 'astropy_helpers' (namespace)>\r\n``` \r\nWith the following patch I can use `make html` in the docs directory, but it is just more hackish :\r\n\r\n```\r\ndiff --git a/docs/conf.py b/docs/conf.py\r\nindex 11192b9..9ae24ea 100644\r\n--- a/docs/conf.py\r\n+++ b/docs/conf.py\r\n@@ -26,7 +26,7 @@\r\n # be accessible, and the documentation will not build correctly.\r\n \r\n try:\r\n-    import astropy_helpers\r\n+    from astropy_helpers.sphinx.conf import *\r\n except ImportError:\r\n     # Building from inside the docs/ directory?\r\n     import os\r\n@@ -36,6 +36,9 @@ except ImportError:\r\n         if os.path.isdir(a_h_path):\r\n             sys.path.insert(1, a_h_path)\r\n \r\n+    if 'astropy_helpers' in sys.modules:\r\n+        del sys.modules['astropy_helpers']\r\n+\r\n     # If that doesn't work trying to import from astropy_helpers below will\r\n     # still blow up\r\n```"},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/230601338","html_url":"https://github.com/astropy/astropy/pull/4133#issuecomment-230601338","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4133","id":230601338,"user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T20:59:13Z","updated_at":"2016-07-05T20:59:13Z","body":"But yes indeed, we need to update ``setup.cfg`` - thanks for spotting the issue!"}}
{"actor":{"display_login":"astrofrog"}}