{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/143","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/143/comments","events_url":"https://api.github.com/repos/coq/coq/issues/143/events","html_url":"https://github.com/coq/coq/pull/143","id":133840203,"number":143,"title":"First steps in Feedback/PP cleanup.","user":{"login":"ejgallego","id":7192257,"avatar_url":"https://avatars.githubusercontent.com/u/7192257?v=3","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-15T23:13:41Z","updated_at":"2016-05-30T13:37:10Z","closed_at":"2016-05-30T13:37:10Z","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/143","html_url":"https://github.com/coq/coq/pull/143","diff_url":"https://github.com/coq/coq/pull/143.diff","patch_url":"https://github.com/coq/coq/pull/143.patch"},"body":"This PR is a step towards the completion of the migration from the old-style `Pp.pp` interface to the new, feedback based one.\r\n\r\nBasically we:\r\n\r\n* Remove all legacy functions.\r\n* Remove all IO from `Pp`.\r\n* Streamline and clenaup the logger/feedback interface.a\r\n\r\nThis change breaks plugin's API; CHANGES.API contains more details.\r\n\r\nThis PR is not ready for a merge yet, but I'm submitting for review/discussion on the ideas posed here.\r\n\r\nA version of this PR for trunk exists, but I'm still thinking about the changes to trunk feedback `Format` to push it.\r\n\r\n## Essential TODOs:\r\n\r\n* Clean up pp_control and pp_style to operate in a formatter basis.\r\n* Move IO users (toploop) to be feedback consumers.\r\n\r\n## Other TODOs:\r\n\r\n* Create a Format-based, modern `Log` module? This new API would have support for automatic handling of located items, filtering, streams, etc...\r\n* Remove `Pp.Tag`? It may be overkill, as we could rely on `Format` tag for most purposes (as is currently done under the hood).\r\n* Remove `Pp`. IMO this would be interesting and as things currently stand, it would improve the handling of pretty printing in\r\n  Coq. However, Coq's error handling strategy relies in the marshalling of pretty printing trees, so a clarification on the error API itself would be needed before this."},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/222494388","html_url":"https://github.com/coq/coq/pull/143#issuecomment-222494388","issue_url":"https://api.github.com/repos/coq/coq/issues/143","id":222494388,"user":{"login":"ejgallego","id":7192257,"avatar_url":"https://avatars.githubusercontent.com/u/7192257?v=3","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T13:37:10Z","updated_at":"2016-05-30T13:37:10Z","body":"Superseeded by #179"}}
{"actor":{"display_login":"ejgallego"}}