{"action":"opened","issue":{"url":"https://api.github.com/repos/defuse/php-encryption/issues/193","repository_url":"https://api.github.com/repos/defuse/php-encryption","labels_url":"https://api.github.com/repos/defuse/php-encryption/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/defuse/php-encryption/issues/193/comments","events_url":"https://api.github.com/repos/defuse/php-encryption/issues/193/events","html_url":"https://github.com/defuse/php-encryption/issues/193","id":145554475,"number":193,"title":"Remove unnecessary complexity by making Key always 32 bytes","user":{"login":"defuse","id":4211072,"avatar_url":"https://avatars.githubusercontent.com/u/4211072?v=3","gravatar_id":"","url":"https://api.github.com/users/defuse","html_url":"https://github.com/defuse","followers_url":"https://api.github.com/users/defuse/followers","following_url":"https://api.github.com/users/defuse/following{/other_user}","gists_url":"https://api.github.com/users/defuse/gists{/gist_id}","starred_url":"https://api.github.com/users/defuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defuse/subscriptions","organizations_url":"https://api.github.com/users/defuse/orgs","repos_url":"https://api.github.com/users/defuse/repos","events_url":"https://api.github.com/users/defuse/events{/privacy}","received_events_url":"https://api.github.com/users/defuse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-04-04T00:04:35Z","updated_at":"2016-04-04T00:04:35Z","closed_at":null,"body":"We can probably get rid of the entire KeyConfig class, it isn't necessary. Just *always* use 32 bytes with SHA256 for the checksum with 32 bytes of checksum. Store it in the same format so *in case it's necessary* we can bring that complexity back later.\r\n\r\nI learned a lesson here: Design your protocols so that they *can* be upgraded, but don't *implement* that additional complexity until you know it's necessary."}}