{"action":"opened","number":6791,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/6791","id":65377539,"html_url":"https://github.com/elastic/kibana/pull/6791","diff_url":"https://github.com/elastic/kibana/pull/6791.diff","patch_url":"https://github.com/elastic/kibana/pull/6791.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/6791","number":6791,"state":"open","locked":false,"title":"Added a custom banner feature in advanced settings","user":{"login":"bevacqua","id":934293,"avatar_url":"https://avatars.githubusercontent.com/u/934293?v=3","gravatar_id":"","url":"https://api.github.com/users/bevacqua","html_url":"https://github.com/bevacqua","followers_url":"https://api.github.com/users/bevacqua/followers","following_url":"https://api.github.com/users/bevacqua/following{/other_user}","gists_url":"https://api.github.com/users/bevacqua/gists{/gist_id}","starred_url":"https://api.github.com/users/bevacqua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bevacqua/subscriptions","organizations_url":"https://api.github.com/users/bevacqua/orgs","repos_url":"https://api.github.com/users/bevacqua/repos","events_url":"https://api.github.com/users/bevacqua/events{/privacy}","received_events_url":"https://api.github.com/users/bevacqua/received_events","type":"User","site_admin":false},"body":"Replaces #6765. Fixes #4452 by adding the ability to compose a toast notification using Markdown through advanced settings.\r\n\r\n- Adds [`trunc-text`][ttext] and [`trunc-html`][thtml] which are two small modules that handle proper text and HTML truncation by words\r\n- Adds advanced setting display mode for Markdown, which gets rendered as HTML\r\n- Adds Markdown filter which allows to easily render text as HTML in views\r\n- Adds support in `kbn-truncated` for truncated HTML\r\n- Adds banner notification support\r\n- Minor refactors like removing an outdated piece of commented-out code, replacing `var` with `const`, etc.\r\n- [ ] We can customize which types of DOM elements are allowed in the banner notification. Currently it's only sanitized via `marked` and `insane`, meaning there won't be any `<script>` tags or any other craze like that.\r\n- [ ] Is missing style configuration _(namely: `background-color`)_ because I need advice as to where to modify styles, and how the notification should be presented\r\n\r\nSome screenshots:\r\n\r\n<img width=\"1434\" alt=\"screen shot 2016-04-04 at 15 19 38\" src=\"https://cloud.githubusercontent.com/assets/934293/14258397/bd4b98cc-fa78-11e5-8c16-60fc661cce58.png\">\r\n<img width=\"1160\" alt=\"screen shot 2016-04-04 at 15 20 04\" src=\"https://cloud.githubusercontent.com/assets/934293/14258398/bd72ee40-fa78-11e5-8856-b9afe3515664.png\">\r\n<img width=\"1166\" alt=\"screen shot 2016-04-04 at 15 20 09\" src=\"https://cloud.githubusercontent.com/assets/934293/14258399/bd82ee3a-fa78-11e5-8b84-4ce624dcdc97.png\">\r\n\r\n[ttext]: https://github.com/bevacqua/trunc-text\r\n[thtml]: https://github.com/bevacqua/trunc-html","created_at":"2016-04-05T21:58:21Z","updated_at":"2016-04-05T21:58:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"tsullivan","id":908371,"avatar_url":"https://avatars.githubusercontent.com/u/908371?v=3","gravatar_id":"","url":"https://api.github.com/users/tsullivan","html_url":"https://github.com/tsullivan","followers_url":"https://api.github.com/users/tsullivan/followers","following_url":"https://api.github.com/users/tsullivan/following{/other_user}","gists_url":"https://api.github.com/users/tsullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsullivan/subscriptions","organizations_url":"https://api.github.com/users/tsullivan/orgs","repos_url":"https://api.github.com/users/tsullivan/repos","events_url":"https://api.github.com/users/tsullivan/events{/privacy}","received_events_url":"https://api.github.com/users/tsullivan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/6791/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/6791/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/6791/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/61a6ff52ee9d48bf935e0bb8e6b71576b72bb40a","head":{"label":"bevacqua:feature/custom-toaster-banner","ref":"feature/custom-toaster-banner","sha":"61a6ff52ee9d48bf935e0bb8e6b71576b72bb40a","user":{"login":"bevacqua","id":934293,"avatar_url":"https://avatars.githubusercontent.com/u/934293?v=3","gravatar_id":"","url":"https://api.github.com/users/bevacqua","html_url":"https://github.com/bevacqua","followers_url":"https://api.github.com/users/bevacqua/followers","following_url":"https://api.github.com/users/bevacqua/following{/other_user}","gists_url":"https://api.github.com/users/bevacqua/gists{/gist_id}","starred_url":"https://api.github.com/users/bevacqua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bevacqua/subscriptions","organizations_url":"https://api.github.com/users/bevacqua/orgs","repos_url":"https://api.github.com/users/bevacqua/repos","events_url":"https://api.github.com/users/bevacqua/events{/privacy}","received_events_url":"https://api.github.com/users/bevacqua/received_events","type":"User","site_admin":false},"repo":{"id":53334717,"name":"kibana","full_name":"bevacqua/kibana","owner":{"login":"bevacqua","id":934293,"avatar_url":"https://avatars.githubusercontent.com/u/934293?v=3","gravatar_id":"","url":"https://api.github.com/users/bevacqua","html_url":"https://github.com/bevacqua","followers_url":"https://api.github.com/users/bevacqua/followers","following_url":"https://api.github.com/users/bevacqua/following{/other_user}","gists_url":"https://api.github.com/users/bevacqua/gists{/gist_id}","starred_url":"https://api.github.com/users/bevacqua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bevacqua/subscriptions","organizations_url":"https://api.github.com/users/bevacqua/orgs","repos_url":"https://api.github.com/users/bevacqua/repos","events_url":"https://api.github.com/users/bevacqua/events{/privacy}","received_events_url":"https://api.github.com/users/bevacqua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bevacqua/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/bevacqua/kibana","forks_url":"https://api.github.com/repos/bevacqua/kibana/forks","keys_url":"https://api.github.com/repos/bevacqua/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bevacqua/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bevacqua/kibana/teams","hooks_url":"https://api.github.com/repos/bevacqua/kibana/hooks","issue_events_url":"https://api.github.com/repos/bevacqua/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/bevacqua/kibana/events","assignees_url":"https://api.github.com/repos/bevacqua/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/bevacqua/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/bevacqua/kibana/tags","blobs_url":"https://api.github.com/repos/bevacqua/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bevacqua/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bevacqua/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/bevacqua/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bevacqua/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/bevacqua/kibana/languages","stargazers_url":"https://api.github.com/repos/bevacqua/kibana/stargazers","contributors_url":"https://api.github.com/repos/bevacqua/kibana/contributors","subscribers_url":"https://api.github.com/repos/bevacqua/kibana/subscribers","subscription_url":"https://api.github.com/repos/bevacqua/kibana/subscription","commits_url":"https://api.github.com/repos/bevacqua/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/bevacqua/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/bevacqua/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/bevacqua/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/bevacqua/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/bevacqua/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bevacqua/kibana/merges","archive_url":"https://api.github.com/repos/bevacqua/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bevacqua/kibana/downloads","issues_url":"https://api.github.com/repos/bevacqua/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/bevacqua/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/bevacqua/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/bevacqua/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bevacqua/kibana/labels{/name}","releases_url":"https://api.github.com/repos/bevacqua/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/bevacqua/kibana/deployments","created_at":"2016-03-07T15:10:45Z","updated_at":"2016-03-15T19:10:52Z","pushed_at":"2016-04-05T21:57:18Z","git_url":"git://github.com/bevacqua/kibana.git","ssh_url":"git@github.com:bevacqua/kibana.git","clone_url":"https://github.com/bevacqua/kibana.git","svn_url":"https://github.com/bevacqua/kibana","homepage":"https://www.elastic.co/products/kibana","size":102296,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"552e291302e2052c53a2a66f49e24778fcc68e0f","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2016-04-05T14:44:12Z","pushed_at":"2016-04-05T21:37:59Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":142849,"stargazers_count":5078,"watchers_count":5078,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1915,"mirror_url":null,"open_issues_count":942,"forks":1915,"open_issues":942,"watchers":5078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6791"},"html":{"href":"https://github.com/elastic/kibana/pull/6791"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/6791"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/6791/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6791/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6791/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/61a6ff52ee9d48bf935e0bb8e6b71576b72bb40a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":99,"deletions":40,"changed_files":13}}