{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/82338678","pull_request_review_id":3253671,"id":82338678,"diff_hunk":"@@ -315,6 +332,23 @@ class HostJSTest < IntegrationTestWithJavascript\n       click_link 'Parameters'\n       assert_equal find(\"#s2id_host_lookup_values_attributes_#{lookup_key.id}_value .select2-chosen\").text, \"true\"\n     end\n+\n+    test 'changing host group updates parameters tab' do","path":"test/integration/host_js_test.rb","position":52,"original_position":52,"commit_id":"6436e23106a2049b1a0254bb62c61647205aaeb7","original_commit_id":"8310d42cce56de8b2632434e2b58172e64000734","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"They're in different contexts, but I've changed this one to \"setting host group [..]\" as it's not changing from one group to another.","created_at":"2016-10-07T07:12:07Z","updated_at":"2016-10-07T07:12:07Z","html_url":"https://github.com/theforeman/foreman/pull/3920#discussion_r82338678","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/3920","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/82338678"},"html":{"href":"https://github.com/theforeman/foreman/pull/3920#discussion_r82338678"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3920"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3920","id":88089094,"html_url":"https://github.com/theforeman/foreman/pull/3920","diff_url":"https://github.com/theforeman/foreman/pull/3920.diff","patch_url":"https://github.com/theforeman/foreman/pull/3920.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3920","number":3920,"state":"open","locked":false,"title":"fixes #16805 - reload host parameters on host group change","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"On Rails 4.2, `Host#type_changed?` may return nil due to bug #24220\r\ncausing data-type-changed to be missing from the host form and the JS\r\nin handleHostgroupChangeEdit to assume host#edit is a hostgroup form.\r\nNow that data-type-changed is always present, the full reload of\r\nparameters occurs when the host group is changed on a host.","created_at":"2016-10-05T14:30:02Z","updated_at":"2016-10-07T07:12:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"772cd710dc737c1ceb43e543bf7a8c83f6bf3c33","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3920/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3920/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3920/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/6436e23106a2049b1a0254bb62c61647205aaeb7","head":{"label":"domcleal:16805-hg-change-reload","ref":"16805-hg-change-reload","sha":"6436e23106a2049b1a0254bb62c61647205aaeb7","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"repo":{"id":6577737,"name":"foreman","full_name":"domcleal/foreman","owner":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domcleal/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/domcleal/foreman","forks_url":"https://api.github.com/repos/domcleal/foreman/forks","keys_url":"https://api.github.com/repos/domcleal/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domcleal/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domcleal/foreman/teams","hooks_url":"https://api.github.com/repos/domcleal/foreman/hooks","issue_events_url":"https://api.github.com/repos/domcleal/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/domcleal/foreman/events","assignees_url":"https://api.github.com/repos/domcleal/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/domcleal/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/domcleal/foreman/tags","blobs_url":"https://api.github.com/repos/domcleal/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domcleal/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domcleal/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/domcleal/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domcleal/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/domcleal/foreman/languages","stargazers_url":"https://api.github.com/repos/domcleal/foreman/stargazers","contributors_url":"https://api.github.com/repos/domcleal/foreman/contributors","subscribers_url":"https://api.github.com/repos/domcleal/foreman/subscribers","subscription_url":"https://api.github.com/repos/domcleal/foreman/subscription","commits_url":"https://api.github.com/repos/domcleal/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/domcleal/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/domcleal/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/domcleal/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/domcleal/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/domcleal/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domcleal/foreman/merges","archive_url":"https://api.github.com/repos/domcleal/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domcleal/foreman/downloads","issues_url":"https://api.github.com/repos/domcleal/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/domcleal/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/domcleal/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/domcleal/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domcleal/foreman/labels{/name}","releases_url":"https://api.github.com/repos/domcleal/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/domcleal/foreman/deployments","created_at":"2012-11-07T10:48:14Z","updated_at":"2016-08-25T09:42:15Z","pushed_at":"2016-10-07T07:11:45Z","git_url":"git://github.com/domcleal/foreman.git","ssh_url":"git@github.com:domcleal/foreman.git","clone_url":"https://github.com/domcleal/foreman.git","svn_url":"https://github.com/domcleal/foreman","homepage":"http://theforeman.org","size":48609,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"a4d7a037ba2cd143713e6a92f49ad6dc8c314628","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-10-05T03:43:09Z","pushed_at":"2016-10-07T07:11:46Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":72371,"stargazers_count":1093,"watchers_count":1093,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":552,"mirror_url":null,"open_issues_count":78,"forks":552,"open_issues":78,"watchers":1093,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3920"},"html":{"href":"https://github.com/theforeman/foreman/pull/3920"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3920"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3920/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3920/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3920/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/6436e23106a2049b1a0254bb62c61647205aaeb7"}}}}
{"actor":{"display_login":"domcleal"}}