{"action":"created","comment":{"url":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/comments/52852778","id":52852778,"diff_hunk":"@@ -34,9 +34,23 @@ import UIKit\n   }\n   \n   // MARK: - BorderDesignable\n-  @IBInspectable public var borderColor: UIColor?\n-  @IBInspectable public var borderWidth: CGFloat = CGFloat.NaN\n-  @IBInspectable public var borderSide: String?\n+  @IBInspectable public var borderColor: UIColor? {\n+    didSet {\n+      configBorder()\n+    }\n+  }\n+  \n+  @IBInspectable public var borderWidth: CGFloat = CGFloat.NaN {\n+    didSet {\n+      configBorder()\n+    }\n+  }\n+  \n+  @IBInspectable public var borderSide: String? {\n+    didSet {\n+      configBorder()\n+    }\n+  }","path":"IBAnimatable/AnimatableButton.swift","position":23,"original_position":23,"commit_id":"0d4a50f5500e8e435a800d89378eca071f977161","original_commit_id":"0d4a50f5500e8e435a800d89378eca071f977161","user":{"login":"JakeLin","id":573856,"avatar_url":"https://avatars.githubusercontent.com/u/573856?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeLin","html_url":"https://github.com/JakeLin","followers_url":"https://api.github.com/users/JakeLin/followers","following_url":"https://api.github.com/users/JakeLin/following{/other_user}","gists_url":"https://api.github.com/users/JakeLin/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLin/subscriptions","organizations_url":"https://api.github.com/users/JakeLin/orgs","repos_url":"https://api.github.com/users/JakeLin/repos","events_url":"https://api.github.com/users/JakeLin/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLin/received_events","type":"User","site_admin":false},"body":"If I remember correctly, I started with that and wanted to avoid calling `configBorder` multiple times, and move them out in `configInspectableProperties`. But should be that way for changing those properties after `awakeFromNib`.\r\n ","created_at":"2016-02-15T01:04:36Z","updated_at":"2016-02-15T01:04:36Z","html_url":"https://github.com/JakeLin/IBAnimatable/pull/99#discussion_r52852778","pull_request_url":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/comments/52852778"},"html":{"href":"https://github.com/JakeLin/IBAnimatable/pull/99#discussion_r52852778"},"pull_request":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/99","id":59295509,"html_url":"https://github.com/JakeLin/IBAnimatable/pull/99","diff_url":"https://github.com/JakeLin/IBAnimatable/pull/99.diff","patch_url":"https://github.com/JakeLin/IBAnimatable/pull/99.patch","issue_url":"https://api.github.com/repos/JakeLin/IBAnimatable/issues/99","number":99,"state":"open","locked":false,"title":"Fixed border designable and mask border","user":{"login":"tbaranes","id":1402212,"avatar_url":"https://avatars.githubusercontent.com/u/1402212?v=3","gravatar_id":"","url":"https://api.github.com/users/tbaranes","html_url":"https://github.com/tbaranes","followers_url":"https://api.github.com/users/tbaranes/followers","following_url":"https://api.github.com/users/tbaranes/following{/other_user}","gists_url":"https://api.github.com/users/tbaranes/gists{/gist_id}","starred_url":"https://api.github.com/users/tbaranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbaranes/subscriptions","organizations_url":"https://api.github.com/users/tbaranes/orgs","repos_url":"https://api.github.com/users/tbaranes/repos","events_url":"https://api.github.com/users/tbaranes/events{/privacy}","received_events_url":"https://api.github.com/users/tbaranes/received_events","type":"User","site_admin":false},"body":"We need to delete and create a new layer when the frame isn't the same as in the xib, or when we rotate. Otherwise, the border line won't be drawn with the right frame.\r\n\r\nI also used this PR to remove the gradientSubview when creating a new one to avoid a stack of useless `GradientView`.\r\n\r\nEDIT: This PR now handles also the follow bugs / improvements:\r\n- Making `BorderDesignable` testable directly in playground\r\n- Making `BorderDesignable` compatible with `MaskDesignable` (#101)","created_at":"2016-02-14T13:34:28Z","updated_at":"2016-02-15T01:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6923c6be3addcecca3afec0c44396d0029024727","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/99/commits","review_comments_url":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/99/comments","review_comment_url":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JakeLin/IBAnimatable/issues/99/comments","statuses_url":"https://api.github.com/repos/JakeLin/IBAnimatable/statuses/0d4a50f5500e8e435a800d89378eca071f977161","head":{"label":"JakeLin:hotfix/sample_layout_ipad","ref":"hotfix/sample_layout_ipad","sha":"0d4a50f5500e8e435a800d89378eca071f977161","user":{"login":"JakeLin","id":573856,"avatar_url":"https://avatars.githubusercontent.com/u/573856?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeLin","html_url":"https://github.com/JakeLin","followers_url":"https://api.github.com/users/JakeLin/followers","following_url":"https://api.github.com/users/JakeLin/following{/other_user}","gists_url":"https://api.github.com/users/JakeLin/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLin/subscriptions","organizations_url":"https://api.github.com/users/JakeLin/orgs","repos_url":"https://api.github.com/users/JakeLin/repos","events_url":"https://api.github.com/users/JakeLin/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLin/received_events","type":"User","site_admin":false},"repo":{"id":46383222,"name":"IBAnimatable","full_name":"JakeLin/IBAnimatable","owner":{"login":"JakeLin","id":573856,"avatar_url":"https://avatars.githubusercontent.com/u/573856?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeLin","html_url":"https://github.com/JakeLin","followers_url":"https://api.github.com/users/JakeLin/followers","following_url":"https://api.github.com/users/JakeLin/following{/other_user}","gists_url":"https://api.github.com/users/JakeLin/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLin/subscriptions","organizations_url":"https://api.github.com/users/JakeLin/orgs","repos_url":"https://api.github.com/users/JakeLin/repos","events_url":"https://api.github.com/users/JakeLin/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JakeLin/IBAnimatable","description":"Design and prototype UI, interaction, navigation, transition and animation for App Store ready Apps in Interface Builder with IBAnimatable.","fork":false,"url":"https://api.github.com/repos/JakeLin/IBAnimatable","forks_url":"https://api.github.com/repos/JakeLin/IBAnimatable/forks","keys_url":"https://api.github.com/repos/JakeLin/IBAnimatable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JakeLin/IBAnimatable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JakeLin/IBAnimatable/teams","hooks_url":"https://api.github.com/repos/JakeLin/IBAnimatable/hooks","issue_events_url":"https://api.github.com/repos/JakeLin/IBAnimatable/issues/events{/number}","events_url":"https://api.github.com/repos/JakeLin/IBAnimatable/events","assignees_url":"https://api.github.com/repos/JakeLin/IBAnimatable/assignees{/user}","branches_url":"https://api.github.com/repos/JakeLin/IBAnimatable/branches{/branch}","tags_url":"https://api.github.com/repos/JakeLin/IBAnimatable/tags","blobs_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/refs{/sha}","trees_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JakeLin/IBAnimatable/statuses/{sha}","languages_url":"https://api.github.com/repos/JakeLin/IBAnimatable/languages","stargazers_url":"https://api.github.com/repos/JakeLin/IBAnimatable/stargazers","contributors_url":"https://api.github.com/repos/JakeLin/IBAnimatable/contributors","subscribers_url":"https://api.github.com/repos/JakeLin/IBAnimatable/subscribers","subscription_url":"https://api.github.com/repos/JakeLin/IBAnimatable/subscription","commits_url":"https://api.github.com/repos/JakeLin/IBAnimatable/commits{/sha}","git_commits_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/commits{/sha}","comments_url":"https://api.github.com/repos/JakeLin/IBAnimatable/comments{/number}","issue_comment_url":"https://api.github.com/repos/JakeLin/IBAnimatable/issues/comments{/number}","contents_url":"https://api.github.com/repos/JakeLin/IBAnimatable/contents/{+path}","compare_url":"https://api.github.com/repos/JakeLin/IBAnimatable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JakeLin/IBAnimatable/merges","archive_url":"https://api.github.com/repos/JakeLin/IBAnimatable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JakeLin/IBAnimatable/downloads","issues_url":"https://api.github.com/repos/JakeLin/IBAnimatable/issues{/number}","pulls_url":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls{/number}","milestones_url":"https://api.github.com/repos/JakeLin/IBAnimatable/milestones{/number}","notifications_url":"https://api.github.com/repos/JakeLin/IBAnimatable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JakeLin/IBAnimatable/labels{/name}","releases_url":"https://api.github.com/repos/JakeLin/IBAnimatable/releases{/id}","deployments_url":"https://api.github.com/repos/JakeLin/IBAnimatable/deployments","created_at":"2015-11-17T23:55:21Z","updated_at":"2016-02-15T00:33:09Z","pushed_at":"2016-02-14T20:34:37Z","git_url":"git://github.com/JakeLin/IBAnimatable.git","ssh_url":"git@github.com:JakeLin/IBAnimatable.git","clone_url":"https://github.com/JakeLin/IBAnimatable.git","svn_url":"https://github.com/JakeLin/IBAnimatable","homepage":"","size":23945,"stargazers_count":2666,"watchers_count":2666,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":41,"forks":143,"open_issues":41,"watchers":2666,"default_branch":"master"}},"base":{"label":"JakeLin:master","ref":"master","sha":"4902bbf14999dd26648aa6c0ef844311f2eed9b7","user":{"login":"JakeLin","id":573856,"avatar_url":"https://avatars.githubusercontent.com/u/573856?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeLin","html_url":"https://github.com/JakeLin","followers_url":"https://api.github.com/users/JakeLin/followers","following_url":"https://api.github.com/users/JakeLin/following{/other_user}","gists_url":"https://api.github.com/users/JakeLin/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLin/subscriptions","organizations_url":"https://api.github.com/users/JakeLin/orgs","repos_url":"https://api.github.com/users/JakeLin/repos","events_url":"https://api.github.com/users/JakeLin/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLin/received_events","type":"User","site_admin":false},"repo":{"id":46383222,"name":"IBAnimatable","full_name":"JakeLin/IBAnimatable","owner":{"login":"JakeLin","id":573856,"avatar_url":"https://avatars.githubusercontent.com/u/573856?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeLin","html_url":"https://github.com/JakeLin","followers_url":"https://api.github.com/users/JakeLin/followers","following_url":"https://api.github.com/users/JakeLin/following{/other_user}","gists_url":"https://api.github.com/users/JakeLin/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLin/subscriptions","organizations_url":"https://api.github.com/users/JakeLin/orgs","repos_url":"https://api.github.com/users/JakeLin/repos","events_url":"https://api.github.com/users/JakeLin/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JakeLin/IBAnimatable","description":"Design and prototype UI, interaction, navigation, transition and animation for App Store ready Apps in Interface Builder with IBAnimatable.","fork":false,"url":"https://api.github.com/repos/JakeLin/IBAnimatable","forks_url":"https://api.github.com/repos/JakeLin/IBAnimatable/forks","keys_url":"https://api.github.com/repos/JakeLin/IBAnimatable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JakeLin/IBAnimatable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JakeLin/IBAnimatable/teams","hooks_url":"https://api.github.com/repos/JakeLin/IBAnimatable/hooks","issue_events_url":"https://api.github.com/repos/JakeLin/IBAnimatable/issues/events{/number}","events_url":"https://api.github.com/repos/JakeLin/IBAnimatable/events","assignees_url":"https://api.github.com/repos/JakeLin/IBAnimatable/assignees{/user}","branches_url":"https://api.github.com/repos/JakeLin/IBAnimatable/branches{/branch}","tags_url":"https://api.github.com/repos/JakeLin/IBAnimatable/tags","blobs_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/refs{/sha}","trees_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JakeLin/IBAnimatable/statuses/{sha}","languages_url":"https://api.github.com/repos/JakeLin/IBAnimatable/languages","stargazers_url":"https://api.github.com/repos/JakeLin/IBAnimatable/stargazers","contributors_url":"https://api.github.com/repos/JakeLin/IBAnimatable/contributors","subscribers_url":"https://api.github.com/repos/JakeLin/IBAnimatable/subscribers","subscription_url":"https://api.github.com/repos/JakeLin/IBAnimatable/subscription","commits_url":"https://api.github.com/repos/JakeLin/IBAnimatable/commits{/sha}","git_commits_url":"https://api.github.com/repos/JakeLin/IBAnimatable/git/commits{/sha}","comments_url":"https://api.github.com/repos/JakeLin/IBAnimatable/comments{/number}","issue_comment_url":"https://api.github.com/repos/JakeLin/IBAnimatable/issues/comments{/number}","contents_url":"https://api.github.com/repos/JakeLin/IBAnimatable/contents/{+path}","compare_url":"https://api.github.com/repos/JakeLin/IBAnimatable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JakeLin/IBAnimatable/merges","archive_url":"https://api.github.com/repos/JakeLin/IBAnimatable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JakeLin/IBAnimatable/downloads","issues_url":"https://api.github.com/repos/JakeLin/IBAnimatable/issues{/number}","pulls_url":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls{/number}","milestones_url":"https://api.github.com/repos/JakeLin/IBAnimatable/milestones{/number}","notifications_url":"https://api.github.com/repos/JakeLin/IBAnimatable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JakeLin/IBAnimatable/labels{/name}","releases_url":"https://api.github.com/repos/JakeLin/IBAnimatable/releases{/id}","deployments_url":"https://api.github.com/repos/JakeLin/IBAnimatable/deployments","created_at":"2015-11-17T23:55:21Z","updated_at":"2016-02-15T00:33:09Z","pushed_at":"2016-02-14T20:34:37Z","git_url":"git://github.com/JakeLin/IBAnimatable.git","ssh_url":"git@github.com:JakeLin/IBAnimatable.git","clone_url":"https://github.com/JakeLin/IBAnimatable.git","svn_url":"https://github.com/JakeLin/IBAnimatable","homepage":"","size":23945,"stargazers_count":2666,"watchers_count":2666,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":41,"forks":143,"open_issues":41,"watchers":2666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/99"},"html":{"href":"https://github.com/JakeLin/IBAnimatable/pull/99"},"issue":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/issues/99"},"comments":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/JakeLin/IBAnimatable/statuses/0d4a50f5500e8e435a800d89378eca071f977161"}}}}