{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-network/pulls/comments/87222580","pull_request_review_id":7837765,"id":87222580,"diff_hunk":"@@ -970,5 +970,34 @@ def confirmed_detection(hwtype)\n       hwstring = hwstrings[hwtype] || _(\"All Network Devices\")\n       Confirm.Detection(hwstring, nil)\n     end\n+\n+    def fix_dhclient_msg(devs)\n+      _(\n+        format(\n+          \"DHCLIENT_SET_HOSTNAME option is set for more than one interface.\\n\" \\\n+          \"This causes indeterministic behavior.\\n\" \\\n+          \"Affected devices:\\n\" \\\n+          \"%s\\n\",\n+          devs.join(\" \")\n+        )\n+      )\n+    end\n+\n+    # A popup informing user that incorrent DHCLIENT_SET_HOSTNAME was detected\n+    def fix_dhclient_warning(devs)\n+      message = _(\n+        fix_dhclient_msg(devs) + _(\"Use Hostname/DNS tab to fix it.\")\n+      )\n+\n+      Popup.Warning(message)\n+    end\n+\n+    def fix_dhclient_yesno(devs)","path":"src/include/network/routines.rb","position":26,"original_position":26,"commit_id":"4f710905456a89a85ae22f3d3523a1b18d7886fa","original_commit_id":"4f710905456a89a85ae22f3d3523a1b18d7886fa","user":{"login":"mvidner","id":102056,"avatar_url":"https://avatars.githubusercontent.com/u/102056?v=3","gravatar_id":"","url":"https://api.github.com/users/mvidner","html_url":"https://github.com/mvidner","followers_url":"https://api.github.com/users/mvidner/followers","following_url":"https://api.github.com/users/mvidner/following{/other_user}","gists_url":"https://api.github.com/users/mvidner/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidner/subscriptions","organizations_url":"https://api.github.com/users/mvidner/orgs","repos_url":"https://api.github.com/users/mvidner/repos","events_url":"https://api.github.com/users/mvidner/events{/privacy}","received_events_url":"https://api.github.com/users/mvidner/received_events","type":"User","site_admin":false},"body":"```\r\n# A yes-no pop-up\r\n# @return [Boolean]\r\n```","created_at":"2016-11-09T16:08:58Z","updated_at":"2016-11-09T16:21:46Z","html_url":"https://github.com/yast/yast-network/pull/461#discussion_r87222580","pull_request_url":"https://api.github.com/repos/yast/yast-network/pulls/461","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments/87222580"},"html":{"href":"https://github.com/yast/yast-network/pull/461#discussion_r87222580"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-network/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-network/pulls/461","id":92982477,"html_url":"https://github.com/yast/yast-network/pull/461","diff_url":"https://github.com/yast/yast-network/pull/461.diff","patch_url":"https://github.com/yast/yast-network/pull/461.patch","issue_url":"https://api.github.com/repos/yast/yast-network/issues/461","number":461,"state":"open","locked":false,"title":"[WIP] DHCLIENT_SET_HOSTNAME per interface","user":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"body":"- https://trello.com/c/pN6f3kzr (screenshots!)\r\n- [bsc#984890](https://bugzilla.suse.com/show_bug.cgi?id=984890)\r\n\r\nTodo:\r\n- changelog\r\n- clarification with UI / UX\r\n- some minor tweeks","created_at":"2016-11-09T15:23:59Z","updated_at":"2016-11-09T16:21:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b83c0e6de858c06a81474d227b63046698c4698","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-network/pulls/461/commits","review_comments_url":"https://api.github.com/repos/yast/yast-network/pulls/461/comments","review_comment_url":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-network/issues/461/comments","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/4f710905456a89a85ae22f3d3523a1b18d7886fa","head":{"label":"mchf:dhcp-sethostname","ref":"dhcp-sethostname","sha":"4f710905456a89a85ae22f3d3523a1b18d7886fa","user":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"repo":{"id":4748313,"name":"yast-network","full_name":"mchf/yast-network","owner":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mchf/yast-network","description":"YaST module network","fork":true,"url":"https://api.github.com/repos/mchf/yast-network","forks_url":"https://api.github.com/repos/mchf/yast-network/forks","keys_url":"https://api.github.com/repos/mchf/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mchf/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mchf/yast-network/teams","hooks_url":"https://api.github.com/repos/mchf/yast-network/hooks","issue_events_url":"https://api.github.com/repos/mchf/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/mchf/yast-network/events","assignees_url":"https://api.github.com/repos/mchf/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/mchf/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/mchf/yast-network/tags","blobs_url":"https://api.github.com/repos/mchf/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mchf/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mchf/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/mchf/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mchf/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/mchf/yast-network/languages","stargazers_url":"https://api.github.com/repos/mchf/yast-network/stargazers","contributors_url":"https://api.github.com/repos/mchf/yast-network/contributors","subscribers_url":"https://api.github.com/repos/mchf/yast-network/subscribers","subscription_url":"https://api.github.com/repos/mchf/yast-network/subscription","commits_url":"https://api.github.com/repos/mchf/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/mchf/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/mchf/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/mchf/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/mchf/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/mchf/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mchf/yast-network/merges","archive_url":"https://api.github.com/repos/mchf/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mchf/yast-network/downloads","issues_url":"https://api.github.com/repos/mchf/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/mchf/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/mchf/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/mchf/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mchf/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/mchf/yast-network/releases{/id}","deployments_url":"https://api.github.com/repos/mchf/yast-network/deployments","created_at":"2012-06-22T06:44:13Z","updated_at":"2015-05-06T13:22:26Z","pushed_at":"2016-11-09T15:22:38Z","git_url":"git://github.com/mchf/yast-network.git","ssh_url":"git@github.com:mchf/yast-network.git","clone_url":"https://github.com/mchf/yast-network.git","svn_url":"https://github.com/mchf/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":24885,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"yast:SLE-12-SP2","ref":"SLE-12-SP2","sha":"87c5d2fea4aab90619b3f57572a7208fb72cde53","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368160,"name":"yast-network","full_name":"yast/yast-network","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-network","description":"YaST module network","fork":false,"url":"https://api.github.com/repos/yast/yast-network","forks_url":"https://api.github.com/repos/yast/yast-network/forks","keys_url":"https://api.github.com/repos/yast/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-network/teams","hooks_url":"https://api.github.com/repos/yast/yast-network/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-network/events","assignees_url":"https://api.github.com/repos/yast/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-network/tags","blobs_url":"https://api.github.com/repos/yast/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-network/languages","stargazers_url":"https://api.github.com/repos/yast/yast-network/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-network/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-network/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-network/subscription","commits_url":"https://api.github.com/repos/yast/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-network/merges","archive_url":"https://api.github.com/repos/yast/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-network/downloads","issues_url":"https://api.github.com/repos/yast/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-network/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-network/deployments","created_at":"2012-05-18T10:24:50Z","updated_at":"2016-10-25T13:34:43Z","pushed_at":"2016-11-09T15:23:59Z","git_url":"git://github.com/yast/yast-network.git","ssh_url":"git@github.com:yast/yast-network.git","clone_url":"https://github.com/yast/yast-network.git","svn_url":"https://github.com/yast/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":24890,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/461"},"html":{"href":"https://github.com/yast/yast-network/pull/461"},"issue":{"href":"https://api.github.com/repos/yast/yast-network/issues/461"},"comments":{"href":"https://api.github.com/repos/yast/yast-network/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-network/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-network/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-network/statuses/4f710905456a89a85ae22f3d3523a1b18d7886fa"}}}}
{"actor":{"display_login":"mvidner"}}