{"action":"created","issue":{"url":"https://api.github.com/repos/botify-labs/simpleflow/issues/97","repository_url":"https://api.github.com/repos/botify-labs/simpleflow","labels_url":"https://api.github.com/repos/botify-labs/simpleflow/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/botify-labs/simpleflow/issues/97/comments","events_url":"https://api.github.com/repos/botify-labs/simpleflow/issues/97/events","html_url":"https://github.com/botify-labs/simpleflow/pull/97","id":157663324,"number":97,"title":"Avoid duplicate logs if root logger has an handler","user":{"login":"jbbarth","id":29363,"avatar_url":"https://avatars.githubusercontent.com/u/29363?v=3","gravatar_id":"","url":"https://api.github.com/users/jbbarth","html_url":"https://github.com/jbbarth","followers_url":"https://api.github.com/users/jbbarth/followers","following_url":"https://api.github.com/users/jbbarth/following{/other_user}","gists_url":"https://api.github.com/users/jbbarth/gists{/gist_id}","starred_url":"https://api.github.com/users/jbbarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbbarth/subscriptions","organizations_url":"https://api.github.com/users/jbbarth/orgs","repos_url":"https://api.github.com/users/jbbarth/repos","events_url":"https://api.github.com/users/jbbarth/events{/privacy}","received_events_url":"https://api.github.com/users/jbbarth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-31T12:48:52Z","updated_at":"2016-05-31T13:42:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/botify-labs/simpleflow/pulls/97","html_url":"https://github.com/botify-labs/simpleflow/pull/97","diff_url":"https://github.com/botify-labs/simpleflow/pull/97.diff","patch_url":"https://github.com/botify-labs/simpleflow/pull/97.patch"},"body":"Without this fix:\r\n```\r\n$ AWS_DEFAULT_REGION=eu-west-1 simpleflow decider.start my.Workflow --domain xxxxx --task-list tl --nb-processes 1\r\n2016-05-31T13:42:58 INFO [process=MainProcess, pid=18241]: starting <bound method DeciderPoller.start of DeciderPoller(xxxxx, tl, xx)>\r\nstarting <bound method DeciderPoller.start of DeciderPoller(xxxxx, tl, xx)>\r\n2016-05-31T13:42:58 INFO [process=Process-1, pid=18248]: starting DeciderPoller(workflow=job) on domain xxxxx\r\nstarting DeciderPoller(workflow=xx) on domain xxxxx\r\n```\r\n\r\nSame with this fix:\r\n```\r\n$ AWS_DEFAULT_REGION=eu-west-1 simpleflow decider.start my.Workflow --domain xxxxx --task-list tl --nb-processes 1\r\n2016-05-31T13:42:58 INFO [process=MainProcess, pid=18241]: starting <bound method DeciderPoller.start of DeciderPoller(xxxxx, tl, xx)>\r\n2016-05-31T13:42:58 INFO [process=Process-1, pid=18248]: starting DeciderPoller(workflow=xx) on domain xxxxx\r\n```\r\n\r\nBut maybe it's better to leave the code of the workflow handle that? simpleflow's own logging is better than our internal code for now, so if you prefer the private code to handle that case I'd be happy to have an example or suggestions\r\n\r\nping @benjastudio @ybastide "},"comment":{"url":"https://api.github.com/repos/botify-labs/simpleflow/issues/comments/222691835","html_url":"https://github.com/botify-labs/simpleflow/pull/97#issuecomment-222691835","issue_url":"https://api.github.com/repos/botify-labs/simpleflow/issues/97","id":222691835,"user":{"login":"jbbarth","id":29363,"avatar_url":"https://avatars.githubusercontent.com/u/29363?v=3","gravatar_id":"","url":"https://api.github.com/users/jbbarth","html_url":"https://github.com/jbbarth","followers_url":"https://api.github.com/users/jbbarth/followers","following_url":"https://api.github.com/users/jbbarth/following{/other_user}","gists_url":"https://api.github.com/users/jbbarth/gists{/gist_id}","starred_url":"https://api.github.com/users/jbbarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbbarth/subscriptions","organizations_url":"https://api.github.com/users/jbbarth/orgs","repos_url":"https://api.github.com/users/jbbarth/repos","events_url":"https://api.github.com/users/jbbarth/events{/privacy}","received_events_url":"https://api.github.com/users/jbbarth/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T13:42:41Z","updated_at":"2016-05-31T13:42:41Z","body":"We could assume that the code inside the workflow definition could define its own log config. But I'm not sure it's really sane in the general case.\r\n\r\nPapertrail: no, all botify code logs into files, and we use a tiny program provided by papertrail to send logs elsewhere ([remove_syslog2](https://github.com/papertrail/remote_syslog2))"}}
{"actor":{"display_login":"jbbarth"}}