{"action":"created","comment":{"url":"https://api.github.com/repos/pwr/Solaar/pulls/comments/90746316","pull_request_review_id":11267406,"id":90746316,"diff_hunk":"@@ -336,10 +336,14 @@ def __init__(self, handle, device_info):\n \n \t\t# read the serial immediately, so we can find out max_devices\n \t\t# this will tell us if it's a Unifying or Nano receiver\n-\t\tserial_reply = self.read_register(_R.receiver_info, 0x03)\n-\t\tassert serial_reply\n-\t\tself.serial = _strhex(serial_reply[1:5])\n-\t\tself.max_devices = ord(serial_reply[6:7])\n+                if self.product_id != 'c534':","path":"lib/logitech_receiver/receiver.py","position":8,"original_position":8,"commit_id":"8c7eeeeafc088a9942e231bb79060d8b70c9612c","original_commit_id":"8c7eeeeafc088a9942e231bb79060d8b70c9612c","user":{"login":"Lekensteyn","id":164530,"avatar_url":"https://avatars.githubusercontent.com/u/164530?v=3","gravatar_id":"","url":"https://api.github.com/users/Lekensteyn","html_url":"https://github.com/Lekensteyn","followers_url":"https://api.github.com/users/Lekensteyn/followers","following_url":"https://api.github.com/users/Lekensteyn/following{/other_user}","gists_url":"https://api.github.com/users/Lekensteyn/gists{/gist_id}","starred_url":"https://api.github.com/users/Lekensteyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lekensteyn/subscriptions","organizations_url":"https://api.github.com/users/Lekensteyn/orgs","repos_url":"https://api.github.com/users/Lekensteyn/repos","events_url":"https://api.github.com/users/Lekensteyn/events{/privacy}","received_events_url":"https://api.github.com/users/Lekensteyn/received_events","type":"User","site_admin":false},"body":"Logitech told me that for older devices using the \"Quad\" protocol, there should be nothing returned after the base address. See #292\r\n\r\nI think something like this this is acceptable (but please use consistent indentation, the file uses tabs I think)","created_at":"2016-12-03T01:23:51Z","updated_at":"2016-12-03T01:23:57Z","html_url":"https://github.com/pwr/Solaar/pull/318#discussion_r90746316","pull_request_url":"https://api.github.com/repos/pwr/Solaar/pulls/318","_links":{"self":{"href":"https://api.github.com/repos/pwr/Solaar/pulls/comments/90746316"},"html":{"href":"https://github.com/pwr/Solaar/pull/318#discussion_r90746316"},"pull_request":{"href":"https://api.github.com/repos/pwr/Solaar/pulls/318"}}},"pull_request":{"url":"https://api.github.com/repos/pwr/Solaar/pulls/318","id":95712410,"html_url":"https://github.com/pwr/Solaar/pull/318","diff_url":"https://github.com/pwr/Solaar/pull/318.diff","patch_url":"https://github.com/pwr/Solaar/pull/318.patch","issue_url":"https://api.github.com/repos/pwr/Solaar/issues/318","number":318,"state":"open","locked":false,"title":"add basic recognition of c534 receiver (combo kit like  K270/K220 and M185/M150)","user":{"login":"saimonn","id":6391720,"avatar_url":"https://avatars.githubusercontent.com/u/6391720?v=3","gravatar_id":"","url":"https://api.github.com/users/saimonn","html_url":"https://github.com/saimonn","followers_url":"https://api.github.com/users/saimonn/followers","following_url":"https://api.github.com/users/saimonn/following{/other_user}","gists_url":"https://api.github.com/users/saimonn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimonn/subscriptions","organizations_url":"https://api.github.com/users/saimonn/orgs","repos_url":"https://api.github.com/users/saimonn/repos","events_url":"https://api.github.com/users/saimonn/events{/privacy}","received_events_url":"https://api.github.com/users/saimonn/received_events","type":"User","site_admin":false},"body":"I did manage to get some informations with `solaar show` with modifications in this PR, mostly made from informations given by @jrbenito on #234 .\r\n\r\nThis may be also related to #222 and #152.","created_at":"2016-11-29T15:20:28Z","updated_at":"2016-12-03T01:23:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2028f92626e96c10332ca434bb5cb7cdea55b75","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pwr/Solaar/pulls/318/commits","review_comments_url":"https://api.github.com/repos/pwr/Solaar/pulls/318/comments","review_comment_url":"https://api.github.com/repos/pwr/Solaar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pwr/Solaar/issues/318/comments","statuses_url":"https://api.github.com/repos/pwr/Solaar/statuses/8c7eeeeafc088a9942e231bb79060d8b70c9612c","head":{"label":"saimonn:c534","ref":"c534","sha":"8c7eeeeafc088a9942e231bb79060d8b70c9612c","user":{"login":"saimonn","id":6391720,"avatar_url":"https://avatars.githubusercontent.com/u/6391720?v=3","gravatar_id":"","url":"https://api.github.com/users/saimonn","html_url":"https://github.com/saimonn","followers_url":"https://api.github.com/users/saimonn/followers","following_url":"https://api.github.com/users/saimonn/following{/other_user}","gists_url":"https://api.github.com/users/saimonn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimonn/subscriptions","organizations_url":"https://api.github.com/users/saimonn/orgs","repos_url":"https://api.github.com/users/saimonn/repos","events_url":"https://api.github.com/users/saimonn/events{/privacy}","received_events_url":"https://api.github.com/users/saimonn/received_events","type":"User","site_admin":false},"repo":{"id":75092055,"name":"Solaar","full_name":"saimonn/Solaar","owner":{"login":"saimonn","id":6391720,"avatar_url":"https://avatars.githubusercontent.com/u/6391720?v=3","gravatar_id":"","url":"https://api.github.com/users/saimonn","html_url":"https://github.com/saimonn","followers_url":"https://api.github.com/users/saimonn/followers","following_url":"https://api.github.com/users/saimonn/following{/other_user}","gists_url":"https://api.github.com/users/saimonn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimonn/subscriptions","organizations_url":"https://api.github.com/users/saimonn/orgs","repos_url":"https://api.github.com/users/saimonn/repos","events_url":"https://api.github.com/users/saimonn/events{/privacy}","received_events_url":"https://api.github.com/users/saimonn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saimonn/Solaar","description":"Linux devices manager for the Logitech Unifying Receiver.","fork":true,"url":"https://api.github.com/repos/saimonn/Solaar","forks_url":"https://api.github.com/repos/saimonn/Solaar/forks","keys_url":"https://api.github.com/repos/saimonn/Solaar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saimonn/Solaar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saimonn/Solaar/teams","hooks_url":"https://api.github.com/repos/saimonn/Solaar/hooks","issue_events_url":"https://api.github.com/repos/saimonn/Solaar/issues/events{/number}","events_url":"https://api.github.com/repos/saimonn/Solaar/events","assignees_url":"https://api.github.com/repos/saimonn/Solaar/assignees{/user}","branches_url":"https://api.github.com/repos/saimonn/Solaar/branches{/branch}","tags_url":"https://api.github.com/repos/saimonn/Solaar/tags","blobs_url":"https://api.github.com/repos/saimonn/Solaar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saimonn/Solaar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saimonn/Solaar/git/refs{/sha}","trees_url":"https://api.github.com/repos/saimonn/Solaar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saimonn/Solaar/statuses/{sha}","languages_url":"https://api.github.com/repos/saimonn/Solaar/languages","stargazers_url":"https://api.github.com/repos/saimonn/Solaar/stargazers","contributors_url":"https://api.github.com/repos/saimonn/Solaar/contributors","subscribers_url":"https://api.github.com/repos/saimonn/Solaar/subscribers","subscription_url":"https://api.github.com/repos/saimonn/Solaar/subscription","commits_url":"https://api.github.com/repos/saimonn/Solaar/commits{/sha}","git_commits_url":"https://api.github.com/repos/saimonn/Solaar/git/commits{/sha}","comments_url":"https://api.github.com/repos/saimonn/Solaar/comments{/number}","issue_comment_url":"https://api.github.com/repos/saimonn/Solaar/issues/comments{/number}","contents_url":"https://api.github.com/repos/saimonn/Solaar/contents/{+path}","compare_url":"https://api.github.com/repos/saimonn/Solaar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saimonn/Solaar/merges","archive_url":"https://api.github.com/repos/saimonn/Solaar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saimonn/Solaar/downloads","issues_url":"https://api.github.com/repos/saimonn/Solaar/issues{/number}","pulls_url":"https://api.github.com/repos/saimonn/Solaar/pulls{/number}","milestones_url":"https://api.github.com/repos/saimonn/Solaar/milestones{/number}","notifications_url":"https://api.github.com/repos/saimonn/Solaar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saimonn/Solaar/labels{/name}","releases_url":"https://api.github.com/repos/saimonn/Solaar/releases{/id}","deployments_url":"https://api.github.com/repos/saimonn/Solaar/deployments","created_at":"2016-11-29T15:01:05Z","updated_at":"2016-11-29T15:01:07Z","pushed_at":"2016-11-29T15:09:38Z","git_url":"git://github.com/saimonn/Solaar.git","ssh_url":"git@github.com:saimonn/Solaar.git","clone_url":"https://github.com/saimonn/Solaar.git","svn_url":"https://github.com/saimonn/Solaar","homepage":"http://pwr.github.io/Solaar","size":6342,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pwr:master","ref":"master","sha":"773cb7f45fbf9164ce349eec1760cd85654894b0","user":{"login":"pwr","id":91762,"avatar_url":"https://avatars.githubusercontent.com/u/91762?v=3","gravatar_id":"","url":"https://api.github.com/users/pwr","html_url":"https://github.com/pwr","followers_url":"https://api.github.com/users/pwr/followers","following_url":"https://api.github.com/users/pwr/following{/other_user}","gists_url":"https://api.github.com/users/pwr/gists{/gist_id}","starred_url":"https://api.github.com/users/pwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwr/subscriptions","organizations_url":"https://api.github.com/users/pwr/orgs","repos_url":"https://api.github.com/users/pwr/repos","events_url":"https://api.github.com/users/pwr/events{/privacy}","received_events_url":"https://api.github.com/users/pwr/received_events","type":"User","site_admin":false},"repo":{"id":5772041,"name":"Solaar","full_name":"pwr/Solaar","owner":{"login":"pwr","id":91762,"avatar_url":"https://avatars.githubusercontent.com/u/91762?v=3","gravatar_id":"","url":"https://api.github.com/users/pwr","html_url":"https://github.com/pwr","followers_url":"https://api.github.com/users/pwr/followers","following_url":"https://api.github.com/users/pwr/following{/other_user}","gists_url":"https://api.github.com/users/pwr/gists{/gist_id}","starred_url":"https://api.github.com/users/pwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwr/subscriptions","organizations_url":"https://api.github.com/users/pwr/orgs","repos_url":"https://api.github.com/users/pwr/repos","events_url":"https://api.github.com/users/pwr/events{/privacy}","received_events_url":"https://api.github.com/users/pwr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pwr/Solaar","description":"Linux devices manager for the Logitech Unifying Receiver.","fork":true,"url":"https://api.github.com/repos/pwr/Solaar","forks_url":"https://api.github.com/repos/pwr/Solaar/forks","keys_url":"https://api.github.com/repos/pwr/Solaar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwr/Solaar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwr/Solaar/teams","hooks_url":"https://api.github.com/repos/pwr/Solaar/hooks","issue_events_url":"https://api.github.com/repos/pwr/Solaar/issues/events{/number}","events_url":"https://api.github.com/repos/pwr/Solaar/events","assignees_url":"https://api.github.com/repos/pwr/Solaar/assignees{/user}","branches_url":"https://api.github.com/repos/pwr/Solaar/branches{/branch}","tags_url":"https://api.github.com/repos/pwr/Solaar/tags","blobs_url":"https://api.github.com/repos/pwr/Solaar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwr/Solaar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwr/Solaar/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwr/Solaar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwr/Solaar/statuses/{sha}","languages_url":"https://api.github.com/repos/pwr/Solaar/languages","stargazers_url":"https://api.github.com/repos/pwr/Solaar/stargazers","contributors_url":"https://api.github.com/repos/pwr/Solaar/contributors","subscribers_url":"https://api.github.com/repos/pwr/Solaar/subscribers","subscription_url":"https://api.github.com/repos/pwr/Solaar/subscription","commits_url":"https://api.github.com/repos/pwr/Solaar/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwr/Solaar/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwr/Solaar/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwr/Solaar/issues/comments{/number}","contents_url":"https://api.github.com/repos/pwr/Solaar/contents/{+path}","compare_url":"https://api.github.com/repos/pwr/Solaar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwr/Solaar/merges","archive_url":"https://api.github.com/repos/pwr/Solaar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwr/Solaar/downloads","issues_url":"https://api.github.com/repos/pwr/Solaar/issues{/number}","pulls_url":"https://api.github.com/repos/pwr/Solaar/pulls{/number}","milestones_url":"https://api.github.com/repos/pwr/Solaar/milestones{/number}","notifications_url":"https://api.github.com/repos/pwr/Solaar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwr/Solaar/labels{/name}","releases_url":"https://api.github.com/repos/pwr/Solaar/releases{/id}","deployments_url":"https://api.github.com/repos/pwr/Solaar/deployments","created_at":"2012-09-11T22:40:27Z","updated_at":"2016-12-02T16:36:37Z","pushed_at":"2016-12-03T01:19:04Z","git_url":"git://github.com/pwr/Solaar.git","ssh_url":"git@github.com:pwr/Solaar.git","clone_url":"https://github.com/pwr/Solaar.git","svn_url":"https://github.com/pwr/Solaar","homepage":"http://pwr.github.io/Solaar","size":6894,"stargazers_count":543,"watchers_count":543,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":99,"forks":95,"open_issues":99,"watchers":543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pwr/Solaar/pulls/318"},"html":{"href":"https://github.com/pwr/Solaar/pull/318"},"issue":{"href":"https://api.github.com/repos/pwr/Solaar/issues/318"},"comments":{"href":"https://api.github.com/repos/pwr/Solaar/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/pwr/Solaar/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/pwr/Solaar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pwr/Solaar/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/pwr/Solaar/statuses/8c7eeeeafc088a9942e231bb79060d8b70c9612c"}}}}
{"actor":{"display_login":"Lekensteyn"}}