{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/82682953","pull_request_review_id":3573888,"id":82682953,"diff_hunk":"@@ -26,4 +26,10 @@\n     MiqAeEngine.instantiate(\"#{@ins}?Vm::vm=#{@vm.id}#amazon\", @user)\n     expect(MiqQueue.exists?(:method_name => 'stop', :instance_id => @vm.id, :role => 'ems_operations')).to be_falsey\n   end\n+\n+  it \"calls abort for nil instances\" do\n+    @vm.hardware = nil\n+    expect { MiqAeEngine.instantiate(\"#{@ins}?Vm::vm=#{@vm.id}#amazon\", @user) }.to raise_error(\n+      MiqAeException::AbortInstantiation)\n+  end","path":"spec/automation/unit/method_validation/amazon_pre_retirement_spec.rb","position":9,"original_position":9,"commit_id":"fb8eab0d454dc815515b3eceb1b58bc3fbe6e1e4","original_commit_id":"fb8eab0d454dc815515b3eceb1b58bc3fbe6e1e4","user":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"body":"@billfitzgerald0120 \r\nOn line 5 you have\r\n@ems  = FactoryGirl.create(:ems_vmware, :zone => @zone)\r\n\r\ncan we change this to\r\n@ems  = FactoryGirl.create(:ems_amazon, :zone => @zone)\r\n","created_at":"2016-10-10T21:06:45Z","updated_at":"2016-10-10T21:06:45Z","html_url":"https://github.com/ManageIQ/manageiq/pull/11612#discussion_r82682953","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11612","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/82682953"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/11612#discussion_r82682953"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11612"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11612","id":87480786,"html_url":"https://github.com/ManageIQ/manageiq/pull/11612","diff_url":"https://github.com/ManageIQ/manageiq/pull/11612.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11612.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11612","number":11612,"state":"open","locked":false,"title":"Automate - Added checks and logging for amazon retirement.","user":{"login":"billfitzgerald0120","id":11841651,"avatar_url":"https://avatars.githubusercontent.com/u/11841651?v=3","gravatar_id":"","url":"https://api.github.com/users/billfitzgerald0120","html_url":"https://github.com/billfitzgerald0120","followers_url":"https://api.github.com/users/billfitzgerald0120/followers","following_url":"https://api.github.com/users/billfitzgerald0120/following{/other_user}","gists_url":"https://api.github.com/users/billfitzgerald0120/gists{/gist_id}","starred_url":"https://api.github.com/users/billfitzgerald0120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billfitzgerald0120/subscriptions","organizations_url":"https://api.github.com/users/billfitzgerald0120/orgs","repos_url":"https://api.github.com/users/billfitzgerald0120/repos","events_url":"https://api.github.com/users/billfitzgerald0120/events{/privacy}","received_events_url":"https://api.github.com/users/billfitzgerald0120/received_events","type":"User","site_admin":false},"body":"Added checks for amazon retirement for nil vm, ems nil and root_device_type nil.\r\n\r\nAdded messages when one of these occur.\r\n\r\nAbort and message if type is nil.\r\n\r\nAdded spec for nil type.\r\n\r\nhttps://www.pivotaltracker.com/story/show/131399819","created_at":"2016-09-30T11:56:54Z","updated_at":"2016-10-10T21:06:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"442456174b38fd7f03ebdcdd954f0917cff45210","assignee":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11612/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11612/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11612/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/fb8eab0d454dc815515b3eceb1b58bc3fbe6e1e4","head":{"label":"billfitzgerald0120:amazon_pre_retirement","ref":"amazon_pre_retirement","sha":"fb8eab0d454dc815515b3eceb1b58bc3fbe6e1e4","user":{"login":"billfitzgerald0120","id":11841651,"avatar_url":"https://avatars.githubusercontent.com/u/11841651?v=3","gravatar_id":"","url":"https://api.github.com/users/billfitzgerald0120","html_url":"https://github.com/billfitzgerald0120","followers_url":"https://api.github.com/users/billfitzgerald0120/followers","following_url":"https://api.github.com/users/billfitzgerald0120/following{/other_user}","gists_url":"https://api.github.com/users/billfitzgerald0120/gists{/gist_id}","starred_url":"https://api.github.com/users/billfitzgerald0120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billfitzgerald0120/subscriptions","organizations_url":"https://api.github.com/users/billfitzgerald0120/orgs","repos_url":"https://api.github.com/users/billfitzgerald0120/repos","events_url":"https://api.github.com/users/billfitzgerald0120/events{/privacy}","received_events_url":"https://api.github.com/users/billfitzgerald0120/received_events","type":"User","site_admin":false},"repo":{"id":49597161,"name":"manageiq","full_name":"billfitzgerald0120/manageiq","owner":{"login":"billfitzgerald0120","id":11841651,"avatar_url":"https://avatars.githubusercontent.com/u/11841651?v=3","gravatar_id":"","url":"https://api.github.com/users/billfitzgerald0120","html_url":"https://github.com/billfitzgerald0120","followers_url":"https://api.github.com/users/billfitzgerald0120/followers","following_url":"https://api.github.com/users/billfitzgerald0120/following{/other_user}","gists_url":"https://api.github.com/users/billfitzgerald0120/gists{/gist_id}","starred_url":"https://api.github.com/users/billfitzgerald0120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billfitzgerald0120/subscriptions","organizations_url":"https://api.github.com/users/billfitzgerald0120/orgs","repos_url":"https://api.github.com/users/billfitzgerald0120/repos","events_url":"https://api.github.com/users/billfitzgerald0120/events{/privacy}","received_events_url":"https://api.github.com/users/billfitzgerald0120/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/billfitzgerald0120/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/billfitzgerald0120/manageiq","forks_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/forks","keys_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/teams","hooks_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/hooks","issue_events_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/events","assignees_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/tags","blobs_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/languages","stargazers_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/stargazers","contributors_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/contributors","subscribers_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/subscribers","subscription_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/subscription","commits_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/merges","archive_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/downloads","issues_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/billfitzgerald0120/manageiq/deployments","created_at":"2016-01-13T19:40:24Z","updated_at":"2016-01-13T19:40:41Z","pushed_at":"2016-10-04T18:01:47Z","git_url":"git://github.com/billfitzgerald0120/manageiq.git","ssh_url":"git@github.com:billfitzgerald0120/manageiq.git","clone_url":"https://github.com/billfitzgerald0120/manageiq.git","svn_url":"https://github.com/billfitzgerald0120/manageiq","homepage":"manageiq.org","size":159422,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"92655f24f4a8f7f9c4a6d7584583bb03c0ee6be8","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-10-07T20:22:27Z","pushed_at":"2016-10-10T21:01:17Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":210265,"stargazers_count":335,"watchers_count":335,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":361,"mirror_url":null,"open_issues_count":838,"forks":361,"open_issues":838,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11612"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/11612"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/11612"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/11612/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11612/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11612/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/fb8eab0d454dc815515b3eceb1b58bc3fbe6e1e4"}}}}
{"actor":{"display_login":"mkanoor"}}