{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/repository-forms/issues/93","repository_url":"https://api.github.com/repos/ezsystems/repository-forms","labels_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/93/comments","events_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/93/events","html_url":"https://github.com/ezsystems/repository-forms/pull/93","id":169381001,"number":93,"title":"[WIP] EZP-26128: As a Developer I want deprecation issues resolved, so that application logs are clean","user":{"login":"alongosz","id":7099219,"avatar_url":"https://avatars.githubusercontent.com/u/7099219?v=3","gravatar_id":"","url":"https://api.github.com/users/alongosz","html_url":"https://github.com/alongosz","followers_url":"https://api.github.com/users/alongosz/followers","following_url":"https://api.github.com/users/alongosz/following{/other_user}","gists_url":"https://api.github.com/users/alongosz/gists{/gist_id}","starred_url":"https://api.github.com/users/alongosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alongosz/subscriptions","organizations_url":"https://api.github.com/users/alongosz/orgs","repos_url":"https://api.github.com/users/alongosz/repos","events_url":"https://api.github.com/users/alongosz/events{/privacy}","received_events_url":"https://api.github.com/users/alongosz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-04T13:58:34Z","updated_at":"2016-08-08T07:16:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/repository-forms/pulls/93","html_url":"https://github.com/ezsystems/repository-forms/pull/93","diff_url":"https://github.com/ezsystems/repository-forms/pull/93.diff","patch_url":"https://github.com/ezsystems/repository-forms/pull/93.patch"},"body":"Status: **WIP**.\r\nJIRA Story: [EZP-26128](https://jira.ez.no/browse/EZP-26128)\r\n\r\n**TODO**:\r\n- [x] Quote service references in Yaml files (3e12b51).\r\n- [x] Quote parameter references in Yaml files (93996e2).\r\n- [x] Make sure tests are run with full error reporting (5ffa8a7).\r\n- [x] Cleanup `services.yml` to keep the code consistent (2a86fb4).\r\n- [x] Replace references of deprecated `FieldTypeFormMapperInterface` with `FieldDefinitionFormMapperInterface` (cb8a97c).\r\n- [x] Replace references of deprecated ez.fieldType.formMapper service tag with `ez.fieldFormMapper.value` or/and  `ez.fieldFormMapper.definition` depending on an interface a mapper implements (c7e291b).\r\n- [ ] Replace string references of form field types with fully-qualified type class names.\r\n\r\n@glye: thanks for help with this :)"},"comment":{"url":"https://api.github.com/repos/ezsystems/repository-forms/issues/comments/238158941","html_url":"https://github.com/ezsystems/repository-forms/pull/93#issuecomment-238158941","issue_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/93","id":238158941,"user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T07:16:46Z","updated_at":"2016-08-08T07:16:46Z","body":"> I also found more deprecation warnings - form field types should be now referenced with fully-qualified type class names, so instead of e.g. $builder->add('identifier', 'text') we should use $builder->add('identifier', TextType::class). I'll fix that as well.\r\n\r\nhmm, that seems like a bc break.\r\n@glye any input on if this was intended change or not? or should we wait to check with @bdunogier once back?"}}
{"actor":{"display_login":"andrerom"}}