{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/58636423","id":58636423,"diff_hunk":"@@ -279,7 +280,31 @@ mono_native_thread_create (MonoNativeThreadId *tid, gpointer func, gpointer arg)\n void\n mono_threads_core_set_name (MonoNativeThreadId tid, const char *name)\n {\n-#if defined (HAVE_PTHREAD_SETNAME_NP) && !defined (__MACH__)\n+#ifdef __MACH__\n+\tstatic int (*pthread_setname_np_fn) (const char *);\n+\n+\t/*\n+\t * We can't set the thread name for other threads, but we can at least make\n+\t * it work for threads that try to change their own name.\n+\t */\n+\tif (tid != mono_native_thread_id_get ())\n+\t\treturn;\n+\n+\t/* The function is only available on OS X 10.6+, so find it at runtime. */","path":"mono/utils/mono-threads-posix.c","position":23,"original_position":23,"commit_id":"df8e4dc4fc9d06807aceb3268eec4232a3519f8c","original_commit_id":"df8e4dc4fc9d06807aceb3268eec4232a3519f8c","user":{"login":"alexrp","id":44076,"avatar_url":"https://avatars.githubusercontent.com/u/44076?v=3","gravatar_id":"","url":"https://api.github.com/users/alexrp","html_url":"https://github.com/alexrp","followers_url":"https://api.github.com/users/alexrp/followers","following_url":"https://api.github.com/users/alexrp/following{/other_user}","gists_url":"https://api.github.com/users/alexrp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrp/subscriptions","organizations_url":"https://api.github.com/users/alexrp/orgs","repos_url":"https://api.github.com/users/alexrp/repos","events_url":"https://api.github.com/users/alexrp/events{/privacy}","received_events_url":"https://api.github.com/users/alexrp/received_events","type":"User","site_admin":false},"body":"OK, will get rid of the `dlsym` stuff.","created_at":"2016-04-06T00:28:20Z","updated_at":"2016-04-06T00:28:20Z","html_url":"https://github.com/mono/mono/pull/2837#discussion_r58636423","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/2837","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/58636423"},"html":{"href":"https://github.com/mono/mono/pull/2837#discussion_r58636423"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/2837"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/2837","id":65392698,"html_url":"https://github.com/mono/mono/pull/2837","diff_url":"https://github.com/mono/mono/pull/2837.diff","patch_url":"https://github.com/mono/mono/pull/2837.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/2837","number":2837,"state":"open","locked":false,"title":"Bunch of improvements surrounding thread names and reporting of such to the profiler","user":{"login":"alexrp","id":44076,"avatar_url":"https://avatars.githubusercontent.com/u/44076?v=3","gravatar_id":"","url":"https://api.github.com/users/alexrp","html_url":"https://github.com/alexrp","followers_url":"https://api.github.com/users/alexrp/followers","following_url":"https://api.github.com/users/alexrp/following{/other_user}","gists_url":"https://api.github.com/users/alexrp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrp/subscriptions","organizations_url":"https://api.github.com/users/alexrp/orgs","repos_url":"https://api.github.com/users/alexrp/repos","events_url":"https://api.github.com/users/alexrp/events{/privacy}","received_events_url":"https://api.github.com/users/alexrp/received_events","type":"User","site_admin":false},"body":"Supersedes #2830.","created_at":"2016-04-06T00:17:46Z","updated_at":"2016-04-06T00:28:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"660272b6628a16508a64855e4d3cfac518e761cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/2837/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/2837/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/2837/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/df8e4dc4fc9d06807aceb3268eec4232a3519f8c","head":{"label":"alexrp:master","ref":"master","sha":"df8e4dc4fc9d06807aceb3268eec4232a3519f8c","user":{"login":"alexrp","id":44076,"avatar_url":"https://avatars.githubusercontent.com/u/44076?v=3","gravatar_id":"","url":"https://api.github.com/users/alexrp","html_url":"https://github.com/alexrp","followers_url":"https://api.github.com/users/alexrp/followers","following_url":"https://api.github.com/users/alexrp/following{/other_user}","gists_url":"https://api.github.com/users/alexrp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrp/subscriptions","organizations_url":"https://api.github.com/users/alexrp/orgs","repos_url":"https://api.github.com/users/alexrp/repos","events_url":"https://api.github.com/users/alexrp/events{/privacy}","received_events_url":"https://api.github.com/users/alexrp/received_events","type":"User","site_admin":false},"repo":{"id":1155583,"name":"mono","full_name":"alexrp/mono","owner":{"login":"alexrp","id":44076,"avatar_url":"https://avatars.githubusercontent.com/u/44076?v=3","gravatar_id":"","url":"https://api.github.com/users/alexrp","html_url":"https://github.com/alexrp","followers_url":"https://api.github.com/users/alexrp/followers","following_url":"https://api.github.com/users/alexrp/following{/other_user}","gists_url":"https://api.github.com/users/alexrp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrp/subscriptions","organizations_url":"https://api.github.com/users/alexrp/orgs","repos_url":"https://api.github.com/users/alexrp/repos","events_url":"https://api.github.com/users/alexrp/events{/privacy}","received_events_url":"https://api.github.com/users/alexrp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexrp/mono","description":"My contributions to Mono.","fork":true,"url":"https://api.github.com/repos/alexrp/mono","forks_url":"https://api.github.com/repos/alexrp/mono/forks","keys_url":"https://api.github.com/repos/alexrp/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexrp/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexrp/mono/teams","hooks_url":"https://api.github.com/repos/alexrp/mono/hooks","issue_events_url":"https://api.github.com/repos/alexrp/mono/issues/events{/number}","events_url":"https://api.github.com/repos/alexrp/mono/events","assignees_url":"https://api.github.com/repos/alexrp/mono/assignees{/user}","branches_url":"https://api.github.com/repos/alexrp/mono/branches{/branch}","tags_url":"https://api.github.com/repos/alexrp/mono/tags","blobs_url":"https://api.github.com/repos/alexrp/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexrp/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexrp/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexrp/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexrp/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/alexrp/mono/languages","stargazers_url":"https://api.github.com/repos/alexrp/mono/stargazers","contributors_url":"https://api.github.com/repos/alexrp/mono/contributors","subscribers_url":"https://api.github.com/repos/alexrp/mono/subscribers","subscription_url":"https://api.github.com/repos/alexrp/mono/subscription","commits_url":"https://api.github.com/repos/alexrp/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexrp/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexrp/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexrp/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexrp/mono/contents/{+path}","compare_url":"https://api.github.com/repos/alexrp/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexrp/mono/merges","archive_url":"https://api.github.com/repos/alexrp/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexrp/mono/downloads","issues_url":"https://api.github.com/repos/alexrp/mono/issues{/number}","pulls_url":"https://api.github.com/repos/alexrp/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/alexrp/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/alexrp/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexrp/mono/labels{/name}","releases_url":"https://api.github.com/repos/alexrp/mono/releases{/id}","deployments_url":"https://api.github.com/repos/alexrp/mono/deployments","created_at":"2010-12-10T07:59:15Z","updated_at":"2015-05-08T09:05:58Z","pushed_at":"2016-04-06T00:16:24Z","git_url":"git://github.com/alexrp/mono.git","ssh_url":"git@github.com:alexrp/mono.git","clone_url":"https://github.com/alexrp/mono.git","svn_url":"https://github.com/alexrp/mono","homepage":"http://www.mono-project.com/","size":377054,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":11,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"0ebac113fce97894d0a53844f62c660a27cad7f7","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-04-05T17:52:55Z","pushed_at":"2016-04-06T00:17:47Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":467815,"stargazers_count":4479,"watchers_count":4479,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2142,"mirror_url":null,"open_issues_count":110,"forks":2142,"open_issues":110,"watchers":4479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/2837"},"html":{"href":"https://github.com/mono/mono/pull/2837"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/2837"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/2837/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/2837/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/2837/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/df8e4dc4fc9d06807aceb3268eec4232a3519f8c"}}}}