{"action":"opened","number":146,"pull_request":{"url":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls/146","id":94284590,"html_url":"https://github.com/philipn/django-rest-framework-filters/pull/146","diff_url":"https://github.com/philipn/django-rest-framework-filters/pull/146.diff","patch_url":"https://github.com/philipn/django-rest-framework-filters/pull/146.patch","issue_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/issues/146","number":146,"state":"open","locked":false,"title":"Use more secure default for RelatedFilter.queryset","user":{"login":"rpkilby","id":2370209,"avatar_url":"https://avatars.githubusercontent.com/u/2370209?v=3","gravatar_id":"","url":"https://api.github.com/users/rpkilby","html_url":"https://github.com/rpkilby","followers_url":"https://api.github.com/users/rpkilby/followers","following_url":"https://api.github.com/users/rpkilby/following{/other_user}","gists_url":"https://api.github.com/users/rpkilby/gists{/gist_id}","starred_url":"https://api.github.com/users/rpkilby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpkilby/subscriptions","organizations_url":"https://api.github.com/users/rpkilby/orgs","repos_url":"https://api.github.com/users/rpkilby/repos","events_url":"https://api.github.com/users/rpkilby/events{/privacy}","received_events_url":"https://api.github.com/users/rpkilby/received_events","type":"User","site_admin":false},"body":"The secure default here is to simply remove the current default handling for the `queryset` argument. The underlying form field will complain about the lack of a `queryset` if it's not provided, so this forces the user to explicitly add it to the filter instance. \r\n\r\nRef #100. This is only a partial fix, as this only restricts the displayed choices for the relationship. This does not prevent against joins that might leak data.\r\n\r\nThis is a breaking change.","created_at":"2016-11-18T01:02:56Z","updated_at":"2016-11-18T01:02:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/philipn/django-rest-framework-filters/milestones/4","html_url":"https://github.com/philipn/django-rest-framework-filters/milestones/v1.0.0","labels_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/milestones/4/labels","id":1917290,"number":4,"title":"v1.0.0","description":"","creator":{"login":"rpkilby","id":2370209,"avatar_url":"https://avatars.githubusercontent.com/u/2370209?v=3","gravatar_id":"","url":"https://api.github.com/users/rpkilby","html_url":"https://github.com/rpkilby","followers_url":"https://api.github.com/users/rpkilby/followers","following_url":"https://api.github.com/users/rpkilby/following{/other_user}","gists_url":"https://api.github.com/users/rpkilby/gists{/gist_id}","starred_url":"https://api.github.com/users/rpkilby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpkilby/subscriptions","organizations_url":"https://api.github.com/users/rpkilby/orgs","repos_url":"https://api.github.com/users/rpkilby/repos","events_url":"https://api.github.com/users/rpkilby/events{/privacy}","received_events_url":"https://api.github.com/users/rpkilby/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":13,"state":"open","created_at":"2016-08-02T03:45:11Z","updated_at":"2016-11-18T01:02:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls/146/commits","review_comments_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls/146/comments","review_comment_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/issues/146/comments","statuses_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/statuses/256d9a7fa6fc962ad74a92cecfacb7542bf65f48","head":{"label":"rpkilby:secure-qs-default","ref":"secure-qs-default","sha":"256d9a7fa6fc962ad74a92cecfacb7542bf65f48","user":{"login":"rpkilby","id":2370209,"avatar_url":"https://avatars.githubusercontent.com/u/2370209?v=3","gravatar_id":"","url":"https://api.github.com/users/rpkilby","html_url":"https://github.com/rpkilby","followers_url":"https://api.github.com/users/rpkilby/followers","following_url":"https://api.github.com/users/rpkilby/following{/other_user}","gists_url":"https://api.github.com/users/rpkilby/gists{/gist_id}","starred_url":"https://api.github.com/users/rpkilby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpkilby/subscriptions","organizations_url":"https://api.github.com/users/rpkilby/orgs","repos_url":"https://api.github.com/users/rpkilby/repos","events_url":"https://api.github.com/users/rpkilby/events{/privacy}","received_events_url":"https://api.github.com/users/rpkilby/received_events","type":"User","site_admin":false},"repo":{"id":42417199,"name":"django-rest-framework-filters","full_name":"rpkilby/django-rest-framework-filters","owner":{"login":"rpkilby","id":2370209,"avatar_url":"https://avatars.githubusercontent.com/u/2370209?v=3","gravatar_id":"","url":"https://api.github.com/users/rpkilby","html_url":"https://github.com/rpkilby","followers_url":"https://api.github.com/users/rpkilby/followers","following_url":"https://api.github.com/users/rpkilby/following{/other_user}","gists_url":"https://api.github.com/users/rpkilby/gists{/gist_id}","starred_url":"https://api.github.com/users/rpkilby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpkilby/subscriptions","organizations_url":"https://api.github.com/users/rpkilby/orgs","repos_url":"https://api.github.com/users/rpkilby/repos","events_url":"https://api.github.com/users/rpkilby/events{/privacy}","received_events_url":"https://api.github.com/users/rpkilby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpkilby/django-rest-framework-filters","description":"Better filtering for Django REST Framework","fork":true,"url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters","forks_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/forks","keys_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/teams","hooks_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/hooks","issue_events_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/issues/events{/number}","events_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/events","assignees_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/assignees{/user}","branches_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/branches{/branch}","tags_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/tags","blobs_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/statuses/{sha}","languages_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/languages","stargazers_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/stargazers","contributors_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/contributors","subscribers_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/subscribers","subscription_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/subscription","commits_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/contents/{+path}","compare_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/merges","archive_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/downloads","issues_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/issues{/number}","pulls_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/pulls{/number}","milestones_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/milestones{/number}","notifications_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/labels{/name}","releases_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/releases{/id}","deployments_url":"https://api.github.com/repos/rpkilby/django-rest-framework-filters/deployments","created_at":"2015-09-13T23:41:41Z","updated_at":"2016-01-13T04:51:08Z","pushed_at":"2016-11-18T00:49:27Z","git_url":"git://github.com/rpkilby/django-rest-framework-filters.git","ssh_url":"git@github.com:rpkilby/django-rest-framework-filters.git","clone_url":"https://github.com/rpkilby/django-rest-framework-filters.git","svn_url":"https://github.com/rpkilby/django-rest-framework-filters","homepage":"","size":231,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"philipn:master","ref":"master","sha":"ebb03cfde05ea5dad94cde18179557365a1234f8","user":{"login":"philipn","id":96469,"avatar_url":"https://avatars.githubusercontent.com/u/96469?v=3","gravatar_id":"","url":"https://api.github.com/users/philipn","html_url":"https://github.com/philipn","followers_url":"https://api.github.com/users/philipn/followers","following_url":"https://api.github.com/users/philipn/following{/other_user}","gists_url":"https://api.github.com/users/philipn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipn/subscriptions","organizations_url":"https://api.github.com/users/philipn/orgs","repos_url":"https://api.github.com/users/philipn/repos","events_url":"https://api.github.com/users/philipn/events{/privacy}","received_events_url":"https://api.github.com/users/philipn/received_events","type":"User","site_admin":false},"repo":{"id":15126511,"name":"django-rest-framework-filters","full_name":"philipn/django-rest-framework-filters","owner":{"login":"philipn","id":96469,"avatar_url":"https://avatars.githubusercontent.com/u/96469?v=3","gravatar_id":"","url":"https://api.github.com/users/philipn","html_url":"https://github.com/philipn","followers_url":"https://api.github.com/users/philipn/followers","following_url":"https://api.github.com/users/philipn/following{/other_user}","gists_url":"https://api.github.com/users/philipn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipn/subscriptions","organizations_url":"https://api.github.com/users/philipn/orgs","repos_url":"https://api.github.com/users/philipn/repos","events_url":"https://api.github.com/users/philipn/events{/privacy}","received_events_url":"https://api.github.com/users/philipn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philipn/django-rest-framework-filters","description":"Better filtering for Django REST Framework","fork":false,"url":"https://api.github.com/repos/philipn/django-rest-framework-filters","forks_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/forks","keys_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/teams","hooks_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/hooks","issue_events_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/issues/events{/number}","events_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/events","assignees_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/assignees{/user}","branches_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/branches{/branch}","tags_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/tags","blobs_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/git/refs{/sha}","trees_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/statuses/{sha}","languages_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/languages","stargazers_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/stargazers","contributors_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/contributors","subscribers_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/subscribers","subscription_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/subscription","commits_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/commits{/sha}","git_commits_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/git/commits{/sha}","comments_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/comments{/number}","issue_comment_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/issues/comments{/number}","contents_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/contents/{+path}","compare_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/merges","archive_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/downloads","issues_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/issues{/number}","pulls_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls{/number}","milestones_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/milestones{/number}","notifications_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/labels{/name}","releases_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/releases{/id}","deployments_url":"https://api.github.com/repos/philipn/django-rest-framework-filters/deployments","created_at":"2013-12-12T03:59:33Z","updated_at":"2016-11-17T05:15:37Z","pushed_at":"2016-11-18T01:02:56Z","git_url":"git://github.com/philipn/django-rest-framework-filters.git","ssh_url":"git@github.com:philipn/django-rest-framework-filters.git","clone_url":"https://github.com/philipn/django-rest-framework-filters.git","svn_url":"https://github.com/philipn/django-rest-framework-filters","homepage":"","size":250,"stargazers_count":229,"watchers_count":229,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":9,"forks":40,"open_issues":9,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls/146"},"html":{"href":"https://github.com/philipn/django-rest-framework-filters/pull/146"},"issue":{"href":"https://api.github.com/repos/philipn/django-rest-framework-filters/issues/146"},"comments":{"href":"https://api.github.com/repos/philipn/django-rest-framework-filters/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/philipn/django-rest-framework-filters/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/philipn/django-rest-framework-filters/statuses/256d9a7fa6fc962ad74a92cecfacb7542bf65f48"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":81,"deletions":27,"changed_files":5}}
{"actor":{"display_login":"rpkilby"}}