{"action":"created","issue":{"url":"https://api.github.com/repos/obspy/obspy/issues/1488","repository_url":"https://api.github.com/repos/obspy/obspy","labels_url":"https://api.github.com/repos/obspy/obspy/issues/1488/labels{/name}","comments_url":"https://api.github.com/repos/obspy/obspy/issues/1488/comments","events_url":"https://api.github.com/repos/obspy/obspy/issues/1488/events","html_url":"https://github.com/obspy/obspy/issues/1488","id":168461225,"number":1488,"title":"python setup.py clean has side effects.","user":{"login":"ghisvail","id":1964655,"avatar_url":"https://avatars.githubusercontent.com/u/1964655?v=3","gravatar_id":"","url":"https://api.github.com/users/ghisvail","html_url":"https://github.com/ghisvail","followers_url":"https://api.github.com/users/ghisvail/followers","following_url":"https://api.github.com/users/ghisvail/following{/other_user}","gists_url":"https://api.github.com/users/ghisvail/gists{/gist_id}","starred_url":"https://api.github.com/users/ghisvail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghisvail/subscriptions","organizations_url":"https://api.github.com/users/ghisvail/orgs","repos_url":"https://api.github.com/users/ghisvail/repos","events_url":"https://api.github.com/users/ghisvail/events{/privacy}","received_events_url":"https://api.github.com/users/ghisvail/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/obspy/obspy/labels/DEB","name":"DEB","color":"009800"},{"url":"https://api.github.com/repos/obspy/obspy/labels/installation","name":"installation","color":"cc317c"},{"url":"https://api.github.com/repos/obspy/obspy/labels/packaging","name":"packaging","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-07-30T10:36:25Z","updated_at":"2016-07-31T14:51:01Z","closed_at":null,"body":"Running `python setup.py clean` overwrites the version file `obspy/RELEASE-VERSION`. Is this intended ?"},"comment":{"url":"https://api.github.com/repos/obspy/obspy/issues/comments/236434183","html_url":"https://github.com/obspy/obspy/issues/1488#issuecomment-236434183","issue_url":"https://api.github.com/repos/obspy/obspy/issues/1488","id":236434183,"user":{"login":"megies","id":1842780,"avatar_url":"https://avatars.githubusercontent.com/u/1842780?v=3","gravatar_id":"","url":"https://api.github.com/users/megies","html_url":"https://github.com/megies","followers_url":"https://api.github.com/users/megies/followers","following_url":"https://api.github.com/users/megies/following{/other_user}","gists_url":"https://api.github.com/users/megies/gists{/gist_id}","starred_url":"https://api.github.com/users/megies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megies/subscriptions","organizations_url":"https://api.github.com/users/megies/orgs","repos_url":"https://api.github.com/users/megies/repos","events_url":"https://api.github.com/users/megies/events{/privacy}","received_events_url":"https://api.github.com/users/megies/received_events","type":"User","site_admin":false},"created_at":"2016-07-31T14:51:01Z","updated_at":"2016-07-31T14:51:01Z","body":"> Let me know whether my explanation was not clear enough.\r\n\r\nYes, I understand the problem now.\r\n\r\nCan't you just add a patch in the deb packaging to change the version number lookup? You could patch it in a couple of places (e.g. in top-level `__init__.py` where `__version__` is set) but safest would be to patch `obspy.core.util.version.get_git_version` like this:\r\n\r\n```diff\r\ndiff --git a/obspy/core/util/version.py b/obspy/core/util/version.py\r\nindex df0ea7d..b6179da 100644\r\n--- a/obspy/core/util/version.py\r\n+++ b/obspy/core/util/version.py\r\n@@ -139,31 +139,6 @@ def write_release_version(version):\r\n def get_git_version(abbrev=10, dirty=True, append_remote_tracking_branch=True):\r\n     # Read in the version that's currently in RELEASE-VERSION.\r\n     release_version = read_release_version()\r\n-\r\n-    # First try to get the current version using “git describe”.\r\n-    version = call_git_describe(\r\n-        abbrev, dirty=dirty,\r\n-        append_remote_tracking_branch=append_remote_tracking_branch)\r\n-\r\n-    # If that doesn't work, fall back on the value that's in\r\n-    # RELEASE-VERSION.\r\n-    if version is None:\r\n-        version = release_version\r\n-\r\n-    # If we still don't have anything, that's an error.\r\n-    if version is None:\r\n-        return '0.0.0+archive'\r\n-\r\n-    # pip uses its normalized version number (strict PEP440) instead of our\r\n-    # original version number, so we bow to pip and use the normalized version\r\n-    # number internally, too, to avoid discrepancies.\r\n-    version = _normalize_version(version)\r\n-\r\n-    # If the current version is different from what's in the\r\n-    # RELEASE-VERSION file, update the file to be current.\r\n-    if version != release_version:\r\n-        write_release_version(version)\r\n-\r\n     # Finally, return the current version.\r\n     return version\r\n```"}}
{"actor":{"display_login":"megies"}}