{"action":"created","comment":{"url":"https://api.github.com/repos/Shyp/mocha/pulls/comments/77734478","id":77734478,"diff_hunk":"@@ -219,6 +219,11 @@ exports.list = function(failures) {\n     stack = stack.replace(/^/gm, '  ');\n \n     console.log(fmt, (i + 1), test.fullTitle(), msg, stack);\n+\n+    // [hack] Handle waterline's nested `originalError`\n+    if (err.originalError && err.originalError instanceof Error) {","path":"lib/reporters/base.js","position":6,"original_position":6,"commit_id":"645bb8a6513c59962643a9e9908e5272908bb74e","original_commit_id":"645bb8a6513c59962643a9e9908e5272908bb74e","user":{"login":"lafave","id":697613,"avatar_url":"https://avatars.githubusercontent.com/u/697613?v=3","gravatar_id":"","url":"https://api.github.com/users/lafave","html_url":"https://github.com/lafave","followers_url":"https://api.github.com/users/lafave/followers","following_url":"https://api.github.com/users/lafave/following{/other_user}","gists_url":"https://api.github.com/users/lafave/gists{/gist_id}","starred_url":"https://api.github.com/users/lafave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafave/subscriptions","organizations_url":"https://api.github.com/users/lafave/orgs","repos_url":"https://api.github.com/users/lafave/repos","events_url":"https://api.github.com/users/lafave/events{/privacy}","received_events_url":"https://api.github.com/users/lafave/received_events","type":"User","site_admin":false},"body":"Curious, is `originalError` ever not an instance of `Error`? Would we want to console log it anyways if it weren't?","created_at":"2016-09-06T23:01:44Z","updated_at":"2016-09-06T23:01:44Z","html_url":"https://github.com/Shyp/mocha/pull/1#discussion_r77734478","pull_request_url":"https://api.github.com/repos/Shyp/mocha/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Shyp/mocha/pulls/comments/77734478"},"html":{"href":"https://github.com/Shyp/mocha/pull/1#discussion_r77734478"},"pull_request":{"href":"https://api.github.com/repos/Shyp/mocha/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Shyp/mocha/pulls/1","id":84209283,"html_url":"https://github.com/Shyp/mocha/pull/1","diff_url":"https://github.com/Shyp/mocha/pull/1.diff","patch_url":"https://github.com/Shyp/mocha/pull/1.patch","issue_url":"https://api.github.com/repos/Shyp/mocha/issues/1","number":1,"state":"open","locked":false,"title":"Hack for errors with `originalError` properties","user":{"login":"benbuckman","id":354655,"avatar_url":"https://avatars.githubusercontent.com/u/354655?v=3","gravatar_id":"","url":"https://api.github.com/users/benbuckman","html_url":"https://github.com/benbuckman","followers_url":"https://api.github.com/users/benbuckman/followers","following_url":"https://api.github.com/users/benbuckman/following{/other_user}","gists_url":"https://api.github.com/users/benbuckman/gists{/gist_id}","starred_url":"https://api.github.com/users/benbuckman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbuckman/subscriptions","organizations_url":"https://api.github.com/users/benbuckman/orgs","repos_url":"https://api.github.com/users/benbuckman/repos","events_url":"https://api.github.com/users/benbuckman/events{/privacy}","received_events_url":"https://api.github.com/users/benbuckman/received_events","type":"User","site_admin":false},"body":"We frequently have tests fail with Waterline errors, which have an `originalError` property indicating the real failure, but Mocha's `spec` runner doesn't show this value.\r\n\r\nThis is a hack to the reporter on our fork which logs that value when it's present.\r\n\r\nI was unsuccessful at less hacky approaches, such as accessing the `runner` in our app-side test code. We've already made [a number of custom changes to our fork](https://github.com/mochajs/mocha/compare/master...Shyp:show-originalError), and we're still at the head of the public 2.x branch (the 3.x branch is in beta), so this seems worth the tradeoff.\r\n\r\n---\r\n\r\n> shyp reviewer platform\r\n> lafave has been chosen!\r\n","created_at":"2016-09-06T22:43:04Z","updated_at":"2016-09-06T23:01:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0ceb5ba83b2582c9fe6fcac411370fb78c7a4dc","assignee":{"login":"lafave","id":697613,"avatar_url":"https://avatars.githubusercontent.com/u/697613?v=3","gravatar_id":"","url":"https://api.github.com/users/lafave","html_url":"https://github.com/lafave","followers_url":"https://api.github.com/users/lafave/followers","following_url":"https://api.github.com/users/lafave/following{/other_user}","gists_url":"https://api.github.com/users/lafave/gists{/gist_id}","starred_url":"https://api.github.com/users/lafave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafave/subscriptions","organizations_url":"https://api.github.com/users/lafave/orgs","repos_url":"https://api.github.com/users/lafave/repos","events_url":"https://api.github.com/users/lafave/events{/privacy}","received_events_url":"https://api.github.com/users/lafave/received_events","type":"User","site_admin":false},"assignees":[{"login":"lafave","id":697613,"avatar_url":"https://avatars.githubusercontent.com/u/697613?v=3","gravatar_id":"","url":"https://api.github.com/users/lafave","html_url":"https://github.com/lafave","followers_url":"https://api.github.com/users/lafave/followers","following_url":"https://api.github.com/users/lafave/following{/other_user}","gists_url":"https://api.github.com/users/lafave/gists{/gist_id}","starred_url":"https://api.github.com/users/lafave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafave/subscriptions","organizations_url":"https://api.github.com/users/lafave/orgs","repos_url":"https://api.github.com/users/lafave/repos","events_url":"https://api.github.com/users/lafave/events{/privacy}","received_events_url":"https://api.github.com/users/lafave/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Shyp/mocha/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Shyp/mocha/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Shyp/mocha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shyp/mocha/issues/1/comments","statuses_url":"https://api.github.com/repos/Shyp/mocha/statuses/645bb8a6513c59962643a9e9908e5272908bb74e","head":{"label":"Shyp:show-originalError","ref":"show-originalError","sha":"645bb8a6513c59962643a9e9908e5272908bb74e","user":{"login":"Shyp","id":5368149,"avatar_url":"https://avatars.githubusercontent.com/u/5368149?v=3","gravatar_id":"","url":"https://api.github.com/users/Shyp","html_url":"https://github.com/Shyp","followers_url":"https://api.github.com/users/Shyp/followers","following_url":"https://api.github.com/users/Shyp/following{/other_user}","gists_url":"https://api.github.com/users/Shyp/gists{/gist_id}","starred_url":"https://api.github.com/users/Shyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shyp/subscriptions","organizations_url":"https://api.github.com/users/Shyp/orgs","repos_url":"https://api.github.com/users/Shyp/repos","events_url":"https://api.github.com/users/Shyp/events{/privacy}","received_events_url":"https://api.github.com/users/Shyp/received_events","type":"Organization","site_admin":false},"repo":{"id":41661318,"name":"mocha","full_name":"Shyp/mocha","owner":{"login":"Shyp","id":5368149,"avatar_url":"https://avatars.githubusercontent.com/u/5368149?v=3","gravatar_id":"","url":"https://api.github.com/users/Shyp","html_url":"https://github.com/Shyp","followers_url":"https://api.github.com/users/Shyp/followers","following_url":"https://api.github.com/users/Shyp/following{/other_user}","gists_url":"https://api.github.com/users/Shyp/gists{/gist_id}","starred_url":"https://api.github.com/users/Shyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shyp/subscriptions","organizations_url":"https://api.github.com/users/Shyp/orgs","repos_url":"https://api.github.com/users/Shyp/repos","events_url":"https://api.github.com/users/Shyp/events{/privacy}","received_events_url":"https://api.github.com/users/Shyp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shyp/mocha","description":"mocha - simple, flexible, fun javascript test framework for node.js & the browser. (BDD, TDD, QUnit styles via interfaces)","fork":true,"url":"https://api.github.com/repos/Shyp/mocha","forks_url":"https://api.github.com/repos/Shyp/mocha/forks","keys_url":"https://api.github.com/repos/Shyp/mocha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shyp/mocha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shyp/mocha/teams","hooks_url":"https://api.github.com/repos/Shyp/mocha/hooks","issue_events_url":"https://api.github.com/repos/Shyp/mocha/issues/events{/number}","events_url":"https://api.github.com/repos/Shyp/mocha/events","assignees_url":"https://api.github.com/repos/Shyp/mocha/assignees{/user}","branches_url":"https://api.github.com/repos/Shyp/mocha/branches{/branch}","tags_url":"https://api.github.com/repos/Shyp/mocha/tags","blobs_url":"https://api.github.com/repos/Shyp/mocha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shyp/mocha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shyp/mocha/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shyp/mocha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shyp/mocha/statuses/{sha}","languages_url":"https://api.github.com/repos/Shyp/mocha/languages","stargazers_url":"https://api.github.com/repos/Shyp/mocha/stargazers","contributors_url":"https://api.github.com/repos/Shyp/mocha/contributors","subscribers_url":"https://api.github.com/repos/Shyp/mocha/subscribers","subscription_url":"https://api.github.com/repos/Shyp/mocha/subscription","commits_url":"https://api.github.com/repos/Shyp/mocha/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shyp/mocha/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shyp/mocha/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shyp/mocha/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shyp/mocha/contents/{+path}","compare_url":"https://api.github.com/repos/Shyp/mocha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shyp/mocha/merges","archive_url":"https://api.github.com/repos/Shyp/mocha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shyp/mocha/downloads","issues_url":"https://api.github.com/repos/Shyp/mocha/issues{/number}","pulls_url":"https://api.github.com/repos/Shyp/mocha/pulls{/number}","milestones_url":"https://api.github.com/repos/Shyp/mocha/milestones{/number}","notifications_url":"https://api.github.com/repos/Shyp/mocha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shyp/mocha/labels{/name}","releases_url":"https://api.github.com/repos/Shyp/mocha/releases{/id}","deployments_url":"https://api.github.com/repos/Shyp/mocha/deployments","created_at":"2015-08-31T07:14:46Z","updated_at":"2016-03-21T23:16:28Z","pushed_at":"2016-09-06T22:43:04Z","git_url":"git://github.com/Shyp/mocha.git","ssh_url":"git@github.com:Shyp/mocha.git","clone_url":"https://github.com/Shyp/mocha.git","svn_url":"https://github.com/Shyp/mocha","homepage":"http://mochajs.org","size":2744,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Shyp:master","ref":"master","sha":"927f8e9f35346292fce2f967f1caf317ad9563c9","user":{"login":"Shyp","id":5368149,"avatar_url":"https://avatars.githubusercontent.com/u/5368149?v=3","gravatar_id":"","url":"https://api.github.com/users/Shyp","html_url":"https://github.com/Shyp","followers_url":"https://api.github.com/users/Shyp/followers","following_url":"https://api.github.com/users/Shyp/following{/other_user}","gists_url":"https://api.github.com/users/Shyp/gists{/gist_id}","starred_url":"https://api.github.com/users/Shyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shyp/subscriptions","organizations_url":"https://api.github.com/users/Shyp/orgs","repos_url":"https://api.github.com/users/Shyp/repos","events_url":"https://api.github.com/users/Shyp/events{/privacy}","received_events_url":"https://api.github.com/users/Shyp/received_events","type":"Organization","site_admin":false},"repo":{"id":41661318,"name":"mocha","full_name":"Shyp/mocha","owner":{"login":"Shyp","id":5368149,"avatar_url":"https://avatars.githubusercontent.com/u/5368149?v=3","gravatar_id":"","url":"https://api.github.com/users/Shyp","html_url":"https://github.com/Shyp","followers_url":"https://api.github.com/users/Shyp/followers","following_url":"https://api.github.com/users/Shyp/following{/other_user}","gists_url":"https://api.github.com/users/Shyp/gists{/gist_id}","starred_url":"https://api.github.com/users/Shyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shyp/subscriptions","organizations_url":"https://api.github.com/users/Shyp/orgs","repos_url":"https://api.github.com/users/Shyp/repos","events_url":"https://api.github.com/users/Shyp/events{/privacy}","received_events_url":"https://api.github.com/users/Shyp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shyp/mocha","description":"mocha - simple, flexible, fun javascript test framework for node.js & the browser. (BDD, TDD, QUnit styles via interfaces)","fork":true,"url":"https://api.github.com/repos/Shyp/mocha","forks_url":"https://api.github.com/repos/Shyp/mocha/forks","keys_url":"https://api.github.com/repos/Shyp/mocha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shyp/mocha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shyp/mocha/teams","hooks_url":"https://api.github.com/repos/Shyp/mocha/hooks","issue_events_url":"https://api.github.com/repos/Shyp/mocha/issues/events{/number}","events_url":"https://api.github.com/repos/Shyp/mocha/events","assignees_url":"https://api.github.com/repos/Shyp/mocha/assignees{/user}","branches_url":"https://api.github.com/repos/Shyp/mocha/branches{/branch}","tags_url":"https://api.github.com/repos/Shyp/mocha/tags","blobs_url":"https://api.github.com/repos/Shyp/mocha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shyp/mocha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shyp/mocha/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shyp/mocha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shyp/mocha/statuses/{sha}","languages_url":"https://api.github.com/repos/Shyp/mocha/languages","stargazers_url":"https://api.github.com/repos/Shyp/mocha/stargazers","contributors_url":"https://api.github.com/repos/Shyp/mocha/contributors","subscribers_url":"https://api.github.com/repos/Shyp/mocha/subscribers","subscription_url":"https://api.github.com/repos/Shyp/mocha/subscription","commits_url":"https://api.github.com/repos/Shyp/mocha/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shyp/mocha/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shyp/mocha/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shyp/mocha/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shyp/mocha/contents/{+path}","compare_url":"https://api.github.com/repos/Shyp/mocha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shyp/mocha/merges","archive_url":"https://api.github.com/repos/Shyp/mocha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shyp/mocha/downloads","issues_url":"https://api.github.com/repos/Shyp/mocha/issues{/number}","pulls_url":"https://api.github.com/repos/Shyp/mocha/pulls{/number}","milestones_url":"https://api.github.com/repos/Shyp/mocha/milestones{/number}","notifications_url":"https://api.github.com/repos/Shyp/mocha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shyp/mocha/labels{/name}","releases_url":"https://api.github.com/repos/Shyp/mocha/releases{/id}","deployments_url":"https://api.github.com/repos/Shyp/mocha/deployments","created_at":"2015-08-31T07:14:46Z","updated_at":"2016-03-21T23:16:28Z","pushed_at":"2016-09-06T22:43:04Z","git_url":"git://github.com/Shyp/mocha.git","ssh_url":"git@github.com:Shyp/mocha.git","clone_url":"https://github.com/Shyp/mocha.git","svn_url":"https://github.com/Shyp/mocha","homepage":"http://mochajs.org","size":2744,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shyp/mocha/pulls/1"},"html":{"href":"https://github.com/Shyp/mocha/pull/1"},"issue":{"href":"https://api.github.com/repos/Shyp/mocha/issues/1"},"comments":{"href":"https://api.github.com/repos/Shyp/mocha/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Shyp/mocha/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Shyp/mocha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shyp/mocha/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Shyp/mocha/statuses/645bb8a6513c59962643a9e9908e5272908bb74e"}}}}
{"actor":{"display_login":"lafave"}}