{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/563","repository_url":"https://api.github.com/repos/apple/swift-corelibs-foundation","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/563/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/563/comments","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/563/events","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/563","id":171824915,"number":563,"title":"[SR-2384] remove NSUniqueObject","user":{"login":"lhoward","id":541239,"avatar_url":"https://avatars.githubusercontent.com/u/541239?v=3","gravatar_id":"","url":"https://api.github.com/users/lhoward","html_url":"https://github.com/lhoward","followers_url":"https://api.github.com/users/lhoward/followers","following_url":"https://api.github.com/users/lhoward/following{/other_user}","gists_url":"https://api.github.com/users/lhoward/gists{/gist_id}","starred_url":"https://api.github.com/users/lhoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhoward/subscriptions","organizations_url":"https://api.github.com/users/lhoward/orgs","repos_url":"https://api.github.com/users/lhoward/repos","events_url":"https://api.github.com/users/lhoward/events{/privacy}","received_events_url":"https://api.github.com/users/lhoward/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-08-18T06:09:07Z","updated_at":"2016-08-19T04:32:15Z","closed_at":"2016-08-18T17:48:04Z","pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/563","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/563","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/563.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/563.patch"},"body":"NSKeyedArchiver uses an internal struct, NSUniqueObject to box unhashable objects so they may be used as dictionary keys. AnyHashable, if my understanding is correct, obviates the need for this."},"comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments/240925455","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/563#issuecomment-240925455","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/563","id":240925455,"user":{"login":"lhoward","id":541239,"avatar_url":"https://avatars.githubusercontent.com/u/541239?v=3","gravatar_id":"","url":"https://api.github.com/users/lhoward","html_url":"https://github.com/lhoward","followers_url":"https://api.github.com/users/lhoward/followers","following_url":"https://api.github.com/users/lhoward/following{/other_user}","gists_url":"https://api.github.com/users/lhoward/gists{/gist_id}","starred_url":"https://api.github.com/users/lhoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhoward/subscriptions","organizations_url":"https://api.github.com/users/lhoward/orgs","repos_url":"https://api.github.com/users/lhoward/repos","events_url":"https://api.github.com/users/lhoward/events{/privacy}","received_events_url":"https://api.github.com/users/lhoward/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T04:32:15Z","updated_at":"2016-08-19T04:32:15Z","body":"\n> On 19 Aug 2016, at 2:25 PM, Tony Parker <notifications@github.com> wrote:\n> \n> What'll happen is that the internal _SwiftValue class will be given to the keyed archiver, which will then throw an exception (I think) because it doesn't implement -encodeWithCoder:. So you'll still be allowed at compile time to pass it in (as you were before, because we didn't actually check for NSCoding conformance), but it'll fail at runtime.\n> \n\nThis is for value types, right? What happens if you encode, say, [1, 2, 3] on Darwin, will it work or crash?\n\nIn the case of classes that do not explicitly subclass NSObject (but implement NSCoding), presumably these work on Darwin by implicitly subclassing NSObject (because NSCoding is @objc)? So in order to have source compatibility where ObjC is not available, we’d want to support arbitrary classes implementing NSCoding."}}
{"actor":{"display_login":"lhoward"}}