{"action":"created","issue":{"url":"https://api.github.com/repos/libgdx/libgdx/issues/4357","repository_url":"https://api.github.com/repos/libgdx/libgdx","labels_url":"https://api.github.com/repos/libgdx/libgdx/issues/4357/labels{/name}","comments_url":"https://api.github.com/repos/libgdx/libgdx/issues/4357/comments","events_url":"https://api.github.com/repos/libgdx/libgdx/issues/4357/events","html_url":"https://github.com/libgdx/libgdx/pull/4357","id":182233585,"number":4357,"title":"Camera now uses correct viewport height value for unproject","user":{"login":"metaphore","id":6159734,"avatar_url":"https://avatars.githubusercontent.com/u/6159734?v=3","gravatar_id":"","url":"https://api.github.com/users/metaphore","html_url":"https://github.com/metaphore","followers_url":"https://api.github.com/users/metaphore/followers","following_url":"https://api.github.com/users/metaphore/following{/other_user}","gists_url":"https://api.github.com/users/metaphore/gists{/gist_id}","starred_url":"https://api.github.com/users/metaphore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaphore/subscriptions","organizations_url":"https://api.github.com/users/metaphore/orgs","repos_url":"https://api.github.com/users/metaphore/repos","events_url":"https://api.github.com/users/metaphore/events{/privacy}","received_events_url":"https://api.github.com/users/metaphore/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-11T10:53:24Z","updated_at":"2016-12-05T06:45:31Z","closed_at":"2016-12-03T19:27:00Z","pull_request":{"url":"https://api.github.com/repos/libgdx/libgdx/pulls/4357","html_url":"https://github.com/libgdx/libgdx/pull/4357","diff_url":"https://github.com/libgdx/libgdx/pull/4357.diff","patch_url":"https://github.com/libgdx/libgdx/pull/4357.patch"},"body":"There is a bug in `Camera#unproject(Vector3, int, int, int, int)` code, it has viewport height as fifth argument, but still uses `Gdx.graphics.getHeight()` for that value. As result, it gives wrong point translation result (Y component is messed up) in case when actual GL viewport and application window size are different.\n\nThis PR is partially related to https://github.com/libgdx/libgdx/pull/3175\n"},"comment":{"url":"https://api.github.com/repos/libgdx/libgdx/issues/comments/264779443","html_url":"https://github.com/libgdx/libgdx/pull/4357#issuecomment-264779443","issue_url":"https://api.github.com/repos/libgdx/libgdx/issues/4357","id":264779443,"user":{"login":"metaphore","id":6159734,"avatar_url":"https://avatars.githubusercontent.com/u/6159734?v=3","gravatar_id":"","url":"https://api.github.com/users/metaphore","html_url":"https://github.com/metaphore","followers_url":"https://api.github.com/users/metaphore/followers","following_url":"https://api.github.com/users/metaphore/following{/other_user}","gists_url":"https://api.github.com/users/metaphore/gists{/gist_id}","starred_url":"https://api.github.com/users/metaphore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaphore/subscriptions","organizations_url":"https://api.github.com/users/metaphore/orgs","repos_url":"https://api.github.com/users/metaphore/repos","events_url":"https://api.github.com/users/metaphore/events{/privacy}","received_events_url":"https://api.github.com/users/metaphore/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T06:45:31Z","updated_at":"2016-12-05T06:45:31Z","body":"Hm, it's a very good question, thanks for pointing me out @Tom-Ski. Seems like I just a bit lost in all this translations.\r\nBut still, I don't understand why do we have `Camera#unporject(Vector3, float, float, float, float)` viewport  parametrized overload and don't use actual height from it? In what case this method can be used directly?"}}
{"actor":{"display_login":"metaphore"}}