{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6963","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6963/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6963/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6963/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6963","id":164240074,"number":6963,"title":"[MRG] [MAINT] Make sure set_params does not break clone on kernels","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=3","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-07T06:41:14Z","updated_at":"2016-07-07T07:18:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6963","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6963","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6963.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6963.patch"},"body":"#### Reference Issue\r\nFixes #6961 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nFor example, in kernels such as RBF, using set_params with a\r\nlength_scale of different length, used to break clone because of\r\nthe non-trivial modification of length_scale in the constructor.\r\n\r\nThis PR resolves this by moving this logic to __call__ and\r\nmaking hyperparameter attributes properties."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/231001917","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6963#issuecomment-231001917","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6963","id":231001917,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T07:18:49Z","updated_at":"2016-07-07T07:18:49Z","body":"Could you please check whether and how similar issues are being tested in `sklearn.tests.test_common`?"}}
{"actor":{"display_login":"jnothman"}}