{"action":"created","comment":{"url":"https://api.github.com/repos/liveh2o/active_remote/pulls/comments/67529530","id":67529530,"diff_hunk":"@@ -1,5 +1,13 @@\n module ActiveRemote\n   module Attributes\n+    def attributes","path":"lib/active_remote/attributes.rb","position":3,"original_position":3,"commit_id":"12f40ba39eee3c8758aa646126374e2791c790c8","original_commit_id":"12f40ba39eee3c8758aa646126374e2791c790c8","user":{"login":"liveh2o","id":207933,"avatar_url":"https://avatars.githubusercontent.com/u/207933?v=3","gravatar_id":"","url":"https://api.github.com/users/liveh2o","html_url":"https://github.com/liveh2o","followers_url":"https://api.github.com/users/liveh2o/followers","following_url":"https://api.github.com/users/liveh2o/following{/other_user}","gists_url":"https://api.github.com/users/liveh2o/gists{/gist_id}","starred_url":"https://api.github.com/users/liveh2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveh2o/subscriptions","organizations_url":"https://api.github.com/users/liveh2o/orgs","repos_url":"https://api.github.com/users/liveh2o/repos","events_url":"https://api.github.com/users/liveh2o/events{/privacy}","received_events_url":"https://api.github.com/users/liveh2o/received_events","type":"User","site_admin":false},"body":"Why is this necessary? Not opposed, just want to understand.","created_at":"2016-06-17T15:32:27Z","updated_at":"2016-06-17T15:32:27Z","html_url":"https://github.com/liveh2o/active_remote/pull/43#discussion_r67529530","pull_request_url":"https://api.github.com/repos/liveh2o/active_remote/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/comments/67529530"},"html":{"href":"https://github.com/liveh2o/active_remote/pull/43#discussion_r67529530"},"pull_request":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/liveh2o/active_remote/pulls/43","id":74159546,"html_url":"https://github.com/liveh2o/active_remote/pull/43","diff_url":"https://github.com/liveh2o/active_remote/pull/43.diff","patch_url":"https://github.com/liveh2o/active_remote/pull/43.patch","issue_url":"https://api.github.com/repos/liveh2o/active_remote/issues/43","number":43,"state":"open","locked":false,"title":"Remove active attr typecasting","user":{"login":"brianstien","id":1568220,"avatar_url":"https://avatars.githubusercontent.com/u/1568220?v=3","gravatar_id":"","url":"https://api.github.com/users/brianstien","html_url":"https://github.com/brianstien","followers_url":"https://api.github.com/users/brianstien/followers","following_url":"https://api.github.com/users/brianstien/following{/other_user}","gists_url":"https://api.github.com/users/brianstien/gists{/gist_id}","starred_url":"https://api.github.com/users/brianstien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianstien/subscriptions","organizations_url":"https://api.github.com/users/brianstien/orgs","repos_url":"https://api.github.com/users/brianstien/repos","events_url":"https://api.github.com/users/brianstien/events{/privacy}","received_events_url":"https://api.github.com/users/brianstien/received_events","type":"User","site_admin":false},"body":"This removes the active_attr typecasting module and and implements our own.  Instead of typecasting at the read time of an attribute (or attributes), this moves the typecasting to write time.\r\n\r\nThis is a substantial performance improvement whenever `attributes`, or `respond_to?` is called on an instance, we do not have to typecast every attribute.\r\n\r\nI imported the active_attr typecasters and also kept their same dsl so this is backwards compatible.\r\n\r\nIn the future I think the attribute store should allow attributes to be written without typecasting, so that we can skip that step when getting data from an adapter, which has likely already done the typecasting.  Currently the attribute store is just a dumb hash, but I think that should be improved.","created_at":"2016-06-16T21:59:08Z","updated_at":"2016-06-17T15:32:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f503dc6fd50c26f0e11bea5318248b54dd165f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/liveh2o/active_remote/pulls/43/commits","review_comments_url":"https://api.github.com/repos/liveh2o/active_remote/pulls/43/comments","review_comment_url":"https://api.github.com/repos/liveh2o/active_remote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liveh2o/active_remote/issues/43/comments","statuses_url":"https://api.github.com/repos/liveh2o/active_remote/statuses/12f40ba39eee3c8758aa646126374e2791c790c8","head":{"label":"brianstien:remove_active_attr_typecasting","ref":"remove_active_attr_typecasting","sha":"12f40ba39eee3c8758aa646126374e2791c790c8","user":{"login":"brianstien","id":1568220,"avatar_url":"https://avatars.githubusercontent.com/u/1568220?v=3","gravatar_id":"","url":"https://api.github.com/users/brianstien","html_url":"https://github.com/brianstien","followers_url":"https://api.github.com/users/brianstien/followers","following_url":"https://api.github.com/users/brianstien/following{/other_user}","gists_url":"https://api.github.com/users/brianstien/gists{/gist_id}","starred_url":"https://api.github.com/users/brianstien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianstien/subscriptions","organizations_url":"https://api.github.com/users/brianstien/orgs","repos_url":"https://api.github.com/users/brianstien/repos","events_url":"https://api.github.com/users/brianstien/events{/privacy}","received_events_url":"https://api.github.com/users/brianstien/received_events","type":"User","site_admin":false},"repo":{"id":19707655,"name":"active_remote","full_name":"brianstien/active_remote","owner":{"login":"brianstien","id":1568220,"avatar_url":"https://avatars.githubusercontent.com/u/1568220?v=3","gravatar_id":"","url":"https://api.github.com/users/brianstien","html_url":"https://github.com/brianstien","followers_url":"https://api.github.com/users/brianstien/followers","following_url":"https://api.github.com/users/brianstien/following{/other_user}","gists_url":"https://api.github.com/users/brianstien/gists{/gist_id}","starred_url":"https://api.github.com/users/brianstien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianstien/subscriptions","organizations_url":"https://api.github.com/users/brianstien/orgs","repos_url":"https://api.github.com/users/brianstien/repos","events_url":"https://api.github.com/users/brianstien/events{/privacy}","received_events_url":"https://api.github.com/users/brianstien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianstien/active_remote","description":"Active Remote provides Active Record-like object-relational mapping over RPC. It's Active Record for your platform.","fork":true,"url":"https://api.github.com/repos/brianstien/active_remote","forks_url":"https://api.github.com/repos/brianstien/active_remote/forks","keys_url":"https://api.github.com/repos/brianstien/active_remote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianstien/active_remote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianstien/active_remote/teams","hooks_url":"https://api.github.com/repos/brianstien/active_remote/hooks","issue_events_url":"https://api.github.com/repos/brianstien/active_remote/issues/events{/number}","events_url":"https://api.github.com/repos/brianstien/active_remote/events","assignees_url":"https://api.github.com/repos/brianstien/active_remote/assignees{/user}","branches_url":"https://api.github.com/repos/brianstien/active_remote/branches{/branch}","tags_url":"https://api.github.com/repos/brianstien/active_remote/tags","blobs_url":"https://api.github.com/repos/brianstien/active_remote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianstien/active_remote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianstien/active_remote/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianstien/active_remote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianstien/active_remote/statuses/{sha}","languages_url":"https://api.github.com/repos/brianstien/active_remote/languages","stargazers_url":"https://api.github.com/repos/brianstien/active_remote/stargazers","contributors_url":"https://api.github.com/repos/brianstien/active_remote/contributors","subscribers_url":"https://api.github.com/repos/brianstien/active_remote/subscribers","subscription_url":"https://api.github.com/repos/brianstien/active_remote/subscription","commits_url":"https://api.github.com/repos/brianstien/active_remote/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianstien/active_remote/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianstien/active_remote/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianstien/active_remote/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianstien/active_remote/contents/{+path}","compare_url":"https://api.github.com/repos/brianstien/active_remote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianstien/active_remote/merges","archive_url":"https://api.github.com/repos/brianstien/active_remote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianstien/active_remote/downloads","issues_url":"https://api.github.com/repos/brianstien/active_remote/issues{/number}","pulls_url":"https://api.github.com/repos/brianstien/active_remote/pulls{/number}","milestones_url":"https://api.github.com/repos/brianstien/active_remote/milestones{/number}","notifications_url":"https://api.github.com/repos/brianstien/active_remote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianstien/active_remote/labels{/name}","releases_url":"https://api.github.com/repos/brianstien/active_remote/releases{/id}","deployments_url":"https://api.github.com/repos/brianstien/active_remote/deployments","created_at":"2014-05-12T17:09:16Z","updated_at":"2016-06-08T17:21:36Z","pushed_at":"2016-06-16T21:51:10Z","git_url":"git://github.com/brianstien/active_remote.git","ssh_url":"git@github.com:brianstien/active_remote.git","clone_url":"https://github.com/brianstien/active_remote.git","svn_url":"https://github.com/brianstien/active_remote","homepage":null,"size":378,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"liveh2o:master","ref":"master","sha":"c4fe79874ee648e21695965ca441be0996b7e709","user":{"login":"liveh2o","id":207933,"avatar_url":"https://avatars.githubusercontent.com/u/207933?v=3","gravatar_id":"","url":"https://api.github.com/users/liveh2o","html_url":"https://github.com/liveh2o","followers_url":"https://api.github.com/users/liveh2o/followers","following_url":"https://api.github.com/users/liveh2o/following{/other_user}","gists_url":"https://api.github.com/users/liveh2o/gists{/gist_id}","starred_url":"https://api.github.com/users/liveh2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveh2o/subscriptions","organizations_url":"https://api.github.com/users/liveh2o/orgs","repos_url":"https://api.github.com/users/liveh2o/repos","events_url":"https://api.github.com/users/liveh2o/events{/privacy}","received_events_url":"https://api.github.com/users/liveh2o/received_events","type":"User","site_admin":false},"repo":{"id":6716431,"name":"active_remote","full_name":"liveh2o/active_remote","owner":{"login":"liveh2o","id":207933,"avatar_url":"https://avatars.githubusercontent.com/u/207933?v=3","gravatar_id":"","url":"https://api.github.com/users/liveh2o","html_url":"https://github.com/liveh2o","followers_url":"https://api.github.com/users/liveh2o/followers","following_url":"https://api.github.com/users/liveh2o/following{/other_user}","gists_url":"https://api.github.com/users/liveh2o/gists{/gist_id}","starred_url":"https://api.github.com/users/liveh2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveh2o/subscriptions","organizations_url":"https://api.github.com/users/liveh2o/orgs","repos_url":"https://api.github.com/users/liveh2o/repos","events_url":"https://api.github.com/users/liveh2o/events{/privacy}","received_events_url":"https://api.github.com/users/liveh2o/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liveh2o/active_remote","description":"Active Remote provides Active Record-like object-relational mapping over RPC. It's Active Record for your platform.","fork":false,"url":"https://api.github.com/repos/liveh2o/active_remote","forks_url":"https://api.github.com/repos/liveh2o/active_remote/forks","keys_url":"https://api.github.com/repos/liveh2o/active_remote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liveh2o/active_remote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liveh2o/active_remote/teams","hooks_url":"https://api.github.com/repos/liveh2o/active_remote/hooks","issue_events_url":"https://api.github.com/repos/liveh2o/active_remote/issues/events{/number}","events_url":"https://api.github.com/repos/liveh2o/active_remote/events","assignees_url":"https://api.github.com/repos/liveh2o/active_remote/assignees{/user}","branches_url":"https://api.github.com/repos/liveh2o/active_remote/branches{/branch}","tags_url":"https://api.github.com/repos/liveh2o/active_remote/tags","blobs_url":"https://api.github.com/repos/liveh2o/active_remote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liveh2o/active_remote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liveh2o/active_remote/git/refs{/sha}","trees_url":"https://api.github.com/repos/liveh2o/active_remote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liveh2o/active_remote/statuses/{sha}","languages_url":"https://api.github.com/repos/liveh2o/active_remote/languages","stargazers_url":"https://api.github.com/repos/liveh2o/active_remote/stargazers","contributors_url":"https://api.github.com/repos/liveh2o/active_remote/contributors","subscribers_url":"https://api.github.com/repos/liveh2o/active_remote/subscribers","subscription_url":"https://api.github.com/repos/liveh2o/active_remote/subscription","commits_url":"https://api.github.com/repos/liveh2o/active_remote/commits{/sha}","git_commits_url":"https://api.github.com/repos/liveh2o/active_remote/git/commits{/sha}","comments_url":"https://api.github.com/repos/liveh2o/active_remote/comments{/number}","issue_comment_url":"https://api.github.com/repos/liveh2o/active_remote/issues/comments{/number}","contents_url":"https://api.github.com/repos/liveh2o/active_remote/contents/{+path}","compare_url":"https://api.github.com/repos/liveh2o/active_remote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liveh2o/active_remote/merges","archive_url":"https://api.github.com/repos/liveh2o/active_remote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liveh2o/active_remote/downloads","issues_url":"https://api.github.com/repos/liveh2o/active_remote/issues{/number}","pulls_url":"https://api.github.com/repos/liveh2o/active_remote/pulls{/number}","milestones_url":"https://api.github.com/repos/liveh2o/active_remote/milestones{/number}","notifications_url":"https://api.github.com/repos/liveh2o/active_remote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liveh2o/active_remote/labels{/name}","releases_url":"https://api.github.com/repos/liveh2o/active_remote/releases{/id}","deployments_url":"https://api.github.com/repos/liveh2o/active_remote/deployments","created_at":"2012-11-16T04:34:45Z","updated_at":"2016-06-15T13:47:21Z","pushed_at":"2016-06-16T21:59:08Z","git_url":"git://github.com/liveh2o/active_remote.git","ssh_url":"git@github.com:liveh2o/active_remote.git","clone_url":"https://github.com/liveh2o/active_remote.git","svn_url":"https://github.com/liveh2o/active_remote","homepage":null,"size":372,"stargazers_count":20,"watchers_count":20,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/43"},"html":{"href":"https://github.com/liveh2o/active_remote/pull/43"},"issue":{"href":"https://api.github.com/repos/liveh2o/active_remote/issues/43"},"comments":{"href":"https://api.github.com/repos/liveh2o/active_remote/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/liveh2o/active_remote/statuses/12f40ba39eee3c8758aa646126374e2791c790c8"}}}}
{"actor":{"display_login":"liveh2o"}}