{"action":"created","comment":{"url":"https://api.github.com/repos/EconomicSL/agora/pulls/comments/87731233","pull_request_review_id":8330921,"id":87731233,"diff_hunk":"@@ -41,11 +41,11 @@ class FindFirstMatchingFunctionSpec extends FeatureSpec with Matchers with Order\n     scenario(\"Given an orderBook with no acceptable orders, FindFirstMatchingFunction should return None.\") {\n \n       val orderBook = OrderBook[LimitAskOrder](tradable)\n-      val askPrice = 15\n+      val askPrice = Price(15)\n       val askOrder = orderGenerator.nextLimitAskOrder(askPrice, None, tradable)\n       orderBook.add(askOrder)\n \n-      val bidPrice = 10\n+      val bidPrice = Price(10)","path":"src/test/scala/org/economicsl/agora/markets/auctions/matching/FindFirstMatchingFunctionSpec.scala","position":19,"original_position":19,"commit_id":"d0f6947c00ffa6210a3ef55f1a242f8670b28d94","original_commit_id":"d0f6947c00ffa6210a3ef55f1a242f8670b28d94","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Magic Number](https://www.codacy.com/app/davidrpugh/agora/file/4431205665/issues/source?bid=2921361&fileBranchId=3905173#l48)","created_at":"2016-11-14T02:23:46Z","updated_at":"2016-11-14T02:23:46Z","html_url":"https://github.com/EconomicSL/agora/pull/228#discussion_r87731233","pull_request_url":"https://api.github.com/repos/EconomicSL/agora/pulls/228","_links":{"self":{"href":"https://api.github.com/repos/EconomicSL/agora/pulls/comments/87731233"},"html":{"href":"https://github.com/EconomicSL/agora/pull/228#discussion_r87731233"},"pull_request":{"href":"https://api.github.com/repos/EconomicSL/agora/pulls/228"}}},"pull_request":{"url":"https://api.github.com/repos/EconomicSL/agora/pulls/228","id":93498513,"html_url":"https://github.com/EconomicSL/agora/pull/228","diff_url":"https://github.com/EconomicSL/agora/pull/228.diff","patch_url":"https://github.com/EconomicSL/agora/pull/228.patch","issue_url":"https://api.github.com/repos/EconomicSL/agora/issues/228","number":228,"state":"open","locked":false,"title":"Add price value class","user":{"login":"davidrpugh","id":2219562,"avatar_url":"https://avatars.githubusercontent.com/u/2219562?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrpugh","html_url":"https://github.com/davidrpugh","followers_url":"https://api.github.com/users/davidrpugh/followers","following_url":"https://api.github.com/users/davidrpugh/following{/other_user}","gists_url":"https://api.github.com/users/davidrpugh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrpugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrpugh/subscriptions","organizations_url":"https://api.github.com/users/davidrpugh/orgs","repos_url":"https://api.github.com/users/davidrpugh/repos","events_url":"https://api.github.com/users/davidrpugh/events{/privacy}","received_events_url":"https://api.github.com/users/davidrpugh/received_events","type":"User","site_admin":false},"body":"Price value class will allow us to do useful things with prices...","created_at":"2016-11-14T02:06:00Z","updated_at":"2016-11-14T02:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"080d2ed910d0297641bdfdaf6f94f56e7bdec461","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/EconomicSL/agora/pulls/228/commits","review_comments_url":"https://api.github.com/repos/EconomicSL/agora/pulls/228/comments","review_comment_url":"https://api.github.com/repos/EconomicSL/agora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EconomicSL/agora/issues/228/comments","statuses_url":"https://api.github.com/repos/EconomicSL/agora/statuses/d0f6947c00ffa6210a3ef55f1a242f8670b28d94","head":{"label":"EconomicSL:add-price-value-class","ref":"add-price-value-class","sha":"d0f6947c00ffa6210a3ef55f1a242f8670b28d94","user":{"login":"EconomicSL","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/EconomicSL","html_url":"https://github.com/EconomicSL","followers_url":"https://api.github.com/users/EconomicSL/followers","following_url":"https://api.github.com/users/EconomicSL/following{/other_user}","gists_url":"https://api.github.com/users/EconomicSL/gists{/gist_id}","starred_url":"https://api.github.com/users/EconomicSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EconomicSL/subscriptions","organizations_url":"https://api.github.com/users/EconomicSL/orgs","repos_url":"https://api.github.com/users/EconomicSL/repos","events_url":"https://api.github.com/users/EconomicSL/events{/privacy}","received_events_url":"https://api.github.com/users/EconomicSL/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"agora","full_name":"EconomicSL/agora","owner":{"login":"EconomicSL","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/EconomicSL","html_url":"https://github.com/EconomicSL","followers_url":"https://api.github.com/users/EconomicSL/followers","following_url":"https://api.github.com/users/EconomicSL/following{/other_user}","gists_url":"https://api.github.com/users/EconomicSL/gists{/gist_id}","starred_url":"https://api.github.com/users/EconomicSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EconomicSL/subscriptions","organizations_url":"https://api.github.com/users/EconomicSL/orgs","repos_url":"https://api.github.com/users/EconomicSL/repos","events_url":"https://api.github.com/users/EconomicSL/events{/privacy}","received_events_url":"https://api.github.com/users/EconomicSL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EconomicSL/agora","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/EconomicSL/agora","forks_url":"https://api.github.com/repos/EconomicSL/agora/forks","keys_url":"https://api.github.com/repos/EconomicSL/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EconomicSL/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EconomicSL/agora/teams","hooks_url":"https://api.github.com/repos/EconomicSL/agora/hooks","issue_events_url":"https://api.github.com/repos/EconomicSL/agora/issues/events{/number}","events_url":"https://api.github.com/repos/EconomicSL/agora/events","assignees_url":"https://api.github.com/repos/EconomicSL/agora/assignees{/user}","branches_url":"https://api.github.com/repos/EconomicSL/agora/branches{/branch}","tags_url":"https://api.github.com/repos/EconomicSL/agora/tags","blobs_url":"https://api.github.com/repos/EconomicSL/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EconomicSL/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EconomicSL/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/EconomicSL/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EconomicSL/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/EconomicSL/agora/languages","stargazers_url":"https://api.github.com/repos/EconomicSL/agora/stargazers","contributors_url":"https://api.github.com/repos/EconomicSL/agora/contributors","subscribers_url":"https://api.github.com/repos/EconomicSL/agora/subscribers","subscription_url":"https://api.github.com/repos/EconomicSL/agora/subscription","commits_url":"https://api.github.com/repos/EconomicSL/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/EconomicSL/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/EconomicSL/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/EconomicSL/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/EconomicSL/agora/contents/{+path}","compare_url":"https://api.github.com/repos/EconomicSL/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EconomicSL/agora/merges","archive_url":"https://api.github.com/repos/EconomicSL/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EconomicSL/agora/downloads","issues_url":"https://api.github.com/repos/EconomicSL/agora/issues{/number}","pulls_url":"https://api.github.com/repos/EconomicSL/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/EconomicSL/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/EconomicSL/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EconomicSL/agora/labels{/name}","releases_url":"https://api.github.com/repos/EconomicSL/agora/releases{/id}","deployments_url":"https://api.github.com/repos/EconomicSL/agora/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-09-15T15:30:59Z","pushed_at":"2016-11-14T02:21:14Z","git_url":"git://github.com/EconomicSL/agora.git","ssh_url":"git@github.com:EconomicSL/agora.git","clone_url":"https://github.com/EconomicSL/agora.git","svn_url":"https://github.com/EconomicSL/agora","homepage":null,"size":1613,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":21,"forks":2,"open_issues":21,"watchers":1,"default_branch":"master"}},"base":{"label":"EconomicSL:develop","ref":"develop","sha":"7aa1987dea761f16d27c2edd863aee9df8f7db03","user":{"login":"EconomicSL","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/EconomicSL","html_url":"https://github.com/EconomicSL","followers_url":"https://api.github.com/users/EconomicSL/followers","following_url":"https://api.github.com/users/EconomicSL/following{/other_user}","gists_url":"https://api.github.com/users/EconomicSL/gists{/gist_id}","starred_url":"https://api.github.com/users/EconomicSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EconomicSL/subscriptions","organizations_url":"https://api.github.com/users/EconomicSL/orgs","repos_url":"https://api.github.com/users/EconomicSL/repos","events_url":"https://api.github.com/users/EconomicSL/events{/privacy}","received_events_url":"https://api.github.com/users/EconomicSL/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"agora","full_name":"EconomicSL/agora","owner":{"login":"EconomicSL","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/EconomicSL","html_url":"https://github.com/EconomicSL","followers_url":"https://api.github.com/users/EconomicSL/followers","following_url":"https://api.github.com/users/EconomicSL/following{/other_user}","gists_url":"https://api.github.com/users/EconomicSL/gists{/gist_id}","starred_url":"https://api.github.com/users/EconomicSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EconomicSL/subscriptions","organizations_url":"https://api.github.com/users/EconomicSL/orgs","repos_url":"https://api.github.com/users/EconomicSL/repos","events_url":"https://api.github.com/users/EconomicSL/events{/privacy}","received_events_url":"https://api.github.com/users/EconomicSL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EconomicSL/agora","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/EconomicSL/agora","forks_url":"https://api.github.com/repos/EconomicSL/agora/forks","keys_url":"https://api.github.com/repos/EconomicSL/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EconomicSL/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EconomicSL/agora/teams","hooks_url":"https://api.github.com/repos/EconomicSL/agora/hooks","issue_events_url":"https://api.github.com/repos/EconomicSL/agora/issues/events{/number}","events_url":"https://api.github.com/repos/EconomicSL/agora/events","assignees_url":"https://api.github.com/repos/EconomicSL/agora/assignees{/user}","branches_url":"https://api.github.com/repos/EconomicSL/agora/branches{/branch}","tags_url":"https://api.github.com/repos/EconomicSL/agora/tags","blobs_url":"https://api.github.com/repos/EconomicSL/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EconomicSL/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EconomicSL/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/EconomicSL/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EconomicSL/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/EconomicSL/agora/languages","stargazers_url":"https://api.github.com/repos/EconomicSL/agora/stargazers","contributors_url":"https://api.github.com/repos/EconomicSL/agora/contributors","subscribers_url":"https://api.github.com/repos/EconomicSL/agora/subscribers","subscription_url":"https://api.github.com/repos/EconomicSL/agora/subscription","commits_url":"https://api.github.com/repos/EconomicSL/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/EconomicSL/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/EconomicSL/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/EconomicSL/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/EconomicSL/agora/contents/{+path}","compare_url":"https://api.github.com/repos/EconomicSL/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EconomicSL/agora/merges","archive_url":"https://api.github.com/repos/EconomicSL/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EconomicSL/agora/downloads","issues_url":"https://api.github.com/repos/EconomicSL/agora/issues{/number}","pulls_url":"https://api.github.com/repos/EconomicSL/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/EconomicSL/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/EconomicSL/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EconomicSL/agora/labels{/name}","releases_url":"https://api.github.com/repos/EconomicSL/agora/releases{/id}","deployments_url":"https://api.github.com/repos/EconomicSL/agora/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-09-15T15:30:59Z","pushed_at":"2016-11-14T02:21:14Z","git_url":"git://github.com/EconomicSL/agora.git","ssh_url":"git@github.com:EconomicSL/agora.git","clone_url":"https://github.com/EconomicSL/agora.git","svn_url":"https://github.com/EconomicSL/agora","homepage":null,"size":1613,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":21,"forks":2,"open_issues":21,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EconomicSL/agora/pulls/228"},"html":{"href":"https://github.com/EconomicSL/agora/pull/228"},"issue":{"href":"https://api.github.com/repos/EconomicSL/agora/issues/228"},"comments":{"href":"https://api.github.com/repos/EconomicSL/agora/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/EconomicSL/agora/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/EconomicSL/agora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EconomicSL/agora/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/EconomicSL/agora/statuses/d0f6947c00ffa6210a3ef55f1a242f8670b28d94"}}}}
{"actor":{"display_login":"codacy-bot"}}