{"action":"created","comment":{"url":"https://api.github.com/repos/nick8325/quickcheck/pulls/comments/82842235","pull_request_review_id":3720889,"id":82842235,"diff_hunk":"@@ -343,4 +355,100 @@ instance (Arbitrary a, ShrinkState s a) => Arbitrary (Shrinking s a) where\n #endif /* NO_MULTI_PARAM_TYPE_CLASSES */\n \n --------------------------------------------------------------------------\n+-- | @ASCII@.\n+newtype ASCII = ASCII {getASCII :: Char}\n+  deriving ( Eq, Ord, Show, Read )\n+\n+asciiGen :: Gen Char\n+asciiGen = choose ('\\0', '\\127')\n+\n+instance Arbitrary ASCII where\n+  arbitrary = ASCII `fmap` asciiGen\n+\n+--------------------------------------------------------------------------\n+-- | @Latin1@: latin1 Char, same Arbitrary as Char itself.\n+newtype Latin1 = Latin1 {getLatin1 :: Char}\n+  deriving ( Eq, Ord, Show, Read )\n+\n+instance Arbitrary Latin1 where\n+  arbitrary = Latin1 `fmap` arbitrary\n+  shrink (Latin1 c) = Latin1 `fmap` shrink c\n+\n+--------------------------------------------------------------------------\n+-- | @Unicode@: yields unicode Char.\n+newtype Unicode = Unicode {getUnicode :: Char}\n+  deriving ( Eq, Ord, Show, Read )\n+\n+unicodeGen' :: Gen Char\n+unicodeGen' = oneof [choose (minBound, '\\55296'), -- Skip high and low surrogates\n+                     choose ('\\57344', maxBound)]\n+","path":"Test/QuickCheck/Modifiers.hs","position":57,"original_position":57,"commit_id":"a93826af4e33d33275b0e617cc9c5c3ae6aaf1ec","original_commit_id":"a93826af4e33d33275b0e617cc9c5c3ae6aaf1ec","user":{"login":"berdario","id":752835,"avatar_url":"https://avatars.githubusercontent.com/u/752835?v=3","gravatar_id":"","url":"https://api.github.com/users/berdario","html_url":"https://github.com/berdario","followers_url":"https://api.github.com/users/berdario/followers","following_url":"https://api.github.com/users/berdario/following{/other_user}","gists_url":"https://api.github.com/users/berdario/gists{/gist_id}","starred_url":"https://api.github.com/users/berdario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berdario/subscriptions","organizations_url":"https://api.github.com/users/berdario/orgs","repos_url":"https://api.github.com/users/berdario/repos","events_url":"https://api.github.com/users/berdario/events{/privacy}","received_events_url":"https://api.github.com/users/berdario/received_events","type":"User","site_admin":false},"body":"I just realized... distribution of values here might be skewed...\r\nshould I rather go with `suchThat` instead of `oneof`?","created_at":"2016-10-11T17:11:58Z","updated_at":"2016-10-11T17:11:58Z","html_url":"https://github.com/nick8325/quickcheck/pull/119#discussion_r82842235","pull_request_url":"https://api.github.com/repos/nick8325/quickcheck/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/nick8325/quickcheck/pulls/comments/82842235"},"html":{"href":"https://github.com/nick8325/quickcheck/pull/119#discussion_r82842235"},"pull_request":{"href":"https://api.github.com/repos/nick8325/quickcheck/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/nick8325/quickcheck/pulls/119","id":88546080,"html_url":"https://github.com/nick8325/quickcheck/pull/119","diff_url":"https://github.com/nick8325/quickcheck/pull/119.diff","patch_url":"https://github.com/nick8325/quickcheck/pull/119.patch","issue_url":"https://api.github.com/repos/nick8325/quickcheck/issues/119","number":119,"state":"open","locked":false,"title":"Add newtype modifiers for Arbitrary String/Char instances that take into account Unicode","user":{"login":"berdario","id":752835,"avatar_url":"https://avatars.githubusercontent.com/u/752835?v=3","gravatar_id":"","url":"https://api.github.com/users/berdario","html_url":"https://github.com/berdario","followers_url":"https://api.github.com/users/berdario/followers","following_url":"https://api.github.com/users/berdario/following{/other_user}","gists_url":"https://api.github.com/users/berdario/gists{/gist_id}","starred_url":"https://api.github.com/users/berdario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berdario/subscriptions","organizations_url":"https://api.github.com/users/berdario/orgs","repos_url":"https://api.github.com/users/berdario/repos","events_url":"https://api.github.com/users/berdario/events{/privacy}","received_events_url":"https://api.github.com/users/berdario/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-10-08T13:33:23Z","updated_at":"2016-10-11T17:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c173245e3fc8983c3925573ab7543543351ba10","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nick8325/quickcheck/pulls/119/commits","review_comments_url":"https://api.github.com/repos/nick8325/quickcheck/pulls/119/comments","review_comment_url":"https://api.github.com/repos/nick8325/quickcheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nick8325/quickcheck/issues/119/comments","statuses_url":"https://api.github.com/repos/nick8325/quickcheck/statuses/a93826af4e33d33275b0e617cc9c5c3ae6aaf1ec","head":{"label":"berdario:master","ref":"master","sha":"a93826af4e33d33275b0e617cc9c5c3ae6aaf1ec","user":{"login":"berdario","id":752835,"avatar_url":"https://avatars.githubusercontent.com/u/752835?v=3","gravatar_id":"","url":"https://api.github.com/users/berdario","html_url":"https://github.com/berdario","followers_url":"https://api.github.com/users/berdario/followers","following_url":"https://api.github.com/users/berdario/following{/other_user}","gists_url":"https://api.github.com/users/berdario/gists{/gist_id}","starred_url":"https://api.github.com/users/berdario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berdario/subscriptions","organizations_url":"https://api.github.com/users/berdario/orgs","repos_url":"https://api.github.com/users/berdario/repos","events_url":"https://api.github.com/users/berdario/events{/privacy}","received_events_url":"https://api.github.com/users/berdario/received_events","type":"User","site_admin":false},"repo":{"id":70333198,"name":"quickcheck","full_name":"berdario/quickcheck","owner":{"login":"berdario","id":752835,"avatar_url":"https://avatars.githubusercontent.com/u/752835?v=3","gravatar_id":"","url":"https://api.github.com/users/berdario","html_url":"https://github.com/berdario","followers_url":"https://api.github.com/users/berdario/followers","following_url":"https://api.github.com/users/berdario/following{/other_user}","gists_url":"https://api.github.com/users/berdario/gists{/gist_id}","starred_url":"https://api.github.com/users/berdario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berdario/subscriptions","organizations_url":"https://api.github.com/users/berdario/orgs","repos_url":"https://api.github.com/users/berdario/repos","events_url":"https://api.github.com/users/berdario/events{/privacy}","received_events_url":"https://api.github.com/users/berdario/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/berdario/quickcheck","description":"Automatic testing of Haskell programs.","fork":true,"url":"https://api.github.com/repos/berdario/quickcheck","forks_url":"https://api.github.com/repos/berdario/quickcheck/forks","keys_url":"https://api.github.com/repos/berdario/quickcheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/berdario/quickcheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/berdario/quickcheck/teams","hooks_url":"https://api.github.com/repos/berdario/quickcheck/hooks","issue_events_url":"https://api.github.com/repos/berdario/quickcheck/issues/events{/number}","events_url":"https://api.github.com/repos/berdario/quickcheck/events","assignees_url":"https://api.github.com/repos/berdario/quickcheck/assignees{/user}","branches_url":"https://api.github.com/repos/berdario/quickcheck/branches{/branch}","tags_url":"https://api.github.com/repos/berdario/quickcheck/tags","blobs_url":"https://api.github.com/repos/berdario/quickcheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/berdario/quickcheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/berdario/quickcheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/berdario/quickcheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/berdario/quickcheck/statuses/{sha}","languages_url":"https://api.github.com/repos/berdario/quickcheck/languages","stargazers_url":"https://api.github.com/repos/berdario/quickcheck/stargazers","contributors_url":"https://api.github.com/repos/berdario/quickcheck/contributors","subscribers_url":"https://api.github.com/repos/berdario/quickcheck/subscribers","subscription_url":"https://api.github.com/repos/berdario/quickcheck/subscription","commits_url":"https://api.github.com/repos/berdario/quickcheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/berdario/quickcheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/berdario/quickcheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/berdario/quickcheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/berdario/quickcheck/contents/{+path}","compare_url":"https://api.github.com/repos/berdario/quickcheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/berdario/quickcheck/merges","archive_url":"https://api.github.com/repos/berdario/quickcheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/berdario/quickcheck/downloads","issues_url":"https://api.github.com/repos/berdario/quickcheck/issues{/number}","pulls_url":"https://api.github.com/repos/berdario/quickcheck/pulls{/number}","milestones_url":"https://api.github.com/repos/berdario/quickcheck/milestones{/number}","notifications_url":"https://api.github.com/repos/berdario/quickcheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/berdario/quickcheck/labels{/name}","releases_url":"https://api.github.com/repos/berdario/quickcheck/releases{/id}","deployments_url":"https://api.github.com/repos/berdario/quickcheck/deployments","created_at":"2016-10-08T13:33:03Z","updated_at":"2016-10-08T13:33:04Z","pushed_at":"2016-10-08T15:48:22Z","git_url":"git://github.com/berdario/quickcheck.git","ssh_url":"git@github.com:berdario/quickcheck.git","clone_url":"https://github.com/berdario/quickcheck.git","svn_url":"https://github.com/berdario/quickcheck","homepage":"","size":601,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nick8325:master","ref":"master","sha":"ec11a4a0a5602045ad4b15dab868db4072a574fa","user":{"login":"nick8325","id":104447,"avatar_url":"https://avatars.githubusercontent.com/u/104447?v=3","gravatar_id":"","url":"https://api.github.com/users/nick8325","html_url":"https://github.com/nick8325","followers_url":"https://api.github.com/users/nick8325/followers","following_url":"https://api.github.com/users/nick8325/following{/other_user}","gists_url":"https://api.github.com/users/nick8325/gists{/gist_id}","starred_url":"https://api.github.com/users/nick8325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick8325/subscriptions","organizations_url":"https://api.github.com/users/nick8325/orgs","repos_url":"https://api.github.com/users/nick8325/repos","events_url":"https://api.github.com/users/nick8325/events{/privacy}","received_events_url":"https://api.github.com/users/nick8325/received_events","type":"User","site_admin":false},"repo":{"id":5218355,"name":"quickcheck","full_name":"nick8325/quickcheck","owner":{"login":"nick8325","id":104447,"avatar_url":"https://avatars.githubusercontent.com/u/104447?v=3","gravatar_id":"","url":"https://api.github.com/users/nick8325","html_url":"https://github.com/nick8325","followers_url":"https://api.github.com/users/nick8325/followers","following_url":"https://api.github.com/users/nick8325/following{/other_user}","gists_url":"https://api.github.com/users/nick8325/gists{/gist_id}","starred_url":"https://api.github.com/users/nick8325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick8325/subscriptions","organizations_url":"https://api.github.com/users/nick8325/orgs","repos_url":"https://api.github.com/users/nick8325/repos","events_url":"https://api.github.com/users/nick8325/events{/privacy}","received_events_url":"https://api.github.com/users/nick8325/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nick8325/quickcheck","description":"Automatic testing of Haskell programs.","fork":false,"url":"https://api.github.com/repos/nick8325/quickcheck","forks_url":"https://api.github.com/repos/nick8325/quickcheck/forks","keys_url":"https://api.github.com/repos/nick8325/quickcheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nick8325/quickcheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nick8325/quickcheck/teams","hooks_url":"https://api.github.com/repos/nick8325/quickcheck/hooks","issue_events_url":"https://api.github.com/repos/nick8325/quickcheck/issues/events{/number}","events_url":"https://api.github.com/repos/nick8325/quickcheck/events","assignees_url":"https://api.github.com/repos/nick8325/quickcheck/assignees{/user}","branches_url":"https://api.github.com/repos/nick8325/quickcheck/branches{/branch}","tags_url":"https://api.github.com/repos/nick8325/quickcheck/tags","blobs_url":"https://api.github.com/repos/nick8325/quickcheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nick8325/quickcheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nick8325/quickcheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/nick8325/quickcheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nick8325/quickcheck/statuses/{sha}","languages_url":"https://api.github.com/repos/nick8325/quickcheck/languages","stargazers_url":"https://api.github.com/repos/nick8325/quickcheck/stargazers","contributors_url":"https://api.github.com/repos/nick8325/quickcheck/contributors","subscribers_url":"https://api.github.com/repos/nick8325/quickcheck/subscribers","subscription_url":"https://api.github.com/repos/nick8325/quickcheck/subscription","commits_url":"https://api.github.com/repos/nick8325/quickcheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/nick8325/quickcheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/nick8325/quickcheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/nick8325/quickcheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/nick8325/quickcheck/contents/{+path}","compare_url":"https://api.github.com/repos/nick8325/quickcheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nick8325/quickcheck/merges","archive_url":"https://api.github.com/repos/nick8325/quickcheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nick8325/quickcheck/downloads","issues_url":"https://api.github.com/repos/nick8325/quickcheck/issues{/number}","pulls_url":"https://api.github.com/repos/nick8325/quickcheck/pulls{/number}","milestones_url":"https://api.github.com/repos/nick8325/quickcheck/milestones{/number}","notifications_url":"https://api.github.com/repos/nick8325/quickcheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nick8325/quickcheck/labels{/name}","releases_url":"https://api.github.com/repos/nick8325/quickcheck/releases{/id}","deployments_url":"https://api.github.com/repos/nick8325/quickcheck/deployments","created_at":"2012-07-28T22:50:15Z","updated_at":"2016-10-09T10:10:33Z","pushed_at":"2016-10-09T10:01:34Z","git_url":"git://github.com/nick8325/quickcheck.git","ssh_url":"git@github.com:nick8325/quickcheck.git","clone_url":"https://github.com/nick8325/quickcheck.git","svn_url":"https://github.com/nick8325/quickcheck","homepage":"","size":1024,"stargazers_count":226,"watchers_count":226,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":26,"forks":46,"open_issues":26,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nick8325/quickcheck/pulls/119"},"html":{"href":"https://github.com/nick8325/quickcheck/pull/119"},"issue":{"href":"https://api.github.com/repos/nick8325/quickcheck/issues/119"},"comments":{"href":"https://api.github.com/repos/nick8325/quickcheck/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/nick8325/quickcheck/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/nick8325/quickcheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nick8325/quickcheck/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/nick8325/quickcheck/statuses/a93826af4e33d33275b0e617cc9c5c3ae6aaf1ec"}}}}
{"actor":{"display_login":"berdario"}}