{"action":"created","issue":{"url":"https://api.github.com/repos/elkarte/Elkarte/issues/2549","repository_url":"https://api.github.com/repos/elkarte/Elkarte","labels_url":"https://api.github.com/repos/elkarte/Elkarte/issues/2549/labels{/name}","comments_url":"https://api.github.com/repos/elkarte/Elkarte/issues/2549/comments","events_url":"https://api.github.com/repos/elkarte/Elkarte/issues/2549/events","html_url":"https://github.com/elkarte/Elkarte/pull/2549","id":156124518,"number":2549,"title":"Do not merge, just for feedback","user":{"login":"Spuds","id":1181042,"avatar_url":"https://avatars.githubusercontent.com/u/1181042?v=3","gravatar_id":"","url":"https://api.github.com/users/Spuds","html_url":"https://github.com/Spuds","followers_url":"https://api.github.com/users/Spuds/followers","following_url":"https://api.github.com/users/Spuds/following{/other_user}","gists_url":"https://api.github.com/users/Spuds/gists{/gist_id}","starred_url":"https://api.github.com/users/Spuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spuds/subscriptions","organizations_url":"https://api.github.com/users/Spuds/orgs","repos_url":"https://api.github.com/users/Spuds/repos","events_url":"https://api.github.com/users/Spuds/events{/privacy}","received_events_url":"https://api.github.com/users/Spuds/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elkarte/Elkarte/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/elkarte/Elkarte/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/elkarte/Elkarte/milestones/4","html_url":"https://github.com/elkarte/Elkarte/milestones/1.1%20Beta%201","labels_url":"https://api.github.com/repos/elkarte/Elkarte/milestones/4/labels","id":447100,"number":4,"title":"1.1 Beta 1","description":"","creator":{"login":"eurich","id":1027992,"avatar_url":"https://avatars.githubusercontent.com/u/1027992?v=3","gravatar_id":"","url":"https://api.github.com/users/eurich","html_url":"https://github.com/eurich","followers_url":"https://api.github.com/users/eurich/followers","following_url":"https://api.github.com/users/eurich/following{/other_user}","gists_url":"https://api.github.com/users/eurich/gists{/gist_id}","starred_url":"https://api.github.com/users/eurich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurich/subscriptions","organizations_url":"https://api.github.com/users/eurich/orgs","repos_url":"https://api.github.com/users/eurich/repos","events_url":"https://api.github.com/users/eurich/events{/privacy}","received_events_url":"https://api.github.com/users/eurich/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":336,"state":"open","created_at":"2013-10-07T08:37:11Z","updated_at":"2016-05-23T01:11:46Z","due_on":"2015-09-06T22:00:00Z","closed_at":null},"comments":7,"created_at":"2016-05-21T22:27:08Z","updated_at":"2016-05-23T14:11:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549","html_url":"https://github.com/elkarte/Elkarte/pull/2549","diff_url":"https://github.com/elkarte/Elkarte/pull/2549.diff","patch_url":"https://github.com/elkarte/Elkarte/pull/2549.patch"},"body":"Ignore the minor things in the PR and look at \r\n\r\nhttps://github.com/elkarte/Elkarte/commit/f989f89b10c4393b5f05db49b22aec68fafd3705\r\nhttps://github.com/elkarte/Elkarte/commit/950d85fdb157ea4a029c87abd280434c4b91df7a\r\nhttps://github.com/elkarte/Elkarte/commit/f72e92f746ae6b914d2e7101d9b4691ad2c854ce\r\nhttps://github.com/elkarte/Elkarte/commit/fa3c224329f0eb7d301301a92cea0a6b266a2a57\r\n\r\nThis is moving the profile Buddies tab to be ajax.   Have not looked at \"recent\" tab yet but that would be next. \r\n\r\nTo make this work UI tabs allows us to specify an href value to load ajax html into a tab when its activated.  Given the way tabs work, it has to be HTML and not XML data (its called to late in the stack to effect the ajax settings).  So is kind of \"ugly\" having the action inside of xml.controller since it does not return XML.  You could use the tab load event to trigger a AJAX / XML event and then build the values but that IMO gets super ugly in the JS, at least any way I could see this working.\r\n\r\nHad to do a minor refactor of ProfileInfo.controller so that one could call the buddies function from the xml controller (or anywhere), as to much user context was built inside of the main method. So this just broke it up in to small methods so one can call the needed methods to get things rolling.\r\n\r\nSo take a look, give me thoughts on if we should proceed or make change or leave things as they were."},"comment":{"url":"https://api.github.com/repos/elkarte/Elkarte/issues/comments/220991378","html_url":"https://github.com/elkarte/Elkarte/pull/2549#issuecomment-220991378","issue_url":"https://api.github.com/repos/elkarte/Elkarte/issues/2549","id":220991378,"user":{"login":"Spuds","id":1181042,"avatar_url":"https://avatars.githubusercontent.com/u/1181042?v=3","gravatar_id":"","url":"https://api.github.com/users/Spuds","html_url":"https://github.com/Spuds","followers_url":"https://api.github.com/users/Spuds/followers","following_url":"https://api.github.com/users/Spuds/following{/other_user}","gists_url":"https://api.github.com/users/Spuds/gists{/gist_id}","starred_url":"https://api.github.com/users/Spuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spuds/subscriptions","organizations_url":"https://api.github.com/users/Spuds/orgs","repos_url":"https://api.github.com/users/Spuds/repos","events_url":"https://api.github.com/users/Spuds/events{/privacy}","received_events_url":"https://api.github.com/users/Spuds/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T14:11:21Z","updated_at":"2016-05-23T14:11:21Z","body":"Did that work? \r\n\r\nI'll certainly give it a try but I thought ;xml would output an xml header.  The jquery ajax object while available in the tabs widget, has been mostly processed (type set, data set, etc) so you can't tell it that its XML data, nor would I want to write the code to process all of that array data anyway."}}
{"actor":{"display_login":"Spuds"}}