{"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3/pulls/comments/49977146","id":49977146,"diff_hunk":"@@ -7,6 +8,11 @@\n from .variable import *\n import numpy as np\n \n+from Orange.util import deprecated\n+\n+\n+log = logging.getLogger()","path":"Orange/data/domain.py","position":12,"original_position":12,"commit_id":"f5f33b1309800a9ce607d6d8f27daa89d9a305e5","original_commit_id":"f5f33b1309800a9ce607d6d8f27daa89d9a305e5","user":{"login":"astaric","id":588601,"avatar_url":"https://avatars.githubusercontent.com/u/588601?v=3","gravatar_id":"","url":"https://api.github.com/users/astaric","html_url":"https://github.com/astaric","followers_url":"https://api.github.com/users/astaric/followers","following_url":"https://api.github.com/users/astaric/following{/other_user}","gists_url":"https://api.github.com/users/astaric/gists{/gist_id}","starred_url":"https://api.github.com/users/astaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaric/subscriptions","organizations_url":"https://api.github.com/users/astaric/orgs","repos_url":"https://api.github.com/users/astaric/repos","events_url":"https://api.github.com/users/astaric/events{/privacy}","received_events_url":"https://api.github.com/users/astaric/received_events","type":"User","site_admin":false},"body":"This shadows\r\nfrom math import log\r\nabove (causing many failing tests)","created_at":"2016-01-18T09:41:28Z","updated_at":"2016-01-18T09:41:28Z","html_url":"https://github.com/biolab/orange3/pull/978#discussion_r49977146","pull_request_url":"https://api.github.com/repos/biolab/orange3/pulls/978","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/49977146"},"html":{"href":"https://github.com/biolab/orange3/pull/978#discussion_r49977146"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3/pulls/978"}}},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/978","id":56177412,"html_url":"https://github.com/biolab/orange3/pull/978","diff_url":"https://github.com/biolab/orange3/pull/978.diff","patch_url":"https://github.com/biolab/orange3/pull/978.patch","issue_url":"https://api.github.com/repos/biolab/orange3/issues/978","number":978,"state":"open","locked":false,"title":"[WIP] Orange.data.Domain: reworked iterating, indexing, member access","user":{"login":"kernc","id":684364,"avatar_url":"https://avatars.githubusercontent.com/u/684364?v=3","gravatar_id":"","url":"https://api.github.com/users/kernc","html_url":"https://github.com/kernc","followers_url":"https://api.github.com/users/kernc/followers","following_url":"https://api.github.com/users/kernc/following{/other_user}","gists_url":"https://api.github.com/users/kernc/gists{/gist_id}","starred_url":"https://api.github.com/users/kernc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernc/subscriptions","organizations_url":"https://api.github.com/users/kernc/orgs","repos_url":"https://api.github.com/users/kernc/repos","events_url":"https://api.github.com/users/kernc/events{/privacy}","received_events_url":"https://api.github.com/users/kernc/received_events","type":"User","site_admin":false},"body":"Summary of changes:\r\n* `for var in data.domain` (`iter(domain)`) iterates over _all_ Variables in the domain, including meta variables. The are several arguments for this change:\r\n  * String variables are also Variables. There are tickets about extending widgets' functionality to include meta features. Lots of widgets already use metas by `data.domain.variables + data.domain.metas` (40+ results in the codebase, excluding any `chain()` calls).\r\n  * It is easy enough to filter out only the primitive variables with `... for var in data.domain if var.is_primitive` or apply just about any other condition.\r\n  * `data.domain.variables` is still accessible and works as before (although it is deprecated as its utility is questionable and is yet to be assessed). \r\n  * This is consistent with `str()` of `Table` and `RowInstance` instances.\r\n* Indexing and slicing is reworked. Most importantly, negative indexes no longer return metas but are just plain true Pythonic negative indexes, i.e. from the back. It works almost the same, except that the order of returned metas is reversed, e.g. in domain with three metas `domain[-1]` now is what `domain[-3]` was before. I doubt much code is relying on this.\r\n* `Domain.anonymous` attribute is removed. It is used nowhere besides tests.\r\n* `Domain.checksum()` is depreacted in favor of the equality operator.\r\n* Some more basic `is_*`/`has_*` boolean members are converted to properties for consistency.\r\n* Domain has a new constructor which acts mostly the same. The more significant of changes is that any non-primitive variables passed as `attributes` or `class_vars` are put into `metas` instead.\r\n\r\nPlease see individual commits.\r\n\r\nIt is expected for some tests to fail. I didn't want to touch tests or auxiliaries until the interface is agreed on.\r\n\r\nSome relevant discussion: https://github.com/biolab/orange3-text/pull/23#discussion_r49006804","created_at":"2016-01-15T14:49:20Z","updated_at":"2016-01-18T09:41:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e72a78be55b0ffc15e7340f1868557f7082ba9c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biolab/orange3/pulls/978/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3/pulls/978/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/978/comments","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/f5f33b1309800a9ce607d6d8f27daa89d9a305e5","head":{"label":"kernc:domain-new","ref":"domain-new","sha":"f5f33b1309800a9ce607d6d8f27daa89d9a305e5","user":{"login":"kernc","id":684364,"avatar_url":"https://avatars.githubusercontent.com/u/684364?v=3","gravatar_id":"","url":"https://api.github.com/users/kernc","html_url":"https://github.com/kernc","followers_url":"https://api.github.com/users/kernc/followers","following_url":"https://api.github.com/users/kernc/following{/other_user}","gists_url":"https://api.github.com/users/kernc/gists{/gist_id}","starred_url":"https://api.github.com/users/kernc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernc/subscriptions","organizations_url":"https://api.github.com/users/kernc/orgs","repos_url":"https://api.github.com/users/kernc/repos","events_url":"https://api.github.com/users/kernc/events{/privacy}","received_events_url":"https://api.github.com/users/kernc/received_events","type":"User","site_admin":false},"repo":{"id":34139728,"name":"orange3","full_name":"kernc/orange3","owner":{"login":"kernc","id":684364,"avatar_url":"https://avatars.githubusercontent.com/u/684364?v=3","gravatar_id":"","url":"https://api.github.com/users/kernc","html_url":"https://github.com/kernc","followers_url":"https://api.github.com/users/kernc/followers","following_url":"https://api.github.com/users/kernc/following{/other_user}","gists_url":"https://api.github.com/users/kernc/gists{/gist_id}","starred_url":"https://api.github.com/users/kernc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernc/subscriptions","organizations_url":"https://api.github.com/users/kernc/orgs","repos_url":"https://api.github.com/users/kernc/repos","events_url":"https://api.github.com/users/kernc/events{/privacy}","received_events_url":"https://api.github.com/users/kernc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kernc/orange3","description":"","fork":true,"url":"https://api.github.com/repos/kernc/orange3","forks_url":"https://api.github.com/repos/kernc/orange3/forks","keys_url":"https://api.github.com/repos/kernc/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kernc/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kernc/orange3/teams","hooks_url":"https://api.github.com/repos/kernc/orange3/hooks","issue_events_url":"https://api.github.com/repos/kernc/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/kernc/orange3/events","assignees_url":"https://api.github.com/repos/kernc/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/kernc/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/kernc/orange3/tags","blobs_url":"https://api.github.com/repos/kernc/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kernc/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kernc/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/kernc/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kernc/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/kernc/orange3/languages","stargazers_url":"https://api.github.com/repos/kernc/orange3/stargazers","contributors_url":"https://api.github.com/repos/kernc/orange3/contributors","subscribers_url":"https://api.github.com/repos/kernc/orange3/subscribers","subscription_url":"https://api.github.com/repos/kernc/orange3/subscription","commits_url":"https://api.github.com/repos/kernc/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/kernc/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/kernc/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/kernc/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/kernc/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/kernc/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kernc/orange3/merges","archive_url":"https://api.github.com/repos/kernc/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kernc/orange3/downloads","issues_url":"https://api.github.com/repos/kernc/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/kernc/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/kernc/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/kernc/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kernc/orange3/labels{/name}","releases_url":"https://api.github.com/repos/kernc/orange3/releases{/id}","created_at":"2015-04-17T20:56:32Z","updated_at":"2016-01-14T12:39:26Z","pushed_at":"2016-01-17T03:47:55Z","git_url":"git://github.com/kernc/orange3.git","ssh_url":"git@github.com:kernc/orange3.git","clone_url":"https://github.com/kernc/orange3.git","svn_url":"https://github.com/kernc/orange3","homepage":null,"size":35822,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"b3eb35b44d193b2307d2a89268a75e7c97eab9b1","user":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":8357227,"name":"orange3","full_name":"biolab/orange3","owner":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biolab/orange3","description":"Orange 3 data mining suite: http://orange.biolab.si ","fork":false,"url":"https://api.github.com/repos/biolab/orange3","forks_url":"https://api.github.com/repos/biolab/orange3/forks","keys_url":"https://api.github.com/repos/biolab/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3/teams","hooks_url":"https://api.github.com/repos/biolab/orange3/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3/events","assignees_url":"https://api.github.com/repos/biolab/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3/tags","blobs_url":"https://api.github.com/repos/biolab/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3/subscription","commits_url":"https://api.github.com/repos/biolab/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/biolab/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3/merges","archive_url":"https://api.github.com/repos/biolab/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3/downloads","issues_url":"https://api.github.com/repos/biolab/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3/releases{/id}","created_at":"2013-02-22T12:52:56Z","updated_at":"2016-01-18T09:17:36Z","pushed_at":"2016-01-18T09:17:29Z","git_url":"git://github.com/biolab/orange3.git","ssh_url":"git@github.com:biolab/orange3.git","clone_url":"https://github.com/biolab/orange3.git","svn_url":"https://github.com/biolab/orange3","homepage":"","size":72791,"stargazers_count":179,"watchers_count":179,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":37,"forks":74,"open_issues":37,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/978"},"html":{"href":"https://github.com/biolab/orange3/pull/978"},"issue":{"href":"https://api.github.com/repos/biolab/orange3/issues/978"},"comments":{"href":"https://api.github.com/repos/biolab/orange3/issues/978/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3/pulls/978/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3/pulls/978/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3/statuses/f5f33b1309800a9ce607d6d8f27daa89d9a305e5"}}}}