{"action":"created","comment":{"url":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments/86467012","pull_request_review_id":7126230,"id":86467012,"diff_hunk":"@@ -0,0 +1,453 @@\n+/*\n+  Copyright (c) 2016 RhythmOne, LLC. All rights reserved.\n+*/\n+\n+var bidmanager = require('../bidmanager.js'),\n+  bidfactory = require('../bidfactory.js'),\n+  utils = require('../utils.js');\n+\n+import {ajax as ajax} from '../ajax';\n+\n+//function setupGA() {\n+//  /* jshint ignore:start */\n+//  (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)})(window,document,'script','https://www.google-analytics.com/analytics.js','ga');\n+//\n+//  ga('create', 'UA-63935000-31', { 'name': 'r1hbga' });\n+//  ga('r1hbga.send', 'pageview');\n+//  /* jshint ignore:end */\n+//}\n+\n+function track(debug, p1, p2, p3) {\n+  if(debug === true){\n+    //window.ga('r1hbga.send', 'event', p1, p2, p3);\n+    console.log('GA: %s %s %s', p1, p2, p3 || '');\n+  }\n+}\n+\n+//setupGA();\n+\n+var w = (typeof window !== \"undefined\" ? window : {});\n+w.trackR1Impression = track;\n+  \n+module.exports = function(bidManager, global, loader){\n+\n+  var version = \"0.9.0.0\",\n+    defaultZone = \"1r\",\n+    defaultPath = \"mvo\",\n+    bidfloor = 0,\n+    currency = \"USD\",\n+    debug = false,\n+    auctionEnded = false,\n+    requestCompleted = false;\n+    \n+  if(typeof global === \"undefined\")\n+    global = window;\n+      \n+  if(typeof bidManager === \"undefined\")\n+    bidManager = bidmanager;\n+    \n+  if(typeof loader === \"undefined\")\n+    loader = ajax;\n+  \n+  var rhythmBidderUtilities = {\n+    template: function(){return \"<div id=\\\"{0}_wrapper\\\"></div><script type=\\\"text/javascript\\\">(\"+rhythmBidderUtilities.process.toString()+\")(\\\"{0}\\\", {1}, {2}, {3}, \\\"{4}\\\", {5}, {6});</scr\"+\"ipt>\";},\n+\n+    process: function(target, markup, bidResponse, bidfloor, currency, seat, url){\n+    \n+      function frameWrap(target, markup, url){\n+        var f = document.createElement(\"iframe\");\n+        f.style.border=\"0\";\n+        f.scrolling=\"no\";\n+        f.seamless=\"seamless\";\n+        f.style.height = bidResponse.h+\"px\";\n+        f.style.width = bidResponse.w+\"px\";\n+        \n+        target.style.height = bidResponse.h+\"px\";\n+        target.style.width = bidResponse.w+\"px\";\n+        target.appendChild(f);\n+        \n+        if(markup){\n+          f.contentWindow.document.open();\n+          f.contentWindow.document.write(\"<html><head></head><body style=\\\"margin:0;padding:0;\\\">\"+markup+\"</body></html>\");\n+          if((/(MSIE|Trident|Edge)/).test(window.navigator.userAgent) === false)\n+            f.contentWindow.document.close();\n+        }\n+        else if(url)\n+          f.src = url;\n+      }\n+    \n+      var w = window,\n+        pjs = (function(){\n+          try{\n+            while(w){\n+              if(w.$$PREBID_GLOBAL$$ || w === window.top) return w.$$PREBID_GLOBAL$$;\n+              w = w.parent;\n+            }\n+          }\n+          catch(ex){}\n+          return null;\n+        })(),\n+        responses = (pjs && pjs.getBidResponses ? pjs.getBidResponses() : {}),","path":"src/adapters/rhythmone.js","position":90,"original_position":90,"commit_id":"b0272e0d593ed4df9fe3283ebdea05992c37b55b","original_commit_id":"b0272e0d593ed4df9fe3283ebdea05992c37b55b","user":{"login":"mkendall07","id":1870166,"avatar_url":"https://avatars.githubusercontent.com/u/1870166?v=3","gravatar_id":"","url":"https://api.github.com/users/mkendall07","html_url":"https://github.com/mkendall07","followers_url":"https://api.github.com/users/mkendall07/followers","following_url":"https://api.github.com/users/mkendall07/following{/other_user}","gists_url":"https://api.github.com/users/mkendall07/gists{/gist_id}","starred_url":"https://api.github.com/users/mkendall07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkendall07/subscriptions","organizations_url":"https://api.github.com/users/mkendall07/orgs","repos_url":"https://api.github.com/users/mkendall07/repos","events_url":"https://api.github.com/users/mkendall07/events{/privacy}","received_events_url":"https://api.github.com/users/mkendall07/received_events","type":"User","site_admin":false},"body":"No, but we should have one. Essentially no adapter should be looking at bids submitted by other partners or otherwise using the public API's designated for publishers. What this means practically is that you do not need to access any methods/properties on `pbjs` with the exception of if your adapter needs to expose a JSONP callback handler function. ","created_at":"2016-11-03T23:46:52Z","updated_at":"2016-11-03T23:46:52Z","html_url":"https://github.com/prebid/Prebid.js/pull/657#discussion_r86467012","pull_request_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/657","_links":{"self":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments/86467012"},"html":{"href":"https://github.com/prebid/Prebid.js/pull/657#discussion_r86467012"},"pull_request":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/657"}}},"pull_request":{"url":"https://api.github.com/repos/prebid/Prebid.js/pulls/657","id":86843629,"html_url":"https://github.com/prebid/Prebid.js/pull/657","diff_url":"https://github.com/prebid/Prebid.js/pull/657.diff","patch_url":"https://github.com/prebid/Prebid.js/pull/657.patch","issue_url":"https://api.github.com/repos/prebid/Prebid.js/issues/657","number":657,"state":"open","locked":false,"title":"Initial checkin of RhythmOne bidder adapter and unit tests","user":{"login":"jstocker76","id":9953282,"avatar_url":"https://avatars.githubusercontent.com/u/9953282?v=3","gravatar_id":"","url":"https://api.github.com/users/jstocker76","html_url":"https://github.com/jstocker76","followers_url":"https://api.github.com/users/jstocker76/followers","following_url":"https://api.github.com/users/jstocker76/following{/other_user}","gists_url":"https://api.github.com/users/jstocker76/gists{/gist_id}","starred_url":"https://api.github.com/users/jstocker76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstocker76/subscriptions","organizations_url":"https://api.github.com/users/jstocker76/orgs","repos_url":"https://api.github.com/users/jstocker76/repos","events_url":"https://api.github.com/users/jstocker76/events{/privacy}","received_events_url":"https://api.github.com/users/jstocker76/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please make sure this PR is scoped to one change, and that any added or changed code includes tests with greater than 80% code coverage. See http://prebid.org/dev-docs/testing-prebid.html for documentation on testing Prebid.js.\r\n-->\r\n## Type of change\r\n\r\n<!-- Remove items that don't apply and/or select an item by changing [ ] to [x] -->\r\n- [ ] Bugfix\r\n- [ ] Feature\r\n- [x] New bidder adapter\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build related changes\r\n- [ ] CI related changes\r\n- [ ] Other\r\n## Description of change\r\n\r\nAddition of a new bidder adapter that uses RhythmOne's ad exchange with unit tests.\r\n\r\n<!-- For new bidder adapters, please provide the following -->\r\n- test parameters for validating bids\r\n\r\n```\r\n\t\t\t{\r\n\t\t\t\tbidder: 'rhythmone',\r\n\t\t\t\tparams: {\r\n\t\t\t\t\tplacementId: \"549\",\r\n\t\t\t\t\tzone: \"hb\",\r\n\t\t\t\t\tpath: \"mvo\"\r\n\t\t\t\t}\r\n\t\t\t}\r\n```\r\n- contact email of the adapter’s maintainer\r\n  astocker@rhythmone.com\r\n- [x] official adapter submission\r\n","created_at":"2016-09-27T00:29:40Z","updated_at":"2016-11-03T23:46:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b74ea94aa296f3b1d9d80e3c338737e766102e06","assignee":{"login":"protonate","id":4116940,"avatar_url":"https://avatars.githubusercontent.com/u/4116940?v=3","gravatar_id":"","url":"https://api.github.com/users/protonate","html_url":"https://github.com/protonate","followers_url":"https://api.github.com/users/protonate/followers","following_url":"https://api.github.com/users/protonate/following{/other_user}","gists_url":"https://api.github.com/users/protonate/gists{/gist_id}","starred_url":"https://api.github.com/users/protonate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protonate/subscriptions","organizations_url":"https://api.github.com/users/protonate/orgs","repos_url":"https://api.github.com/users/protonate/repos","events_url":"https://api.github.com/users/protonate/events{/privacy}","received_events_url":"https://api.github.com/users/protonate/received_events","type":"User","site_admin":false},"assignees":[{"login":"protonate","id":4116940,"avatar_url":"https://avatars.githubusercontent.com/u/4116940?v=3","gravatar_id":"","url":"https://api.github.com/users/protonate","html_url":"https://github.com/protonate","followers_url":"https://api.github.com/users/protonate/followers","following_url":"https://api.github.com/users/protonate/following{/other_user}","gists_url":"https://api.github.com/users/protonate/gists{/gist_id}","starred_url":"https://api.github.com/users/protonate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protonate/subscriptions","organizations_url":"https://api.github.com/users/protonate/orgs","repos_url":"https://api.github.com/users/protonate/repos","events_url":"https://api.github.com/users/protonate/events{/privacy}","received_events_url":"https://api.github.com/users/protonate/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/657/commits","review_comments_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/657/comments","review_comment_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prebid/Prebid.js/issues/657/comments","statuses_url":"https://api.github.com/repos/prebid/Prebid.js/statuses/b0272e0d593ed4df9fe3283ebdea05992c37b55b","head":{"label":"jstocker76:master","ref":"master","sha":"b0272e0d593ed4df9fe3283ebdea05992c37b55b","user":{"login":"jstocker76","id":9953282,"avatar_url":"https://avatars.githubusercontent.com/u/9953282?v=3","gravatar_id":"","url":"https://api.github.com/users/jstocker76","html_url":"https://github.com/jstocker76","followers_url":"https://api.github.com/users/jstocker76/followers","following_url":"https://api.github.com/users/jstocker76/following{/other_user}","gists_url":"https://api.github.com/users/jstocker76/gists{/gist_id}","starred_url":"https://api.github.com/users/jstocker76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstocker76/subscriptions","organizations_url":"https://api.github.com/users/jstocker76/orgs","repos_url":"https://api.github.com/users/jstocker76/repos","events_url":"https://api.github.com/users/jstocker76/events{/privacy}","received_events_url":"https://api.github.com/users/jstocker76/received_events","type":"User","site_admin":false},"repo":{"id":69303569,"name":"Prebid.js","full_name":"jstocker76/Prebid.js","owner":{"login":"jstocker76","id":9953282,"avatar_url":"https://avatars.githubusercontent.com/u/9953282?v=3","gravatar_id":"","url":"https://api.github.com/users/jstocker76","html_url":"https://github.com/jstocker76","followers_url":"https://api.github.com/users/jstocker76/followers","following_url":"https://api.github.com/users/jstocker76/following{/other_user}","gists_url":"https://api.github.com/users/jstocker76/gists{/gist_id}","starred_url":"https://api.github.com/users/jstocker76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstocker76/subscriptions","organizations_url":"https://api.github.com/users/jstocker76/orgs","repos_url":"https://api.github.com/users/jstocker76/repos","events_url":"https://api.github.com/users/jstocker76/events{/privacy}","received_events_url":"https://api.github.com/users/jstocker76/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jstocker76/Prebid.js","description":"Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.","fork":true,"url":"https://api.github.com/repos/jstocker76/Prebid.js","forks_url":"https://api.github.com/repos/jstocker76/Prebid.js/forks","keys_url":"https://api.github.com/repos/jstocker76/Prebid.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jstocker76/Prebid.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jstocker76/Prebid.js/teams","hooks_url":"https://api.github.com/repos/jstocker76/Prebid.js/hooks","issue_events_url":"https://api.github.com/repos/jstocker76/Prebid.js/issues/events{/number}","events_url":"https://api.github.com/repos/jstocker76/Prebid.js/events","assignees_url":"https://api.github.com/repos/jstocker76/Prebid.js/assignees{/user}","branches_url":"https://api.github.com/repos/jstocker76/Prebid.js/branches{/branch}","tags_url":"https://api.github.com/repos/jstocker76/Prebid.js/tags","blobs_url":"https://api.github.com/repos/jstocker76/Prebid.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jstocker76/Prebid.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jstocker76/Prebid.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jstocker76/Prebid.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jstocker76/Prebid.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jstocker76/Prebid.js/languages","stargazers_url":"https://api.github.com/repos/jstocker76/Prebid.js/stargazers","contributors_url":"https://api.github.com/repos/jstocker76/Prebid.js/contributors","subscribers_url":"https://api.github.com/repos/jstocker76/Prebid.js/subscribers","subscription_url":"https://api.github.com/repos/jstocker76/Prebid.js/subscription","commits_url":"https://api.github.com/repos/jstocker76/Prebid.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jstocker76/Prebid.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jstocker76/Prebid.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jstocker76/Prebid.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/jstocker76/Prebid.js/contents/{+path}","compare_url":"https://api.github.com/repos/jstocker76/Prebid.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jstocker76/Prebid.js/merges","archive_url":"https://api.github.com/repos/jstocker76/Prebid.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jstocker76/Prebid.js/downloads","issues_url":"https://api.github.com/repos/jstocker76/Prebid.js/issues{/number}","pulls_url":"https://api.github.com/repos/jstocker76/Prebid.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jstocker76/Prebid.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jstocker76/Prebid.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jstocker76/Prebid.js/labels{/name}","releases_url":"https://api.github.com/repos/jstocker76/Prebid.js/releases{/id}","deployments_url":"https://api.github.com/repos/jstocker76/Prebid.js/deployments","created_at":"2016-09-27T00:16:31Z","updated_at":"2016-09-27T00:16:32Z","pushed_at":"2016-11-03T21:58:39Z","git_url":"git://github.com/jstocker76/Prebid.js.git","ssh_url":"git@github.com:jstocker76/Prebid.js.git","clone_url":"https://github.com/jstocker76/Prebid.js.git","svn_url":"https://github.com/jstocker76/Prebid.js","homepage":"http://prebid.org","size":20376,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prebid:master","ref":"master","sha":"2c0ca80a1b06e67ad76886779f02855704ea1c8d","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars.githubusercontent.com/u/13242760?v=3","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":39321023,"name":"Prebid.js","full_name":"prebid/Prebid.js","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars.githubusercontent.com/u/13242760?v=3","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/Prebid.js","description":"Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.","fork":false,"url":"https://api.github.com/repos/prebid/Prebid.js","forks_url":"https://api.github.com/repos/prebid/Prebid.js/forks","keys_url":"https://api.github.com/repos/prebid/Prebid.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/Prebid.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/Prebid.js/teams","hooks_url":"https://api.github.com/repos/prebid/Prebid.js/hooks","issue_events_url":"https://api.github.com/repos/prebid/Prebid.js/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/Prebid.js/events","assignees_url":"https://api.github.com/repos/prebid/Prebid.js/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/Prebid.js/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/Prebid.js/tags","blobs_url":"https://api.github.com/repos/prebid/Prebid.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/Prebid.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/Prebid.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/Prebid.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/Prebid.js/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/Prebid.js/languages","stargazers_url":"https://api.github.com/repos/prebid/Prebid.js/stargazers","contributors_url":"https://api.github.com/repos/prebid/Prebid.js/contributors","subscribers_url":"https://api.github.com/repos/prebid/Prebid.js/subscribers","subscription_url":"https://api.github.com/repos/prebid/Prebid.js/subscription","commits_url":"https://api.github.com/repos/prebid/Prebid.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/Prebid.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/Prebid.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/Prebid.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/Prebid.js/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/Prebid.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/Prebid.js/merges","archive_url":"https://api.github.com/repos/prebid/Prebid.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/Prebid.js/downloads","issues_url":"https://api.github.com/repos/prebid/Prebid.js/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/Prebid.js/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/Prebid.js/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/Prebid.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/Prebid.js/labels{/name}","releases_url":"https://api.github.com/repos/prebid/Prebid.js/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/Prebid.js/deployments","created_at":"2015-07-19T03:26:23Z","updated_at":"2016-11-03T22:22:21Z","pushed_at":"2016-11-03T22:42:21Z","git_url":"git://github.com/prebid/Prebid.js.git","ssh_url":"git@github.com:prebid/Prebid.js.git","clone_url":"https://github.com/prebid/Prebid.js.git","svn_url":"https://github.com/prebid/Prebid.js","homepage":"http://prebid.org","size":41021,"stargazers_count":298,"watchers_count":298,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":33,"forks":239,"open_issues":33,"watchers":298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/657"},"html":{"href":"https://github.com/prebid/Prebid.js/pull/657"},"issue":{"href":"https://api.github.com/repos/prebid/Prebid.js/issues/657"},"comments":{"href":"https://api.github.com/repos/prebid/Prebid.js/issues/657/comments"},"review_comments":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/657/comments"},"review_comment":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/657/commits"},"statuses":{"href":"https://api.github.com/repos/prebid/Prebid.js/statuses/b0272e0d593ed4df9fe3283ebdea05992c37b55b"}}}}
{"actor":{"display_login":"mkendall07"}}