{"action":"created","issue":{"url":"https://api.github.com/repos/stylelint/stylelint/issues/2182","repository_url":"https://api.github.com/repos/stylelint/stylelint","labels_url":"https://api.github.com/repos/stylelint/stylelint/issues/2182/labels{/name}","comments_url":"https://api.github.com/repos/stylelint/stylelint/issues/2182/comments","events_url":"https://api.github.com/repos/stylelint/stylelint/issues/2182/events","html_url":"https://github.com/stylelint/stylelint/pull/2182","id":194599406,"number":2182,"title":"Ignore maps and lists in color-named","user":{"login":"mmase","id":753529,"avatar_url":"https://avatars.githubusercontent.com/u/753529?v=3","gravatar_id":"","url":"https://api.github.com/users/mmase","html_url":"https://github.com/mmase","followers_url":"https://api.github.com/users/mmase/followers","following_url":"https://api.github.com/users/mmase/following{/other_user}","gists_url":"https://api.github.com/users/mmase/gists{/gist_id}","starred_url":"https://api.github.com/users/mmase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmase/subscriptions","organizations_url":"https://api.github.com/users/mmase/orgs","repos_url":"https://api.github.com/users/mmase/repos","events_url":"https://api.github.com/users/mmase/events{/privacy}","received_events_url":"https://api.github.com/users/mmase/received_events","type":"User","site_admin":false},"labels":[{"id":210042514,"url":"https://api.github.com/repos/stylelint/stylelint/labels/PR:%20review%20needed","name":"PR: review needed","color":"FFE600","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-09T13:41:47Z","updated_at":"2016-12-12T15:02:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stylelint/stylelint/pulls/2182","html_url":"https://github.com/stylelint/stylelint/pull/2182","diff_url":"https://github.com/stylelint/stylelint/pull/2182.diff","patch_url":"https://github.com/stylelint/stylelint/pull/2182.patch"},"body":"> Which issue, if any, is this issue related to?\r\n\r\nhttps://github.com/stylelint/stylelint/issues/2009\r\n\r\n> Is there anything in the PR that needs further explanation?\r\n\r\nNo, it's self explanatory.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/stylelint/stylelint/issues/comments/266452840","html_url":"https://github.com/stylelint/stylelint/pull/2182#issuecomment-266452840","issue_url":"https://api.github.com/repos/stylelint/stylelint/issues/2182","id":266452840,"user":{"login":"jeddy3","id":808227,"avatar_url":"https://avatars.githubusercontent.com/u/808227?v=3","gravatar_id":"","url":"https://api.github.com/users/jeddy3","html_url":"https://github.com/jeddy3","followers_url":"https://api.github.com/users/jeddy3/followers","following_url":"https://api.github.com/users/jeddy3/following{/other_user}","gists_url":"https://api.github.com/users/jeddy3/gists{/gist_id}","starred_url":"https://api.github.com/users/jeddy3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeddy3/subscriptions","organizations_url":"https://api.github.com/users/jeddy3/orgs","repos_url":"https://api.github.com/users/jeddy3/repos","events_url":"https://api.github.com/users/jeddy3/events{/privacy}","received_events_url":"https://api.github.com/users/jeddy3/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T15:02:04Z","updated_at":"2016-12-12T15:02:04Z","body":"> Made requested changes, let me know if you have any other thoughts on improvements!\r\n\r\nThank you!\r\n\r\nI think this issue has highlighted a few shortcomings in the tests of this rule as it's not immediately obvious from them if this rule is behaving as expected.\r\n\r\nAm I right in thinking that the default behaviour should be:\r\n\r\n1. Check color representations inside all standard syntax functions (e.g. when using [color-mod](https://drafts.csswg.org/css-color/#modifying-colors): `a { color: color(black a(50%))`)\r\n2. Ignore non-standard list and map syntax i.e. `(..)`\r\n\r\nThen we provide an `\"ignore\": [\"inside-function\"]` option for ignoring standard syntax functions.\r\n\r\nI think we're at least missing two tests in the `\"never\"` set that show colours within standard syntax functions are checked e.g. `accept` and `reject` tests for `a { color: color(black a(50%))`.\r\n\r\nAdd another in `\"always-where-possible\"` `reject`. (There is one for the `accept` already.)\r\n\r\nThese I think these new `reject` tests will likely fail with the current implementation in this PR.\r\n\r\n> If we can ignore them by some other means, we'd do that.\r\n\r\nI thought we might be able to use `postcss-value-parser` to distinguish between standard syntax functions (i.e. those that have a name (e.g. `color(..)` or `map-get(..)) and non-standard syntax ones (i.e. those that don't `(..)`).  @mmase Do you think this might be possible or did you initial investigation turn up a blank?\r\n\r\nThanks for sticking with us on this. It's a deceptively tricky PR."}}
{"actor":{"display_login":"jeddy3"}}