{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6271","repository_url":"https://api.github.com/repos/silverstripe/silverstripe-framework","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6271/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6271/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6271/events","html_url":"https://github.com/silverstripe/silverstripe-framework/issues/6271","id":186659948,"number":6271,"title":"ENHANCEMENT: LoginAttempt -  set max size of IP address to 45 characters","user":{"login":"sunnysideup","id":167154,"avatar_url":"https://avatars.githubusercontent.com/u/167154?v=3","gravatar_id":"","url":"https://api.github.com/users/sunnysideup","html_url":"https://github.com/sunnysideup","followers_url":"https://api.github.com/users/sunnysideup/followers","following_url":"https://api.github.com/users/sunnysideup/following{/other_user}","gists_url":"https://api.github.com/users/sunnysideup/gists{/gist_id}","starred_url":"https://api.github.com/users/sunnysideup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunnysideup/subscriptions","organizations_url":"https://api.github.com/users/sunnysideup/orgs","repos_url":"https://api.github.com/users/sunnysideup/repos","events_url":"https://api.github.com/users/sunnysideup/events{/privacy}","received_events_url":"https://api.github.com/users/sunnysideup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-01T22:00:40Z","updated_at":"2016-11-01T22:07:33Z","closed_at":null,"body":"see: https://github.com/silverstripe/silverstripe-framework/blob/master/src/Security/LoginAttempt.php#L30\r\n\r\nIP address should be set to up to 45 characters.... ? \r\n\r\ninfo:\r\n\r\n- http://stackoverflow.com/questions/1076714/max-length-for-client-ip-address\r\nhtt\r\n - http://stackoverflow.com/questions/166132/maximum-length-of-the-textual-representation-of-an-ipv6-address"},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/257713691","html_url":"https://github.com/silverstripe/silverstripe-framework/issues/6271#issuecomment-257713691","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6271","id":257713691,"user":{"login":"sunnysideup","id":167154,"avatar_url":"https://avatars.githubusercontent.com/u/167154?v=3","gravatar_id":"","url":"https://api.github.com/users/sunnysideup","html_url":"https://github.com/sunnysideup","followers_url":"https://api.github.com/users/sunnysideup/followers","following_url":"https://api.github.com/users/sunnysideup/following{/other_user}","gists_url":"https://api.github.com/users/sunnysideup/gists{/gist_id}","starred_url":"https://api.github.com/users/sunnysideup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunnysideup/subscriptions","organizations_url":"https://api.github.com/users/sunnysideup/orgs","repos_url":"https://api.github.com/users/sunnysideup/repos","events_url":"https://api.github.com/users/sunnysideup/events{/privacy}","received_events_url":"https://api.github.com/users/sunnysideup/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T22:07:33Z","updated_at":"2016-11-01T22:07:33Z","body":"Hi Robbie,\r\n\r\nThank you for your quick response.\r\n\r\nGood question ;-) \r\n\r\nWhat is the benefit of being able to limit the number of characters in VARCHAR?  As far as I know it basically helps you to make your database faster and smaller? \r\n\r\nIf this does not matter then is it an idea to set all VARCHARS to be 255?\r\n\r\n"}}
{"actor":{"display_login":"sunnysideup"}}