{"action":"created","comment":{"url":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/comments/83908451","pull_request_review_id":4720653,"id":83908451,"diff_hunk":"@@ -47,26 +47,38 @@ extension OrderedDictionaryType {\n         while let element = iterator.next() {\n             result.append(try transform(element))\n         }\n+        \n         return Array(result)\n     }\n }\n \n extension OrderedDictionaryType where\n+    Index == Int,\n     KeyStorage.Index == Int,\n     KeyStorage.Iterator.Element == Key\n {\n     \n+    // MARK: - Collection\n+    \n+    public var startIndex: Int { return keyStorage.startIndex }\n+    public var endIndex: Int { return keyStorage.endIndex }\n+    \n+    public func index(after i: Int) -> Int {\n+        guard i != endIndex else { fatalError(\"Cannot increment endIndex\") }\n+        return keyStorage.index(after: i)\n+    }\n+    \n     /**\n-     Create an iterator for an `OrderedDictionaryType` value.\n+     - returns: Value at the given `index`. Will crash if index out-of-range.\n      */\n-    public func generate() -> AnyIterator<(Key, Value)> {\n-        var index = keyStorage.startIndex\n-        return AnyIterator<(Key, Value)> {\n-            defer { index += 1 }\n-            guard index < self.keyStorage.endIndex else { return nil }\n-            let key = self.keyStorage[index]\n-            guard let value = self.values[key] else { return nil }\n-            return (key, value)\n+    public subscript (index: Int) -> (Key,Value) {\n+        ","path":"DictionaryTools/OrderedDictionaryType.swift","position":51,"original_position":51,"commit_id":"f9f6a4f6abaaf346d512041f7d6c68303bf616aa","original_commit_id":"f9f6a4f6abaaf346d512041f7d6c68303bf616aa","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)","created_at":"2016-10-18T17:34:35Z","updated_at":"2016-10-18T17:34:35Z","html_url":"https://github.com/dn-m/DictionaryTools/pull/11#discussion_r83908451","pull_request_url":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/comments/83908451"},"html":{"href":"https://github.com/dn-m/DictionaryTools/pull/11#discussion_r83908451"},"pull_request":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/11","id":89863225,"html_url":"https://github.com/dn-m/DictionaryTools/pull/11","diff_url":"https://github.com/dn-m/DictionaryTools/pull/11.diff","patch_url":"https://github.com/dn-m/DictionaryTools/pull/11.patch","issue_url":"https://api.github.com/repos/dn-m/DictionaryTools/issues/11","number":11,"state":"closed","locked":false,"title":"Update Indexing of Ordered and Sorted Dictionaries","user":{"login":"jsbean","id":7040073,"avatar_url":"https://avatars.githubusercontent.com/u/7040073?v=3","gravatar_id":"","url":"https://api.github.com/users/jsbean","html_url":"https://github.com/jsbean","followers_url":"https://api.github.com/users/jsbean/followers","following_url":"https://api.github.com/users/jsbean/following{/other_user}","gists_url":"https://api.github.com/users/jsbean/gists{/gist_id}","starred_url":"https://api.github.com/users/jsbean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsbean/subscriptions","organizations_url":"https://api.github.com/users/jsbean/orgs","repos_url":"https://api.github.com/users/jsbean/repos","events_url":"https://api.github.com/users/jsbean/events{/privacy}","received_events_url":"https://api.github.com/users/jsbean/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-18T17:34:18Z","updated_at":"2016-10-18T17:34:35Z","closed_at":"2016-10-18T17:34:24Z","merged_at":"2016-10-18T17:34:24Z","merge_commit_sha":"e9d5706f3632d723b99b5c8f5d9de3925508d7ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/11/commits","review_comments_url":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/11/comments","review_comment_url":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dn-m/DictionaryTools/issues/11/comments","statuses_url":"https://api.github.com/repos/dn-m/DictionaryTools/statuses/f9f6a4f6abaaf346d512041f7d6c68303bf616aa","head":{"label":"dn-m:fix-ordered-dictionary","ref":"fix-ordered-dictionary","sha":"f9f6a4f6abaaf346d512041f7d6c68303bf616aa","user":{"login":"dn-m","id":17167826,"avatar_url":"https://avatars.githubusercontent.com/u/17167826?v=3","gravatar_id":"","url":"https://api.github.com/users/dn-m","html_url":"https://github.com/dn-m","followers_url":"https://api.github.com/users/dn-m/followers","following_url":"https://api.github.com/users/dn-m/following{/other_user}","gists_url":"https://api.github.com/users/dn-m/gists{/gist_id}","starred_url":"https://api.github.com/users/dn-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dn-m/subscriptions","organizations_url":"https://api.github.com/users/dn-m/orgs","repos_url":"https://api.github.com/users/dn-m/repos","events_url":"https://api.github.com/users/dn-m/events{/privacy}","received_events_url":"https://api.github.com/users/dn-m/received_events","type":"Organization","site_admin":false},"repo":{"id":52380174,"name":"DictionaryTools","full_name":"dn-m/DictionaryTools","owner":{"login":"dn-m","id":17167826,"avatar_url":"https://avatars.githubusercontent.com/u/17167826?v=3","gravatar_id":"","url":"https://api.github.com/users/dn-m","html_url":"https://github.com/dn-m","followers_url":"https://api.github.com/users/dn-m/followers","following_url":"https://api.github.com/users/dn-m/following{/other_user}","gists_url":"https://api.github.com/users/dn-m/gists{/gist_id}","starred_url":"https://api.github.com/users/dn-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dn-m/subscriptions","organizations_url":"https://api.github.com/users/dn-m/orgs","repos_url":"https://api.github.com/users/dn-m/repos","events_url":"https://api.github.com/users/dn-m/events{/privacy}","received_events_url":"https://api.github.com/users/dn-m/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dn-m/DictionaryTools","description":"Extensions of Swift Dictionary struct","fork":false,"url":"https://api.github.com/repos/dn-m/DictionaryTools","forks_url":"https://api.github.com/repos/dn-m/DictionaryTools/forks","keys_url":"https://api.github.com/repos/dn-m/DictionaryTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dn-m/DictionaryTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dn-m/DictionaryTools/teams","hooks_url":"https://api.github.com/repos/dn-m/DictionaryTools/hooks","issue_events_url":"https://api.github.com/repos/dn-m/DictionaryTools/issues/events{/number}","events_url":"https://api.github.com/repos/dn-m/DictionaryTools/events","assignees_url":"https://api.github.com/repos/dn-m/DictionaryTools/assignees{/user}","branches_url":"https://api.github.com/repos/dn-m/DictionaryTools/branches{/branch}","tags_url":"https://api.github.com/repos/dn-m/DictionaryTools/tags","blobs_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dn-m/DictionaryTools/statuses/{sha}","languages_url":"https://api.github.com/repos/dn-m/DictionaryTools/languages","stargazers_url":"https://api.github.com/repos/dn-m/DictionaryTools/stargazers","contributors_url":"https://api.github.com/repos/dn-m/DictionaryTools/contributors","subscribers_url":"https://api.github.com/repos/dn-m/DictionaryTools/subscribers","subscription_url":"https://api.github.com/repos/dn-m/DictionaryTools/subscription","commits_url":"https://api.github.com/repos/dn-m/DictionaryTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dn-m/DictionaryTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dn-m/DictionaryTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dn-m/DictionaryTools/contents/{+path}","compare_url":"https://api.github.com/repos/dn-m/DictionaryTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dn-m/DictionaryTools/merges","archive_url":"https://api.github.com/repos/dn-m/DictionaryTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dn-m/DictionaryTools/downloads","issues_url":"https://api.github.com/repos/dn-m/DictionaryTools/issues{/number}","pulls_url":"https://api.github.com/repos/dn-m/DictionaryTools/pulls{/number}","milestones_url":"https://api.github.com/repos/dn-m/DictionaryTools/milestones{/number}","notifications_url":"https://api.github.com/repos/dn-m/DictionaryTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dn-m/DictionaryTools/labels{/name}","releases_url":"https://api.github.com/repos/dn-m/DictionaryTools/releases{/id}","deployments_url":"https://api.github.com/repos/dn-m/DictionaryTools/deployments","created_at":"2016-02-23T18:02:04Z","updated_at":"2016-02-23T18:03:11Z","pushed_at":"2016-10-18T17:34:24Z","git_url":"git://github.com/dn-m/DictionaryTools.git","ssh_url":"git@github.com:dn-m/DictionaryTools.git","clone_url":"https://github.com/dn-m/DictionaryTools.git","svn_url":"https://github.com/dn-m/DictionaryTools","homepage":null,"size":163,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dn-m:master","ref":"master","sha":"34fd37f1596210397067d1b3a6c52249f860e977","user":{"login":"dn-m","id":17167826,"avatar_url":"https://avatars.githubusercontent.com/u/17167826?v=3","gravatar_id":"","url":"https://api.github.com/users/dn-m","html_url":"https://github.com/dn-m","followers_url":"https://api.github.com/users/dn-m/followers","following_url":"https://api.github.com/users/dn-m/following{/other_user}","gists_url":"https://api.github.com/users/dn-m/gists{/gist_id}","starred_url":"https://api.github.com/users/dn-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dn-m/subscriptions","organizations_url":"https://api.github.com/users/dn-m/orgs","repos_url":"https://api.github.com/users/dn-m/repos","events_url":"https://api.github.com/users/dn-m/events{/privacy}","received_events_url":"https://api.github.com/users/dn-m/received_events","type":"Organization","site_admin":false},"repo":{"id":52380174,"name":"DictionaryTools","full_name":"dn-m/DictionaryTools","owner":{"login":"dn-m","id":17167826,"avatar_url":"https://avatars.githubusercontent.com/u/17167826?v=3","gravatar_id":"","url":"https://api.github.com/users/dn-m","html_url":"https://github.com/dn-m","followers_url":"https://api.github.com/users/dn-m/followers","following_url":"https://api.github.com/users/dn-m/following{/other_user}","gists_url":"https://api.github.com/users/dn-m/gists{/gist_id}","starred_url":"https://api.github.com/users/dn-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dn-m/subscriptions","organizations_url":"https://api.github.com/users/dn-m/orgs","repos_url":"https://api.github.com/users/dn-m/repos","events_url":"https://api.github.com/users/dn-m/events{/privacy}","received_events_url":"https://api.github.com/users/dn-m/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dn-m/DictionaryTools","description":"Extensions of Swift Dictionary struct","fork":false,"url":"https://api.github.com/repos/dn-m/DictionaryTools","forks_url":"https://api.github.com/repos/dn-m/DictionaryTools/forks","keys_url":"https://api.github.com/repos/dn-m/DictionaryTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dn-m/DictionaryTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dn-m/DictionaryTools/teams","hooks_url":"https://api.github.com/repos/dn-m/DictionaryTools/hooks","issue_events_url":"https://api.github.com/repos/dn-m/DictionaryTools/issues/events{/number}","events_url":"https://api.github.com/repos/dn-m/DictionaryTools/events","assignees_url":"https://api.github.com/repos/dn-m/DictionaryTools/assignees{/user}","branches_url":"https://api.github.com/repos/dn-m/DictionaryTools/branches{/branch}","tags_url":"https://api.github.com/repos/dn-m/DictionaryTools/tags","blobs_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dn-m/DictionaryTools/statuses/{sha}","languages_url":"https://api.github.com/repos/dn-m/DictionaryTools/languages","stargazers_url":"https://api.github.com/repos/dn-m/DictionaryTools/stargazers","contributors_url":"https://api.github.com/repos/dn-m/DictionaryTools/contributors","subscribers_url":"https://api.github.com/repos/dn-m/DictionaryTools/subscribers","subscription_url":"https://api.github.com/repos/dn-m/DictionaryTools/subscription","commits_url":"https://api.github.com/repos/dn-m/DictionaryTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dn-m/DictionaryTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dn-m/DictionaryTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dn-m/DictionaryTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dn-m/DictionaryTools/contents/{+path}","compare_url":"https://api.github.com/repos/dn-m/DictionaryTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dn-m/DictionaryTools/merges","archive_url":"https://api.github.com/repos/dn-m/DictionaryTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dn-m/DictionaryTools/downloads","issues_url":"https://api.github.com/repos/dn-m/DictionaryTools/issues{/number}","pulls_url":"https://api.github.com/repos/dn-m/DictionaryTools/pulls{/number}","milestones_url":"https://api.github.com/repos/dn-m/DictionaryTools/milestones{/number}","notifications_url":"https://api.github.com/repos/dn-m/DictionaryTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dn-m/DictionaryTools/labels{/name}","releases_url":"https://api.github.com/repos/dn-m/DictionaryTools/releases{/id}","deployments_url":"https://api.github.com/repos/dn-m/DictionaryTools/deployments","created_at":"2016-02-23T18:02:04Z","updated_at":"2016-02-23T18:03:11Z","pushed_at":"2016-10-18T17:34:24Z","git_url":"git://github.com/dn-m/DictionaryTools.git","ssh_url":"git@github.com:dn-m/DictionaryTools.git","clone_url":"https://github.com/dn-m/DictionaryTools.git","svn_url":"https://github.com/dn-m/DictionaryTools","homepage":null,"size":163,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/11"},"html":{"href":"https://github.com/dn-m/DictionaryTools/pull/11"},"issue":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/issues/11"},"comments":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/dn-m/DictionaryTools/statuses/f9f6a4f6abaaf346d512041f7d6c68303bf616aa"}}}}
{"actor":{"display_login":"houndci-bot"}}