{"action":"created","comment":{"url":"https://api.github.com/repos/ontohub/ontohub/pulls/comments/49945785","id":49945785,"diff_hunk":"@@ -0,0 +1,10 @@\n+class RepositoryFetchingWorker < BaseWorker\n+  sidekiq_options retry: false, queue: 'default'","path":"lib/repository_fetching_worker.rb","position":2,"original_position":2,"commit_id":"a7ce8a0835900d97ea907d3f9459b2d79e7269ff","original_commit_id":"a7ce8a0835900d97ea907d3f9459b2d79e7269ff","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2016-01-17T12:48:50Z","updated_at":"2016-01-17T12:48:50Z","html_url":"https://github.com/ontohub/ontohub/pull/1557#discussion_r49945785","pull_request_url":"https://api.github.com/repos/ontohub/ontohub/pulls/1557","_links":{"self":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/comments/49945785"},"html":{"href":"https://github.com/ontohub/ontohub/pull/1557#discussion_r49945785"},"pull_request":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/1557"}}},"pull_request":{"url":"https://api.github.com/repos/ontohub/ontohub/pulls/1557","id":55321052,"html_url":"https://github.com/ontohub/ontohub/pull/1557","diff_url":"https://github.com/ontohub/ontohub/pull/1557.diff","patch_url":"https://github.com/ontohub/ontohub/pull/1557.patch","issue_url":"https://api.github.com/repos/ontohub/ontohub/issues/1557","number":1557,"state":"open","locked":false,"title":"Refactor async helper","user":{"login":"eugenk","id":339751,"avatar_url":"https://avatars.githubusercontent.com/u/339751?v=3","gravatar_id":"","url":"https://api.github.com/users/eugenk","html_url":"https://github.com/eugenk","followers_url":"https://api.github.com/users/eugenk/followers","following_url":"https://api.github.com/users/eugenk/following{/other_user}","gists_url":"https://api.github.com/users/eugenk/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenk/subscriptions","organizations_url":"https://api.github.com/users/eugenk/orgs","repos_url":"https://api.github.com/users/eugenk/repos","events_url":"https://api.github.com/users/eugenk/events{/privacy}","received_events_url":"https://api.github.com/users/eugenk/received_events","type":"User","site_admin":false},"body":"This removes the `AsyncHelper`. By circumventing some Sidekiq mechanics, this module over-complicates the code and reduces performance.\r\n\r\nAfter this refactoring, every asynchronous call is done according to Sidekiq's best practices.\r\n\r\nAdditionally, we should finally get rid of the \"Ontology indefinitely pending\" problem because we don't schedule a parsing task to be executed at a defined point in time but rather use Sidekiq's `perfom_async` as we are supposed to do.\r\n\r\n--\r\n\r\n###### Todo if this gets merged:\r\n* [ ] Add issue for the `FIXME` comment: When parsing an Ontology, we wait a second for the SQL query to finish. This was also done before this refactoring, but it is not an appropriate solution.","created_at":"2016-01-07T10:18:26Z","updated_at":"2016-01-17T12:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91dc2f93454f1288d4c705dba6027b42c1ee4fb8","assignee":{"login":"SGraef","id":630027,"avatar_url":"https://avatars.githubusercontent.com/u/630027?v=3","gravatar_id":"","url":"https://api.github.com/users/SGraef","html_url":"https://github.com/SGraef","followers_url":"https://api.github.com/users/SGraef/followers","following_url":"https://api.github.com/users/SGraef/following{/other_user}","gists_url":"https://api.github.com/users/SGraef/gists{/gist_id}","starred_url":"https://api.github.com/users/SGraef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SGraef/subscriptions","organizations_url":"https://api.github.com/users/SGraef/orgs","repos_url":"https://api.github.com/users/SGraef/repos","events_url":"https://api.github.com/users/SGraef/events{/privacy}","received_events_url":"https://api.github.com/users/SGraef/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ontohub/ontohub/pulls/1557/commits","review_comments_url":"https://api.github.com/repos/ontohub/ontohub/pulls/1557/comments","review_comment_url":"https://api.github.com/repos/ontohub/ontohub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ontohub/ontohub/issues/1557/comments","statuses_url":"https://api.github.com/repos/ontohub/ontohub/statuses/a7ce8a0835900d97ea907d3f9459b2d79e7269ff","head":{"label":"ontohub:refactor_async_helper","ref":"refactor_async_helper","sha":"a7ce8a0835900d97ea907d3f9459b2d79e7269ff","user":{"login":"ontohub","id":1575984,"avatar_url":"https://avatars.githubusercontent.com/u/1575984?v=3","gravatar_id":"","url":"https://api.github.com/users/ontohub","html_url":"https://github.com/ontohub","followers_url":"https://api.github.com/users/ontohub/followers","following_url":"https://api.github.com/users/ontohub/following{/other_user}","gists_url":"https://api.github.com/users/ontohub/gists{/gist_id}","starred_url":"https://api.github.com/users/ontohub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ontohub/subscriptions","organizations_url":"https://api.github.com/users/ontohub/orgs","repos_url":"https://api.github.com/users/ontohub/repos","events_url":"https://api.github.com/users/ontohub/events{/privacy}","received_events_url":"https://api.github.com/users/ontohub/received_events","type":"Organization","site_admin":false},"repo":{"id":3643206,"name":"ontohub","full_name":"ontohub/ontohub","owner":{"login":"ontohub","id":1575984,"avatar_url":"https://avatars.githubusercontent.com/u/1575984?v=3","gravatar_id":"","url":"https://api.github.com/users/ontohub","html_url":"https://github.com/ontohub","followers_url":"https://api.github.com/users/ontohub/followers","following_url":"https://api.github.com/users/ontohub/following{/other_user}","gists_url":"https://api.github.com/users/ontohub/gists{/gist_id}","starred_url":"https://api.github.com/users/ontohub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ontohub/subscriptions","organizations_url":"https://api.github.com/users/ontohub/orgs","repos_url":"https://api.github.com/users/ontohub/repos","events_url":"https://api.github.com/users/ontohub/events{/privacy}","received_events_url":"https://api.github.com/users/ontohub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ontohub/ontohub","description":"A web-based repository for distributed ontologies.","fork":false,"url":"https://api.github.com/repos/ontohub/ontohub","forks_url":"https://api.github.com/repos/ontohub/ontohub/forks","keys_url":"https://api.github.com/repos/ontohub/ontohub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ontohub/ontohub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ontohub/ontohub/teams","hooks_url":"https://api.github.com/repos/ontohub/ontohub/hooks","issue_events_url":"https://api.github.com/repos/ontohub/ontohub/issues/events{/number}","events_url":"https://api.github.com/repos/ontohub/ontohub/events","assignees_url":"https://api.github.com/repos/ontohub/ontohub/assignees{/user}","branches_url":"https://api.github.com/repos/ontohub/ontohub/branches{/branch}","tags_url":"https://api.github.com/repos/ontohub/ontohub/tags","blobs_url":"https://api.github.com/repos/ontohub/ontohub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ontohub/ontohub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ontohub/ontohub/git/refs{/sha}","trees_url":"https://api.github.com/repos/ontohub/ontohub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ontohub/ontohub/statuses/{sha}","languages_url":"https://api.github.com/repos/ontohub/ontohub/languages","stargazers_url":"https://api.github.com/repos/ontohub/ontohub/stargazers","contributors_url":"https://api.github.com/repos/ontohub/ontohub/contributors","subscribers_url":"https://api.github.com/repos/ontohub/ontohub/subscribers","subscription_url":"https://api.github.com/repos/ontohub/ontohub/subscription","commits_url":"https://api.github.com/repos/ontohub/ontohub/commits{/sha}","git_commits_url":"https://api.github.com/repos/ontohub/ontohub/git/commits{/sha}","comments_url":"https://api.github.com/repos/ontohub/ontohub/comments{/number}","issue_comment_url":"https://api.github.com/repos/ontohub/ontohub/issues/comments{/number}","contents_url":"https://api.github.com/repos/ontohub/ontohub/contents/{+path}","compare_url":"https://api.github.com/repos/ontohub/ontohub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ontohub/ontohub/merges","archive_url":"https://api.github.com/repos/ontohub/ontohub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ontohub/ontohub/downloads","issues_url":"https://api.github.com/repos/ontohub/ontohub/issues{/number}","pulls_url":"https://api.github.com/repos/ontohub/ontohub/pulls{/number}","milestones_url":"https://api.github.com/repos/ontohub/ontohub/milestones{/number}","notifications_url":"https://api.github.com/repos/ontohub/ontohub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ontohub/ontohub/labels{/name}","releases_url":"https://api.github.com/repos/ontohub/ontohub/releases{/id}","created_at":"2012-03-06T22:05:27Z","updated_at":"2015-05-06T13:08:29Z","pushed_at":"2016-01-17T12:48:46Z","git_url":"git://github.com/ontohub/ontohub.git","ssh_url":"git@github.com:ontohub/ontohub.git","clone_url":"https://github.com/ontohub/ontohub.git","svn_url":"https://github.com/ontohub/ontohub","homepage":"","size":20915,"stargazers_count":20,"watchers_count":20,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":317,"forks":6,"open_issues":317,"watchers":20,"default_branch":"staging"}},"base":{"label":"ontohub:staging","ref":"staging","sha":"876a981f573c6982c65a61b801753c7a78286a22","user":{"login":"ontohub","id":1575984,"avatar_url":"https://avatars.githubusercontent.com/u/1575984?v=3","gravatar_id":"","url":"https://api.github.com/users/ontohub","html_url":"https://github.com/ontohub","followers_url":"https://api.github.com/users/ontohub/followers","following_url":"https://api.github.com/users/ontohub/following{/other_user}","gists_url":"https://api.github.com/users/ontohub/gists{/gist_id}","starred_url":"https://api.github.com/users/ontohub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ontohub/subscriptions","organizations_url":"https://api.github.com/users/ontohub/orgs","repos_url":"https://api.github.com/users/ontohub/repos","events_url":"https://api.github.com/users/ontohub/events{/privacy}","received_events_url":"https://api.github.com/users/ontohub/received_events","type":"Organization","site_admin":false},"repo":{"id":3643206,"name":"ontohub","full_name":"ontohub/ontohub","owner":{"login":"ontohub","id":1575984,"avatar_url":"https://avatars.githubusercontent.com/u/1575984?v=3","gravatar_id":"","url":"https://api.github.com/users/ontohub","html_url":"https://github.com/ontohub","followers_url":"https://api.github.com/users/ontohub/followers","following_url":"https://api.github.com/users/ontohub/following{/other_user}","gists_url":"https://api.github.com/users/ontohub/gists{/gist_id}","starred_url":"https://api.github.com/users/ontohub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ontohub/subscriptions","organizations_url":"https://api.github.com/users/ontohub/orgs","repos_url":"https://api.github.com/users/ontohub/repos","events_url":"https://api.github.com/users/ontohub/events{/privacy}","received_events_url":"https://api.github.com/users/ontohub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ontohub/ontohub","description":"A web-based repository for distributed ontologies.","fork":false,"url":"https://api.github.com/repos/ontohub/ontohub","forks_url":"https://api.github.com/repos/ontohub/ontohub/forks","keys_url":"https://api.github.com/repos/ontohub/ontohub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ontohub/ontohub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ontohub/ontohub/teams","hooks_url":"https://api.github.com/repos/ontohub/ontohub/hooks","issue_events_url":"https://api.github.com/repos/ontohub/ontohub/issues/events{/number}","events_url":"https://api.github.com/repos/ontohub/ontohub/events","assignees_url":"https://api.github.com/repos/ontohub/ontohub/assignees{/user}","branches_url":"https://api.github.com/repos/ontohub/ontohub/branches{/branch}","tags_url":"https://api.github.com/repos/ontohub/ontohub/tags","blobs_url":"https://api.github.com/repos/ontohub/ontohub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ontohub/ontohub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ontohub/ontohub/git/refs{/sha}","trees_url":"https://api.github.com/repos/ontohub/ontohub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ontohub/ontohub/statuses/{sha}","languages_url":"https://api.github.com/repos/ontohub/ontohub/languages","stargazers_url":"https://api.github.com/repos/ontohub/ontohub/stargazers","contributors_url":"https://api.github.com/repos/ontohub/ontohub/contributors","subscribers_url":"https://api.github.com/repos/ontohub/ontohub/subscribers","subscription_url":"https://api.github.com/repos/ontohub/ontohub/subscription","commits_url":"https://api.github.com/repos/ontohub/ontohub/commits{/sha}","git_commits_url":"https://api.github.com/repos/ontohub/ontohub/git/commits{/sha}","comments_url":"https://api.github.com/repos/ontohub/ontohub/comments{/number}","issue_comment_url":"https://api.github.com/repos/ontohub/ontohub/issues/comments{/number}","contents_url":"https://api.github.com/repos/ontohub/ontohub/contents/{+path}","compare_url":"https://api.github.com/repos/ontohub/ontohub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ontohub/ontohub/merges","archive_url":"https://api.github.com/repos/ontohub/ontohub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ontohub/ontohub/downloads","issues_url":"https://api.github.com/repos/ontohub/ontohub/issues{/number}","pulls_url":"https://api.github.com/repos/ontohub/ontohub/pulls{/number}","milestones_url":"https://api.github.com/repos/ontohub/ontohub/milestones{/number}","notifications_url":"https://api.github.com/repos/ontohub/ontohub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ontohub/ontohub/labels{/name}","releases_url":"https://api.github.com/repos/ontohub/ontohub/releases{/id}","created_at":"2012-03-06T22:05:27Z","updated_at":"2015-05-06T13:08:29Z","pushed_at":"2016-01-17T12:48:46Z","git_url":"git://github.com/ontohub/ontohub.git","ssh_url":"git@github.com:ontohub/ontohub.git","clone_url":"https://github.com/ontohub/ontohub.git","svn_url":"https://github.com/ontohub/ontohub","homepage":"","size":20915,"stargazers_count":20,"watchers_count":20,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":317,"forks":6,"open_issues":317,"watchers":20,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/1557"},"html":{"href":"https://github.com/ontohub/ontohub/pull/1557"},"issue":{"href":"https://api.github.com/repos/ontohub/ontohub/issues/1557"},"comments":{"href":"https://api.github.com/repos/ontohub/ontohub/issues/1557/comments"},"review_comments":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/1557/comments"},"review_comment":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ontohub/ontohub/pulls/1557/commits"},"statuses":{"href":"https://api.github.com/repos/ontohub/ontohub/statuses/a7ce8a0835900d97ea907d3f9459b2d79e7269ff"}}}}