{"action":"created","comment":{"url":"https://api.github.com/repos/openMVG/openMVG/pulls/comments/92197580","pull_request_review_id":12708337,"id":92197580,"diff_hunk":"@@ -57,10 +58,11 @@ void ImageCollectionGeometricFilter::Robust_model_estimation\n   const GeometryFunctor & functor,\n   const PairWiseMatches & putative_matches,\n   const bool b_guided_matching,\n-  const double d_distance_ratio\n+  const double d_distance_ratio,\n+  C_Progress& my_progress_bar\n )\n {\n-  C_Progress_display my_progress_bar( putative_matches.size() );\n+  my_progress_bar.restart( putative_matches.size(), \"\\n- Geometric filtering -\\n\" );\n \n #ifdef OPENMVG_USE_OPENMP\n #pragma omp parallel for schedule(dynamic)","path":"src/openMVG/matching_image_collection/GeometricFilter.hpp","position":23,"original_position":23,"commit_id":"1a6458e638ac8340b587e385f22b283ec37e9b11","original_commit_id":"60f65b5b5e6343094ec7ea357c5d0f357a786e37","user":{"login":"bjornpiltz","id":1873764,"avatar_url":"https://avatars.githubusercontent.com/u/1873764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornpiltz","html_url":"https://github.com/bjornpiltz","followers_url":"https://api.github.com/users/bjornpiltz/followers","following_url":"https://api.github.com/users/bjornpiltz/following{/other_user}","gists_url":"https://api.github.com/users/bjornpiltz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornpiltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornpiltz/subscriptions","organizations_url":"https://api.github.com/users/bjornpiltz/orgs","repos_url":"https://api.github.com/users/bjornpiltz/repos","events_url":"https://api.github.com/users/bjornpiltz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornpiltz/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-12-13T15:51:48Z","updated_at":"2016-12-13T16:02:04Z","html_url":"https://github.com/openMVG/openMVG/pull/674#discussion_r92197580","pull_request_url":"https://api.github.com/repos/openMVG/openMVG/pulls/674","_links":{"self":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/comments/92197580"},"html":{"href":"https://github.com/openMVG/openMVG/pull/674#discussion_r92197580"},"pull_request":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/openMVG/openMVG/pulls/674","id":93179018,"html_url":"https://github.com/openMVG/openMVG/pull/674","diff_url":"https://github.com/openMVG/openMVG/pull/674.diff","patch_url":"https://github.com/openMVG/openMVG/pull/674.patch","issue_url":"https://api.github.com/repos/openMVG/openMVG/issues/674","number":674,"state":"open","locked":false,"title":"Added interface to pass abstract C_Progress& to some functions.","user":{"login":"bjornpiltz","id":1873764,"avatar_url":"https://avatars.githubusercontent.com/u/1873764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornpiltz","html_url":"https://github.com/bjornpiltz","followers_url":"https://api.github.com/users/bjornpiltz/followers","following_url":"https://api.github.com/users/bjornpiltz/following{/other_user}","gists_url":"https://api.github.com/users/bjornpiltz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornpiltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornpiltz/subscriptions","organizations_url":"https://api.github.com/users/bjornpiltz/orgs","repos_url":"https://api.github.com/users/bjornpiltz/repos","events_url":"https://api.github.com/users/bjornpiltz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornpiltz/received_events","type":"User","site_admin":false},"body":"The idea is that the caller decides how to display progress. Ideally the class C_Progress_Display should not be found in any library code, but only used in the command line tools. See main_computeMatches.\r\nI also added a function hasBeenCanceled(), which should be checked periodically during long operations.","created_at":"2016-11-10T16:04:58Z","updated_at":"2016-12-13T16:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93d9cc36a4945ef13fe0479545e8c2488cf3c3c0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openMVG/openMVG/pulls/674/commits","review_comments_url":"https://api.github.com/repos/openMVG/openMVG/pulls/674/comments","review_comment_url":"https://api.github.com/repos/openMVG/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openMVG/openMVG/issues/674/comments","statuses_url":"https://api.github.com/repos/openMVG/openMVG/statuses/1a6458e638ac8340b587e385f22b283ec37e9b11","head":{"label":"bjornpiltz:develop","ref":"develop","sha":"1a6458e638ac8340b587e385f22b283ec37e9b11","user":{"login":"bjornpiltz","id":1873764,"avatar_url":"https://avatars.githubusercontent.com/u/1873764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornpiltz","html_url":"https://github.com/bjornpiltz","followers_url":"https://api.github.com/users/bjornpiltz/followers","following_url":"https://api.github.com/users/bjornpiltz/following{/other_user}","gists_url":"https://api.github.com/users/bjornpiltz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornpiltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornpiltz/subscriptions","organizations_url":"https://api.github.com/users/bjornpiltz/orgs","repos_url":"https://api.github.com/users/bjornpiltz/repos","events_url":"https://api.github.com/users/bjornpiltz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornpiltz/received_events","type":"User","site_admin":false},"repo":{"id":73362696,"name":"openMVG","full_name":"bjornpiltz/openMVG","owner":{"login":"bjornpiltz","id":1873764,"avatar_url":"https://avatars.githubusercontent.com/u/1873764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornpiltz","html_url":"https://github.com/bjornpiltz","followers_url":"https://api.github.com/users/bjornpiltz/followers","following_url":"https://api.github.com/users/bjornpiltz/following{/other_user}","gists_url":"https://api.github.com/users/bjornpiltz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornpiltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornpiltz/subscriptions","organizations_url":"https://api.github.com/users/bjornpiltz/orgs","repos_url":"https://api.github.com/users/bjornpiltz/repos","events_url":"https://api.github.com/users/bjornpiltz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornpiltz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjornpiltz/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/bjornpiltz/openMVG","forks_url":"https://api.github.com/repos/bjornpiltz/openMVG/forks","keys_url":"https://api.github.com/repos/bjornpiltz/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjornpiltz/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjornpiltz/openMVG/teams","hooks_url":"https://api.github.com/repos/bjornpiltz/openMVG/hooks","issue_events_url":"https://api.github.com/repos/bjornpiltz/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/bjornpiltz/openMVG/events","assignees_url":"https://api.github.com/repos/bjornpiltz/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/bjornpiltz/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/bjornpiltz/openMVG/tags","blobs_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjornpiltz/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/bjornpiltz/openMVG/languages","stargazers_url":"https://api.github.com/repos/bjornpiltz/openMVG/stargazers","contributors_url":"https://api.github.com/repos/bjornpiltz/openMVG/contributors","subscribers_url":"https://api.github.com/repos/bjornpiltz/openMVG/subscribers","subscription_url":"https://api.github.com/repos/bjornpiltz/openMVG/subscription","commits_url":"https://api.github.com/repos/bjornpiltz/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjornpiltz/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjornpiltz/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjornpiltz/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/bjornpiltz/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjornpiltz/openMVG/merges","archive_url":"https://api.github.com/repos/bjornpiltz/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjornpiltz/openMVG/downloads","issues_url":"https://api.github.com/repos/bjornpiltz/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/bjornpiltz/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/bjornpiltz/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/bjornpiltz/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjornpiltz/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/bjornpiltz/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/bjornpiltz/openMVG/deployments","created_at":"2016-11-10T08:40:38Z","updated_at":"2016-11-10T08:40:41Z","pushed_at":"2016-12-13T15:51:26Z","git_url":"git://github.com/bjornpiltz/openMVG.git","ssh_url":"git@github.com:bjornpiltz/openMVG.git","clone_url":"https://github.com/bjornpiltz/openMVG.git","svn_url":"https://github.com/bjornpiltz/openMVG","homepage":"","size":23146,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openMVG:develop","ref":"develop","sha":"853a628fd9371f47c12af3e963a035880fa6b233","user":{"login":"openMVG","id":3512104,"avatar_url":"https://avatars.githubusercontent.com/u/3512104?v=3","gravatar_id":"","url":"https://api.github.com/users/openMVG","html_url":"https://github.com/openMVG","followers_url":"https://api.github.com/users/openMVG/followers","following_url":"https://api.github.com/users/openMVG/following{/other_user}","gists_url":"https://api.github.com/users/openMVG/gists{/gist_id}","starred_url":"https://api.github.com/users/openMVG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMVG/subscriptions","organizations_url":"https://api.github.com/users/openMVG/orgs","repos_url":"https://api.github.com/users/openMVG/repos","events_url":"https://api.github.com/users/openMVG/events{/privacy}","received_events_url":"https://api.github.com/users/openMVG/received_events","type":"Organization","site_admin":false},"repo":{"id":8096326,"name":"openMVG","full_name":"openMVG/openMVG","owner":{"login":"openMVG","id":3512104,"avatar_url":"https://avatars.githubusercontent.com/u/3512104?v=3","gravatar_id":"","url":"https://api.github.com/users/openMVG","html_url":"https://github.com/openMVG","followers_url":"https://api.github.com/users/openMVG/followers","following_url":"https://api.github.com/users/openMVG/following{/other_user}","gists_url":"https://api.github.com/users/openMVG/gists{/gist_id}","starred_url":"https://api.github.com/users/openMVG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMVG/subscriptions","organizations_url":"https://api.github.com/users/openMVG/orgs","repos_url":"https://api.github.com/users/openMVG/repos","events_url":"https://api.github.com/users/openMVG/events{/privacy}","received_events_url":"https://api.github.com/users/openMVG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openMVG/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":false,"url":"https://api.github.com/repos/openMVG/openMVG","forks_url":"https://api.github.com/repos/openMVG/openMVG/forks","keys_url":"https://api.github.com/repos/openMVG/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openMVG/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openMVG/openMVG/teams","hooks_url":"https://api.github.com/repos/openMVG/openMVG/hooks","issue_events_url":"https://api.github.com/repos/openMVG/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/openMVG/openMVG/events","assignees_url":"https://api.github.com/repos/openMVG/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/openMVG/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/openMVG/openMVG/tags","blobs_url":"https://api.github.com/repos/openMVG/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openMVG/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openMVG/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/openMVG/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openMVG/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/openMVG/openMVG/languages","stargazers_url":"https://api.github.com/repos/openMVG/openMVG/stargazers","contributors_url":"https://api.github.com/repos/openMVG/openMVG/contributors","subscribers_url":"https://api.github.com/repos/openMVG/openMVG/subscribers","subscription_url":"https://api.github.com/repos/openMVG/openMVG/subscription","commits_url":"https://api.github.com/repos/openMVG/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/openMVG/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/openMVG/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/openMVG/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/openMVG/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/openMVG/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openMVG/openMVG/merges","archive_url":"https://api.github.com/repos/openMVG/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openMVG/openMVG/downloads","issues_url":"https://api.github.com/repos/openMVG/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/openMVG/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/openMVG/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/openMVG/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openMVG/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/openMVG/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/openMVG/openMVG/deployments","created_at":"2013-02-08T16:01:08Z","updated_at":"2016-12-11T21:14:22Z","pushed_at":"2016-12-13T15:51:27Z","git_url":"git://github.com/openMVG/openMVG.git","ssh_url":"git@github.com:openMVG/openMVG.git","clone_url":"https://github.com/openMVG/openMVG.git","svn_url":"https://github.com/openMVG/openMVG","homepage":"","size":27318,"stargazers_count":875,"watchers_count":875,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":419,"mirror_url":null,"open_issues_count":51,"forks":419,"open_issues":51,"watchers":875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/674"},"html":{"href":"https://github.com/openMVG/openMVG/pull/674"},"issue":{"href":"https://api.github.com/repos/openMVG/openMVG/issues/674"},"comments":{"href":"https://api.github.com/repos/openMVG/openMVG/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/openMVG/openMVG/statuses/1a6458e638ac8340b587e385f22b283ec37e9b11"}}}}
{"actor":{"display_login":"bjornpiltz"}}