{"action":"created","issue":{"url":"https://api.github.com/repos/reddit/reddit-mobile/issues/772","repository_url":"https://api.github.com/repos/reddit/reddit-mobile","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/772/labels{/name}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/772/comments","events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/772/events","html_url":"https://github.com/reddit/reddit-mobile/pull/772","id":179438009,"number":772,"title":"Fix error handling for Register","user":{"login":"jamesmaa","id":2382537,"avatar_url":"https://avatars.githubusercontent.com/u/2382537?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesmaa","html_url":"https://github.com/jamesmaa","followers_url":"https://api.github.com/users/jamesmaa/followers","following_url":"https://api.github.com/users/jamesmaa/following{/other_user}","gists_url":"https://api.github.com/users/jamesmaa/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmaa/subscriptions","organizations_url":"https://api.github.com/users/jamesmaa/orgs","repos_url":"https://api.github.com/users/jamesmaa/repos","events_url":"https://api.github.com/users/jamesmaa/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmaa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-27T09:13:34Z","updated_at":"2016-09-27T18:14:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/772","html_url":"https://github.com/reddit/reddit-mobile/pull/772","diff_url":"https://github.com/reddit/reddit-mobile/pull/772.diff","patch_url":"https://github.com/reddit/reddit-mobile/pull/772.patch"},"body":"I looked into the koa docs and found some examples I was modeling off of. It seems to produce simpler and more readable code and it works.\r\n\r\nhttps://github.com/koajs/koa#koa-v2\r\nhttp://stackoverflow.com/questions/22059775/using-callbacks-with-nodejs-in-koa\r\n\r\nThe problem with the Login error handling fix is that ultimately it is convoluted to differentiate between different types of errors, and requires additional JSON parsing.\r\n\r\nHappy to discuss whether this is the right approach or not\r\n\r\n👓 @phil303 "},"comment":{"url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments/249950329","html_url":"https://github.com/reddit/reddit-mobile/pull/772#issuecomment-249950329","issue_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/772","id":249950329,"user":{"login":"phil303","id":787203,"avatar_url":"https://avatars.githubusercontent.com/u/787203?v=3","gravatar_id":"","url":"https://api.github.com/users/phil303","html_url":"https://github.com/phil303","followers_url":"https://api.github.com/users/phil303/followers","following_url":"https://api.github.com/users/phil303/following{/other_user}","gists_url":"https://api.github.com/users/phil303/gists{/gist_id}","starred_url":"https://api.github.com/users/phil303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil303/subscriptions","organizations_url":"https://api.github.com/users/phil303/orgs","repos_url":"https://api.github.com/users/phil303/repos","events_url":"https://api.github.com/users/phil303/events{/privacy}","received_events_url":"https://api.github.com/users/phil303/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T18:14:32Z","updated_at":"2016-09-27T18:14:32Z","body":":nail_care: small comments and give a chance for @schwers to weigh in "}}
{"actor":{"display_login":"phil303"}}