{"action":"created","comment":{"url":"https://api.github.com/repos/habitat-sh/habitat/pulls/comments/80941097","pull_request_review_id":1958257,"id":80941097,"diff_hunk":"@@ -345,20 +368,20 @@ impl Cfg {\n     }\n \n     fn to_toml(&self) -> toml::Value {\n-        let mut left = toml::Table::new();\n-        if let Some(toml::Value::Table(ref right)) = self.default {\n-            left = toml_merge(&left, right);\n+        let mut output_toml = toml::Table::new();","path":"components/sup/src/service_config.rs","position":44,"original_position":44,"commit_id":"c14643be4b8439f2da1dd9b737169ac84f5da1dd","original_commit_id":"c14643be4b8439f2da1dd9b737169ac84f5da1dd","user":{"login":"metadave","id":58244,"avatar_url":"https://avatars.githubusercontent.com/u/58244?v=3","gravatar_id":"","url":"https://api.github.com/users/metadave","html_url":"https://github.com/metadave","followers_url":"https://api.github.com/users/metadave/followers","following_url":"https://api.github.com/users/metadave/following{/other_user}","gists_url":"https://api.github.com/users/metadave/gists{/gist_id}","starred_url":"https://api.github.com/users/metadave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metadave/subscriptions","organizations_url":"https://api.github.com/users/metadave/orgs","repos_url":"https://api.github.com/users/metadave/repos","events_url":"https://api.github.com/users/metadave/events{/privacy}","received_events_url":"https://api.github.com/users/metadave/received_events","type":"User","site_admin":false},"body":"actually, all the vars in this block have better names, thank you!","created_at":"2016-09-28T15:11:34Z","updated_at":"2016-09-28T15:11:34Z","html_url":"https://github.com/habitat-sh/habitat/pull/1294#discussion_r80941097","pull_request_url":"https://api.github.com/repos/habitat-sh/habitat/pulls/1294","_links":{"self":{"href":"https://api.github.com/repos/habitat-sh/habitat/pulls/comments/80941097"},"html":{"href":"https://github.com/habitat-sh/habitat/pull/1294#discussion_r80941097"},"pull_request":{"href":"https://api.github.com/repos/habitat-sh/habitat/pulls/1294"}}},"pull_request":{"url":"https://api.github.com/repos/habitat-sh/habitat/pulls/1294","id":87139404,"html_url":"https://github.com/habitat-sh/habitat/pull/1294","diff_url":"https://github.com/habitat-sh/habitat/pull/1294.diff","patch_url":"https://github.com/habitat-sh/habitat/pull/1294.patch","issue_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1294","number":1294,"state":"open","locked":false,"title":"service_config::toml_merge handles toml::Tables (rebased w/ changed order)","user":{"login":"robbkidd","id":517302,"avatar_url":"https://avatars.githubusercontent.com/u/517302?v=3","gravatar_id":"","url":"https://api.github.com/users/robbkidd","html_url":"https://github.com/robbkidd","followers_url":"https://api.github.com/users/robbkidd/followers","following_url":"https://api.github.com/users/robbkidd/following{/other_user}","gists_url":"https://api.github.com/users/robbkidd/gists{/gist_id}","starred_url":"https://api.github.com/users/robbkidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbkidd/subscriptions","organizations_url":"https://api.github.com/users/robbkidd/orgs","repos_url":"https://api.github.com/users/robbkidd/repos","events_url":"https://api.github.com/users/robbkidd/events{/privacy}","received_events_url":"https://api.github.com/users/robbkidd/received_events","type":"User","site_admin":false},"body":"Rebased @metadave's `dp_toml_merge_table_fix` branch from #1185 and added on a fix for config value precedence in the merge. \r\n\r\nI'm not sure how to re-add the \"types mismatch in config _values_\" test, though.","created_at":"2016-09-28T15:07:52Z","updated_at":"2016-09-28T15:11:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cef35c1c70b87b0e8462166b67f79428d64507c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/habitat-sh/habitat/pulls/1294/commits","review_comments_url":"https://api.github.com/repos/habitat-sh/habitat/pulls/1294/comments","review_comment_url":"https://api.github.com/repos/habitat-sh/habitat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1294/comments","statuses_url":"https://api.github.com/repos/habitat-sh/habitat/statuses/c14643be4b8439f2da1dd9b737169ac84f5da1dd","head":{"label":"robbkidd:dp_toml_merge_table_fix","ref":"dp_toml_merge_table_fix","sha":"c14643be4b8439f2da1dd9b737169ac84f5da1dd","user":{"login":"robbkidd","id":517302,"avatar_url":"https://avatars.githubusercontent.com/u/517302?v=3","gravatar_id":"","url":"https://api.github.com/users/robbkidd","html_url":"https://github.com/robbkidd","followers_url":"https://api.github.com/users/robbkidd/followers","following_url":"https://api.github.com/users/robbkidd/following{/other_user}","gists_url":"https://api.github.com/users/robbkidd/gists{/gist_id}","starred_url":"https://api.github.com/users/robbkidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbkidd/subscriptions","organizations_url":"https://api.github.com/users/robbkidd/orgs","repos_url":"https://api.github.com/users/robbkidd/repos","events_url":"https://api.github.com/users/robbkidd/events{/privacy}","received_events_url":"https://api.github.com/users/robbkidd/received_events","type":"User","site_admin":false},"repo":{"id":69362372,"name":"habitat","full_name":"robbkidd/habitat","owner":{"login":"robbkidd","id":517302,"avatar_url":"https://avatars.githubusercontent.com/u/517302?v=3","gravatar_id":"","url":"https://api.github.com/users/robbkidd","html_url":"https://github.com/robbkidd","followers_url":"https://api.github.com/users/robbkidd/followers","following_url":"https://api.github.com/users/robbkidd/following{/other_user}","gists_url":"https://api.github.com/users/robbkidd/gists{/gist_id}","starred_url":"https://api.github.com/users/robbkidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbkidd/subscriptions","organizations_url":"https://api.github.com/users/robbkidd/orgs","repos_url":"https://api.github.com/users/robbkidd/repos","events_url":"https://api.github.com/users/robbkidd/events{/privacy}","received_events_url":"https://api.github.com/users/robbkidd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robbkidd/habitat","description":"Modern applications with built-in automation","fork":true,"url":"https://api.github.com/repos/robbkidd/habitat","forks_url":"https://api.github.com/repos/robbkidd/habitat/forks","keys_url":"https://api.github.com/repos/robbkidd/habitat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robbkidd/habitat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robbkidd/habitat/teams","hooks_url":"https://api.github.com/repos/robbkidd/habitat/hooks","issue_events_url":"https://api.github.com/repos/robbkidd/habitat/issues/events{/number}","events_url":"https://api.github.com/repos/robbkidd/habitat/events","assignees_url":"https://api.github.com/repos/robbkidd/habitat/assignees{/user}","branches_url":"https://api.github.com/repos/robbkidd/habitat/branches{/branch}","tags_url":"https://api.github.com/repos/robbkidd/habitat/tags","blobs_url":"https://api.github.com/repos/robbkidd/habitat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robbkidd/habitat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robbkidd/habitat/git/refs{/sha}","trees_url":"https://api.github.com/repos/robbkidd/habitat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robbkidd/habitat/statuses/{sha}","languages_url":"https://api.github.com/repos/robbkidd/habitat/languages","stargazers_url":"https://api.github.com/repos/robbkidd/habitat/stargazers","contributors_url":"https://api.github.com/repos/robbkidd/habitat/contributors","subscribers_url":"https://api.github.com/repos/robbkidd/habitat/subscribers","subscription_url":"https://api.github.com/repos/robbkidd/habitat/subscription","commits_url":"https://api.github.com/repos/robbkidd/habitat/commits{/sha}","git_commits_url":"https://api.github.com/repos/robbkidd/habitat/git/commits{/sha}","comments_url":"https://api.github.com/repos/robbkidd/habitat/comments{/number}","issue_comment_url":"https://api.github.com/repos/robbkidd/habitat/issues/comments{/number}","contents_url":"https://api.github.com/repos/robbkidd/habitat/contents/{+path}","compare_url":"https://api.github.com/repos/robbkidd/habitat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robbkidd/habitat/merges","archive_url":"https://api.github.com/repos/robbkidd/habitat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robbkidd/habitat/downloads","issues_url":"https://api.github.com/repos/robbkidd/habitat/issues{/number}","pulls_url":"https://api.github.com/repos/robbkidd/habitat/pulls{/number}","milestones_url":"https://api.github.com/repos/robbkidd/habitat/milestones{/number}","notifications_url":"https://api.github.com/repos/robbkidd/habitat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robbkidd/habitat/labels{/name}","releases_url":"https://api.github.com/repos/robbkidd/habitat/releases{/id}","deployments_url":"https://api.github.com/repos/robbkidd/habitat/deployments","created_at":"2016-09-27T13:56:27Z","updated_at":"2016-09-27T13:56:30Z","pushed_at":"2016-09-28T03:05:16Z","git_url":"git://github.com/robbkidd/habitat.git","ssh_url":"git@github.com:robbkidd/habitat.git","clone_url":"https://github.com/robbkidd/habitat.git","svn_url":"https://github.com/robbkidd/habitat","homepage":"https://www.habitat.sh","size":37792,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"habitat-sh:master","ref":"master","sha":"ae07b682e5a94194ae1edf8217ebbca9da1d9146","user":{"login":"habitat-sh","id":18171698,"avatar_url":"https://avatars.githubusercontent.com/u/18171698?v=3","gravatar_id":"","url":"https://api.github.com/users/habitat-sh","html_url":"https://github.com/habitat-sh","followers_url":"https://api.github.com/users/habitat-sh/followers","following_url":"https://api.github.com/users/habitat-sh/following{/other_user}","gists_url":"https://api.github.com/users/habitat-sh/gists{/gist_id}","starred_url":"https://api.github.com/users/habitat-sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/habitat-sh/subscriptions","organizations_url":"https://api.github.com/users/habitat-sh/orgs","repos_url":"https://api.github.com/users/habitat-sh/repos","events_url":"https://api.github.com/users/habitat-sh/events{/privacy}","received_events_url":"https://api.github.com/users/habitat-sh/received_events","type":"Organization","site_admin":false},"repo":{"id":36098429,"name":"habitat","full_name":"habitat-sh/habitat","owner":{"login":"habitat-sh","id":18171698,"avatar_url":"https://avatars.githubusercontent.com/u/18171698?v=3","gravatar_id":"","url":"https://api.github.com/users/habitat-sh","html_url":"https://github.com/habitat-sh","followers_url":"https://api.github.com/users/habitat-sh/followers","following_url":"https://api.github.com/users/habitat-sh/following{/other_user}","gists_url":"https://api.github.com/users/habitat-sh/gists{/gist_id}","starred_url":"https://api.github.com/users/habitat-sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/habitat-sh/subscriptions","organizations_url":"https://api.github.com/users/habitat-sh/orgs","repos_url":"https://api.github.com/users/habitat-sh/repos","events_url":"https://api.github.com/users/habitat-sh/events{/privacy}","received_events_url":"https://api.github.com/users/habitat-sh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/habitat-sh/habitat","description":"Modern applications with built-in automation","fork":false,"url":"https://api.github.com/repos/habitat-sh/habitat","forks_url":"https://api.github.com/repos/habitat-sh/habitat/forks","keys_url":"https://api.github.com/repos/habitat-sh/habitat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/habitat-sh/habitat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/habitat-sh/habitat/teams","hooks_url":"https://api.github.com/repos/habitat-sh/habitat/hooks","issue_events_url":"https://api.github.com/repos/habitat-sh/habitat/issues/events{/number}","events_url":"https://api.github.com/repos/habitat-sh/habitat/events","assignees_url":"https://api.github.com/repos/habitat-sh/habitat/assignees{/user}","branches_url":"https://api.github.com/repos/habitat-sh/habitat/branches{/branch}","tags_url":"https://api.github.com/repos/habitat-sh/habitat/tags","blobs_url":"https://api.github.com/repos/habitat-sh/habitat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/habitat-sh/habitat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/habitat-sh/habitat/git/refs{/sha}","trees_url":"https://api.github.com/repos/habitat-sh/habitat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/habitat-sh/habitat/statuses/{sha}","languages_url":"https://api.github.com/repos/habitat-sh/habitat/languages","stargazers_url":"https://api.github.com/repos/habitat-sh/habitat/stargazers","contributors_url":"https://api.github.com/repos/habitat-sh/habitat/contributors","subscribers_url":"https://api.github.com/repos/habitat-sh/habitat/subscribers","subscription_url":"https://api.github.com/repos/habitat-sh/habitat/subscription","commits_url":"https://api.github.com/repos/habitat-sh/habitat/commits{/sha}","git_commits_url":"https://api.github.com/repos/habitat-sh/habitat/git/commits{/sha}","comments_url":"https://api.github.com/repos/habitat-sh/habitat/comments{/number}","issue_comment_url":"https://api.github.com/repos/habitat-sh/habitat/issues/comments{/number}","contents_url":"https://api.github.com/repos/habitat-sh/habitat/contents/{+path}","compare_url":"https://api.github.com/repos/habitat-sh/habitat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/habitat-sh/habitat/merges","archive_url":"https://api.github.com/repos/habitat-sh/habitat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/habitat-sh/habitat/downloads","issues_url":"https://api.github.com/repos/habitat-sh/habitat/issues{/number}","pulls_url":"https://api.github.com/repos/habitat-sh/habitat/pulls{/number}","milestones_url":"https://api.github.com/repos/habitat-sh/habitat/milestones{/number}","notifications_url":"https://api.github.com/repos/habitat-sh/habitat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/habitat-sh/habitat/labels{/name}","releases_url":"https://api.github.com/repos/habitat-sh/habitat/releases{/id}","deployments_url":"https://api.github.com/repos/habitat-sh/habitat/deployments","created_at":"2015-05-22T22:47:14Z","updated_at":"2016-09-28T07:39:56Z","pushed_at":"2016-09-28T15:07:52Z","git_url":"git://github.com/habitat-sh/habitat.git","ssh_url":"git@github.com:habitat-sh/habitat.git","clone_url":"https://github.com/habitat-sh/habitat.git","svn_url":"https://github.com/habitat-sh/habitat","homepage":"https://www.habitat.sh","size":38428,"stargazers_count":847,"watchers_count":847,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":89,"forks":101,"open_issues":89,"watchers":847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/habitat-sh/habitat/pulls/1294"},"html":{"href":"https://github.com/habitat-sh/habitat/pull/1294"},"issue":{"href":"https://api.github.com/repos/habitat-sh/habitat/issues/1294"},"comments":{"href":"https://api.github.com/repos/habitat-sh/habitat/issues/1294/comments"},"review_comments":{"href":"https://api.github.com/repos/habitat-sh/habitat/pulls/1294/comments"},"review_comment":{"href":"https://api.github.com/repos/habitat-sh/habitat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/habitat-sh/habitat/pulls/1294/commits"},"statuses":{"href":"https://api.github.com/repos/habitat-sh/habitat/statuses/c14643be4b8439f2da1dd9b737169ac84f5da1dd"}}}}
{"actor":{"display_login":"metadave"}}