{"action":"created","comment":{"url":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/comments/60637819","id":60637819,"diff_hunk":"@@ -41,44 +66,15 @@ findFile() {\n }\n \n # Recursively search input directory for a package.json\n-PACKAGE_PATH=$(findFile \"package.json\" $OUTPUT_DIR)\n+PACKAGE_PATH=$(findFile \"package.json\" $OUTPUT_DIR/bundle)\n \n if [[ $PACKAGE_PATH ]]; then\n   printf \"Package found: ${PACKAGE_PATH/$OUTPUT_DIR/}\\n\"","path":"bin/build","position":55,"original_position":55,"commit_id":"f1d7556853dc848b256731ee4cfa226339ed724b","original_commit_id":"f1d7556853dc848b256731ee4cfa226339ed724b","user":{"login":"harlanj","id":1561133,"avatar_url":"https://avatars.githubusercontent.com/u/1561133?v=3","gravatar_id":"","url":"https://api.github.com/users/harlanj","html_url":"https://github.com/harlanj","followers_url":"https://api.github.com/users/harlanj/followers","following_url":"https://api.github.com/users/harlanj/following{/other_user}","gists_url":"https://api.github.com/users/harlanj/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanj/subscriptions","organizations_url":"https://api.github.com/users/harlanj/orgs","repos_url":"https://api.github.com/users/harlanj/repos","events_url":"https://api.github.com/users/harlanj/events{/privacy}","received_events_url":"https://api.github.com/users/harlanj/received_events","type":"User","site_admin":false},"body":"I agree. I could remove that `printf` line","created_at":"2016-04-21T19:05:22Z","updated_at":"2016-04-21T19:05:22Z","html_url":"https://github.com/onmodulus/docker-build-meteor/pull/12#discussion_r60637819","pull_request_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/comments/60637819"},"html":{"href":"https://github.com/onmodulus/docker-build-meteor/pull/12#discussion_r60637819"},"pull_request":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/12","id":66878857,"html_url":"https://github.com/onmodulus/docker-build-meteor/pull/12","diff_url":"https://github.com/onmodulus/docker-build-meteor/pull/12.diff","patch_url":"https://github.com/onmodulus/docker-build-meteor/pull/12.patch","issue_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues/12","number":12,"state":"open","locked":false,"title":"Install root package.json modules before demeteorizing","user":{"login":"harlanj","id":1561133,"avatar_url":"https://avatars.githubusercontent.com/u/1561133?v=3","gravatar_id":"","url":"https://api.github.com/users/harlanj","html_url":"https://github.com/harlanj","followers_url":"https://api.github.com/users/harlanj/followers","following_url":"https://api.github.com/users/harlanj/following{/other_user}","gists_url":"https://api.github.com/users/harlanj/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanj/subscriptions","organizations_url":"https://api.github.com/users/harlanj/orgs","repos_url":"https://api.github.com/users/harlanj/repos","events_url":"https://api.github.com/users/harlanj/events{/privacy}","received_events_url":"https://api.github.com/users/harlanj/received_events","type":"User","site_admin":false},"body":"- Install root `package.json` modules\r\n- Copy over `node_modules` directory to `$OUTPUT_DIR`\r\n\r\n- [x] Build image\r\n- [x] Test on staging","created_at":"2016-04-18T16:02:48Z","updated_at":"2016-04-21T19:05:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f540a1b4ced6cd09d0a00ce235f091f412da048","assignee":{"login":"harlanj","id":1561133,"avatar_url":"https://avatars.githubusercontent.com/u/1561133?v=3","gravatar_id":"","url":"https://api.github.com/users/harlanj","html_url":"https://github.com/harlanj","followers_url":"https://api.github.com/users/harlanj/followers","following_url":"https://api.github.com/users/harlanj/following{/other_user}","gists_url":"https://api.github.com/users/harlanj/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanj/subscriptions","organizations_url":"https://api.github.com/users/harlanj/orgs","repos_url":"https://api.github.com/users/harlanj/repos","events_url":"https://api.github.com/users/harlanj/events{/privacy}","received_events_url":"https://api.github.com/users/harlanj/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/12/commits","review_comments_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/12/comments","review_comment_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues/12/comments","statuses_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/statuses/f1d7556853dc848b256731ee4cfa226339ed724b","head":{"label":"onmodulus:enhacement/install-root-package-json","ref":"enhacement/install-root-package-json","sha":"f1d7556853dc848b256731ee4cfa226339ed724b","user":{"login":"onmodulus","id":1659483,"avatar_url":"https://avatars.githubusercontent.com/u/1659483?v=3","gravatar_id":"","url":"https://api.github.com/users/onmodulus","html_url":"https://github.com/onmodulus","followers_url":"https://api.github.com/users/onmodulus/followers","following_url":"https://api.github.com/users/onmodulus/following{/other_user}","gists_url":"https://api.github.com/users/onmodulus/gists{/gist_id}","starred_url":"https://api.github.com/users/onmodulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmodulus/subscriptions","organizations_url":"https://api.github.com/users/onmodulus/orgs","repos_url":"https://api.github.com/users/onmodulus/repos","events_url":"https://api.github.com/users/onmodulus/events{/privacy}","received_events_url":"https://api.github.com/users/onmodulus/received_events","type":"Organization","site_admin":false},"repo":{"id":53975092,"name":"docker-build-meteor","full_name":"onmodulus/docker-build-meteor","owner":{"login":"onmodulus","id":1659483,"avatar_url":"https://avatars.githubusercontent.com/u/1659483?v=3","gravatar_id":"","url":"https://api.github.com/users/onmodulus","html_url":"https://github.com/onmodulus","followers_url":"https://api.github.com/users/onmodulus/followers","following_url":"https://api.github.com/users/onmodulus/following{/other_user}","gists_url":"https://api.github.com/users/onmodulus/gists{/gist_id}","starred_url":"https://api.github.com/users/onmodulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmodulus/subscriptions","organizations_url":"https://api.github.com/users/onmodulus/orgs","repos_url":"https://api.github.com/users/onmodulus/repos","events_url":"https://api.github.com/users/onmodulus/events{/privacy}","received_events_url":"https://api.github.com/users/onmodulus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onmodulus/docker-build-meteor","description":"The Docker build image for Modulus Meteor applications. ","fork":false,"url":"https://api.github.com/repos/onmodulus/docker-build-meteor","forks_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/forks","keys_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/teams","hooks_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/hooks","issue_events_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues/events{/number}","events_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/events","assignees_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/assignees{/user}","branches_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/branches{/branch}","tags_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/tags","blobs_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/languages","stargazers_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/stargazers","contributors_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/contributors","subscribers_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/subscribers","subscription_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/subscription","commits_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/contents/{+path}","compare_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/merges","archive_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/downloads","issues_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues{/number}","pulls_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/labels{/name}","releases_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/releases{/id}","deployments_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/deployments","created_at":"2016-03-15T20:10:26Z","updated_at":"2016-04-16T18:33:12Z","pushed_at":"2016-04-21T17:04:32Z","git_url":"git://github.com/onmodulus/docker-build-meteor.git","ssh_url":"git@github.com:onmodulus/docker-build-meteor.git","clone_url":"https://github.com/onmodulus/docker-build-meteor.git","svn_url":"https://github.com/onmodulus/docker-build-meteor","homepage":null,"size":47,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"onmodulus:master","ref":"master","sha":"8294b655820c194247f12764d8ec66c14bf43d9c","user":{"login":"onmodulus","id":1659483,"avatar_url":"https://avatars.githubusercontent.com/u/1659483?v=3","gravatar_id":"","url":"https://api.github.com/users/onmodulus","html_url":"https://github.com/onmodulus","followers_url":"https://api.github.com/users/onmodulus/followers","following_url":"https://api.github.com/users/onmodulus/following{/other_user}","gists_url":"https://api.github.com/users/onmodulus/gists{/gist_id}","starred_url":"https://api.github.com/users/onmodulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmodulus/subscriptions","organizations_url":"https://api.github.com/users/onmodulus/orgs","repos_url":"https://api.github.com/users/onmodulus/repos","events_url":"https://api.github.com/users/onmodulus/events{/privacy}","received_events_url":"https://api.github.com/users/onmodulus/received_events","type":"Organization","site_admin":false},"repo":{"id":53975092,"name":"docker-build-meteor","full_name":"onmodulus/docker-build-meteor","owner":{"login":"onmodulus","id":1659483,"avatar_url":"https://avatars.githubusercontent.com/u/1659483?v=3","gravatar_id":"","url":"https://api.github.com/users/onmodulus","html_url":"https://github.com/onmodulus","followers_url":"https://api.github.com/users/onmodulus/followers","following_url":"https://api.github.com/users/onmodulus/following{/other_user}","gists_url":"https://api.github.com/users/onmodulus/gists{/gist_id}","starred_url":"https://api.github.com/users/onmodulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmodulus/subscriptions","organizations_url":"https://api.github.com/users/onmodulus/orgs","repos_url":"https://api.github.com/users/onmodulus/repos","events_url":"https://api.github.com/users/onmodulus/events{/privacy}","received_events_url":"https://api.github.com/users/onmodulus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onmodulus/docker-build-meteor","description":"The Docker build image for Modulus Meteor applications. ","fork":false,"url":"https://api.github.com/repos/onmodulus/docker-build-meteor","forks_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/forks","keys_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/teams","hooks_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/hooks","issue_events_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues/events{/number}","events_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/events","assignees_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/assignees{/user}","branches_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/branches{/branch}","tags_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/tags","blobs_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/languages","stargazers_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/stargazers","contributors_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/contributors","subscribers_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/subscribers","subscription_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/subscription","commits_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/contents/{+path}","compare_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/merges","archive_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/downloads","issues_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues{/number}","pulls_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/labels{/name}","releases_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/releases{/id}","deployments_url":"https://api.github.com/repos/onmodulus/docker-build-meteor/deployments","created_at":"2016-03-15T20:10:26Z","updated_at":"2016-04-16T18:33:12Z","pushed_at":"2016-04-21T17:04:32Z","git_url":"git://github.com/onmodulus/docker-build-meteor.git","ssh_url":"git@github.com:onmodulus/docker-build-meteor.git","clone_url":"https://github.com/onmodulus/docker-build-meteor.git","svn_url":"https://github.com/onmodulus/docker-build-meteor","homepage":null,"size":47,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/12"},"html":{"href":"https://github.com/onmodulus/docker-build-meteor/pull/12"},"issue":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues/12"},"comments":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/onmodulus/docker-build-meteor/statuses/f1d7556853dc848b256731ee4cfa226339ed724b"}}}}