{"action":"created","comment":{"url":"https://api.github.com/repos/google/sagetv/pulls/comments/71812405","id":71812405,"diff_hunk":"@@ -121,7 +134,11 @@ else if (rv.length() == 0 && willDisplay)\n         }\n       }\n     }\n-    //System.out.println(\"Got Subtitle text=\" + rv + \" subEntryPos=\" + subEntryPos);\n+    finally\n+    {\n+      subtitleLock.readLock().unlock();\n+    }\n+    System.out.println(\"Got Subtitle text=\" + rv + \" subEntryPos=\" + subEntryPos);","path":"java/sage/media/sub/SubtitleHandler.java","position":101,"original_position":101,"commit_id":"e961fd30258812aa9efdad34d2286f969ece268d","original_commit_id":"e961fd30258812aa9efdad34d2286f969ece268d","user":{"login":"enternoescape","id":4162345,"avatar_url":"https://avatars.githubusercontent.com/u/4162345?v=3","gravatar_id":"","url":"https://api.github.com/users/enternoescape","html_url":"https://github.com/enternoescape","followers_url":"https://api.github.com/users/enternoescape/followers","following_url":"https://api.github.com/users/enternoescape/following{/other_user}","gists_url":"https://api.github.com/users/enternoescape/gists{/gist_id}","starred_url":"https://api.github.com/users/enternoescape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enternoescape/subscriptions","organizations_url":"https://api.github.com/users/enternoescape/orgs","repos_url":"https://api.github.com/users/enternoescape/repos","events_url":"https://api.github.com/users/enternoescape/events{/privacy}","received_events_url":"https://api.github.com/users/enternoescape/received_events","type":"User","site_admin":false},"body":"I went through all of the subtitle classes and applied the the subtitle debug boolean only to things that were not actual errors or warnings.","created_at":"2016-07-22T00:45:13Z","updated_at":"2016-07-22T00:45:13Z","html_url":"https://github.com/google/sagetv/pull/156#discussion_r71812405","pull_request_url":"https://api.github.com/repos/google/sagetv/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/google/sagetv/pulls/comments/71812405"},"html":{"href":"https://github.com/google/sagetv/pull/156#discussion_r71812405"},"pull_request":{"href":"https://api.github.com/repos/google/sagetv/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/google/sagetv/pulls/156","id":77894828,"html_url":"https://github.com/google/sagetv/pull/156","diff_url":"https://github.com/google/sagetv/pull/156.diff","patch_url":"https://github.com/google/sagetv/pull/156.patch","issue_url":"https://api.github.com/repos/google/sagetv/issues/156","number":156,"state":"open","locked":false,"title":"Fixed issue #87 so that now SRT subtitles are read live and made local and remote file access consistent and easily extendable.","user":{"login":"enternoescape","id":4162345,"avatar_url":"https://avatars.githubusercontent.com/u/4162345?v=3","gravatar_id":"","url":"https://api.github.com/users/enternoescape","html_url":"https://github.com/enternoescape","followers_url":"https://api.github.com/users/enternoescape/followers","following_url":"https://api.github.com/users/enternoescape/following{/other_user}","gists_url":"https://api.github.com/users/enternoescape/gists{/gist_id}","starred_url":"https://api.github.com/users/enternoescape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enternoescape/subscriptions","organizations_url":"https://api.github.com/users/enternoescape/orgs","repos_url":"https://api.github.com/users/enternoescape/repos","events_url":"https://api.github.com/users/enternoescape/events{/privacy}","received_events_url":"https://api.github.com/users/enternoescape/received_events","type":"User","site_admin":false},"body":"This does not address multi-part recordings that have a subtitle file for each segment.","created_at":"2016-07-18T23:11:46Z","updated_at":"2016-07-22T00:45:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e633accfc97d13a3486a5aff2356b808ee2a1ae","assignee":{"login":"Narflex","id":13699084,"avatar_url":"https://avatars.githubusercontent.com/u/13699084?v=3","gravatar_id":"","url":"https://api.github.com/users/Narflex","html_url":"https://github.com/Narflex","followers_url":"https://api.github.com/users/Narflex/followers","following_url":"https://api.github.com/users/Narflex/following{/other_user}","gists_url":"https://api.github.com/users/Narflex/gists{/gist_id}","starred_url":"https://api.github.com/users/Narflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narflex/subscriptions","organizations_url":"https://api.github.com/users/Narflex/orgs","repos_url":"https://api.github.com/users/Narflex/repos","events_url":"https://api.github.com/users/Narflex/events{/privacy}","received_events_url":"https://api.github.com/users/Narflex/received_events","type":"User","site_admin":false},"assignees":[{"login":"Narflex","id":13699084,"avatar_url":"https://avatars.githubusercontent.com/u/13699084?v=3","gravatar_id":"","url":"https://api.github.com/users/Narflex","html_url":"https://github.com/Narflex","followers_url":"https://api.github.com/users/Narflex/followers","following_url":"https://api.github.com/users/Narflex/following{/other_user}","gists_url":"https://api.github.com/users/Narflex/gists{/gist_id}","starred_url":"https://api.github.com/users/Narflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narflex/subscriptions","organizations_url":"https://api.github.com/users/Narflex/orgs","repos_url":"https://api.github.com/users/Narflex/repos","events_url":"https://api.github.com/users/Narflex/events{/privacy}","received_events_url":"https://api.github.com/users/Narflex/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/sagetv/pulls/156/commits","review_comments_url":"https://api.github.com/repos/google/sagetv/pulls/156/comments","review_comment_url":"https://api.github.com/repos/google/sagetv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/sagetv/issues/156/comments","statuses_url":"https://api.github.com/repos/google/sagetv/statuses/e961fd30258812aa9efdad34d2286f969ece268d","head":{"label":"enternoescape:live-srt-playback","ref":"live-srt-playback","sha":"e961fd30258812aa9efdad34d2286f969ece268d","user":{"login":"enternoescape","id":4162345,"avatar_url":"https://avatars.githubusercontent.com/u/4162345?v=3","gravatar_id":"","url":"https://api.github.com/users/enternoescape","html_url":"https://github.com/enternoescape","followers_url":"https://api.github.com/users/enternoescape/followers","following_url":"https://api.github.com/users/enternoescape/following{/other_user}","gists_url":"https://api.github.com/users/enternoescape/gists{/gist_id}","starred_url":"https://api.github.com/users/enternoescape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enternoescape/subscriptions","organizations_url":"https://api.github.com/users/enternoescape/orgs","repos_url":"https://api.github.com/users/enternoescape/repos","events_url":"https://api.github.com/users/enternoescape/events{/privacy}","received_events_url":"https://api.github.com/users/enternoescape/received_events","type":"User","site_admin":false},"repo":{"id":58501382,"name":"sagetv","full_name":"enternoescape/sagetv","owner":{"login":"enternoescape","id":4162345,"avatar_url":"https://avatars.githubusercontent.com/u/4162345?v=3","gravatar_id":"","url":"https://api.github.com/users/enternoescape","html_url":"https://github.com/enternoescape","followers_url":"https://api.github.com/users/enternoescape/followers","following_url":"https://api.github.com/users/enternoescape/following{/other_user}","gists_url":"https://api.github.com/users/enternoescape/gists{/gist_id}","starred_url":"https://api.github.com/users/enternoescape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enternoescape/subscriptions","organizations_url":"https://api.github.com/users/enternoescape/orgs","repos_url":"https://api.github.com/users/enternoescape/repos","events_url":"https://api.github.com/users/enternoescape/events{/privacy}","received_events_url":"https://api.github.com/users/enternoescape/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enternoescape/sagetv","description":"SageTV is a cross-platform networked DVR and media management system","fork":true,"url":"https://api.github.com/repos/enternoescape/sagetv","forks_url":"https://api.github.com/repos/enternoescape/sagetv/forks","keys_url":"https://api.github.com/repos/enternoescape/sagetv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enternoescape/sagetv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enternoescape/sagetv/teams","hooks_url":"https://api.github.com/repos/enternoescape/sagetv/hooks","issue_events_url":"https://api.github.com/repos/enternoescape/sagetv/issues/events{/number}","events_url":"https://api.github.com/repos/enternoescape/sagetv/events","assignees_url":"https://api.github.com/repos/enternoescape/sagetv/assignees{/user}","branches_url":"https://api.github.com/repos/enternoescape/sagetv/branches{/branch}","tags_url":"https://api.github.com/repos/enternoescape/sagetv/tags","blobs_url":"https://api.github.com/repos/enternoescape/sagetv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enternoescape/sagetv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enternoescape/sagetv/git/refs{/sha}","trees_url":"https://api.github.com/repos/enternoescape/sagetv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enternoescape/sagetv/statuses/{sha}","languages_url":"https://api.github.com/repos/enternoescape/sagetv/languages","stargazers_url":"https://api.github.com/repos/enternoescape/sagetv/stargazers","contributors_url":"https://api.github.com/repos/enternoescape/sagetv/contributors","subscribers_url":"https://api.github.com/repos/enternoescape/sagetv/subscribers","subscription_url":"https://api.github.com/repos/enternoescape/sagetv/subscription","commits_url":"https://api.github.com/repos/enternoescape/sagetv/commits{/sha}","git_commits_url":"https://api.github.com/repos/enternoescape/sagetv/git/commits{/sha}","comments_url":"https://api.github.com/repos/enternoescape/sagetv/comments{/number}","issue_comment_url":"https://api.github.com/repos/enternoescape/sagetv/issues/comments{/number}","contents_url":"https://api.github.com/repos/enternoescape/sagetv/contents/{+path}","compare_url":"https://api.github.com/repos/enternoescape/sagetv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enternoescape/sagetv/merges","archive_url":"https://api.github.com/repos/enternoescape/sagetv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enternoescape/sagetv/downloads","issues_url":"https://api.github.com/repos/enternoescape/sagetv/issues{/number}","pulls_url":"https://api.github.com/repos/enternoescape/sagetv/pulls{/number}","milestones_url":"https://api.github.com/repos/enternoescape/sagetv/milestones{/number}","notifications_url":"https://api.github.com/repos/enternoescape/sagetv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enternoescape/sagetv/labels{/name}","releases_url":"https://api.github.com/repos/enternoescape/sagetv/releases{/id}","deployments_url":"https://api.github.com/repos/enternoescape/sagetv/deployments","created_at":"2016-05-11T00:11:40Z","updated_at":"2016-05-11T00:11:46Z","pushed_at":"2016-07-21T03:36:10Z","git_url":"git://github.com/enternoescape/sagetv.git","ssh_url":"git@github.com:enternoescape/sagetv.git","clone_url":"https://github.com/enternoescape/sagetv.git","svn_url":"https://github.com/enternoescape/sagetv","homepage":"http://forums.sagetv.com/","size":68570,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"b2480ec532890c542cfc5eabd9f5d99e71b630ee","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":40379991,"name":"sagetv","full_name":"google/sagetv","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/sagetv","description":"SageTV is a cross-platform networked DVR and media management system","fork":false,"url":"https://api.github.com/repos/google/sagetv","forks_url":"https://api.github.com/repos/google/sagetv/forks","keys_url":"https://api.github.com/repos/google/sagetv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/sagetv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/sagetv/teams","hooks_url":"https://api.github.com/repos/google/sagetv/hooks","issue_events_url":"https://api.github.com/repos/google/sagetv/issues/events{/number}","events_url":"https://api.github.com/repos/google/sagetv/events","assignees_url":"https://api.github.com/repos/google/sagetv/assignees{/user}","branches_url":"https://api.github.com/repos/google/sagetv/branches{/branch}","tags_url":"https://api.github.com/repos/google/sagetv/tags","blobs_url":"https://api.github.com/repos/google/sagetv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/sagetv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/sagetv/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/sagetv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/sagetv/statuses/{sha}","languages_url":"https://api.github.com/repos/google/sagetv/languages","stargazers_url":"https://api.github.com/repos/google/sagetv/stargazers","contributors_url":"https://api.github.com/repos/google/sagetv/contributors","subscribers_url":"https://api.github.com/repos/google/sagetv/subscribers","subscription_url":"https://api.github.com/repos/google/sagetv/subscription","commits_url":"https://api.github.com/repos/google/sagetv/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/sagetv/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/sagetv/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/sagetv/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/sagetv/contents/{+path}","compare_url":"https://api.github.com/repos/google/sagetv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/sagetv/merges","archive_url":"https://api.github.com/repos/google/sagetv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/sagetv/downloads","issues_url":"https://api.github.com/repos/google/sagetv/issues{/number}","pulls_url":"https://api.github.com/repos/google/sagetv/pulls{/number}","milestones_url":"https://api.github.com/repos/google/sagetv/milestones{/number}","notifications_url":"https://api.github.com/repos/google/sagetv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/sagetv/labels{/name}","releases_url":"https://api.github.com/repos/google/sagetv/releases{/id}","deployments_url":"https://api.github.com/repos/google/sagetv/deployments","created_at":"2015-08-07T20:37:14Z","updated_at":"2016-07-20T04:54:28Z","pushed_at":"2016-07-21T03:36:10Z","git_url":"git://github.com/google/sagetv.git","ssh_url":"git@github.com:google/sagetv.git","clone_url":"https://github.com/google/sagetv.git","svn_url":"https://github.com/google/sagetv","homepage":"http://forums.sagetv.com/","size":68286,"stargazers_count":116,"watchers_count":116,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":59,"forks":112,"open_issues":59,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/sagetv/pulls/156"},"html":{"href":"https://github.com/google/sagetv/pull/156"},"issue":{"href":"https://api.github.com/repos/google/sagetv/issues/156"},"comments":{"href":"https://api.github.com/repos/google/sagetv/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/google/sagetv/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/google/sagetv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/sagetv/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/google/sagetv/statuses/e961fd30258812aa9efdad34d2286f969ece268d"}}}}
{"actor":{"display_login":"enternoescape"}}