{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/67916710","id":67916710,"diff_hunk":"@@ -31,8 +31,18 @@\n  *\n  */\n \n-/// A completion queue implements a concurrent producer-consumer queue, with two\n-/// main methods, \\a Next and \\a AsyncNext.\n+/// A completion queue implements a concurrent producer-consumer queue, with\n+/// two main API-exposed methods: \\a Next and \\a AsyncNext. These\n+/// methods are the essential component of the gRPC C++ asynchronous API.\n+/// There is also a Shutdown method to indicate that a given completion queue","path":"include/grpc++/impl/codegen/completion_queue.h","position":9,"original_position":9,"commit_id":"b9df2760ed15930429305f01407914db106510d5","original_commit_id":"b9df2760ed15930429305f01407914db106510d5","user":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"body":"Actually, we should decide whether we want to always use \\a in front of function/method names. Right now we do it inconsistently (eg, the mentions of Read and Write wrt thread safety).","created_at":"2016-06-21T17:45:07Z","updated_at":"2016-06-21T17:45:07Z","html_url":"https://github.com/grpc/grpc/pull/6947#discussion_r67916710","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/6947","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/67916710"},"html":{"href":"https://github.com/grpc/grpc/pull/6947#discussion_r67916710"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6947"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/6947","id":74199809,"html_url":"https://github.com/grpc/grpc/pull/6947","diff_url":"https://github.com/grpc/grpc/pull/6947.diff","patch_url":"https://github.com/grpc/grpc/pull/6947.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/6947","number":6947,"state":"open","locked":false,"title":"Doc Fixit: Ordering and thread-safety for C++ streaming (sync/async) APIs","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"body":"Fixes #5420 \r\nCc: @slash-lib \r\n","created_at":"2016-06-17T07:29:42Z","updated_at":"2016-06-21T17:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9566033cec744b6830c2032085fb45a58980e824","assignee":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/grpc/grpc/milestones/41","html_url":"https://github.com/grpc/grpc/milestones/2016/05/21%20Milestone","labels_url":"https://api.github.com/repos/grpc/grpc/milestones/41/labels","id":1724098,"number":41,"title":"2016/05/21 Milestone","description":"","creator":{"login":"nicolasnoble","id":7281574,"avatar_url":"https://avatars.githubusercontent.com/u/7281574?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasnoble","html_url":"https://github.com/nicolasnoble","followers_url":"https://api.github.com/users/nicolasnoble/followers","following_url":"https://api.github.com/users/nicolasnoble/following{/other_user}","gists_url":"https://api.github.com/users/nicolasnoble/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasnoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasnoble/subscriptions","organizations_url":"https://api.github.com/users/nicolasnoble/orgs","repos_url":"https://api.github.com/users/nicolasnoble/repos","events_url":"https://api.github.com/users/nicolasnoble/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasnoble/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":301,"state":"open","created_at":"2016-04-21T23:36:09Z","updated_at":"2016-06-21T00:20:20Z","due_on":"2016-05-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/6947/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/6947/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/6947/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/b9df2760ed15930429305f01407914db106510d5","head":{"label":"vjpai:async_stream_doc","ref":"async_stream_doc","sha":"b9df2760ed15930429305f01407914db106510d5","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"repo":{"id":43449564,"name":"grpc","full_name":"vjpai/grpc","owner":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjpai/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/vjpai/grpc","forks_url":"https://api.github.com/repos/vjpai/grpc/forks","keys_url":"https://api.github.com/repos/vjpai/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjpai/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjpai/grpc/teams","hooks_url":"https://api.github.com/repos/vjpai/grpc/hooks","issue_events_url":"https://api.github.com/repos/vjpai/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/vjpai/grpc/events","assignees_url":"https://api.github.com/repos/vjpai/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/vjpai/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/vjpai/grpc/tags","blobs_url":"https://api.github.com/repos/vjpai/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjpai/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjpai/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjpai/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjpai/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/vjpai/grpc/languages","stargazers_url":"https://api.github.com/repos/vjpai/grpc/stargazers","contributors_url":"https://api.github.com/repos/vjpai/grpc/contributors","subscribers_url":"https://api.github.com/repos/vjpai/grpc/subscribers","subscription_url":"https://api.github.com/repos/vjpai/grpc/subscription","commits_url":"https://api.github.com/repos/vjpai/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjpai/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjpai/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjpai/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/vjpai/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/vjpai/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjpai/grpc/merges","archive_url":"https://api.github.com/repos/vjpai/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjpai/grpc/downloads","issues_url":"https://api.github.com/repos/vjpai/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/vjpai/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/vjpai/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/vjpai/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjpai/grpc/labels{/name}","releases_url":"https://api.github.com/repos/vjpai/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/vjpai/grpc/deployments","created_at":"2015-09-30T17:59:22Z","updated_at":"2016-01-11T17:59:46Z","pushed_at":"2016-06-21T16:09:52Z","git_url":"git://github.com/vjpai/grpc.git","ssh_url":"git@github.com:vjpai/grpc.git","clone_url":"https://github.com/vjpai/grpc.git","svn_url":"https://github.com/vjpai/grpc","homepage":"","size":75801,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"69170755b8f16d7f2540e0bc060f67940e4b4158","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-06-21T16:50:03Z","pushed_at":"2016-06-21T17:15:12Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":193705,"stargazers_count":5240,"watchers_count":5240,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":960,"mirror_url":null,"open_issues_count":640,"forks":960,"open_issues":640,"watchers":5240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6947"},"html":{"href":"https://github.com/grpc/grpc/pull/6947"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/6947"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/6947/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6947/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6947/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/b9df2760ed15930429305f01407914db106510d5"}}}}
{"actor":{"display_login":"dgquintas"}}