{"action":"created","issue":{"url":"https://api.github.com/repos/opencobra/cobrapy/issues/257","repository_url":"https://api.github.com/repos/opencobra/cobrapy","labels_url":"https://api.github.com/repos/opencobra/cobrapy/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/opencobra/cobrapy/issues/257/comments","events_url":"https://api.github.com/repos/opencobra/cobrapy/issues/257/events","html_url":"https://github.com/opencobra/cobrapy/issues/257","id":160443597,"number":257,"title":"Adding reaction with new compartment does not create compartment","user":{"login":"wbryant","id":8303141,"avatar_url":"https://avatars.githubusercontent.com/u/8303141?v=3","gravatar_id":"","url":"https://api.github.com/users/wbryant","html_url":"https://github.com/wbryant","followers_url":"https://api.github.com/users/wbryant/followers","following_url":"https://api.github.com/users/wbryant/following{/other_user}","gists_url":"https://api.github.com/users/wbryant/gists{/gist_id}","starred_url":"https://api.github.com/users/wbryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbryant/subscriptions","organizations_url":"https://api.github.com/users/wbryant/orgs","repos_url":"https://api.github.com/users/wbryant/repos","events_url":"https://api.github.com/users/wbryant/events{/privacy}","received_events_url":"https://api.github.com/users/wbryant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-15T14:57:08Z","updated_at":"2016-09-01T18:55:37Z","closed_at":null,"body":"If I add a new reaction to a model, I can add metabolites from a new compartment (not in the current model), but the compartment is not created in the model.\r\n\r\nI will have a go at fixing it myself when I have some time, but wondered if anyone has opinions on whether it should throw an error (i.e. assume compartments are incorrect), or whether a new compartment should (silently or not) be created in the model."},"comment":{"url":"https://api.github.com/repos/opencobra/cobrapy/issues/comments/244176814","html_url":"https://github.com/opencobra/cobrapy/issues/257#issuecomment-244176814","issue_url":"https://api.github.com/repos/opencobra/cobrapy/issues/257","id":244176814,"user":{"login":"mmundy42","id":2896238,"avatar_url":"https://avatars.githubusercontent.com/u/2896238?v=3","gravatar_id":"","url":"https://api.github.com/users/mmundy42","html_url":"https://github.com/mmundy42","followers_url":"https://api.github.com/users/mmundy42/followers","following_url":"https://api.github.com/users/mmundy42/following{/other_user}","gists_url":"https://api.github.com/users/mmundy42/gists{/gist_id}","starred_url":"https://api.github.com/users/mmundy42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmundy42/subscriptions","organizations_url":"https://api.github.com/users/mmundy42/orgs","repos_url":"https://api.github.com/users/mmundy42/repos","events_url":"https://api.github.com/users/mmundy42/events{/privacy}","received_events_url":"https://api.github.com/users/mmundy42/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T18:55:37Z","updated_at":"2016-09-01T18:55:37Z","body":"I recently ran across this issue too. It makes sense to remove `compartments` from the model and get the compartments from the metabolites. Although setting a compartment for a metabolite is optional and the default value is `None`. Will that cause any side effects?"}}
{"actor":{"display_login":"mmundy42"}}