{"action":"created","comment":{"url":"https://api.github.com/repos/eventbrite/javascript/pulls/comments/71047829","id":71047829,"diff_hunk":"@@ -410,7 +411,53 @@ _superComplextName: function() {\n UpdateAll: function() {\n     / /code here\n }\n+```\n+## comments\n+\n+### commented code\n+\n+*We recommend not to leave commented code lingering around. If the code is meant to be used in the future, either save the code on a branch or in our internal paste bin via phabricator. (arc paste).*\n+\n+### when the comment has multiple lines we use the block form (i.e: JSDocs)\n+\n+```js\n+ \n+/**\n+* returns the calculated offset for lower bound range. (from)\n+* @example\n+* // returns 2\n+* scenario:\n+* Viewport Large\n+* skiping first and applying corrections\n+* @returns {integer} lower bound range\n+*/\n+\n+const getMinBound = (pageSize = constants.DEFAULT_PAGE_SIZE) => (\n+    pageSize === constants.DEFAULT_PAGE_SIZE ? constants.MIN_BOUND_SMALL : constants.MIN_BOUND_DEFAULT\n+);\n+```\n \n+### when the comment has a single line we instead one liner comments: \n+\n+```js\n+const getToOffset = (pageNumber, middleRangeOffset, maxPagesShown, maxBound) => {\n+    // default -> page is in the middle, and we have enough pages in both sides.\n+    let to = pageNumber + middleRangeOffset;\n+\n+    // are we too close to the bottom? if so, we need to adjust the split","path":"general/README.md","position":45,"original_position":45,"commit_id":"c96ab84a7df69c5dbf0ba90c150142f39bc38497","original_commit_id":"c96ab84a7df69c5dbf0ba90c150142f39bc38497","user":{"login":"BenAtEventbrite","id":12259799,"avatar_url":"https://avatars.githubusercontent.com/u/12259799?v=3","gravatar_id":"","url":"https://api.github.com/users/BenAtEventbrite","html_url":"https://github.com/BenAtEventbrite","followers_url":"https://api.github.com/users/BenAtEventbrite/followers","following_url":"https://api.github.com/users/BenAtEventbrite/following{/other_user}","gists_url":"https://api.github.com/users/BenAtEventbrite/gists{/gist_id}","starred_url":"https://api.github.com/users/BenAtEventbrite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenAtEventbrite/subscriptions","organizations_url":"https://api.github.com/users/BenAtEventbrite/orgs","repos_url":"https://api.github.com/users/BenAtEventbrite/repos","events_url":"https://api.github.com/users/BenAtEventbrite/events{/privacy}","received_events_url":"https://api.github.com/users/BenAtEventbrite/received_events","type":"User","site_admin":false},"body":"this comment is on two lines but uses one-liner comments?","created_at":"2016-07-15T22:11:05Z","updated_at":"2016-07-15T22:11:05Z","html_url":"https://github.com/eventbrite/javascript/pull/19#discussion_r71047829","pull_request_url":"https://api.github.com/repos/eventbrite/javascript/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/eventbrite/javascript/pulls/comments/71047829"},"html":{"href":"https://github.com/eventbrite/javascript/pull/19#discussion_r71047829"},"pull_request":{"href":"https://api.github.com/repos/eventbrite/javascript/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/eventbrite/javascript/pulls/19","id":77546798,"html_url":"https://github.com/eventbrite/javascript/pull/19","diff_url":"https://github.com/eventbrite/javascript/pull/19.diff","patch_url":"https://github.com/eventbrite/javascript/pull/19.patch","issue_url":"https://api.github.com/repos/eventbrite/javascript/issues/19","number":19,"state":"open","locked":false,"title":"about_comments","user":{"login":"gagoar","id":226559,"avatar_url":"https://avatars.githubusercontent.com/u/226559?v=3","gravatar_id":"","url":"https://api.github.com/users/gagoar","html_url":"https://github.com/gagoar","followers_url":"https://api.github.com/users/gagoar/followers","following_url":"https://api.github.com/users/gagoar/following{/other_user}","gists_url":"https://api.github.com/users/gagoar/gists{/gist_id}","starred_url":"https://api.github.com/users/gagoar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagoar/subscriptions","organizations_url":"https://api.github.com/users/gagoar/orgs","repos_url":"https://api.github.com/users/gagoar/repos","events_url":"https://api.github.com/users/gagoar/events{/privacy}","received_events_url":"https://api.github.com/users/gagoar/received_events","type":"User","site_admin":false},"body":"adding comments to our general ","created_at":"2016-07-15T00:19:39Z","updated_at":"2016-07-15T22:11:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c2f30c4a77844318a175ed8d12ce563591a3011","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eventbrite/javascript/pulls/19/commits","review_comments_url":"https://api.github.com/repos/eventbrite/javascript/pulls/19/comments","review_comment_url":"https://api.github.com/repos/eventbrite/javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eventbrite/javascript/issues/19/comments","statuses_url":"https://api.github.com/repos/eventbrite/javascript/statuses/c96ab84a7df69c5dbf0ba90c150142f39bc38497","head":{"label":"eventbrite:about_comments","ref":"about_comments","sha":"c96ab84a7df69c5dbf0ba90c150142f39bc38497","user":{"login":"eventbrite","id":369874,"avatar_url":"https://avatars.githubusercontent.com/u/369874?v=3","gravatar_id":"","url":"https://api.github.com/users/eventbrite","html_url":"https://github.com/eventbrite","followers_url":"https://api.github.com/users/eventbrite/followers","following_url":"https://api.github.com/users/eventbrite/following{/other_user}","gists_url":"https://api.github.com/users/eventbrite/gists{/gist_id}","starred_url":"https://api.github.com/users/eventbrite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventbrite/subscriptions","organizations_url":"https://api.github.com/users/eventbrite/orgs","repos_url":"https://api.github.com/users/eventbrite/repos","events_url":"https://api.github.com/users/eventbrite/events{/privacy}","received_events_url":"https://api.github.com/users/eventbrite/received_events","type":"Organization","site_admin":false},"repo":{"id":59158617,"name":"javascript","full_name":"eventbrite/javascript","owner":{"login":"eventbrite","id":369874,"avatar_url":"https://avatars.githubusercontent.com/u/369874?v=3","gravatar_id":"","url":"https://api.github.com/users/eventbrite","html_url":"https://github.com/eventbrite","followers_url":"https://api.github.com/users/eventbrite/followers","following_url":"https://api.github.com/users/eventbrite/following{/other_user}","gists_url":"https://api.github.com/users/eventbrite/gists{/gist_id}","starred_url":"https://api.github.com/users/eventbrite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventbrite/subscriptions","organizations_url":"https://api.github.com/users/eventbrite/orgs","repos_url":"https://api.github.com/users/eventbrite/repos","events_url":"https://api.github.com/users/eventbrite/events{/privacy}","received_events_url":"https://api.github.com/users/eventbrite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventbrite/javascript","description":"Eventbrite JavaScript coding style guide","fork":false,"url":"https://api.github.com/repos/eventbrite/javascript","forks_url":"https://api.github.com/repos/eventbrite/javascript/forks","keys_url":"https://api.github.com/repos/eventbrite/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventbrite/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventbrite/javascript/teams","hooks_url":"https://api.github.com/repos/eventbrite/javascript/hooks","issue_events_url":"https://api.github.com/repos/eventbrite/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/eventbrite/javascript/events","assignees_url":"https://api.github.com/repos/eventbrite/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/eventbrite/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/eventbrite/javascript/tags","blobs_url":"https://api.github.com/repos/eventbrite/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventbrite/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventbrite/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventbrite/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventbrite/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/eventbrite/javascript/languages","stargazers_url":"https://api.github.com/repos/eventbrite/javascript/stargazers","contributors_url":"https://api.github.com/repos/eventbrite/javascript/contributors","subscribers_url":"https://api.github.com/repos/eventbrite/javascript/subscribers","subscription_url":"https://api.github.com/repos/eventbrite/javascript/subscription","commits_url":"https://api.github.com/repos/eventbrite/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventbrite/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventbrite/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventbrite/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventbrite/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/eventbrite/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventbrite/javascript/merges","archive_url":"https://api.github.com/repos/eventbrite/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventbrite/javascript/downloads","issues_url":"https://api.github.com/repos/eventbrite/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/eventbrite/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/eventbrite/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/eventbrite/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventbrite/javascript/labels{/name}","releases_url":"https://api.github.com/repos/eventbrite/javascript/releases{/id}","deployments_url":"https://api.github.com/repos/eventbrite/javascript/deployments","created_at":"2016-05-18T23:30:33Z","updated_at":"2016-06-27T17:07:22Z","pushed_at":"2016-07-15T22:02:49Z","git_url":"git://github.com/eventbrite/javascript.git","ssh_url":"git@github.com:eventbrite/javascript.git","clone_url":"https://github.com/eventbrite/javascript.git","svn_url":"https://github.com/eventbrite/javascript","homepage":null,"size":98,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"eventbrite:master","ref":"master","sha":"b151b6c9c14269bbf2ba1e63c2ae8ad3653489b4","user":{"login":"eventbrite","id":369874,"avatar_url":"https://avatars.githubusercontent.com/u/369874?v=3","gravatar_id":"","url":"https://api.github.com/users/eventbrite","html_url":"https://github.com/eventbrite","followers_url":"https://api.github.com/users/eventbrite/followers","following_url":"https://api.github.com/users/eventbrite/following{/other_user}","gists_url":"https://api.github.com/users/eventbrite/gists{/gist_id}","starred_url":"https://api.github.com/users/eventbrite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventbrite/subscriptions","organizations_url":"https://api.github.com/users/eventbrite/orgs","repos_url":"https://api.github.com/users/eventbrite/repos","events_url":"https://api.github.com/users/eventbrite/events{/privacy}","received_events_url":"https://api.github.com/users/eventbrite/received_events","type":"Organization","site_admin":false},"repo":{"id":59158617,"name":"javascript","full_name":"eventbrite/javascript","owner":{"login":"eventbrite","id":369874,"avatar_url":"https://avatars.githubusercontent.com/u/369874?v=3","gravatar_id":"","url":"https://api.github.com/users/eventbrite","html_url":"https://github.com/eventbrite","followers_url":"https://api.github.com/users/eventbrite/followers","following_url":"https://api.github.com/users/eventbrite/following{/other_user}","gists_url":"https://api.github.com/users/eventbrite/gists{/gist_id}","starred_url":"https://api.github.com/users/eventbrite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventbrite/subscriptions","organizations_url":"https://api.github.com/users/eventbrite/orgs","repos_url":"https://api.github.com/users/eventbrite/repos","events_url":"https://api.github.com/users/eventbrite/events{/privacy}","received_events_url":"https://api.github.com/users/eventbrite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventbrite/javascript","description":"Eventbrite JavaScript coding style guide","fork":false,"url":"https://api.github.com/repos/eventbrite/javascript","forks_url":"https://api.github.com/repos/eventbrite/javascript/forks","keys_url":"https://api.github.com/repos/eventbrite/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventbrite/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventbrite/javascript/teams","hooks_url":"https://api.github.com/repos/eventbrite/javascript/hooks","issue_events_url":"https://api.github.com/repos/eventbrite/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/eventbrite/javascript/events","assignees_url":"https://api.github.com/repos/eventbrite/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/eventbrite/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/eventbrite/javascript/tags","blobs_url":"https://api.github.com/repos/eventbrite/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventbrite/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventbrite/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventbrite/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventbrite/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/eventbrite/javascript/languages","stargazers_url":"https://api.github.com/repos/eventbrite/javascript/stargazers","contributors_url":"https://api.github.com/repos/eventbrite/javascript/contributors","subscribers_url":"https://api.github.com/repos/eventbrite/javascript/subscribers","subscription_url":"https://api.github.com/repos/eventbrite/javascript/subscription","commits_url":"https://api.github.com/repos/eventbrite/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventbrite/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventbrite/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventbrite/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventbrite/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/eventbrite/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventbrite/javascript/merges","archive_url":"https://api.github.com/repos/eventbrite/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventbrite/javascript/downloads","issues_url":"https://api.github.com/repos/eventbrite/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/eventbrite/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/eventbrite/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/eventbrite/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventbrite/javascript/labels{/name}","releases_url":"https://api.github.com/repos/eventbrite/javascript/releases{/id}","deployments_url":"https://api.github.com/repos/eventbrite/javascript/deployments","created_at":"2016-05-18T23:30:33Z","updated_at":"2016-06-27T17:07:22Z","pushed_at":"2016-07-15T22:02:49Z","git_url":"git://github.com/eventbrite/javascript.git","ssh_url":"git@github.com:eventbrite/javascript.git","clone_url":"https://github.com/eventbrite/javascript.git","svn_url":"https://github.com/eventbrite/javascript","homepage":null,"size":98,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eventbrite/javascript/pulls/19"},"html":{"href":"https://github.com/eventbrite/javascript/pull/19"},"issue":{"href":"https://api.github.com/repos/eventbrite/javascript/issues/19"},"comments":{"href":"https://api.github.com/repos/eventbrite/javascript/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/eventbrite/javascript/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/eventbrite/javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eventbrite/javascript/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/eventbrite/javascript/statuses/c96ab84a7df69c5dbf0ba90c150142f39bc38497"}}}}
{"actor":{"display_login":"BenAtEventbrite"}}