{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/60241257","id":60241257,"diff_hunk":"@@ -174,6 +174,30 @@ class FramingSpec extends AkkaSpec {\n         3.seconds) should ===(Vector.empty)\n     }\n \n+    \"work with grouped frames\" in {\n+\n+      for {\n+        byteOrder ← byteOrders\n+        fieldOffset ← fieldOffsets\n+        fieldLength ← fieldLengths\n+        count ← 2 to frameLengths.count(_ < (1L << (fieldLength * 8)))\n+      } {\n+\n+        val encodedFrames = frameLengths.filter(_ < (1L << (fieldLength * 8))).map { length ⇒\n+          val payload = referenceChunk.take(length)\n+          encode(payload, fieldOffset, fieldLength, byteOrder)\n+        }\n+        val grouped = encodedFrames.grouped(count).map(_.fold(ByteString.empty)((r, bs) ⇒ r ++ bs)).toList\n+\n+        Await.result(\n+          Source(encodedFrames)\n+            .via(Framing.lengthField(fieldLength, fieldOffset, Int.MaxValue, byteOrder))\n+            .grouped(10000)\n+            .runWith(Sink.head),\n+          3.seconds) should ===(encodedFrames)\n+      }\n+    }\n+","path":"akka-stream-tests/src/test/scala/akka/stream/scaladsl/FramingSpec.scala","position":null,"original_position":27,"commit_id":"4c895448eed2170e56797e55e40ddb43990c2bf2","original_commit_id":"8b60d3e89279cfe8e1a5c01f2de34ff8ac01b298","user":{"login":"zhxiaogg","id":6303886,"avatar_url":"https://avatars.githubusercontent.com/u/6303886?v=3","gravatar_id":"","url":"https://api.github.com/users/zhxiaogg","html_url":"https://github.com/zhxiaogg","followers_url":"https://api.github.com/users/zhxiaogg/followers","following_url":"https://api.github.com/users/zhxiaogg/following{/other_user}","gists_url":"https://api.github.com/users/zhxiaogg/gists{/gist_id}","starred_url":"https://api.github.com/users/zhxiaogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhxiaogg/subscriptions","organizations_url":"https://api.github.com/users/zhxiaogg/orgs","repos_url":"https://api.github.com/users/zhxiaogg/repos","events_url":"https://api.github.com/users/zhxiaogg/events{/privacy}","received_events_url":"https://api.github.com/users/zhxiaogg/received_events","type":"User","site_admin":false},"body":"I add a simple unit test using `TestPublisher` and `TestSubscriber`. I did reproduce the failure. Thanks.","created_at":"2016-04-19T14:29:14Z","updated_at":"2016-04-19T14:29:15Z","html_url":"https://github.com/akka/akka/pull/20345#discussion_r60241257","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/20345","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/60241257"},"html":{"href":"https://github.com/akka/akka/pull/20345#discussion_r60241257"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/20345"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/20345","id":66770870,"html_url":"https://github.com/akka/akka/pull/20345","diff_url":"https://github.com/akka/akka/pull/20345.diff","patch_url":"https://github.com/akka/akka/pull/20345.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/20345","number":20345,"state":"open","locked":false,"title":"#20288: converts LengthFieldFramingStage to GraphStage","user":{"login":"zhxiaogg","id":6303886,"avatar_url":"https://avatars.githubusercontent.com/u/6303886?v=3","gravatar_id":"","url":"https://api.github.com/users/zhxiaogg","html_url":"https://github.com/zhxiaogg","followers_url":"https://api.github.com/users/zhxiaogg/followers","following_url":"https://api.github.com/users/zhxiaogg/following{/other_user}","gists_url":"https://api.github.com/users/zhxiaogg/gists{/gist_id}","starred_url":"https://api.github.com/users/zhxiaogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhxiaogg/subscriptions","organizations_url":"https://api.github.com/users/zhxiaogg/orgs","repos_url":"https://api.github.com/users/zhxiaogg/repos","events_url":"https://api.github.com/users/zhxiaogg/events{/privacy}","received_events_url":"https://api.github.com/users/zhxiaogg/received_events","type":"User","site_admin":false},"body":"see #20288 ","created_at":"2016-04-17T15:05:16Z","updated_at":"2016-04-19T14:29:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43006418dd06fe5bdb90fe1518246af5a35c1d18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/20345/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/20345/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/20345/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/4c895448eed2170e56797e55e40ddb43990c2bf2","head":{"label":"zhxiaogg:feature/zhxiaogg_LengthFieldFramingStage","ref":"feature/zhxiaogg_LengthFieldFramingStage","sha":"4c895448eed2170e56797e55e40ddb43990c2bf2","user":{"login":"zhxiaogg","id":6303886,"avatar_url":"https://avatars.githubusercontent.com/u/6303886?v=3","gravatar_id":"","url":"https://api.github.com/users/zhxiaogg","html_url":"https://github.com/zhxiaogg","followers_url":"https://api.github.com/users/zhxiaogg/followers","following_url":"https://api.github.com/users/zhxiaogg/following{/other_user}","gists_url":"https://api.github.com/users/zhxiaogg/gists{/gist_id}","starred_url":"https://api.github.com/users/zhxiaogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhxiaogg/subscriptions","organizations_url":"https://api.github.com/users/zhxiaogg/orgs","repos_url":"https://api.github.com/users/zhxiaogg/repos","events_url":"https://api.github.com/users/zhxiaogg/events{/privacy}","received_events_url":"https://api.github.com/users/zhxiaogg/received_events","type":"User","site_admin":false},"repo":{"id":56165504,"name":"akka","full_name":"zhxiaogg/akka","owner":{"login":"zhxiaogg","id":6303886,"avatar_url":"https://avatars.githubusercontent.com/u/6303886?v=3","gravatar_id":"","url":"https://api.github.com/users/zhxiaogg","html_url":"https://github.com/zhxiaogg","followers_url":"https://api.github.com/users/zhxiaogg/followers","following_url":"https://api.github.com/users/zhxiaogg/following{/other_user}","gists_url":"https://api.github.com/users/zhxiaogg/gists{/gist_id}","starred_url":"https://api.github.com/users/zhxiaogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhxiaogg/subscriptions","organizations_url":"https://api.github.com/users/zhxiaogg/orgs","repos_url":"https://api.github.com/users/zhxiaogg/repos","events_url":"https://api.github.com/users/zhxiaogg/events{/privacy}","received_events_url":"https://api.github.com/users/zhxiaogg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhxiaogg/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/zhxiaogg/akka","forks_url":"https://api.github.com/repos/zhxiaogg/akka/forks","keys_url":"https://api.github.com/repos/zhxiaogg/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhxiaogg/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhxiaogg/akka/teams","hooks_url":"https://api.github.com/repos/zhxiaogg/akka/hooks","issue_events_url":"https://api.github.com/repos/zhxiaogg/akka/issues/events{/number}","events_url":"https://api.github.com/repos/zhxiaogg/akka/events","assignees_url":"https://api.github.com/repos/zhxiaogg/akka/assignees{/user}","branches_url":"https://api.github.com/repos/zhxiaogg/akka/branches{/branch}","tags_url":"https://api.github.com/repos/zhxiaogg/akka/tags","blobs_url":"https://api.github.com/repos/zhxiaogg/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhxiaogg/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhxiaogg/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhxiaogg/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhxiaogg/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/zhxiaogg/akka/languages","stargazers_url":"https://api.github.com/repos/zhxiaogg/akka/stargazers","contributors_url":"https://api.github.com/repos/zhxiaogg/akka/contributors","subscribers_url":"https://api.github.com/repos/zhxiaogg/akka/subscribers","subscription_url":"https://api.github.com/repos/zhxiaogg/akka/subscription","commits_url":"https://api.github.com/repos/zhxiaogg/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhxiaogg/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhxiaogg/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhxiaogg/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhxiaogg/akka/contents/{+path}","compare_url":"https://api.github.com/repos/zhxiaogg/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhxiaogg/akka/merges","archive_url":"https://api.github.com/repos/zhxiaogg/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhxiaogg/akka/downloads","issues_url":"https://api.github.com/repos/zhxiaogg/akka/issues{/number}","pulls_url":"https://api.github.com/repos/zhxiaogg/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/zhxiaogg/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/zhxiaogg/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhxiaogg/akka/labels{/name}","releases_url":"https://api.github.com/repos/zhxiaogg/akka/releases{/id}","deployments_url":"https://api.github.com/repos/zhxiaogg/akka/deployments","created_at":"2016-04-13T15:50:21Z","updated_at":"2016-04-13T15:50:33Z","pushed_at":"2016-04-19T14:25:07Z","git_url":"git://github.com/zhxiaogg/akka.git","ssh_url":"git@github.com:zhxiaogg/akka.git","clone_url":"https://github.com/zhxiaogg/akka.git","svn_url":"https://github.com/zhxiaogg/akka","homepage":"http://akka.io","size":192675,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"9af39f97baccaf148a7fe67143ebbca94b9177d4","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2016-04-19T10:09:51Z","pushed_at":"2016-04-19T14:25:07Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":204610,"stargazers_count":5384,"watchers_count":5384,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1678,"mirror_url":null,"open_issues_count":725,"forks":1678,"open_issues":725,"watchers":5384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/20345"},"html":{"href":"https://github.com/akka/akka/pull/20345"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/20345"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/20345/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/20345/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/20345/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/4c895448eed2170e56797e55e40ddb43990c2bf2"}}}}