{"action":"created","comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/61409520","id":61409520,"diff_hunk":"@@ -529,11 +531,34 @@ extern bool FMVstarted;\n extern bool renderswitch;\n extern bool EnableFMV;\n \n-void DoFmvSwitch()\n+void DoFmvSwitch(bool on)\n {\n-\tScopedCoreThreadPause paused_core( new SysExecEvent_SaveSinglePlugin(PluginId_GS) );\n-\trenderswitch = !renderswitch;\n-\tpaused_core.AllowResume();\n+\tif (g_Conf->GSWindow.IsToggleAspectRatioSwitch) {\n+\t\tAspectRatioType& art = g_Conf->GSWindow.AspectRatio;\n+\t\tif (!EnableFMV && !FMVstarted && art == AspectRatio_4_3 && prevAR != art)\n+\t\t\tprevAR = art;\n+\n+\t\tif (on) {\n+\t\t\tif (art != AspectRatio_4_3) {\n+\t\t\t\tprevAR = art;\n+\t\t\t\tart = AspectRatio_4_3;\n+\t\t\t}\n+\t\t}\n+\t\telse if (!on) {\n+\t\t\tif (art == AspectRatio_4_3 && prevAR != AspectRatio_4_3)\n+\t\t\t\tart = prevAR;\n+\t\t}\n+","path":"pcsx2/gui/AppMain.cpp","position":34,"original_position":34,"commit_id":"a0e2e9a9d8f1397a680a1c0aadaf07736ac54015","original_commit_id":"5aef5558f627ee0102a2b6d4ae8803c3b79deaaa","user":{"login":"FlatOutPS2","id":15942346,"avatar_url":"https://avatars.githubusercontent.com/u/15942346?v=3","gravatar_id":"","url":"https://api.github.com/users/FlatOutPS2","html_url":"https://github.com/FlatOutPS2","followers_url":"https://api.github.com/users/FlatOutPS2/followers","following_url":"https://api.github.com/users/FlatOutPS2/following{/other_user}","gists_url":"https://api.github.com/users/FlatOutPS2/gists{/gist_id}","starred_url":"https://api.github.com/users/FlatOutPS2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlatOutPS2/subscriptions","organizations_url":"https://api.github.com/users/FlatOutPS2/orgs","repos_url":"https://api.github.com/users/FlatOutPS2/repos","events_url":"https://api.github.com/users/FlatOutPS2/events{/privacy}","received_events_url":"https://api.github.com/users/FlatOutPS2/received_events","type":"User","site_admin":false},"body":"That wasn't exactly clear from what you said earlier.","created_at":"2016-04-28T11:06:56Z","updated_at":"2016-04-28T11:06:56Z","html_url":"https://github.com/PCSX2/pcsx2/pull/1312#discussion_r61409520","pull_request_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1312","_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/61409520"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1312#discussion_r61409520"},"pull_request":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1312"}}},"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1312","id":67936864,"html_url":"https://github.com/PCSX2/pcsx2/pull/1312","diff_url":"https://github.com/PCSX2/pcsx2/pull/1312.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1312.patch","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1312","number":1312,"state":"open","locked":false,"title":"Automatic aspect ratio switch during FMV playback","user":{"login":"FlatOutPS2","id":15942346,"avatar_url":"https://avatars.githubusercontent.com/u/15942346?v=3","gravatar_id":"","url":"https://api.github.com/users/FlatOutPS2","html_url":"https://github.com/FlatOutPS2","followers_url":"https://api.github.com/users/FlatOutPS2/followers","following_url":"https://api.github.com/users/FlatOutPS2/following{/other_user}","gists_url":"https://api.github.com/users/FlatOutPS2/gists{/gist_id}","starred_url":"https://api.github.com/users/FlatOutPS2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlatOutPS2/subscriptions","organizations_url":"https://api.github.com/users/FlatOutPS2/orgs","repos_url":"https://api.github.com/users/FlatOutPS2/repos","events_url":"https://api.github.com/users/FlatOutPS2/events{/privacy}","received_events_url":"https://api.github.com/users/FlatOutPS2/received_events","type":"User","site_admin":false},"body":"Add option to Emulation Settings - GS Window to for automatically switching to 4:3 aspect ratio when a FMV plays, and back to widescreen/stretch when it's finished.\r\n\r\n![aspectswitch](https://cloud.githubusercontent.com/assets/15942346/14832352/1c40903e-0bfa-11e6-9067-34c7b08f2fe5.png)\r\n\r\nCode probably requires optimising to follow PCSX2 coding guidelines, as I'm not a PCSX2 code or C++ expert.\r\n\r\nFeature-request by trostboot as posted in issues: #1212\r\n\r\nUpdate: latest commit Appveyor build link: https://ci.appveyor.com/api/buildjobs/meaxcps1yp7eai7k/artifacts/pcsx2-v1.5.0-dev-664-g777b932-master-907-vs2015-Win32-AppVeyor.7z","created_at":"2016-04-26T18:40:41Z","updated_at":"2016-04-28T11:06:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd115bfd813a30a30d257489cf345307cdf6713b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1312/commits","review_comments_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1312/comments","review_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1312/comments","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/a0e2e9a9d8f1397a680a1c0aadaf07736ac54015","head":{"label":"FlatOutPS2:master","ref":"master","sha":"a0e2e9a9d8f1397a680a1c0aadaf07736ac54015","user":{"login":"FlatOutPS2","id":15942346,"avatar_url":"https://avatars.githubusercontent.com/u/15942346?v=3","gravatar_id":"","url":"https://api.github.com/users/FlatOutPS2","html_url":"https://github.com/FlatOutPS2","followers_url":"https://api.github.com/users/FlatOutPS2/followers","following_url":"https://api.github.com/users/FlatOutPS2/following{/other_user}","gists_url":"https://api.github.com/users/FlatOutPS2/gists{/gist_id}","starred_url":"https://api.github.com/users/FlatOutPS2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlatOutPS2/subscriptions","organizations_url":"https://api.github.com/users/FlatOutPS2/orgs","repos_url":"https://api.github.com/users/FlatOutPS2/repos","events_url":"https://api.github.com/users/FlatOutPS2/events{/privacy}","received_events_url":"https://api.github.com/users/FlatOutPS2/received_events","type":"User","site_admin":false},"repo":{"id":57151783,"name":"pcsx2","full_name":"FlatOutPS2/pcsx2","owner":{"login":"FlatOutPS2","id":15942346,"avatar_url":"https://avatars.githubusercontent.com/u/15942346?v=3","gravatar_id":"","url":"https://api.github.com/users/FlatOutPS2","html_url":"https://github.com/FlatOutPS2","followers_url":"https://api.github.com/users/FlatOutPS2/followers","following_url":"https://api.github.com/users/FlatOutPS2/following{/other_user}","gists_url":"https://api.github.com/users/FlatOutPS2/gists{/gist_id}","starred_url":"https://api.github.com/users/FlatOutPS2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlatOutPS2/subscriptions","organizations_url":"https://api.github.com/users/FlatOutPS2/orgs","repos_url":"https://api.github.com/users/FlatOutPS2/repos","events_url":"https://api.github.com/users/FlatOutPS2/events{/privacy}","received_events_url":"https://api.github.com/users/FlatOutPS2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FlatOutPS2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":true,"url":"https://api.github.com/repos/FlatOutPS2/pcsx2","forks_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/forks","keys_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/teams","hooks_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/events","assignees_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/tags","blobs_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/subscription","commits_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/merges","archive_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/downloads","issues_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/FlatOutPS2/pcsx2/deployments","created_at":"2016-04-26T18:21:26Z","updated_at":"2016-04-26T18:21:36Z","pushed_at":"2016-04-28T10:59:53Z","git_url":"git://github.com/FlatOutPS2/pcsx2.git","ssh_url":"git@github.com:FlatOutPS2/pcsx2.git","clone_url":"https://github.com/FlatOutPS2/pcsx2.git","svn_url":"https://github.com/FlatOutPS2/pcsx2","homepage":"http://pcsx2.net/","size":77696,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PCSX2:master","ref":"master","sha":"0de8f4a3a6f19b6718b515d1f1d9c7c5e7248a0b","user":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"name":"pcsx2","full_name":"PCSX2/pcsx2","owner":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/PCSX2/pcsx2/deployments","created_at":"2013-12-22T17:56:48Z","updated_at":"2016-04-27T15:31:19Z","pushed_at":"2016-04-28T10:59:54Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":91740,"stargazers_count":1211,"watchers_count":1211,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"open_issues_count":244,"forks":289,"open_issues":244,"watchers":1211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1312"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1312"},"issue":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1312"},"comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1312/comments"},"review_comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1312/comments"},"review_comment":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1312/commits"},"statuses":{"href":"https://api.github.com/repos/PCSX2/pcsx2/statuses/a0e2e9a9d8f1397a680a1c0aadaf07736ac54015"}}}}