{"action":"created","comment":{"url":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/comments/90150196","pull_request_review_id":10673569,"id":90150196,"diff_hunk":"@@ -151,12 +153,40 @@ object Application{\n   }\n \n   def findCity(neLat: Double, swLat: Double, neLng: Double, swLng: Double, cities: List[JsValue]) =  {\n-    //TODO: Do binary search\n-    val citiesWithinBoundary = cities.filter{\n-      city =>\n-        (city \\ CentroidLatitude).as[Double] <= neLat && (city \\ CentroidLatitude).as[Double] >= swLat.toDouble && (city \\ CentroidLongitude).as[Double] <= neLng.toDouble && (city \\ CentroidLongitude).as[Double] >= swLng.toDouble\n+    /*","path":"neo/app/controllers/Application.scala","position":17,"original_position":17,"commit_id":"b238cab6f83f21cf935a8cac072cbf0041270608","original_commit_id":"b238cab6f83f21cf935a8cac072cbf0041270608","user":{"login":"JavierJia","id":910229,"avatar_url":"https://avatars.githubusercontent.com/u/910229?v=3","gravatar_id":"","url":"https://api.github.com/users/JavierJia","html_url":"https://github.com/JavierJia","followers_url":"https://api.github.com/users/JavierJia/followers","following_url":"https://api.github.com/users/JavierJia/following{/other_user}","gists_url":"https://api.github.com/users/JavierJia/gists{/gist_id}","starred_url":"https://api.github.com/users/JavierJia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavierJia/subscriptions","organizations_url":"https://api.github.com/users/JavierJia/orgs","repos_url":"https://api.github.com/users/JavierJia/repos","events_url":"https://api.github.com/users/JavierJia/events{/privacy}","received_events_url":"https://api.github.com/users/JavierJia/received_events","type":"User","site_admin":false},"body":"Every function should explicitly declare the return type.\r\n`def findCity(neLat: Double, swLat: Double, neLng: Double, swLng: Double, cities: List[JsValue])` ==> \r\n`def findCity(neLat: Double, swLat: Double, neLng: Double, swLng: Double, cities: List[JsValue]) : JsArray` ","created_at":"2016-11-30T01:01:18Z","updated_at":"2016-11-30T01:01:18Z","html_url":"https://github.com/ISG-ICS/cloudberry/pull/225#discussion_r90150196","pull_request_url":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/comments/90150196"},"html":{"href":"https://github.com/ISG-ICS/cloudberry/pull/225#discussion_r90150196"},"pull_request":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/225","id":94763342,"html_url":"https://github.com/ISG-ICS/cloudberry/pull/225","diff_url":"https://github.com/ISG-ICS/cloudberry/pull/225.diff","patch_url":"https://github.com/ISG-ICS/cloudberry/pull/225.patch","issue_url":"https://api.github.com/repos/ISG-ICS/cloudberry/issues/225","number":225,"state":"open","locked":false,"title":"Do binary search in middleware while searching for cities within a boundary.","user":{"login":"zonghengma","id":7375243,"avatar_url":"https://avatars.githubusercontent.com/u/7375243?v=3","gravatar_id":"","url":"https://api.github.com/users/zonghengma","html_url":"https://github.com/zonghengma","followers_url":"https://api.github.com/users/zonghengma/followers","following_url":"https://api.github.com/users/zonghengma/following{/other_user}","gists_url":"https://api.github.com/users/zonghengma/gists{/gist_id}","starred_url":"https://api.github.com/users/zonghengma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonghengma/subscriptions","organizations_url":"https://api.github.com/users/zonghengma/orgs","repos_url":"https://api.github.com/users/zonghengma/repos","events_url":"https://api.github.com/users/zonghengma/events{/privacy}","received_events_url":"https://api.github.com/users/zonghengma/received_events","type":"User","site_admin":false},"body":"The middle-ware can do binary search. I'll compare the times of running binary search and scaning all the cities.","created_at":"2016-11-22T07:49:05Z","updated_at":"2016-11-30T01:04:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5482fa365092500a0162f8c7c42a8c45ad57d62a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/225/commits","review_comments_url":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/225/comments","review_comment_url":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ISG-ICS/cloudberry/issues/225/comments","statuses_url":"https://api.github.com/repos/ISG-ICS/cloudberry/statuses/b238cab6f83f21cf935a8cac072cbf0041270608","head":{"label":"zonghengma:binary_search","ref":"binary_search","sha":"b238cab6f83f21cf935a8cac072cbf0041270608","user":{"login":"zonghengma","id":7375243,"avatar_url":"https://avatars.githubusercontent.com/u/7375243?v=3","gravatar_id":"","url":"https://api.github.com/users/zonghengma","html_url":"https://github.com/zonghengma","followers_url":"https://api.github.com/users/zonghengma/followers","following_url":"https://api.github.com/users/zonghengma/following{/other_user}","gists_url":"https://api.github.com/users/zonghengma/gists{/gist_id}","starred_url":"https://api.github.com/users/zonghengma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonghengma/subscriptions","organizations_url":"https://api.github.com/users/zonghengma/orgs","repos_url":"https://api.github.com/users/zonghengma/repos","events_url":"https://api.github.com/users/zonghengma/events{/privacy}","received_events_url":"https://api.github.com/users/zonghengma/received_events","type":"User","site_admin":false},"repo":{"id":71945728,"name":"cloudberry","full_name":"zonghengma/cloudberry","owner":{"login":"zonghengma","id":7375243,"avatar_url":"https://avatars.githubusercontent.com/u/7375243?v=3","gravatar_id":"","url":"https://api.github.com/users/zonghengma","html_url":"https://github.com/zonghengma","followers_url":"https://api.github.com/users/zonghengma/followers","following_url":"https://api.github.com/users/zonghengma/following{/other_user}","gists_url":"https://api.github.com/users/zonghengma/gists{/gist_id}","starred_url":"https://api.github.com/users/zonghengma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonghengma/subscriptions","organizations_url":"https://api.github.com/users/zonghengma/orgs","repos_url":"https://api.github.com/users/zonghengma/repos","events_url":"https://api.github.com/users/zonghengma/events{/privacy}","received_events_url":"https://api.github.com/users/zonghengma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zonghengma/cloudberry","description":"Interactive Twitter map analytic application","fork":true,"url":"https://api.github.com/repos/zonghengma/cloudberry","forks_url":"https://api.github.com/repos/zonghengma/cloudberry/forks","keys_url":"https://api.github.com/repos/zonghengma/cloudberry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zonghengma/cloudberry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zonghengma/cloudberry/teams","hooks_url":"https://api.github.com/repos/zonghengma/cloudberry/hooks","issue_events_url":"https://api.github.com/repos/zonghengma/cloudberry/issues/events{/number}","events_url":"https://api.github.com/repos/zonghengma/cloudberry/events","assignees_url":"https://api.github.com/repos/zonghengma/cloudberry/assignees{/user}","branches_url":"https://api.github.com/repos/zonghengma/cloudberry/branches{/branch}","tags_url":"https://api.github.com/repos/zonghengma/cloudberry/tags","blobs_url":"https://api.github.com/repos/zonghengma/cloudberry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zonghengma/cloudberry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zonghengma/cloudberry/git/refs{/sha}","trees_url":"https://api.github.com/repos/zonghengma/cloudberry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zonghengma/cloudberry/statuses/{sha}","languages_url":"https://api.github.com/repos/zonghengma/cloudberry/languages","stargazers_url":"https://api.github.com/repos/zonghengma/cloudberry/stargazers","contributors_url":"https://api.github.com/repos/zonghengma/cloudberry/contributors","subscribers_url":"https://api.github.com/repos/zonghengma/cloudberry/subscribers","subscription_url":"https://api.github.com/repos/zonghengma/cloudberry/subscription","commits_url":"https://api.github.com/repos/zonghengma/cloudberry/commits{/sha}","git_commits_url":"https://api.github.com/repos/zonghengma/cloudberry/git/commits{/sha}","comments_url":"https://api.github.com/repos/zonghengma/cloudberry/comments{/number}","issue_comment_url":"https://api.github.com/repos/zonghengma/cloudberry/issues/comments{/number}","contents_url":"https://api.github.com/repos/zonghengma/cloudberry/contents/{+path}","compare_url":"https://api.github.com/repos/zonghengma/cloudberry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zonghengma/cloudberry/merges","archive_url":"https://api.github.com/repos/zonghengma/cloudberry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zonghengma/cloudberry/downloads","issues_url":"https://api.github.com/repos/zonghengma/cloudberry/issues{/number}","pulls_url":"https://api.github.com/repos/zonghengma/cloudberry/pulls{/number}","milestones_url":"https://api.github.com/repos/zonghengma/cloudberry/milestones{/number}","notifications_url":"https://api.github.com/repos/zonghengma/cloudberry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zonghengma/cloudberry/labels{/name}","releases_url":"https://api.github.com/repos/zonghengma/cloudberry/releases{/id}","deployments_url":"https://api.github.com/repos/zonghengma/cloudberry/deployments","created_at":"2016-10-25T22:55:23Z","updated_at":"2016-10-25T22:55:26Z","pushed_at":"2016-11-30T00:48:47Z","git_url":"git://github.com/zonghengma/cloudberry.git","ssh_url":"git@github.com:zonghengma/cloudberry.git","clone_url":"https://github.com/zonghengma/cloudberry.git","svn_url":"https://github.com/zonghengma/cloudberry","homepage":"http://cloudberry.ics.uci.edu","size":164086,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ISG-ICS:master","ref":"master","sha":"a2c872ef9de57221e7e8b68aac52555c340c0e4b","user":{"login":"ISG-ICS","id":17169982,"avatar_url":"https://avatars.githubusercontent.com/u/17169982?v=3","gravatar_id":"","url":"https://api.github.com/users/ISG-ICS","html_url":"https://github.com/ISG-ICS","followers_url":"https://api.github.com/users/ISG-ICS/followers","following_url":"https://api.github.com/users/ISG-ICS/following{/other_user}","gists_url":"https://api.github.com/users/ISG-ICS/gists{/gist_id}","starred_url":"https://api.github.com/users/ISG-ICS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISG-ICS/subscriptions","organizations_url":"https://api.github.com/users/ISG-ICS/orgs","repos_url":"https://api.github.com/users/ISG-ICS/repos","events_url":"https://api.github.com/users/ISG-ICS/events{/privacy}","received_events_url":"https://api.github.com/users/ISG-ICS/received_events","type":"Organization","site_admin":false},"repo":{"id":46375119,"name":"cloudberry","full_name":"ISG-ICS/cloudberry","owner":{"login":"ISG-ICS","id":17169982,"avatar_url":"https://avatars.githubusercontent.com/u/17169982?v=3","gravatar_id":"","url":"https://api.github.com/users/ISG-ICS","html_url":"https://github.com/ISG-ICS","followers_url":"https://api.github.com/users/ISG-ICS/followers","following_url":"https://api.github.com/users/ISG-ICS/following{/other_user}","gists_url":"https://api.github.com/users/ISG-ICS/gists{/gist_id}","starred_url":"https://api.github.com/users/ISG-ICS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISG-ICS/subscriptions","organizations_url":"https://api.github.com/users/ISG-ICS/orgs","repos_url":"https://api.github.com/users/ISG-ICS/repos","events_url":"https://api.github.com/users/ISG-ICS/events{/privacy}","received_events_url":"https://api.github.com/users/ISG-ICS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISG-ICS/cloudberry","description":"Interactive analytic system","fork":false,"url":"https://api.github.com/repos/ISG-ICS/cloudberry","forks_url":"https://api.github.com/repos/ISG-ICS/cloudberry/forks","keys_url":"https://api.github.com/repos/ISG-ICS/cloudberry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISG-ICS/cloudberry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISG-ICS/cloudberry/teams","hooks_url":"https://api.github.com/repos/ISG-ICS/cloudberry/hooks","issue_events_url":"https://api.github.com/repos/ISG-ICS/cloudberry/issues/events{/number}","events_url":"https://api.github.com/repos/ISG-ICS/cloudberry/events","assignees_url":"https://api.github.com/repos/ISG-ICS/cloudberry/assignees{/user}","branches_url":"https://api.github.com/repos/ISG-ICS/cloudberry/branches{/branch}","tags_url":"https://api.github.com/repos/ISG-ICS/cloudberry/tags","blobs_url":"https://api.github.com/repos/ISG-ICS/cloudberry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISG-ICS/cloudberry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISG-ICS/cloudberry/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISG-ICS/cloudberry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISG-ICS/cloudberry/statuses/{sha}","languages_url":"https://api.github.com/repos/ISG-ICS/cloudberry/languages","stargazers_url":"https://api.github.com/repos/ISG-ICS/cloudberry/stargazers","contributors_url":"https://api.github.com/repos/ISG-ICS/cloudberry/contributors","subscribers_url":"https://api.github.com/repos/ISG-ICS/cloudberry/subscribers","subscription_url":"https://api.github.com/repos/ISG-ICS/cloudberry/subscription","commits_url":"https://api.github.com/repos/ISG-ICS/cloudberry/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISG-ICS/cloudberry/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISG-ICS/cloudberry/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISG-ICS/cloudberry/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISG-ICS/cloudberry/contents/{+path}","compare_url":"https://api.github.com/repos/ISG-ICS/cloudberry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISG-ICS/cloudberry/merges","archive_url":"https://api.github.com/repos/ISG-ICS/cloudberry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISG-ICS/cloudberry/downloads","issues_url":"https://api.github.com/repos/ISG-ICS/cloudberry/issues{/number}","pulls_url":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls{/number}","milestones_url":"https://api.github.com/repos/ISG-ICS/cloudberry/milestones{/number}","notifications_url":"https://api.github.com/repos/ISG-ICS/cloudberry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISG-ICS/cloudberry/labels{/name}","releases_url":"https://api.github.com/repos/ISG-ICS/cloudberry/releases{/id}","deployments_url":"https://api.github.com/repos/ISG-ICS/cloudberry/deployments","created_at":"2015-11-17T20:59:29Z","updated_at":"2016-11-29T18:31:56Z","pushed_at":"2016-11-29T18:47:31Z","git_url":"git://github.com/ISG-ICS/cloudberry.git","ssh_url":"git@github.com:ISG-ICS/cloudberry.git","clone_url":"https://github.com/ISG-ICS/cloudberry.git","svn_url":"https://github.com/ISG-ICS/cloudberry","homepage":"http://cloudberry.ics.uci.edu","size":173429,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":30,"forks":17,"open_issues":30,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/225"},"html":{"href":"https://github.com/ISG-ICS/cloudberry/pull/225"},"issue":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/issues/225"},"comments":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/ISG-ICS/cloudberry/statuses/b238cab6f83f21cf935a8cac072cbf0041270608"}}}}
{"actor":{"display_login":"JavierJia"}}