{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/50385284","id":50385284,"diff_hunk":"@@ -36,26 +37,59 @@ git_init_if_necessary() {\n     git config remote.origin.fetch \"+refs/heads/*:refs/remotes/origin/*\"\n   fi\n \n-  if git remote show origin -n | grep -q \"mxcl/homebrew\"\n+  if [[ \"$(git remote show origin -n)\" = *\"mxcl/homebrew\"* ]]\n   then\n     git remote set-url origin https://github.com/Homebrew/homebrew.git\n     git remote set-url --delete origin \".*mxcl\\/homebrew.*\"\n   fi\n }\n \n+rename_taps_dir_if_necessary() {\n+  local tap_dir\n+  for tap_dir in \"$HOMEBREW_LIBRARY\"/Taps/*\n+  do\n+    [[ -d \"$tap_dir/.git\" ]] || continue\n+    local tap_dir_basename\n+    tap_dir_basename=\"$(basename \"$tap_dir\")\"\n+    if [[ \"$tap_dir_basename\" = *\"-\"* ]]\n+    then\n+      # only replace the *last* dash: yes, tap filenames suck\n+      local user\n+      local repo\n+      user=\"$(echo \"${tap_dir_basename%-*}\" | tr \"[:upper:]\" \"[:lower:]\")\"\n+      repo=\"$(echo \"${tap_dir_basename:${#user}+1}\" | tr \"[:upper:]\" \"[:lower:]\")\"\n+      mkdir -p \"$HOMEBREW_LIBRARY/Taps/$user\"\n+      mv \"$tap_dir\", \"$HOMEBREW_LIBRARY/Taps/$user/homebrew-$repo\"\n+\n+      if [[ ${#${tap_dir_basename//[^\\-]}} -gt 1 ]]\n+      then\n+        echo \"Homebrew changed the structure of Taps like <someuser>/<sometap>. \" >&2\n+        echo \"So you may need to rename $HOMEBREW_LIBRARY/Taps/$user/homebrew-$repo manually.\" >&2\n+      fi\n+    else\n+      echo \"Homebrew changed the structure of Taps like <someuser>/<sometap>. \" >&2\n+      echo \"$tap_dir is incorrect name format. You may need to rename it like <someuser>/<sometap> manually.\" >&2","path":"Library/Homebrew/cmd/update-bash.sh","position":null,"original_position":69,"commit_id":"b11313b65a5706f8f9618667910398cadf59ac59","original_commit_id":"2c2092c1c68ca7b614dc088c8b1c80494c84d1b3","user":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=3","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"body":"I changed `like` part. As for `$tap_dir`, I keep it as it is because `$tap_dir` is a full path not tap name.","created_at":"2016-01-21T10:46:40Z","updated_at":"2016-01-21T10:46:40Z","html_url":"https://github.com/Homebrew/homebrew/pull/48286#discussion_r50385284","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/48286","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/50385284"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/48286#discussion_r50385284"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/48286"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/48286","id":56609661,"html_url":"https://github.com/Homebrew/homebrew/pull/48286","diff_url":"https://github.com/Homebrew/homebrew/pull/48286.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/48286.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/48286","number":48286,"state":"open","locked":false,"title":"update-bash: various","user":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=3","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"body":"\r\ncc @Homebrew/maintainers ","created_at":"2016-01-20T13:50:17Z","updated_at":"2016-01-21T10:46:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c33e60b29011df05ad06bd5e0aeaef2105afc1f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/48286/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/48286/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/48286/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/b11313b65a5706f8f9618667910398cadf59ac59","head":{"label":"xu-cheng:update-bash","ref":"update-bash","sha":"b11313b65a5706f8f9618667910398cadf59ac59","user":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=3","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"repo":{"id":17541180,"name":"homebrew","full_name":"xu-cheng/homebrew","owner":{"login":"xu-cheng","id":3105373,"avatar_url":"https://avatars.githubusercontent.com/u/3105373?v=3","gravatar_id":"","url":"https://api.github.com/users/xu-cheng","html_url":"https://github.com/xu-cheng","followers_url":"https://api.github.com/users/xu-cheng/followers","following_url":"https://api.github.com/users/xu-cheng/following{/other_user}","gists_url":"https://api.github.com/users/xu-cheng/gists{/gist_id}","starred_url":"https://api.github.com/users/xu-cheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xu-cheng/subscriptions","organizations_url":"https://api.github.com/users/xu-cheng/orgs","repos_url":"https://api.github.com/users/xu-cheng/repos","events_url":"https://api.github.com/users/xu-cheng/events{/privacy}","received_events_url":"https://api.github.com/users/xu-cheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xu-cheng/homebrew","description":":beer: The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/xu-cheng/homebrew","forks_url":"https://api.github.com/repos/xu-cheng/homebrew/forks","keys_url":"https://api.github.com/repos/xu-cheng/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xu-cheng/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xu-cheng/homebrew/teams","hooks_url":"https://api.github.com/repos/xu-cheng/homebrew/hooks","issue_events_url":"https://api.github.com/repos/xu-cheng/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/xu-cheng/homebrew/events","assignees_url":"https://api.github.com/repos/xu-cheng/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/xu-cheng/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/xu-cheng/homebrew/tags","blobs_url":"https://api.github.com/repos/xu-cheng/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xu-cheng/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xu-cheng/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/xu-cheng/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xu-cheng/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/xu-cheng/homebrew/languages","stargazers_url":"https://api.github.com/repos/xu-cheng/homebrew/stargazers","contributors_url":"https://api.github.com/repos/xu-cheng/homebrew/contributors","subscribers_url":"https://api.github.com/repos/xu-cheng/homebrew/subscribers","subscription_url":"https://api.github.com/repos/xu-cheng/homebrew/subscription","commits_url":"https://api.github.com/repos/xu-cheng/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/xu-cheng/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/xu-cheng/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/xu-cheng/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/xu-cheng/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/xu-cheng/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xu-cheng/homebrew/merges","archive_url":"https://api.github.com/repos/xu-cheng/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xu-cheng/homebrew/downloads","issues_url":"https://api.github.com/repos/xu-cheng/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/xu-cheng/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/xu-cheng/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/xu-cheng/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xu-cheng/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/xu-cheng/homebrew/releases{/id}","created_at":"2014-03-08T12:05:07Z","updated_at":"2016-01-11T06:32:34Z","pushed_at":"2016-01-21T10:45:00Z","git_url":"git://github.com/xu-cheng/homebrew.git","ssh_url":"git@github.com:xu-cheng/homebrew.git","clone_url":"https://github.com/xu-cheng/homebrew.git","svn_url":"https://github.com/xu-cheng/homebrew","homepage":"http://brew.sh","size":68027,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"eea7220ab53e8dce38820286838e546184a186a2","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":":beer: The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2016-01-21T09:03:24Z","pushed_at":"2016-01-21T10:45:03Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1411440,"stargazers_count":28607,"watchers_count":28607,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":14106,"mirror_url":null,"open_issues_count":424,"forks":14106,"open_issues":424,"watchers":28607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/48286"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/48286"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/48286"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/48286/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/48286/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/48286/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/b11313b65a5706f8f9618667910398cadf59ac59"}}}}