{"action":"created","issue":{"url":"https://api.github.com/repos/yarpc/yarpc-go/issues/628","repository_url":"https://api.github.com/repos/yarpc/yarpc-go","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/628/labels{/name}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/628/comments","events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/628/events","html_url":"https://github.com/yarpc/yarpc-go/pull/628","id":196885998,"number":628,"title":"Update dockerfile and add make docker-test","user":{"login":"peter-edge","id":4228796,"avatar_url":"https://avatars.githubusercontent.com/u/4228796?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-21T09:36:23Z","updated_at":"2016-12-21T14:53:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/628","html_url":"https://github.com/yarpc/yarpc-go/pull/628","diff_url":"https://github.com/yarpc/yarpc-go/pull/628.diff","patch_url":"https://github.com/yarpc/yarpc-go/pull/628.patch"},"body":"This does a few things:\r\n\r\n- Adds a .dockerignore that matches .gitignore, specifically so that vendor is ignored\r\n- Updates the Dockerfile with a few minor cleanups (1.7 -> 1.74, etc)\r\n- Updates the Dockerfile to do glide install in a cache-friendly way, and set WORKDIR\r\n- Changes ENTRYPOINT to CMD to make it simpler to override the default comand\r\n- Adds make docker-build and make-docker test, which use docker directly, but match the current name of the image outputted by docker-compose (because of port bindings, doing docker-compose run go make test will fail)\r\n\r\nI like having a Dockerfile that allows me to run make test in a fresh environment, to confirm that make test works out of the box for new developers. With that said, it still doesn't, because vendor isn't checked in, and glide install is not a dependency of make test, but at least the Dockerfile somewhat documents that (and it is annoying to have glide install run every time)."},"comment":{"url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments/268541749","html_url":"https://github.com/yarpc/yarpc-go/pull/628#issuecomment-268541749","issue_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/628","id":268541749,"user":{"login":"peter-edge","id":4228796,"avatar_url":"https://avatars.githubusercontent.com/u/4228796?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T14:53:54Z","updated_at":"2016-12-21T14:53:54Z","body":"I think travis failed just because of docker push (which does not have a password assigned here, which makes sense)"}}
{"actor":{"display_login":"peter-edge"}}