{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webauthn/pulls/comments/70488828","id":70488828,"diff_hunk":"@@ -281,7 +281,8 @@ The API is defined by the following Web IDL fragment.\n     interface WebAuthentication {\n         Promise < ScopedCredentialInfo > makeCredential (\n             Account                                 accountInformation,\n-            sequence < ScopedCredentialParameters > cryptoParameters,\n+            sequence < CredentialType >             supportedTypes,\n+            sequence < AlgorithmIdentifier >        supportedAlgorithms,","path":"index.bs","position":null,"original_position":6,"commit_id":"9de3a98ee74a6c70b5a50a54263e8472503851fe","original_commit_id":"548efc13b1f42f95faf545dba9e5199ec8218ea7","user":{"login":"jcjones","id":518542,"avatar_url":"https://avatars.githubusercontent.com/u/518542?v=3","gravatar_id":"","url":"https://api.github.com/users/jcjones","html_url":"https://github.com/jcjones","followers_url":"https://api.github.com/users/jcjones/followers","following_url":"https://api.github.com/users/jcjones/following{/other_user}","gists_url":"https://api.github.com/users/jcjones/gists{/gist_id}","starred_url":"https://api.github.com/users/jcjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcjones/subscriptions","organizations_url":"https://api.github.com/users/jcjones/orgs","repos_url":"https://api.github.com/users/jcjones/repos","events_url":"https://api.github.com/users/jcjones/events{/privacy}","received_events_url":"https://api.github.com/users/jcjones/received_events","type":"User","site_admin":false},"body":"This is now PR #143.","created_at":"2016-07-12T18:01:55Z","updated_at":"2016-07-12T18:01:55Z","html_url":"https://github.com/w3c/webauthn/pull/142#discussion_r70488828","pull_request_url":"https://api.github.com/repos/w3c/webauthn/pulls/142","_links":{"self":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/comments/70488828"},"html":{"href":"https://github.com/w3c/webauthn/pull/142#discussion_r70488828"},"pull_request":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/webauthn/pulls/142","id":77027190,"html_url":"https://github.com/w3c/webauthn/pull/142","diff_url":"https://github.com/w3c/webauthn/pull/142.diff","patch_url":"https://github.com/w3c/webauthn/pull/142.patch","issue_url":"https://api.github.com/repos/w3c/webauthn/issues/142","number":142,"state":"open","locked":false,"title":"API aesthetic updates","user":{"login":"jcjones","id":518542,"avatar_url":"https://avatars.githubusercontent.com/u/518542?v=3","gravatar_id":"","url":"https://api.github.com/users/jcjones","html_url":"https://github.com/jcjones","followers_url":"https://api.github.com/users/jcjones/followers","following_url":"https://api.github.com/users/jcjones/following{/other_user}","gists_url":"https://api.github.com/users/jcjones/gists{/gist_id}","starred_url":"https://api.github.com/users/jcjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcjones/subscriptions","organizations_url":"https://api.github.com/users/jcjones/orgs","repos_url":"https://api.github.com/users/jcjones/repos","events_url":"https://api.github.com/users/jcjones/events{/privacy}","received_events_url":"https://api.github.com/users/jcjones/received_events","type":"User","site_admin":false},"body":"These changes are also aesthetic, similar to PR #135, but in this case they are all related to API aesthetics. They are still, for the most part, editorial in nature. It'd be good to get some care in the review of the `makeCredential()` updates per the removal of `ScopedCredentialParameters`, though.\r\n\r\nFirst, per Vijay's comment [on issue 60](https://github.com/w3c/webauthn/issues/60#issuecomment-230693738), moving the interface from the global window namespace to the navigator namespace to reduce pollution of the global namespace. This also makes semantic sense, as the HTML5 `window` object represents an open window in the browser, whereas the `navigator` object represents the browser itself. Since authenticators belong to the whole system, not one window, the object model makes more sense to be a property attached to `navigator`.\r\n\r\nSecond, I've renamed the factory object from `navigator.webauthn` to `navigator.authentication`. In general, web APIs shouldn't use the word \"web\" in their name. It's implicit. (I considered \"authn\" but I feel the verbosity here is justified -- most of the users will assign the object to a local variable for ease of use anyway, like our example code does.)\r\n\r\nThird, I changed the type of `ScopedCredentialInfo.publicKey` from `any` to `CryptoKey`, referencing the WebCryptoAPI for the type information. This feels like a fairly substantial change, but it really isn't: javascript gets flexibility to ask for the pubkey in a variety of formats (including JsonWebKey), and we get a tighter (and more expected) type.\r\n\r\nFourth, I've removed the `ScopedCredentialParameters` tuple by unpairing the `type` and `algorithm` fields. `ScopedCredentialParameters` is used in the procedure for normalizing algorithms and types, but said procedure doesn't actually use the types! This changes the makeCredential() method to instead have a list of supported types and a list of supported algorithms, and perform its procedure that way.\r\n\r\nKeeping these together in an object gives a kind of flexibility, but after consideration, I don't see much actual purpose in said flexibility. A RP can either handle an algorithm or not, and is either willing to handle an authenticator type or not -- particular combinations seem an unnecessary burden.\r\n\r\nFifth, in response to [Vijay's note about extension names](https://lists.w3.org/Archives/Public /public- webauthn/2016Jul/0046.html), I've renamed the example extensions (correcting a CBOR mismatch in the process). I also noted in section 7.1, Extension identifiers, that  \"Use of dot-separated notation here does not imply an object hierarchy.\", and provided a counterexample of a differently- separated, versioned id: `mycompany-myextension_v01`. None of the pre-defined extensions were modified.\r\n\r\n","created_at":"2016-07-11T21:33:39Z","updated_at":"2016-07-12T18:01:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21f2c3dd6424318d9695dfd9ad7fbe5e0ae5f400","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/webauthn/pulls/142/commits","review_comments_url":"https://api.github.com/repos/w3c/webauthn/pulls/142/comments","review_comment_url":"https://api.github.com/repos/w3c/webauthn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webauthn/issues/142/comments","statuses_url":"https://api.github.com/repos/w3c/webauthn/statuses/9de3a98ee74a6c70b5a50a54263e8472503851fe","head":{"label":"jcjones:master","ref":"master","sha":"9de3a98ee74a6c70b5a50a54263e8472503851fe","user":{"login":"jcjones","id":518542,"avatar_url":"https://avatars.githubusercontent.com/u/518542?v=3","gravatar_id":"","url":"https://api.github.com/users/jcjones","html_url":"https://github.com/jcjones","followers_url":"https://api.github.com/users/jcjones/followers","following_url":"https://api.github.com/users/jcjones/following{/other_user}","gists_url":"https://api.github.com/users/jcjones/gists{/gist_id}","starred_url":"https://api.github.com/users/jcjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcjones/subscriptions","organizations_url":"https://api.github.com/users/jcjones/orgs","repos_url":"https://api.github.com/users/jcjones/repos","events_url":"https://api.github.com/users/jcjones/events{/privacy}","received_events_url":"https://api.github.com/users/jcjones/received_events","type":"User","site_admin":false},"repo":{"id":54432506,"name":"webauthn","full_name":"jcjones/webauthn","owner":{"login":"jcjones","id":518542,"avatar_url":"https://avatars.githubusercontent.com/u/518542?v=3","gravatar_id":"","url":"https://api.github.com/users/jcjones","html_url":"https://github.com/jcjones","followers_url":"https://api.github.com/users/jcjones/followers","following_url":"https://api.github.com/users/jcjones/following{/other_user}","gists_url":"https://api.github.com/users/jcjones/gists{/gist_id}","starred_url":"https://api.github.com/users/jcjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcjones/subscriptions","organizations_url":"https://api.github.com/users/jcjones/orgs","repos_url":"https://api.github.com/users/jcjones/repos","events_url":"https://api.github.com/users/jcjones/events{/privacy}","received_events_url":"https://api.github.com/users/jcjones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcjones/webauthn","description":"Personal fork of WebAuthn Specification","fork":true,"url":"https://api.github.com/repos/jcjones/webauthn","forks_url":"https://api.github.com/repos/jcjones/webauthn/forks","keys_url":"https://api.github.com/repos/jcjones/webauthn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcjones/webauthn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcjones/webauthn/teams","hooks_url":"https://api.github.com/repos/jcjones/webauthn/hooks","issue_events_url":"https://api.github.com/repos/jcjones/webauthn/issues/events{/number}","events_url":"https://api.github.com/repos/jcjones/webauthn/events","assignees_url":"https://api.github.com/repos/jcjones/webauthn/assignees{/user}","branches_url":"https://api.github.com/repos/jcjones/webauthn/branches{/branch}","tags_url":"https://api.github.com/repos/jcjones/webauthn/tags","blobs_url":"https://api.github.com/repos/jcjones/webauthn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcjones/webauthn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcjones/webauthn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcjones/webauthn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcjones/webauthn/statuses/{sha}","languages_url":"https://api.github.com/repos/jcjones/webauthn/languages","stargazers_url":"https://api.github.com/repos/jcjones/webauthn/stargazers","contributors_url":"https://api.github.com/repos/jcjones/webauthn/contributors","subscribers_url":"https://api.github.com/repos/jcjones/webauthn/subscribers","subscription_url":"https://api.github.com/repos/jcjones/webauthn/subscription","commits_url":"https://api.github.com/repos/jcjones/webauthn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcjones/webauthn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcjones/webauthn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcjones/webauthn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcjones/webauthn/contents/{+path}","compare_url":"https://api.github.com/repos/jcjones/webauthn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcjones/webauthn/merges","archive_url":"https://api.github.com/repos/jcjones/webauthn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcjones/webauthn/downloads","issues_url":"https://api.github.com/repos/jcjones/webauthn/issues{/number}","pulls_url":"https://api.github.com/repos/jcjones/webauthn/pulls{/number}","milestones_url":"https://api.github.com/repos/jcjones/webauthn/milestones{/number}","notifications_url":"https://api.github.com/repos/jcjones/webauthn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcjones/webauthn/labels{/name}","releases_url":"https://api.github.com/repos/jcjones/webauthn/releases{/id}","deployments_url":"https://api.github.com/repos/jcjones/webauthn/deployments","created_at":"2016-03-22T00:22:23Z","updated_at":"2016-06-30T17:01:36Z","pushed_at":"2016-07-12T18:01:36Z","git_url":"git://github.com/jcjones/webauthn.git","ssh_url":"git@github.com:jcjones/webauthn.git","clone_url":"https://github.com/jcjones/webauthn.git","svn_url":"https://github.com/jcjones/webauthn","homepage":"http://jcjones.github.io/webauthn/","size":2916,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"d34e23f986cc9b93c143b77c3a2de03209c44215","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":51303856,"name":"webauthn","full_name":"w3c/webauthn","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webauthn","description":"Web Authentication WG: https://www.w3.org/Webauthn       Editors' Draft:","fork":false,"url":"https://api.github.com/repos/w3c/webauthn","forks_url":"https://api.github.com/repos/w3c/webauthn/forks","keys_url":"https://api.github.com/repos/w3c/webauthn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webauthn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webauthn/teams","hooks_url":"https://api.github.com/repos/w3c/webauthn/hooks","issue_events_url":"https://api.github.com/repos/w3c/webauthn/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webauthn/events","assignees_url":"https://api.github.com/repos/w3c/webauthn/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webauthn/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webauthn/tags","blobs_url":"https://api.github.com/repos/w3c/webauthn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webauthn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webauthn/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webauthn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webauthn/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webauthn/languages","stargazers_url":"https://api.github.com/repos/w3c/webauthn/stargazers","contributors_url":"https://api.github.com/repos/w3c/webauthn/contributors","subscribers_url":"https://api.github.com/repos/w3c/webauthn/subscribers","subscription_url":"https://api.github.com/repos/w3c/webauthn/subscription","commits_url":"https://api.github.com/repos/w3c/webauthn/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webauthn/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webauthn/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webauthn/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webauthn/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webauthn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webauthn/merges","archive_url":"https://api.github.com/repos/w3c/webauthn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webauthn/downloads","issues_url":"https://api.github.com/repos/w3c/webauthn/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webauthn/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webauthn/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webauthn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webauthn/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webauthn/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webauthn/deployments","created_at":"2016-02-08T14:51:38Z","updated_at":"2016-07-02T10:13:33Z","pushed_at":"2016-07-12T18:01:47Z","git_url":"git://github.com/w3c/webauthn.git","ssh_url":"git@github.com:w3c/webauthn.git","clone_url":"https://github.com/w3c/webauthn.git","svn_url":"https://github.com/w3c/webauthn","homepage":"https://w3c.github.io/webauthn/","size":3685,"stargazers_count":24,"watchers_count":24,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":64,"forks":8,"open_issues":64,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/142"},"html":{"href":"https://github.com/w3c/webauthn/pull/142"},"issue":{"href":"https://api.github.com/repos/w3c/webauthn/issues/142"},"comments":{"href":"https://api.github.com/repos/w3c/webauthn/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webauthn/statuses/9de3a98ee74a6c70b5a50a54263e8472503851fe"}}}}
{"actor":{"display_login":"jcjones"}}