{"action":"created","comment":{"url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments/57495010","id":57495010,"diff_hunk":"@@ -317,7 +317,33 @@ public DataSet GetContributionTransactions( int groupId, int? personId, [FromBod\n         }\n \n         /// <summary>\n-        /// \n+        /// Gets the contribution transactions.\n+        /// </summary>\n+        /// <param name=\"groupId\">The group unique identifier.</param>\n+        /// <returns></returns>\n+        /// <exception cref=\"System.Web.Http.HttpResponseException\"></exception>\n+        [Authenticate, Secured]\n+        [HttpGet]\n+        [EnableQuery]\n+        [System.Web.Http.Route( \"api/FinancialTransactions/GetTransactionsForGivingGroup/{personId}\" )]\n+        public IQueryable<FinancialTransaction> GetTransactionsForGivingGroup( int personId )\n+        {","path":"Rock.Rest/Controllers/FinancialTransactionsController.Partial.cs","position":68,"original_position":68,"commit_id":"9b7b3e355f1538778d679f6edd37b0db5141ec4f","original_commit_id":"9b7b3e355f1538778d679f6edd37b0db5141ec4f","user":{"login":"azturner","id":548180,"avatar_url":"https://avatars.githubusercontent.com/u/548180?v=3","gravatar_id":"","url":"https://api.github.com/users/azturner","html_url":"https://github.com/azturner","followers_url":"https://api.github.com/users/azturner/followers","following_url":"https://api.github.com/users/azturner/following{/other_user}","gists_url":"https://api.github.com/users/azturner/gists{/gist_id}","starred_url":"https://api.github.com/users/azturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azturner/subscriptions","organizations_url":"https://api.github.com/users/azturner/orgs","repos_url":"https://api.github.com/users/azturner/repos","events_url":"https://api.github.com/users/azturner/events{/privacy}","received_events_url":"https://api.github.com/users/azturner/received_events","type":"User","site_admin":false},"body":"@benwiley, Does your app already depend on this method/parameter? A better name for the method might be `GetByPersonGivingId` since that is what is being used to query the transactions (there is also a GivingGroupId on person which is why it's a bit confusing).  \r\n\r\nAlso, if the calling app already has a person object (with a GivingId value already), an even better idea would be to just pass the GivingId instead of PersonId and call the method `GetByGivingId( int givingId )`","created_at":"2016-03-25T21:47:21Z","updated_at":"2016-03-25T21:47:21Z","html_url":"https://github.com/SparkDevNetwork/Rock/pull/1423#discussion_r57495010","pull_request_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/1423","_links":{"self":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments/57495010"},"html":{"href":"https://github.com/SparkDevNetwork/Rock/pull/1423#discussion_r57495010"},"pull_request":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/1423"}}},"pull_request":{"url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/1423","id":62280386,"html_url":"https://github.com/SparkDevNetwork/Rock/pull/1423","diff_url":"https://github.com/SparkDevNetwork/Rock/pull/1423.diff","patch_url":"https://github.com/SparkDevNetwork/Rock/pull/1423.patch","issue_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/1423","number":1423,"state":"open","locked":false,"title":"API Transactions by Giving Group","user":{"login":"benwiley","id":8700223,"avatar_url":"https://avatars.githubusercontent.com/u/8700223?v=3","gravatar_id":"","url":"https://api.github.com/users/benwiley","html_url":"https://github.com/benwiley","followers_url":"https://api.github.com/users/benwiley/followers","following_url":"https://api.github.com/users/benwiley/following{/other_user}","gists_url":"https://api.github.com/users/benwiley/gists{/gist_id}","starred_url":"https://api.github.com/users/benwiley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwiley/subscriptions","organizations_url":"https://api.github.com/users/benwiley/orgs","repos_url":"https://api.github.com/users/benwiley/repos","events_url":"https://api.github.com/users/benwiley/events{/privacy}","received_events_url":"https://api.github.com/users/benwiley/received_events","type":"User","site_admin":false},"body":"- Add endpoint to get a person's giving group's transactions.  This mimics the TransactionList block functionality with a person context (https://github.com/SparkDevNetwork/Rock/blob/develop/RockWeb/Blocks/Finance/TransactionList.ascx.cs#L906)\r\n- Add `DataMember` to AuthorizedPersonAlias to allow `$expand` ODATA operation","created_at":"2016-03-09T19:16:55Z","updated_at":"2016-03-25T21:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef67ce3c76b3b9e351c1c25767265247f0a03b0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/1423/commits","review_comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/1423/comments","review_comment_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/1423/comments","statuses_url":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/9b7b3e355f1538778d679f6edd37b0db5141ec4f","head":{"label":"NewSpring:api-transactions-by-giving-group","ref":"api-transactions-by-giving-group","sha":"9b7b3e355f1538778d679f6edd37b0db5141ec4f","user":{"login":"NewSpring","id":1241964,"avatar_url":"https://avatars.githubusercontent.com/u/1241964?v=3","gravatar_id":"","url":"https://api.github.com/users/NewSpring","html_url":"https://github.com/NewSpring","followers_url":"https://api.github.com/users/NewSpring/followers","following_url":"https://api.github.com/users/NewSpring/following{/other_user}","gists_url":"https://api.github.com/users/NewSpring/gists{/gist_id}","starred_url":"https://api.github.com/users/NewSpring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewSpring/subscriptions","organizations_url":"https://api.github.com/users/NewSpring/orgs","repos_url":"https://api.github.com/users/NewSpring/repos","events_url":"https://api.github.com/users/NewSpring/events{/privacy}","received_events_url":"https://api.github.com/users/NewSpring/received_events","type":"Organization","site_admin":false},"repo":{"id":7984241,"name":"Rock","full_name":"NewSpring/Rock","owner":{"login":"NewSpring","id":1241964,"avatar_url":"https://avatars.githubusercontent.com/u/1241964?v=3","gravatar_id":"","url":"https://api.github.com/users/NewSpring","html_url":"https://github.com/NewSpring","followers_url":"https://api.github.com/users/NewSpring/followers","following_url":"https://api.github.com/users/NewSpring/following{/other_user}","gists_url":"https://api.github.com/users/NewSpring/gists{/gist_id}","starred_url":"https://api.github.com/users/NewSpring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewSpring/subscriptions","organizations_url":"https://api.github.com/users/NewSpring/orgs","repos_url":"https://api.github.com/users/NewSpring/repos","events_url":"https://api.github.com/users/NewSpring/events{/privacy}","received_events_url":"https://api.github.com/users/NewSpring/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NewSpring/Rock","description":"Rock","fork":true,"url":"https://api.github.com/repos/NewSpring/Rock","forks_url":"https://api.github.com/repos/NewSpring/Rock/forks","keys_url":"https://api.github.com/repos/NewSpring/Rock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NewSpring/Rock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NewSpring/Rock/teams","hooks_url":"https://api.github.com/repos/NewSpring/Rock/hooks","issue_events_url":"https://api.github.com/repos/NewSpring/Rock/issues/events{/number}","events_url":"https://api.github.com/repos/NewSpring/Rock/events","assignees_url":"https://api.github.com/repos/NewSpring/Rock/assignees{/user}","branches_url":"https://api.github.com/repos/NewSpring/Rock/branches{/branch}","tags_url":"https://api.github.com/repos/NewSpring/Rock/tags","blobs_url":"https://api.github.com/repos/NewSpring/Rock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NewSpring/Rock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NewSpring/Rock/git/refs{/sha}","trees_url":"https://api.github.com/repos/NewSpring/Rock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NewSpring/Rock/statuses/{sha}","languages_url":"https://api.github.com/repos/NewSpring/Rock/languages","stargazers_url":"https://api.github.com/repos/NewSpring/Rock/stargazers","contributors_url":"https://api.github.com/repos/NewSpring/Rock/contributors","subscribers_url":"https://api.github.com/repos/NewSpring/Rock/subscribers","subscription_url":"https://api.github.com/repos/NewSpring/Rock/subscription","commits_url":"https://api.github.com/repos/NewSpring/Rock/commits{/sha}","git_commits_url":"https://api.github.com/repos/NewSpring/Rock/git/commits{/sha}","comments_url":"https://api.github.com/repos/NewSpring/Rock/comments{/number}","issue_comment_url":"https://api.github.com/repos/NewSpring/Rock/issues/comments{/number}","contents_url":"https://api.github.com/repos/NewSpring/Rock/contents/{+path}","compare_url":"https://api.github.com/repos/NewSpring/Rock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NewSpring/Rock/merges","archive_url":"https://api.github.com/repos/NewSpring/Rock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NewSpring/Rock/downloads","issues_url":"https://api.github.com/repos/NewSpring/Rock/issues{/number}","pulls_url":"https://api.github.com/repos/NewSpring/Rock/pulls{/number}","milestones_url":"https://api.github.com/repos/NewSpring/Rock/milestones{/number}","notifications_url":"https://api.github.com/repos/NewSpring/Rock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NewSpring/Rock/labels{/name}","releases_url":"https://api.github.com/repos/NewSpring/Rock/releases{/id}","deployments_url":"https://api.github.com/repos/NewSpring/Rock/deployments","created_at":"2013-02-03T00:34:44Z","updated_at":"2016-03-24T15:08:35Z","pushed_at":"2016-03-24T20:40:01Z","git_url":"git://github.com/NewSpring/Rock.git","ssh_url":"git@github.com:NewSpring/Rock.git","clone_url":"https://github.com/NewSpring/Rock.git","svn_url":"https://github.com/NewSpring/Rock","homepage":"http://rockrms.com","size":1032255,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"SparkDevNetwork:develop","ref":"develop","sha":"e441bfc8b43554cf5b83d2559dbd4049d0b8b82a","user":{"login":"SparkDevNetwork","id":548191,"avatar_url":"https://avatars.githubusercontent.com/u/548191?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkDevNetwork","html_url":"https://github.com/SparkDevNetwork","followers_url":"https://api.github.com/users/SparkDevNetwork/followers","following_url":"https://api.github.com/users/SparkDevNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparkDevNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkDevNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkDevNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparkDevNetwork/orgs","repos_url":"https://api.github.com/users/SparkDevNetwork/repos","events_url":"https://api.github.com/users/SparkDevNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparkDevNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":1614137,"name":"Rock","full_name":"SparkDevNetwork/Rock","owner":{"login":"SparkDevNetwork","id":548191,"avatar_url":"https://avatars.githubusercontent.com/u/548191?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkDevNetwork","html_url":"https://github.com/SparkDevNetwork","followers_url":"https://api.github.com/users/SparkDevNetwork/followers","following_url":"https://api.github.com/users/SparkDevNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparkDevNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkDevNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkDevNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparkDevNetwork/orgs","repos_url":"https://api.github.com/users/SparkDevNetwork/repos","events_url":"https://api.github.com/users/SparkDevNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparkDevNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SparkDevNetwork/Rock","description":"An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.","fork":false,"url":"https://api.github.com/repos/SparkDevNetwork/Rock","forks_url":"https://api.github.com/repos/SparkDevNetwork/Rock/forks","keys_url":"https://api.github.com/repos/SparkDevNetwork/Rock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SparkDevNetwork/Rock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SparkDevNetwork/Rock/teams","hooks_url":"https://api.github.com/repos/SparkDevNetwork/Rock/hooks","issue_events_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/events{/number}","events_url":"https://api.github.com/repos/SparkDevNetwork/Rock/events","assignees_url":"https://api.github.com/repos/SparkDevNetwork/Rock/assignees{/user}","branches_url":"https://api.github.com/repos/SparkDevNetwork/Rock/branches{/branch}","tags_url":"https://api.github.com/repos/SparkDevNetwork/Rock/tags","blobs_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/refs{/sha}","trees_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/{sha}","languages_url":"https://api.github.com/repos/SparkDevNetwork/Rock/languages","stargazers_url":"https://api.github.com/repos/SparkDevNetwork/Rock/stargazers","contributors_url":"https://api.github.com/repos/SparkDevNetwork/Rock/contributors","subscribers_url":"https://api.github.com/repos/SparkDevNetwork/Rock/subscribers","subscription_url":"https://api.github.com/repos/SparkDevNetwork/Rock/subscription","commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/commits{/sha}","git_commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/commits{/sha}","comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/comments{/number}","issue_comment_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/comments{/number}","contents_url":"https://api.github.com/repos/SparkDevNetwork/Rock/contents/{+path}","compare_url":"https://api.github.com/repos/SparkDevNetwork/Rock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SparkDevNetwork/Rock/merges","archive_url":"https://api.github.com/repos/SparkDevNetwork/Rock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SparkDevNetwork/Rock/downloads","issues_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues{/number}","pulls_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls{/number}","milestones_url":"https://api.github.com/repos/SparkDevNetwork/Rock/milestones{/number}","notifications_url":"https://api.github.com/repos/SparkDevNetwork/Rock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SparkDevNetwork/Rock/labels{/name}","releases_url":"https://api.github.com/repos/SparkDevNetwork/Rock/releases{/id}","deployments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/deployments","created_at":"2011-04-14T13:11:46Z","updated_at":"2016-03-09T14:31:27Z","pushed_at":"2016-03-25T21:39:56Z","git_url":"git://github.com/SparkDevNetwork/Rock.git","ssh_url":"git@github.com:SparkDevNetwork/Rock.git","clone_url":"https://github.com/SparkDevNetwork/Rock.git","svn_url":"https://github.com/SparkDevNetwork/Rock","homepage":"http://www.rockrms.com","size":1063391,"stargazers_count":149,"watchers_count":149,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":102,"mirror_url":null,"open_issues_count":115,"forks":102,"open_issues":115,"watchers":149,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/1423"},"html":{"href":"https://github.com/SparkDevNetwork/Rock/pull/1423"},"issue":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/1423"},"comments":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/1423/comments"},"review_comments":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/1423/comments"},"review_comment":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/1423/commits"},"statuses":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/9b7b3e355f1538778d679f6edd37b0db5141ec4f"}}}}