{"action":"created","issue":{"url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/171","repository_url":"https://api.github.com/repos/TTLabs/EvaporateJS","labels_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/171/comments","events_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/171/events","html_url":"https://github.com/TTLabs/EvaporateJS/issues/171","id":164126893,"number":171,"title":"partSize cant be overridden in the .add overrideOptions","user":{"login":"achard","id":776287,"avatar_url":"https://avatars.githubusercontent.com/u/776287?v=3","gravatar_id":"","url":"https://api.github.com/users/achard","html_url":"https://github.com/achard","followers_url":"https://api.github.com/users/achard/followers","following_url":"https://api.github.com/users/achard/following{/other_user}","gists_url":"https://api.github.com/users/achard/gists{/gist_id}","starred_url":"https://api.github.com/users/achard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achard/subscriptions","organizations_url":"https://api.github.com/users/achard/orgs","repos_url":"https://api.github.com/users/achard/repos","events_url":"https://api.github.com/users/achard/events{/privacy}","received_events_url":"https://api.github.com/users/achard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-06T17:09:30Z","updated_at":"2016-07-08T10:10:33Z","closed_at":null,"body":"It appears that partSize might be one of the properties that can't be changed using the .add functions overrideOptions object, however this is not mentioned in the readme.\r\n\r\nIt would be useful to allow the partSize to dynamically adjust depending on the size of the file to be uploaded."},"comment":{"url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/comments/231324377","html_url":"https://github.com/TTLabs/EvaporateJS/issues/171#issuecomment-231324377","issue_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/171","id":231324377,"user":{"login":"bikeath1337","id":243237,"avatar_url":"https://avatars.githubusercontent.com/u/243237?v=3","gravatar_id":"","url":"https://api.github.com/users/bikeath1337","html_url":"https://github.com/bikeath1337","followers_url":"https://api.github.com/users/bikeath1337/followers","following_url":"https://api.github.com/users/bikeath1337/following{/other_user}","gists_url":"https://api.github.com/users/bikeath1337/gists{/gist_id}","starred_url":"https://api.github.com/users/bikeath1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bikeath1337/subscriptions","organizations_url":"https://api.github.com/users/bikeath1337/orgs","repos_url":"https://api.github.com/users/bikeath1337/repos","events_url":"https://api.github.com/users/bikeath1337/events{/privacy}","received_events_url":"https://api.github.com/users/bikeath1337/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T10:10:32Z","updated_at":"2016-07-08T10:10:32Z","body":"Thanks @achard . While checking your report, I noticed that the docs for the .add() method did not match with the sample code usage. I pushed a \"fix\" to master, that hasn't been codified into a version, to address this. There is some discussion about it but basically, if you want to get it to work, you've got to pass the config as the second param like so:\r\n\r\n```javascript\r\n            ins.add(file, { // Add the file as the first parameter\r\n                partSize: setchunksize(files[i].size),\r\n                name: target_name,\r\n                file: files[i], // keep this here for backward compatibility\r\n                xAmzHeadersAtInitiate: s3UploadHeaders,\r\n                notSignedHeadersAtInitiate:{ \"Content-Disposition\":\"attachment\" },\r\n                contentType: filecontenttype,\r\n...\r\n```"}}
{"actor":{"display_login":"bikeath1337"}}