{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/comments/79449002","id":79449002,"diff_hunk":"@@ -2,13 +2,14 @@\n // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n \n using System;\n+using System.Threading.Tasks;\n \n namespace Microsoft.AspNetCore.ResponseCaching\n {\n     public interface IResponseCacheStore\n     {\n-        object Get(string key);\n-        void Set(string key, object entry, TimeSpan validFor);\n-        void Remove(string key);\n+        Task PopulateValueAsync(KeyValuePair keyValuePair);","path":"src/Microsoft.AspNetCore.ResponseCaching/Interfaces/IResponseCacheStore.cs","position":13,"original_position":13,"commit_id":"bfdf6d2e3d6679e6c2333c7c0bdaa7a2b2cc789b","original_commit_id":"bfdf6d2e3d6679e6c2333c7c0bdaa7a2b2cc789b","user":{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars.githubusercontent.com/u/1821173?v=3","gravatar_id":"","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},"body":"Needs numbers to show that KVP is significantly lighter than `Task<T>`","created_at":"2016-09-19T17:50:26Z","updated_at":"2016-09-19T17:52:01Z","html_url":"https://github.com/aspnet/ResponseCaching/pull/47#discussion_r79449002","pull_request_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/comments/79449002"},"html":{"href":"https://github.com/aspnet/ResponseCaching/pull/47#discussion_r79449002"},"pull_request":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/47","id":85650430,"html_url":"https://github.com/aspnet/ResponseCaching/pull/47","diff_url":"https://github.com/aspnet/ResponseCaching/pull/47.diff","patch_url":"https://github.com/aspnet/ResponseCaching/pull/47.patch","issue_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/47","number":47,"state":"open","locked":false,"title":"Make IResponseCacheStore APIs async","user":{"login":"JunTaoLuo","id":2030323,"avatar_url":"https://avatars.githubusercontent.com/u/2030323?v=3","gravatar_id":"","url":"https://api.github.com/users/JunTaoLuo","html_url":"https://github.com/JunTaoLuo","followers_url":"https://api.github.com/users/JunTaoLuo/followers","following_url":"https://api.github.com/users/JunTaoLuo/following{/other_user}","gists_url":"https://api.github.com/users/JunTaoLuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JunTaoLuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunTaoLuo/subscriptions","organizations_url":"https://api.github.com/users/JunTaoLuo/orgs","repos_url":"https://api.github.com/users/JunTaoLuo/repos","events_url":"https://api.github.com/users/JunTaoLuo/events{/privacy}","received_events_url":"https://api.github.com/users/JunTaoLuo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-16T22:44:53Z","updated_at":"2016-09-19T17:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc755d50e83e3e6405f089a77d86a7ed4330b34b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/47/commits","review_comments_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/47/comments","review_comment_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/47/comments","statuses_url":"https://api.github.com/repos/aspnet/ResponseCaching/statuses/bfdf6d2e3d6679e6c2333c7c0bdaa7a2b2cc789b","head":{"label":"aspnet:johluo/async-response-cache","ref":"johluo/async-response-cache","sha":"bfdf6d2e3d6679e6c2333c7c0bdaa7a2b2cc789b","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35685759,"name":"ResponseCaching","full_name":"aspnet/ResponseCaching","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/ResponseCaching","description":"ASP.NET Core middleware for caching responses","fork":false,"url":"https://api.github.com/repos/aspnet/ResponseCaching","forks_url":"https://api.github.com/repos/aspnet/ResponseCaching/forks","keys_url":"https://api.github.com/repos/aspnet/ResponseCaching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/ResponseCaching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/ResponseCaching/teams","hooks_url":"https://api.github.com/repos/aspnet/ResponseCaching/hooks","issue_events_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/ResponseCaching/events","assignees_url":"https://api.github.com/repos/aspnet/ResponseCaching/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/ResponseCaching/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/ResponseCaching/tags","blobs_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/ResponseCaching/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/ResponseCaching/languages","stargazers_url":"https://api.github.com/repos/aspnet/ResponseCaching/stargazers","contributors_url":"https://api.github.com/repos/aspnet/ResponseCaching/contributors","subscribers_url":"https://api.github.com/repos/aspnet/ResponseCaching/subscribers","subscription_url":"https://api.github.com/repos/aspnet/ResponseCaching/subscription","commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/ResponseCaching/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/ResponseCaching/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/ResponseCaching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/ResponseCaching/merges","archive_url":"https://api.github.com/repos/aspnet/ResponseCaching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/ResponseCaching/downloads","issues_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/ResponseCaching/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/ResponseCaching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/ResponseCaching/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/ResponseCaching/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/ResponseCaching/deployments","created_at":"2015-05-15T16:55:52Z","updated_at":"2016-09-19T08:26:45Z","pushed_at":"2016-09-19T04:00:08Z","git_url":"git://github.com/aspnet/ResponseCaching.git","ssh_url":"git@github.com:aspnet/ResponseCaching.git","clone_url":"https://github.com/aspnet/ResponseCaching.git","svn_url":"https://github.com/aspnet/ResponseCaching","homepage":"","size":217,"stargazers_count":18,"watchers_count":18,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":16,"forks":8,"open_issues":16,"watchers":18,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"fbac81a471a10232996cecb00563abc78055c3e7","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35685759,"name":"ResponseCaching","full_name":"aspnet/ResponseCaching","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/ResponseCaching","description":"ASP.NET Core middleware for caching responses","fork":false,"url":"https://api.github.com/repos/aspnet/ResponseCaching","forks_url":"https://api.github.com/repos/aspnet/ResponseCaching/forks","keys_url":"https://api.github.com/repos/aspnet/ResponseCaching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/ResponseCaching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/ResponseCaching/teams","hooks_url":"https://api.github.com/repos/aspnet/ResponseCaching/hooks","issue_events_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/ResponseCaching/events","assignees_url":"https://api.github.com/repos/aspnet/ResponseCaching/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/ResponseCaching/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/ResponseCaching/tags","blobs_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/ResponseCaching/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/ResponseCaching/languages","stargazers_url":"https://api.github.com/repos/aspnet/ResponseCaching/stargazers","contributors_url":"https://api.github.com/repos/aspnet/ResponseCaching/contributors","subscribers_url":"https://api.github.com/repos/aspnet/ResponseCaching/subscribers","subscription_url":"https://api.github.com/repos/aspnet/ResponseCaching/subscription","commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/ResponseCaching/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/ResponseCaching/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/ResponseCaching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/ResponseCaching/merges","archive_url":"https://api.github.com/repos/aspnet/ResponseCaching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/ResponseCaching/downloads","issues_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/ResponseCaching/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/ResponseCaching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/ResponseCaching/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/ResponseCaching/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/ResponseCaching/deployments","created_at":"2015-05-15T16:55:52Z","updated_at":"2016-09-19T08:26:45Z","pushed_at":"2016-09-19T04:00:08Z","git_url":"git://github.com/aspnet/ResponseCaching.git","ssh_url":"git@github.com:aspnet/ResponseCaching.git","clone_url":"https://github.com/aspnet/ResponseCaching.git","svn_url":"https://github.com/aspnet/ResponseCaching","homepage":"","size":217,"stargazers_count":18,"watchers_count":18,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":16,"forks":8,"open_issues":16,"watchers":18,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/47"},"html":{"href":"https://github.com/aspnet/ResponseCaching/pull/47"},"issue":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/issues/47"},"comments":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/statuses/bfdf6d2e3d6679e6c2333c7c0bdaa7a2b2cc789b"}}}}
{"actor":{"display_login":"Tratcher"}}