{"action":"created","comment":{"url":"https://api.github.com/repos/librenms/librenms/pulls/comments/75779232","id":75779232,"diff_hunk":"@@ -0,0 +1,8 @@\n+<?php\n+\n+if (!$os || $os == \"hytera\") {\n+    if (preg_match(\"/^lwIP/\", $sysDescr)) {","path":"includes/discovery/os/hytera.inc.php","position":4,"original_position":4,"commit_id":"90b762c1a47ae0ba3d6703fb0c79ec0c9f27d841","original_commit_id":"90b762c1a47ae0ba3d6703fb0c79ec0c9f27d841","user":{"login":"murrant","id":39462,"avatar_url":"https://avatars.githubusercontent.com/u/39462?v=3","gravatar_id":"","url":"https://api.github.com/users/murrant","html_url":"https://github.com/murrant","followers_url":"https://api.github.com/users/murrant/followers","following_url":"https://api.github.com/users/murrant/following{/other_user}","gists_url":"https://api.github.com/users/murrant/gists{/gist_id}","starred_url":"https://api.github.com/users/murrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrant/subscriptions","organizations_url":"https://api.github.com/users/murrant/orgs","repos_url":"https://api.github.com/users/murrant/repos","events_url":"https://api.github.com/users/murrant/events{/privacy}","received_events_url":"https://api.github.com/users/murrant/received_events","type":"User","site_admin":false},"body":"Yeah, this preg_match seems to generic and could have false positives.","created_at":"2016-08-22T23:34:43Z","updated_at":"2016-08-22T23:34:43Z","html_url":"https://github.com/librenms/librenms/pull/4163#discussion_r75779232","pull_request_url":"https://api.github.com/repos/librenms/librenms/pulls/4163","_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments/75779232"},"html":{"href":"https://github.com/librenms/librenms/pull/4163#discussion_r75779232"},"pull_request":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4163"}}},"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/4163","id":82160695,"html_url":"https://github.com/librenms/librenms/pull/4163","diff_url":"https://github.com/librenms/librenms/pull/4163.diff","patch_url":"https://github.com/librenms/librenms/pull/4163.patch","issue_url":"https://api.github.com/repos/librenms/librenms/issues/4163","number":4163,"state":"open","locked":false,"title":"Hytera repeater support","user":{"login":"zarya","id":387694,"avatar_url":"https://avatars.githubusercontent.com/u/387694?v=3","gravatar_id":"","url":"https://api.github.com/users/zarya","html_url":"https://github.com/zarya","followers_url":"https://api.github.com/users/zarya/followers","following_url":"https://api.github.com/users/zarya/following{/other_user}","gists_url":"https://api.github.com/users/zarya/gists{/gist_id}","starred_url":"https://api.github.com/users/zarya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarya/subscriptions","organizations_url":"https://api.github.com/users/zarya/orgs","repos_url":"https://api.github.com/users/zarya/repos","events_url":"https://api.github.com/users/zarya/events{/privacy}","received_events_url":"https://api.github.com/users/zarya/received_events","type":"User","site_admin":false},"body":"Support for the Hytera DMR repeaters\r\n\r\n","created_at":"2016-08-22T09:40:14Z","updated_at":"2016-08-22T23:34:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bd2e57b448314b9d2b66d276006cf1335882b57","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/librenms/librenms/pulls/4163/commits","review_comments_url":"https://api.github.com/repos/librenms/librenms/pulls/4163/comments","review_comment_url":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/4163/comments","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/90b762c1a47ae0ba3d6703fb0c79ec0c9f27d841","head":{"label":"zarya:hytera_new","ref":"hytera_new","sha":"90b762c1a47ae0ba3d6703fb0c79ec0c9f27d841","user":{"login":"zarya","id":387694,"avatar_url":"https://avatars.githubusercontent.com/u/387694?v=3","gravatar_id":"","url":"https://api.github.com/users/zarya","html_url":"https://github.com/zarya","followers_url":"https://api.github.com/users/zarya/followers","following_url":"https://api.github.com/users/zarya/following{/other_user}","gists_url":"https://api.github.com/users/zarya/gists{/gist_id}","starred_url":"https://api.github.com/users/zarya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarya/subscriptions","organizations_url":"https://api.github.com/users/zarya/orgs","repos_url":"https://api.github.com/users/zarya/repos","events_url":"https://api.github.com/users/zarya/events{/privacy}","received_events_url":"https://api.github.com/users/zarya/received_events","type":"User","site_admin":false},"repo":{"id":66256844,"name":"librenms","full_name":"zarya/librenms","owner":{"login":"zarya","id":387694,"avatar_url":"https://avatars.githubusercontent.com/u/387694?v=3","gravatar_id":"","url":"https://api.github.com/users/zarya","html_url":"https://github.com/zarya","followers_url":"https://api.github.com/users/zarya/followers","following_url":"https://api.github.com/users/zarya/following{/other_user}","gists_url":"https://api.github.com/users/zarya/gists{/gist_id}","starred_url":"https://api.github.com/users/zarya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarya/subscriptions","organizations_url":"https://api.github.com/users/zarya/orgs","repos_url":"https://api.github.com/users/zarya/repos","events_url":"https://api.github.com/users/zarya/events{/privacy}","received_events_url":"https://api.github.com/users/zarya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zarya/librenms","description":"Community-based GPL-licensed network monitoring system","fork":true,"url":"https://api.github.com/repos/zarya/librenms","forks_url":"https://api.github.com/repos/zarya/librenms/forks","keys_url":"https://api.github.com/repos/zarya/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zarya/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zarya/librenms/teams","hooks_url":"https://api.github.com/repos/zarya/librenms/hooks","issue_events_url":"https://api.github.com/repos/zarya/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/zarya/librenms/events","assignees_url":"https://api.github.com/repos/zarya/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/zarya/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/zarya/librenms/tags","blobs_url":"https://api.github.com/repos/zarya/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zarya/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zarya/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/zarya/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zarya/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/zarya/librenms/languages","stargazers_url":"https://api.github.com/repos/zarya/librenms/stargazers","contributors_url":"https://api.github.com/repos/zarya/librenms/contributors","subscribers_url":"https://api.github.com/repos/zarya/librenms/subscribers","subscription_url":"https://api.github.com/repos/zarya/librenms/subscription","commits_url":"https://api.github.com/repos/zarya/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/zarya/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/zarya/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/zarya/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/zarya/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/zarya/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zarya/librenms/merges","archive_url":"https://api.github.com/repos/zarya/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zarya/librenms/downloads","issues_url":"https://api.github.com/repos/zarya/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/zarya/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/zarya/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/zarya/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zarya/librenms/labels{/name}","releases_url":"https://api.github.com/repos/zarya/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/zarya/librenms/deployments","created_at":"2016-08-22T09:07:16Z","updated_at":"2016-08-22T09:08:02Z","pushed_at":"2016-08-22T21:36:34Z","git_url":"git://github.com/zarya/librenms.git","ssh_url":"git@github.com:zarya/librenms.git","clone_url":"https://github.com/zarya/librenms.git","svn_url":"https://github.com/zarya/librenms","homepage":"http://www.librenms.org/","size":73230,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librenms:master","ref":"master","sha":"9b3fbfbb5ef7038a49b1d4f237f6699663e9a67d","user":{"login":"librenms","id":5791783,"avatar_url":"https://avatars.githubusercontent.com/u/5791783?v=3","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"repo":{"id":13914116,"name":"librenms","full_name":"librenms/librenms","owner":{"login":"librenms","id":5791783,"avatar_url":"https://avatars.githubusercontent.com/u/5791783?v=3","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librenms/librenms","description":"Community-based GPL-licensed network monitoring system","fork":false,"url":"https://api.github.com/repos/librenms/librenms","forks_url":"https://api.github.com/repos/librenms/librenms/forks","keys_url":"https://api.github.com/repos/librenms/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librenms/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librenms/librenms/teams","hooks_url":"https://api.github.com/repos/librenms/librenms/hooks","issue_events_url":"https://api.github.com/repos/librenms/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/librenms/librenms/events","assignees_url":"https://api.github.com/repos/librenms/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/librenms/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/librenms/librenms/tags","blobs_url":"https://api.github.com/repos/librenms/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librenms/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librenms/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/librenms/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/librenms/librenms/languages","stargazers_url":"https://api.github.com/repos/librenms/librenms/stargazers","contributors_url":"https://api.github.com/repos/librenms/librenms/contributors","subscribers_url":"https://api.github.com/repos/librenms/librenms/subscribers","subscription_url":"https://api.github.com/repos/librenms/librenms/subscription","commits_url":"https://api.github.com/repos/librenms/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/librenms/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/librenms/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/librenms/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/librenms/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/librenms/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librenms/librenms/merges","archive_url":"https://api.github.com/repos/librenms/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librenms/librenms/downloads","issues_url":"https://api.github.com/repos/librenms/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/librenms/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/librenms/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/librenms/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librenms/librenms/labels{/name}","releases_url":"https://api.github.com/repos/librenms/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/librenms/librenms/deployments","created_at":"2013-10-28T01:37:13Z","updated_at":"2016-08-22T21:51:21Z","pushed_at":"2016-08-22T23:00:02Z","git_url":"git://github.com/librenms/librenms.git","ssh_url":"git@github.com:librenms/librenms.git","clone_url":"https://github.com/librenms/librenms.git","svn_url":"https://github.com/librenms/librenms","homepage":"http://www.librenms.org/","size":101735,"stargazers_count":478,"watchers_count":478,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":307,"mirror_url":null,"open_issues_count":313,"forks":307,"open_issues":313,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4163"},"html":{"href":"https://github.com/librenms/librenms/pull/4163"},"issue":{"href":"https://api.github.com/repos/librenms/librenms/issues/4163"},"comments":{"href":"https://api.github.com/repos/librenms/librenms/issues/4163/comments"},"review_comments":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4163/comments"},"review_comment":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4163/commits"},"statuses":{"href":"https://api.github.com/repos/librenms/librenms/statuses/90b762c1a47ae0ba3d6703fb0c79ec0c9f27d841"}}}}
{"actor":{"display_login":"murrant"}}