{"action":"created","comment":{"url":"https://api.github.com/repos/Moya/Moya/pulls/comments/79320653","id":79320653,"diff_hunk":"@@ -228,48 +228,48 @@ class MoyaProviderIntegrationTests: QuickSpec {\n                 }\n             }\n             \n-            describe(\"a reactive provider with SignalProducer\") {\n-                var provider: ReactiveCocoaMoyaProvider<GitHub>!\n-                beforeEach {\n-                    provider = ReactiveCocoaMoyaProvider<GitHub>()\n-                }\n-                \n-                it(\"returns some data for zen request\") {\n-                    var message: String?\n-\n-                    waitUntil { done in\n-                        provider.request(.Zen).startWithNext { response in\n-                            message = NSString(data: response.data, encoding: NSUTF8StringEncoding) as? String\n-                            done()\n-                        }\n-                    }\n-                    \n-                    expect(message) == zenMessage\n-                }\n-                \n-                it(\"returns some data for user profile request\") {\n-                    var message: String?\n-\n-                    waitUntil { done in\n-                        let target: GitHub = .UserProfile(\"ashfurrow\")\n-                        provider.request(target).startWithNext { response in\n-                            message = NSString(data: response.data, encoding: NSUTF8StringEncoding) as? String\n-                            done()\n-                        }\n-                    }\n-                    \n-                    expect(message) == userMessage\n-                }\n-            }\n+//            describe(\"a reactive provider with SignalProducer\") {\n+//                var provider: ReactiveCocoaMoyaProvider<GitHub>!\n+//                beforeEach {\n+//                    provider = ReactiveCocoaMoyaProvider<GitHub>()\n+//                }\n+//                \n+//                it(\"returns some data for zen request\") {\n+//                    var message: String?\n+//\n+//                    waitUntil { done in\n+//                        provider.request(.Zen).startWithNext { response in\n+//                            message = NSString(data: response.data, encoding: NSUTF8StringEncoding) as? String\n+//                            done()\n+//                        }\n+//                    }\n+//                    \n+//                    expect(message) == zenMessage\n+//                }\n+//                \n+//                it(\"returns some data for user profile request\") {\n+//                    var message: String?\n+//\n+//                    waitUntil { done in\n+//                        let target: GitHub = .UserProfile(\"ashfurrow\")\n+//                        provider.request(target).startWithNext { response in\n+//                            message = NSString(data: response.data, encoding: NSUTF8StringEncoding) as? String\n+//                            done()\n+//                        }\n+//                    }\n+//                    \n+//                    expect(message) == userMessage\n+//                }\n+//            }","path":"Demo/Tests/MoyaProviderIntegrationTests.swift","position":261,"original_position":261,"commit_id":"331b6eac74614e2e5cc5e608a39c5fd7e0587100","original_commit_id":"331b6eac74614e2e5cc5e608a39c5fd7e0587100","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"body":"Oops, missed these when I re-added the ReactiveCocoa tests. ","created_at":"2016-09-19T01:27:13Z","updated_at":"2016-09-19T01:27:28Z","html_url":"https://github.com/Moya/Moya/pull/608#discussion_r79320653","pull_request_url":"https://api.github.com/repos/Moya/Moya/pulls/608","_links":{"self":{"href":"https://api.github.com/repos/Moya/Moya/pulls/comments/79320653"},"html":{"href":"https://github.com/Moya/Moya/pull/608#discussion_r79320653"},"pull_request":{"href":"https://api.github.com/repos/Moya/Moya/pulls/608"}}},"pull_request":{"url":"https://api.github.com/repos/Moya/Moya/pulls/608","id":84494852,"html_url":"https://github.com/Moya/Moya/pull/608","diff_url":"https://github.com/Moya/Moya/pull/608.diff","patch_url":"https://github.com/Moya/Moya/pull/608.patch","issue_url":"https://api.github.com/repos/Moya/Moya/issues/608","number":608,"state":"open","locked":false,"title":"[WIP][Swift 3.0] Update for Xcode GM Seed.","user":{"login":"sunshinejr","id":5232779,"avatar_url":"https://avatars.githubusercontent.com/u/5232779?v=3","gravatar_id":"","url":"https://api.github.com/users/sunshinejr","html_url":"https://github.com/sunshinejr","followers_url":"https://api.github.com/users/sunshinejr/followers","following_url":"https://api.github.com/users/sunshinejr/following{/other_user}","gists_url":"https://api.github.com/users/sunshinejr/gists{/gist_id}","starred_url":"https://api.github.com/users/sunshinejr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunshinejr/subscriptions","organizations_url":"https://api.github.com/users/sunshinejr/orgs","repos_url":"https://api.github.com/users/sunshinejr/repos","events_url":"https://api.github.com/users/sunshinejr/events{/privacy}","received_events_url":"https://api.github.com/users/sunshinejr/received_events","type":"User","site_admin":false},"body":"Hey guys! 🎉  I tried to update Moya to the latest Swift 3.0 shipped with Xcode GM Seed. As there is work that still needs to be done, I would use some help with:\r\n\r\n- [x] `sendAlamofireRequest` method in [Moya+Internal](https://github.com/Moya/Moya/blob/swift-3.0/Source/Moya%2BInternal.swift#L187-L221). (@sunshinejr, PR: #613)\r\n- [x] [NetworkLoggerPlugin](https://github.com/Moya/Moya/blob/swift-3.0/Source/Plugins/NetworkLoggerPlugin.swift). (@AndrewSB, PR: https://github.com/Moya/Moya/pull/612)\r\n- [x] [ReactiveCocoa extensions with Tests](https://github.com/Moya/Moya/tree/swift-3.0/Source/ReactiveCocoa). (@ashfurrow, PR: #647)\r\n- [x] [Tests](https://github.com/Moya/Moya/tree/swift-3.0/Demo/Tests). (@sunshinejr, PR: #625)\r\n- [ ] Continuous Integration.\r\n- [ ] Any other things you may find.\r\n\r\nI think together we can make it better 👊Cheers! ","created_at":"2016-09-08T15:01:39Z","updated_at":"2016-09-19T01:27:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df218da07e2ff3658e6c447b5a4d58d287a4dbe1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Moya/Moya/pulls/608/commits","review_comments_url":"https://api.github.com/repos/Moya/Moya/pulls/608/comments","review_comment_url":"https://api.github.com/repos/Moya/Moya/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Moya/Moya/issues/608/comments","statuses_url":"https://api.github.com/repos/Moya/Moya/statuses/331b6eac74614e2e5cc5e608a39c5fd7e0587100","head":{"label":"Moya:swift-3.0","ref":"swift-3.0","sha":"331b6eac74614e2e5cc5e608a39c5fd7e0587100","user":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"repo":{"id":23013268,"name":"Moya","full_name":"Moya/Moya","owner":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Moya/Moya","description":"Network abstraction layer written in Swift.","fork":false,"url":"https://api.github.com/repos/Moya/Moya","forks_url":"https://api.github.com/repos/Moya/Moya/forks","keys_url":"https://api.github.com/repos/Moya/Moya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Moya/Moya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Moya/Moya/teams","hooks_url":"https://api.github.com/repos/Moya/Moya/hooks","issue_events_url":"https://api.github.com/repos/Moya/Moya/issues/events{/number}","events_url":"https://api.github.com/repos/Moya/Moya/events","assignees_url":"https://api.github.com/repos/Moya/Moya/assignees{/user}","branches_url":"https://api.github.com/repos/Moya/Moya/branches{/branch}","tags_url":"https://api.github.com/repos/Moya/Moya/tags","blobs_url":"https://api.github.com/repos/Moya/Moya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Moya/Moya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Moya/Moya/git/refs{/sha}","trees_url":"https://api.github.com/repos/Moya/Moya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Moya/Moya/statuses/{sha}","languages_url":"https://api.github.com/repos/Moya/Moya/languages","stargazers_url":"https://api.github.com/repos/Moya/Moya/stargazers","contributors_url":"https://api.github.com/repos/Moya/Moya/contributors","subscribers_url":"https://api.github.com/repos/Moya/Moya/subscribers","subscription_url":"https://api.github.com/repos/Moya/Moya/subscription","commits_url":"https://api.github.com/repos/Moya/Moya/commits{/sha}","git_commits_url":"https://api.github.com/repos/Moya/Moya/git/commits{/sha}","comments_url":"https://api.github.com/repos/Moya/Moya/comments{/number}","issue_comment_url":"https://api.github.com/repos/Moya/Moya/issues/comments{/number}","contents_url":"https://api.github.com/repos/Moya/Moya/contents/{+path}","compare_url":"https://api.github.com/repos/Moya/Moya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Moya/Moya/merges","archive_url":"https://api.github.com/repos/Moya/Moya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Moya/Moya/downloads","issues_url":"https://api.github.com/repos/Moya/Moya/issues{/number}","pulls_url":"https://api.github.com/repos/Moya/Moya/pulls{/number}","milestones_url":"https://api.github.com/repos/Moya/Moya/milestones{/number}","notifications_url":"https://api.github.com/repos/Moya/Moya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Moya/Moya/labels{/name}","releases_url":"https://api.github.com/repos/Moya/Moya/releases{/id}","deployments_url":"https://api.github.com/repos/Moya/Moya/deployments","created_at":"2014-08-16T07:41:21Z","updated_at":"2016-09-18T23:23:00Z","pushed_at":"2016-09-19T01:14:43Z","git_url":"git://github.com/Moya/Moya.git","ssh_url":"git@github.com:Moya/Moya.git","clone_url":"https://github.com/Moya/Moya.git","svn_url":"https://github.com/Moya/Moya","homepage":"","size":17080,"stargazers_count":3607,"watchers_count":3607,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":374,"mirror_url":null,"open_issues_count":44,"forks":374,"open_issues":44,"watchers":3607,"default_branch":"master"}},"base":{"label":"Moya:master","ref":"master","sha":"6b9b08df8c03366e9a0a9a029cfc21b35c32bc64","user":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"repo":{"id":23013268,"name":"Moya","full_name":"Moya/Moya","owner":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Moya/Moya","description":"Network abstraction layer written in Swift.","fork":false,"url":"https://api.github.com/repos/Moya/Moya","forks_url":"https://api.github.com/repos/Moya/Moya/forks","keys_url":"https://api.github.com/repos/Moya/Moya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Moya/Moya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Moya/Moya/teams","hooks_url":"https://api.github.com/repos/Moya/Moya/hooks","issue_events_url":"https://api.github.com/repos/Moya/Moya/issues/events{/number}","events_url":"https://api.github.com/repos/Moya/Moya/events","assignees_url":"https://api.github.com/repos/Moya/Moya/assignees{/user}","branches_url":"https://api.github.com/repos/Moya/Moya/branches{/branch}","tags_url":"https://api.github.com/repos/Moya/Moya/tags","blobs_url":"https://api.github.com/repos/Moya/Moya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Moya/Moya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Moya/Moya/git/refs{/sha}","trees_url":"https://api.github.com/repos/Moya/Moya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Moya/Moya/statuses/{sha}","languages_url":"https://api.github.com/repos/Moya/Moya/languages","stargazers_url":"https://api.github.com/repos/Moya/Moya/stargazers","contributors_url":"https://api.github.com/repos/Moya/Moya/contributors","subscribers_url":"https://api.github.com/repos/Moya/Moya/subscribers","subscription_url":"https://api.github.com/repos/Moya/Moya/subscription","commits_url":"https://api.github.com/repos/Moya/Moya/commits{/sha}","git_commits_url":"https://api.github.com/repos/Moya/Moya/git/commits{/sha}","comments_url":"https://api.github.com/repos/Moya/Moya/comments{/number}","issue_comment_url":"https://api.github.com/repos/Moya/Moya/issues/comments{/number}","contents_url":"https://api.github.com/repos/Moya/Moya/contents/{+path}","compare_url":"https://api.github.com/repos/Moya/Moya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Moya/Moya/merges","archive_url":"https://api.github.com/repos/Moya/Moya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Moya/Moya/downloads","issues_url":"https://api.github.com/repos/Moya/Moya/issues{/number}","pulls_url":"https://api.github.com/repos/Moya/Moya/pulls{/number}","milestones_url":"https://api.github.com/repos/Moya/Moya/milestones{/number}","notifications_url":"https://api.github.com/repos/Moya/Moya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Moya/Moya/labels{/name}","releases_url":"https://api.github.com/repos/Moya/Moya/releases{/id}","deployments_url":"https://api.github.com/repos/Moya/Moya/deployments","created_at":"2014-08-16T07:41:21Z","updated_at":"2016-09-18T23:23:00Z","pushed_at":"2016-09-19T01:14:43Z","git_url":"git://github.com/Moya/Moya.git","ssh_url":"git@github.com:Moya/Moya.git","clone_url":"https://github.com/Moya/Moya.git","svn_url":"https://github.com/Moya/Moya","homepage":"","size":17080,"stargazers_count":3607,"watchers_count":3607,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":374,"mirror_url":null,"open_issues_count":44,"forks":374,"open_issues":44,"watchers":3607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Moya/Moya/pulls/608"},"html":{"href":"https://github.com/Moya/Moya/pull/608"},"issue":{"href":"https://api.github.com/repos/Moya/Moya/issues/608"},"comments":{"href":"https://api.github.com/repos/Moya/Moya/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/Moya/Moya/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/Moya/Moya/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Moya/Moya/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/Moya/Moya/statuses/331b6eac74614e2e5cc5e608a39c5fd7e0587100"}}}}
{"actor":{"display_login":"ashfurrow"}}