{"action":"created","issue":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/474","repository_url":"https://api.github.com/repos/openpgpjs/openpgpjs","labels_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/474/labels{/name}","comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/474/comments","events_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/474/events","html_url":"https://github.com/openpgpjs/openpgpjs/pull/474","id":162170767,"number":474,"title":"Issue/449","user":{"login":"evilaliv3","id":217034,"avatar_url":"https://avatars.githubusercontent.com/u/217034?v=3","gravatar_id":"","url":"https://api.github.com/users/evilaliv3","html_url":"https://github.com/evilaliv3","followers_url":"https://api.github.com/users/evilaliv3/followers","following_url":"https://api.github.com/users/evilaliv3/following{/other_user}","gists_url":"https://api.github.com/users/evilaliv3/gists{/gist_id}","starred_url":"https://api.github.com/users/evilaliv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilaliv3/subscriptions","organizations_url":"https://api.github.com/users/evilaliv3/orgs","repos_url":"https://api.github.com/users/evilaliv3/repos","events_url":"https://api.github.com/users/evilaliv3/events{/privacy}","received_events_url":"https://api.github.com/users/evilaliv3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-24T15:23:28Z","updated_at":"2016-06-26T00:07:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/474","html_url":"https://github.com/openpgpjs/openpgpjs/pull/474","diff_url":"https://github.com/openpgpjs/openpgpjs/pull/474.diff","patch_url":"https://github.com/openpgpjs/openpgpjs/pull/474.patch"},"body":"This pull request implement the possibility to use the combination of both the web workers + the webcrypto by making possible to enable one or the other capability independently.\r\n\r\nthe only browser that would not benefit of this is internet explorer that is not able to use the webcrypto api from inside the web worker; for this browser only the webworker will be used making the library less fast but more resilient to \"this script is running for to long and i want to fucking kill it; can i?\" messages.\r\n\r\nthe pull implement also the additional test for when both the capabilities are enabled.\r\n\r\n@tanx could you please review it and suggest eventual feedbacks?\r\n\r\nfrom a more bigger analysis the improvent impacts not only the key generation but also the encryption/decryption routines where the ascii armor is used as because this functions also are currently runned in the main thread when the webcrypto is used.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/comments/228576827","html_url":"https://github.com/openpgpjs/openpgpjs/pull/474#issuecomment-228576827","issue_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/474","id":228576827,"user":{"login":"evilaliv3","id":217034,"avatar_url":"https://avatars.githubusercontent.com/u/217034?v=3","gravatar_id":"","url":"https://api.github.com/users/evilaliv3","html_url":"https://github.com/evilaliv3","followers_url":"https://api.github.com/users/evilaliv3/followers","following_url":"https://api.github.com/users/evilaliv3/following{/other_user}","gists_url":"https://api.github.com/users/evilaliv3/gists{/gist_id}","starred_url":"https://api.github.com/users/evilaliv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilaliv3/subscriptions","organizations_url":"https://api.github.com/users/evilaliv3/orgs","repos_url":"https://api.github.com/users/evilaliv3/repos","events_url":"https://api.github.com/users/evilaliv3/events{/privacy}","received_events_url":"https://api.github.com/users/evilaliv3/received_events","type":"User","site_admin":false},"created_at":"2016-06-26T00:07:37Z","updated_at":"2016-06-26T00:07:37Z","body":"@tanx: from my side the patch is ready;\r\n\r\n- i've removed the commit raising the timeout limit.\r\n- ive implemented a getGlobal utility where to wrap also 'global' that is defined in Node in place of self;\r\n- i've enabled zero_copy that in my tests seems to work and do not break the build process anymore."}}
{"actor":{"display_login":"evilaliv3"}}