{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/74517810","id":74517810,"diff_hunk":"@@ -95,7 +95,7 @@ def _align_core(terms):\n                 term_axis_size = len(ti.axes[axis])\n                 reindexer_size = len(reindexer)\n \n-                ordm = np.log10(abs(reindexer_size - term_axis_size))\n+                ordm = np.log10(max(1, abs(reindexer_size - term_axis_size)))","path":"pandas/computation/align.py","position":5,"original_position":5,"commit_id":"5ddae9af396c9af52d2d5ddbe916a4e173f9b52d","original_commit_id":"5ddae9af396c9af52d2d5ddbe916a4e173f9b52d","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"this is the fix for #13135 ?","created_at":"2016-08-11T22:47:38Z","updated_at":"2016-08-11T22:47:38Z","html_url":"https://github.com/pydata/pandas/pull/13145#discussion_r74517810","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/13145","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/74517810"},"html":{"href":"https://github.com/pydata/pandas/pull/13145#discussion_r74517810"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13145"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/13145","id":69740856,"html_url":"https://github.com/pydata/pandas/pull/13145","diff_url":"https://github.com/pydata/pandas/pull/13145.diff","patch_url":"https://github.com/pydata/pandas/pull/13145.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/13145","number":13145,"state":"open","locked":false,"title":"Fine-grained errstate handling","user":{"login":"rkern","id":46135,"avatar_url":"https://avatars.githubusercontent.com/u/46135?v=3","gravatar_id":"","url":"https://api.github.com/users/rkern","html_url":"https://github.com/rkern","followers_url":"https://api.github.com/users/rkern/followers","following_url":"https://api.github.com/users/rkern/following{/other_user}","gists_url":"https://api.github.com/users/rkern/gists{/gist_id}","starred_url":"https://api.github.com/users/rkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkern/subscriptions","organizations_url":"https://api.github.com/users/rkern/orgs","repos_url":"https://api.github.com/users/rkern/repos","events_url":"https://api.github.com/users/rkern/events{/privacy}","received_events_url":"https://api.github.com/users/rkern/received_events","type":"User","site_admin":false},"body":" - [x] closes #13109 \r\n - [ ] maybe closes #13135\r\n - [x] tests passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n - [x] whatsnew entry\r\n\r\nThe precise strategy to be taken here is open for discussion. I tried to be reasonably fine-grained rather than slap a generic decorator over everything because it's easier to go that direction than the reverse. The `errstate()` blocks in the tests were added *after* fixing all of the library code. Unfortunately, these are less fine-grained than I would like because some of the tests have many lines of the form `assert_array_equal(pandas_expression_to_test, expected_raw_numpy_expression)` where `expected_raw_numpy_expression` is what is triggering the warning. It was tedious to try to rewrite all of that to wrap just `expected_raw_numpy_expression`.\r\n\r\nI think I got everything exercised by the test suite except for parts of the test suite that are skipped on my machine due to dependencies. We'll see how things go in the CI.\r\n\r\nI haven't added any new tests yet. Could do if requested.","created_at":"2016-05-11T20:55:37Z","updated_at":"2016-08-11T22:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7985f51c10aa07e4b29e7d0268da55771cbc365","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/13145/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/13145/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/13145/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/5ddae9af396c9af52d2d5ddbe916a4e173f9b52d","head":{"label":"rkern:fix/errstate","ref":"fix/errstate","sha":"5ddae9af396c9af52d2d5ddbe916a4e173f9b52d","user":{"login":"rkern","id":46135,"avatar_url":"https://avatars.githubusercontent.com/u/46135?v=3","gravatar_id":"","url":"https://api.github.com/users/rkern","html_url":"https://github.com/rkern","followers_url":"https://api.github.com/users/rkern/followers","following_url":"https://api.github.com/users/rkern/following{/other_user}","gists_url":"https://api.github.com/users/rkern/gists{/gist_id}","starred_url":"https://api.github.com/users/rkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkern/subscriptions","organizations_url":"https://api.github.com/users/rkern/orgs","repos_url":"https://api.github.com/users/rkern/repos","events_url":"https://api.github.com/users/rkern/events{/privacy}","received_events_url":"https://api.github.com/users/rkern/received_events","type":"User","site_admin":false},"repo":{"id":58577460,"name":"pandas","full_name":"rkern/pandas","owner":{"login":"rkern","id":46135,"avatar_url":"https://avatars.githubusercontent.com/u/46135?v=3","gravatar_id":"","url":"https://api.github.com/users/rkern","html_url":"https://github.com/rkern","followers_url":"https://api.github.com/users/rkern/followers","following_url":"https://api.github.com/users/rkern/following{/other_user}","gists_url":"https://api.github.com/users/rkern/gists{/gist_id}","starred_url":"https://api.github.com/users/rkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkern/subscriptions","organizations_url":"https://api.github.com/users/rkern/orgs","repos_url":"https://api.github.com/users/rkern/repos","events_url":"https://api.github.com/users/rkern/events{/privacy}","received_events_url":"https://api.github.com/users/rkern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rkern/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/rkern/pandas","forks_url":"https://api.github.com/repos/rkern/pandas/forks","keys_url":"https://api.github.com/repos/rkern/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rkern/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rkern/pandas/teams","hooks_url":"https://api.github.com/repos/rkern/pandas/hooks","issue_events_url":"https://api.github.com/repos/rkern/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/rkern/pandas/events","assignees_url":"https://api.github.com/repos/rkern/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/rkern/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/rkern/pandas/tags","blobs_url":"https://api.github.com/repos/rkern/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rkern/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rkern/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/rkern/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rkern/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/rkern/pandas/languages","stargazers_url":"https://api.github.com/repos/rkern/pandas/stargazers","contributors_url":"https://api.github.com/repos/rkern/pandas/contributors","subscribers_url":"https://api.github.com/repos/rkern/pandas/subscribers","subscription_url":"https://api.github.com/repos/rkern/pandas/subscription","commits_url":"https://api.github.com/repos/rkern/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/rkern/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/rkern/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/rkern/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/rkern/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/rkern/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rkern/pandas/merges","archive_url":"https://api.github.com/repos/rkern/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rkern/pandas/downloads","issues_url":"https://api.github.com/repos/rkern/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/rkern/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/rkern/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/rkern/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rkern/pandas/labels{/name}","releases_url":"https://api.github.com/repos/rkern/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/rkern/pandas/deployments","created_at":"2016-05-11T20:12:51Z","updated_at":"2016-05-11T20:12:57Z","pushed_at":"2016-08-11T19:36:08Z","git_url":"git://github.com/rkern/pandas.git","ssh_url":"git@github.com:rkern/pandas.git","clone_url":"https://github.com/rkern/pandas.git","svn_url":"https://github.com/rkern/pandas","homepage":"http://pandas.pydata.org","size":79703,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"4a805216d99b37955c97625d304980eff10cab56","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2016-08-11T10:49:03Z","pushed_at":"2016-08-11T22:25:03Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":150036,"stargazers_count":6819,"watchers_count":6819,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2814,"mirror_url":null,"open_issues_count":1827,"forks":2814,"open_issues":1827,"watchers":6819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13145"},"html":{"href":"https://github.com/pydata/pandas/pull/13145"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/13145"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/13145/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13145/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13145/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/5ddae9af396c9af52d2d5ddbe916a4e173f9b52d"}}}}
{"actor":{"display_login":"jreback"}}