{"action":"created","comment":{"url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/comments/61228362","id":61228362,"diff_hunk":"@@ -0,0 +1,15 @@\n+package com.devtechgroup.ems.business.logic.service;\n+\n+import com.devtechgroup.ems.business.logic.model.EmployeeDto;\n+\n+import java.util.List;\n+\n+public interface IEmployeeService {\n+\n+    EmployeeDto createEmployee(EmployeeDto employeeDto);\n+    EmployeeDto editEmployee(Long employee_id, EmployeeDto employee);","path":"ems-business-logic/src/main/java/com/devtechgroup/ems/business/logic/service/IEmployeeService.java","position":10,"original_position":10,"commit_id":"9e88f839132f4ad2aaa1a09c5dcc578eb9148222","original_commit_id":"9e88f839132f4ad2aaa1a09c5dcc578eb9148222","user":{"login":"aleksandar-borkovac-devtech","id":10340303,"avatar_url":"https://avatars.githubusercontent.com/u/10340303?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandar-borkovac-devtech","html_url":"https://github.com/aleksandar-borkovac-devtech","followers_url":"https://api.github.com/users/aleksandar-borkovac-devtech/followers","following_url":"https://api.github.com/users/aleksandar-borkovac-devtech/following{/other_user}","gists_url":"https://api.github.com/users/aleksandar-borkovac-devtech/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandar-borkovac-devtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandar-borkovac-devtech/subscriptions","organizations_url":"https://api.github.com/users/aleksandar-borkovac-devtech/orgs","repos_url":"https://api.github.com/users/aleksandar-borkovac-devtech/repos","events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/received_events","type":"User","site_admin":false},"body":"Use only camel case for variable. Please avoid naming your variables, methods with underscore (employe_id). Keep in mind it is OK for database column name to be with underscore.","created_at":"2016-04-27T09:28:22Z","updated_at":"2016-04-27T09:28:22Z","html_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems/pull/4#discussion_r61228362","pull_request_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/comments/61228362"},"html":{"href":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems/pull/4#discussion_r61228362"},"pull_request":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/4","id":67704336,"html_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems/pull/4","diff_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems/pull/4.diff","patch_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems/pull/4.patch","issue_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues/4","number":4,"state":"open","locked":false,"title":"Finished CRUD with ResponseEntity","user":{"login":"nebojsa-lalic-devtech","id":17617061,"avatar_url":"https://avatars.githubusercontent.com/u/17617061?v=3","gravatar_id":"","url":"https://api.github.com/users/nebojsa-lalic-devtech","html_url":"https://github.com/nebojsa-lalic-devtech","followers_url":"https://api.github.com/users/nebojsa-lalic-devtech/followers","following_url":"https://api.github.com/users/nebojsa-lalic-devtech/following{/other_user}","gists_url":"https://api.github.com/users/nebojsa-lalic-devtech/gists{/gist_id}","starred_url":"https://api.github.com/users/nebojsa-lalic-devtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebojsa-lalic-devtech/subscriptions","organizations_url":"https://api.github.com/users/nebojsa-lalic-devtech/orgs","repos_url":"https://api.github.com/users/nebojsa-lalic-devtech/repos","events_url":"https://api.github.com/users/nebojsa-lalic-devtech/events{/privacy}","received_events_url":"https://api.github.com/users/nebojsa-lalic-devtech/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-25T11:31:31Z","updated_at":"2016-04-27T09:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/4/commits","review_comments_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/4/comments","review_comment_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues/4/comments","statuses_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/statuses/9e88f839132f4ad2aaa1a09c5dcc578eb9148222","head":{"label":"aleksandar-borkovac-devtech:feature/Employee-CRUD","ref":"feature/Employee-CRUD","sha":"9e88f839132f4ad2aaa1a09c5dcc578eb9148222","user":{"login":"aleksandar-borkovac-devtech","id":10340303,"avatar_url":"https://avatars.githubusercontent.com/u/10340303?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandar-borkovac-devtech","html_url":"https://github.com/aleksandar-borkovac-devtech","followers_url":"https://api.github.com/users/aleksandar-borkovac-devtech/followers","following_url":"https://api.github.com/users/aleksandar-borkovac-devtech/following{/other_user}","gists_url":"https://api.github.com/users/aleksandar-borkovac-devtech/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandar-borkovac-devtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandar-borkovac-devtech/subscriptions","organizations_url":"https://api.github.com/users/aleksandar-borkovac-devtech/orgs","repos_url":"https://api.github.com/users/aleksandar-borkovac-devtech/repos","events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/received_events","type":"User","site_admin":false},"repo":{"id":54958270,"name":"multi-module-ems","full_name":"aleksandar-borkovac-devtech/multi-module-ems","owner":{"login":"aleksandar-borkovac-devtech","id":10340303,"avatar_url":"https://avatars.githubusercontent.com/u/10340303?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandar-borkovac-devtech","html_url":"https://github.com/aleksandar-borkovac-devtech","followers_url":"https://api.github.com/users/aleksandar-borkovac-devtech/followers","following_url":"https://api.github.com/users/aleksandar-borkovac-devtech/following{/other_user}","gists_url":"https://api.github.com/users/aleksandar-borkovac-devtech/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandar-borkovac-devtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandar-borkovac-devtech/subscriptions","organizations_url":"https://api.github.com/users/aleksandar-borkovac-devtech/orgs","repos_url":"https://api.github.com/users/aleksandar-borkovac-devtech/repos","events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems","description":"","fork":false,"url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems","forks_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/forks","keys_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/teams","hooks_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/hooks","issue_events_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues/events{/number}","events_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/events","assignees_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/assignees{/user}","branches_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/branches{/branch}","tags_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/tags","blobs_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/refs{/sha}","trees_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/statuses/{sha}","languages_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/languages","stargazers_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/stargazers","contributors_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/contributors","subscribers_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/subscribers","subscription_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/subscription","commits_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/commits{/sha}","git_commits_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/commits{/sha}","comments_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/comments{/number}","issue_comment_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues/comments{/number}","contents_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/contents/{+path}","compare_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/merges","archive_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/downloads","issues_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues{/number}","pulls_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls{/number}","milestones_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/milestones{/number}","notifications_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/labels{/name}","releases_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/releases{/id}","deployments_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/deployments","created_at":"2016-03-29T08:18:12Z","updated_at":"2016-04-18T07:03:36Z","pushed_at":"2016-04-25T11:31:31Z","git_url":"git://github.com/aleksandar-borkovac-devtech/multi-module-ems.git","ssh_url":"git@github.com:aleksandar-borkovac-devtech/multi-module-ems.git","clone_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems.git","svn_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"aleksandar-borkovac-devtech:develop","ref":"develop","sha":"e8312ada8bd5efacbc3173695e5c234b6e498a5b","user":{"login":"aleksandar-borkovac-devtech","id":10340303,"avatar_url":"https://avatars.githubusercontent.com/u/10340303?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandar-borkovac-devtech","html_url":"https://github.com/aleksandar-borkovac-devtech","followers_url":"https://api.github.com/users/aleksandar-borkovac-devtech/followers","following_url":"https://api.github.com/users/aleksandar-borkovac-devtech/following{/other_user}","gists_url":"https://api.github.com/users/aleksandar-borkovac-devtech/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandar-borkovac-devtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandar-borkovac-devtech/subscriptions","organizations_url":"https://api.github.com/users/aleksandar-borkovac-devtech/orgs","repos_url":"https://api.github.com/users/aleksandar-borkovac-devtech/repos","events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/received_events","type":"User","site_admin":false},"repo":{"id":54958270,"name":"multi-module-ems","full_name":"aleksandar-borkovac-devtech/multi-module-ems","owner":{"login":"aleksandar-borkovac-devtech","id":10340303,"avatar_url":"https://avatars.githubusercontent.com/u/10340303?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandar-borkovac-devtech","html_url":"https://github.com/aleksandar-borkovac-devtech","followers_url":"https://api.github.com/users/aleksandar-borkovac-devtech/followers","following_url":"https://api.github.com/users/aleksandar-borkovac-devtech/following{/other_user}","gists_url":"https://api.github.com/users/aleksandar-borkovac-devtech/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandar-borkovac-devtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandar-borkovac-devtech/subscriptions","organizations_url":"https://api.github.com/users/aleksandar-borkovac-devtech/orgs","repos_url":"https://api.github.com/users/aleksandar-borkovac-devtech/repos","events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandar-borkovac-devtech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems","description":"","fork":false,"url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems","forks_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/forks","keys_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/teams","hooks_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/hooks","issue_events_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues/events{/number}","events_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/events","assignees_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/assignees{/user}","branches_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/branches{/branch}","tags_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/tags","blobs_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/refs{/sha}","trees_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/statuses/{sha}","languages_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/languages","stargazers_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/stargazers","contributors_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/contributors","subscribers_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/subscribers","subscription_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/subscription","commits_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/commits{/sha}","git_commits_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/git/commits{/sha}","comments_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/comments{/number}","issue_comment_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues/comments{/number}","contents_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/contents/{+path}","compare_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/merges","archive_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/downloads","issues_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues{/number}","pulls_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls{/number}","milestones_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/milestones{/number}","notifications_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/labels{/name}","releases_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/releases{/id}","deployments_url":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/deployments","created_at":"2016-03-29T08:18:12Z","updated_at":"2016-04-18T07:03:36Z","pushed_at":"2016-04-25T11:31:31Z","git_url":"git://github.com/aleksandar-borkovac-devtech/multi-module-ems.git","ssh_url":"git@github.com:aleksandar-borkovac-devtech/multi-module-ems.git","clone_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems.git","svn_url":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/4"},"html":{"href":"https://github.com/aleksandar-borkovac-devtech/multi-module-ems/pull/4"},"issue":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues/4"},"comments":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/aleksandar-borkovac-devtech/multi-module-ems/statuses/9e88f839132f4ad2aaa1a09c5dcc578eb9148222"}}}}