{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio-js/pulls/comments/90882912","pull_request_review_id":11396368,"id":90882912,"diff_hunk":"@@ -477,7 +477,7 @@ minioClient.fGetObject('mybucket', 'photo.jpg', '/tmp/photo.jpg', function(err)\n \n ```\n <a name=\"putObject\"></a>\n-### putObject(bucketName, objectName, stream, size, contentType, callback)\n+### putObject(bucketName, objectName, stream, size, callback)","path":"docs/API.md","position":5,"original_position":5,"commit_id":"734a07118c0bf56128949040802cc91d670394f9","original_commit_id":"dd1bc89cbbc8f9563118b3cd660b1a280867d5f1","user":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"body":"Should I put it back in the documentation? Right now the parameter is still *supported*, it's just legacy optional — the new `ObjectUploader` doesn't require it. Or should I change something under the hood?","created_at":"2016-12-05T15:11:27Z","updated_at":"2016-12-05T15:11:27Z","html_url":"https://github.com/minio/minio-js/pull/494#discussion_r90882912","pull_request_url":"https://api.github.com/repos/minio/minio-js/pulls/494","_links":{"self":{"href":"https://api.github.com/repos/minio/minio-js/pulls/comments/90882912"},"html":{"href":"https://github.com/minio/minio-js/pull/494#discussion_r90882912"},"pull_request":{"href":"https://api.github.com/repos/minio/minio-js/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio-js/pulls/494","id":81200891,"html_url":"https://github.com/minio/minio-js/pull/494","diff_url":"https://github.com/minio/minio-js/pull/494.diff","patch_url":"https://github.com/minio/minio-js/pull/494.patch","issue_url":"https://api.github.com/repos/minio/minio-js/issues/494","number":494,"state":"open","locked":false,"title":"add new stream uploader","user":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"body":"This PR adds a new stream uploader, `.streamObject()`, which allows for easy uploading of a stream to s3.\n\nThis also ports `.fPutObject()` and `.putObject()` to use `.streamObject()` under the hood.\n\n**NOTE**: this contains a breaking change. Before this, uploading a stream of size 1GB (for example) but declaring it as 2GB would leave the multipart upload open on the server. This PR now makes it close the multipart upload once the stream ends. The tests have been updated/removed for that.\n","created_at":"2016-08-13T00:33:57Z","updated_at":"2016-12-05T15:11:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b223964aa246eb76fe9d87f3c2ed01648e47be5a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio-js/pulls/494/commits","review_comments_url":"https://api.github.com/repos/minio/minio-js/pulls/494/comments","review_comment_url":"https://api.github.com/repos/minio/minio-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio-js/issues/494/comments","statuses_url":"https://api.github.com/repos/minio/minio-js/statuses/734a07118c0bf56128949040802cc91d670394f9","head":{"label":"brendanashworth:new-stream-uploader","ref":"new-stream-uploader","sha":"734a07118c0bf56128949040802cc91d670394f9","user":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"repo":{"id":65051939,"name":"minio-js","full_name":"brendanashworth/minio-js","owner":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brendanashworth/minio-js","description":"Minio JavaScript Library for Amazon S3 compatible cloud storage","fork":true,"url":"https://api.github.com/repos/brendanashworth/minio-js","forks_url":"https://api.github.com/repos/brendanashworth/minio-js/forks","keys_url":"https://api.github.com/repos/brendanashworth/minio-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendanashworth/minio-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendanashworth/minio-js/teams","hooks_url":"https://api.github.com/repos/brendanashworth/minio-js/hooks","issue_events_url":"https://api.github.com/repos/brendanashworth/minio-js/issues/events{/number}","events_url":"https://api.github.com/repos/brendanashworth/minio-js/events","assignees_url":"https://api.github.com/repos/brendanashworth/minio-js/assignees{/user}","branches_url":"https://api.github.com/repos/brendanashworth/minio-js/branches{/branch}","tags_url":"https://api.github.com/repos/brendanashworth/minio-js/tags","blobs_url":"https://api.github.com/repos/brendanashworth/minio-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendanashworth/minio-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendanashworth/minio-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendanashworth/minio-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendanashworth/minio-js/statuses/{sha}","languages_url":"https://api.github.com/repos/brendanashworth/minio-js/languages","stargazers_url":"https://api.github.com/repos/brendanashworth/minio-js/stargazers","contributors_url":"https://api.github.com/repos/brendanashworth/minio-js/contributors","subscribers_url":"https://api.github.com/repos/brendanashworth/minio-js/subscribers","subscription_url":"https://api.github.com/repos/brendanashworth/minio-js/subscription","commits_url":"https://api.github.com/repos/brendanashworth/minio-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendanashworth/minio-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendanashworth/minio-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendanashworth/minio-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendanashworth/minio-js/contents/{+path}","compare_url":"https://api.github.com/repos/brendanashworth/minio-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendanashworth/minio-js/merges","archive_url":"https://api.github.com/repos/brendanashworth/minio-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendanashworth/minio-js/downloads","issues_url":"https://api.github.com/repos/brendanashworth/minio-js/issues{/number}","pulls_url":"https://api.github.com/repos/brendanashworth/minio-js/pulls{/number}","milestones_url":"https://api.github.com/repos/brendanashworth/minio-js/milestones{/number}","notifications_url":"https://api.github.com/repos/brendanashworth/minio-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendanashworth/minio-js/labels{/name}","releases_url":"https://api.github.com/repos/brendanashworth/minio-js/releases{/id}","deployments_url":"https://api.github.com/repos/brendanashworth/minio-js/deployments","created_at":"2016-08-05T22:05:50Z","updated_at":"2016-08-05T22:05:51Z","pushed_at":"2016-12-05T14:48:13Z","git_url":"git://github.com/brendanashworth/minio-js.git","ssh_url":"git@github.com:brendanashworth/minio-js.git","clone_url":"https://github.com/brendanashworth/minio-js.git","svn_url":"https://github.com/brendanashworth/minio-js","homepage":"http://minio.io/downloads/#minio-sdk","size":935,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"7e04da2454d71d91600e02c784ec984d701b3220","user":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":36050777,"name":"minio-js","full_name":"minio/minio-js","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio-js","description":"Minio JavaScript Library for Amazon S3 compatible cloud storage","fork":false,"url":"https://api.github.com/repos/minio/minio-js","forks_url":"https://api.github.com/repos/minio/minio-js/forks","keys_url":"https://api.github.com/repos/minio/minio-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio-js/teams","hooks_url":"https://api.github.com/repos/minio/minio-js/hooks","issue_events_url":"https://api.github.com/repos/minio/minio-js/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio-js/events","assignees_url":"https://api.github.com/repos/minio/minio-js/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio-js/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio-js/tags","blobs_url":"https://api.github.com/repos/minio/minio-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio-js/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio-js/languages","stargazers_url":"https://api.github.com/repos/minio/minio-js/stargazers","contributors_url":"https://api.github.com/repos/minio/minio-js/contributors","subscribers_url":"https://api.github.com/repos/minio/minio-js/subscribers","subscription_url":"https://api.github.com/repos/minio/minio-js/subscription","commits_url":"https://api.github.com/repos/minio/minio-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio-js/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio-js/merges","archive_url":"https://api.github.com/repos/minio/minio-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio-js/downloads","issues_url":"https://api.github.com/repos/minio/minio-js/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio-js/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio-js/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio-js/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio-js/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio-js/deployments","created_at":"2015-05-22T03:42:19Z","updated_at":"2016-11-22T03:48:12Z","pushed_at":"2016-12-05T14:48:14Z","git_url":"git://github.com/minio/minio-js.git","ssh_url":"git@github.com:minio/minio-js.git","clone_url":"https://github.com/minio/minio-js.git","svn_url":"https://github.com/minio/minio-js","homepage":"http://minio.io/downloads/#minio-sdk","size":1037,"stargazers_count":57,"watchers_count":57,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":9,"forks":27,"open_issues":9,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio-js/pulls/494"},"html":{"href":"https://github.com/minio/minio-js/pull/494"},"issue":{"href":"https://api.github.com/repos/minio/minio-js/issues/494"},"comments":{"href":"https://api.github.com/repos/minio/minio-js/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio-js/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio-js/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio-js/statuses/734a07118c0bf56128949040802cc91d670394f9"}}}}
{"actor":{"display_login":"brendanashworth"}}