{"action":"created","comment":{"url":"https://api.github.com/repos/ethpm/epm-spec/pulls/comments/92904193","pull_request_review_id":13430006,"id":92904193,"diff_hunk":"@@ -90,117 +212,377 @@ Sources are declared in a key/value mapping.\n * Type: Object (String: String)\n \n \n-### Contracts: `contracts`\n+### Contract Types: `contract_types`\n \n-The `contracts` field declares information about the deployed contracts\n-included within this release.\n+The `contract_types` field holds information about *contract types* which\n+have been included in this release lockfile.  Release lockfiles **may not**\n+include any *contract types* which are not present in the project's source\n+code.","path":"release-lock-file-spec.md","position":250,"original_position":250,"commit_id":"1e6036f52bbc383109228f51c09e009191c3bef4","original_commit_id":"7d9e247d7b5d6d0133a1a17d418841f7ff74b78e","user":{"login":"pipermerriam","id":824194,"avatar_url":"https://avatars.githubusercontent.com/u/824194?v=3","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"body":"I rewrote this to hopefully be less cryptic.  Will you let me know if the revised version makes more sense.","created_at":"2016-12-16T23:37:40Z","updated_at":"2016-12-16T23:37:40Z","html_url":"https://github.com/ethpm/epm-spec/pull/41#discussion_r92904193","pull_request_url":"https://api.github.com/repos/ethpm/epm-spec/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/ethpm/epm-spec/pulls/comments/92904193"},"html":{"href":"https://github.com/ethpm/epm-spec/pull/41#discussion_r92904193"},"pull_request":{"href":"https://api.github.com/repos/ethpm/epm-spec/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/ethpm/epm-spec/pulls/41","id":98254071,"html_url":"https://github.com/ethpm/epm-spec/pull/41","diff_url":"https://github.com/ethpm/epm-spec/pull/41.diff","patch_url":"https://github.com/ethpm/epm-spec/pull/41.patch","issue_url":"https://api.github.com/repos/ethpm/epm-spec/issues/41","number":41,"state":"open","locked":false,"title":"Lots and lots of things","user":{"login":"pipermerriam","id":824194,"avatar_url":"https://avatars.githubusercontent.com/u/824194?v=3","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"body":"What does this do?\r\n\r\n* Adds RFC2119 definition for the various RFC style keywords like MUST and SHOULD\r\n* Convert to the naming scheme \"lockfile\" instead of \"lock file\"\r\n* Define a number of other terms which are used throughout the spec document.\r\n* Setup terminology for talking about contracts, their *types*, and their deployed instances.\r\n* Modified convention for the filename to match what is going on in populus and truffle.\r\n* Fix the `lockfile_version` type.\r\n* Removed `package_manifest` field\r\n* Added new fields so that all data that is in the Package Manifest can be included in the Release Lockfile.\r\n* Removed the *Contract Instance Object* concept.\r\n* Added the `contract_types` and `deployments` which better represents the data that was previously in the *Contract Instance Object* (See #40 )\r\n* Resolved `build_dependencies` key discrepancy.\r\n* Changed the format that `link_dependencies` are declared.\r\n\r\nThis is a *bunch* of stuff.  Anything controversial can get split out into it's own separate PR.  I know everyone is busy but please review as soon as possible.\r\n\r\n#### Obligatory Cute Animal Picture\r\n\r\n![baby-cute-puppy-corgi](https://cloud.githubusercontent.com/assets/824194/21272879/387d9422-c37e-11e6-9ead-8d31649d93db.jpeg)\r\n\r\n","created_at":"2016-12-15T23:47:30Z","updated_at":"2016-12-16T23:37:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aef8d5dc09233d115803d696ff7aa47169ea0f75","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethpm/epm-spec/pulls/41/commits","review_comments_url":"https://api.github.com/repos/ethpm/epm-spec/pulls/41/comments","review_comment_url":"https://api.github.com/repos/ethpm/epm-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethpm/epm-spec/issues/41/comments","statuses_url":"https://api.github.com/repos/ethpm/epm-spec/statuses/1e6036f52bbc383109228f51c09e009191c3bef4","head":{"label":"pipermerriam:piper/rethinking-linkage-between-manifest-and-release-lockfile","ref":"piper/rethinking-linkage-between-manifest-and-release-lockfile","sha":"1e6036f52bbc383109228f51c09e009191c3bef4","user":{"login":"pipermerriam","id":824194,"avatar_url":"https://avatars.githubusercontent.com/u/824194?v=3","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"repo":{"id":69987086,"name":"epm-spec","full_name":"pipermerriam/epm-spec","owner":{"login":"pipermerriam","id":824194,"avatar_url":"https://avatars.githubusercontent.com/u/824194?v=3","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pipermerriam/epm-spec","description":"Ethereum Package Manager","fork":true,"url":"https://api.github.com/repos/pipermerriam/epm-spec","forks_url":"https://api.github.com/repos/pipermerriam/epm-spec/forks","keys_url":"https://api.github.com/repos/pipermerriam/epm-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pipermerriam/epm-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pipermerriam/epm-spec/teams","hooks_url":"https://api.github.com/repos/pipermerriam/epm-spec/hooks","issue_events_url":"https://api.github.com/repos/pipermerriam/epm-spec/issues/events{/number}","events_url":"https://api.github.com/repos/pipermerriam/epm-spec/events","assignees_url":"https://api.github.com/repos/pipermerriam/epm-spec/assignees{/user}","branches_url":"https://api.github.com/repos/pipermerriam/epm-spec/branches{/branch}","tags_url":"https://api.github.com/repos/pipermerriam/epm-spec/tags","blobs_url":"https://api.github.com/repos/pipermerriam/epm-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pipermerriam/epm-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pipermerriam/epm-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/pipermerriam/epm-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pipermerriam/epm-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/pipermerriam/epm-spec/languages","stargazers_url":"https://api.github.com/repos/pipermerriam/epm-spec/stargazers","contributors_url":"https://api.github.com/repos/pipermerriam/epm-spec/contributors","subscribers_url":"https://api.github.com/repos/pipermerriam/epm-spec/subscribers","subscription_url":"https://api.github.com/repos/pipermerriam/epm-spec/subscription","commits_url":"https://api.github.com/repos/pipermerriam/epm-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/pipermerriam/epm-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/pipermerriam/epm-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/pipermerriam/epm-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/pipermerriam/epm-spec/contents/{+path}","compare_url":"https://api.github.com/repos/pipermerriam/epm-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pipermerriam/epm-spec/merges","archive_url":"https://api.github.com/repos/pipermerriam/epm-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pipermerriam/epm-spec/downloads","issues_url":"https://api.github.com/repos/pipermerriam/epm-spec/issues{/number}","pulls_url":"https://api.github.com/repos/pipermerriam/epm-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/pipermerriam/epm-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/pipermerriam/epm-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pipermerriam/epm-spec/labels{/name}","releases_url":"https://api.github.com/repos/pipermerriam/epm-spec/releases{/id}","deployments_url":"https://api.github.com/repos/pipermerriam/epm-spec/deployments","created_at":"2016-10-04T17:05:56Z","updated_at":"2016-12-05T17:25:16Z","pushed_at":"2016-12-16T23:32:30Z","git_url":"git://github.com/pipermerriam/epm-spec.git","ssh_url":"git@github.com:pipermerriam/epm-spec.git","clone_url":"https://github.com/pipermerriam/epm-spec.git","svn_url":"https://github.com/pipermerriam/epm-spec","homepage":null,"size":79,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethpm:master","ref":"master","sha":"ba32b115b9e00c0bc6543ae1fc770826a3367d22","user":{"login":"ethpm","id":19231566,"avatar_url":"https://avatars.githubusercontent.com/u/19231566?v=3","gravatar_id":"","url":"https://api.github.com/users/ethpm","html_url":"https://github.com/ethpm","followers_url":"https://api.github.com/users/ethpm/followers","following_url":"https://api.github.com/users/ethpm/following{/other_user}","gists_url":"https://api.github.com/users/ethpm/gists{/gist_id}","starred_url":"https://api.github.com/users/ethpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethpm/subscriptions","organizations_url":"https://api.github.com/users/ethpm/orgs","repos_url":"https://api.github.com/users/ethpm/repos","events_url":"https://api.github.com/users/ethpm/events{/privacy}","received_events_url":"https://api.github.com/users/ethpm/received_events","type":"Organization","site_admin":false},"repo":{"id":58237418,"name":"epm-spec","full_name":"ethpm/epm-spec","owner":{"login":"ethpm","id":19231566,"avatar_url":"https://avatars.githubusercontent.com/u/19231566?v=3","gravatar_id":"","url":"https://api.github.com/users/ethpm","html_url":"https://github.com/ethpm","followers_url":"https://api.github.com/users/ethpm/followers","following_url":"https://api.github.com/users/ethpm/following{/other_user}","gists_url":"https://api.github.com/users/ethpm/gists{/gist_id}","starred_url":"https://api.github.com/users/ethpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethpm/subscriptions","organizations_url":"https://api.github.com/users/ethpm/orgs","repos_url":"https://api.github.com/users/ethpm/repos","events_url":"https://api.github.com/users/ethpm/events{/privacy}","received_events_url":"https://api.github.com/users/ethpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethpm/epm-spec","description":"Ethereum Package Manager","fork":false,"url":"https://api.github.com/repos/ethpm/epm-spec","forks_url":"https://api.github.com/repos/ethpm/epm-spec/forks","keys_url":"https://api.github.com/repos/ethpm/epm-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethpm/epm-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethpm/epm-spec/teams","hooks_url":"https://api.github.com/repos/ethpm/epm-spec/hooks","issue_events_url":"https://api.github.com/repos/ethpm/epm-spec/issues/events{/number}","events_url":"https://api.github.com/repos/ethpm/epm-spec/events","assignees_url":"https://api.github.com/repos/ethpm/epm-spec/assignees{/user}","branches_url":"https://api.github.com/repos/ethpm/epm-spec/branches{/branch}","tags_url":"https://api.github.com/repos/ethpm/epm-spec/tags","blobs_url":"https://api.github.com/repos/ethpm/epm-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethpm/epm-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethpm/epm-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethpm/epm-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethpm/epm-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/ethpm/epm-spec/languages","stargazers_url":"https://api.github.com/repos/ethpm/epm-spec/stargazers","contributors_url":"https://api.github.com/repos/ethpm/epm-spec/contributors","subscribers_url":"https://api.github.com/repos/ethpm/epm-spec/subscribers","subscription_url":"https://api.github.com/repos/ethpm/epm-spec/subscription","commits_url":"https://api.github.com/repos/ethpm/epm-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethpm/epm-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethpm/epm-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethpm/epm-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethpm/epm-spec/contents/{+path}","compare_url":"https://api.github.com/repos/ethpm/epm-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethpm/epm-spec/merges","archive_url":"https://api.github.com/repos/ethpm/epm-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethpm/epm-spec/downloads","issues_url":"https://api.github.com/repos/ethpm/epm-spec/issues{/number}","pulls_url":"https://api.github.com/repos/ethpm/epm-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/ethpm/epm-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/ethpm/epm-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethpm/epm-spec/labels{/name}","releases_url":"https://api.github.com/repos/ethpm/epm-spec/releases{/id}","deployments_url":"https://api.github.com/repos/ethpm/epm-spec/deployments","created_at":"2016-05-06T22:07:50Z","updated_at":"2016-12-15T07:33:10Z","pushed_at":"2016-12-16T23:32:30Z","git_url":"git://github.com/ethpm/epm-spec.git","ssh_url":"git@github.com:ethpm/epm-spec.git","clone_url":"https://github.com/ethpm/epm-spec.git","svn_url":"https://github.com/ethpm/epm-spec","homepage":null,"size":72,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethpm/epm-spec/pulls/41"},"html":{"href":"https://github.com/ethpm/epm-spec/pull/41"},"issue":{"href":"https://api.github.com/repos/ethpm/epm-spec/issues/41"},"comments":{"href":"https://api.github.com/repos/ethpm/epm-spec/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/ethpm/epm-spec/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/ethpm/epm-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethpm/epm-spec/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/ethpm/epm-spec/statuses/1e6036f52bbc383109228f51c09e009191c3bef4"}}}}
{"actor":{"display_login":"pipermerriam"}}