{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/77904763","id":77904763,"diff_hunk":"@@ -1340,19 +1445,34 @@ GrainTracker::boundingRegionDistance(std::vector<MeshTools::BoundingBox> & bboxe\n   return min_distance;\n }\n \n+unsigned int\n+GrainTracker::getNextUniqueID()\n+{\n+  /**\n+   * Get the next unique grain ID but make sure to respect\n+   * reserve ids.\n+   */\n+  while (++_max_curr_grain_id <= _reserve_grain_first_idx + _n_reserve_ops)","path":"modules/phase_field/src/postprocessors/GrainTracker.C","position":1347,"original_position":1347,"commit_id":"2ff95c356ee48645a75331016cc7d55a7a5a043f","original_commit_id":"2ff95c356ee48645a75331016cc7d55a7a5a043f","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"Nope - the +1 isn't necessary in the second expression because `_reserve_grain_first_idx` is a valid index.\r\n\r\ne.g.\r\nLet's say I have 42 grains and I have 2 reserved ops. My grains will have indices from [0, 41]. The reserve grain indices will be 42 and 43. The first time I assign a move a new grain from the reserve op, it needs to be index number 44. I assign `_reserve_grain_first_idx` in line 485:\r\n\r\n```\r\n    _reserve_grain_first_idx = _max_curr_grain_id + 1;\r\n   // 42 = 41 + 1\r\n```\r\nTherefore the first index for a new grain is _reserve_grain_first_idx (42) + _n_reserve_ops (2).\r\n\r\n","created_at":"2016-09-07T21:12:03Z","updated_at":"2016-09-07T21:12:03Z","html_url":"https://github.com/idaholab/moose/pull/7605#discussion_r77904763","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/7605","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/77904763"},"html":{"href":"https://github.com/idaholab/moose/pull/7605#discussion_r77904763"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7605"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/7605","id":82436599,"html_url":"https://github.com/idaholab/moose/pull/7605","diff_url":"https://github.com/idaholab/moose/pull/7605.diff","patch_url":"https://github.com/idaholab/moose/pull/7605.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/7605","number":7605,"state":"open","locked":false,"title":"GrainTracker handle no grain (void region) or separate phase case","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"The GrainTracker change was really simple. This gets us a little closer.\r\n\r\n@dschwen - This example is a little problematic because the GrainTracker is printing \"re-assigning grain\"! It's time to \"fix\" how the grain tracker assigns the EBSD information, but I'm not sure how to do that reliably. I'm coming over to chat some more, prepare yourself.","created_at":"2016-08-23T20:38:10Z","updated_at":"2016-09-07T21:12:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dedde872f79423bbf297d4a570db789dc4f33962","assignee":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"assignees":[{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/7605/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/7605/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/7605/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/2ff95c356ee48645a75331016cc7d55a7a5a043f","head":{"label":"permcody:no_grain","ref":"no_grain","sha":"2ff95c356ee48645a75331016cc7d55a7a5a043f","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"repo":{"id":16853237,"name":"moose","full_name":"permcody/moose","owner":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/permcody/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/permcody/moose","forks_url":"https://api.github.com/repos/permcody/moose/forks","keys_url":"https://api.github.com/repos/permcody/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/permcody/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/permcody/moose/teams","hooks_url":"https://api.github.com/repos/permcody/moose/hooks","issue_events_url":"https://api.github.com/repos/permcody/moose/issues/events{/number}","events_url":"https://api.github.com/repos/permcody/moose/events","assignees_url":"https://api.github.com/repos/permcody/moose/assignees{/user}","branches_url":"https://api.github.com/repos/permcody/moose/branches{/branch}","tags_url":"https://api.github.com/repos/permcody/moose/tags","blobs_url":"https://api.github.com/repos/permcody/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/permcody/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/permcody/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/permcody/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/permcody/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/permcody/moose/languages","stargazers_url":"https://api.github.com/repos/permcody/moose/stargazers","contributors_url":"https://api.github.com/repos/permcody/moose/contributors","subscribers_url":"https://api.github.com/repos/permcody/moose/subscribers","subscription_url":"https://api.github.com/repos/permcody/moose/subscription","commits_url":"https://api.github.com/repos/permcody/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/permcody/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/permcody/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/permcody/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/permcody/moose/contents/{+path}","compare_url":"https://api.github.com/repos/permcody/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/permcody/moose/merges","archive_url":"https://api.github.com/repos/permcody/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/permcody/moose/downloads","issues_url":"https://api.github.com/repos/permcody/moose/issues{/number}","pulls_url":"https://api.github.com/repos/permcody/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/permcody/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/permcody/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/permcody/moose/labels{/name}","releases_url":"https://api.github.com/repos/permcody/moose/releases{/id}","deployments_url":"https://api.github.com/repos/permcody/moose/deployments","created_at":"2014-02-15T00:18:23Z","updated_at":"2016-06-07T20:21:54Z","pushed_at":"2016-09-07T20:52:42Z","git_url":"git://github.com/permcody/moose.git","ssh_url":"git@github.com:permcody/moose.git","clone_url":"https://github.com/permcody/moose.git","svn_url":"https://github.com/permcody/moose","homepage":null,"size":142825,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"652b5827bb2abb511f4f5e502e66d4eb79bfe1a8","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2016-08-30T11:54:33Z","pushed_at":"2016-09-07T20:54:46Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":160509,"stargazers_count":167,"watchers_count":167,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"open_issues_count":676,"forks":271,"open_issues":676,"watchers":167,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7605"},"html":{"href":"https://github.com/idaholab/moose/pull/7605"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/7605"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/7605/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7605/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7605/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/2ff95c356ee48645a75331016cc7d55a7a5a043f"}}}}
{"actor":{"display_login":"permcody"}}