{"push_id":926274310,"size":27,"distinct_size":1,"ref":"refs/heads/lr/default-unmanaged-bgo746566","head":"7b9882493d9e790971916416f81bab00b26403cc","before":"d92b300783b73764319b12eb7b34750a0f0640da","commits":[{"sha":"7102cde1ffcaf78852aee8f8c0619b38f8571118","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"platform/trivial: remove extra indention in constructed()","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/7102cde1ffcaf78852aee8f8c0619b38f8571118"},{"sha":"0e164ac6076c855ea7263bdf2d31b3ec682c5a1f","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"platform: ensure _nl_send_auto_with_seq() returns 0 on success\n\nJust for consistency reason.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/0e164ac6076c855ea7263bdf2d31b3ec682c5a1f"},{"sha":"5f93f0101538db39efe0f9ea2316e63bff953bf0","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"ppp-manager: clear @ppp_watch_id upon pppd termination\n\nSet @ppp_watch_id to zero upon pppd termination, otherwise the call to\ng_source_remove(priv->ppp_watch_id) in dispose() could trigger a failed\nassertion.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/5f93f0101538db39efe0f9ea2316e63bff953bf0"},{"sha":"ed536998f9530698ff3082fc5587dbeb7d3a594f","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"device: update @ip_iface only if IP interface exists\n\nIf @ip_ifindex is zero, the IP interface has disappeared and\nthere's no point in updating @ip_iface.\n\nActually, unconditionally updating @ip_iface is dangerous because it\nbreaks the assumption used by other functions (as\nnm_device_get_ip_ifindex()) that a non-NULL @ip_iface implies a valid\n@ip_ifindex. This was causing the scary failure:\n\n  devices/nm-device.c:666:get_ip_iface_identifier: assertion failed: (ifindex)\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1268617","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/ed536998f9530698ff3082fc5587dbeb7d3a594f"},{"sha":"e72b8aa9234cbd4fee98b5a0e01901f66b58d5e1","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"core: merge branch 'bg/ppp-device-fixes-rh1268617'\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1268617","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/e72b8aa9234cbd4fee98b5a0e01901f66b58d5e1"},{"sha":"5bf0697f659b262d7d385ff5903f3b86611a8c35","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"device/infiniband: take interface down to set transport mode\n\nWith some drivers it is necessary to take the interface down to set\nthe transport mode.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1281301","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/5bf0697f659b262d7d385ff5903f3b86611a8c35"},{"sha":"39e97c9339a189ce378a72025c05192fecbaf58b","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"ifcfg-rh: only accept ifcfg base paths in impl_ifcfgrh_get_ifcfg_details()\n\nPreviously, we directly passed the @in_ifcfg path to find_by_path().\nThat means, @in_ifcfg must be the path to the base \"ifcfg-\" file,\nnot an alias or route file.\n\nAdd an additional pre-check, that the provided file name is really a\nifcfg base file.\n\nThis results in a more detailed error message when calling\nGetIfcfgDetails not on the ifcfg base file. It's not that previously\nthe lookup would have succeeded.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/39e97c9339a189ce378a72025c05192fecbaf58b"},{"sha":"272098e48b532ad2b39e55130214c069a1c42b4b","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"ifcfg-rh: fix utils_detect_ifcfg_path() argument\n\nFixes: 39e97c9339a189ce378a72025c05192fecbaf58b","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/272098e48b532ad2b39e55130214c069a1c42b4b"},{"sha":"205ae642f9e45ee911a688356bcba1e5b7646601","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"core: fix signedness of NMPolicyPrivate.reset_retries_id","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/205ae642f9e45ee911a688356bcba1e5b7646601"},{"sha":"fbd32869553dd631c486530a2e543c31041af5c2","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"core,libnm: use nm_clear_g_source() where possible\n\nReplacement was done with commands:\n\nspatch --sp-file nm_clear_g_source.cocci --in-place --smpl-spacing --dir src\nspatch --sp-file nm_clear_g_source.cocci --in-place --smpl-spacing --dir libnm\n\nwhere nm_clear_g_source.cocci contains:\n\n@@\nexpression e;\n@@\n- if (e) {\n-    g_source_remove (e);\n-    e = 0;\n- }\n+ nm_clear_g_source (&e);","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/fbd32869553dd631c486530a2e543c31041af5c2"},{"sha":"f96abc8be53379898ed2cc1b6eb2f52341a86e3f","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"core: always use gulong to store signal handler ids\n\nWe inconsistently use gulong,guint,int types to store signal handler\nid, but the type returned by g_signal_connect() is a gulong.\n\nThis has no practical consequences because a int/guint is enough to\nstore the value, however it is better to use a consistent type, also\nbecause nm_clear_g_signal_handler() accepts a pointer to the signal id\nand thus it must be always called with the same pointer type.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/f96abc8be53379898ed2cc1b6eb2f52341a86e3f"},{"sha":"ea1eb94d9b15edc85a122ae5fdd097e37884a194","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"core: use nm_clear_g_signal_handler() where possible\n\nReplacement was done with command:\n\nspatch --sp-file nm_clear_g_signal_handler.cocci --in-place --smpl-spacing --dir src\n\nwhere nm_clear_g_signal_handler.cocci contains:\n\n@@\nexpression obj, id;\n@@\n- if (id) {\n-    g_signal_handler_disconnect (obj, id);\n-    id = 0;\n- }\n+ nm_clear_g_signal_handler (obj, &id);","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/ea1eb94d9b15edc85a122ae5fdd097e37884a194"},{"sha":"24d8604637d5c382dd99840bda63fd4d84e066d3","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"core: use NM_PLATFORM_GET instead of nm_platform_get() in function calls\n\nReplacement was done with command:\n\nspatch --sp-file nm_platform_get.cocci --in-place --smpl-spacing --dir src\n\nwhere nm_platform_get.cocci contains:\n\n@@\nidentifier func;\nexpression list args;\n@@\n- func (nm_platform_get())\n+ func (NM_PLATFORM_GET)\n\n@@\nidentifier func;\nexpression list args;\n@@\n- func (nm_platform_get(), args)\n+ func (NM_PLATFORM_GET, args)","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/24d8604637d5c382dd99840bda63fd4d84e066d3"},{"sha":"c37c36e7ecdcda94e3f7e86727215a2ecc3b3ac8","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"core: cache pointer to private-data in NMIP{4,6}Config structure\n\nThis is the same as 04c70c76bccf86a5870d957c35d4cff69ae5e558 for the\nNMIP4Config and NMIP6Config structures. The new field makes debugging\nof issues related to IP configuration much easier.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c37c36e7ecdcda94e3f7e86727215a2ecc3b3ac8"},{"sha":"0b5264d400b7f570ab4eade5eba5fff03239c55a","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"merge: branch 'bg/helper-macros-bgo760149'\n\nhttps://bugzilla.gnome.org/show_bug.cgi?id=760149","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/0b5264d400b7f570ab4eade5eba5fff03239c55a"},{"sha":"a097895a6515521eec67861536d126a78d84a9be","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"wifi: use \"bool\" members instead of gboolean in NMDeviceWifiPrivate struct","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a097895a6515521eec67861536d126a78d84a9be"},{"sha":"e2e22eb574d0c18ccd79bf8b3cee883418632a96","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"wifi-olpc: refactor NMDeviceOlpcMesh to hold pointer to NMManager\n\nObjects that register to a signal of a singleton should own a reference\nto the singleton to ensure the proper lifetime of the singleton upon shutdown.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/e2e22eb574d0c18ccd79bf8b3cee883418632a96"},{"sha":"044de4cea2c82d289033e75f1e12c7d346dc5537","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"wifi: don't fail construction of NMDeviceWifi in constructor\n\nWe cannot abort the construction of a GLib object instance\nlike we did for NMDeviceWifi and NMDeviceOlpcMesh when\nnm_platform_wifi_get_capabilities() failed.\n\nInstead, check the capabilities first (in the factory method)\nand only create the object instance when the device can be handled.\n\nhttps://bugzilla.gnome.org/show_bug.cgi?id=760154","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/044de4cea2c82d289033e75f1e12c7d346dc5537"},{"sha":"1a835ad3d03ffe39a3caf4796027baaba73bf9b8","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"wifi: refactor creation of NMDeviceWifi/NMDeviceOlpcMesh to initialize in constructed() method","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/1a835ad3d03ffe39a3caf4796027baaba73bf9b8"},{"sha":"06e0595401e6eb16ac527e54af8ca09c72245672","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"wifi: merge branch 'th/wifi-device-creation-bgo760154'\n\nhttps://bugzilla.gnome.org/show_bug.cgi?id=760154","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/06e0595401e6eb16ac527e54af8ca09c72245672"}]}