{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/75581903","id":75581903,"diff_hunk":"@@ -0,0 +1,97 @@\n+<?php\n+/**\n+ * @package     Joomla.Administrator\n+ * @subpackage  com_joomlaupdate\n+ *\n+ * @copyright   Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved.\n+ * @license     GNU General Public License version 2 or later; see LICENSE.txt\n+ */\n+\n+defined('_JEXEC') or die;\n+\n+JHtml::_('behavior.keepalive');\n+JHtml::_('bootstrap.tooltip');\n+\n+JLoader::register('ModLoginHelper', JPATH_ADMINISTRATOR . '/modules/mod_login/helper.php');\n+\n+$twofactormethods = ModLoginHelper::getTwoFactorMethods();","path":"administrator/components/com_joomlaupdate/views/update/tmpl/finaliseconfirm.php","position":17,"original_position":17,"commit_id":"49c71d74b151b71ded717b1905859cdd61fe1363","original_commit_id":"49c71d74b151b71ded717b1905859cdd61fe1363","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"body":"Can we have problems when the files are not deleted replaced an cleaned up? I need to try that.","created_at":"2016-08-20T17:13:35Z","updated_at":"2016-08-20T17:13:35Z","html_url":"https://github.com/joomla/joomla-cms/pull/11689#discussion_r75581903","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11689","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/75581903"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11689#discussion_r75581903"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11689"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11689","id":82079021,"html_url":"https://github.com/joomla/joomla-cms/pull/11689","diff_url":"https://github.com/joomla/joomla-cms/pull/11689.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/11689.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11689","number":11689,"state":"open","locked":false,"title":"[com_joomlaupdate] Make updating from 3.5.1 to 3.6.x possible without steps between","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"body":"Pull Request for Update Issues since 3.6.2\r\n\r\n### Summary of Changes\r\n\r\nBased on the work by @andrepereiradasilva \r\nWith this changes it is possible to update from 3.x direct to 3.6.3\r\n\r\n### Testing Instructions\r\n\r\n- install 2.5.28\r\n- set this update server `http://www.jah-tz.de/downloads/core/list4.xml`\r\n- Update to 3.5.1 (this step is still needed)\r\n- Update to 3.6.2 with the update provided by the update component\r\n- you need to login to make sure you use this.\r\n- confirm you are on 3.6.2 \r\n\r\n\r\n- install 3.5.1 (or any other 3.x)\r\n- set the update server `http://www.jah-tz.de/downloads/core/list4.xml`\r\n- Update to 3.6.2\r\n- you need to login to make sure you use this.\r\n- confirm you are on 3.6.2\r\n\r\n### Documentation Changes Required\r\n\r\nThere is no step between 3.* and 3.6.x anymore\r\nThere is a step between 2.5 and 3.6.x (3.5.1)\r\n\r\n### Image\r\n\r\nCurrently it looks like \r\n![final_login](https://cloud.githubusercontent.com/assets/2596554/17783940/b48d537a-657a-11e6-804b-394266017897.JPG)\r\n\r\nI'm happy on any feedback e.g. @wilsonge @mbabker @rdeutz @sinpersister @roland-d on the sec point of the issue as it migrates the sec problem with a login page if that is ok for you guys.\r\n\r\nThanks again to @andrepereiradasilva ","created_at":"2016-08-20T13:42:17Z","updated_at":"2016-08-20T17:13:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3806c63232896b4e0feef940eeff1942a3532d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11689/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11689/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11689/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/49c71d74b151b71ded717b1905859cdd61fe1363","head":{"label":"zero-24:update-test-2","ref":"update-test-2","sha":"49c71d74b151b71ded717b1905859cdd61fe1363","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"repo":{"id":52710604,"name":"joomla-cms","full_name":"zero-24/joomla-cms","owner":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zero-24/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/zero-24/joomla-cms","forks_url":"https://api.github.com/repos/zero-24/joomla-cms/forks","keys_url":"https://api.github.com/repos/zero-24/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero-24/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero-24/joomla-cms/teams","hooks_url":"https://api.github.com/repos/zero-24/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/zero-24/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/zero-24/joomla-cms/events","assignees_url":"https://api.github.com/repos/zero-24/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/zero-24/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/zero-24/joomla-cms/tags","blobs_url":"https://api.github.com/repos/zero-24/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero-24/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero-24/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero-24/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero-24/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/zero-24/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/zero-24/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/zero-24/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/zero-24/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/zero-24/joomla-cms/subscription","commits_url":"https://api.github.com/repos/zero-24/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero-24/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero-24/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero-24/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero-24/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/zero-24/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero-24/joomla-cms/merges","archive_url":"https://api.github.com/repos/zero-24/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero-24/joomla-cms/downloads","issues_url":"https://api.github.com/repos/zero-24/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/zero-24/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/zero-24/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/zero-24/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero-24/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/zero-24/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/zero-24/joomla-cms/deployments","created_at":"2016-02-28T07:45:35Z","updated_at":"2016-02-28T07:45:49Z","pushed_at":"2016-08-20T15:50:51Z","git_url":"git://github.com/zero-24/joomla-cms.git","ssh_url":"git@github.com:zero-24/joomla-cms.git","clone_url":"https://github.com/zero-24/joomla-cms.git","svn_url":"https://github.com/zero-24/joomla-cms","homepage":"https://www.joomla.org","size":155358,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"809db9aa9bc6774a0e1afbfeb8840b7cba83a2a3","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-08-19T11:08:26Z","pushed_at":"2016-08-20T16:30:04Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":290561,"stargazers_count":2113,"watchers_count":2113,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2271,"mirror_url":null,"open_issues_count":466,"forks":2271,"open_issues":466,"watchers":2113,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11689"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11689"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11689"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11689/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11689/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11689/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/49c71d74b151b71ded717b1905859cdd61fe1363"}}}}
{"actor":{"display_login":"zero-24"}}