{"action":"created","issue":{"url":"https://api.github.com/repos/locomotivecms/engine/issues/1135","repository_url":"https://api.github.com/repos/locomotivecms/engine","labels_url":"https://api.github.com/repos/locomotivecms/engine/issues/1135/labels{/name}","comments_url":"https://api.github.com/repos/locomotivecms/engine/issues/1135/comments","events_url":"https://api.github.com/repos/locomotivecms/engine/issues/1135/events","html_url":"https://github.com/locomotivecms/engine/pull/1135","id":137691893,"number":1135,"title":"Don't include wysihtml5_editor css unless live editing","user":{"login":"jeppeliisberg","id":13498,"avatar_url":"https://avatars.githubusercontent.com/u/13498?v=3","gravatar_id":"","url":"https://api.github.com/users/jeppeliisberg","html_url":"https://github.com/jeppeliisberg","followers_url":"https://api.github.com/users/jeppeliisberg/followers","following_url":"https://api.github.com/users/jeppeliisberg/following{/other_user}","gists_url":"https://api.github.com/users/jeppeliisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jeppeliisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeppeliisberg/subscriptions","organizations_url":"https://api.github.com/users/jeppeliisberg/orgs","repos_url":"https://api.github.com/users/jeppeliisberg/repos","events_url":"https://api.github.com/users/jeppeliisberg/events{/privacy}","received_events_url":"https://api.github.com/users/jeppeliisberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-01T21:27:47Z","updated_at":"2016-03-02T21:07:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/locomotivecms/engine/pulls/1135","html_url":"https://github.com/locomotivecms/engine/pull/1135","diff_url":"https://github.com/locomotivecms/engine/pull/1135.diff","patch_url":"https://github.com/locomotivecms/engine/pull/1135.patch"},"body":"Before this fix, wysihtml5_editor css was always included, and it cause\r\nall clients to download it.\r\n\r\nThis stylesheet should only be included when the page is being edited\r\nby an editor. It should not be served for all visitors of a website.\r\n\r\nI discovered this bug because google page speed insights complained\r\n\"Eliminate render-blocking JavaScript and CSS in above-the-fold content\"\r\n\r\nI'm not entirely sure when the wysiwyg editor is included, so this is\r\nmy best guess on a fix."},"comment":{"url":"https://api.github.com/repos/locomotivecms/engine/issues/comments/191431014","html_url":"https://github.com/locomotivecms/engine/pull/1135#issuecomment-191431014","issue_url":"https://api.github.com/repos/locomotivecms/engine/issues/1135","id":191431014,"user":{"login":"did","id":8065,"avatar_url":"https://avatars.githubusercontent.com/u/8065?v=3","gravatar_id":"","url":"https://api.github.com/users/did","html_url":"https://github.com/did","followers_url":"https://api.github.com/users/did/followers","following_url":"https://api.github.com/users/did/following{/other_user}","gists_url":"https://api.github.com/users/did/gists{/gist_id}","starred_url":"https://api.github.com/users/did/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/did/subscriptions","organizations_url":"https://api.github.com/users/did/orgs","repos_url":"https://api.github.com/users/did/repos","events_url":"https://api.github.com/users/did/events{/privacy}","received_events_url":"https://api.github.com/users/did/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T21:07:07Z","updated_at":"2016-03-02T21:07:07Z","body":"@jeppeliisberg that makes totally sense. Is that safe to inject the css like you described it? I mean if there is JS error in the page, could it prevent the css to be loaded?"}}