{"action":"created","issue":{"url":"https://api.github.com/repos/otland/forgottenserver/issues/1964","repository_url":"https://api.github.com/repos/otland/forgottenserver","labels_url":"https://api.github.com/repos/otland/forgottenserver/issues/1964/labels{/name}","comments_url":"https://api.github.com/repos/otland/forgottenserver/issues/1964/comments","events_url":"https://api.github.com/repos/otland/forgottenserver/issues/1964/events","html_url":"https://github.com/otland/forgottenserver/issues/1964","id":184977192,"number":1964,"title":"Two-factor authentication crashing on Windows (RC 1.2)","user":{"login":"Znote","id":1552144,"avatar_url":"https://avatars.githubusercontent.com/u/1552144?v=3","gravatar_id":"","url":"https://api.github.com/users/Znote","html_url":"https://github.com/Znote","followers_url":"https://api.github.com/users/Znote/followers","following_url":"https://api.github.com/users/Znote/following{/other_user}","gists_url":"https://api.github.com/users/Znote/gists{/gist_id}","starred_url":"https://api.github.com/users/Znote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Znote/subscriptions","organizations_url":"https://api.github.com/users/Znote/orgs","repos_url":"https://api.github.com/users/Znote/repos","events_url":"https://api.github.com/users/Znote/events{/privacy}","received_events_url":"https://api.github.com/users/Znote/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/otland/forgottenserver/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-24T23:02:43Z","updated_at":"2016-10-25T11:13:55Z","closed_at":null,"body":"<!-- Welcome to the issues section if it's your first time! -->\r\n\r\n### Before creating an issue, please ensure:\r\n- [x] This is a bug in the software that resides in this repository, and not a\r\n      support matter (use https://otland.net/forums/support.16/ for support)\r\n- [x] This issue is reproducible without changes to the code in this repository\r\n\r\n### Steps to reproduce (include any configuration/script required to reproduce)\r\n1. Create account (username: testing1, password: testing1, secret: [OHWC267D3OQKDMTG](http://1.1m.yt/0B1cg-.png))\r\n2. Login with correct username, password but invalid secret key, etc 123123\r\n\r\n### Expected behaviour\r\n1. Login should fail, user should be asked to write correct secret key\r\n\r\n### Actual behaviour\r\n1. Server crashes. \r\n\r\nif I write the correct token generated by \"Authy\" mobile app, it works and I can login just fine.\r\n\r\n### Environment\r\n<!-- If the issue is environment specific (e.g. compiling errors), include\r\n     name and version of the operating system and compiler you are using. -->\r\nWindows 10, 64bit. \r\nTried to run 32bit and 64bit precompiled TFS 1.2 release versions.\r\n\r\nNot quite sure what im doing but I managed to get gdb on windows through mingw32, here is what I was able to capture through debugging of the 32bit executable file:\r\n\r\n```\r\nC:\\tfs13>gdb theforgottenserver.exe\r\nGNU gdb (GDB) 7.6.1\r\nCopyright (C) 2013 Free Software Foundation, Inc.\r\nLicense GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>\r\nThis is free software: you are free to change and redistribute it.\r\nThere is NO WARRANTY, to the extent permitted by law.  Type \"show copying\"\r\nand \"show warranty\" for details.\r\nThis GDB was configured as \"mingw32\".\r\nFor bug reporting instructions, please see:\r\n<http://www.gnu.org/software/gdb/bugs/>...\r\nReading symbols from C:\\tfs13\\theforgottenserver.exe...(no debugging symbols found)...done.\r\n```\r\n\r\n```\r\n(gdb) run\r\nStarting program: C:\\tfs13/theforgottenserver.exe\r\n[New Thread 8032.0x2688]\r\n[New Thread 8032.0x71c]\r\n[New Thread 8032.0x27bc]\r\n[New Thread 8032.0x2f70]\r\n[New Thread 8032.0x2fa4]\r\n[New Thread 8032.0x2d68]\r\n[New Thread 8032.0x19f4]\r\n```\r\n```\r\nThe Forgotten Server - Version 1.2\r\nCompiled with Microsoft Visual C++ version 14.0\r\nCompiled on Oct 22 2016 03:34:15 for platform x86\r\n\r\nA server developed by Mark Samman\r\nVisit our forum for updates, support, and resources: http://otland.net/.\r\n\r\n>> Loading config\r\n>> Establishing database connection... MySQL 6.1.6\r\n>> Running database manager\r\n[New Thread 8032.0x185c]\r\n>> Loading vocations\r\n>> Loading items\r\n>> Loading script systems\r\n>> Loading monsters\r\n>> Loading outfits\r\n>> Checking world type... PVP\r\n>> Loading map\r\n> Map size: 1000x1000.\r\n> Map loading time: 1.295 seconds.\r\n>> Initializing gamestate\r\n>> Loaded all modules, server starting up...\r\n>> Forgotten Server Online!\r\n```\r\n\r\n```\r\ngdb: unknown target exception 0xc0000409 at 0x751491cb\r\n\r\nProgram received signal ?, Unknown signal.\r\n[Switching to Thread 8032.0x2d68]\r\n0x751491cb in ucrtbase!abort () from C:\\WINDOWS\\SysWoW64\\ucrtbase.dll\r\n```\r\n\r\n```\r\n(gdb) frame 0\r\n#0  0x751491cb in ucrtbase!abort () from C:\\WINDOWS\\SysWoW64\\ucrtbase.dll\r\n(gdb) frame 1\r\n#1  0x75148abb in ucrtbase!terminate () from C:\\WINDOWS\\SysWoW64\\ucrtbase.dll\r\n(gdb) frame 2\r\n#2  0x4cd6c780 in ?? ()\r\n(gdb) frame 3\r\n#3  0x0100e378 in ?? ()\r\n(gdb) frame 4\r\n#4  0x73902c87 in wcsstr () from C:\\WINDOWS\\SysWoW64\\vcruntime140.dll\r\n(gdb) frame 5\r\n#5  0x73902ba8 in wcsstr () from C:\\WINDOWS\\SysWoW64\\vcruntime140.dll\r\n(gdb) frame 6\r\n#6  0x7390e436 in _CxxFrameHandler3 ()\r\n   from C:\\WINDOWS\\SysWoW64\\vcruntime140.dll\r\n```\r\n\r\n```\r\n(gdb) thread 1\r\n[Switching to thread 1 (Thread 8032.0x2688)]\r\n#0  0x7720dc7c in ?? ()\r\n(gdb) thread 2\r\n[Switching to thread 2 (Thread 8032.0x71c)]\r\n#0  0x7720f7fc in ?? ()\r\n(gdb) thread 3\r\n[Switching to thread 3 (Thread 8032.0x27bc)]\r\n#0  0x7720f7fc in ?? ()\r\n(gdb) thread 4\r\n[Switching to thread 4 (Thread 8032.0x2f70)]\r\n#0  0x7720f7fc in ?? ()\r\n(gdb) thread 5\r\n[Switching to thread 5 (Thread 8032.0x2fa4)]\r\n#0  0x7720dc2c in ?? ()\r\n(gdb) thread 6\r\n[Switching to thread 6 (Thread 8032.0x2d68)]\r\n#0  0x751491cb in ucrtbase!abort () from C:\\WINDOWS\\SysWoW64\\ucrtbase.dll\r\n```\r\n\r\n```\r\n(gdb) bt full\r\n#0  0x7720f7fc in ?? ()\r\nNo symbol table info available.\r\n#1  0x748462c4 in KERNEL32!BaseThreadInitThunk ()\r\n   from C:\\WINDOWS\\SysWoW64\\kernel32.dll\r\nNo symbol table info available.\r\n#2  0x77200609 in ?? ()\r\nNo symbol table info available.\r\n#3  0x772005d4 in ?? ()\r\nNo symbol table info available.\r\n#4  0x00000000 in ?? ()\r\nNo symbol table info available.\r\n```"},"comment":{"url":"https://api.github.com/repos/otland/forgottenserver/issues/comments/256006583","html_url":"https://github.com/otland/forgottenserver/issues/1964#issuecomment-256006583","issue_url":"https://api.github.com/repos/otland/forgottenserver/issues/1964","id":256006583,"user":{"login":"daniofordon","id":13053215,"avatar_url":"https://avatars.githubusercontent.com/u/13053215?v=3","gravatar_id":"","url":"https://api.github.com/users/daniofordon","html_url":"https://github.com/daniofordon","followers_url":"https://api.github.com/users/daniofordon/followers","following_url":"https://api.github.com/users/daniofordon/following{/other_user}","gists_url":"https://api.github.com/users/daniofordon/gists{/gist_id}","starred_url":"https://api.github.com/users/daniofordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniofordon/subscriptions","organizations_url":"https://api.github.com/users/daniofordon/orgs","repos_url":"https://api.github.com/users/daniofordon/repos","events_url":"https://api.github.com/users/daniofordon/events{/privacy}","received_events_url":"https://api.github.com/users/daniofordon/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T11:13:55Z","updated_at":"2016-10-25T11:13:55Z","body":"on otx 3 after the last update to version 1.3 is a bug with the token on otclient. Customer CipSoft pops debug client\r\n\r\nhttps://github.com/mattyx14/otxserver/issues/133"}}
{"actor":{"display_login":"daniofordon"}}