{"action":"created","comment":{"url":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/comments/64750064","id":64750064,"diff_hunk":"@@ -200,43 +202,59 @@ class BlockF: public Module {\n             double a10 = 2*(alpha6*gamma6 - alpha1*gamma1 - alpha2*gamma2 - alpha3*gamma3);\n             double a01 = 2*(beta6*gamma6 - beta1*gamma1 - beta2*gamma2 - beta3*gamma3);\n             double a00 = SQ(gamma6) - SQ(gamma1) - SQ(gamma2) - SQ(gamma3);\n-            \n-            double b11 = 1 + SQ(alpha4) + SQ(alpha5);\n-            double b22 = SQ(beta4) + SQ(beta5) -1;\n-            double b12 = 2*(alpha4*beta4 + alpha5*beta5);\n+ \n             double b10 = 2*(alpha4*gamma4 + alpha5*gamma5);\n             double b01 = 2*(beta4*gamma4 + beta5*gamma5);\n             double b00 = SQ(gamma4) + SQ(gamma5);\n-            \n-            solve2Quads(a11, a22, a12, a10, a01, a00, b11, b22, b12, b10, b01, b00, p2y, E2, false);\n-            //In this case there will be up to 2 solutions\n-            \n+\n+            //These 2 equations are equivalent to the following system:\n+            //a11*p2y^2 + a22*E2^2 + a12*p2y*E2 + a10*p2y + a01*E2 + a00 = 0\n+            //E2 = c0 + c1*p2y\n+            //From these two, we get a quadratic equation in p2y:\n+            //d2*p2y^2 + d1*p2y + d0 = 0\n+\n+            double c0 = -(a00+b00)/(a01+b01);\n+            double c1 = -(a10+b10)/(a01+b01);\n+\n+            double d0 = a22*SQ(c0) + a01*c0 + a00;\n+            double d1 = 2*a22*c1*c0 + a12*c0 + a01*c1 + a10;\n+            double d2 = a22*SQ(c1) + a12*c1 + a11;\n+\n+            solveQuadratic(d2, d1, d0, p2y, false);\n+\n             if (p2y.size() == 0)\n                 return;\n             \n             for (size_t i=0; i<p2y.size(); i++) {\n-                const double e1 = p2y.at(i);\n-                const double e2 = E2.at(i);\n+                const double e1 = p2y.at(i);      //p2y\n+                const double e2 = (c0 + c1*e1);   //E2\n                 \n-                if (e1 < 0. || e2 < 0.)\n+                if (e2 < 0.)\n                     continue;\n                 \n-                LorentzVector p1(alpha6*e1+beta6*e2+gamma6,     //E1\n-                                 alpha1*e1+beta1*e2+gamma1,     //p1x\n+                LorentzVector p1(alpha1*e1+beta1*e2+gamma1,     //p1x\n                                  alpha2*e1+beta2*e2+gamma2,     //p1y\n-                                 alpha3*e1+beta3*e2+gamma3      //p1z\n+                                 alpha3*e1+beta3*e2+gamma3,     //p1z\n+                                 alpha6*e1+beta6*e2+gamma6      //E1\n                                  );\n-                \n-                LorentzVector p2(e2,                            //E2\n-                                 alpha4*e1+beta4*e2+gamma4,     //p2x\n+\n+                if (p1.E() < 0.)\n+                    continue;\n+\n+                LorentzVector p2(alpha4*e1+beta4*e2+gamma4,     //p2x\n                                  e1,                            //p2y\n-                                 alpha5*e1+beta5*e2+gamma5      //p2z\n+                                 alpha5*e1+beta5*e2+gamma5,     //p2z\n+                                 e2                             //E2\n                                  );                  \n-                \n+                               ","path":"modules/BlockF.cc","position":133,"original_position":133,"commit_id":"148593f70242c10b49d5dd303742998fe481d3d3","original_commit_id":"148593f70242c10b49d5dd303742998fe481d3d3","user":{"login":"blinkseb","id":386274,"avatar_url":"https://avatars.githubusercontent.com/u/386274?v=3","gravatar_id":"","url":"https://api.github.com/users/blinkseb","html_url":"https://github.com/blinkseb","followers_url":"https://api.github.com/users/blinkseb/followers","following_url":"https://api.github.com/users/blinkseb/following{/other_user}","gists_url":"https://api.github.com/users/blinkseb/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkseb/subscriptions","organizations_url":"https://api.github.com/users/blinkseb/orgs","repos_url":"https://api.github.com/users/blinkseb/repos","events_url":"https://api.github.com/users/blinkseb/events{/privacy}","received_events_url":"https://api.github.com/users/blinkseb/received_events","type":"User","site_admin":false},"body":"Please remove","created_at":"2016-05-26T14:00:46Z","updated_at":"2016-05-26T14:00:46Z","html_url":"https://github.com/MoMEMta/MoMEMta/pull/55#discussion_r64750064","pull_request_url":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/comments/64750064"},"html":{"href":"https://github.com/MoMEMta/MoMEMta/pull/55#discussion_r64750064"},"pull_request":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/55","id":70663843,"html_url":"https://github.com/MoMEMta/MoMEMta/pull/55","diff_url":"https://github.com/MoMEMta/MoMEMta/pull/55.diff","patch_url":"https://github.com/MoMEMta/MoMEMta/pull/55.patch","issue_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/55","number":55,"state":"open","locked":false,"title":"added WW fully leptonic","user":{"login":"alesaggio","id":16693208,"avatar_url":"https://avatars.githubusercontent.com/u/16693208?v=3","gravatar_id":"","url":"https://api.github.com/users/alesaggio","html_url":"https://github.com/alesaggio","followers_url":"https://api.github.com/users/alesaggio/followers","following_url":"https://api.github.com/users/alesaggio/following{/other_user}","gists_url":"https://api.github.com/users/alesaggio/gists{/gist_id}","starred_url":"https://api.github.com/users/alesaggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesaggio/subscriptions","organizations_url":"https://api.github.com/users/alesaggio/orgs","repos_url":"https://api.github.com/users/alesaggio/repos","events_url":"https://api.github.com/users/alesaggio/events{/privacy}","received_events_url":"https://api.github.com/users/alesaggio/received_events","type":"User","site_admin":false},"body":"Added WW_fullyleptonic.cc and WW_fullyleptonic.lua in MoMEMta/examples;\r\nAdded the matrix element from the exporter for WW fully lept in MoMEMta/MatrixElements;\r\nMoMEMta/test not updated for this case yet;\r\nCompiling and running\r\n","created_at":"2016-05-19T09:41:39Z","updated_at":"2016-05-26T14:00:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"307bd929b2f2f9039927457ae0d2e3187a76f71c","assignee":null,"milestone":{"url":"https://api.github.com/repos/MoMEMta/MoMEMta/milestones/1","html_url":"https://github.com/MoMEMta/MoMEMta/milestones/First%20public%20version","labels_url":"https://api.github.com/repos/MoMEMta/MoMEMta/milestones/1/labels","id":1735844,"number":1,"title":"First public version","description":"First public version of MoMEMta","creator":{"login":"blinkseb","id":386274,"avatar_url":"https://avatars.githubusercontent.com/u/386274?v=3","gravatar_id":"","url":"https://api.github.com/users/blinkseb","html_url":"https://github.com/blinkseb","followers_url":"https://api.github.com/users/blinkseb/followers","following_url":"https://api.github.com/users/blinkseb/following{/other_user}","gists_url":"https://api.github.com/users/blinkseb/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkseb/subscriptions","organizations_url":"https://api.github.com/users/blinkseb/orgs","repos_url":"https://api.github.com/users/blinkseb/repos","events_url":"https://api.github.com/users/blinkseb/events{/privacy}","received_events_url":"https://api.github.com/users/blinkseb/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":16,"state":"open","created_at":"2016-04-28T09:11:00Z","updated_at":"2016-05-26T12:18:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/55/commits","review_comments_url":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/55/comments","review_comment_url":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/55/comments","statuses_url":"https://api.github.com/repos/MoMEMta/MoMEMta/statuses/148593f70242c10b49d5dd303742998fe481d3d3","head":{"label":"alesaggio:validate_WW","ref":"validate_WW","sha":"148593f70242c10b49d5dd303742998fe481d3d3","user":{"login":"alesaggio","id":16693208,"avatar_url":"https://avatars.githubusercontent.com/u/16693208?v=3","gravatar_id":"","url":"https://api.github.com/users/alesaggio","html_url":"https://github.com/alesaggio","followers_url":"https://api.github.com/users/alesaggio/followers","following_url":"https://api.github.com/users/alesaggio/following{/other_user}","gists_url":"https://api.github.com/users/alesaggio/gists{/gist_id}","starred_url":"https://api.github.com/users/alesaggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesaggio/subscriptions","organizations_url":"https://api.github.com/users/alesaggio/orgs","repos_url":"https://api.github.com/users/alesaggio/repos","events_url":"https://api.github.com/users/alesaggio/events{/privacy}","received_events_url":"https://api.github.com/users/alesaggio/received_events","type":"User","site_admin":false},"repo":{"id":50097864,"name":"MoMEMta","full_name":"alesaggio/MoMEMta","owner":{"login":"alesaggio","id":16693208,"avatar_url":"https://avatars.githubusercontent.com/u/16693208?v=3","gravatar_id":"","url":"https://api.github.com/users/alesaggio","html_url":"https://github.com/alesaggio","followers_url":"https://api.github.com/users/alesaggio/followers","following_url":"https://api.github.com/users/alesaggio/following{/other_user}","gists_url":"https://api.github.com/users/alesaggio/gists{/gist_id}","starred_url":"https://api.github.com/users/alesaggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesaggio/subscriptions","organizations_url":"https://api.github.com/users/alesaggio/orgs","repos_url":"https://api.github.com/users/alesaggio/repos","events_url":"https://api.github.com/users/alesaggio/events{/privacy}","received_events_url":"https://api.github.com/users/alesaggio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alesaggio/MoMEMta","description":"Modular Matrix Element Method implementation","fork":true,"url":"https://api.github.com/repos/alesaggio/MoMEMta","forks_url":"https://api.github.com/repos/alesaggio/MoMEMta/forks","keys_url":"https://api.github.com/repos/alesaggio/MoMEMta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alesaggio/MoMEMta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alesaggio/MoMEMta/teams","hooks_url":"https://api.github.com/repos/alesaggio/MoMEMta/hooks","issue_events_url":"https://api.github.com/repos/alesaggio/MoMEMta/issues/events{/number}","events_url":"https://api.github.com/repos/alesaggio/MoMEMta/events","assignees_url":"https://api.github.com/repos/alesaggio/MoMEMta/assignees{/user}","branches_url":"https://api.github.com/repos/alesaggio/MoMEMta/branches{/branch}","tags_url":"https://api.github.com/repos/alesaggio/MoMEMta/tags","blobs_url":"https://api.github.com/repos/alesaggio/MoMEMta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alesaggio/MoMEMta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alesaggio/MoMEMta/git/refs{/sha}","trees_url":"https://api.github.com/repos/alesaggio/MoMEMta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alesaggio/MoMEMta/statuses/{sha}","languages_url":"https://api.github.com/repos/alesaggio/MoMEMta/languages","stargazers_url":"https://api.github.com/repos/alesaggio/MoMEMta/stargazers","contributors_url":"https://api.github.com/repos/alesaggio/MoMEMta/contributors","subscribers_url":"https://api.github.com/repos/alesaggio/MoMEMta/subscribers","subscription_url":"https://api.github.com/repos/alesaggio/MoMEMta/subscription","commits_url":"https://api.github.com/repos/alesaggio/MoMEMta/commits{/sha}","git_commits_url":"https://api.github.com/repos/alesaggio/MoMEMta/git/commits{/sha}","comments_url":"https://api.github.com/repos/alesaggio/MoMEMta/comments{/number}","issue_comment_url":"https://api.github.com/repos/alesaggio/MoMEMta/issues/comments{/number}","contents_url":"https://api.github.com/repos/alesaggio/MoMEMta/contents/{+path}","compare_url":"https://api.github.com/repos/alesaggio/MoMEMta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alesaggio/MoMEMta/merges","archive_url":"https://api.github.com/repos/alesaggio/MoMEMta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alesaggio/MoMEMta/downloads","issues_url":"https://api.github.com/repos/alesaggio/MoMEMta/issues{/number}","pulls_url":"https://api.github.com/repos/alesaggio/MoMEMta/pulls{/number}","milestones_url":"https://api.github.com/repos/alesaggio/MoMEMta/milestones{/number}","notifications_url":"https://api.github.com/repos/alesaggio/MoMEMta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alesaggio/MoMEMta/labels{/name}","releases_url":"https://api.github.com/repos/alesaggio/MoMEMta/releases{/id}","deployments_url":"https://api.github.com/repos/alesaggio/MoMEMta/deployments","created_at":"2016-01-21T09:47:35Z","updated_at":"2016-01-21T09:47:36Z","pushed_at":"2016-05-26T13:46:18Z","git_url":"git://github.com/alesaggio/MoMEMta.git","ssh_url":"git@github.com:alesaggio/MoMEMta.git","clone_url":"https://github.com/alesaggio/MoMEMta.git","svn_url":"https://github.com/alesaggio/MoMEMta","homepage":null,"size":1308,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"prototype"}},"base":{"label":"MoMEMta:prototype","ref":"prototype","sha":"c9b3a29d54964c72e8a152c88b2584f03c2265b7","user":{"login":"MoMEMta","id":16399124,"avatar_url":"https://avatars.githubusercontent.com/u/16399124?v=3","gravatar_id":"","url":"https://api.github.com/users/MoMEMta","html_url":"https://github.com/MoMEMta","followers_url":"https://api.github.com/users/MoMEMta/followers","following_url":"https://api.github.com/users/MoMEMta/following{/other_user}","gists_url":"https://api.github.com/users/MoMEMta/gists{/gist_id}","starred_url":"https://api.github.com/users/MoMEMta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoMEMta/subscriptions","organizations_url":"https://api.github.com/users/MoMEMta/orgs","repos_url":"https://api.github.com/users/MoMEMta/repos","events_url":"https://api.github.com/users/MoMEMta/events{/privacy}","received_events_url":"https://api.github.com/users/MoMEMta/received_events","type":"Organization","site_admin":false},"repo":{"id":48423136,"name":"MoMEMta","full_name":"MoMEMta/MoMEMta","owner":{"login":"MoMEMta","id":16399124,"avatar_url":"https://avatars.githubusercontent.com/u/16399124?v=3","gravatar_id":"","url":"https://api.github.com/users/MoMEMta","html_url":"https://github.com/MoMEMta","followers_url":"https://api.github.com/users/MoMEMta/followers","following_url":"https://api.github.com/users/MoMEMta/following{/other_user}","gists_url":"https://api.github.com/users/MoMEMta/gists{/gist_id}","starred_url":"https://api.github.com/users/MoMEMta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoMEMta/subscriptions","organizations_url":"https://api.github.com/users/MoMEMta/orgs","repos_url":"https://api.github.com/users/MoMEMta/repos","events_url":"https://api.github.com/users/MoMEMta/events{/privacy}","received_events_url":"https://api.github.com/users/MoMEMta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MoMEMta/MoMEMta","description":"Modular Matrix Element Method implementation","fork":false,"url":"https://api.github.com/repos/MoMEMta/MoMEMta","forks_url":"https://api.github.com/repos/MoMEMta/MoMEMta/forks","keys_url":"https://api.github.com/repos/MoMEMta/MoMEMta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoMEMta/MoMEMta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoMEMta/MoMEMta/teams","hooks_url":"https://api.github.com/repos/MoMEMta/MoMEMta/hooks","issue_events_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/events{/number}","events_url":"https://api.github.com/repos/MoMEMta/MoMEMta/events","assignees_url":"https://api.github.com/repos/MoMEMta/MoMEMta/assignees{/user}","branches_url":"https://api.github.com/repos/MoMEMta/MoMEMta/branches{/branch}","tags_url":"https://api.github.com/repos/MoMEMta/MoMEMta/tags","blobs_url":"https://api.github.com/repos/MoMEMta/MoMEMta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoMEMta/MoMEMta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoMEMta/MoMEMta/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoMEMta/MoMEMta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoMEMta/MoMEMta/statuses/{sha}","languages_url":"https://api.github.com/repos/MoMEMta/MoMEMta/languages","stargazers_url":"https://api.github.com/repos/MoMEMta/MoMEMta/stargazers","contributors_url":"https://api.github.com/repos/MoMEMta/MoMEMta/contributors","subscribers_url":"https://api.github.com/repos/MoMEMta/MoMEMta/subscribers","subscription_url":"https://api.github.com/repos/MoMEMta/MoMEMta/subscription","commits_url":"https://api.github.com/repos/MoMEMta/MoMEMta/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoMEMta/MoMEMta/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoMEMta/MoMEMta/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoMEMta/MoMEMta/contents/{+path}","compare_url":"https://api.github.com/repos/MoMEMta/MoMEMta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoMEMta/MoMEMta/merges","archive_url":"https://api.github.com/repos/MoMEMta/MoMEMta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoMEMta/MoMEMta/downloads","issues_url":"https://api.github.com/repos/MoMEMta/MoMEMta/issues{/number}","pulls_url":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls{/number}","milestones_url":"https://api.github.com/repos/MoMEMta/MoMEMta/milestones{/number}","notifications_url":"https://api.github.com/repos/MoMEMta/MoMEMta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoMEMta/MoMEMta/labels{/name}","releases_url":"https://api.github.com/repos/MoMEMta/MoMEMta/releases{/id}","deployments_url":"https://api.github.com/repos/MoMEMta/MoMEMta/deployments","created_at":"2015-12-22T09:30:30Z","updated_at":"2016-05-26T12:52:05Z","pushed_at":"2016-05-26T13:46:19Z","git_url":"git://github.com/MoMEMta/MoMEMta.git","ssh_url":"git@github.com:MoMEMta/MoMEMta.git","clone_url":"https://github.com/MoMEMta/MoMEMta.git","svn_url":"https://github.com/MoMEMta/MoMEMta","homepage":null,"size":5280,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":4,"default_branch":"prototype"}},"_links":{"self":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/55"},"html":{"href":"https://github.com/MoMEMta/MoMEMta/pull/55"},"issue":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/55"},"comments":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/MoMEMta/MoMEMta/statuses/148593f70242c10b49d5dd303742998fe481d3d3"}}}}
{"actor":{"display_login":"blinkseb"}}