{"action":"created","comment":{"url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/comments/78961174","id":78961174,"diff_hunk":"@@ -44,16 +64,42 @@\n             </goals>\n             <configuration>\n               <sources>\n+                <!-- Add generated/ to the source directories. -->\n+                <!-- TODO: Add needed functionality to java/libphonenumber/src/Phonemetadata.java","path":"tools/java/cpp-build/pom.xml","position":32,"original_position":32,"commit_id":"8f3cc46676070c4feae50ea6997bec1f58e3cc02","original_commit_id":"8f3cc46676070c4feae50ea6997bec1f58e3cc02","user":{"login":"keghani","id":9949289,"avatar_url":"https://avatars.githubusercontent.com/u/9949289?v=3","gravatar_id":"","url":"https://api.github.com/users/keghani","html_url":"https://github.com/keghani","followers_url":"https://api.github.com/users/keghani/followers","following_url":"https://api.github.com/users/keghani/following{/other_user}","gists_url":"https://api.github.com/users/keghani/gists{/gist_id}","starred_url":"https://api.github.com/users/keghani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keghani/subscriptions","organizations_url":"https://api.github.com/users/keghani/orgs","repos_url":"https://api.github.com/users/keghani/repos","events_url":"https://api.github.com/users/keghani/events{/privacy}","received_events_url":"https://api.github.com/users/keghani/received_events","type":"User","site_admin":false},"body":"Actually I made a mistake about the Maven version - I had thought that it was getting protoc from the protobuf-java dependency but it's not (that's used for the runtime dependencies, not to generate the files).\r\n\r\nChanged the comments, I'll push the changes momentarily.","created_at":"2016-09-15T13:21:38Z","updated_at":"2016-09-15T13:21:38Z","html_url":"https://github.com/googlei18n/libphonenumber/pull/1339#discussion_r78961174","pull_request_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1339","_links":{"self":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/comments/78961174"},"html":{"href":"https://github.com/googlei18n/libphonenumber/pull/1339#discussion_r78961174"},"pull_request":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1339"}}},"pull_request":{"url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1339","id":85379002,"html_url":"https://github.com/googlei18n/libphonenumber/pull/1339","diff_url":"https://github.com/googlei18n/libphonenumber/pull/1339.diff","patch_url":"https://github.com/googlei18n/libphonenumber/pull/1339.patch","issue_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues/1339","number":1339,"state":"open","locked":false,"title":"Revert use of protobuf-javanano (part 1)","user":{"login":"keghani","id":9949289,"avatar_url":"https://avatars.githubusercontent.com/u/9949289?v=3","gravatar_id":"","url":"https://api.github.com/users/keghani","html_url":"https://github.com/keghani","followers_url":"https://api.github.com/users/keghani/followers","following_url":"https://api.github.com/users/keghani/following{/other_user}","gists_url":"https://api.github.com/users/keghani/gists{/gist_id}","starred_url":"https://api.github.com/users/keghani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keghani/subscriptions","organizations_url":"https://api.github.com/users/keghani/orgs","repos_url":"https://api.github.com/users/keghani/repos","events_url":"https://api.github.com/users/keghani/events{/privacy}","received_events_url":"https://api.github.com/users/keghani/received_events","type":"User","site_admin":false},"body":"I will follow up with the generated file changes, either in this PR or separately into the proposed (non-master) branch, after which all can be merged to master.\r\n\r\nFor now this is all the hand-written changes, please review.\r\nProof of concept that once other files are generated this will build end-to-end: https://github.com/googlei18n/libphonenumber/pull/1338\r\n\r\nInteresting parts to review:\r\n\r\n- java/libphonenumber/src/com/google/i18n/phonenumbers/Phonemetadata.java:\r\nThis is almost what it was in 7.1.1; I added hand-crafted API for possible lengths.\r\nYou can diff https://raw.githubusercontent.com/keghani/libphonenumber/7.7.0/java/libphonenumber/src/com/google/i18n/phonenumbers/Phonemetadata.java and https://raw.githubusercontent.com/googlei18n/libphonenumber/libphonenumber-7.1.1/java/libphonenumber/src/com/google/i18n/phonenumbers/Phonemetadata.java locally.\r\n\r\n- tools/java/common/src/com/google/i18n/phonenumbers/BuildMetadataFromXml.java\r\n\r\n- tools/java/common/test/com/google/i18n/phonenumbers/BuildMetadataFromXmlTest.java\r\n\r\n- tools/java/cpp-build/pom.xml\r\n\r\n- tools/java/cpp-build/src/com/google/i18n/phonenumbers/BuildMetadataCppFromXml.java is back to what it was in 7.1.1.\r\n\r\n- tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataJsonFromXml.java too; interestingly the nanoproto version had a slightly different logic where it was writing the boolean nationalPrefixOptionalWhenFormatting (as true) when it was true (otherwise writing null), but before (and now) we're writing it (as true or false) when it's set (hasNationalPrefixOptionalWhenFormatting())\r\n\r\n- When I first built the entire PR I generated C++ metadata. But now I don't generate anything, even when I try from the same place (in that branch, resetting head to the previous commit). Unsure what's going on. Originally I had this: https://github.com/keghani/libphonenumber/commit/b510d075c6d7852f54fdc135d9fe286a2a92a0f4","created_at":"2016-09-15T10:24:54Z","updated_at":"2016-09-15T13:21:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d32bafd6e046dcdcbc30b0be6ab8446e4630c181","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1339/commits","review_comments_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1339/comments","review_comment_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues/1339/comments","statuses_url":"https://api.github.com/repos/googlei18n/libphonenumber/statuses/8f3cc46676070c4feae50ea6997bec1f58e3cc02","head":{"label":"keghani:7.7.0_candidate","ref":"7.7.0_candidate","sha":"8f3cc46676070c4feae50ea6997bec1f58e3cc02","user":{"login":"keghani","id":9949289,"avatar_url":"https://avatars.githubusercontent.com/u/9949289?v=3","gravatar_id":"","url":"https://api.github.com/users/keghani","html_url":"https://github.com/keghani","followers_url":"https://api.github.com/users/keghani/followers","following_url":"https://api.github.com/users/keghani/following{/other_user}","gists_url":"https://api.github.com/users/keghani/gists{/gist_id}","starred_url":"https://api.github.com/users/keghani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keghani/subscriptions","organizations_url":"https://api.github.com/users/keghani/orgs","repos_url":"https://api.github.com/users/keghani/repos","events_url":"https://api.github.com/users/keghani/events{/privacy}","received_events_url":"https://api.github.com/users/keghani/received_events","type":"User","site_admin":false},"repo":{"id":65822720,"name":"libphonenumber","full_name":"keghani/libphonenumber","owner":{"login":"keghani","id":9949289,"avatar_url":"https://avatars.githubusercontent.com/u/9949289?v=3","gravatar_id":"","url":"https://api.github.com/users/keghani","html_url":"https://github.com/keghani","followers_url":"https://api.github.com/users/keghani/followers","following_url":"https://api.github.com/users/keghani/following{/other_user}","gists_url":"https://api.github.com/users/keghani/gists{/gist_id}","starred_url":"https://api.github.com/users/keghani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keghani/subscriptions","organizations_url":"https://api.github.com/users/keghani/orgs","repos_url":"https://api.github.com/users/keghani/repos","events_url":"https://api.github.com/users/keghani/events{/privacy}","received_events_url":"https://api.github.com/users/keghani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keghani/libphonenumber","description":"Google's common Java, C++ and JavaScript library for parsing, formatting, and validating international phone numbers.","fork":true,"url":"https://api.github.com/repos/keghani/libphonenumber","forks_url":"https://api.github.com/repos/keghani/libphonenumber/forks","keys_url":"https://api.github.com/repos/keghani/libphonenumber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keghani/libphonenumber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keghani/libphonenumber/teams","hooks_url":"https://api.github.com/repos/keghani/libphonenumber/hooks","issue_events_url":"https://api.github.com/repos/keghani/libphonenumber/issues/events{/number}","events_url":"https://api.github.com/repos/keghani/libphonenumber/events","assignees_url":"https://api.github.com/repos/keghani/libphonenumber/assignees{/user}","branches_url":"https://api.github.com/repos/keghani/libphonenumber/branches{/branch}","tags_url":"https://api.github.com/repos/keghani/libphonenumber/tags","blobs_url":"https://api.github.com/repos/keghani/libphonenumber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keghani/libphonenumber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keghani/libphonenumber/git/refs{/sha}","trees_url":"https://api.github.com/repos/keghani/libphonenumber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keghani/libphonenumber/statuses/{sha}","languages_url":"https://api.github.com/repos/keghani/libphonenumber/languages","stargazers_url":"https://api.github.com/repos/keghani/libphonenumber/stargazers","contributors_url":"https://api.github.com/repos/keghani/libphonenumber/contributors","subscribers_url":"https://api.github.com/repos/keghani/libphonenumber/subscribers","subscription_url":"https://api.github.com/repos/keghani/libphonenumber/subscription","commits_url":"https://api.github.com/repos/keghani/libphonenumber/commits{/sha}","git_commits_url":"https://api.github.com/repos/keghani/libphonenumber/git/commits{/sha}","comments_url":"https://api.github.com/repos/keghani/libphonenumber/comments{/number}","issue_comment_url":"https://api.github.com/repos/keghani/libphonenumber/issues/comments{/number}","contents_url":"https://api.github.com/repos/keghani/libphonenumber/contents/{+path}","compare_url":"https://api.github.com/repos/keghani/libphonenumber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keghani/libphonenumber/merges","archive_url":"https://api.github.com/repos/keghani/libphonenumber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keghani/libphonenumber/downloads","issues_url":"https://api.github.com/repos/keghani/libphonenumber/issues{/number}","pulls_url":"https://api.github.com/repos/keghani/libphonenumber/pulls{/number}","milestones_url":"https://api.github.com/repos/keghani/libphonenumber/milestones{/number}","notifications_url":"https://api.github.com/repos/keghani/libphonenumber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keghani/libphonenumber/labels{/name}","releases_url":"https://api.github.com/repos/keghani/libphonenumber/releases{/id}","deployments_url":"https://api.github.com/repos/keghani/libphonenumber/deployments","created_at":"2016-08-16T13:29:27Z","updated_at":"2016-08-16T13:29:30Z","pushed_at":"2016-09-15T10:16:34Z","git_url":"git://github.com/keghani/libphonenumber.git","ssh_url":"git@github.com:keghani/libphonenumber.git","clone_url":"https://github.com/keghani/libphonenumber.git","svn_url":"https://github.com/keghani/libphonenumber","homepage":"","size":59529,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlei18n:7.7.0_candidate","ref":"7.7.0_candidate","sha":"0068d861a68d3d4612f7bf8646ab844dd3cefce5","user":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars.githubusercontent.com/u/5503833?v=3","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"repo":{"id":27500243,"name":"libphonenumber","full_name":"googlei18n/libphonenumber","owner":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars.githubusercontent.com/u/5503833?v=3","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlei18n/libphonenumber","description":"Google's common Java, C++ and JavaScript library for parsing, formatting, and validating international phone numbers.","fork":false,"url":"https://api.github.com/repos/googlei18n/libphonenumber","forks_url":"https://api.github.com/repos/googlei18n/libphonenumber/forks","keys_url":"https://api.github.com/repos/googlei18n/libphonenumber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlei18n/libphonenumber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlei18n/libphonenumber/teams","hooks_url":"https://api.github.com/repos/googlei18n/libphonenumber/hooks","issue_events_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues/events{/number}","events_url":"https://api.github.com/repos/googlei18n/libphonenumber/events","assignees_url":"https://api.github.com/repos/googlei18n/libphonenumber/assignees{/user}","branches_url":"https://api.github.com/repos/googlei18n/libphonenumber/branches{/branch}","tags_url":"https://api.github.com/repos/googlei18n/libphonenumber/tags","blobs_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlei18n/libphonenumber/statuses/{sha}","languages_url":"https://api.github.com/repos/googlei18n/libphonenumber/languages","stargazers_url":"https://api.github.com/repos/googlei18n/libphonenumber/stargazers","contributors_url":"https://api.github.com/repos/googlei18n/libphonenumber/contributors","subscribers_url":"https://api.github.com/repos/googlei18n/libphonenumber/subscribers","subscription_url":"https://api.github.com/repos/googlei18n/libphonenumber/subscription","commits_url":"https://api.github.com/repos/googlei18n/libphonenumber/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlei18n/libphonenumber/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlei18n/libphonenumber/contents/{+path}","compare_url":"https://api.github.com/repos/googlei18n/libphonenumber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlei18n/libphonenumber/merges","archive_url":"https://api.github.com/repos/googlei18n/libphonenumber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlei18n/libphonenumber/downloads","issues_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues{/number}","pulls_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls{/number}","milestones_url":"https://api.github.com/repos/googlei18n/libphonenumber/milestones{/number}","notifications_url":"https://api.github.com/repos/googlei18n/libphonenumber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlei18n/libphonenumber/labels{/name}","releases_url":"https://api.github.com/repos/googlei18n/libphonenumber/releases{/id}","deployments_url":"https://api.github.com/repos/googlei18n/libphonenumber/deployments","created_at":"2014-12-03T18:02:17Z","updated_at":"2016-09-15T05:23:31Z","pushed_at":"2016-09-15T10:24:54Z","git_url":"git://github.com/googlei18n/libphonenumber.git","ssh_url":"git@github.com:googlei18n/libphonenumber.git","clone_url":"https://github.com/googlei18n/libphonenumber.git","svn_url":"https://github.com/googlei18n/libphonenumber","homepage":"","size":71411,"stargazers_count":3996,"watchers_count":3996,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":496,"mirror_url":null,"open_issues_count":140,"forks":496,"open_issues":140,"watchers":3996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1339"},"html":{"href":"https://github.com/googlei18n/libphonenumber/pull/1339"},"issue":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/issues/1339"},"comments":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/issues/1339/comments"},"review_comments":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1339/comments"},"review_comment":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1339/commits"},"statuses":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/statuses/8f3cc46676070c4feae50ea6997bec1f58e3cc02"}}}}
{"actor":{"display_login":"keghani"}}