{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2164","repository_url":"https://api.github.com/repos/scikit-image/scikit-image","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2164/labels{/name}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2164/comments","events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2164/events","html_url":"https://github.com/scikit-image/scikit-image/pull/2164","id":161347356,"number":2164,"title":"fix region merging in `segmentation.felzenszwalb`","user":{"login":"mljli","id":7010007,"avatar_url":"https://avatars.githubusercontent.com/u/7010007?v=3","gravatar_id":"","url":"https://api.github.com/users/mljli","html_url":"https://github.com/mljli","followers_url":"https://api.github.com/users/mljli/followers","following_url":"https://api.github.com/users/mljli/following{/other_user}","gists_url":"https://api.github.com/users/mljli/gists{/gist_id}","starred_url":"https://api.github.com/users/mljli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mljli/subscriptions","organizations_url":"https://api.github.com/users/mljli/orgs","repos_url":"https://api.github.com/users/mljli/repos","events_url":"https://api.github.com/users/mljli/events{/privacy}","received_events_url":"https://api.github.com/users/mljli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scikit-image/scikit-image/labels/bug","name":"bug","color":"ea4041"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/scikit-image/scikit-image/milestones/6","html_url":"https://github.com/scikit-image/scikit-image/milestones/0.13","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/milestones/6/labels","id":1467848,"number":6,"title":"0.13","description":null,"creator":{"login":"ahojnnes","id":134307,"avatar_url":"https://avatars.githubusercontent.com/u/134307?v=3","gravatar_id":"","url":"https://api.github.com/users/ahojnnes","html_url":"https://github.com/ahojnnes","followers_url":"https://api.github.com/users/ahojnnes/followers","following_url":"https://api.github.com/users/ahojnnes/following{/other_user}","gists_url":"https://api.github.com/users/ahojnnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ahojnnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahojnnes/subscriptions","organizations_url":"https://api.github.com/users/ahojnnes/orgs","repos_url":"https://api.github.com/users/ahojnnes/repos","events_url":"https://api.github.com/users/ahojnnes/events{/privacy}","received_events_url":"https://api.github.com/users/ahojnnes/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":4,"state":"open","created_at":"2015-12-19T16:45:03Z","updated_at":"2016-06-21T05:11:44Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-06-21T04:30:28Z","updated_at":"2016-06-21T07:15:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2164","html_url":"https://github.com/scikit-image/scikit-image/pull/2164","diff_url":"https://github.com/scikit-image/scikit-image/pull/2164.diff","patch_url":"https://github.com/scikit-image/scikit-image/pull/2164.patch"},"body":"## Description\r\nOld implementation does not update the sizes of merged regions which causes small regions to be merged into only a few large regions. Fixed.\r\n\r\n## References\r\nFixes the issue discussed in #2134\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments/227359377","html_url":"https://github.com/scikit-image/scikit-image/pull/2164#issuecomment-227359377","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2164","id":227359377,"user":{"login":"mljli","id":7010007,"avatar_url":"https://avatars.githubusercontent.com/u/7010007?v=3","gravatar_id":"","url":"https://api.github.com/users/mljli","html_url":"https://github.com/mljli","followers_url":"https://api.github.com/users/mljli/followers","following_url":"https://api.github.com/users/mljli/following{/other_user}","gists_url":"https://api.github.com/users/mljli/gists{/gist_id}","starred_url":"https://api.github.com/users/mljli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mljli/subscriptions","organizations_url":"https://api.github.com/users/mljli/orgs","repos_url":"https://api.github.com/users/mljli/repos","events_url":"https://api.github.com/users/mljli/events{/privacy}","received_events_url":"https://api.github.com/users/mljli/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T07:15:50Z","updated_at":"2016-06-21T07:15:50Z","body":"@soupault  For the test, I think it's hard to say the result is good or not according to only the number of segments and the result may become different if future changes were applied. So there's no need to embed a reference result. A crafted test case should be enough.\r\n\r\nFor future work on this implementation, I'm afraid that there won't be too much room for improvement. It's almost the same with the reference (though could be closer if we copy the disjoint-set implementation). Also, being (mathematically) accurate in an image segmentation problem does not make too much sense. However, if you mean bug-free, I would like to help."}}
{"actor":{"display_login":"mljli"}}