{"action":"created","issue":{"url":"https://api.github.com/repos/hibri/HttpMock/issues/39","repository_url":"https://api.github.com/repos/hibri/HttpMock","labels_url":"https://api.github.com/repos/hibri/HttpMock/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/hibri/HttpMock/issues/39/comments","events_url":"https://api.github.com/repos/hibri/HttpMock/issues/39/events","html_url":"https://github.com/hibri/HttpMock/pull/39","id":165775012,"number":39,"title":"Assertion for query parameters","user":{"login":"miket969","id":1527807,"avatar_url":"https://avatars.githubusercontent.com/u/1527807?v=3","gravatar_id":"","url":"https://api.github.com/users/miket969","html_url":"https://github.com/miket969","followers_url":"https://api.github.com/users/miket969/followers","following_url":"https://api.github.com/users/miket969/following{/other_user}","gists_url":"https://api.github.com/users/miket969/gists{/gist_id}","starred_url":"https://api.github.com/users/miket969/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miket969/subscriptions","organizations_url":"https://api.github.com/users/miket969/orgs","repos_url":"https://api.github.com/users/miket969/repos","events_url":"https://api.github.com/users/miket969/events{/privacy}","received_events_url":"https://api.github.com/users/miket969/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-15T12:20:00Z","updated_at":"2016-07-19T08:47:37Z","closed_at":"2016-07-17T16:59:43Z","pull_request":{"url":"https://api.github.com/repos/hibri/HttpMock/pulls/39","html_url":"https://github.com/hibri/HttpMock/pull/39","diff_url":"https://github.com/hibri/HttpMock/pull/39.diff","patch_url":"https://github.com/hibri/HttpMock/pull/39.patch"},"body":"Hi, \r\n\r\nWe have been using your library here at Audionetwork for our integration tests and we found it hard to write tests that asserted the query parameters. If we added them to the string in the form of \"?a=b&c=d\" in the AssertWasCalled(), we got an error that the path was never stubbed because the RequestProcessor.FindHandler() did not parse the path to strip it from the query params. \r\n\r\nSo, instead of doing this parsing, we decided to treat the query params like the body and headers of the request. We added another RequestHandlerExpectExtensions method, the WithParams() to be called after the AssertWasCalled().\r\n\r\nPlease review the changes and let me know if you have any questions or remarks. Especially about _where_ I decided to put everything and if the test coverage is right. \r\n\r\nThank you,\r\nMichael Tomaras"},"comment":{"url":"https://api.github.com/repos/hibri/HttpMock/issues/comments/233569173","html_url":"https://github.com/hibri/HttpMock/pull/39#issuecomment-233569173","issue_url":"https://api.github.com/repos/hibri/HttpMock/issues/39","id":233569173,"user":{"login":"hibri","id":122442,"avatar_url":"https://avatars.githubusercontent.com/u/122442?v=3","gravatar_id":"","url":"https://api.github.com/users/hibri","html_url":"https://github.com/hibri","followers_url":"https://api.github.com/users/hibri/followers","following_url":"https://api.github.com/users/hibri/following{/other_user}","gists_url":"https://api.github.com/users/hibri/gists{/gist_id}","starred_url":"https://api.github.com/users/hibri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibri/subscriptions","organizations_url":"https://api.github.com/users/hibri/orgs","repos_url":"https://api.github.com/users/hibri/repos","events_url":"https://api.github.com/users/hibri/events{/privacy}","received_events_url":"https://api.github.com/users/hibri/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T08:47:37Z","updated_at":"2016-07-19T08:47:37Z","body":"@miket969 great. Let me know if you need help. Happy to pair with you on Skype. Feel free to email me at hibri at hibri dot net"}}
{"actor":{"display_login":"hibri"}}