{"action":"closed","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/6345","repository_url":"https://api.github.com/repos/sequelize/sequelize","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/6345/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/6345/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/6345/events","html_url":"https://github.com/sequelize/sequelize/issues/6345","id":168021063,"number":6345,"title":"Failing tests with MySQL 5.7","user":{"login":"Naoto-Ida","id":7748110,"avatar_url":"https://avatars.githubusercontent.com/u/7748110?v=3","gravatar_id":"","url":"https://api.github.com/users/Naoto-Ida","html_url":"https://github.com/Naoto-Ida","followers_url":"https://api.github.com/users/Naoto-Ida/followers","following_url":"https://api.github.com/users/Naoto-Ida/following{/other_user}","gists_url":"https://api.github.com/users/Naoto-Ida/gists{/gist_id}","starred_url":"https://api.github.com/users/Naoto-Ida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naoto-Ida/subscriptions","organizations_url":"https://api.github.com/users/Naoto-Ida/orgs","repos_url":"https://api.github.com/users/Naoto-Ida/repos","events_url":"https://api.github.com/users/Naoto-Ida/events{/privacy}","received_events_url":"https://api.github.com/users/Naoto-Ida/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sequelize/sequelize/labels/mysql","name":"mysql","color":"f7c6c7"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-28T06:16:43Z","updated_at":"2016-09-04T13:21:11Z","closed_at":"2016-09-04T13:21:11Z","body":"I am currently trying to solve #6307 and familiarize myself with the innards of the library, and have started to look into the code.\r\n\r\nThis is the first time I am dealing with tests, so would like to ask the contributors directly. I followed the instructions for contributing and ran `npm run test-mysql` in the sequelize directory.\r\n\r\nI have the following errors without any editing done to the current code.\r\n```\r\n1366 passing (2m)\r\n  2 pending\r\n  4 failing\r\n\r\n  1) [MYSQL] DataTypes allows me to return values from a custom parse function:\r\n     SequelizeDatabaseError: ER_TRUNCATED_WRONG_VALUE: Incorrect datetime value: '2011-10-30 15:00:00 +00:00' for column 'dateField' at row 1\r\n      at Query.formatError (lib/dialects/mysql/query.js:204:16)\r\n      at Query.connection.query [as _callback] (lib/dialects/mysql/query.js:56:23)\r\n      at Query.Sequence.end (node_modules/mysql/lib/protocol/sequences/Sequence.js:85:24)\r\n      at Query.ErrorPacket (node_modules/mysql/lib/protocol/sequences/Query.js:94:8)\r\n      at Protocol._parsePacket (node_modules/mysql/lib/protocol/Protocol.js:280:23)\r\n      at Parser.write (node_modules/mysql/lib/protocol/Parser.js:74:12)\r\n      at Protocol.write (node_modules/mysql/lib/protocol/Protocol.js:39:16)\r\n      at Socket.<anonymous> (node_modules/mysql/lib/Connection.js:109:28)\r\n      at readableAddChunk (_stream_readable.js:172:18)\r\n      at Socket.Readable.push (_stream_readable.js:130:10)\r\n      at TCP.onread (net.js:542:20)\r\n  From previous event:\r\n      at Query.run (lib/dialects/mysql/query.js:44:12)\r\n      at retry (lib/sequelize.js:635:32)\r\n      at node_modules/retry-as-promised/index.js:38:21\r\n      at retryAsPromised (node_modules/retry-as-promised/index.js:27:10)\r\n      at Promise.resolve.then.connection (lib/sequelize.js:635:14)\r\n  From previous event:\r\n      at Promise.then (lib/promise.js:21:17)\r\n      at Context.<anonymous> (test/integration/data-types.test.js:65:42)\r\n\r\n  2) [MYSQL] DataTypes should parse an empty GEOMETRY field:\r\n     SequelizeDatabaseError: UNKNOWN_CODE_PLEASE_REPORT: Invalid GIS data provided to function st_geometryfromtext.\r\n      at Query.formatError (lib/dialects/mysql/query.js:204:16)\r\n      at Query.connection.query [as _callback] (lib/dialects/mysql/query.js:56:23)\r\n      at Query.Sequence.end (node_modules/mysql/lib/protocol/sequences/Sequence.js:85:24)\r\n      at Query.ErrorPacket (node_modules/mysql/lib/protocol/sequences/Query.js:94:8)\r\n      at Protocol._parsePacket (node_modules/mysql/lib/protocol/Protocol.js:280:23)\r\n      at Parser.write (node_modules/mysql/lib/protocol/Parser.js:74:12)\r\n      at Protocol.write (node_modules/mysql/lib/protocol/Protocol.js:39:16)\r\n      at Socket.<anonymous> (node_modules/mysql/lib/Connection.js:109:28)\r\n      at readableAddChunk (_stream_readable.js:172:18)\r\n      at Socket.Readable.push (_stream_readable.js:130:10)\r\n      at TCP.onread (net.js:542:20)\r\n  From previous event:\r\n      at Query.run (lib/dialects/mysql/query.js:44:12)\r\n      at retry (lib/sequelize.js:635:32)\r\n      at node_modules/retry-as-promised/index.js:38:21\r\n      at retryAsPromised (node_modules/retry-as-promised/index.js:27:10)\r\n      at Promise.resolve.then.connection (lib/sequelize.js:635:14)\r\n  From previous event:\r\n      at Promise.then (lib/promise.js:21:17)\r\n      at Context.<anonymous> (test/integration/data-types.test.js:286:43)\r\n\r\n  3) [MYSQL] Model sql injection attacks should properly escape the single quotes in coordinates:\r\n     SequelizeDatabaseError: UNKNOWN_CODE_PLEASE_REPORT: Invalid GIS data provided to function st_geometryfromtext.\r\n      at Query.formatError (lib/dialects/mysql/query.js:204:16)\r\n      at Query.connection.query [as _callback] (lib/dialects/mysql/query.js:56:23)\r\n      at Query.Sequence.end (node_modules/mysql/lib/protocol/sequences/Sequence.js:85:24)\r\n      at Query.ErrorPacket (node_modules/mysql/lib/protocol/sequences/Query.js:94:8)\r\n      at Protocol._parsePacket (node_modules/mysql/lib/protocol/Protocol.js:280:23)\r\n      at Parser.write (node_modules/mysql/lib/protocol/Parser.js:74:12)\r\n      at Protocol.write (node_modules/mysql/lib/protocol/Protocol.js:39:16)\r\n      at Socket.<anonymous> (node_modules/mysql/lib/Connection.js:109:28)\r\n      at readableAddChunk (_stream_readable.js:172:18)\r\n      at Socket.Readable.push (_stream_readable.js:130:10)\r\n      at TCP.onread (net.js:542:20)\r\n  From previous event:\r\n      at Query.run (lib/dialects/mysql/query.js:44:12)\r\n      at retry (lib/sequelize.js:635:32)\r\n      at node_modules/retry-as-promised/index.js:38:21\r\n      at retryAsPromised (node_modules/retry-as-promised/index.js:27:10)\r\n      at Promise.resolve.then.connection (lib/sequelize.js:635:14)\r\n  From previous event:\r\n      at Promise.then (lib/promise.js:21:17)\r\n\r\n  4) [MYSQL] Sequelize query logging logs warnings when there are warnings:\r\n     SequelizeDatabaseError: ER_TRUNCATED_WRONG_VALUE: Incorrect datetime value: 'HORSE' for column 'createdAt' at row 1\r\n      at Query.formatError (lib/dialects/mysql/query.js:204:16)\r\n      at Query.connection.query [as _callback] (lib/dialects/mysql/query.js:56:23)\r\n      at Query.Sequence.end (node_modules/mysql/lib/protocol/sequences/Sequence.js:85:24)\r\n      at Query.ErrorPacket (node_modules/mysql/lib/protocol/sequences/Query.js:94:8)\r\n      at Protocol._parsePacket (node_modules/mysql/lib/protocol/Protocol.js:280:23)\r\n      at Parser.write (node_modules/mysql/lib/protocol/Parser.js:74:12)\r\n      at Protocol.write (node_modules/mysql/lib/protocol/Protocol.js:39:16)\r\n      at Socket.<anonymous> (node_modules/mysql/lib/Connection.js:109:28)\r\n      at readableAddChunk (_stream_readable.js:172:18)\r\n      at Socket.Readable.push (_stream_readable.js:130:10)\r\n      at TCP.onread (net.js:542:20)\r\n      at TCP.onread (node_modules/async-listener/glue.js:188:31)\r\n  From previous event:\r\n      at Query.run (lib/dialects/mysql/query.js:44:12)\r\n      at retry (lib/sequelize.js:635:32)\r\n      at node_modules/retry-as-promised/index.js:38:21\r\n      at retryAsPromised (node_modules/retry-as-promised/index.js:27:10)\r\n      at Promise.resolve.then.connection (lib/sequelize.js:635:14)\r\n  From previous event:\r\n      at Promise.then (lib/promise.js:21:17)\r\n      at Sequelize.query (lib/sequelize.js:632:7)\r\n      at Context.<anonymous> (test/integration/sequelize.test.js:281:28)\r\n```\r\n\r\nIs this expected? I want to progress with figuring out how to solve the aforementioned issue, but not sure if I should progress from here."}}
{"actor":{"display_login":"mickhansen"}}