{"action":"created","issue":{"url":"https://api.github.com/repos/swoole/swoole-src/issues/969","repository_url":"https://api.github.com/repos/swoole/swoole-src","labels_url":"https://api.github.com/repos/swoole/swoole-src/issues/969/labels{/name}","comments_url":"https://api.github.com/repos/swoole/swoole-src/issues/969/comments","events_url":"https://api.github.com/repos/swoole/swoole-src/issues/969/events","html_url":"https://github.com/swoole/swoole-src/issues/969","id":197326872,"number":969,"title":"RFC: Code Change process need clarify: Post RFC first . then make PR ,no direct change code please!!","user":{"login":"netroby","id":278153,"avatar_url":"https://avatars.githubusercontent.com/u/278153?v=3","gravatar_id":"","url":"https://api.github.com/users/netroby","html_url":"https://github.com/netroby","followers_url":"https://api.github.com/users/netroby/followers","following_url":"https://api.github.com/users/netroby/following{/other_user}","gists_url":"https://api.github.com/users/netroby/gists{/gist_id}","starred_url":"https://api.github.com/users/netroby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netroby/subscriptions","organizations_url":"https://api.github.com/users/netroby/orgs","repos_url":"https://api.github.com/users/netroby/repos","events_url":"https://api.github.com/users/netroby/events{/privacy}","received_events_url":"https://api.github.com/users/netroby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-23T07:54:04Z","updated_at":"2016-12-23T08:18:32Z","closed_at":null,"body":"Code Change process need clarify: Post RFC first . then make PR ,no direct change code please!!\r\n\r\n## Problem\r\n\r\nThe easy change code. the easy to import bugs with code.\r\n\r\n## Tuning\r\n\r\nWe need to clarify how code can be changed.\r\n\r\n1. Need post RFC to discuss what change will make . like ( Tuning the memory usage of the connections pool)\r\n2. Need send PR, not just push code change to master branch\r\n3. The PR need reviewed by at least 2 developer?\r\n4. Merge request. then close issue and PR?\r\n5. The change already put in master branch.\r\n\r\n## Benefit\r\n\r\nThe right process will make swoole more stable and more robust. \r\n\r\nThe current change very unstable. not like to see the working like this kind(direct change code base)"},"comment":{"url":"https://api.github.com/repos/swoole/swoole-src/issues/comments/268955130","html_url":"https://github.com/swoole/swoole-src/issues/969#issuecomment-268955130","issue_url":"https://api.github.com/repos/swoole/swoole-src/issues/969","id":268955130,"user":{"login":"netroby","id":278153,"avatar_url":"https://avatars.githubusercontent.com/u/278153?v=3","gravatar_id":"","url":"https://api.github.com/users/netroby","html_url":"https://github.com/netroby","followers_url":"https://api.github.com/users/netroby/followers","following_url":"https://api.github.com/users/netroby/following{/other_user}","gists_url":"https://api.github.com/users/netroby/gists{/gist_id}","starred_url":"https://api.github.com/users/netroby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netroby/subscriptions","organizations_url":"https://api.github.com/users/netroby/orgs","repos_url":"https://api.github.com/users/netroby/repos","events_url":"https://api.github.com/users/netroby/events{/privacy}","received_events_url":"https://api.github.com/users/netroby/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T08:18:32Z","updated_at":"2016-12-23T08:18:32Z","body":"yeah . i am looking for how to improve it. from the RFC / PR progress . \r\nAs a temp resolution. Can we create an testing branch, to rapid commit your unstable code. \r\nThen go RFC->PR->Review->Merge to master branch?\r\n\r\nThe current way direct commit code to master. seems not very stable .. and may be a bit dangerous?"}}
{"actor":{"display_login":"netroby"}}