{"action":"closed","number":3793,"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/3793","id":68144381,"html_url":"https://github.com/chapel-lang/chapel/pull/3793","diff_url":"https://github.com/chapel-lang/chapel/pull/3793.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/3793.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/3793","number":3793,"state":"closed","locked":false,"title":"Minor vararg-related fixes in compiler","user":{"login":"vasslitvinov","id":8039635,"avatar_url":"https://avatars.githubusercontent.com/u/8039635?v=3","gravatar_id":"","url":"https://api.github.com/users/vasslitvinov","html_url":"https://github.com/vasslitvinov","followers_url":"https://api.github.com/users/vasslitvinov/followers","following_url":"https://api.github.com/users/vasslitvinov/following{/other_user}","gists_url":"https://api.github.com/users/vasslitvinov/gists{/gist_id}","starred_url":"https://api.github.com/users/vasslitvinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasslitvinov/subscriptions","organizations_url":"https://api.github.com/users/vasslitvinov/orgs","repos_url":"https://api.github.com/users/vasslitvinov/repos","events_url":"https://api.github.com/users/vasslitvinov/events{/privacy}","received_events_url":"https://api.github.com/users/vasslitvinov/received_events","type":"User","site_admin":false},"body":"* Replace explicit calls to 'delete' etc. on AST nodes\r\n(inserted by a collaborator)\r\nwith the standard node->replace().\r\n\r\n* Added a comment on FnSymbol::variableExpr field.\r\nTaken from compilerOverview.pdf.\r\n\r\n* All code in handleSymExprInExpandVarArgs() is gated by two conditionals.\r\nI verified and documented, using INT_FATAL, that the inner conditional\r\nalways fires.\r\nAlso documented when the outer condition may be false.\r\nThis was illustrated by this one test in our suite:\r\n\r\n  test/functions/deitz/varargs/test_varargs3.chpl\r\n\r\n* Moved \"newFn->partialCopySource = this;\"\r\nfrom copyInnerCore() to partialCopy() - for clarity:\r\ndo not do it where it is not needed.\r\n\r\nPasses full linux64 test suite.","created_at":"2016-04-27T23:57:08Z","updated_at":"2016-04-28T20:05:56Z","closed_at":"2016-04-28T20:05:56Z","merged_at":"2016-04-28T20:05:56Z","merge_commit_sha":"5d661fe687695e25c161d34187f3c8c1ccbe1d0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/3793/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/3793/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/3793/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/10aa43908eb5cb7e53150bfc9c6a798781b80c16","head":{"label":"vasslitvinov:minor-vararg-fixes","ref":"minor-vararg-fixes","sha":"10aa43908eb5cb7e53150bfc9c6a798781b80c16","user":{"login":"vasslitvinov","id":8039635,"avatar_url":"https://avatars.githubusercontent.com/u/8039635?v=3","gravatar_id":"","url":"https://api.github.com/users/vasslitvinov","html_url":"https://github.com/vasslitvinov","followers_url":"https://api.github.com/users/vasslitvinov/followers","following_url":"https://api.github.com/users/vasslitvinov/following{/other_user}","gists_url":"https://api.github.com/users/vasslitvinov/gists{/gist_id}","starred_url":"https://api.github.com/users/vasslitvinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasslitvinov/subscriptions","organizations_url":"https://api.github.com/users/vasslitvinov/orgs","repos_url":"https://api.github.com/users/vasslitvinov/repos","events_url":"https://api.github.com/users/vasslitvinov/events{/privacy}","received_events_url":"https://api.github.com/users/vasslitvinov/received_events","type":"User","site_admin":false},"repo":{"id":21914674,"name":"chapel","full_name":"vasslitvinov/chapel","owner":{"login":"vasslitvinov","id":8039635,"avatar_url":"https://avatars.githubusercontent.com/u/8039635?v=3","gravatar_id":"","url":"https://api.github.com/users/vasslitvinov","html_url":"https://github.com/vasslitvinov","followers_url":"https://api.github.com/users/vasslitvinov/followers","following_url":"https://api.github.com/users/vasslitvinov/following{/other_user}","gists_url":"https://api.github.com/users/vasslitvinov/gists{/gist_id}","starred_url":"https://api.github.com/users/vasslitvinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasslitvinov/subscriptions","organizations_url":"https://api.github.com/users/vasslitvinov/orgs","repos_url":"https://api.github.com/users/vasslitvinov/repos","events_url":"https://api.github.com/users/vasslitvinov/events{/privacy}","received_events_url":"https://api.github.com/users/vasslitvinov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vasslitvinov/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/vasslitvinov/chapel","forks_url":"https://api.github.com/repos/vasslitvinov/chapel/forks","keys_url":"https://api.github.com/repos/vasslitvinov/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vasslitvinov/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vasslitvinov/chapel/teams","hooks_url":"https://api.github.com/repos/vasslitvinov/chapel/hooks","issue_events_url":"https://api.github.com/repos/vasslitvinov/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/vasslitvinov/chapel/events","assignees_url":"https://api.github.com/repos/vasslitvinov/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/vasslitvinov/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/vasslitvinov/chapel/tags","blobs_url":"https://api.github.com/repos/vasslitvinov/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vasslitvinov/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vasslitvinov/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/vasslitvinov/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vasslitvinov/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/vasslitvinov/chapel/languages","stargazers_url":"https://api.github.com/repos/vasslitvinov/chapel/stargazers","contributors_url":"https://api.github.com/repos/vasslitvinov/chapel/contributors","subscribers_url":"https://api.github.com/repos/vasslitvinov/chapel/subscribers","subscription_url":"https://api.github.com/repos/vasslitvinov/chapel/subscription","commits_url":"https://api.github.com/repos/vasslitvinov/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/vasslitvinov/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/vasslitvinov/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/vasslitvinov/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/vasslitvinov/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/vasslitvinov/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vasslitvinov/chapel/merges","archive_url":"https://api.github.com/repos/vasslitvinov/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vasslitvinov/chapel/downloads","issues_url":"https://api.github.com/repos/vasslitvinov/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/vasslitvinov/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/vasslitvinov/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/vasslitvinov/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vasslitvinov/chapel/labels{/name}","releases_url":"https://api.github.com/repos/vasslitvinov/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/vasslitvinov/chapel/deployments","created_at":"2014-07-16T19:46:44Z","updated_at":"2016-03-08T21:35:20Z","pushed_at":"2016-04-27T23:55:48Z","git_url":"git://github.com/vasslitvinov/chapel.git","ssh_url":"git@github.com:vasslitvinov/chapel.git","clone_url":"https://github.com/vasslitvinov/chapel.git","svn_url":"https://github.com/vasslitvinov/chapel","homepage":"http://chapel.cray.com/","size":357678,"stargazers_count":1,"watchers_count":1,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"1afa0b24d9296482cd2831f55ff31cae3886214d","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2016-04-28T13:03:00Z","pushed_at":"2016-04-28T20:05:56Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":467820,"stargazers_count":256,"watchers_count":256,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":12,"forks":100,"open_issues":12,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/3793"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/3793"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/3793"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/3793/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/3793/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/3793/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/10aa43908eb5cb7e53150bfc9c6a798781b80c16"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vasslitvinov","id":8039635,"avatar_url":"https://avatars.githubusercontent.com/u/8039635?v=3","gravatar_id":"","url":"https://api.github.com/users/vasslitvinov","html_url":"https://github.com/vasslitvinov","followers_url":"https://api.github.com/users/vasslitvinov/followers","following_url":"https://api.github.com/users/vasslitvinov/following{/other_user}","gists_url":"https://api.github.com/users/vasslitvinov/gists{/gist_id}","starred_url":"https://api.github.com/users/vasslitvinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasslitvinov/subscriptions","organizations_url":"https://api.github.com/users/vasslitvinov/orgs","repos_url":"https://api.github.com/users/vasslitvinov/repos","events_url":"https://api.github.com/users/vasslitvinov/events{/privacy}","received_events_url":"https://api.github.com/users/vasslitvinov/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":13,"deletions":13,"changed_files":3}}