{"action":"created","issue":{"url":"https://api.github.com/repos/mavlink/mavlink/issues/570","repository_url":"https://api.github.com/repos/mavlink/mavlink","labels_url":"https://api.github.com/repos/mavlink/mavlink/issues/570/labels{/name}","comments_url":"https://api.github.com/repos/mavlink/mavlink/issues/570/comments","events_url":"https://api.github.com/repos/mavlink/mavlink/issues/570/events","html_url":"https://github.com/mavlink/mavlink/issues/570","id":159821842,"number":570,"title":"common.xml message with id 256","user":{"login":"dsuarezv","id":220631,"avatar_url":"https://avatars.githubusercontent.com/u/220631?v=3","gravatar_id":"","url":"https://api.github.com/users/dsuarezv","html_url":"https://github.com/dsuarezv","followers_url":"https://api.github.com/users/dsuarezv/followers","following_url":"https://api.github.com/users/dsuarezv/following{/other_user}","gists_url":"https://api.github.com/users/dsuarezv/gists{/gist_id}","starred_url":"https://api.github.com/users/dsuarezv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsuarezv/subscriptions","organizations_url":"https://api.github.com/users/dsuarezv/orgs","repos_url":"https://api.github.com/users/dsuarezv/repos","events_url":"https://api.github.com/users/dsuarezv/events{/privacy}","received_events_url":"https://api.github.com/users/dsuarezv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-12T11:02:05Z","updated_at":"2016-06-13T08:43:47Z","closed_at":null,"body":"Hi, a recent commit (184893c0b9f6d95a05d4af29a809762e4614a224) has introduced a new message in common.xml with id 256. \r\n\r\nI understand that the message id field is supposed to be a byte, at least in http://qgroundcontrol.org/mavlink/create_new_mavlink_message, it says \r\n\r\n> id=“0” means this message has the id / index number zero. \r\n> Valid numbers range from 0 to 255, with ids 150-240 being reserved for extensions (so you will want to use the 150-240 range for your personal messages)\r\n\r\nIs this a mistake or rules have changed regarding the message id field? "},"comment":{"url":"https://api.github.com/repos/mavlink/mavlink/issues/comments/225521481","html_url":"https://github.com/mavlink/mavlink/issues/570#issuecomment-225521481","issue_url":"https://api.github.com/repos/mavlink/mavlink/issues/570","id":225521481,"user":{"login":"magicrub","id":4782875,"avatar_url":"https://avatars.githubusercontent.com/u/4782875?v=3","gravatar_id":"","url":"https://api.github.com/users/magicrub","html_url":"https://github.com/magicrub","followers_url":"https://api.github.com/users/magicrub/followers","following_url":"https://api.github.com/users/magicrub/following{/other_user}","gists_url":"https://api.github.com/users/magicrub/gists{/gist_id}","starred_url":"https://api.github.com/users/magicrub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicrub/subscriptions","organizations_url":"https://api.github.com/users/magicrub/orgs","repos_url":"https://api.github.com/users/magicrub/repos","events_url":"https://api.github.com/users/magicrub/events{/privacy}","received_events_url":"https://api.github.com/users/magicrub/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T08:43:47Z","updated_at":"2016-06-13T08:43:47Z","body":"I would think so.\n\nOn Mon, Jun 13, 2016 at 1:39 AM, David Suarez <notifications@github.com>\nwrote:\n\n> Actually I'm a developer of https://github.com/dsuarezv/mavlink.net, it's\n> another generator for C#, so we only use the xml files to generate a\n> different set of classes.\n>\n> Am I right thinking the proper way to handle this in a V1 generator would\n> be to simply ignore messages with id > 255?\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/mavlink/mavlink/issues/570#issuecomment-225520459>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AEj7G9LeRVp7X7bX5dBzvlGRTrf0kKp3ks5qLRctgaJpZM4IzxDo>\n> .\n>\n"}}
{"actor":{"display_login":"magicrub"}}