{"action":"created","issue":{"url":"https://api.github.com/repos/Winael/snappy-playpen-1/issues/1","repository_url":"https://api.github.com/repos/Winael/snappy-playpen-1","labels_url":"https://api.github.com/repos/Winael/snappy-playpen-1/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Winael/snappy-playpen-1/issues/1/comments","events_url":"https://api.github.com/repos/Winael/snappy-playpen-1/issues/1/events","html_url":"https://github.com/Winael/snappy-playpen-1/pull/1","id":159056317,"number":1,"title":"Build etherpad-lite snap","user":{"login":"dplanella","id":1689781,"avatar_url":"https://avatars.githubusercontent.com/u/1689781?v=3","gravatar_id":"","url":"https://api.github.com/users/dplanella","html_url":"https://github.com/dplanella","followers_url":"https://api.github.com/users/dplanella/followers","following_url":"https://api.github.com/users/dplanella/following{/other_user}","gists_url":"https://api.github.com/users/dplanella/gists{/gist_id}","starred_url":"https://api.github.com/users/dplanella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dplanella/subscriptions","organizations_url":"https://api.github.com/users/dplanella/orgs","repos_url":"https://api.github.com/users/dplanella/repos","events_url":"https://api.github.com/users/dplanella/events{/privacy}","received_events_url":"https://api.github.com/users/dplanella/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-06-08T00:46:29Z","updated_at":"2016-06-08T13:18:53Z","closed_at":"2016-06-08T09:43:33Z","pull_request":{"url":"https://api.github.com/repos/Winael/snappy-playpen-1/pulls/1","html_url":"https://github.com/Winael/snappy-playpen-1/pull/1","diff_url":"https://github.com/Winael/snappy-playpen-1/pull/1.diff","patch_url":"https://github.com/Winael/snappy-playpen-1/pull/1.patch"},"body":"The snap now builds correctly, seemingly including all files.\r\n\r\nHowever, the server does not seem to start (or at least http://127.0.0.1:9001/ is not accessible).\r\n\r\nNotes:\r\n- I had been looking at @asac's original [etherpad-lite snap](https://github.com/asac/etherpad-lite), which I've changed and adapted to the current snapcraft.yaml syntax\r\n- He actually forked the upstream repo with [two changes](https://github.com/asac/etherpad-lite/commit/21a772999f35b3026b56acd8ef45e6c2bc92dd61):\r\n  - The first one is no longer necessary in this pull request\r\n  - The second one I *think* is not necessary either"},"comment":{"url":"https://api.github.com/repos/Winael/snappy-playpen-1/issues/comments/224585857","html_url":"https://github.com/Winael/snappy-playpen-1/pull/1#issuecomment-224585857","issue_url":"https://api.github.com/repos/Winael/snappy-playpen-1/issues/1","id":224585857,"user":{"login":"asac","id":2370210,"avatar_url":"https://avatars.githubusercontent.com/u/2370210?v=3","gravatar_id":"","url":"https://api.github.com/users/asac","html_url":"https://github.com/asac","followers_url":"https://api.github.com/users/asac/followers","following_url":"https://api.github.com/users/asac/following{/other_user}","gists_url":"https://api.github.com/users/asac/gists{/gist_id}","starred_url":"https://api.github.com/users/asac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asac/subscriptions","organizations_url":"https://api.github.com/users/asac/orgs","repos_url":"https://api.github.com/users/asac/repos","events_url":"https://api.github.com/users/asac/events{/privacy}","received_events_url":"https://api.github.com/users/asac/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T13:18:53Z","updated_at":"2016-06-08T13:18:53Z","body":"and fix bin/snappy/runpad to use the new SNAP variables...\n\n2016-06-08 15:17 GMT+02:00 Alexander Sack <asacasa@gmail.com>:\n\n> i would just work on top of that branch... and fix the yamnl to be 2.x\n> compatible...\n>\n> 2016-06-08 15:17 GMT+02:00 Alexander Sack <asacasa@gmail.com>:\n>\n>> Key commits are:\n>>\n>>\n>> https://github.com/asac/etherpad-lite/commit/d3e12b31e4542eb637b33f2fbbad265d7116e38f\n>>\n>> https://github.com/asac/etherpad-lite/commit/8e62911cb2f6be278f70d11c2dc8492e22782f2a\n>>\n>> 2016-06-08 15:15 GMT+02:00 Alexander Sack <asacasa@gmail.com>:\n>>\n>>> Hi,\n>>>\n>>> have you checked the real branch?\n>>> https://github.com/asac/etherpad-lite/commits/snap-support\n>>>\n>>> 2016-06-08 14:07 GMT+02:00 David Planella <notifications@github.com>:\n>>>\n>>>> @asac <https://github.com/asac>: thanks for the comments! Here is some\n>>>> more context on the original post:\n>>>>\n>>>>    - The first change to the upstream code (settings.js) is no longer\n>>>>    needed as this branch does not copy over the settings.json.template\n>>>>    file but defines a new one. The upstream .template file cannot be used as\n>>>>    it is due to it hardcoding the database location to /var, which snaps have\n>>>>    no access to.\n>>>>    - The second change to the upstream code I couldn't quite follow,\n>>>>    but it seems that using the nodejs plugin as it is today already takes care\n>>>>    of installing everything in the right locations.\n>>>>\n>>>> In any case, the current failure to run is due to etherpad trying to\n>>>> write to a R/O location:\n>>>>\n>>>> + cd /var/snap/etherpad-lite-unofficial/100001\n>>>> + exec /snap/etherpad-lite-unofficial/100001/bin/etherpad-lite --settings /snap/etherpad-lite-unofficial/100001/etc/settings.json\n>>>> [2016-06-08 14:04:54.765] [WARN] console - DirtyDB is used. This is fine for testing but not recommended for production.\n>>>> [2016-06-08 14:04:56.998] [ERROR] console - Failed to load '/snap/etherpad-lite-unofficial/100001/lib/node_modules/ep_etherpad-lite/node/hooks/express/static:expressCreateServer' for 'ep_etherpad-lite/static/hooks/expressCreateServer': Error: ENOENT: no such file or directory, stat '/snap/etherpad-lite-unofficial/100001/lib/var/'\n>>>>\n>>>> As per the snapcraft config ownership, I think we all agree that\n>>>> eventually it should be upstream's. But regardless of where development is\n>>>> going on, the first step is to get the snap working again :)\n>>>>\n>>>> —\n>>>> You are receiving this because you were mentioned.\n>>>> Reply to this email directly, view it on GitHub\n>>>> <https://github.com/Winael/snappy-playpen-1/pull/1#issuecomment-224569720>,\n>>>> or mute the thread\n>>>> <https://github.com/notifications/unsubscribe/ACQqoj6cA4mgqsvVAibdPF6LhtTXV-6Zks5qJrCHgaJpZM4Iwfx6>\n>>>> .\n>>>>\n>>>\n>>>\n>>\n>\n"}}
{"actor":{"display_login":"asac"}}