{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/78508945","id":78508945,"diff_hunk":"@@ -210,6 +214,11 @@ func (d *DockerBuilder) addBuildParameters(dir string) error {\n \tinstructions := dockerfile.ParseTreeToDockerfile(node)\n \n \t// Overwrite the Dockerfile.\n+\tf, err := os.Open(dockerfilePath)","path":"pkg/build/builder/docker.go","position":64,"original_position":64,"commit_id":"06a88f40e8b4911c0730252c96502ffef4eec747","original_commit_id":"06a88f40e8b4911c0730252c96502ffef4eec747","user":{"login":"wanghaoran1988","id":13621088,"avatar_url":"https://avatars.githubusercontent.com/u/13621088?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaoran1988","html_url":"https://github.com/wanghaoran1988","followers_url":"https://api.github.com/users/wanghaoran1988/followers","following_url":"https://api.github.com/users/wanghaoran1988/following{/other_user}","gists_url":"https://api.github.com/users/wanghaoran1988/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaoran1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaoran1988/subscriptions","organizations_url":"https://api.github.com/users/wanghaoran1988/orgs","repos_url":"https://api.github.com/users/wanghaoran1988/repos","events_url":"https://api.github.com/users/wanghaoran1988/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaoran1988/received_events","type":"User","site_admin":false},"body":"the `fi.Mode()` of this file will be used in the last line of the method, any way to get the fileMode without open the file ?","created_at":"2016-09-13T07:30:18Z","updated_at":"2016-09-13T07:30:18Z","html_url":"https://github.com/openshift/origin/pull/10873#discussion_r78508945","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/10873","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/78508945"},"html":{"href":"https://github.com/openshift/origin/pull/10873#discussion_r78508945"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/10873"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10873","id":84779956,"html_url":"https://github.com/openshift/origin/pull/10873","diff_url":"https://github.com/openshift/origin/pull/10873.diff","patch_url":"https://github.com/openshift/origin/pull/10873.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/10873","number":10873,"state":"open","locked":false,"title":"Explicit pull the docker base image for docker build","user":{"login":"wanghaoran1988","id":13621088,"avatar_url":"https://avatars.githubusercontent.com/u/13621088?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaoran1988","html_url":"https://github.com/wanghaoran1988","followers_url":"https://api.github.com/users/wanghaoran1988/followers","following_url":"https://api.github.com/users/wanghaoran1988/following{/other_user}","gists_url":"https://api.github.com/users/wanghaoran1988/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaoran1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaoran1988/subscriptions","organizations_url":"https://api.github.com/users/wanghaoran1988/orgs","repos_url":"https://api.github.com/users/wanghaoran1988/repos","events_url":"https://api.github.com/users/wanghaoran1988/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaoran1988/received_events","type":"User","site_admin":false},"body":"To address this [trello card](https://trello.com/c/Pzhdtv0I/1025-explicit-pull-of-base-image-for-docker-builds), and this is the build log now:\r\n[root@ip-172-18-15-120 docker-builder]# oc start-build ruby-hello-world\r\nbuild \"ruby-hello-world-7\" started\r\n[root@ip-172-18-15-120 docker-builder]# oc logs -f build/ruby-hello-world-7\r\nCloning \"https://github.com/openshift/ruby-hello-world\" ...\r\n\tCommit:\te79d8870be808a7abb4ab304e94c8bee69d909c6 (Merge pull request #53 from danmcp/master)\r\n\tAuthor:\tBen Parees <bparees@users.noreply.github.com>\r\n\tDate:\tTue Apr 5 10:06:50 2016 -0400\r\nPulling image registry.access.redhat.com/rhscl/ruby-22-rhel7@sha256:733b79c6addd6b25dc0c2527196a4d921ca255961eae294be62806a0d2c94202 ...\r\nPulled 0/3 layers, 2% complete\r\nPulled 1/3 layers, 41% complete\r\nPulled 2/3 layers, 95% complete\r\nPulled 3/3 layers, 100% complete\r\nExtracting\r\nStep 1 : FROM registry.access.redhat.com/rhscl/ruby-22-rhel7@sha256:733b79c6addd6b25dc0c2527196a4d921ca255961eae294be62806a0d2c94202\r\n ---> c5b8ac088a6c\r\nStep 2 : USER default\r\n ---> Running in b5cf641a162c\r\n ---> 48e5fa8b42a1\r\nRemoving intermediate container b5cf641a162c\r\n","created_at":"2016-09-11T08:00:20Z","updated_at":"2016-09-13T07:30:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d9e7aa7a165fcc01819bbc040078bcb995742d4","assignee":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"assignees":[{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/10873/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/10873/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10873/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/06a88f40e8b4911c0730252c96502ffef4eec747","head":{"label":"wanghaoran1988:explicit_pull_docker_image","ref":"explicit_pull_docker_image","sha":"06a88f40e8b4911c0730252c96502ffef4eec747","user":{"login":"wanghaoran1988","id":13621088,"avatar_url":"https://avatars.githubusercontent.com/u/13621088?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaoran1988","html_url":"https://github.com/wanghaoran1988","followers_url":"https://api.github.com/users/wanghaoran1988/followers","following_url":"https://api.github.com/users/wanghaoran1988/following{/other_user}","gists_url":"https://api.github.com/users/wanghaoran1988/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaoran1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaoran1988/subscriptions","organizations_url":"https://api.github.com/users/wanghaoran1988/orgs","repos_url":"https://api.github.com/users/wanghaoran1988/repos","events_url":"https://api.github.com/users/wanghaoran1988/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaoran1988/received_events","type":"User","site_admin":false},"repo":{"id":42173515,"name":"origin","full_name":"wanghaoran1988/origin","owner":{"login":"wanghaoran1988","id":13621088,"avatar_url":"https://avatars.githubusercontent.com/u/13621088?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaoran1988","html_url":"https://github.com/wanghaoran1988","followers_url":"https://api.github.com/users/wanghaoran1988/followers","following_url":"https://api.github.com/users/wanghaoran1988/following{/other_user}","gists_url":"https://api.github.com/users/wanghaoran1988/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaoran1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaoran1988/subscriptions","organizations_url":"https://api.github.com/users/wanghaoran1988/orgs","repos_url":"https://api.github.com/users/wanghaoran1988/repos","events_url":"https://api.github.com/users/wanghaoran1988/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaoran1988/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wanghaoran1988/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/wanghaoran1988/origin","forks_url":"https://api.github.com/repos/wanghaoran1988/origin/forks","keys_url":"https://api.github.com/repos/wanghaoran1988/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wanghaoran1988/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wanghaoran1988/origin/teams","hooks_url":"https://api.github.com/repos/wanghaoran1988/origin/hooks","issue_events_url":"https://api.github.com/repos/wanghaoran1988/origin/issues/events{/number}","events_url":"https://api.github.com/repos/wanghaoran1988/origin/events","assignees_url":"https://api.github.com/repos/wanghaoran1988/origin/assignees{/user}","branches_url":"https://api.github.com/repos/wanghaoran1988/origin/branches{/branch}","tags_url":"https://api.github.com/repos/wanghaoran1988/origin/tags","blobs_url":"https://api.github.com/repos/wanghaoran1988/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wanghaoran1988/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wanghaoran1988/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/wanghaoran1988/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wanghaoran1988/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/wanghaoran1988/origin/languages","stargazers_url":"https://api.github.com/repos/wanghaoran1988/origin/stargazers","contributors_url":"https://api.github.com/repos/wanghaoran1988/origin/contributors","subscribers_url":"https://api.github.com/repos/wanghaoran1988/origin/subscribers","subscription_url":"https://api.github.com/repos/wanghaoran1988/origin/subscription","commits_url":"https://api.github.com/repos/wanghaoran1988/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/wanghaoran1988/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/wanghaoran1988/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/wanghaoran1988/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/wanghaoran1988/origin/contents/{+path}","compare_url":"https://api.github.com/repos/wanghaoran1988/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wanghaoran1988/origin/merges","archive_url":"https://api.github.com/repos/wanghaoran1988/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wanghaoran1988/origin/downloads","issues_url":"https://api.github.com/repos/wanghaoran1988/origin/issues{/number}","pulls_url":"https://api.github.com/repos/wanghaoran1988/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/wanghaoran1988/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/wanghaoran1988/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wanghaoran1988/origin/labels{/name}","releases_url":"https://api.github.com/repos/wanghaoran1988/origin/releases{/id}","deployments_url":"https://api.github.com/repos/wanghaoran1988/origin/deployments","created_at":"2015-09-09T11:03:42Z","updated_at":"2016-05-01T10:52:35Z","pushed_at":"2016-09-12T08:30:45Z","git_url":"git://github.com/wanghaoran1988/origin.git","ssh_url":"git@github.com:wanghaoran1988/origin.git","clone_url":"https://github.com/wanghaoran1988/origin.git","svn_url":"https://github.com/wanghaoran1988/origin","homepage":"http://www.openshift.org","size":331670,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"84a8c523fa1e94e8f822389ec8fdc6bc086e4ecd","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-09-13T05:01:13Z","pushed_at":"2016-09-13T07:11:18Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":588352,"stargazers_count":1703,"watchers_count":1703,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1098,"mirror_url":null,"open_issues_count":1164,"forks":1098,"open_issues":1164,"watchers":1703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/10873"},"html":{"href":"https://github.com/openshift/origin/pull/10873"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/10873"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/10873/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/10873/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/10873/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/06a88f40e8b4911c0730252c96502ffef4eec747"}}}}
{"actor":{"display_login":"wanghaoran1988"}}