{"action":"created","issue":{"url":"https://api.github.com/repos/google/certificate-transparency/issues/1124","repository_url":"https://api.github.com/repos/google/certificate-transparency","labels_url":"https://api.github.com/repos/google/certificate-transparency/issues/1124/labels{/name}","comments_url":"https://api.github.com/repos/google/certificate-transparency/issues/1124/comments","events_url":"https://api.github.com/repos/google/certificate-transparency/issues/1124/events","html_url":"https://github.com/google/certificate-transparency/pull/1124","id":137232765,"number":1124,"title":"Add support for serializing SCT Lists","user":{"login":"mehmooda","id":455116,"avatar_url":"https://avatars.githubusercontent.com/u/455116?v=3","gravatar_id":"","url":"https://api.github.com/users/mehmooda","html_url":"https://github.com/mehmooda","followers_url":"https://api.github.com/users/mehmooda/followers","following_url":"https://api.github.com/users/mehmooda/following{/other_user}","gists_url":"https://api.github.com/users/mehmooda/gists{/gist_id}","starred_url":"https://api.github.com/users/mehmooda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehmooda/subscriptions","organizations_url":"https://api.github.com/users/mehmooda/orgs","repos_url":"https://api.github.com/users/mehmooda/repos","events_url":"https://api.github.com/users/mehmooda/events{/privacy}","received_events_url":"https://api.github.com/users/mehmooda/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/google/certificate-transparency/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars.githubusercontent.com/u/7648032?v=3","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-02-29T11:52:52Z","updated_at":"2016-04-12T00:29:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/1124","html_url":"https://github.com/google/certificate-transparency/pull/1124","diff_url":"https://github.com/google/certificate-transparency/pull/1124.diff","patch_url":"https://github.com/google/certificate-transparency/pull/1124.patch"},"body":"depends on #1075 "},"comment":{"url":"https://api.github.com/repos/google/certificate-transparency/issues/comments/208639328","html_url":"https://github.com/google/certificate-transparency/pull/1124#issuecomment-208639328","issue_url":"https://api.github.com/repos/google/certificate-transparency/issues/1124","id":208639328,"user":{"login":"jsha","id":220205,"avatar_url":"https://avatars.githubusercontent.com/u/220205?v=3","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T00:29:23Z","updated_at":"2016-04-12T00:29:23Z","body":"@mehmooda: Regarding the above comments on benchmarking, it looks like you've put a bunch of effort into making this very efficient. But I don't anticipate this code being used in a highly performance-sensitive context. In Boulder, where we intend to use it for Let's Encrypt, the difference between the 45 microseconds / op version based on `asn1.Marshal` and the 5 microseconds / op version based on hand-rolled ASN.1 is negligible, and we'd prefer the one based on `asn1.Marshal` on the grounds that it's easier to reason about and more likely to be correct. Is there a reason you prefer the heavily-optimized version?"}}