{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10424","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10424/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10424/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10424/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10424","id":170764759,"number":10424,"title":"Fix for provisioning workflow issues after refactoring","user":{"login":"eclarizio","id":164557,"avatar_url":"https://avatars.githubusercontent.com/u/164557?v=3","gravatar_id":"","url":"https://api.github.com/users/eclarizio","html_url":"https://github.com/eclarizio","followers_url":"https://api.github.com/users/eclarizio/followers","following_url":"https://api.github.com/users/eclarizio/following{/other_user}","gists_url":"https://api.github.com/users/eclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/eclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclarizio/subscriptions","organizations_url":"https://api.github.com/users/eclarizio/orgs","repos_url":"https://api.github.com/users/eclarizio/repos","events_url":"https://api.github.com/users/eclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/eclarizio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bdunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},"assignees":[{"login":"bdunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-08-11T22:46:40Z","updated_at":"2016-08-18T00:43:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10424","html_url":"https://github.com/ManageIQ/manageiq/pull/10424","diff_url":"https://github.com/ManageIQ/manageiq/pull/10424.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10424.patch"},"body":"Purpose or Intent\r\n-----------------\r\nPreviously, the code was collecting the fields and field names, and passing them to the visibility service to modify. That didn't actually modify them, so there were still certain things being hidden/shown that shouldn't have been. This should ensure that :hide and :edit display properties are properly set. Note that if a field is not explicitly hidden, it will be shown by default.\r\n\r\nLinks\r\n-----\r\nhttps://github.com/ManageIQ/manageiq/issues/10231\r\n\r\n@bdunne This should also fix the issue you were talking about in gitter where PXE server images/values were being required even without PXE selected.\r\n\r\n@miq-bot assign @gmcculloug "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/240592377","html_url":"https://github.com/ManageIQ/manageiq/pull/10424#issuecomment-240592377","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10424","id":240592377,"user":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T00:43:49Z","updated_at":"2016-08-18T00:43:49Z","body":"@bdunne - Glad to hear that since I was not able to reproduce your issue. 😌 \r\n\r\n@eclarizio - Still seeing two issues after this update:\r\n\r\n1. The \"Linked Clone\" control referenced in issue #10231 is completely hidden now.  \r\n2. On the Customize tab the \"Override Specification Values\" checkbox is only showing when the spec is set to <None>.  It should be the opposite.  The checkbox should be hidden when <None> is selected and visible when a spec is selected.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/2591569/17758015/b90583e4-64b9-11e6-9745-ee43fe3010b4.png)\r\n"}}
{"actor":{"display_login":"gmcculloug"}}