{"action":"opened","number":369,"pull_request":{"url":"https://api.github.com/repos/go-kit/kit/pulls/369","id":87648779,"html_url":"https://github.com/go-kit/kit/pull/369","diff_url":"https://github.com/go-kit/kit/pull/369.diff","patch_url":"https://github.com/go-kit/kit/pull/369.patch","issue_url":"https://api.github.com/repos/go-kit/kit/issues/369","number":369,"state":"open","locked":false,"title":"metrics/influx: fix the package implementation","user":{"login":"kpacha","id":1307694,"avatar_url":"https://avatars.githubusercontent.com/u/1307694?v=3","gravatar_id":"","url":"https://api.github.com/users/kpacha","html_url":"https://github.com/kpacha","followers_url":"https://api.github.com/users/kpacha/followers","following_url":"https://api.github.com/users/kpacha/following{/other_user}","gists_url":"https://api.github.com/users/kpacha/gists{/gist_id}","starred_url":"https://api.github.com/users/kpacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpacha/subscriptions","organizations_url":"https://api.github.com/users/kpacha/orgs","repos_url":"https://api.github.com/users/kpacha/repos","events_url":"https://api.github.com/users/kpacha/events{/privacy}","received_events_url":"https://api.github.com/users/kpacha/received_events","type":"User","site_admin":false},"body":"As reviewing the #367 I've found all the implementations of the metrics used the labels as fields, so I generalized the hack for gauges and histograms too.\r\n\r\nAlso, the histogram implementation wasn't aggregating the results, so they couldn't be stored properly in the backend (same problem as in #367, because influx accepts just one combination of fields for a given combination of tags and timestamp).\r\n\r\nFinally, I added 3 tests where you can see how the messages are being sent over the wire.","created_at":"2016-10-02T22:18:39Z","updated_at":"2016-10-02T22:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18dfe3daee92c3f6151ca5b1fdfe302144509764","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-kit/kit/pulls/369/commits","review_comments_url":"https://api.github.com/repos/go-kit/kit/pulls/369/comments","review_comment_url":"https://api.github.com/repos/go-kit/kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-kit/kit/issues/369/comments","statuses_url":"https://api.github.com/repos/go-kit/kit/statuses/ac7fd0a2890fb6950a276e264a053f4311d387e8","head":{"label":"kpacha:fix_influxdb_metrics","ref":"fix_influxdb_metrics","sha":"ac7fd0a2890fb6950a276e264a053f4311d387e8","user":{"login":"kpacha","id":1307694,"avatar_url":"https://avatars.githubusercontent.com/u/1307694?v=3","gravatar_id":"","url":"https://api.github.com/users/kpacha","html_url":"https://github.com/kpacha","followers_url":"https://api.github.com/users/kpacha/followers","following_url":"https://api.github.com/users/kpacha/following{/other_user}","gists_url":"https://api.github.com/users/kpacha/gists{/gist_id}","starred_url":"https://api.github.com/users/kpacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpacha/subscriptions","organizations_url":"https://api.github.com/users/kpacha/orgs","repos_url":"https://api.github.com/users/kpacha/repos","events_url":"https://api.github.com/users/kpacha/events{/privacy}","received_events_url":"https://api.github.com/users/kpacha/received_events","type":"User","site_admin":false},"repo":{"id":69791505,"name":"kit","full_name":"kpacha/kit","owner":{"login":"kpacha","id":1307694,"avatar_url":"https://avatars.githubusercontent.com/u/1307694?v=3","gravatar_id":"","url":"https://api.github.com/users/kpacha","html_url":"https://github.com/kpacha","followers_url":"https://api.github.com/users/kpacha/followers","following_url":"https://api.github.com/users/kpacha/following{/other_user}","gists_url":"https://api.github.com/users/kpacha/gists{/gist_id}","starred_url":"https://api.github.com/users/kpacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpacha/subscriptions","organizations_url":"https://api.github.com/users/kpacha/orgs","repos_url":"https://api.github.com/users/kpacha/repos","events_url":"https://api.github.com/users/kpacha/events{/privacy}","received_events_url":"https://api.github.com/users/kpacha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kpacha/kit","description":"A standard library for microservices.","fork":true,"url":"https://api.github.com/repos/kpacha/kit","forks_url":"https://api.github.com/repos/kpacha/kit/forks","keys_url":"https://api.github.com/repos/kpacha/kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kpacha/kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kpacha/kit/teams","hooks_url":"https://api.github.com/repos/kpacha/kit/hooks","issue_events_url":"https://api.github.com/repos/kpacha/kit/issues/events{/number}","events_url":"https://api.github.com/repos/kpacha/kit/events","assignees_url":"https://api.github.com/repos/kpacha/kit/assignees{/user}","branches_url":"https://api.github.com/repos/kpacha/kit/branches{/branch}","tags_url":"https://api.github.com/repos/kpacha/kit/tags","blobs_url":"https://api.github.com/repos/kpacha/kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kpacha/kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kpacha/kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/kpacha/kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kpacha/kit/statuses/{sha}","languages_url":"https://api.github.com/repos/kpacha/kit/languages","stargazers_url":"https://api.github.com/repos/kpacha/kit/stargazers","contributors_url":"https://api.github.com/repos/kpacha/kit/contributors","subscribers_url":"https://api.github.com/repos/kpacha/kit/subscribers","subscription_url":"https://api.github.com/repos/kpacha/kit/subscription","commits_url":"https://api.github.com/repos/kpacha/kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/kpacha/kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/kpacha/kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/kpacha/kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/kpacha/kit/contents/{+path}","compare_url":"https://api.github.com/repos/kpacha/kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kpacha/kit/merges","archive_url":"https://api.github.com/repos/kpacha/kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kpacha/kit/downloads","issues_url":"https://api.github.com/repos/kpacha/kit/issues{/number}","pulls_url":"https://api.github.com/repos/kpacha/kit/pulls{/number}","milestones_url":"https://api.github.com/repos/kpacha/kit/milestones{/number}","notifications_url":"https://api.github.com/repos/kpacha/kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kpacha/kit/labels{/name}","releases_url":"https://api.github.com/repos/kpacha/kit/releases{/id}","deployments_url":"https://api.github.com/repos/kpacha/kit/deployments","created_at":"2016-10-02T10:32:04Z","updated_at":"2016-10-02T10:32:07Z","pushed_at":"2016-10-02T22:03:35Z","git_url":"git://github.com/kpacha/kit.git","ssh_url":"git@github.com:kpacha/kit.git","clone_url":"https://github.com/kpacha/kit.git","svn_url":"https://github.com/kpacha/kit","homepage":"https://gokit.io","size":5032,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-kit:master","ref":"master","sha":"fe6fe28ba0d54b39f27e79cddba4911b7e4fffc7","user":{"login":"go-kit","id":10981023,"avatar_url":"https://avatars.githubusercontent.com/u/10981023?v=3","gravatar_id":"","url":"https://api.github.com/users/go-kit","html_url":"https://github.com/go-kit","followers_url":"https://api.github.com/users/go-kit/followers","following_url":"https://api.github.com/users/go-kit/following{/other_user}","gists_url":"https://api.github.com/users/go-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/go-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-kit/subscriptions","organizations_url":"https://api.github.com/users/go-kit/orgs","repos_url":"https://api.github.com/users/go-kit/repos","events_url":"https://api.github.com/users/go-kit/events{/privacy}","received_events_url":"https://api.github.com/users/go-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":30215630,"name":"kit","full_name":"go-kit/kit","owner":{"login":"go-kit","id":10981023,"avatar_url":"https://avatars.githubusercontent.com/u/10981023?v=3","gravatar_id":"","url":"https://api.github.com/users/go-kit","html_url":"https://github.com/go-kit","followers_url":"https://api.github.com/users/go-kit/followers","following_url":"https://api.github.com/users/go-kit/following{/other_user}","gists_url":"https://api.github.com/users/go-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/go-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-kit/subscriptions","organizations_url":"https://api.github.com/users/go-kit/orgs","repos_url":"https://api.github.com/users/go-kit/repos","events_url":"https://api.github.com/users/go-kit/events{/privacy}","received_events_url":"https://api.github.com/users/go-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-kit/kit","description":"A standard library for microservices.","fork":false,"url":"https://api.github.com/repos/go-kit/kit","forks_url":"https://api.github.com/repos/go-kit/kit/forks","keys_url":"https://api.github.com/repos/go-kit/kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-kit/kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-kit/kit/teams","hooks_url":"https://api.github.com/repos/go-kit/kit/hooks","issue_events_url":"https://api.github.com/repos/go-kit/kit/issues/events{/number}","events_url":"https://api.github.com/repos/go-kit/kit/events","assignees_url":"https://api.github.com/repos/go-kit/kit/assignees{/user}","branches_url":"https://api.github.com/repos/go-kit/kit/branches{/branch}","tags_url":"https://api.github.com/repos/go-kit/kit/tags","blobs_url":"https://api.github.com/repos/go-kit/kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-kit/kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-kit/kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-kit/kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-kit/kit/statuses/{sha}","languages_url":"https://api.github.com/repos/go-kit/kit/languages","stargazers_url":"https://api.github.com/repos/go-kit/kit/stargazers","contributors_url":"https://api.github.com/repos/go-kit/kit/contributors","subscribers_url":"https://api.github.com/repos/go-kit/kit/subscribers","subscription_url":"https://api.github.com/repos/go-kit/kit/subscription","commits_url":"https://api.github.com/repos/go-kit/kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-kit/kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-kit/kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-kit/kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-kit/kit/contents/{+path}","compare_url":"https://api.github.com/repos/go-kit/kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-kit/kit/merges","archive_url":"https://api.github.com/repos/go-kit/kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-kit/kit/downloads","issues_url":"https://api.github.com/repos/go-kit/kit/issues{/number}","pulls_url":"https://api.github.com/repos/go-kit/kit/pulls{/number}","milestones_url":"https://api.github.com/repos/go-kit/kit/milestones{/number}","notifications_url":"https://api.github.com/repos/go-kit/kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-kit/kit/labels{/name}","releases_url":"https://api.github.com/repos/go-kit/kit/releases{/id}","deployments_url":"https://api.github.com/repos/go-kit/kit/deployments","created_at":"2015-02-03T00:01:19Z","updated_at":"2016-10-02T08:18:47Z","pushed_at":"2016-10-02T22:18:39Z","git_url":"git://github.com/go-kit/kit.git","ssh_url":"git@github.com:go-kit/kit.git","clone_url":"https://github.com/go-kit/kit.git","svn_url":"https://github.com/go-kit/kit","homepage":"https://gokit.io","size":8307,"stargazers_count":5205,"watchers_count":5205,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":444,"mirror_url":null,"open_issues_count":29,"forks":444,"open_issues":29,"watchers":5205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-kit/kit/pulls/369"},"html":{"href":"https://github.com/go-kit/kit/pull/369"},"issue":{"href":"https://api.github.com/repos/go-kit/kit/issues/369"},"comments":{"href":"https://api.github.com/repos/go-kit/kit/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/go-kit/kit/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/go-kit/kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-kit/kit/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/go-kit/kit/statuses/ac7fd0a2890fb6950a276e264a053f4311d387e8"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":114,"deletions":28,"changed_files":2}}
{"actor":{"display_login":"kpacha"}}