{"action":"created","comment":{"url":"https://api.github.com/repos/meteor/meteor/pulls/comments/80533013","id":80533013,"diff_hunk":"@@ -83,8 +83,8 @@ export class CoffeeCompiler extends CachingCompiler {\n \n     let sourceMap = JSON.parse(output.v3SourceMap);\n \n-    if (source.match(/(`|import|export|function\\*)/)) {\n-      // If source contains backticks or ES2015+ features,\n+    if (source.match(/`|\\bimport\\b|\\bexport\\b|\\byield\\b/)) {","path":"packages/coffeescript/plugin/compile-coffeescript.js","position":null,"original_position":6,"commit_id":"e1ac0742167afe8e0b81d2c5c5f69c4a57e06060","original_commit_id":"e1ac0742167afe8e0b81d2c5c5f69c4a57e06060","user":{"login":"GeoffreyBooth","id":456802,"avatar_url":"https://avatars.githubusercontent.com/u/456802?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"body":"So which regex would you recommend? ``/`|\\b(?:import|export|yield)\\b/``?\r\n\r\nFWIW I think `import` is the most likely substring that a file would contain, and most likely to be first. Backticks are probably last.","created_at":"2016-09-26T17:53:49Z","updated_at":"2016-09-26T17:53:49Z","html_url":"https://github.com/meteor/meteor/pull/7818#discussion_r80533013","pull_request_url":"https://api.github.com/repos/meteor/meteor/pulls/7818","_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments/80533013"},"html":{"href":"https://github.com/meteor/meteor/pull/7818#discussion_r80533013"},"pull_request":{"href":"https://api.github.com/repos/meteor/meteor/pulls/7818"}}},"pull_request":{"url":"https://api.github.com/repos/meteor/meteor/pulls/7818","id":86627806,"html_url":"https://github.com/meteor/meteor/pull/7818","diff_url":"https://github.com/meteor/meteor/pull/7818.diff","patch_url":"https://github.com/meteor/meteor/pull/7818.patch","issue_url":"https://api.github.com/repos/meteor/meteor/issues/7818","number":7818,"state":"open","locked":false,"title":"CoffeeScript now supports ES2015 modules","user":{"login":"GeoffreyBooth","id":456802,"avatar_url":"https://avatars.githubusercontent.com/u/456802?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"body":"CoffeeScript 1.11.0 is out, and this release adds [native support for `import` and `export` statements](http://coffeescript.org/#modules). There’s no need to wrap such statements in backticks anymore.\r\n\r\nThis pull request updates Meteor’s `coffeescript` package as follows:\r\n- The version of CoffeeScript is bumped to 1.11.0.\r\n- Previously, any CoffeeScript file that contained at least one backtick was passed to the `ecmascript` package for further compilation by Babel. Now CoffeeScript files that contain backticks or the substrings `import`, `export` or `function*` are passed to `ecmascript`.\r\n- New tests are added to check that the native `import` and `export` statements work.\r\n\r\nRegarding when to pass to `ecmascript`, technically CoffeeScript currently has two features that are output as ES2015 rather than ES5: modules, and [generator functions](http://coffeescript.org/#fat-arrow). It was a bug in the previous version of the package that generators were passed through to the runtime, rather than getting further processing by `ecmascript`/Babel. We might want to consider eliminating this check and simply pass everything output by CoffeeScript to `ecmascript`, rather than continuing to expand this list as CoffeeScript adds more features that it outputs in ESNext syntax. For now I’ve left it, since it should improve performance and the list of ESNext syntax features is still fairly short.","created_at":"2016-09-24T19:25:14Z","updated_at":"2016-09-26T17:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"190b2aaf73cb24db128f97cbb2a25098d428e6b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/meteor/meteor/pulls/7818/commits","review_comments_url":"https://api.github.com/repos/meteor/meteor/pulls/7818/comments","review_comment_url":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteor/meteor/issues/7818/comments","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/e1ac0742167afe8e0b81d2c5c5f69c4a57e06060","head":{"label":"GeoffreyBooth:coffeescript-modules","ref":"coffeescript-modules","sha":"e1ac0742167afe8e0b81d2c5c5f69c4a57e06060","user":{"login":"GeoffreyBooth","id":456802,"avatar_url":"https://avatars.githubusercontent.com/u/456802?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"repo":{"id":52945560,"name":"meteor","full_name":"GeoffreyBooth/meteor","owner":{"login":"GeoffreyBooth","id":456802,"avatar_url":"https://avatars.githubusercontent.com/u/456802?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyBooth","html_url":"https://github.com/GeoffreyBooth","followers_url":"https://api.github.com/users/GeoffreyBooth/followers","following_url":"https://api.github.com/users/GeoffreyBooth/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyBooth/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyBooth/orgs","repos_url":"https://api.github.com/users/GeoffreyBooth/repos","events_url":"https://api.github.com/users/GeoffreyBooth/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyBooth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeoffreyBooth/meteor","description":"Meteor, the JavaScript App Platform","fork":true,"url":"https://api.github.com/repos/GeoffreyBooth/meteor","forks_url":"https://api.github.com/repos/GeoffreyBooth/meteor/forks","keys_url":"https://api.github.com/repos/GeoffreyBooth/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoffreyBooth/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoffreyBooth/meteor/teams","hooks_url":"https://api.github.com/repos/GeoffreyBooth/meteor/hooks","issue_events_url":"https://api.github.com/repos/GeoffreyBooth/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/GeoffreyBooth/meteor/events","assignees_url":"https://api.github.com/repos/GeoffreyBooth/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/GeoffreyBooth/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/GeoffreyBooth/meteor/tags","blobs_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoffreyBooth/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoffreyBooth/meteor/languages","stargazers_url":"https://api.github.com/repos/GeoffreyBooth/meteor/stargazers","contributors_url":"https://api.github.com/repos/GeoffreyBooth/meteor/contributors","subscribers_url":"https://api.github.com/repos/GeoffreyBooth/meteor/subscribers","subscription_url":"https://api.github.com/repos/GeoffreyBooth/meteor/subscription","commits_url":"https://api.github.com/repos/GeoffreyBooth/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoffreyBooth/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoffreyBooth/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoffreyBooth/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoffreyBooth/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/GeoffreyBooth/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoffreyBooth/meteor/merges","archive_url":"https://api.github.com/repos/GeoffreyBooth/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoffreyBooth/meteor/downloads","issues_url":"https://api.github.com/repos/GeoffreyBooth/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/GeoffreyBooth/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoffreyBooth/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoffreyBooth/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoffreyBooth/meteor/labels{/name}","releases_url":"https://api.github.com/repos/GeoffreyBooth/meteor/releases{/id}","deployments_url":"https://api.github.com/repos/GeoffreyBooth/meteor/deployments","created_at":"2016-03-02T08:11:08Z","updated_at":"2016-03-02T08:11:30Z","pushed_at":"2016-09-26T14:33:45Z","git_url":"git://github.com/GeoffreyBooth/meteor.git","ssh_url":"git@github.com:GeoffreyBooth/meteor.git","clone_url":"https://github.com/GeoffreyBooth/meteor.git","svn_url":"https://github.com/GeoffreyBooth/meteor","homepage":"https://www.meteor.com","size":64522,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"meteor:devel","ref":"devel","sha":"4c2ba4ff4bae1d5503b19ce9497fa6a09069b053","user":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"repo":{"id":3214406,"name":"meteor","full_name":"meteor/meteor","owner":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meteor/meteor","description":"Meteor, the JavaScript App Platform","fork":false,"url":"https://api.github.com/repos/meteor/meteor","forks_url":"https://api.github.com/repos/meteor/meteor/forks","keys_url":"https://api.github.com/repos/meteor/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor/meteor/teams","hooks_url":"https://api.github.com/repos/meteor/meteor/hooks","issue_events_url":"https://api.github.com/repos/meteor/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/meteor/meteor/events","assignees_url":"https://api.github.com/repos/meteor/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/meteor/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/meteor/meteor/tags","blobs_url":"https://api.github.com/repos/meteor/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor/meteor/languages","stargazers_url":"https://api.github.com/repos/meteor/meteor/stargazers","contributors_url":"https://api.github.com/repos/meteor/meteor/contributors","subscribers_url":"https://api.github.com/repos/meteor/meteor/subscribers","subscription_url":"https://api.github.com/repos/meteor/meteor/subscription","commits_url":"https://api.github.com/repos/meteor/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/meteor/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor/meteor/merges","archive_url":"https://api.github.com/repos/meteor/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor/meteor/downloads","issues_url":"https://api.github.com/repos/meteor/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/meteor/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor/meteor/labels{/name}","releases_url":"https://api.github.com/repos/meteor/meteor/releases{/id}","deployments_url":"https://api.github.com/repos/meteor/meteor/deployments","created_at":"2012-01-19T01:58:17Z","updated_at":"2016-09-26T17:29:41Z","pushed_at":"2016-09-26T14:33:50Z","git_url":"git://github.com/meteor/meteor.git","ssh_url":"git@github.com:meteor/meteor.git","clone_url":"https://github.com/meteor/meteor.git","svn_url":"https://github.com/meteor/meteor","homepage":"https://www.meteor.com","size":146291,"stargazers_count":35439,"watchers_count":35439,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4387,"mirror_url":null,"open_issues_count":1033,"forks":4387,"open_issues":1033,"watchers":35439,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/7818"},"html":{"href":"https://github.com/meteor/meteor/pull/7818"},"issue":{"href":"https://api.github.com/repos/meteor/meteor/issues/7818"},"comments":{"href":"https://api.github.com/repos/meteor/meteor/issues/7818/comments"},"review_comments":{"href":"https://api.github.com/repos/meteor/meteor/pulls/7818/comments"},"review_comment":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteor/meteor/pulls/7818/commits"},"statuses":{"href":"https://api.github.com/repos/meteor/meteor/statuses/e1ac0742167afe8e0b81d2c5c5f69c4a57e06060"}}}}
{"actor":{"display_login":"GeoffreyBooth"}}