{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-split-layout/issues/19","repository_url":"https://api.github.com/repos/vaadin/vaadin-split-layout","labels_url":"https://api.github.com/repos/vaadin/vaadin-split-layout/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-split-layout/issues/19/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-split-layout/issues/19/events","html_url":"https://github.com/vaadin/vaadin-split-layout/pull/19","id":191197381,"number":19,"title":"Custom styles","user":{"login":"manolo","id":161853,"avatar_url":"https://avatars.githubusercontent.com/u/161853?v=3","gravatar_id":"","url":"https://api.github.com/users/manolo","html_url":"https://github.com/manolo","followers_url":"https://api.github.com/users/manolo/followers","following_url":"https://api.github.com/users/manolo/following{/other_user}","gists_url":"https://api.github.com/users/manolo/gists{/gist_id}","starred_url":"https://api.github.com/users/manolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolo/subscriptions","organizations_url":"https://api.github.com/users/manolo/orgs","repos_url":"https://api.github.com/users/manolo/repos","events_url":"https://api.github.com/users/manolo/events{/privacy}","received_events_url":"https://api.github.com/users/manolo/received_events","type":"User","site_admin":false},"labels":[{"id":422037995,"url":"https://api.github.com/repos/vaadin/vaadin-split-layout/labels/in%20review","name":"in review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-11-23T06:32:05Z","updated_at":"2016-11-23T14:53:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-split-layout/pulls/19","html_url":"https://github.com/vaadin/vaadin-split-layout/pull/19","diff_url":"https://github.com/vaadin/vaadin-split-layout/pull/19.diff","patch_url":"https://github.com/vaadin/vaadin-split-layout/pull/19.patch"},"body":"fixes #6\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-split-layout/19)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-split-layout/issues/comments/262534888","html_url":"https://github.com/vaadin/vaadin-split-layout/pull/19#issuecomment-262534888","issue_url":"https://api.github.com/repos/vaadin/vaadin-split-layout/issues/19","id":262534888,"user":{"login":"tomivirkki","id":1222264,"avatar_url":"https://avatars.githubusercontent.com/u/1222264?v=3","gravatar_id":"","url":"https://api.github.com/users/tomivirkki","html_url":"https://github.com/tomivirkki","followers_url":"https://api.github.com/users/tomivirkki/followers","following_url":"https://api.github.com/users/tomivirkki/following{/other_user}","gists_url":"https://api.github.com/users/tomivirkki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomivirkki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomivirkki/subscriptions","organizations_url":"https://api.github.com/users/tomivirkki/orgs","repos_url":"https://api.github.com/users/tomivirkki/repos","events_url":"https://api.github.com/users/tomivirkki/events{/privacy}","received_events_url":"https://api.github.com/users/tomivirkki/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T14:53:39Z","updated_at":"2016-11-23T14:53:39Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 29 unresolved discussions.\n\n---\n\n*[vaadin-split-layout.html, line 128 at r3](https://reviewable.io:443/reviews/vaadin/vaadin-split-layout/19#-KXG_IZLvSWvuPKzJu7E:-KXG_IZLvSWvuPKzJu7F:bsifxeq) ([raw file](https://github.com/vaadin/vaadin-split-layout/blob/0b92215f586a3758718809030bed42c5ee832596/vaadin-split-layout.html#L128)):*\n> ```HTML\n>         position: absolute;\n>         @apply(--vaadin-split-layout-icon);\n>         margin-left: -8px;\n> ```\n\nPlease don't center with magic numbers, if someone places custom content whose size isn't 24x24, it won't center correctly with this rule.\nUse left: 50% and translateX -50% instead\n\nHere's an example: https://www.dropbox.com/s/2h2kzq03hbxkh8z/Screenshot%202016-11-23%2016.45.12.png?dl=0\n\n---\n\n*[vaadin-split-layout.html, line 200 at r5](https://reviewable.io:443/reviews/vaadin/vaadin-split-layout/19#-KXGe02mi8mFcWOUz11e:-KXGe02nly0u-pmka-5N:bfj3il2) ([raw file](https://github.com/vaadin/vaadin-split-layout/blob/4220b4333b01df5a89365a7d8e5ae45354605a04/vaadin-split-layout.html#L200)):*\n> ```HTML\n>         this._primaryChild = children[0];\n>         this._secondaryChild = children[1];\n>         children.forEach(function(child, i) {\n> ```\n\nThis logic here will tag the light DOM children (based on indexes) with attributes that will be used by the content selectors later on. Now if you add custom \"icon-horizontal\" as the first child for your vaadin-split-layout, things will break: https://www.dropbox.com/s/n1bdbbild6dtk66/Screenshot%202016-11-23%2016.46.39.png?dl=0\n\nNeed to ignore \"icon-horizontal\" and \"icon-vertical\" in the loop.\n\nThe whole custom content feature (which I'm starting to have doubts about) isn't apparently tested well since this didn't come up earlier. Please test properly.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/vaadin-split-layout/19)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tomivirkki"}}