{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/63265138","id":63265138,"diff_hunk":"@@ -64,14 +64,12 @@ struct fi_ibv_msg_ep;\n \n #define FI_IBV_RDM_CM_THREAD_TIMEOUT (100)\n #define FI_IBV_RDM_MEM_ALIGNMENT (64)\n-#define FI_IBV_RDM_BUF_ALIGNMENT (4096)\n+#define FI_IBV_RDM_BUF_ALIGNMENT (4096) /* TODO: Page size */\n \n #define FI_IBV_RDM_TAGGED_DFLT_BUFFER_NUM (8)\n \n #define FI_IBV_RDM_DFLT_BUFFER_SIZE\t\t\t\t\t\\\n-\t((8 * 1024 + FI_IBV_RDM_BUFF_SERVICE_DATA_SIZE) +\t\t\\\n-\t (8 * 1024 + FI_IBV_RDM_BUFF_SERVICE_DATA_SIZE) %\t\t\\\n-\t  FI_IBV_RDM_BUF_ALIGNMENT)\n+\t(3 * FI_IBV_RDM_BUF_ALIGNMENT)\n \n #define FI_IBV_RDM_DFLT_BUFFERED_SSIZE\t\t\t\t\t\\\n \t(FI_IBV_RDM_DFLT_BUFFER_SIZE -\t\t\t\t\t\\","path":"prov/verbs/src/ep_rdm/verbs_utils.h","position":16,"original_position":16,"commit_id":"ec90a466dffbe2f2cae6bf9563e4a160b477b652","original_commit_id":"52e4ca64576f5274b0c7d90493bd6f8dce7fb487","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars.githubusercontent.com/u/3967608?v=3","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"This is a general comment about this commit.  There are a lot of white space changes that add noise to the overall patch, and the original formatting of the code is better aligned with the coding guidelines and style.","created_at":"2016-05-13T23:46:53Z","updated_at":"2016-05-13T23:46:53Z","html_url":"https://github.com/ofiwg/libfabric/pull/2029#discussion_r63265138","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2029","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/63265138"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/2029#discussion_r63265138"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2029"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2029","id":69975835,"html_url":"https://github.com/ofiwg/libfabric/pull/2029","diff_url":"https://github.com/ofiwg/libfabric/pull/2029.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/2029.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/2029","number":2029,"state":"open","locked":false,"title":"prov/verbs: refactoring of rdm buffers","user":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"body":"This series of patches is a deep refactoring of addressing and memory layout of preregistered buffers. It reduces HW requirement for wr.imm_data.\r\n\r\n@a-ilango @shefty ","created_at":"2016-05-13T10:38:24Z","updated_at":"2016-05-13T23:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89a4d428adbe1a7bc1d4412eb34774033457a889","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2029/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2029/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/2029/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/ec90a466dffbe2f2cae6bf9563e4a160b477b652","head":{"label":"evgeny-leksikov:rbuf_wo_imm","ref":"rbuf_wo_imm","sha":"ec90a466dffbe2f2cae6bf9563e4a160b477b652","user":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"repo":{"id":44616498,"name":"libfabric","full_name":"evgeny-leksikov/libfabric","owner":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evgeny-leksikov/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/evgeny-leksikov/libfabric","forks_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/forks","keys_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/teams","hooks_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/hooks","issue_events_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/events","assignees_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/tags","blobs_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/languages","stargazers_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/stargazers","contributors_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/contributors","subscribers_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/subscribers","subscription_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/subscription","commits_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/merges","archive_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/downloads","issues_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/evgeny-leksikov/libfabric/deployments","created_at":"2015-10-20T15:38:55Z","updated_at":"2016-01-11T13:59:36Z","pushed_at":"2016-05-13T10:35:43Z","git_url":"git://github.com/evgeny-leksikov/libfabric.git","ssh_url":"git@github.com:evgeny-leksikov/libfabric.git","clone_url":"https://github.com/evgeny-leksikov/libfabric.git","svn_url":"https://github.com/evgeny-leksikov/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":10896,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"eed91e59cc5c0b252178e10f46f39030552fa1d1","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2016-04-14T15:34:09Z","pushed_at":"2016-05-13T21:57:52Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":12155,"stargazers_count":67,"watchers_count":67,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":75,"forks":65,"open_issues":75,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2029"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/2029"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/2029"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/2029/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2029/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2029/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/ec90a466dffbe2f2cae6bf9563e4a160b477b652"}}}}