{"action":"created","comment":{"url":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments/53131777","id":53131777,"diff_hunk":"@@ -116,6 +128,24 @@ public BsmAdminPageEditWindow addReductionKeyEdge(String reductionKeyText, Strin\n             return this;\n         }\n \n+        public BsmAdminPageEditWindow addAttribute(String key, String value) throws InterruptedException {\n+            newAttributeWindow()\n+                    .key(key)\n+                    .value(value)\n+                    .confirm();\n+            wait.until(ExpectedConditions.elementToBeClickable(By.id(\"addAttributeButton\")));\n+            return this;\n+        }\n+\n+        public BsmAdminPageEditWindow editAttribute(String key, String value) throws InterruptedException {\n+            getSelectWebElement(\"attributeList\").selectByVisibleText(key);\n+            editAttributeWindow()\n+                    .value(value)\n+                    .confirm();\n+            wait.until(ExpectedConditions.elementToBeClickable(By.id(\"addAttributeButton\")));","path":"smoke-test/src/test/java/org/opennms/smoketest/BSMAdminIT.java","position":78,"original_position":78,"commit_id":"b3dfa810f9a6f06be33fc67ff0cde76c6690e15f","original_commit_id":"b3dfa810f9a6f06be33fc67ff0cde76c6690e15f","user":{"login":"mvrueden","id":4202259,"avatar_url":"https://avatars.githubusercontent.com/u/4202259?v=3","gravatar_id":"","url":"https://api.github.com/users/mvrueden","html_url":"https://github.com/mvrueden","followers_url":"https://api.github.com/users/mvrueden/followers","following_url":"https://api.github.com/users/mvrueden/following{/other_user}","gists_url":"https://api.github.com/users/mvrueden/gists{/gist_id}","starred_url":"https://api.github.com/users/mvrueden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvrueden/subscriptions","organizations_url":"https://api.github.com/users/mvrueden/orgs","repos_url":"https://api.github.com/users/mvrueden/repos","events_url":"https://api.github.com/users/mvrueden/events{/privacy}","received_events_url":"https://api.github.com/users/mvrueden/received_events","type":"User","site_admin":false},"body":"This is kinda a duplicate, as we already wait in the confirm() method or is there a particular reason to wait again for another element? ","created_at":"2016-02-17T08:14:48Z","updated_at":"2016-02-17T08:14:48Z","html_url":"https://github.com/OpenNMS/opennms/pull/599#discussion_r53131777","pull_request_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/599","_links":{"self":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments/53131777"},"html":{"href":"https://github.com/OpenNMS/opennms/pull/599#discussion_r53131777"},"pull_request":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/599"}}},"pull_request":{"url":"https://api.github.com/repos/OpenNMS/opennms/pulls/599","id":59605051,"html_url":"https://github.com/OpenNMS/opennms/pull/599","diff_url":"https://github.com/OpenNMS/opennms/pull/599.diff","patch_url":"https://github.com/OpenNMS/opennms/pull/599.patch","issue_url":"https://api.github.com/repos/OpenNMS/opennms/issues/599","number":599,"state":"open","locked":false,"title":"BSM-145: Configure the Business Service attributes using the Admin UI","user":{"login":"christianpape","id":4200555,"avatar_url":"https://avatars.githubusercontent.com/u/4200555?v=3","gravatar_id":"","url":"https://api.github.com/users/christianpape","html_url":"https://github.com/christianpape","followers_url":"https://api.github.com/users/christianpape/followers","following_url":"https://api.github.com/users/christianpape/following{/other_user}","gists_url":"https://api.github.com/users/christianpape/gists{/gist_id}","starred_url":"https://api.github.com/users/christianpape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianpape/subscriptions","organizations_url":"https://api.github.com/users/christianpape/orgs","repos_url":"https://api.github.com/users/christianpape/repos","events_url":"https://api.github.com/users/christianpape/events{/privacy}","received_events_url":"https://api.github.com/users/christianpape/received_events","type":"User","site_admin":false},"body":"Jira: http://issues.opennms.org/browse/BSM-145\r\nBamboo: http://bamboo.internal.opennms.com:8085/browse/OPENNMS-ONMS478","created_at":"2016-02-17T07:16:50Z","updated_at":"2016-02-17T08:14:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9d00d8b7022d7d1da9331fda5b3910c494bd131","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/599/commits","review_comments_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/599/comments","review_comment_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/issues/599/comments","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/b3dfa810f9a6f06be33fc67ff0cde76c6690e15f","head":{"label":"OpenNMS:jira/BSM-145","ref":"jira/BSM-145","sha":"b3dfa810f9a6f06be33fc67ff0cde76c6690e15f","user":{"login":"OpenNMS","id":2972482,"avatar_url":"https://avatars.githubusercontent.com/u/2972482?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"repo":{"id":9377198,"name":"opennms","full_name":"OpenNMS/opennms","owner":{"login":"OpenNMS","id":2972482,"avatar_url":"https://avatars.githubusercontent.com/u/2972482?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenNMS/opennms","description":"","fork":false,"url":"https://api.github.com/repos/OpenNMS/opennms","forks_url":"https://api.github.com/repos/OpenNMS/opennms/forks","keys_url":"https://api.github.com/repos/OpenNMS/opennms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNMS/opennms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNMS/opennms/teams","hooks_url":"https://api.github.com/repos/OpenNMS/opennms/hooks","issue_events_url":"https://api.github.com/repos/OpenNMS/opennms/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNMS/opennms/events","assignees_url":"https://api.github.com/repos/OpenNMS/opennms/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNMS/opennms/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNMS/opennms/tags","blobs_url":"https://api.github.com/repos/OpenNMS/opennms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNMS/opennms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNMS/opennms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNMS/opennms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNMS/opennms/languages","stargazers_url":"https://api.github.com/repos/OpenNMS/opennms/stargazers","contributors_url":"https://api.github.com/repos/OpenNMS/opennms/contributors","subscribers_url":"https://api.github.com/repos/OpenNMS/opennms/subscribers","subscription_url":"https://api.github.com/repos/OpenNMS/opennms/subscription","commits_url":"https://api.github.com/repos/OpenNMS/opennms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNMS/opennms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNMS/opennms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenNMS/opennms/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNMS/opennms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNMS/opennms/merges","archive_url":"https://api.github.com/repos/OpenNMS/opennms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNMS/opennms/downloads","issues_url":"https://api.github.com/repos/OpenNMS/opennms/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNMS/opennms/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNMS/opennms/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNMS/opennms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNMS/opennms/labels{/name}","releases_url":"https://api.github.com/repos/OpenNMS/opennms/releases{/id}","deployments_url":"https://api.github.com/repos/OpenNMS/opennms/deployments","created_at":"2013-04-11T18:22:33Z","updated_at":"2016-02-12T08:51:06Z","pushed_at":"2016-02-17T07:16:51Z","git_url":"git://github.com/OpenNMS/opennms.git","ssh_url":"git@github.com:OpenNMS/opennms.git","clone_url":"https://github.com/OpenNMS/opennms.git","svn_url":"https://github.com/OpenNMS/opennms","homepage":"http://www.opennms.org/","size":422706,"stargazers_count":117,"watchers_count":117,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":17,"forks":238,"open_issues":17,"watchers":117,"default_branch":"develop"}},"base":{"label":"OpenNMS:features/bsm","ref":"features/bsm","sha":"27bd65def90a66464434cbecb9a72f28bfd7c88c","user":{"login":"OpenNMS","id":2972482,"avatar_url":"https://avatars.githubusercontent.com/u/2972482?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"repo":{"id":9377198,"name":"opennms","full_name":"OpenNMS/opennms","owner":{"login":"OpenNMS","id":2972482,"avatar_url":"https://avatars.githubusercontent.com/u/2972482?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenNMS/opennms","description":"","fork":false,"url":"https://api.github.com/repos/OpenNMS/opennms","forks_url":"https://api.github.com/repos/OpenNMS/opennms/forks","keys_url":"https://api.github.com/repos/OpenNMS/opennms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNMS/opennms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNMS/opennms/teams","hooks_url":"https://api.github.com/repos/OpenNMS/opennms/hooks","issue_events_url":"https://api.github.com/repos/OpenNMS/opennms/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNMS/opennms/events","assignees_url":"https://api.github.com/repos/OpenNMS/opennms/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNMS/opennms/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNMS/opennms/tags","blobs_url":"https://api.github.com/repos/OpenNMS/opennms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNMS/opennms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNMS/opennms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNMS/opennms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNMS/opennms/languages","stargazers_url":"https://api.github.com/repos/OpenNMS/opennms/stargazers","contributors_url":"https://api.github.com/repos/OpenNMS/opennms/contributors","subscribers_url":"https://api.github.com/repos/OpenNMS/opennms/subscribers","subscription_url":"https://api.github.com/repos/OpenNMS/opennms/subscription","commits_url":"https://api.github.com/repos/OpenNMS/opennms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNMS/opennms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNMS/opennms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenNMS/opennms/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNMS/opennms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNMS/opennms/merges","archive_url":"https://api.github.com/repos/OpenNMS/opennms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNMS/opennms/downloads","issues_url":"https://api.github.com/repos/OpenNMS/opennms/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNMS/opennms/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNMS/opennms/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNMS/opennms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNMS/opennms/labels{/name}","releases_url":"https://api.github.com/repos/OpenNMS/opennms/releases{/id}","deployments_url":"https://api.github.com/repos/OpenNMS/opennms/deployments","created_at":"2013-04-11T18:22:33Z","updated_at":"2016-02-12T08:51:06Z","pushed_at":"2016-02-17T07:16:51Z","git_url":"git://github.com/OpenNMS/opennms.git","ssh_url":"git@github.com:OpenNMS/opennms.git","clone_url":"https://github.com/OpenNMS/opennms.git","svn_url":"https://github.com/OpenNMS/opennms","homepage":"http://www.opennms.org/","size":422706,"stargazers_count":117,"watchers_count":117,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":17,"forks":238,"open_issues":17,"watchers":117,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/599"},"html":{"href":"https://github.com/OpenNMS/opennms/pull/599"},"issue":{"href":"https://api.github.com/repos/OpenNMS/opennms/issues/599"},"comments":{"href":"https://api.github.com/repos/OpenNMS/opennms/issues/599/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/599/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/599/commits"},"statuses":{"href":"https://api.github.com/repos/OpenNMS/opennms/statuses/b3dfa810f9a6f06be33fc67ff0cde76c6690e15f"}}}}