{"action":"created","comment":{"url":"https://api.github.com/repos/go-kit/kit/pulls/comments/63908841","id":63908841,"diff_hunk":"@@ -0,0 +1,237 @@\n+package provider\n+\n+import (\n+\t\"errors\"\n+\t\"time\"\n+\n+\t\"github.com/prometheus/client_golang/prometheus\"\n+\n+\t\"github.com/go-kit/kit/log\"\n+\t\"github.com/go-kit/kit/metrics\"\n+\t\"github.com/go-kit/kit/metrics/dogstatsd\"\n+\tkitexp \"github.com/go-kit/kit/metrics/expvar\"\n+\t\"github.com/go-kit/kit/metrics/graphite\"\n+\tkitprom \"github.com/go-kit/kit/metrics/prometheus\"\n+\t\"github.com/go-kit/kit/metrics/statsd\"\n+)\n+\n+// Provider represents a union set of constructors and lifecycle management\n+// functions for each supported metrics backend. It should be used by those who\n+// need to easily swap out implementations, e.g. dynamically, or at a single\n+// point in an intermediating framework.\n+type Provider interface {\n+\tNewCounter(name, help string) metrics.Counter\n+\tNewHistogram(name, help string, min, max int64, sigfigs int, quantiles ...int) (metrics.Histogram, error)\n+\tNewGauge(name, help string) metrics.Gauge\n+\tStop()\n+}\n+\n+// NewGraphiteProvider will return a Provider implementation that is a simple\n+// wrapper around a graphite.Emitter. All metric names will be prefixed with the\n+// given value and data will be emitted once every interval. If no network value\n+// is given, it will default to \"udp\".\n+func NewGraphiteProvider(network, address, prefix string, interval time.Duration, logger log.Logger) (Provider, error) {\n+\tif network == \"\" {\n+\t\tnetwork = \"udp\"\n+\t}\n+\tif address == \"\" {\n+\t\treturn nil, errors.New(\"address is required\")\n+\t}\n+\treturn graphiteProvider{\n+\t\te: graphite.NewEmitter(network, address, prefix, interval, logger),\n+\t}, nil\n+}\n+\n+type graphiteProvider struct {\n+\te *graphite.Emitter\n+}\n+\n+var _ Provider = graphiteProvider{}\n+\n+// NewCounter implements Provider. Help is ignored.\n+func (p graphiteProvider) NewCounter(name, _ string) metrics.Counter {\n+\treturn p.e.NewCounter(name)\n+}\n+\n+// NewHistogram implements Provider. Help is ignored.\n+func (p graphiteProvider) NewHistogram(name, _ string, min, max int64, sigfigs int, quantiles ...int) (metrics.Histogram, error) {\n+\treturn p.e.NewHistogram(name, min, max, sigfigs, quantiles...)\n+}\n+\n+// NewGauge implements Provider. Help is ignored.\n+func (p graphiteProvider) NewGauge(name, _ string) metrics.Gauge {\n+\treturn p.e.NewGauge(name)\n+}\n+\n+// Stop implements Provider.\n+func (p graphiteProvider) Stop() {\n+\tp.e.Stop()\n+}\n+\n+// NewStatsdProvider will return a Provider implementation that is a simple\n+// wrapper around a statsd.Emitter. All metric names will be prefixed with the\n+// given value and data will be emitted once every interval or when the buffer\n+// has reached its max size. If no network value is given, it will default to\n+// \"udp\".\n+func NewStatsdProvider(network, address, prefix string, interval time.Duration, logger log.Logger) (Provider, error) {\n+\tif network == \"\" {\n+\t\tnetwork = \"udp\"\n+\t}\n+\tif address == \"\" {\n+\t\treturn nil, errors.New(\"address is required\")\n+\t}\n+\treturn statsdProvider{\n+\t\te: statsd.NewEmitter(network, address, prefix, interval, logger),\n+\t}, nil\n+}\n+\n+type statsdProvider struct {\n+\te *statsd.Emitter\n+}\n+\n+var _ Provider = statsdProvider{}\n+\n+// NewCounter implements Provider. Help is ignored.\n+func (p statsdProvider) NewCounter(name, _ string) metrics.Counter {\n+\treturn p.e.NewCounter(name)\n+}\n+\n+// NewHistogram implements Provider. Help is ignored.\n+func (p statsdProvider) NewHistogram(name, _ string, min, max int64, sigfigs int, quantiles ...int) (metrics.Histogram, error) {\n+\treturn p.e.NewHistogram(name), nil\n+}\n+\n+// NewGauge implements Provider. Help is ignored.\n+func (p statsdProvider) NewGauge(name, _ string) metrics.Gauge {\n+\treturn p.e.NewGauge(name)\n+}\n+\n+// Stop will call the underlying statsd.Emitter's Stop method.\n+func (p statsdProvider) Stop() {\n+\tp.e.Stop()\n+}\n+\n+// NewDogStatsdProvider will return a Provider implementation that is a simple\n+// wrapper around a dogstatsd.Emitter. All metric names will be prefixed with\n+// the given value and data will be emitted once every interval or when the\n+// buffer has reached its max size. If no network value is given, it will\n+// default to \"udp\".\n+func NewDogStatsdProvider(network, address, prefix string, interval time.Duration, logger log.Logger) (Provider, error) {\n+\tif network == \"\" {\n+\t\tnetwork = \"udp\"\n+\t}\n+\tif address == \"\" {\n+\t\treturn nil, errors.New(\"address is required\")\n+\t}\n+\treturn dogstatsdProvider{\n+\t\te: dogstatsd.NewEmitter(network, address, prefix, interval, logger),\n+\t}, nil\n+}\n+\n+type dogstatsdProvider struct {\n+\te *dogstatsd.Emitter\n+}\n+\n+var _ Provider = dogstatsdProvider{}\n+\n+// NewCounter implements Provider. Help is ignored.\n+func (p dogstatsdProvider) NewCounter(name, _ string) metrics.Counter {\n+\treturn p.e.NewCounter(name)\n+}\n+\n+// NewHistogram implements Provider. Help is ignored.\n+func (p dogstatsdProvider) NewHistogram(name, _ string, min, max int64, sigfigs int, quantiles ...int) (metrics.Histogram, error) {\n+\treturn p.e.NewHistogram(name), nil\n+}\n+\n+// NewGauge implements Provider. Help is ignored.\n+func (p dogstatsdProvider) NewGauge(name, _ string) metrics.Gauge {\n+\treturn p.e.NewGauge(name)\n+}\n+\n+// Stop will call the underlying statsd.Emitter's Stop method.\n+func (p dogstatsdProvider) Stop() {\n+\tp.e.Stop()\n+}\n+\n+// NewExpvarProvider is a very thin wrapper over the expvar package.\n+// If a prefix is provided, it will prefix all metric names.\n+func NewExpvarProvider(prefix string) Provider {\n+\treturn expvarProvider{prefix: prefix}\n+}\n+\n+type expvarProvider struct {\n+\tprefix string\n+}\n+\n+var _ Provider = expvarProvider{}\n+\n+// NewCounter implements Provider. Help is ignored.\n+func (p expvarProvider) NewCounter(name, _ string) metrics.Counter {\n+\treturn kitexp.NewCounter(p.prefix + name)\n+}\n+\n+// NewHistogram implements Provider. Help is ignored.\n+func (p expvarProvider) NewHistogram(name, _ string, min, max int64, sigfigs int, quantiles ...int) (metrics.Histogram, error) {\n+\treturn kitexp.NewHistogram(p.prefix+name, min, max, sigfigs, quantiles...), nil\n+}\n+\n+// NewGauge implements Provider. Help is ignored.\n+func (p expvarProvider) NewGauge(name, _ string) metrics.Gauge {\n+\treturn kitexp.NewGauge(p.prefix + name)\n+}\n+\n+// Stop is a no-op.\n+func (expvarProvider) Stop() {}\n+\n+type prometheusProvider struct {\n+\tnamespace string\n+\tsubsystem string\n+}\n+\n+var _ Provider = prometheusProvider{}\n+\n+// NewPrometheusProvider returns a Prometheus provider that uses the provided\n+// namespace and subsystem for all metrics. Help is not provided, which is very","path":"metrics/provider/providers.go","position":195,"original_position":195,"commit_id":"8bbd545cae3a97352be1876f7a49e5932e2e67a4","original_commit_id":"8bbd545cae3a97352be1876f7a49e5932e2e67a4","user":{"login":"jprobinson","id":1386065,"avatar_url":"https://avatars.githubusercontent.com/u/1386065?v=3","gravatar_id":"","url":"https://api.github.com/users/jprobinson","html_url":"https://github.com/jprobinson","followers_url":"https://api.github.com/users/jprobinson/followers","following_url":"https://api.github.com/users/jprobinson/following{/other_user}","gists_url":"https://api.github.com/users/jprobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprobinson/subscriptions","organizations_url":"https://api.github.com/users/jprobinson/orgs","repos_url":"https://api.github.com/users/jprobinson/repos","events_url":"https://api.github.com/users/jprobinson/events{/privacy}","received_events_url":"https://api.github.com/users/jprobinson/received_events","type":"User","site_admin":false},"body":"Do we still need this note since we've added the \"help\" parameter to all of the implementations?","created_at":"2016-05-19T16:15:54Z","updated_at":"2016-05-19T16:15:54Z","html_url":"https://github.com/go-kit/kit/pull/268#discussion_r63908841","pull_request_url":"https://api.github.com/repos/go-kit/kit/pulls/268","_links":{"self":{"href":"https://api.github.com/repos/go-kit/kit/pulls/comments/63908841"},"html":{"href":"https://github.com/go-kit/kit/pull/268#discussion_r63908841"},"pull_request":{"href":"https://api.github.com/repos/go-kit/kit/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/go-kit/kit/pulls/268","id":70596720,"html_url":"https://github.com/go-kit/kit/pull/268","diff_url":"https://github.com/go-kit/kit/pull/268.diff","patch_url":"https://github.com/go-kit/kit/pull/268.patch","issue_url":"https://api.github.com/repos/go-kit/kit/issues/268","number":268,"state":"open","locked":false,"title":"Adding `metrics/graphite`, `metrics/provider` and `util/conn` packages plus `Emitter` types","user":{"login":"jprobinson","id":1386065,"avatar_url":"https://avatars.githubusercontent.com/u/1386065?v=3","gravatar_id":"","url":"https://api.github.com/users/jprobinson","html_url":"https://github.com/jprobinson","followers_url":"https://api.github.com/users/jprobinson/followers","following_url":"https://api.github.com/users/jprobinson/following{/other_user}","gists_url":"https://api.github.com/users/jprobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprobinson/subscriptions","organizations_url":"https://api.github.com/users/jprobinson/orgs","repos_url":"https://api.github.com/users/jprobinson/repos","events_url":"https://api.github.com/users/jprobinson/events{/privacy}","received_events_url":"https://api.github.com/users/jprobinson/received_events","type":"User","site_admin":false},"body":"This PR is hoping to knock out both issues #251 and #262.\r\n\r\nIncluded is the the new `Emitter` types for the `metrics/statsd` and `metrics/graphite` packages, both of which utilize the new `util/conn.Manager` connection manager.\r\n\r\nThe new `metrics/provider.Provider` is a thin layer over the new `Emitter` types along with very basic implementations for `expvar` and `prometheus`.\r\n\r\nThis PR currently lacks implementations for `dogstatsd` as I wanted to wait for feedback on the `statsd.Emitter` before continuing down the route and creating a `dogstatd.Emitter`.\r\n\r\nIf this PR is accepted, we can discard PR #259.","created_at":"2016-05-18T20:49:09Z","updated_at":"2016-05-19T16:15:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c2112e6af8d3a298ba959cb81078f508b87499c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-kit/kit/pulls/268/commits","review_comments_url":"https://api.github.com/repos/go-kit/kit/pulls/268/comments","review_comment_url":"https://api.github.com/repos/go-kit/kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-kit/kit/issues/268/comments","statuses_url":"https://api.github.com/repos/go-kit/kit/statuses/8bbd545cae3a97352be1876f7a49e5932e2e67a4","head":{"label":"jprobinson:provider","ref":"provider","sha":"8bbd545cae3a97352be1876f7a49e5932e2e67a4","user":{"login":"jprobinson","id":1386065,"avatar_url":"https://avatars.githubusercontent.com/u/1386065?v=3","gravatar_id":"","url":"https://api.github.com/users/jprobinson","html_url":"https://github.com/jprobinson","followers_url":"https://api.github.com/users/jprobinson/followers","following_url":"https://api.github.com/users/jprobinson/following{/other_user}","gists_url":"https://api.github.com/users/jprobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprobinson/subscriptions","organizations_url":"https://api.github.com/users/jprobinson/orgs","repos_url":"https://api.github.com/users/jprobinson/repos","events_url":"https://api.github.com/users/jprobinson/events{/privacy}","received_events_url":"https://api.github.com/users/jprobinson/received_events","type":"User","site_admin":false},"repo":{"id":58155983,"name":"kit","full_name":"jprobinson/kit","owner":{"login":"jprobinson","id":1386065,"avatar_url":"https://avatars.githubusercontent.com/u/1386065?v=3","gravatar_id":"","url":"https://api.github.com/users/jprobinson","html_url":"https://github.com/jprobinson","followers_url":"https://api.github.com/users/jprobinson/followers","following_url":"https://api.github.com/users/jprobinson/following{/other_user}","gists_url":"https://api.github.com/users/jprobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprobinson/subscriptions","organizations_url":"https://api.github.com/users/jprobinson/orgs","repos_url":"https://api.github.com/users/jprobinson/repos","events_url":"https://api.github.com/users/jprobinson/events{/privacy}","received_events_url":"https://api.github.com/users/jprobinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jprobinson/kit","description":"A standard library for microservices.","fork":true,"url":"https://api.github.com/repos/jprobinson/kit","forks_url":"https://api.github.com/repos/jprobinson/kit/forks","keys_url":"https://api.github.com/repos/jprobinson/kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jprobinson/kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jprobinson/kit/teams","hooks_url":"https://api.github.com/repos/jprobinson/kit/hooks","issue_events_url":"https://api.github.com/repos/jprobinson/kit/issues/events{/number}","events_url":"https://api.github.com/repos/jprobinson/kit/events","assignees_url":"https://api.github.com/repos/jprobinson/kit/assignees{/user}","branches_url":"https://api.github.com/repos/jprobinson/kit/branches{/branch}","tags_url":"https://api.github.com/repos/jprobinson/kit/tags","blobs_url":"https://api.github.com/repos/jprobinson/kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jprobinson/kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jprobinson/kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jprobinson/kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jprobinson/kit/statuses/{sha}","languages_url":"https://api.github.com/repos/jprobinson/kit/languages","stargazers_url":"https://api.github.com/repos/jprobinson/kit/stargazers","contributors_url":"https://api.github.com/repos/jprobinson/kit/contributors","subscribers_url":"https://api.github.com/repos/jprobinson/kit/subscribers","subscription_url":"https://api.github.com/repos/jprobinson/kit/subscription","commits_url":"https://api.github.com/repos/jprobinson/kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jprobinson/kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jprobinson/kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jprobinson/kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jprobinson/kit/contents/{+path}","compare_url":"https://api.github.com/repos/jprobinson/kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jprobinson/kit/merges","archive_url":"https://api.github.com/repos/jprobinson/kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jprobinson/kit/downloads","issues_url":"https://api.github.com/repos/jprobinson/kit/issues{/number}","pulls_url":"https://api.github.com/repos/jprobinson/kit/pulls{/number}","milestones_url":"https://api.github.com/repos/jprobinson/kit/milestones{/number}","notifications_url":"https://api.github.com/repos/jprobinson/kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jprobinson/kit/labels{/name}","releases_url":"https://api.github.com/repos/jprobinson/kit/releases{/id}","deployments_url":"https://api.github.com/repos/jprobinson/kit/deployments","created_at":"2016-05-05T19:39:15Z","updated_at":"2016-05-05T19:39:17Z","pushed_at":"2016-05-19T15:20:47Z","git_url":"git://github.com/jprobinson/kit.git","ssh_url":"git@github.com:jprobinson/kit.git","clone_url":"https://github.com/jprobinson/kit.git","svn_url":"https://github.com/jprobinson/kit","homepage":"http://gokit.io","size":4761,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-kit:master","ref":"master","sha":"9b342ab939309acce34c8cf94659404ea43409d5","user":{"login":"go-kit","id":10981023,"avatar_url":"https://avatars.githubusercontent.com/u/10981023?v=3","gravatar_id":"","url":"https://api.github.com/users/go-kit","html_url":"https://github.com/go-kit","followers_url":"https://api.github.com/users/go-kit/followers","following_url":"https://api.github.com/users/go-kit/following{/other_user}","gists_url":"https://api.github.com/users/go-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/go-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-kit/subscriptions","organizations_url":"https://api.github.com/users/go-kit/orgs","repos_url":"https://api.github.com/users/go-kit/repos","events_url":"https://api.github.com/users/go-kit/events{/privacy}","received_events_url":"https://api.github.com/users/go-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":30215630,"name":"kit","full_name":"go-kit/kit","owner":{"login":"go-kit","id":10981023,"avatar_url":"https://avatars.githubusercontent.com/u/10981023?v=3","gravatar_id":"","url":"https://api.github.com/users/go-kit","html_url":"https://github.com/go-kit","followers_url":"https://api.github.com/users/go-kit/followers","following_url":"https://api.github.com/users/go-kit/following{/other_user}","gists_url":"https://api.github.com/users/go-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/go-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-kit/subscriptions","organizations_url":"https://api.github.com/users/go-kit/orgs","repos_url":"https://api.github.com/users/go-kit/repos","events_url":"https://api.github.com/users/go-kit/events{/privacy}","received_events_url":"https://api.github.com/users/go-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-kit/kit","description":"A standard library for microservices.","fork":false,"url":"https://api.github.com/repos/go-kit/kit","forks_url":"https://api.github.com/repos/go-kit/kit/forks","keys_url":"https://api.github.com/repos/go-kit/kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-kit/kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-kit/kit/teams","hooks_url":"https://api.github.com/repos/go-kit/kit/hooks","issue_events_url":"https://api.github.com/repos/go-kit/kit/issues/events{/number}","events_url":"https://api.github.com/repos/go-kit/kit/events","assignees_url":"https://api.github.com/repos/go-kit/kit/assignees{/user}","branches_url":"https://api.github.com/repos/go-kit/kit/branches{/branch}","tags_url":"https://api.github.com/repos/go-kit/kit/tags","blobs_url":"https://api.github.com/repos/go-kit/kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-kit/kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-kit/kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-kit/kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-kit/kit/statuses/{sha}","languages_url":"https://api.github.com/repos/go-kit/kit/languages","stargazers_url":"https://api.github.com/repos/go-kit/kit/stargazers","contributors_url":"https://api.github.com/repos/go-kit/kit/contributors","subscribers_url":"https://api.github.com/repos/go-kit/kit/subscribers","subscription_url":"https://api.github.com/repos/go-kit/kit/subscription","commits_url":"https://api.github.com/repos/go-kit/kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-kit/kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-kit/kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-kit/kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-kit/kit/contents/{+path}","compare_url":"https://api.github.com/repos/go-kit/kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-kit/kit/merges","archive_url":"https://api.github.com/repos/go-kit/kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-kit/kit/downloads","issues_url":"https://api.github.com/repos/go-kit/kit/issues{/number}","pulls_url":"https://api.github.com/repos/go-kit/kit/pulls{/number}","milestones_url":"https://api.github.com/repos/go-kit/kit/milestones{/number}","notifications_url":"https://api.github.com/repos/go-kit/kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-kit/kit/labels{/name}","releases_url":"https://api.github.com/repos/go-kit/kit/releases{/id}","deployments_url":"https://api.github.com/repos/go-kit/kit/deployments","created_at":"2015-02-03T00:01:19Z","updated_at":"2016-05-19T15:19:13Z","pushed_at":"2016-05-19T15:20:48Z","git_url":"git://github.com/go-kit/kit.git","ssh_url":"git@github.com:go-kit/kit.git","clone_url":"https://github.com/go-kit/kit.git","svn_url":"https://github.com/go-kit/kit","homepage":"http://gokit.io","size":7919,"stargazers_count":4320,"watchers_count":4320,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":330,"mirror_url":null,"open_issues_count":28,"forks":330,"open_issues":28,"watchers":4320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-kit/kit/pulls/268"},"html":{"href":"https://github.com/go-kit/kit/pull/268"},"issue":{"href":"https://api.github.com/repos/go-kit/kit/issues/268"},"comments":{"href":"https://api.github.com/repos/go-kit/kit/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/go-kit/kit/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/go-kit/kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-kit/kit/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/go-kit/kit/statuses/8bbd545cae3a97352be1876f7a49e5932e2e67a4"}}}}