{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/29039","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/29039/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/29039/comments","events_url":"https://api.github.com/repos/docker/docker/issues/29039/events","html_url":"https://github.com/docker/docker/pull/29039","id":192967345,"number":29039,"title":"Fix restartpolicy max-retry validation","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"labels":[{"id":333712692,"url":"https://api.github.com/repos/docker/docker/labels/process/cherry-pick","name":"process/cherry-pick","color":"a98bf3","default":false},{"id":175375407,"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":111,"closed_issues":1099,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-12-01T21:29:12Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-12-01T21:29:07Z","updated_at":"2016-12-01T21:34:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/29039","html_url":"https://github.com/docker/docker/pull/29039","diff_url":"https://github.com/docker/docker/pull/29039.diff","patch_url":"https://github.com/docker/docker/pull/29039.patch"},"body":"the restart policy validation was moved from\r\nthe client to the daemon in 94e95e4711643640701bd614902e75a2d01f12c5 (https://github.com/docker/docker/pull/24073)\r\n\r\nAs part of that change, retry-counts < 1 were marked as \"invalid\".\r\nHowever, the default is 0 (unlimited), causing\r\n\r\n    docker run -d --restart=on-failure nginx\r\n\r\nTo fail.\r\n\r\nThis changes the validation to only invalidate retry-counts < 0.\r\n\r\nA test was added, and other tests renamed to allow running just these tests :)\r\n\r\nfixes https://github.com/docker/docker/issues/29035"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/264302386","html_url":"https://github.com/docker/docker/pull/29039#issuecomment-264302386","issue_url":"https://api.github.com/repos/docker/docker/issues/29039","id":264302386,"user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T21:34:58Z","updated_at":"2016-12-01T21:34:58Z","body":"Perhaps a CLI test as well?"}}
{"actor":{"display_login":"cpuguy83"}}