{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1127","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1127/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1127/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1127/events","html_url":"https://github.com/greenplum-db/gpdb/pull/1127","id":177142521,"number":1127,"title":"Allow for test program compilation to override CFLAGS","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-15T10:33:50Z","updated_at":"2016-09-15T16:18:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1127","html_url":"https://github.com/greenplum-db/gpdb/pull/1127","diff_url":"https://github.com/greenplum-db/gpdb/pull/1127.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1127.patch"},"body":"In case a test program requires a specialized set of CFLAGS, allow it to be overriden with `LOCAL_CFLAGS` and `LOCAL_CFLAGS_FILTER`. Also include an override from the tcop tests where -O3 is causing problems with post-ereport assertions (reported to -dev in https://groups.google.com/a/greenplum.org/forum/#!topic/gpdb-dev/sFMpzprBWG4). By going with -O0 we can instruct the compiler to not remove unreachable code which allows the test to perform assertions after the ereport."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/247376533","html_url":"https://github.com/greenplum-db/gpdb/pull/1127#issuecomment-247376533","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1127","id":247376533,"user":{"login":"asimrp","id":4307811,"avatar_url":"https://avatars.githubusercontent.com/u/4307811?v=3","gravatar_id":"","url":"https://api.github.com/users/asimrp","html_url":"https://github.com/asimrp","followers_url":"https://api.github.com/users/asimrp/followers","following_url":"https://api.github.com/users/asimrp/following{/other_user}","gists_url":"https://api.github.com/users/asimrp/gists{/gist_id}","starred_url":"https://api.github.com/users/asimrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimrp/subscriptions","organizations_url":"https://api.github.com/users/asimrp/orgs","repos_url":"https://api.github.com/users/asimrp/repos","events_url":"https://api.github.com/users/asimrp/events{/privacy}","received_events_url":"https://api.github.com/users/asimrp/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T16:18:52Z","updated_at":"2016-09-15T16:18:52Z","body":"I tried this PR on my OSX.  The tcop test continues to fail.  Looking at the compile command, I still see the O3 flag there.\r\n```\r\napraveen ~/gpdb/src/backend/tcop/test]$ git show -s \r\ncommit 07c8dbd7bf1487a74c0bb25853487acf38753018\r\nAuthor: Daniel Gustafsson <dgustafsson@pivotal.io>\r\nDate:   Thu Sep 15 12:28:04 2016 +0200\r\n\r\n    Allow for test program compilation to override CFLAGS\r\n    \r\n    In case a test program requires a specialized set of CFLAGS it can\r\n    be overriden with LOCAL_CFLAGS and LOCAL_CFLAGS_FILTER.\r\n    \r\n    Also include an override from the tcop tests where -O3 is causing\r\n    problems with post-ereport assertions.\r\n[apraveen ~/gpdb/src/backend/tcop/test]$\r\n[apraveen ~/gpdb/src/backend/tcop/test]$ make\r\ngcc -no-cpp-precomp -O3 -std=gnu99  -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -Wno-address -g -ggdb  -w -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -I../../../../src/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/libxml2  -I../../../../src/test/unit/cmockery -I../../../../src/backend/libpq -I../../../../src/backend/gp_libpq_fe -I../../../../src/backend/postmaster -I. -I../../../../src/port -DDLSUFFIX=.so -I../../../../src/backend/utils/stat  -c -o postgres_test.o postgres_test.c\r\ngcc -no-cpp-precomp -O3 -std=gnu99  -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -Wno-address -g -ggdb  -w -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -I../../../../src/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/libxml2  -I../../../../src/test/unit/cmockery -I../../../../src/backend/libpq -I../../../../src/backend/gp_libpq_fe -I../../../../src/backend/postmaster -I. -I../../../../src/port -DDLSUFFIX=.so -I../../../../src/backend/utils/stat  -c -o ../../../../src/test/unit/mock/backend/utils/error/elog_mock.o ../../../../src/test/unit/mock/backend/utils/error/elog_mock.c\r\n\r\n   ...\r\n\r\n[apraveen ~/gpdb/src/backend/tcop/test]$ ./postgres.t \r\n[ RUN         ] test__IsTransactionExitStmtList__MultipleElementList\r\n[          OK ] test__IsTransactionExitStmtList__MultipleElementList\r\n[ RUN         ] test__IsTransactionExitStmt__IsTransactionStmt\r\n[          OK ] test__IsTransactionExitStmt__IsTransactionStmt\r\n[ RUN         ] test__IsTransactionExitStmt__IsQuery\r\n[          OK ] test__IsTransactionExitStmt__IsQuery\r\n[ RUN         ] test__ProcessInterrupts__ClientConnectionLost\r\nAbort trap: 6\r\n[apraveen ~/gpdb/src/backend/tcop/test]$\r\n```"}}
{"actor":{"display_login":"asimrp"}}