{"action":"created","comment":{"url":"https://api.github.com/repos/rsim/ruby-plsql/pulls/comments/94018751","pull_request_review_id":14548556,"id":94018751,"diff_hunk":"@@ -5,21 +5,31 @@\n   # ojdbc6.jar or ojdbc5.jar file should be in JRUBY_HOME/lib or should be in ENV['PATH'] or load path\n \n   java_version = java.lang.System.getProperty(\"java.version\")\n-  ojdbc_jar = if java_version =~ /^1.5/\n+  ojdbc_jars = if java_version =~ /^1.5/\n     \"ojdbc5.jar\"\n-  elsif java_version >= '1.6'\n+  elsif java_version =~ /^1.6/\n     \"ojdbc6.jar\"\n+  elsif java_version >= \"1.7\"\n+    # Oracle 11g client ojdbc6.jar is also compatible with Java 1.7\n+    # Oracle 12c client provides new ojdbc7.jar\n+    %w(ojdbc7.jar ojdbc6.jar)\n   else\n     nil\n   end\n \n-  unless ENV_JAVA['java.class.path'] =~ Regexp.new(ojdbc_jar)\n+  if ojdbc_jars && ENV_JAVA[\"java.class.path\"] !~ Regexp.new(ojdbc_jars.join(\"|\"))","path":"lib/plsql/jdbc_connection.rb","position":19,"original_position":19,"commit_id":"b2ac2da6b74608cfb0c193058eb0a6691c5d56f6","original_commit_id":"b2ac2da6b74608cfb0c193058eb0a6691c5d56f6","user":{"login":"javornikolov","id":203471,"avatar_url":"https://avatars.githubusercontent.com/u/203471?v=3","gravatar_id":"","url":"https://api.github.com/users/javornikolov","html_url":"https://github.com/javornikolov","followers_url":"https://api.github.com/users/javornikolov/followers","following_url":"https://api.github.com/users/javornikolov/following{/other_user}","gists_url":"https://api.github.com/users/javornikolov/gists{/gist_id}","starred_url":"https://api.github.com/users/javornikolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javornikolov/subscriptions","organizations_url":"https://api.github.com/users/javornikolov/orgs","repos_url":"https://api.github.com/users/javornikolov/repos","events_url":"https://api.github.com/users/javornikolov/events{/privacy}","received_events_url":"https://api.github.com/users/javornikolov/received_events","type":"User","site_admin":false},"body":"`join` doesn't work on plain string so I guess this would currently fail for Java < 1.7.","created_at":"2016-12-28T10:46:39Z","updated_at":"2016-12-28T10:46:39Z","html_url":"https://github.com/rsim/ruby-plsql/pull/120#discussion_r94018751","pull_request_url":"https://api.github.com/repos/rsim/ruby-plsql/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/rsim/ruby-plsql/pulls/comments/94018751"},"html":{"href":"https://github.com/rsim/ruby-plsql/pull/120#discussion_r94018751"},"pull_request":{"href":"https://api.github.com/repos/rsim/ruby-plsql/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/rsim/ruby-plsql/pulls/120","id":99502927,"html_url":"https://github.com/rsim/ruby-plsql/pull/120","diff_url":"https://github.com/rsim/ruby-plsql/pull/120.diff","patch_url":"https://github.com/rsim/ruby-plsql/pull/120.patch","issue_url":"https://api.github.com/repos/rsim/ruby-plsql/issues/120","number":120,"state":"open","locked":false,"title":"Allow ojdbc7.jar when Java version is 1.7 or higher","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"body":"This pull request allows to use ojdbc7.jar when Java version is 1.7 or higher.\r\n\r\nRefer http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-faq-090281.html#01_02 for JDBC driver and JDK version matrix.","created_at":"2016-12-28T02:51:27Z","updated_at":"2016-12-28T10:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e30d699774f16ae2075e66a0e5fff24c3accf1a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rsim/ruby-plsql/pulls/120/commits","review_comments_url":"https://api.github.com/repos/rsim/ruby-plsql/pulls/120/comments","review_comment_url":"https://api.github.com/repos/rsim/ruby-plsql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsim/ruby-plsql/issues/120/comments","statuses_url":"https://api.github.com/repos/rsim/ruby-plsql/statuses/b2ac2da6b74608cfb0c193058eb0a6691c5d56f6","head":{"label":"yahonda:allow_ojdbc7","ref":"allow_ojdbc7","sha":"b2ac2da6b74608cfb0c193058eb0a6691c5d56f6","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"repo":{"id":2792356,"name":"ruby-plsql","full_name":"yahonda/ruby-plsql","owner":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yahonda/ruby-plsql","description":"ruby-plsql gem provides simple Ruby API for calling Oracle PL/SQL procedures. It could be used both for accessing Oracle PL/SQL API procedures in legacy applications as well as it could be used to create PL/SQL unit tests using Ruby testing libraries.","fork":true,"url":"https://api.github.com/repos/yahonda/ruby-plsql","forks_url":"https://api.github.com/repos/yahonda/ruby-plsql/forks","keys_url":"https://api.github.com/repos/yahonda/ruby-plsql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahonda/ruby-plsql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahonda/ruby-plsql/teams","hooks_url":"https://api.github.com/repos/yahonda/ruby-plsql/hooks","issue_events_url":"https://api.github.com/repos/yahonda/ruby-plsql/issues/events{/number}","events_url":"https://api.github.com/repos/yahonda/ruby-plsql/events","assignees_url":"https://api.github.com/repos/yahonda/ruby-plsql/assignees{/user}","branches_url":"https://api.github.com/repos/yahonda/ruby-plsql/branches{/branch}","tags_url":"https://api.github.com/repos/yahonda/ruby-plsql/tags","blobs_url":"https://api.github.com/repos/yahonda/ruby-plsql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahonda/ruby-plsql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahonda/ruby-plsql/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahonda/ruby-plsql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahonda/ruby-plsql/statuses/{sha}","languages_url":"https://api.github.com/repos/yahonda/ruby-plsql/languages","stargazers_url":"https://api.github.com/repos/yahonda/ruby-plsql/stargazers","contributors_url":"https://api.github.com/repos/yahonda/ruby-plsql/contributors","subscribers_url":"https://api.github.com/repos/yahonda/ruby-plsql/subscribers","subscription_url":"https://api.github.com/repos/yahonda/ruby-plsql/subscription","commits_url":"https://api.github.com/repos/yahonda/ruby-plsql/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahonda/ruby-plsql/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahonda/ruby-plsql/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahonda/ruby-plsql/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahonda/ruby-plsql/contents/{+path}","compare_url":"https://api.github.com/repos/yahonda/ruby-plsql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahonda/ruby-plsql/merges","archive_url":"https://api.github.com/repos/yahonda/ruby-plsql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahonda/ruby-plsql/downloads","issues_url":"https://api.github.com/repos/yahonda/ruby-plsql/issues{/number}","pulls_url":"https://api.github.com/repos/yahonda/ruby-plsql/pulls{/number}","milestones_url":"https://api.github.com/repos/yahonda/ruby-plsql/milestones{/number}","notifications_url":"https://api.github.com/repos/yahonda/ruby-plsql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahonda/ruby-plsql/labels{/name}","releases_url":"https://api.github.com/repos/yahonda/ruby-plsql/releases{/id}","deployments_url":"https://api.github.com/repos/yahonda/ruby-plsql/deployments","created_at":"2011-11-17T01:00:34Z","updated_at":"2016-07-17T04:33:59Z","pushed_at":"2016-12-28T02:24:30Z","git_url":"git://github.com/yahonda/ruby-plsql.git","ssh_url":"git@github.com:yahonda/ruby-plsql.git","clone_url":"https://github.com/yahonda/ruby-plsql.git","svn_url":"https://github.com/yahonda/ruby-plsql","homepage":"","size":540,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rsim:master","ref":"master","sha":"c34abca2d142df882997d32701e8ca7166d0c727","user":{"login":"rsim","id":4736,"avatar_url":"https://avatars.githubusercontent.com/u/4736?v=3","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"repo":{"id":11137,"name":"ruby-plsql","full_name":"rsim/ruby-plsql","owner":{"login":"rsim","id":4736,"avatar_url":"https://avatars.githubusercontent.com/u/4736?v=3","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsim/ruby-plsql","description":"ruby-plsql gem provides simple Ruby API for calling Oracle PL/SQL procedures. It could be used both for accessing Oracle PL/SQL API procedures in legacy applications as well as it could be used to create PL/SQL unit tests using Ruby testing libraries.","fork":false,"url":"https://api.github.com/repos/rsim/ruby-plsql","forks_url":"https://api.github.com/repos/rsim/ruby-plsql/forks","keys_url":"https://api.github.com/repos/rsim/ruby-plsql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsim/ruby-plsql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsim/ruby-plsql/teams","hooks_url":"https://api.github.com/repos/rsim/ruby-plsql/hooks","issue_events_url":"https://api.github.com/repos/rsim/ruby-plsql/issues/events{/number}","events_url":"https://api.github.com/repos/rsim/ruby-plsql/events","assignees_url":"https://api.github.com/repos/rsim/ruby-plsql/assignees{/user}","branches_url":"https://api.github.com/repos/rsim/ruby-plsql/branches{/branch}","tags_url":"https://api.github.com/repos/rsim/ruby-plsql/tags","blobs_url":"https://api.github.com/repos/rsim/ruby-plsql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsim/ruby-plsql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsim/ruby-plsql/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsim/ruby-plsql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsim/ruby-plsql/statuses/{sha}","languages_url":"https://api.github.com/repos/rsim/ruby-plsql/languages","stargazers_url":"https://api.github.com/repos/rsim/ruby-plsql/stargazers","contributors_url":"https://api.github.com/repos/rsim/ruby-plsql/contributors","subscribers_url":"https://api.github.com/repos/rsim/ruby-plsql/subscribers","subscription_url":"https://api.github.com/repos/rsim/ruby-plsql/subscription","commits_url":"https://api.github.com/repos/rsim/ruby-plsql/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsim/ruby-plsql/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsim/ruby-plsql/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsim/ruby-plsql/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsim/ruby-plsql/contents/{+path}","compare_url":"https://api.github.com/repos/rsim/ruby-plsql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsim/ruby-plsql/merges","archive_url":"https://api.github.com/repos/rsim/ruby-plsql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsim/ruby-plsql/downloads","issues_url":"https://api.github.com/repos/rsim/ruby-plsql/issues{/number}","pulls_url":"https://api.github.com/repos/rsim/ruby-plsql/pulls{/number}","milestones_url":"https://api.github.com/repos/rsim/ruby-plsql/milestones{/number}","notifications_url":"https://api.github.com/repos/rsim/ruby-plsql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsim/ruby-plsql/labels{/name}","releases_url":"https://api.github.com/repos/rsim/ruby-plsql/releases{/id}","deployments_url":"https://api.github.com/repos/rsim/ruby-plsql/deployments","created_at":"2008-04-19T14:49:12Z","updated_at":"2016-11-03T17:44:13Z","pushed_at":"2016-12-28T02:51:29Z","git_url":"git://github.com/rsim/ruby-plsql.git","ssh_url":"git@github.com:rsim/ruby-plsql.git","clone_url":"https://github.com/rsim/ruby-plsql.git","svn_url":"https://github.com/rsim/ruby-plsql","homepage":"","size":542,"stargazers_count":117,"watchers_count":117,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":27,"forks":44,"open_issues":27,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsim/ruby-plsql/pulls/120"},"html":{"href":"https://github.com/rsim/ruby-plsql/pull/120"},"issue":{"href":"https://api.github.com/repos/rsim/ruby-plsql/issues/120"},"comments":{"href":"https://api.github.com/repos/rsim/ruby-plsql/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/rsim/ruby-plsql/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/rsim/ruby-plsql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsim/ruby-plsql/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/rsim/ruby-plsql/statuses/b2ac2da6b74608cfb0c193058eb0a6691c5d56f6"}}}}
{"actor":{"display_login":"javornikolov"}}