{"action":"created","comment":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/comments/86487222","pull_request_review_id":7144415,"id":86487222,"diff_hunk":"@@ -461,11 +461,16 @@ def calculateModifiedAttributes(self, targetFit=None, withBoosters=False, dirtyS\n         timer = Timer(u'Fit: {}, {}'.format(self.ID, self.name), logger)\n         logger.debug(\"Starting fit calculation on: %r, withBoosters: %s\", self, withBoosters)\n \n+        try:\n+            projectionInfo = self.getProjectionInfo(targetFit.ID)\n+        except:\n+            pass\n+        else:\n+            logger.debug(\"ProjectionInfo: %s\", projectionInfo)\n+","path":"eos/saveddata/fit.py","position":null,"original_position":10,"commit_id":"928246a8cab668b787d17476b2a92d1091966970","original_commit_id":"4036ac8cd22bde8f288b85179c2aa34995572ae5","user":{"login":"Ebag333","id":7693907,"avatar_url":"https://avatars.githubusercontent.com/u/7693907?v=3","gravatar_id":"","url":"https://api.github.com/users/Ebag333","html_url":"https://github.com/Ebag333","followers_url":"https://api.github.com/users/Ebag333/followers","following_url":"https://api.github.com/users/Ebag333/following{/other_user}","gists_url":"https://api.github.com/users/Ebag333/gists{/gist_id}","starred_url":"https://api.github.com/users/Ebag333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ebag333/subscriptions","organizations_url":"https://api.github.com/users/Ebag333/orgs","repos_url":"https://api.github.com/users/Ebag333/repos","events_url":"https://api.github.com/users/Ebag333/events{/privacy}","received_events_url":"https://api.github.com/users/Ebag333/received_events","type":"User","site_admin":false},"body":">Or, you could probably set projectionInfo = None outside the if statement, and put the debug log back in the if block. That assigns the variables and prevents pyCharm from yelling whatever obscenities it yells with this kind of 'error'. I would be okay with that, and it looks cleaner. :)\r\n\r\nBrilliant! \r\n\r\nExcept I already tried this, and then pyCharm complains that it's assigned and not used, because it knows it's a bullshit assignment. ☺\r\n\r\nI'll revert it for now, we can look at it later. It's not a major thing. ","created_at":"2016-11-04T04:18:27Z","updated_at":"2016-11-04T04:18:27Z","html_url":"https://github.com/pyfa-org/Pyfa/pull/774#discussion_r86487222","pull_request_url":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/774","_links":{"self":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/comments/86487222"},"html":{"href":"https://github.com/pyfa-org/Pyfa/pull/774#discussion_r86487222"},"pull_request":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/774"}}},"pull_request":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/774","id":90094675,"html_url":"https://github.com/pyfa-org/Pyfa/pull/774","diff_url":"https://github.com/pyfa-org/Pyfa/pull/774.diff","patch_url":"https://github.com/pyfa-org/Pyfa/pull/774.patch","issue_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/774","number":774,"state":"open","locked":false,"title":"Eos Code Cleanup","user":{"login":"Ebag333","id":7693907,"avatar_url":"https://avatars.githubusercontent.com/u/7693907?v=3","gravatar_id":"","url":"https://api.github.com/users/Ebag333","html_url":"https://github.com/Ebag333","followers_url":"https://api.github.com/users/Ebag333/followers","following_url":"https://api.github.com/users/Ebag333/following{/other_user}","gists_url":"https://api.github.com/users/Ebag333/gists{/gist_id}","starred_url":"https://api.github.com/users/Ebag333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ebag333/subscriptions","organizations_url":"https://api.github.com/users/Ebag333/orgs","repos_url":"https://api.github.com/users/Ebag333/repos","events_url":"https://api.github.com/users/Ebag333/events{/privacy}","received_events_url":"https://api.github.com/users/Ebag333/received_events","type":"User","site_admin":false},"body":"_LOTS_ of cleanup.\n\nActual code changes are _very_ minimal, only what is strictly necessary to handle validation/inspection issues.\n\nAfter code cleanup, inspection for `Eos` shows:\n(this excludes `eos.effects` as that is a bit of a mess)\n342 warnings\n1031 weak warnings\n\nPre-cleanup (again no `eos.effects`):\n424 warnings\n2038 weak warnings\n\n.\nFor `eos.effects` post: \n0 warnings\n2001 weak warnings\n\nFor `eos.effects` pre:\n6 warnings\n5592 weak warnings\n\nUnfortunately a lot of the warnings can't be easily cleaned up.  There's a slew of shadowing warnings because of variable names we use, and virtually every effect file contains weak warnings about unused local variables because `context` is rarely used.\n\nSome of the other warnings will be cleared up in another PR I will be submitting shortly (regarding requirements).\n","created_at":"2016-10-19T21:31:46Z","updated_at":"2016-11-04T04:18:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80a2492e8ce7020583dbcdee3bae08a925fbff4b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/774/commits","review_comments_url":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/774/comments","review_comment_url":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/774/comments","statuses_url":"https://api.github.com/repos/pyfa-org/Pyfa/statuses/928246a8cab668b787d17476b2a92d1091966970","head":{"label":"Ebag333:EosCodeCleanup","ref":"EosCodeCleanup","sha":"928246a8cab668b787d17476b2a92d1091966970","user":{"login":"Ebag333","id":7693907,"avatar_url":"https://avatars.githubusercontent.com/u/7693907?v=3","gravatar_id":"","url":"https://api.github.com/users/Ebag333","html_url":"https://github.com/Ebag333","followers_url":"https://api.github.com/users/Ebag333/followers","following_url":"https://api.github.com/users/Ebag333/following{/other_user}","gists_url":"https://api.github.com/users/Ebag333/gists{/gist_id}","starred_url":"https://api.github.com/users/Ebag333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ebag333/subscriptions","organizations_url":"https://api.github.com/users/Ebag333/orgs","repos_url":"https://api.github.com/users/Ebag333/repos","events_url":"https://api.github.com/users/Ebag333/events{/privacy}","received_events_url":"https://api.github.com/users/Ebag333/received_events","type":"User","site_admin":false},"repo":{"id":58230346,"name":"Pyfa","full_name":"Ebag333/Pyfa","owner":{"login":"Ebag333","id":7693907,"avatar_url":"https://avatars.githubusercontent.com/u/7693907?v=3","gravatar_id":"","url":"https://api.github.com/users/Ebag333","html_url":"https://github.com/Ebag333","followers_url":"https://api.github.com/users/Ebag333/followers","following_url":"https://api.github.com/users/Ebag333/following{/other_user}","gists_url":"https://api.github.com/users/Ebag333/gists{/gist_id}","starred_url":"https://api.github.com/users/Ebag333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ebag333/subscriptions","organizations_url":"https://api.github.com/users/Ebag333/orgs","repos_url":"https://api.github.com/users/Ebag333/repos","events_url":"https://api.github.com/users/Ebag333/events{/privacy}","received_events_url":"https://api.github.com/users/Ebag333/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ebag333/Pyfa","description":"Python fitting assistant, cross-platform fitting tool for EVE Online","fork":true,"url":"https://api.github.com/repos/Ebag333/Pyfa","forks_url":"https://api.github.com/repos/Ebag333/Pyfa/forks","keys_url":"https://api.github.com/repos/Ebag333/Pyfa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ebag333/Pyfa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ebag333/Pyfa/teams","hooks_url":"https://api.github.com/repos/Ebag333/Pyfa/hooks","issue_events_url":"https://api.github.com/repos/Ebag333/Pyfa/issues/events{/number}","events_url":"https://api.github.com/repos/Ebag333/Pyfa/events","assignees_url":"https://api.github.com/repos/Ebag333/Pyfa/assignees{/user}","branches_url":"https://api.github.com/repos/Ebag333/Pyfa/branches{/branch}","tags_url":"https://api.github.com/repos/Ebag333/Pyfa/tags","blobs_url":"https://api.github.com/repos/Ebag333/Pyfa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ebag333/Pyfa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ebag333/Pyfa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ebag333/Pyfa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ebag333/Pyfa/statuses/{sha}","languages_url":"https://api.github.com/repos/Ebag333/Pyfa/languages","stargazers_url":"https://api.github.com/repos/Ebag333/Pyfa/stargazers","contributors_url":"https://api.github.com/repos/Ebag333/Pyfa/contributors","subscribers_url":"https://api.github.com/repos/Ebag333/Pyfa/subscribers","subscription_url":"https://api.github.com/repos/Ebag333/Pyfa/subscription","commits_url":"https://api.github.com/repos/Ebag333/Pyfa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ebag333/Pyfa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ebag333/Pyfa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ebag333/Pyfa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ebag333/Pyfa/contents/{+path}","compare_url":"https://api.github.com/repos/Ebag333/Pyfa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ebag333/Pyfa/merges","archive_url":"https://api.github.com/repos/Ebag333/Pyfa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ebag333/Pyfa/downloads","issues_url":"https://api.github.com/repos/Ebag333/Pyfa/issues{/number}","pulls_url":"https://api.github.com/repos/Ebag333/Pyfa/pulls{/number}","milestones_url":"https://api.github.com/repos/Ebag333/Pyfa/milestones{/number}","notifications_url":"https://api.github.com/repos/Ebag333/Pyfa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ebag333/Pyfa/labels{/name}","releases_url":"https://api.github.com/repos/Ebag333/Pyfa/releases{/id}","deployments_url":"https://api.github.com/repos/Ebag333/Pyfa/deployments","created_at":"2016-05-06T19:30:15Z","updated_at":"2016-07-07T09:48:03Z","pushed_at":"2016-10-26T17:09:59Z","git_url":"git://github.com/Ebag333/Pyfa.git","ssh_url":"git@github.com:Ebag333/Pyfa.git","clone_url":"https://github.com/Ebag333/Pyfa.git","svn_url":"https://github.com/Ebag333/Pyfa","homepage":null,"size":226241,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pyfa-org:master","ref":"master","sha":"f1771a61d0a599e63ba1cf696f43685a0a2c8e3e","user":{"login":"pyfa-org","id":16587622,"avatar_url":"https://avatars.githubusercontent.com/u/16587622?v=3","gravatar_id":"","url":"https://api.github.com/users/pyfa-org","html_url":"https://github.com/pyfa-org","followers_url":"https://api.github.com/users/pyfa-org/followers","following_url":"https://api.github.com/users/pyfa-org/following{/other_user}","gists_url":"https://api.github.com/users/pyfa-org/gists{/gist_id}","starred_url":"https://api.github.com/users/pyfa-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyfa-org/subscriptions","organizations_url":"https://api.github.com/users/pyfa-org/orgs","repos_url":"https://api.github.com/users/pyfa-org/repos","events_url":"https://api.github.com/users/pyfa-org/events{/privacy}","received_events_url":"https://api.github.com/users/pyfa-org/received_events","type":"Organization","site_admin":false},"repo":{"id":10608253,"name":"Pyfa","full_name":"pyfa-org/Pyfa","owner":{"login":"pyfa-org","id":16587622,"avatar_url":"https://avatars.githubusercontent.com/u/16587622?v=3","gravatar_id":"","url":"https://api.github.com/users/pyfa-org","html_url":"https://github.com/pyfa-org","followers_url":"https://api.github.com/users/pyfa-org/followers","following_url":"https://api.github.com/users/pyfa-org/following{/other_user}","gists_url":"https://api.github.com/users/pyfa-org/gists{/gist_id}","starred_url":"https://api.github.com/users/pyfa-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyfa-org/subscriptions","organizations_url":"https://api.github.com/users/pyfa-org/orgs","repos_url":"https://api.github.com/users/pyfa-org/repos","events_url":"https://api.github.com/users/pyfa-org/events{/privacy}","received_events_url":"https://api.github.com/users/pyfa-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyfa-org/Pyfa","description":"Python fitting assistant, cross-platform fitting tool for EVE Online","fork":false,"url":"https://api.github.com/repos/pyfa-org/Pyfa","forks_url":"https://api.github.com/repos/pyfa-org/Pyfa/forks","keys_url":"https://api.github.com/repos/pyfa-org/Pyfa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyfa-org/Pyfa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyfa-org/Pyfa/teams","hooks_url":"https://api.github.com/repos/pyfa-org/Pyfa/hooks","issue_events_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/events{/number}","events_url":"https://api.github.com/repos/pyfa-org/Pyfa/events","assignees_url":"https://api.github.com/repos/pyfa-org/Pyfa/assignees{/user}","branches_url":"https://api.github.com/repos/pyfa-org/Pyfa/branches{/branch}","tags_url":"https://api.github.com/repos/pyfa-org/Pyfa/tags","blobs_url":"https://api.github.com/repos/pyfa-org/Pyfa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyfa-org/Pyfa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyfa-org/Pyfa/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyfa-org/Pyfa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyfa-org/Pyfa/statuses/{sha}","languages_url":"https://api.github.com/repos/pyfa-org/Pyfa/languages","stargazers_url":"https://api.github.com/repos/pyfa-org/Pyfa/stargazers","contributors_url":"https://api.github.com/repos/pyfa-org/Pyfa/contributors","subscribers_url":"https://api.github.com/repos/pyfa-org/Pyfa/subscribers","subscription_url":"https://api.github.com/repos/pyfa-org/Pyfa/subscription","commits_url":"https://api.github.com/repos/pyfa-org/Pyfa/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyfa-org/Pyfa/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyfa-org/Pyfa/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyfa-org/Pyfa/contents/{+path}","compare_url":"https://api.github.com/repos/pyfa-org/Pyfa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyfa-org/Pyfa/merges","archive_url":"https://api.github.com/repos/pyfa-org/Pyfa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyfa-org/Pyfa/downloads","issues_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues{/number}","pulls_url":"https://api.github.com/repos/pyfa-org/Pyfa/pulls{/number}","milestones_url":"https://api.github.com/repos/pyfa-org/Pyfa/milestones{/number}","notifications_url":"https://api.github.com/repos/pyfa-org/Pyfa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyfa-org/Pyfa/labels{/name}","releases_url":"https://api.github.com/repos/pyfa-org/Pyfa/releases{/id}","deployments_url":"https://api.github.com/repos/pyfa-org/Pyfa/deployments","created_at":"2013-06-10T20:00:53Z","updated_at":"2016-11-02T15:22:27Z","pushed_at":"2016-11-03T19:01:24Z","git_url":"git://github.com/pyfa-org/Pyfa.git","ssh_url":"git@github.com:pyfa-org/Pyfa.git","clone_url":"https://github.com/pyfa-org/Pyfa.git","svn_url":"https://github.com/pyfa-org/Pyfa","homepage":null,"size":234484,"stargazers_count":508,"watchers_count":508,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":125,"forks":158,"open_issues":125,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/774"},"html":{"href":"https://github.com/pyfa-org/Pyfa/pull/774"},"issue":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/issues/774"},"comments":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/issues/774/comments"},"review_comments":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/774/comments"},"review_comment":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/pulls/774/commits"},"statuses":{"href":"https://api.github.com/repos/pyfa-org/Pyfa/statuses/928246a8cab668b787d17476b2a92d1091966970"}}}}
{"actor":{"display_login":"Ebag333"}}