{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/comments/72256935","id":72256935,"diff_hunk":"@@ -362,6 +363,11 @@ def publish_brief(framework_slug, lot_slug, brief_id):\n             question_and_answers['slug'] = section['id']\n \n     unanswered_required, unanswered_optional = count_unanswered_questions(sections)\n+\n+    if sections.get_section('set-how-long-your-requirements-will-be-live-for') and \\\n+            sections.get_section('set-how-long-your-requirements-will-be-live-for').questions[0].answer_required:\n+            unanswered_required -= 1","path":"app/buyers/views/buyers.py","position":21,"original_position":21,"commit_id":"5f6685878ea532d420ae5a8ac168999dc6ff9bee","original_commit_id":"5f6685878ea532d420ae5a8ac168999dc6ff9bee","user":{"login":"idavidmcdonald","id":7228605,"avatar_url":"https://avatars.githubusercontent.com/u/7228605?v=3","gravatar_id":"","url":"https://api.github.com/users/idavidmcdonald","html_url":"https://github.com/idavidmcdonald","followers_url":"https://api.github.com/users/idavidmcdonald/followers","following_url":"https://api.github.com/users/idavidmcdonald/following{/other_user}","gists_url":"https://api.github.com/users/idavidmcdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/idavidmcdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idavidmcdonald/subscriptions","organizations_url":"https://api.github.com/users/idavidmcdonald/orgs","repos_url":"https://api.github.com/users/idavidmcdonald/repos","events_url":"https://api.github.com/users/idavidmcdonald/events{/privacy}","received_events_url":"https://api.github.com/users/idavidmcdonald/received_events","type":"User","site_admin":false},"body":"So it's clear that we are decreasing the unanswered_required question count by one, but it might be good to put a one line comment _why_ we are doing this","created_at":"2016-07-26T14:13:45Z","updated_at":"2016-07-26T14:13:45Z","html_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/365#discussion_r72256935","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/comments/72256935"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/365#discussion_r72256935"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/365","id":78674223,"html_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/365","diff_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/365.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/365.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/365","number":365,"state":"open","locked":false,"title":"Specialist briefs can be open for 1 or two weeks","user":{"login":"Wynndow","id":13836290,"avatar_url":"https://avatars.githubusercontent.com/u/13836290?v=3","gravatar_id":"","url":"https://api.github.com/users/Wynndow","html_url":"https://github.com/Wynndow","followers_url":"https://api.github.com/users/Wynndow/followers","following_url":"https://api.github.com/users/Wynndow/following{/other_user}","gists_url":"https://api.github.com/users/Wynndow/gists{/gist_id}","starred_url":"https://api.github.com/users/Wynndow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wynndow/subscriptions","organizations_url":"https://api.github.com/users/Wynndow/orgs","repos_url":"https://api.github.com/users/Wynndow/repos","events_url":"https://api.github.com/users/Wynndow/events{/privacy}","received_events_url":"https://api.github.com/users/Wynndow/received_events","type":"User","site_admin":false},"body":"For [this](https://www.pivotaltracker.com/story/show/123706751) story on Pivotal.\r\n\r\nWill need separate PR's on [utils](https://github.com/alphagov/digitalmarketplace-utils/pull/275), [apiclient](https://github.com/alphagov/digitalmarketplace-apiclient/pull/30), [api](https://github.com/alphagov/digitalmarketplace-api/pull/422) and [frameworks](https://github.com/alphagov/digitalmarketplace-frameworks/pull/294) to be accepted before this one.\r\n\r\nThe logic for calculating dates has been moved to dmutils so that it can be used by other apps, specifically the api app.\r\n\r\nThe dates are shown on the publishing page when the buyer is creating a brief and are dependent on the brief length chosen during creation of the brief. If that question hasn't been answered yet a link to the question is shown instead.\r\n\r\nThe catalogue of briefs is ordered slightly differently now; by live then closed, and by publishing date within that. The published date is also displayed for briefs to give more context.\r\n\r\nThe dmspeak styles have been imported from the frontend toolkit for use on the publishing page, which was using prototype styles which had leaked into the app.\r\n\r\nScreenshots\r\n---------------\r\n\r\nRequirements length question in overview.\r\n\r\n<img width=\"736\" alt=\"screen shot 2016-07-25 at 13 26 53\" src=\"https://cloud.githubusercontent.com/assets/13836290/17101469/a8ed532e-526c-11e6-98a8-4c29394a2fe8.png\">\r\n---------------\r\nSelecting length\r\n\r\n<img width=\"698\" alt=\"screen shot 2016-07-25 at 13 27 22\" src=\"https://cloud.githubusercontent.com/assets/13836290/17101485/bd729d4a-526c-11e6-96bf-5b9a8108a574.png\">\r\n---------------\r\nPublishing page with no length set\r\n\r\n<img width=\"662\" alt=\"screen shot 2016-07-25 at 13 28 58\" src=\"https://cloud.githubusercontent.com/assets/13836290/17101500/dceb663e-526c-11e6-8856-88869dcbe336.png\">\r\n---------------\r\nPublishing page with length set\r\n\r\n<img width=\"686\" alt=\"screen shot 2016-07-25 at 13 27 45\" src=\"https://cloud.githubusercontent.com/assets/13836290/17101522/f6b60290-526c-11e6-899e-4a61e8a508a8.png\">\r\n----------------\r\nPublishing page with length set and no outstanding required questions.\r\n\r\n<img width=\"664\" alt=\"screen shot 2016-07-25 at 13 30 42\" src=\"https://cloud.githubusercontent.com/assets/13836290/17101539/132899ec-526d-11e6-8ff4-455aebba1bd7.png\">\r\n----------------\r\nDates post publishing\r\n\r\n<img width=\"670\" alt=\"screen shot 2016-07-25 at 13 31 07\" src=\"https://cloud.githubusercontent.com/assets/13836290/17101561/34ebfb8c-526d-11e6-9a79-eb2bd5788b51.png\">\r\n---------------\r\nBriefs catalogue\r\n<img width=\"771\" alt=\"screen shot 2016-07-25 at 13 31 20\" src=\"https://cloud.githubusercontent.com/assets/13836290/17101641/957472f4-526d-11e6-8ce3-05ce3fc48e7d.png\">\r\n<img width=\"725\" alt=\"screen shot 2016-07-25 at 13 31 37\" src=\"https://cloud.githubusercontent.com/assets/13836290/17101648/98a00ce0-526d-11e6-9b2d-694a9977a81c.png\">\r\n\r\n\r\n\r\n","created_at":"2016-07-25T12:41:08Z","updated_at":"2016-07-26T14:13:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10bd81b55c9f654dd58743829ee1d7c55aaa7cb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/365/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/365/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/365/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/statuses/5f6685878ea532d420ae5a8ac168999dc6ff9bee","head":{"label":"alphagov:1_week_or_two","ref":"1_week_or_two","sha":"5f6685878ea532d420ae5a8ac168999dc6ff9bee","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31320841,"name":"digitalmarketplace-buyer-frontend","full_name":"alphagov/digitalmarketplace-buyer-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend","description":"Frontend buyer application for the digital marketplace","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/deployments","created_at":"2015-02-25T15:42:09Z","updated_at":"2016-01-13T11:02:36Z","pushed_at":"2016-07-25T13:28:32Z","git_url":"git://github.com/alphagov/digitalmarketplace-buyer-frontend.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-buyer-frontend.git","clone_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend.git","svn_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend","homepage":"","size":1730,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"1345def27e74ef7a677a49269b938a2ad97dca68","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31320841,"name":"digitalmarketplace-buyer-frontend","full_name":"alphagov/digitalmarketplace-buyer-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend","description":"Frontend buyer application for the digital marketplace","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/deployments","created_at":"2015-02-25T15:42:09Z","updated_at":"2016-01-13T11:02:36Z","pushed_at":"2016-07-25T13:28:32Z","git_url":"git://github.com/alphagov/digitalmarketplace-buyer-frontend.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-buyer-frontend.git","clone_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend.git","svn_url":"https://github.com/alphagov/digitalmarketplace-buyer-frontend","homepage":"","size":1730,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/365"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/365"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/365"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-buyer-frontend/statuses/5f6685878ea532d420ae5a8ac168999dc6ff9bee"}}}}
{"actor":{"display_login":"idavidmcdonald"}}