{"action":"closed","number":978,"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/978","id":73841870,"html_url":"https://github.com/docker/swarmkit/pull/978","diff_url":"https://github.com/docker/swarmkit/pull/978.diff","patch_url":"https://github.com/docker/swarmkit/pull/978.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/978","number":978,"state":"closed","locked":false,"title":"agent/exec: revise error handling approach","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"Errors returned from controller methods are now all treated as fatal by\r\nthe the task controller. The defers most retries to the orchestration\r\nlayer, where they can be better handled. We also cement the concept of a\r\n\"Temporary\" error, allowing an Executor/Controller to signal to the\r\ncaller that the error is actually temporary. We can mark these as\r\ntemporary as we find cases where it makes more sense.\r\n\r\nSigned-off-by: Stephen J Day <stephen.day@docker.com>\r\n\r\nCloses #970, among others.\r\n\r\ncc @tonistiigi @dongluochen @cpuguy83 @aluzzardi ","created_at":"2016-06-15T02:02:45Z","updated_at":"2016-06-15T18:52:54Z","closed_at":"2016-06-15T18:52:53Z","merged_at":"2016-06-15T18:52:53Z","merge_commit_sha":"ff98e62144100063d1c9ca4bac20f8051a6cace7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/978/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/978/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/978/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/5c1c0b0a74125a11b63d5d9f22791ec5acf82c70","head":{"label":"stevvooe:fatal-errors","ref":"fatal-errors","sha":"5c1c0b0a74125a11b63d5d9f22791ec5acf82c70","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"repo":{"id":60661861,"name":"swarmkit","full_name":"stevvooe/swarmkit","owner":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevvooe/swarmkit","description":"A toolkit for embedding orchestration and cluster management capabilities in your application","fork":true,"url":"https://api.github.com/repos/stevvooe/swarmkit","forks_url":"https://api.github.com/repos/stevvooe/swarmkit/forks","keys_url":"https://api.github.com/repos/stevvooe/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevvooe/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevvooe/swarmkit/teams","hooks_url":"https://api.github.com/repos/stevvooe/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/stevvooe/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/stevvooe/swarmkit/events","assignees_url":"https://api.github.com/repos/stevvooe/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/stevvooe/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/stevvooe/swarmkit/tags","blobs_url":"https://api.github.com/repos/stevvooe/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevvooe/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevvooe/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevvooe/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevvooe/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/stevvooe/swarmkit/languages","stargazers_url":"https://api.github.com/repos/stevvooe/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/stevvooe/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/stevvooe/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/stevvooe/swarmkit/subscription","commits_url":"https://api.github.com/repos/stevvooe/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevvooe/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevvooe/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevvooe/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevvooe/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/stevvooe/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevvooe/swarmkit/merges","archive_url":"https://api.github.com/repos/stevvooe/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevvooe/swarmkit/downloads","issues_url":"https://api.github.com/repos/stevvooe/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/stevvooe/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/stevvooe/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/stevvooe/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevvooe/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/stevvooe/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/stevvooe/swarmkit/deployments","created_at":"2016-06-08T02:23:25Z","updated_at":"2016-06-08T02:23:27Z","pushed_at":"2016-06-15T18:21:57Z","git_url":"git://github.com/stevvooe/swarmkit.git","ssh_url":"git@github.com:stevvooe/swarmkit.git","clone_url":"https://github.com/stevvooe/swarmkit.git","svn_url":"https://github.com/stevvooe/swarmkit","homepage":"","size":7653,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"682e0b69be208176d6055cba855a5e9cf15c7cb4","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"name":"swarmkit","full_name":"docker/swarmkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2016-06-15T18:27:02Z","pushed_at":"2016-06-15T18:52:54Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":17416,"stargazers_count":591,"watchers_count":591,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":121,"forks":74,"open_issues":121,"watchers":591,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/978"},"html":{"href":"https://github.com/docker/swarmkit/pull/978"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/978"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/978/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/978/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/978/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/5c1c0b0a74125a11b63d5d9f22791ec5acf82c70"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"comments":6,"review_comments":9,"commits":3,"additions":2324,"deletions":186,"changed_files":55}}
{"actor":{"display_login":"stevvooe"}}