{"action":"created","comment":{"url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/comments/61294611","id":61294611,"diff_hunk":"@@ -18,6 +18,8 @@\n \n require 'spec_helper'\n \n+require 'vra/http'","path":"spec/catalog_request_spec.rb","position":null,"original_position":4,"commit_id":"12f56ed89d77295a4e7d5a3ea67e384182adcbd8","original_commit_id":"398a7a73a2f1e9e1e23dbdba292d94d8df2ea551","user":{"login":"regularfry","id":39277,"avatar_url":"https://avatars.githubusercontent.com/u/39277?v=3","gravatar_id":"","url":"https://api.github.com/users/regularfry","html_url":"https://github.com/regularfry","followers_url":"https://api.github.com/users/regularfry/followers","following_url":"https://api.github.com/users/regularfry/following{/other_user}","gists_url":"https://api.github.com/users/regularfry/gists{/gist_id}","starred_url":"https://api.github.com/users/regularfry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regularfry/subscriptions","organizations_url":"https://api.github.com/users/regularfry/orgs","repos_url":"https://api.github.com/users/regularfry/repos","events_url":"https://api.github.com/users/regularfry/events{/privacy}","received_events_url":"https://api.github.com/users/regularfry/received_events","type":"User","site_admin":false},"body":"It was a left-over from the tests in a more nascent form.  Happily dropped.","created_at":"2016-04-27T16:52:27Z","updated_at":"2016-04-27T16:52:27Z","html_url":"https://github.com/chef-partners/vmware-vra-gem/pull/28#discussion_r61294611","pull_request_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/comments/61294611"},"html":{"href":"https://github.com/chef-partners/vmware-vra-gem/pull/28#discussion_r61294611"},"pull_request":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/28","id":68064098,"html_url":"https://github.com/chef-partners/vmware-vra-gem/pull/28","diff_url":"https://github.com/chef-partners/vmware-vra-gem/pull/28.diff","patch_url":"https://github.com/chef-partners/vmware-vra-gem/pull/28.patch","issue_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/issues/28","number":28,"state":"open","locked":false,"title":"Remove rest-client dependency","user":{"login":"regularfry","id":39277,"avatar_url":"https://avatars.githubusercontent.com/u/39277?v=3","gravatar_id":"","url":"https://api.github.com/users/regularfry","html_url":"https://github.com/regularfry","followers_url":"https://api.github.com/users/regularfry/followers","following_url":"https://api.github.com/users/regularfry/following{/other_user}","gists_url":"https://api.github.com/users/regularfry/gists{/gist_id}","starred_url":"https://api.github.com/users/regularfry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regularfry/subscriptions","organizations_url":"https://api.github.com/users/regularfry/orgs","repos_url":"https://api.github.com/users/regularfry/repos","events_url":"https://api.github.com/users/regularfry/events{/privacy}","received_events_url":"https://api.github.com/users/regularfry/received_events","type":"User","site_admin":false},"body":"This patch removes the dependency on the rest-client gem.\r\n\r\nThis has mostly been achieved by replacing RestClient-specific API calls with a\r\nsmall `Net::HTTP` wrapper in `lib/vra/http.rb`.  A reasonable attempt has been made\r\nto retain RestClient's HTTP request lifecycle behaviour and exception raising,\r\nto minimise the impact of the change.\r\n\r\nSome refactoring has also been done to the users of `Vra::Client`, to simplify the\r\nremoval slightly.","created_at":"2016-04-27T14:35:50Z","updated_at":"2016-04-27T16:52:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0a919744dc976ff4c36eda15d9dceebe4dd95c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/28/commits","review_comments_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/28/comments","review_comment_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/issues/28/comments","statuses_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/statuses/12f56ed89d77295a4e7d5a3ea67e384182adcbd8","head":{"label":"sky-uk:remove-rest-client","ref":"remove-rest-client","sha":"12f56ed89d77295a4e7d5a3ea67e384182adcbd8","user":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars.githubusercontent.com/u/1391938?v=3","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"repo":{"id":57131403,"name":"vmware-vra-gem","full_name":"sky-uk/vmware-vra-gem","owner":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars.githubusercontent.com/u/1391938?v=3","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sky-uk/vmware-vra-gem","description":"Gem for interacting with the VMware vRealize Automation system.","fork":true,"url":"https://api.github.com/repos/sky-uk/vmware-vra-gem","forks_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/forks","keys_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/teams","hooks_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/hooks","issue_events_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/issues/events{/number}","events_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/events","assignees_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/assignees{/user}","branches_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/branches{/branch}","tags_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/tags","blobs_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/git/refs{/sha}","trees_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/statuses/{sha}","languages_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/languages","stargazers_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/stargazers","contributors_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/contributors","subscribers_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/subscribers","subscription_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/subscription","commits_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/commits{/sha}","git_commits_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/git/commits{/sha}","comments_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/comments{/number}","issue_comment_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/issues/comments{/number}","contents_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/contents/{+path}","compare_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/merges","archive_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/downloads","issues_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/issues{/number}","pulls_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/pulls{/number}","milestones_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/milestones{/number}","notifications_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/labels{/name}","releases_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/releases{/id}","deployments_url":"https://api.github.com/repos/sky-uk/vmware-vra-gem/deployments","created_at":"2016-04-26T13:41:38Z","updated_at":"2016-04-26T13:41:39Z","pushed_at":"2016-04-27T16:51:20Z","git_url":"git://github.com/sky-uk/vmware-vra-gem.git","ssh_url":"git@github.com:sky-uk/vmware-vra-gem.git","clone_url":"https://github.com/sky-uk/vmware-vra-gem.git","svn_url":"https://github.com/sky-uk/vmware-vra-gem","homepage":null,"size":99,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef-partners:master","ref":"master","sha":"602bffc8f8d4764e6de20e1ef356f6577fe25c96","user":{"login":"chef-partners","id":6988876,"avatar_url":"https://avatars.githubusercontent.com/u/6988876?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-partners","html_url":"https://github.com/chef-partners","followers_url":"https://api.github.com/users/chef-partners/followers","following_url":"https://api.github.com/users/chef-partners/following{/other_user}","gists_url":"https://api.github.com/users/chef-partners/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-partners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-partners/subscriptions","organizations_url":"https://api.github.com/users/chef-partners/orgs","repos_url":"https://api.github.com/users/chef-partners/repos","events_url":"https://api.github.com/users/chef-partners/events{/privacy}","received_events_url":"https://api.github.com/users/chef-partners/received_events","type":"Organization","site_admin":false},"repo":{"id":39275246,"name":"vmware-vra-gem","full_name":"chef-partners/vmware-vra-gem","owner":{"login":"chef-partners","id":6988876,"avatar_url":"https://avatars.githubusercontent.com/u/6988876?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-partners","html_url":"https://github.com/chef-partners","followers_url":"https://api.github.com/users/chef-partners/followers","following_url":"https://api.github.com/users/chef-partners/following{/other_user}","gists_url":"https://api.github.com/users/chef-partners/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-partners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-partners/subscriptions","organizations_url":"https://api.github.com/users/chef-partners/orgs","repos_url":"https://api.github.com/users/chef-partners/repos","events_url":"https://api.github.com/users/chef-partners/events{/privacy}","received_events_url":"https://api.github.com/users/chef-partners/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-partners/vmware-vra-gem","description":"Gem for interacting with the VMware vRealize Automation system.","fork":false,"url":"https://api.github.com/repos/chef-partners/vmware-vra-gem","forks_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/forks","keys_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/teams","hooks_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/hooks","issue_events_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/issues/events{/number}","events_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/events","assignees_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/assignees{/user}","branches_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/branches{/branch}","tags_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/tags","blobs_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/languages","stargazers_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/stargazers","contributors_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/contributors","subscribers_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/subscribers","subscription_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/subscription","commits_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/contents/{+path}","compare_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/merges","archive_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/downloads","issues_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/issues{/number}","pulls_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/labels{/name}","releases_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/releases{/id}","deployments_url":"https://api.github.com/repos/chef-partners/vmware-vra-gem/deployments","created_at":"2015-07-17T21:06:47Z","updated_at":"2016-03-31T22:57:35Z","pushed_at":"2016-04-27T16:51:20Z","git_url":"git://github.com/chef-partners/vmware-vra-gem.git","ssh_url":"git@github.com:chef-partners/vmware-vra-gem.git","clone_url":"https://github.com/chef-partners/vmware-vra-gem.git","svn_url":"https://github.com/chef-partners/vmware-vra-gem","homepage":null,"size":92,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/28"},"html":{"href":"https://github.com/chef-partners/vmware-vra-gem/pull/28"},"issue":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/issues/28"},"comments":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/chef-partners/vmware-vra-gem/statuses/12f56ed89d77295a4e7d5a3ea67e384182adcbd8"}}}}