{"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3/pulls/comments/90447868","pull_request_review_id":10965634,"id":90447868,"diff_hunk":"@@ -54,13 +61,18 @@ def create_learner(self):\n             n_estimators=self.n_estimators,\n             learning_rate=self.learning_rate,\n             preprocessors=self.preprocessors,\n-            algorithm=self.losses[self.algorithm]\n-        )\n+            algorithm=self.losses[self.algorithm])\n \n     def set_base_learner(self, learner):\n-        self.base_estimator = learner if learner \\\n-            else self.DEFAULT_BASE_ESTIMATOR\n-        self.base_label.setText(\"Base estimator: \" + self.base_estimator.name)\n+        self.Error.no_weight_support.clear()\n+        if learner and not learner.supports_weights:\n+            # Clear the error and reset to default base learner\n+            self.Error.no_weight_support()\n+            self.base_estimator = self.DEFAULT_BASE_ESTIMATOR\n+        else:\n+            self.base_estimator = learner or self.DEFAULT_BASE_ESTIMATOR\n+            self.base_label.setText(","path":"Orange/widgets/classify/owadaboost.py","position":60,"original_position":60,"commit_id":"6a4a0d193ce1e87b5369e5d0090df233a03f437e","original_commit_id":"6a4a0d193ce1e87b5369e5d0090df233a03f437e","user":{"login":"lanzagar","id":4579717,"avatar_url":"https://avatars.githubusercontent.com/u/4579717?v=3","gravatar_id":"","url":"https://api.github.com/users/lanzagar","html_url":"https://github.com/lanzagar","followers_url":"https://api.github.com/users/lanzagar/followers","following_url":"https://api.github.com/users/lanzagar/following{/other_user}","gists_url":"https://api.github.com/users/lanzagar/gists{/gist_id}","starred_url":"https://api.github.com/users/lanzagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanzagar/subscriptions","organizations_url":"https://api.github.com/users/lanzagar/orgs","repos_url":"https://api.github.com/users/lanzagar/repos","events_url":"https://api.github.com/users/lanzagar/events{/privacy}","received_events_url":"https://api.github.com/users/lanzagar/received_events","type":"User","site_admin":false},"body":"This should be outside of the else block (remove one indent).\r\nIt sets the base_estimator correctly now, but not the label.","created_at":"2016-12-01T13:41:01Z","updated_at":"2016-12-01T13:44:20Z","html_url":"https://github.com/biolab/orange3/pull/1787#discussion_r90447868","pull_request_url":"https://api.github.com/repos/biolab/orange3/pulls/1787","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/90447868"},"html":{"href":"https://github.com/biolab/orange3/pull/1787#discussion_r90447868"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1787"}}},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/1787","id":95868950,"html_url":"https://github.com/biolab/orange3/pull/1787","diff_url":"https://github.com/biolab/orange3/pull/1787.diff","patch_url":"https://github.com/biolab/orange3/pull/1787.patch","issue_url":"https://api.github.com/repos/biolab/orange3/issues/1787","number":1787,"state":"open","locked":false,"title":"[FIX] Improve ada boost widget","user":{"login":"pavlin-policar","id":5758119,"avatar_url":"https://avatars.githubusercontent.com/u/5758119?v=3","gravatar_id":"","url":"https://api.github.com/users/pavlin-policar","html_url":"https://github.com/pavlin-policar","followers_url":"https://api.github.com/users/pavlin-policar/followers","following_url":"https://api.github.com/users/pavlin-policar/following{/other_user}","gists_url":"https://api.github.com/users/pavlin-policar/gists{/gist_id}","starred_url":"https://api.github.com/users/pavlin-policar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavlin-policar/subscriptions","organizations_url":"https://api.github.com/users/pavlin-policar/orgs","repos_url":"https://api.github.com/users/pavlin-policar/repos","events_url":"https://api.github.com/users/pavlin-policar/events{/privacy}","received_events_url":"https://api.github.com/users/pavlin-policar/received_events","type":"User","site_admin":false},"body":"##### Issue\r\nAdaBoost simply crashed when a learner without support for `sample_weights` was put onto the input.\r\n\r\n##### Description of changes\r\nThis does not happen any more, but it uses the Orange widget Error that tells us that the learner doesn't support sample weights. I've also changed the control widths to match most of the other learner widgets.\r\n\r\n##### Includes\r\n- [X] Code changes\r\n- [X] Tests\r\n- [ ] Documentation\r\n","created_at":"2016-11-30T10:55:08Z","updated_at":"2016-12-01T13:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e18ba2e717ebab9b4bafccd0ffb3ad6ae8913419","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/biolab/orange3/milestones/4","html_url":"https://github.com/biolab/orange3/milestones/3.3.9","labels_url":"https://api.github.com/repos/biolab/orange3/milestones/4/labels","id":2157641,"number":4,"title":"3.3.9","description":"","creator":{"login":"lanzagar","id":4579717,"avatar_url":"https://avatars.githubusercontent.com/u/4579717?v=3","gravatar_id":"","url":"https://api.github.com/users/lanzagar","html_url":"https://github.com/lanzagar","followers_url":"https://api.github.com/users/lanzagar/followers","following_url":"https://api.github.com/users/lanzagar/following{/other_user}","gists_url":"https://api.github.com/users/lanzagar/gists{/gist_id}","starred_url":"https://api.github.com/users/lanzagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanzagar/subscriptions","organizations_url":"https://api.github.com/users/lanzagar/orgs","repos_url":"https://api.github.com/users/lanzagar/repos","events_url":"https://api.github.com/users/lanzagar/events{/privacy}","received_events_url":"https://api.github.com/users/lanzagar/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":60,"state":"open","created_at":"2016-11-25T13:14:49Z","updated_at":"2016-12-01T11:35:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/biolab/orange3/pulls/1787/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3/pulls/1787/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/1787/comments","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/6a4a0d193ce1e87b5369e5d0090df233a03f437e","head":{"label":"pavlin-policar:improve-ada-boost-widget","ref":"improve-ada-boost-widget","sha":"6a4a0d193ce1e87b5369e5d0090df233a03f437e","user":{"login":"pavlin-policar","id":5758119,"avatar_url":"https://avatars.githubusercontent.com/u/5758119?v=3","gravatar_id":"","url":"https://api.github.com/users/pavlin-policar","html_url":"https://github.com/pavlin-policar","followers_url":"https://api.github.com/users/pavlin-policar/followers","following_url":"https://api.github.com/users/pavlin-policar/following{/other_user}","gists_url":"https://api.github.com/users/pavlin-policar/gists{/gist_id}","starred_url":"https://api.github.com/users/pavlin-policar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavlin-policar/subscriptions","organizations_url":"https://api.github.com/users/pavlin-policar/orgs","repos_url":"https://api.github.com/users/pavlin-policar/repos","events_url":"https://api.github.com/users/pavlin-policar/events{/privacy}","received_events_url":"https://api.github.com/users/pavlin-policar/received_events","type":"User","site_admin":false},"repo":{"id":55218103,"name":"orange3","full_name":"pavlin-policar/orange3","owner":{"login":"pavlin-policar","id":5758119,"avatar_url":"https://avatars.githubusercontent.com/u/5758119?v=3","gravatar_id":"","url":"https://api.github.com/users/pavlin-policar","html_url":"https://github.com/pavlin-policar","followers_url":"https://api.github.com/users/pavlin-policar/followers","following_url":"https://api.github.com/users/pavlin-policar/following{/other_user}","gists_url":"https://api.github.com/users/pavlin-policar/gists{/gist_id}","starred_url":"https://api.github.com/users/pavlin-policar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavlin-policar/subscriptions","organizations_url":"https://api.github.com/users/pavlin-policar/orgs","repos_url":"https://api.github.com/users/pavlin-policar/repos","events_url":"https://api.github.com/users/pavlin-policar/events{/privacy}","received_events_url":"https://api.github.com/users/pavlin-policar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavlin-policar/orange3","description":"Orange 3 data mining suite: http://orange.biolab.si ","fork":true,"url":"https://api.github.com/repos/pavlin-policar/orange3","forks_url":"https://api.github.com/repos/pavlin-policar/orange3/forks","keys_url":"https://api.github.com/repos/pavlin-policar/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavlin-policar/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavlin-policar/orange3/teams","hooks_url":"https://api.github.com/repos/pavlin-policar/orange3/hooks","issue_events_url":"https://api.github.com/repos/pavlin-policar/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/pavlin-policar/orange3/events","assignees_url":"https://api.github.com/repos/pavlin-policar/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/pavlin-policar/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/pavlin-policar/orange3/tags","blobs_url":"https://api.github.com/repos/pavlin-policar/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavlin-policar/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavlin-policar/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavlin-policar/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavlin-policar/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/pavlin-policar/orange3/languages","stargazers_url":"https://api.github.com/repos/pavlin-policar/orange3/stargazers","contributors_url":"https://api.github.com/repos/pavlin-policar/orange3/contributors","subscribers_url":"https://api.github.com/repos/pavlin-policar/orange3/subscribers","subscription_url":"https://api.github.com/repos/pavlin-policar/orange3/subscription","commits_url":"https://api.github.com/repos/pavlin-policar/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavlin-policar/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavlin-policar/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavlin-policar/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavlin-policar/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/pavlin-policar/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavlin-policar/orange3/merges","archive_url":"https://api.github.com/repos/pavlin-policar/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavlin-policar/orange3/downloads","issues_url":"https://api.github.com/repos/pavlin-policar/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/pavlin-policar/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/pavlin-policar/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/pavlin-policar/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavlin-policar/orange3/labels{/name}","releases_url":"https://api.github.com/repos/pavlin-policar/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/pavlin-policar/orange3/deployments","created_at":"2016-04-01T08:58:41Z","updated_at":"2016-04-01T08:58:44Z","pushed_at":"2016-11-30T12:36:34Z","git_url":"git://github.com/pavlin-policar/orange3.git","ssh_url":"git@github.com:pavlin-policar/orange3.git","clone_url":"https://github.com/pavlin-policar/orange3.git","svn_url":"https://github.com/pavlin-policar/orange3","homepage":"","size":55667,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"28efe7e197a136587443148d5e7e9e264a6a5bf5","user":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":8357227,"name":"orange3","full_name":"biolab/orange3","owner":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biolab/orange3","description":"Orange 3 data mining suite: http://orange.biolab.si ","fork":false,"url":"https://api.github.com/repos/biolab/orange3","forks_url":"https://api.github.com/repos/biolab/orange3/forks","keys_url":"https://api.github.com/repos/biolab/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3/teams","hooks_url":"https://api.github.com/repos/biolab/orange3/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3/events","assignees_url":"https://api.github.com/repos/biolab/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3/tags","blobs_url":"https://api.github.com/repos/biolab/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3/subscription","commits_url":"https://api.github.com/repos/biolab/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/biolab/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3/merges","archive_url":"https://api.github.com/repos/biolab/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3/downloads","issues_url":"https://api.github.com/repos/biolab/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/biolab/orange3/deployments","created_at":"2013-02-22T12:52:56Z","updated_at":"2016-12-01T09:39:28Z","pushed_at":"2016-12-01T13:44:43Z","git_url":"git://github.com/biolab/orange3.git","ssh_url":"git@github.com:biolab/orange3.git","clone_url":"https://github.com/biolab/orange3.git","svn_url":"https://github.com/biolab/orange3","homepage":"","size":97512,"stargazers_count":568,"watchers_count":568,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":77,"forks":184,"open_issues":77,"watchers":568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1787"},"html":{"href":"https://github.com/biolab/orange3/pull/1787"},"issue":{"href":"https://api.github.com/repos/biolab/orange3/issues/1787"},"comments":{"href":"https://api.github.com/repos/biolab/orange3/issues/1787/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1787/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1787/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3/statuses/6a4a0d193ce1e87b5369e5d0090df233a03f437e"}}}}
{"actor":{"display_login":"lanzagar"}}