{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/91581117","pull_request_review_id":12091091,"id":91581117,"diff_hunk":"@@ -24,6 +30,26 @@ func ParseEnvironment(vals ...string) Environment {\n \treturn env\n }\n \n+func ParseEnvironment(vals ...string) (Environment, []string, []error) {","path":"pkg/generate/app/env.go","position":32,"original_position":32,"commit_id":"9ebcda44f1ccfc70c7d679f80eb83b9d643d08f9","original_commit_id":"9ebcda44f1ccfc70c7d679f80eb83b9d643d08f9","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"body":"This looks like it would accepts invalid things for env keys. What happens if you do for example \r\n\r\n```--env=\"S P A C E S=test\"```\r\n\r\nor have that pair in the file? Env vars are very strict about what's accepted for names, since you still have `validArgumentEnvironment`, make use of it.","created_at":"2016-12-08T18:53:12Z","updated_at":"2016-12-08T18:53:12Z","html_url":"https://github.com/openshift/origin/pull/12164#discussion_r91581117","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/12164","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/91581117"},"html":{"href":"https://github.com/openshift/origin/pull/12164#discussion_r91581117"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/12164"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/12164","id":96822765,"html_url":"https://github.com/openshift/origin/pull/12164","diff_url":"https://github.com/openshift/origin/pull/12164.diff","patch_url":"https://github.com/openshift/origin/pull/12164.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/12164","number":12164,"state":"open","locked":false,"title":"oc new-app/new-build/process: add --env-file/--param-file parameters","user":{"login":"mmilata","id":85857,"avatar_url":"https://avatars.githubusercontent.com/u/85857?v=3","gravatar_id":"","url":"https://api.github.com/users/mmilata","html_url":"https://github.com/mmilata","followers_url":"https://api.github.com/users/mmilata/followers","following_url":"https://api.github.com/users/mmilata/following{/other_user}","gists_url":"https://api.github.com/users/mmilata/gists{/gist_id}","starred_url":"https://api.github.com/users/mmilata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmilata/subscriptions","organizations_url":"https://api.github.com/users/mmilata/orgs","repos_url":"https://api.github.com/users/mmilata/repos","events_url":"https://api.github.com/users/mmilata/events{/privacy}","received_events_url":"https://api.github.com/users/mmilata/received_events","type":"User","site_admin":false},"body":"Trello card: https://trello.com/c/BMuLvOny/968-5-supply-oc-new-app-and-oc-process-parameter-list-env-vars-via-a-file-app-creation\r\n\r\nFollow-up of #10766","created_at":"2016-12-06T22:46:19Z","updated_at":"2016-12-08T18:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"059e9916e4f0fa45d4c5a282f4a13d803689e85b","assignee":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"assignees":[{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/12164/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/12164/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/12164/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/9ebcda44f1ccfc70c7d679f80eb83b9d643d08f9","head":{"label":"mmilata:env-file","ref":"env-file","sha":"9ebcda44f1ccfc70c7d679f80eb83b9d643d08f9","user":{"login":"mmilata","id":85857,"avatar_url":"https://avatars.githubusercontent.com/u/85857?v=3","gravatar_id":"","url":"https://api.github.com/users/mmilata","html_url":"https://github.com/mmilata","followers_url":"https://api.github.com/users/mmilata/followers","following_url":"https://api.github.com/users/mmilata/following{/other_user}","gists_url":"https://api.github.com/users/mmilata/gists{/gist_id}","starred_url":"https://api.github.com/users/mmilata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmilata/subscriptions","organizations_url":"https://api.github.com/users/mmilata/orgs","repos_url":"https://api.github.com/users/mmilata/repos","events_url":"https://api.github.com/users/mmilata/events{/privacy}","received_events_url":"https://api.github.com/users/mmilata/received_events","type":"User","site_admin":false},"repo":{"id":67504809,"name":"origin","full_name":"mmilata/origin","owner":{"login":"mmilata","id":85857,"avatar_url":"https://avatars.githubusercontent.com/u/85857?v=3","gravatar_id":"","url":"https://api.github.com/users/mmilata","html_url":"https://github.com/mmilata","followers_url":"https://api.github.com/users/mmilata/followers","following_url":"https://api.github.com/users/mmilata/following{/other_user}","gists_url":"https://api.github.com/users/mmilata/gists{/gist_id}","starred_url":"https://api.github.com/users/mmilata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmilata/subscriptions","organizations_url":"https://api.github.com/users/mmilata/orgs","repos_url":"https://api.github.com/users/mmilata/repos","events_url":"https://api.github.com/users/mmilata/events{/privacy}","received_events_url":"https://api.github.com/users/mmilata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmilata/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/mmilata/origin","forks_url":"https://api.github.com/repos/mmilata/origin/forks","keys_url":"https://api.github.com/repos/mmilata/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmilata/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmilata/origin/teams","hooks_url":"https://api.github.com/repos/mmilata/origin/hooks","issue_events_url":"https://api.github.com/repos/mmilata/origin/issues/events{/number}","events_url":"https://api.github.com/repos/mmilata/origin/events","assignees_url":"https://api.github.com/repos/mmilata/origin/assignees{/user}","branches_url":"https://api.github.com/repos/mmilata/origin/branches{/branch}","tags_url":"https://api.github.com/repos/mmilata/origin/tags","blobs_url":"https://api.github.com/repos/mmilata/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmilata/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmilata/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmilata/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmilata/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/mmilata/origin/languages","stargazers_url":"https://api.github.com/repos/mmilata/origin/stargazers","contributors_url":"https://api.github.com/repos/mmilata/origin/contributors","subscribers_url":"https://api.github.com/repos/mmilata/origin/subscribers","subscription_url":"https://api.github.com/repos/mmilata/origin/subscription","commits_url":"https://api.github.com/repos/mmilata/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmilata/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmilata/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmilata/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmilata/origin/contents/{+path}","compare_url":"https://api.github.com/repos/mmilata/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmilata/origin/merges","archive_url":"https://api.github.com/repos/mmilata/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmilata/origin/downloads","issues_url":"https://api.github.com/repos/mmilata/origin/issues{/number}","pulls_url":"https://api.github.com/repos/mmilata/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/mmilata/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/mmilata/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmilata/origin/labels{/name}","releases_url":"https://api.github.com/repos/mmilata/origin/releases{/id}","deployments_url":"https://api.github.com/repos/mmilata/origin/deployments","created_at":"2016-09-06T12:10:42Z","updated_at":"2016-09-06T12:10:51Z","pushed_at":"2016-12-08T16:26:55Z","git_url":"git://github.com/mmilata/origin.git","ssh_url":"git@github.com:mmilata/origin.git","clone_url":"https://github.com/mmilata/origin.git","svn_url":"https://github.com/mmilata/origin","homepage":"http://www.openshift.org","size":420304,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"09034cdf897e93044bcb1be55ddb1abd1ce9d8fd","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-12-08T15:50:38Z","pushed_at":"2016-12-08T18:39:28Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":677006,"stargazers_count":2123,"watchers_count":2123,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1408,"mirror_url":null,"open_issues_count":1175,"forks":1408,"open_issues":1175,"watchers":2123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/12164"},"html":{"href":"https://github.com/openshift/origin/pull/12164"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/12164"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/12164/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/12164/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/12164/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/9ebcda44f1ccfc70c7d679f80eb83b9d643d08f9"}}}}
{"actor":{"display_login":"fabianofranz"}}