{"action":"closed","number":714,"pull_request":{"url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/714","id":69659892,"html_url":"https://github.com/alphagov/specialist-publisher/pull/714","diff_url":"https://github.com/alphagov/specialist-publisher/pull/714.diff","patch_url":"https://github.com/alphagov/specialist-publisher/pull/714.patch","issue_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/714","number":714,"state":"closed","locked":false,"title":"Explicitly document what json payload looks like when republishing","user":{"login":"christophwong","id":3989823,"avatar_url":"https://avatars.githubusercontent.com/u/3989823?v=3","gravatar_id":"","url":"https://api.github.com/users/christophwong","html_url":"https://github.com/christophwong","followers_url":"https://api.github.com/users/christophwong/followers","following_url":"https://api.github.com/users/christophwong/following{/other_user}","gists_url":"https://api.github.com/users/christophwong/gists{/gist_id}","starred_url":"https://api.github.com/users/christophwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophwong/subscriptions","organizations_url":"https://api.github.com/users/christophwong/orgs","repos_url":"https://api.github.com/users/christophwong/repos","events_url":"https://api.github.com/users/christophwong/events{/privacy}","received_events_url":"https://api.github.com/users/christophwong/received_events","type":"User","site_admin":false},"body":"I intend to add more explicit tests so it is very clear what is sent to publishing api and rummager on a republish action. However there are some helpers that are confusing. As the commented-out lines show, by using `request_json_including` or `request_json_matching` the same data could either fail or pass the test. This seems strange to me because if a json passes a \"matching\" test, it should logically pass the \"including\" test.\r\n\r\nSecondly, please comment on whether putting the json payload in this test is good readability/clarity or too verbose/messy?","created_at":"2016-05-11T12:01:58Z","updated_at":"2016-05-11T14:45:40Z","closed_at":"2016-05-11T14:45:40Z","merged_at":"2016-05-11T14:45:40Z","merge_commit_sha":"42b40538ddb6d798b44399ecf6b3550025e02be5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/714/commits","review_comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/714/comments","review_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/714/comments","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/fad69f6453186ae345e10dab18967c9166a0c38a","head":{"label":"alphagov:republish-for-specialist-documents","ref":"republish-for-specialist-documents","sha":"fad69f6453186ae345e10dab18967c9166a0c38a","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176198,"name":"specialist-publisher","full_name":"alphagov/specialist-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/specialist-publisher","description":"Publishing App for Specialist Documents and Manuals on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/specialist-publisher","forks_url":"https://api.github.com/repos/alphagov/specialist-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/specialist-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/specialist-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/specialist-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/specialist-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/specialist-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/specialist-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/specialist-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/specialist-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/specialist-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/specialist-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/specialist-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/specialist-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/specialist-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/specialist-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/specialist-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/specialist-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/specialist-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/specialist-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/specialist-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/specialist-publisher/deployments","created_at":"2014-01-23T15:21:42Z","updated_at":"2016-01-13T12:00:31Z","pushed_at":"2016-05-11T14:45:40Z","git_url":"git://github.com/alphagov/specialist-publisher.git","ssh_url":"git@github.com:alphagov/specialist-publisher.git","clone_url":"https://github.com/alphagov/specialist-publisher.git","svn_url":"https://github.com/alphagov/specialist-publisher","homepage":"","size":5776,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"52223f359f7d76699b87826d05d85afdc4076824","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176198,"name":"specialist-publisher","full_name":"alphagov/specialist-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/specialist-publisher","description":"Publishing App for Specialist Documents and Manuals on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/specialist-publisher","forks_url":"https://api.github.com/repos/alphagov/specialist-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/specialist-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/specialist-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/specialist-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/specialist-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/specialist-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/specialist-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/specialist-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/specialist-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/specialist-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/specialist-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/specialist-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/specialist-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/specialist-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/specialist-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/specialist-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/specialist-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/specialist-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/specialist-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/specialist-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/specialist-publisher/deployments","created_at":"2014-01-23T15:21:42Z","updated_at":"2016-01-13T12:00:31Z","pushed_at":"2016-05-11T14:45:40Z","git_url":"git://github.com/alphagov/specialist-publisher.git","ssh_url":"git@github.com:alphagov/specialist-publisher.git","clone_url":"https://github.com/alphagov/specialist-publisher.git","svn_url":"https://github.com/alphagov/specialist-publisher","homepage":"","size":5776,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/714"},"html":{"href":"https://github.com/alphagov/specialist-publisher/pull/714"},"issue":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/issues/714"},"comments":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/issues/714/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/714/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/714/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/fad69f6453186ae345e10dab18967c9166a0c38a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tuzz","id":892251,"avatar_url":"https://avatars.githubusercontent.com/u/892251?v=3","gravatar_id":"","url":"https://api.github.com/users/tuzz","html_url":"https://github.com/tuzz","followers_url":"https://api.github.com/users/tuzz/followers","following_url":"https://api.github.com/users/tuzz/following{/other_user}","gists_url":"https://api.github.com/users/tuzz/gists{/gist_id}","starred_url":"https://api.github.com/users/tuzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuzz/subscriptions","organizations_url":"https://api.github.com/users/tuzz/orgs","repos_url":"https://api.github.com/users/tuzz/repos","events_url":"https://api.github.com/users/tuzz/events{/privacy}","received_events_url":"https://api.github.com/users/tuzz/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":45,"deletions":9,"changed_files":1}}