{"action":"created","issue":{"url":"https://api.github.com/repos/pyugrid/pyugrid/issues/116","repository_url":"https://api.github.com/repos/pyugrid/pyugrid","labels_url":"https://api.github.com/repos/pyugrid/pyugrid/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/pyugrid/pyugrid/issues/116/comments","events_url":"https://api.github.com/repos/pyugrid/pyugrid/issues/116/events","html_url":"https://github.com/pyugrid/pyugrid/pull/116","id":133274327,"number":116,"title":"Flake8","user":{"login":"ocefpaf","id":950575,"avatar_url":"https://avatars.githubusercontent.com/u/950575?v=3","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-02-12T15:50:19Z","updated_at":"2016-02-14T13:17:38Z","closed_at":"2016-02-13T01:09:28Z","pull_request":{"url":"https://api.github.com/repos/pyugrid/pyugrid/pulls/116","html_url":"https://github.com/pyugrid/pyugrid/pull/116","diff_url":"https://github.com/pyugrid/pyugrid/pull/116.diff","patch_url":"https://github.com/pyugrid/pyugrid/pull/116.patch"},"body":"Looks a lot but most of it is `pep8`,  `typos`, and Python 2 and 3 compliant code.\r\n\r\nThe only code changed is from `pyselfe_kdtree.py`, but if I had to guess that code is currently broken and my changes did not fix it.\r\n\r\nWhat needs some review:\r\n\r\n- changed how the version number is obtained.\r\n- some re-wording in the `README.rst`\r\n- removed Python 3.3 test (They still pass, but we should discourage py33 use.)\r\n- enforce `flaky8` tests on Travis-CI\r\n\r\nThe last one is to avoid #114."},"comment":{"url":"https://api.github.com/repos/pyugrid/pyugrid/issues/comments/183886522","html_url":"https://github.com/pyugrid/pyugrid/pull/116#issuecomment-183886522","issue_url":"https://api.github.com/repos/pyugrid/pyugrid/issues/116","id":183886522,"user":{"login":"ocefpaf","id":950575,"avatar_url":"https://avatars.githubusercontent.com/u/950575?v=3","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"created_at":"2016-02-14T13:17:37Z","updated_at":"2016-02-14T13:17:37Z","body":"> But I don't think that it's good to be a slave to automated linting tools.\r\n\r\n@ChrisBarker-NOAA you mention Python-dev as an example that this practice is bad.  I agree, but I don't believe it applies to our case here.  Earth scientists are not coders who will infringe recommended practices with a good reason.  You, Kyle, and many good coders I see contributing to libraries do **know** what you are doing, but people like me, @rsignell-usgs, and many more future contributors **will** benefit from this test.\r\n\r\nBesides, the code base had many violations that scrambled the code and made it hard to follow.  Not to mention syntax erros that were passed silently!  Adding the `flake8` test will help the review process and prevent that from happening again.  Virtually every project I know and contribute to uses such a test. (Iris, Cartopy, PyCSW, OWSLib, all of Axiom/ASA modern code, etc).\r\n\r\n> They can really get in the way.\r\n\r\nI still think that the advantages outweighs the disadvantages.  Besides, it is only 1 test that servers as a reviewer helper-tool. We **can**  merge good code that fails this test and passes the others.  We only need to check the Travis-CI log and use our best judgment.\r\n\r\nIf you want to remove that go ahead.  I am not against it.  I  think it will make reviewing process harder and/or flawed. (Something like #114 would never happen with this test on.)"}}