{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/78885844","id":78885844,"diff_hunk":"@@ -147,7 +147,7 @@ namespace Js\n     {\n         double result;\n \n-#if defined(_M_IX86)\n+#if defined(_M_IX86) && defined(_WIN32) // TODO: xplat support","path":"lib/Runtime/Library/MathLibrary.cpp","position":5,"original_position":5,"commit_id":"cd6bc590c1528881693d197d0324e15f756092c5","original_commit_id":"cd6bc590c1528881693d197d0324e15f756092c5","user":{"login":"digitalinfinity","id":158390,"avatar_url":"https://avatars.githubusercontent.com/u/158390?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalinfinity","html_url":"https://github.com/digitalinfinity","followers_url":"https://api.github.com/users/digitalinfinity/followers","following_url":"https://api.github.com/users/digitalinfinity/following{/other_user}","gists_url":"https://api.github.com/users/digitalinfinity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalinfinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalinfinity/subscriptions","organizations_url":"https://api.github.com/users/digitalinfinity/orgs","repos_url":"https://api.github.com/users/digitalinfinity/repos","events_url":"https://api.github.com/users/digitalinfinity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalinfinity/received_events","type":"User","site_admin":false},"body":"Yeah, I'd do this under a different ifdef (assuming -msse3 doesn't fix it)","created_at":"2016-09-15T03:48:53Z","updated_at":"2016-09-15T03:48:53Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1540#discussion_r78885844","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1540","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/78885844"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1540#discussion_r78885844"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1540"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1540","id":84013779,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1540","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1540.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1540.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1540","number":1540,"state":"open","locked":false,"title":"cross-platform: x86 support","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"body":"ChakraCore compiles to x86 target\r\n\r\n- Add xplat x86 Support [not tested - linker problems - see below]\r\n- Improvements to existing amd64 implementation\r\n- This PR needs 'ICU/etc static linkage' support for linker pass\r\n- Additional work will be needed on posix (At the moment, the main focus for this x86 PR is iOS simulator / Android targets)\r\n\r\nImportant: Unless otherwise specified, x86 is not officially supported.","created_at":"2016-09-05T14:56:27Z","updated_at":"2016-09-15T03:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9682c688b1578d24c95872250b7fd7f8f5671399","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1540/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1540/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1540/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/cd6bc590c1528881693d197d0324e15f756092c5","head":{"label":"obastemur:x86","ref":"x86","sha":"cd6bc590c1528881693d197d0324e15f756092c5","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"repo":{"id":61668748,"name":"ChakraCore","full_name":"obastemur/ChakraCore","owner":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obastemur/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/obastemur/ChakraCore","forks_url":"https://api.github.com/repos/obastemur/ChakraCore/forks","keys_url":"https://api.github.com/repos/obastemur/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obastemur/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obastemur/ChakraCore/teams","hooks_url":"https://api.github.com/repos/obastemur/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/obastemur/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/obastemur/ChakraCore/events","assignees_url":"https://api.github.com/repos/obastemur/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/obastemur/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/obastemur/ChakraCore/tags","blobs_url":"https://api.github.com/repos/obastemur/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obastemur/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obastemur/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/obastemur/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obastemur/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/obastemur/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/obastemur/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/obastemur/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/obastemur/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/obastemur/ChakraCore/subscription","commits_url":"https://api.github.com/repos/obastemur/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/obastemur/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/obastemur/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/obastemur/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/obastemur/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/obastemur/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obastemur/ChakraCore/merges","archive_url":"https://api.github.com/repos/obastemur/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obastemur/ChakraCore/downloads","issues_url":"https://api.github.com/repos/obastemur/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/obastemur/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/obastemur/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/obastemur/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obastemur/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/obastemur/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/obastemur/ChakraCore/deployments","created_at":"2016-06-21T21:35:20Z","updated_at":"2016-06-21T21:35:44Z","pushed_at":"2016-09-14T11:28:13Z","git_url":"git://github.com/obastemur/ChakraCore.git","ssh_url":"git@github.com:obastemur/ChakraCore.git","clone_url":"https://github.com/obastemur/ChakraCore.git","svn_url":"https://github.com/obastemur/ChakraCore","homepage":null,"size":39910,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"291ebeceef940337485269fb12874838bd61a831","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-09-15T03:38:13Z","pushed_at":"2016-09-15T01:49:40Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":51327,"stargazers_count":5636,"watchers_count":5636,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":621,"mirror_url":null,"open_issues_count":161,"forks":621,"open_issues":161,"watchers":5636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1540"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1540"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1540"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1540/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1540/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1540/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/cd6bc590c1528881693d197d0324e15f756092c5"}}}}
{"actor":{"display_login":"digitalinfinity"}}