{"action":"closed","number":37691,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37691","id":95900313,"html_url":"https://github.com/kubernetes/kubernetes/pull/37691","diff_url":"https://github.com/kubernetes/kubernetes/pull/37691.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37691.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37691","number":37691,"state":"closed","locked":false,"title":"Do not create selector and namespaces in a loop where possible","user":{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars.githubusercontent.com/u/1964576?v=3","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false},"body":"With 1000 nodes and 5000 pods (5 pods per node) with anti-affinity a lot of CPU wasted on creating LabelSelector and sets.String (map). \r\n\r\nWith this change we are able to deploy that number of pods in ~25 minutes. Without - it takes 30 minutes to deploy 500 pods with anti-affinity configured.\r\n\r\n","created_at":"2016-11-30T14:23:32Z","updated_at":"2016-12-08T18:52:01Z","closed_at":"2016-12-08T18:52:01Z","merged_at":"2016-12-08T18:52:01Z","merge_commit_sha":"f2f107124be9591bb02c665d791c03b9e82e021b","assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31","html_url":"https://github.com/kubernetes/kubernetes/milestone/31","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31/labels","id":2130587,"number":31,"title":"v1.6","description":null,"creator":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"open_issues":202,"closed_issues":81,"state":"open","created_at":"2016-11-12T00:35:38Z","updated_at":"2016-12-08T18:52:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37691/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37691/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37691/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/55b413f504338a028262d5989c992c7b8ee6c696","head":{"label":"dshulyak:term_selector","ref":"term_selector","sha":"55b413f504338a028262d5989c992c7b8ee6c696","user":{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars.githubusercontent.com/u/1964576?v=3","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false},"repo":{"id":30866948,"name":"kubernetes","full_name":"dshulyak/kubernetes","owner":{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars.githubusercontent.com/u/1964576?v=3","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dshulyak/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/dshulyak/kubernetes","forks_url":"https://api.github.com/repos/dshulyak/kubernetes/forks","keys_url":"https://api.github.com/repos/dshulyak/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dshulyak/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dshulyak/kubernetes/teams","hooks_url":"https://api.github.com/repos/dshulyak/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dshulyak/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dshulyak/kubernetes/events","assignees_url":"https://api.github.com/repos/dshulyak/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dshulyak/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dshulyak/kubernetes/tags","blobs_url":"https://api.github.com/repos/dshulyak/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dshulyak/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dshulyak/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dshulyak/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dshulyak/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dshulyak/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dshulyak/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dshulyak/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dshulyak/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dshulyak/kubernetes/subscription","commits_url":"https://api.github.com/repos/dshulyak/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dshulyak/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dshulyak/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dshulyak/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dshulyak/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dshulyak/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dshulyak/kubernetes/merges","archive_url":"https://api.github.com/repos/dshulyak/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dshulyak/kubernetes/downloads","issues_url":"https://api.github.com/repos/dshulyak/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dshulyak/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dshulyak/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dshulyak/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dshulyak/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dshulyak/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dshulyak/kubernetes/deployments","created_at":"2015-02-16T12:16:17Z","updated_at":"2015-02-16T12:16:21Z","pushed_at":"2016-12-08T16:15:35Z","git_url":"git://github.com/dshulyak/kubernetes.git","ssh_url":"git@github.com:dshulyak/kubernetes.git","clone_url":"https://github.com/dshulyak/kubernetes.git","svn_url":"https://github.com/dshulyak/kubernetes","homepage":"http://kubernetes.io","size":356671,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"63044c410eff3bb02beb7fce0e50886d3f3400d2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-08T18:46:11Z","pushed_at":"2016-12-08T18:52:02Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":663321,"stargazers_count":18999,"watchers_count":18999,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6322,"mirror_url":null,"open_issues_count":5351,"forks":6322,"open_issues":5351,"watchers":18999,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37691"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37691"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37691"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37691/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37691/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37691/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/55b413f504338a028262d5989c992c7b8ee6c696"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":29,"review_comments":11,"commits":1,"additions":31,"deletions":19,"changed_files":4}}
{"actor":{"display_login":"k8s-merge-robot"}}