{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/80433654","id":80433654,"diff_hunk":"@@ -61,51 +61,122 @@ ApplicationWindow {\n                             property var url: \"mapbox://styles/mapbox/streets-v9\"\n                         },\n                         MapParameter {\n+                            id: waterPaint\n+                            property var type: \"paint\"\n+                            property var layer: \"water\"\n+                            property var fillColor: waterColorDialog.color\n+                        },\n+                        MapParameter {\n                             property var type: \"source\"\n-                            property var id: \"testSource\"\n+                            property var name: \"routeSource\"\n                             property var sourceType: \"geojson\"\n                             property var data: \":source.geojson\"\n                         },\n                         MapParameter {\n                             property var type: \"layer\"\n-                            property var id: \"testLayer\"\n-                            property var layerType: \"fill\"\n-                            property var source: \"testSource\"\n+                            property var name: \"routeCase\"\n+                            property var layerType: \"line\"\n+                            property var source: \"routeSource\"\n                         },\n                         MapParameter {\n                             property var type: \"paint\"\n-                            property var layer: \"testLayer\"\n-                            property var fillColor: Qt.rgba(0, 0, 1, 1)\n+                            property var layer: \"routeCase\"\n+                            property color lineColor: \"white\"","path":"platform/qt/qmlapp/main.qml","position":null,"original_position":30,"commit_id":"e7e90b97c4a638b8b6ea4a76c9c026c91ad220d7","original_commit_id":"cb3e54d6f9dc16dc59a5fa046ae5f292501d531a","user":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"body":"Indeed - I must have confused this with some other error I had at the time I was implementing this - good to know Qt is smart enough on this ;)","created_at":"2016-09-26T09:06:31Z","updated_at":"2016-09-26T09:06:31Z","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/6449#discussion_r80433654","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6449","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/80433654"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/6449#discussion_r80433654"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6449"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6449","id":86613486,"html_url":"https://github.com/mapbox/mapbox-gl-native/pull/6449","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/6449.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/6449.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6449","number":6449,"state":"open","locked":false,"title":"[Qt] QML runtime style 2.0","user":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"body":"Implements Qt QML runtime style via `MapParameter`, as part of future integration with Qt upstream. Now, we only expose two different QML types: `QQuickMapboxGL` and `QQuickMapboxGLMapParameter`. The latter is used for specifying Mapbox-specific features:\r\n\r\nEvery map parameter starts with a property `name` - which is used to identify the parameter type. Accepted parameter types are: `style`, `paint`, `layout`, `layer`, `source`, `filter`, `image`, `bearing` and `pitch` - examples below:\r\n\r\n### Style: `style`\r\nProperties:\r\n- `url`: Specifies the style URL e.g. `\"mapbox://styles/mapbox/streets-v9\"`\r\n\r\n### Style paint properties: `paint`\r\nProperties:\r\n- `layer`: Specifies the style layer.\r\n- `class` (optional): Specifies the style class.\r\nStyle paint properties are then defined in camelCase e.g. `fill-color` becomes `fillColor`:\r\n``` qml\r\nproperty var fillColor: Qt.rgba(1, 1, 1, 1)\r\n```\r\nor\r\n``` qml\r\nproperty color fillColor: \"blue\"\r\n``` \r\n\r\n### Style layout properties: `layout`\r\nProperties:\r\n- `layer`: Specifies the style layer.\r\nStyle layout properties are then defined in camelCase e.g. `line-join` becomes `lineJoin`.\r\n\r\n### Style layer: `layer`\r\nProperties:\r\n- `name`: Specifies the layer name (aka. `id`).\r\n- `layerType`: Specifies the layer type e.g. `line`.\r\n- `source`: Specifies the layer source.\r\n\r\n### Style source: `source`\r\nProperties:\r\n- `name`: Specifies the source name (aka. `id`).\r\n- `sourceType`: Specifies the layer type e.g. `geojson`.\r\n- `data`: Specifies the source file path.\r\n\r\n### Style filter: `filter`\r\nProperties:\r\n- `layer`: Specifies the associated style layer.\r\n- `filter`: Specifies the filter as a list of strings e.g. `[ \"==\", \"$type\", \"Point\" ]`\r\n\r\n### Style image: `image`\r\nProperties:\r\n- `name`: Specifies the image name.\r\n- `sprite`: Specifies the image file path. `QQuickImage` items are not supported because these are not exposed via public API.\r\n\r\n### Map bearing: `bearing`\r\nProperties:\r\n- `angle`: Specifies the map bearing angle (in degrees).\r\n\r\n### Map bearing: `pitch`\r\nProperties:\r\n- `angle`: Specifies the map pitch angle (in degrees).","created_at":"2016-09-24T09:47:52Z","updated_at":"2016-09-26T09:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c87b46a1a40a1683b46f031929128506ed351a0","assignee":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"assignees":[{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6449/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6449/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6449/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/e7e90b97c4a638b8b6ea4a76c9c026c91ad220d7","head":{"label":"mapbox:qt-qml-runtime-style-2.0","ref":"qt-qml-runtime-style-2.0","sha":"e7e90b97c4a638b8b6ea4a76c9c026c91ad220d7","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Render Mapbox styles in mobile, desktop, and node applications using C++ and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2016-09-25T18:53:43Z","pushed_at":"2016-09-26T07:09:19Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":130048,"stargazers_count":1467,"watchers_count":1467,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":426,"mirror_url":null,"open_issues_count":595,"forks":426,"open_issues":595,"watchers":1467,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"bf18c330406a44b36218aab20a11b74f0151f6e7","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Render Mapbox styles in mobile, desktop, and node applications using C++ and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2016-09-25T18:53:43Z","pushed_at":"2016-09-26T07:09:19Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":130048,"stargazers_count":1467,"watchers_count":1467,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":426,"mirror_url":null,"open_issues_count":595,"forks":426,"open_issues":595,"watchers":1467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6449"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/6449"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6449"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6449/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6449/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6449/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/e7e90b97c4a638b8b6ea4a76c9c026c91ad220d7"}}}}
{"actor":{"display_login":"brunoabinader"}}