{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/comments/73214623","id":73214623,"diff_hunk":"@@ -5,10 +5,12 @@\n \n namespace Microsoft.AspNetCore.ResponseCaching\n {\n-    internal class ResponseCachingEntry\n+    public class CachedResponse\n     {\n         public int StatusCode { get; set; }\n+\n         internal IHeaderDictionary Headers { get; set; } = new HeaderDictionary();","path":"src/Microsoft.AspNetCore.ResponseCaching/ResponseCache/CachedResponse.cs","position":9,"original_position":9,"commit_id":"03d104f8f7a04ead41dd2e77ef11e9a12461554e","original_commit_id":"03d104f8f7a04ead41dd2e77ef11e9a12461554e","user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"body":"Why are these internal and status code public?","created_at":"2016-08-02T18:49:38Z","updated_at":"2016-08-02T18:49:38Z","html_url":"https://github.com/aspnet/ResponseCaching/pull/14#discussion_r73214623","pull_request_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/comments/73214623"},"html":{"href":"https://github.com/aspnet/ResponseCaching/pull/14#discussion_r73214623"},"pull_request":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/14","id":79264998,"html_url":"https://github.com/aspnet/ResponseCaching/pull/14","diff_url":"https://github.com/aspnet/ResponseCaching/pull/14.diff","patch_url":"https://github.com/aspnet/ResponseCaching/pull/14.patch","issue_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/14","number":14,"state":"open","locked":false,"title":"ResponseCache updates to support varyby rules","user":{"login":"JunTaoLuo","id":2030323,"avatar_url":"https://avatars.githubusercontent.com/u/2030323?v=3","gravatar_id":"","url":"https://api.github.com/users/JunTaoLuo","html_url":"https://github.com/JunTaoLuo","followers_url":"https://api.github.com/users/JunTaoLuo/followers","following_url":"https://api.github.com/users/JunTaoLuo/following{/other_user}","gists_url":"https://api.github.com/users/JunTaoLuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JunTaoLuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunTaoLuo/subscriptions","organizations_url":"https://api.github.com/users/JunTaoLuo/orgs","repos_url":"https://api.github.com/users/JunTaoLuo/repos","events_url":"https://api.github.com/users/JunTaoLuo/events{/privacy}","received_events_url":"https://api.github.com/users/JunTaoLuo/received_events","type":"User","site_admin":false},"body":"Updating the design of ResponseCache/ResponseCacheEntries to support varyby rules. The design of how to configure these rules and what elements to vary by have not been finalized yet.\r\n\r\ncc @Tratcher @davidfowl ","created_at":"2016-07-28T20:43:36Z","updated_at":"2016-08-02T18:49:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b5bfdf26db4d26fe3ba3d960bb07dfd38c2d4da","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/14/commits","review_comments_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/14/comments","review_comment_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/14/comments","statuses_url":"https://api.github.com/repos/aspnet/ResponseCaching/statuses/03d104f8f7a04ead41dd2e77ef11e9a12461554e","head":{"label":"aspnet:johluo/varyby","ref":"johluo/varyby","sha":"03d104f8f7a04ead41dd2e77ef11e9a12461554e","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35685759,"name":"ResponseCaching","full_name":"aspnet/ResponseCaching","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/ResponseCaching","description":"ASP.NET Core middleware for caching responses","fork":false,"url":"https://api.github.com/repos/aspnet/ResponseCaching","forks_url":"https://api.github.com/repos/aspnet/ResponseCaching/forks","keys_url":"https://api.github.com/repos/aspnet/ResponseCaching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/ResponseCaching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/ResponseCaching/teams","hooks_url":"https://api.github.com/repos/aspnet/ResponseCaching/hooks","issue_events_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/ResponseCaching/events","assignees_url":"https://api.github.com/repos/aspnet/ResponseCaching/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/ResponseCaching/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/ResponseCaching/tags","blobs_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/ResponseCaching/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/ResponseCaching/languages","stargazers_url":"https://api.github.com/repos/aspnet/ResponseCaching/stargazers","contributors_url":"https://api.github.com/repos/aspnet/ResponseCaching/contributors","subscribers_url":"https://api.github.com/repos/aspnet/ResponseCaching/subscribers","subscription_url":"https://api.github.com/repos/aspnet/ResponseCaching/subscription","commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/ResponseCaching/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/ResponseCaching/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/ResponseCaching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/ResponseCaching/merges","archive_url":"https://api.github.com/repos/aspnet/ResponseCaching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/ResponseCaching/downloads","issues_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/ResponseCaching/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/ResponseCaching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/ResponseCaching/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/ResponseCaching/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/ResponseCaching/deployments","created_at":"2015-05-15T16:55:52Z","updated_at":"2016-08-01T19:19:44Z","pushed_at":"2016-08-02T17:44:06Z","git_url":"git://github.com/aspnet/ResponseCaching.git","ssh_url":"git@github.com:aspnet/ResponseCaching.git","clone_url":"https://github.com/aspnet/ResponseCaching.git","svn_url":"https://github.com/aspnet/ResponseCaching","homepage":"","size":62,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":12,"forks":5,"open_issues":12,"watchers":11,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"d204adafd2560852acf82b2c16c624caba6aba8a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35685759,"name":"ResponseCaching","full_name":"aspnet/ResponseCaching","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/ResponseCaching","description":"ASP.NET Core middleware for caching responses","fork":false,"url":"https://api.github.com/repos/aspnet/ResponseCaching","forks_url":"https://api.github.com/repos/aspnet/ResponseCaching/forks","keys_url":"https://api.github.com/repos/aspnet/ResponseCaching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/ResponseCaching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/ResponseCaching/teams","hooks_url":"https://api.github.com/repos/aspnet/ResponseCaching/hooks","issue_events_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/ResponseCaching/events","assignees_url":"https://api.github.com/repos/aspnet/ResponseCaching/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/ResponseCaching/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/ResponseCaching/tags","blobs_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/ResponseCaching/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/ResponseCaching/languages","stargazers_url":"https://api.github.com/repos/aspnet/ResponseCaching/stargazers","contributors_url":"https://api.github.com/repos/aspnet/ResponseCaching/contributors","subscribers_url":"https://api.github.com/repos/aspnet/ResponseCaching/subscribers","subscription_url":"https://api.github.com/repos/aspnet/ResponseCaching/subscription","commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/ResponseCaching/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/ResponseCaching/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/ResponseCaching/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/ResponseCaching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/ResponseCaching/merges","archive_url":"https://api.github.com/repos/aspnet/ResponseCaching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/ResponseCaching/downloads","issues_url":"https://api.github.com/repos/aspnet/ResponseCaching/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/ResponseCaching/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/ResponseCaching/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/ResponseCaching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/ResponseCaching/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/ResponseCaching/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/ResponseCaching/deployments","created_at":"2015-05-15T16:55:52Z","updated_at":"2016-08-01T19:19:44Z","pushed_at":"2016-08-02T17:44:06Z","git_url":"git://github.com/aspnet/ResponseCaching.git","ssh_url":"git@github.com:aspnet/ResponseCaching.git","clone_url":"https://github.com/aspnet/ResponseCaching.git","svn_url":"https://github.com/aspnet/ResponseCaching","homepage":"","size":62,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":12,"forks":5,"open_issues":12,"watchers":11,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/14"},"html":{"href":"https://github.com/aspnet/ResponseCaching/pull/14"},"issue":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/issues/14"},"comments":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/ResponseCaching/statuses/03d104f8f7a04ead41dd2e77ef11e9a12461554e"}}}}
{"actor":{"display_login":"davidfowl"}}