{"action":"closed","number":103,"pull_request":{"url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls/103","id":91622861,"html_url":"https://github.com/wildfly-swarm/wildfly-swarm-examples/pull/103","diff_url":"https://github.com/wildfly-swarm/wildfly-swarm-examples/pull/103.diff","patch_url":"https://github.com/wildfly-swarm/wildfly-swarm-examples/pull/103.patch","issue_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/issues/103","number":103,"state":"closed","locked":false,"title":"SWARM-806: JPA+JAX-RS+CDI+JTA examples have wrong assertions","user":{"login":"Ladicek","id":480590,"avatar_url":"https://avatars.githubusercontent.com/u/480590?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladicek","html_url":"https://github.com/Ladicek","followers_url":"https://api.github.com/users/Ladicek/followers","following_url":"https://api.github.com/users/Ladicek/following{/other_user}","gists_url":"https://api.github.com/users/Ladicek/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladicek/subscriptions","organizations_url":"https://api.github.com/users/Ladicek/orgs","repos_url":"https://api.github.com/users/Ladicek/repos","events_url":"https://api.github.com/users/Ladicek/events{/privacy}","received_events_url":"https://api.github.com/users/Ladicek/received_events","type":"User","site_admin":false},"body":"Motivation\r\n----------\r\nBoth the JPA+JAX-RS+CDI+JTA examples have the following exceptions\r\nin the log:\r\n\r\n    Could not find MessageBodyWriter for response object of type:\r\n    java.lang.Integer of media type: text/html\r\n\r\nyet the tests don't fail. This is because the FEST Assert API\r\nis used wrongly and no assertions are actually made.\r\n\r\nModifications\r\n-------------\r\nFix usage of the FEST Assert API so that asserts are actually made.\r\nThis itself makes the tests fail, but that is easy to fix: just\r\nmake the int-returning JAX-RS methods @Produces(\"text/plain\"),\r\nso that java.lang.Integer marshaller is found.\r\n\r\nResult\r\n------\r\nMore test coverage, less exceptions in the log, tests still pass.","created_at":"2016-10-31T14:51:56Z","updated_at":"2016-11-07T18:57:39Z","closed_at":"2016-11-07T18:57:39Z","merged_at":"2016-11-07T18:57:39Z","merge_commit_sha":"d6b7337a477a780dc60f8d96151e4635a2ed96b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls/103/commits","review_comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls/103/comments","review_comment_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/issues/103/comments","statuses_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/statuses/a6147d26e3b5ef63182d021eeaff9bc3cc0fe31b","head":{"label":"Ladicek:fix-assertions-in-jpa-jaxrs-cdi-jta-examples","ref":"fix-assertions-in-jpa-jaxrs-cdi-jta-examples","sha":"a6147d26e3b5ef63182d021eeaff9bc3cc0fe31b","user":{"login":"Ladicek","id":480590,"avatar_url":"https://avatars.githubusercontent.com/u/480590?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladicek","html_url":"https://github.com/Ladicek","followers_url":"https://api.github.com/users/Ladicek/followers","following_url":"https://api.github.com/users/Ladicek/following{/other_user}","gists_url":"https://api.github.com/users/Ladicek/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladicek/subscriptions","organizations_url":"https://api.github.com/users/Ladicek/orgs","repos_url":"https://api.github.com/users/Ladicek/repos","events_url":"https://api.github.com/users/Ladicek/events{/privacy}","received_events_url":"https://api.github.com/users/Ladicek/received_events","type":"User","site_admin":false},"repo":{"id":67125796,"name":"wildfly-swarm-examples","full_name":"Ladicek/wildfly-swarm-examples","owner":{"login":"Ladicek","id":480590,"avatar_url":"https://avatars.githubusercontent.com/u/480590?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladicek","html_url":"https://github.com/Ladicek","followers_url":"https://api.github.com/users/Ladicek/followers","following_url":"https://api.github.com/users/Ladicek/following{/other_user}","gists_url":"https://api.github.com/users/Ladicek/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladicek/subscriptions","organizations_url":"https://api.github.com/users/Ladicek/orgs","repos_url":"https://api.github.com/users/Ladicek/repos","events_url":"https://api.github.com/users/Ladicek/events{/privacy}","received_events_url":"https://api.github.com/users/Ladicek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ladicek/wildfly-swarm-examples","description":"Examples of how to write applications using Swarm.","fork":true,"url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples","forks_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/forks","keys_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/teams","hooks_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/hooks","issue_events_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/issues/events{/number}","events_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/events","assignees_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/assignees{/user}","branches_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/branches{/branch}","tags_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/tags","blobs_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/languages","stargazers_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/stargazers","contributors_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/contributors","subscribers_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/subscribers","subscription_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/subscription","commits_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/contents/{+path}","compare_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/merges","archive_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/downloads","issues_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/issues{/number}","pulls_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/labels{/name}","releases_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/releases{/id}","deployments_url":"https://api.github.com/repos/Ladicek/wildfly-swarm-examples/deployments","created_at":"2016-09-01T11:34:38Z","updated_at":"2016-09-01T11:34:40Z","pushed_at":"2016-11-07T13:45:18Z","git_url":"git://github.com/Ladicek/wildfly-swarm-examples.git","ssh_url":"git@github.com:Ladicek/wildfly-swarm-examples.git","clone_url":"https://github.com/Ladicek/wildfly-swarm-examples.git","svn_url":"https://github.com/Ladicek/wildfly-swarm-examples","homepage":"","size":19214,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly-swarm:master","ref":"master","sha":"0243b7d48e84903f4c9693e11a22390b5b877587","user":{"login":"wildfly-swarm","id":11523816,"avatar_url":"https://avatars.githubusercontent.com/u/11523816?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-swarm","html_url":"https://github.com/wildfly-swarm","followers_url":"https://api.github.com/users/wildfly-swarm/followers","following_url":"https://api.github.com/users/wildfly-swarm/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-swarm/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-swarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-swarm/subscriptions","organizations_url":"https://api.github.com/users/wildfly-swarm/orgs","repos_url":"https://api.github.com/users/wildfly-swarm/repos","events_url":"https://api.github.com/users/wildfly-swarm/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-swarm/received_events","type":"Organization","site_admin":false},"repo":{"id":36889530,"name":"wildfly-swarm-examples","full_name":"wildfly-swarm/wildfly-swarm-examples","owner":{"login":"wildfly-swarm","id":11523816,"avatar_url":"https://avatars.githubusercontent.com/u/11523816?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-swarm","html_url":"https://github.com/wildfly-swarm","followers_url":"https://api.github.com/users/wildfly-swarm/followers","following_url":"https://api.github.com/users/wildfly-swarm/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-swarm/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-swarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-swarm/subscriptions","organizations_url":"https://api.github.com/users/wildfly-swarm/orgs","repos_url":"https://api.github.com/users/wildfly-swarm/repos","events_url":"https://api.github.com/users/wildfly-swarm/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-swarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-swarm/wildfly-swarm-examples","description":"Examples of how to write applications using Swarm.","fork":false,"url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples","forks_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/forks","keys_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/teams","hooks_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/hooks","issue_events_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/events","assignees_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/tags","blobs_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/languages","stargazers_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/stargazers","contributors_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/contributors","subscribers_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/subscribers","subscription_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/subscription","commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/merges","archive_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/downloads","issues_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/deployments","created_at":"2015-06-04T18:59:40Z","updated_at":"2016-11-04T15:37:27Z","pushed_at":"2016-11-07T18:57:39Z","git_url":"git://github.com/wildfly-swarm/wildfly-swarm-examples.git","ssh_url":"git@github.com:wildfly-swarm/wildfly-swarm-examples.git","clone_url":"https://github.com/wildfly-swarm/wildfly-swarm-examples.git","svn_url":"https://github.com/wildfly-swarm/wildfly-swarm-examples","homepage":"","size":19456,"stargazers_count":126,"watchers_count":126,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":2,"forks":111,"open_issues":2,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls/103"},"html":{"href":"https://github.com/wildfly-swarm/wildfly-swarm-examples/pull/103"},"issue":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/issues/103"},"comments":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-examples/statuses/a6147d26e3b5ef63182d021eeaff9bc3cc0fe31b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kenfinnigan","id":441240,"avatar_url":"https://avatars.githubusercontent.com/u/441240?v=3","gravatar_id":"","url":"https://api.github.com/users/kenfinnigan","html_url":"https://github.com/kenfinnigan","followers_url":"https://api.github.com/users/kenfinnigan/followers","following_url":"https://api.github.com/users/kenfinnigan/following{/other_user}","gists_url":"https://api.github.com/users/kenfinnigan/gists{/gist_id}","starred_url":"https://api.github.com/users/kenfinnigan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenfinnigan/subscriptions","organizations_url":"https://api.github.com/users/kenfinnigan/orgs","repos_url":"https://api.github.com/users/kenfinnigan/repos","events_url":"https://api.github.com/users/kenfinnigan/events{/privacy}","received_events_url":"https://api.github.com/users/kenfinnigan/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":12,"deletions":8,"changed_files":4}}
{"actor":{"display_login":"kenfinnigan"}}