{"push_id":1291723497,"size":28,"distinct_size":28,"ref":"refs/heads/master","head":"0e17ee468095df609921271e4c6513dac815f068","before":"65c2ff78e0e88f5052751747f6686084caab3d4c","commits":[{"sha":"a67f5698705dab8cb58bd07c733ac492e81ad28f","author":{"name":"Eugene Rozenfeld","email":"b92c126989258baecbfe1802b67fe5907a5aa0d6@microsoft.com"},"message":"Make GT_LIST processing non-recursive to avoid StackOverflow.\n\nWe had some internal cases where crossgen failed with StackOverflow exception\nwhen compiling huge methods. In particular, the methods had GT_PHI nodes with\nhuge number of arguments.\n\nStackOverflow was happening in multiple places. Recent LIR changes eliminated two of those places,\nthese changes eliminate two more: gtSetEvalOrder and fgDebugCheckFlags (debug only). We already had\ngtSetListOrder but it was only used for call arg lists. I made gtSetListOrder non-recursive and also generalized\nto handle other GT_LIST nodes.\n\nWith that with these changes the huge repros can now be crossgen'd.\n\nI verified no assembly diffs in SuperPMI.\n\nI'm verifying overall throughput effect.","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/a67f5698705dab8cb58bd07c733ac492e81ad28f"},{"sha":"57d6887745844ea882b3dde4c54155e4f57f41ff","author":{"name":"Pat Gavlin","email":"31abb87c1630f1a235ae3e5824500fcc02bda71b@microsoft.com"},"message":"Return false from isRegPairType for RyuJIT.\n\nThe RyuJIT backend does not use regpair types, so this method should\nsimply return false when that backend is in use. In the future we\nshould consider removing this method (and other regpair-related code).\n\nFixes #7089.","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/57d6887745844ea882b3dde4c54155e4f57f41ff"},{"sha":"6519911fbccbec049f9592484f69c213b4b78264","author":{"name":"Sean Gillespie","email":"8360f824a9058f9e49e7231bb6790a5c6cebf45e@microsoft.com"},"message":"Introduce an interface separating the GC and the VM,\nmodifying the VM to utilize this interface.\n\nIntroduce an interface separating the GC and the rest of the VM\n\nRemove static members of both IGCHeap and IGCHeapInternal and move the management of the singular GC heap to the VM.\n\nRename uses of IGCHeap in the VM to GCHeapHolder, as well as other misc. renames throughout the VM and GC.\n\nSplit each interface function into categories, document them, use consistent formatting across the interface\n\nUndo some accidental find/replace collateral damage\n\nRemove all ifdefs from the GC interface\n\nDeduplicate function declarations between IGCHeap and IGCHeapInternal, expose AllocAlign8 through the interface and the reference to alloc_context to repair the ARM build\n\nPaper cut: false -> nullptr\n\nRepair the ARM and x86 builds\n\nRename GCHeapHolder -> GCHeapUtilities and address documentation feedback\n\nRebase against master\n\nRename gcholder.h/cpp -> gcheaputilities.h/cpp\n\nFix an uninitialized field on alloc_context causing test failures on clang\n\nRename the include guard for gcheaputilities.h\n\nUn-breaks SOS by making the following changes:\n  1) Instructs the DAC to look for IGCHeap::gcHeapType by name,\n     instead of assuming that it exists near g_pGCHeap,\n  2) Eliminate all virtual calls on IGCHeap in the DAC, since we cannot\n     dispatch on an object in another process,\n  3) Because of 2, expose the number of generations past the GC interface\n     using a static variable on IGCHeap that the DAC can read directly.\n\nrepair the Windows build","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/6519911fbccbec049f9592484f69c213b4b78264"},{"sha":"1c43df95410e57f0d40e6ee55012ef65bdac2487","author":{"name":"Sean Gillespie","email":"7a359a9be69d439068f263a8184cbe55a351d06e@gmail.com"},"message":"Merge pull request #6764 from swgillespie/gc-interface-3\n\nMove the GC behind an interface and use that interface in the VM","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/1c43df95410e57f0d40e6ee55012ef65bdac2487"},{"sha":"d54da68a2ba1c1b6345bf66931621b17e1d97f9e","author":{"name":"Pat Gavlin","email":"324147c0e7e65f4285291b25db1c19ffc72308a9@gmail.com"},"message":"Merge pull request #7107 from pgavlin/gh7089\n\nFix #7089.","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/d54da68a2ba1c1b6345bf66931621b17e1d97f9e"},{"sha":"f2e28ea518e4ff42345b99eea2d11e95b58a7dc0","author":{"name":"Kyungwoo Lee","email":"fba579c9b2ed583a2e1b367dacc455fb93e888c8@microsoft.com"},"message":"ILDASM: Ignore Metadata flag for CoreCLR\n\nFull metadata emission is disabled under coreclr.\nSo is ILDASM instead of failing during the run.","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/f2e28ea518e4ff42345b99eea2d11e95b58a7dc0"},{"sha":"871bb909502f205bad8cf47036a37615fbd1ba7a","author":{"name":"Eugene Rozenfeld","email":"b92c126989258baecbfe1802b67fe5907a5aa0d6@microsoft.com"},"message":"Merge pull request #7071 from erozenfeld/StackOverflow\n\nMake GT_LIST processing non-recursive to avoid StackOverflow.","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/871bb909502f205bad8cf47036a37615fbd1ba7a"},{"sha":"c526b321b89bd50b0da5858b9f5853f58b6b849f","author":{"name":"sivarv","email":"73fae3b6c24de473684fcc85cbed17d3fb546409@microsoft.com"},"message":"Fix to #7087","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/c526b321b89bd50b0da5858b9f5853f58b6b849f"},{"sha":"587840091d335f14ded4b6bec514487b8ac5e5e4","author":{"name":"Rahul Kumar","email":"328de7336c502e686bd5152d4ee6dc54f5921228@microsoft.com"},"message":"Add AppContext.UnhandledException to ref file","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/587840091d335f14ded4b6bec514487b8ac5e5e4"},{"sha":"01b87afda3e9b9f21af51c334eb7fb5854070c4d","author":{"name":"Rahul Kumar","email":"328de7336c502e686bd5152d4ee6dc54f5921228@microsoft.com"},"message":"Merge pull request #7112 from rahku/appdomain\n\nAdd AppContext.UnhandledException to ref file","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/01b87afda3e9b9f21af51c334eb7fb5854070c4d"},{"sha":"08f3ae19c6e07e6772ace96706012ed87e4e6f2e","author":{"name":"Bruce Forstall","email":"74743cd806e5cc8aa129b22f4e1c9e76e37958d3@microsoft.com"},"message":"Fix #7100\n\nThis issue is the following assert:\n```\nAssert failure '!emitComp->opts.compReloc || memBase->IsIconHandle()'\n```\nwhile ngen'ing mscorlib on desktop.\n\nWe're trying to generate\n```\ncmp ebx, dword ptr [0000H]\n```\n(due to inlining). But, emitInsBinary() doesn't expect a zero address that\nis not a relocatable handle.\n\nSimply change the assert to allow this. The code then generates the correct\nzero base address.","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/08f3ae19c6e07e6772ace96706012ed87e4e6f2e"},{"sha":"1d90f2cbb3e52323e14354e6873c90b20fb63081","author":{"name":"dotnet-bot","email":"f84cdf622175726c596bcedcda3805233e2ca5f8@microsoft.com"},"message":"Fix a build break introduced by GH#6764\n\n[tfs-changeset: 1626397]","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/1d90f2cbb3e52323e14354e6873c90b20fb63081"},{"sha":"193c5816dff234aa7504826eb559360607748563","author":{"name":"Sean Gillespie","email":"7a359a9be69d439068f263a8184cbe55a351d06e@gmail.com"},"message":"Merge pull request #7116 from dotnet-bot/from-tfs\n\nMerge changes from TFS","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/193c5816dff234aa7504826eb559360607748563"},{"sha":"9f7eabe48460518fb7215de1fabefdc4a6800af1","author":{"name":"Jan Kotas","email":"ef12690177f97a0d90c7dc945df7fe18ccd5b553@microsoft.com"},"message":"Revert \"Fix IMGREL32 static field addr value-num blindspot\"","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/9f7eabe48460518fb7215de1fabefdc4a6800af1"},{"sha":"c16b6bc96c1aa1edd9a3085a12f12a9df4169da5","author":{"name":"Bruce Forstall","email":"74743cd806e5cc8aa129b22f4e1c9e76e37958d3@microsoft.com"},"message":"Fix #7093\n\nThis is an assert due to how STRESS_64RSLT_MUL is implemented. This\nstress mode converts:\n```\n/--*  lclVar    int    V01 loc0\n*  *         int\n\\--*  lclVar    int    V01 loc0\n```\nto:\n```\n*  cast      int <- long\n|  /--*  cast      long <- int\n|  |  \\--*  lclVar    int    V01 loc0\n\\--*  *         long\n   \\--*  cast      long <- long\n      \\--*  nop       long\n         \\--*  lclVar    int    V01 loc0\n```\nThus, the long 'nop' node is above an 'int' operand node. This led to an assert\nin genCodeForTreeLng() that the lclVar was type long, which is isn't.\n\nI added yet another cast under the 'nop' to fix this typing problem:\n```\n*  cast      int <- long\n|  /--*  cast      long <- int\n|  |  \\--*  lclVar    int    V01 loc0\n\\--*  *         long\n   \\--*  cast      long <- long\n      \\--*  nop       long\n         \\--*  cast      long <- int\n            \\--*  lclVar    int    V01 loc0\n```","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/c16b6bc96c1aa1edd9a3085a12f12a9df4169da5"},{"sha":"14628f3218c4678817dedbb41f396ac62d139b8d","author":{"name":"Jan Kotas","email":"ef12690177f97a0d90c7dc945df7fe18ccd5b553@microsoft.com"},"message":"Merge pull request #7118 from dotnet/revert-6889-StaticField\n\nRevert \"Fix IMGREL32 static field addr value-num blindspot\"","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/14628f3218c4678817dedbb41f396ac62d139b8d"},{"sha":"23c166d03a673e515131c2bb8777de308c0637ce","author":{"name":"Jan Vorlicek","email":"09bb9bc2e782fb04614d1a465f5dc8996873b58c@microsoft.com"},"message":"Fix enregistered max size constants on Unix AMD64 (#7117)\n\nThis change fixes ENREGISTERED_PARAMTYPE_MAXSIZE and ENREGISTERED_RETURNTYPE_INTEGER_MAXSIZE\r\nconstants that were not updated properly for the Unix AMD64 ABI. The values are used\r\nfor Unix/AMD64 for marshalling and typedbyref parameters and our tests probably don't\r\nexecute those code paths with structs larger than 8 bytes.","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/23c166d03a673e515131c2bb8777de308c0637ce"},{"sha":"c4d22a210bc28923906b205b219e8bf5c8e58926","author":{"name":"Sean Gillespie","email":"8360f824a9058f9e49e7231bb6790a5c6cebf45e@microsoft.com"},"message":"Only reference IGCHeap::gcHeapType when FEATURE_SVR_GC is defined","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/c4d22a210bc28923906b205b219e8bf5c8e58926"},{"sha":"bd2b72b3516b36a10d5e51fd255df1f2efbb665c","author":{"name":"Sean Gillespie","email":"7a359a9be69d439068f263a8184cbe55a351d06e@gmail.com"},"message":"Merge pull request #7121 from swgillespie/request-build-break\n\nOnly reference IGCHeap::gcHeapType when FEATURE_SVR_GC is defined","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/bd2b72b3516b36a10d5e51fd255df1f2efbb665c"},{"sha":"e3924fd0e3c65b2cae1d7c9d844d7840115916fb","author":{"name":"Kyungwoo Lee","email":"fba579c9b2ed583a2e1b367dacc455fb93e888c8@microsoft.com"},"message":"Merge pull request #7108 from kyulee1/igmeta\n\nILDAMS: Ignore Metadata flag for CoreCLR","distinct":true,"url":"https://api.github.com/repos/BruceForstall/coreclr/commits/e3924fd0e3c65b2cae1d7c9d844d7840115916fb"}]}
{"actor":{"display_login":"BruceForstall"}}