{"action":"created","comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/89692806","pull_request_review_id":10232803,"id":89692806,"diff_hunk":"@@ -706,7 +706,9 @@ import android.*;\n           <tr>\n             <td>file</td>\n             <td>\n-              name of the file containing the import control configuration.\n+              The location of the file containing the import control configuration.\n+              It can be a regular file, URL or resource path. It will try loading\n+              the path as a file first, then as a resource.","path":"src/xdocs/config_imports.xml","position":null,"original_position":7,"commit_id":"b0254f57d05df52e904199b16de8dd14564bb077","original_commit_id":"97e100fb8511c2085e5fbfb7f2138b69db5e5d8d","user":{"login":"jochenvdv","id":6173051,"avatar_url":"https://avatars.githubusercontent.com/u/6173051?v=3","gravatar_id":"","url":"https://api.github.com/users/jochenvdv","html_url":"https://github.com/jochenvdv","followers_url":"https://api.github.com/users/jochenvdv/followers","following_url":"https://api.github.com/users/jochenvdv/following{/other_user}","gists_url":"https://api.github.com/users/jochenvdv/gists{/gist_id}","starred_url":"https://api.github.com/users/jochenvdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochenvdv/subscriptions","organizations_url":"https://api.github.com/users/jochenvdv/orgs","repos_url":"https://api.github.com/users/jochenvdv/repos","events_url":"https://api.github.com/users/jochenvdv/events{/privacy}","received_events_url":"https://api.github.com/users/jochenvdv/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-11-27T15:46:00Z","updated_at":"2016-11-27T15:46:00Z","html_url":"https://github.com/checkstyle/checkstyle/pull/3583#discussion_r89692806","pull_request_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/3583","_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/89692806"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/3583#discussion_r89692806"},"pull_request":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/3583"}}},"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/3583","id":95325472,"html_url":"https://github.com/checkstyle/checkstyle/pull/3583","diff_url":"https://github.com/checkstyle/checkstyle/pull/3583.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/3583.patch","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/3583","number":3583,"state":"open","locked":false,"title":"Issue #3450: Support loading import control configuration from URLs and classpath","user":{"login":"jochenvdv","id":6173051,"avatar_url":"https://avatars.githubusercontent.com/u/6173051?v=3","gravatar_id":"","url":"https://api.github.com/users/jochenvdv","html_url":"https://github.com/jochenvdv","followers_url":"https://api.github.com/users/jochenvdv/followers","following_url":"https://api.github.com/users/jochenvdv/following{/other_user}","gists_url":"https://api.github.com/users/jochenvdv/gists{/gist_id}","starred_url":"https://api.github.com/users/jochenvdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochenvdv/subscriptions","organizations_url":"https://api.github.com/users/jochenvdv/orgs","repos_url":"https://api.github.com/users/jochenvdv/repos","events_url":"https://api.github.com/users/jochenvdv/events{/privacy}","received_events_url":"https://api.github.com/users/jochenvdv/received_events","type":"User","site_admin":false},"body":"Issue #3450\r\n\r\nFor now, I just copied some unit tests to test loading URLs and resources with the `file` property.\r\n\r\nHowever, in [SuppressionFilterTest](https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionFilterTest.java#L159), `CommonUtils#getUriByFilename(String filename)` is mocked with Mockito.\r\n\r\nShould I change the tests to use mocking? If so, they would also have to be changed for testing regular files.\r\n\r\nBy the way, I have kept tests for `url` property until it will be removed.","created_at":"2016-11-25T16:09:05Z","updated_at":"2016-11-27T15:46:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64ee2d0c7b98cea98b10354c3c618ee3b585955a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/3583/commits","review_comments_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/3583/comments","review_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/3583/comments","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/b0254f57d05df52e904199b16de8dd14564bb077","head":{"label":"jochenvdv:issue-3450","ref":"issue-3450","sha":"b0254f57d05df52e904199b16de8dd14564bb077","user":{"login":"jochenvdv","id":6173051,"avatar_url":"https://avatars.githubusercontent.com/u/6173051?v=3","gravatar_id":"","url":"https://api.github.com/users/jochenvdv","html_url":"https://github.com/jochenvdv","followers_url":"https://api.github.com/users/jochenvdv/followers","following_url":"https://api.github.com/users/jochenvdv/following{/other_user}","gists_url":"https://api.github.com/users/jochenvdv/gists{/gist_id}","starred_url":"https://api.github.com/users/jochenvdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochenvdv/subscriptions","organizations_url":"https://api.github.com/users/jochenvdv/orgs","repos_url":"https://api.github.com/users/jochenvdv/repos","events_url":"https://api.github.com/users/jochenvdv/events{/privacy}","received_events_url":"https://api.github.com/users/jochenvdv/received_events","type":"User","site_admin":false},"repo":{"id":71600874,"name":"checkstyle","full_name":"jochenvdv/checkstyle","owner":{"login":"jochenvdv","id":6173051,"avatar_url":"https://avatars.githubusercontent.com/u/6173051?v=3","gravatar_id":"","url":"https://api.github.com/users/jochenvdv","html_url":"https://github.com/jochenvdv","followers_url":"https://api.github.com/users/jochenvdv/followers","following_url":"https://api.github.com/users/jochenvdv/following{/other_user}","gists_url":"https://api.github.com/users/jochenvdv/gists{/gist_id}","starred_url":"https://api.github.com/users/jochenvdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochenvdv/subscriptions","organizations_url":"https://api.github.com/users/jochenvdv/orgs","repos_url":"https://api.github.com/users/jochenvdv/repos","events_url":"https://api.github.com/users/jochenvdv/events{/privacy}","received_events_url":"https://api.github.com/users/jochenvdv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jochenvdv/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":true,"url":"https://api.github.com/repos/jochenvdv/checkstyle","forks_url":"https://api.github.com/repos/jochenvdv/checkstyle/forks","keys_url":"https://api.github.com/repos/jochenvdv/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jochenvdv/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jochenvdv/checkstyle/teams","hooks_url":"https://api.github.com/repos/jochenvdv/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/jochenvdv/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/jochenvdv/checkstyle/events","assignees_url":"https://api.github.com/repos/jochenvdv/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/jochenvdv/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/jochenvdv/checkstyle/tags","blobs_url":"https://api.github.com/repos/jochenvdv/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jochenvdv/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jochenvdv/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jochenvdv/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jochenvdv/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/jochenvdv/checkstyle/languages","stargazers_url":"https://api.github.com/repos/jochenvdv/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/jochenvdv/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/jochenvdv/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/jochenvdv/checkstyle/subscription","commits_url":"https://api.github.com/repos/jochenvdv/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jochenvdv/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jochenvdv/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jochenvdv/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jochenvdv/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/jochenvdv/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jochenvdv/checkstyle/merges","archive_url":"https://api.github.com/repos/jochenvdv/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jochenvdv/checkstyle/downloads","issues_url":"https://api.github.com/repos/jochenvdv/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/jochenvdv/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/jochenvdv/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/jochenvdv/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jochenvdv/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/jochenvdv/checkstyle/releases{/id}","deployments_url":"https://api.github.com/repos/jochenvdv/checkstyle/deployments","created_at":"2016-10-21T22:15:44Z","updated_at":"2016-10-21T22:15:49Z","pushed_at":"2016-11-27T15:39:33Z","git_url":"git://github.com/jochenvdv/checkstyle.git","ssh_url":"git@github.com:jochenvdv/checkstyle.git","clone_url":"https://github.com/jochenvdv/checkstyle.git","svn_url":"https://github.com/jochenvdv/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":52478,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"checkstyle:master","ref":"master","sha":"825e6a8fcd85e1d77ba86b39aa3834b03344a055","user":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars.githubusercontent.com/u/5179750?v=3","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"repo":{"id":12499251,"name":"checkstyle","full_name":"checkstyle/checkstyle","owner":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars.githubusercontent.com/u/5179750?v=3","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/checkstyle/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":false,"url":"https://api.github.com/repos/checkstyle/checkstyle","forks_url":"https://api.github.com/repos/checkstyle/checkstyle/forks","keys_url":"https://api.github.com/repos/checkstyle/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checkstyle/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checkstyle/checkstyle/teams","hooks_url":"https://api.github.com/repos/checkstyle/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/checkstyle/checkstyle/events","assignees_url":"https://api.github.com/repos/checkstyle/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/checkstyle/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/checkstyle/checkstyle/tags","blobs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checkstyle/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/checkstyle/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/checkstyle/checkstyle/languages","stargazers_url":"https://api.github.com/repos/checkstyle/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/checkstyle/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/checkstyle/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/checkstyle/checkstyle/subscription","commits_url":"https://api.github.com/repos/checkstyle/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/checkstyle/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/checkstyle/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/checkstyle/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checkstyle/checkstyle/merges","archive_url":"https://api.github.com/repos/checkstyle/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checkstyle/checkstyle/downloads","issues_url":"https://api.github.com/repos/checkstyle/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/checkstyle/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/checkstyle/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/checkstyle/checkstyle/releases{/id}","deployments_url":"https://api.github.com/repos/checkstyle/checkstyle/deployments","created_at":"2013-08-31T02:05:05Z","updated_at":"2016-11-27T10:50:26Z","pushed_at":"2016-11-27T15:39:34Z","git_url":"git://github.com/checkstyle/checkstyle.git","ssh_url":"git@github.com:checkstyle/checkstyle.git","clone_url":"https://github.com/checkstyle/checkstyle.git","svn_url":"https://github.com/checkstyle/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":59149,"stargazers_count":1483,"watchers_count":1483,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":671,"mirror_url":null,"open_issues_count":284,"forks":671,"open_issues":284,"watchers":1483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/3583"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/3583"},"issue":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/3583"},"comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/3583/comments"},"review_comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/3583/comments"},"review_comment":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/3583/commits"},"statuses":{"href":"https://api.github.com/repos/checkstyle/checkstyle/statuses/b0254f57d05df52e904199b16de8dd14564bb077"}}}}
{"actor":{"display_login":"jochenvdv"}}