{"action":"closed","issue":{"url":"https://api.github.com/repos/geocohn/Twitternator/issues/1","repository_url":"https://api.github.com/repos/geocohn/Twitternator","labels_url":"https://api.github.com/repos/geocohn/Twitternator/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/geocohn/Twitternator/issues/1/comments","events_url":"https://api.github.com/repos/geocohn/Twitternator/issues/1/events","html_url":"https://github.com/geocohn/Twitternator/issues/1","id":186215448,"number":1,"title":"Project Feedback!","user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-31T06:37:49Z","updated_at":"2016-11-07T01:27:56Z","closed_at":"2016-11-07T01:27:56Z","body":":+1: Nice work overall. A few notes after checking out the code:\r\n\r\n* Nice to see you successfully used OAuth login. OAuth is widely used and it's important to understand OAuth v1 and v2 properly.\r\n* Good to see you were able to format the timestamp cleanly (consider using the short format - `8m`, `7h`, etc.)\r\n* Nice touch with the character count being displayed while the user composes a tweet\r\n* Nice to see you used a `SwipeRefreshLayout` library for easy timeline refreshes\r\n* Good to see you added the new tweet directly to the home timeline after it was successfully posted to Twitter.\r\n* Good to see you added `DBFlow` annotations to the models\r\n* Consider using [Parceler](https://guides.codepath.com/android/Using-Parceler) instead of directly using Parcelable to reduce boilerplate and conveniently serialize and deserialize objects.\r\n* Consider adding [progress bars] (http://guides.codepath.com/android/Handling-ProgressBars#actionbar-progress-bar) to your app whenever a network request goes out\r\n\r\nHere's a detailed [Project 3 Feedback Guide here](http://courses.codepath.com/snippets/intro_to_android/project_3_feedback) which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission. \r\n\r\nLet us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a \"critical mass\" towards your knowledge of Android."}}
{"actor":{"display_login":"geocohn"}}