{"action":"created","issue":{"url":"https://api.github.com/repos/jabbink/PokemonGoBot/issues/1155","repository_url":"https://api.github.com/repos/jabbink/PokemonGoBot","labels_url":"https://api.github.com/repos/jabbink/PokemonGoBot/issues/1155/labels{/name}","comments_url":"https://api.github.com/repos/jabbink/PokemonGoBot/issues/1155/comments","events_url":"https://api.github.com/repos/jabbink/PokemonGoBot/issues/1155/events","html_url":"https://github.com/jabbink/PokemonGoBot/pull/1155","id":171787565,"number":1155,"title":"Use correct altitude for given GPS coordinates","user":{"login":"KyleBoyer","id":1487324,"avatar_url":"https://avatars.githubusercontent.com/u/1487324?v=3","gravatar_id":"","url":"https://api.github.com/users/KyleBoyer","html_url":"https://github.com/KyleBoyer","followers_url":"https://api.github.com/users/KyleBoyer/followers","following_url":"https://api.github.com/users/KyleBoyer/following{/other_user}","gists_url":"https://api.github.com/users/KyleBoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/KyleBoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyleBoyer/subscriptions","organizations_url":"https://api.github.com/users/KyleBoyer/orgs","repos_url":"https://api.github.com/users/KyleBoyer/repos","events_url":"https://api.github.com/users/KyleBoyer/events{/privacy}","received_events_url":"https://api.github.com/users/KyleBoyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-17T23:54:25Z","updated_at":"2016-08-18T09:07:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jabbink/PokemonGoBot/pulls/1155","html_url":"https://github.com/jabbink/PokemonGoBot/pull/1155","diff_url":"https://github.com/jabbink/PokemonGoBot/pull/1155.diff","patch_url":"https://github.com/jabbink/PokemonGoBot/pull/1155.patch"},"body":"Fixes: https://github.com/jabbink/PokemonGoBot/issues/1122\r\n\r\n**Changes made:**\r\n\r\n* Looks up correct elevation/altitude in meters for given GPS coordinates\r\n* Fixed 2 warnings(by changing var to val)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jabbink/PokemonGoBot/issues/comments/240666354","html_url":"https://github.com/jabbink/PokemonGoBot/pull/1155#issuecomment-240666354","issue_url":"https://api.github.com/repos/jabbink/PokemonGoBot/issues/1155","id":240666354,"user":{"login":"Sieberkev","id":3216851,"avatar_url":"https://avatars.githubusercontent.com/u/3216851?v=3","gravatar_id":"","url":"https://api.github.com/users/Sieberkev","html_url":"https://github.com/Sieberkev","followers_url":"https://api.github.com/users/Sieberkev/followers","following_url":"https://api.github.com/users/Sieberkev/following{/other_user}","gists_url":"https://api.github.com/users/Sieberkev/gists{/gist_id}","starred_url":"https://api.github.com/users/Sieberkev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sieberkev/subscriptions","organizations_url":"https://api.github.com/users/Sieberkev/orgs","repos_url":"https://api.github.com/users/Sieberkev/repos","events_url":"https://api.github.com/users/Sieberkev/events{/privacy}","received_events_url":"https://api.github.com/users/Sieberkev/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T09:07:21Z","updated_at":"2016-08-18T09:07:21Z","body":"> however i believe getting the altitude on each Start wont overload their servers\r\n\r\nIf you start every time on the exact same location, that altitude will never change (maybe when a volcano erupts, but what are the chances of that).\r\nIf you are caching anyway (because nuking other APIs/servers for information that does not change it not very polite), you better use that value too on start since you have it anyway.\r\n\r\n> If I change the location my bot is farming, the altitude should change too.\r\n\r\nEach time you move, it checks in which S2 cell you are. If that value is cached, use that value (+/- a small randomisation on large cells), if you don't have it in cache, fetch it from the external server."}}
{"actor":{"display_login":"Sieberkev"}}