{"action":"created","comment":{"url":"https://api.github.com/repos/uber/ringpop-node/pulls/comments/62495107","id":62495107,"diff_hunk":"@@ -63,6 +63,7 @@ require('util').inherits(DiscoverProviderHealer, Healer);\n  */\n DiscoverProviderHealer.prototype.heal = function heal(callback) {\n     var self = this;\n+    self.ringpop.stat('increment', 'heal.triggered.discover_provider');","path":"lib/partition_healing/discover_provider_healer.js","position":null,"original_position":4,"commit_id":"d23220af5582f3ed54e7055934320fbfdf818ffa","original_commit_id":"d23220af5582f3ed54e7055934320fbfdf818ffa","user":{"login":"thanodnl","id":273145,"avatar_url":"https://avatars.githubusercontent.com/u/273145?v=3","gravatar_id":"","url":"https://api.github.com/users/thanodnl","html_url":"https://github.com/thanodnl","followers_url":"https://api.github.com/users/thanodnl/followers","following_url":"https://api.github.com/users/thanodnl/following{/other_user}","gists_url":"https://api.github.com/users/thanodnl/gists{/gist_id}","starred_url":"https://api.github.com/users/thanodnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanodnl/subscriptions","organizations_url":"https://api.github.com/users/thanodnl/orgs","repos_url":"https://api.github.com/users/thanodnl/repos","events_url":"https://api.github.com/users/thanodnl/events{/privacy}","received_events_url":"https://api.github.com/users/thanodnl/received_events","type":"User","site_admin":false},"body":"the stat we emit here differs from the stat in `ringpop-go`: https://github.com/uber/ringpop-go/blob/dev/ringpop.go#L497 is that on purpose?","created_at":"2016-05-09T13:13:33Z","updated_at":"2016-05-09T13:13:33Z","html_url":"https://github.com/uber/ringpop-node/pull/264#discussion_r62495107","pull_request_url":"https://api.github.com/repos/uber/ringpop-node/pulls/264","_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop-node/pulls/comments/62495107"},"html":{"href":"https://github.com/uber/ringpop-node/pull/264#discussion_r62495107"},"pull_request":{"href":"https://api.github.com/repos/uber/ringpop-node/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/uber/ringpop-node/pulls/264","id":68910306,"html_url":"https://github.com/uber/ringpop-node/pull/264","diff_url":"https://github.com/uber/ringpop-node/pull/264.diff","patch_url":"https://github.com/uber/ringpop-node/pull/264.patch","issue_url":"https://api.github.com/repos/uber/ringpop-node/issues/264","number":264,"state":"open","locked":false,"title":"Partition healing","user":{"login":"mennopruijssers","id":831983,"avatar_url":"https://avatars.githubusercontent.com/u/831983?v=3","gravatar_id":"","url":"https://api.github.com/users/mennopruijssers","html_url":"https://github.com/mennopruijssers","followers_url":"https://api.github.com/users/mennopruijssers/followers","following_url":"https://api.github.com/users/mennopruijssers/following{/other_user}","gists_url":"https://api.github.com/users/mennopruijssers/gists{/gist_id}","starred_url":"https://api.github.com/users/mennopruijssers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mennopruijssers/subscriptions","organizations_url":"https://api.github.com/users/mennopruijssers/orgs","repos_url":"https://api.github.com/users/mennopruijssers/repos","events_url":"https://api.github.com/users/mennopruijssers/events{/privacy}","received_events_url":"https://api.github.com/users/mennopruijssers/received_events","type":"User","site_admin":false},"body":"This PR adds partition healing to ringpop-node. This initial PR is only healing manually. Periodic partition healing will be added in a subsequent PR.","created_at":"2016-05-04T18:36:20Z","updated_at":"2016-05-09T13:13:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8832ce9f37145213a792ed7bd3e630b812a2f92a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/ringpop-node/pulls/264/commits","review_comments_url":"https://api.github.com/repos/uber/ringpop-node/pulls/264/comments","review_comment_url":"https://api.github.com/repos/uber/ringpop-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/ringpop-node/issues/264/comments","statuses_url":"https://api.github.com/repos/uber/ringpop-node/statuses/d23220af5582f3ed54e7055934320fbfdf818ffa","head":{"label":"uber:menno/partition-healing","ref":"menno/partition-healing","sha":"d23220af5582f3ed54e7055934320fbfdf818ffa","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":29378455,"name":"ringpop-node","full_name":"uber/ringpop-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop-node","description":"Scalable, fault-tolerant application-layer sharding for Node.js applications","fork":false,"url":"https://api.github.com/repos/uber/ringpop-node","forks_url":"https://api.github.com/repos/uber/ringpop-node/forks","keys_url":"https://api.github.com/repos/uber/ringpop-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop-node/teams","hooks_url":"https://api.github.com/repos/uber/ringpop-node/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop-node/events","assignees_url":"https://api.github.com/repos/uber/ringpop-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop-node/tags","blobs_url":"https://api.github.com/repos/uber/ringpop-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop-node/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop-node/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop-node/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop-node/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop-node/subscription","commits_url":"https://api.github.com/repos/uber/ringpop-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop-node/merges","archive_url":"https://api.github.com/repos/uber/ringpop-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop-node/downloads","issues_url":"https://api.github.com/repos/uber/ringpop-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop-node/releases{/id}","deployments_url":"https://api.github.com/repos/uber/ringpop-node/deployments","created_at":"2015-01-17T03:26:35Z","updated_at":"2016-05-07T00:50:44Z","pushed_at":"2016-05-09T12:28:00Z","git_url":"git://github.com/uber/ringpop-node.git","ssh_url":"git@github.com:uber/ringpop-node.git","clone_url":"https://github.com/uber/ringpop-node.git","svn_url":"https://github.com/uber/ringpop-node","homepage":"http://uber.github.io/ringpop/","size":1442,"stargazers_count":581,"watchers_count":581,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":25,"forks":63,"open_issues":25,"watchers":581,"default_branch":"master"}},"base":{"label":"uber:menno/partition-healing-base","ref":"menno/partition-healing-base","sha":"5724b104c21d8f98ffbba71d255d72fe79c75e2e","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":29378455,"name":"ringpop-node","full_name":"uber/ringpop-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop-node","description":"Scalable, fault-tolerant application-layer sharding for Node.js applications","fork":false,"url":"https://api.github.com/repos/uber/ringpop-node","forks_url":"https://api.github.com/repos/uber/ringpop-node/forks","keys_url":"https://api.github.com/repos/uber/ringpop-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop-node/teams","hooks_url":"https://api.github.com/repos/uber/ringpop-node/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop-node/events","assignees_url":"https://api.github.com/repos/uber/ringpop-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop-node/tags","blobs_url":"https://api.github.com/repos/uber/ringpop-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop-node/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop-node/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop-node/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop-node/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop-node/subscription","commits_url":"https://api.github.com/repos/uber/ringpop-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop-node/merges","archive_url":"https://api.github.com/repos/uber/ringpop-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop-node/downloads","issues_url":"https://api.github.com/repos/uber/ringpop-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop-node/releases{/id}","deployments_url":"https://api.github.com/repos/uber/ringpop-node/deployments","created_at":"2015-01-17T03:26:35Z","updated_at":"2016-05-07T00:50:44Z","pushed_at":"2016-05-09T12:28:00Z","git_url":"git://github.com/uber/ringpop-node.git","ssh_url":"git@github.com:uber/ringpop-node.git","clone_url":"https://github.com/uber/ringpop-node.git","svn_url":"https://github.com/uber/ringpop-node","homepage":"http://uber.github.io/ringpop/","size":1442,"stargazers_count":581,"watchers_count":581,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":25,"forks":63,"open_issues":25,"watchers":581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop-node/pulls/264"},"html":{"href":"https://github.com/uber/ringpop-node/pull/264"},"issue":{"href":"https://api.github.com/repos/uber/ringpop-node/issues/264"},"comments":{"href":"https://api.github.com/repos/uber/ringpop-node/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/ringpop-node/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/ringpop-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/ringpop-node/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/uber/ringpop-node/statuses/d23220af5582f3ed54e7055934320fbfdf818ffa"}}}}