{"action":"created","issue":{"url":"https://api.github.com/repos/qmlweb/qmlweb/issues/106","repository_url":"https://api.github.com/repos/qmlweb/qmlweb","labels_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/106/comments","events_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/106/events","html_url":"https://github.com/qmlweb/qmlweb/pull/106","id":138670420,"number":106,"title":"Refactor render test","user":{"login":"henrikrudstrom","id":82979,"avatar_url":"https://avatars.githubusercontent.com/u/82979?v=3","gravatar_id":"","url":"https://api.github.com/users/henrikrudstrom","html_url":"https://github.com/henrikrudstrom","followers_url":"https://api.github.com/users/henrikrudstrom/followers","following_url":"https://api.github.com/users/henrikrudstrom/following{/other_user}","gists_url":"https://api.github.com/users/henrikrudstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikrudstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikrudstrom/subscriptions","organizations_url":"https://api.github.com/users/henrikrudstrom/orgs","repos_url":"https://api.github.com/users/henrikrudstrom/repos","events_url":"https://api.github.com/users/henrikrudstrom/events{/privacy}","received_events_url":"https://api.github.com/users/henrikrudstrom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/qmlweb/qmlweb/labels/tests","name":"tests","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-05T11:21:23Z","updated_at":"2016-03-07T09:23:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/106","html_url":"https://github.com/qmlweb/qmlweb/pull/106","diff_url":"https://github.com/qmlweb/qmlweb/pull/106.diff","patch_url":"https://github.com/qmlweb/qmlweb/pull/106.patch"},"body":"Moved the render test code out of runner.js so it can be used in other test suites: \r\nThat means we can organize the tests by the *subject* of test instead of *method* of test \r\n```\r\n  var itCanRender = prefixedRenderTester(\"QtQuick/qml/Rectangle\");\r\n  itCanRender(\"Color\");\r\n```\r\n* Moved some of the render tests to their respective QtQuick test suite...\r\n* Files that are not in `tests/Render` can be flagged for rendering with `//@Render` as the first line of the qml file (depends on #84) to so that [qmlweb-dev](https://github.com/qmlweb/qmlweb-dev) knows it needs a screenshot.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/qmlweb/qmlweb/issues/comments/193176647","html_url":"https://github.com/qmlweb/qmlweb/pull/106#issuecomment-193176647","issue_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/106","id":193176647,"user":{"login":"henrikrudstrom","id":82979,"avatar_url":"https://avatars.githubusercontent.com/u/82979?v=3","gravatar_id":"","url":"https://api.github.com/users/henrikrudstrom","html_url":"https://github.com/henrikrudstrom","followers_url":"https://api.github.com/users/henrikrudstrom/followers","following_url":"https://api.github.com/users/henrikrudstrom/following{/other_user}","gists_url":"https://api.github.com/users/henrikrudstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikrudstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikrudstrom/subscriptions","organizations_url":"https://api.github.com/users/henrikrudstrom/orgs","repos_url":"https://api.github.com/users/henrikrudstrom/repos","events_url":"https://api.github.com/users/henrikrudstrom/events{/privacy}","received_events_url":"https://api.github.com/users/henrikrudstrom/received_events","type":"User","site_admin":false},"created_at":"2016-03-07T09:23:35Z","updated_at":"2016-03-07T09:23:35Z","body":"I think adding a line of javascript code is an acceptable, but its a good point about a single file that has to be edited, didnt think about that.\r\nIf we make one test suite pr component (in `Render` folder or together with inspection tests). the same file editing shouldnt be that much of an issue. \r\n```\r\nRender/QtQuick/Rectangle.js\r\nRender/QtQuick/qml/RectangleSomething.qml\r\nRender/QtQuick/qml/RectangleSomething.png\r\n```\r\nThe advantages is see are:\r\n* more flexible handling of test cases (like Async vs Simple now, more Complex later)\r\n* we can specify which .qml file is a test if we need to define a sub qml file that doesnt stand on itself.\r\n\r\n\r\n"}}