{"action":"closed","number":330,"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/330","id":85561981,"html_url":"https://github.com/apache/brooklyn-server/pull/330","diff_url":"https://github.com/apache/brooklyn-server/pull/330.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/330.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/330","number":330,"state":"closed","locked":false,"title":"TypeCoerce string to byte[]","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"An alternative impl would have been to treat the given string as base64 encoded. But I don't think that is what people would expect as the default. However, by using a simple `string.getBytes()` there are two downsides:\r\n* can't pass in some byte array values, e.g. in UI effector parameter (would require base64 for that)\r\n* it's using the default of the JVM (e.g. rather than explicitly using UTF-8)\r\n\r\nI think that's good enough though - thoughts?\r\n\r\nMy use-case is in a test case I wrote for a HTTP client entity, where an effector takes a parameter of type `byte[]` and uses that as the payload of a POST request. The most common situation I think is where one wants to just pass a \"normal\" string body.","created_at":"2016-09-16T12:06:15Z","updated_at":"2016-09-22T20:51:55Z","closed_at":"2016-09-22T20:51:55Z","merged_at":null,"merge_commit_sha":"899f1ecb4e4addec8b5acb01b136f3cc9c23f71a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/330/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/330/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/330/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/79e35a486b9aff44b0f9dfe0b5c3b4a336ef33bd","head":{"label":"aledsage:typeCoercions-string-to-byte-array","ref":"typeCoercions-string-to-byte-array","sha":"79e35a486b9aff44b0f9dfe0b5c3b4a336ef33bd","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"repo":{"id":50909018,"name":"brooklyn-server","full_name":"aledsage/brooklyn-server","owner":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledsage/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/aledsage/brooklyn-server","forks_url":"https://api.github.com/repos/aledsage/brooklyn-server/forks","keys_url":"https://api.github.com/repos/aledsage/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledsage/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledsage/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/aledsage/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/aledsage/brooklyn-server/events","assignees_url":"https://api.github.com/repos/aledsage/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/aledsage/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/aledsage/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledsage/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/aledsage/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/aledsage/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/aledsage/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/aledsage/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/aledsage/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/aledsage/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledsage/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledsage/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledsage/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/aledsage/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledsage/brooklyn-server/merges","archive_url":"https://api.github.com/repos/aledsage/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledsage/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/aledsage/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/aledsage/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/aledsage/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/aledsage/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledsage/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/aledsage/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/aledsage/brooklyn-server/deployments","created_at":"2016-02-02T09:23:44Z","updated_at":"2016-02-02T09:23:52Z","pushed_at":"2016-09-22T20:04:19Z","git_url":"git://github.com/aledsage/brooklyn-server.git","ssh_url":"git@github.com:aledsage/brooklyn-server.git","clone_url":"https://github.com/aledsage/brooklyn-server.git","svn_url":"https://github.com/aledsage/brooklyn-server","homepage":null,"size":31095,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e947e929a743dbb55aedc953fdd2bbc4f75ce0db","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-09-04T17:03:47Z","pushed_at":"2016-09-22T20:38:10Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":31276,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":26,"forks":37,"open_issues":26,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/330"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/330"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/330"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/79e35a486b9aff44b0f9dfe0b5c3b4a336ef33bd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":11,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"aledsage"}}