{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/60261955","id":60261955,"diff_hunk":"@@ -112,16 +110,42 @@ class FlutterDriverExtension {\n     }\n   }\n \n+  Stream<Duration> _onFrameReadyStream;\n+  Stream<Duration> get _onFrameReady {\n+    if (_onFrameReadyStream == null) {\n+      // Lazy-initialize the frame callback because the renderer is not yet\n+      // available at the time the extension is registered.\n+      StreamController<Duration> frameReadyController = new StreamController<Duration>.broadcast(sync: true);\n+      Renderer.instance.addPersistentFrameCallback((Duration timestamp) {","path":"packages/flutter_driver/lib/src/extension.dart","position":74,"original_position":74,"commit_id":"370ff93786e30ea1d349165ff27c73d4cc7a9b31","original_commit_id":"370ff93786e30ea1d349165ff27c73d4cc7a9b31","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"Scheduler, not Renderer","created_at":"2016-04-19T16:15:19Z","updated_at":"2016-04-19T16:15:19Z","html_url":"https://github.com/flutter/flutter/pull/3373#discussion_r60261955","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/3373","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/60261955"},"html":{"href":"https://github.com/flutter/flutter/pull/3373#discussion_r60261955"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3373"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/3373","id":66728833,"html_url":"https://github.com/flutter/flutter/pull/3373","diff_url":"https://github.com/flutter/flutter/pull/3373.diff","patch_url":"https://github.com/flutter/flutter/pull/3373.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/3373","number":3373,"state":"open","locked":false,"title":"[driver] \"waitFor\" command in place of broken \"exists\"","user":{"login":"yjbanov","id":211513,"avatar_url":"https://avatars.githubusercontent.com/u/211513?v=3","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"body":"- Replace the driver-side polling \"waitFor\" method with one executed on the extension side\r\n- Delete the half-implemented \"Exists\" command (currently breaks the `sample_app` integration test)","created_at":"2016-04-16T05:43:37Z","updated_at":"2016-04-19T16:15:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1a0514f5d1b5375a749637e23d368de45613d74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/3373/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/3373/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/3373/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/370ff93786e30ea1d349165ff27c73d4cc7a9b31","head":{"label":"yjbanov:do-not-use-Exists","ref":"do-not-use-Exists","sha":"370ff93786e30ea1d349165ff27c73d4cc7a9b31","user":{"login":"yjbanov","id":211513,"avatar_url":"https://avatars.githubusercontent.com/u/211513?v=3","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"repo":{"id":50871415,"name":"flutter","full_name":"yjbanov/flutter","owner":{"login":"yjbanov","id":211513,"avatar_url":"https://avatars.githubusercontent.com/u/211513?v=3","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yjbanov/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":true,"url":"https://api.github.com/repos/yjbanov/flutter","forks_url":"https://api.github.com/repos/yjbanov/flutter/forks","keys_url":"https://api.github.com/repos/yjbanov/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yjbanov/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yjbanov/flutter/teams","hooks_url":"https://api.github.com/repos/yjbanov/flutter/hooks","issue_events_url":"https://api.github.com/repos/yjbanov/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/yjbanov/flutter/events","assignees_url":"https://api.github.com/repos/yjbanov/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/yjbanov/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/yjbanov/flutter/tags","blobs_url":"https://api.github.com/repos/yjbanov/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yjbanov/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yjbanov/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/yjbanov/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yjbanov/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/yjbanov/flutter/languages","stargazers_url":"https://api.github.com/repos/yjbanov/flutter/stargazers","contributors_url":"https://api.github.com/repos/yjbanov/flutter/contributors","subscribers_url":"https://api.github.com/repos/yjbanov/flutter/subscribers","subscription_url":"https://api.github.com/repos/yjbanov/flutter/subscription","commits_url":"https://api.github.com/repos/yjbanov/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/yjbanov/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/yjbanov/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/yjbanov/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/yjbanov/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/yjbanov/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yjbanov/flutter/merges","archive_url":"https://api.github.com/repos/yjbanov/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yjbanov/flutter/downloads","issues_url":"https://api.github.com/repos/yjbanov/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/yjbanov/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/yjbanov/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/yjbanov/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yjbanov/flutter/labels{/name}","releases_url":"https://api.github.com/repos/yjbanov/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/yjbanov/flutter/deployments","created_at":"2016-02-01T21:09:40Z","updated_at":"2016-02-01T21:09:42Z","pushed_at":"2016-04-19T06:19:15Z","git_url":"git://github.com/yjbanov/flutter.git","ssh_url":"git@github.com:yjbanov/flutter.git","clone_url":"https://github.com/yjbanov/flutter.git","svn_url":"https://github.com/yjbanov/flutter","homepage":"http://flutter.io","size":15937,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"1c0a966384772d61d33b976b6e19cc69f41acb5e","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-04-19T09:00:05Z","pushed_at":"2016-04-19T06:19:16Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"http://flutter.io","size":109695,"stargazers_count":2749,"watchers_count":2749,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"open_issues_count":838,"forks":278,"open_issues":838,"watchers":2749,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3373"},"html":{"href":"https://github.com/flutter/flutter/pull/3373"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/3373"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/3373/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3373/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3373/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/370ff93786e30ea1d349165ff27c73d4cc7a9b31"}}}}