{"action":"created","comment":{"url":"https://api.github.com/repos/rock-core/base-cmake/pulls/comments/78632399","id":78632399,"diff_hunk":"@@ -49,6 +49,31 @@ function(rock_add_compiler_flag_if_it_exists FLAG)\n     endif()\n endfunction()\n \n+macro(ADD_TARGET_PROPERTIES _target _name _properties)\n+    set(_properties ${ARGV})\n+    list(REMOVE_AT _properties 0)\n+    list(REMOVE_AT _properties 0)\n+    get_target_property(_old_properties ${_target} ${_name})\n+    if(NOT _old_properties)\n+        set(_old_properties)\n+    else(NOT _old_properties)","path":"modules/Rock.cmake","position":11,"original_position":11,"commit_id":"8eddbeef04d3c0f48c3d8a6072ed144160de2c63","original_commit_id":"8eddbeef04d3c0f48c3d8a6072ed144160de2c63","user":{"login":"doudou","id":292,"avatar_url":"https://avatars.githubusercontent.com/u/292?v=3","gravatar_id":"","url":"https://api.github.com/users/doudou","html_url":"https://github.com/doudou","followers_url":"https://api.github.com/users/doudou/followers","following_url":"https://api.github.com/users/doudou/following{/other_user}","gists_url":"https://api.github.com/users/doudou/gists{/gist_id}","starred_url":"https://api.github.com/users/doudou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doudou/subscriptions","organizations_url":"https://api.github.com/users/doudou/orgs","repos_url":"https://api.github.com/users/doudou/repos","events_url":"https://api.github.com/users/doudou/events{/privacy}","received_events_url":"https://api.github.com/users/doudou/received_events","type":"User","site_admin":false},"body":"repeating the arguments to CMake constructs has not been needed for a very long time ... and is deprecated. Don't do it, e.g.\r\n\r\n```\r\nif (xxxxx)\r\nelse()\r\nendif()\r\n```","created_at":"2016-09-13T19:57:18Z","updated_at":"2016-09-13T19:57:18Z","html_url":"https://github.com/rock-core/base-cmake/pull/35#discussion_r78632399","pull_request_url":"https://api.github.com/repos/rock-core/base-cmake/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/rock-core/base-cmake/pulls/comments/78632399"},"html":{"href":"https://github.com/rock-core/base-cmake/pull/35#discussion_r78632399"},"pull_request":{"href":"https://api.github.com/repos/rock-core/base-cmake/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/rock-core/base-cmake/pulls/35","id":84638879,"html_url":"https://github.com/rock-core/base-cmake/pull/35","diff_url":"https://github.com/rock-core/base-cmake/pull/35.diff","patch_url":"https://github.com/rock-core/base-cmake/pull/35.patch","issue_url":"https://api.github.com/repos/rock-core/base-cmake/issues/35","number":35,"state":"open","locked":false,"title":"Add support for C targets","user":{"login":"g-arjones","id":17409636,"avatar_url":"https://avatars.githubusercontent.com/u/17409636?v=3","gravatar_id":"","url":"https://api.github.com/users/g-arjones","html_url":"https://github.com/g-arjones","followers_url":"https://api.github.com/users/g-arjones/followers","following_url":"https://api.github.com/users/g-arjones/following{/other_user}","gists_url":"https://api.github.com/users/g-arjones/gists{/gist_id}","starred_url":"https://api.github.com/users/g-arjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-arjones/subscriptions","organizations_url":"https://api.github.com/users/g-arjones/orgs","repos_url":"https://api.github.com/users/g-arjones/repos","events_url":"https://api.github.com/users/g-arjones/events{/privacy}","received_events_url":"https://api.github.com/users/g-arjones/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-09T12:00:54Z","updated_at":"2016-09-13T19:57:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2ec44984c11e1f2e5660be67aebd40ce02b3474","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rock-core/base-cmake/pulls/35/commits","review_comments_url":"https://api.github.com/repos/rock-core/base-cmake/pulls/35/comments","review_comment_url":"https://api.github.com/repos/rock-core/base-cmake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rock-core/base-cmake/issues/35/comments","statuses_url":"https://api.github.com/repos/rock-core/base-cmake/statuses/8eddbeef04d3c0f48c3d8a6072ed144160de2c63","head":{"label":"Brazilian-Institute-of-Robotics:support_c","ref":"support_c","sha":"8eddbeef04d3c0f48c3d8a6072ed144160de2c63","user":{"login":"Brazilian-Institute-of-Robotics","id":7870694,"avatar_url":"https://avatars.githubusercontent.com/u/7870694?v=3","gravatar_id":"","url":"https://api.github.com/users/Brazilian-Institute-of-Robotics","html_url":"https://github.com/Brazilian-Institute-of-Robotics","followers_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/followers","following_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/following{/other_user}","gists_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/gists{/gist_id}","starred_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/subscriptions","organizations_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/orgs","repos_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/repos","events_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/events{/privacy}","received_events_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/received_events","type":"Organization","site_admin":false},"repo":{"id":67219890,"name":"base-cmake","full_name":"Brazilian-Institute-of-Robotics/base-cmake","owner":{"login":"Brazilian-Institute-of-Robotics","id":7870694,"avatar_url":"https://avatars.githubusercontent.com/u/7870694?v=3","gravatar_id":"","url":"https://api.github.com/users/Brazilian-Institute-of-Robotics","html_url":"https://github.com/Brazilian-Institute-of-Robotics","followers_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/followers","following_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/following{/other_user}","gists_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/gists{/gist_id}","starred_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/subscriptions","organizations_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/orgs","repos_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/repos","events_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/events{/privacy}","received_events_url":"https://api.github.com/users/Brazilian-Institute-of-Robotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brazilian-Institute-of-Robotics/base-cmake","description":"CMake find scripts and macros used in Rock's packages","fork":true,"url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake","forks_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/forks","keys_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/teams","hooks_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/hooks","issue_events_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/issues/events{/number}","events_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/events","assignees_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/assignees{/user}","branches_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/branches{/branch}","tags_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/tags","blobs_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/statuses/{sha}","languages_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/languages","stargazers_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/stargazers","contributors_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/contributors","subscribers_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/subscribers","subscription_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/subscription","commits_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/contents/{+path}","compare_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/merges","archive_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/downloads","issues_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/issues{/number}","pulls_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/pulls{/number}","milestones_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/milestones{/number}","notifications_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/labels{/name}","releases_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/releases{/id}","deployments_url":"https://api.github.com/repos/Brazilian-Institute-of-Robotics/base-cmake/deployments","created_at":"2016-09-02T12:14:34Z","updated_at":"2016-09-02T12:14:36Z","pushed_at":"2016-09-13T19:12:37Z","git_url":"git://github.com/Brazilian-Institute-of-Robotics/base-cmake.git","ssh_url":"git@github.com:Brazilian-Institute-of-Robotics/base-cmake.git","clone_url":"https://github.com/Brazilian-Institute-of-Robotics/base-cmake.git","svn_url":"https://github.com/Brazilian-Institute-of-Robotics/base-cmake","homepage":null,"size":580,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rock-core:master","ref":"master","sha":"605f84d9deed4bcec1dbaa38761f589b253dced2","user":{"login":"rock-core","id":6654878,"avatar_url":"https://avatars.githubusercontent.com/u/6654878?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-core","html_url":"https://github.com/rock-core","followers_url":"https://api.github.com/users/rock-core/followers","following_url":"https://api.github.com/users/rock-core/following{/other_user}","gists_url":"https://api.github.com/users/rock-core/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-core/subscriptions","organizations_url":"https://api.github.com/users/rock-core/orgs","repos_url":"https://api.github.com/users/rock-core/repos","events_url":"https://api.github.com/users/rock-core/events{/privacy}","received_events_url":"https://api.github.com/users/rock-core/received_events","type":"Organization","site_admin":false},"repo":{"id":19136548,"name":"base-cmake","full_name":"rock-core/base-cmake","owner":{"login":"rock-core","id":6654878,"avatar_url":"https://avatars.githubusercontent.com/u/6654878?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-core","html_url":"https://github.com/rock-core","followers_url":"https://api.github.com/users/rock-core/followers","following_url":"https://api.github.com/users/rock-core/following{/other_user}","gists_url":"https://api.github.com/users/rock-core/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-core/subscriptions","organizations_url":"https://api.github.com/users/rock-core/orgs","repos_url":"https://api.github.com/users/rock-core/repos","events_url":"https://api.github.com/users/rock-core/events{/privacy}","received_events_url":"https://api.github.com/users/rock-core/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rock-core/base-cmake","description":"CMake find scripts and macros used in Rock's packages","fork":false,"url":"https://api.github.com/repos/rock-core/base-cmake","forks_url":"https://api.github.com/repos/rock-core/base-cmake/forks","keys_url":"https://api.github.com/repos/rock-core/base-cmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rock-core/base-cmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rock-core/base-cmake/teams","hooks_url":"https://api.github.com/repos/rock-core/base-cmake/hooks","issue_events_url":"https://api.github.com/repos/rock-core/base-cmake/issues/events{/number}","events_url":"https://api.github.com/repos/rock-core/base-cmake/events","assignees_url":"https://api.github.com/repos/rock-core/base-cmake/assignees{/user}","branches_url":"https://api.github.com/repos/rock-core/base-cmake/branches{/branch}","tags_url":"https://api.github.com/repos/rock-core/base-cmake/tags","blobs_url":"https://api.github.com/repos/rock-core/base-cmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rock-core/base-cmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rock-core/base-cmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/rock-core/base-cmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rock-core/base-cmake/statuses/{sha}","languages_url":"https://api.github.com/repos/rock-core/base-cmake/languages","stargazers_url":"https://api.github.com/repos/rock-core/base-cmake/stargazers","contributors_url":"https://api.github.com/repos/rock-core/base-cmake/contributors","subscribers_url":"https://api.github.com/repos/rock-core/base-cmake/subscribers","subscription_url":"https://api.github.com/repos/rock-core/base-cmake/subscription","commits_url":"https://api.github.com/repos/rock-core/base-cmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/rock-core/base-cmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/rock-core/base-cmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/rock-core/base-cmake/issues/comments{/number}","contents_url":"https://api.github.com/repos/rock-core/base-cmake/contents/{+path}","compare_url":"https://api.github.com/repos/rock-core/base-cmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rock-core/base-cmake/merges","archive_url":"https://api.github.com/repos/rock-core/base-cmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rock-core/base-cmake/downloads","issues_url":"https://api.github.com/repos/rock-core/base-cmake/issues{/number}","pulls_url":"https://api.github.com/repos/rock-core/base-cmake/pulls{/number}","milestones_url":"https://api.github.com/repos/rock-core/base-cmake/milestones{/number}","notifications_url":"https://api.github.com/repos/rock-core/base-cmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rock-core/base-cmake/labels{/name}","releases_url":"https://api.github.com/repos/rock-core/base-cmake/releases{/id}","deployments_url":"https://api.github.com/repos/rock-core/base-cmake/deployments","created_at":"2014-04-25T06:35:47Z","updated_at":"2016-05-25T16:42:22Z","pushed_at":"2016-09-13T19:12:37Z","git_url":"git://github.com/rock-core/base-cmake.git","ssh_url":"git@github.com:rock-core/base-cmake.git","clone_url":"https://github.com/rock-core/base-cmake.git","svn_url":"https://github.com/rock-core/base-cmake","homepage":null,"size":632,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rock-core/base-cmake/pulls/35"},"html":{"href":"https://github.com/rock-core/base-cmake/pull/35"},"issue":{"href":"https://api.github.com/repos/rock-core/base-cmake/issues/35"},"comments":{"href":"https://api.github.com/repos/rock-core/base-cmake/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/rock-core/base-cmake/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/rock-core/base-cmake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rock-core/base-cmake/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/rock-core/base-cmake/statuses/8eddbeef04d3c0f48c3d8a6072ed144160de2c63"}}}}
{"actor":{"display_login":"doudou"}}