{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/docker-node/issues/222","repository_url":"https://api.github.com/repos/nodejs/docker-node","labels_url":"https://api.github.com/repos/nodejs/docker-node/issues/222/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/docker-node/issues/222/comments","events_url":"https://api.github.com/repos/nodejs/docker-node/issues/222/events","html_url":"https://github.com/nodejs/docker-node/pull/222","id":173227298,"number":222,"title":"Proposal: Introduce Dockerfiles for windowsservercore","user":{"login":"StefanScherer","id":207759,"avatar_url":"https://avatars.githubusercontent.com/u/207759?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanScherer","html_url":"https://github.com/StefanScherer","followers_url":"https://api.github.com/users/StefanScherer/followers","following_url":"https://api.github.com/users/StefanScherer/following{/other_user}","gists_url":"https://api.github.com/users/StefanScherer/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanScherer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanScherer/subscriptions","organizations_url":"https://api.github.com/users/StefanScherer/orgs","repos_url":"https://api.github.com/users/StefanScherer/repos","events_url":"https://api.github.com/users/StefanScherer/events{/privacy}","received_events_url":"https://api.github.com/users/StefanScherer/received_events","type":"User","site_admin":false},"labels":[{"id":431017706,"url":"https://api.github.com/repos/nodejs/docker-node/labels/do%20not%20merge","name":"do not merge","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-08-25T14:59:46Z","updated_at":"2016-11-03T19:06:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/docker-node/pulls/222","html_url":"https://github.com/nodejs/docker-node/pull/222","diff_url":"https://github.com/nodejs/docker-node/pull/222.diff","patch_url":"https://github.com/nodejs/docker-node/pull/222.patch"},"body":"After `golang` now has its first Windows Docker image on [Docker Hub](https://hub.docker.com/_/golang/) it is time for `node` to provide an official Windows Docker image as well.\n\nThis PR is a proposal to build and push Windows Docker images for the `windowsservercore` variant which works on Windows 10 + Docker 4 Windows Beta 26++ or Windows Server 2016.\n\nThe `test-build.ps1` can be called to build the images. It downloads the ZIP files for Node.js 4.6.0 and 6.7.0 and builds these Docker images:\n- node:4.6.0-windowsservercore\n- node:4.6.0-windowsservercore-onbuild\n- node:6.7.0-windowsservercore\n- node:6.7.0-windowsservercore-onbuild\n\nIn my previous work building a Windows Docker image I used the MSI packages which can be found here https://github.com/StefanScherer/dockerfiles-windows/tree/master/node, but this results in a slightly bigger Docker image as Windows caches the MSI packages in a second place even after removing it in the Dockerfile. So I switched to the ZIP files.\n\nThe labels for the Docker images are based on the work for the `golang` Docker images.\n\nSee also:\n- https://github.com/docker-library/golang/pull/106\n- https://hub.docker.com/_/golang/\n\nFor information about how to get Docker running on Windows, please see the relevant [Windows Server Quick Start](https://msdn.microsoft.com/en-us/virtualization/windowscontainers/quick_start/quick_start_windows_server) guide provided by Microsoft.\n\nSee also #223 for the nanoserver Dockerfile proposal.\n"},"comment":{"url":"https://api.github.com/repos/nodejs/docker-node/issues/comments/258243282","html_url":"https://github.com/nodejs/docker-node/pull/222#issuecomment-258243282","issue_url":"https://api.github.com/repos/nodejs/docker-node/issues/222","id":258243282,"user":{"login":"StefanScherer","id":207759,"avatar_url":"https://avatars.githubusercontent.com/u/207759?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanScherer","html_url":"https://github.com/StefanScherer","followers_url":"https://api.github.com/users/StefanScherer/followers","following_url":"https://api.github.com/users/StefanScherer/following{/other_user}","gists_url":"https://api.github.com/users/StefanScherer/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanScherer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanScherer/subscriptions","organizations_url":"https://api.github.com/users/StefanScherer/orgs","repos_url":"https://api.github.com/users/StefanScherer/repos","events_url":"https://api.github.com/users/StefanScherer/events{/privacy}","received_events_url":"https://api.github.com/users/StefanScherer/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T19:06:11Z","updated_at":"2016-11-03T19:06:11Z","body":"Something like `.travis.yml` + `test_build.sh` for Windows?\r\nThis should be possible on AppVeyor soon: `appveyor.yml` + `test_build.ps1`\r\n\r\nBut I think there is more CI to push to Docker Hub as well, right? Jenkins? So you would need eg. a Windows 2016 Jenkins slave for further steps.\r\n"}}
{"actor":{"display_login":"StefanScherer"}}