{"action":"created","comment":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/52111908","id":52111908,"diff_hunk":"@@ -1519,12 +1612,14 @@ int gnix_ep_open(struct fid_domain *domain, struct fi_info *info,\n \tep_priv->progress_fn = NULL;\n \tep_priv->rx_progress_fn = NULL;\n \n-\tret = gnix_nic_alloc(domain_priv, attr, &ep_priv->nic);\n-\tif (ret != FI_SUCCESS) {\n-\t\tGNIX_WARN(FI_LOG_EP_CTRL,\n-\t\t\t    \"_gnix_nic_alloc call returned %d\\n\",\n-\t\t\t     ret);\n-\t\tgoto err;\n+\tif (ep_priv->nic == NULL) {","path":"prov/gni/src/gnix_ep.c","position":202,"original_position":202,"commit_id":"1d6eef0472ec4cf65e832f6fa0d154504c07a77f","original_commit_id":"1d6eef0472ec4cf65e832f6fa0d154504c07a77f","user":{"login":"ztiffany","id":10633253,"avatar_url":"https://avatars.githubusercontent.com/u/10633253?v=3","gravatar_id":"","url":"https://api.github.com/users/ztiffany","html_url":"https://github.com/ztiffany","followers_url":"https://api.github.com/users/ztiffany/followers","following_url":"https://api.github.com/users/ztiffany/following{/other_user}","gists_url":"https://api.github.com/users/ztiffany/gists{/gist_id}","starred_url":"https://api.github.com/users/ztiffany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztiffany/subscriptions","organizations_url":"https://api.github.com/users/ztiffany/orgs","repos_url":"https://api.github.com/users/ztiffany/repos","events_url":"https://api.github.com/users/ztiffany/events{/privacy}","received_events_url":"https://api.github.com/users/ztiffany/received_events","type":"User","site_admin":false},"body":"I think I get it, only the first EP on the domain creates a CM NIC and uses that same GNI NIC for itself (which is where resources are saved).  We still need to create a new NIC for additional EPs on the NIC, though?","created_at":"2016-02-07T03:17:57Z","updated_at":"2016-02-07T03:17:57Z","html_url":"https://github.com/ofi-cray/libfabric-cray/pull/660#discussion_r52111908","pull_request_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/660","_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/52111908"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/660#discussion_r52111908"},"pull_request":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/660"}}},"pull_request":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/660","id":58470130,"html_url":"https://github.com/ofi-cray/libfabric-cray/pull/660","diff_url":"https://github.com/ofi-cray/libfabric-cray/pull/660.diff","patch_url":"https://github.com/ofi-cray/libfabric-cray/pull/660.patch","issue_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/660","number":660,"state":"open","locked":false,"title":"prov/gni: refactor cm nic code","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"body":"Refactor the cm nic code as part of a campaign\r\nto reduce use of Aries NIC resources per process.\r\nThis refactor now has the cm_nic embed a gnix_nic\r\nstruct.  The gnix_nic can then be reused for\r\nRDMA network requests.  This also cuts down on\r\nthe number of HW CQs required per process.\r\n\r\n@sungeunchoi \r\n@ztiffany \r\n\r\nSigned-off-by: Howard Pritchard <howardp@lanl.gov>","created_at":"2016-02-05T19:03:55Z","updated_at":"2016-02-07T03:17:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82ea0e36da864d5fe905666b7cbcdbded41b64b0","assignee":null,"milestone":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/milestones/8","html_url":"https://github.com/ofi-cray/libfabric-cray/milestones/libfabric%201.3%20release","labels_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/milestones/8/labels","id":1470068,"number":8,"title":"libfabric 1.3 release","description":"","creator":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":7,"state":"open","created_at":"2015-12-21T18:51:50Z","updated_at":"2016-02-05T19:03:55Z","due_on":"2016-03-31T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/660/commits","review_comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/660/comments","review_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/660/comments","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/1d6eef0472ec4cf65e832f6fa0d154504c07a77f","head":{"label":"hppritcha:topic/cm_nic_refactor","ref":"topic/cm_nic_refactor","sha":"1d6eef0472ec4cf65e832f6fa0d154504c07a77f","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"repo":{"id":29201359,"name":"libfabric","full_name":"hppritcha/libfabric","owner":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hppritcha/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/hppritcha/libfabric","forks_url":"https://api.github.com/repos/hppritcha/libfabric/forks","keys_url":"https://api.github.com/repos/hppritcha/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hppritcha/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hppritcha/libfabric/teams","hooks_url":"https://api.github.com/repos/hppritcha/libfabric/hooks","issue_events_url":"https://api.github.com/repos/hppritcha/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/hppritcha/libfabric/events","assignees_url":"https://api.github.com/repos/hppritcha/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/hppritcha/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/hppritcha/libfabric/tags","blobs_url":"https://api.github.com/repos/hppritcha/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hppritcha/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hppritcha/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/hppritcha/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hppritcha/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/hppritcha/libfabric/languages","stargazers_url":"https://api.github.com/repos/hppritcha/libfabric/stargazers","contributors_url":"https://api.github.com/repos/hppritcha/libfabric/contributors","subscribers_url":"https://api.github.com/repos/hppritcha/libfabric/subscribers","subscription_url":"https://api.github.com/repos/hppritcha/libfabric/subscription","commits_url":"https://api.github.com/repos/hppritcha/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/hppritcha/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/hppritcha/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/hppritcha/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/hppritcha/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/hppritcha/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hppritcha/libfabric/merges","archive_url":"https://api.github.com/repos/hppritcha/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hppritcha/libfabric/downloads","issues_url":"https://api.github.com/repos/hppritcha/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/hppritcha/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/hppritcha/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/hppritcha/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hppritcha/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/hppritcha/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/hppritcha/libfabric/deployments","created_at":"2015-01-13T17:14:54Z","updated_at":"2015-04-30T20:43:53Z","pushed_at":"2016-02-05T21:09:18Z","git_url":"git://github.com/hppritcha/libfabric.git","ssh_url":"git@github.com:hppritcha/libfabric.git","clone_url":"https://github.com/hppritcha/libfabric.git","svn_url":"https://github.com/hppritcha/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":10862,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofi-cray:master","ref":"master","sha":"2e446dbf0b66cf3a8bb4e852733bf0818fa2aed1","user":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"repo":{"id":29607348,"name":"libfabric-cray","full_name":"ofi-cray/libfabric-cray","owner":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofi-cray/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/ofi-cray/libfabric-cray","forks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/forks","keys_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/events","assignees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/merges","archive_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/releases{/id}","deployments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/deployments","created_at":"2015-01-21T19:30:52Z","updated_at":"2016-01-13T18:57:54Z","pushed_at":"2016-02-05T21:37:13Z","git_url":"git://github.com/ofi-cray/libfabric-cray.git","ssh_url":"git@github.com:ofi-cray/libfabric-cray.git","clone_url":"https://github.com/ofi-cray/libfabric-cray.git","svn_url":"https://github.com/ofi-cray/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":14162,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":48,"forks":6,"open_issues":48,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/660"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/660"},"issue":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/660"},"comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/660/comments"},"review_comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/660/comments"},"review_comment":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/660/commits"},"statuses":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/1d6eef0472ec4cf65e832f6fa0d154504c07a77f"}}}}