{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26996","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26996/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26996/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26996/events","html_url":"https://github.com/kubernetes/kubernetes/issues/26996","id":159019204,"number":26996,"title":"isLikelyNotMountPoint() function needs refactored ","user":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars.githubusercontent.com/u/19172805?v=3","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/storage","name":"area/storage","color":"006b75"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P2","name":"priority/P2","color":"fbca04"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/cluster","name":"team/cluster","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars.githubusercontent.com/u/19172805?v=3","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"assignees":[{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars.githubusercontent.com/u/19172805?v=3","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/17","html_url":"https://github.com/kubernetes/kubernetes/milestones/next-candidate","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/17/labels","id":1510379,"number":17,"title":"next-candidate","description":"Candidates for the next milestone","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":306,"closed_issues":102,"state":"open","created_at":"2016-01-16T17:58:20Z","updated_at":"2016-07-13T16:29:09Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-06-07T20:40:14Z","updated_at":"2016-07-13T17:03:48Z","closed_at":null,"body":"CC @kubernetes/sig-storage \r\n\r\nCurrently, isLikelyNotMountPoint() is implemented in mount_linux.go and nsenter_mount.go. They use different approach to determine whether a path is mounted or not.\r\n1. mount_linux.go checks if the directory has a different device as parent, then it is a mountpoint.\r\n2. nsenter_mount.go uses findmnt command result to check the mountpoint. This approach has issue: if the path is relatively long, findmnt execute output will truncate the last letter of the path. \r\n\r\nOpen an issue here to investigate whether we need to different approaches for this function. Another related issue is that isLikelyNotMountPoint() is called by many places and served as two purposes, one is checking whether directory exists or not, the other is to check the mount point. Suggest to separate these two functions. "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/232420267","html_url":"https://github.com/kubernetes/kubernetes/issues/26996#issuecomment-232420267","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26996","id":232420267,"user":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars.githubusercontent.com/u/19172805?v=3","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T17:03:48Z","updated_at":"2016-07-13T17:03:48Z","body":"No, it is not resolved yet. We want to keep it open and I should have time\nto address this early next week. Thanks!\n\nOn Wed, Jul 13, 2016 at 8:17 AM, bradley childs <notifications@github.com>\nwrote:\n\n> @jingxu97 <https://github.com/jingxu97> did #27054\n> <https://github.com/kubernetes/kubernetes/pull/27054> resolve this issue?\n> Is this remaining open for future refactoring?\n>\n> If so i'd like to adjust the priority\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kubernetes/kubernetes/issues/26996#issuecomment-232388028>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/ASSNxYUM0Aw9wwwZIeMEmughYYLbhDmhks5qVQF2gaJpZM4IwVlt>\n> .\n>\n\n\n\n-- \n- Jing\n"}}
{"actor":{"display_login":"jingxu97"}}