{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/comments/91511036","pull_request_review_id":12018822,"id":91511036,"diff_hunk":"@@ -191,16 +191,7 @@ public function testDependencyInjectionConfigurationDefaults()\n         $this->assertEquals('Doctrine\\Common\\Persistence\\Mapping\\Driver\\MappingDriverChain', $container->getParameter('doctrine.orm.metadata.driver_chain.class'));\n         $this->assertEquals('Doctrine\\ORM\\Mapping\\Driver\\AnnotationDriver', $container->getParameter('doctrine.orm.metadata.annotation.class'));\n         $this->assertEquals('Doctrine\\ORM\\Mapping\\Driver\\SimplifiedXmlDriver', $container->getParameter('doctrine.orm.metadata.xml.class'));\n-        $this->assertEquals('Doctrine\\ORM\\Mapping\\Driver\\SimplifiedYamlDriver', $container->getParameter('doctrine.orm.metadata.yml.class'));\n-\n-        // second-level cache\n-        $this->assertEquals('Doctrine\\ORM\\Cache\\DefaultCacheFactory', $container->getParameter('doctrine.orm.second_level_cache.default_cache_factory.class'));\n-        $this->assertEquals('Doctrine\\ORM\\Cache\\Region\\DefaultRegion', $container->getParameter('doctrine.orm.second_level_cache.default_region.class'));\n-        $this->assertEquals('Doctrine\\ORM\\Cache\\Region\\FileLockRegion', $container->getParameter('doctrine.orm.second_level_cache.filelock_region.class'));\n-        $this->assertEquals('Doctrine\\ORM\\Cache\\Logging\\CacheLoggerChain', $container->getParameter('doctrine.orm.second_level_cache.logger_chain.class'));\n-        $this->assertEquals('Doctrine\\ORM\\Cache\\Logging\\StatisticsCacheLogger', $container->getParameter('doctrine.orm.second_level_cache.logger_statistics.class'));\n-        $this->assertEquals('Doctrine\\ORM\\Cache\\CacheConfiguration', $container->getParameter('doctrine.orm.second_level_cache.cache_configuration.class'));","path":"Tests/DependencyInjection/DoctrineExtensionTest.php","position":12,"original_position":12,"commit_id":"ba8666c3fc0d51cab2df352c03b1f6f7f9ae9fa0","original_commit_id":"ba8666c3fc0d51cab2df352c03b1f6f7f9ae9fa0","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"Removing these assertions is bad. If your code is BC, they should still be passing","created_at":"2016-12-08T13:17:29Z","updated_at":"2016-12-08T13:17:33Z","html_url":"https://github.com/doctrine/DoctrineBundle/pull/596#discussion_r91511036","pull_request_url":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/596","_links":{"self":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/comments/91511036"},"html":{"href":"https://github.com/doctrine/DoctrineBundle/pull/596#discussion_r91511036"},"pull_request":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/596"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/596","id":97117124,"html_url":"https://github.com/doctrine/DoctrineBundle/pull/596","diff_url":"https://github.com/doctrine/DoctrineBundle/pull/596.diff","patch_url":"https://github.com/doctrine/DoctrineBundle/pull/596.patch","issue_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/596","number":596,"state":"open","locked":false,"title":"Enabling second level cache config in doctrine.orm section","user":{"login":"alertiu5","id":2384494,"avatar_url":"https://avatars.githubusercontent.com/u/2384494?v=3","gravatar_id":"","url":"https://api.github.com/users/alertiu5","html_url":"https://github.com/alertiu5","followers_url":"https://api.github.com/users/alertiu5/followers","following_url":"https://api.github.com/users/alertiu5/following{/other_user}","gists_url":"https://api.github.com/users/alertiu5/gists{/gist_id}","starred_url":"https://api.github.com/users/alertiu5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertiu5/subscriptions","organizations_url":"https://api.github.com/users/alertiu5/orgs","repos_url":"https://api.github.com/users/alertiu5/repos","events_url":"https://api.github.com/users/alertiu5/events{/privacy}","received_events_url":"https://api.github.com/users/alertiu5/received_events","type":"User","site_admin":false},"body":"Originally created so we could use our own implementation of CacheFactory via config option. Expanded for all parameters in doctrine.orm.second_level_cache.default_cache_factory to be setup-able.","created_at":"2016-12-08T12:56:44Z","updated_at":"2016-12-08T13:17:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3f592fc69ed73a81b51e25fc7b4695296f8c0ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/596/commits","review_comments_url":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/596/comments","review_comment_url":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/596/comments","statuses_url":"https://api.github.com/repos/doctrine/DoctrineBundle/statuses/ba8666c3fc0d51cab2df352c03b1f6f7f9ae9fa0","head":{"label":"alertiu5:second-level-cache-config","ref":"second-level-cache-config","sha":"ba8666c3fc0d51cab2df352c03b1f6f7f9ae9fa0","user":{"login":"alertiu5","id":2384494,"avatar_url":"https://avatars.githubusercontent.com/u/2384494?v=3","gravatar_id":"","url":"https://api.github.com/users/alertiu5","html_url":"https://github.com/alertiu5","followers_url":"https://api.github.com/users/alertiu5/followers","following_url":"https://api.github.com/users/alertiu5/following{/other_user}","gists_url":"https://api.github.com/users/alertiu5/gists{/gist_id}","starred_url":"https://api.github.com/users/alertiu5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertiu5/subscriptions","organizations_url":"https://api.github.com/users/alertiu5/orgs","repos_url":"https://api.github.com/users/alertiu5/repos","events_url":"https://api.github.com/users/alertiu5/events{/privacy}","received_events_url":"https://api.github.com/users/alertiu5/received_events","type":"User","site_admin":false},"repo":{"id":75644693,"name":"DoctrineBundle","full_name":"alertiu5/DoctrineBundle","owner":{"login":"alertiu5","id":2384494,"avatar_url":"https://avatars.githubusercontent.com/u/2384494?v=3","gravatar_id":"","url":"https://api.github.com/users/alertiu5","html_url":"https://github.com/alertiu5","followers_url":"https://api.github.com/users/alertiu5/followers","following_url":"https://api.github.com/users/alertiu5/following{/other_user}","gists_url":"https://api.github.com/users/alertiu5/gists{/gist_id}","starred_url":"https://api.github.com/users/alertiu5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertiu5/subscriptions","organizations_url":"https://api.github.com/users/alertiu5/orgs","repos_url":"https://api.github.com/users/alertiu5/repos","events_url":"https://api.github.com/users/alertiu5/events{/privacy}","received_events_url":"https://api.github.com/users/alertiu5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alertiu5/DoctrineBundle","description":"Symfony Bundle for Doctrine ORM and DBAL","fork":true,"url":"https://api.github.com/repos/alertiu5/DoctrineBundle","forks_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/forks","keys_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/teams","hooks_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/hooks","issue_events_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/issues/events{/number}","events_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/events","assignees_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/assignees{/user}","branches_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/branches{/branch}","tags_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/tags","blobs_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/languages","stargazers_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/stargazers","contributors_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/contributors","subscribers_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/subscribers","subscription_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/subscription","commits_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/contents/{+path}","compare_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/merges","archive_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/downloads","issues_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/issues{/number}","pulls_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/labels{/name}","releases_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/releases{/id}","deployments_url":"https://api.github.com/repos/alertiu5/DoctrineBundle/deployments","created_at":"2016-12-05T16:29:54Z","updated_at":"2016-12-05T16:29:56Z","pushed_at":"2016-12-08T13:13:07Z","git_url":"git://github.com/alertiu5/DoctrineBundle.git","ssh_url":"git@github.com:alertiu5/DoctrineBundle.git","clone_url":"https://github.com/alertiu5/DoctrineBundle.git","svn_url":"https://github.com/alertiu5/DoctrineBundle","homepage":"http://www.doctrine-project.org/projects/orm.html","size":1325,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"ea0cf9fb5bf69c2d92e4d279bbab894eec3a2d2c","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":2797951,"name":"DoctrineBundle","full_name":"doctrine/DoctrineBundle","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/DoctrineBundle","description":"Symfony Bundle for Doctrine ORM and DBAL","fork":false,"url":"https://api.github.com/repos/doctrine/DoctrineBundle","forks_url":"https://api.github.com/repos/doctrine/DoctrineBundle/forks","keys_url":"https://api.github.com/repos/doctrine/DoctrineBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/DoctrineBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/DoctrineBundle/teams","hooks_url":"https://api.github.com/repos/doctrine/DoctrineBundle/hooks","issue_events_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/DoctrineBundle/events","assignees_url":"https://api.github.com/repos/doctrine/DoctrineBundle/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/DoctrineBundle/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/DoctrineBundle/tags","blobs_url":"https://api.github.com/repos/doctrine/DoctrineBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/DoctrineBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/DoctrineBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/DoctrineBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/DoctrineBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/DoctrineBundle/languages","stargazers_url":"https://api.github.com/repos/doctrine/DoctrineBundle/stargazers","contributors_url":"https://api.github.com/repos/doctrine/DoctrineBundle/contributors","subscribers_url":"https://api.github.com/repos/doctrine/DoctrineBundle/subscribers","subscription_url":"https://api.github.com/repos/doctrine/DoctrineBundle/subscription","commits_url":"https://api.github.com/repos/doctrine/DoctrineBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/DoctrineBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/DoctrineBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/DoctrineBundle/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/DoctrineBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/DoctrineBundle/merges","archive_url":"https://api.github.com/repos/doctrine/DoctrineBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/DoctrineBundle/downloads","issues_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/DoctrineBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/DoctrineBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/DoctrineBundle/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/DoctrineBundle/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/DoctrineBundle/deployments","created_at":"2011-11-17T19:25:50Z","updated_at":"2016-11-29T04:24:53Z","pushed_at":"2016-12-08T13:13:08Z","git_url":"git://github.com/doctrine/DoctrineBundle.git","ssh_url":"git@github.com:doctrine/DoctrineBundle.git","clone_url":"https://github.com/doctrine/DoctrineBundle.git","svn_url":"https://github.com/doctrine/DoctrineBundle","homepage":"http://www.doctrine-project.org/projects/orm.html","size":1993,"stargazers_count":213,"watchers_count":213,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":75,"forks":225,"open_issues":75,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/596"},"html":{"href":"https://github.com/doctrine/DoctrineBundle/pull/596"},"issue":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/596"},"comments":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/DoctrineBundle/statuses/ba8666c3fc0d51cab2df352c03b1f6f7f9ae9fa0"}}}}
{"actor":{"display_login":"stof"}}