{"action":"created","comment":{"url":"https://api.github.com/repos/thelounge/docker-lounge/pulls/comments/62303336","id":62303336,"diff_hunk":"@@ -13,15 +11,16 @@ ENV HOME /home/lounge\n ENV LOUNGE_HOME ${HOME}/data\n ENV LOUNGE_SRC ${HOME}/src\n \n-RUN mkdir -p ${LOUNGE_SRC}\n-WORKDIR ${LOUNGE_SRC}\n-\n-RUN curl -L https://github.com/thelounge/lounge/archive/v${LOUNGE_VERSION}.tar.gz | tar --strip-components 1 -xzf -\n-\n-RUN chown -R lounge:lounge ${LOUNGE_SRC}\n+# Create a non-root user for lounge to run in.\n+RUN useradd --create-home --uid 1000 lounge\n \n # Drop root.\n USER lounge\n+\n+RUN mkdir -p ${LOUNGE_SRC}\n+WORKDIR ${LOUNGE_SRC}\n+\n+RUN curl -L $(npm view thelounge@${LOUNGE_VERSION} dist.tarball) | tar --strip-components 1 -xzf -","path":"Dockerfile","position":30,"original_position":30,"commit_id":"9c38eb94cc185430bcc07628f619996cc5a08b7e","original_commit_id":"9c38eb94cc185430bcc07628f619996cc5a08b7e","user":{"login":"xPaw","id":613331,"avatar_url":"https://avatars.githubusercontent.com/u/613331?v=3","gravatar_id":"","url":"https://api.github.com/users/xPaw","html_url":"https://github.com/xPaw","followers_url":"https://api.github.com/users/xPaw/followers","following_url":"https://api.github.com/users/xPaw/following{/other_user}","gists_url":"https://api.github.com/users/xPaw/gists{/gist_id}","starred_url":"https://api.github.com/users/xPaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xPaw/subscriptions","organizations_url":"https://api.github.com/users/xPaw/orgs","repos_url":"https://api.github.com/users/xPaw/repos","events_url":"https://api.github.com/users/xPaw/events{/privacy}","received_events_url":"https://api.github.com/users/xPaw/received_events","type":"User","site_admin":false},"body":"Can't you use `npm install thelounge` here? This would also get rid of `LOUNGE_VERSION`, thus require less maintenance.\r\n\r\nAnd instead of using `NODE_ENV`, you could pass in `--only=prod`.","created_at":"2016-05-06T08:47:34Z","updated_at":"2016-05-06T08:47:34Z","html_url":"https://github.com/thelounge/docker-lounge/pull/7#discussion_r62303336","pull_request_url":"https://api.github.com/repos/thelounge/docker-lounge/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/thelounge/docker-lounge/pulls/comments/62303336"},"html":{"href":"https://github.com/thelounge/docker-lounge/pull/7#discussion_r62303336"},"pull_request":{"href":"https://api.github.com/repos/thelounge/docker-lounge/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/thelounge/docker-lounge/pulls/7","id":68467194,"html_url":"https://github.com/thelounge/docker-lounge/pull/7","diff_url":"https://github.com/thelounge/docker-lounge/pull/7.diff","patch_url":"https://github.com/thelounge/docker-lounge/pull/7.patch","issue_url":"https://api.github.com/repos/thelounge/docker-lounge/issues/7","number":7,"state":"open","locked":false,"title":"Improve Dockerfile","user":{"login":"williamboman","id":6705160,"avatar_url":"https://avatars.githubusercontent.com/u/6705160?v=3","gravatar_id":"","url":"https://api.github.com/users/williamboman","html_url":"https://github.com/williamboman","followers_url":"https://api.github.com/users/williamboman/followers","following_url":"https://api.github.com/users/williamboman/following{/other_user}","gists_url":"https://api.github.com/users/williamboman/gists{/gist_id}","starred_url":"https://api.github.com/users/williamboman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamboman/subscriptions","organizations_url":"https://api.github.com/users/williamboman/orgs","repos_url":"https://api.github.com/users/williamboman/repos","events_url":"https://api.github.com/users/williamboman/events{/privacy}","received_events_url":"https://api.github.com/users/williamboman/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-30T12:49:11Z","updated_at":"2016-05-06T08:47:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fdc2cf4a4b94c887d869c5425da35eb2eb975cb","assignee":{"login":"astorije","id":113730,"avatar_url":"https://avatars.githubusercontent.com/u/113730?v=3","gravatar_id":"","url":"https://api.github.com/users/astorije","html_url":"https://github.com/astorije","followers_url":"https://api.github.com/users/astorije/followers","following_url":"https://api.github.com/users/astorije/following{/other_user}","gists_url":"https://api.github.com/users/astorije/gists{/gist_id}","starred_url":"https://api.github.com/users/astorije/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astorije/subscriptions","organizations_url":"https://api.github.com/users/astorije/orgs","repos_url":"https://api.github.com/users/astorije/repos","events_url":"https://api.github.com/users/astorije/events{/privacy}","received_events_url":"https://api.github.com/users/astorije/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/thelounge/docker-lounge/pulls/7/commits","review_comments_url":"https://api.github.com/repos/thelounge/docker-lounge/pulls/7/comments","review_comment_url":"https://api.github.com/repos/thelounge/docker-lounge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thelounge/docker-lounge/issues/7/comments","statuses_url":"https://api.github.com/repos/thelounge/docker-lounge/statuses/9c38eb94cc185430bcc07628f619996cc5a08b7e","head":{"label":"williamboman:chore/cleanup-files","ref":"chore/cleanup-files","sha":"9c38eb94cc185430bcc07628f619996cc5a08b7e","user":{"login":"williamboman","id":6705160,"avatar_url":"https://avatars.githubusercontent.com/u/6705160?v=3","gravatar_id":"","url":"https://api.github.com/users/williamboman","html_url":"https://github.com/williamboman","followers_url":"https://api.github.com/users/williamboman/followers","following_url":"https://api.github.com/users/williamboman/following{/other_user}","gists_url":"https://api.github.com/users/williamboman/gists{/gist_id}","starred_url":"https://api.github.com/users/williamboman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamboman/subscriptions","organizations_url":"https://api.github.com/users/williamboman/orgs","repos_url":"https://api.github.com/users/williamboman/repos","events_url":"https://api.github.com/users/williamboman/events{/privacy}","received_events_url":"https://api.github.com/users/williamboman/received_events","type":"User","site_admin":false},"repo":{"id":57441448,"name":"docker-lounge","full_name":"williamboman/docker-lounge","owner":{"login":"williamboman","id":6705160,"avatar_url":"https://avatars.githubusercontent.com/u/6705160?v=3","gravatar_id":"","url":"https://api.github.com/users/williamboman","html_url":"https://github.com/williamboman","followers_url":"https://api.github.com/users/williamboman/followers","following_url":"https://api.github.com/users/williamboman/following{/other_user}","gists_url":"https://api.github.com/users/williamboman/gists{/gist_id}","starred_url":"https://api.github.com/users/williamboman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamboman/subscriptions","organizations_url":"https://api.github.com/users/williamboman/orgs","repos_url":"https://api.github.com/users/williamboman/repos","events_url":"https://api.github.com/users/williamboman/events{/privacy}","received_events_url":"https://api.github.com/users/williamboman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/williamboman/docker-lounge","description":"Docker container for The Lounge, a self-hosted web IRC client","fork":true,"url":"https://api.github.com/repos/williamboman/docker-lounge","forks_url":"https://api.github.com/repos/williamboman/docker-lounge/forks","keys_url":"https://api.github.com/repos/williamboman/docker-lounge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/williamboman/docker-lounge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/williamboman/docker-lounge/teams","hooks_url":"https://api.github.com/repos/williamboman/docker-lounge/hooks","issue_events_url":"https://api.github.com/repos/williamboman/docker-lounge/issues/events{/number}","events_url":"https://api.github.com/repos/williamboman/docker-lounge/events","assignees_url":"https://api.github.com/repos/williamboman/docker-lounge/assignees{/user}","branches_url":"https://api.github.com/repos/williamboman/docker-lounge/branches{/branch}","tags_url":"https://api.github.com/repos/williamboman/docker-lounge/tags","blobs_url":"https://api.github.com/repos/williamboman/docker-lounge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/williamboman/docker-lounge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/williamboman/docker-lounge/git/refs{/sha}","trees_url":"https://api.github.com/repos/williamboman/docker-lounge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/williamboman/docker-lounge/statuses/{sha}","languages_url":"https://api.github.com/repos/williamboman/docker-lounge/languages","stargazers_url":"https://api.github.com/repos/williamboman/docker-lounge/stargazers","contributors_url":"https://api.github.com/repos/williamboman/docker-lounge/contributors","subscribers_url":"https://api.github.com/repos/williamboman/docker-lounge/subscribers","subscription_url":"https://api.github.com/repos/williamboman/docker-lounge/subscription","commits_url":"https://api.github.com/repos/williamboman/docker-lounge/commits{/sha}","git_commits_url":"https://api.github.com/repos/williamboman/docker-lounge/git/commits{/sha}","comments_url":"https://api.github.com/repos/williamboman/docker-lounge/comments{/number}","issue_comment_url":"https://api.github.com/repos/williamboman/docker-lounge/issues/comments{/number}","contents_url":"https://api.github.com/repos/williamboman/docker-lounge/contents/{+path}","compare_url":"https://api.github.com/repos/williamboman/docker-lounge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/williamboman/docker-lounge/merges","archive_url":"https://api.github.com/repos/williamboman/docker-lounge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/williamboman/docker-lounge/downloads","issues_url":"https://api.github.com/repos/williamboman/docker-lounge/issues{/number}","pulls_url":"https://api.github.com/repos/williamboman/docker-lounge/pulls{/number}","milestones_url":"https://api.github.com/repos/williamboman/docker-lounge/milestones{/number}","notifications_url":"https://api.github.com/repos/williamboman/docker-lounge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/williamboman/docker-lounge/labels{/name}","releases_url":"https://api.github.com/repos/williamboman/docker-lounge/releases{/id}","deployments_url":"https://api.github.com/repos/williamboman/docker-lounge/deployments","created_at":"2016-04-30T12:45:12Z","updated_at":"2016-04-29T01:31:10Z","pushed_at":"2016-05-04T12:22:11Z","git_url":"git://github.com/williamboman/docker-lounge.git","ssh_url":"git@github.com:williamboman/docker-lounge.git","clone_url":"https://github.com/williamboman/docker-lounge.git","svn_url":"https://github.com/williamboman/docker-lounge","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thelounge:master","ref":"master","sha":"193726c7afbadc9abef7c39b12e30c5b372ca06c","user":{"login":"thelounge","id":14336958,"avatar_url":"https://avatars.githubusercontent.com/u/14336958?v=3","gravatar_id":"","url":"https://api.github.com/users/thelounge","html_url":"https://github.com/thelounge","followers_url":"https://api.github.com/users/thelounge/followers","following_url":"https://api.github.com/users/thelounge/following{/other_user}","gists_url":"https://api.github.com/users/thelounge/gists{/gist_id}","starred_url":"https://api.github.com/users/thelounge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelounge/subscriptions","organizations_url":"https://api.github.com/users/thelounge/orgs","repos_url":"https://api.github.com/users/thelounge/repos","events_url":"https://api.github.com/users/thelounge/events{/privacy}","received_events_url":"https://api.github.com/users/thelounge/received_events","type":"Organization","site_admin":false},"repo":{"id":57344313,"name":"docker-lounge","full_name":"thelounge/docker-lounge","owner":{"login":"thelounge","id":14336958,"avatar_url":"https://avatars.githubusercontent.com/u/14336958?v=3","gravatar_id":"","url":"https://api.github.com/users/thelounge","html_url":"https://github.com/thelounge","followers_url":"https://api.github.com/users/thelounge/followers","following_url":"https://api.github.com/users/thelounge/following{/other_user}","gists_url":"https://api.github.com/users/thelounge/gists{/gist_id}","starred_url":"https://api.github.com/users/thelounge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelounge/subscriptions","organizations_url":"https://api.github.com/users/thelounge/orgs","repos_url":"https://api.github.com/users/thelounge/repos","events_url":"https://api.github.com/users/thelounge/events{/privacy}","received_events_url":"https://api.github.com/users/thelounge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thelounge/docker-lounge","description":"Docker container for The Lounge, a self-hosted web IRC client","fork":false,"url":"https://api.github.com/repos/thelounge/docker-lounge","forks_url":"https://api.github.com/repos/thelounge/docker-lounge/forks","keys_url":"https://api.github.com/repos/thelounge/docker-lounge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thelounge/docker-lounge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thelounge/docker-lounge/teams","hooks_url":"https://api.github.com/repos/thelounge/docker-lounge/hooks","issue_events_url":"https://api.github.com/repos/thelounge/docker-lounge/issues/events{/number}","events_url":"https://api.github.com/repos/thelounge/docker-lounge/events","assignees_url":"https://api.github.com/repos/thelounge/docker-lounge/assignees{/user}","branches_url":"https://api.github.com/repos/thelounge/docker-lounge/branches{/branch}","tags_url":"https://api.github.com/repos/thelounge/docker-lounge/tags","blobs_url":"https://api.github.com/repos/thelounge/docker-lounge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thelounge/docker-lounge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thelounge/docker-lounge/git/refs{/sha}","trees_url":"https://api.github.com/repos/thelounge/docker-lounge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thelounge/docker-lounge/statuses/{sha}","languages_url":"https://api.github.com/repos/thelounge/docker-lounge/languages","stargazers_url":"https://api.github.com/repos/thelounge/docker-lounge/stargazers","contributors_url":"https://api.github.com/repos/thelounge/docker-lounge/contributors","subscribers_url":"https://api.github.com/repos/thelounge/docker-lounge/subscribers","subscription_url":"https://api.github.com/repos/thelounge/docker-lounge/subscription","commits_url":"https://api.github.com/repos/thelounge/docker-lounge/commits{/sha}","git_commits_url":"https://api.github.com/repos/thelounge/docker-lounge/git/commits{/sha}","comments_url":"https://api.github.com/repos/thelounge/docker-lounge/comments{/number}","issue_comment_url":"https://api.github.com/repos/thelounge/docker-lounge/issues/comments{/number}","contents_url":"https://api.github.com/repos/thelounge/docker-lounge/contents/{+path}","compare_url":"https://api.github.com/repos/thelounge/docker-lounge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thelounge/docker-lounge/merges","archive_url":"https://api.github.com/repos/thelounge/docker-lounge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thelounge/docker-lounge/downloads","issues_url":"https://api.github.com/repos/thelounge/docker-lounge/issues{/number}","pulls_url":"https://api.github.com/repos/thelounge/docker-lounge/pulls{/number}","milestones_url":"https://api.github.com/repos/thelounge/docker-lounge/milestones{/number}","notifications_url":"https://api.github.com/repos/thelounge/docker-lounge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thelounge/docker-lounge/labels{/name}","releases_url":"https://api.github.com/repos/thelounge/docker-lounge/releases{/id}","deployments_url":"https://api.github.com/repos/thelounge/docker-lounge/deployments","created_at":"2016-04-29T01:06:47Z","updated_at":"2016-04-29T01:31:10Z","pushed_at":"2016-05-04T12:23:45Z","git_url":"git://github.com/thelounge/docker-lounge.git","ssh_url":"git@github.com:thelounge/docker-lounge.git","clone_url":"https://github.com/thelounge/docker-lounge.git","svn_url":"https://github.com/thelounge/docker-lounge","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thelounge/docker-lounge/pulls/7"},"html":{"href":"https://github.com/thelounge/docker-lounge/pull/7"},"issue":{"href":"https://api.github.com/repos/thelounge/docker-lounge/issues/7"},"comments":{"href":"https://api.github.com/repos/thelounge/docker-lounge/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/thelounge/docker-lounge/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/thelounge/docker-lounge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thelounge/docker-lounge/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/thelounge/docker-lounge/statuses/9c38eb94cc185430bcc07628f619996cc5a08b7e"}}}}