{"action":"created","comment":{"url":"https://api.github.com/repos/karies/root/pulls/comments/70426391","id":70426391,"diff_hunk":"@@ -168,4 +201,55 @@ namespace cling {\n       }\n       return false;\n     }\n+\n+    ///\\brief Make available to child all decls in parent's decl context\n+    /// that corresponds to child decl context.\n+    void ASTImportSource::completeVisibleDeclsMap(\n+                                  const clang::DeclContext *childDeclContext) {\n+      assert (childDeclContext && \"No child decl context!\");\n+\n+      if (!childDeclContext->hasExternalVisibleStorage())\n+        return;\n+\n+      // Search in the map of the stored Decl Contexts for this\n+      // Decl Context.\n+      std::map<const clang::DeclContext *, clang::DeclContext *>::iterator I;","path":"interpreter/cling/lib/Interpreter/ASTImportSource.cpp","position":null,"original_position":111,"commit_id":"ac8bca01b26d361338725e4986990e9b76a0b699","original_commit_id":"04d08a5e8c7b5c8123ef534b9ec30e266c2ddb39","user":{"login":"CristinaCristescu","id":4940839,"avatar_url":"https://avatars.githubusercontent.com/u/4940839?v=3","gravatar_id":"","url":"https://api.github.com/users/CristinaCristescu","html_url":"https://github.com/CristinaCristescu","followers_url":"https://api.github.com/users/CristinaCristescu/followers","following_url":"https://api.github.com/users/CristinaCristescu/following{/other_user}","gists_url":"https://api.github.com/users/CristinaCristescu/gists{/gist_id}","starred_url":"https://api.github.com/users/CristinaCristescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CristinaCristescu/subscriptions","organizations_url":"https://api.github.com/users/CristinaCristescu/orgs","repos_url":"https://api.github.com/users/CristinaCristescu/repos","events_url":"https://api.github.com/users/CristinaCristescu/events{/privacy}","received_events_url":"https://api.github.com/users/CristinaCristescu/received_events","type":"User","site_admin":false},"body":"Yes it's cleaner","created_at":"2016-07-12T12:17:23Z","updated_at":"2016-07-12T12:17:23Z","html_url":"https://github.com/karies/root/pull/179#discussion_r70426391","pull_request_url":"https://api.github.com/repos/karies/root/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/karies/root/pulls/comments/70426391"},"html":{"href":"https://github.com/karies/root/pull/179#discussion_r70426391"},"pull_request":{"href":"https://api.github.com/repos/karies/root/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/karies/root/pulls/179","id":76604891,"html_url":"https://github.com/karies/root/pull/179","diff_url":"https://github.com/karies/root/pull/179.diff","patch_url":"https://github.com/karies/root/pull/179.patch","issue_url":"https://api.github.com/repos/karies/root/issues/179","number":179,"state":"open","locked":false,"title":"Root + Cling tab comp","user":{"login":"CristinaCristescu","id":4940839,"avatar_url":"https://avatars.githubusercontent.com/u/4940839?v=3","gravatar_id":"","url":"https://api.github.com/users/CristinaCristescu","html_url":"https://github.com/CristinaCristescu","followers_url":"https://api.github.com/users/CristinaCristescu/followers","following_url":"https://api.github.com/users/CristinaCristescu/following{/other_user}","gists_url":"https://api.github.com/users/CristinaCristescu/gists{/gist_id}","starred_url":"https://api.github.com/users/CristinaCristescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CristinaCristescu/subscriptions","organizations_url":"https://api.github.com/users/CristinaCristescu/orgs","repos_url":"https://api.github.com/users/CristinaCristescu/repos","events_url":"https://api.github.com/users/CristinaCristescu/events{/privacy}","received_events_url":"https://api.github.com/users/CristinaCristescu/received_events","type":"User","site_admin":false},"body":"It works for ROOT but for cling I could not test the machinery. After it is merged I can take cling standalone and double check.","created_at":"2016-07-07T14:29:11Z","updated_at":"2016-07-12T12:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f19d1173ddae0c984c6853cf7e12238ebc319fa6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/karies/root/pulls/179/commits","review_comments_url":"https://api.github.com/repos/karies/root/pulls/179/comments","review_comment_url":"https://api.github.com/repos/karies/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/karies/root/issues/179/comments","statuses_url":"https://api.github.com/repos/karies/root/statuses/ac8bca01b26d361338725e4986990e9b76a0b699","head":{"label":"CristinaCristescu:root_tab_comp","ref":"root_tab_comp","sha":"ac8bca01b26d361338725e4986990e9b76a0b699","user":{"login":"CristinaCristescu","id":4940839,"avatar_url":"https://avatars.githubusercontent.com/u/4940839?v=3","gravatar_id":"","url":"https://api.github.com/users/CristinaCristescu","html_url":"https://github.com/CristinaCristescu","followers_url":"https://api.github.com/users/CristinaCristescu/followers","following_url":"https://api.github.com/users/CristinaCristescu/following{/other_user}","gists_url":"https://api.github.com/users/CristinaCristescu/gists{/gist_id}","starred_url":"https://api.github.com/users/CristinaCristescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CristinaCristescu/subscriptions","organizations_url":"https://api.github.com/users/CristinaCristescu/orgs","repos_url":"https://api.github.com/users/CristinaCristescu/repos","events_url":"https://api.github.com/users/CristinaCristescu/events{/privacy}","received_events_url":"https://api.github.com/users/CristinaCristescu/received_events","type":"User","site_admin":false},"repo":{"id":11178465,"name":"root","full_name":"CristinaCristescu/root","owner":{"login":"CristinaCristescu","id":4940839,"avatar_url":"https://avatars.githubusercontent.com/u/4940839?v=3","gravatar_id":"","url":"https://api.github.com/users/CristinaCristescu","html_url":"https://github.com/CristinaCristescu","followers_url":"https://api.github.com/users/CristinaCristescu/followers","following_url":"https://api.github.com/users/CristinaCristescu/following{/other_user}","gists_url":"https://api.github.com/users/CristinaCristescu/gists{/gist_id}","starred_url":"https://api.github.com/users/CristinaCristescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CristinaCristescu/subscriptions","organizations_url":"https://api.github.com/users/CristinaCristescu/orgs","repos_url":"https://api.github.com/users/CristinaCristescu/repos","events_url":"https://api.github.com/users/CristinaCristescu/events{/privacy}","received_events_url":"https://api.github.com/users/CristinaCristescu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CristinaCristescu/root","description":"Mirror of official ROOT git repository located at ","fork":true,"url":"https://api.github.com/repos/CristinaCristescu/root","forks_url":"https://api.github.com/repos/CristinaCristescu/root/forks","keys_url":"https://api.github.com/repos/CristinaCristescu/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CristinaCristescu/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CristinaCristescu/root/teams","hooks_url":"https://api.github.com/repos/CristinaCristescu/root/hooks","issue_events_url":"https://api.github.com/repos/CristinaCristescu/root/issues/events{/number}","events_url":"https://api.github.com/repos/CristinaCristescu/root/events","assignees_url":"https://api.github.com/repos/CristinaCristescu/root/assignees{/user}","branches_url":"https://api.github.com/repos/CristinaCristescu/root/branches{/branch}","tags_url":"https://api.github.com/repos/CristinaCristescu/root/tags","blobs_url":"https://api.github.com/repos/CristinaCristescu/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CristinaCristescu/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CristinaCristescu/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/CristinaCristescu/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CristinaCristescu/root/statuses/{sha}","languages_url":"https://api.github.com/repos/CristinaCristescu/root/languages","stargazers_url":"https://api.github.com/repos/CristinaCristescu/root/stargazers","contributors_url":"https://api.github.com/repos/CristinaCristescu/root/contributors","subscribers_url":"https://api.github.com/repos/CristinaCristescu/root/subscribers","subscription_url":"https://api.github.com/repos/CristinaCristescu/root/subscription","commits_url":"https://api.github.com/repos/CristinaCristescu/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/CristinaCristescu/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/CristinaCristescu/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/CristinaCristescu/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/CristinaCristescu/root/contents/{+path}","compare_url":"https://api.github.com/repos/CristinaCristescu/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CristinaCristescu/root/merges","archive_url":"https://api.github.com/repos/CristinaCristescu/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CristinaCristescu/root/downloads","issues_url":"https://api.github.com/repos/CristinaCristescu/root/issues{/number}","pulls_url":"https://api.github.com/repos/CristinaCristescu/root/pulls{/number}","milestones_url":"https://api.github.com/repos/CristinaCristescu/root/milestones{/number}","notifications_url":"https://api.github.com/repos/CristinaCristescu/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CristinaCristescu/root/labels{/name}","releases_url":"https://api.github.com/repos/CristinaCristescu/root/releases{/id}","deployments_url":"https://api.github.com/repos/CristinaCristescu/root/deployments","created_at":"2013-07-04T13:59:54Z","updated_at":"2014-06-26T09:36:02Z","pushed_at":"2016-07-07T14:36:50Z","git_url":"git://github.com/CristinaCristescu/root.git","ssh_url":"git@github.com:CristinaCristescu/root.git","clone_url":"https://github.com/CristinaCristescu/root.git","svn_url":"https://github.com/CristinaCristescu/root","homepage":"http://root.cern.ch","size":557888,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"karies:master","ref":"master","sha":"0df8f67a0c8e55f47017253227b4eceac2b241af","user":{"login":"karies","id":144675,"avatar_url":"https://avatars.githubusercontent.com/u/144675?v=3","gravatar_id":"","url":"https://api.github.com/users/karies","html_url":"https://github.com/karies","followers_url":"https://api.github.com/users/karies/followers","following_url":"https://api.github.com/users/karies/following{/other_user}","gists_url":"https://api.github.com/users/karies/gists{/gist_id}","starred_url":"https://api.github.com/users/karies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karies/subscriptions","organizations_url":"https://api.github.com/users/karies/orgs","repos_url":"https://api.github.com/users/karies/repos","events_url":"https://api.github.com/users/karies/events{/privacy}","received_events_url":"https://api.github.com/users/karies/received_events","type":"User","site_admin":false},"repo":{"id":11053789,"name":"root","full_name":"karies/root","owner":{"login":"karies","id":144675,"avatar_url":"https://avatars.githubusercontent.com/u/144675?v=3","gravatar_id":"","url":"https://api.github.com/users/karies","html_url":"https://github.com/karies","followers_url":"https://api.github.com/users/karies/followers","following_url":"https://api.github.com/users/karies/following{/other_user}","gists_url":"https://api.github.com/users/karies/gists{/gist_id}","starred_url":"https://api.github.com/users/karies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karies/subscriptions","organizations_url":"https://api.github.com/users/karies/orgs","repos_url":"https://api.github.com/users/karies/repos","events_url":"https://api.github.com/users/karies/events{/privacy}","received_events_url":"https://api.github.com/users/karies/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karies/root","description":"Mirror of official ROOT git repository located at ","fork":true,"url":"https://api.github.com/repos/karies/root","forks_url":"https://api.github.com/repos/karies/root/forks","keys_url":"https://api.github.com/repos/karies/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karies/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karies/root/teams","hooks_url":"https://api.github.com/repos/karies/root/hooks","issue_events_url":"https://api.github.com/repos/karies/root/issues/events{/number}","events_url":"https://api.github.com/repos/karies/root/events","assignees_url":"https://api.github.com/repos/karies/root/assignees{/user}","branches_url":"https://api.github.com/repos/karies/root/branches{/branch}","tags_url":"https://api.github.com/repos/karies/root/tags","blobs_url":"https://api.github.com/repos/karies/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karies/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karies/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/karies/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karies/root/statuses/{sha}","languages_url":"https://api.github.com/repos/karies/root/languages","stargazers_url":"https://api.github.com/repos/karies/root/stargazers","contributors_url":"https://api.github.com/repos/karies/root/contributors","subscribers_url":"https://api.github.com/repos/karies/root/subscribers","subscription_url":"https://api.github.com/repos/karies/root/subscription","commits_url":"https://api.github.com/repos/karies/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/karies/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/karies/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/karies/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/karies/root/contents/{+path}","compare_url":"https://api.github.com/repos/karies/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karies/root/merges","archive_url":"https://api.github.com/repos/karies/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karies/root/downloads","issues_url":"https://api.github.com/repos/karies/root/issues{/number}","pulls_url":"https://api.github.com/repos/karies/root/pulls{/number}","milestones_url":"https://api.github.com/repos/karies/root/milestones{/number}","notifications_url":"https://api.github.com/repos/karies/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karies/root/labels{/name}","releases_url":"https://api.github.com/repos/karies/root/releases{/id}","deployments_url":"https://api.github.com/repos/karies/root/deployments","created_at":"2013-06-29T14:35:42Z","updated_at":"2016-02-12T18:23:03Z","pushed_at":"2016-07-07T14:36:51Z","git_url":"git://github.com/karies/root.git","ssh_url":"git@github.com:karies/root.git","clone_url":"https://github.com/karies/root.git","svn_url":"https://github.com/karies/root","homepage":"http://root.cern.ch","size":568281,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":15,"forks":4,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karies/root/pulls/179"},"html":{"href":"https://github.com/karies/root/pull/179"},"issue":{"href":"https://api.github.com/repos/karies/root/issues/179"},"comments":{"href":"https://api.github.com/repos/karies/root/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/karies/root/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/karies/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/karies/root/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/karies/root/statuses/ac8bca01b26d361338725e4986990e9b76a0b699"}}}}
{"actor":{"display_login":"CristinaCristescu"}}