{"action":"created","comment":{"url":"https://api.github.com/repos/gajus/youtube-player/pulls/comments/51031665","id":51031665,"diff_hunk":"@@ -56,6 +56,7 @@ export default (elementId, options = {}) => {\n \n     playerAPI = YouTubePlayer.promisifyPlayer(playerAPIReady);\n     playerAPI.on = emitter.on;\n+    playerAPI.off = emitter.off;","path":"src/index.js","position":4,"original_position":4,"commit_id":"20b8c5968e42b7ef2319512ee37ac284ce1b12e7","original_commit_id":"20b8c5968e42b7ef2319512ee37ac284ce1b12e7","user":{"login":"gajus","id":973543,"avatar_url":"https://avatars.githubusercontent.com/u/973543?v=3","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"body":"Docs should simply declare that such method exists. I am referring to the README. https://github.com/gajus/youtube-player#events","created_at":"2016-01-27T19:00:32Z","updated_at":"2016-01-27T19:00:32Z","html_url":"https://github.com/gajus/youtube-player/pull/4#discussion_r51031665","pull_request_url":"https://api.github.com/repos/gajus/youtube-player/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/gajus/youtube-player/pulls/comments/51031665"},"html":{"href":"https://github.com/gajus/youtube-player/pull/4#discussion_r51031665"},"pull_request":{"href":"https://api.github.com/repos/gajus/youtube-player/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/gajus/youtube-player/pulls/4","id":57231307,"html_url":"https://github.com/gajus/youtube-player/pull/4","diff_url":"https://github.com/gajus/youtube-player/pull/4.diff","patch_url":"https://github.com/gajus/youtube-player/pull/4.patch","issue_url":"https://api.github.com/repos/gajus/youtube-player/issues/4","number":4,"state":"open","locked":false,"title":"Added 'off' method of Sister to player API","user":{"login":"besuikerd","id":1638661,"avatar_url":"https://avatars.githubusercontent.com/u/1638661?v=3","gravatar_id":"","url":"https://api.github.com/users/besuikerd","html_url":"https://github.com/besuikerd","followers_url":"https://api.github.com/users/besuikerd/followers","following_url":"https://api.github.com/users/besuikerd/following{/other_user}","gists_url":"https://api.github.com/users/besuikerd/gists{/gist_id}","starred_url":"https://api.github.com/users/besuikerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besuikerd/subscriptions","organizations_url":"https://api.github.com/users/besuikerd/orgs","repos_url":"https://api.github.com/users/besuikerd/repos","events_url":"https://api.github.com/users/besuikerd/events{/privacy}","received_events_url":"https://api.github.com/users/besuikerd/received_events","type":"User","site_admin":false},"body":"You are able to add event listeners to the event emitter, but there is no option to clean up event listeners after you are done listening. Simple fix to expose the 'off' method of Sister to the player api.","created_at":"2016-01-26T16:07:07Z","updated_at":"2016-01-27T19:00:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71a9cbbad1af4a01ffab014d60eb99f9c27821c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gajus/youtube-player/pulls/4/commits","review_comments_url":"https://api.github.com/repos/gajus/youtube-player/pulls/4/comments","review_comment_url":"https://api.github.com/repos/gajus/youtube-player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gajus/youtube-player/issues/4/comments","statuses_url":"https://api.github.com/repos/gajus/youtube-player/statuses/20b8c5968e42b7ef2319512ee37ac284ce1b12e7","head":{"label":"besuikerd:master","ref":"master","sha":"20b8c5968e42b7ef2319512ee37ac284ce1b12e7","user":{"login":"besuikerd","id":1638661,"avatar_url":"https://avatars.githubusercontent.com/u/1638661?v=3","gravatar_id":"","url":"https://api.github.com/users/besuikerd","html_url":"https://github.com/besuikerd","followers_url":"https://api.github.com/users/besuikerd/followers","following_url":"https://api.github.com/users/besuikerd/following{/other_user}","gists_url":"https://api.github.com/users/besuikerd/gists{/gist_id}","starred_url":"https://api.github.com/users/besuikerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besuikerd/subscriptions","organizations_url":"https://api.github.com/users/besuikerd/orgs","repos_url":"https://api.github.com/users/besuikerd/repos","events_url":"https://api.github.com/users/besuikerd/events{/privacy}","received_events_url":"https://api.github.com/users/besuikerd/received_events","type":"User","site_admin":false},"repo":{"id":50440222,"name":"youtube-player","full_name":"besuikerd/youtube-player","owner":{"login":"besuikerd","id":1638661,"avatar_url":"https://avatars.githubusercontent.com/u/1638661?v=3","gravatar_id":"","url":"https://api.github.com/users/besuikerd","html_url":"https://github.com/besuikerd","followers_url":"https://api.github.com/users/besuikerd/followers","following_url":"https://api.github.com/users/besuikerd/following{/other_user}","gists_url":"https://api.github.com/users/besuikerd/gists{/gist_id}","starred_url":"https://api.github.com/users/besuikerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besuikerd/subscriptions","organizations_url":"https://api.github.com/users/besuikerd/orgs","repos_url":"https://api.github.com/users/besuikerd/repos","events_url":"https://api.github.com/users/besuikerd/events{/privacy}","received_events_url":"https://api.github.com/users/besuikerd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/besuikerd/youtube-player","description":"YouTube iframe API abstraction.","fork":true,"url":"https://api.github.com/repos/besuikerd/youtube-player","forks_url":"https://api.github.com/repos/besuikerd/youtube-player/forks","keys_url":"https://api.github.com/repos/besuikerd/youtube-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/besuikerd/youtube-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/besuikerd/youtube-player/teams","hooks_url":"https://api.github.com/repos/besuikerd/youtube-player/hooks","issue_events_url":"https://api.github.com/repos/besuikerd/youtube-player/issues/events{/number}","events_url":"https://api.github.com/repos/besuikerd/youtube-player/events","assignees_url":"https://api.github.com/repos/besuikerd/youtube-player/assignees{/user}","branches_url":"https://api.github.com/repos/besuikerd/youtube-player/branches{/branch}","tags_url":"https://api.github.com/repos/besuikerd/youtube-player/tags","blobs_url":"https://api.github.com/repos/besuikerd/youtube-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/besuikerd/youtube-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/besuikerd/youtube-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/besuikerd/youtube-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/besuikerd/youtube-player/statuses/{sha}","languages_url":"https://api.github.com/repos/besuikerd/youtube-player/languages","stargazers_url":"https://api.github.com/repos/besuikerd/youtube-player/stargazers","contributors_url":"https://api.github.com/repos/besuikerd/youtube-player/contributors","subscribers_url":"https://api.github.com/repos/besuikerd/youtube-player/subscribers","subscription_url":"https://api.github.com/repos/besuikerd/youtube-player/subscription","commits_url":"https://api.github.com/repos/besuikerd/youtube-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/besuikerd/youtube-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/besuikerd/youtube-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/besuikerd/youtube-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/besuikerd/youtube-player/contents/{+path}","compare_url":"https://api.github.com/repos/besuikerd/youtube-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/besuikerd/youtube-player/merges","archive_url":"https://api.github.com/repos/besuikerd/youtube-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/besuikerd/youtube-player/downloads","issues_url":"https://api.github.com/repos/besuikerd/youtube-player/issues{/number}","pulls_url":"https://api.github.com/repos/besuikerd/youtube-player/pulls{/number}","milestones_url":"https://api.github.com/repos/besuikerd/youtube-player/milestones{/number}","notifications_url":"https://api.github.com/repos/besuikerd/youtube-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/besuikerd/youtube-player/labels{/name}","releases_url":"https://api.github.com/repos/besuikerd/youtube-player/releases{/id}","deployments_url":"https://api.github.com/repos/besuikerd/youtube-player/deployments","created_at":"2016-01-26T16:01:45Z","updated_at":"2016-01-26T16:01:46Z","pushed_at":"2016-01-26T16:05:13Z","git_url":"git://github.com/besuikerd/youtube-player.git","ssh_url":"git@github.com:besuikerd/youtube-player.git","clone_url":"https://github.com/besuikerd/youtube-player.git","svn_url":"https://github.com/besuikerd/youtube-player","homepage":null,"size":494,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gajus:master","ref":"master","sha":"79182343a70b7da62e20b91c0eacae75d47a6181","user":{"login":"gajus","id":973543,"avatar_url":"https://avatars.githubusercontent.com/u/973543?v=3","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"repo":{"id":31009998,"name":"youtube-player","full_name":"gajus/youtube-player","owner":{"login":"gajus","id":973543,"avatar_url":"https://avatars.githubusercontent.com/u/973543?v=3","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gajus/youtube-player","description":"YouTube iframe API abstraction.","fork":false,"url":"https://api.github.com/repos/gajus/youtube-player","forks_url":"https://api.github.com/repos/gajus/youtube-player/forks","keys_url":"https://api.github.com/repos/gajus/youtube-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gajus/youtube-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gajus/youtube-player/teams","hooks_url":"https://api.github.com/repos/gajus/youtube-player/hooks","issue_events_url":"https://api.github.com/repos/gajus/youtube-player/issues/events{/number}","events_url":"https://api.github.com/repos/gajus/youtube-player/events","assignees_url":"https://api.github.com/repos/gajus/youtube-player/assignees{/user}","branches_url":"https://api.github.com/repos/gajus/youtube-player/branches{/branch}","tags_url":"https://api.github.com/repos/gajus/youtube-player/tags","blobs_url":"https://api.github.com/repos/gajus/youtube-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gajus/youtube-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gajus/youtube-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/gajus/youtube-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gajus/youtube-player/statuses/{sha}","languages_url":"https://api.github.com/repos/gajus/youtube-player/languages","stargazers_url":"https://api.github.com/repos/gajus/youtube-player/stargazers","contributors_url":"https://api.github.com/repos/gajus/youtube-player/contributors","subscribers_url":"https://api.github.com/repos/gajus/youtube-player/subscribers","subscription_url":"https://api.github.com/repos/gajus/youtube-player/subscription","commits_url":"https://api.github.com/repos/gajus/youtube-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/gajus/youtube-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/gajus/youtube-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/gajus/youtube-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/gajus/youtube-player/contents/{+path}","compare_url":"https://api.github.com/repos/gajus/youtube-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gajus/youtube-player/merges","archive_url":"https://api.github.com/repos/gajus/youtube-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gajus/youtube-player/downloads","issues_url":"https://api.github.com/repos/gajus/youtube-player/issues{/number}","pulls_url":"https://api.github.com/repos/gajus/youtube-player/pulls{/number}","milestones_url":"https://api.github.com/repos/gajus/youtube-player/milestones{/number}","notifications_url":"https://api.github.com/repos/gajus/youtube-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gajus/youtube-player/labels{/name}","releases_url":"https://api.github.com/repos/gajus/youtube-player/releases{/id}","deployments_url":"https://api.github.com/repos/gajus/youtube-player/deployments","created_at":"2015-02-19T10:13:13Z","updated_at":"2016-01-13T21:54:30Z","pushed_at":"2016-01-26T16:07:07Z","git_url":"git://github.com/gajus/youtube-player.git","ssh_url":"git@github.com:gajus/youtube-player.git","clone_url":"https://github.com/gajus/youtube-player.git","svn_url":"https://github.com/gajus/youtube-player","homepage":null,"size":497,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gajus/youtube-player/pulls/4"},"html":{"href":"https://github.com/gajus/youtube-player/pull/4"},"issue":{"href":"https://api.github.com/repos/gajus/youtube-player/issues/4"},"comments":{"href":"https://api.github.com/repos/gajus/youtube-player/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/gajus/youtube-player/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/gajus/youtube-player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gajus/youtube-player/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/gajus/youtube-player/statuses/20b8c5968e42b7ef2319512ee37ac284ce1b12e7"}}}}