{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/751","repository_url":"https://api.github.com/repos/Microsoft/msbuild","labels_url":"https://api.github.com/repos/Microsoft/msbuild/issues/751/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/751/comments","events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/751/events","html_url":"https://github.com/Microsoft/msbuild/pull/751","id":163249329,"number":751,"title":"Implementation of ImportGlobalBuildProps and ImportGlobalBuildTargets","user":{"login":"jeffkl","id":17556515,"avatar_url":"https://avatars.githubusercontent.com/u/17556515?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffkl","html_url":"https://github.com/jeffkl","followers_url":"https://api.github.com/users/jeffkl/followers","following_url":"https://api.github.com/users/jeffkl/following{/other_user}","gists_url":"https://api.github.com/users/jeffkl/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkl/subscriptions","organizations_url":"https://api.github.com/users/jeffkl/orgs","repos_url":"https://api.github.com/users/jeffkl/repos","events_url":"https://api.github.com/users/jeffkl/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/msbuild/labels/cla-required","name":"cla-required","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"assignees":[{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},{"login":"rainersigwald","id":3347530,"avatar_url":"https://avatars.githubusercontent.com/u/3347530?v=3","gravatar_id":"","url":"https://api.github.com/users/rainersigwald","html_url":"https://github.com/rainersigwald","followers_url":"https://api.github.com/users/rainersigwald/followers","following_url":"https://api.github.com/users/rainersigwald/following{/other_user}","gists_url":"https://api.github.com/users/rainersigwald/gists{/gist_id}","starred_url":"https://api.github.com/users/rainersigwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainersigwald/subscriptions","organizations_url":"https://api.github.com/users/rainersigwald/orgs","repos_url":"https://api.github.com/users/rainersigwald/repos","events_url":"https://api.github.com/users/rainersigwald/events{/privacy}","received_events_url":"https://api.github.com/users/rainersigwald/received_events","type":"User","site_admin":false},{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-06-30T19:34:39Z","updated_at":"2016-06-30T19:34:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/751","html_url":"https://github.com/Microsoft/msbuild/pull/751","diff_url":"https://github.com/Microsoft/msbuild/pull/751.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/751.patch"},"body":"#222 MSBuild should have a solution import in Microsoft.Common.Targets\r\n\r\nHere is my initial implementation of the \"global\" import.  I optimized it as much as possible by not continuing if GetDirectoryNameOfFileAbove() returns String.Empty.\r\n\r\n1. _GlobalBuildPropsFile is sort of private with the underscore and is only there so that I didn't have global.build.props in a few places.  I can remove it if we want.\r\n2. _GlobalBuildPropsBasePath is used to store the value of GetDirectoryNameOfFileAbove() in the event that the file isn't found.\r\n3. GlobalBuildPropsPath is the property that stores the combination of the file and base path, unless the user overrides it.\r\n\r\n**My biggest concern is ordering and I wasn't sure if the import is in the correct place or not.  Should the import happen sooner or later?**\r\n\r\nI'm working on the unit tests and will commit them once everyone signs off on the property names."},"comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments/229765060","html_url":"https://github.com/Microsoft/msbuild/pull/751#issuecomment-229765060","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/751","id":229765060,"user":{"login":"dnfclas","id":10201666,"avatar_url":"https://avatars.githubusercontent.com/u/10201666?v=3","gravatar_id":"","url":"https://api.github.com/users/dnfclas","html_url":"https://github.com/dnfclas","followers_url":"https://api.github.com/users/dnfclas/followers","following_url":"https://api.github.com/users/dnfclas/following{/other_user}","gists_url":"https://api.github.com/users/dnfclas/gists{/gist_id}","starred_url":"https://api.github.com/users/dnfclas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnfclas/subscriptions","organizations_url":"https://api.github.com/users/dnfclas/orgs","repos_url":"https://api.github.com/users/dnfclas/repos","events_url":"https://api.github.com/users/dnfclas/events{/privacy}","received_events_url":"https://api.github.com/users/dnfclas/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T19:34:44Z","updated_at":"2016-06-30T19:34:44Z","body":"Hi __@jeffkl__, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!\r\n    <span>\r\n        In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.\r\n    </span>\r\n\r\nTTYL, DNFBOT;\r\n"}}
{"actor":{"display_login":"dnfclas"}}