{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/79367954","id":79367954,"diff_hunk":"@@ -554,7 +554,7 @@ def terminate(self):\n         self._connectable.clear()\n         time.sleep(0.0125)\n         terminate_process_pid(self._process.pid)\n-        self._process.join()\n+#        self._process.join()","path":"tests/integration/__init__.py","position":14,"original_position":14,"commit_id":"6cced56ad32bee775ad6b41973c9295667fc67ab","original_commit_id":"6cced56ad32bee775ad6b41973c9295667fc67ab","user":{"login":"s0undt3ch","id":300048,"avatar_url":"https://avatars.githubusercontent.com/u/300048?v=3","gravatar_id":"","url":"https://api.github.com/users/s0undt3ch","html_url":"https://github.com/s0undt3ch","followers_url":"https://api.github.com/users/s0undt3ch/followers","following_url":"https://api.github.com/users/s0undt3ch/following{/other_user}","gists_url":"https://api.github.com/users/s0undt3ch/gists{/gist_id}","starred_url":"https://api.github.com/users/s0undt3ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s0undt3ch/subscriptions","organizations_url":"https://api.github.com/users/s0undt3ch/orgs","repos_url":"https://api.github.com/users/s0undt3ch/repos","events_url":"https://api.github.com/users/s0undt3ch/events{/privacy}","received_events_url":"https://api.github.com/users/s0undt3ch/received_events","type":"User","site_admin":false},"body":"Produces a stackstrace *with* the `.join()` right?","created_at":"2016-09-19T11:02:33Z","updated_at":"2016-09-19T11:02:49Z","html_url":"https://github.com/saltstack/salt/pull/36399#discussion_r79367954","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/36399","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/79367954"},"html":{"href":"https://github.com/saltstack/salt/pull/36399#discussion_r79367954"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36399"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/36399","id":85767180,"html_url":"https://github.com/saltstack/salt/pull/36399","diff_url":"https://github.com/saltstack/salt/pull/36399.diff","patch_url":"https://github.com/saltstack/salt/pull/36399.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/36399","number":36399,"state":"open","locked":false,"title":"Test shutdown","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"body":"This still isn't 100% complete but it does make some improvements.\r\n\r\nThis modified our implementation of Popen to kill child procs if they are found. This obviates the need to collect child procs in the caller and kill them.\r\n\r\nSecondly, this implements a customized version of the multiprocess poller, which is more understanding about processes which may have been reaped underneath it. This is somewhat of a stopgap measure.\r\n\r\n Finally, this removes the need to send a `.communicate()` to the process, since we aren't processing the output anyhow. \r\n\r\ncc: @s0undt3ch ","created_at":"2016-09-19T10:12:37Z","updated_at":"2016-09-19T11:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07e23ef41384d549229052fe84c52b1c6f950a64","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/36399/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/36399/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/36399/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/6cced56ad32bee775ad6b41973c9295667fc67ab","head":{"label":"cachedout:test_shutdown2","ref":"test_shutdown2","sha":"6cced56ad32bee775ad6b41973c9295667fc67ab","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"repo":{"id":13233022,"name":"salt","full_name":"cachedout/salt","owner":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cachedout/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/cachedout/salt","forks_url":"https://api.github.com/repos/cachedout/salt/forks","keys_url":"https://api.github.com/repos/cachedout/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cachedout/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cachedout/salt/teams","hooks_url":"https://api.github.com/repos/cachedout/salt/hooks","issue_events_url":"https://api.github.com/repos/cachedout/salt/issues/events{/number}","events_url":"https://api.github.com/repos/cachedout/salt/events","assignees_url":"https://api.github.com/repos/cachedout/salt/assignees{/user}","branches_url":"https://api.github.com/repos/cachedout/salt/branches{/branch}","tags_url":"https://api.github.com/repos/cachedout/salt/tags","blobs_url":"https://api.github.com/repos/cachedout/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cachedout/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cachedout/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cachedout/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cachedout/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/cachedout/salt/languages","stargazers_url":"https://api.github.com/repos/cachedout/salt/stargazers","contributors_url":"https://api.github.com/repos/cachedout/salt/contributors","subscribers_url":"https://api.github.com/repos/cachedout/salt/subscribers","subscription_url":"https://api.github.com/repos/cachedout/salt/subscription","commits_url":"https://api.github.com/repos/cachedout/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cachedout/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cachedout/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cachedout/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cachedout/salt/contents/{+path}","compare_url":"https://api.github.com/repos/cachedout/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cachedout/salt/merges","archive_url":"https://api.github.com/repos/cachedout/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cachedout/salt/downloads","issues_url":"https://api.github.com/repos/cachedout/salt/issues{/number}","pulls_url":"https://api.github.com/repos/cachedout/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/cachedout/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/cachedout/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cachedout/salt/labels{/name}","releases_url":"https://api.github.com/repos/cachedout/salt/releases{/id}","deployments_url":"https://api.github.com/repos/cachedout/salt/deployments","created_at":"2013-10-01T02:32:42Z","updated_at":"2015-01-07T05:47:18Z","pushed_at":"2016-09-19T10:09:08Z","git_url":"git://github.com/cachedout/salt.git","ssh_url":"git@github.com:cachedout/salt.git","clone_url":"https://github.com/cachedout/salt.git","svn_url":"https://github.com/cachedout/salt","homepage":"saltstack.org","size":141673,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"30d5a7874e9c2a49e21ca7610240864270b9361e","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-09-18T20:23:57Z","pushed_at":"2016-09-19T10:12:37Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":217748,"stargazers_count":6889,"watchers_count":6889,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3129,"mirror_url":null,"open_issues_count":3870,"forks":3129,"open_issues":3870,"watchers":6889,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36399"},"html":{"href":"https://github.com/saltstack/salt/pull/36399"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/36399"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/36399/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36399/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36399/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/6cced56ad32bee775ad6b41973c9295667fc67ab"}}}}
{"actor":{"display_login":"s0undt3ch"}}