{"action":"opened","number":43,"pull_request":{"url":"https://api.github.com/repos/litchie/dospad/pulls/43","id":83923484,"html_url":"https://github.com/litchie/dospad/pull/43","diff_url":"https://github.com/litchie/dospad/pull/43.diff","patch_url":"https://github.com/litchie/dospad/pull/43.patch","issue_url":"https://api.github.com/repos/litchie/dospad/issues/43","number":43,"state":"open","locked":false,"title":"Fix for keyboard modifiers","user":{"login":"landswipe","id":1407386,"avatar_url":"https://avatars.githubusercontent.com/u/1407386?v=3","gravatar_id":"","url":"https://api.github.com/users/landswipe","html_url":"https://github.com/landswipe","followers_url":"https://api.github.com/users/landswipe/followers","following_url":"https://api.github.com/users/landswipe/following{/other_user}","gists_url":"https://api.github.com/users/landswipe/gists{/gist_id}","starred_url":"https://api.github.com/users/landswipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landswipe/subscriptions","organizations_url":"https://api.github.com/users/landswipe/orgs","repos_url":"https://api.github.com/users/landswipe/repos","events_url":"https://api.github.com/users/landswipe/events{/privacy}","received_events_url":"https://api.github.com/users/landswipe/received_events","type":"User","site_admin":false},"body":"Noted that conditional adjustment of GSEVENT_TYPE was based on IS_IOS9, but since the project moved back to 32bit, this broke modifiers (SHIFT/ALT/etc) as the offsets are actually a result of the integer size not the version of the operating system. Work still needs to be done to clean this up, but I have it working now and tested.\r\n\r\nTested with Apple Wireless Bluetooth on IOS 9.5.3 and IOS 10 Beta 6, also tested with SmartKeyboard on iPad Pro (IOS 10 Beta 6).\r\n\r\nN.B. Regarding Smart Keyboard support, something should be done about mapping for function keys. I noticed the emoji keyboard is inaccessible (no scan codes are sent to application), however an idea might be to use CMD+TILDE (for ESC) and CMD+1->0 (for FN1->FN10).","created_at":"2016-09-04T13:54:01Z","updated_at":"2016-09-04T13:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"815256373cc1c092d40444f0f7e533003d99e6f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/litchie/dospad/pulls/43/commits","review_comments_url":"https://api.github.com/repos/litchie/dospad/pulls/43/comments","review_comment_url":"https://api.github.com/repos/litchie/dospad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/litchie/dospad/issues/43/comments","statuses_url":"https://api.github.com/repos/litchie/dospad/statuses/1e755987193eada896a2b7a14425749136827ca0","head":{"label":"landswipe:keyboardfix32bit","ref":"keyboardfix32bit","sha":"1e755987193eada896a2b7a14425749136827ca0","user":{"login":"landswipe","id":1407386,"avatar_url":"https://avatars.githubusercontent.com/u/1407386?v=3","gravatar_id":"","url":"https://api.github.com/users/landswipe","html_url":"https://github.com/landswipe","followers_url":"https://api.github.com/users/landswipe/followers","following_url":"https://api.github.com/users/landswipe/following{/other_user}","gists_url":"https://api.github.com/users/landswipe/gists{/gist_id}","starred_url":"https://api.github.com/users/landswipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landswipe/subscriptions","organizations_url":"https://api.github.com/users/landswipe/orgs","repos_url":"https://api.github.com/users/landswipe/repos","events_url":"https://api.github.com/users/landswipe/events{/privacy}","received_events_url":"https://api.github.com/users/landswipe/received_events","type":"User","site_admin":false},"repo":{"id":45779299,"name":"dospad","full_name":"landswipe/dospad","owner":{"login":"landswipe","id":1407386,"avatar_url":"https://avatars.githubusercontent.com/u/1407386?v=3","gravatar_id":"","url":"https://api.github.com/users/landswipe","html_url":"https://github.com/landswipe","followers_url":"https://api.github.com/users/landswipe/followers","following_url":"https://api.github.com/users/landswipe/following{/other_user}","gists_url":"https://api.github.com/users/landswipe/gists{/gist_id}","starred_url":"https://api.github.com/users/landswipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landswipe/subscriptions","organizations_url":"https://api.github.com/users/landswipe/orgs","repos_url":"https://api.github.com/users/landswipe/repos","events_url":"https://api.github.com/users/landswipe/events{/privacy}","received_events_url":"https://api.github.com/users/landswipe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/landswipe/dospad","description":"dosbox port for iOS, aka iDOS","fork":true,"url":"https://api.github.com/repos/landswipe/dospad","forks_url":"https://api.github.com/repos/landswipe/dospad/forks","keys_url":"https://api.github.com/repos/landswipe/dospad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/landswipe/dospad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/landswipe/dospad/teams","hooks_url":"https://api.github.com/repos/landswipe/dospad/hooks","issue_events_url":"https://api.github.com/repos/landswipe/dospad/issues/events{/number}","events_url":"https://api.github.com/repos/landswipe/dospad/events","assignees_url":"https://api.github.com/repos/landswipe/dospad/assignees{/user}","branches_url":"https://api.github.com/repos/landswipe/dospad/branches{/branch}","tags_url":"https://api.github.com/repos/landswipe/dospad/tags","blobs_url":"https://api.github.com/repos/landswipe/dospad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/landswipe/dospad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/landswipe/dospad/git/refs{/sha}","trees_url":"https://api.github.com/repos/landswipe/dospad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/landswipe/dospad/statuses/{sha}","languages_url":"https://api.github.com/repos/landswipe/dospad/languages","stargazers_url":"https://api.github.com/repos/landswipe/dospad/stargazers","contributors_url":"https://api.github.com/repos/landswipe/dospad/contributors","subscribers_url":"https://api.github.com/repos/landswipe/dospad/subscribers","subscription_url":"https://api.github.com/repos/landswipe/dospad/subscription","commits_url":"https://api.github.com/repos/landswipe/dospad/commits{/sha}","git_commits_url":"https://api.github.com/repos/landswipe/dospad/git/commits{/sha}","comments_url":"https://api.github.com/repos/landswipe/dospad/comments{/number}","issue_comment_url":"https://api.github.com/repos/landswipe/dospad/issues/comments{/number}","contents_url":"https://api.github.com/repos/landswipe/dospad/contents/{+path}","compare_url":"https://api.github.com/repos/landswipe/dospad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/landswipe/dospad/merges","archive_url":"https://api.github.com/repos/landswipe/dospad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/landswipe/dospad/downloads","issues_url":"https://api.github.com/repos/landswipe/dospad/issues{/number}","pulls_url":"https://api.github.com/repos/landswipe/dospad/pulls{/number}","milestones_url":"https://api.github.com/repos/landswipe/dospad/milestones{/number}","notifications_url":"https://api.github.com/repos/landswipe/dospad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/landswipe/dospad/labels{/name}","releases_url":"https://api.github.com/repos/landswipe/dospad/releases{/id}","deployments_url":"https://api.github.com/repos/landswipe/dospad/deployments","created_at":"2015-11-08T12:22:27Z","updated_at":"2016-09-04T13:43:21Z","pushed_at":"2016-09-04T13:52:54Z","git_url":"git://github.com/landswipe/dospad.git","ssh_url":"git@github.com:landswipe/dospad.git","clone_url":"https://github.com/landswipe/dospad.git","svn_url":"https://github.com/landswipe/dospad","homepage":"","size":10069,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"litchie:master","ref":"master","sha":"8f5055a4c164785e681b01d43741c376c5ba5a10","user":{"login":"litchie","id":1026634,"avatar_url":"https://avatars.githubusercontent.com/u/1026634?v=3","gravatar_id":"","url":"https://api.github.com/users/litchie","html_url":"https://github.com/litchie","followers_url":"https://api.github.com/users/litchie/followers","following_url":"https://api.github.com/users/litchie/following{/other_user}","gists_url":"https://api.github.com/users/litchie/gists{/gist_id}","starred_url":"https://api.github.com/users/litchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litchie/subscriptions","organizations_url":"https://api.github.com/users/litchie/orgs","repos_url":"https://api.github.com/users/litchie/repos","events_url":"https://api.github.com/users/litchie/events{/privacy}","received_events_url":"https://api.github.com/users/litchie/received_events","type":"User","site_admin":false},"repo":{"id":24850043,"name":"dospad","full_name":"litchie/dospad","owner":{"login":"litchie","id":1026634,"avatar_url":"https://avatars.githubusercontent.com/u/1026634?v=3","gravatar_id":"","url":"https://api.github.com/users/litchie","html_url":"https://github.com/litchie","followers_url":"https://api.github.com/users/litchie/followers","following_url":"https://api.github.com/users/litchie/following{/other_user}","gists_url":"https://api.github.com/users/litchie/gists{/gist_id}","starred_url":"https://api.github.com/users/litchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litchie/subscriptions","organizations_url":"https://api.github.com/users/litchie/orgs","repos_url":"https://api.github.com/users/litchie/repos","events_url":"https://api.github.com/users/litchie/events{/privacy}","received_events_url":"https://api.github.com/users/litchie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/litchie/dospad","description":"dosbox port for iOS, aka iDOS","fork":false,"url":"https://api.github.com/repos/litchie/dospad","forks_url":"https://api.github.com/repos/litchie/dospad/forks","keys_url":"https://api.github.com/repos/litchie/dospad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/litchie/dospad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/litchie/dospad/teams","hooks_url":"https://api.github.com/repos/litchie/dospad/hooks","issue_events_url":"https://api.github.com/repos/litchie/dospad/issues/events{/number}","events_url":"https://api.github.com/repos/litchie/dospad/events","assignees_url":"https://api.github.com/repos/litchie/dospad/assignees{/user}","branches_url":"https://api.github.com/repos/litchie/dospad/branches{/branch}","tags_url":"https://api.github.com/repos/litchie/dospad/tags","blobs_url":"https://api.github.com/repos/litchie/dospad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/litchie/dospad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/litchie/dospad/git/refs{/sha}","trees_url":"https://api.github.com/repos/litchie/dospad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/litchie/dospad/statuses/{sha}","languages_url":"https://api.github.com/repos/litchie/dospad/languages","stargazers_url":"https://api.github.com/repos/litchie/dospad/stargazers","contributors_url":"https://api.github.com/repos/litchie/dospad/contributors","subscribers_url":"https://api.github.com/repos/litchie/dospad/subscribers","subscription_url":"https://api.github.com/repos/litchie/dospad/subscription","commits_url":"https://api.github.com/repos/litchie/dospad/commits{/sha}","git_commits_url":"https://api.github.com/repos/litchie/dospad/git/commits{/sha}","comments_url":"https://api.github.com/repos/litchie/dospad/comments{/number}","issue_comment_url":"https://api.github.com/repos/litchie/dospad/issues/comments{/number}","contents_url":"https://api.github.com/repos/litchie/dospad/contents/{+path}","compare_url":"https://api.github.com/repos/litchie/dospad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/litchie/dospad/merges","archive_url":"https://api.github.com/repos/litchie/dospad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/litchie/dospad/downloads","issues_url":"https://api.github.com/repos/litchie/dospad/issues{/number}","pulls_url":"https://api.github.com/repos/litchie/dospad/pulls{/number}","milestones_url":"https://api.github.com/repos/litchie/dospad/milestones{/number}","notifications_url":"https://api.github.com/repos/litchie/dospad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/litchie/dospad/labels{/name}","releases_url":"https://api.github.com/repos/litchie/dospad/releases{/id}","deployments_url":"https://api.github.com/repos/litchie/dospad/deployments","created_at":"2014-10-06T14:48:47Z","updated_at":"2016-09-03T04:19:44Z","pushed_at":"2016-09-04T13:54:02Z","git_url":"git://github.com/litchie/dospad.git","ssh_url":"git@github.com:litchie/dospad.git","clone_url":"https://github.com/litchie/dospad.git","svn_url":"https://github.com/litchie/dospad","homepage":"","size":10178,"stargazers_count":86,"watchers_count":86,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":31,"forks":39,"open_issues":31,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/litchie/dospad/pulls/43"},"html":{"href":"https://github.com/litchie/dospad/pull/43"},"issue":{"href":"https://api.github.com/repos/litchie/dospad/issues/43"},"comments":{"href":"https://api.github.com/repos/litchie/dospad/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/litchie/dospad/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/litchie/dospad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/litchie/dospad/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/litchie/dospad/statuses/1e755987193eada896a2b7a14425749136827ca0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"landswipe"}}