{"action":"created","issue":{"url":"https://api.github.com/repos/shrinkwrap/resolver/issues/85","repository_url":"https://api.github.com/repos/shrinkwrap/resolver","labels_url":"https://api.github.com/repos/shrinkwrap/resolver/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/shrinkwrap/resolver/issues/85/comments","events_url":"https://api.github.com/repos/shrinkwrap/resolver/issues/85/events","html_url":"https://github.com/shrinkwrap/resolver/pull/85","id":98710472,"number":85,"title":"Fix CL problem when used as java agent","user":{"login":"khotyn","id":584455,"avatar_url":"https://avatars.githubusercontent.com/u/584455?v=3","gravatar_id":"","url":"https://api.github.com/users/khotyn","html_url":"https://github.com/khotyn","followers_url":"https://api.github.com/users/khotyn/followers","following_url":"https://api.github.com/users/khotyn/following{/other_user}","gists_url":"https://api.github.com/users/khotyn/gists{/gist_id}","starred_url":"https://api.github.com/users/khotyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khotyn/subscriptions","organizations_url":"https://api.github.com/users/khotyn/orgs","repos_url":"https://api.github.com/users/khotyn/repos","events_url":"https://api.github.com/users/khotyn/events{/privacy}","received_events_url":"https://api.github.com/users/khotyn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2015-08-03T10:00:08Z","updated_at":"2016-08-23T17:51:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shrinkwrap/resolver/pulls/85","html_url":"https://github.com/shrinkwrap/resolver/pull/85","diff_url":"https://github.com/shrinkwrap/resolver/pull/85.diff","patch_url":"https://github.com/shrinkwrap/resolver/pull/85.patch"},"body":"1. When package shrinkwrap resolver to a java agent, the class loader loaded shrinkwrap resolver's class is bootstrap class loader, and when use Class.getClassLoader() the get the class loader of a class that is loaded by bootstrap class loader, the result will be null, and will cause a NPE error. So when the class loader is null, use ClassLoader.getSystemClassLoader instead make sure that we will not use a null class loader to load class.\r\n2. When shading shrinkwrap resolver to a java agent using maven's shade plugin, and modify the package of shrinkwrap resolver, for example, modify org.boss to com.myagent.org.jboss, the hard coded NAME_IMPL_CLASS will cause a ClassNotFoundException, so added a system properties to specify the NAME_IMPL_CLASS value."},"comment":{"url":"https://api.github.com/repos/shrinkwrap/resolver/issues/comments/241816832","html_url":"https://github.com/shrinkwrap/resolver/pull/85#issuecomment-241816832","issue_url":"https://api.github.com/repos/shrinkwrap/resolver/issues/85","id":241816832,"user":{"login":"ALRubinger","id":199891,"avatar_url":"https://avatars.githubusercontent.com/u/199891?v=3","gravatar_id":"","url":"https://api.github.com/users/ALRubinger","html_url":"https://github.com/ALRubinger","followers_url":"https://api.github.com/users/ALRubinger/followers","following_url":"https://api.github.com/users/ALRubinger/following{/other_user}","gists_url":"https://api.github.com/users/ALRubinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ALRubinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ALRubinger/subscriptions","organizations_url":"https://api.github.com/users/ALRubinger/orgs","repos_url":"https://api.github.com/users/ALRubinger/repos","events_url":"https://api.github.com/users/ALRubinger/events{/privacy}","received_events_url":"https://api.github.com/users/ALRubinger/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T17:51:12Z","updated_at":"2016-08-23T17:51:12Z","body":"@khotyn Would you like to take a stab at a test showing this fails without the fix, and passes with it?  In other words, something we can put into the suite to ensure we don't regress to the current behavior you've kindly outlined?"}}
{"actor":{"display_login":"ALRubinger"}}