{"action":"created","issue":{"url":"https://api.github.com/repos/TechChange/eslint-config/issues/5","repository_url":"https://api.github.com/repos/TechChange/eslint-config","labels_url":"https://api.github.com/repos/TechChange/eslint-config/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/TechChange/eslint-config/issues/5/comments","events_url":"https://api.github.com/repos/TechChange/eslint-config/issues/5/events","html_url":"https://github.com/TechChange/eslint-config/pull/5","id":135248017,"number":5,"title":"Update ESLint rules based on feedback","user":{"login":"wchest","id":470326,"avatar_url":"https://avatars.githubusercontent.com/u/470326?v=3","gravatar_id":"","url":"https://api.github.com/users/wchest","html_url":"https://github.com/wchest","followers_url":"https://api.github.com/users/wchest/followers","following_url":"https://api.github.com/users/wchest/following{/other_user}","gists_url":"https://api.github.com/users/wchest/gists{/gist_id}","starred_url":"https://api.github.com/users/wchest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchest/subscriptions","organizations_url":"https://api.github.com/users/wchest/orgs","repos_url":"https://api.github.com/users/wchest/repos","events_url":"https://api.github.com/users/wchest/events{/privacy}","received_events_url":"https://api.github.com/users/wchest/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-21T19:36:40Z","updated_at":"2016-02-22T16:16:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TechChange/eslint-config/pulls/5","html_url":"https://github.com/TechChange/eslint-config/pull/5","diff_url":"https://github.com/TechChange/eslint-config/pull/5.diff","patch_url":"https://github.com/TechChange/eslint-config/pull/5.patch"},"body":"@gabeisman has pointed out a number of rules that are causing numerous ESLint errors. This PR updates some of these so that they are warnings and comments out others until ESLint gets smarter about recognizing nuanced applications of some of the rules. One impetus for these changes is the fact that we are now going to be linting as part of our CI suite and any errors will cause the CI to fail.\r\n\r\nSpecifically, the following rules have been reduced to warnings:\r\n* Max Lenth - We should be mindful of this, but not worth preventing the CI from passing.\r\n* Complexity - There are times when complexity is unavoidable. Keeping as an error, but could certainly be convinced that this should be removed in favor of convention rather than enforcement\r\n* Global Require - With react-router this is unavoidable, but should be fixed in ESLint 2.0. Making this a warning until we get to ESLint 2.0+\r\n\r\nThe following rules have been commented out until we decide to remove or otherwise adjust:\r\n* No Multi Component - The ESLint React plugin does not differentiate between multiple dumb components in one file. There are times when this can be useful, so removing for now.\r\n* Arrow Body Style - There is no way currently to differentiate between instances where it is convenient to leave out surrounding braces. This will be enforced via convention rather than linting\r\n\r\nThese are only suggested changes, so feel free to push back on anything in here. Or add others that you'd like to update."},"comment":{"url":"https://api.github.com/repos/TechChange/eslint-config/issues/comments/187249834","html_url":"https://github.com/TechChange/eslint-config/pull/5#issuecomment-187249834","issue_url":"https://api.github.com/repos/TechChange/eslint-config/issues/5","id":187249834,"user":{"login":"wchest","id":470326,"avatar_url":"https://avatars.githubusercontent.com/u/470326?v=3","gravatar_id":"","url":"https://api.github.com/users/wchest","html_url":"https://github.com/wchest","followers_url":"https://api.github.com/users/wchest/followers","following_url":"https://api.github.com/users/wchest/following{/other_user}","gists_url":"https://api.github.com/users/wchest/gists{/gist_id}","starred_url":"https://api.github.com/users/wchest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchest/subscriptions","organizations_url":"https://api.github.com/users/wchest/orgs","repos_url":"https://api.github.com/users/wchest/repos","events_url":"https://api.github.com/users/wchest/events{/privacy}","received_events_url":"https://api.github.com/users/wchest/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T16:16:57Z","updated_at":"2016-02-22T16:16:57Z","body":"Forgot that I also need to bump the version number in package.json. Will add shortly."}}