{"action":"created","issue":{"url":"https://api.github.com/repos/ratpack/ratpack/issues/1124","repository_url":"https://api.github.com/repos/ratpack/ratpack","labels_url":"https://api.github.com/repos/ratpack/ratpack/issues/1124/labels{/name}","comments_url":"https://api.github.com/repos/ratpack/ratpack/issues/1124/comments","events_url":"https://api.github.com/repos/ratpack/ratpack/issues/1124/events","html_url":"https://github.com/ratpack/ratpack/pull/1124","id":192101243,"number":1124,"title":"Support for HTTPClient interceptors.","user":{"login":"johnrengelman","id":1012772,"avatar_url":"https://avatars.githubusercontent.com/u/1012772?v=3","gravatar_id":"","url":"https://api.github.com/users/johnrengelman","html_url":"https://github.com/johnrengelman","followers_url":"https://api.github.com/users/johnrengelman/followers","following_url":"https://api.github.com/users/johnrengelman/following{/other_user}","gists_url":"https://api.github.com/users/johnrengelman/gists{/gist_id}","starred_url":"https://api.github.com/users/johnrengelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnrengelman/subscriptions","organizations_url":"https://api.github.com/users/johnrengelman/orgs","repos_url":"https://api.github.com/users/johnrengelman/repos","events_url":"https://api.github.com/users/johnrengelman/events{/privacy}","received_events_url":"https://api.github.com/users/johnrengelman/received_events","type":"User","site_admin":false},"labels":[{"id":71890257,"url":"https://api.github.com/repos/ratpack/ratpack/labels/in%20progress","name":"in progress","color":"eac04b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ratpack/ratpack/milestones/40","html_url":"https://github.com/ratpack/ratpack/milestones/release-1.5.0","labels_url":"https://api.github.com/repos/ratpack/ratpack/milestones/40/labels","id":1887930,"number":40,"title":"release-1.5.0","description":"","creator":{"login":"alkemist","id":17825,"avatar_url":"https://avatars.githubusercontent.com/u/17825?v=3","gravatar_id":"","url":"https://api.github.com/users/alkemist","html_url":"https://github.com/alkemist","followers_url":"https://api.github.com/users/alkemist/followers","following_url":"https://api.github.com/users/alkemist/following{/other_user}","gists_url":"https://api.github.com/users/alkemist/gists{/gist_id}","starred_url":"https://api.github.com/users/alkemist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alkemist/subscriptions","organizations_url":"https://api.github.com/users/alkemist/orgs","repos_url":"https://api.github.com/users/alkemist/repos","events_url":"https://api.github.com/users/alkemist/events{/privacy}","received_events_url":"https://api.github.com/users/alkemist/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":3,"state":"open","created_at":"2016-07-17T08:48:51Z","updated_at":"2016-11-29T14:47:30Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-11-28T19:53:35Z","updated_at":"2016-11-29T16:29:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ratpack/ratpack/pulls/1124","html_url":"https://github.com/ratpack/ratpack/pull/1124","diff_url":"https://github.com/ratpack/ratpack/pull/1124.diff","patch_url":"https://github.com/ratpack/ratpack/pull/1124.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/ratpack/ratpack/1124)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/ratpack/ratpack/issues/comments/263620810","html_url":"https://github.com/ratpack/ratpack/pull/1124#issuecomment-263620810","issue_url":"https://api.github.com/repos/ratpack/ratpack/issues/1124","id":263620810,"user":{"login":"rhart","id":226023,"avatar_url":"https://avatars.githubusercontent.com/u/226023?v=3","gravatar_id":"","url":"https://api.github.com/users/rhart","html_url":"https://github.com/rhart","followers_url":"https://api.github.com/users/rhart/followers","following_url":"https://api.github.com/users/rhart/following{/other_user}","gists_url":"https://api.github.com/users/rhart/gists{/gist_id}","starred_url":"https://api.github.com/users/rhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhart/subscriptions","organizations_url":"https://api.github.com/users/rhart/orgs","repos_url":"https://api.github.com/users/rhart/repos","events_url":"https://api.github.com/users/rhart/events{/privacy}","received_events_url":"https://api.github.com/users/rhart/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T16:29:37Z","updated_at":"2016-11-29T16:29:37Z","body":"\n\n\n\n\n\n\n\n*[ratpack-core/src/main/java/ratpack/http/client/internal/DefaultHttpClient.java, line 162 at r1](https://reviewable.io:443/reviews/ratpack/ratpack/1124#-KXku62EzLDcYAhjaM3T:-KXku62Fv9vIEBB3Au75:b-ldobpi) ([raw file](https://github.com/ratpack/ratpack/blob/675674c1beb888179002fc5ced0c1f7ce86c9289/ratpack-core/src/main/java/ratpack/http/client/internal/DefaultHttpClient.java#L162)):*\n> ```Java\n>       s.readTimeout(getReadTimeout());\n>       s.requestIntercept(getRequestInterceptor());\n>       s.responseIntercept(getResponseInterceptor());\n> ```\n\nThis seems quite fragile. If we add new properties to the spec it is too easy to forget to set them here.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/ratpack/ratpack/1124)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"rhart"}}