{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4418","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4418/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4418/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4418/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/4418","id":187066979,"number":4418,"title":"Implemented the slider bar present on GHWT guitar controllers","user":{"login":"Freyaday","id":4823271,"avatar_url":"https://avatars.githubusercontent.com/u/4823271?v=3","gravatar_id":"","url":"https://api.github.com/users/Freyaday","html_url":"https://github.com/Freyaday","followers_url":"https://api.github.com/users/Freyaday/followers","following_url":"https://api.github.com/users/Freyaday/following{/other_user}","gists_url":"https://api.github.com/users/Freyaday/gists{/gist_id}","starred_url":"https://api.github.com/users/Freyaday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freyaday/subscriptions","organizations_url":"https://api.github.com/users/Freyaday/orgs","repos_url":"https://api.github.com/users/Freyaday/repos","events_url":"https://api.github.com/users/Freyaday/events{/privacy}","received_events_url":"https://api.github.com/users/Freyaday/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-11-03T13:58:20Z","updated_at":"2016-11-05T10:11:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4418","html_url":"https://github.com/dolphin-emu/dolphin/pull/4418","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4418.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4418.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4418)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/258602457","html_url":"https://github.com/dolphin-emu/dolphin/pull/4418#issuecomment-258602457","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4418","id":258602457,"user":{"login":"Freyaday","id":4823271,"avatar_url":"https://avatars.githubusercontent.com/u/4823271?v=3","gravatar_id":"","url":"https://api.github.com/users/Freyaday","html_url":"https://github.com/Freyaday","followers_url":"https://api.github.com/users/Freyaday/followers","following_url":"https://api.github.com/users/Freyaday/following{/other_user}","gists_url":"https://api.github.com/users/Freyaday/gists{/gist_id}","starred_url":"https://api.github.com/users/Freyaday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freyaday/subscriptions","organizations_url":"https://api.github.com/users/Freyaday/orgs","repos_url":"https://api.github.com/users/Freyaday/repos","events_url":"https://api.github.com/users/Freyaday/events{/privacy}","received_events_url":"https://api.github.com/users/Freyaday/received_events","type":"User","site_admin":false},"created_at":"2016-11-05T10:11:26Z","updated_at":"2016-11-05T10:11:26Z","body":"\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[Source/Core/Core/HW/WiimoteEmu/Attachment/Guitar.cpp, line 12 at r4](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4418#-KVfAorfIOhqZhjc6VqK:-KVnwxVLJhTRaDJ6LYd3:bz7ftid) ([raw file](https://github.com/dolphin-emu/dolphin/blob/74115837a80fd088e6861683f40666fd39132a7b/Source/Core/Core/HW/WiimoteEmu/Attachment/Guitar.cpp#L12)):*\n<details><summary><i>Previously, BhaaLseN (BhaaL) wrote…</i></summary>\n> Hmm, with increased (height-)scale, it does look non-linear too :/\n> But it does resemble an S-curve that peaks upwards from `-1 .. 0` then levels through zero and dips downwards from `0 .. 1` - but not in a way that can be mirrored (unless your values are rounded oddly so it looks off). Closest match to a trend-line I can get is 6th order polynomial (up from at least 3rd order, which doesn't quite hit the center mark), but thats going to be a pain to implement... and probably not worth it either.\n> Suppose its best to keep the LUT for now, until someone comes up with a better idea.\n</details>\nI redid the mappings for better accuracy and while they're strictly-increasing, they don't seem to follow any particular curve or formula: https://puu.sh/s7bul/e6801da2db.png A quintic function maps to them perfectly, but that's true of any six points (for n points, there's an n-1th order polynomial that exactly fits them).\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4418)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Freyaday"}}