{"action":"closed","number":2449,"pull_request":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2449","id":88350979,"html_url":"https://github.com/Microsoft/RTVS/pull/2449","diff_url":"https://github.com/Microsoft/RTVS/pull/2449.diff","patch_url":"https://github.com/Microsoft/RTVS/pull/2449.patch","issue_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2449","number":2449,"state":"closed","locked":false,"title":"Store settings in an environment.","user":{"login":"huguesv","id":1696845,"avatar_url":"https://avatars.githubusercontent.com/u/1696845?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/Microsoft/RTVS/issues/2409\r\n\r\nFile looks like this now:\r\n```\r\n# Application settings file.\r\n# File content was generated on 10/6/2016 3:09:07 PM.\r\n\r\nsettings <- new.env()\r\n\r\nsettings$name1 <- 'value1'\r\n\r\nsettings$name2 <- 'value2'\r\n\r\n```\r\n\r\nAnd it can import settings from v0.5 or older. Once you save, it will rewrite it in new format.\r\n\r\nSo if you source the settings file, you access them via `settings$name1`.  That's not exactly what is mentioned in the bug though, which says you should be able to access them via `settings:::name1`.  Not sure if that was a mistake of if there's a way to achieve that.\r\n","created_at":"2016-10-06T22:14:20Z","updated_at":"2016-10-19T00:46:51Z","closed_at":"2016-10-19T00:46:50Z","merged_at":"2016-10-19T00:46:50Z","merge_commit_sha":"4b4139fe4ae2ecbe840ae8e557672637fdedc4b3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2449/commits","review_comments_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2449/comments","review_comment_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2449/comments","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/4897375e4358a6671810062dab9bc0e3d5634445","head":{"label":"huguesv:settingsenv","ref":"settingsenv","sha":"4897375e4358a6671810062dab9bc0e3d5634445","user":{"login":"huguesv","id":1696845,"avatar_url":"https://avatars.githubusercontent.com/u/1696845?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"repo":{"id":53520855,"name":"RTVS","full_name":"huguesv/RTVS","owner":{"login":"huguesv","id":1696845,"avatar_url":"https://avatars.githubusercontent.com/u/1696845?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huguesv/RTVS","description":"R Tools for Visual Studio.","fork":true,"url":"https://api.github.com/repos/huguesv/RTVS","forks_url":"https://api.github.com/repos/huguesv/RTVS/forks","keys_url":"https://api.github.com/repos/huguesv/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huguesv/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huguesv/RTVS/teams","hooks_url":"https://api.github.com/repos/huguesv/RTVS/hooks","issue_events_url":"https://api.github.com/repos/huguesv/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/huguesv/RTVS/events","assignees_url":"https://api.github.com/repos/huguesv/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/huguesv/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/huguesv/RTVS/tags","blobs_url":"https://api.github.com/repos/huguesv/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huguesv/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huguesv/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/huguesv/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huguesv/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/huguesv/RTVS/languages","stargazers_url":"https://api.github.com/repos/huguesv/RTVS/stargazers","contributors_url":"https://api.github.com/repos/huguesv/RTVS/contributors","subscribers_url":"https://api.github.com/repos/huguesv/RTVS/subscribers","subscription_url":"https://api.github.com/repos/huguesv/RTVS/subscription","commits_url":"https://api.github.com/repos/huguesv/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/huguesv/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/huguesv/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/huguesv/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/huguesv/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/huguesv/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huguesv/RTVS/merges","archive_url":"https://api.github.com/repos/huguesv/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huguesv/RTVS/downloads","issues_url":"https://api.github.com/repos/huguesv/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/huguesv/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/huguesv/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/huguesv/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huguesv/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/huguesv/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/huguesv/RTVS/deployments","created_at":"2016-03-09T18:22:52Z","updated_at":"2016-03-09T18:25:54Z","pushed_at":"2016-10-17T20:18:02Z","git_url":"git://github.com/huguesv/RTVS.git","ssh_url":"git@github.com:huguesv/RTVS.git","clone_url":"https://github.com/huguesv/RTVS.git","svn_url":"https://github.com/huguesv/RTVS","homepage":null,"size":52527,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"3871e30e140376adc995cd396cc6046864d4eb64","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38640473,"name":"RTVS","full_name":"Microsoft/RTVS","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/RTVS","description":"R Tools for Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/RTVS","forks_url":"https://api.github.com/repos/Microsoft/RTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/RTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/RTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/RTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/RTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/RTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/RTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/RTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/RTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/RTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/RTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/RTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/RTVS/deployments","created_at":"2015-07-06T19:14:09Z","updated_at":"2016-10-18T18:02:11Z","pushed_at":"2016-10-19T00:46:50Z","git_url":"git://github.com/Microsoft/RTVS.git","ssh_url":"git@github.com:Microsoft/RTVS.git","clone_url":"https://github.com/Microsoft/RTVS.git","svn_url":"https://github.com/Microsoft/RTVS","homepage":null,"size":53353,"stargazers_count":208,"watchers_count":208,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":324,"forks":57,"open_issues":324,"watchers":208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2449"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2449"},"issue":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2449"},"comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2449/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2449/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2449/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/RTVS/statuses/4897375e4358a6671810062dab9bc0e3d5634445"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"huguesv","id":1696845,"avatar_url":"https://avatars.githubusercontent.com/u/1696845?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"comments":5,"review_comments":14,"commits":7,"additions":365,"deletions":71,"changed_files":7}}
{"actor":{"display_login":"huguesv"}}