{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/696","repository_url":"https://api.github.com/repos/eclipse/jetty.project","labels_url":"https://api.github.com/repos/eclipse/jetty.project/issues/696/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/696/comments","events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/696/events","html_url":"https://github.com/eclipse/jetty.project/issues/696","id":164345477,"number":696,"title":"LocalConnector.getResponse() doesn't find close if using HTTP/1.1 w/Connection: close","user":{"login":"joakime","id":191721,"avatar_url":"https://avatars.githubusercontent.com/u/191721?v=3","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/eclipse/jetty.project/labels/Bug","name":"Bug","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"gregw","id":70829,"avatar_url":"https://avatars.githubusercontent.com/u/70829?v=3","gravatar_id":"","url":"https://api.github.com/users/gregw","html_url":"https://github.com/gregw","followers_url":"https://api.github.com/users/gregw/followers","following_url":"https://api.github.com/users/gregw/following{/other_user}","gists_url":"https://api.github.com/users/gregw/gists{/gist_id}","starred_url":"https://api.github.com/users/gregw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregw/subscriptions","organizations_url":"https://api.github.com/users/gregw/orgs","repos_url":"https://api.github.com/users/gregw/repos","events_url":"https://api.github.com/users/gregw/events{/privacy}","received_events_url":"https://api.github.com/users/gregw/received_events","type":"User","site_admin":false},"assignees":[{"login":"gregw","id":70829,"avatar_url":"https://avatars.githubusercontent.com/u/70829?v=3","gravatar_id":"","url":"https://api.github.com/users/gregw","html_url":"https://github.com/gregw","followers_url":"https://api.github.com/users/gregw/followers","following_url":"https://api.github.com/users/gregw/following{/other_user}","gists_url":"https://api.github.com/users/gregw/gists{/gist_id}","starred_url":"https://api.github.com/users/gregw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregw/subscriptions","organizations_url":"https://api.github.com/users/gregw/orgs","repos_url":"https://api.github.com/users/gregw/repos","events_url":"https://api.github.com/users/gregw/events{/privacy}","received_events_url":"https://api.github.com/users/gregw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-07T15:57:48Z","updated_at":"2016-07-08T12:19:15Z","closed_at":null,"body":"In the following testing example ...\r\n\r\n``` java\r\nHttpTester.Request request = HttpTester.newRequest();\r\n\r\nrequest.setMethod(\"GET\");\r\nrequest.setVersion(HttpVersion.HTTP_1_1);\r\nrequest.setHeader(\"Host\", \"tester\");\r\nrequest.setHeader(\"Connection\", \"close\");\r\nrequest.setURI(\"/testdir/\");\r\n\r\nString response = localConnector.getResponse(BufferUtil.toString(request.generate()));\r\n```\r\n\r\nThe `localConnector.getResponse()` never returns, as its waiting on the connection close at ...\r\n\r\n```\r\n\tat sun.misc.Unsafe.park(Native Method)\r\n\tat java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)\r\n\tat java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2163)\r\n\tat org.eclipse.jetty.io.ByteArrayEndPoint.waitForOutput(ByteArrayEndPoint.java:286)\r\n\tat org.eclipse.jetty.server.LocalConnector$LocalEndPoint.waitForResponse(LocalConnector.java:403)\r\n\tat org.eclipse.jetty.server.LocalConnector.getResponse(LocalConnector.java:244)\r\n\tat org.eclipse.jetty.server.LocalConnector.getResponse(LocalConnector.java:226)\r\n\tat org.eclipse.jetty.server.handler.AllowSymLinkAliasCheckerTest.testAccessTestDir(AllowSymLinkAliasCheckerTest.java:149)\r\n```\r\n\r\nRemoving the two lines ...\r\n\r\n``` java\r\nrequest.setVersion(HttpVersion.HTTP_1_1);\r\nrequest.setHeader(\"Connection\", \"close\");\r\n```\r\n\r\nallows the test to continue, but this seems like a bug in `LocalConnector`\r\n"},"comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments/231345390","html_url":"https://github.com/eclipse/jetty.project/issues/696#issuecomment-231345390","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/696","id":231345390,"user":{"login":"joakime","id":191721,"avatar_url":"https://avatars.githubusercontent.com/u/191721?v=3","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T12:19:15Z","updated_at":"2016-07-08T12:19:15Z","body":"Saw this in 9.3.x - you can replicate pretty easily by adding these 2 headers to the usage found in the `AllowSymLinkAliasCheckerTest.testAccess()` method.\r\n\r\n``` java\r\nrequest.setVersion(HttpVersion.HTTP_1_1);\r\nrequest.setHeader(\"Connection\", \"close\");\r\n```"}}
{"actor":{"display_login":"joakime"}}