{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/comments/88340709","pull_request_review_id":8917879,"id":88340709,"diff_hunk":"@@ -0,0 +1,48 @@\n+﻿using System;\n+using System.IO;\n+\n+namespace Microsoft.SqlTools.ServiceLayer.TestDriver.Utility\n+{\n+    public class SelfCleaningFile : IDisposable\n+    {\n+        private bool disposed;\n+\n+        public SelfCleaningFile()","path":"test/Microsoft.SqlTools.ServiceLayer.TestDriver/Utility/SelfCleaningFile.cs","position":10,"original_position":10,"commit_id":"29fa52860498ba7cdef0dfc6a5ed358d712d401d","original_commit_id":"29fa52860498ba7cdef0dfc6a5ed358d712d401d","user":{"login":"llali","id":17187348,"avatar_url":"https://avatars.githubusercontent.com/u/17187348?v=3","gravatar_id":"","url":"https://api.github.com/users/llali","html_url":"https://github.com/llali","followers_url":"https://api.github.com/users/llali/followers","following_url":"https://api.github.com/users/llali/following{/other_user}","gists_url":"https://api.github.com/users/llali/gists{/gist_id}","starred_url":"https://api.github.com/users/llali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llali/subscriptions","organizations_url":"https://api.github.com/users/llali/orgs","repos_url":"https://api.github.com/users/llali/repos","events_url":"https://api.github.com/users/llali/events{/privacy}","received_events_url":"https://api.github.com/users/llali/received_events","type":"User","site_admin":false},"body":"SelfCleaningTempFile? ","created_at":"2016-11-16T21:58:13Z","updated_at":"2016-11-16T21:58:13Z","html_url":"https://github.com/Microsoft/sqltoolsservice/pull/151#discussion_r88340709","pull_request_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/comments/88340709"},"html":{"href":"https://github.com/Microsoft/sqltoolsservice/pull/151#discussion_r88340709"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/151","id":94051349,"html_url":"https://github.com/Microsoft/sqltoolsservice/pull/151","diff_url":"https://github.com/Microsoft/sqltoolsservice/pull/151.diff","patch_url":"https://github.com/Microsoft/sqltoolsservice/pull/151.patch","issue_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/151","number":151,"state":"open","locked":false,"title":"Fix Code Coverage","user":{"login":"benrr101","id":585878,"avatar_url":"https://avatars.githubusercontent.com/u/585878?v=3","gravatar_id":"","url":"https://api.github.com/users/benrr101","html_url":"https://github.com/benrr101","followers_url":"https://api.github.com/users/benrr101/followers","following_url":"https://api.github.com/users/benrr101/following{/other_user}","gists_url":"https://api.github.com/users/benrr101/gists{/gist_id}","starred_url":"https://api.github.com/users/benrr101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrr101/subscriptions","organizations_url":"https://api.github.com/users/benrr101/orgs","repos_url":"https://api.github.com/users/benrr101/repos","events_url":"https://api.github.com/users/benrr101/events{/privacy}","received_events_url":"https://api.github.com/users/benrr101/received_events","type":"User","site_admin":false},"body":"This is another large code review. I want to make a few more changes, but since these changes will stand on their own, I'll hold back on making this change set any larger than it already is.\r\n\r\nChanges in this request:\r\n* To address Microsoft/vscode-mssql#326, instead of doing `taskkill` on the service layer when WaitForExit is executed, we now make an educated guess at which service layer was spawned when the test starts and do a Process.Kill on it when we shut down the test.\r\n* All the perf tests have been moved into a new project. This was done to keep them easily separated from code coverage test runs. At the same time the perf tests were separated into separate classes for logical categorization. This process will likely be repeated on the stress tests. The tests can still easily be ran from Visual Studio Test Explorer\r\n* To address Microsoft/vscode-mssql#349, a new SelfCleaningFile class was created to allow for easy cleanup of temporary files generated for integration tests via using blocks.\r\n* Due to some of the refactoring done while moving the perf tests to a new project, the TestBase class had to be switched to more of a helper class style. As such, all tests that use inherit from TestBase now create a TestBase object on start via a using block. This also simplifies the cleanup at the end of the test.","created_at":"2016-11-16T21:15:07Z","updated_at":"2016-11-16T21:58:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cd9e36b0c9a8ae52ca1d2ebe1f12325e784e3dd","assignee":{"login":"MitchellSternke","id":168615,"avatar_url":"https://avatars.githubusercontent.com/u/168615?v=3","gravatar_id":"","url":"https://api.github.com/users/MitchellSternke","html_url":"https://github.com/MitchellSternke","followers_url":"https://api.github.com/users/MitchellSternke/followers","following_url":"https://api.github.com/users/MitchellSternke/following{/other_user}","gists_url":"https://api.github.com/users/MitchellSternke/gists{/gist_id}","starred_url":"https://api.github.com/users/MitchellSternke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitchellSternke/subscriptions","organizations_url":"https://api.github.com/users/MitchellSternke/orgs","repos_url":"https://api.github.com/users/MitchellSternke/repos","events_url":"https://api.github.com/users/MitchellSternke/events{/privacy}","received_events_url":"https://api.github.com/users/MitchellSternke/received_events","type":"User","site_admin":false},"assignees":[{"login":"MitchellSternke","id":168615,"avatar_url":"https://avatars.githubusercontent.com/u/168615?v=3","gravatar_id":"","url":"https://api.github.com/users/MitchellSternke","html_url":"https://github.com/MitchellSternke","followers_url":"https://api.github.com/users/MitchellSternke/followers","following_url":"https://api.github.com/users/MitchellSternke/following{/other_user}","gists_url":"https://api.github.com/users/MitchellSternke/gists{/gist_id}","starred_url":"https://api.github.com/users/MitchellSternke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitchellSternke/subscriptions","organizations_url":"https://api.github.com/users/MitchellSternke/orgs","repos_url":"https://api.github.com/users/MitchellSternke/repos","events_url":"https://api.github.com/users/MitchellSternke/events{/privacy}","received_events_url":"https://api.github.com/users/MitchellSternke/received_events","type":"User","site_admin":false},{"login":"kburtram","id":599935,"avatar_url":"https://avatars.githubusercontent.com/u/599935?v=3","gravatar_id":"","url":"https://api.github.com/users/kburtram","html_url":"https://github.com/kburtram","followers_url":"https://api.github.com/users/kburtram/followers","following_url":"https://api.github.com/users/kburtram/following{/other_user}","gists_url":"https://api.github.com/users/kburtram/gists{/gist_id}","starred_url":"https://api.github.com/users/kburtram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kburtram/subscriptions","organizations_url":"https://api.github.com/users/kburtram/orgs","repos_url":"https://api.github.com/users/kburtram/repos","events_url":"https://api.github.com/users/kburtram/events{/privacy}","received_events_url":"https://api.github.com/users/kburtram/received_events","type":"User","site_admin":false},{"login":"llali","id":17187348,"avatar_url":"https://avatars.githubusercontent.com/u/17187348?v=3","gravatar_id":"","url":"https://api.github.com/users/llali","html_url":"https://github.com/llali","followers_url":"https://api.github.com/users/llali/followers","following_url":"https://api.github.com/users/llali/following{/other_user}","gists_url":"https://api.github.com/users/llali/gists{/gist_id}","starred_url":"https://api.github.com/users/llali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llali/subscriptions","organizations_url":"https://api.github.com/users/llali/orgs","repos_url":"https://api.github.com/users/llali/repos","events_url":"https://api.github.com/users/llali/events{/privacy}","received_events_url":"https://api.github.com/users/llali/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/151/commits","review_comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/151/comments","review_comment_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/151/comments","statuses_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/statuses/29fa52860498ba7cdef0dfc6a5ed358d712d401d","head":{"label":"Microsoft:bug/codeCoverageKillFail","ref":"bug/codeCoverageKillFail","sha":"29fa52860498ba7cdef0dfc6a5ed358d712d401d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":63441273,"name":"sqltoolsservice","full_name":"Microsoft/sqltoolsservice","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/sqltoolsservice","description":"SQL Tools API service repo.","fork":false,"url":"https://api.github.com/repos/Microsoft/sqltoolsservice","forks_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/forks","keys_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/teams","hooks_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/events","assignees_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/tags","blobs_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/languages","stargazers_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/subscription","commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/merges","archive_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/downloads","issues_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/deployments","created_at":"2016-07-15T18:00:16Z","updated_at":"2016-11-16T14:07:33Z","pushed_at":"2016-11-16T21:15:07Z","git_url":"git://github.com/Microsoft/sqltoolsservice.git","ssh_url":"git@github.com:Microsoft/sqltoolsservice.git","clone_url":"https://github.com/Microsoft/sqltoolsservice.git","svn_url":"https://github.com/Microsoft/sqltoolsservice","homepage":null,"size":13998,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"dev"}},"base":{"label":"Microsoft:dev","ref":"dev","sha":"c2ffd4c2a5ffdfc296f46136b364a234cb94b69a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":63441273,"name":"sqltoolsservice","full_name":"Microsoft/sqltoolsservice","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/sqltoolsservice","description":"SQL Tools API service repo.","fork":false,"url":"https://api.github.com/repos/Microsoft/sqltoolsservice","forks_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/forks","keys_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/teams","hooks_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/events","assignees_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/tags","blobs_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/languages","stargazers_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/subscription","commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/merges","archive_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/downloads","issues_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/deployments","created_at":"2016-07-15T18:00:16Z","updated_at":"2016-11-16T14:07:33Z","pushed_at":"2016-11-16T21:15:07Z","git_url":"git://github.com/Microsoft/sqltoolsservice.git","ssh_url":"git@github.com:Microsoft/sqltoolsservice.git","clone_url":"https://github.com/Microsoft/sqltoolsservice.git","svn_url":"https://github.com/Microsoft/sqltoolsservice","homepage":null,"size":13998,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/151"},"html":{"href":"https://github.com/Microsoft/sqltoolsservice/pull/151"},"issue":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/151"},"comments":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/statuses/29fa52860498ba7cdef0dfc6a5ed358d712d401d"}}}}
{"actor":{"display_login":"llali"}}