{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls/1","id":99298380,"html_url":"https://github.com/james-johnston-thumbtack/php-debugbar/pull/1","diff_url":"https://github.com/james-johnston-thumbtack/php-debugbar/pull/1.diff","patch_url":"https://github.com/james-johnston-thumbtack/php-debugbar/pull/1.patch","issue_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues/1","number":1,"state":"closed","locked":false,"title":"Fix bodyMarginBottomHeight-related bugs in DebugBar","user":{"login":"james-johnston-thumbtack","id":22308682,"avatar_url":"https://avatars.githubusercontent.com/u/22308682?v=3","gravatar_id":"","url":"https://api.github.com/users/james-johnston-thumbtack","html_url":"https://github.com/james-johnston-thumbtack","followers_url":"https://api.github.com/users/james-johnston-thumbtack/followers","following_url":"https://api.github.com/users/james-johnston-thumbtack/following{/other_user}","gists_url":"https://api.github.com/users/james-johnston-thumbtack/gists{/gist_id}","starred_url":"https://api.github.com/users/james-johnston-thumbtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-johnston-thumbtack/subscriptions","organizations_url":"https://api.github.com/users/james-johnston-thumbtack/orgs","repos_url":"https://api.github.com/users/james-johnston-thumbtack/repos","events_url":"https://api.github.com/users/james-johnston-thumbtack/events{/privacy}","received_events_url":"https://api.github.com/users/james-johnston-thumbtack/received_events","type":"User","site_admin":false},"body":"This fixes two problems:\r\n\r\n1.  In recomputeBottomOffset, if bodyMarginBottomHeight is NaN, we need\r\n    to change that to a 0 before adding so we don’t end up setting\r\n    the offset variable to NaN.\r\n\r\n2.  We now initialize bodyMarginBottomHeight in the initialize function.\r\n    This fixes a bug where bodyMarginBottomHeight gets set to NaN if the\r\n    debugbar.js is included in the page header and not the page body\r\n    (i.e. before the body element has been loaded).","created_at":"2016-12-24T08:16:41Z","updated_at":"2016-12-24T08:17:31Z","closed_at":"2016-12-24T08:17:31Z","merged_at":"2016-12-24T08:17:31Z","merge_commit_sha":"c628e1a53ffbf03078786d8707d91729129999bd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls/1/commits","review_comments_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls/1/comments","review_comment_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues/1/comments","statuses_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/statuses/acfca4d8e7815cec16357f1dda9704841cd63a07","head":{"label":"james-johnston-thumbtack:fix-recomputeBottomOffset","ref":"fix-recomputeBottomOffset","sha":"acfca4d8e7815cec16357f1dda9704841cd63a07","user":{"login":"james-johnston-thumbtack","id":22308682,"avatar_url":"https://avatars.githubusercontent.com/u/22308682?v=3","gravatar_id":"","url":"https://api.github.com/users/james-johnston-thumbtack","html_url":"https://github.com/james-johnston-thumbtack","followers_url":"https://api.github.com/users/james-johnston-thumbtack/followers","following_url":"https://api.github.com/users/james-johnston-thumbtack/following{/other_user}","gists_url":"https://api.github.com/users/james-johnston-thumbtack/gists{/gist_id}","starred_url":"https://api.github.com/users/james-johnston-thumbtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-johnston-thumbtack/subscriptions","organizations_url":"https://api.github.com/users/james-johnston-thumbtack/orgs","repos_url":"https://api.github.com/users/james-johnston-thumbtack/repos","events_url":"https://api.github.com/users/james-johnston-thumbtack/events{/privacy}","received_events_url":"https://api.github.com/users/james-johnston-thumbtack/received_events","type":"User","site_admin":false},"repo":{"id":77263435,"name":"php-debugbar","full_name":"james-johnston-thumbtack/php-debugbar","owner":{"login":"james-johnston-thumbtack","id":22308682,"avatar_url":"https://avatars.githubusercontent.com/u/22308682?v=3","gravatar_id":"","url":"https://api.github.com/users/james-johnston-thumbtack","html_url":"https://github.com/james-johnston-thumbtack","followers_url":"https://api.github.com/users/james-johnston-thumbtack/followers","following_url":"https://api.github.com/users/james-johnston-thumbtack/following{/other_user}","gists_url":"https://api.github.com/users/james-johnston-thumbtack/gists{/gist_id}","starred_url":"https://api.github.com/users/james-johnston-thumbtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-johnston-thumbtack/subscriptions","organizations_url":"https://api.github.com/users/james-johnston-thumbtack/orgs","repos_url":"https://api.github.com/users/james-johnston-thumbtack/repos","events_url":"https://api.github.com/users/james-johnston-thumbtack/events{/privacy}","received_events_url":"https://api.github.com/users/james-johnston-thumbtack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/james-johnston-thumbtack/php-debugbar","description":"Debug bar for PHP","fork":true,"url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar","forks_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/forks","keys_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/teams","hooks_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/hooks","issue_events_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues/events{/number}","events_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/events","assignees_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/assignees{/user}","branches_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/branches{/branch}","tags_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/tags","blobs_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/statuses/{sha}","languages_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/languages","stargazers_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/stargazers","contributors_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/contributors","subscribers_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/subscribers","subscription_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/subscription","commits_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/contents/{+path}","compare_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/merges","archive_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/downloads","issues_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues{/number}","pulls_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls{/number}","milestones_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/milestones{/number}","notifications_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/labels{/name}","releases_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/releases{/id}","deployments_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/deployments","created_at":"2016-12-24T03:22:06Z","updated_at":"2016-12-24T03:22:19Z","pushed_at":"2016-12-24T08:17:31Z","git_url":"git://github.com/james-johnston-thumbtack/php-debugbar.git","ssh_url":"git@github.com:james-johnston-thumbtack/php-debugbar.git","clone_url":"https://github.com/james-johnston-thumbtack/php-debugbar.git","svn_url":"https://github.com/james-johnston-thumbtack/php-debugbar","homepage":"phpdebugbar.com","size":4545,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"james-johnston-thumbtack:dev-master","ref":"dev-master","sha":"938526c6956a6b0f6347aa5940e18e8497e67b26","user":{"login":"james-johnston-thumbtack","id":22308682,"avatar_url":"https://avatars.githubusercontent.com/u/22308682?v=3","gravatar_id":"","url":"https://api.github.com/users/james-johnston-thumbtack","html_url":"https://github.com/james-johnston-thumbtack","followers_url":"https://api.github.com/users/james-johnston-thumbtack/followers","following_url":"https://api.github.com/users/james-johnston-thumbtack/following{/other_user}","gists_url":"https://api.github.com/users/james-johnston-thumbtack/gists{/gist_id}","starred_url":"https://api.github.com/users/james-johnston-thumbtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-johnston-thumbtack/subscriptions","organizations_url":"https://api.github.com/users/james-johnston-thumbtack/orgs","repos_url":"https://api.github.com/users/james-johnston-thumbtack/repos","events_url":"https://api.github.com/users/james-johnston-thumbtack/events{/privacy}","received_events_url":"https://api.github.com/users/james-johnston-thumbtack/received_events","type":"User","site_admin":false},"repo":{"id":77263435,"name":"php-debugbar","full_name":"james-johnston-thumbtack/php-debugbar","owner":{"login":"james-johnston-thumbtack","id":22308682,"avatar_url":"https://avatars.githubusercontent.com/u/22308682?v=3","gravatar_id":"","url":"https://api.github.com/users/james-johnston-thumbtack","html_url":"https://github.com/james-johnston-thumbtack","followers_url":"https://api.github.com/users/james-johnston-thumbtack/followers","following_url":"https://api.github.com/users/james-johnston-thumbtack/following{/other_user}","gists_url":"https://api.github.com/users/james-johnston-thumbtack/gists{/gist_id}","starred_url":"https://api.github.com/users/james-johnston-thumbtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-johnston-thumbtack/subscriptions","organizations_url":"https://api.github.com/users/james-johnston-thumbtack/orgs","repos_url":"https://api.github.com/users/james-johnston-thumbtack/repos","events_url":"https://api.github.com/users/james-johnston-thumbtack/events{/privacy}","received_events_url":"https://api.github.com/users/james-johnston-thumbtack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/james-johnston-thumbtack/php-debugbar","description":"Debug bar for PHP","fork":true,"url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar","forks_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/forks","keys_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/teams","hooks_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/hooks","issue_events_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues/events{/number}","events_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/events","assignees_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/assignees{/user}","branches_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/branches{/branch}","tags_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/tags","blobs_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/statuses/{sha}","languages_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/languages","stargazers_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/stargazers","contributors_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/contributors","subscribers_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/subscribers","subscription_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/subscription","commits_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/contents/{+path}","compare_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/merges","archive_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/downloads","issues_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues{/number}","pulls_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls{/number}","milestones_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/milestones{/number}","notifications_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/labels{/name}","releases_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/releases{/id}","deployments_url":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/deployments","created_at":"2016-12-24T03:22:06Z","updated_at":"2016-12-24T03:22:19Z","pushed_at":"2016-12-24T08:17:31Z","git_url":"git://github.com/james-johnston-thumbtack/php-debugbar.git","ssh_url":"git@github.com:james-johnston-thumbtack/php-debugbar.git","clone_url":"https://github.com/james-johnston-thumbtack/php-debugbar.git","svn_url":"https://github.com/james-johnston-thumbtack/php-debugbar","homepage":"phpdebugbar.com","size":4545,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls/1"},"html":{"href":"https://github.com/james-johnston-thumbtack/php-debugbar/pull/1"},"issue":{"href":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues/1"},"comments":{"href":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/james-johnston-thumbtack/php-debugbar/statuses/acfca4d8e7815cec16357f1dda9704841cd63a07"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"james-johnston-thumbtack","id":22308682,"avatar_url":"https://avatars.githubusercontent.com/u/22308682?v=3","gravatar_id":"","url":"https://api.github.com/users/james-johnston-thumbtack","html_url":"https://github.com/james-johnston-thumbtack","followers_url":"https://api.github.com/users/james-johnston-thumbtack/followers","following_url":"https://api.github.com/users/james-johnston-thumbtack/following{/other_user}","gists_url":"https://api.github.com/users/james-johnston-thumbtack/gists{/gist_id}","starred_url":"https://api.github.com/users/james-johnston-thumbtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-johnston-thumbtack/subscriptions","organizations_url":"https://api.github.com/users/james-johnston-thumbtack/orgs","repos_url":"https://api.github.com/users/james-johnston-thumbtack/repos","events_url":"https://api.github.com/users/james-johnston-thumbtack/events{/privacy}","received_events_url":"https://api.github.com/users/james-johnston-thumbtack/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"james-johnston-thumbtack"}}