{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-linux-extensions/issues/80","labels_url":"https://api.github.com/repos/Azure/azure-linux-extensions/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-linux-extensions/issues/80/comments","events_url":"https://api.github.com/repos/Azure/azure-linux-extensions/issues/80/events","html_url":"https://github.com/Azure/azure-linux-extensions/pull/80","id":122904406,"number":80,"title":"Fixing parsing error at mounts.py","user":{"login":"chan-alex","id":112162,"avatar_url":"https://avatars.githubusercontent.com/u/112162?v=3","gravatar_id":"","url":"https://api.github.com/users/chan-alex","html_url":"https://github.com/chan-alex","followers_url":"https://api.github.com/users/chan-alex/followers","following_url":"https://api.github.com/users/chan-alex/following{/other_user}","gists_url":"https://api.github.com/users/chan-alex/gists{/gist_id}","starred_url":"https://api.github.com/users/chan-alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chan-alex/subscriptions","organizations_url":"https://api.github.com/users/chan-alex/orgs","repos_url":"https://api.github.com/users/chan-alex/repos","events_url":"https://api.github.com/users/chan-alex/events{/privacy}","received_events_url":"https://api.github.com/users/chan-alex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-18T08:31:15Z","updated_at":"2016-01-07T05:10:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-linux-extensions/pulls/80","html_url":"https://github.com/Azure/azure-linux-extensions/pull/80","diff_url":"https://github.com/Azure/azure-linux-extensions/pull/80.diff","patch_url":"https://github.com/Azure/azure-linux-extensions/pull/80.patch"},"body":"Hi, \r\n\r\nThis patch fixes a bug in mounts.py.\r\n\r\nCurrently Mounts.__init__(self,logger)  parses output from lsblk incorrectly if there are space characters present in any of its output. This can occur if linux LVM is being used.\r\n\r\nAn example is this output from \"lsblk -l -n -o NAME,TYPE,FSTYPE,MOUNTPOINT\"\r\n\r\n\r\n       backups_vg-hk_static_backup_lv-real (dm-0)             lvm   ext4 \r\n\r\nWill result in a \"Mount\" object with the following fields:\r\n\r\n        self.name = backups_vg-hk_static_backup_lv-real\r\n        self.type = (dm-0) <---- this is wrong\r\n        self.fstype = lvm   <---- this is wrong\r\n        self.mount_point = ext4   <---- this is wrong\r\n\r\nThis inaccurate parsing will result in the following (detected) behavior:\r\n\r\n  1) All filesystem will be freezed during the backup (because self.mount_point is never null)\r\n  2) The waagent will hang if there are many of this misparsed lines (which happens if there are many LVM snapshots)\r\n\r\nThe patch fixes this by using the \"-p\" option from lsblk and parsing the output more accurately.\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/azure-linux-extensions/issues/comments/169552928","html_url":"https://github.com/Azure/azure-linux-extensions/pull/80#issuecomment-169552928","issue_url":"https://api.github.com/repos/Azure/azure-linux-extensions/issues/80","id":169552928,"user":{"login":"andyliuliming","id":339728,"avatar_url":"https://avatars.githubusercontent.com/u/339728?v=3","gravatar_id":"","url":"https://api.github.com/users/andyliuliming","html_url":"https://github.com/andyliuliming","followers_url":"https://api.github.com/users/andyliuliming/followers","following_url":"https://api.github.com/users/andyliuliming/following{/other_user}","gists_url":"https://api.github.com/users/andyliuliming/gists{/gist_id}","starred_url":"https://api.github.com/users/andyliuliming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyliuliming/subscriptions","organizations_url":"https://api.github.com/users/andyliuliming/orgs","repos_url":"https://api.github.com/users/andyliuliming/repos","events_url":"https://api.github.com/users/andyliuliming/events{/privacy}","received_events_url":"https://api.github.com/users/andyliuliming/received_events","type":"User","site_admin":false},"created_at":"2016-01-07T05:10:30Z","updated_at":"2016-01-07T05:10:30Z","body":"@chan-alex  thanks reporting this issue, we are fixing it now. thanks."}}