{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/86120121","pull_request_review_id":6793514,"id":86120121,"diff_hunk":"@@ -27,47 +27,104 @@ limitations under the License.\n \n #include \"../crypto/signature.hpp\"\n #include \"../util/logger.hpp\"\n-#include \"../model/transactions/abstract_transaction.hpp\"\n+#include \"../model/transaction.hpp\"\n \n-namespace consensus_event {\n-\n-struct ConsensusEvent {\n+#include \"../service/json_parse.hpp\"\n \n-    std::unique_ptr<abstract_transaction::AbstractTransaction> tx;\n-    std::unordered_map<std::string, std::string> txSignatures; // map of public keys→signatures\n-\n-    std::string merkleRootHash;\n-    std::unordered_map<std::string, std::string> merkleRootSignatures;\n+namespace consensus_event {\n \n+template<\n+        typename T, typename U,\n+        std::enable_if_t<\n+                std::is_base_of<transaction::Transaction<U>, T>::value,std::nullptr_t\n+        > = nullptr\n+>\n+class ConsensusEvent {\n+\n+\n+    struct eventSignature{\n+        std::string publicKey;\n+        std::string signature;\n+\n+        eventSignature(\n+            std::string pubKey,\n+            std::string sig\n+        ):\n+                publicKey(pubKey),\n+                signature(sig)\n+        {}\n+    };\n+    T tx;\n+    std::vector<eventSignature> eventSignatures;\n+\n+public:\n     unsigned long long order = 0;\n \n-    ConsensusEvent(std::unique_ptr<abstract_transaction::AbstractTransaction> atx):\n-        tx(std::move(atx))\n+    ConsensusEvent(T atx):","path":"core/consensus/consensus_event.hpp","position":48,"original_position":48,"commit_id":"6e677f14f00f445a9a5a76a4abf62b3873916905","original_commit_id":"6e677f14f00f445a9a5a76a4abf62b3873916905","user":{"login":"takemiyamakoto","id":20982317,"avatar_url":"https://avatars.githubusercontent.com/u/20982317?v=3","gravatar_id":"","url":"https://api.github.com/users/takemiyamakoto","html_url":"https://github.com/takemiyamakoto","followers_url":"https://api.github.com/users/takemiyamakoto/followers","following_url":"https://api.github.com/users/takemiyamakoto/following{/other_user}","gists_url":"https://api.github.com/users/takemiyamakoto/gists{/gist_id}","starred_url":"https://api.github.com/users/takemiyamakoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takemiyamakoto/subscriptions","organizations_url":"https://api.github.com/users/takemiyamakoto/orgs","repos_url":"https://api.github.com/users/takemiyamakoto/repos","events_url":"https://api.github.com/users/takemiyamakoto/events{/privacy}","received_events_url":"https://api.github.com/users/takemiyamakoto/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Class 'ConsensusEvent' has a constructor with 1 argument that is not explicit.](https://www.codacy.com/app/soramitsu/iroha/file/4345446875/issues/source?bid=3712491&fileBranchId=3870372#l63)","created_at":"2016-11-02T11:25:17Z","updated_at":"2016-11-02T11:25:17Z","html_url":"https://github.com/hyperledger/iroha/pull/52#discussion_r86120121","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/86120121"},"html":{"href":"https://github.com/hyperledger/iroha/pull/52#discussion_r86120121"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/52","id":91951536,"html_url":"https://github.com/hyperledger/iroha/pull/52","diff_url":"https://github.com/hyperledger/iroha/pull/52.diff","patch_url":"https://github.com/hyperledger/iroha/pull/52.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/52","number":52,"state":"open","locked":false,"title":"Develop","user":{"login":"takemiyamakoto","id":20982317,"avatar_url":"https://avatars.githubusercontent.com/u/20982317?v=3","gravatar_id":"","url":"https://api.github.com/users/takemiyamakoto","html_url":"https://github.com/takemiyamakoto","followers_url":"https://api.github.com/users/takemiyamakoto/followers","following_url":"https://api.github.com/users/takemiyamakoto/following{/other_user}","gists_url":"https://api.github.com/users/takemiyamakoto/gists{/gist_id}","starred_url":"https://api.github.com/users/takemiyamakoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takemiyamakoto/subscriptions","organizations_url":"https://api.github.com/users/takemiyamakoto/orgs","repos_url":"https://api.github.com/users/takemiyamakoto/repos","events_url":"https://api.github.com/users/takemiyamakoto/events{/privacy}","received_events_url":"https://api.github.com/users/takemiyamakoto/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-02T11:23:05Z","updated_at":"2016-11-02T11:25:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de41c3447769b2018bc8c2d1778b610e1aa027eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/52/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/52/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/52/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/6e677f14f00f445a9a5a76a4abf62b3873916905","head":{"label":"hyperledger:develop","ref":"develop","sha":"6e677f14f00f445a9a5a76a4abf62b3873916905","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2016-11-01T22:32:59Z","pushed_at":"2016-11-02T11:23:06Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":19954,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":29,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"d09d42463068389e6b8c43bb292d04c1f42aa0cd","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2016-11-01T22:32:59Z","pushed_at":"2016-11-02T11:23:06Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":19954,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/52"},"html":{"href":"https://github.com/hyperledger/iroha/pull/52"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/52"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/6e677f14f00f445a9a5a76a4abf62b3873916905"}}}}
{"actor":{"display_login":"takemiyamakoto"}}