{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2029","repository_url":"https://api.github.com/repos/magnumripper/JohnTheRipper","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2029/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2029/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2029/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/2029","id":132066492,"number":2029,"title":"Mask mode bug: Placeholder within brackets","user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/bug","name":"bug","color":"e11d21"},{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/Fixed%20-%20pending%20verify","name":"Fixed - pending verify","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/milestones/2","html_url":"https://github.com/magnumripper/JohnTheRipper/milestones/1.8.0-jumbo-2","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/milestones/2/labels","id":492145,"number":2,"title":"1.8.0-jumbo-2","description":"Please assign ALL issues which should be in J2 to this milestone, and lets push forward in fixing all of them.","creator":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":252,"state":"open","created_at":"2013-11-21T06:59:25Z","updated_at":"2016-02-09T07:22:22Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-02-08T06:46:44Z","updated_at":"2016-02-10T20:06:05Z","closed_at":null,"body":"[Solar  wrote](http://www.openwall.com/lists/john-users/2016/02/07/4):\r\n> magnum, Sayantan -\r\n\r\n> However, this appears buggy:\r\n```\r\n$ ./john --mask='[1?9]' --stdout\r\n1\r\n[\r\n]\r\n3p 0:00:00:00 100.00% (2016-02-08 02:50) 50.00p/s ]\r\n```\r\nand e.g. '[1?2]' is even worse.  Looks like we're (wrongly) expanding\r\n?digit (but not ?letter) even inside square brackets?  This looks like a\r\njumbo bug to me."},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/182555998","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/2029#issuecomment-182555998","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2029","id":182555998,"user":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars.githubusercontent.com/u/1270024?v=3","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T20:06:05Z","updated_at":"2016-02-10T20:06:05Z","body":"If you use MASK_DEBUG, things are pretty easy to follow along, and that is why I zero'd in on that function.  I 'know' what that function is doing (just replacing unknown replacements with known ones).  The problem appears to be that when we were doing that, we simply were jamming in a new [xxxxx] group block.  But that was wrong logic if we are INSIDE a group already.  In that case, we just leave the ? and digit alone.\r\n\r\nIf there are more test cases, that would be fine."}}