{"action":"created","comment":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments/91959686","pull_request_review_id":12468618,"id":91959686,"diff_hunk":"@@ -335,21 +336,21 @@ function DragAndDropTemplates(configuration) {\n         );\n     };\n \n-    var sidebarButtonTemplate = function(buttonClass, iconClass, buttonText, disabled, spinner) {\n-        if (spinner) {\n+    var sidebarButtonTemplate = function(buttonClass, iconClass, buttonText, options) {","path":"drag_and_drop_v2/public/js/drag_and_drop.js","position":30,"original_position":30,"commit_id":"aa6dfd5714240846c9925b0d2aeb25f10a1eb0e0","original_commit_id":"aa6dfd5714240846c9925b0d2aeb25f10a1eb0e0","user":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"body":"I like the small refactor here - changing it to take an options object rather than continually add more and more parameters.","created_at":"2016-12-12T14:46:31Z","updated_at":"2016-12-12T14:46:31Z","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/111#discussion_r91959686","pull_request_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments/91959686"},"html":{"href":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/111#discussion_r91959686"},"pull_request":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/111","id":97089811,"html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/111","diff_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/111.diff","patch_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/111.patch","issue_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/111","number":111,"state":"open","locked":false,"title":"Usability improvements for screen reader users","user":{"login":"mtyaka","id":32585,"avatar_url":"https://avatars.githubusercontent.com/u/32585?v=3","gravatar_id":"","url":"https://api.github.com/users/mtyaka","html_url":"https://github.com/mtyaka","followers_url":"https://api.github.com/users/mtyaka/followers","following_url":"https://api.github.com/users/mtyaka/following{/other_user}","gists_url":"https://api.github.com/users/mtyaka/gists{/gist_id}","starred_url":"https://api.github.com/users/mtyaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtyaka/subscriptions","organizations_url":"https://api.github.com/users/mtyaka/orgs","repos_url":"https://api.github.com/users/mtyaka/repos","events_url":"https://api.github.com/users/mtyaka/events{/privacy}","received_events_url":"https://api.github.com/users/mtyaka/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nImplements these usability improvements suggested by Mark S:\r\n\r\n- [TNL-6024](https://openedx.atlassian.net/browse/TNL-6024): Move Close button to beginning of dialog.\r\n- [TNL-6020](https://openedx.atlassian.net/browse/TNL-6020): Focus is not moved to feedback dialog box\r\n- [TNL-6028](https://openedx.atlassian.net/browse/TNL-6028): Add a method for moving focus back to the beginning of the problem after dropping and item,\r\n\r\n## JIRA Ticket\r\n\r\n- [SOL-2158](https://openedx.atlassian.net/browse/SOL-2158)\r\n\r\n## Sandbox URLs\r\n\r\nProvisioned with 2b6306cc6e19ed5169455923dd9db12819ebe749.\r\nYou might have to add a certificate security exception to be able to access the sandbox.\r\n\r\n- LMS: http://pr14132.sandbox.stage.opencraft.hosting/\r\n- Studio: http://studio-pr14132.sandbox.stage.opencraft.hosting/\r\n\r\n## Testing Instructions\r\n\r\n### Keyboard help dialog close button focus\r\n\r\n1. Open the Keyboard help dialog\r\n2. The close button should be focused automatically, hitting the RET key will close the dialog\r\n\r\n### Per item feedback close button\r\n\r\nThis only works in standard mode since in assessment mode feedback popup is not displayed when dropping an item.\r\n\r\n1. Pick an item that has a negative feedback message defined.\r\n2. Drop it onto a wrong zone.\r\n3. The feedback popup will be shown. Verify that the close button is automatically focused.\r\n4. Hitting the RET key closes the feedback popup and automatically moves focus back to the first item in the item bank.\r\n5. Repeat by dropping an item with a positive feedback message onto the correct zone.\r\n\r\n### Go to beginning button\r\n\r\n1. TAB through the items and zones until you reach the \"Go to Beginning\" button which is hidden by default.\r\n2. When it receives focus, the \"Go to Beginning\" button becomes visible.\r\n3. TAB again to move focus to next button - the \"Go to Beginning\" button should automatically become hidden again.\r\n4. Shift-TAB back to the \"Go to Beginning\" item to make it visible.\r\n5. Clicking (or pressing the RET key on) the button should move focus to the first item in the item bank and the button should become hidden.\r\n6. Verify that the button is not focusable when the problem is finished, user has no more attemtps, or there are no more items in the item bank.\r\n\r\n### Method for moving focus back to beginning after dropping an item\r\n\r\nIn standard mode this only works with items that have no per-item feedback message defined. In assessment mode it works with any item since feedback messages are not shown in assessment mode on drop.\r\n\r\n1. Pick an item and drop it onto desired zone.\r\n2. Press the TAB key. The focus should automatically move to the \"Go to Beginning\" button, no matter which zone you dropped the item into.\r\n\r\n## Author notes\r\n\r\nI placed the \"Go to Beginning\" button as the first item in the section that contains other buttons (Keyboard Help, Reset, Show Answer). The area is becoming somewhat crowded, but that should be fixed #110, which moves the \"Keyboard Help\" button out of that area to the beginning of the problem.\r\n\r\n![screen shot 2016-12-12 at 08 54 15](https://cloud.githubusercontent.com/assets/32585/21091760/98624d9e-c048-11e6-9a64-28904ab2a827.png)\r\n\r\n\r\n## Reviewers\r\n\r\n- [ ] OpenCraft: @haikuginger\r\n- [ ] TNL: TBD\r\n- [ ] a11y: TBD","created_at":"2016-12-08T09:52:22Z","updated_at":"2016-12-12T14:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8b65ea7320cb00055105994bebbe71e509333f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/111/commits","review_comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/111/comments","review_comment_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/111/comments","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/aa6dfd5714240846c9925b0d2aeb25f10a1eb0e0","head":{"label":"open-craft:mtyaka/usability-improvements","ref":"mtyaka/usability-improvements","sha":"aa6dfd5714240846c9925b0d2aeb25f10a1eb0e0","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":24362875,"name":"xblock-drag-and-drop-v2","full_name":"open-craft/xblock-drag-and-drop-v2","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/xblock-drag-and-drop-v2","description":"Drag and Drop v2 XBlock","fork":true,"url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2","forks_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/forks","keys_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/teams","hooks_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/hooks","issue_events_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/events","assignees_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/tags","blobs_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/languages","stargazers_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/stargazers","contributors_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/contributors","subscribers_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/subscribers","subscription_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/subscription","commits_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/merges","archive_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/downloads","issues_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/deployments","created_at":"2014-09-23T08:23:37Z","updated_at":"2016-08-11T19:47:53Z","pushed_at":"2016-12-11T02:09:16Z","git_url":"git://github.com/open-craft/xblock-drag-and-drop-v2.git","ssh_url":"git@github.com:open-craft/xblock-drag-and-drop-v2.git","clone_url":"https://github.com/open-craft/xblock-drag-and-drop-v2.git","svn_url":"https://github.com/open-craft/xblock-drag-and-drop-v2","homepage":"","size":1741,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edx-solutions:master","ref":"master","sha":"292c2baf77d25afd46694402693e9146ee3161f2","user":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":21356168,"name":"xblock-drag-and-drop-v2","full_name":"edx-solutions/xblock-drag-and-drop-v2","owner":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2","description":null,"fork":false,"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2","forks_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/forks","keys_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/teams","hooks_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/events","assignees_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/tags","blobs_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/subscription","commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/merges","archive_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/downloads","issues_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/deployments","created_at":"2014-06-30T15:30:30Z","updated_at":"2016-11-08T13:11:50Z","pushed_at":"2016-12-11T02:09:16Z","git_url":"git://github.com/edx-solutions/xblock-drag-and-drop-v2.git","ssh_url":"git@github.com:edx-solutions/xblock-drag-and-drop-v2.git","clone_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2.git","svn_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2","homepage":null,"size":3219,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":5,"forks":15,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/111"},"html":{"href":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/111"},"issue":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/111"},"comments":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/aa6dfd5714240846c9925b0d2aeb25f10a1eb0e0"}}}}
{"actor":{"display_login":"haikuginger"}}