{"action":"created","comment":{"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/comments/87314156","pull_request_review_id":7931304,"id":87314156,"diff_hunk":"@@ -97,13 +137,23 @@ class FiveBellsLedger extends EventEmitter2 {\n   }\n \n   * _connect () {\n-    const accountUri = this.account\n-\n     if (this.connection) {\n       debug('already connected, ignoring connection request')\n       return Promise.resolve(null)\n     }\n \n+    if (this.identifier) {\n+      const newOptions = yield webfingerToOptions(this.identifier)\n+\n+      this.credentials = Object.assign(","path":"src/lib/plugin.js","position":68,"original_position":68,"commit_id":"47e7947a1b42e69dc0c22250fd3c342ed18f7606","original_commit_id":"47e7947a1b42e69dc0c22250fd3c342ed18f7606","user":{"login":"justmoon","id":53233,"avatar_url":"https://avatars.githubusercontent.com/u/53233?v=3","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},"body":"`Object.assign` is destructive, so you usually want to pass an empty object as the first parameter. In this case, it's not causing any problems, but if somebody changes how `webfingerToOptions` works... suddenly you have a subtle bug. So I'd create a new object just to be safe.","created_at":"2016-11-10T01:28:24Z","updated_at":"2016-11-10T01:39:22Z","html_url":"https://github.com/interledgerjs/ilp-plugin-bells/pull/68#discussion_r87314156","pull_request_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/comments/87314156"},"html":{"href":"https://github.com/interledgerjs/ilp-plugin-bells/pull/68#discussion_r87314156"},"pull_request":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/68","id":93063220,"html_url":"https://github.com/interledgerjs/ilp-plugin-bells/pull/68","diff_url":"https://github.com/interledgerjs/ilp-plugin-bells/pull/68.diff","patch_url":"https://github.com/interledgerjs/ilp-plugin-bells/pull/68.patch","issue_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues/68","number":68,"state":"open","locked":false,"title":"Feat: allow login with webfinger indentifier","user":{"login":"sharafian","id":3362563,"avatar_url":"https://avatars.githubusercontent.com/u/3362563?v=3","gravatar_id":"","url":"https://api.github.com/users/sharafian","html_url":"https://github.com/sharafian","followers_url":"https://api.github.com/users/sharafian/followers","following_url":"https://api.github.com/users/sharafian/following{/other_user}","gists_url":"https://api.github.com/users/sharafian/gists{/gist_id}","starred_url":"https://api.github.com/users/sharafian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharafian/subscriptions","organizations_url":"https://api.github.com/users/sharafian/orgs","repos_url":"https://api.github.com/users/sharafian/repos","events_url":"https://api.github.com/users/sharafian/events{/privacy}","received_events_url":"https://api.github.com/users/sharafian/received_events","type":"User","site_admin":false},"body":"Instead of requiring `account`, `username`, and `password`, you can use a webfinger identifier in the form `username@ledger.example` (the same one used to send in the `ilp-kit`). The old credential format is still supported.","created_at":"2016-11-10T00:06:19Z","updated_at":"2016-11-10T01:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a28e15cbb3355f153de5b230d59f7a4a4b1ef99","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/68/commits","review_comments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/68/comments","review_comment_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues/68/comments","statuses_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/statuses/47e7947a1b42e69dc0c22250fd3c342ed18f7606","head":{"label":"interledgerjs:feat/bs-identifier","ref":"feat/bs-identifier","sha":"47e7947a1b42e69dc0c22250fd3c342ed18f7606","user":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":60421762,"name":"ilp-plugin-bells","full_name":"interledgerjs/ilp-plugin-bells","owner":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledgerjs/ilp-plugin-bells","description":"ILP Ledger plugin for five-bells-ledger","fork":false,"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells","forks_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/forks","keys_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/teams","hooks_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/hooks","issue_events_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues/events{/number}","events_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/events","assignees_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/assignees{/user}","branches_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/branches{/branch}","tags_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/tags","blobs_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/statuses/{sha}","languages_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/languages","stargazers_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/stargazers","contributors_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/contributors","subscribers_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/subscribers","subscription_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/subscription","commits_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/contents/{+path}","compare_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/merges","archive_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/downloads","issues_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues{/number}","pulls_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls{/number}","milestones_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/milestones{/number}","notifications_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/labels{/name}","releases_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/releases{/id}","deployments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/deployments","created_at":"2016-06-04T17:20:36Z","updated_at":"2016-10-28T18:38:33Z","pushed_at":"2016-11-10T00:36:44Z","git_url":"git://github.com/interledgerjs/ilp-plugin-bells.git","ssh_url":"git@github.com:interledgerjs/ilp-plugin-bells.git","clone_url":"https://github.com/interledgerjs/ilp-plugin-bells.git","svn_url":"https://github.com/interledgerjs/ilp-plugin-bells","homepage":null,"size":159,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"interledgerjs:master","ref":"master","sha":"f8272f9ab222bfd2f0ac5e3c1e658dc97e1efeda","user":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":60421762,"name":"ilp-plugin-bells","full_name":"interledgerjs/ilp-plugin-bells","owner":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledgerjs/ilp-plugin-bells","description":"ILP Ledger plugin for five-bells-ledger","fork":false,"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells","forks_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/forks","keys_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/teams","hooks_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/hooks","issue_events_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues/events{/number}","events_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/events","assignees_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/assignees{/user}","branches_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/branches{/branch}","tags_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/tags","blobs_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/statuses/{sha}","languages_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/languages","stargazers_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/stargazers","contributors_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/contributors","subscribers_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/subscribers","subscription_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/subscription","commits_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/contents/{+path}","compare_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/merges","archive_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/downloads","issues_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues{/number}","pulls_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls{/number}","milestones_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/milestones{/number}","notifications_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/labels{/name}","releases_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/releases{/id}","deployments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/deployments","created_at":"2016-06-04T17:20:36Z","updated_at":"2016-10-28T18:38:33Z","pushed_at":"2016-11-10T00:36:44Z","git_url":"git://github.com/interledgerjs/ilp-plugin-bells.git","ssh_url":"git@github.com:interledgerjs/ilp-plugin-bells.git","clone_url":"https://github.com/interledgerjs/ilp-plugin-bells.git","svn_url":"https://github.com/interledgerjs/ilp-plugin-bells","homepage":null,"size":159,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/68"},"html":{"href":"https://github.com/interledgerjs/ilp-plugin-bells/pull/68"},"issue":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues/68"},"comments":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-bells/statuses/47e7947a1b42e69dc0c22250fd3c342ed18f7606"}}}}
{"actor":{"display_login":"justmoon"}}