{"action":"created","comment":{"url":"https://api.github.com/repos/gilt/gilt-swig/pulls/comments/84940974","pull_request_review_id":5686527,"id":84940974,"diff_hunk":"@@ -0,0 +1,76 @@\n+#!/bin/sh\n+#\n+#  ________  ___       __   ___  ________\n+# |\\   ____\\|\\  \\     |\\  \\|\\  \\|\\   ____\\\n+# \\ \\  \\___|\\ \\  \\    \\ \\  \\ \\  \\ \\  \\___|\n+#  \\ \\_____  \\ \\  \\  __\\ \\  \\ \\  \\ \\  \\  ___\n+#   \\|____|\\  \\ \\  \\|\\__\\_\\  \\ \\  \\ \\  \\|\\  \\\n+#     ____\\_\\  \\ \\____________\\ \\__\\ \\_______\\\n+#    |\\_________\\|____________|\\|__|\\|_______|\n+#    \\|_________|\n+\n+#    It's delicious.\n+#    Brought to you by the fine folks at Gilt (http://github.com/gilt)\n+\n+# Set Desired Node version\n+# This script will install the required version if the user does not have this version or one greater already installed.\n+# comparison is done using major version number. Will not update to newer version of the same major version i.e. 4.1 --> 4.3\n+DESIRED_NODE_MAJOR_VERSION=6","path":"bin/check_node_version","position":18,"original_position":18,"commit_id":"48a70a0529bd64346cbefa22c1a845a28fb8e4f6","original_commit_id":"48a70a0529bd64346cbefa22c1a845a28fb8e4f6","user":{"login":"RoryH","id":374591,"avatar_url":"https://avatars.githubusercontent.com/u/374591?v=3","gravatar_id":"","url":"https://api.github.com/users/RoryH","html_url":"https://github.com/RoryH","followers_url":"https://api.github.com/users/RoryH/followers","following_url":"https://api.github.com/users/RoryH/following{/other_user}","gists_url":"https://api.github.com/users/RoryH/gists{/gist_id}","starred_url":"https://api.github.com/users/RoryH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoryH/subscriptions","organizations_url":"https://api.github.com/users/RoryH/orgs","repos_url":"https://api.github.com/users/RoryH/repos","events_url":"https://api.github.com/users/RoryH/events{/privacy}","received_events_url":"https://api.github.com/users/RoryH/received_events","type":"User","site_admin":false},"body":"I'd prefer that we manually control the desired version for now so as we can do controlled upgrades. Also the `nvm ls-remote` call would add extra latency on top of the latancy-tastic performance already 😢 ","created_at":"2016-10-25T16:13:28Z","updated_at":"2016-10-25T16:13:29Z","html_url":"https://github.com/gilt/gilt-swig/pull/34#discussion_r84940974","pull_request_url":"https://api.github.com/repos/gilt/gilt-swig/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/gilt/gilt-swig/pulls/comments/84940974"},"html":{"href":"https://github.com/gilt/gilt-swig/pull/34#discussion_r84940974"},"pull_request":{"href":"https://api.github.com/repos/gilt/gilt-swig/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/gilt/gilt-swig/pulls/34","id":90815554,"html_url":"https://github.com/gilt/gilt-swig/pull/34","diff_url":"https://github.com/gilt/gilt-swig/pull/34.diff","patch_url":"https://github.com/gilt/gilt-swig/pull/34.patch","issue_url":"https://api.github.com/repos/gilt/gilt-swig/issues/34","number":34,"state":"open","locked":false,"title":"Improve the functionality of Swig's Node version check","user":{"login":"RoryH","id":374591,"avatar_url":"https://avatars.githubusercontent.com/u/374591?v=3","gravatar_id":"","url":"https://api.github.com/users/RoryH","html_url":"https://github.com/RoryH","followers_url":"https://api.github.com/users/RoryH/followers","following_url":"https://api.github.com/users/RoryH/following{/other_user}","gists_url":"https://api.github.com/users/RoryH/gists{/gist_id}","starred_url":"https://api.github.com/users/RoryH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoryH/subscriptions","organizations_url":"https://api.github.com/users/RoryH/orgs","repos_url":"https://api.github.com/users/RoryH/repos","events_url":"https://api.github.com/users/RoryH/events{/privacy}","received_events_url":"https://api.github.com/users/RoryH/received_events","type":"User","site_admin":false},"body":"Previously Swig dictated a specific major version of Node, now we will allow the user to have a version of node greater than is required, assuming backward compatibility.\r\n\r\nAs this change also dictates >= version 6 of Node, it is dependent on the PR being merged and published here: https://github.com/gilt/gilt-swig-run/pull/6","created_at":"2016-10-25T14:09:54Z","updated_at":"2016-10-25T16:13:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dd95ac9974d5f348df05a10aedc2c1cba8c886d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gilt/gilt-swig/pulls/34/commits","review_comments_url":"https://api.github.com/repos/gilt/gilt-swig/pulls/34/comments","review_comment_url":"https://api.github.com/repos/gilt/gilt-swig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gilt/gilt-swig/issues/34/comments","statuses_url":"https://api.github.com/repos/gilt/gilt-swig/statuses/48a70a0529bd64346cbefa22c1a845a28fb8e4f6","head":{"label":"gilt:optimize-version-detection-for-nvm","ref":"optimize-version-detection-for-nvm","sha":"48a70a0529bd64346cbefa22c1a845a28fb8e4f6","user":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"repo":{"id":23161523,"name":"gilt-swig","full_name":"gilt/gilt-swig","owner":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gilt/gilt-swig","description":"A framework for using Gulp across many projects in large organizations.","fork":false,"url":"https://api.github.com/repos/gilt/gilt-swig","forks_url":"https://api.github.com/repos/gilt/gilt-swig/forks","keys_url":"https://api.github.com/repos/gilt/gilt-swig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilt/gilt-swig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilt/gilt-swig/teams","hooks_url":"https://api.github.com/repos/gilt/gilt-swig/hooks","issue_events_url":"https://api.github.com/repos/gilt/gilt-swig/issues/events{/number}","events_url":"https://api.github.com/repos/gilt/gilt-swig/events","assignees_url":"https://api.github.com/repos/gilt/gilt-swig/assignees{/user}","branches_url":"https://api.github.com/repos/gilt/gilt-swig/branches{/branch}","tags_url":"https://api.github.com/repos/gilt/gilt-swig/tags","blobs_url":"https://api.github.com/repos/gilt/gilt-swig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilt/gilt-swig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilt/gilt-swig/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilt/gilt-swig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilt/gilt-swig/statuses/{sha}","languages_url":"https://api.github.com/repos/gilt/gilt-swig/languages","stargazers_url":"https://api.github.com/repos/gilt/gilt-swig/stargazers","contributors_url":"https://api.github.com/repos/gilt/gilt-swig/contributors","subscribers_url":"https://api.github.com/repos/gilt/gilt-swig/subscribers","subscription_url":"https://api.github.com/repos/gilt/gilt-swig/subscription","commits_url":"https://api.github.com/repos/gilt/gilt-swig/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilt/gilt-swig/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilt/gilt-swig/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilt/gilt-swig/issues/comments{/number}","contents_url":"https://api.github.com/repos/gilt/gilt-swig/contents/{+path}","compare_url":"https://api.github.com/repos/gilt/gilt-swig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilt/gilt-swig/merges","archive_url":"https://api.github.com/repos/gilt/gilt-swig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilt/gilt-swig/downloads","issues_url":"https://api.github.com/repos/gilt/gilt-swig/issues{/number}","pulls_url":"https://api.github.com/repos/gilt/gilt-swig/pulls{/number}","milestones_url":"https://api.github.com/repos/gilt/gilt-swig/milestones{/number}","notifications_url":"https://api.github.com/repos/gilt/gilt-swig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilt/gilt-swig/labels{/name}","releases_url":"https://api.github.com/repos/gilt/gilt-swig/releases{/id}","deployments_url":"https://api.github.com/repos/gilt/gilt-swig/deployments","created_at":"2014-08-20T19:36:52Z","updated_at":"2016-09-05T13:42:11Z","pushed_at":"2016-10-25T15:59:40Z","git_url":"git://github.com/gilt/gilt-swig.git","ssh_url":"git@github.com:gilt/gilt-swig.git","clone_url":"https://github.com/gilt/gilt-swig.git","svn_url":"https://github.com/gilt/gilt-swig","homepage":"","size":403,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":9,"default_branch":"master"}},"base":{"label":"gilt:master","ref":"master","sha":"f554ee97022b5735fd56663c3dc11f2e2c7db913","user":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"repo":{"id":23161523,"name":"gilt-swig","full_name":"gilt/gilt-swig","owner":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gilt/gilt-swig","description":"A framework for using Gulp across many projects in large organizations.","fork":false,"url":"https://api.github.com/repos/gilt/gilt-swig","forks_url":"https://api.github.com/repos/gilt/gilt-swig/forks","keys_url":"https://api.github.com/repos/gilt/gilt-swig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilt/gilt-swig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilt/gilt-swig/teams","hooks_url":"https://api.github.com/repos/gilt/gilt-swig/hooks","issue_events_url":"https://api.github.com/repos/gilt/gilt-swig/issues/events{/number}","events_url":"https://api.github.com/repos/gilt/gilt-swig/events","assignees_url":"https://api.github.com/repos/gilt/gilt-swig/assignees{/user}","branches_url":"https://api.github.com/repos/gilt/gilt-swig/branches{/branch}","tags_url":"https://api.github.com/repos/gilt/gilt-swig/tags","blobs_url":"https://api.github.com/repos/gilt/gilt-swig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilt/gilt-swig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilt/gilt-swig/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilt/gilt-swig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilt/gilt-swig/statuses/{sha}","languages_url":"https://api.github.com/repos/gilt/gilt-swig/languages","stargazers_url":"https://api.github.com/repos/gilt/gilt-swig/stargazers","contributors_url":"https://api.github.com/repos/gilt/gilt-swig/contributors","subscribers_url":"https://api.github.com/repos/gilt/gilt-swig/subscribers","subscription_url":"https://api.github.com/repos/gilt/gilt-swig/subscription","commits_url":"https://api.github.com/repos/gilt/gilt-swig/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilt/gilt-swig/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilt/gilt-swig/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilt/gilt-swig/issues/comments{/number}","contents_url":"https://api.github.com/repos/gilt/gilt-swig/contents/{+path}","compare_url":"https://api.github.com/repos/gilt/gilt-swig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilt/gilt-swig/merges","archive_url":"https://api.github.com/repos/gilt/gilt-swig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilt/gilt-swig/downloads","issues_url":"https://api.github.com/repos/gilt/gilt-swig/issues{/number}","pulls_url":"https://api.github.com/repos/gilt/gilt-swig/pulls{/number}","milestones_url":"https://api.github.com/repos/gilt/gilt-swig/milestones{/number}","notifications_url":"https://api.github.com/repos/gilt/gilt-swig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilt/gilt-swig/labels{/name}","releases_url":"https://api.github.com/repos/gilt/gilt-swig/releases{/id}","deployments_url":"https://api.github.com/repos/gilt/gilt-swig/deployments","created_at":"2014-08-20T19:36:52Z","updated_at":"2016-09-05T13:42:11Z","pushed_at":"2016-10-25T15:59:40Z","git_url":"git://github.com/gilt/gilt-swig.git","ssh_url":"git@github.com:gilt/gilt-swig.git","clone_url":"https://github.com/gilt/gilt-swig.git","svn_url":"https://github.com/gilt/gilt-swig","homepage":"","size":403,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gilt/gilt-swig/pulls/34"},"html":{"href":"https://github.com/gilt/gilt-swig/pull/34"},"issue":{"href":"https://api.github.com/repos/gilt/gilt-swig/issues/34"},"comments":{"href":"https://api.github.com/repos/gilt/gilt-swig/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/gilt/gilt-swig/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/gilt/gilt-swig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gilt/gilt-swig/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/gilt/gilt-swig/statuses/48a70a0529bd64346cbefa22c1a845a28fb8e4f6"}}}}
{"actor":{"display_login":"RoryH"}}