{"action":"created","comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/59273232","id":59273232,"diff_hunk":"@@ -68,7 +68,14 @@ else\n       echo  \"$0: wav-to-duration is not on your path\"\n       exit 1;\n     fi\n-    if ! wav-to-duration scp:$data/wav.scp ark,t:$data/utt2dur 2>&1 | grep -v 'nonzero return status'; then\n+\n+    read_entire_file=false\n+    if [ `cat $data/wav.scp | sed -n '/sox.*speed/p' | wc -l` -gt 0 ]; then","path":"egs/wsj/s5/utils/data/get_utt2dur.sh","position":7,"original_position":7,"commit_id":"931f031ca715e9a281fed28a04e2295ba0355d16","original_commit_id":"931f031ca715e9a281fed28a04e2295ba0355d16","user":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"body":"I think a grep or grep -E command with output piped to /dev/null would be more elegant-- grep returns true if it matched at least one line. ","created_at":"2016-04-11T20:16:32Z","updated_at":"2016-04-11T20:16:32Z","html_url":"https://github.com/kaldi-asr/kaldi/pull/678#discussion_r59273232","pull_request_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/678","_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/59273232"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/678#discussion_r59273232"},"pull_request":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/678"}}},"pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/678","id":65899930,"html_url":"https://github.com/kaldi-asr/kaldi/pull/678","diff_url":"https://github.com/kaldi-asr/kaldi/pull/678.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/678.patch","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/678","number":678,"state":"open","locked":false,"title":"WIP: fix for utt2dur when applied on speed-pertubed data","user":{"login":"freewym","id":3506322,"avatar_url":"https://avatars.githubusercontent.com/u/3506322?v=3","gravatar_id":"","url":"https://api.github.com/users/freewym","html_url":"https://github.com/freewym","followers_url":"https://api.github.com/users/freewym/followers","following_url":"https://api.github.com/users/freewym/following{/other_user}","gists_url":"https://api.github.com/users/freewym/gists{/gist_id}","starred_url":"https://api.github.com/users/freewym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freewym/subscriptions","organizations_url":"https://api.github.com/users/freewym/orgs","repos_url":"https://api.github.com/users/freewym/repos","events_url":"https://api.github.com/users/freewym/events{/privacy}","received_events_url":"https://api.github.com/users/freewym/received_events","type":"User","site_admin":false},"body":"In order to fix the issue raised in #671 \r\n\r\nclass WaveInfoHolder and class WaveHolder do not have relationship in terms of inheritance. So currently I did two separate instantiations of SequentialTableReader in the \"if  else \" branches in featbin/wav-to-duration.cc, which duplicate some code. Please let me know if there are better solutions.\r\n\r\nYiming\r\n","created_at":"2016-04-10T03:36:12Z","updated_at":"2016-04-11T20:16:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf5cba51b4b841c77f2810c73a38be10a2fb9a29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/678/commits","review_comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/678/comments","review_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/678/comments","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/931f031ca715e9a281fed28a04e2295ba0355d16","head":{"label":"freewym:dur_fix","ref":"dur_fix","sha":"931f031ca715e9a281fed28a04e2295ba0355d16","user":{"login":"freewym","id":3506322,"avatar_url":"https://avatars.githubusercontent.com/u/3506322?v=3","gravatar_id":"","url":"https://api.github.com/users/freewym","html_url":"https://github.com/freewym","followers_url":"https://api.github.com/users/freewym/followers","following_url":"https://api.github.com/users/freewym/following{/other_user}","gists_url":"https://api.github.com/users/freewym/gists{/gist_id}","starred_url":"https://api.github.com/users/freewym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freewym/subscriptions","organizations_url":"https://api.github.com/users/freewym/orgs","repos_url":"https://api.github.com/users/freewym/repos","events_url":"https://api.github.com/users/freewym/events{/privacy}","received_events_url":"https://api.github.com/users/freewym/received_events","type":"User","site_admin":false},"repo":{"id":41891891,"name":"kaldi","full_name":"freewym/kaldi","owner":{"login":"freewym","id":3506322,"avatar_url":"https://avatars.githubusercontent.com/u/3506322?v=3","gravatar_id":"","url":"https://api.github.com/users/freewym","html_url":"https://github.com/freewym","followers_url":"https://api.github.com/users/freewym/followers","following_url":"https://api.github.com/users/freewym/following{/other_user}","gists_url":"https://api.github.com/users/freewym/gists{/gist_id}","starred_url":"https://api.github.com/users/freewym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freewym/subscriptions","organizations_url":"https://api.github.com/users/freewym/orgs","repos_url":"https://api.github.com/users/freewym/repos","events_url":"https://api.github.com/users/freewym/events{/privacy}","received_events_url":"https://api.github.com/users/freewym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freewym/kaldi","description":"This is now the official location of the Kaldi project.","fork":true,"url":"https://api.github.com/repos/freewym/kaldi","forks_url":"https://api.github.com/repos/freewym/kaldi/forks","keys_url":"https://api.github.com/repos/freewym/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freewym/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freewym/kaldi/teams","hooks_url":"https://api.github.com/repos/freewym/kaldi/hooks","issue_events_url":"https://api.github.com/repos/freewym/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/freewym/kaldi/events","assignees_url":"https://api.github.com/repos/freewym/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/freewym/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/freewym/kaldi/tags","blobs_url":"https://api.github.com/repos/freewym/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freewym/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freewym/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/freewym/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freewym/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/freewym/kaldi/languages","stargazers_url":"https://api.github.com/repos/freewym/kaldi/stargazers","contributors_url":"https://api.github.com/repos/freewym/kaldi/contributors","subscribers_url":"https://api.github.com/repos/freewym/kaldi/subscribers","subscription_url":"https://api.github.com/repos/freewym/kaldi/subscription","commits_url":"https://api.github.com/repos/freewym/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/freewym/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/freewym/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/freewym/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/freewym/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/freewym/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freewym/kaldi/merges","archive_url":"https://api.github.com/repos/freewym/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freewym/kaldi/downloads","issues_url":"https://api.github.com/repos/freewym/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/freewym/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/freewym/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/freewym/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freewym/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/freewym/kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/freewym/kaldi/deployments","created_at":"2015-09-04T01:18:16Z","updated_at":"2016-01-12T19:28:02Z","pushed_at":"2016-04-10T21:21:48Z","git_url":"git://github.com/freewym/kaldi.git","ssh_url":"git@github.com:freewym/kaldi.git","clone_url":"https://github.com/freewym/kaldi.git","svn_url":"https://github.com/freewym/kaldi","homepage":"http://kaldi-asr.org","size":101467,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kaldi-asr:master","ref":"master","sha":"b77e93095b81b9e93322b90e74d12b4469089e17","user":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"repo":{"id":34275045,"name":"kaldi","full_name":"kaldi-asr/kaldi","owner":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaldi-asr/kaldi","description":"This is now the official location of the Kaldi project.","fork":false,"url":"https://api.github.com/repos/kaldi-asr/kaldi","forks_url":"https://api.github.com/repos/kaldi-asr/kaldi/forks","keys_url":"https://api.github.com/repos/kaldi-asr/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaldi-asr/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaldi-asr/kaldi/teams","hooks_url":"https://api.github.com/repos/kaldi-asr/kaldi/hooks","issue_events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/events","assignees_url":"https://api.github.com/repos/kaldi-asr/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/kaldi-asr/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/tags","blobs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/kaldi-asr/kaldi/languages","stargazers_url":"https://api.github.com/repos/kaldi-asr/kaldi/stargazers","contributors_url":"https://api.github.com/repos/kaldi-asr/kaldi/contributors","subscribers_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscribers","subscription_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscription","commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaldi-asr/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/kaldi-asr/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaldi-asr/kaldi/merges","archive_url":"https://api.github.com/repos/kaldi-asr/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaldi-asr/kaldi/downloads","issues_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/kaldi-asr/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/kaldi-asr/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/kaldi-asr/kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/kaldi-asr/kaldi/deployments","created_at":"2015-04-20T17:23:16Z","updated_at":"2016-04-11T19:26:55Z","pushed_at":"2016-04-11T20:11:13Z","git_url":"git://github.com/kaldi-asr/kaldi.git","ssh_url":"git@github.com:kaldi-asr/kaldi.git","clone_url":"https://github.com/kaldi-asr/kaldi.git","svn_url":"https://github.com/kaldi-asr/kaldi","homepage":"http://kaldi-asr.org","size":115620,"stargazers_count":548,"watchers_count":548,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":336,"mirror_url":null,"open_issues_count":60,"forks":336,"open_issues":60,"watchers":548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/678"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/678"},"issue":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/678"},"comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/678/comments"},"review_comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/678/comments"},"review_comment":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/678/commits"},"statuses":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/931f031ca715e9a281fed28a04e2295ba0355d16"}}}}