{"action":"closed","issue":{"url":"https://api.github.com/repos/HPCE/hpce-2016-cw2/issues/21","repository_url":"https://api.github.com/repos/HPCE/hpce-2016-cw2","labels_url":"https://api.github.com/repos/HPCE/hpce-2016-cw2/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/HPCE/hpce-2016-cw2/issues/21/comments","events_url":"https://api.github.com/repos/HPCE/hpce-2016-cw2/issues/21/events","html_url":"https://github.com/HPCE/hpce-2016-cw2/issues/21","id":185463526,"number":21,"title":"Typo in readme.md section 5?","user":{"login":"JHertz5","id":22753502,"avatar_url":"https://avatars.githubusercontent.com/u/22753502?v=3","gravatar_id":"","url":"https://api.github.com/users/JHertz5","html_url":"https://github.com/JHertz5","followers_url":"https://api.github.com/users/JHertz5/followers","following_url":"https://api.github.com/users/JHertz5/following{/other_user}","gists_url":"https://api.github.com/users/JHertz5/gists{/gist_id}","starred_url":"https://api.github.com/users/JHertz5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JHertz5/subscriptions","organizations_url":"https://api.github.com/users/JHertz5/orgs","repos_url":"https://api.github.com/users/JHertz5/repos","events_url":"https://api.github.com/users/JHertz5/events{/privacy}","received_events_url":"https://api.github.com/users/JHertz5/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-26T17:48:58Z","updated_at":"2016-10-26T18:51:09Z","closed_at":"2016-10-26T18:51:09Z","body":"Hi\r\n\r\nI'm at the end of section 5, under the sub-heading \"Use tbb::task_group to parallelise the recursion\", and the document says to look for a section of code in our version of fast_fourier_transform.cpp that matches: \r\n```\r\nforwards_impl(m,wn*wn,pIn,2*sIn,pOut,sOut);\r\nforwards_impl(m,wn*wn,pIn+sIn,2*sIn,pOut+sOut*m,sOut);\r\n```\r\nAs far as I can tell, this does not exist in fast_fourier_transform.cpp in my private repository or the main repository, and there are too many inputs to work with `forwards_impl()` anyway. I assume that this part of the document is supposed to read:\r\n```\r\nrecurse(m,wn*wn,pIn,2*sIn,pOut,sOut);\r\nrecurse(m,wn*wn,pIn+sIn,2*sIn,pOut+sOut*m,sOut);\r\n```\r\n, which does exist in the code. Is that correct?"}}
{"actor":{"display_login":"m8pple"}}