{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/65896243","id":65896243,"diff_hunk":"@@ -2617,15 +2616,10 @@ public void run() {\n             }\n \n             // Get all the other port-forwarding mappings for this VM, and release all of those\n-            Set<PortMapping> mappings;\n-            if (portForwardManager != null) {\n-                mappings = Sets.newLinkedHashSet();\n-                mappings.addAll(portForwardManager.getLocationPublicIpIds(machine));\n-                if (nodeId != null) {\n-                    mappings.addAll(portForwardManager.getPortMappingWithPublicIpId(nodeId));\n-                }\n-            } else {\n-                mappings = ImmutableSet.of();\n+            Set<PortMapping> mappings = Sets.newLinkedHashSet();","path":"locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java","position":74,"original_position":74,"commit_id":"a166122426600ecbc0846ab9065ae4772bbcd196","original_commit_id":"a166122426600ecbc0846ab9065ae4772bbcd196","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"@grkvlt I don't follow - it's a `Set<PortMapping>`. What would you copy?","created_at":"2016-06-06T14:12:11Z","updated_at":"2016-06-06T14:12:11Z","html_url":"https://github.com/apache/brooklyn-server/pull/181#discussion_r65896243","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/65896243"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/181#discussion_r65896243"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/181","id":72519863,"html_url":"https://github.com/apache/brooklyn-server/pull/181","diff_url":"https://github.com/apache/brooklyn-server/pull/181.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/181.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/181","number":181,"state":"open","locked":false,"title":"Added a default PortForwardManager","user":{"login":"Graeme-Miller","id":3742990,"avatar_url":"https://avatars.githubusercontent.com/u/3742990?v=3","gravatar_id":"","url":"https://api.github.com/users/Graeme-Miller","html_url":"https://github.com/Graeme-Miller","followers_url":"https://api.github.com/users/Graeme-Miller/followers","following_url":"https://api.github.com/users/Graeme-Miller/following{/other_user}","gists_url":"https://api.github.com/users/Graeme-Miller/gists{/gist_id}","starred_url":"https://api.github.com/users/Graeme-Miller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graeme-Miller/subscriptions","organizations_url":"https://api.github.com/users/Graeme-Miller/orgs","repos_url":"https://api.github.com/users/Graeme-Miller/repos","events_url":"https://api.github.com/users/Graeme-Miller/events{/privacy}","received_events_url":"https://api.github.com/users/Graeme-Miller/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-03T14:53:06Z","updated_at":"2016-06-06T14:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a8e524ad8cd1fdddd93ac4e822ab510a7d95608","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/181/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/181/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/181/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/a166122426600ecbc0846ab9065ae4772bbcd196","head":{"label":"Graeme-Miller:default_pf_manager_2","ref":"default_pf_manager_2","sha":"a166122426600ecbc0846ab9065ae4772bbcd196","user":{"login":"Graeme-Miller","id":3742990,"avatar_url":"https://avatars.githubusercontent.com/u/3742990?v=3","gravatar_id":"","url":"https://api.github.com/users/Graeme-Miller","html_url":"https://github.com/Graeme-Miller","followers_url":"https://api.github.com/users/Graeme-Miller/followers","following_url":"https://api.github.com/users/Graeme-Miller/following{/other_user}","gists_url":"https://api.github.com/users/Graeme-Miller/gists{/gist_id}","starred_url":"https://api.github.com/users/Graeme-Miller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graeme-Miller/subscriptions","organizations_url":"https://api.github.com/users/Graeme-Miller/orgs","repos_url":"https://api.github.com/users/Graeme-Miller/repos","events_url":"https://api.github.com/users/Graeme-Miller/events{/privacy}","received_events_url":"https://api.github.com/users/Graeme-Miller/received_events","type":"User","site_admin":false},"repo":{"id":50934823,"name":"brooklyn-server","full_name":"Graeme-Miller/brooklyn-server","owner":{"login":"Graeme-Miller","id":3742990,"avatar_url":"https://avatars.githubusercontent.com/u/3742990?v=3","gravatar_id":"","url":"https://api.github.com/users/Graeme-Miller","html_url":"https://github.com/Graeme-Miller","followers_url":"https://api.github.com/users/Graeme-Miller/followers","following_url":"https://api.github.com/users/Graeme-Miller/following{/other_user}","gists_url":"https://api.github.com/users/Graeme-Miller/gists{/gist_id}","starred_url":"https://api.github.com/users/Graeme-Miller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graeme-Miller/subscriptions","organizations_url":"https://api.github.com/users/Graeme-Miller/orgs","repos_url":"https://api.github.com/users/Graeme-Miller/repos","events_url":"https://api.github.com/users/Graeme-Miller/events{/privacy}","received_events_url":"https://api.github.com/users/Graeme-Miller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Graeme-Miller/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server","forks_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/forks","keys_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/events","assignees_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/merges","archive_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/Graeme-Miller/brooklyn-server/deployments","created_at":"2016-02-02T16:35:43Z","updated_at":"2016-02-02T16:35:51Z","pushed_at":"2016-06-03T13:40:20Z","git_url":"git://github.com/Graeme-Miller/brooklyn-server.git","ssh_url":"git@github.com:Graeme-Miller/brooklyn-server.git","clone_url":"https://github.com/Graeme-Miller/brooklyn-server.git","svn_url":"https://github.com/Graeme-Miller/brooklyn-server","homepage":null,"size":29606,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"784e18fd106dd15084052a8ed71015450f13ca3a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-05-30T11:46:29Z","pushed_at":"2016-06-06T14:10:20Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":29895,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":21,"forks":32,"open_issues":21,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/181"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/181"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/181"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/a166122426600ecbc0846ab9065ae4772bbcd196"}}}}
{"actor":{"display_login":"aledsage"}}