{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/72145816","id":72145816,"diff_hunk":"@@ -111,7 +135,14 @@ class Scheduler {\n     if (CURRENT_TAG.validate(lastTagValue)) { return; }\n     let view = this._root;\n     if (view) {\n-      view.renderer.rerender(view);\n+      if (isEnabled('ember-glimmer-detect-two-way-reflush') ||\n+          isEnabled('ember-glimmer-allow-two-way-reflush')) {\n+        let shouldReflush;\n+        let callback = () => view.renderer.rerender(view, { alwaysRevalidate: true });\n+        do { shouldReflush = runInTransaction(callback); } while (shouldReflush);\n+      } else {\n+        view.renderer.rerender(view);\n+      }","path":"packages/ember-glimmer/lib/renderer.js","position":43,"original_position":43,"commit_id":"995286378171b41a91c9a3e63655dc45006cb9bd","original_commit_id":"995286378171b41a91c9a3e63655dc45006cb9bd","user":{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"body":"I *think* this change is not needed/wrong, need to check my branch to be sure. What's making me suspicious is that `view.renderer.rerender` doesn't actually take the `alwaysRevalidate` option, and it already does the `runInTransaction` stuff there, so this is probably a copy/paste/merge error","created_at":"2016-07-25T21:12:14Z","updated_at":"2016-07-25T21:12:14Z","html_url":"https://github.com/emberjs/ember.js/pull/13858#discussion_r72145816","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13858","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/72145816"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13858#discussion_r72145816"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13858"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13858","id":78518039,"html_url":"https://github.com/emberjs/ember.js/pull/13858","diff_url":"https://github.com/emberjs/ember.js/pull/13858.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13858.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13858","number":13858,"state":"open","locked":false,"title":"[Glimmer2] Two-way flush","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"body":"Depends on https://github.com/tildeio/glimmer/pull/223","created_at":"2016-07-22T18:13:32Z","updated_at":"2016-07-25T21:12:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"add8741751b94fbc7b6f9e8c05308d92e732a9fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13858/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13858/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13858/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/995286378171b41a91c9a3e63655dc45006cb9bd","head":{"label":"chadhietala:flushing","ref":"flushing","sha":"995286378171b41a91c9a3e63655dc45006cb9bd","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"repo":{"id":22746792,"name":"ember.js","full_name":"chadhietala/ember.js","owner":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadhietala/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/chadhietala/ember.js","forks_url":"https://api.github.com/repos/chadhietala/ember.js/forks","keys_url":"https://api.github.com/repos/chadhietala/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadhietala/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadhietala/ember.js/teams","hooks_url":"https://api.github.com/repos/chadhietala/ember.js/hooks","issue_events_url":"https://api.github.com/repos/chadhietala/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/chadhietala/ember.js/events","assignees_url":"https://api.github.com/repos/chadhietala/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/chadhietala/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/chadhietala/ember.js/tags","blobs_url":"https://api.github.com/repos/chadhietala/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadhietala/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadhietala/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadhietala/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadhietala/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chadhietala/ember.js/languages","stargazers_url":"https://api.github.com/repos/chadhietala/ember.js/stargazers","contributors_url":"https://api.github.com/repos/chadhietala/ember.js/contributors","subscribers_url":"https://api.github.com/repos/chadhietala/ember.js/subscribers","subscription_url":"https://api.github.com/repos/chadhietala/ember.js/subscription","commits_url":"https://api.github.com/repos/chadhietala/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadhietala/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadhietala/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadhietala/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadhietala/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/chadhietala/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadhietala/ember.js/merges","archive_url":"https://api.github.com/repos/chadhietala/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadhietala/ember.js/downloads","issues_url":"https://api.github.com/repos/chadhietala/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/chadhietala/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chadhietala/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chadhietala/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadhietala/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/chadhietala/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/chadhietala/ember.js/deployments","created_at":"2014-08-08T05:15:30Z","updated_at":"2014-12-11T18:19:26Z","pushed_at":"2016-07-25T18:20:36Z","git_url":"git://github.com/chadhietala/ember.js.git","ssh_url":"git@github.com:chadhietala/ember.js.git","clone_url":"https://github.com/chadhietala/ember.js.git","svn_url":"https://github.com/chadhietala/ember.js","homepage":"http://www.emberjs.com","size":31877,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"c63793d7b1ed5853c4272ba01098b7795da3a455","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-07-25T21:11:01Z","pushed_at":"2016-07-25T21:07:24Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":72806,"stargazers_count":16530,"watchers_count":16530,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3532,"mirror_url":null,"open_issues_count":248,"forks":3532,"open_issues":248,"watchers":16530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13858"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13858"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13858"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13858/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13858/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13858/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/995286378171b41a91c9a3e63655dc45006cb9bd"}}}}
{"actor":{"display_login":"chancancode"}}