{"action":"opened","issue":{"url":"https://api.github.com/repos/rsheets/rexcel/issues/15","repository_url":"https://api.github.com/repos/rsheets/rexcel","labels_url":"https://api.github.com/repos/rsheets/rexcel/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/rsheets/rexcel/issues/15/comments","events_url":"https://api.github.com/repos/rsheets/rexcel/issues/15/events","html_url":"https://github.com/rsheets/rexcel/issues/15","id":159739299,"number":15,"title":"Tests","user":{"login":"jennybc","id":599454,"avatar_url":"https://avatars.githubusercontent.com/u/599454?v=3","gravatar_id":"","url":"https://api.github.com/users/jennybc","html_url":"https://github.com/jennybc","followers_url":"https://api.github.com/users/jennybc/followers","following_url":"https://api.github.com/users/jennybc/following{/other_user}","gists_url":"https://api.github.com/users/jennybc/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybc/subscriptions","organizations_url":"https://api.github.com/users/jennybc/orgs","repos_url":"https://api.github.com/users/jennybc/repos","events_url":"https://api.github.com/users/jennybc/events{/privacy}","received_events_url":"https://api.github.com/users/jennybc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-10T23:04:01Z","updated_at":"2016-06-10T23:04:01Z","closed_at":null,"body":"@richfitz \r\n\r\nI have made progress on the tests, working towards the goal of passing R CMD check and succeeding on travis and appveyor.\r\n\r\nHappening in https://github.com/rsheets/rexcel/tree/pass-existing-tests.\r\n\r\nA couple things:\r\n\r\n  * I disabled the test re: an xlsx from Google Sheets. The tested function, `xlsx_internal_sheet_name()`, no longer seems to work the way it did when this test was created? It doesn't seem worth fixing, since we're about to do some fiddling with worksheet metadata anyway. Just commented out for now. We can bring it back online soon. I think we should make this information available in the linen object. And then consult it in this test.\r\n  * Do we have a policy re: testing and exported functions? Will we test unexported functions directly? If they are test-worthy are they export-worthy?\r\n  * I started using `rprojroot` which I hope you'll allow 😬. I really think it's a sane way to deal with directories relative to a project's root. However at the moment I use the default criterion to locate project root (it looks for a DESCRIPTION file), which works during interactive development and with `devtools::test()` but not during R CMD check. I've asked @krlmlr for thoughts on this. If he has no remedies, I will obviously handle paths differently.\r\n  * On my machine, two of `readxl`'s sheets are not equal to what we get with `rexcel`. Does that surprise you? Does that test pass for you right now?\r\n  * We are not even trying the comparison on 2 of `readxl`'s test sheets and the explanatory comment from you says something about Numbers. Is there something I should do with Excel to see if we can bring these online?\r\n  * Why is the helper file called `helper-jailbreakr.R`?"}}
{"actor":{"display_login":"jennybc"}}