{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/6538","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/6538/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/6538/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/6538/events","html_url":"https://github.com/eslint/eslint/pull/6538","id":162287008,"number":6538,"title":"Breaking: Error thrown/printed if no config found (fixes #5987)","user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/eslint/eslint/labels/breaking","name":"breaking","color":"e11d21"},{"url":"https://api.github.com/repos/eslint/eslint/labels/CLA:%20Valid","name":"CLA: Valid","color":"007700"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-06-25T15:47:07Z","updated_at":"2016-06-27T16:18:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/6538","html_url":"https://github.com/eslint/eslint/pull/6538","diff_url":"https://github.com/eslint/eslint/pull/6538.diff","patch_url":"https://github.com/eslint/eslint/pull/6538.patch"},"body":"Pulled in @IanVS' commit and added a few of my own to reorganize things a bit. I'm *fairly* sure this is ready, but let me know if I can organize things better (or if I should revert some of my last commits).\r\n\r\nOrganization stuff:\r\n* Created new sub-describe in tests for cases where local and personal config does not exist (throws unless no-eslintrc or unless there is at least one rule key/value pair)\r\n* Tried to make lib/config.js getLocalConfig() have fewer exit points. At the end is an if statement setting up the throw condition, and immediately after that is an unconditional return.\r\n\r\nThanks in advance for any feedback.\r\n\r\nPing @IanVS, @nzakas"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/228795826","html_url":"https://github.com/eslint/eslint/pull/6538#issuecomment-228795826","issue_url":"https://api.github.com/repos/eslint/eslint/issues/6538","id":228795826,"user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T16:18:48Z","updated_at":"2016-06-27T16:18:48Z","body":"My thoughts/planned next steps:\r\n\r\nRight now `getLocalConfig()` is violating single responsibility principle (assuming \"local config\" refers specifically to a config in the same or ancestor directory, as contrasted with \"personal config\" for the home directory case). It shouldn't be responsible for finding the personal config as well.\r\n\r\nI'm going to create an orchestration function that will hopefully make things easier to read overall. `getLocalConfig()` will focus on local/ancestor configs, `getPersonalConfig()` will probably be untouched, and the new orchestration function will basically be a big if/else to make things easier to read and less redundant."}}
{"actor":{"display_login":"platinumazure"}}