{"action":"created","issue":{"url":"https://api.github.com/repos/SciTools/iris/issues/1911","repository_url":"https://api.github.com/repos/SciTools/iris","labels_url":"https://api.github.com/repos/SciTools/iris/issues/1911/labels{/name}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/1911/comments","events_url":"https://api.github.com/repos/SciTools/iris/issues/1911/events","html_url":"https://github.com/SciTools/iris/pull/1911","id":126889584,"number":1911,"title":"Remove coord checks when adding/subtracting cubes","user":{"login":"rcomer","id":10599679,"avatar_url":"https://avatars.githubusercontent.com/u/10599679?v=3","gravatar_id":"","url":"https://api.github.com/users/rcomer","html_url":"https://github.com/rcomer","followers_url":"https://api.github.com/users/rcomer/followers","following_url":"https://api.github.com/users/rcomer/following{/other_user}","gists_url":"https://api.github.com/users/rcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/rcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcomer/subscriptions","organizations_url":"https://api.github.com/users/rcomer/orgs","repos_url":"https://api.github.com/users/rcomer/repos","events_url":"https://api.github.com/users/rcomer/events{/privacy}","received_events_url":"https://api.github.com/users/rcomer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2016-01-15T15:01:43Z","updated_at":"2016-04-21T13:29:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/1911","html_url":"https://github.com/SciTools/iris/pull/1911","diff_url":"https://github.com/SciTools/iris/pull/1911.diff","patch_url":"https://github.com/SciTools/iris/pull/1911.patch"},"body":"As discussed at #1887, this PR removes checks which are applied to coordinates before adding and subtracting cubes.  It makes these operations consistent with multiplication and division in terms of whether two cubes are compatible.\r\n\r\nHaving bypassed `_add_subtract_common`, scalar coords which exist on `cube` but not on `other` (\"ignorable\" coords) are no longer removed as part of the operation.  I think this is consistent with allowing the vector coords to differ (if I've understood correctly, `_binary_op_common` ignores all of the coords on `other`).  There are no unit tests to check whether the \"ignorable\" coords are removed, but I am getting a failure in the doctests for `userguide/cube_maths.rst` because a print out of a cube shows more metadata than previously.\r\n\r\nI have also removed the depreciated (since 0.8.0) keyword `ignore`.  It's not 100% clear what it did, but I guess it triggered the above mentioned removal of \"ignorable\" coords."},"comment":{"url":"https://api.github.com/repos/SciTools/iris/issues/comments/212919847","html_url":"https://github.com/SciTools/iris/pull/1911#issuecomment-212919847","issue_url":"https://api.github.com/repos/SciTools/iris/issues/1911","id":212919847,"user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T13:29:22Z","updated_at":"2016-04-21T13:29:22Z","body":"> Can I get a restart on my Travis TimedOutExceptions?\r\n\r\nDone."}}