{"action":"created","issue":{"url":"https://api.github.com/repos/pydata/pandas/issues/14214","repository_url":"https://api.github.com/repos/pydata/pandas","labels_url":"https://api.github.com/repos/pydata/pandas/issues/14214/labels{/name}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/14214/comments","events_url":"https://api.github.com/repos/pydata/pandas/issues/14214/events","html_url":"https://github.com/pydata/pandas/pull/14214","id":176724593,"number":14214,"title":"add check for infinity in __call__ of EngFormatter","user":{"login":"swfiua","id":251611,"avatar_url":"https://avatars.githubusercontent.com/u/251611?v=3","gravatar_id":"","url":"https://api.github.com/users/swfiua","html_url":"https://github.com/swfiua","followers_url":"https://api.github.com/users/swfiua/followers","following_url":"https://api.github.com/users/swfiua/following{/other_user}","gists_url":"https://api.github.com/users/swfiua/gists{/gist_id}","starred_url":"https://api.github.com/users/swfiua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swfiua/subscriptions","organizations_url":"https://api.github.com/users/swfiua/orgs","repos_url":"https://api.github.com/users/swfiua/repos","events_url":"https://api.github.com/users/swfiua/events{/privacy}","received_events_url":"https://api.github.com/users/swfiua/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pydata/pandas/labels/Bug","name":"Bug","color":"e10c02"},{"url":"https://api.github.com/repos/pydata/pandas/labels/Output-Formatting","name":"Output-Formatting","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/40","html_url":"https://github.com/pydata/pandas/milestones/0.19.0","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/40/labels","id":1639795,"number":40,"title":"0.19.0","description":"","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":691,"state":"open","created_at":"2016-03-11T21:24:45Z","updated_at":"2016-09-13T23:07:43Z","due_on":"2016-09-27T00:00:00Z","closed_at":null},"comments":4,"created_at":"2016-09-13T19:09:55Z","updated_at":"2016-09-13T23:18:07Z","closed_at":"2016-09-13T22:00:08Z","pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/14214","html_url":"https://github.com/pydata/pandas/pull/14214","diff_url":"https://github.com/pydata/pandas/pull/14214.diff","patch_url":"https://github.com/pydata/pandas/pull/14214.patch"},"body":"EngFormatter throws an exception if passed 'inf' as below.\r\n\r\nThis patch checks for infinity and just returns 'inf' in that case.  The fix is analagous to the recent fix for NaN: \r\n\r\nhttps://github.com/pydata/pandas/commit/d0734ba4d0f4c228110dc3974943ce4ec2adeea4\r\n\r\n```python\r\n\r\nimport pandas\r\nimport pandas.core.format as fmt\r\n\r\nef = fmt.EngFormatter()\r\nef(pandas.np.inf)\r\n \r\n...\r\n```\r\n---------------------------------------------------------------------------\r\nOverflowError                             Traceback (most recent call last)\r\n<ipython-input-17-c4aa659346ee> in <module>()\r\n      3 \r\n      4 ef = fmt.EngFormatter()\r\n----> 5 ef(pandas.np.inf)\r\n\r\n/usr/lib/python3/dist-packages/pandas/core/format.py in __call__(self, num)\r\n   2485 \r\n   2486         if dnum != 0:\r\n-> 2487             pow10 = decimal.Decimal(int(math.floor(dnum.log10() / 3) * 3))\r\n   2488         else:\r\n   2489             pow10 = decimal.Decimal(0)\r\n\r\nOverflowError: cannot convert Infinity to integer\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pydata/pandas/issues/comments/246856499","html_url":"https://github.com/pydata/pandas/pull/14214#issuecomment-246856499","issue_url":"https://api.github.com/repos/pydata/pandas/issues/14214","id":246856499,"user":{"login":"swfiua","id":251611,"avatar_url":"https://avatars.githubusercontent.com/u/251611?v=3","gravatar_id":"","url":"https://api.github.com/users/swfiua","html_url":"https://github.com/swfiua","followers_url":"https://api.github.com/users/swfiua/followers","following_url":"https://api.github.com/users/swfiua/following{/other_user}","gists_url":"https://api.github.com/users/swfiua/gists{/gist_id}","starred_url":"https://api.github.com/users/swfiua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swfiua/subscriptions","organizations_url":"https://api.github.com/users/swfiua/orgs","repos_url":"https://api.github.com/users/swfiua/repos","events_url":"https://api.github.com/users/swfiua/events{/privacy}","received_events_url":"https://api.github.com/users/swfiua/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T23:18:06Z","updated_at":"2016-09-13T23:18:06Z","body":"A pleasure.  Pandas is magic.\n\nOn 13 Sep 2016 19:00, \"Jeff Reback\" <notifications@github.com> wrote:\n\n> thanks!\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/pydata/pandas/pull/14214#issuecomment-246839271>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAPW25I6CyKwwpIw8sAuzo3JBXKDx9z-ks5qpxzzgaJpZM4J8CRc>\n> .\n>\n"}}
{"actor":{"display_login":"swfiua"}}