{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/318","repository_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp","labels_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/318/comments","events_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/318/events","html_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/318","id":160266921,"number":318,"title":"Update Instant_Articles_Post->_get_the_content() to validate $post->I…","user":{"login":"jeremyclarke","id":139995,"avatar_url":"https://avatars.githubusercontent.com/u/139995?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyclarke","html_url":"https://github.com/jeremyclarke","followers_url":"https://api.github.com/users/jeremyclarke/followers","following_url":"https://api.github.com/users/jeremyclarke/following{/other_user}","gists_url":"https://api.github.com/users/jeremyclarke/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyclarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyclarke/subscriptions","organizations_url":"https://api.github.com/users/jeremyclarke/orgs","repos_url":"https://api.github.com/users/jeremyclarke/repos","events_url":"https://api.github.com/users/jeremyclarke/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyclarke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/labels/Needs%20investigation","name":"Needs investigation","color":"b60205"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-14T19:43:13Z","updated_at":"2016-07-15T16:00:40Z","closed_at":"2016-07-15T16:00:40Z","pull_request":{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/pulls/318","html_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/318","diff_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/318.diff","patch_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/318.patch"},"body":"Fixes the following error which blocks saving contact forms in Contact Form 7:\r\n\r\n`Notice: Trying to get property of a non-object in /.../.../fb-instant-articles/class-instant-articles-post.php on line 299`\r\n\r\nWhatever this code is trying to do, I don't think it intends to throw an error when `$post->ID` is empty. \r\n\r\nThis edit replicates the old behavior but without throwing a notice:  If `$post` is undefined OR the ID doesn't match `$this->_post` then we run `setup_postdata()` to ensure globals reflect `$this->post_id`. \r\n\r\nThe undefined `$post` state was previously implied rather than specified, but I can't see how the old code would behave differently from this edit."},"comment":{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/comments/232993296","html_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/318#issuecomment-232993296","issue_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/318","id":232993296,"user":{"login":"jeremyclarke","id":139995,"avatar_url":"https://avatars.githubusercontent.com/u/139995?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyclarke","html_url":"https://github.com/jeremyclarke","followers_url":"https://api.github.com/users/jeremyclarke/followers","following_url":"https://api.github.com/users/jeremyclarke/following{/other_user}","gists_url":"https://api.github.com/users/jeremyclarke/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyclarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyclarke/subscriptions","organizations_url":"https://api.github.com/users/jeremyclarke/orgs","repos_url":"https://api.github.com/users/jeremyclarke/repos","events_url":"https://api.github.com/users/jeremyclarke/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyclarke/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T16:00:40Z","updated_at":"2016-07-15T16:00:40Z","body":"This was resolved separately by checking empty($post): \r\n\r\nhttps://github.com/Automattic/facebook-instant-articles-wp/blob/master/class-instant-articles-post.php#L299\r\n\r\nClosing. "}}
{"actor":{"display_login":"jeremyclarke"}}