{"action":"opened","number":37,"pull_request":{"url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls/37","id":74734390,"html_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pull/37","diff_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pull/37.diff","patch_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pull/37.patch","issue_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues/37","number":37,"state":"open","locked":false,"title":"Bugfix/page builder","user":{"login":"andreassiegelrfid","id":13197892,"avatar_url":"https://avatars.githubusercontent.com/u/13197892?v=3","gravatar_id":"","url":"https://api.github.com/users/andreassiegelrfid","html_url":"https://github.com/andreassiegelrfid","followers_url":"https://api.github.com/users/andreassiegelrfid/followers","following_url":"https://api.github.com/users/andreassiegelrfid/following{/other_user}","gists_url":"https://api.github.com/users/andreassiegelrfid/gists{/gist_id}","starred_url":"https://api.github.com/users/andreassiegelrfid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreassiegelrfid/subscriptions","organizations_url":"https://api.github.com/users/andreassiegelrfid/orgs","repos_url":"https://api.github.com/users/andreassiegelrfid/repos","events_url":"https://api.github.com/users/andreassiegelrfid/events{/privacy}","received_events_url":"https://api.github.com/users/andreassiegelrfid/received_events","type":"User","site_admin":false},"body":"### What changes were proposed in this pull request?\r\n\r\nFor some reason, the `@Builder` annotation didn't always work with generics, and IntelliJ kept showing compiler warnings, although the code actually compiled.\r\n\r\nThis wasn't the problem, but the tests didn't succeed:\r\n```\r\nTests in error: \r\n  PageTest.thatBuilderDataWorks:62 NoSuchMethod net.smartcosmos.dto.things.Page$...\r\n  PageTest.thatBuilderEmptyDataWorks:37 NoSuchMethod net.smartcosmos.dto.things....\r\n  PageTest.thatBuilderNullDataWorks:49 NoSuchMethod net.smartcosmos.dto.things.P...\r\n```\r\n\r\nTests were fine in IntelliJ, on the command line, with Travis, but Jenkins kept having test errors. So I de-lomboked the builder and made sure everything looks nice, i.e. fixed the builder's generic typing manually.\r\n\r\n### How is this patch documented?\r\n\r\nComment in the `Page` class.\r\n\r\n### How was this patch tested?\r\n\r\nUnit tests.\r\n\r\n#### Depends On\r\n\r\nNothing.","created_at":"2016-06-22T07:14:10Z","updated_at":"2016-06-22T07:14:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"jbauerrfid","id":7868978,"avatar_url":"https://avatars.githubusercontent.com/u/7868978?v=3","gravatar_id":"","url":"https://api.github.com/users/jbauerrfid","html_url":"https://github.com/jbauerrfid","followers_url":"https://api.github.com/users/jbauerrfid/followers","following_url":"https://api.github.com/users/jbauerrfid/following{/other_user}","gists_url":"https://api.github.com/users/jbauerrfid/gists{/gist_id}","starred_url":"https://api.github.com/users/jbauerrfid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbauerrfid/subscriptions","organizations_url":"https://api.github.com/users/jbauerrfid/orgs","repos_url":"https://api.github.com/users/jbauerrfid/repos","events_url":"https://api.github.com/users/jbauerrfid/events{/privacy}","received_events_url":"https://api.github.com/users/jbauerrfid/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls/37/commits","review_comments_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls/37/comments","review_comment_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues/37/comments","statuses_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/statuses/eea7c04929cc4750c1314663ea1e050f46909168","head":{"label":"SMARTRACTECHNOLOGY:bugfix/page_builder","ref":"bugfix/page_builder","sha":"eea7c04929cc4750c1314663ea1e050f46909168","user":{"login":"SMARTRACTECHNOLOGY","id":7856965,"avatar_url":"https://avatars.githubusercontent.com/u/7856965?v=3","gravatar_id":"","url":"https://api.github.com/users/SMARTRACTECHNOLOGY","html_url":"https://github.com/SMARTRACTECHNOLOGY","followers_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/followers","following_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/following{/other_user}","gists_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/gists{/gist_id}","starred_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/subscriptions","organizations_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/orgs","repos_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/repos","events_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/events{/privacy}","received_events_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/received_events","type":"Organization","site_admin":false},"repo":{"id":56861622,"name":"smartcosmos-dao-objects","full_name":"SMARTRACTECHNOLOGY/smartcosmos-dao-objects","owner":{"login":"SMARTRACTECHNOLOGY","id":7856965,"avatar_url":"https://avatars.githubusercontent.com/u/7856965?v=3","gravatar_id":"","url":"https://api.github.com/users/SMARTRACTECHNOLOGY","html_url":"https://github.com/SMARTRACTECHNOLOGY","followers_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/followers","following_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/following{/other_user}","gists_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/gists{/gist_id}","starred_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/subscriptions","organizations_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/orgs","repos_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/repos","events_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/events{/privacy}","received_events_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects","description":"DAO interfaces and DTO necessary to properly implement an Object RDAO.","fork":false,"url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects","forks_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/forks","keys_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/teams","hooks_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/hooks","issue_events_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues/events{/number}","events_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/events","assignees_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/assignees{/user}","branches_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/branches{/branch}","tags_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/tags","blobs_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/refs{/sha}","trees_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/statuses/{sha}","languages_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/languages","stargazers_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/stargazers","contributors_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/contributors","subscribers_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/subscribers","subscription_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/subscription","commits_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/commits{/sha}","git_commits_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/commits{/sha}","comments_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/comments{/number}","issue_comment_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues/comments{/number}","contents_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/contents/{+path}","compare_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/merges","archive_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/downloads","issues_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues{/number}","pulls_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls{/number}","milestones_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/milestones{/number}","notifications_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/labels{/name}","releases_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/releases{/id}","deployments_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/deployments","created_at":"2016-04-22T14:32:00Z","updated_at":"2016-04-22T14:39:02Z","pushed_at":"2016-06-22T07:06:35Z","git_url":"git://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects.git","ssh_url":"git@github.com:SMARTRACTECHNOLOGY/smartcosmos-dao-objects.git","clone_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects.git","svn_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SMARTRACTECHNOLOGY:master","ref":"master","sha":"432c101dd93b337d2a04368b08bbfce67b7a024e","user":{"login":"SMARTRACTECHNOLOGY","id":7856965,"avatar_url":"https://avatars.githubusercontent.com/u/7856965?v=3","gravatar_id":"","url":"https://api.github.com/users/SMARTRACTECHNOLOGY","html_url":"https://github.com/SMARTRACTECHNOLOGY","followers_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/followers","following_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/following{/other_user}","gists_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/gists{/gist_id}","starred_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/subscriptions","organizations_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/orgs","repos_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/repos","events_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/events{/privacy}","received_events_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/received_events","type":"Organization","site_admin":false},"repo":{"id":56861622,"name":"smartcosmos-dao-objects","full_name":"SMARTRACTECHNOLOGY/smartcosmos-dao-objects","owner":{"login":"SMARTRACTECHNOLOGY","id":7856965,"avatar_url":"https://avatars.githubusercontent.com/u/7856965?v=3","gravatar_id":"","url":"https://api.github.com/users/SMARTRACTECHNOLOGY","html_url":"https://github.com/SMARTRACTECHNOLOGY","followers_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/followers","following_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/following{/other_user}","gists_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/gists{/gist_id}","starred_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/subscriptions","organizations_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/orgs","repos_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/repos","events_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/events{/privacy}","received_events_url":"https://api.github.com/users/SMARTRACTECHNOLOGY/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects","description":"DAO interfaces and DTO necessary to properly implement an Object RDAO.","fork":false,"url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects","forks_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/forks","keys_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/teams","hooks_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/hooks","issue_events_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues/events{/number}","events_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/events","assignees_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/assignees{/user}","branches_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/branches{/branch}","tags_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/tags","blobs_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/refs{/sha}","trees_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/statuses/{sha}","languages_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/languages","stargazers_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/stargazers","contributors_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/contributors","subscribers_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/subscribers","subscription_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/subscription","commits_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/commits{/sha}","git_commits_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/git/commits{/sha}","comments_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/comments{/number}","issue_comment_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues/comments{/number}","contents_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/contents/{+path}","compare_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/merges","archive_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/downloads","issues_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues{/number}","pulls_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls{/number}","milestones_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/milestones{/number}","notifications_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/labels{/name}","releases_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/releases{/id}","deployments_url":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/deployments","created_at":"2016-04-22T14:32:00Z","updated_at":"2016-04-22T14:39:02Z","pushed_at":"2016-06-22T07:06:35Z","git_url":"git://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects.git","ssh_url":"git@github.com:SMARTRACTECHNOLOGY/smartcosmos-dao-objects.git","clone_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects.git","svn_url":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls/37"},"html":{"href":"https://github.com/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pull/37"},"issue":{"href":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues/37"},"comments":{"href":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/SMARTRACTECHNOLOGY/smartcosmos-dao-objects/statuses/eea7c04929cc4750c1314663ea1e050f46909168"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":63,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"andreassiegelrfid"}}