{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/93545921","pull_request_review_id":14075088,"id":93545921,"diff_hunk":"@@ -147,6 +147,14 @@ lane :verify_docs do\n   end\n end\n \n+desc \"Generates the actions.md that will get used on https://docs.fastlane.tools\"\n+desc \"This will NOT also automatically submit a pull request to fastlane/docs\"\n+desc \"This SHOULD only be used for testing changes to the docs\"\n+lane :generate_docs do","path":"fastlane/Fastfile","position":7,"original_position":7,"commit_id":"2c279d8a1bc584df5d38c80c05de1b6f2db0f982","original_commit_id":"2c279d8a1bc584df5d38c80c05de1b6f2db0f982","user":{"login":"milch","id":279407,"avatar_url":"https://avatars.githubusercontent.com/u/279407?v=3","gravatar_id":"","url":"https://api.github.com/users/milch","html_url":"https://github.com/milch","followers_url":"https://api.github.com/users/milch/followers","following_url":"https://api.github.com/users/milch/following{/other_user}","gists_url":"https://api.github.com/users/milch/gists{/gist_id}","starred_url":"https://api.github.com/users/milch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milch/subscriptions","organizations_url":"https://api.github.com/users/milch/orgs","repos_url":"https://api.github.com/users/milch/repos","events_url":"https://api.github.com/users/milch/events{/privacy}","received_events_url":"https://api.github.com/users/milch/received_events","type":"User","site_admin":false},"body":"In accordance with the description above the lane, please rename this to `test_generate_docs` ","created_at":"2016-12-22T00:13:16Z","updated_at":"2016-12-22T00:13:52Z","html_url":"https://github.com/fastlane/fastlane/pull/7609#discussion_r93545921","pull_request_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7609","_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/93545921"},"html":{"href":"https://github.com/fastlane/fastlane/pull/7609#discussion_r93545921"},"pull_request":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7609"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/7609","id":98845996,"html_url":"https://github.com/fastlane/fastlane/pull/7609","diff_url":"https://github.com/fastlane/fastlane/pull/7609.diff","patch_url":"https://github.com/fastlane/fastlane/pull/7609.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/7609","number":7609,"state":"open","locked":false,"title":"Deprecated actions will display deprecated notes in actions list, action info, while running, and in docs","user":{"login":"joshdholtz","id":401294,"avatar_url":"https://avatars.githubusercontent.com/u/401294?v=3","gravatar_id":"","url":"https://api.github.com/users/joshdholtz","html_url":"https://github.com/joshdholtz","followers_url":"https://api.github.com/users/joshdholtz/followers","following_url":"https://api.github.com/users/joshdholtz/following{/other_user}","gists_url":"https://api.github.com/users/joshdholtz/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdholtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdholtz/subscriptions","organizations_url":"https://api.github.com/users/joshdholtz/orgs","repos_url":"https://api.github.com/users/joshdholtz/repos","events_url":"https://api.github.com/users/joshdholtz/events{/privacy}","received_events_url":"https://api.github.com/users/joshdholtz/received_events","type":"User","site_admin":false},"body":"- [x] Show deprecated actions in `fastlane actions`\r\n- [x] Show deprecated action in `fastlane action <name>` \r\n- [x] Show deprecated action while executing a lane\r\n- [x] Show deprecated actions in docs\r\n- [x] add notes to `notify`\r\n- [x] add notes to `update_project_code_signing`\r\n- [x] deprecate `ipa`\r\n- [x] deprecate and add notes to `s3`\r\n- [x] deprecate and add notes to `upload_symbols_to_sentry`\r\n\r\n## How things currently work...\r\n\r\n**deprecated** actions have lived in `fastlane` already but have never been _really_ shown or notified to the user in a consistent way. And with the introduction of plugins, some actions _should_ be migrating away from being inside of `fastlane`. The two currently deprecated actions simply have some `UI.important` and `UI.message` calls in them to notify the user but these do not stand out enough and also don't show anything to the user when the action is queried with `fastlane action <name>`.\r\n\r\n`notify` and `update_project_code_signing` have been define by the following...\r\n```rb\r\ndef self.category\r\n  :deprecated\r\nend\r\n```\r\n\r\n## How things WILL work...\r\nThis PR will introduce `deprecated_notes` for an action which will inform the user (in a consistent manner) on how to migrate off of these **deprecated** actions.\r\n\r\n### Notify (use a different internal action instead)\r\n```rb\r\ndef self.category\r\n  :deprecated\r\nend\r\n\r\ndef self.deprecated_notes\r\n  \"It's recommended to use the new 'notification' method instead of 'notify'\"\r\nend\r\n```\r\n\r\n### S3 (install a plugin)\r\n```rb\r\ndef self.category\r\n  :deprecated\r\nend\r\n\r\ndef self.deprecated_notes\r\n  \"Please use the `aws_s3` plugin instead.\\n\" +\r\n  \"Install using `fastlane add_plugin aws_s3`.\"\r\nend\r\n```\r\n\r\n## Screenshots\r\n\r\n### fastlane actions\r\n<img width=\"1086\" alt=\"screen shot 2016-12-20 at 5 25 46 pm\" src=\"https://cloud.githubusercontent.com/assets/401294/21371873/5fa15198-c6d9-11e6-93f8-a69622d2da1b.png\">\r\n\r\n### fastlane action (without `deprecated_notes`)\r\n<img width=\"533\" alt=\"screen shot 2016-12-20 at 5 22 51 pm\" src=\"https://cloud.githubusercontent.com/assets/401294/21371858/407b63a8-c6d9-11e6-8a49-ce884c560bf5.png\">\r\n\r\n### fastlane action name (with `deprecated_notes`)\r\n<img width=\"554\" alt=\"screen shot 2016-12-20 at 5 23 03 pm\" src=\"https://cloud.githubusercontent.com/assets/401294/21371857/407b852c-c6d9-11e6-8499-a0c09f938298.png\">\r\n\r\n### fastlane (while running a lane)\r\n<img width=\"635\" alt=\"screen shot 2016-12-20 at 5 24 08 pm\" src=\"https://cloud.githubusercontent.com/assets/401294/21371856/407a0968-c6d9-11e6-9d1a-f3a2d48a5104.png\">\r\n\r\n\r\n\r\n","created_at":"2016-12-20T23:34:31Z","updated_at":"2016-12-22T00:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"700f5b0a59cd72c1cf0df9b4ed7b7af6bc5458a5","assignee":{"login":"joshdholtz","id":401294,"avatar_url":"https://avatars.githubusercontent.com/u/401294?v=3","gravatar_id":"","url":"https://api.github.com/users/joshdholtz","html_url":"https://github.com/joshdholtz","followers_url":"https://api.github.com/users/joshdholtz/followers","following_url":"https://api.github.com/users/joshdholtz/following{/other_user}","gists_url":"https://api.github.com/users/joshdholtz/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdholtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdholtz/subscriptions","organizations_url":"https://api.github.com/users/joshdholtz/orgs","repos_url":"https://api.github.com/users/joshdholtz/repos","events_url":"https://api.github.com/users/joshdholtz/events{/privacy}","received_events_url":"https://api.github.com/users/joshdholtz/received_events","type":"User","site_admin":false},"assignees":[{"login":"joshdholtz","id":401294,"avatar_url":"https://avatars.githubusercontent.com/u/401294?v=3","gravatar_id":"","url":"https://api.github.com/users/joshdholtz","html_url":"https://github.com/joshdholtz","followers_url":"https://api.github.com/users/joshdholtz/followers","following_url":"https://api.github.com/users/joshdholtz/following{/other_user}","gists_url":"https://api.github.com/users/joshdholtz/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdholtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdholtz/subscriptions","organizations_url":"https://api.github.com/users/joshdholtz/orgs","repos_url":"https://api.github.com/users/joshdholtz/repos","events_url":"https://api.github.com/users/joshdholtz/events{/privacy}","received_events_url":"https://api.github.com/users/joshdholtz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7609/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7609/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/7609/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/2c279d8a1bc584df5d38c80c05de1b6f2db0f982","head":{"label":"joshdholtz:deprecated-actions","ref":"deprecated-actions","sha":"2c279d8a1bc584df5d38c80c05de1b6f2db0f982","user":{"login":"joshdholtz","id":401294,"avatar_url":"https://avatars.githubusercontent.com/u/401294?v=3","gravatar_id":"","url":"https://api.github.com/users/joshdholtz","html_url":"https://github.com/joshdholtz","followers_url":"https://api.github.com/users/joshdholtz/followers","following_url":"https://api.github.com/users/joshdholtz/following{/other_user}","gists_url":"https://api.github.com/users/joshdholtz/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdholtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdholtz/subscriptions","organizations_url":"https://api.github.com/users/joshdholtz/orgs","repos_url":"https://api.github.com/users/joshdholtz/repos","events_url":"https://api.github.com/users/joshdholtz/events{/privacy}","received_events_url":"https://api.github.com/users/joshdholtz/received_events","type":"User","site_admin":false},"repo":{"id":53360747,"name":"fastlane","full_name":"joshdholtz/fastlane","owner":{"login":"joshdholtz","id":401294,"avatar_url":"https://avatars.githubusercontent.com/u/401294?v=3","gravatar_id":"","url":"https://api.github.com/users/joshdholtz","html_url":"https://github.com/joshdholtz","followers_url":"https://api.github.com/users/joshdholtz/followers","following_url":"https://api.github.com/users/joshdholtz/following{/other_user}","gists_url":"https://api.github.com/users/joshdholtz/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdholtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdholtz/subscriptions","organizations_url":"https://api.github.com/users/joshdholtz/orgs","repos_url":"https://api.github.com/users/joshdholtz/repos","events_url":"https://api.github.com/users/joshdholtz/events{/privacy}","received_events_url":"https://api.github.com/users/joshdholtz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshdholtz/fastlane","description":"Connect all iOS deployment tools into one streamlined workflow","fork":true,"url":"https://api.github.com/repos/joshdholtz/fastlane","forks_url":"https://api.github.com/repos/joshdholtz/fastlane/forks","keys_url":"https://api.github.com/repos/joshdholtz/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshdholtz/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshdholtz/fastlane/teams","hooks_url":"https://api.github.com/repos/joshdholtz/fastlane/hooks","issue_events_url":"https://api.github.com/repos/joshdholtz/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/joshdholtz/fastlane/events","assignees_url":"https://api.github.com/repos/joshdholtz/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/joshdholtz/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/joshdholtz/fastlane/tags","blobs_url":"https://api.github.com/repos/joshdholtz/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshdholtz/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshdholtz/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshdholtz/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshdholtz/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/joshdholtz/fastlane/languages","stargazers_url":"https://api.github.com/repos/joshdholtz/fastlane/stargazers","contributors_url":"https://api.github.com/repos/joshdholtz/fastlane/contributors","subscribers_url":"https://api.github.com/repos/joshdholtz/fastlane/subscribers","subscription_url":"https://api.github.com/repos/joshdholtz/fastlane/subscription","commits_url":"https://api.github.com/repos/joshdholtz/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshdholtz/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshdholtz/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshdholtz/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshdholtz/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/joshdholtz/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshdholtz/fastlane/merges","archive_url":"https://api.github.com/repos/joshdholtz/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshdholtz/fastlane/downloads","issues_url":"https://api.github.com/repos/joshdholtz/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/joshdholtz/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/joshdholtz/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/joshdholtz/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshdholtz/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/joshdholtz/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/joshdholtz/fastlane/deployments","created_at":"2016-03-07T21:33:09Z","updated_at":"2016-03-07T21:33:12Z","pushed_at":"2016-12-21T23:03:24Z","git_url":"git://github.com/joshdholtz/fastlane.git","ssh_url":"git@github.com:joshdholtz/fastlane.git","clone_url":"https://github.com/joshdholtz/fastlane.git","svn_url":"https://github.com/joshdholtz/fastlane","homepage":"https://fastlane.tools","size":53537,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"14d2fc81d7dd6cc0285068ed30c202c098a88b27","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2016-12-21T21:28:14Z","pushed_at":"2016-12-21T23:57:18Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":54265,"stargazers_count":12991,"watchers_count":12991,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1972,"mirror_url":null,"open_issues_count":385,"forks":1972,"open_issues":385,"watchers":12991,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7609"},"html":{"href":"https://github.com/fastlane/fastlane/pull/7609"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/7609"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/7609/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7609/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7609/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/2c279d8a1bc584df5d38c80c05de1b6f2db0f982"}}}}
{"actor":{"display_login":"milch"}}