{"action":"created","issue":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/630","repository_url":"https://api.github.com/repos/BuoyantIO/linkerd","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/630/comments","events_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/630/events","html_url":"https://github.com/BuoyantIO/linkerd/pull/630","id":175419964,"number":630,"title":"Graceful shutdown","user":{"login":"erdody","id":215270,"avatar_url":"https://avatars.githubusercontent.com/u/215270?v=3","gravatar_id":"","url":"https://api.github.com/users/erdody","html_url":"https://github.com/erdody","followers_url":"https://api.github.com/users/erdody/followers","following_url":"https://api.github.com/users/erdody/following{/other_user}","gists_url":"https://api.github.com/users/erdody/gists{/gist_id}","starred_url":"https://api.github.com/users/erdody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdody/subscriptions","organizations_url":"https://api.github.com/users/erdody/orgs","repos_url":"https://api.github.com/users/erdody/repos","events_url":"https://api.github.com/users/erdody/events{/privacy}","received_events_url":"https://api.github.com/users/erdody/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-07T06:04:25Z","updated_at":"2016-09-07T19:50:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/630","html_url":"https://github.com/BuoyantIO/linkerd/pull/630","diff_url":"https://github.com/BuoyantIO/linkerd/pull/630.diff","patch_url":"https://github.com/BuoyantIO/linkerd/pull/630.patch"},"body":"Goal: add a way to handle termination signals and gracefully close routers, announcers, etc.\r\n\r\nThere's still a pre-existing issue (reproducible if you use /admin/shutdown) that prevents closing log lines from showing up."},"comment":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/comments/245395845","html_url":"https://github.com/BuoyantIO/linkerd/pull/630#issuecomment-245395845","issue_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/630","id":245395845,"user":{"login":"erdody","id":215270,"avatar_url":"https://avatars.githubusercontent.com/u/215270?v=3","gravatar_id":"","url":"https://api.github.com/users/erdody","html_url":"https://github.com/erdody","followers_url":"https://api.github.com/users/erdody/followers","following_url":"https://api.github.com/users/erdody/following{/other_user}","gists_url":"https://api.github.com/users/erdody/gists{/gist_id}","starred_url":"https://api.github.com/users/erdody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdody/subscriptions","organizations_url":"https://api.github.com/users/erdody/orgs","repos_url":"https://api.github.com/users/erdody/repos","events_url":"https://api.github.com/users/erdody/events{/privacy}","received_events_url":"https://api.github.com/users/erdody/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T19:50:08Z","updated_at":"2016-09-07T19:50:08Z","body":"Thanks @olix0r for the context.\r\nCan you elaborate on what exactly is unreliable? Is it the triggering of the hook or the execution?\r\nMy main goal is to have a way to cleanly shutdown on a SIGTERM signal. Of course, SIGKILL won't be captured and there's not much you can or want to do about it. \r\nSpecific example: I want to use linkerd as an in-container sidecar. On shutdown, init frameworks (s6-overlay / phusion) will kill all side process and wait for a graceful termination. I can write a specific shutdown script that calls /admin/shutdown and then waits for the process to die, but I\r\n'd rather move that logic to the process. \r\n"}}
{"actor":{"display_login":"erdody"}}