{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/59557654","id":59557654,"diff_hunk":"@@ -121,6 +132,11 @@ define('video/09_events_plugin.js', [], function() {\n             return player ? player.currentTime : 0;\n         },\n \n+        getCurrentLanguage: function() {\n+            var player = this.state.lang;","path":"common/lib/xmodule/xmodule/js/src/video/09_events_plugin.js","position":54,"original_position":54,"commit_id":"bd089507a776d5c3afee6d3ea82802b5b87689f3","original_commit_id":"bd089507a776d5c3afee6d3ea82802b5b87689f3","user":{"login":"clytwynec","id":3818105,"avatar_url":"https://avatars.githubusercontent.com/u/3818105?v=3","gravatar_id":"","url":"https://api.github.com/users/clytwynec","html_url":"https://github.com/clytwynec","followers_url":"https://api.github.com/users/clytwynec/followers","following_url":"https://api.github.com/users/clytwynec/following{/other_user}","gists_url":"https://api.github.com/users/clytwynec/gists{/gist_id}","starred_url":"https://api.github.com/users/clytwynec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clytwynec/subscriptions","organizations_url":"https://api.github.com/users/clytwynec/orgs","repos_url":"https://api.github.com/users/clytwynec/repos","events_url":"https://api.github.com/users/clytwynec/events{/privacy}","received_events_url":"https://api.github.com/users/clytwynec/received_events","type":"User","site_admin":false},"body":"Yea, I think it make sense to call this something like  'language'.  In the `getCurrentTime` method, `player` is actually a video player object.  Here, `player` is a language code.","created_at":"2016-04-13T14:28:30Z","updated_at":"2016-04-13T14:28:30Z","html_url":"https://github.com/edx/edx-platform/pull/12125#discussion_r59557654","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/12125","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/59557654"},"html":{"href":"https://github.com/edx/edx-platform/pull/12125#discussion_r59557654"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12125"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12125","id":66205082,"html_url":"https://github.com/edx/edx-platform/pull/12125","diff_url":"https://github.com/edx/edx-platform/pull/12125.diff","patch_url":"https://github.com/edx/edx-platform/pull/12125.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12125","number":12125,"state":"open","locked":false,"title":"AC-380 ensuring proper event tracking with updated video player","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"body":"# [AC-380](https://openedx.atlassian.net/browse/AC-380)\r\n\r\nAfter video player skin updates were completed several months ago, analytics eventing needed to be updated to match the new controls and markup structure. The first part of this work was to see which events were still present and working. The second was to ensure only the language menu event was triggered when a language menu was present and made visible. Then I made sure that the transcript event was specific to the transcript. Finally I added a new event for closed captioning, which was added in the recent video work.\r\n\r\n## Overview of (modified) events\r\n\r\n* **Language menu** triggered with `video_show_language_menu` and `video_hide_language_menu` now only triggers when more than one language is available and the menu is opened or closed respectively.\r\n  * Note, these were previously titled `video_show_cc_menu` and `video_hide_cc_menu`, which are no inappropriate.\r\n* **Transcript** triggered with `show_transcript` and `hide_transcript` is triggered when the vertically scrolling transcript to the side of the video is shown or hidden.\r\n* **Closed-captions** triggered with `show_closed_captions` and `hide_closed_captions` is a new event for showing and hiding the floating closed-captions.\r\n\r\n## Event proposals\r\n\r\n* https://openedx.atlassian.net/wiki/display/AN/Video%3A+closed-captioning+events\r\n* https://openedx.atlassian.net/wiki/display/AN/Video%3A+language+menu+events\r\n\r\n## Sandboxes\r\n\r\nhttps://clrux-ac-380.sandbox.edx.org\r\nhttps://studio-clrux-ac-380.sandbox.edx.org\r\n\r\n## Reviewers\r\n\r\n- [ ] @stroilova \r\n- [ ] @lamagnifica \r\n- [ ] @clytwynec \r\n\r\nFYI @shnayder ","created_at":"2016-04-12T18:28:25Z","updated_at":"2016-04-13T14:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"573d52899ed864ad84d90493dc7a1e898d8a1396","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/12125/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/12125/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12125/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/bd089507a776d5c3afee6d3ea82802b5b87689f3","head":{"label":"edx:clrux/ac-382","ref":"clrux/ac-382","sha":"bd089507a776d5c3afee6d3ea82802b5b87689f3","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-04-13T12:36:31Z","pushed_at":"2016-04-13T14:14:21Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":751081,"stargazers_count":2499,"watchers_count":2499,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1523,"mirror_url":null,"open_issues_count":173,"forks":1523,"open_issues":173,"watchers":2499,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"537dd040c8ee4e32b0eb72d9e94cabea07b322cd","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-04-13T12:36:31Z","pushed_at":"2016-04-13T14:14:21Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":751081,"stargazers_count":2499,"watchers_count":2499,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1523,"mirror_url":null,"open_issues_count":173,"forks":1523,"open_issues":173,"watchers":2499,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12125"},"html":{"href":"https://github.com/edx/edx-platform/pull/12125"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12125"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12125/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12125/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12125/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/bd089507a776d5c3afee6d3ea82802b5b87689f3"}}}}