{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/54568909","id":54568909,"diff_hunk":"@@ -365,6 +367,7 @@ stdenv.mkDerivation ({\n     ${if cross != null then crossConfigureFlags else \"\"}\n     ${if !bootstrap then \"--disable-bootstrap\" else \"\"}\n     ${if cross == null then platformFlags else \"\"}\n+    ${if langJit then \"--enable-host-shared\" else \"\"}","path":"pkgs/development/compilers/gcc/5/default.nix","position":20,"original_position":20,"commit_id":"da6f4f0d0b27fdc88e6bf0e7c982d459ec1f7eb0","original_commit_id":"da6f4f0d0b27fdc88e6bf0e7c982d459ec1f7eb0","user":{"login":"shlevy","id":487050,"avatar_url":"https://avatars.githubusercontent.com/u/487050?v=3","gravatar_id":"","url":"https://api.github.com/users/shlevy","html_url":"https://github.com/shlevy","followers_url":"https://api.github.com/users/shlevy/followers","following_url":"https://api.github.com/users/shlevy/following{/other_user}","gists_url":"https://api.github.com/users/shlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/shlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlevy/subscriptions","organizations_url":"https://api.github.com/users/shlevy/orgs","repos_url":"https://api.github.com/users/shlevy/repos","events_url":"https://api.github.com/users/shlevy/events{/privacy}","received_events_url":"https://api.github.com/users/shlevy/received_events","type":"User","site_admin":false},"body":"Can you verify that this patch doesn't change the hash for `pkgs.gcc` without langJit enabled? I'm worried that this line in particular will add a newline even without the option.","created_at":"2016-03-01T13:55:37Z","updated_at":"2016-03-01T13:55:37Z","html_url":"https://github.com/NixOS/nixpkgs/pull/13400#discussion_r54568909","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13400","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/54568909"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/13400#discussion_r54568909"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13400"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13400","id":60421332,"html_url":"https://github.com/NixOS/nixpkgs/pull/13400","diff_url":"https://github.com/NixOS/nixpkgs/pull/13400.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/13400.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/13400","number":13400,"state":"open","locked":false,"title":"gcc5: add libgccjit language","user":{"login":"bendlas","id":214787,"avatar_url":"https://avatars.githubusercontent.com/u/214787?v=3","gravatar_id":"","url":"https://api.github.com/users/bendlas","html_url":"https://github.com/bendlas","followers_url":"https://api.github.com/users/bendlas/followers","following_url":"https://api.github.com/users/bendlas/following{/other_user}","gists_url":"https://api.github.com/users/bendlas/gists{/gist_id}","starred_url":"https://api.github.com/users/bendlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendlas/subscriptions","organizations_url":"https://api.github.com/users/bendlas/orgs","repos_url":"https://api.github.com/users/bendlas/repos","events_url":"https://api.github.com/users/bendlas/events{/privacy}","received_events_url":"https://api.github.com/users/bendlas/received_events","type":"User","site_admin":false},"body":"###### Things done:\r\n- [ ] Tested via `nix.useChroot`.\r\n- [x] Built on platform(s): `Linux nitox 4.4.2 #1-NixOS SMP Wed Feb 17 20:31:25 UTC 2016 x86_64 GNU/Linux, 16.03-pre-401d590a64736d3c (Emu)`\r\n- [ ] Tested compilation of all pkgs that depend on this change.\r\n- [x] Tested execution of binary products.\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n###### Extra\r\n\r\nShould this flag be enabled by default? It doesn't pull in extra deps, and the additional .so could live in an extra derivation.","created_at":"2016-02-23T22:27:18Z","updated_at":"2016-03-01T13:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49a664a63d6c05883893ce6febddd795b62180e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13400/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13400/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/13400/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/da6f4f0d0b27fdc88e6bf0e7c982d459ec1f7eb0","head":{"label":"bendlas:add-gcc-jit","ref":"add-gcc-jit","sha":"da6f4f0d0b27fdc88e6bf0e7c982d459ec1f7eb0","user":{"login":"bendlas","id":214787,"avatar_url":"https://avatars.githubusercontent.com/u/214787?v=3","gravatar_id":"","url":"https://api.github.com/users/bendlas","html_url":"https://github.com/bendlas","followers_url":"https://api.github.com/users/bendlas/followers","following_url":"https://api.github.com/users/bendlas/following{/other_user}","gists_url":"https://api.github.com/users/bendlas/gists{/gist_id}","starred_url":"https://api.github.com/users/bendlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendlas/subscriptions","organizations_url":"https://api.github.com/users/bendlas/orgs","repos_url":"https://api.github.com/users/bendlas/repos","events_url":"https://api.github.com/users/bendlas/events{/privacy}","received_events_url":"https://api.github.com/users/bendlas/received_events","type":"User","site_admin":false},"repo":{"id":29099913,"name":"nixpkgs","full_name":"bendlas/nixpkgs","owner":{"login":"bendlas","id":214787,"avatar_url":"https://avatars.githubusercontent.com/u/214787?v=3","gravatar_id":"","url":"https://api.github.com/users/bendlas","html_url":"https://github.com/bendlas","followers_url":"https://api.github.com/users/bendlas/followers","following_url":"https://api.github.com/users/bendlas/following{/other_user}","gists_url":"https://api.github.com/users/bendlas/gists{/gist_id}","starred_url":"https://api.github.com/users/bendlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendlas/subscriptions","organizations_url":"https://api.github.com/users/bendlas/orgs","repos_url":"https://api.github.com/users/bendlas/repos","events_url":"https://api.github.com/users/bendlas/events{/privacy}","received_events_url":"https://api.github.com/users/bendlas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bendlas/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/bendlas/nixpkgs","forks_url":"https://api.github.com/repos/bendlas/nixpkgs/forks","keys_url":"https://api.github.com/repos/bendlas/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bendlas/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bendlas/nixpkgs/teams","hooks_url":"https://api.github.com/repos/bendlas/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/bendlas/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/bendlas/nixpkgs/events","assignees_url":"https://api.github.com/repos/bendlas/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/bendlas/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/bendlas/nixpkgs/tags","blobs_url":"https://api.github.com/repos/bendlas/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bendlas/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bendlas/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bendlas/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bendlas/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/bendlas/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/bendlas/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/bendlas/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/bendlas/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/bendlas/nixpkgs/subscription","commits_url":"https://api.github.com/repos/bendlas/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bendlas/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bendlas/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bendlas/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bendlas/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/bendlas/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bendlas/nixpkgs/merges","archive_url":"https://api.github.com/repos/bendlas/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bendlas/nixpkgs/downloads","issues_url":"https://api.github.com/repos/bendlas/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/bendlas/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/bendlas/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/bendlas/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bendlas/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/bendlas/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/bendlas/nixpkgs/deployments","created_at":"2015-01-11T17:41:26Z","updated_at":"2016-02-15T11:53:46Z","pushed_at":"2016-02-29T20:19:56Z","git_url":"git://github.com/bendlas/nixpkgs.git","ssh_url":"git@github.com:bendlas/nixpkgs.git","clone_url":"https://github.com/bendlas/nixpkgs.git","svn_url":"https://github.com/bendlas/nixpkgs","homepage":null,"size":305018,"stargazers_count":1,"watchers_count":1,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"build-pixie"}},"base":{"label":"NixOS:master","ref":"master","sha":"ea242619fb0028f830238a0fa1b19277d14508ff","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-03-01T00:40:55Z","pushed_at":"2016-03-01T13:52:48Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":354068,"stargazers_count":967,"watchers_count":967,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1293,"mirror_url":null,"open_issues_count":1344,"forks":1293,"open_issues":1344,"watchers":967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13400"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/13400"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/13400"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/13400/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13400/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13400/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/da6f4f0d0b27fdc88e6bf0e7c982d459ec1f7eb0"}}}}