{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/88401940","pull_request_review_id":8975294,"id":88401940,"diff_hunk":"@@ -151,13 +151,15 @@ const propsBase: RenderProps = {\n   error: null,\n   trackerState: normal,\n   currentlyFollowing: false,\n+  currentFriendshipsTab: 'Followers',","path":"shared/profile/dumb.js","position":4,"original_position":4,"commit_id":"e42bebc698d61309adb23b4eea79d15911f06a56","original_commit_id":"d5e55f25e3e597657e781fa07ed6ed8f0cad408e","user":{"login":"chromakode","id":16893,"avatar_url":"https://avatars.githubusercontent.com/u/16893?v=3","gravatar_id":"","url":"https://api.github.com/users/chromakode","html_url":"https://github.com/chromakode","followers_url":"https://api.github.com/users/chromakode/followers","following_url":"https://api.github.com/users/chromakode/following{/other_user}","gists_url":"https://api.github.com/users/chromakode/gists{/gist_id}","starred_url":"https://api.github.com/users/chromakode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chromakode/subscriptions","organizations_url":"https://api.github.com/users/chromakode/orgs","repos_url":"https://api.github.com/users/chromakode/repos","events_url":"https://api.github.com/users/chromakode/events{/privacy}","received_events_url":"https://api.github.com/users/chromakode/received_events","type":"User","site_admin":false},"body":"Sure, will do.","created_at":"2016-11-17T07:59:26Z","updated_at":"2016-11-17T07:59:26Z","html_url":"https://github.com/keybase/client/pull/4857#discussion_r88401940","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/4857","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/88401940"},"html":{"href":"https://github.com/keybase/client/pull/4857#discussion_r88401940"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/4857"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/4857","id":93678842,"html_url":"https://github.com/keybase/client/pull/4857","diff_url":"https://github.com/keybase/client/pull/4857.diff","patch_url":"https://github.com/keybase/client/pull/4857.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/4857","number":4857,"state":"open","locked":false,"title":"Add new route tree state management system","user":{"login":"chromakode","id":16893,"avatar_url":"https://avatars.githubusercontent.com/u/16893?v=3","gravatar_id":"","url":"https://api.github.com/users/chromakode","html_url":"https://github.com/chromakode","followers_url":"https://api.github.com/users/chromakode/followers","following_url":"https://api.github.com/users/chromakode/following{/other_user}","gists_url":"https://api.github.com/users/chromakode/gists{/gist_id}","starred_url":"https://api.github.com/users/chromakode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chromakode/subscriptions","organizations_url":"https://api.github.com/users/chromakode/orgs","repos_url":"https://api.github.com/users/chromakode/repos","events_url":"https://api.github.com/users/chromakode/events{/privacy}","received_events_url":"https://api.github.com/users/chromakode/received_events","type":"User","site_admin":false},"body":":eyeglasses: @keybase/react-hackers \r\n\r\nSee https://github.com/keybase/client/pull/4681 for some design notes.\r\n\r\n* Core router code is in \"Add new route tree state management system\". Happy to walk through the code with anyone who is interested.\r\n\r\n* Updating all the previous router usages is in \"Overhaul routes to route tree structure\". This also contains some cleanup of the Nav TabBar code to flatten away logic. The top-level component is now called `<Main>`. `<Nav>` is a renders a container around the current screen content with a nav bar.\r\n\r\n* On the mobile side, this switches to using [`NavigationExperimental`](https://facebook.github.io/react-native/docs/navigation.html#navigationexperimental) and removes the native-esque header title. Screens can now bleed underneath the status bar. This is implemented in \"Add status bar height bleed to some views\".\r\n\r\n* I have attempted to manually test all of these routes, but there's the possibility I've missed a case. We should QA this for a little while internally to make sure there's no critical breakage (+ pause builds?).\r\n \r\nI'd like to add tests for the core route functions, but will break that into another ticket.","created_at":"2016-11-15T00:42:46Z","updated_at":"2016-11-17T07:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cee957a0980f739833b40d5cb0e9f9b6c58245e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/4857/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/4857/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/4857/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/e42bebc698d61309adb23b4eea79d15911f06a56","head":{"label":"keybase:mgood/DESKTOP-1909","ref":"mgood/DESKTOP-1909","sha":"e42bebc698d61309adb23b4eea79d15911f06a56","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2016-11-17T03:59:45Z","pushed_at":"2016-11-17T01:31:34Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":168350,"stargazers_count":850,"watchers_count":850,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":583,"forks":78,"open_issues":583,"watchers":850,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"0abf973078fcfeb3fb5e364f22600565918f5a0a","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2016-11-17T03:59:45Z","pushed_at":"2016-11-17T01:31:34Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":168350,"stargazers_count":850,"watchers_count":850,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":583,"forks":78,"open_issues":583,"watchers":850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/4857"},"html":{"href":"https://github.com/keybase/client/pull/4857"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/4857"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/4857/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/4857/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/4857/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/e42bebc698d61309adb23b4eea79d15911f06a56"}}}}
{"actor":{"display_login":"chromakode"}}