{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17060","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17060/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17060/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17060/events","html_url":"https://github.com/TrinityCore/TrinityCore/issues/17060","id":152057711,"number":17060,"title":"RangeHack","user":{"login":"L30m4nc3r","id":710285,"avatar_url":"https://avatars.githubusercontent.com/u/710285?v=3","gravatar_id":"","url":"https://api.github.com/users/L30m4nc3r","html_url":"https://github.com/L30m4nc3r","followers_url":"https://api.github.com/users/L30m4nc3r/followers","following_url":"https://api.github.com/users/L30m4nc3r/following{/other_user}","gists_url":"https://api.github.com/users/L30m4nc3r/gists{/gist_id}","starred_url":"https://api.github.com/users/L30m4nc3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L30m4nc3r/subscriptions","organizations_url":"https://api.github.com/users/L30m4nc3r/orgs","repos_url":"https://api.github.com/users/L30m4nc3r/repos","events_url":"https://api.github.com/users/L30m4nc3r/events{/privacy}","received_events_url":"https://api.github.com/users/L30m4nc3r/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2016-04-30T22:59:11Z","updated_at":"2016-07-01T14:29:49Z","closed_at":null,"body":"**Description**: When you install the patch (mpq) to the client, we are witnessing a critical bug with range.\r\n\r\n**Current behaviour**: The maximum distance for use spells is increased in 2 times more than standard.\r\n\r\n**Steps to reproduce the problem**:\r\n\r\n1. Add patch (MPQ) to client /Data/enUS/[patch-enUS-7.mpq](https://mega.nz/#!6YdjyaCI!f-Btta3wiPXTSs02Wn6rRdLv22DeWqcV0oNk7N-6_fk)\r\n2. Login in game, create warrior\r\n3. Use Skills on max range.\r\n\r\n**Branch(es)**: 335\r\n\r\n**TC hash/commit**:  https://github.com/TrinityCore/TrinityCore/commit/f9582ed09d224265977ff62d25bdf0257b589af8\r\n\r\n**TDB version**:  335.60 + updates.\r\n\r\n**Operating system**:  Ubuntu 14.04\r\n\r\n\r\n![e1owx19](https://cloud.githubusercontent.com/assets/710285/14939036/bf64fd64-0f37-11e6-8c65-2e30e98ebc3e.jpg)\r\n![ekqndw7](https://cloud.githubusercontent.com/assets/710285/14939037/bf7d4e6e-0f37-11e6-9ed8-bbfbb29cbd44.png)\r\n![rcpsgzq](https://cloud.githubusercontent.com/assets/710285/14939038/bf80dae8-0f37-11e6-9180-3be8c8b123d7.jpg)\r\n![eymflla](https://cloud.githubusercontent.com/assets/710285/14939127/02bed998-0f3a-11e6-9132-2b0705e9197a.jpg)\r\n\r\n```SpellCastResult Spell::CheckCast(bool strict)```\r\n ```diff \r\n         if (!m_spellInfo->HasAttribute(SPELL_ATTR2_CAN_TARGET_NOT_IN_LOS) && !DisableMgr::IsDisabledFor(DISABLE_TYPE_SPELL, m_spellInfo->Id, NULL, SPELL_DISABLE_LOS) && !m_caster->IsWithinLOS(x, y, z))\r\n             return SPELL_FAILED_LINE_OF_SIGHT;\r\n     }\r\n+    \r\n+    // Test Anti-Rangehack (need test) may bug some triggers .. this is apply only for players. (i guess creatures will not use rangehack!? jk)\r\n+    if (m_caster->GetTypeId() == TYPEID_PLAYER && m_spellInfo->GetMaxRange(m_spellInfo->IsPositive) + 2.0f > m_caster->GetDistance(target->GetPositionX(), target->GetPositionY(), target->GetPositionZ()))\r\n+        return SPELL_FAILED_OUT_OF_RANGE;\r\n \r\n     // check pet presence\r\n     for (int j = 0; j < MAX_SPELL_EFFECTS; ++j)\r\n```\r\nNot work any ideas?"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/229961773","html_url":"https://github.com/TrinityCore/TrinityCore/issues/17060#issuecomment-229961773","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17060","id":229961773,"user":{"login":"Raydor","id":2204071,"avatar_url":"https://avatars.githubusercontent.com/u/2204071?v=3","gravatar_id":"","url":"https://api.github.com/users/Raydor","html_url":"https://github.com/Raydor","followers_url":"https://api.github.com/users/Raydor/followers","following_url":"https://api.github.com/users/Raydor/following{/other_user}","gists_url":"https://api.github.com/users/Raydor/gists{/gist_id}","starred_url":"https://api.github.com/users/Raydor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raydor/subscriptions","organizations_url":"https://api.github.com/users/Raydor/orgs","repos_url":"https://api.github.com/users/Raydor/repos","events_url":"https://api.github.com/users/Raydor/events{/privacy}","received_events_url":"https://api.github.com/users/Raydor/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T14:29:49Z","updated_at":"2016-07-01T14:29:49Z","body":"@robinsch The spell indicator is still in white, thats checked by the client, without the patch, the client displays red icon and with it, even with your fix, it displays white but the server returns Out of Range."}}
{"actor":{"display_login":"Raydor"}}