{"action":"created","issue":{"url":"https://api.github.com/repos/pachyderm/pachyderm/issues/801","repository_url":"https://api.github.com/repos/pachyderm/pachyderm","labels_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/801/labels{/name}","comments_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/801/comments","events_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/801/events","html_url":"https://github.com/pachyderm/pachyderm/issues/801","id":175628237,"number":801,"title":"Add rethinkdb readiness check","user":{"login":"sjezewski","id":597953,"avatar_url":"https://avatars.githubusercontent.com/u/597953?v=3","gravatar_id":"","url":"https://api.github.com/users/sjezewski","html_url":"https://github.com/sjezewski","followers_url":"https://api.github.com/users/sjezewski/followers","following_url":"https://api.github.com/users/sjezewski/following{/other_user}","gists_url":"https://api.github.com/users/sjezewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sjezewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjezewski/subscriptions","organizations_url":"https://api.github.com/users/sjezewski/orgs","repos_url":"https://api.github.com/users/sjezewski/repos","events_url":"https://api.github.com/users/sjezewski/events{/privacy}","received_events_url":"https://api.github.com/users/sjezewski/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pachyderm/pachyderm/labels/technical-debt","name":"technical-debt","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-07T23:10:50Z","updated_at":"2016-09-08T20:18:19Z","closed_at":null,"body":"Right now we wrap `make test` w a single `make launch-test-rethinkdb` sub task. (Before we had this subtask running on each suite that required it ... so that e.g. if you run `make fuse` it'll spin up the dependencies it needs to run the tests).\r\n\r\nThe problem is that the start time of rethinkdb is flaky. We know this lesson well from how `pachd` starts up (if it can't connect, it panics, and k8s reschedules the pod until it connects).\r\n\r\nHowever, for the testing purposes it would be nice to have something block until its ready. Even the fix we have in place now will err sometimes if rethink happens to take longer than 20s to startup.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pachyderm/pachyderm/issues/comments/245726518","html_url":"https://github.com/pachyderm/pachyderm/issues/801#issuecomment-245726518","issue_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/801","id":245726518,"user":{"login":"sjezewski","id":597953,"avatar_url":"https://avatars.githubusercontent.com/u/597953?v=3","gravatar_id":"","url":"https://api.github.com/users/sjezewski","html_url":"https://github.com/sjezewski","followers_url":"https://api.github.com/users/sjezewski/followers","following_url":"https://api.github.com/users/sjezewski/following{/other_user}","gists_url":"https://api.github.com/users/sjezewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sjezewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjezewski/subscriptions","organizations_url":"https://api.github.com/users/sjezewski/orgs","repos_url":"https://api.github.com/users/sjezewski/repos","events_url":"https://api.github.com/users/sjezewski/events{/privacy}","received_events_url":"https://api.github.com/users/sjezewski/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T20:18:19Z","updated_at":"2016-09-08T20:18:19Z","body":"Yea, thats a good point. However we want to make sure `make test-fuse` and `make test-local` also launch the cluster to make sure they have what they need for the tests. So, I'll:\r\n\r\n- Make each suite that needs it launch the cluster in its make task (`make test`, `make test-fuse`, `make test-local`)\r\n- Update `make launch` to do nothing if it detects that the cluster is already up (so that its idempotent)\r\n\r\nThis way we'll only launch the cluster once on CI, not three times.\r\n\r\n----\r\n\r\nThen, I'll go ahead and add the readiness probe to the manifest for rethinkdb. That should make pachd startup cleaner (and less confusing to users). [I'll be using their own script for this](https://github.com/rosskukulinski/kubernetes-rethinkdb-cluster/blob/master/rethinkdb-quickstart.yml#L107)\r\n"}}
{"actor":{"display_login":"sjezewski"}}