{"action":"created","issue":{"url":"https://api.github.com/repos/ministryofjustice/govuk_elements_form_builder/issues/60","repository_url":"https://api.github.com/repos/ministryofjustice/govuk_elements_form_builder","labels_url":"https://api.github.com/repos/ministryofjustice/govuk_elements_form_builder/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/ministryofjustice/govuk_elements_form_builder/issues/60/comments","events_url":"https://api.github.com/repos/ministryofjustice/govuk_elements_form_builder/issues/60/events","html_url":"https://github.com/ministryofjustice/govuk_elements_form_builder/pull/60","id":176199283,"number":60,"title":"Fix non thread safe setting of ActionView::Base.field_error_proc","user":{"login":"robmckinnon","id":3447,"avatar_url":"https://avatars.githubusercontent.com/u/3447?v=3","gravatar_id":"","url":"https://api.github.com/users/robmckinnon","html_url":"https://github.com/robmckinnon","followers_url":"https://api.github.com/users/robmckinnon/followers","following_url":"https://api.github.com/users/robmckinnon/following{/other_user}","gists_url":"https://api.github.com/users/robmckinnon/gists{/gist_id}","starred_url":"https://api.github.com/users/robmckinnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmckinnon/subscriptions","organizations_url":"https://api.github.com/users/robmckinnon/orgs","repos_url":"https://api.github.com/users/robmckinnon/repos","events_url":"https://api.github.com/users/robmckinnon/events{/privacy}","received_events_url":"https://api.github.com/users/robmckinnon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-10T19:52:22Z","updated_at":"2016-10-07T16:14:08Z","closed_at":"2016-10-07T16:13:01Z","pull_request":{"url":"https://api.github.com/repos/ministryofjustice/govuk_elements_form_builder/pulls/60","html_url":"https://github.com/ministryofjustice/govuk_elements_form_builder/pull/60","diff_url":"https://github.com/ministryofjustice/govuk_elements_form_builder/pull/60.diff","patch_url":"https://github.com/ministryofjustice/govuk_elements_form_builder/pull/60.patch"},"body":"Call class method in proc set as `ActionView::Base.field_error_proc`, instead of a builder instance method. No longer set `ActionView::Base.field_error_proc` in builder initializer method.\r\n\r\nFixes nil exception raised when a nested builder renders errors before the  parent builder, reported by @alan.\r\n\r\nRemoves potential for threaded servers to override `ActionView::Base.field_error_proc` from multiple threads during concurrent request handling, which could cause inconsistent error rendering.\r\n\r\nChange `add_error_to_html_tag!` and methods it calls to class methods. Where needed create builder instance methods with same name as class methods for instance usage.\r\n"},"comment":{"url":"https://api.github.com/repos/ministryofjustice/govuk_elements_form_builder/issues/comments/252294885","html_url":"https://github.com/ministryofjustice/govuk_elements_form_builder/pull/60#issuecomment-252294885","issue_url":"https://api.github.com/repos/ministryofjustice/govuk_elements_form_builder/issues/60","id":252294885,"user":{"login":"aliuk2012","id":3441519,"avatar_url":"https://avatars.githubusercontent.com/u/3441519?v=3","gravatar_id":"","url":"https://api.github.com/users/aliuk2012","html_url":"https://github.com/aliuk2012","followers_url":"https://api.github.com/users/aliuk2012/followers","following_url":"https://api.github.com/users/aliuk2012/following{/other_user}","gists_url":"https://api.github.com/users/aliuk2012/gists{/gist_id}","starred_url":"https://api.github.com/users/aliuk2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliuk2012/subscriptions","organizations_url":"https://api.github.com/users/aliuk2012/orgs","repos_url":"https://api.github.com/users/aliuk2012/repos","events_url":"https://api.github.com/users/aliuk2012/events{/privacy}","received_events_url":"https://api.github.com/users/aliuk2012/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T16:14:08Z","updated_at":"2016-10-07T16:14:08Z","body":"Sorry for the delay. just been hectically busy trying to get our service live on govuk. I'll look at hosting this on rubygems"}}
{"actor":{"display_login":"aliuk2012"}}