{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/409","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/409/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/409/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/409/events","html_url":"https://github.com/trilinos/Trilinos/issues/409","id":157894245,"number":409,"title":"Many deprecated warnings for the deprecated class Ifpack2::Krylov","user":{"login":"nschloe","id":181628,"avatar_url":"https://avatars.githubusercontent.com/u/181628?v=3","gravatar_id":"","url":"https://api.github.com/users/nschloe","html_url":"https://github.com/nschloe","followers_url":"https://api.github.com/users/nschloe/followers","following_url":"https://api.github.com/users/nschloe/following{/other_user}","gists_url":"https://api.github.com/users/nschloe/gists{/gist_id}","starred_url":"https://api.github.com/users/nschloe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschloe/subscriptions","organizations_url":"https://api.github.com/users/nschloe/orgs","repos_url":"https://api.github.com/users/nschloe/repos","events_url":"https://api.github.com/users/nschloe/events{/privacy}","received_events_url":"https://api.github.com/users/nschloe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trilinos/Trilinos/labels/Ifpack2","name":"Ifpack2","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-06-01T12:27:43Z","updated_at":"2016-06-06T17:03:41Z","closed_at":null,"body":"When compiling Trilinos, I'm getting more than one thousand (!) warnings of the kind\r\n```\r\n/«PKGBUILDDIR»/packages/ifpack2/src/Ifpack2_Krylov_decl.hpp:280:19: warning: ‘template<class MatrixType> class Ifpack2::Krylov’ is deprecated [-Wdeprecated-declarations]\r\n     Krylov (const Krylov<MatrixType>& RHS);\r\n                   ^\r\nIn file included from /«PKGBUILDDIR»/obj-x86_64-linux-gnu/packages/ifpack2/src/Ifpack2_Krylov.hpp:1:0,\r\n                 from /«PKGBUILDDIR»/packages/stokhos/src/sacado/kokkos/vector/ifpack2/Ifpack2_Krylov_MP_Vector.hpp:52,\r\n                 from /«PKGBUILDDIR»/packages/stokhos/src/sacado/kokkos/vector/ifpack2/Stokhos_Ifpack2_MP_Vector.hpp:50,\r\n                 from /«PKGBUILDDIR»/obj-x86_64-linux-gnu/packages/stokhos/src/Ifpack2_Diagonal_MP_Vector_Serial.cpp:48:\r\n/«PKGBUILDDIR»/packages/ifpack2/src/Ifpack2_Krylov_decl.hpp:95:28: note: declared here\r\n   class IFPACK2_DEPRECATED Krylov :\r\n                            ^\r\n```\r\nThe deprecating commit is\r\n```\r\ncommit f45616d794c95455bf15abd859b1aefdec2710b3\r\nAuthor: Mark Hoemmen <mhoemme@sandia.gov>\r\nDate:   Thu Aug 13 13:28:55 2015 -0600\r\n\r\n    Ifpack2::Krylov: Deprecated.\r\n\r\n    There's no need for Ifpack2 to implement Krylov methods.  Belos does a\r\n    fine job of this.  Furthermore, the LinearSolverFactory will make such\r\n    duplication of functionality unnecessary and obsolete.\r\n    \r\n    Ifpack2::Factory, and other implementation-level factories in Ifpack2,\r\n    no longer create instances of Ifpack2::Krylov.  Instead, they throw an\r\n    exception with an informative message.  They no longer include\r\n    Ifpack2::Krylov header files.  The header files still exist, but are\r\n    heavily marked as deprecated.  The class itself uses the deprecated\r\n    macro.\r\n```\r\nso this is nearly a year old. Time to scratch `Ifpack2_Krylov_decl.hpp`?"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/224021473","html_url":"https://github.com/trilinos/Trilinos/issues/409#issuecomment-224021473","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/409","id":224021473,"user":{"login":"jhux2","id":12970120,"avatar_url":"https://avatars.githubusercontent.com/u/12970120?v=3","gravatar_id":"","url":"https://api.github.com/users/jhux2","html_url":"https://github.com/jhux2","followers_url":"https://api.github.com/users/jhux2/followers","following_url":"https://api.github.com/users/jhux2/following{/other_user}","gists_url":"https://api.github.com/users/jhux2/gists{/gist_id}","starred_url":"https://api.github.com/users/jhux2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhux2/subscriptions","organizations_url":"https://api.github.com/users/jhux2/orgs","repos_url":"https://api.github.com/users/jhux2/repos","events_url":"https://api.github.com/users/jhux2/events{/privacy}","received_events_url":"https://api.github.com/users/jhux2/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T17:03:41Z","updated_at":"2016-06-06T17:03:41Z","body":"> @jhux2 @nschloe Ok, what do we want to do? Do we want to move the class into the Ifpack2::Deprecated namespace and remove the IFPACK2_DEPRECATED macro?\r\n\r\nMoving the class into the Ifpack2::Deprecated namespace for sure.   To avoid the warnings Nico mentions, a possibility is keeping IFPACK2_DEPRECATED in Ifpack2::Deprecated::Krylov class, but only build that class if the user explicitly asks for it, e.g., with a cmake option like -DIfpack2_EnableDeprecatedNamespace.  Comments?"}}
{"actor":{"display_login":"jhux2"}}