{"action":"created","issue":{"url":"https://api.github.com/repos/wocommunity/wonder/issues/704","repository_url":"https://api.github.com/repos/wocommunity/wonder","labels_url":"https://api.github.com/repos/wocommunity/wonder/issues/704/labels{/name}","comments_url":"https://api.github.com/repos/wocommunity/wonder/issues/704/comments","events_url":"https://api.github.com/repos/wocommunity/wonder/issues/704/events","html_url":"https://github.com/wocommunity/wonder/pull/704","id":119054449,"number":704,"title":"Erx framework embedding","user":{"login":"markusstoll","id":1909884,"avatar_url":"https://avatars.githubusercontent.com/u/1909884?v=3","gravatar_id":"","url":"https://api.github.com/users/markusstoll","html_url":"https://github.com/markusstoll","followers_url":"https://api.github.com/users/markusstoll/followers","following_url":"https://api.github.com/users/markusstoll/following{/other_user}","gists_url":"https://api.github.com/users/markusstoll/gists{/gist_id}","starred_url":"https://api.github.com/users/markusstoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusstoll/subscriptions","organizations_url":"https://api.github.com/users/markusstoll/orgs","repos_url":"https://api.github.com/users/markusstoll/repos","events_url":"https://api.github.com/users/markusstoll/events{/privacy}","received_events_url":"https://api.github.com/users/markusstoll/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wocommunity/wonder/labels/Wonder6","name":"Wonder6","color":"fef2c0"},{"url":"https://api.github.com/repos/wocommunity/wonder/labels/Wonder7","name":"Wonder7","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2015-11-26T14:25:56Z","updated_at":"2016-06-30T08:37:57Z","closed_at":"2015-11-29T14:23:17Z","pull_request":{"url":"https://api.github.com/repos/wocommunity/wonder/pulls/704","html_url":"https://github.com/wocommunity/wonder/pull/704","diff_url":"https://github.com/wocommunity/wonder/pull/704.diff","patch_url":"https://github.com/wocommunity/wonder/pull/704.patch"},"body":"This fix automatically fixes the WebServerResources URL for embedded frameworks to be accessed via \r\n\r\n/WebServer/#Appname#.woa/Frameworks/...\r\n\r\nthe default all or nothing solution does not help when you only embed a part of your frameworks"},"comment":{"url":"https://api.github.com/repos/wocommunity/wonder/issues/comments/229597472","html_url":"https://github.com/wocommunity/wonder/pull/704#issuecomment-229597472","issue_url":"https://api.github.com/repos/wocommunity/wonder/issues/704","id":229597472,"user":{"login":"markusstoll","id":1909884,"avatar_url":"https://avatars.githubusercontent.com/u/1909884?v=3","gravatar_id":"","url":"https://api.github.com/users/markusstoll","html_url":"https://github.com/markusstoll","followers_url":"https://api.github.com/users/markusstoll/followers","following_url":"https://api.github.com/users/markusstoll/following{/other_user}","gists_url":"https://api.github.com/users/markusstoll/gists{/gist_id}","starred_url":"https://api.github.com/users/markusstoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusstoll/subscriptions","organizations_url":"https://api.github.com/users/markusstoll/orgs","repos_url":"https://api.github.com/users/markusstoll/repos","events_url":"https://api.github.com/users/markusstoll/events{/privacy}","received_events_url":"https://api.github.com/users/markusstoll/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T08:37:57Z","updated_at":"2016-06-30T08:37:57Z","body":"Hi @fbarthez and @hprange,\r\n\r\nI agree, if you supply `WOFrameworksBaseURL`, this should be honored. However, `WOFrameworksBaseURL` is set automatically to a default value, so I have to compare against the default value.\r\n\r\nThis branch should take care of the issues properly:\r\n[https://github.com/markusstoll/wonder/commits/ERXDeployedBundle-Fix]\r\n\r\nI tested on a deployment with all variants of supplied Properties and it behaved correctly. Could you test this with a maven build?\r\n\r\nRemark: In your example the framework was embedded, so flag `isEmbeddedFramework` was set correctly to `true`, but the path was not yet determined correctly due to a typo."}}
{"actor":{"display_login":"markusstoll"}}