{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/91839128","pull_request_review_id":12351650,"id":91839128,"diff_hunk":"@@ -25,6 +25,8 @@\n CONF_EXCLUDE = 'exclude'\n # Interval in minutes to exclude devices from a scan while they are home\n CONF_HOME_INTERVAL = 'home_interval'\n+CONF_OPTIONS = 'scan_options'\n+DEFAULT_OPTIONS = '-F --host-timeout 5s '","path":"homeassistant/components/device_tracker/nmap_tracker.py","position":null,"original_position":5,"commit_id":"44754809cbb3c121c1384372b0cb416c5ea2a330","original_commit_id":"9e530a571b90359a90de6dd5b1a05a0bb531b5a3","user":{"login":"Danielhiversen","id":650502,"avatar_url":"https://avatars.githubusercontent.com/u/650502?v=3","gravatar_id":"","url":"https://api.github.com/users/Danielhiversen","html_url":"https://github.com/Danielhiversen","followers_url":"https://api.github.com/users/Danielhiversen/followers","following_url":"https://api.github.com/users/Danielhiversen/following{/other_user}","gists_url":"https://api.github.com/users/Danielhiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/Danielhiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danielhiversen/subscriptions","organizations_url":"https://api.github.com/users/Danielhiversen/orgs","repos_url":"https://api.github.com/users/Danielhiversen/repos","events_url":"https://api.github.com/users/Danielhiversen/events{/privacy}","received_events_url":"https://api.github.com/users/Danielhiversen/received_events","type":"User","site_admin":false},"body":"The space was not needed, so it is now removed","created_at":"2016-12-10T17:45:16Z","updated_at":"2016-12-10T17:45:16Z","html_url":"https://github.com/home-assistant/home-assistant/pull/4838#discussion_r91839128","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4838","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/91839128"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/4838#discussion_r91839128"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4838"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4838","id":97424736,"html_url":"https://github.com/home-assistant/home-assistant/pull/4838","diff_url":"https://github.com/home-assistant/home-assistant/pull/4838.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/4838.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4838","number":4838,"state":"open","locked":false,"title":"Configurable scan options for nmap","user":{"login":"Danielhiversen","id":650502,"avatar_url":"https://avatars.githubusercontent.com/u/650502?v=3","gravatar_id":"","url":"https://api.github.com/users/Danielhiversen","html_url":"https://github.com/Danielhiversen","followers_url":"https://api.github.com/users/Danielhiversen/followers","following_url":"https://api.github.com/users/Danielhiversen/following{/other_user}","gists_url":"https://api.github.com/users/Danielhiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/Danielhiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danielhiversen/subscriptions","organizations_url":"https://api.github.com/users/Danielhiversen/orgs","repos_url":"https://api.github.com/users/Danielhiversen/repos","events_url":"https://api.github.com/users/Danielhiversen/events{/privacy}","received_events_url":"https://api.github.com/users/Danielhiversen/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nConfigurable scan options for nmap\r\n\r\nI have seen many people struggling to set up the nmap device tracker.\r\nThis pr will allow to customize the options passed to nmap.\r\n\r\nAn example of how the Nmap scanner can be customized:\r\n\r\n\r\nAdd the capabilities to Nmap. Be sure to specify the full path to wherever you installed Nmap:\r\n\r\n`sudo setcap cap_net_raw,cap_net_admin,cap_net_bind_service+eip /usr/bin/nmap\r\n`\r\n\r\nAnd you can set up the device tracker as\r\n```yaml\r\n- platform: nmap_tracker\r\n  hosts: 192.168.1.1-25\r\n  scan_options: \" --privileged -sP \"\r\n```\r\n\r\n\r\n\r\n**Checklist:**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [x] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [x] New files were added to `.coveragerc`.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L16\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L51\r\n\r\n","created_at":"2016-12-10T13:26:52Z","updated_at":"2016-12-10T17:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7acc89ec4a34007c7d432bc375b4d32e071d956c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4838/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4838/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4838/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/44754809cbb3c121c1384372b0cb416c5ea2a330","head":{"label":"home-assistant:nmap","ref":"nmap","sha":"44754809cbb3c121c1384372b0cb416c5ea2a330","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-12-10T17:11:26Z","pushed_at":"2016-12-10T17:42:04Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":90102,"stargazers_count":4962,"watchers_count":4962,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1304,"mirror_url":null,"open_issues_count":337,"forks":1304,"open_issues":337,"watchers":4962,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"167260bcc65317aa74212bbcb78ecf14c20263e2","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-12-10T17:11:26Z","pushed_at":"2016-12-10T17:42:04Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":90102,"stargazers_count":4962,"watchers_count":4962,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1304,"mirror_url":null,"open_issues_count":337,"forks":1304,"open_issues":337,"watchers":4962,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4838"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/4838"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/4838"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/4838/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4838/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4838/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/44754809cbb3c121c1384372b0cb416c5ea2a330"}}}}
{"actor":{"display_login":"Danielhiversen"}}