{"action":"created","comment":{"url":"https://api.github.com/repos/halide/Halide/pulls/comments/64249059","id":64249059,"diff_hunk":"@@ -1075,13 +1073,13 @@ void validate_schedule(Function f, Stmt s, const Target &target, bool is_output)\n \n     // Emit a warning if only some of the steps have been scheduled.\n     bool any_scheduled = f.schedule().touched();\n-    for (const UpdateDefinition &r : f.updates()) {\n-        any_scheduled = any_scheduled || r.schedule.touched();\n+    for (const Definition &r : f.updates()) {\n+        any_scheduled = any_scheduled || r.schedule().touched();\n     }\n     if (any_scheduled) {\n         for (size_t i = 0; i < f.updates().size(); i++) {\n-            const UpdateDefinition &r = f.updates()[i];\n-            if (!r.schedule.touched()) {\n+            const Definition &r = f.update(i);\n+            if (!r.schedule().touched()) {\n                 std::cerr << \"Warning: Update step \" << i","path":"src/ScheduleFunctions.cpp","position":249,"original_position":249,"commit_id":"9938493c39af0b08368f675b69ed0daba5c8ec90","original_commit_id":"9938493c39af0b08368f675b69ed0daba5c8ec90","user":{"login":"dsharletg","id":7494796,"avatar_url":"https://avatars.githubusercontent.com/u/7494796?v=3","gravatar_id":"","url":"https://api.github.com/users/dsharletg","html_url":"https://github.com/dsharletg","followers_url":"https://api.github.com/users/dsharletg/followers","following_url":"https://api.github.com/users/dsharletg/following{/other_user}","gists_url":"https://api.github.com/users/dsharletg/gists{/gist_id}","starred_url":"https://api.github.com/users/dsharletg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsharletg/subscriptions","organizations_url":"https://api.github.com/users/dsharletg/orgs","repos_url":"https://api.github.com/users/dsharletg/repos","events_url":"https://api.github.com/users/dsharletg/events{/privacy}","received_events_url":"https://api.github.com/users/dsharletg/received_events","type":"User","site_admin":false},"body":"I know this is not changed code, but I just spotted this, it seems like maybe this should be user_warning << ...","created_at":"2016-05-23T16:43:42Z","updated_at":"2016-05-23T16:43:42Z","html_url":"https://github.com/halide/Halide/pull/1233#discussion_r64249059","pull_request_url":"https://api.github.com/repos/halide/Halide/pulls/1233","_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments/64249059"},"html":{"href":"https://github.com/halide/Halide/pull/1233#discussion_r64249059"},"pull_request":{"href":"https://api.github.com/repos/halide/Halide/pulls/1233"}}},"pull_request":{"url":"https://api.github.com/repos/halide/Halide/pulls/1233","id":70933011,"html_url":"https://github.com/halide/Halide/pull/1233","diff_url":"https://github.com/halide/Halide/pull/1233.diff","patch_url":"https://github.com/halide/Halide/pull/1233.patch","issue_url":"https://api.github.com/repos/halide/Halide/issues/1233","number":1233,"state":"open","locked":false,"title":"Refactor func definition","user":{"login":"psuriana","id":2260287,"avatar_url":"https://avatars.githubusercontent.com/u/2260287?v=3","gravatar_id":"","url":"https://api.github.com/users/psuriana","html_url":"https://github.com/psuriana","followers_url":"https://api.github.com/users/psuriana/followers","following_url":"https://api.github.com/users/psuriana/following{/other_user}","gists_url":"https://api.github.com/users/psuriana/gists{/gist_id}","starred_url":"https://api.github.com/users/psuriana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psuriana/subscriptions","organizations_url":"https://api.github.com/users/psuriana/orgs","repos_url":"https://api.github.com/users/psuriana/repos","events_url":"https://api.github.com/users/psuriana/events{/privacy}","received_events_url":"https://api.github.com/users/psuriana/received_events","type":"User","site_admin":false},"body":"This PR refactors Specialization/UpdateDefinition. Function definition (args+values) is now in a separate class called Definition which also contains the schedule. Whenever specialize() is called on a Func, it will add the specialization to its Definition. This lets a Func to have different definitions (args/values) due to specialization (not possible from the front-end, but is needed for the associative_reduction PR). Although the RHS/LHS may be different across specializations, they must have the same pure dimensions.\r\n\r\nThis PR also pull DeepCopy from WrapCalls and make it into a separate lowering pass.","created_at":"2016-05-21T00:13:58Z","updated_at":"2016-05-23T16:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5ac9cf43400eb65cd4b67274cb173b57d546dd2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/halide/Halide/pulls/1233/commits","review_comments_url":"https://api.github.com/repos/halide/Halide/pulls/1233/comments","review_comment_url":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/halide/Halide/issues/1233/comments","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/9938493c39af0b08368f675b69ed0daba5c8ec90","head":{"label":"halide:refactor_func_definition","ref":"refactor_func_definition","sha":"9938493c39af0b08368f675b69ed0daba5c8ec90","user":{"login":"halide","id":1548551,"avatar_url":"https://avatars.githubusercontent.com/u/1548551?v=3","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"name":"Halide","full_name":"halide/Halide","owner":{"login":"halide","id":1548551,"avatar_url":"https://avatars.githubusercontent.com/u/1548551?v=3","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/halide/Halide","description":"a language for image processing and computational photography","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2016-05-23T10:25:45Z","pushed_at":"2016-05-23T01:50:34Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":264133,"stargazers_count":1292,"watchers_count":1292,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":184,"forks":257,"open_issues":184,"watchers":1292,"default_branch":"master"}},"base":{"label":"halide:master","ref":"master","sha":"383ab6b62fe645651bdfa49c31e27370d894650c","user":{"login":"halide","id":1548551,"avatar_url":"https://avatars.githubusercontent.com/u/1548551?v=3","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"name":"Halide","full_name":"halide/Halide","owner":{"login":"halide","id":1548551,"avatar_url":"https://avatars.githubusercontent.com/u/1548551?v=3","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/halide/Halide","description":"a language for image processing and computational photography","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2016-05-23T10:25:45Z","pushed_at":"2016-05-23T01:50:34Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":264133,"stargazers_count":1292,"watchers_count":1292,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":184,"forks":257,"open_issues":184,"watchers":1292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/1233"},"html":{"href":"https://github.com/halide/Halide/pull/1233"},"issue":{"href":"https://api.github.com/repos/halide/Halide/issues/1233"},"comments":{"href":"https://api.github.com/repos/halide/Halide/issues/1233/comments"},"review_comments":{"href":"https://api.github.com/repos/halide/Halide/pulls/1233/comments"},"review_comment":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/halide/Halide/pulls/1233/commits"},"statuses":{"href":"https://api.github.com/repos/halide/Halide/statuses/9938493c39af0b08368f675b69ed0daba5c8ec90"}}}}
{"actor":{"display_login":"dsharletg"}}