{"action":"created","issue":{"url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/193","repository_url":"https://api.github.com/repos/mirage/mirage-tcpip","labels_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/193/comments","events_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/193/events","html_url":"https://github.com/mirage/mirage-tcpip/pull/193","id":142977322,"number":193,"title":"Pull ICMP functionality into its own module","user":{"login":"yomimono","id":4086825,"avatar_url":"https://avatars.githubusercontent.com/u/4086825?v=3","gravatar_id":"","url":"https://api.github.com/users/yomimono","html_url":"https://github.com/yomimono","followers_url":"https://api.github.com/users/yomimono/followers","following_url":"https://api.github.com/users/yomimono/following{/other_user}","gists_url":"https://api.github.com/users/yomimono/gists{/gist_id}","starred_url":"https://api.github.com/users/yomimono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomimono/subscriptions","organizations_url":"https://api.github.com/users/yomimono/orgs","repos_url":"https://api.github.com/users/yomimono/repos","events_url":"https://api.github.com/users/yomimono/events{/privacy}","received_events_url":"https://api.github.com/users/yomimono/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-03-23T14:37:43Z","updated_at":"2016-03-28T18:30:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/193","html_url":"https://github.com/mirage/mirage-tcpip/pull/193","diff_url":"https://github.com/mirage/mirage-tcpip/pull/193.diff","patch_url":"https://github.com/mirage/mirage-tcpip/pull/193.patch"},"body":"Remove the implicit ICMP behavior from IPV4 and instead provide an ICMPV4 implementation.  Include some simple tests for this module, and provide sensible default behavior for the STACKV4 modules (in other words, answer pings).  While this PR includes little new functionality, it should make developing ICMP-related features easier for consumers of the stack (e.g. mirage-nat, mirage-mimic, and other router- or proxy-like applications).\r\n\r\nAn incidental bugfix for the indiscriminate answering of ICMP echo requests is also included."},"comment":{"url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/comments/202519140","html_url":"https://github.com/mirage/mirage-tcpip/pull/193#issuecomment-202519140","issue_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/193","id":202519140,"user":{"login":"hannesm","id":228456,"avatar_url":"https://avatars.githubusercontent.com/u/228456?v=3","gravatar_id":"","url":"https://api.github.com/users/hannesm","html_url":"https://github.com/hannesm","followers_url":"https://api.github.com/users/hannesm/followers","following_url":"https://api.github.com/users/hannesm/following{/other_user}","gists_url":"https://api.github.com/users/hannesm/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesm/subscriptions","organizations_url":"https://api.github.com/users/hannesm/orgs","repos_url":"https://api.github.com/users/hannesm/repos","events_url":"https://api.github.com/users/hannesm/events{/privacy}","received_events_url":"https://api.github.com/users/hannesm/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T18:30:48Z","updated_at":"2016-03-28T18:30:48Z","body":"this looks good to me! thanks!"}}