{"action":"created","comment":{"url":"https://api.github.com/repos/longld/peda/pulls/comments/68248194","id":68248194,"diff_hunk":"@@ -754,7 +756,17 @@ def assemble(self, asmcode, bits=None):\n         \"\"\"\n         if bits is None:\n             (arch, bits) = self.getarch()\n-        return Nasm.assemble(asmcode, bits)\n+\n+        if bits == 16:","path":"peda.py","position":15,"original_position":15,"commit_id":"471b99b0d63689e12e912fa7f91921af206062df","original_commit_id":"471b99b0d63689e12e912fa7f91921af206062df","user":{"login":"aquynh","id":5965536,"avatar_url":"https://avatars.githubusercontent.com/u/5965536?v=3","gravatar_id":"","url":"https://api.github.com/users/aquynh","html_url":"https://github.com/aquynh","followers_url":"https://api.github.com/users/aquynh/followers","following_url":"https://api.github.com/users/aquynh/following{/other_user}","gists_url":"https://api.github.com/users/aquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/aquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquynh/subscriptions","organizations_url":"https://api.github.com/users/aquynh/orgs","repos_url":"https://api.github.com/users/aquynh/repos","events_url":"https://api.github.com/users/aquynh/events{/privacy}","received_events_url":"https://api.github.com/users/aquynh/received_events","type":"User","site_admin":false},"body":"i know, but this is simple enough that i did not bother.","created_at":"2016-06-23T14:46:07Z","updated_at":"2016-06-23T14:46:07Z","html_url":"https://github.com/longld/peda/pull/82#discussion_r68248194","pull_request_url":"https://api.github.com/repos/longld/peda/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/longld/peda/pulls/comments/68248194"},"html":{"href":"https://github.com/longld/peda/pull/82#discussion_r68248194"},"pull_request":{"href":"https://api.github.com/repos/longld/peda/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/longld/peda/pulls/82","id":74962499,"html_url":"https://github.com/longld/peda/pull/82","diff_url":"https://github.com/longld/peda/pull/82.diff","patch_url":"https://github.com/longld/peda/pull/82.patch","issue_url":"https://api.github.com/repos/longld/peda/issues/82","number":82,"state":"open","locked":false,"title":"replace Nasm assembler with Keystone engine","user":{"login":"aquynh","id":5965536,"avatar_url":"https://avatars.githubusercontent.com/u/5965536?v=3","gravatar_id":"","url":"https://api.github.com/users/aquynh","html_url":"https://github.com/aquynh","followers_url":"https://api.github.com/users/aquynh/followers","following_url":"https://api.github.com/users/aquynh/following{/other_user}","gists_url":"https://api.github.com/users/aquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/aquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquynh/subscriptions","organizations_url":"https://api.github.com/users/aquynh/orgs","repos_url":"https://api.github.com/users/aquynh/repos","events_url":"https://api.github.com/users/aquynh/events{/privacy}","received_events_url":"https://api.github.com/users/aquynh/received_events","type":"User","site_admin":false},"body":"ditch Nasm assembler & replace it with Keystone. see https://github.com/longld/peda/issues/81","created_at":"2016-06-23T14:16:14Z","updated_at":"2016-06-23T14:46:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7ef4d0d53ae7034293391b19b073306da8997ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/longld/peda/pulls/82/commits","review_comments_url":"https://api.github.com/repos/longld/peda/pulls/82/comments","review_comment_url":"https://api.github.com/repos/longld/peda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/longld/peda/issues/82/comments","statuses_url":"https://api.github.com/repos/longld/peda/statuses/471b99b0d63689e12e912fa7f91921af206062df","head":{"label":"aquynh:master","ref":"master","sha":"471b99b0d63689e12e912fa7f91921af206062df","user":{"login":"aquynh","id":5965536,"avatar_url":"https://avatars.githubusercontent.com/u/5965536?v=3","gravatar_id":"","url":"https://api.github.com/users/aquynh","html_url":"https://github.com/aquynh","followers_url":"https://api.github.com/users/aquynh/followers","following_url":"https://api.github.com/users/aquynh/following{/other_user}","gists_url":"https://api.github.com/users/aquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/aquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquynh/subscriptions","organizations_url":"https://api.github.com/users/aquynh/orgs","repos_url":"https://api.github.com/users/aquynh/repos","events_url":"https://api.github.com/users/aquynh/events{/privacy}","received_events_url":"https://api.github.com/users/aquynh/received_events","type":"User","site_admin":false},"repo":{"id":61810452,"name":"peda","full_name":"aquynh/peda","owner":{"login":"aquynh","id":5965536,"avatar_url":"https://avatars.githubusercontent.com/u/5965536?v=3","gravatar_id":"","url":"https://api.github.com/users/aquynh","html_url":"https://github.com/aquynh","followers_url":"https://api.github.com/users/aquynh/followers","following_url":"https://api.github.com/users/aquynh/following{/other_user}","gists_url":"https://api.github.com/users/aquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/aquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquynh/subscriptions","organizations_url":"https://api.github.com/users/aquynh/orgs","repos_url":"https://api.github.com/users/aquynh/repos","events_url":"https://api.github.com/users/aquynh/events{/privacy}","received_events_url":"https://api.github.com/users/aquynh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aquynh/peda","description":"PEDA - Python Exploit Development Assistance for GDB","fork":true,"url":"https://api.github.com/repos/aquynh/peda","forks_url":"https://api.github.com/repos/aquynh/peda/forks","keys_url":"https://api.github.com/repos/aquynh/peda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aquynh/peda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aquynh/peda/teams","hooks_url":"https://api.github.com/repos/aquynh/peda/hooks","issue_events_url":"https://api.github.com/repos/aquynh/peda/issues/events{/number}","events_url":"https://api.github.com/repos/aquynh/peda/events","assignees_url":"https://api.github.com/repos/aquynh/peda/assignees{/user}","branches_url":"https://api.github.com/repos/aquynh/peda/branches{/branch}","tags_url":"https://api.github.com/repos/aquynh/peda/tags","blobs_url":"https://api.github.com/repos/aquynh/peda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aquynh/peda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aquynh/peda/git/refs{/sha}","trees_url":"https://api.github.com/repos/aquynh/peda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aquynh/peda/statuses/{sha}","languages_url":"https://api.github.com/repos/aquynh/peda/languages","stargazers_url":"https://api.github.com/repos/aquynh/peda/stargazers","contributors_url":"https://api.github.com/repos/aquynh/peda/contributors","subscribers_url":"https://api.github.com/repos/aquynh/peda/subscribers","subscription_url":"https://api.github.com/repos/aquynh/peda/subscription","commits_url":"https://api.github.com/repos/aquynh/peda/commits{/sha}","git_commits_url":"https://api.github.com/repos/aquynh/peda/git/commits{/sha}","comments_url":"https://api.github.com/repos/aquynh/peda/comments{/number}","issue_comment_url":"https://api.github.com/repos/aquynh/peda/issues/comments{/number}","contents_url":"https://api.github.com/repos/aquynh/peda/contents/{+path}","compare_url":"https://api.github.com/repos/aquynh/peda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aquynh/peda/merges","archive_url":"https://api.github.com/repos/aquynh/peda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aquynh/peda/downloads","issues_url":"https://api.github.com/repos/aquynh/peda/issues{/number}","pulls_url":"https://api.github.com/repos/aquynh/peda/pulls{/number}","milestones_url":"https://api.github.com/repos/aquynh/peda/milestones{/number}","notifications_url":"https://api.github.com/repos/aquynh/peda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aquynh/peda/labels{/name}","releases_url":"https://api.github.com/repos/aquynh/peda/releases{/id}","deployments_url":"https://api.github.com/repos/aquynh/peda/deployments","created_at":"2016-06-23T14:13:37Z","updated_at":"2016-06-23T14:13:38Z","pushed_at":"2016-06-23T14:15:11Z","git_url":"git://github.com/aquynh/peda.git","ssh_url":"git@github.com:aquynh/peda.git","clone_url":"https://github.com/aquynh/peda.git","svn_url":"https://github.com/aquynh/peda","homepage":null,"size":469,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"longld:master","ref":"master","sha":"b7c7d7aeeba65a467fe982787b4f72e017774905","user":{"login":"longld","id":38460,"avatar_url":"https://avatars.githubusercontent.com/u/38460?v=3","gravatar_id":"","url":"https://api.github.com/users/longld","html_url":"https://github.com/longld","followers_url":"https://api.github.com/users/longld/followers","following_url":"https://api.github.com/users/longld/following{/other_user}","gists_url":"https://api.github.com/users/longld/gists{/gist_id}","starred_url":"https://api.github.com/users/longld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longld/subscriptions","organizations_url":"https://api.github.com/users/longld/orgs","repos_url":"https://api.github.com/users/longld/repos","events_url":"https://api.github.com/users/longld/events{/privacy}","received_events_url":"https://api.github.com/users/longld/received_events","type":"User","site_admin":false},"repo":{"id":5282021,"name":"peda","full_name":"longld/peda","owner":{"login":"longld","id":38460,"avatar_url":"https://avatars.githubusercontent.com/u/38460?v=3","gravatar_id":"","url":"https://api.github.com/users/longld","html_url":"https://github.com/longld","followers_url":"https://api.github.com/users/longld/followers","following_url":"https://api.github.com/users/longld/following{/other_user}","gists_url":"https://api.github.com/users/longld/gists{/gist_id}","starred_url":"https://api.github.com/users/longld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longld/subscriptions","organizations_url":"https://api.github.com/users/longld/orgs","repos_url":"https://api.github.com/users/longld/repos","events_url":"https://api.github.com/users/longld/events{/privacy}","received_events_url":"https://api.github.com/users/longld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/longld/peda","description":"PEDA - Python Exploit Development Assistance for GDB","fork":false,"url":"https://api.github.com/repos/longld/peda","forks_url":"https://api.github.com/repos/longld/peda/forks","keys_url":"https://api.github.com/repos/longld/peda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/longld/peda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/longld/peda/teams","hooks_url":"https://api.github.com/repos/longld/peda/hooks","issue_events_url":"https://api.github.com/repos/longld/peda/issues/events{/number}","events_url":"https://api.github.com/repos/longld/peda/events","assignees_url":"https://api.github.com/repos/longld/peda/assignees{/user}","branches_url":"https://api.github.com/repos/longld/peda/branches{/branch}","tags_url":"https://api.github.com/repos/longld/peda/tags","blobs_url":"https://api.github.com/repos/longld/peda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/longld/peda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/longld/peda/git/refs{/sha}","trees_url":"https://api.github.com/repos/longld/peda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/longld/peda/statuses/{sha}","languages_url":"https://api.github.com/repos/longld/peda/languages","stargazers_url":"https://api.github.com/repos/longld/peda/stargazers","contributors_url":"https://api.github.com/repos/longld/peda/contributors","subscribers_url":"https://api.github.com/repos/longld/peda/subscribers","subscription_url":"https://api.github.com/repos/longld/peda/subscription","commits_url":"https://api.github.com/repos/longld/peda/commits{/sha}","git_commits_url":"https://api.github.com/repos/longld/peda/git/commits{/sha}","comments_url":"https://api.github.com/repos/longld/peda/comments{/number}","issue_comment_url":"https://api.github.com/repos/longld/peda/issues/comments{/number}","contents_url":"https://api.github.com/repos/longld/peda/contents/{+path}","compare_url":"https://api.github.com/repos/longld/peda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/longld/peda/merges","archive_url":"https://api.github.com/repos/longld/peda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/longld/peda/downloads","issues_url":"https://api.github.com/repos/longld/peda/issues{/number}","pulls_url":"https://api.github.com/repos/longld/peda/pulls{/number}","milestones_url":"https://api.github.com/repos/longld/peda/milestones{/number}","notifications_url":"https://api.github.com/repos/longld/peda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/longld/peda/labels{/name}","releases_url":"https://api.github.com/repos/longld/peda/releases{/id}","deployments_url":"https://api.github.com/repos/longld/peda/deployments","created_at":"2012-08-03T06:26:41Z","updated_at":"2016-06-23T03:00:59Z","pushed_at":"2016-06-23T14:16:14Z","git_url":"git://github.com/longld/peda.git","ssh_url":"git@github.com:longld/peda.git","clone_url":"https://github.com/longld/peda.git","svn_url":"https://github.com/longld/peda","homepage":null,"size":469,"stargazers_count":1119,"watchers_count":1119,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":19,"forks":247,"open_issues":19,"watchers":1119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/longld/peda/pulls/82"},"html":{"href":"https://github.com/longld/peda/pull/82"},"issue":{"href":"https://api.github.com/repos/longld/peda/issues/82"},"comments":{"href":"https://api.github.com/repos/longld/peda/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/longld/peda/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/longld/peda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/longld/peda/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/longld/peda/statuses/471b99b0d63689e12e912fa7f91921af206062df"}}}}
{"actor":{"display_login":"aquynh"}}