{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/ripple-lib-java/issues/72","repository_url":"https://api.github.com/repos/ripple/ripple-lib-java","labels_url":"https://api.github.com/repos/ripple/ripple-lib-java/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/ripple/ripple-lib-java/issues/72/comments","events_url":"https://api.github.com/repos/ripple/ripple-lib-java/issues/72/events","html_url":"https://github.com/ripple/ripple-lib-java/issues/72","id":111440546,"number":72,"title":"Hash prefix for inner nodes is wrong in documentation","user":{"login":"MarkusTeufelberger","id":950561,"avatar_url":"https://avatars.githubusercontent.com/u/950561?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkusTeufelberger","html_url":"https://github.com/MarkusTeufelberger","followers_url":"https://api.github.com/users/MarkusTeufelberger/followers","following_url":"https://api.github.com/users/MarkusTeufelberger/following{/other_user}","gists_url":"https://api.github.com/users/MarkusTeufelberger/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusTeufelberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusTeufelberger/subscriptions","organizations_url":"https://api.github.com/users/MarkusTeufelberger/orgs","repos_url":"https://api.github.com/users/MarkusTeufelberger/repos","events_url":"https://api.github.com/users/MarkusTeufelberger/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusTeufelberger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-14T16:45:41Z","updated_at":"2016-04-20T07:02:46Z","closed_at":null,"body":"https://github.com/ripple/ripple-lib-java/blob/master/ripple-core/src/main/java/com/ripple/core/types/shamap/README.md claims that \"Converted to ascii letters the hex 40494E00 is MIN\\x00, meaning sham)ap i)nner n)ode.\" - correct value would be \"4D494E00\" (40 --> 4D).\r\n\r\nThis is consistently used wrongly in that file.\r\n\r\nI'm also not able to hash the data from the \"7C0B1C90CD3AE3446F65A1F59B36E5C990A7386C1D513E224A59BA404B6ED58C\" node to that value - are the hashes just made up, or am I doing something wrong? I simply concatenated the 16 values in the shown order, added \"4D494E00\" in front, hashed the result with SHA512 and removed the last 256 bits."},"comment":{"url":"https://api.github.com/repos/ripple/ripple-lib-java/issues/comments/212289016","html_url":"https://github.com/ripple/ripple-lib-java/issues/72#issuecomment-212289016","issue_url":"https://api.github.com/repos/ripple/ripple-lib-java/issues/72","id":212289016,"user":{"login":"sublimator","id":525211,"avatar_url":"https://avatars.githubusercontent.com/u/525211?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimator","html_url":"https://github.com/sublimator","followers_url":"https://api.github.com/users/sublimator/followers","following_url":"https://api.github.com/users/sublimator/following{/other_user}","gists_url":"https://api.github.com/users/sublimator/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimator/subscriptions","organizations_url":"https://api.github.com/users/sublimator/orgs","repos_url":"https://api.github.com/users/sublimator/repos","events_url":"https://api.github.com/users/sublimator/events{/privacy}","received_events_url":"https://api.github.com/users/sublimator/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T07:02:46Z","updated_at":"2016-04-20T07:02:46Z","body":"Yeah, I don't know what went wrong there! I vaguely recall when writing this that I was using made up prefixes for examples, and then changed to try to use the real prefixes. Clearly I messed up somewhere.\r\n\r\nThe overall gist, if the not the details is correct though. I'll try and update with verified examples soon. Thanks for the report, and apologies for the slow response."}}