{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/84334765","pull_request_review_id":5088475,"id":84334765,"diff_hunk":"@@ -1,8 +1,8 @@\n <div class=\"modal-resource-action\">\n   <div class=\"modal-body\">\n     <h1>{{message}}</h1>\n+    <p ng-if=\"details\" ng-bind-html=\"details\"></p>","path":"app/views/modals/confirm.html","position":4,"original_position":4,"commit_id":"cd389ea5656b442896b1e39585d3d462d98cd596","original_commit_id":"cd389ea5656b442896b1e39585d3d462d98cd596","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"There is existing code that uses this dialog which might not be passing HTML sanitized values in details. This really need to be a separate property like `detailsMarkup` or something that makes it clear markup is expected.","created_at":"2016-10-20T17:28:19Z","updated_at":"2016-10-20T17:29:21Z","html_url":"https://github.com/openshift/origin-web-console/pull/562#discussion_r84334765","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/562","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/84334765"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/562#discussion_r84334765"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/562"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/562","id":86009724,"html_url":"https://github.com/openshift/origin-web-console/pull/562","diff_url":"https://github.com/openshift/origin-web-console/pull/562.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/562.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/562","number":562,"state":"open","locked":false,"title":"Project Membership","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"@ajacobs21e @jwforres @spadgett @enj \r\n\r\nTasks:\r\n- [x] On remove, ensure a user/group/etc in two different `rolebindings` for the same role is removed from both `rolebindings`. \r\n- [x]  On add, if there are two `rolebindings` for the same role, only add to one of the `rolebindings`.\r\n- [x] On add, check for duplicates,do not add a user/group/etc to a `rolebinding` if already present in the specified `rolebinding`\r\n- [x] On delete, if all subjects are removed from the `rolebinding`, delete the `rolebinding`\r\n- [x] Limit the # of roles a user can see by default, but provide checkbox to show all if desired\r\n- [x] work with @enj on a `end-user` type of annotation to show/hide roles (for above checkbox task)\r\n- [x] be sure to use the `description` annotation if present\r\n- [x] handle both clusterRoles & local roles (namespaced)\r\n\r\nPotential additional tasks (nice to have if they make sense):\r\n- [x] ~~Show/hide the membership menu item based on the user's ability to manage rolebindings?~~ Future\r\n- [x] Show/hide the \"edit\" functionality of the membership page based on the user's ability to manage rolebindings?\r\n- [x] ~~For non-admin users, it may be nice to show a list of \"what can I do\" for the project, since they will not be able to see the `rolebindings`, and showing them `local roles` & `clusterroles` that they cannot interact with is not helpful~~ Future perhaps\r\n- [x]  ~~On add, if user/group/etc is already a part of another role, can offer to update that role if it is sensible (ie, if in `view` and is added to `admin`, is not necessary for.~~ Not currently a \"weight\" or ranking available via api for roles\r\n- [x] ~~create a new group, add users to group, assign group to a role?~~ nope. cluster admin only\r\n\r\nPrototype UI screenshots:\r\n\r\nFirst view hides many of the roles to keep the picker sane:\r\n![screen shot 2016-09-20 at 10 43 09 am](https://cloud.githubusercontent.com/assets/280512/18679135/51b82560-7f2c-11e6-8996-c6e94f38a126.png)\r\nSecond view shows everything, it is reasonable someone will want to interact with these at some point:\r\n![screen shot 2016-09-20 at 10 43 32 am](https://cloud.githubusercontent.com/assets/280512/18679134/51b13386-7f2c-11e6-93a4-7f2248694c24.png)\r\n\r\n\r\n","created_at":"2016-09-20T16:23:57Z","updated_at":"2016-10-20T17:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"711ee45b4ca85b44023751a170fc7895606a7b95","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/562/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/562/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/562/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/cd389ea5656b442896b1e39585d3d462d98cd596","head":{"label":"benjaminapetersen:bpeterse/membership","ref":"bpeterse/membership","sha":"cd389ea5656b442896b1e39585d3d462d98cd596","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"repo":{"id":58689425,"name":"origin-web-console","full_name":"benjaminapetersen/origin-web-console","owner":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminapetersen/origin-web-console","description":null,"fork":true,"url":"https://api.github.com/repos/benjaminapetersen/origin-web-console","forks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/forks","keys_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/teams","hooks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/events","assignees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/tags","blobs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/subscription","commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/merges","archive_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/downloads","issues_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/deployments","created_at":"2016-05-13T01:31:58Z","updated_at":"2016-05-13T01:31:59Z","pushed_at":"2016-10-20T16:00:08Z","git_url":"git://github.com/benjaminapetersen/origin-web-console.git","ssh_url":"git@github.com:benjaminapetersen/origin-web-console.git","clone_url":"https://github.com/benjaminapetersen/origin-web-console.git","svn_url":"https://github.com/benjaminapetersen/origin-web-console","homepage":null,"size":15988,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"2b6d3f1daf4532b0cabbe55df61acb6b31ca27f5","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-10-07T13:19:44Z","pushed_at":"2016-10-20T16:00:10Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":17050,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":78,"forks":55,"open_issues":78,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/562"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/562"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/562"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/562/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/562/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/562/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/cd389ea5656b442896b1e39585d3d462d98cd596"}}}}
{"actor":{"display_login":"spadgett"}}