{"action":"opened","number":589,"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/589","id":91875342,"html_url":"https://github.com/Microsoft/react-native-code-push/pull/589","diff_url":"https://github.com/Microsoft/react-native-code-push/pull/589.diff","patch_url":"https://github.com/Microsoft/react-native-code-push/pull/589.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/589","number":589,"state":"open","locked":false,"title":"[Android] Let npm take care of versioning","user":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars.githubusercontent.com/u/346214?v=3","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"body":"From [build.gradle](https://github.com/Microsoft/react-native-code-push/blob/master/android/app/build.gradle#L24):\r\n\r\n    dependencies {\r\n        compile \"com.facebook.react:react-native:0.19.+\"\r\n    }\r\n\r\nThis means that when adding the react-native-code-push module to an app and building it, Gradle will fetch React Native 0.19 from Maven, even if the app is using say RN 0.34. We stopped releasing the React Native Android artifacts to Maven - they are distributed via npm along with the JS code.\r\n\r\nWould you consider using `compile 'com.facebook.react:react-native:+'` instead, as for example [react-native-push-notification](https://github.com/zo0r/react-native-push-notification/blob/master/android/build.gradle) do [react-native-maps](https://github.com/airbnb/react-native-maps/blob/master/android/build.gradle#L56) do?\r\n\r\nIf this doesn't make sense for some reason feel free to close this pull request. But I thought explicitly depending on a very old RN version looked wrong.\r\n","created_at":"2016-11-01T22:21:12Z","updated_at":"2016-11-01T22:21:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/589/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/589/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/589/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-code-push/statuses/41ff219a8cfce272bd1c47ad6cbc81341d2f2427","head":{"label":"mkonicek:gradle_latest","ref":"gradle_latest","sha":"41ff219a8cfce272bd1c47ad6cbc81341d2f2427","user":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars.githubusercontent.com/u/346214?v=3","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"repo":{"id":72581495,"name":"react-native-code-push","full_name":"mkonicek/react-native-code-push","owner":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars.githubusercontent.com/u/346214?v=3","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkonicek/react-native-code-push","description":"React Native module for CodePush","fork":true,"url":"https://api.github.com/repos/mkonicek/react-native-code-push","forks_url":"https://api.github.com/repos/mkonicek/react-native-code-push/forks","keys_url":"https://api.github.com/repos/mkonicek/react-native-code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkonicek/react-native-code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkonicek/react-native-code-push/teams","hooks_url":"https://api.github.com/repos/mkonicek/react-native-code-push/hooks","issue_events_url":"https://api.github.com/repos/mkonicek/react-native-code-push/issues/events{/number}","events_url":"https://api.github.com/repos/mkonicek/react-native-code-push/events","assignees_url":"https://api.github.com/repos/mkonicek/react-native-code-push/assignees{/user}","branches_url":"https://api.github.com/repos/mkonicek/react-native-code-push/branches{/branch}","tags_url":"https://api.github.com/repos/mkonicek/react-native-code-push/tags","blobs_url":"https://api.github.com/repos/mkonicek/react-native-code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkonicek/react-native-code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkonicek/react-native-code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkonicek/react-native-code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkonicek/react-native-code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/mkonicek/react-native-code-push/languages","stargazers_url":"https://api.github.com/repos/mkonicek/react-native-code-push/stargazers","contributors_url":"https://api.github.com/repos/mkonicek/react-native-code-push/contributors","subscribers_url":"https://api.github.com/repos/mkonicek/react-native-code-push/subscribers","subscription_url":"https://api.github.com/repos/mkonicek/react-native-code-push/subscription","commits_url":"https://api.github.com/repos/mkonicek/react-native-code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkonicek/react-native-code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkonicek/react-native-code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkonicek/react-native-code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkonicek/react-native-code-push/contents/{+path}","compare_url":"https://api.github.com/repos/mkonicek/react-native-code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkonicek/react-native-code-push/merges","archive_url":"https://api.github.com/repos/mkonicek/react-native-code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkonicek/react-native-code-push/downloads","issues_url":"https://api.github.com/repos/mkonicek/react-native-code-push/issues{/number}","pulls_url":"https://api.github.com/repos/mkonicek/react-native-code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/mkonicek/react-native-code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/mkonicek/react-native-code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkonicek/react-native-code-push/labels{/name}","releases_url":"https://api.github.com/repos/mkonicek/react-native-code-push/releases{/id}","deployments_url":"https://api.github.com/repos/mkonicek/react-native-code-push/deployments","created_at":"2016-11-01T22:17:27Z","updated_at":"2016-11-01T22:17:29Z","pushed_at":"2016-11-01T22:19:48Z","git_url":"git://github.com/mkonicek/react-native-code-push.git","ssh_url":"git@github.com:mkonicek/react-native-code-push.git","clone_url":"https://github.com/mkonicek/react-native-code-push.git","svn_url":"https://github.com/mkonicek/react-native-code-push","homepage":"http://codepush.tools","size":7903,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5bcea7be3566984a3fb7368603ff8c0e264afa39","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36749153,"name":"react-native-code-push","full_name":"Microsoft/react-native-code-push","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/react-native-code-push","description":"React Native module for CodePush","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-code-push","forks_url":"https://api.github.com/repos/Microsoft/react-native-code-push/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-code-push/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-code-push/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-code-push/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-code-push/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-code-push/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-code-push/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-code-push/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-code-push/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-code-push/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-code-push/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-code-push/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-code-push/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-code-push/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-code-push/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-code-push/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-code-push/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/deployments","created_at":"2015-06-02T17:19:20Z","updated_at":"2016-11-01T18:23:35Z","pushed_at":"2016-11-01T05:30:11Z","git_url":"git://github.com/Microsoft/react-native-code-push.git","ssh_url":"git@github.com:Microsoft/react-native-code-push.git","clone_url":"https://github.com/Microsoft/react-native-code-push.git","svn_url":"https://github.com/Microsoft/react-native-code-push","homepage":"http://codepush.tools","size":7903,"stargazers_count":1810,"watchers_count":1810,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":33,"forks":223,"open_issues":33,"watchers":1810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/589"},"html":{"href":"https://github.com/Microsoft/react-native-code-push/pull/589"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/589"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-code-push/statuses/41ff219a8cfce272bd1c47ad6cbc81341d2f2427"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mkonicek"}}