{"action":"created","comment":{"url":"https://api.github.com/repos/docker/hyperkit/pulls/comments/64220407","id":64220407,"diff_hunk":"@@ -78,15 +78,37 @@\n #include <xhyve/mevent.h>\n #include <xhyve/virtio.h>\n \n-#include \"protocol.h\"\n-#include \"utils.h\"\n-\n #define WPRINTF(format, ...) printf(format, __VA_ARGS__)\n \n #define VTNET_RINGSZ 1024\n #define VTNET_MAXSEGS 32\n \n /*\n+ * wire protocol\n+ */\n+struct msg_init {\n+\tuint8_t magic[5]; /* VMN3T */\n+\tuint32_t version;\n+\tuint8_t commit[40];\n+} __packed;\n+\n+#define CMD_ETHERNET 1\n+struct msg_common {\n+\tuint8_t command;\n+} __packed;\n+\n+struct msg_ethernet {\n+\tuint8_t command; /* CMD_ETHERNET */\n+\tchar uuid[36];\n+} __packed;\n+\n+struct vif_info {\n+\tuint16_t mtu;\n+\tuint16_t max_packet_size;\n+\tuint8_t mac[6];\n+} /*__packed*/;","path":"src/pci_virtio_net_vpnkit.c","position":35,"original_position":35,"commit_id":"26dbab99cc2cc4178afe0f80b185fdffc5198072","original_commit_id":"26dbab99cc2cc4178afe0f80b185fdffc5198072","user":{"login":"ijc25","id":12985729,"avatar_url":"https://avatars.githubusercontent.com/u/12985729?v=3","gravatar_id":"","url":"https://api.github.com/users/ijc25","html_url":"https://github.com/ijc25","followers_url":"https://api.github.com/users/ijc25/followers","following_url":"https://api.github.com/users/ijc25/following{/other_user}","gists_url":"https://api.github.com/users/ijc25/gists{/gist_id}","starred_url":"https://api.github.com/users/ijc25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijc25/subscriptions","organizations_url":"https://api.github.com/users/ijc25/orgs","repos_url":"https://api.github.com/users/ijc25/repos","events_url":"https://api.github.com/users/ijc25/events{/privacy}","received_events_url":"https://api.github.com/users/ijc25/received_events","type":"User","site_admin":false},"body":"Clang complained (with an error) that the struct was already naturally packed and so therefore the annotation was unnecessary. I left it in mainly for its documentary effects (personally I think the error was actively harmful...)","created_at":"2016-05-23T13:18:09Z","updated_at":"2016-05-23T13:18:09Z","html_url":"https://github.com/docker/hyperkit/pull/27#discussion_r64220407","pull_request_url":"https://api.github.com/repos/docker/hyperkit/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/docker/hyperkit/pulls/comments/64220407"},"html":{"href":"https://github.com/docker/hyperkit/pull/27#discussion_r64220407"},"pull_request":{"href":"https://api.github.com/repos/docker/hyperkit/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/docker/hyperkit/pulls/27","id":70880607,"html_url":"https://github.com/docker/hyperkit/pull/27","diff_url":"https://github.com/docker/hyperkit/pull/27.diff","patch_url":"https://github.com/docker/hyperkit/pull/27.patch","issue_url":"https://api.github.com/repos/docker/hyperkit/issues/27","number":27,"state":"open","locked":false,"title":"Rename/port net_ipc virtio backend to net_vpnkit","user":{"login":"ijc25","id":12985729,"avatar_url":"https://avatars.githubusercontent.com/u/12985729?v=3","gravatar_id":"","url":"https://api.github.com/users/ijc25","html_url":"https://github.com/ijc25","followers_url":"https://api.github.com/users/ijc25/followers","following_url":"https://api.github.com/users/ijc25/following{/other_user}","gists_url":"https://api.github.com/users/ijc25/gists{/gist_id}","starred_url":"https://api.github.com/users/ijc25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijc25/subscriptions","organizations_url":"https://api.github.com/users/ijc25/orgs","repos_url":"https://api.github.com/users/ijc25/repos","events_url":"https://api.github.com/users/ijc25/events{/privacy}","received_events_url":"https://api.github.com/users/ijc25/received_events","type":"User","site_admin":false},"body":"When this was developed vpnkit didn't yet have a name, now that it does rename\r\nit to fit and add the frontend protocol inline instead of expecting it\r\nexternally (and simplify things along the way).\r\n\r\nSigned-off-by: Ian Campbell <ian.campbell@docker.com>","created_at":"2016-05-20T16:15:53Z","updated_at":"2016-05-23T13:18:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35a7155a670c6dc3e940eb9635bccaff0d1fb458","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/hyperkit/pulls/27/commits","review_comments_url":"https://api.github.com/repos/docker/hyperkit/pulls/27/comments","review_comment_url":"https://api.github.com/repos/docker/hyperkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/hyperkit/issues/27/comments","statuses_url":"https://api.github.com/repos/docker/hyperkit/statuses/26dbab99cc2cc4178afe0f80b185fdffc5198072","head":{"label":"ijc25:vpnkit","ref":"vpnkit","sha":"26dbab99cc2cc4178afe0f80b185fdffc5198072","user":{"login":"ijc25","id":12985729,"avatar_url":"https://avatars.githubusercontent.com/u/12985729?v=3","gravatar_id":"","url":"https://api.github.com/users/ijc25","html_url":"https://github.com/ijc25","followers_url":"https://api.github.com/users/ijc25/followers","following_url":"https://api.github.com/users/ijc25/following{/other_user}","gists_url":"https://api.github.com/users/ijc25/gists{/gist_id}","starred_url":"https://api.github.com/users/ijc25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijc25/subscriptions","organizations_url":"https://api.github.com/users/ijc25/orgs","repos_url":"https://api.github.com/users/ijc25/repos","events_url":"https://api.github.com/users/ijc25/events{/privacy}","received_events_url":"https://api.github.com/users/ijc25/received_events","type":"User","site_admin":false},"repo":{"id":59125670,"name":"hyperkit","full_name":"ijc25/hyperkit","owner":{"login":"ijc25","id":12985729,"avatar_url":"https://avatars.githubusercontent.com/u/12985729?v=3","gravatar_id":"","url":"https://api.github.com/users/ijc25","html_url":"https://github.com/ijc25","followers_url":"https://api.github.com/users/ijc25/followers","following_url":"https://api.github.com/users/ijc25/following{/other_user}","gists_url":"https://api.github.com/users/ijc25/gists{/gist_id}","starred_url":"https://api.github.com/users/ijc25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijc25/subscriptions","organizations_url":"https://api.github.com/users/ijc25/orgs","repos_url":"https://api.github.com/users/ijc25/repos","events_url":"https://api.github.com/users/ijc25/events{/privacy}","received_events_url":"https://api.github.com/users/ijc25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ijc25/hyperkit","description":"A toolkit for embedding hypervisor capabilities in your application","fork":true,"url":"https://api.github.com/repos/ijc25/hyperkit","forks_url":"https://api.github.com/repos/ijc25/hyperkit/forks","keys_url":"https://api.github.com/repos/ijc25/hyperkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijc25/hyperkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijc25/hyperkit/teams","hooks_url":"https://api.github.com/repos/ijc25/hyperkit/hooks","issue_events_url":"https://api.github.com/repos/ijc25/hyperkit/issues/events{/number}","events_url":"https://api.github.com/repos/ijc25/hyperkit/events","assignees_url":"https://api.github.com/repos/ijc25/hyperkit/assignees{/user}","branches_url":"https://api.github.com/repos/ijc25/hyperkit/branches{/branch}","tags_url":"https://api.github.com/repos/ijc25/hyperkit/tags","blobs_url":"https://api.github.com/repos/ijc25/hyperkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijc25/hyperkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijc25/hyperkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijc25/hyperkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijc25/hyperkit/statuses/{sha}","languages_url":"https://api.github.com/repos/ijc25/hyperkit/languages","stargazers_url":"https://api.github.com/repos/ijc25/hyperkit/stargazers","contributors_url":"https://api.github.com/repos/ijc25/hyperkit/contributors","subscribers_url":"https://api.github.com/repos/ijc25/hyperkit/subscribers","subscription_url":"https://api.github.com/repos/ijc25/hyperkit/subscription","commits_url":"https://api.github.com/repos/ijc25/hyperkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijc25/hyperkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijc25/hyperkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijc25/hyperkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijc25/hyperkit/contents/{+path}","compare_url":"https://api.github.com/repos/ijc25/hyperkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijc25/hyperkit/merges","archive_url":"https://api.github.com/repos/ijc25/hyperkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijc25/hyperkit/downloads","issues_url":"https://api.github.com/repos/ijc25/hyperkit/issues{/number}","pulls_url":"https://api.github.com/repos/ijc25/hyperkit/pulls{/number}","milestones_url":"https://api.github.com/repos/ijc25/hyperkit/milestones{/number}","notifications_url":"https://api.github.com/repos/ijc25/hyperkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijc25/hyperkit/labels{/name}","releases_url":"https://api.github.com/repos/ijc25/hyperkit/releases{/id}","deployments_url":"https://api.github.com/repos/ijc25/hyperkit/deployments","created_at":"2016-05-18T14:58:32Z","updated_at":"2016-05-18T15:01:47Z","pushed_at":"2016-05-23T11:04:33Z","git_url":"git://github.com/ijc25/hyperkit.git","ssh_url":"git@github.com:ijc25/hyperkit.git","clone_url":"https://github.com/ijc25/hyperkit.git","svn_url":"https://github.com/ijc25/hyperkit","homepage":"","size":11790,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"e7147841cf2099c63fbae0ccb6f3f716e529e258","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":55985023,"name":"hyperkit","full_name":"docker/hyperkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/hyperkit","description":"A toolkit for embedding hypervisor capabilities in your application","fork":false,"url":"https://api.github.com/repos/docker/hyperkit","forks_url":"https://api.github.com/repos/docker/hyperkit/forks","keys_url":"https://api.github.com/repos/docker/hyperkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/hyperkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/hyperkit/teams","hooks_url":"https://api.github.com/repos/docker/hyperkit/hooks","issue_events_url":"https://api.github.com/repos/docker/hyperkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/hyperkit/events","assignees_url":"https://api.github.com/repos/docker/hyperkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/hyperkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/hyperkit/tags","blobs_url":"https://api.github.com/repos/docker/hyperkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/hyperkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/hyperkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/hyperkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/hyperkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/hyperkit/languages","stargazers_url":"https://api.github.com/repos/docker/hyperkit/stargazers","contributors_url":"https://api.github.com/repos/docker/hyperkit/contributors","subscribers_url":"https://api.github.com/repos/docker/hyperkit/subscribers","subscription_url":"https://api.github.com/repos/docker/hyperkit/subscription","commits_url":"https://api.github.com/repos/docker/hyperkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/hyperkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/hyperkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/hyperkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/hyperkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/hyperkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/hyperkit/merges","archive_url":"https://api.github.com/repos/docker/hyperkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/hyperkit/downloads","issues_url":"https://api.github.com/repos/docker/hyperkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/hyperkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/hyperkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/hyperkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/hyperkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/hyperkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/hyperkit/deployments","created_at":"2016-04-11T15:36:20Z","updated_at":"2016-05-23T08:22:23Z","pushed_at":"2016-05-23T13:12:30Z","git_url":"git://github.com/docker/hyperkit.git","ssh_url":"git@github.com:docker/hyperkit.git","clone_url":"https://github.com/docker/hyperkit.git","svn_url":"https://github.com/docker/hyperkit","homepage":"","size":11793,"stargazers_count":213,"watchers_count":213,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":7,"forks":32,"open_issues":7,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/hyperkit/pulls/27"},"html":{"href":"https://github.com/docker/hyperkit/pull/27"},"issue":{"href":"https://api.github.com/repos/docker/hyperkit/issues/27"},"comments":{"href":"https://api.github.com/repos/docker/hyperkit/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/hyperkit/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/hyperkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/hyperkit/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/docker/hyperkit/statuses/26dbab99cc2cc4178afe0f80b185fdffc5198072"}}}}
{"actor":{"display_login":"ijc25"}}