{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/64653585","id":64653585,"diff_hunk":"@@ -230,7 +230,7 @@ test(\"push(promise)\", function(assert) {\n     push = familyReference.push(deferred.promise);\n   });\n \n-  assert.ok(push.then, 'BelongsToReference.push returns a promise');\n+  assert.ok(push instanceof Ember.RSVP.Promise, 'BelongsToReference.push() returns a promise');","path":"tests/integration/references/belongs-to-test.js","position":5,"original_position":5,"commit_id":"ee5c9a2715bc0bc0a29bd9108effab15c541d502","original_commit_id":"ee5c9a2715bc0bc0a29bd9108effab15c541d502","user":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=3","gravatar_id":"","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"body":"maybe `! instanceof PromiseProxyObject` ? might be the most clear, as well as updating the description.","created_at":"2016-05-25T21:08:14Z","updated_at":"2016-05-25T21:08:14Z","html_url":"https://github.com/emberjs/data/pull/4401#discussion_r64653585","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/4401","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/64653585"},"html":{"href":"https://github.com/emberjs/data/pull/4401#discussion_r64653585"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/4401"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/4401","id":71353048,"html_url":"https://github.com/emberjs/data/pull/4401","diff_url":"https://github.com/emberjs/data/pull/4401.diff","patch_url":"https://github.com/emberjs/data/pull/4401.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/4401","number":4401,"state":"open","locked":false,"title":"[BUGFIX beta] References load() enhancements","user":{"login":"tchak","id":12428,"avatar_url":"https://avatars.githubusercontent.com/u/12428?v=3","gravatar_id":"","url":"https://api.github.com/users/tchak","html_url":"https://github.com/tchak","followers_url":"https://api.github.com/users/tchak/followers","following_url":"https://api.github.com/users/tchak/following{/other_user}","gists_url":"https://api.github.com/users/tchak/gists{/gist_id}","starred_url":"https://api.github.com/users/tchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchak/subscriptions","organizations_url":"https://api.github.com/users/tchak/orgs","repos_url":"https://api.github.com/users/tchak/repos","events_url":"https://api.github.com/users/tchak/events{/privacy}","received_events_url":"https://api.github.com/users/tchak/received_events","type":"User","site_admin":false},"body":"* ensure reference.load() is always returning a simple RSVP.Promise not an ObjectProxy\r\n* Make `isLoaded` public\r\n* Check if belongsTo reference record is actually loaded\r\n\r\nI don't expect any breaking changes here.","created_at":"2016-05-25T08:56:28Z","updated_at":"2016-05-25T21:08:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca719768f7124df6a390e1a2896067899f0c47f9","assignee":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/4401/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/4401/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/4401/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/ee5c9a2715bc0bc0a29bd9108effab15c541d502","head":{"label":"tchak:cleanup-references-tests","ref":"cleanup-references-tests","sha":"ee5c9a2715bc0bc0a29bd9108effab15c541d502","user":{"login":"tchak","id":12428,"avatar_url":"https://avatars.githubusercontent.com/u/12428?v=3","gravatar_id":"","url":"https://api.github.com/users/tchak","html_url":"https://github.com/tchak","followers_url":"https://api.github.com/users/tchak/followers","following_url":"https://api.github.com/users/tchak/following{/other_user}","gists_url":"https://api.github.com/users/tchak/gists{/gist_id}","starred_url":"https://api.github.com/users/tchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchak/subscriptions","organizations_url":"https://api.github.com/users/tchak/orgs","repos_url":"https://api.github.com/users/tchak/repos","events_url":"https://api.github.com/users/tchak/events{/privacy}","received_events_url":"https://api.github.com/users/tchak/received_events","type":"User","site_admin":false},"repo":{"id":3018509,"name":"data","full_name":"tchak/data","owner":{"login":"tchak","id":12428,"avatar_url":"https://avatars.githubusercontent.com/u/12428?v=3","gravatar_id":"","url":"https://api.github.com/users/tchak","html_url":"https://github.com/tchak","followers_url":"https://api.github.com/users/tchak/followers","following_url":"https://api.github.com/users/tchak/following{/other_user}","gists_url":"https://api.github.com/users/tchak/gists{/gist_id}","starred_url":"https://api.github.com/users/tchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchak/subscriptions","organizations_url":"https://api.github.com/users/tchak/orgs","repos_url":"https://api.github.com/users/tchak/repos","events_url":"https://api.github.com/users/tchak/events{/privacy}","received_events_url":"https://api.github.com/users/tchak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tchak/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/tchak/data","forks_url":"https://api.github.com/repos/tchak/data/forks","keys_url":"https://api.github.com/repos/tchak/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tchak/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tchak/data/teams","hooks_url":"https://api.github.com/repos/tchak/data/hooks","issue_events_url":"https://api.github.com/repos/tchak/data/issues/events{/number}","events_url":"https://api.github.com/repos/tchak/data/events","assignees_url":"https://api.github.com/repos/tchak/data/assignees{/user}","branches_url":"https://api.github.com/repos/tchak/data/branches{/branch}","tags_url":"https://api.github.com/repos/tchak/data/tags","blobs_url":"https://api.github.com/repos/tchak/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tchak/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tchak/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/tchak/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tchak/data/statuses/{sha}","languages_url":"https://api.github.com/repos/tchak/data/languages","stargazers_url":"https://api.github.com/repos/tchak/data/stargazers","contributors_url":"https://api.github.com/repos/tchak/data/contributors","subscribers_url":"https://api.github.com/repos/tchak/data/subscribers","subscription_url":"https://api.github.com/repos/tchak/data/subscription","commits_url":"https://api.github.com/repos/tchak/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/tchak/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/tchak/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/tchak/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/tchak/data/contents/{+path}","compare_url":"https://api.github.com/repos/tchak/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tchak/data/merges","archive_url":"https://api.github.com/repos/tchak/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tchak/data/downloads","issues_url":"https://api.github.com/repos/tchak/data/issues{/number}","pulls_url":"https://api.github.com/repos/tchak/data/pulls{/number}","milestones_url":"https://api.github.com/repos/tchak/data/milestones{/number}","notifications_url":"https://api.github.com/repos/tchak/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tchak/data/labels{/name}","releases_url":"https://api.github.com/repos/tchak/data/releases{/id}","deployments_url":"https://api.github.com/repos/tchak/data/deployments","created_at":"2011-12-20T09:32:45Z","updated_at":"2014-05-13T12:53:05Z","pushed_at":"2016-05-25T13:00:14Z","git_url":"git://github.com/tchak/data.git","ssh_url":"git@github.com:tchak/data.git","clone_url":"https://github.com/tchak/data.git","svn_url":"https://github.com/tchak/data","homepage":"","size":11824,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"tchak"}},"base":{"label":"emberjs:master","ref":"master","sha":"ac1a6660904fe409aa8bc87e3edc7f27c319a57e","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2016-05-24T16:08:47Z","pushed_at":"2016-05-25T15:48:49Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":20090,"stargazers_count":2681,"watchers_count":2681,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1055,"mirror_url":null,"open_issues_count":199,"forks":1055,"open_issues":199,"watchers":2681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/4401"},"html":{"href":"https://github.com/emberjs/data/pull/4401"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/4401"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/4401/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/4401/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/4401/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/ee5c9a2715bc0bc0a29bd9108effab15c541d502"}}}}
{"actor":{"display_login":"fivetanley"}}