{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/81053271","pull_request_review_id":2061816,"id":81053271,"diff_hunk":"@@ -25,6 +25,12 @@\n # 5. And release mode (/m[:<N>] is also supported)\n #        msbuild rocksdb.sln /p:Configuration=Release\n #\n+# Linux:\n+#\n+# 1. Install a recent toolchain such as devtoolset-3 if you're on a older distro. C++11 recommended","path":"CMakeLists.txt","position":15,"original_position":15,"commit_id":"777ffcb5021ccbc2f2471dc3bd781c9eccbed607","original_commit_id":"777ffcb5021ccbc2f2471dc3bd781c9eccbed607","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"actually, C++11 support is a must-have.","created_at":"2016-09-29T02:00:43Z","updated_at":"2016-09-29T02:00:43Z","html_url":"https://github.com/facebook/rocksdb/pull/1364#discussion_r81053271","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1364","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/81053271"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1364#discussion_r81053271"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1364"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/1364","id":87225276,"html_url":"https://github.com/facebook/rocksdb/pull/1364","diff_url":"https://github.com/facebook/rocksdb/pull/1364.diff","patch_url":"https://github.com/facebook/rocksdb/pull/1364.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/1364","number":1364,"state":"open","locked":false,"title":"[cmake] Fixup a couple of builds errors on Linux.","user":{"login":"adsharma","id":658691,"avatar_url":"https://avatars.githubusercontent.com/u/658691?v=3","gravatar_id":"","url":"https://api.github.com/users/adsharma","html_url":"https://github.com/adsharma","followers_url":"https://api.github.com/users/adsharma/followers","following_url":"https://api.github.com/users/adsharma/following{/other_user}","gists_url":"https://api.github.com/users/adsharma/gists{/gist_id}","starred_url":"https://api.github.com/users/adsharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adsharma/subscriptions","organizations_url":"https://api.github.com/users/adsharma/orgs","repos_url":"https://api.github.com/users/adsharma/repos","events_url":"https://api.github.com/users/adsharma/events{/privacy}","received_events_url":"https://api.github.com/users/adsharma/received_events","type":"User","site_admin":false},"body":"The libraries produced on linux are now named\r\nlibrocksdb.a\r\nlibrocksdb.so\r\n\r\nAlso link with -lrt to avoid linker errors.\r\n\r\nGeneralize comments at the top to include Linux","created_at":"2016-09-29T00:16:00Z","updated_at":"2016-09-29T02:00:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60b7f4b53c5f53fe67ef13b557f00740b99ae51b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1364/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1364/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/1364/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/777ffcb5021ccbc2f2471dc3bd781c9eccbed607","head":{"label":"adsharma:cmake_0928","ref":"cmake_0928","sha":"777ffcb5021ccbc2f2471dc3bd781c9eccbed607","user":{"login":"adsharma","id":658691,"avatar_url":"https://avatars.githubusercontent.com/u/658691?v=3","gravatar_id":"","url":"https://api.github.com/users/adsharma","html_url":"https://github.com/adsharma","followers_url":"https://api.github.com/users/adsharma/followers","following_url":"https://api.github.com/users/adsharma/following{/other_user}","gists_url":"https://api.github.com/users/adsharma/gists{/gist_id}","starred_url":"https://api.github.com/users/adsharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adsharma/subscriptions","organizations_url":"https://api.github.com/users/adsharma/orgs","repos_url":"https://api.github.com/users/adsharma/repos","events_url":"https://api.github.com/users/adsharma/events{/privacy}","received_events_url":"https://api.github.com/users/adsharma/received_events","type":"User","site_admin":false},"repo":{"id":57001619,"name":"rocksdb","full_name":"adsharma/rocksdb","owner":{"login":"adsharma","id":658691,"avatar_url":"https://avatars.githubusercontent.com/u/658691?v=3","gravatar_id":"","url":"https://api.github.com/users/adsharma","html_url":"https://github.com/adsharma","followers_url":"https://api.github.com/users/adsharma/followers","following_url":"https://api.github.com/users/adsharma/following{/other_user}","gists_url":"https://api.github.com/users/adsharma/gists{/gist_id}","starred_url":"https://api.github.com/users/adsharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adsharma/subscriptions","organizations_url":"https://api.github.com/users/adsharma/orgs","repos_url":"https://api.github.com/users/adsharma/repos","events_url":"https://api.github.com/users/adsharma/events{/privacy}","received_events_url":"https://api.github.com/users/adsharma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adsharma/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/adsharma/rocksdb","forks_url":"https://api.github.com/repos/adsharma/rocksdb/forks","keys_url":"https://api.github.com/repos/adsharma/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adsharma/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adsharma/rocksdb/teams","hooks_url":"https://api.github.com/repos/adsharma/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/adsharma/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/adsharma/rocksdb/events","assignees_url":"https://api.github.com/repos/adsharma/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/adsharma/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/adsharma/rocksdb/tags","blobs_url":"https://api.github.com/repos/adsharma/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adsharma/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adsharma/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/adsharma/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adsharma/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/adsharma/rocksdb/languages","stargazers_url":"https://api.github.com/repos/adsharma/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/adsharma/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/adsharma/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/adsharma/rocksdb/subscription","commits_url":"https://api.github.com/repos/adsharma/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/adsharma/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/adsharma/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/adsharma/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/adsharma/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/adsharma/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adsharma/rocksdb/merges","archive_url":"https://api.github.com/repos/adsharma/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adsharma/rocksdb/downloads","issues_url":"https://api.github.com/repos/adsharma/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/adsharma/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/adsharma/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/adsharma/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adsharma/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/adsharma/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/adsharma/rocksdb/deployments","created_at":"2016-04-25T00:50:30Z","updated_at":"2016-04-25T00:50:34Z","pushed_at":"2016-09-29T00:29:40Z","git_url":"git://github.com/adsharma/rocksdb.git","ssh_url":"git@github.com:adsharma/rocksdb.git","clone_url":"https://github.com/adsharma/rocksdb.git","svn_url":"https://github.com/adsharma/rocksdb","homepage":"http://rocksdb.org","size":89789,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"87dfc1d23e0e16ff73e15f63c6fa0fb3b3fc8c8c","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2016-09-28T23:45:14Z","pushed_at":"2016-09-29T00:29:40Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":127907,"stargazers_count":6121,"watchers_count":6121,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1272,"mirror_url":null,"open_issues_count":264,"forks":1272,"open_issues":264,"watchers":6121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1364"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1364"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1364"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1364/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1364/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1364/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/777ffcb5021ccbc2f2471dc3bd781c9eccbed607"}}}}
{"actor":{"display_login":"tchaikov"}}