{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3676","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3676/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3676/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3676/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/3676","id":153097141,"number":3676,"title":"Advance extrusion algorithm – LIN_ADVANCE","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Improvement","name":"Improvement","color":"009800"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Needs:%20Testing","name":"Needs: Testing","color":"eb6420"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20New%20Feature","name":"PR: New Feature","color":"bfe5bf"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Status:%20Don't%20Merge","name":"Status: Don't Merge","color":"b60205"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-04T19:38:23Z","updated_at":"2016-05-05T10:18:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3676","html_url":"https://github.com/MarlinFirmware/Marlin/pull/3676","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/3676.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/3676.patch"},"body":"@Sebastianv650 has been working on this over on his fork. This is a patched up PR for compatibility with `stepper_indirection.h` which already handles multiple steppers for different features. This also keeps `Stepper::advance_isr` compatible with the upcoming Mixing Extruder feature.\r\n\r\n- Disable `LIN_ADVANCE` by default\r\n- Added a sanity check to prevent enabling both `ADVANCE` and `LIN_ADVANCE`\r\n- Blocks use `ENABLED(LIN_ADVANCE)`\r\n- Blocks use `#if ... #elif ... #endif` to group `LIN_ADVANCE` with `ADVANCE`\r\n- The `advance_isr` can be simplified due to macros in `stepper_indirection.h`\r\n\r\nReferences: MarlinFirmware/MarlinDev#402 #3655"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/217118776","html_url":"https://github.com/MarlinFirmware/Marlin/pull/3676#issuecomment-217118776","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3676","id":217118776,"user":{"login":"Blue-Marlin","id":17075493,"avatar_url":"https://avatars.githubusercontent.com/u/17075493?v=3","gravatar_id":"","url":"https://api.github.com/users/Blue-Marlin","html_url":"https://github.com/Blue-Marlin","followers_url":"https://api.github.com/users/Blue-Marlin/followers","following_url":"https://api.github.com/users/Blue-Marlin/following{/other_user}","gists_url":"https://api.github.com/users/Blue-Marlin/gists{/gist_id}","starred_url":"https://api.github.com/users/Blue-Marlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blue-Marlin/subscriptions","organizations_url":"https://api.github.com/users/Blue-Marlin/orgs","repos_url":"https://api.github.com/users/Blue-Marlin/repos","events_url":"https://api.github.com/users/Blue-Marlin/events{/privacy}","received_events_url":"https://api.github.com/users/Blue-Marlin/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T10:18:05Z","updated_at":"2016-05-05T10:18:05Z","body":"> That means for me, some research or learning is lost.\r\n\r\nClosed issues/PRs are not lost. You just have to include them in your search."}}