{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/exporter/issues/86","repository_url":"https://api.github.com/repos/sonata-project/exporter","labels_url":"https://api.github.com/repos/sonata-project/exporter/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/exporter/issues/86/comments","events_url":"https://api.github.com/repos/sonata-project/exporter/issues/86/events","html_url":"https://github.com/sonata-project/exporter/pull/86","id":155835463,"number":86,"title":"Add KnpSnappyWriter","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sonata-project/exporter/labels/review%20required","name":"review required","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-05-19T21:08:17Z","updated_at":"2016-05-20T09:19:19Z","closed_at":"2016-05-20T09:19:19Z","pull_request":{"url":"https://api.github.com/repos/sonata-project/exporter/pulls/86","html_url":"https://github.com/sonata-project/exporter/pull/86","diff_url":"https://github.com/sonata-project/exporter/pull/86.diff","patch_url":"https://github.com/sonata-project/exporter/pull/86.patch"},"body":"### Changelog\r\n\r\n```markdown\r\n### Added\r\n- Added pdf writer based on [knp/snappy](https://packagist.org/packages/knplabs/knp-snappy)\r\n```\r\n\r\n### Subject\r\n\r\nThis PR is my take on #76 , thanks @chalasr for what you already did\r\n\r\n### To do\r\n\r\n~~- [ ] consider relying on knp/snappy-bundle to inject the dependency~~ this is not a symfony bundle so we can't\r\n- [x] fix DIP violation (dependency on Pdf is not injected)\r\n- [x] write real unit tests (the tests that already exist are integration tests). Implies applying this : https://phpunit.de/manual/current/en/test-doubles.html#test-doubles.mocking-the-filesystem\r\n- [x] document usage\r\n"},"comment":{"url":"https://api.github.com/repos/sonata-project/exporter/issues/comments/220557131","html_url":"https://github.com/sonata-project/exporter/pull/86#issuecomment-220557131","issue_url":"https://api.github.com/repos/sonata-project/exporter/issues/86","id":220557131,"user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T09:19:19Z","updated_at":"2016-05-20T09:19:19Z","body":"Hmm so off-topic… I did not see that because I don't know the library that well… closing then."}}
{"actor":{"display_login":"greg0ire"}}