{"action":"closed","issue":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2315","repository_url":"https://api.github.com/repos/aspnet/EntityFramework","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2315/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2315/comments","events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2315/events","html_url":"https://github.com/aspnet/EntityFramework/issues/2315","id":84255762,"number":2315,"title":"Cache FromSql based on parameter types instead of values","user":{"login":"mikary","id":6787717,"avatar_url":"https://avatars.githubusercontent.com/u/6787717?v=3","gravatar_id":"","url":"https://api.github.com/users/mikary","html_url":"https://github.com/mikary","followers_url":"https://api.github.com/users/mikary/followers","following_url":"https://api.github.com/users/mikary/following{/other_user}","gists_url":"https://api.github.com/users/mikary/gists{/gist_id}","starred_url":"https://api.github.com/users/mikary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikary/subscriptions","organizations_url":"https://api.github.com/users/mikary/orgs","repos_url":"https://api.github.com/users/mikary/repos","events_url":"https://api.github.com/users/mikary/events{/privacy}","received_events_url":"https://api.github.com/users/mikary/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aspnet/EntityFramework/labels/2%20-%20Done","name":"2 - Done","color":"CCCCCC"},{"url":"https://api.github.com/repos/aspnet/EntityFramework/labels/perf","name":"perf","color":"fef2c0"},{"url":"https://api.github.com/repos/aspnet/EntityFramework/labels/test","name":"test","color":"c7def8"}],"state":"closed","locked":false,"assignee":{"login":"mikary","id":6787717,"avatar_url":"https://avatars.githubusercontent.com/u/6787717?v=3","gravatar_id":"","url":"https://api.github.com/users/mikary","html_url":"https://github.com/mikary","followers_url":"https://api.github.com/users/mikary/followers","following_url":"https://api.github.com/users/mikary/following{/other_user}","gists_url":"https://api.github.com/users/mikary/gists{/gist_id}","starred_url":"https://api.github.com/users/mikary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikary/subscriptions","organizations_url":"https://api.github.com/users/mikary/orgs","repos_url":"https://api.github.com/users/mikary/repos","events_url":"https://api.github.com/users/mikary/events{/privacy}","received_events_url":"https://api.github.com/users/mikary/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/aspnet/EntityFramework/milestones/7","html_url":"https://github.com/aspnet/EntityFramework/milestones/1.0.0","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/milestones/7/labels","id":666128,"number":7,"title":"1.0.0","description":"","creator":{"login":"rowanmiller","id":4741851,"avatar_url":"https://avatars.githubusercontent.com/u/4741851?v=3","gravatar_id":"","url":"https://api.github.com/users/rowanmiller","html_url":"https://github.com/rowanmiller","followers_url":"https://api.github.com/users/rowanmiller/followers","following_url":"https://api.github.com/users/rowanmiller/following{/other_user}","gists_url":"https://api.github.com/users/rowanmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanmiller/subscriptions","organizations_url":"https://api.github.com/users/rowanmiller/orgs","repos_url":"https://api.github.com/users/rowanmiller/repos","events_url":"https://api.github.com/users/rowanmiller/events{/privacy}","received_events_url":"https://api.github.com/users/rowanmiller/received_events","type":"User","site_admin":false},"open_issues":148,"closed_issues":65,"state":"open","created_at":"2014-05-21T19:25:32Z","updated_at":"2016-03-11T18:55:23Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-06-02T23:13:15Z","updated_at":"2016-03-11T18:55:23Z","closed_at":"2016-03-11T18:55:23Z","body":"The ```CompiledQueryCache``` adds a new entry for each unique set of argument values in the ```FromSql``` call. If we extract the parameters (SQL string and parameters object array) in query compilation and update the cache key to use the ```QueryAnnotation``` parameter types (using these parameters on SQL generation), the caching for ```FromSql``` will be more consistent with other query operations."}}