{"push_id":1462168815,"size":191,"distinct_size":6,"ref":"refs/heads/10.2_warnings","head":"bd5dc97383b1c0d15e22c72e672525ff6b6ca8a1","before":"780db8e25239e5423cfab50c04c60b79ebc0224b","commits":[{"sha":"e726ae6b045ec1b11553ea5e150c9751f1e270d9","author":{"name":"Lawrin Novitsky","email":"969edc65a11796097589b6c689793e4060ed61fd@mariadb.com"},"message":"Made all capability bit constants to be ULL. All new MariaDB\ncapabilities(in upper 32bits) were sent as 0 on 32bit Windows. They were\nreset because CLIENT_SSL, CLIENT_COMPRESS and CLIENT_SSL_VERIFY_SERVER_CERT were defined as UL\nPlus MARIADB_CLIENT_STMT_BULK_OPERATIONS was defined as 1UL << 34, and that is undefined operation.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/e726ae6b045ec1b11553ea5e150c9751f1e270d9"},{"sha":"89236a8ad93bbfa39b935afc8eabdaab5a1e2474","author":{"name":"Otto Kekäläinen","email":"2d9953888fdaa8611893a214bba2b31235035b3c@mariadb.org"},"message":"Deb: skip invoke-rc.d mysql stop if no mysql process is running at all\n\nQuite often in upgrades on systemd systems dpkg emitted an error like:\n\n  Failed to stop mysql.service: Unit mysql.service not loaded.\n  invoke-rc.d: initscript mysql, action \"stop\" failed.\n  invoke-rc.d returned 5\n  There is a MySQL server running, but we failed in our attempts to stop it.\n  Stop it yourself and try again!\n  dpkg: error processing archive /var/cache/apt/archives/mariadb-server-10.2\n\nThis is because the mariadb/mysql.service file is not loaded during\nthe upgrade/unpack stage of dpkg in certain situations. With this simple\ncheck we can easily skip the shutdown step when it is really not needed,\nwhich is for sure the case if no mysqld process at all is running on the\nentire system.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/89236a8ad93bbfa39b935afc8eabdaab5a1e2474"},{"sha":"e06e455eeaffa04fd551eb0012cd256480b2552a","author":{"name":"Otto Kekäläinen","email":"2d9953888fdaa8611893a214bba2b31235035b3c@mariadb.org"},"message":"Deb: make server core package breaks/replaces earlier client packages\n\nThis is required, as the innochecksum binary has moved package.\nWithout this change the following error would be emitted:\n\n  Unpacking mariadb-server-core-10.2 (10.2.3+maria~jessie) over (10.2.2+maria-1~jessie) ...\n  dpkg: error processing archive /var/cache/apt/archives/mariadb-server-core-10.2_10.2.3+maria~jessie_amd64.deb (--unpack):\n    trying to overwrite '/usr/bin/innochecksum', which is also in package mariadb-client-10.2 10.2.2+maria-1~jessie","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/e06e455eeaffa04fd551eb0012cd256480b2552a"},{"sha":"bb7e84b79ab5243392e3691c27d6d64566e26b39","author":{"name":"Sergey Vojtovich","email":"f7bb3c4d1423048768491a0d16a8f7427983335b@mariadb.org"},"message":"MDEV-11296 - InnoDB stalls under OLTP RW on P8\n\nSimplified away rw_lock_lock_word_incr().","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/bb7e84b79ab5243392e3691c27d6d64566e26b39"},{"sha":"8d010c44ef6f156566bcd5ff7fbdcf23ef96e92e","author":{"name":"Sergey Vojtovich","email":"f7bb3c4d1423048768491a0d16a8f7427983335b@mariadb.org"},"message":"MDEV-11296 - InnoDB stalls under OLTP RW on P8\n\nSimplified away rw_lock_get_waiters(), rw_lock_set_waiter_flag(),\nrw_lock_reset_waiter_flag(). Let waiters have predictable data type.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/8d010c44ef6f156566bcd5ff7fbdcf23ef96e92e"},{"sha":"68a853732750902fbd97e8ddd1a7f264f9b199c9","author":{"name":"Sergey Vojtovich","email":"f7bb3c4d1423048768491a0d16a8f7427983335b@mariadb.org"},"message":"MDEV-11296 - InnoDB stalls under OLTP RW on P8\n\nClean-up INNODB_RW_LOCKS_USE_ATOMICS: it is always set.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/68a853732750902fbd97e8ddd1a7f264f9b199c9"},{"sha":"fb7caad72b5c37e96c69aad63f9589f8b56855d6","author":{"name":"Sergey Vojtovich","email":"f7bb3c4d1423048768491a0d16a8f7427983335b@mariadb.org"},"message":"MDEV-11296 - InnoDB stalls under OLTP RW on P8\n\nSimplify away recursive flag: it is not necessary for rw-locks to operate\nproperly. Now writer_thread != 0 means recursive.\n\nAs we only need correct value of writer_thread only in writer_thread itself\nit is rather safe to load and update it non-atomically.\n\nThis patch also fixes potential reorder of \"writer_thread\" and \"recursive\"\nloads (aka MDEV-7148), which was reopened along with InnoDB thread fences\nsimplification. Previous versions are unaffected, because they have os_rmb\nin rw_lock_lock_word_decr(). It wasn't observed at the moment of writing\nthough.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/fb7caad72b5c37e96c69aad63f9589f8b56855d6"},{"sha":"1a1749e38c774ce3a3493da2410b19ebe71eccb5","author":{"name":"Sergey Vojtovich","email":"f7bb3c4d1423048768491a0d16a8f7427983335b@mariadb.org"},"message":"MDEV-11296 - InnoDB stalls under OLTP RW on P8\n\nThreads may fall asleep forever while acquiring InnoDB rw-lock on Power8. This\nregression was introduced along with InnoDB atomic operations fixes.\n\nThe problem was that proper memory order wasn't enforced between \"writers\"\nstore and \"lock_word\" load:\n\n  my_atomic_store32((int32*) &lock->waiters, 1);\n  ...\n  local_lock_word = lock->lock_word;\n\nLocking protocol is such that store to \"writers\" must be completed before load\nof \"lock_word\". my_atomic_store32() was expected to enforce memory order because\nit issues strongest MY_MEMORY_ORDER_SEQ_CST memory barrier.\n\nAccording to C11:\n- any operation with this memory order is both an acquire operation and a\n  release operation\n- for atomic store order must be one of memory_order_relaxed\n  memory_order_release or memory_order_seq_cst. Otherwise the behavior is\n  undefined.\n\nThat is it doesn't say explicitly that this expectation is wrong, but there are\nindications that acquire (which is actually supposed to guarantee memory order\nin this case) may not be issued along with MY_MEMORY_ORDER_SEQ_CST.\n\nA good fix for this is to encode waiters into lock_word, but it is a bit too\nintrusive. Instead we change atomic store to atomic fetch-and-store, which\ndoes memory load and is guaranteed to issue acquire.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/1a1749e38c774ce3a3493da2410b19ebe71eccb5"},{"sha":"cdaa1d768ebc002b968dee347c1928fef87b9537","author":{"name":"Marko Mäkelä","email":"8e45a01f33d432daf319ea6ccf609effd6e7ab53@mariadb.com"},"message":"MDEV-11349 (1/2) Fix some clang 4.0 warnings\n\nIn functions that declare pointer parameters as nonnull,\nremove nullness checks, because GCC would optimize them away anyway.\n\nUse #ifdef instead of #if when checking for a configuration flag.\n\nClang says that left shifts of negative values are undefined.\nSo, use ~0U instead of ~0 in a number of macros.\n\nSome functions that were defined as UNIV_INLINE were declared as\nUNIV_INTERN. Consistently use the same type of linkage.\n\nibuf_merge_or_delete_for_page() could pass bitmap_page=NULL to\nbuf_page_print(), conflicting with the __attribute__((nonnull)).","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/cdaa1d768ebc002b968dee347c1928fef87b9537"},{"sha":"d247d64988fb3b5d348e412813593a13f3be91fa","author":{"name":"Marko Mäkelä","email":"8e45a01f33d432daf319ea6ccf609effd6e7ab53@mariadb.com"},"message":"MDEV-11349 (2/2) Fix some bogus-looking Valgrind warnings\n\nbuf_block_init(): Initialize buf_page_t::flush_type.\nFor some reason, Valgrind 3.12.0 would seem to flag some\nbits in adjacent bitfields as uninitialized, even though only\nthe two bits of flush_type were left uninitialized. Initialize\nthe field to get rid of many warnings.\n\nbuf_page_init_low(): Initialize buf_page_t::old.\nFor some reason, Valgrind 3.12.0 would seem to flag all 32\nbits uninitialized when buf_page_init_for_read() invokes\nbuf_LRU_add_block(bpage, TRUE). This would trigger bogus warnings\nfor buf_page_t::freed_page_clock being uninitialized.\n(The V-bits would later claim that only \"old\" is initialized\nin the 32-bit word.) Perhaps recent compilers\n(GCC 6.2.1 and clang 4.0.0) generate more optimized x86_64 code\nfor bitfield operations, confusing Valgrind?\n\nmach_write_to_1(), mach_write_to_2(), mach_write_to_3():\nRewrite the assertions that ensure that the most significant\nbits are zero. Apparently, clang 4.0.0 would optimize expressions\nof the form ((n | 0xFF) <= 0x100) to (n <= 0x100). The redundant\n0xFF was added in the first place in order to suppress a\nValgrind warning. (Valgrind would warn about comparing uninitialized\nvalues even in the case when the uninitialized bits do not affect\nthe result of the comparison.)","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/d247d64988fb3b5d348e412813593a13f3be91fa"},{"sha":"cc3aba26ffdf2e052a7f9f0a94707e0567833a43","author":{"name":"Marko Mäkelä","email":"8e45a01f33d432daf319ea6ccf609effd6e7ab53@mariadb.com"},"message":"Merge branch '10.2_warnings' of https://github.com/kevgs/server into kevgs-10.2_warnings\n\nRevert the XtraDB changes, because 10.2 does not currently build with XtraDB.\n\nAlso omit some changes that need further investigation.\n\nEnsure that all callers of partition_info::get_clone() are passing this!=NULL.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/cc3aba26ffdf2e052a7f9f0a94707e0567833a43"},{"sha":"618edd4057d7947fccdd2f486d118f8376e95081","author":{"name":"Marko Mäkelä","email":"8e45a01f33d432daf319ea6ccf609effd6e7ab53@mariadb.com"},"message":"Merge branch 'kevgs-10.2_warnings' into 10.2","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/618edd4057d7947fccdd2f486d118f8376e95081"},{"sha":"3a6e781ea39b67fabf1a528e6a071215a65f50b0","author":{"name":"Otto Kekäläinen","email":"2d9953888fdaa8611893a214bba2b31235035b3c@mariadb.org"},"message":"MDEV-9165: Run chown much faster on the datadir during install/update","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/3a6e781ea39b67fabf1a528e6a071215a65f50b0"},{"sha":"b5b68b6bb809624b7cee6464eabb4b633443add0","author":{"name":"Otto Kekäläinen","email":"2d9953888fdaa8611893a214bba2b31235035b3c@mariadb.org"},"message":"MDEV-10126: replace deprecated iproute dependency with iproute2\n\nFall back to old iproute on Debian Wheezy and Ubuntu Precise that\ndon't have iproute2 available.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/b5b68b6bb809624b7cee6464eabb4b633443add0"},{"sha":"1d0f17415a7b0907498fbdf7b499862bed790edd","author":{"name":"Igor Babaev","email":"3b85b3e83e658d5d33308486a92b220edc8ae0a6@askmonty.org"},"message":"Fixed bug mdev-11313.\nThe fix for bug 11072 was not complete though it also fixed\nthe bug mdev-10800.\nThis patch resolves the problems of all three bugs.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/1d0f17415a7b0907498fbdf7b499862bed790edd"},{"sha":"9bfde897c37ca81492ccf5e83cbbe22289f7d592","author":{"name":"Alexander Barkov","email":"0f6b97dba78ece845922cd8b90dcd7bb4ae5b838@mariadb.org"},"message":"MDEV-11360 Dynamic SQL: DEFAULT as a bind parameter\n\nThis patch adds DEFAULT as a possible dynamic SQL parameter, e.g.:\n  EXECUTE IMMEDIATE 'INSERT INTO t1 (column) VALUES(?)' USING DEFAULT;\n  EXECUTE IMMEDIATE 'UPDATE t1 SET column=?' USING DEFAULT;\nand for similar PREPARE..EXECUTE queries.\n\nThis is done for symmetry with the STMT_INDICATOR_DEFAULT indicator in\nthe client-server PS protocol.\n\nThe changes include:\n- Allowing DEFAULT as a possible option in execute USING clause (sql_yacc.yy)\n- Adding \"virtual bool Item::save_in_param(THD *thd, Item_param *param)\",\n  because \"normal\" items (that have real values) and Item_default_value\n  have now different actions when assigning itself as an Item_param value.\n- Fixing switch() statements in a few Item_param methods not to have \"default\",\n  because it was easy to forget to add a new \"case\" when adding a new XXX_VALUE\n  value into the enum Item_param::enum_item_param_state.\n  This is important, as we'll be adding new values soon, e.g. for MDEV-11359.\n  Removing \"default\" helped to find and report bugs MDEV-11361 and MDEV-11362,\n  because DECIMAL_VALUE is obviously not properly handled in some cases.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/9bfde897c37ca81492ccf5e83cbbe22289f7d592"},{"sha":"2949282ccfc549fd7c9829accdbd6ef1fd2d9834","author":{"name":"Otto Kekäläinen","email":"2d9953888fdaa8611893a214bba2b31235035b3c@mariadb.org"},"message":"Deb: Fix libmariadbclient.so.18 link path to point to libmariadb.so.3\n\nAs libmariadb.so.3 does not reside in a multi-arch directory (yet),\nuse the plain path.","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/2949282ccfc549fd7c9829accdbd6ef1fd2d9834"},{"sha":"1965f03c80c336081d1a07c40cf5dedf9b9ce92f","author":{"name":"Otto Kekäläinen","email":"2d9953888fdaa8611893a214bba2b31235035b3c@mariadb.org"},"message":"Deb: Rename libmariadbclient-dev to libmariadb-dev\n\nThis change was accidentally omitted from commit 2bcc16c17b","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/1965f03c80c336081d1a07c40cf5dedf9b9ce92f"},{"sha":"f977709b65f7a34ea3ca918732a7cee77ff6d7b4","author":{"name":"Otto Kekäläinen","email":"2d9953888fdaa8611893a214bba2b31235035b3c@mariadb.org"},"message":"Deb: Make libmariadb3 to provide the libmysqlclient.so.XX links\n\nFor backwards compatibility reasons.\n\nE.g. innotop builds against libmysqlclient.so and expects to find\na libmysqlclient.so.18 library and does not use libmariadb.so.3 even\nwhen built from our own sources.\n\nThis commit mimics to dcfe6cb834b8106e384e24ac038cf6a6456fa9ee","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/f977709b65f7a34ea3ca918732a7cee77ff6d7b4"},{"sha":"ca3df8f68d01da5d590d2b0749dd4d05ef899203","author":{"name":"Otto Kekäläinen","email":"2d9953888fdaa8611893a214bba2b31235035b3c@mariadb.org"},"message":"Deb: wrap-and-sort for easier comparison to downstream in future","distinct":false,"url":"https://api.github.com/repos/kevgs/server/commits/ca3df8f68d01da5d590d2b0749dd4d05ef899203"}]}
{"actor":{"display_login":"kevgs"}}