{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/comments/56383206","id":56383206,"diff_hunk":"@@ -177,7 +177,7 @@ def generate_msi_package(project)\n         app_heat_flags = \" -dr INSTALLDIR -v -ke -indent 2 -cg AppComponentGroup -gg -srd -t wix/filter.xslt -sreg -var var.AppSourcePath \"\n         app_source_path = \"SourceDir/#{project.settings[:base_dir]}/#{project.settings[:company_id]}/#{project.settings[:product_id]}\"\n         appdata_heat_flags = \"  -dr APPDATADIR -v -ke -indent 2 -cg AppDataComponentGroup -gg -srd -t wix/filter.xslt -sreg -var var.AppDataSourcePath \"\n-        appdata_source_path = \"SourceDir/CommonAppDataFolder\"\n+        appdata_source_path = \"SourceDir/CommonAppDataFolder/#{project.settings[:company_id]}\"","path":"lib/vanagon/platform/windows.rb","position":5,"original_position":5,"commit_id":"15a920fb7a6b175028de2744bb6297746f06531a","original_commit_id":"15a920fb7a6b175028de2744bb6297746f06531a","user":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"body":"I was wrong, it does not require a change in vanagon and this is in fact the right way to go, before we were not doing things the same between app and appdata, this will make it so we are","created_at":"2016-03-16T17:52:45Z","updated_at":"2016-03-16T17:52:45Z","html_url":"https://github.com/puppetlabs/vanagon/pull/321#discussion_r56383206","pull_request_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/321","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/comments/56383206"},"html":{"href":"https://github.com/puppetlabs/vanagon/pull/321#discussion_r56383206"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/321","id":63084393,"html_url":"https://github.com/puppetlabs/vanagon/pull/321","diff_url":"https://github.com/puppetlabs/vanagon/pull/321.diff","patch_url":"https://github.com/puppetlabs/vanagon/pull/321.patch","issue_url":"https://api.github.com/repos/puppetlabs/vanagon/issues/321","number":321,"state":"open","locked":false,"title":"(MAINT) Fix the CommonAppData location","user":{"login":"jcoconnor","id":13116231,"avatar_url":"https://avatars.githubusercontent.com/u/13116231?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"body":"Files were being installed in C:\\ProgramData\\PuppetLabs\\PuppetLabs\r\nMove files up one level to C:\\ProgramData\\PuppetLabs","created_at":"2016-03-16T15:32:00Z","updated_at":"2016-03-16T17:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25d8f1ede74eb51108da2b068e194e61df6adbc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/321/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/321/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/vanagon/issues/321/comments","statuses_url":"https://api.github.com/repos/puppetlabs/vanagon/statuses/15a920fb7a6b175028de2744bb6297746f06531a","head":{"label":"jcoconnor:maint/fix-appdir-level","ref":"maint/fix-appdir-level","sha":"15a920fb7a6b175028de2744bb6297746f06531a","user":{"login":"jcoconnor","id":13116231,"avatar_url":"https://avatars.githubusercontent.com/u/13116231?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"repo":{"id":44818189,"name":"vanagon","full_name":"jcoconnor/vanagon","owner":{"login":"jcoconnor","id":13116231,"avatar_url":"https://avatars.githubusercontent.com/u/13116231?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcoconnor/vanagon","description":"All of your packages will fit into this van with this one simple trick.","fork":true,"url":"https://api.github.com/repos/jcoconnor/vanagon","forks_url":"https://api.github.com/repos/jcoconnor/vanagon/forks","keys_url":"https://api.github.com/repos/jcoconnor/vanagon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcoconnor/vanagon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcoconnor/vanagon/teams","hooks_url":"https://api.github.com/repos/jcoconnor/vanagon/hooks","issue_events_url":"https://api.github.com/repos/jcoconnor/vanagon/issues/events{/number}","events_url":"https://api.github.com/repos/jcoconnor/vanagon/events","assignees_url":"https://api.github.com/repos/jcoconnor/vanagon/assignees{/user}","branches_url":"https://api.github.com/repos/jcoconnor/vanagon/branches{/branch}","tags_url":"https://api.github.com/repos/jcoconnor/vanagon/tags","blobs_url":"https://api.github.com/repos/jcoconnor/vanagon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcoconnor/vanagon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcoconnor/vanagon/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcoconnor/vanagon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcoconnor/vanagon/statuses/{sha}","languages_url":"https://api.github.com/repos/jcoconnor/vanagon/languages","stargazers_url":"https://api.github.com/repos/jcoconnor/vanagon/stargazers","contributors_url":"https://api.github.com/repos/jcoconnor/vanagon/contributors","subscribers_url":"https://api.github.com/repos/jcoconnor/vanagon/subscribers","subscription_url":"https://api.github.com/repos/jcoconnor/vanagon/subscription","commits_url":"https://api.github.com/repos/jcoconnor/vanagon/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcoconnor/vanagon/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcoconnor/vanagon/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcoconnor/vanagon/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcoconnor/vanagon/contents/{+path}","compare_url":"https://api.github.com/repos/jcoconnor/vanagon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcoconnor/vanagon/merges","archive_url":"https://api.github.com/repos/jcoconnor/vanagon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcoconnor/vanagon/downloads","issues_url":"https://api.github.com/repos/jcoconnor/vanagon/issues{/number}","pulls_url":"https://api.github.com/repos/jcoconnor/vanagon/pulls{/number}","milestones_url":"https://api.github.com/repos/jcoconnor/vanagon/milestones{/number}","notifications_url":"https://api.github.com/repos/jcoconnor/vanagon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcoconnor/vanagon/labels{/name}","releases_url":"https://api.github.com/repos/jcoconnor/vanagon/releases{/id}","deployments_url":"https://api.github.com/repos/jcoconnor/vanagon/deployments","created_at":"2015-10-23T14:29:07Z","updated_at":"2016-01-27T10:46:40Z","pushed_at":"2016-03-16T15:59:45Z","git_url":"git://github.com/jcoconnor/vanagon.git","ssh_url":"git@github.com:jcoconnor/vanagon.git","clone_url":"https://github.com/jcoconnor/vanagon.git","svn_url":"https://github.com/jcoconnor/vanagon","homepage":null,"size":886,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"d84af5e8f9164f83c68983a8528102dc71640cda","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":26653553,"name":"vanagon","full_name":"puppetlabs/vanagon","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/vanagon","description":"All of your packages will fit into this van with this one simple trick.","fork":false,"url":"https://api.github.com/repos/puppetlabs/vanagon","forks_url":"https://api.github.com/repos/puppetlabs/vanagon/forks","keys_url":"https://api.github.com/repos/puppetlabs/vanagon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/vanagon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/vanagon/teams","hooks_url":"https://api.github.com/repos/puppetlabs/vanagon/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/vanagon/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/vanagon/events","assignees_url":"https://api.github.com/repos/puppetlabs/vanagon/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/vanagon/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/vanagon/tags","blobs_url":"https://api.github.com/repos/puppetlabs/vanagon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/vanagon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/vanagon/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/vanagon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/vanagon/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/vanagon/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/vanagon/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/vanagon/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/vanagon/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/vanagon/subscription","commits_url":"https://api.github.com/repos/puppetlabs/vanagon/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/vanagon/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/vanagon/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/vanagon/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/vanagon/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/vanagon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/vanagon/merges","archive_url":"https://api.github.com/repos/puppetlabs/vanagon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/vanagon/downloads","issues_url":"https://api.github.com/repos/puppetlabs/vanagon/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/vanagon/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/vanagon/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/vanagon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/vanagon/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/vanagon/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/vanagon/deployments","created_at":"2014-11-14T19:17:18Z","updated_at":"2016-01-29T12:05:09Z","pushed_at":"2016-03-16T16:21:11Z","git_url":"git://github.com/puppetlabs/vanagon.git","ssh_url":"git@github.com:puppetlabs/vanagon.git","clone_url":"https://github.com/puppetlabs/vanagon.git","svn_url":"https://github.com/puppetlabs/vanagon","homepage":null,"size":1008,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":5,"forks":19,"open_issues":5,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/321"},"html":{"href":"https://github.com/puppetlabs/vanagon/pull/321"},"issue":{"href":"https://api.github.com/repos/puppetlabs/vanagon/issues/321"},"comments":{"href":"https://api.github.com/repos/puppetlabs/vanagon/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/vanagon/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/vanagon/statuses/15a920fb7a6b175028de2744bb6297746f06531a"}}}}