{"action":"created","issue":{"url":"https://api.github.com/repos/popcornmix/omxplayer/issues/312","repository_url":"https://api.github.com/repos/popcornmix/omxplayer","labels_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/312/labels{/name}","comments_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/312/comments","events_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/312/events","html_url":"https://github.com/popcornmix/omxplayer/pull/312","id":57494433,"number":312,"title":"Fix Cppcheck reported issues and revert video/audio player instantiation order","user":{"login":"brunogm0","id":1731755,"avatar_url":"https://avatars.githubusercontent.com/u/1731755?v=3","gravatar_id":"","url":"https://api.github.com/users/brunogm0","html_url":"https://github.com/brunogm0","followers_url":"https://api.github.com/users/brunogm0/followers","following_url":"https://api.github.com/users/brunogm0/following{/other_user}","gists_url":"https://api.github.com/users/brunogm0/gists{/gist_id}","starred_url":"https://api.github.com/users/brunogm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunogm0/subscriptions","organizations_url":"https://api.github.com/users/brunogm0/orgs","repos_url":"https://api.github.com/users/brunogm0/repos","events_url":"https://api.github.com/users/brunogm0/events{/privacy}","received_events_url":"https://api.github.com/users/brunogm0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-12T17:47:25Z","updated_at":"2016-05-05T15:21:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/popcornmix/omxplayer/pulls/312","html_url":"https://github.com/popcornmix/omxplayer/pull/312","diff_url":"https://github.com/popcornmix/omxplayer/pull/312.diff","patch_url":"https://github.com/popcornmix/omxplayer/pull/312.patch"},"body":"I decided to put these two together: \r\nfix almost all cppcheck issues;\r\nInvert audio and video player Open(), to change allocation order for the buffers;\r\n\r\nThe second helps with #230 , it not solves completely because too little memory will trigger, but is much more easy to dynamically manage video_fifo size as the number of audio buffers is fixed.  "},"comment":{"url":"https://api.github.com/repos/popcornmix/omxplayer/issues/comments/217183853","html_url":"https://github.com/popcornmix/omxplayer/pull/312#issuecomment-217183853","issue_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/312","id":217183853,"user":{"login":"brunogm0","id":1731755,"avatar_url":"https://avatars.githubusercontent.com/u/1731755?v=3","gravatar_id":"","url":"https://api.github.com/users/brunogm0","html_url":"https://github.com/brunogm0","followers_url":"https://api.github.com/users/brunogm0/followers","following_url":"https://api.github.com/users/brunogm0/following{/other_user}","gists_url":"https://api.github.com/users/brunogm0/gists{/gist_id}","starred_url":"https://api.github.com/users/brunogm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunogm0/subscriptions","organizations_url":"https://api.github.com/users/brunogm0/orgs","repos_url":"https://api.github.com/users/brunogm0/repos","events_url":"https://api.github.com/users/brunogm0/events{/privacy}","received_events_url":"https://api.github.com/users/brunogm0/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T15:21:05Z","updated_at":"2016-05-05T15:21:05Z","body":"I dont hava a RPi to test anymore.  The purpose of the instantiation order was to allow audio to play when the video buffer is to small or initialization error.    \r\nI will run the newer cppcheck on the latest source and report back but takes a long time to run it. "}}