{"action":"created","issue":{"url":"https://api.github.com/repos/npm/npm/issues/14117","repository_url":"https://api.github.com/repos/npm/npm","labels_url":"https://api.github.com/repos/npm/npm/issues/14117/labels{/name}","comments_url":"https://api.github.com/repos/npm/npm/issues/14117/comments","events_url":"https://api.github.com/repos/npm/npm/issues/14117/events","html_url":"https://github.com/npm/npm/pull/14117","id":179929993,"number":14117,"title":"shrinkwrap: fix optional deps check","user":{"login":"watilde","id":1716463,"avatar_url":"https://avatars.githubusercontent.com/u/1716463?v=3","gravatar_id":"","url":"https://api.github.com/users/watilde","html_url":"https://github.com/watilde","followers_url":"https://api.github.com/users/watilde/followers","following_url":"https://api.github.com/users/watilde/following{/other_user}","gists_url":"https://api.github.com/users/watilde/gists{/gist_id}","starred_url":"https://api.github.com/users/watilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watilde/subscriptions","organizations_url":"https://api.github.com/users/watilde/orgs","repos_url":"https://api.github.com/users/watilde/repos","events_url":"https://api.github.com/users/watilde/events{/privacy}","received_events_url":"https://api.github.com/users/watilde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-29T01:15:34Z","updated_at":"2016-10-03T21:58:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/npm/npm/pulls/14117","html_url":"https://github.com/npm/npm/pull/14117","diff_url":"https://github.com/npm/npm/pull/14117.diff","patch_url":"https://github.com/npm/npm/pull/14117.patch"},"body":"Fixes https://github.com/npm/npm/issues/14042. From the last release, `npm-shrinkwrap.json` has been updated to tell us the deps is optional or not, but instal-check in `install/action.js` still has been checking the deps could be installable or not even the deps has `optional: true`.\r\n\r\nI've updated `inflate-shrinkwrap.js` to pass the property of the optional to `action.js` and  `isInstallable ` should be skipped if the deps is optional. I will add a test and write more detail into the commit message later. Thanks!"},"comment":{"url":"https://api.github.com/repos/npm/npm/issues/comments/251239720","html_url":"https://github.com/npm/npm/pull/14117#issuecomment-251239720","issue_url":"https://api.github.com/repos/npm/npm/issues/14117","id":251239720,"user":{"login":"iarna","id":983798,"avatar_url":"https://avatars.githubusercontent.com/u/983798?v=3","gravatar_id":"","url":"https://api.github.com/users/iarna","html_url":"https://github.com/iarna","followers_url":"https://api.github.com/users/iarna/followers","following_url":"https://api.github.com/users/iarna/following{/other_user}","gists_url":"https://api.github.com/users/iarna/gists{/gist_id}","starred_url":"https://api.github.com/users/iarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iarna/subscriptions","organizations_url":"https://api.github.com/users/iarna/orgs","repos_url":"https://api.github.com/users/iarna/repos","events_url":"https://api.github.com/users/iarna/events{/privacy}","received_events_url":"https://api.github.com/users/iarna/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T21:58:32Z","updated_at":"2016-10-03T21:58:32Z","body":"This looks much better! I'm still concerned that apparently our optionalDependency checker is failing under some circumstances (that you've isolated). I'd _prefer_ not to have to fall back on assuming the shrinkwrap is correct regarding the optional status of packages.\r\n\r\nSo this is my plan:\r\n\r\n1. I plan on taking this patch, because as long as we have optional in the shrinkwrap I think we should believe it.\r\n2. I'm going to pull out your reproducer and see if I can't figure out what the root cause of the failure is.\r\n\r\nI'd like to get #2 done before I land #1 as having #1 in place will make it harder to reproduce.\r\n"}}
{"actor":{"display_login":"iarna"}}