{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/comments/81168525","pull_request_review_id":2168495,"id":81168525,"diff_hunk":"@@ -1071,6 +1077,45 @@ define([\n       });\n   };\n \n+  /**\n+   * Send an unblock code\n+   *\n+   * @method sendUnblockCode\n+   * @param {String} email email where to send the login authorization code\n+   * @return {Promise} A promise that will be fulfilled with JSON `xhr.responseText` of the request\n+   */\n+  FxAccountClient.prototype.sendUnblockCode = function (email) {\n+    required(email, 'email');\n+\n+    var data = {\n+      email: email\n+    };\n+\n+    var request = this.request;","path":"client/FxAccountClient.js","position":null,"original_position":38,"commit_id":"4d7474ab9492727dca0d6e0c4658d9597a843f88","original_commit_id":"95198123438235e23927caa39887d5fa746b9d77","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"I just audited the rest of the file, everywhere there is a `var request = this.request`, `request` is used inside of a callback, so there was a real reason to set the reference. I had no such reason.","created_at":"2016-09-29T15:45:54Z","updated_at":"2016-09-29T15:45:54Z","html_url":"https://github.com/mozilla/fxa-js-client/pull/211#discussion_r81168525","pull_request_url":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/211","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/comments/81168525"},"html":{"href":"https://github.com/mozilla/fxa-js-client/pull/211#discussion_r81168525"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/211","id":80823399,"html_url":"https://github.com/mozilla/fxa-js-client/pull/211","diff_url":"https://github.com/mozilla/fxa-js-client/pull/211.diff","patch_url":"https://github.com/mozilla/fxa-js-client/pull/211.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-js-client/issues/211","number":211,"state":"open","locked":false,"title":"feat(client): Add signin authorization support.","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"fixes #210 ","created_at":"2016-08-10T16:15:56Z","updated_at":"2016-09-29T15:45:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffd18e889e7f700a496c06a1b4b4e92d325384dc","assignee":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=3","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"assignees":[{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=3","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mozilla/fxa-js-client/milestones/43","html_url":"https://github.com/mozilla/fxa-js-client/milestones/FxA-106:%20signin%20unblock","labels_url":"https://api.github.com/repos/mozilla/fxa-js-client/milestones/43/labels","id":1929223,"number":43,"title":"FxA-106: signin unblock","description":"","creator":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-08-08T12:34:04Z","updated_at":"2016-09-19T20:29:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/211/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/211/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-js-client/issues/211/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-js-client/statuses/4d7474ab9492727dca0d6e0c4658d9597a843f88","head":{"label":"mozilla:fxa106-signin-authorization","ref":"fxa106-signin-authorization","sha":"4d7474ab9492727dca0d6e0c4658d9597a843f88","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":13972055,"name":"fxa-js-client","full_name":"mozilla/fxa-js-client","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-js-client","description":"A web client that talks to the Firefox Accounts API server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-js-client","forks_url":"https://api.github.com/repos/mozilla/fxa-js-client/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-js-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-js-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-js-client/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-js-client/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-js-client/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-js-client/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-js-client/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-js-client/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-js-client/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-js-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-js-client/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-js-client/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-js-client/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-js-client/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-js-client/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-js-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-js-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-js-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-js-client/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-js-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-js-client/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-js-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-js-client/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-js-client/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-js-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-js-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-js-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-js-client/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-js-client/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-js-client/deployments","created_at":"2013-10-29T23:39:29Z","updated_at":"2016-06-09T04:41:17Z","pushed_at":"2016-09-29T15:01:34Z","git_url":"git://github.com/mozilla/fxa-js-client.git","ssh_url":"git@github.com:mozilla/fxa-js-client.git","clone_url":"https://github.com/mozilla/fxa-js-client.git","svn_url":"https://github.com/mozilla/fxa-js-client","homepage":"","size":1504,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":23,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"d64209c19f457ea6721e3568a12f34beb39c3ee9","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":13972055,"name":"fxa-js-client","full_name":"mozilla/fxa-js-client","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-js-client","description":"A web client that talks to the Firefox Accounts API server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-js-client","forks_url":"https://api.github.com/repos/mozilla/fxa-js-client/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-js-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-js-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-js-client/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-js-client/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-js-client/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-js-client/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-js-client/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-js-client/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-js-client/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-js-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-js-client/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-js-client/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-js-client/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-js-client/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-js-client/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-js-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-js-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-js-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-js-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-js-client/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-js-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-js-client/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-js-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-js-client/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-js-client/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-js-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-js-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-js-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-js-client/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-js-client/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-js-client/deployments","created_at":"2013-10-29T23:39:29Z","updated_at":"2016-06-09T04:41:17Z","pushed_at":"2016-09-29T15:01:34Z","git_url":"git://github.com/mozilla/fxa-js-client.git","ssh_url":"git@github.com:mozilla/fxa-js-client.git","clone_url":"https://github.com/mozilla/fxa-js-client.git","svn_url":"https://github.com/mozilla/fxa-js-client","homepage":"","size":1504,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/211"},"html":{"href":"https://github.com/mozilla/fxa-js-client/pull/211"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/issues/211"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-js-client/statuses/4d7474ab9492727dca0d6e0c4658d9597a843f88"}}}}
{"actor":{"display_login":"shane-tomlinson"}}