{"push_id":1434311333,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"76dee3fba6a23a3049cd9226131263ca823db0ad","before":"4994cb1129ca4819a8675c66775ac267408448f9","commits":[{"sha":"06acc5ce08e11bee1d05d11e47c6afacb073a7f0","author":{"name":"Murray Steele","email":"7fd5846ea6ef627614ea669595ce6a868b4c0162@h-lame.com"},"message":"Write MONGODB_NODES for manuals-publisher correctly\n\nThis value is expected to be slotted into a YAML file as an array.  The key\nthe value belongs to is nested and so the lines need to be indented correctly\nor the resulting YAML file will be invalid.  Given some YAML as follows:\n\n    production:\n      hosts:\n        - <%= ENV['MONGODB_NODES'] %>\n\nIf we don't add indentation to the lines after the first one what we end up\nwith is:\n\n    production:\n      hosts:\n        - - first_node:27017\n    - second_node:27017\n    - and-so-on\n\nThis is not valid YAML and so the app will refuse to load the mongoid config\nand ultimately refuse to run.  By tweaking the env var value to indent those\nlines and correctly format the YAML as follows:\n\n    production:\n      hosts:\n        - - first_node:27017\n          - second_node:27017\n          - and-so-on\n\nAnd the app will boot again.\n\nThe bug in the formatting of this env var value was exposed by commit\n336343d5198a62e76ab1da5515a6e40cbaf9fc0b where we introduced support\nfor multiline env vars.  Prior to this commit this value was ultimately treated\nas a single line value.  The single line version of the value fits into the\nYAML file correctly as the first line doesn't need indenting, so the problem\nnever arose.  Although it did mean that the app only ever communicated with\none of the expected mongo nodes.","distinct":true,"url":"https://api.github.com/repos/alphagov/govuk-puppet/commits/06acc5ce08e11bee1d05d11e47c6afacb073a7f0"},{"sha":"76dee3fba6a23a3049cd9226131263ca823db0ad","author":{"name":"Murray Steele","email":"7fd5846ea6ef627614ea669595ce6a868b4c0162@h-lame.com"},"message":"Merge pull request #5207 from alphagov/prepare-multiline-env-var-as-yaml-fragment-for-manuals-publisher-correctly\n\nWrite MONGODB_NODES for manuals-publisher correctly","distinct":true,"url":"https://api.github.com/repos/alphagov/govuk-puppet/commits/76dee3fba6a23a3049cd9226131263ca823db0ad"}]}
{"actor":{"display_login":"h-lame"}}