{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/53339775","id":53339775,"diff_hunk":"@@ -5,23 +5,31 @@ import getenv from 'getenv'\n // To enable a feature, include it in the environment variable KEYBASE_FEATURES.\n // For example, KEYBASE_FEATURES=tracker2,login,awesomefeature\n \n+const tracker2Key = 'tracker2'\n+const loginKey = 'login'\n+const mobileAppsExistKey = 'mobileAppsExist'\n+\n type FeatureFlags = {\n-  tracker2: boolean,\n-  login: boolean\n+  'tracker2': boolean,\n+  'login': boolean,\n+  'mobileAppsExist': boolean\n }\n \n let features = getenv.array('KEYBASE_FEATURES', 'string', '')\n \n // For compatibility, this is deprecated\n-if (getenv.boolish('KEYBASE_TRACKER_V2', false)) { features.push('tracker2') }\n-if (getenv.boolish('KEYBASE_ALLOW_LOGIN', false)) { features.push('login') }\n+if (getenv.boolish('KEYBASE_TRACKER_V2', false)) { features.push(tracker2Key) }\n+if (getenv.boolish('KEYBASE_ALLOW_LOGIN', false)) { features.push(loginKey) }\n+if (getenv.boolish('KEYBASE_MOBILE_APPS_EXIST', false)) { features.push(mobileAppsExistKey) }","path":"shared/util/feature-flags.js","position":23,"original_position":23,"commit_id":"6a6a05a45c3c9c0b4694cfa109649355689b79ba","original_commit_id":"6a6a05a45c3c9c0b4694cfa109649355689b79ba","user":{"login":"cjb","id":21217,"avatar_url":"https://avatars.githubusercontent.com/u/21217?v=3","gravatar_id":"","url":"https://api.github.com/users/cjb","html_url":"https://github.com/cjb","followers_url":"https://api.github.com/users/cjb/followers","following_url":"https://api.github.com/users/cjb/following{/other_user}","gists_url":"https://api.github.com/users/cjb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjb/subscriptions","organizations_url":"https://api.github.com/users/cjb/orgs","repos_url":"https://api.github.com/users/cjb/repos","events_url":"https://api.github.com/users/cjb/events{/privacy}","received_events_url":"https://api.github.com/users/cjb/received_events","type":"User","site_admin":false},"body":"If these are deprecated, maybe we shouldn't add more.  You can use KEYBASE_FEATURES_MOBILE_APPS_EXIST instead, is that okay?","created_at":"2016-02-18T16:29:38Z","updated_at":"2016-02-18T16:29:38Z","html_url":"https://github.com/keybase/client/pull/2047#discussion_r53339775","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/2047","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/53339775"},"html":{"href":"https://github.com/keybase/client/pull/2047#discussion_r53339775"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/2047"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/2047","id":59662795,"html_url":"https://github.com/keybase/client/pull/2047","diff_url":"https://github.com/keybase/client/pull/2047.diff","patch_url":"https://github.com/keybase/client/pull/2047.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/2047","number":2047,"state":"open","locked":false,"title":"Ask which device to use provisioning dz2","user":{"login":"chrisnojima","id":516435,"avatar_url":"https://avatars.githubusercontent.com/u/516435?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisnojima","html_url":"https://github.com/chrisnojima","followers_url":"https://api.github.com/users/chrisnojima/followers","following_url":"https://api.github.com/users/chrisnojima/following{/other_user}","gists_url":"https://api.github.com/users/chrisnojima/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnojima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnojima/subscriptions","organizations_url":"https://api.github.com/users/chrisnojima/orgs","repos_url":"https://api.github.com/users/chrisnojima/repos","events_url":"https://api.github.com/users/chrisnojima/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnojima/received_events","type":"User","site_admin":false},"body":"Replaces https://github.com/keybase/client/pull/2042\r\n\r\n@keybase/react-hackers ","created_at":"2016-02-17T15:46:22Z","updated_at":"2016-02-18T16:29:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb03b617a1ab854e84b1fd5646be53252a5fa3e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/2047/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/2047/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/2047/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/6a6a05a45c3c9c0b4694cfa109649355689b79ba","head":{"label":"keybase:nojima/DESKTOP-521-provisioning-device","ref":"nojima/DESKTOP-521-provisioning-device","sha":"6a6a05a45c3c9c0b4694cfa109649355689b79ba","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2016-02-18T10:54:16Z","pushed_at":"2016-02-18T15:16:30Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":143627,"stargazers_count":325,"watchers_count":325,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":87,"forks":16,"open_issues":87,"watchers":325,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"a290ca275ddf66399d72cd1cd69d8ed8b0f7b479","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2016-02-18T10:54:16Z","pushed_at":"2016-02-18T15:16:30Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":143627,"stargazers_count":325,"watchers_count":325,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":87,"forks":16,"open_issues":87,"watchers":325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/2047"},"html":{"href":"https://github.com/keybase/client/pull/2047"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/2047"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/2047/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/2047/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/2047/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/6a6a05a45c3c9c0b4694cfa109649355689b79ba"}}}}