{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments/49414079","id":49414079,"diff_hunk":"@@ -1917,25 +1930,30 @@ public void updateRecoveryCheckpoints(PTOperator operator, UpdateCheckpointsCont\n       long currentWindowId = WindowGenerator.getWindowId(ctx.currentTms, this.vars.windowStartMillis, this.getLogicalPlan().getValue(LogicalPlan.STREAMING_WINDOW_SIZE_MILLIS));\n       maxCheckpoint = currentWindowId;\n     }\n+    ctx.visited.add(operator);\n \n     // DFS downstream operators\n-    for (PTOperator.PTOutput out : operator.getOutputs()) {\n-      for (PTOperator.PTInput sink : out.sinks) {\n-        PTOperator sinkOperator = sink.target;\n-        if (!ctx.visited.contains(sinkOperator)) {\n-          // downstream traversal\n-          updateRecoveryCheckpoints(sinkOperator, ctx);\n-        }\n-        // recovery window id cannot move backwards\n-        // when dynamically adding new operators\n-        if (sinkOperator.getRecoveryCheckpoint().windowId >= operator.getRecoveryCheckpoint().windowId) {\n-          maxCheckpoint = Math.min(maxCheckpoint, sinkOperator.getRecoveryCheckpoint().windowId);\n-        }\n+    if (operator.getOperatorMeta().getOperator() instanceof Operator.DelayOperator) {\n+      addVisited(operator, ctx);\n+    } else {","path":"engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java","position":50,"original_position":50,"commit_id":"6f21979063dc68d159488cb2d8d499b9dee110b4","original_commit_id":"6f21979063dc68d159488cb2d8d499b9dee110b4","user":{"login":"tweise","id":263695,"avatar_url":"https://avatars.githubusercontent.com/u/263695?v=3","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"body":"It's not working because the recovery checkpoint of the operator where the delay loop joins can be older than the downstream operators. Therefore, when traversing the loop, upstream checkpoints needs to be taken into consideration, which is part of the broader solution Pramod refers to. Looking into this further, would like to clean up the special case handling for delay operator also.","created_at":"2016-01-12T04:06:23Z","updated_at":"2016-01-12T04:06:23Z","html_url":"https://github.com/apache/incubator-apex-core/pull/185#discussion_r49414079","pull_request_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments/49414079"},"html":{"href":"https://github.com/apache/incubator-apex-core/pull/185#discussion_r49414079"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185","id":53196832,"html_url":"https://github.com/apache/incubator-apex-core/pull/185","diff_url":"https://github.com/apache/incubator-apex-core/pull/185.diff","patch_url":"https://github.com/apache/incubator-apex-core/pull/185.patch","issue_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/185","number":185,"state":"open","locked":false,"title":"APEXCORE-60 Iteration support in Apex Core","user":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"body":"Please review","created_at":"2015-12-09T23:54:18Z","updated_at":"2016-01-12T04:06:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c1f7c65b8f6b8ad69a94691956cc89f79c40f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/185/comments","statuses_url":"https://api.github.com/repos/apache/incubator-apex-core/statuses/6f21979063dc68d159488cb2d8d499b9dee110b4","head":{"label":"davidyan74:APEXCORE-60","ref":"APEXCORE-60","sha":"6f21979063dc68d159488cb2d8d499b9dee110b4","user":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"repo":{"id":41393462,"name":"incubator-apex-core","full_name":"davidyan74/incubator-apex-core","owner":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidyan74/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":true,"url":"https://api.github.com/repos/davidyan74/incubator-apex-core","forks_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/releases{/id}","created_at":"2015-08-25T23:39:13Z","updated_at":"2015-08-25T23:39:18Z","pushed_at":"2016-01-09T00:44:19Z","git_url":"git://github.com/davidyan74/incubator-apex-core.git","ssh_url":"git@github.com:davidyan74/incubator-apex-core.git","clone_url":"https://github.com/davidyan74/incubator-apex-core.git","svn_url":"https://github.com/davidyan74/incubator-apex-core","homepage":null,"size":11172,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:devel-3","ref":"devel-3","sha":"fadb6f4f702315ea7123911d330e3e9711f439db","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348333,"name":"incubator-apex-core","full_name":"apache/incubator-apex-core","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-apex-core","forks_url":"https://api.github.com/repos/apache/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/apache/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/apache/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/apache/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/apache/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/apache/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/apache/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/apache/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-apex-core/releases{/id}","created_at":"2015-08-25T07:00:05Z","updated_at":"2016-01-12T01:33:41Z","pushed_at":"2016-01-12T01:41:27Z","git_url":"git://github.com/apache/incubator-apex-core.git","ssh_url":"git@github.com:apache/incubator-apex-core.git","clone_url":"https://github.com/apache/incubator-apex-core.git","svn_url":"https://github.com/apache/incubator-apex-core","homepage":null,"size":11450,"stargazers_count":50,"watchers_count":50,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":"git://git.apache.org/incubator-apex-core.git","open_issues_count":15,"forks":53,"open_issues":15,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185"},"html":{"href":"https://github.com/apache/incubator-apex-core/pull/185"},"issue":{"href":"https://api.github.com/repos/apache/incubator-apex-core/issues/185"},"comments":{"href":"https://api.github.com/repos/apache/incubator-apex-core/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-apex-core/statuses/6f21979063dc68d159488cb2d8d499b9dee110b4"}}}}