{"action":"created","issue":{"url":"https://api.github.com/repos/AgilionApps/ja_serializer/issues/144","repository_url":"https://api.github.com/repos/AgilionApps/ja_serializer","labels_url":"https://api.github.com/repos/AgilionApps/ja_serializer/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/AgilionApps/ja_serializer/issues/144/comments","events_url":"https://api.github.com/repos/AgilionApps/ja_serializer/issues/144/events","html_url":"https://github.com/AgilionApps/ja_serializer/pull/144","id":167250102,"number":144,"title":"Changes","user":{"login":"bcardarella","id":18524,"avatar_url":"https://avatars.githubusercontent.com/u/18524?v=3","gravatar_id":"","url":"https://api.github.com/users/bcardarella","html_url":"https://github.com/bcardarella","followers_url":"https://api.github.com/users/bcardarella/followers","following_url":"https://api.github.com/users/bcardarella/following{/other_user}","gists_url":"https://api.github.com/users/bcardarella/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardarella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardarella/subscriptions","organizations_url":"https://api.github.com/users/bcardarella/orgs","repos_url":"https://api.github.com/users/bcardarella/repos","events_url":"https://api.github.com/users/bcardarella/events{/privacy}","received_events_url":"https://api.github.com/users/bcardarella/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-24T19:38:44Z","updated_at":"2016-07-25T13:14:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AgilionApps/ja_serializer/pulls/144","html_url":"https://github.com/AgilionApps/ja_serializer/pull/144","diff_url":"https://github.com/AgilionApps/ja_serializer/pull/144.diff","patch_url":"https://github.com/AgilionApps/ja_serializer/pull/144.patch"},"body":"Please consider this a WIP branch. It does address #143 as well as some other blockers I've hit.\r\n\r\nThe 2nd change may appear to be subjective but I'd like to discuss the merits of it before any rejection is given.\r\n\r\n1. Added `bare: true` to allow `JaSerializer.Builder.ResourceObject` to\r\nbuild a bare object without requiring relationships. This can probably\r\nbe expected to `meta` and `links` as well. TBD.\r\n2. Changed `JaSerializer.Formatter` to always output all keys as\r\nstrings. Currently the output format was a mix of atoms and strings.\r\nHaving a consistent key format will make payloads easier to test.\r\nHowever, this may have an impact on the performance of the library and\r\nthis should be considered a breaking API change."},"comment":{"url":"https://api.github.com/repos/AgilionApps/ja_serializer/issues/comments/234949433","html_url":"https://github.com/AgilionApps/ja_serializer/pull/144#issuecomment-234949433","issue_url":"https://api.github.com/repos/AgilionApps/ja_serializer/issues/144","id":234949433,"user":{"login":"alanpeabody","id":19368,"avatar_url":"https://avatars.githubusercontent.com/u/19368?v=3","gravatar_id":"","url":"https://api.github.com/users/alanpeabody","html_url":"https://github.com/alanpeabody","followers_url":"https://api.github.com/users/alanpeabody/followers","following_url":"https://api.github.com/users/alanpeabody/following{/other_user}","gists_url":"https://api.github.com/users/alanpeabody/gists{/gist_id}","starred_url":"https://api.github.com/users/alanpeabody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanpeabody/subscriptions","organizations_url":"https://api.github.com/users/alanpeabody/orgs","repos_url":"https://api.github.com/users/alanpeabody/repos","events_url":"https://api.github.com/users/alanpeabody/events{/privacy}","received_events_url":"https://api.github.com/users/alanpeabody/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T13:14:53Z","updated_at":"2016-07-25T13:14:53Z","body":"Ah, yeah, I wasn't thinking about id and type. The per key approach makes sense to me, even if we start with just relationships.\r\n\r\nYou will probably also want to skip sideloading the included relationships."}}
{"actor":{"display_login":"alanpeabody"}}