{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3044","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3044/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3044/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3044/events","html_url":"https://github.com/fish-shell/fish-shell/issues/3044","id":155885631,"number":3044,"title":"fish unit tests involving unicode fail on Cygwin (MS Windows)","user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fish-shell/fish-shell/labels/cleanup","name":"cleanup","color":"bfdadc"},{"url":"https://api.github.com/repos/fish-shell/fish-shell/labels/windows","name":"windows","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/4","html_url":"https://github.com/fish-shell/fish-shell/milestones/fish-future","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/4/labels","id":130257,"number":4,"title":"fish-future","description":"These are issues that are not targeted for an upcoming minor or major release. After a release, we will re-examine these issues and pull any in that we think are good targets; that is retarget them to the next minor (or major) release.\r\n\r\nIf you can provide a fix for an issue in this milestone, we'll generally accept it for the next release even if the issue is not targeted for the release.","creator":{"login":"ridiculousfish","id":920838,"avatar_url":"https://avatars.githubusercontent.com/u/920838?v=3","gravatar_id":"","url":"https://api.github.com/users/ridiculousfish","html_url":"https://github.com/ridiculousfish","followers_url":"https://api.github.com/users/ridiculousfish/followers","following_url":"https://api.github.com/users/ridiculousfish/following{/other_user}","gists_url":"https://api.github.com/users/ridiculousfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ridiculousfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridiculousfish/subscriptions","organizations_url":"https://api.github.com/users/ridiculousfish/orgs","repos_url":"https://api.github.com/users/ridiculousfish/repos","events_url":"https://api.github.com/users/ridiculousfish/events{/privacy}","received_events_url":"https://api.github.com/users/ridiculousfish/received_events","type":"User","site_admin":false},"open_issues":368,"closed_issues":2,"state":"open","created_at":"2012-06-11T02:25:13Z","updated_at":"2016-05-23T21:49:58Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-05-20T04:39:21Z","updated_at":"2016-05-24T09:31:24Z","closed_at":null,"body":"Running `make test` on Cygwin resulted in test failures such as\r\n\r\n```\r\nTesting utils\r\nError: u2w: resulted in forbitten wchars (len): FAILED (rv: 3, must be 0)\r\n```\r\n\r\nThat made we wonder why `utf8_to_wchar()` exists. As far as I can tell it is used in exactly two places (directly or indirectly):\r\n\r\n1) *src/env_universal_common.cpp*\r\n\r\n2) *src/fish_tests.cpp*\r\n\r\nIt seems to me it should be removed.\r\n"},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/221215701","html_url":"https://github.com/fish-shell/fish-shell/issues/3044#issuecomment-221215701","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3044","id":221215701,"user":{"login":"ridiculousfish","id":920838,"avatar_url":"https://avatars.githubusercontent.com/u/920838?v=3","gravatar_id":"","url":"https://api.github.com/users/ridiculousfish","html_url":"https://github.com/ridiculousfish","followers_url":"https://api.github.com/users/ridiculousfish/followers","following_url":"https://api.github.com/users/ridiculousfish/following{/other_user}","gists_url":"https://api.github.com/users/ridiculousfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ridiculousfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridiculousfish/subscriptions","organizations_url":"https://api.github.com/users/ridiculousfish/orgs","repos_url":"https://api.github.com/users/ridiculousfish/repos","events_url":"https://api.github.com/users/ridiculousfish/events{/privacy}","received_events_url":"https://api.github.com/users/ridiculousfish/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T09:31:24Z","updated_at":"2016-05-24T09:31:24Z","body":"A wchar_t is supposed to be able to represent any character (by which I mean code point). I don't know if current Cygwin uses either UCS-2 or UTF-16, but either way it can't represent astral characters in a single wchar_t. So it's not surprising these tests fail. Just another reason to get off of wchar_t."}}
{"actor":{"display_login":"ridiculousfish"}}