{"action":"created","issue":{"url":"https://api.github.com/repos/ramda/ramda/issues/1585","labels_url":"https://api.github.com/repos/ramda/ramda/issues/1585/labels{/name}","comments_url":"https://api.github.com/repos/ramda/ramda/issues/1585/comments","events_url":"https://api.github.com/repos/ramda/ramda/issues/1585/events","html_url":"https://github.com/ramda/ramda/issues/1585","id":125979325,"number":1585,"title":"Feature request: easier to read source","user":{"login":"Sequoia","id":317498,"avatar_url":"https://avatars.githubusercontent.com/u/317498?v=3","gravatar_id":"","url":"https://api.github.com/users/Sequoia","html_url":"https://github.com/Sequoia","followers_url":"https://api.github.com/users/Sequoia/followers","following_url":"https://api.github.com/users/Sequoia/following{/other_user}","gists_url":"https://api.github.com/users/Sequoia/gists{/gist_id}","starred_url":"https://api.github.com/users/Sequoia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sequoia/subscriptions","organizations_url":"https://api.github.com/users/Sequoia/orgs","repos_url":"https://api.github.com/users/Sequoia/repos","events_url":"https://api.github.com/users/Sequoia/events{/privacy}","received_events_url":"https://api.github.com/users/Sequoia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-11T16:16:56Z","updated_at":"2016-01-12T10:03:41Z","closed_at":null,"body":"Reading [the source](https://github.com/ramda/ramda/blob/v0.19.0/src/lens.js) when...\r\n```js\r\nmodule.exports = _curry2(function lens(getter, setter) {\r\n  return function(f) {\r\n    return function(s) {\r\n      return map(function(v) { return setter(v, s); }, f(getter(s)));\r\n    };\r\n  };\r\n});\r\n```\r\n`f`? `s`? `v`? `s` is... I think the property name? Or wait, maybe `v` is the propname and `s` is . . . well `f` if \"function\", that's clear, but what is the function's purpose here?\r\n\r\n## Meaningful variable names\r\n\r\n### Benefit\r\n1. Easier to read source\r\n2. Makes Ramda a better teaching tool\r\n3. Makes it easier for newbs to understand & contribute\r\n\r\n### Cost\r\n1. ???"},"comment":{"url":"https://api.github.com/repos/ramda/ramda/issues/comments/170860506","html_url":"https://github.com/ramda/ramda/issues/1585#issuecomment-170860506","issue_url":"https://api.github.com/repos/ramda/ramda/issues/1585","id":170860506,"user":{"login":"scott-christopher","id":8951601,"avatar_url":"https://avatars.githubusercontent.com/u/8951601?v=3","gravatar_id":"","url":"https://api.github.com/users/scott-christopher","html_url":"https://github.com/scott-christopher","followers_url":"https://api.github.com/users/scott-christopher/followers","following_url":"https://api.github.com/users/scott-christopher/following{/other_user}","gists_url":"https://api.github.com/users/scott-christopher/gists{/gist_id}","starred_url":"https://api.github.com/users/scott-christopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott-christopher/subscriptions","organizations_url":"https://api.github.com/users/scott-christopher/orgs","repos_url":"https://api.github.com/users/scott-christopher/repos","events_url":"https://api.github.com/users/scott-christopher/events{/privacy}","received_events_url":"https://api.github.com/users/scott-christopher/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T10:03:41Z","updated_at":"2016-01-12T10:03:41Z","body":"I've raised #1588 to address the specific concerns raised about the various lens functions."}}