{"action":"created","issue":{"url":"https://api.github.com/repos/mila-udem/fuel/issues/368","repository_url":"https://api.github.com/repos/mila-udem/fuel","labels_url":"https://api.github.com/repos/mila-udem/fuel/issues/368/labels{/name}","comments_url":"https://api.github.com/repos/mila-udem/fuel/issues/368/comments","events_url":"https://api.github.com/repos/mila-udem/fuel/issues/368/events","html_url":"https://github.com/mila-udem/fuel/pull/368","id":182325389,"number":368,"title":"Make get_data optional in AbstractDataStream.","user":{"login":"dwf","id":60206,"avatar_url":"https://avatars.githubusercontent.com/u/60206?v=3","gravatar_id":"","url":"https://api.github.com/users/dwf","html_url":"https://github.com/dwf","followers_url":"https://api.github.com/users/dwf/followers","following_url":"https://api.github.com/users/dwf/following{/other_user}","gists_url":"https://api.github.com/users/dwf/gists{/gist_id}","starred_url":"https://api.github.com/users/dwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwf/subscriptions","organizations_url":"https://api.github.com/users/dwf/orgs","repos_url":"https://api.github.com/users/dwf/repos","events_url":"https://api.github.com/users/dwf/events{/privacy}","received_events_url":"https://api.github.com/users/dwf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-11T17:30:10Z","updated_at":"2016-10-13T12:13:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mila-udem/fuel/pulls/368","html_url":"https://github.com/mila-udem/fuel/pull/368","diff_url":"https://github.com/mila-udem/fuel/pull/368.diff","patch_url":"https://github.com/mila-udem/fuel/pull/368.patch"},"body":"I've noticed that it's often a lot more expedient to stub out `get_data` if all you care is epoch iterators, so we might as well make it an optional implement."},"comment":{"url":"https://api.github.com/repos/mila-udem/fuel/issues/comments/253496040","html_url":"https://github.com/mila-udem/fuel/pull/368#issuecomment-253496040","issue_url":"https://api.github.com/repos/mila-udem/fuel/issues/368","id":253496040,"user":{"login":"rizar","id":654434,"avatar_url":"https://avatars.githubusercontent.com/u/654434?v=3","gravatar_id":"","url":"https://api.github.com/users/rizar","html_url":"https://github.com/rizar","followers_url":"https://api.github.com/users/rizar/followers","following_url":"https://api.github.com/users/rizar/following{/other_user}","gists_url":"https://api.github.com/users/rizar/gists{/gist_id}","starred_url":"https://api.github.com/users/rizar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rizar/subscriptions","organizations_url":"https://api.github.com/users/rizar/orgs","repos_url":"https://api.github.com/users/rizar/repos","events_url":"https://api.github.com/users/rizar/events{/privacy}","received_events_url":"https://api.github.com/users/rizar/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T12:13:34Z","updated_at":"2016-10-13T12:13:34Z","body":"I understand you right, your point is that very often the only method of a data stream that is actually called is `get_epoch_iterator`. Thus, it makes sense to make all other methods optional.\r\n\r\nIf my understanding is correct, I approve this change. I guess you still have to rebase. "}}
{"actor":{"display_login":"rizar"}}