{"action":"created","comment":{"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/comments/80044252","id":80044252,"diff_hunk":"@@ -1,26 +1,33 @@\n ---\n \n-# _environment can be set to e.g. \"staging\" on the command line. \n-# _version is then also preferably changed.\n+# If deploying to staging one should call with \n+# -e deployment_environment=staging\n+# One can also override the default installed version \n+# by overriding the arteria_checksum_version on the command line. \n #\n # This will set corresponding paths and use the appropriate port. \n arteria_siswrap_repo: https://github.com/arteria-project/arteria-siswrap.git\n arteria_siswrap_version: v1.1.0\n-arteria_siswrap_environment: production\n \n arteria_install_path: \"{{ root_path }}/sw/arteria\"\n \n # These values will be appended with production and staging specific\n # paths in the tasks.\n #\n # NB. The log dirs need to be created manually on destination cluster.\n+#\n+# NB 2. Hard coded root path for runfolders, because that path \n+# needs to be reachable from outside world; i.e. have to be under /proj\n+# And hard coded log paths because we do not want the log files \n+# to disappear when the wildwest directory is cleaned out with every \n+# staging sync. \n arteria_siswrap_env_root: \"{{ arteria_install_path }}/siswrap_venv\"\n arteria_siswrap_sources_path: \"{{ arteria_install_path }}/siswrap_src\"\n arteria_siswrap_config_root: \"{{ ngi_pipeline_conf }}/arteria/siswrap\"\n arteria_siswrap_app_config: \"{{ arteria_siswrap_config_root }}/app.config\"\n arteria_siswrap_logger_config: \"{{ arteria_siswrap_config_root }}/logger.config\"\n-arteria_siswrap_log: \"{{ ngi_pipeline_upps_path }}/log/arteria/siswrap-ws\"\n-runfolder_path: \"{{ proj_root }}/{{ ngi_pipeline_upps_delivery }}/incoming/\"\n+arteria_siswrap_log: \"/proj/{{ ngi_pipeline_upps_delivery }}/private/log/arteria/siswrap-ws\"\n+runfolder_path: \"/proj/{{ ngi_pipeline_upps_delivery }}/incoming/\"","path":"roles/arteria-siswrap-ws/defaults/main.yml","position":35,"original_position":35,"commit_id":"987c05409f635861bac135100facd62f512e3713","original_commit_id":"987c05409f635861bac135100facd62f512e3713","user":{"login":"johanherman","id":11720374,"avatar_url":"https://avatars.githubusercontent.com/u/11720374?v=3","gravatar_id":"","url":"https://api.github.com/users/johanherman","html_url":"https://github.com/johanherman","followers_url":"https://api.github.com/users/johanherman/followers","following_url":"https://api.github.com/users/johanherman/following{/other_user}","gists_url":"https://api.github.com/users/johanherman/gists{/gist_id}","starred_url":"https://api.github.com/users/johanherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanherman/subscriptions","organizations_url":"https://api.github.com/users/johanherman/orgs","repos_url":"https://api.github.com/users/johanherman/repos","events_url":"https://api.github.com/users/johanherman/events{/privacy}","received_events_url":"https://api.github.com/users/johanherman/received_events","type":"User","site_admin":false},"body":"Yeah. Especially the `runfolder_path` and the `arteria_checksum_monitored_path`. The Arteria staging services are tested in our complete workflow, i.e. including things that are happening automatically here in Uppsala. So our services here need to be able to upload data to the service at UPPMAX. And that can only happen inside the incoming dir under `/proj`. \r\n\r\nFor the logs dir... that's more a tracability issue. Because `wildwest` is cleaned with every sync of the staging environment. But as these are long running services then it is nice to be able to go back and look at historical events, therefore I changed them to be put under `/proj` as well so they don't get removed. ","created_at":"2016-09-22T13:51:23Z","updated_at":"2016-09-22T13:51:23Z","html_url":"https://github.com/NationalGenomicsInfrastructure/irma-provision/pull/144#discussion_r80044252","pull_request_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/comments/80044252"},"html":{"href":"https://github.com/NationalGenomicsInfrastructure/irma-provision/pull/144#discussion_r80044252"},"pull_request":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/144","id":86196548,"html_url":"https://github.com/NationalGenomicsInfrastructure/irma-provision/pull/144","diff_url":"https://github.com/NationalGenomicsInfrastructure/irma-provision/pull/144.diff","patch_url":"https://github.com/NationalGenomicsInfrastructure/irma-provision/pull/144.patch","issue_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/issues/144","number":144,"state":"open","locked":false,"title":"Fixes and updates to the staging env ","user":{"login":"johanherman","id":11720374,"avatar_url":"https://avatars.githubusercontent.com/u/11720374?v=3","gravatar_id":"","url":"https://api.github.com/users/johanherman","html_url":"https://github.com/johanherman","followers_url":"https://api.github.com/users/johanherman/followers","following_url":"https://api.github.com/users/johanherman/following{/other_user}","gists_url":"https://api.github.com/users/johanherman/gists{/gist_id}","starred_url":"https://api.github.com/users/johanherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanherman/subscriptions","organizations_url":"https://api.github.com/users/johanherman/orgs","repos_url":"https://api.github.com/users/johanherman/repos","events_url":"https://api.github.com/users/johanherman/events{/privacy}","received_events_url":"https://api.github.com/users/johanherman/received_events","type":"User","site_admin":false},"body":"This PR mainly updates the Arteria roles so that they use the Irma staging/prod environments instead of having their own internal staging/prod combos. \r\n\r\nIt also fixes a bug with `tasks/pre-install.yml` where `proj_root` got set to `/proj` even in staging due to a mistake I made when I added the `set_fact` for `milou_delivery`. I assumed the tasks were in a `block` only evaluated for production setups, but instead it got set all the time. \r\n\r\nThen we're now setting the Bash path explicitly instead of re-using the `PS1` variable, because that didn't work when having a staging env as a personal user (although it did work as a func user in production mode). Having it set like this instead makes it work in both setups though. ","created_at":"2016-09-21T16:24:50Z","updated_at":"2016-09-22T13:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ade84656cf798f9d33a579c6736a84036507993d","assignee":{"login":"sylvinite","id":5452272,"avatar_url":"https://avatars.githubusercontent.com/u/5452272?v=3","gravatar_id":"","url":"https://api.github.com/users/sylvinite","html_url":"https://github.com/sylvinite","followers_url":"https://api.github.com/users/sylvinite/followers","following_url":"https://api.github.com/users/sylvinite/following{/other_user}","gists_url":"https://api.github.com/users/sylvinite/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvinite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvinite/subscriptions","organizations_url":"https://api.github.com/users/sylvinite/orgs","repos_url":"https://api.github.com/users/sylvinite/repos","events_url":"https://api.github.com/users/sylvinite/events{/privacy}","received_events_url":"https://api.github.com/users/sylvinite/received_events","type":"User","site_admin":false},"assignees":[{"login":"sylvinite","id":5452272,"avatar_url":"https://avatars.githubusercontent.com/u/5452272?v=3","gravatar_id":"","url":"https://api.github.com/users/sylvinite","html_url":"https://github.com/sylvinite","followers_url":"https://api.github.com/users/sylvinite/followers","following_url":"https://api.github.com/users/sylvinite/following{/other_user}","gists_url":"https://api.github.com/users/sylvinite/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvinite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvinite/subscriptions","organizations_url":"https://api.github.com/users/sylvinite/orgs","repos_url":"https://api.github.com/users/sylvinite/repos","events_url":"https://api.github.com/users/sylvinite/events{/privacy}","received_events_url":"https://api.github.com/users/sylvinite/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/144/commits","review_comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/144/comments","review_comment_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/issues/144/comments","statuses_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/statuses/987c05409f635861bac135100facd62f512e3713","head":{"label":"johanherman:staging-fixes","ref":"staging-fixes","sha":"987c05409f635861bac135100facd62f512e3713","user":{"login":"johanherman","id":11720374,"avatar_url":"https://avatars.githubusercontent.com/u/11720374?v=3","gravatar_id":"","url":"https://api.github.com/users/johanherman","html_url":"https://github.com/johanherman","followers_url":"https://api.github.com/users/johanherman/followers","following_url":"https://api.github.com/users/johanherman/following{/other_user}","gists_url":"https://api.github.com/users/johanherman/gists{/gist_id}","starred_url":"https://api.github.com/users/johanherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanherman/subscriptions","organizations_url":"https://api.github.com/users/johanherman/orgs","repos_url":"https://api.github.com/users/johanherman/repos","events_url":"https://api.github.com/users/johanherman/events{/privacy}","received_events_url":"https://api.github.com/users/johanherman/received_events","type":"User","site_admin":false},"repo":{"id":56850572,"name":"irma-provision","full_name":"johanherman/irma-provision","owner":{"login":"johanherman","id":11720374,"avatar_url":"https://avatars.githubusercontent.com/u/11720374?v=3","gravatar_id":"","url":"https://api.github.com/users/johanherman","html_url":"https://github.com/johanherman","followers_url":"https://api.github.com/users/johanherman/followers","following_url":"https://api.github.com/users/johanherman/following{/other_user}","gists_url":"https://api.github.com/users/johanherman/gists{/gist_id}","starred_url":"https://api.github.com/users/johanherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanherman/subscriptions","organizations_url":"https://api.github.com/users/johanherman/orgs","repos_url":"https://api.github.com/users/johanherman/repos","events_url":"https://api.github.com/users/johanherman/events{/privacy}","received_events_url":"https://api.github.com/users/johanherman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johanherman/irma-provision","description":"Ansible playbooks for provisioning NGI pipeline and related sw","fork":true,"url":"https://api.github.com/repos/johanherman/irma-provision","forks_url":"https://api.github.com/repos/johanherman/irma-provision/forks","keys_url":"https://api.github.com/repos/johanherman/irma-provision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johanherman/irma-provision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johanherman/irma-provision/teams","hooks_url":"https://api.github.com/repos/johanherman/irma-provision/hooks","issue_events_url":"https://api.github.com/repos/johanherman/irma-provision/issues/events{/number}","events_url":"https://api.github.com/repos/johanherman/irma-provision/events","assignees_url":"https://api.github.com/repos/johanherman/irma-provision/assignees{/user}","branches_url":"https://api.github.com/repos/johanherman/irma-provision/branches{/branch}","tags_url":"https://api.github.com/repos/johanherman/irma-provision/tags","blobs_url":"https://api.github.com/repos/johanherman/irma-provision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johanherman/irma-provision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johanherman/irma-provision/git/refs{/sha}","trees_url":"https://api.github.com/repos/johanherman/irma-provision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johanherman/irma-provision/statuses/{sha}","languages_url":"https://api.github.com/repos/johanherman/irma-provision/languages","stargazers_url":"https://api.github.com/repos/johanherman/irma-provision/stargazers","contributors_url":"https://api.github.com/repos/johanherman/irma-provision/contributors","subscribers_url":"https://api.github.com/repos/johanherman/irma-provision/subscribers","subscription_url":"https://api.github.com/repos/johanherman/irma-provision/subscription","commits_url":"https://api.github.com/repos/johanherman/irma-provision/commits{/sha}","git_commits_url":"https://api.github.com/repos/johanherman/irma-provision/git/commits{/sha}","comments_url":"https://api.github.com/repos/johanherman/irma-provision/comments{/number}","issue_comment_url":"https://api.github.com/repos/johanherman/irma-provision/issues/comments{/number}","contents_url":"https://api.github.com/repos/johanherman/irma-provision/contents/{+path}","compare_url":"https://api.github.com/repos/johanherman/irma-provision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johanherman/irma-provision/merges","archive_url":"https://api.github.com/repos/johanherman/irma-provision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johanherman/irma-provision/downloads","issues_url":"https://api.github.com/repos/johanherman/irma-provision/issues{/number}","pulls_url":"https://api.github.com/repos/johanherman/irma-provision/pulls{/number}","milestones_url":"https://api.github.com/repos/johanherman/irma-provision/milestones{/number}","notifications_url":"https://api.github.com/repos/johanherman/irma-provision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johanherman/irma-provision/labels{/name}","releases_url":"https://api.github.com/repos/johanherman/irma-provision/releases{/id}","deployments_url":"https://api.github.com/repos/johanherman/irma-provision/deployments","created_at":"2016-04-22T11:28:36Z","updated_at":"2016-04-22T11:28:37Z","pushed_at":"2016-09-22T13:46:57Z","git_url":"git://github.com/johanherman/irma-provision.git","ssh_url":"git@github.com:johanherman/irma-provision.git","clone_url":"https://github.com/johanherman/irma-provision.git","svn_url":"https://github.com/johanherman/irma-provision","homepage":"","size":469,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NationalGenomicsInfrastructure:master","ref":"master","sha":"ec05db4ba0c9eea4c535ee335826e7cf7d7a4911","user":{"login":"NationalGenomicsInfrastructure","id":7566557,"avatar_url":"https://avatars.githubusercontent.com/u/7566557?v=3","gravatar_id":"","url":"https://api.github.com/users/NationalGenomicsInfrastructure","html_url":"https://github.com/NationalGenomicsInfrastructure","followers_url":"https://api.github.com/users/NationalGenomicsInfrastructure/followers","following_url":"https://api.github.com/users/NationalGenomicsInfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/NationalGenomicsInfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalGenomicsInfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalGenomicsInfrastructure/subscriptions","organizations_url":"https://api.github.com/users/NationalGenomicsInfrastructure/orgs","repos_url":"https://api.github.com/users/NationalGenomicsInfrastructure/repos","events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":53669245,"name":"irma-provision","full_name":"NationalGenomicsInfrastructure/irma-provision","owner":{"login":"NationalGenomicsInfrastructure","id":7566557,"avatar_url":"https://avatars.githubusercontent.com/u/7566557?v=3","gravatar_id":"","url":"https://api.github.com/users/NationalGenomicsInfrastructure","html_url":"https://github.com/NationalGenomicsInfrastructure","followers_url":"https://api.github.com/users/NationalGenomicsInfrastructure/followers","following_url":"https://api.github.com/users/NationalGenomicsInfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/NationalGenomicsInfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalGenomicsInfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalGenomicsInfrastructure/subscriptions","organizations_url":"https://api.github.com/users/NationalGenomicsInfrastructure/orgs","repos_url":"https://api.github.com/users/NationalGenomicsInfrastructure/repos","events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NationalGenomicsInfrastructure/irma-provision","description":"Ansible playbooks for provisioning NGI pipeline and related sw","fork":false,"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision","forks_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/forks","keys_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/teams","hooks_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/hooks","issue_events_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/issues/events{/number}","events_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/events","assignees_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/assignees{/user}","branches_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/branches{/branch}","tags_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/tags","blobs_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/git/refs{/sha}","trees_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/statuses/{sha}","languages_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/languages","stargazers_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/stargazers","contributors_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/contributors","subscribers_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/subscribers","subscription_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/subscription","commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/commits{/sha}","git_commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/git/commits{/sha}","comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/comments{/number}","issue_comment_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/issues/comments{/number}","contents_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/contents/{+path}","compare_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/merges","archive_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/downloads","issues_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/issues{/number}","pulls_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls{/number}","milestones_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/milestones{/number}","notifications_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/labels{/name}","releases_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/releases{/id}","deployments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/deployments","created_at":"2016-03-11T13:34:16Z","updated_at":"2016-04-22T11:19:27Z","pushed_at":"2016-09-21T16:24:50Z","git_url":"git://github.com/NationalGenomicsInfrastructure/irma-provision.git","ssh_url":"git@github.com:NationalGenomicsInfrastructure/irma-provision.git","clone_url":"https://github.com/NationalGenomicsInfrastructure/irma-provision.git","svn_url":"https://github.com/NationalGenomicsInfrastructure/irma-provision","homepage":"","size":464,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/144"},"html":{"href":"https://github.com/NationalGenomicsInfrastructure/irma-provision/pull/144"},"issue":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/issues/144"},"comments":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/irma-provision/statuses/987c05409f635861bac135100facd62f512e3713"}}}}
{"actor":{"display_login":"johanherman"}}