{"action":"created","issue":{"url":"https://api.github.com/repos/EFForg/privacybadgerchrome/issues/860","repository_url":"https://api.github.com/repos/EFForg/privacybadgerchrome","labels_url":"https://api.github.com/repos/EFForg/privacybadgerchrome/issues/860/labels{/name}","comments_url":"https://api.github.com/repos/EFForg/privacybadgerchrome/issues/860/comments","events_url":"https://api.github.com/repos/EFForg/privacybadgerchrome/issues/860/events","html_url":"https://github.com/EFForg/privacybadgerchrome/pull/860","id":158488702,"number":860,"title":"Fixing incognito mode","user":{"login":"cowlicks","id":598099,"avatar_url":"https://avatars.githubusercontent.com/u/598099?v=3","gravatar_id":"","url":"https://api.github.com/users/cowlicks","html_url":"https://github.com/cowlicks","followers_url":"https://api.github.com/users/cowlicks/followers","following_url":"https://api.github.com/users/cowlicks/following{/other_user}","gists_url":"https://api.github.com/users/cowlicks/gists{/gist_id}","starred_url":"https://api.github.com/users/cowlicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowlicks/subscriptions","organizations_url":"https://api.github.com/users/cowlicks/orgs","repos_url":"https://api.github.com/users/cowlicks/repos","events_url":"https://api.github.com/users/cowlicks/events{/privacy}","received_events_url":"https://api.github.com/users/cowlicks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2016-06-04T05:31:09Z","updated_at":"2016-07-08T18:21:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/EFForg/privacybadgerchrome/pulls/860","html_url":"https://github.com/EFForg/privacybadgerchrome/pull/860","diff_url":"https://github.com/EFForg/privacybadgerchrome/pull/860.diff","patch_url":"https://github.com/EFForg/privacybadgerchrome/pull/860.patch"},"body":"To get privacybadgerchrome to work with firefox, it needs to use the [`\"incognito\": \"spanning\"`](https://developer.chrome.com/extensions/manifest/incognito) manifest key.\r\n\r\nTo get spanning mode to work, privacy badger needs to manage the state of two sessions *in the same process*. One for the normal browsing mode, the other for incognito mode.\r\n\r\nTo do this, we need to encapsulate all the state of a privacy badger session. The current codebase takes for granted that there will only ever be one `pb` instance, so a lot of stuff is passed around globally.\r\n\r\nSo this pull request is a **major refactoring of privacy badger** which tries to encapsulate all this state, and add management for normal and incognito privacy badger sessions."},"comment":{"url":"https://api.github.com/repos/EFForg/privacybadgerchrome/issues/comments/231434930","html_url":"https://github.com/EFForg/privacybadgerchrome/pull/860#issuecomment-231434930","issue_url":"https://api.github.com/repos/EFForg/privacybadgerchrome/issues/860","id":231434930,"user":{"login":"cooperq","id":64981,"avatar_url":"https://avatars.githubusercontent.com/u/64981?v=3","gravatar_id":"","url":"https://api.github.com/users/cooperq","html_url":"https://github.com/cooperq","followers_url":"https://api.github.com/users/cooperq/followers","following_url":"https://api.github.com/users/cooperq/following{/other_user}","gists_url":"https://api.github.com/users/cooperq/gists{/gist_id}","starred_url":"https://api.github.com/users/cooperq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cooperq/subscriptions","organizations_url":"https://api.github.com/users/cooperq/orgs","repos_url":"https://api.github.com/users/cooperq/repos","events_url":"https://api.github.com/users/cooperq/events{/privacy}","received_events_url":"https://api.github.com/users/cooperq/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T18:21:34Z","updated_at":"2016-07-08T18:21:34Z","body":"@cowlicks this is looking pretty good, just one last bug, the popup seems to be totally broken now! The counter doesn't update and domains aren't being listed in the popup. Probably something to do with the recent changes you made but I don't have time to look into it ATM. "}}
{"actor":{"display_login":"cooperq"}}