{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/87297254","pull_request_review_id":7915802,"id":87297254,"diff_hunk":"@@ -0,0 +1,265 @@\n+# Copyright (C) 2016 Google Inc.\n+# Licensed under http://www.apache.org/licenses/LICENSE-2.0 <see LICENSE file>\n+\n+\"\"\"Manage indexing for snapshotter service\"\"\"\n+\n+from sqlalchemy.sql.expression import tuple_\n+\n+from ggrc import db\n+from ggrc import models\n+from ggrc.fulltext.mysql import MysqlRecordProperty as Record\n+from ggrc.models.reflection import AttributeInfo\n+\n+from ggrc.snapshotter.rules import Types\n+from ggrc.snapshotter.datastructures import Pair\n+\n+\n+def _get_tag(pair):\n+  return u\"{parent_type}-{parent_id}-{child_type}\".format(**{\n+      \"parent_type\": pair.parent.type,\n+      \"parent_id\": pair.parent.id,\n+      \"child_type\": pair.child.type,\n+  })","path":"src/ggrc/snapshotter/indexer.py","position":22,"original_position":22,"commit_id":"8beaf3b526533e570486ea2a90247ee777e055d9","original_commit_id":"8beaf3b526533e570486ea2a90247ee777e055d9","user":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"body":"@uskudnik I would still want the first issue to be resolved, so having kwargs instead of expanded dict here.","created_at":"2016-11-09T23:04:33Z","updated_at":"2016-11-09T23:04:33Z","html_url":"https://github.com/google/ggrc-core/pull/4654#discussion_r87297254","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/4654","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/87297254"},"html":{"href":"https://github.com/google/ggrc-core/pull/4654#discussion_r87297254"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4654"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/4654","id":92832988,"html_url":"https://github.com/google/ggrc-core/pull/4654","diff_url":"https://github.com/google/ggrc-core/pull/4654.diff","patch_url":"https://github.com/google/ggrc-core/pull/4654.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/4654","number":4654,"state":"open","locked":false,"title":"[FEATURE/SNAPSHOTS] Indexer","user":{"login":"uskudnik","id":120451,"avatar_url":"https://avatars.githubusercontent.com/u/120451?v=3","gravatar_id":"","url":"https://api.github.com/users/uskudnik","html_url":"https://github.com/uskudnik","followers_url":"https://api.github.com/users/uskudnik/followers","following_url":"https://api.github.com/users/uskudnik/following{/other_user}","gists_url":"https://api.github.com/users/uskudnik/gists{/gist_id}","starred_url":"https://api.github.com/users/uskudnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uskudnik/subscriptions","organizations_url":"https://api.github.com/users/uskudnik/orgs","repos_url":"https://api.github.com/users/uskudnik/repos","events_url":"https://api.github.com/users/uskudnik/events{/privacy}","received_events_url":"https://api.github.com/users/uskudnik/received_events","type":"User","site_admin":false},"body":"Add indexing support for snapshots.\r\n\r\nWhile I have tests (see #4237), those are not useful until we include full snapshotter into develop. However, indexing is needed to speed up the development of Query API support for snapshots.","created_at":"2016-11-08T18:27:29Z","updated_at":"2016-11-09T23:04:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c925b3adf560baadc1619ac0f4526bc236825597","assignee":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"assignees":[{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/22","html_url":"https://github.com/google/ggrc-core/milestones/0.10.0-Raspberry","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/22/labels","id":1902139,"number":22,"title":"0.10.0-Raspberry","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":75,"state":"open","created_at":"2016-07-25T10:56:23Z","updated_at":"2016-11-09T23:01:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/4654/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/4654/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/4654/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/8beaf3b526533e570486ea2a90247ee777e055d9","head":{"label":"uskudnik:feature-snapshot-indexer","ref":"feature-snapshot-indexer","sha":"8beaf3b526533e570486ea2a90247ee777e055d9","user":{"login":"uskudnik","id":120451,"avatar_url":"https://avatars.githubusercontent.com/u/120451?v=3","gravatar_id":"","url":"https://api.github.com/users/uskudnik","html_url":"https://github.com/uskudnik","followers_url":"https://api.github.com/users/uskudnik/followers","following_url":"https://api.github.com/users/uskudnik/following{/other_user}","gists_url":"https://api.github.com/users/uskudnik/gists{/gist_id}","starred_url":"https://api.github.com/users/uskudnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uskudnik/subscriptions","organizations_url":"https://api.github.com/users/uskudnik/orgs","repos_url":"https://api.github.com/users/uskudnik/repos","events_url":"https://api.github.com/users/uskudnik/events{/privacy}","received_events_url":"https://api.github.com/users/uskudnik/received_events","type":"User","site_admin":false},"repo":{"id":36459094,"name":"ggrc-core","full_name":"uskudnik/ggrc-core","owner":{"login":"uskudnik","id":120451,"avatar_url":"https://avatars.githubusercontent.com/u/120451?v=3","gravatar_id":"","url":"https://api.github.com/users/uskudnik","html_url":"https://github.com/uskudnik","followers_url":"https://api.github.com/users/uskudnik/followers","following_url":"https://api.github.com/users/uskudnik/following{/other_user}","gists_url":"https://api.github.com/users/uskudnik/gists{/gist_id}","starred_url":"https://api.github.com/users/uskudnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uskudnik/subscriptions","organizations_url":"https://api.github.com/users/uskudnik/orgs","repos_url":"https://api.github.com/users/uskudnik/repos","events_url":"https://api.github.com/users/uskudnik/events{/privacy}","received_events_url":"https://api.github.com/users/uskudnik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uskudnik/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/uskudnik/ggrc-core","forks_url":"https://api.github.com/repos/uskudnik/ggrc-core/forks","keys_url":"https://api.github.com/repos/uskudnik/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uskudnik/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uskudnik/ggrc-core/teams","hooks_url":"https://api.github.com/repos/uskudnik/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/uskudnik/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/uskudnik/ggrc-core/events","assignees_url":"https://api.github.com/repos/uskudnik/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/uskudnik/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/uskudnik/ggrc-core/tags","blobs_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uskudnik/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/uskudnik/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/uskudnik/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/uskudnik/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/uskudnik/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/uskudnik/ggrc-core/subscription","commits_url":"https://api.github.com/repos/uskudnik/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/uskudnik/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/uskudnik/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/uskudnik/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/uskudnik/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uskudnik/ggrc-core/merges","archive_url":"https://api.github.com/repos/uskudnik/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uskudnik/ggrc-core/downloads","issues_url":"https://api.github.com/repos/uskudnik/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/uskudnik/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/uskudnik/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/uskudnik/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uskudnik/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/uskudnik/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/uskudnik/ggrc-core/deployments","created_at":"2015-05-28T18:50:16Z","updated_at":"2015-05-28T18:50:20Z","pushed_at":"2016-11-09T23:01:21Z","git_url":"git://github.com/uskudnik/ggrc-core.git","ssh_url":"git@github.com:uskudnik/ggrc-core.git","clone_url":"https://github.com/uskudnik/ggrc-core.git","svn_url":"https://github.com/uskudnik/ggrc-core","homepage":null,"size":56256,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"91635624b8d74272d4904f532f9b19c145150679","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2016-11-02T01:18:34Z","pushed_at":"2016-11-09T23:01:19Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":66583,"stargazers_count":141,"watchers_count":141,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":23,"forks":110,"open_issues":23,"watchers":141,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4654"},"html":{"href":"https://github.com/google/ggrc-core/pull/4654"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/4654"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/4654/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4654/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4654/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/8beaf3b526533e570486ea2a90247ee777e055d9"}}}}
{"actor":{"display_login":"zidarsk8"}}