{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/73127988","id":73127988,"diff_hunk":"@@ -26,6 +26,7 @@\n import org.elasticsearch.Version;\n import org.elasticsearch.cluster.node.DiscoveryNode;\n import org.elasticsearch.common.Strings;\n+import org.elasticsearch.common.SuppressForbidden;","path":"core/src/main/java/org/elasticsearch/transport/TcpTransport.java","position":null,"original_position":4,"commit_id":"5c0ebd02fbbeecd5c37a3f9f4c1703283e4e8dec","original_commit_id":"c2284066bd33029996619291f063f5cf8c2001c6","user":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars.githubusercontent.com/u/1699576?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"body":"Right, I missed it. Thanks for spotting it. I've removed it now.","created_at":"2016-08-02T10:06:26Z","updated_at":"2016-08-02T10:06:26Z","html_url":"https://github.com/elastic/elasticsearch/pull/19677#discussion_r73127988","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/19677","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/73127988"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/19677#discussion_r73127988"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/19677"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/19677","id":79326709,"html_url":"https://github.com/elastic/elasticsearch/pull/19677","diff_url":"https://github.com/elastic/elasticsearch/pull/19677.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/19677.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/19677","number":19677,"state":"open","locked":false,"title":"Ban dangerous methods of java.lang.Thread","user":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars.githubusercontent.com/u/1699576?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"body":"With this commit we disallow usage of the methods Thread.stop()\r\nand Thread.interrupted(). The former should never be used at all\r\nand the latter has certain side effects that are often not\r\nintended.","created_at":"2016-07-29T08:52:58Z","updated_at":"2016-08-02T10:06:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ce074149ec92aa1b9938cf42b3a450fe0dcd615","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/19677/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/19677/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/19677/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/5c0ebd02fbbeecd5c37a3f9f4c1703283e4e8dec","head":{"label":"danielmitterdorfer:ban-dangerous-methods-on-thread","ref":"ban-dangerous-methods-on-thread","sha":"5c0ebd02fbbeecd5c37a3f9f4c1703283e4e8dec","user":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars.githubusercontent.com/u/1699576?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"repo":{"id":45385894,"name":"elasticsearch","full_name":"danielmitterdorfer/elasticsearch","owner":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars.githubusercontent.com/u/1699576?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielmitterdorfer/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch","forks_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/forks","keys_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/teams","hooks_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/events","assignees_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/tags","blobs_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/subscription","commits_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/merges","archive_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/downloads","issues_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/deployments","created_at":"2015-11-02T09:51:30Z","updated_at":"2016-07-03T08:20:37Z","pushed_at":"2016-08-02T10:05:53Z","git_url":"git://github.com/danielmitterdorfer/elasticsearch.git","ssh_url":"git@github.com:danielmitterdorfer/elasticsearch.git","clone_url":"https://github.com/danielmitterdorfer/elasticsearch.git","svn_url":"https://github.com/danielmitterdorfer/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":230831,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"5a99ce5b91411015594ab0afb296900580f103b0","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-08-02T10:00:38Z","pushed_at":"2016-08-02T10:05:57Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":338782,"stargazers_count":17676,"watchers_count":17676,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5975,"mirror_url":null,"open_issues_count":1093,"forks":5975,"open_issues":1093,"watchers":17676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/19677"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/19677"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/19677"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/19677/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/19677/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/19677/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/5c0ebd02fbbeecd5c37a3f9f4c1703283e4e8dec"}}}}
{"actor":{"display_login":"danielmitterdorfer"}}