{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/maxwell/pulls/comments/48927463","id":48927463,"diff_hunk":"@@ -85,7 +87,7 @@ private void store(BinlogPosition newPosition) {\n \t\tif ( newPosition == null )\n \t\t\treturn;\n \n-\t\tString sql = \"INSERT INTO `maxwell`.`positions` set \"\n+\t\tString sql = \"INSERT INTO `\" + this.schemaDatabaseName + \"`.`positions` set \"","path":"src/main/java/com/zendesk/maxwell/schema/SchemaPosition.java","position":21,"original_position":21,"commit_id":"a869547daffa42a634a891d1e352dd049a5c9753","original_commit_id":"a869547daffa42a634a891d1e352dd049a5c9753","user":{"login":"osheroff","id":260084,"avatar_url":"https://avatars.githubusercontent.com/u/260084?v=3","gravatar_id":"","url":"https://api.github.com/users/osheroff","html_url":"https://github.com/osheroff","followers_url":"https://api.github.com/users/osheroff/followers","following_url":"https://api.github.com/users/osheroff/following{/other_user}","gists_url":"https://api.github.com/users/osheroff/gists{/gist_id}","starred_url":"https://api.github.com/users/osheroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheroff/subscriptions","organizations_url":"https://api.github.com/users/osheroff/orgs","repos_url":"https://api.github.com/users/osheroff/repos","events_url":"https://api.github.com/users/osheroff/events{/privacy}","received_events_url":"https://api.github.com/users/osheroff/received_events","type":"User","site_admin":false},"body":"all of these look like potential SQL injection sites to me.  Maybe we instead of substituting in the dbName we strip off the explicit db name and connect the `ConnectionPool` to a particular db?  (if that's possible...)","created_at":"2016-01-06T04:46:54Z","updated_at":"2016-01-06T04:46:54Z","html_url":"https://github.com/zendesk/maxwell/pull/242#discussion_r48927463","pull_request_url":"https://api.github.com/repos/zendesk/maxwell/pulls/242","_links":{"self":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/comments/48927463"},"html":{"href":"https://github.com/zendesk/maxwell/pull/242#discussion_r48927463"},"pull_request":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/maxwell/pulls/242","id":55175562,"html_url":"https://github.com/zendesk/maxwell/pull/242","diff_url":"https://github.com/zendesk/maxwell/pull/242.diff","patch_url":"https://github.com/zendesk/maxwell/pull/242.patch","issue_url":"https://api.github.com/repos/zendesk/maxwell/issues/242","number":242,"state":"open","locked":false,"title":"Allow custom maxwell database name","user":{"login":"kristiankaufmann","id":2005858,"avatar_url":"https://avatars.githubusercontent.com/u/2005858?v=3","gravatar_id":"","url":"https://api.github.com/users/kristiankaufmann","html_url":"https://github.com/kristiankaufmann","followers_url":"https://api.github.com/users/kristiankaufmann/followers","following_url":"https://api.github.com/users/kristiankaufmann/following{/other_user}","gists_url":"https://api.github.com/users/kristiankaufmann/gists{/gist_id}","starred_url":"https://api.github.com/users/kristiankaufmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristiankaufmann/subscriptions","organizations_url":"https://api.github.com/users/kristiankaufmann/orgs","repos_url":"https://api.github.com/users/kristiankaufmann/repos","events_url":"https://api.github.com/users/kristiankaufmann/events{/privacy}","received_events_url":"https://api.github.com/users/kristiankaufmann/received_events","type":"User","site_admin":false},"body":"resolves zendesk/maxwell#225\r\n\r\ntests still pending.","created_at":"2016-01-06T04:16:52Z","updated_at":"2016-01-06T04:46:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d278d7684ddff721a470b189a47d897037d4d89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/maxwell/pulls/242/commits","review_comments_url":"https://api.github.com/repos/zendesk/maxwell/pulls/242/comments","review_comment_url":"https://api.github.com/repos/zendesk/maxwell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/maxwell/issues/242/comments","statuses_url":"https://api.github.com/repos/zendesk/maxwell/statuses/a869547daffa42a634a891d1e352dd049a5c9753","head":{"label":"kristiankaufmann:allow_custom_maxwell_database_name","ref":"allow_custom_maxwell_database_name","sha":"a869547daffa42a634a891d1e352dd049a5c9753","user":{"login":"kristiankaufmann","id":2005858,"avatar_url":"https://avatars.githubusercontent.com/u/2005858?v=3","gravatar_id":"","url":"https://api.github.com/users/kristiankaufmann","html_url":"https://github.com/kristiankaufmann","followers_url":"https://api.github.com/users/kristiankaufmann/followers","following_url":"https://api.github.com/users/kristiankaufmann/following{/other_user}","gists_url":"https://api.github.com/users/kristiankaufmann/gists{/gist_id}","starred_url":"https://api.github.com/users/kristiankaufmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristiankaufmann/subscriptions","organizations_url":"https://api.github.com/users/kristiankaufmann/orgs","repos_url":"https://api.github.com/users/kristiankaufmann/repos","events_url":"https://api.github.com/users/kristiankaufmann/events{/privacy}","received_events_url":"https://api.github.com/users/kristiankaufmann/received_events","type":"User","site_admin":false},"repo":{"id":47561738,"name":"maxwell","full_name":"kristiankaufmann/maxwell","owner":{"login":"kristiankaufmann","id":2005858,"avatar_url":"https://avatars.githubusercontent.com/u/2005858?v=3","gravatar_id":"","url":"https://api.github.com/users/kristiankaufmann","html_url":"https://github.com/kristiankaufmann","followers_url":"https://api.github.com/users/kristiankaufmann/followers","following_url":"https://api.github.com/users/kristiankaufmann/following{/other_user}","gists_url":"https://api.github.com/users/kristiankaufmann/gists{/gist_id}","starred_url":"https://api.github.com/users/kristiankaufmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristiankaufmann/subscriptions","organizations_url":"https://api.github.com/users/kristiankaufmann/orgs","repos_url":"https://api.github.com/users/kristiankaufmann/repos","events_url":"https://api.github.com/users/kristiankaufmann/events{/privacy}","received_events_url":"https://api.github.com/users/kristiankaufmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kristiankaufmann/maxwell","description":"Maxwell's daemon, a mysqlbinlog->kafka/json pusher","fork":true,"url":"https://api.github.com/repos/kristiankaufmann/maxwell","forks_url":"https://api.github.com/repos/kristiankaufmann/maxwell/forks","keys_url":"https://api.github.com/repos/kristiankaufmann/maxwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kristiankaufmann/maxwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kristiankaufmann/maxwell/teams","hooks_url":"https://api.github.com/repos/kristiankaufmann/maxwell/hooks","issue_events_url":"https://api.github.com/repos/kristiankaufmann/maxwell/issues/events{/number}","events_url":"https://api.github.com/repos/kristiankaufmann/maxwell/events","assignees_url":"https://api.github.com/repos/kristiankaufmann/maxwell/assignees{/user}","branches_url":"https://api.github.com/repos/kristiankaufmann/maxwell/branches{/branch}","tags_url":"https://api.github.com/repos/kristiankaufmann/maxwell/tags","blobs_url":"https://api.github.com/repos/kristiankaufmann/maxwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kristiankaufmann/maxwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kristiankaufmann/maxwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/kristiankaufmann/maxwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kristiankaufmann/maxwell/statuses/{sha}","languages_url":"https://api.github.com/repos/kristiankaufmann/maxwell/languages","stargazers_url":"https://api.github.com/repos/kristiankaufmann/maxwell/stargazers","contributors_url":"https://api.github.com/repos/kristiankaufmann/maxwell/contributors","subscribers_url":"https://api.github.com/repos/kristiankaufmann/maxwell/subscribers","subscription_url":"https://api.github.com/repos/kristiankaufmann/maxwell/subscription","commits_url":"https://api.github.com/repos/kristiankaufmann/maxwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/kristiankaufmann/maxwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/kristiankaufmann/maxwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/kristiankaufmann/maxwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/kristiankaufmann/maxwell/contents/{+path}","compare_url":"https://api.github.com/repos/kristiankaufmann/maxwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kristiankaufmann/maxwell/merges","archive_url":"https://api.github.com/repos/kristiankaufmann/maxwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kristiankaufmann/maxwell/downloads","issues_url":"https://api.github.com/repos/kristiankaufmann/maxwell/issues{/number}","pulls_url":"https://api.github.com/repos/kristiankaufmann/maxwell/pulls{/number}","milestones_url":"https://api.github.com/repos/kristiankaufmann/maxwell/milestones{/number}","notifications_url":"https://api.github.com/repos/kristiankaufmann/maxwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kristiankaufmann/maxwell/labels{/name}","releases_url":"https://api.github.com/repos/kristiankaufmann/maxwell/releases{/id}","created_at":"2015-12-07T15:44:27Z","updated_at":"2015-12-07T15:44:28Z","pushed_at":"2016-01-06T04:40:45Z","git_url":"git://github.com/kristiankaufmann/maxwell.git","ssh_url":"git@github.com:kristiankaufmann/maxwell.git","clone_url":"https://github.com/kristiankaufmann/maxwell.git","svn_url":"https://github.com/kristiankaufmann/maxwell","homepage":"http://maxwells-daemon.io/","size":6902,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"f1051eedc92ae09c23ef93f5b83867e15f8b1209","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":30561160,"name":"maxwell","full_name":"zendesk/maxwell","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/maxwell","description":"Maxwell's daemon, a mysqlbinlog->kafka/json pusher","fork":false,"url":"https://api.github.com/repos/zendesk/maxwell","forks_url":"https://api.github.com/repos/zendesk/maxwell/forks","keys_url":"https://api.github.com/repos/zendesk/maxwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/maxwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/maxwell/teams","hooks_url":"https://api.github.com/repos/zendesk/maxwell/hooks","issue_events_url":"https://api.github.com/repos/zendesk/maxwell/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/maxwell/events","assignees_url":"https://api.github.com/repos/zendesk/maxwell/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/maxwell/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/maxwell/tags","blobs_url":"https://api.github.com/repos/zendesk/maxwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/maxwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/maxwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/maxwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/maxwell/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/maxwell/languages","stargazers_url":"https://api.github.com/repos/zendesk/maxwell/stargazers","contributors_url":"https://api.github.com/repos/zendesk/maxwell/contributors","subscribers_url":"https://api.github.com/repos/zendesk/maxwell/subscribers","subscription_url":"https://api.github.com/repos/zendesk/maxwell/subscription","commits_url":"https://api.github.com/repos/zendesk/maxwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/maxwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/maxwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/maxwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/maxwell/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/maxwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/maxwell/merges","archive_url":"https://api.github.com/repos/zendesk/maxwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/maxwell/downloads","issues_url":"https://api.github.com/repos/zendesk/maxwell/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/maxwell/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/maxwell/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/maxwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/maxwell/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/maxwell/releases{/id}","created_at":"2015-02-09T22:06:13Z","updated_at":"2016-01-04T08:51:16Z","pushed_at":"2016-01-06T04:38:51Z","git_url":"git://github.com/zendesk/maxwell.git","ssh_url":"git@github.com:zendesk/maxwell.git","clone_url":"https://github.com/zendesk/maxwell.git","svn_url":"https://github.com/zendesk/maxwell","homepage":"http://maxwells-daemon.io/","size":7045,"stargazers_count":73,"watchers_count":73,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":25,"forks":26,"open_issues":25,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/242"},"html":{"href":"https://github.com/zendesk/maxwell/pull/242"},"issue":{"href":"https://api.github.com/repos/zendesk/maxwell/issues/242"},"comments":{"href":"https://api.github.com/repos/zendesk/maxwell/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/maxwell/statuses/a869547daffa42a634a891d1e352dd049a5c9753"}}}}