{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/69550459","id":69550459,"diff_hunk":"@@ -82,9 +82,4 @@ void OPENSSL_add_all_algorithms_noconf(void)\n     OPENSSL_cpuid_setup();\n     OpenSSL_add_all_ciphers();\n     OpenSSL_add_all_digests();\n-#ifndef OPENSSL_NO_ENGINE\n-# if defined(__OpenBSD__) || defined(__FreeBSD__) || defined(HAVE_CRYPTODEV)\n-    ENGINE_setup_bsd_cryptodev();\n-# endif\n-#endif","path":"crypto/evp/c_all.c","position":8,"original_position":8,"commit_id":"8164badaf5c7f80e21961b8ed9da9327174fea90","original_commit_id":"88a149619c8a582144e397322aacba300667ab0d","user":{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"body":"I got inspired, see #1288","created_at":"2016-07-05T11:59:34Z","updated_at":"2016-07-05T11:59:34Z","html_url":"https://github.com/openssl/openssl/pull/1285#discussion_r69550459","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/1285","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/69550459"},"html":{"href":"https://github.com/openssl/openssl/pull/1285#discussion_r69550459"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1285"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/1285","id":76242155,"html_url":"https://github.com/openssl/openssl/pull/1285","diff_url":"https://github.com/openssl/openssl/pull/1285.diff","patch_url":"https://github.com/openssl/openssl/pull/1285.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/1285","number":1285,"state":"open","locked":false,"title":"remove double initialization of cryptodev engine","user":{"login":"cristian-stoica","id":19388796,"avatar_url":"https://avatars.githubusercontent.com/u/19388796?v=3","gravatar_id":"","url":"https://api.github.com/users/cristian-stoica","html_url":"https://github.com/cristian-stoica","followers_url":"https://api.github.com/users/cristian-stoica/followers","following_url":"https://api.github.com/users/cristian-stoica/following{/other_user}","gists_url":"https://api.github.com/users/cristian-stoica/gists{/gist_id}","starred_url":"https://api.github.com/users/cristian-stoica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristian-stoica/subscriptions","organizations_url":"https://api.github.com/users/cristian-stoica/orgs","repos_url":"https://api.github.com/users/cristian-stoica/repos","events_url":"https://api.github.com/users/cristian-stoica/events{/privacy}","received_events_url":"https://api.github.com/users/cristian-stoica/received_events","type":"User","site_admin":false},"body":"cryptodev engine is initialized together with the other engines in\r\nENGINE_load_builtin_engines. The initialization done through\r\nOpenSSL_add_all_algorithms is redundant.\r\n\r\nSigned-off-by: Cristian Stoica <cristian.stoica@nxp.com>","created_at":"2016-07-05T09:23:06Z","updated_at":"2016-07-05T11:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c44b51f81c10346f9a325950b9540860d26a4ebb","assignee":{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"assignees":[{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/1285/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/1285/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/1285/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/8164badaf5c7f80e21961b8ed9da9327174fea90","head":{"label":"cristian-stoica:clean-eng-init","ref":"clean-eng-init","sha":"8164badaf5c7f80e21961b8ed9da9327174fea90","user":{"login":"cristian-stoica","id":19388796,"avatar_url":"https://avatars.githubusercontent.com/u/19388796?v=3","gravatar_id":"","url":"https://api.github.com/users/cristian-stoica","html_url":"https://github.com/cristian-stoica","followers_url":"https://api.github.com/users/cristian-stoica/followers","following_url":"https://api.github.com/users/cristian-stoica/following{/other_user}","gists_url":"https://api.github.com/users/cristian-stoica/gists{/gist_id}","starred_url":"https://api.github.com/users/cristian-stoica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristian-stoica/subscriptions","organizations_url":"https://api.github.com/users/cristian-stoica/orgs","repos_url":"https://api.github.com/users/cristian-stoica/repos","events_url":"https://api.github.com/users/cristian-stoica/events{/privacy}","received_events_url":"https://api.github.com/users/cristian-stoica/received_events","type":"User","site_admin":false},"repo":{"id":58931568,"name":"openssl","full_name":"cristian-stoica/openssl","owner":{"login":"cristian-stoica","id":19388796,"avatar_url":"https://avatars.githubusercontent.com/u/19388796?v=3","gravatar_id":"","url":"https://api.github.com/users/cristian-stoica","html_url":"https://github.com/cristian-stoica","followers_url":"https://api.github.com/users/cristian-stoica/followers","following_url":"https://api.github.com/users/cristian-stoica/following{/other_user}","gists_url":"https://api.github.com/users/cristian-stoica/gists{/gist_id}","starred_url":"https://api.github.com/users/cristian-stoica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristian-stoica/subscriptions","organizations_url":"https://api.github.com/users/cristian-stoica/orgs","repos_url":"https://api.github.com/users/cristian-stoica/repos","events_url":"https://api.github.com/users/cristian-stoica/events{/privacy}","received_events_url":"https://api.github.com/users/cristian-stoica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cristian-stoica/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/cristian-stoica/openssl","forks_url":"https://api.github.com/repos/cristian-stoica/openssl/forks","keys_url":"https://api.github.com/repos/cristian-stoica/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristian-stoica/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristian-stoica/openssl/teams","hooks_url":"https://api.github.com/repos/cristian-stoica/openssl/hooks","issue_events_url":"https://api.github.com/repos/cristian-stoica/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/cristian-stoica/openssl/events","assignees_url":"https://api.github.com/repos/cristian-stoica/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/cristian-stoica/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/cristian-stoica/openssl/tags","blobs_url":"https://api.github.com/repos/cristian-stoica/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristian-stoica/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristian-stoica/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristian-stoica/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristian-stoica/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/cristian-stoica/openssl/languages","stargazers_url":"https://api.github.com/repos/cristian-stoica/openssl/stargazers","contributors_url":"https://api.github.com/repos/cristian-stoica/openssl/contributors","subscribers_url":"https://api.github.com/repos/cristian-stoica/openssl/subscribers","subscription_url":"https://api.github.com/repos/cristian-stoica/openssl/subscription","commits_url":"https://api.github.com/repos/cristian-stoica/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristian-stoica/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristian-stoica/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristian-stoica/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cristian-stoica/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/cristian-stoica/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristian-stoica/openssl/merges","archive_url":"https://api.github.com/repos/cristian-stoica/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristian-stoica/openssl/downloads","issues_url":"https://api.github.com/repos/cristian-stoica/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/cristian-stoica/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/cristian-stoica/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/cristian-stoica/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristian-stoica/openssl/labels{/name}","releases_url":"https://api.github.com/repos/cristian-stoica/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/cristian-stoica/openssl/deployments","created_at":"2016-05-16T12:43:26Z","updated_at":"2016-05-16T12:43:39Z","pushed_at":"2016-07-05T11:59:11Z","git_url":"git://github.com/cristian-stoica/openssl.git","ssh_url":"git@github.com:cristian-stoica/openssl.git","clone_url":"https://github.com/cristian-stoica/openssl.git","svn_url":"https://github.com/cristian-stoica/openssl","homepage":"https://www.openssl.org","size":91126,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:OpenSSL_1_0_2-stable","ref":"OpenSSL_1_0_2-stable","sha":"77857ddcca41e1ad34725715fe7b32adc4de7930","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-07-05T06:40:10Z","pushed_at":"2016-07-05T11:59:12Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":111617,"stargazers_count":2841,"watchers_count":2841,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1633,"mirror_url":null,"open_issues_count":105,"forks":1633,"open_issues":105,"watchers":2841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1285"},"html":{"href":"https://github.com/openssl/openssl/pull/1285"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/1285"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/1285/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1285/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1285/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/8164badaf5c7f80e21961b8ed9da9327174fea90"}}}}
{"actor":{"display_login":"levitte"}}