{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/10363","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/10363/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10363/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/10363/events","html_url":"https://github.com/openshift/origin/pull/10363","id":170743789,"number":10363,"title":"emit warning on no liveness probe defined for pods","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars.githubusercontent.com/u/3902875?v=3","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-08-11T20:53:10Z","updated_at":"2016-10-26T20:29:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10363","html_url":"https://github.com/openshift/origin/pull/10363","diff_url":"https://github.com/openshift/origin/pull/10363.diff","patch_url":"https://github.com/openshift/origin/pull/10363.patch"},"body":"fixes #10271\r\n\r\nThis patch iterates through pod specs, listing specs with no liveness\r\nprobes set. Any replication controllers whose deployment is fulfilled by\r\na DeploymentConfig are ignored.\r\n\r\n**Example**\r\n```\r\n$ oc create -f pkg/api/graph/test/simple-deployment\r\ndeploymentconfig \"simple-deployment\" created\r\n\r\n$ oc get all\r\nNAME                   REVISION   DESIRED   CURRENT   TRIGGERED BY\r\ndc/simple-deployment   1          1         0         config\r\n\r\nNAME                     DESIRED   CURRENT   READY     AGE\r\nrc/simple-deployment-1   0         0         0         1m\r\n\r\nNAME                            READY     STATUS              RESTARTS\r\nAGE\r\npo/simple-deployment-1-deploy   0/1       ContainerCreating   0\r\n1m\r\n\r\n$ oc status -v\r\nIn project test on server https://10.111.123.56:8443\r\n\r\ndc/simple-deployment deploys docker.io/openshift/deployment-example:v1\r\n  deployment #1 pending 26 seconds ago\r\n\r\nWarnings:\r\n  * pod/simple-deployment-1-deploy has no liveness probe to verify pods are still running.\r\n    try: oc set probe pod/simple-deployment-1-deploy --liveness ...\r\n  * dc/simple-deployment has no liveness probe to verify pods are still running.\r\n    try: oc set probe dc/simple-deployment --liveness ...\r\n\r\nView details with 'oc describe <resource>/<name>' or list everything with 'oc get all'.\r\n```\r\ncc @fabianofranz @stevekuznetsov "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/256467590","html_url":"https://github.com/openshift/origin/pull/10363#issuecomment-256467590","issue_url":"https://api.github.com/repos/openshift/origin/issues/10363","id":256467590,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T20:29:38Z","updated_at":"2016-10-26T20:29:38Z","body":"continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10701/) (Base Commit: 8bb33be163deaf9613874398757006b3e631f6d3)"}}
{"actor":{"display_login":"openshift-bot"}}