{"action":"created","issue":{"url":"https://api.github.com/repos/cornernote/minetest-bags/issues/2","repository_url":"https://api.github.com/repos/cornernote/minetest-bags","labels_url":"https://api.github.com/repos/cornernote/minetest-bags/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/cornernote/minetest-bags/issues/2/comments","events_url":"https://api.github.com/repos/cornernote/minetest-bags/issues/2/events","html_url":"https://github.com/cornernote/minetest-bags/issues/2","id":192119491,"number":2,"title":"minetest.create_detached_inventory updates","user":{"login":"Fixer-007","id":16494741,"avatar_url":"https://avatars.githubusercontent.com/u/16494741?v=3","gravatar_id":"","url":"https://api.github.com/users/Fixer-007","html_url":"https://github.com/Fixer-007","followers_url":"https://api.github.com/users/Fixer-007/followers","following_url":"https://api.github.com/users/Fixer-007/following{/other_user}","gists_url":"https://api.github.com/users/Fixer-007/gists{/gist_id}","starred_url":"https://api.github.com/users/Fixer-007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fixer-007/subscriptions","organizations_url":"https://api.github.com/users/Fixer-007/orgs","repos_url":"https://api.github.com/users/Fixer-007/repos","events_url":"https://api.github.com/users/Fixer-007/events{/privacy}","received_events_url":"https://api.github.com/users/Fixer-007/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-28T21:17:27Z","updated_at":"2016-11-28T22:48:38Z","closed_at":null,"body":"There were changes to minetest.create_detached_inventory function, due to bug https://github.com/minetest/minetest/issues/4403, there were fixes merged: https://github.com/minetest/minetest/pull/4812 and https://github.com/minetest/minetest_game/pull/1413.\r\n\r\nBasically on player join all other players detached inventories were send to player causing him to have severe 0 0 0 bug for several minutes on some servers. This was fixed, but some mod makers should check their mods for use of this function to send only his player inventory to him if needed.\r\n\r\nAlso quoting sfan5 about minetest.create_detached_inventory(player:get_player_name():\r\n>everything with :get_player_name() definitely need a fix\r\n\r\nNew function info:\r\n```\r\n* `minetest.create_detached_inventory(name, callbacks, [player_name])`: returns an `InvRef`\r\n    * callbacks: See \"Detached inventory callbacks\"\r\n    * player_name: Make detached inventory available to one player exclusively,\r\n      by default they will be sent to every player (even if not used).\r\n      Note that this parameter is mostly just a workaround and will be removed in future releases.\r\n    * Creates a detached inventory. If it already exists, it is cleared.\r\n```\r\n\r\nYour mod has this: \r\n```\r\nminetest-bags/bags/init.lua:64:\tlocal bags_inv = minetest.create_detached_inventory(player:get_player_name()..\"_bags\",{\r\n```\r\n\r\nI hope I described it right. Some mods are already updated. If not sure ask on IRC."},"comment":{"url":"https://api.github.com/repos/cornernote/minetest-bags/issues/comments/263419790","html_url":"https://github.com/cornernote/minetest-bags/issues/2#issuecomment-263419790","issue_url":"https://api.github.com/repos/cornernote/minetest-bags/issues/2","id":263419790,"user":{"login":"cornernote","id":51875,"avatar_url":"https://avatars.githubusercontent.com/u/51875?v=3","gravatar_id":"","url":"https://api.github.com/users/cornernote","html_url":"https://github.com/cornernote","followers_url":"https://api.github.com/users/cornernote/followers","following_url":"https://api.github.com/users/cornernote/following{/other_user}","gists_url":"https://api.github.com/users/cornernote/gists{/gist_id}","starred_url":"https://api.github.com/users/cornernote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornernote/subscriptions","organizations_url":"https://api.github.com/users/cornernote/orgs","repos_url":"https://api.github.com/users/cornernote/repos","events_url":"https://api.github.com/users/cornernote/events{/privacy}","received_events_url":"https://api.github.com/users/cornernote/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T22:48:38Z","updated_at":"2016-11-28T22:48:38Z","body":"Hi @Fixer-007 \r\n\r\nThanks for pointing this out.  Would you like to submit a PR for this change?"}}
{"actor":{"display_login":"cornernote"}}