{"action":"created","issue":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/issues/363","repository_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead","labels_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/issues/363/labels{/name}","comments_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/issues/363/comments","events_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/issues/363/events","html_url":"https://github.com/duckduckgo/zeroclickinfo-fathead/pull/363","id":175583396,"number":363,"title":"MDN CSS: Add support for -webkit and -moz extensions","user":{"login":"rasikapohankar","id":8025692,"avatar_url":"https://avatars.githubusercontent.com/u/8025692?v=3","gravatar_id":"","url":"https://api.github.com/users/rasikapohankar","html_url":"https://github.com/rasikapohankar","followers_url":"https://api.github.com/users/rasikapohankar/followers","following_url":"https://api.github.com/users/rasikapohankar/following{/other_user}","gists_url":"https://api.github.com/users/rasikapohankar/gists{/gist_id}","starred_url":"https://api.github.com/users/rasikapohankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasikapohankar/subscriptions","organizations_url":"https://api.github.com/users/rasikapohankar/orgs","repos_url":"https://api.github.com/users/rasikapohankar/repos","events_url":"https://api.github.com/users/rasikapohankar/events{/privacy}","received_events_url":"https://api.github.com/users/rasikapohankar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/labels/Improvement","name":"Improvement","color":"d7e102"},{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/labels/Mission:%20Programming","name":"Mission: Programming","color":"60a5da"}],"state":"open","locked":false,"assignee":{"login":"hchienjo","id":13175534,"avatar_url":"https://avatars.githubusercontent.com/u/13175534?v=3","gravatar_id":"","url":"https://api.github.com/users/hchienjo","html_url":"https://github.com/hchienjo","followers_url":"https://api.github.com/users/hchienjo/followers","following_url":"https://api.github.com/users/hchienjo/following{/other_user}","gists_url":"https://api.github.com/users/hchienjo/gists{/gist_id}","starred_url":"https://api.github.com/users/hchienjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hchienjo/subscriptions","organizations_url":"https://api.github.com/users/hchienjo/orgs","repos_url":"https://api.github.com/users/hchienjo/repos","events_url":"https://api.github.com/users/hchienjo/events{/privacy}","received_events_url":"https://api.github.com/users/hchienjo/received_events","type":"User","site_admin":false},"assignees":[{"login":"hchienjo","id":13175534,"avatar_url":"https://avatars.githubusercontent.com/u/13175534?v=3","gravatar_id":"","url":"https://api.github.com/users/hchienjo","html_url":"https://github.com/hchienjo","followers_url":"https://api.github.com/users/hchienjo/followers","following_url":"https://api.github.com/users/hchienjo/following{/other_user}","gists_url":"https://api.github.com/users/hchienjo/gists{/gist_id}","starred_url":"https://api.github.com/users/hchienjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hchienjo/subscriptions","organizations_url":"https://api.github.com/users/hchienjo/orgs","repos_url":"https://api.github.com/users/hchienjo/repos","events_url":"https://api.github.com/users/hchienjo/events{/privacy}","received_events_url":"https://api.github.com/users/hchienjo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-09-07T19:18:06Z","updated_at":"2016-09-14T14:50:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/pulls/363","html_url":"https://github.com/duckduckgo/zeroclickinfo-fathead/pull/363","diff_url":"https://github.com/duckduckgo/zeroclickinfo-fathead/pull/363.diff","patch_url":"https://github.com/duckduckgo/zeroclickinfo-fathead/pull/363.patch"},"body":"Attempted to add fetching of URLs for the -webkit and -moz extensions in fetch.pl. For #293 \r\nPlease review :)\r\n\r\n###### People to notify \r\n\r\n@moollaza @hchienjo \r\n\r\nIA Page: https://duck.co/ia/view/mdn_css\r\n\r\nMaintainer: @hchienjo "},"comment":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/issues/comments/247038419","html_url":"https://github.com/duckduckgo/zeroclickinfo-fathead/pull/363#issuecomment-247038419","issue_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-fathead/issues/363","id":247038419,"user":{"login":"rasikapohankar","id":8025692,"avatar_url":"https://avatars.githubusercontent.com/u/8025692?v=3","gravatar_id":"","url":"https://api.github.com/users/rasikapohankar","html_url":"https://github.com/rasikapohankar","followers_url":"https://api.github.com/users/rasikapohankar/followers","following_url":"https://api.github.com/users/rasikapohankar/following{/other_user}","gists_url":"https://api.github.com/users/rasikapohankar/gists{/gist_id}","starred_url":"https://api.github.com/users/rasikapohankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasikapohankar/subscriptions","organizations_url":"https://api.github.com/users/rasikapohankar/orgs","repos_url":"https://api.github.com/users/rasikapohankar/repos","events_url":"https://api.github.com/users/rasikapohankar/events{/privacy}","received_events_url":"https://api.github.com/users/rasikapohankar/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T14:50:00Z","updated_at":"2016-09-14T14:50:00Z","body":"Hi @hchienjo! Yes I did refactor some of the code, I put the part of the code that fetched into a subroutine called `fetch()` and called it for each of the URLs from the loop [here](https://github.com/rasikapohankar/zeroclickinfo-fathead/blob/6ca3f84fcee1183cd7629c506bae47508c85ecd3/lib/fathead/mdn_css/fetch.pl#L48) and the downloading part into `download()`, but I didn't change any of the earlier code.\r\n\r\nExcept I added [this](https://github.com/duckduckgo/zeroclickinfo-fathead/pull/363/files#diff-ca443e93fd9afead3b245f141e784161R82) because the Mozilla extensions page had a similar `li` structure without hyperlinks.\r\nI have also called `download()` for each of the URLs, but after looking at the code in your PR I realised it can be called only once!\r\n\r\nYes, I'd like some help. What should I do with this PR? Also is it a convention to not use subroutines in scripts?"}}
{"actor":{"display_login":"rasikapohankar"}}