{"action":"created","issue":{"url":"https://api.github.com/repos/spazzarama/SharpDisasm/issues/3","repository_url":"https://api.github.com/repos/spazzarama/SharpDisasm","labels_url":"https://api.github.com/repos/spazzarama/SharpDisasm/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/spazzarama/SharpDisasm/issues/3/comments","events_url":"https://api.github.com/repos/spazzarama/SharpDisasm/issues/3/events","html_url":"https://github.com/spazzarama/SharpDisasm/pull/3","id":130207069,"number":3,"title":"Use abstract byte code interface to remove unsafe/pointer code ","user":{"login":"tgiphil","id":124747,"avatar_url":"https://avatars.githubusercontent.com/u/124747?v=3","gravatar_id":"","url":"https://api.github.com/users/tgiphil","html_url":"https://github.com/tgiphil","followers_url":"https://api.github.com/users/tgiphil/followers","following_url":"https://api.github.com/users/tgiphil/following{/other_user}","gists_url":"https://api.github.com/users/tgiphil/gists{/gist_id}","starred_url":"https://api.github.com/users/tgiphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgiphil/subscriptions","organizations_url":"https://api.github.com/users/tgiphil/orgs","repos_url":"https://api.github.com/users/tgiphil/repos","events_url":"https://api.github.com/users/tgiphil/events{/privacy}","received_events_url":"https://api.github.com/users/tgiphil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-01-31T22:56:34Z","updated_at":"2016-02-05T09:23:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spazzarama/SharpDisasm/pulls/3","html_url":"https://github.com/spazzarama/SharpDisasm/pull/3","diff_url":"https://github.com/spazzarama/SharpDisasm/pull/3.diff","patch_url":"https://github.com/spazzarama/SharpDisasm/pull/3.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/spazzarama/SharpDisasm/issues/comments/180264312","html_url":"https://github.com/spazzarama/SharpDisasm/pull/3#issuecomment-180264312","issue_url":"https://api.github.com/repos/spazzarama/SharpDisasm/issues/3","id":180264312,"user":{"login":"spazzarama","id":933730,"avatar_url":"https://avatars.githubusercontent.com/u/933730?v=3","gravatar_id":"","url":"https://api.github.com/users/spazzarama","html_url":"https://github.com/spazzarama","followers_url":"https://api.github.com/users/spazzarama/followers","following_url":"https://api.github.com/users/spazzarama/following{/other_user}","gists_url":"https://api.github.com/users/spazzarama/gists{/gist_id}","starred_url":"https://api.github.com/users/spazzarama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spazzarama/subscriptions","organizations_url":"https://api.github.com/users/spazzarama/orgs","repos_url":"https://api.github.com/users/spazzarama/repos","events_url":"https://api.github.com/users/spazzarama/events{/privacy}","received_events_url":"https://api.github.com/users/spazzarama/received_events","type":"User","site_admin":false},"created_at":"2016-02-05T09:23:57Z","updated_at":"2016-02-05T09:23:57Z","body":"Thanks for the effort you have put in Phil. Performance tests appear to match up pretty good.\r\n\r\nCouple of changes needed before I can complete the pull request if that is ok:\r\n\r\n 1. can you please add an IndexOutOfRange check to the AssemblyCodeMemory this[]\r\n 2. Can you please use the Tabs as 4 spaces setting in your IDE and resave those files\r\n 3. Please change the filename comment at start of your new files to have correct filename\r\n 4. Question: is there are reason you are not exposing the IAssemblyCode implementations as public? If there is no particular reason they might as well be exposed as public to ease use if anyone makes use of the classes outside of the disassembler.\r\n\r\nThanks again"}}