{"action":"closed","number":5377,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5377","id":65194112,"html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5377","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/5377.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/5377.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5377","number":5377,"state":"closed","locked":false,"title":"Update notification defaults to \"instantly\" on node creation [OSF-4685]","user":{"login":"erinspace","id":801594,"avatar_url":"https://avatars.githubusercontent.com/u/801594?v=3","gravatar_id":"","url":"https://api.github.com/users/erinspace","html_url":"https://github.com/erinspace","followers_url":"https://api.github.com/users/erinspace/followers","following_url":"https://api.github.com/users/erinspace/following{/other_user}","gists_url":"https://api.github.com/users/erinspace/gists{/gist_id}","starred_url":"https://api.github.com/users/erinspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinspace/subscriptions","organizations_url":"https://api.github.com/users/erinspace/orgs","repos_url":"https://api.github.com/users/erinspace/repos","events_url":"https://api.github.com/users/erinspace/events{/privacy}","received_events_url":"https://api.github.com/users/erinspace/received_events","type":"User","site_admin":false},"body":"*note*: this is a redo of #5117, I made a new PR because changes were pretty extensive \r\n\r\nhttps://openscience.atlassian.net/browse/OSF-4685\r\n\r\n# Purpose\r\nWhen a user creates a project, notification settings are automatically set to \"none,\" and a user might not know notifications even exist. This PR adds a method that automatically adds a node's creator to subscriptions for files and comments so they know the option exists.  It also will automatically subscribe any contributor added to the project.\r\n\r\n# Changes\r\n- Add method that subscribes a user to notifications\r\n- Call that method with signals when a node is first saved with the nodes' creator\r\n- Also call that method when a contributor is added with that contributor\r\n- Add a setting that decides if a notification subscription should be automatically created (by default yes)\r\n- Adjust that setting to False in a special case for NotificationSubscrtiption realted tests that don't create the subscriptions by default\r\n- Disable automatic subscriptions on tests that benefit from creating them manually\r\n- Alter text on contributor added, invite, forward invite, and public project emails to explain notifications and link to profile settings to update them\r\n\r\n# Side effects and Notes\r\n- Node settings for current projects are NOT touched\r\n","created_at":"2016-04-04T18:51:34Z","updated_at":"2016-04-12T18:41:21Z","closed_at":"2016-04-12T18:41:21Z","merged_at":null,"merge_commit_sha":"4f3bf306ac5081ce7330928693551815d0c1d2e0","assignee":null,"milestone":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/67","html_url":"https://github.com/CenterForOpenScience/osf.io/milestones/0.68.0","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/67/labels","id":1685281,"number":67,"title":"0.68.0","description":"","creator":{"login":"icereval","id":3111541,"avatar_url":"https://avatars.githubusercontent.com/u/3111541?v=3","gravatar_id":"","url":"https://api.github.com/users/icereval","html_url":"https://github.com/icereval","followers_url":"https://api.github.com/users/icereval/followers","following_url":"https://api.github.com/users/icereval/following{/other_user}","gists_url":"https://api.github.com/users/icereval/gists{/gist_id}","starred_url":"https://api.github.com/users/icereval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icereval/subscriptions","organizations_url":"https://api.github.com/users/icereval/orgs","repos_url":"https://api.github.com/users/icereval/repos","events_url":"https://api.github.com/users/icereval/events{/privacy}","received_events_url":"https://api.github.com/users/icereval/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":4,"state":"open","created_at":"2016-04-05T17:51:06Z","updated_at":"2016-04-12T18:41:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5377/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5377/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5377/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/67a5c0647f6255036b52bf5fc1f465669688c863","head":{"label":"erinspace:feature/change_notification_defaults","ref":"feature/change_notification_defaults","sha":"67a5c0647f6255036b52bf5fc1f465669688c863","user":{"login":"erinspace","id":801594,"avatar_url":"https://avatars.githubusercontent.com/u/801594?v=3","gravatar_id":"","url":"https://api.github.com/users/erinspace","html_url":"https://github.com/erinspace","followers_url":"https://api.github.com/users/erinspace/followers","following_url":"https://api.github.com/users/erinspace/following{/other_user}","gists_url":"https://api.github.com/users/erinspace/gists{/gist_id}","starred_url":"https://api.github.com/users/erinspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinspace/subscriptions","organizations_url":"https://api.github.com/users/erinspace/orgs","repos_url":"https://api.github.com/users/erinspace/repos","events_url":"https://api.github.com/users/erinspace/events{/privacy}","received_events_url":"https://api.github.com/users/erinspace/received_events","type":"User","site_admin":false},"repo":{"id":27143923,"name":"osf.io","full_name":"erinspace/osf.io","owner":{"login":"erinspace","id":801594,"avatar_url":"https://avatars.githubusercontent.com/u/801594?v=3","gravatar_id":"","url":"https://api.github.com/users/erinspace","html_url":"https://github.com/erinspace","followers_url":"https://api.github.com/users/erinspace/followers","following_url":"https://api.github.com/users/erinspace/following{/other_user}","gists_url":"https://api.github.com/users/erinspace/gists{/gist_id}","starred_url":"https://api.github.com/users/erinspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinspace/subscriptions","organizations_url":"https://api.github.com/users/erinspace/orgs","repos_url":"https://api.github.com/users/erinspace/repos","events_url":"https://api.github.com/users/erinspace/events{/privacy}","received_events_url":"https://api.github.com/users/erinspace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erinspace/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/erinspace/osf.io","forks_url":"https://api.github.com/repos/erinspace/osf.io/forks","keys_url":"https://api.github.com/repos/erinspace/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erinspace/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erinspace/osf.io/teams","hooks_url":"https://api.github.com/repos/erinspace/osf.io/hooks","issue_events_url":"https://api.github.com/repos/erinspace/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/erinspace/osf.io/events","assignees_url":"https://api.github.com/repos/erinspace/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/erinspace/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/erinspace/osf.io/tags","blobs_url":"https://api.github.com/repos/erinspace/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erinspace/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erinspace/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/erinspace/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erinspace/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/erinspace/osf.io/languages","stargazers_url":"https://api.github.com/repos/erinspace/osf.io/stargazers","contributors_url":"https://api.github.com/repos/erinspace/osf.io/contributors","subscribers_url":"https://api.github.com/repos/erinspace/osf.io/subscribers","subscription_url":"https://api.github.com/repos/erinspace/osf.io/subscription","commits_url":"https://api.github.com/repos/erinspace/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/erinspace/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/erinspace/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/erinspace/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/erinspace/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/erinspace/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erinspace/osf.io/merges","archive_url":"https://api.github.com/repos/erinspace/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erinspace/osf.io/downloads","issues_url":"https://api.github.com/repos/erinspace/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/erinspace/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/erinspace/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/erinspace/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erinspace/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/erinspace/osf.io/releases{/id}","deployments_url":"https://api.github.com/repos/erinspace/osf.io/deployments","created_at":"2014-11-25T20:10:31Z","updated_at":"2015-04-03T14:29:22Z","pushed_at":"2016-04-08T18:20:25Z","git_url":"git://github.com/erinspace/osf.io.git","ssh_url":"git@github.com:erinspace/osf.io.git","clone_url":"https://github.com/erinspace/osf.io.git","svn_url":"https://github.com/erinspace/osf.io","homepage":"http://osf.io","size":126966,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"8dd59ffad5b31e6021bd5f42c27a11e12562c3c1","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/deployments","created_at":"2013-05-21T15:53:37Z","updated_at":"2016-04-11T14:54:41Z","pushed_at":"2016-04-12T18:25:59Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"git@github.com:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"http://osf.io","size":272487,"stargazers_count":211,"watchers_count":211,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":213,"forks":162,"open_issues":213,"watchers":211,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5377"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/5377"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5377"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5377/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5377/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5377/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/67a5c0647f6255036b52bf5fc1f465669688c863"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":5,"commits":22,"additions":148,"deletions":100,"changed_files":9}}