{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/heron/pulls/comments/73072984","id":73072984,"diff_hunk":"@@ -71,10 +77,16 @@ message Config {\n message Component {\n   // The name of the component. Like Tail-FlatMap\n   required string name = 1;\n-  // Only one of the below two are set\n-  optional string java_class_name = 2;\n-  optional bytes java_object = 4;\n+  // Only one of the below two is set, whose meaning is determined\n+  // by the value of spec. For example, when spec is JAVA_CLASS_NAME,\n+  // `class_name` is set and contains Java's class name.\n+  // When spec is JAVA_SERIALIZED_OBJECT, `serialized_object` is set and\n+  // contains a serialized Java object.\n+  optional string class_name = 2;\n+  optional bytes serialized_object = 4;\n+\n   required Config config = 3;\n+  required ComponentObjectSpec spec = 5;","path":"heron/proto/topology.proto","position":29,"original_position":29,"commit_id":"66eef90008e3f475eb765ccb5e3a7741f32f1d26","original_commit_id":"66eef90008e3f475eb765ccb5e3a7741f32f1d26","user":{"login":"nlu90","id":16407807,"avatar_url":"https://avatars.githubusercontent.com/u/16407807?v=3","gravatar_id":"","url":"https://api.github.com/users/nlu90","html_url":"https://github.com/nlu90","followers_url":"https://api.github.com/users/nlu90/followers","following_url":"https://api.github.com/users/nlu90/following{/other_user}","gists_url":"https://api.github.com/users/nlu90/gists{/gist_id}","starred_url":"https://api.github.com/users/nlu90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlu90/subscriptions","organizations_url":"https://api.github.com/users/nlu90/orgs","repos_url":"https://api.github.com/users/nlu90/repos","events_url":"https://api.github.com/users/nlu90/events{/privacy}","received_events_url":"https://api.github.com/users/nlu90/received_events","type":"User","site_admin":false},"body":"@taishi8117 thanks for the fix.","created_at":"2016-08-01T23:42:11Z","updated_at":"2016-08-01T23:42:11Z","html_url":"https://github.com/twitter/heron/pull/1149#discussion_r73072984","pull_request_url":"https://api.github.com/repos/twitter/heron/pulls/1149","_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments/73072984"},"html":{"href":"https://github.com/twitter/heron/pull/1149#discussion_r73072984"},"pull_request":{"href":"https://api.github.com/repos/twitter/heron/pulls/1149"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/1149","id":78735339,"html_url":"https://github.com/twitter/heron/pull/1149","diff_url":"https://github.com/twitter/heron/pull/1149.diff","patch_url":"https://github.com/twitter/heron/pull/1149.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/1149","number":1149,"state":"closed","locked":false,"title":"Modified topology.proto to support for Python topology","user":{"login":"taishi8117","id":5788629,"avatar_url":"https://avatars.githubusercontent.com/u/5788629?v=3","gravatar_id":"","url":"https://api.github.com/users/taishi8117","html_url":"https://github.com/taishi8117","followers_url":"https://api.github.com/users/taishi8117/followers","following_url":"https://api.github.com/users/taishi8117/following{/other_user}","gists_url":"https://api.github.com/users/taishi8117/gists{/gist_id}","starred_url":"https://api.github.com/users/taishi8117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taishi8117/subscriptions","organizations_url":"https://api.github.com/users/taishi8117/orgs","repos_url":"https://api.github.com/users/taishi8117/repos","events_url":"https://api.github.com/users/taishi8117/events{/privacy}","received_events_url":"https://api.github.com/users/taishi8117/received_events","type":"User","site_admin":false},"body":"Modified topology.proto so a component object can be defined in java or python. \r\nIt is backward-compatible and easily extensible to add a support for another language.\r\n\r\nThis change is necessary for #1138 ","created_at":"2016-07-25T19:12:59Z","updated_at":"2016-08-01T23:42:11Z","closed_at":"2016-07-26T22:51:51Z","merged_at":"2016-07-26T22:51:51Z","merge_commit_sha":"9c3d559e278e1b2fb32ae00d7fe8919a3e4e6d3c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/heron/pulls/1149/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/1149/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/1149/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/66eef90008e3f475eb765ccb5e3a7741f32f1d26","head":{"label":"taishi8117:pytopo/protobuf","ref":"pytopo/protobuf","sha":"66eef90008e3f475eb765ccb5e3a7741f32f1d26","user":{"login":"taishi8117","id":5788629,"avatar_url":"https://avatars.githubusercontent.com/u/5788629?v=3","gravatar_id":"","url":"https://api.github.com/users/taishi8117","html_url":"https://github.com/taishi8117","followers_url":"https://api.github.com/users/taishi8117/followers","following_url":"https://api.github.com/users/taishi8117/following{/other_user}","gists_url":"https://api.github.com/users/taishi8117/gists{/gist_id}","starred_url":"https://api.github.com/users/taishi8117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taishi8117/subscriptions","organizations_url":"https://api.github.com/users/taishi8117/orgs","repos_url":"https://api.github.com/users/taishi8117/repos","events_url":"https://api.github.com/users/taishi8117/events{/privacy}","received_events_url":"https://api.github.com/users/taishi8117/received_events","type":"User","site_admin":false},"repo":{"id":60656849,"name":"heron","full_name":"taishi8117/heron","owner":{"login":"taishi8117","id":5788629,"avatar_url":"https://avatars.githubusercontent.com/u/5788629?v=3","gravatar_id":"","url":"https://api.github.com/users/taishi8117","html_url":"https://github.com/taishi8117","followers_url":"https://api.github.com/users/taishi8117/followers","following_url":"https://api.github.com/users/taishi8117/following{/other_user}","gists_url":"https://api.github.com/users/taishi8117/gists{/gist_id}","starred_url":"https://api.github.com/users/taishi8117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taishi8117/subscriptions","organizations_url":"https://api.github.com/users/taishi8117/orgs","repos_url":"https://api.github.com/users/taishi8117/repos","events_url":"https://api.github.com/users/taishi8117/events{/privacy}","received_events_url":"https://api.github.com/users/taishi8117/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taishi8117/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/taishi8117/heron","forks_url":"https://api.github.com/repos/taishi8117/heron/forks","keys_url":"https://api.github.com/repos/taishi8117/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taishi8117/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taishi8117/heron/teams","hooks_url":"https://api.github.com/repos/taishi8117/heron/hooks","issue_events_url":"https://api.github.com/repos/taishi8117/heron/issues/events{/number}","events_url":"https://api.github.com/repos/taishi8117/heron/events","assignees_url":"https://api.github.com/repos/taishi8117/heron/assignees{/user}","branches_url":"https://api.github.com/repos/taishi8117/heron/branches{/branch}","tags_url":"https://api.github.com/repos/taishi8117/heron/tags","blobs_url":"https://api.github.com/repos/taishi8117/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taishi8117/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taishi8117/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/taishi8117/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taishi8117/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/taishi8117/heron/languages","stargazers_url":"https://api.github.com/repos/taishi8117/heron/stargazers","contributors_url":"https://api.github.com/repos/taishi8117/heron/contributors","subscribers_url":"https://api.github.com/repos/taishi8117/heron/subscribers","subscription_url":"https://api.github.com/repos/taishi8117/heron/subscription","commits_url":"https://api.github.com/repos/taishi8117/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/taishi8117/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/taishi8117/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/taishi8117/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/taishi8117/heron/contents/{+path}","compare_url":"https://api.github.com/repos/taishi8117/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taishi8117/heron/merges","archive_url":"https://api.github.com/repos/taishi8117/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taishi8117/heron/downloads","issues_url":"https://api.github.com/repos/taishi8117/heron/issues{/number}","pulls_url":"https://api.github.com/repos/taishi8117/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/taishi8117/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/taishi8117/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taishi8117/heron/labels{/name}","releases_url":"https://api.github.com/repos/taishi8117/heron/releases{/id}","deployments_url":"https://api.github.com/repos/taishi8117/heron/deployments","created_at":"2016-06-08T00:47:56Z","updated_at":"2016-06-08T00:47:59Z","pushed_at":"2016-08-01T23:36:57Z","git_url":"git://github.com/taishi8117/heron.git","ssh_url":"git@github.com:taishi8117/heron.git","clone_url":"https://github.com/taishi8117/heron.git","svn_url":"https://github.com/taishi8117/heron","homepage":"http://heronstreaming.io","size":111863,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"18e0c06e109f28e10ab9b54b52c6c907d6f13876","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2016-08-01T22:09:42Z","pushed_at":"2016-08-01T23:18:24Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"git@github.com:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":137064,"stargazers_count":2206,"watchers_count":2206,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":342,"mirror_url":null,"open_issues_count":164,"forks":342,"open_issues":164,"watchers":2206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/1149"},"html":{"href":"https://github.com/twitter/heron/pull/1149"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/1149"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/1149/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/1149/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/1149/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/66eef90008e3f475eb765ccb5e3a7741f32f1d26"}}}}
{"actor":{"display_login":"nlu90"}}