{"action":"opened","number":7893,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7893","id":78997556,"html_url":"https://github.com/nodejs/node/pull/7893","diff_url":"https://github.com/nodejs/node/pull/7893.diff","patch_url":"https://github.com/nodejs/node/pull/7893.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/7893","number":7893,"state":"open","locked":false,"title":"build: adding a clean-addons target to Makefile","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"body":"\r\n##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nbuild\r\n\r\n##### Description of change\r\n\r\n\r\nCurrently the build-addons target is called as part of the\r\ntest target, and it has test/addons/.buildstamp as a dependency.\r\nWhen running `./configure --debug` and later switching/\r\nupdating branches you can be in a situation where the config.gypi\r\nfiles in the addons build directories are using an incorrect\r\nvalue for default_configuration. Currently this can happen and you\r\nwill get test errors as there are a few test that depend on the\r\nvalue of default_configuration to be Release. When this happens\r\nit might not be obvious to someone new to the project (like me)\r\nto correct this state. This commit attempts to make it easier\r\nto fix this.\r\n\r\nThe suggestion here is if you find yourself in the above situation\r\nthe the following steps would be preformed:\r\n\r\n    1) make clean\r\n    2) ./configure\r\n    3) make -j4 test\r\n\r\nThe target distclean also calls clean-addons so that could be used\r\ninstead of clean in the above example. Also clean-addons could be\r\ncalled directly if required.\r\n\r\nThis commit is related to #7860. Please see the dicussion in that\r\nissue regarding the test using hard-coded paths.","created_at":"2016-07-27T10:05:35Z","updated_at":"2016-07-27T10:05:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/7893/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/7893/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7893/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/c038a6acd4752873ad71f3d7dec8e38acc1f75b9","head":{"label":"danbev:clean-test-addons","ref":"clean-test-addons","sha":"c038a6acd4752873ad71f3d7dec8e38acc1f75b9","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"repo":{"id":60841866,"name":"node","full_name":"danbev/node","owner":{"login":"danbev","id":432351,"avatar_url":"https://avatars.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danbev/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/danbev/node","forks_url":"https://api.github.com/repos/danbev/node/forks","keys_url":"https://api.github.com/repos/danbev/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danbev/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danbev/node/teams","hooks_url":"https://api.github.com/repos/danbev/node/hooks","issue_events_url":"https://api.github.com/repos/danbev/node/issues/events{/number}","events_url":"https://api.github.com/repos/danbev/node/events","assignees_url":"https://api.github.com/repos/danbev/node/assignees{/user}","branches_url":"https://api.github.com/repos/danbev/node/branches{/branch}","tags_url":"https://api.github.com/repos/danbev/node/tags","blobs_url":"https://api.github.com/repos/danbev/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danbev/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danbev/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/danbev/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danbev/node/statuses/{sha}","languages_url":"https://api.github.com/repos/danbev/node/languages","stargazers_url":"https://api.github.com/repos/danbev/node/stargazers","contributors_url":"https://api.github.com/repos/danbev/node/contributors","subscribers_url":"https://api.github.com/repos/danbev/node/subscribers","subscription_url":"https://api.github.com/repos/danbev/node/subscription","commits_url":"https://api.github.com/repos/danbev/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/danbev/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/danbev/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/danbev/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/danbev/node/contents/{+path}","compare_url":"https://api.github.com/repos/danbev/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danbev/node/merges","archive_url":"https://api.github.com/repos/danbev/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danbev/node/downloads","issues_url":"https://api.github.com/repos/danbev/node/issues{/number}","pulls_url":"https://api.github.com/repos/danbev/node/pulls{/number}","milestones_url":"https://api.github.com/repos/danbev/node/milestones{/number}","notifications_url":"https://api.github.com/repos/danbev/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danbev/node/labels{/name}","releases_url":"https://api.github.com/repos/danbev/node/releases{/id}","deployments_url":"https://api.github.com/repos/danbev/node/deployments","created_at":"2016-06-10T11:03:24Z","updated_at":"2016-06-10T11:03:40Z","pushed_at":"2016-07-27T10:02:00Z","git_url":"git://github.com/danbev/node.git","ssh_url":"git@github.com:danbev/node.git","clone_url":"https://github.com/danbev/node.git","svn_url":"https://github.com/danbev/node","homepage":"https://nodejs.org","size":228933,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"dee0e3a3336473973eda3a8e0e334e96f587572a","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-07-27T09:29:23Z","pushed_at":"2016-07-27T10:05:35Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":302037,"stargazers_count":25185,"watchers_count":25185,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3820,"mirror_url":null,"open_issues_count":759,"forks":3820,"open_issues":759,"watchers":25185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/7893"},"html":{"href":"https://github.com/nodejs/node/pull/7893"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/7893"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/7893/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/7893/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/7893/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/c038a6acd4752873ad71f3d7dec8e38acc1f75b9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"danbev"}}