{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/85067747","pull_request_review_id":5803404,"id":85067747,"diff_hunk":"@@ -548,6 +548,77 @@ extern char *convert_time(char *);\n extern struct batch_status *bs_isort(struct batch_status *bs,\n \tint (*cmp_func)(struct batch_status*, struct batch_status *));\n \n+extern int __pbs_asyrunjob(int, char *, char *, char *);","path":"src/include/pbs_internal.h","position":4,"original_position":4,"commit_id":"458ef304dadacef1cd1943350f02f0ba7a9a94d9","original_commit_id":"458ef304dadacef1cd1943350f02f0ba7a9a94d9","user":{"login":"agrawalravi90","id":4574875,"avatar_url":"https://avatars.githubusercontent.com/u/4574875?v=3","gravatar_id":"","url":"https://api.github.com/users/agrawalravi90","html_url":"https://github.com/agrawalravi90","followers_url":"https://api.github.com/users/agrawalravi90/followers","following_url":"https://api.github.com/users/agrawalravi90/following{/other_user}","gists_url":"https://api.github.com/users/agrawalravi90/gists{/gist_id}","starred_url":"https://api.github.com/users/agrawalravi90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrawalravi90/subscriptions","organizations_url":"https://api.github.com/users/agrawalravi90/orgs","repos_url":"https://api.github.com/users/agrawalravi90/repos","events_url":"https://api.github.com/users/agrawalravi90/events{/privacy}","received_events_url":"https://api.github.com/users/agrawalravi90/received_events","type":"User","site_admin":false},"body":"Instead of overloading pbs_internal.h, how about putting these declarations in a new header file, something like \"ifl_internal.h\" ? I think it will make things cleaner, but it's up to you. ","created_at":"2016-10-26T08:01:08Z","updated_at":"2016-10-26T08:33:15Z","html_url":"https://github.com/PBSPro/pbspro/pull/181#discussion_r85067747","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/85067747"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/181#discussion_r85067747"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/181","id":90158181,"html_url":"https://github.com/PBSPro/pbspro/pull/181","diff_url":"https://github.com/PBSPro/pbspro/pull/181.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/181.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/181","number":181,"state":"open","locked":false,"title":"PP-459: Code refactoring for pbs ifl interfaces","user":{"login":"vinodchitrali","id":17923322,"avatar_url":"https://avatars.githubusercontent.com/u/17923322?v=3","gravatar_id":"","url":"https://api.github.com/users/vinodchitrali","html_url":"https://github.com/vinodchitrali","followers_url":"https://api.github.com/users/vinodchitrali/followers","following_url":"https://api.github.com/users/vinodchitrali/following{/other_user}","gists_url":"https://api.github.com/users/vinodchitrali/gists{/gist_id}","starred_url":"https://api.github.com/users/vinodchitrali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinodchitrali/subscriptions","organizations_url":"https://api.github.com/users/vinodchitrali/orgs","repos_url":"https://api.github.com/users/vinodchitrali/repos","events_url":"https://api.github.com/users/vinodchitrali/events{/privacy}","received_events_url":"https://api.github.com/users/vinodchitrali/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Issue-ID\r\n<!--- Replace XXXX below (2 places) with the actual JIRA id -->\r\n* **[PP-459](https://pbspro.atlassian.net/browse/PP-459)**\r\n\r\n#### Problem description\r\n* As a developer one would like to override the existing IFL interfaces. In IFL library this is not possible\r\n\r\n#### Cause / Analysis\r\n* Wrapper function would resolve the issues  \r\n\r\n#### Solution description\r\n* IFL interface intern calls default wrapper functions,  With this developer can defined their own IFL interface behavior. Link the library with their own implementation \r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n- [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n- [x] I have added  **manual test(s) to the Jira ticket and explained why PTL is not appropriate** for this case.\r\n- [x] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to the Jira ticket** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n\r\n","created_at":"2016-10-20T08:56:06Z","updated_at":"2016-10-26T08:33:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f22bdfc19df2c7684cf8fb0f4128c80646a2c079","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/181/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/181/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/181/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/458ef304dadacef1cd1943350f02f0ba7a9a94d9","head":{"label":"vinodchitrali:pp-459","ref":"pp-459","sha":"458ef304dadacef1cd1943350f02f0ba7a9a94d9","user":{"login":"vinodchitrali","id":17923322,"avatar_url":"https://avatars.githubusercontent.com/u/17923322?v=3","gravatar_id":"","url":"https://api.github.com/users/vinodchitrali","html_url":"https://github.com/vinodchitrali","followers_url":"https://api.github.com/users/vinodchitrali/followers","following_url":"https://api.github.com/users/vinodchitrali/following{/other_user}","gists_url":"https://api.github.com/users/vinodchitrali/gists{/gist_id}","starred_url":"https://api.github.com/users/vinodchitrali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinodchitrali/subscriptions","organizations_url":"https://api.github.com/users/vinodchitrali/orgs","repos_url":"https://api.github.com/users/vinodchitrali/repos","events_url":"https://api.github.com/users/vinodchitrali/events{/privacy}","received_events_url":"https://api.github.com/users/vinodchitrali/received_events","type":"User","site_admin":false},"repo":{"id":62203700,"name":"pbspro","full_name":"vinodchitrali/pbspro","owner":{"login":"vinodchitrali","id":17923322,"avatar_url":"https://avatars.githubusercontent.com/u/17923322?v=3","gravatar_id":"","url":"https://api.github.com/users/vinodchitrali","html_url":"https://github.com/vinodchitrali","followers_url":"https://api.github.com/users/vinodchitrali/followers","following_url":"https://api.github.com/users/vinodchitrali/following{/other_user}","gists_url":"https://api.github.com/users/vinodchitrali/gists{/gist_id}","starred_url":"https://api.github.com/users/vinodchitrali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinodchitrali/subscriptions","organizations_url":"https://api.github.com/users/vinodchitrali/orgs","repos_url":"https://api.github.com/users/vinodchitrali/repos","events_url":"https://api.github.com/users/vinodchitrali/events{/privacy}","received_events_url":"https://api.github.com/users/vinodchitrali/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinodchitrali/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/vinodchitrali/pbspro","forks_url":"https://api.github.com/repos/vinodchitrali/pbspro/forks","keys_url":"https://api.github.com/repos/vinodchitrali/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinodchitrali/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinodchitrali/pbspro/teams","hooks_url":"https://api.github.com/repos/vinodchitrali/pbspro/hooks","issue_events_url":"https://api.github.com/repos/vinodchitrali/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/vinodchitrali/pbspro/events","assignees_url":"https://api.github.com/repos/vinodchitrali/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/vinodchitrali/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/vinodchitrali/pbspro/tags","blobs_url":"https://api.github.com/repos/vinodchitrali/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinodchitrali/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinodchitrali/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinodchitrali/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinodchitrali/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/vinodchitrali/pbspro/languages","stargazers_url":"https://api.github.com/repos/vinodchitrali/pbspro/stargazers","contributors_url":"https://api.github.com/repos/vinodchitrali/pbspro/contributors","subscribers_url":"https://api.github.com/repos/vinodchitrali/pbspro/subscribers","subscription_url":"https://api.github.com/repos/vinodchitrali/pbspro/subscription","commits_url":"https://api.github.com/repos/vinodchitrali/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinodchitrali/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinodchitrali/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinodchitrali/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinodchitrali/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/vinodchitrali/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinodchitrali/pbspro/merges","archive_url":"https://api.github.com/repos/vinodchitrali/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinodchitrali/pbspro/downloads","issues_url":"https://api.github.com/repos/vinodchitrali/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/vinodchitrali/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/vinodchitrali/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/vinodchitrali/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinodchitrali/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/vinodchitrali/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/vinodchitrali/pbspro/deployments","created_at":"2016-06-29T07:04:30Z","updated_at":"2016-06-29T07:04:35Z","pushed_at":"2016-10-26T06:54:13Z","git_url":"git://github.com/vinodchitrali/pbspro.git","ssh_url":"git@github.com:vinodchitrali/pbspro.git","clone_url":"https://github.com/vinodchitrali/pbspro.git","svn_url":"https://github.com/vinodchitrali/pbspro","homepage":"www.pbspro.org","size":5490,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"6733daa7c24ca65c2975908d930d43b18f21caec","user":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars.githubusercontent.com/u/19280436?v=3","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars.githubusercontent.com/u/19280436?v=3","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2016-10-26T01:54:57Z","pushed_at":"2016-10-26T06:54:14Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":6223,"stargazers_count":58,"watchers_count":58,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":6,"forks":61,"open_issues":6,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/181"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/181"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/181"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/458ef304dadacef1cd1943350f02f0ba7a9a94d9"}}}}
{"actor":{"display_login":"agrawalravi90"}}