{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/77343548","id":77343548,"diff_hunk":"@@ -50,6 +50,28 @@ object ExportVCF extends Command {\n     case _ => \"String\"\n   }\n \n+  def appendIntArrayOption(sb: StringBuilder, toAppend: Option[Array[Int]]): Unit = {\n+    if (toAppend.isDefined)\n+      toAppend.foreach(_.foreachBetween(sb.append(_))(sb += ','))\n+    else\n+      sb += '.'\n+  }\n+\n+  def appendIntOption(sb: StringBuilder, toAppend: Option[Int]): Unit = {\n+    if (toAppend.isDefined)\n+      sb.append(toAppend)","path":"src/main/scala/org/broadinstitute/hail/driver/ExportVCF.scala","position":13,"original_position":13,"commit_id":"d9f2983e784e4ee2e0e5a3f43e6d52c06586e010","original_commit_id":"d9f2983e784e4ee2e0e5a3f43e6d52c06586e010","user":{"login":"cseed","id":1244990,"avatar_url":"https://avatars.githubusercontent.com/u/1244990?v=3","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"body":"This is appending the `Option`, not its contents.  This was causing some tests to fail.  You want `toAppend.get`, but better is pattern matching:\r\n\r\n```\r\n  toAppend match {\r\n    case Some(i) => sb.append(i)\r\n    case None => sb += '.'\r\n  }\r\n```\r\n\r\nSame for `appendIntArrayOption `.  Otherwise, looks great!\r\n","created_at":"2016-09-02T13:14:17Z","updated_at":"2016-09-02T13:14:17Z","html_url":"https://github.com/hail-is/hail/pull/654#discussion_r77343548","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/654","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/77343548"},"html":{"href":"https://github.com/hail-is/hail/pull/654#discussion_r77343548"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/654"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/654","id":82088827,"html_url":"https://github.com/hail-is/hail/pull/654","diff_url":"https://github.com/hail-is/hail/pull/654.diff","patch_url":"https://github.com/hail-is/hail/pull/654.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/654","number":654,"state":"open","locked":false,"title":"fixes #631: Don't call Genotype.toString in ExportVCF","user":{"login":"zamoshchin","id":3536827,"avatar_url":"https://avatars.githubusercontent.com/u/3536827?v=3","gravatar_id":"","url":"https://api.github.com/users/zamoshchin","html_url":"https://github.com/zamoshchin","followers_url":"https://api.github.com/users/zamoshchin/followers","following_url":"https://api.github.com/users/zamoshchin/following{/other_user}","gists_url":"https://api.github.com/users/zamoshchin/gists{/gist_id}","starred_url":"https://api.github.com/users/zamoshchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamoshchin/subscriptions","organizations_url":"https://api.github.com/users/zamoshchin/orgs","repos_url":"https://api.github.com/users/zamoshchin/repos","events_url":"https://api.github.com/users/zamoshchin/events{/privacy}","received_events_url":"https://api.github.com/users/zamoshchin/received_events","type":"User","site_admin":false},"body":"Genotype `toString()` is of the format `0/1*:10,10,0:22:99:PL=100,0,100` where * indicates fakeRef","created_at":"2016-08-20T20:31:57Z","updated_at":"2016-09-02T13:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7168c7b22836acd79774856508723e5a52e644c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/654/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/654/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/654/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/d9f2983e784e4ee2e0e5a3f43e6d52c06586e010","head":{"label":"zamoshchin:genotype_tostring","ref":"genotype_tostring","sha":"d9f2983e784e4ee2e0e5a3f43e6d52c06586e010","user":{"login":"zamoshchin","id":3536827,"avatar_url":"https://avatars.githubusercontent.com/u/3536827?v=3","gravatar_id":"","url":"https://api.github.com/users/zamoshchin","html_url":"https://github.com/zamoshchin","followers_url":"https://api.github.com/users/zamoshchin/followers","following_url":"https://api.github.com/users/zamoshchin/following{/other_user}","gists_url":"https://api.github.com/users/zamoshchin/gists{/gist_id}","starred_url":"https://api.github.com/users/zamoshchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamoshchin/subscriptions","organizations_url":"https://api.github.com/users/zamoshchin/orgs","repos_url":"https://api.github.com/users/zamoshchin/repos","events_url":"https://api.github.com/users/zamoshchin/events{/privacy}","received_events_url":"https://api.github.com/users/zamoshchin/received_events","type":"User","site_admin":false},"repo":{"id":65982827,"name":"hail","full_name":"zamoshchin/hail","owner":{"login":"zamoshchin","id":3536827,"avatar_url":"https://avatars.githubusercontent.com/u/3536827?v=3","gravatar_id":"","url":"https://api.github.com/users/zamoshchin","html_url":"https://github.com/zamoshchin","followers_url":"https://api.github.com/users/zamoshchin/followers","following_url":"https://api.github.com/users/zamoshchin/following{/other_user}","gists_url":"https://api.github.com/users/zamoshchin/gists{/gist_id}","starred_url":"https://api.github.com/users/zamoshchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamoshchin/subscriptions","organizations_url":"https://api.github.com/users/zamoshchin/orgs","repos_url":"https://api.github.com/users/zamoshchin/repos","events_url":"https://api.github.com/users/zamoshchin/events{/privacy}","received_events_url":"https://api.github.com/users/zamoshchin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zamoshchin/hail","description":"scalable genetic data analysis https://hail.is","fork":true,"url":"https://api.github.com/repos/zamoshchin/hail","forks_url":"https://api.github.com/repos/zamoshchin/hail/forks","keys_url":"https://api.github.com/repos/zamoshchin/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zamoshchin/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zamoshchin/hail/teams","hooks_url":"https://api.github.com/repos/zamoshchin/hail/hooks","issue_events_url":"https://api.github.com/repos/zamoshchin/hail/issues/events{/number}","events_url":"https://api.github.com/repos/zamoshchin/hail/events","assignees_url":"https://api.github.com/repos/zamoshchin/hail/assignees{/user}","branches_url":"https://api.github.com/repos/zamoshchin/hail/branches{/branch}","tags_url":"https://api.github.com/repos/zamoshchin/hail/tags","blobs_url":"https://api.github.com/repos/zamoshchin/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zamoshchin/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zamoshchin/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/zamoshchin/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zamoshchin/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/zamoshchin/hail/languages","stargazers_url":"https://api.github.com/repos/zamoshchin/hail/stargazers","contributors_url":"https://api.github.com/repos/zamoshchin/hail/contributors","subscribers_url":"https://api.github.com/repos/zamoshchin/hail/subscribers","subscription_url":"https://api.github.com/repos/zamoshchin/hail/subscription","commits_url":"https://api.github.com/repos/zamoshchin/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/zamoshchin/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/zamoshchin/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/zamoshchin/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/zamoshchin/hail/contents/{+path}","compare_url":"https://api.github.com/repos/zamoshchin/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zamoshchin/hail/merges","archive_url":"https://api.github.com/repos/zamoshchin/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zamoshchin/hail/downloads","issues_url":"https://api.github.com/repos/zamoshchin/hail/issues{/number}","pulls_url":"https://api.github.com/repos/zamoshchin/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/zamoshchin/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/zamoshchin/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zamoshchin/hail/labels{/name}","releases_url":"https://api.github.com/repos/zamoshchin/hail/releases{/id}","deployments_url":"https://api.github.com/repos/zamoshchin/hail/deployments","created_at":"2016-08-18T09:12:24Z","updated_at":"2016-08-18T09:12:25Z","pushed_at":"2016-09-02T05:42:50Z","git_url":"git://github.com/zamoshchin/hail.git","ssh_url":"git@github.com:zamoshchin/hail.git","clone_url":"https://github.com/zamoshchin/hail.git","svn_url":"https://github.com/zamoshchin/hail","homepage":"","size":5781,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"a5cfbdf6efce4880afa119bdc231ca5f66992d9b","user":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genetic data analysis","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2016-08-29T18:23:01Z","pushed_at":"2016-09-02T13:10:08Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":6860,"stargazers_count":47,"watchers_count":47,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":196,"forks":20,"open_issues":196,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/654"},"html":{"href":"https://github.com/hail-is/hail/pull/654"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/654"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/654/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/654/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/654/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/d9f2983e784e4ee2e0e5a3f43e6d52c06586e010"}}}}
{"actor":{"display_login":"cseed"}}