{"action":"created","comment":{"url":"https://api.github.com/repos/goodeggs/geomoment/pulls/comments/86053676","pull_request_review_id":6731756,"id":86053676,"diff_hunk":"@@ -28,7 +29,7 @@\n   },\n   \"devDependencies\": {\n     \"moment\": \"2.14.1\",","path":"package.json","position":13,"original_position":13,"commit_id":"2bc25f823131acf6538d2000ab38b6b78626c564","original_commit_id":"2bc25f823131acf6538d2000ab38b6b78626c564","user":{"login":"brycefisher","id":220106,"avatar_url":"https://avatars.githubusercontent.com/u/220106?v=3","gravatar_id":"","url":"https://api.github.com/users/brycefisher","html_url":"https://github.com/brycefisher","followers_url":"https://api.github.com/users/brycefisher/followers","following_url":"https://api.github.com/users/brycefisher/following{/other_user}","gists_url":"https://api.github.com/users/brycefisher/gists{/gist_id}","starred_url":"https://api.github.com/users/brycefisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brycefisher/subscriptions","organizations_url":"https://api.github.com/users/brycefisher/orgs","repos_url":"https://api.github.com/users/brycefisher/repos","events_url":"https://api.github.com/users/brycefisher/events{/privacy}","received_events_url":"https://api.github.com/users/brycefisher/received_events","type":"User","site_admin":false},"body":"@asalant - do you remember why this won't work with `moment` > 2.9.0?","created_at":"2016-11-02T00:25:22Z","updated_at":"2016-11-02T00:25:22Z","html_url":"https://github.com/goodeggs/geomoment/pull/9#discussion_r86053676","pull_request_url":"https://api.github.com/repos/goodeggs/geomoment/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/goodeggs/geomoment/pulls/comments/86053676"},"html":{"href":"https://github.com/goodeggs/geomoment/pull/9#discussion_r86053676"},"pull_request":{"href":"https://api.github.com/repos/goodeggs/geomoment/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/goodeggs/geomoment/pulls/9","id":91889441,"html_url":"https://github.com/goodeggs/geomoment/pull/9","diff_url":"https://github.com/goodeggs/geomoment/pull/9.diff","patch_url":"https://github.com/goodeggs/geomoment/pull/9.patch","issue_url":"https://api.github.com/repos/goodeggs/geomoment/issues/9","number":9,"state":"open","locked":false,"title":"Issame false negative bug","user":{"login":"brycefisher","id":220106,"avatar_url":"https://avatars.githubusercontent.com/u/220106?v=3","gravatar_id":"","url":"https://api.github.com/users/brycefisher","html_url":"https://github.com/brycefisher","followers_url":"https://api.github.com/users/brycefisher/followers","following_url":"https://api.github.com/users/brycefisher/following{/other_user}","gists_url":"https://api.github.com/users/brycefisher/gists{/gist_id}","starred_url":"https://api.github.com/users/brycefisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brycefisher/subscriptions","organizations_url":"https://api.github.com/users/brycefisher/orgs","repos_url":"https://api.github.com/users/brycefisher/repos","events_url":"https://api.github.com/users/brycefisher/events{/privacy}","received_events_url":"https://api.github.com/users/brycefisher/received_events","type":"User","site_admin":false},"body":"We ran into a bug in production such that:\r\n\r\n```js\r\nwww-localhost> moment(new Date('Sun Nov 06 2016 18:00:00 GMT+0000 (UTC)')).isSame('2016-11-06', 'day')\r\ntrue\r\nwww-localhost> geomoment.tz(new Date('Sun Nov 06 2016 18:00:00 GMT+0000 (UTC)'), geomoment.pacific.tzid).isSame('2016-11-06', 'day')\r\nfalse \r\n```\r\n\r\nThis branch will (hopefully) fix that problem. It also includes various updates and changes I've found helpful while working in this repo:\r\n\r\n * Workaround for npm install bug such that I can't install geomoment itself as is outside my application by upgrading the version `moment-timezone` to the latest\r\n * Stop autogenerating the README: instead only do this during prepublish and use a different file, FORMATS.md.\r\n\r\nIn particular, autogenerating the README during `npm test` was surprising.\r\n\r\ncc @serhalp @dannynelson @sylspren ","created_at":"2016-11-02T00:21:29Z","updated_at":"2016-11-02T00:25:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82e88781f2c53d3fcb0799ec63f354eedd3a01de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/goodeggs/geomoment/pulls/9/commits","review_comments_url":"https://api.github.com/repos/goodeggs/geomoment/pulls/9/comments","review_comment_url":"https://api.github.com/repos/goodeggs/geomoment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goodeggs/geomoment/issues/9/comments","statuses_url":"https://api.github.com/repos/goodeggs/geomoment/statuses/2bc25f823131acf6538d2000ab38b6b78626c564","head":{"label":"goodeggs:issame-false-negative-bug","ref":"issame-false-negative-bug","sha":"2bc25f823131acf6538d2000ab38b6b78626c564","user":{"login":"goodeggs","id":892928,"avatar_url":"https://avatars.githubusercontent.com/u/892928?v=3","gravatar_id":"","url":"https://api.github.com/users/goodeggs","html_url":"https://github.com/goodeggs","followers_url":"https://api.github.com/users/goodeggs/followers","following_url":"https://api.github.com/users/goodeggs/following{/other_user}","gists_url":"https://api.github.com/users/goodeggs/gists{/gist_id}","starred_url":"https://api.github.com/users/goodeggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodeggs/subscriptions","organizations_url":"https://api.github.com/users/goodeggs/orgs","repos_url":"https://api.github.com/users/goodeggs/repos","events_url":"https://api.github.com/users/goodeggs/events{/privacy}","received_events_url":"https://api.github.com/users/goodeggs/received_events","type":"Organization","site_admin":false},"repo":{"id":14940145,"name":"geomoment","full_name":"goodeggs/geomoment","owner":{"login":"goodeggs","id":892928,"avatar_url":"https://avatars.githubusercontent.com/u/892928?v=3","gravatar_id":"","url":"https://api.github.com/users/goodeggs","html_url":"https://github.com/goodeggs","followers_url":"https://api.github.com/users/goodeggs/followers","following_url":"https://api.github.com/users/goodeggs/following{/other_user}","gists_url":"https://api.github.com/users/goodeggs/gists{/gist_id}","starred_url":"https://api.github.com/users/goodeggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodeggs/subscriptions","organizations_url":"https://api.github.com/users/goodeggs/orgs","repos_url":"https://api.github.com/users/goodeggs/repos","events_url":"https://api.github.com/users/goodeggs/events{/privacy}","received_events_url":"https://api.github.com/users/goodeggs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/goodeggs/geomoment","description":"a thin, sugary wrapper over moment.js and moment-timezone","fork":false,"url":"https://api.github.com/repos/goodeggs/geomoment","forks_url":"https://api.github.com/repos/goodeggs/geomoment/forks","keys_url":"https://api.github.com/repos/goodeggs/geomoment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goodeggs/geomoment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goodeggs/geomoment/teams","hooks_url":"https://api.github.com/repos/goodeggs/geomoment/hooks","issue_events_url":"https://api.github.com/repos/goodeggs/geomoment/issues/events{/number}","events_url":"https://api.github.com/repos/goodeggs/geomoment/events","assignees_url":"https://api.github.com/repos/goodeggs/geomoment/assignees{/user}","branches_url":"https://api.github.com/repos/goodeggs/geomoment/branches{/branch}","tags_url":"https://api.github.com/repos/goodeggs/geomoment/tags","blobs_url":"https://api.github.com/repos/goodeggs/geomoment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goodeggs/geomoment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goodeggs/geomoment/git/refs{/sha}","trees_url":"https://api.github.com/repos/goodeggs/geomoment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goodeggs/geomoment/statuses/{sha}","languages_url":"https://api.github.com/repos/goodeggs/geomoment/languages","stargazers_url":"https://api.github.com/repos/goodeggs/geomoment/stargazers","contributors_url":"https://api.github.com/repos/goodeggs/geomoment/contributors","subscribers_url":"https://api.github.com/repos/goodeggs/geomoment/subscribers","subscription_url":"https://api.github.com/repos/goodeggs/geomoment/subscription","commits_url":"https://api.github.com/repos/goodeggs/geomoment/commits{/sha}","git_commits_url":"https://api.github.com/repos/goodeggs/geomoment/git/commits{/sha}","comments_url":"https://api.github.com/repos/goodeggs/geomoment/comments{/number}","issue_comment_url":"https://api.github.com/repos/goodeggs/geomoment/issues/comments{/number}","contents_url":"https://api.github.com/repos/goodeggs/geomoment/contents/{+path}","compare_url":"https://api.github.com/repos/goodeggs/geomoment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goodeggs/geomoment/merges","archive_url":"https://api.github.com/repos/goodeggs/geomoment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goodeggs/geomoment/downloads","issues_url":"https://api.github.com/repos/goodeggs/geomoment/issues{/number}","pulls_url":"https://api.github.com/repos/goodeggs/geomoment/pulls{/number}","milestones_url":"https://api.github.com/repos/goodeggs/geomoment/milestones{/number}","notifications_url":"https://api.github.com/repos/goodeggs/geomoment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goodeggs/geomoment/labels{/name}","releases_url":"https://api.github.com/repos/goodeggs/geomoment/releases{/id}","deployments_url":"https://api.github.com/repos/goodeggs/geomoment/deployments","created_at":"2013-12-05T00:44:50Z","updated_at":"2016-11-01T19:47:01Z","pushed_at":"2016-11-02T00:23:59Z","git_url":"git://github.com/goodeggs/geomoment.git","ssh_url":"git@github.com:goodeggs/geomoment.git","clone_url":"https://github.com/goodeggs/geomoment.git","svn_url":"https://github.com/goodeggs/geomoment","homepage":"","size":2000,"stargazers_count":7,"watchers_count":7,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"goodeggs:master","ref":"master","sha":"907c3f5902c35ca1e8119f86f7ff49554b6abb4a","user":{"login":"goodeggs","id":892928,"avatar_url":"https://avatars.githubusercontent.com/u/892928?v=3","gravatar_id":"","url":"https://api.github.com/users/goodeggs","html_url":"https://github.com/goodeggs","followers_url":"https://api.github.com/users/goodeggs/followers","following_url":"https://api.github.com/users/goodeggs/following{/other_user}","gists_url":"https://api.github.com/users/goodeggs/gists{/gist_id}","starred_url":"https://api.github.com/users/goodeggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodeggs/subscriptions","organizations_url":"https://api.github.com/users/goodeggs/orgs","repos_url":"https://api.github.com/users/goodeggs/repos","events_url":"https://api.github.com/users/goodeggs/events{/privacy}","received_events_url":"https://api.github.com/users/goodeggs/received_events","type":"Organization","site_admin":false},"repo":{"id":14940145,"name":"geomoment","full_name":"goodeggs/geomoment","owner":{"login":"goodeggs","id":892928,"avatar_url":"https://avatars.githubusercontent.com/u/892928?v=3","gravatar_id":"","url":"https://api.github.com/users/goodeggs","html_url":"https://github.com/goodeggs","followers_url":"https://api.github.com/users/goodeggs/followers","following_url":"https://api.github.com/users/goodeggs/following{/other_user}","gists_url":"https://api.github.com/users/goodeggs/gists{/gist_id}","starred_url":"https://api.github.com/users/goodeggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodeggs/subscriptions","organizations_url":"https://api.github.com/users/goodeggs/orgs","repos_url":"https://api.github.com/users/goodeggs/repos","events_url":"https://api.github.com/users/goodeggs/events{/privacy}","received_events_url":"https://api.github.com/users/goodeggs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/goodeggs/geomoment","description":"a thin, sugary wrapper over moment.js and moment-timezone","fork":false,"url":"https://api.github.com/repos/goodeggs/geomoment","forks_url":"https://api.github.com/repos/goodeggs/geomoment/forks","keys_url":"https://api.github.com/repos/goodeggs/geomoment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goodeggs/geomoment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goodeggs/geomoment/teams","hooks_url":"https://api.github.com/repos/goodeggs/geomoment/hooks","issue_events_url":"https://api.github.com/repos/goodeggs/geomoment/issues/events{/number}","events_url":"https://api.github.com/repos/goodeggs/geomoment/events","assignees_url":"https://api.github.com/repos/goodeggs/geomoment/assignees{/user}","branches_url":"https://api.github.com/repos/goodeggs/geomoment/branches{/branch}","tags_url":"https://api.github.com/repos/goodeggs/geomoment/tags","blobs_url":"https://api.github.com/repos/goodeggs/geomoment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goodeggs/geomoment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goodeggs/geomoment/git/refs{/sha}","trees_url":"https://api.github.com/repos/goodeggs/geomoment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goodeggs/geomoment/statuses/{sha}","languages_url":"https://api.github.com/repos/goodeggs/geomoment/languages","stargazers_url":"https://api.github.com/repos/goodeggs/geomoment/stargazers","contributors_url":"https://api.github.com/repos/goodeggs/geomoment/contributors","subscribers_url":"https://api.github.com/repos/goodeggs/geomoment/subscribers","subscription_url":"https://api.github.com/repos/goodeggs/geomoment/subscription","commits_url":"https://api.github.com/repos/goodeggs/geomoment/commits{/sha}","git_commits_url":"https://api.github.com/repos/goodeggs/geomoment/git/commits{/sha}","comments_url":"https://api.github.com/repos/goodeggs/geomoment/comments{/number}","issue_comment_url":"https://api.github.com/repos/goodeggs/geomoment/issues/comments{/number}","contents_url":"https://api.github.com/repos/goodeggs/geomoment/contents/{+path}","compare_url":"https://api.github.com/repos/goodeggs/geomoment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goodeggs/geomoment/merges","archive_url":"https://api.github.com/repos/goodeggs/geomoment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goodeggs/geomoment/downloads","issues_url":"https://api.github.com/repos/goodeggs/geomoment/issues{/number}","pulls_url":"https://api.github.com/repos/goodeggs/geomoment/pulls{/number}","milestones_url":"https://api.github.com/repos/goodeggs/geomoment/milestones{/number}","notifications_url":"https://api.github.com/repos/goodeggs/geomoment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goodeggs/geomoment/labels{/name}","releases_url":"https://api.github.com/repos/goodeggs/geomoment/releases{/id}","deployments_url":"https://api.github.com/repos/goodeggs/geomoment/deployments","created_at":"2013-12-05T00:44:50Z","updated_at":"2016-11-01T19:47:01Z","pushed_at":"2016-11-02T00:23:59Z","git_url":"git://github.com/goodeggs/geomoment.git","ssh_url":"git@github.com:goodeggs/geomoment.git","clone_url":"https://github.com/goodeggs/geomoment.git","svn_url":"https://github.com/goodeggs/geomoment","homepage":"","size":2000,"stargazers_count":7,"watchers_count":7,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goodeggs/geomoment/pulls/9"},"html":{"href":"https://github.com/goodeggs/geomoment/pull/9"},"issue":{"href":"https://api.github.com/repos/goodeggs/geomoment/issues/9"},"comments":{"href":"https://api.github.com/repos/goodeggs/geomoment/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/goodeggs/geomoment/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/goodeggs/geomoment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goodeggs/geomoment/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/goodeggs/geomoment/statuses/2bc25f823131acf6538d2000ab38b6b78626c564"}}}}
{"actor":{"display_login":"brycefisher"}}