{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5376","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5376/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5376/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5376/events","html_url":"https://github.com/nodejs/node/pull/5376","id":135615531,"number":5376,"title":"test: allow passing args to executable","user":{"login":"stefanmb","id":1356314,"avatar_url":"https://avatars.githubusercontent.com/u/1356314?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanmb","html_url":"https://github.com/stefanmb","followers_url":"https://api.github.com/users/stefanmb/followers","following_url":"https://api.github.com/users/stefanmb/following{/other_user}","gists_url":"https://api.github.com/users/stefanmb/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmb/subscriptions","organizations_url":"https://api.github.com/users/stefanmb/orgs","repos_url":"https://api.github.com/users/stefanmb/repos","events_url":"https://api.github.com/users/stefanmb/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2016-02-23T03:05:03Z","updated_at":"2016-02-25T18:13:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5376","html_url":"https://github.com/nodejs/node/pull/5376","diff_url":"https://github.com/nodejs/node/pull/5376.diff","patch_url":"https://github.com/nodejs/node/pull/5376.patch"},"body":"To set up CI jobs for https://github.com/nodejs/node/pull/5181 there has to be a way to pass an argument to the Node executable at test time. The makefile supports the TEST_CI_ARGS environment variable, but the test harness (test.py) provides no facility to further pass the argument to the executable under test.\r\n\r\nThere is a \"--special-command\" argument, but it is only able to suffix or prefix the existing command line in the format [node, test] so it is insufficient to produce commands in the form [node, node_args, test]. In this PR I've introduced an extra argument to the test harness called --node-args which can be used to pass commands verbatim.\r\n\r\nSome support for this feature already existed in test/\\__init\\__.py in the form of the \"additional\" argument, however none of the individual test modules' testcfg.py make use of it, so in the interest of minimal footprint I've opted to directly set this value form test.py, instead of passing it through as a constructor argument.\r\n\r\nThere is an additional complication in \"test-cluster-debug-port.js\" which for reasons that are unclear refuses to run if any arguments are passed to the process. I've simply relaxed this requirement."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/188912080","html_url":"https://github.com/nodejs/node/pull/5376#issuecomment-188912080","issue_url":"https://api.github.com/repos/nodejs/node/issues/5376","id":188912080,"user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T18:13:18Z","updated_at":"2016-02-25T18:13:18Z","body":"Only one failure in CI which is unrelated to this change - reopened https://github.com/nodejs/node/issues/5184 and added link to failure"}}