{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/61985162","id":61985162,"diff_hunk":"@@ -159,6 +160,16 @@ public double getConfidence()\n         return groupingSets;\n     }\n \n+    @JsonProperty(\"groupingSetsIntersection\")","path":"presto-main/src/main/java/com/facebook/presto/sql/planner/plan/AggregationNode.java","position":12,"original_position":12,"commit_id":"d4745d4720ac1da2f074745b7b78e772ce7e2a72","original_commit_id":"d4745d4720ac1da2f074745b7b78e772ce7e2a72","user":{"login":"martint","id":14387,"avatar_url":"https://avatars.githubusercontent.com/u/14387?v=3","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"body":"Why does this need to be serializable?\r\n\r\nAlso, I might rename this to `getCommonGroupingColumns` ","created_at":"2016-05-04T02:39:07Z","updated_at":"2016-05-04T02:39:07Z","html_url":"https://github.com/prestodb/presto/pull/5187#discussion_r61985162","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/5187","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/61985162"},"html":{"href":"https://github.com/prestodb/presto/pull/5187#discussion_r61985162"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5187"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/5187","id":68800795,"html_url":"https://github.com/prestodb/presto/pull/5187","diff_url":"https://github.com/prestodb/presto/pull/5187.diff","patch_url":"https://github.com/prestodb/presto/pull/5187.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/5187","number":5187,"state":"open","locked":false,"title":"[WIP] Fix grouping set bug with predicate pushdown","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"body":"Predicates should not be pushed down through aggregation nodes unless\r\nthe predicate can be applied to the intersection of the grouping set\r\ncolumns.","created_at":"2016-05-04T01:36:54Z","updated_at":"2016-05-04T02:39:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c6ba8e99715b3502d870221ef69214ac9073669","assignee":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/5187/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/5187/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/5187/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/d4745d4720ac1da2f074745b7b78e772ce7e2a72","head":{"label":"raghavsethi:fix_gset","ref":"fix_gset","sha":"d4745d4720ac1da2f074745b7b78e772ce7e2a72","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"repo":{"id":42330619,"name":"presto","full_name":"raghavsethi/presto","owner":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raghavsethi/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/raghavsethi/presto","forks_url":"https://api.github.com/repos/raghavsethi/presto/forks","keys_url":"https://api.github.com/repos/raghavsethi/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raghavsethi/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raghavsethi/presto/teams","hooks_url":"https://api.github.com/repos/raghavsethi/presto/hooks","issue_events_url":"https://api.github.com/repos/raghavsethi/presto/issues/events{/number}","events_url":"https://api.github.com/repos/raghavsethi/presto/events","assignees_url":"https://api.github.com/repos/raghavsethi/presto/assignees{/user}","branches_url":"https://api.github.com/repos/raghavsethi/presto/branches{/branch}","tags_url":"https://api.github.com/repos/raghavsethi/presto/tags","blobs_url":"https://api.github.com/repos/raghavsethi/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raghavsethi/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raghavsethi/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/raghavsethi/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raghavsethi/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/raghavsethi/presto/languages","stargazers_url":"https://api.github.com/repos/raghavsethi/presto/stargazers","contributors_url":"https://api.github.com/repos/raghavsethi/presto/contributors","subscribers_url":"https://api.github.com/repos/raghavsethi/presto/subscribers","subscription_url":"https://api.github.com/repos/raghavsethi/presto/subscription","commits_url":"https://api.github.com/repos/raghavsethi/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/raghavsethi/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/raghavsethi/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/raghavsethi/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/raghavsethi/presto/contents/{+path}","compare_url":"https://api.github.com/repos/raghavsethi/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raghavsethi/presto/merges","archive_url":"https://api.github.com/repos/raghavsethi/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raghavsethi/presto/downloads","issues_url":"https://api.github.com/repos/raghavsethi/presto/issues{/number}","pulls_url":"https://api.github.com/repos/raghavsethi/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/raghavsethi/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/raghavsethi/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raghavsethi/presto/labels{/name}","releases_url":"https://api.github.com/repos/raghavsethi/presto/releases{/id}","deployments_url":"https://api.github.com/repos/raghavsethi/presto/deployments","created_at":"2015-09-11T20:28:31Z","updated_at":"2016-01-12T19:42:33Z","pushed_at":"2016-05-04T01:36:30Z","git_url":"git://github.com/raghavsethi/presto.git","ssh_url":"git@github.com:raghavsethi/presto.git","clone_url":"https://github.com/raghavsethi/presto.git","svn_url":"https://github.com/raghavsethi/presto","homepage":"https://prestodb.io","size":57588,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"f173afd2baaa81f094763c7c3944c69e4089d118","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2016-05-02T23:13:23Z","pushed_at":"2016-05-04T02:12:44Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":150190,"stargazers_count":4710,"watchers_count":4710,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1369,"mirror_url":null,"open_issues_count":545,"forks":1369,"open_issues":545,"watchers":4710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5187"},"html":{"href":"https://github.com/prestodb/presto/pull/5187"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/5187"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/5187/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5187/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5187/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/d4745d4720ac1da2f074745b7b78e772ce7e2a72"}}}}