{"action":"created","comment":{"url":"https://api.github.com/repos/armada-ths/armada-android/pulls/comments/82140671","pull_request_review_id":3067793,"id":82140671,"diff_hunk":"@@ -32,11 +32,16 @@ public void start() {\n \n     @Override\n     public void loadPartners() {\n+        view.startLoadingIndicator();\n         dataSource.getPartners().subscribe(this::onPartnersLoaded);\n     }\n \n     private void onPartnersLoaded(List<Partner> partners) {\n         view.setPartners(partners);\n+\n+        if (!partners.isEmpty()) {\n+            view.stopLoadingIndicator();\n+        }","path":"app/src/main/java/se/ths/kth/Aramda/components/armada/ArmadaPresenter.java","position":13,"original_position":13,"commit_id":"e0ac6720fa3b4977b6513248f4eceee42bb413b2","original_commit_id":"e0ac6720fa3b4977b6513248f4eceee42bb413b2","user":{"login":"Jeppes","id":6968065,"avatar_url":"https://avatars.githubusercontent.com/u/6968065?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeppes","html_url":"https://github.com/Jeppes","followers_url":"https://api.github.com/users/Jeppes/followers","following_url":"https://api.github.com/users/Jeppes/following{/other_user}","gists_url":"https://api.github.com/users/Jeppes/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeppes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeppes/subscriptions","organizations_url":"https://api.github.com/users/Jeppes/orgs","repos_url":"https://api.github.com/users/Jeppes/repos","events_url":"https://api.github.com/users/Jeppes/events{/privacy}","received_events_url":"https://api.github.com/users/Jeppes/received_events","type":"User","site_admin":false},"body":"There is no way of knowing in that case","created_at":"2016-10-06T08:37:32Z","updated_at":"2016-10-06T08:37:32Z","html_url":"https://github.com/armada-ths/armada-android/pull/43#discussion_r82140671","pull_request_url":"https://api.github.com/repos/armada-ths/armada-android/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/armada-ths/armada-android/pulls/comments/82140671"},"html":{"href":"https://github.com/armada-ths/armada-android/pull/43#discussion_r82140671"},"pull_request":{"href":"https://api.github.com/repos/armada-ths/armada-android/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/armada-ths/armada-android/pulls/43","id":88216663,"html_url":"https://github.com/armada-ths/armada-android/pull/43","diff_url":"https://github.com/armada-ths/armada-android/pull/43.diff","patch_url":"https://github.com/armada-ths/armada-android/pull/43.patch","issue_url":"https://api.github.com/repos/armada-ths/armada-android/issues/43","number":43,"state":"open","locked":false,"title":"loading indicators everywhere content is loading;","user":{"login":"Jeppes","id":6968065,"avatar_url":"https://avatars.githubusercontent.com/u/6968065?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeppes","html_url":"https://github.com/Jeppes","followers_url":"https://api.github.com/users/Jeppes/followers","following_url":"https://api.github.com/users/Jeppes/following{/other_user}","gists_url":"https://api.github.com/users/Jeppes/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeppes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeppes/subscriptions","organizations_url":"https://api.github.com/users/Jeppes/orgs","repos_url":"https://api.github.com/users/Jeppes/repos","events_url":"https://api.github.com/users/Jeppes/events{/privacy}","received_events_url":"https://api.github.com/users/Jeppes/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-06T08:18:04Z","updated_at":"2016-10-06T08:37:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b82afc2e7100c70dbb54fed79a6c941dbd9e7b76","assignee":{"login":"apals","id":2913152,"avatar_url":"https://avatars.githubusercontent.com/u/2913152?v=3","gravatar_id":"","url":"https://api.github.com/users/apals","html_url":"https://github.com/apals","followers_url":"https://api.github.com/users/apals/followers","following_url":"https://api.github.com/users/apals/following{/other_user}","gists_url":"https://api.github.com/users/apals/gists{/gist_id}","starred_url":"https://api.github.com/users/apals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apals/subscriptions","organizations_url":"https://api.github.com/users/apals/orgs","repos_url":"https://api.github.com/users/apals/repos","events_url":"https://api.github.com/users/apals/events{/privacy}","received_events_url":"https://api.github.com/users/apals/received_events","type":"User","site_admin":false},"assignees":[{"login":"apals","id":2913152,"avatar_url":"https://avatars.githubusercontent.com/u/2913152?v=3","gravatar_id":"","url":"https://api.github.com/users/apals","html_url":"https://github.com/apals","followers_url":"https://api.github.com/users/apals/followers","following_url":"https://api.github.com/users/apals/following{/other_user}","gists_url":"https://api.github.com/users/apals/gists{/gist_id}","starred_url":"https://api.github.com/users/apals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apals/subscriptions","organizations_url":"https://api.github.com/users/apals/orgs","repos_url":"https://api.github.com/users/apals/repos","events_url":"https://api.github.com/users/apals/events{/privacy}","received_events_url":"https://api.github.com/users/apals/received_events","type":"User","site_admin":false},{"login":"Jeppes","id":6968065,"avatar_url":"https://avatars.githubusercontent.com/u/6968065?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeppes","html_url":"https://github.com/Jeppes","followers_url":"https://api.github.com/users/Jeppes/followers","following_url":"https://api.github.com/users/Jeppes/following{/other_user}","gists_url":"https://api.github.com/users/Jeppes/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeppes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeppes/subscriptions","organizations_url":"https://api.github.com/users/Jeppes/orgs","repos_url":"https://api.github.com/users/Jeppes/repos","events_url":"https://api.github.com/users/Jeppes/events{/privacy}","received_events_url":"https://api.github.com/users/Jeppes/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/armada-ths/armada-android/pulls/43/commits","review_comments_url":"https://api.github.com/repos/armada-ths/armada-android/pulls/43/comments","review_comment_url":"https://api.github.com/repos/armada-ths/armada-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/armada-ths/armada-android/issues/43/comments","statuses_url":"https://api.github.com/repos/armada-ths/armada-android/statuses/e0ac6720fa3b4977b6513248f4eceee42bb413b2","head":{"label":"armada-ths:loading","ref":"loading","sha":"e0ac6720fa3b4977b6513248f4eceee42bb413b2","user":{"login":"armada-ths","id":6577346,"avatar_url":"https://avatars.githubusercontent.com/u/6577346?v=3","gravatar_id":"","url":"https://api.github.com/users/armada-ths","html_url":"https://github.com/armada-ths","followers_url":"https://api.github.com/users/armada-ths/followers","following_url":"https://api.github.com/users/armada-ths/following{/other_user}","gists_url":"https://api.github.com/users/armada-ths/gists{/gist_id}","starred_url":"https://api.github.com/users/armada-ths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armada-ths/subscriptions","organizations_url":"https://api.github.com/users/armada-ths/orgs","repos_url":"https://api.github.com/users/armada-ths/repos","events_url":"https://api.github.com/users/armada-ths/events{/privacy}","received_events_url":"https://api.github.com/users/armada-ths/received_events","type":"Organization","site_admin":false},"repo":{"id":59129983,"name":"armada-android","full_name":"armada-ths/armada-android","owner":{"login":"armada-ths","id":6577346,"avatar_url":"https://avatars.githubusercontent.com/u/6577346?v=3","gravatar_id":"","url":"https://api.github.com/users/armada-ths","html_url":"https://github.com/armada-ths","followers_url":"https://api.github.com/users/armada-ths/followers","following_url":"https://api.github.com/users/armada-ths/following{/other_user}","gists_url":"https://api.github.com/users/armada-ths/gists{/gist_id}","starred_url":"https://api.github.com/users/armada-ths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armada-ths/subscriptions","organizations_url":"https://api.github.com/users/armada-ths/orgs","repos_url":"https://api.github.com/users/armada-ths/repos","events_url":"https://api.github.com/users/armada-ths/events{/privacy}","received_events_url":"https://api.github.com/users/armada-ths/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/armada-ths/armada-android","description":"THS Armada 2016 Android Application","fork":false,"url":"https://api.github.com/repos/armada-ths/armada-android","forks_url":"https://api.github.com/repos/armada-ths/armada-android/forks","keys_url":"https://api.github.com/repos/armada-ths/armada-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armada-ths/armada-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armada-ths/armada-android/teams","hooks_url":"https://api.github.com/repos/armada-ths/armada-android/hooks","issue_events_url":"https://api.github.com/repos/armada-ths/armada-android/issues/events{/number}","events_url":"https://api.github.com/repos/armada-ths/armada-android/events","assignees_url":"https://api.github.com/repos/armada-ths/armada-android/assignees{/user}","branches_url":"https://api.github.com/repos/armada-ths/armada-android/branches{/branch}","tags_url":"https://api.github.com/repos/armada-ths/armada-android/tags","blobs_url":"https://api.github.com/repos/armada-ths/armada-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armada-ths/armada-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armada-ths/armada-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/armada-ths/armada-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armada-ths/armada-android/statuses/{sha}","languages_url":"https://api.github.com/repos/armada-ths/armada-android/languages","stargazers_url":"https://api.github.com/repos/armada-ths/armada-android/stargazers","contributors_url":"https://api.github.com/repos/armada-ths/armada-android/contributors","subscribers_url":"https://api.github.com/repos/armada-ths/armada-android/subscribers","subscription_url":"https://api.github.com/repos/armada-ths/armada-android/subscription","commits_url":"https://api.github.com/repos/armada-ths/armada-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/armada-ths/armada-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/armada-ths/armada-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/armada-ths/armada-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/armada-ths/armada-android/contents/{+path}","compare_url":"https://api.github.com/repos/armada-ths/armada-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armada-ths/armada-android/merges","archive_url":"https://api.github.com/repos/armada-ths/armada-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armada-ths/armada-android/downloads","issues_url":"https://api.github.com/repos/armada-ths/armada-android/issues{/number}","pulls_url":"https://api.github.com/repos/armada-ths/armada-android/pulls{/number}","milestones_url":"https://api.github.com/repos/armada-ths/armada-android/milestones{/number}","notifications_url":"https://api.github.com/repos/armada-ths/armada-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armada-ths/armada-android/labels{/name}","releases_url":"https://api.github.com/repos/armada-ths/armada-android/releases{/id}","deployments_url":"https://api.github.com/repos/armada-ths/armada-android/deployments","created_at":"2016-05-18T15:49:04Z","updated_at":"2016-08-17T20:57:44Z","pushed_at":"2016-10-06T08:36:22Z","git_url":"git://github.com/armada-ths/armada-android.git","ssh_url":"git@github.com:armada-ths/armada-android.git","clone_url":"https://github.com/armada-ths/armada-android.git","svn_url":"https://github.com/armada-ths/armada-android","homepage":"","size":539,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"development"}},"base":{"label":"armada-ths:development","ref":"development","sha":"99049b4f821a843c482c00bfdc09524d8e5d58fc","user":{"login":"armada-ths","id":6577346,"avatar_url":"https://avatars.githubusercontent.com/u/6577346?v=3","gravatar_id":"","url":"https://api.github.com/users/armada-ths","html_url":"https://github.com/armada-ths","followers_url":"https://api.github.com/users/armada-ths/followers","following_url":"https://api.github.com/users/armada-ths/following{/other_user}","gists_url":"https://api.github.com/users/armada-ths/gists{/gist_id}","starred_url":"https://api.github.com/users/armada-ths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armada-ths/subscriptions","organizations_url":"https://api.github.com/users/armada-ths/orgs","repos_url":"https://api.github.com/users/armada-ths/repos","events_url":"https://api.github.com/users/armada-ths/events{/privacy}","received_events_url":"https://api.github.com/users/armada-ths/received_events","type":"Organization","site_admin":false},"repo":{"id":59129983,"name":"armada-android","full_name":"armada-ths/armada-android","owner":{"login":"armada-ths","id":6577346,"avatar_url":"https://avatars.githubusercontent.com/u/6577346?v=3","gravatar_id":"","url":"https://api.github.com/users/armada-ths","html_url":"https://github.com/armada-ths","followers_url":"https://api.github.com/users/armada-ths/followers","following_url":"https://api.github.com/users/armada-ths/following{/other_user}","gists_url":"https://api.github.com/users/armada-ths/gists{/gist_id}","starred_url":"https://api.github.com/users/armada-ths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armada-ths/subscriptions","organizations_url":"https://api.github.com/users/armada-ths/orgs","repos_url":"https://api.github.com/users/armada-ths/repos","events_url":"https://api.github.com/users/armada-ths/events{/privacy}","received_events_url":"https://api.github.com/users/armada-ths/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/armada-ths/armada-android","description":"THS Armada 2016 Android Application","fork":false,"url":"https://api.github.com/repos/armada-ths/armada-android","forks_url":"https://api.github.com/repos/armada-ths/armada-android/forks","keys_url":"https://api.github.com/repos/armada-ths/armada-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armada-ths/armada-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armada-ths/armada-android/teams","hooks_url":"https://api.github.com/repos/armada-ths/armada-android/hooks","issue_events_url":"https://api.github.com/repos/armada-ths/armada-android/issues/events{/number}","events_url":"https://api.github.com/repos/armada-ths/armada-android/events","assignees_url":"https://api.github.com/repos/armada-ths/armada-android/assignees{/user}","branches_url":"https://api.github.com/repos/armada-ths/armada-android/branches{/branch}","tags_url":"https://api.github.com/repos/armada-ths/armada-android/tags","blobs_url":"https://api.github.com/repos/armada-ths/armada-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armada-ths/armada-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armada-ths/armada-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/armada-ths/armada-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armada-ths/armada-android/statuses/{sha}","languages_url":"https://api.github.com/repos/armada-ths/armada-android/languages","stargazers_url":"https://api.github.com/repos/armada-ths/armada-android/stargazers","contributors_url":"https://api.github.com/repos/armada-ths/armada-android/contributors","subscribers_url":"https://api.github.com/repos/armada-ths/armada-android/subscribers","subscription_url":"https://api.github.com/repos/armada-ths/armada-android/subscription","commits_url":"https://api.github.com/repos/armada-ths/armada-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/armada-ths/armada-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/armada-ths/armada-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/armada-ths/armada-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/armada-ths/armada-android/contents/{+path}","compare_url":"https://api.github.com/repos/armada-ths/armada-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armada-ths/armada-android/merges","archive_url":"https://api.github.com/repos/armada-ths/armada-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armada-ths/armada-android/downloads","issues_url":"https://api.github.com/repos/armada-ths/armada-android/issues{/number}","pulls_url":"https://api.github.com/repos/armada-ths/armada-android/pulls{/number}","milestones_url":"https://api.github.com/repos/armada-ths/armada-android/milestones{/number}","notifications_url":"https://api.github.com/repos/armada-ths/armada-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armada-ths/armada-android/labels{/name}","releases_url":"https://api.github.com/repos/armada-ths/armada-android/releases{/id}","deployments_url":"https://api.github.com/repos/armada-ths/armada-android/deployments","created_at":"2016-05-18T15:49:04Z","updated_at":"2016-08-17T20:57:44Z","pushed_at":"2016-10-06T08:36:22Z","git_url":"git://github.com/armada-ths/armada-android.git","ssh_url":"git@github.com:armada-ths/armada-android.git","clone_url":"https://github.com/armada-ths/armada-android.git","svn_url":"https://github.com/armada-ths/armada-android","homepage":"","size":539,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/armada-ths/armada-android/pulls/43"},"html":{"href":"https://github.com/armada-ths/armada-android/pull/43"},"issue":{"href":"https://api.github.com/repos/armada-ths/armada-android/issues/43"},"comments":{"href":"https://api.github.com/repos/armada-ths/armada-android/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/armada-ths/armada-android/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/armada-ths/armada-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/armada-ths/armada-android/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/armada-ths/armada-android/statuses/e0ac6720fa3b4977b6513248f4eceee42bb413b2"}}}}
{"actor":{"display_login":"Jeppes"}}