{"action":"opened","number":22,"pull_request":{"url":"https://api.github.com/repos/spotify/dockerfile-mode/pulls/22","id":56945432,"html_url":"https://github.com/spotify/dockerfile-mode/pull/22","diff_url":"https://github.com/spotify/dockerfile-mode/pull/22.diff","patch_url":"https://github.com/spotify/dockerfile-mode/pull/22.patch","issue_url":"https://api.github.com/repos/spotify/dockerfile-mode/issues/22","number":22,"state":"open","locked":false,"title":"Fix inability to build images on Windows.","user":{"login":"jaccarmac","id":3029245,"avatar_url":"https://avatars.githubusercontent.com/u/3029245?v=3","gravatar_id":"","url":"https://api.github.com/users/jaccarmac","html_url":"https://github.com/jaccarmac","followers_url":"https://api.github.com/users/jaccarmac/followers","following_url":"https://api.github.com/users/jaccarmac/following{/other_user}","gists_url":"https://api.github.com/users/jaccarmac/gists{/gist_id}","starred_url":"https://api.github.com/users/jaccarmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaccarmac/subscriptions","organizations_url":"https://api.github.com/users/jaccarmac/orgs","repos_url":"https://api.github.com/users/jaccarmac/repos","events_url":"https://api.github.com/users/jaccarmac/events{/privacy}","received_events_url":"https://api.github.com/users/jaccarmac/received_events","type":"User","site_admin":false},"body":"When `dockerfile-use-sudo` was set to `nil`, the shell command for\r\nbuilding an image would start with a space, which had no effect on a\r\nLinux system, but broke the ability to build on Windows. The error\r\nmessage (\"docker is not a docker command\") seemed to indicate that a\r\nspace in front of a command causes it to double in some way, but I am\r\nunable to duplicate a similar error in CMD, PowerShell, or Docker\r\nToolbox's Bash, with our without quotation marks around the command,\r\ni.e. \" docker\".\r\n\r\nNevertheless, moving the space from the beginning of the base string to\r\nthe end of the piece inserted when `dockerfile-use-sudo` is non-`nil`\r\nfixes the problem.\r\n\r\nThis fix does not address the problem of initializing the proper\r\nenvironment variables. Emacs needs to inherit the settings suggested by\r\n`docker-machine env` if the `docker` command is to work.","created_at":"2016-01-22T21:41:29Z","updated_at":"2016-01-22T21:41:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spotify/dockerfile-mode/pulls/22/commits","review_comments_url":"https://api.github.com/repos/spotify/dockerfile-mode/pulls/22/comments","review_comment_url":"https://api.github.com/repos/spotify/dockerfile-mode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/dockerfile-mode/issues/22/comments","statuses_url":"https://api.github.com/repos/spotify/dockerfile-mode/statuses/35d10860d97e5d6ef8cf91bca3d56d4ee7f78cde","head":{"label":"jaccarmac:fix-windows-build","ref":"fix-windows-build","sha":"35d10860d97e5d6ef8cf91bca3d56d4ee7f78cde","user":{"login":"jaccarmac","id":3029245,"avatar_url":"https://avatars.githubusercontent.com/u/3029245?v=3","gravatar_id":"","url":"https://api.github.com/users/jaccarmac","html_url":"https://github.com/jaccarmac","followers_url":"https://api.github.com/users/jaccarmac/followers","following_url":"https://api.github.com/users/jaccarmac/following{/other_user}","gists_url":"https://api.github.com/users/jaccarmac/gists{/gist_id}","starred_url":"https://api.github.com/users/jaccarmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaccarmac/subscriptions","organizations_url":"https://api.github.com/users/jaccarmac/orgs","repos_url":"https://api.github.com/users/jaccarmac/repos","events_url":"https://api.github.com/users/jaccarmac/events{/privacy}","received_events_url":"https://api.github.com/users/jaccarmac/received_events","type":"User","site_admin":false},"repo":{"id":50208744,"name":"dockerfile-mode","full_name":"jaccarmac/dockerfile-mode","owner":{"login":"jaccarmac","id":3029245,"avatar_url":"https://avatars.githubusercontent.com/u/3029245?v=3","gravatar_id":"","url":"https://api.github.com/users/jaccarmac","html_url":"https://github.com/jaccarmac","followers_url":"https://api.github.com/users/jaccarmac/followers","following_url":"https://api.github.com/users/jaccarmac/following{/other_user}","gists_url":"https://api.github.com/users/jaccarmac/gists{/gist_id}","starred_url":"https://api.github.com/users/jaccarmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaccarmac/subscriptions","organizations_url":"https://api.github.com/users/jaccarmac/orgs","repos_url":"https://api.github.com/users/jaccarmac/repos","events_url":"https://api.github.com/users/jaccarmac/events{/privacy}","received_events_url":"https://api.github.com/users/jaccarmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaccarmac/dockerfile-mode","description":"An emacs mode for handling Dockerfiles","fork":true,"url":"https://api.github.com/repos/jaccarmac/dockerfile-mode","forks_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/forks","keys_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/teams","hooks_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/hooks","issue_events_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/issues/events{/number}","events_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/events","assignees_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/assignees{/user}","branches_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/branches{/branch}","tags_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/tags","blobs_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/languages","stargazers_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/stargazers","contributors_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/contributors","subscribers_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/subscribers","subscription_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/subscription","commits_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/contents/{+path}","compare_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/merges","archive_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/downloads","issues_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/issues{/number}","pulls_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/labels{/name}","releases_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/releases{/id}","deployments_url":"https://api.github.com/repos/jaccarmac/dockerfile-mode/deployments","created_at":"2016-01-22T21:32:46Z","updated_at":"2016-01-22T21:32:47Z","pushed_at":"2016-01-22T21:40:48Z","git_url":"git://github.com/jaccarmac/dockerfile-mode.git","ssh_url":"git@github.com:jaccarmac/dockerfile-mode.git","clone_url":"https://github.com/jaccarmac/dockerfile-mode.git","svn_url":"https://github.com/jaccarmac/dockerfile-mode","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"6fcecb517dcea1db2443dbc2b12ccc1382d67ec9","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":11930304,"name":"dockerfile-mode","full_name":"spotify/dockerfile-mode","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/dockerfile-mode","description":"An emacs mode for handling Dockerfiles","fork":false,"url":"https://api.github.com/repos/spotify/dockerfile-mode","forks_url":"https://api.github.com/repos/spotify/dockerfile-mode/forks","keys_url":"https://api.github.com/repos/spotify/dockerfile-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/dockerfile-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/dockerfile-mode/teams","hooks_url":"https://api.github.com/repos/spotify/dockerfile-mode/hooks","issue_events_url":"https://api.github.com/repos/spotify/dockerfile-mode/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/dockerfile-mode/events","assignees_url":"https://api.github.com/repos/spotify/dockerfile-mode/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/dockerfile-mode/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/dockerfile-mode/tags","blobs_url":"https://api.github.com/repos/spotify/dockerfile-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/dockerfile-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/dockerfile-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/dockerfile-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/dockerfile-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/dockerfile-mode/languages","stargazers_url":"https://api.github.com/repos/spotify/dockerfile-mode/stargazers","contributors_url":"https://api.github.com/repos/spotify/dockerfile-mode/contributors","subscribers_url":"https://api.github.com/repos/spotify/dockerfile-mode/subscribers","subscription_url":"https://api.github.com/repos/spotify/dockerfile-mode/subscription","commits_url":"https://api.github.com/repos/spotify/dockerfile-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/dockerfile-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/dockerfile-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/dockerfile-mode/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/dockerfile-mode/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/dockerfile-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/dockerfile-mode/merges","archive_url":"https://api.github.com/repos/spotify/dockerfile-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/dockerfile-mode/downloads","issues_url":"https://api.github.com/repos/spotify/dockerfile-mode/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/dockerfile-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/dockerfile-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/dockerfile-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/dockerfile-mode/labels{/name}","releases_url":"https://api.github.com/repos/spotify/dockerfile-mode/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/dockerfile-mode/deployments","created_at":"2013-08-06T17:35:45Z","updated_at":"2016-01-22T07:45:37Z","pushed_at":"2016-01-19T14:51:44Z","git_url":"git://github.com/spotify/dockerfile-mode.git","ssh_url":"git@github.com:spotify/dockerfile-mode.git","clone_url":"https://github.com/spotify/dockerfile-mode.git","svn_url":"https://github.com/spotify/dockerfile-mode","homepage":null,"size":24,"stargazers_count":128,"watchers_count":128,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/dockerfile-mode/pulls/22"},"html":{"href":"https://github.com/spotify/dockerfile-mode/pull/22"},"issue":{"href":"https://api.github.com/repos/spotify/dockerfile-mode/issues/22"},"comments":{"href":"https://api.github.com/repos/spotify/dockerfile-mode/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/dockerfile-mode/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/dockerfile-mode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/dockerfile-mode/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/dockerfile-mode/statuses/35d10860d97e5d6ef8cf91bca3d56d4ee7f78cde"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}