{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/kubernetes/pulls/comments/90395979","pull_request_review_id":10913665,"id":90395979,"diff_hunk":"@@ -150,17 +152,16 @@ func init() {\n \t})\n }\n \n-// Returns the name of the VM and its Cluster on which this code is running.\n-// This is done by searching for the name of virtual machine by current IP.\n+// Returns the name of the VM on which this code is running.\n // Prerequisite: this code assumes VMWare vmtools or open-vm-tools to be installed in the VM.\n-func readInstance(cfg *VSphereConfig) (string, string, error) {\n+func getVMName(cfg *VSphereConfig) (string, error) {\n \taddrs, err := net.InterfaceAddrs()\n \tif err != nil {\n-\t\treturn \"\", \"\", err\n+\t\treturn \"\", err\n \t}\n-\n+\t","path":"pkg/cloudprovider/providers/vsphere/vsphere.go","position":36,"original_position":36,"commit_id":"285bbacb1ed00419cfb2fcb157f6d45540bb66f9","original_commit_id":"285bbacb1ed00419cfb2fcb157f6d45540bb66f9","user":{"login":"kerneltime","id":774455,"avatar_url":"https://avatars.githubusercontent.com/u/774455?v=3","gravatar_id":"","url":"https://api.github.com/users/kerneltime","html_url":"https://github.com/kerneltime","followers_url":"https://api.github.com/users/kerneltime/followers","following_url":"https://api.github.com/users/kerneltime/following{/other_user}","gists_url":"https://api.github.com/users/kerneltime/gists{/gist_id}","starred_url":"https://api.github.com/users/kerneltime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerneltime/subscriptions","organizations_url":"https://api.github.com/users/kerneltime/orgs","repos_url":"https://api.github.com/users/kerneltime/repos","events_url":"https://api.github.com/users/kerneltime/events{/privacy}","received_events_url":"https://api.github.com/users/kerneltime/received_events","type":"User","site_admin":false},"body":"clean up","created_at":"2016-12-01T07:39:47Z","updated_at":"2016-12-01T07:39:48Z","html_url":"https://github.com/vmware/kubernetes/pull/32#discussion_r90395979","pull_request_url":"https://api.github.com/repos/vmware/kubernetes/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/comments/90395979"},"html":{"href":"https://github.com/vmware/kubernetes/pull/32#discussion_r90395979"},"pull_request":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/kubernetes/pulls/32","id":96017742,"html_url":"https://github.com/vmware/kubernetes/pull/32","diff_url":"https://github.com/vmware/kubernetes/pull/32.diff","patch_url":"https://github.com/vmware/kubernetes/pull/32.patch","issue_url":"https://api.github.com/repos/vmware/kubernetes/issues/32","number":32,"state":"open","locked":false,"title":"Make region and failure domain configurable by the user. Removed code…","user":{"login":"BaluDontu","id":22899615,"avatar_url":"https://avatars.githubusercontent.com/u/22899615?v=3","gravatar_id":"","url":"https://api.github.com/users/BaluDontu","html_url":"https://github.com/BaluDontu","followers_url":"https://api.github.com/users/BaluDontu/followers","following_url":"https://api.github.com/users/BaluDontu/following{/other_user}","gists_url":"https://api.github.com/users/BaluDontu/gists{/gist_id}","starred_url":"https://api.github.com/users/BaluDontu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaluDontu/subscriptions","organizations_url":"https://api.github.com/users/BaluDontu/orgs","repos_url":"https://api.github.com/users/BaluDontu/repos","events_url":"https://api.github.com/users/BaluDontu/events{/privacy}","received_events_url":"https://api.github.com/users/BaluDontu/received_events","type":"User","site_admin":false},"body":"The current fix will take a configurable values of region and fault domain from the user. The zone will comprise of these values which in turn will be used Kubernetes in making decision on where to deploy the node/pod. \r\n\r\nPreviously, once the node is deployed the code will try to retrieve the cluster name and datacenter and use it to assign to failure domain and region respectively. This information varies from each vcenter set up to set up. We should not limit to always pick up these values which doesn't any sense in current scenario. Also the existing implementation panics sometimes - see issue 36295 for more details. \r\n\r\n@abrarshivani @pdhamdhere @kerneltime \r\n","created_at":"2016-12-01T02:59:02Z","updated_at":"2016-12-01T07:39:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7430af158c94a8cd44beb3395975a578d94deba8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/kubernetes/pulls/32/commits","review_comments_url":"https://api.github.com/repos/vmware/kubernetes/pulls/32/comments","review_comment_url":"https://api.github.com/repos/vmware/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/kubernetes/issues/32/comments","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/285bbacb1ed00419cfb2fcb157f6d45540bb66f9","head":{"label":"vmware:panicAttackvmwarerelease-1.4","ref":"panicAttackvmwarerelease-1.4","sha":"285bbacb1ed00419cfb2fcb157f6d45540bb66f9","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49536898,"name":"kubernetes","full_name":"vmware/kubernetes","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/vmware/kubernetes","forks_url":"https://api.github.com/repos/vmware/kubernetes/forks","keys_url":"https://api.github.com/repos/vmware/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/kubernetes/teams","hooks_url":"https://api.github.com/repos/vmware/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vmware/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/kubernetes/events","assignees_url":"https://api.github.com/repos/vmware/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/kubernetes/tags","blobs_url":"https://api.github.com/repos/vmware/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vmware/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vmware/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vmware/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vmware/kubernetes/subscription","commits_url":"https://api.github.com/repos/vmware/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/kubernetes/merges","archive_url":"https://api.github.com/repos/vmware/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/kubernetes/downloads","issues_url":"https://api.github.com/repos/vmware/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vmware/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/kubernetes/deployments","created_at":"2016-01-12T23:58:29Z","updated_at":"2016-11-04T08:04:24Z","pushed_at":"2016-12-01T02:59:02Z","git_url":"git://github.com/vmware/kubernetes.git","ssh_url":"git@github.com:vmware/kubernetes.git","clone_url":"https://github.com/vmware/kubernetes.git","svn_url":"https://github.com/vmware/kubernetes","homepage":"http://kubernetes.io","size":362458,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":6,"default_branch":"master"}},"base":{"label":"vmware:release-1.4","ref":"release-1.4","sha":"69bd37d77009599eca9ce78669afab6666665c53","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49536898,"name":"kubernetes","full_name":"vmware/kubernetes","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/vmware/kubernetes","forks_url":"https://api.github.com/repos/vmware/kubernetes/forks","keys_url":"https://api.github.com/repos/vmware/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/kubernetes/teams","hooks_url":"https://api.github.com/repos/vmware/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vmware/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/kubernetes/events","assignees_url":"https://api.github.com/repos/vmware/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/kubernetes/tags","blobs_url":"https://api.github.com/repos/vmware/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vmware/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vmware/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vmware/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vmware/kubernetes/subscription","commits_url":"https://api.github.com/repos/vmware/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/kubernetes/merges","archive_url":"https://api.github.com/repos/vmware/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/kubernetes/downloads","issues_url":"https://api.github.com/repos/vmware/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vmware/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/kubernetes/deployments","created_at":"2016-01-12T23:58:29Z","updated_at":"2016-11-04T08:04:24Z","pushed_at":"2016-12-01T02:59:02Z","git_url":"git://github.com/vmware/kubernetes.git","ssh_url":"git@github.com:vmware/kubernetes.git","clone_url":"https://github.com/vmware/kubernetes.git","svn_url":"https://github.com/vmware/kubernetes","homepage":"http://kubernetes.io","size":362458,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/32"},"html":{"href":"https://github.com/vmware/kubernetes/pull/32"},"issue":{"href":"https://api.github.com/repos/vmware/kubernetes/issues/32"},"comments":{"href":"https://api.github.com/repos/vmware/kubernetes/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/kubernetes/statuses/285bbacb1ed00419cfb2fcb157f6d45540bb66f9"}}}}
{"actor":{"display_login":"kerneltime"}}