{"action":"created","issue":{"url":"https://api.github.com/repos/slac207/cs207project/issues/41","repository_url":"https://api.github.com/repos/slac207/cs207project","labels_url":"https://api.github.com/repos/slac207/cs207project/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/slac207/cs207project/issues/41/comments","events_url":"https://api.github.com/repos/slac207/cs207project/issues/41/events","html_url":"https://github.com/slac207/cs207project/pull/41","id":185554773,"number":41,"title":"#40 Rewrite ArrayTimeSeries to take advantage of np storage, rewrite tests","user":{"login":"cocochrane","id":16770397,"avatar_url":"https://avatars.githubusercontent.com/u/16770397?v=3","gravatar_id":"","url":"https://api.github.com/users/cocochrane","html_url":"https://github.com/cocochrane","followers_url":"https://api.github.com/users/cocochrane/followers","following_url":"https://api.github.com/users/cocochrane/following{/other_user}","gists_url":"https://api.github.com/users/cocochrane/gists{/gist_id}","starred_url":"https://api.github.com/users/cocochrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocochrane/subscriptions","organizations_url":"https://api.github.com/users/cocochrane/orgs","repos_url":"https://api.github.com/users/cocochrane/repos","events_url":"https://api.github.com/users/cocochrane/events{/privacy}","received_events_url":"https://api.github.com/users/cocochrane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-27T01:57:56Z","updated_at":"2016-10-27T01:58:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/slac207/cs207project/pulls/41","html_url":"https://github.com/slac207/cs207project/pull/41","diff_url":"https://github.com/slac207/cs207project/pull/41.diff","patch_url":"https://github.com/slac207/cs207project/pull/41.patch"},"body":"These are the changes in ArrayTimeSeries:\r\n\r\n1. init(): now checks sizes of times and values\r\n2. getitem(): uses np.take() which is faster than regular indexing (says the internet)\r\n3. setitem(): uses np.put() likewise faster than regular indexing/setting\r\n4. len(): uses np.size()\r\n5. values: just returns the values (doesn't need to cast into a np array again)\r\n6. times: just returns the times (doesn't need to cast into a np array again)\r\n7. interpolate: now uses np.searchsorted() instead of the binary_search code\r\n8. neg(): uses numpy multiplication\r\n9. abs(): uses numpy absolute value\r\n10. bool(): uses np.count_nonzero()\r\n11. add(): uses numpy addition\r\n12. mul(): uses numpy multiplication\r\n13. eqtimes(): uses np.array_equal()\r\n14. eqvalues(): uses np.array_equal()\r\n\r\nFunctions omitted (should just inherit these from the parent because I can't find a faster way to implement them):\r\n1. repr()\r\n2. str()\r\n3. iter()\r\n4. contains()\r\n5. itertimes()\r\n6. iteritems()\r\n7. itervalues()\r\n8. items()\r\n9. identity()\r\n10. lazy()\r\n11. pos()\r\n12. sub()\r\n13. eq()\r\n\r\n@brennan-ae See anything on this bottom list that you think could be sped up? I was unsure whether I should use the numpy iterator?"},"comment":{"url":"https://api.github.com/repos/slac207/cs207project/issues/comments/256526529","html_url":"https://github.com/slac207/cs207project/pull/41#issuecomment-256526529","issue_url":"https://api.github.com/repos/slac207/cs207project/issues/41","id":256526529,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T01:58:39Z","updated_at":"2016-10-27T01:58:39Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8531598/badge)](https://coveralls.io/builds/8531598)\n\nCoverage decreased (-0.2%) to 99.82% when pulling **454555f3d45d590549ceb22858add95667adc2c7 on ChangeArrayTS** into **c101a66c35b83bcee5560b0f18bee1b23ba08591 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}