{"action":"created","comment":{"url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments/53592989","id":53592989,"diff_hunk":"@@ -384,6 +384,15 @@\n \n % dimen keeping the shift computed with next function\n \\newdimen\\gre@dimen@eolshift\n+\\newcount\\gre@count@protrusion@hyphen@eol %\n+\n+% protrusion for hyphens inerted by Lua\n+\\gre@count@protrusion@hyphen@eol = 50","path":"tex/gregoriotex-spaces.tex","position":7,"original_position":7,"commit_id":"f3eab25920c0bae4deaead627e15a0d9dbe45e4c","original_commit_id":"f3eab25920c0bae4deaead627e15a0d9dbe45e4c","user":{"login":"eroux","id":60868,"avatar_url":"https://avatars.githubusercontent.com/u/60868?v=3","gravatar_id":"","url":"https://api.github.com/users/eroux","html_url":"https://github.com/eroux","followers_url":"https://api.github.com/users/eroux/followers","following_url":"https://api.github.com/users/eroux/following{/other_user}","gists_url":"https://api.github.com/users/eroux/gists{/gist_id}","starred_url":"https://api.github.com/users/eroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eroux/subscriptions","organizations_url":"https://api.github.com/users/eroux/orgs","repos_url":"https://api.github.com/users/eroux/repos","events_url":"https://api.github.com/users/eroux/events{/privacy}","received_events_url":"https://api.github.com/users/eroux/received_events","type":"User","site_admin":false},"body":"I'll add it for the sake of safety, but here (not in a macro), we're not in an environment where we have to avoid end of lines, and there is an end of line after the number, so TeX will see a `number` token, and then a `end of line` token, so it won't search for what's after the number. In an environment where we avoid end of lines, TeX would keep looking for what's after the number, which can lead to errors","created_at":"2016-02-22T07:30:38Z","updated_at":"2016-02-22T07:30:38Z","html_url":"https://github.com/gregorio-project/gregorio/pull/945#discussion_r53592989","pull_request_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/945","_links":{"self":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments/53592989"},"html":{"href":"https://github.com/gregorio-project/gregorio/pull/945#discussion_r53592989"},"pull_request":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/945"}}},"pull_request":{"url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/945","id":60102986,"html_url":"https://github.com/gregorio-project/gregorio/pull/945","diff_url":"https://github.com/gregorio-project/gregorio/pull/945.diff","patch_url":"https://github.com/gregorio-project/gregorio/pull/945.patch","issue_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/945","number":945,"state":"open","locked":false,"title":"Fix #845","user":{"login":"eroux","id":60868,"avatar_url":"https://avatars.githubusercontent.com/u/60868?v=3","gravatar_id":"","url":"https://api.github.com/users/eroux","html_url":"https://github.com/eroux","followers_url":"https://api.github.com/users/eroux/followers","following_url":"https://api.github.com/users/eroux/following{/other_user}","gists_url":"https://api.github.com/users/eroux/gists{/gist_id}","starred_url":"https://api.github.com/users/eroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eroux/subscriptions","organizations_url":"https://api.github.com/users/eroux/orgs","repos_url":"https://api.github.com/users/eroux/repos","events_url":"https://api.github.com/users/eroux/events{/privacy}","received_events_url":"https://api.github.com/users/eroux/received_events","type":"User","site_admin":false},"body":"Introduce a protrusion factor for hyphens automatically inserted by Lua (so it's a small first step towards #931). The value of 50 should prevent the hyphens from going too far on the right, and shouldn't change the output too much. I'm not entirely sure there's a completely logical explanation to this value, that's just what I found after some experiments. I tried to apply the same protrusion factor to hyphens automatically inserted by TeX, but it changed the tests a lot, in a very surprising way, so it seems unsafe to do it at this stage of the release cycle.","created_at":"2016-02-21T20:39:30Z","updated_at":"2016-02-22T07:30:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fb0421b3f33589baf1dd6c467e7a47717301f9f","assignee":null,"milestone":{"url":"https://api.github.com/repos/gregorio-project/gregorio/milestones/4","html_url":"https://github.com/gregorio-project/gregorio/milestones/4.1","labels_url":"https://api.github.com/repos/gregorio-project/gregorio/milestones/4/labels","id":1380377,"number":4,"title":"4.1","description":"","creator":{"login":"rpspringuel","id":7671682,"avatar_url":"https://avatars.githubusercontent.com/u/7671682?v=3","gravatar_id":"","url":"https://api.github.com/users/rpspringuel","html_url":"https://github.com/rpspringuel","followers_url":"https://api.github.com/users/rpspringuel/followers","following_url":"https://api.github.com/users/rpspringuel/following{/other_user}","gists_url":"https://api.github.com/users/rpspringuel/gists{/gist_id}","starred_url":"https://api.github.com/users/rpspringuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpspringuel/subscriptions","organizations_url":"https://api.github.com/users/rpspringuel/orgs","repos_url":"https://api.github.com/users/rpspringuel/repos","events_url":"https://api.github.com/users/rpspringuel/events{/privacy}","received_events_url":"https://api.github.com/users/rpspringuel/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":163,"state":"open","created_at":"2015-10-27T20:55:01Z","updated_at":"2016-02-21T22:59:21Z","due_on":"2016-02-29T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/945/commits","review_comments_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/945/comments","review_comment_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/945/comments","statuses_url":"https://api.github.com/repos/gregorio-project/gregorio/statuses/f3eab25920c0bae4deaead627e15a0d9dbe45e4c","head":{"label":"gregorio-project:fix-845","ref":"fix-845","sha":"f3eab25920c0bae4deaead627e15a0d9dbe45e4c","user":{"login":"gregorio-project","id":7902256,"avatar_url":"https://avatars.githubusercontent.com/u/7902256?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorio-project","html_url":"https://github.com/gregorio-project","followers_url":"https://api.github.com/users/gregorio-project/followers","following_url":"https://api.github.com/users/gregorio-project/following{/other_user}","gists_url":"https://api.github.com/users/gregorio-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorio-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorio-project/subscriptions","organizations_url":"https://api.github.com/users/gregorio-project/orgs","repos_url":"https://api.github.com/users/gregorio-project/repos","events_url":"https://api.github.com/users/gregorio-project/events{/privacy}","received_events_url":"https://api.github.com/users/gregorio-project/received_events","type":"Organization","site_admin":false},"repo":{"id":20884374,"name":"gregorio","full_name":"gregorio-project/gregorio","owner":{"login":"gregorio-project","id":7902256,"avatar_url":"https://avatars.githubusercontent.com/u/7902256?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorio-project","html_url":"https://github.com/gregorio-project","followers_url":"https://api.github.com/users/gregorio-project/followers","following_url":"https://api.github.com/users/gregorio-project/following{/other_user}","gists_url":"https://api.github.com/users/gregorio-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorio-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorio-project/subscriptions","organizations_url":"https://api.github.com/users/gregorio-project/orgs","repos_url":"https://api.github.com/users/gregorio-project/repos","events_url":"https://api.github.com/users/gregorio-project/events{/privacy}","received_events_url":"https://api.github.com/users/gregorio-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gregorio-project/gregorio","description":"The Gregorio Project","fork":false,"url":"https://api.github.com/repos/gregorio-project/gregorio","forks_url":"https://api.github.com/repos/gregorio-project/gregorio/forks","keys_url":"https://api.github.com/repos/gregorio-project/gregorio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregorio-project/gregorio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregorio-project/gregorio/teams","hooks_url":"https://api.github.com/repos/gregorio-project/gregorio/hooks","issue_events_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/events{/number}","events_url":"https://api.github.com/repos/gregorio-project/gregorio/events","assignees_url":"https://api.github.com/repos/gregorio-project/gregorio/assignees{/user}","branches_url":"https://api.github.com/repos/gregorio-project/gregorio/branches{/branch}","tags_url":"https://api.github.com/repos/gregorio-project/gregorio/tags","blobs_url":"https://api.github.com/repos/gregorio-project/gregorio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregorio-project/gregorio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregorio-project/gregorio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregorio-project/gregorio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregorio-project/gregorio/statuses/{sha}","languages_url":"https://api.github.com/repos/gregorio-project/gregorio/languages","stargazers_url":"https://api.github.com/repos/gregorio-project/gregorio/stargazers","contributors_url":"https://api.github.com/repos/gregorio-project/gregorio/contributors","subscribers_url":"https://api.github.com/repos/gregorio-project/gregorio/subscribers","subscription_url":"https://api.github.com/repos/gregorio-project/gregorio/subscription","commits_url":"https://api.github.com/repos/gregorio-project/gregorio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregorio-project/gregorio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregorio-project/gregorio/contents/{+path}","compare_url":"https://api.github.com/repos/gregorio-project/gregorio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregorio-project/gregorio/merges","archive_url":"https://api.github.com/repos/gregorio-project/gregorio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregorio-project/gregorio/downloads","issues_url":"https://api.github.com/repos/gregorio-project/gregorio/issues{/number}","pulls_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls{/number}","milestones_url":"https://api.github.com/repos/gregorio-project/gregorio/milestones{/number}","notifications_url":"https://api.github.com/repos/gregorio-project/gregorio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregorio-project/gregorio/labels{/name}","releases_url":"https://api.github.com/repos/gregorio-project/gregorio/releases{/id}","deployments_url":"https://api.github.com/repos/gregorio-project/gregorio/deployments","created_at":"2014-06-16T12:41:52Z","updated_at":"2016-02-10T22:02:38Z","pushed_at":"2016-02-22T01:39:04Z","git_url":"git://github.com/gregorio-project/gregorio.git","ssh_url":"git@github.com:gregorio-project/gregorio.git","clone_url":"https://github.com/gregorio-project/gregorio.git","svn_url":"https://github.com/gregorio-project/gregorio","homepage":"http://gregorio-project.github.io","size":79964,"stargazers_count":29,"watchers_count":29,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":19,"forks":11,"open_issues":19,"watchers":29,"default_branch":"master"}},"base":{"label":"gregorio-project:release-4.1","ref":"release-4.1","sha":"611e8ea49399cd990e4be0eb823c29bdafd749f4","user":{"login":"gregorio-project","id":7902256,"avatar_url":"https://avatars.githubusercontent.com/u/7902256?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorio-project","html_url":"https://github.com/gregorio-project","followers_url":"https://api.github.com/users/gregorio-project/followers","following_url":"https://api.github.com/users/gregorio-project/following{/other_user}","gists_url":"https://api.github.com/users/gregorio-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorio-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorio-project/subscriptions","organizations_url":"https://api.github.com/users/gregorio-project/orgs","repos_url":"https://api.github.com/users/gregorio-project/repos","events_url":"https://api.github.com/users/gregorio-project/events{/privacy}","received_events_url":"https://api.github.com/users/gregorio-project/received_events","type":"Organization","site_admin":false},"repo":{"id":20884374,"name":"gregorio","full_name":"gregorio-project/gregorio","owner":{"login":"gregorio-project","id":7902256,"avatar_url":"https://avatars.githubusercontent.com/u/7902256?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorio-project","html_url":"https://github.com/gregorio-project","followers_url":"https://api.github.com/users/gregorio-project/followers","following_url":"https://api.github.com/users/gregorio-project/following{/other_user}","gists_url":"https://api.github.com/users/gregorio-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorio-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorio-project/subscriptions","organizations_url":"https://api.github.com/users/gregorio-project/orgs","repos_url":"https://api.github.com/users/gregorio-project/repos","events_url":"https://api.github.com/users/gregorio-project/events{/privacy}","received_events_url":"https://api.github.com/users/gregorio-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gregorio-project/gregorio","description":"The Gregorio Project","fork":false,"url":"https://api.github.com/repos/gregorio-project/gregorio","forks_url":"https://api.github.com/repos/gregorio-project/gregorio/forks","keys_url":"https://api.github.com/repos/gregorio-project/gregorio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregorio-project/gregorio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregorio-project/gregorio/teams","hooks_url":"https://api.github.com/repos/gregorio-project/gregorio/hooks","issue_events_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/events{/number}","events_url":"https://api.github.com/repos/gregorio-project/gregorio/events","assignees_url":"https://api.github.com/repos/gregorio-project/gregorio/assignees{/user}","branches_url":"https://api.github.com/repos/gregorio-project/gregorio/branches{/branch}","tags_url":"https://api.github.com/repos/gregorio-project/gregorio/tags","blobs_url":"https://api.github.com/repos/gregorio-project/gregorio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregorio-project/gregorio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregorio-project/gregorio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregorio-project/gregorio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregorio-project/gregorio/statuses/{sha}","languages_url":"https://api.github.com/repos/gregorio-project/gregorio/languages","stargazers_url":"https://api.github.com/repos/gregorio-project/gregorio/stargazers","contributors_url":"https://api.github.com/repos/gregorio-project/gregorio/contributors","subscribers_url":"https://api.github.com/repos/gregorio-project/gregorio/subscribers","subscription_url":"https://api.github.com/repos/gregorio-project/gregorio/subscription","commits_url":"https://api.github.com/repos/gregorio-project/gregorio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregorio-project/gregorio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregorio-project/gregorio/contents/{+path}","compare_url":"https://api.github.com/repos/gregorio-project/gregorio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregorio-project/gregorio/merges","archive_url":"https://api.github.com/repos/gregorio-project/gregorio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregorio-project/gregorio/downloads","issues_url":"https://api.github.com/repos/gregorio-project/gregorio/issues{/number}","pulls_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls{/number}","milestones_url":"https://api.github.com/repos/gregorio-project/gregorio/milestones{/number}","notifications_url":"https://api.github.com/repos/gregorio-project/gregorio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregorio-project/gregorio/labels{/name}","releases_url":"https://api.github.com/repos/gregorio-project/gregorio/releases{/id}","deployments_url":"https://api.github.com/repos/gregorio-project/gregorio/deployments","created_at":"2014-06-16T12:41:52Z","updated_at":"2016-02-10T22:02:38Z","pushed_at":"2016-02-22T01:39:04Z","git_url":"git://github.com/gregorio-project/gregorio.git","ssh_url":"git@github.com:gregorio-project/gregorio.git","clone_url":"https://github.com/gregorio-project/gregorio.git","svn_url":"https://github.com/gregorio-project/gregorio","homepage":"http://gregorio-project.github.io","size":79964,"stargazers_count":29,"watchers_count":29,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":19,"forks":11,"open_issues":19,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/945"},"html":{"href":"https://github.com/gregorio-project/gregorio/pull/945"},"issue":{"href":"https://api.github.com/repos/gregorio-project/gregorio/issues/945"},"comments":{"href":"https://api.github.com/repos/gregorio-project/gregorio/issues/945/comments"},"review_comments":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/945/comments"},"review_comment":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/945/commits"},"statuses":{"href":"https://api.github.com/repos/gregorio-project/gregorio/statuses/f3eab25920c0bae4deaead627e15a0d9dbe45e4c"}}}}