{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/656","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/656/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/656/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/656/events","html_url":"https://github.com/ocaml/ocaml/pull/656","id":163711976,"number":656,"title":"Install all include files, and access internals with CAML_ACCESS_INTE…","user":{"login":"lefessan","id":514957,"avatar_url":"https://avatars.githubusercontent.com/u/514957?v=3","gravatar_id":"","url":"https://api.github.com/users/lefessan","html_url":"https://github.com/lefessan","followers_url":"https://api.github.com/users/lefessan/followers","following_url":"https://api.github.com/users/lefessan/following{/other_user}","gists_url":"https://api.github.com/users/lefessan/gists{/gist_id}","starred_url":"https://api.github.com/users/lefessan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefessan/subscriptions","organizations_url":"https://api.github.com/users/lefessan/orgs","repos_url":"https://api.github.com/users/lefessan/repos","events_url":"https://api.github.com/users/lefessan/events{/privacy}","received_events_url":"https://api.github.com/users/lefessan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-04T17:01:48Z","updated_at":"2016-07-08T21:51:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/656","html_url":"https://github.com/ocaml/ocaml/pull/656","diff_url":"https://github.com/ocaml/ocaml/pull/656.diff","patch_url":"https://github.com/ocaml/ocaml/pull/656.patch"},"body":"Currently, OCaml only installs some of its include files, and remove some \"private\" sections from these public headers. This PR changes this behavior by installing _all_ include files, but keeps them private (i.e. they will exactly define the same values as before) unless a macro `CAML_ACCESS_INTERNALS` is defined. The rationale is that specific applications might require more access to the internals of the runtime, but they should be warned of the possibility of incompatible changes by setting this macro.\r\n\r\nTo have access to internals, all C files within the distribution must also set `CAML_ACCESS_INTERNALS`.\r\n\r\nThis PR is needed for OCamlPro's memory profiler to work on an unpatched version of OCaml."},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/231481754","html_url":"https://github.com/ocaml/ocaml/pull/656#issuecomment-231481754","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/656","id":231481754,"user":{"login":"lefessan","id":514957,"avatar_url":"https://avatars.githubusercontent.com/u/514957?v=3","gravatar_id":"","url":"https://api.github.com/users/lefessan","html_url":"https://github.com/lefessan","followers_url":"https://api.github.com/users/lefessan/followers","following_url":"https://api.github.com/users/lefessan/following{/other_user}","gists_url":"https://api.github.com/users/lefessan/gists{/gist_id}","starred_url":"https://api.github.com/users/lefessan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefessan/subscriptions","organizations_url":"https://api.github.com/users/lefessan/orgs","repos_url":"https://api.github.com/users/lefessan/repos","events_url":"https://api.github.com/users/lefessan/events{/privacy}","received_events_url":"https://api.github.com/users/lefessan/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T21:51:35Z","updated_at":"2016-07-08T21:51:35Z","body":"I have switched to CAML_INTERNALS and updated the manual. Is the short paragraph that I added enough ? Since it is supposed to grant access to the \"private\" parts of the headers, it was not clear for me that it had to be documented in the \"public\" manual..."}}
{"actor":{"display_login":"lefessan"}}