{"action":"created","issue":{"url":"https://api.github.com/repos/chaijs/chai/issues/692","repository_url":"https://api.github.com/repos/chaijs/chai","labels_url":"https://api.github.com/repos/chaijs/chai/issues/692/labels{/name}","comments_url":"https://api.github.com/repos/chaijs/chai/issues/692/comments","events_url":"https://api.github.com/repos/chaijs/chai/issues/692/events","html_url":"https://github.com/chaijs/chai/pull/692","id":152053192,"number":692,"title":"[WIP] Verify types on within and related assertions","user":{"login":"vieiralucas","id":7764293,"avatar_url":"https://avatars.githubusercontent.com/u/7764293?v=3","gravatar_id":"","url":"https://api.github.com/users/vieiralucas","html_url":"https://github.com/vieiralucas","followers_url":"https://api.github.com/users/vieiralucas/followers","following_url":"https://api.github.com/users/vieiralucas/following{/other_user}","gists_url":"https://api.github.com/users/vieiralucas/gists{/gist_id}","starred_url":"https://api.github.com/users/vieiralucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieiralucas/subscriptions","organizations_url":"https://api.github.com/users/vieiralucas/orgs","repos_url":"https://api.github.com/users/vieiralucas/repos","events_url":"https://api.github.com/users/vieiralucas/events{/privacy}","received_events_url":"https://api.github.com/users/vieiralucas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-04-30T21:10:35Z","updated_at":"2016-05-04T12:12:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chaijs/chai/pulls/692","html_url":"https://github.com/chaijs/chai/pull/692","diff_url":"https://github.com/chaijs/chai/pull/692.diff","patch_url":"https://github.com/chaijs/chai/pull/692.patch"},"body":"Hello there, this will be my proposal solution for #691 \r\n\r\nSo why this is a WIP...\r\nI started coding this from the branch master.\r\nWhen I came here to make the PR, I realized that the 4.x.x branch was 166 commits behind master and that my PR could not be merged.\r\nWell, no problem. I checkout to 4.x.x and made some cherry-picks (actually ctrl-c ctrl-v :smile:)\r\nBUT, I saw that some features that exists on master did not exist here on 4.x.x\r\n\r\nThe features which are missing on 4.x.x that affect this PR:\r\n- `assert.atLeast`\r\n- `assert.atMost`\r\n- `increase|decrease...by()`\r\n \r\nWhat should I do about it?\r\n\r\nThings that I'm not sure how to do\r\n- [ ] Documentation updated to indicate type requirements"},"comment":{"url":"https://api.github.com/repos/chaijs/chai/issues/comments/216841795","html_url":"https://github.com/chaijs/chai/pull/692#issuecomment-216841795","issue_url":"https://api.github.com/repos/chaijs/chai/issues/692","id":216841795,"user":{"login":"meeber","id":17260989,"avatar_url":"https://avatars.githubusercontent.com/u/17260989?v=3","gravatar_id":"","url":"https://api.github.com/users/meeber","html_url":"https://github.com/meeber","followers_url":"https://api.github.com/users/meeber/followers","following_url":"https://api.github.com/users/meeber/following{/other_user}","gists_url":"https://api.github.com/users/meeber/gists{/gist_id}","starred_url":"https://api.github.com/users/meeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeber/subscriptions","organizations_url":"https://api.github.com/users/meeber/orgs","repos_url":"https://api.github.com/users/meeber/repos","events_url":"https://api.github.com/users/meeber/events{/privacy}","received_events_url":"https://api.github.com/users/meeber/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T12:12:52Z","updated_at":"2016-05-04T12:12:52Z","body":"@keithamus I just want to make sure we're on the same page here. There are two separate issues:\r\n\r\n1. There are a few numeric assertions currently on `master` but not on `4.x.x`: `atLeast`, `atMost`, and `increase/decrease`. @vieiralucas originally wrote this PR against the master branch, providing type checking on those assertions. But when he went to open a PR, he saw that they weren't in `4.x.x` and thus removed them so there weren't any conflicts. Do you want him to resubmit his original PR that covers those assertions before we merge? He just posted in this thread so it seems he's active.\r\n\r\n1. It was also discovered that the `within` assertion doesn't exist on the `assert` interface. @lucasfcosta and I were discussing opening a separate issue for that + any other missing assertions. Agreed that this should be handled after 4.x.x is release."}}