{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/79812839","id":79812839,"diff_hunk":"@@ -0,0 +1,21 @@\n+'use strict';\n+const common = require('../common');\n+const assert = require('assert');\n+const http = require('http');\n+\n+const server = http.createServer((req, res) => {\n+  assert.doesNotThrow(() => {\n+    res.setHeader('header1', 1);\n+  });\n+  res.write('abc')\n+  assert.throws(() => {\n+    res.setHeader('header2', 2);\n+  }, Error, 'setHeader after write should throw');\n+  res.end()\n+});\n+\n+server.listen(common.PORT, () => {\n+  http.get({port: server.address().port}, () => {\n+    server.close()\n+  });","path":"test/parallel/test-http-response-add-header-after-sent.js","position":null,"original_position":20,"commit_id":"8787d21dd2c8efa43456824af4b7ec0631558745","original_commit_id":"361542bb14bd71c2df8ab29c5d14f40568288ee3","user":{"login":"niklasi","id":1456821,"avatar_url":"https://avatars.githubusercontent.com/u/1456821?v=3","gravatar_id":"","url":"https://api.github.com/users/niklasi","html_url":"https://github.com/niklasi","followers_url":"https://api.github.com/users/niklasi/followers","following_url":"https://api.github.com/users/niklasi/following{/other_user}","gists_url":"https://api.github.com/users/niklasi/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasi/subscriptions","organizations_url":"https://api.github.com/users/niklasi/orgs","repos_url":"https://api.github.com/users/niklasi/repos","events_url":"https://api.github.com/users/niklasi/events{/privacy}","received_events_url":"https://api.github.com/users/niklasi/received_events","type":"User","site_admin":false},"body":"I have updated the PR with 0 as port number now. Thanks for the feedback.","created_at":"2016-09-21T11:34:23Z","updated_at":"2016-09-21T11:34:23Z","html_url":"https://github.com/nodejs/node/pull/8682#discussion_r79812839","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/8682","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/79812839"},"html":{"href":"https://github.com/nodejs/node/pull/8682#discussion_r79812839"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/8682"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8682","id":86109018,"html_url":"https://github.com/nodejs/node/pull/8682","diff_url":"https://github.com/nodejs/node/pull/8682.diff","patch_url":"https://github.com/nodejs/node/pull/8682.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/8682","number":8682,"state":"open","locked":false,"title":"test: Add tests for add/remove header after sent.","user":{"login":"niklasi","id":1456821,"avatar_url":"https://avatars.githubusercontent.com/u/1456821?v=3","gravatar_id":"","url":"https://api.github.com/users/niklasi","html_url":"https://github.com/niklasi","followers_url":"https://api.github.com/users/niklasi/followers","following_url":"https://api.github.com/users/niklasi/following{/other_user}","gists_url":"https://api.github.com/users/niklasi/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasi/subscriptions","organizations_url":"https://api.github.com/users/niklasi/orgs","repos_url":"https://api.github.com/users/niklasi/repos","events_url":"https://api.github.com/users/niklasi/events{/privacy}","received_events_url":"https://api.github.com/users/niklasi/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\ntest, http\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nThis change adds tests to make sure an Error is thrown if a header\r\nis added or removed after they are sent.","created_at":"2016-09-21T07:14:13Z","updated_at":"2016-09-21T11:34:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fb78ebaee41a47b77dd9c3e53b9bfc2bbd882fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/8682/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/8682/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8682/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/8787d21dd2c8efa43456824af4b7ec0631558745","head":{"label":"niklasi:master","ref":"master","sha":"8787d21dd2c8efa43456824af4b7ec0631558745","user":{"login":"niklasi","id":1456821,"avatar_url":"https://avatars.githubusercontent.com/u/1456821?v=3","gravatar_id":"","url":"https://api.github.com/users/niklasi","html_url":"https://github.com/niklasi","followers_url":"https://api.github.com/users/niklasi/followers","following_url":"https://api.github.com/users/niklasi/following{/other_user}","gists_url":"https://api.github.com/users/niklasi/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasi/subscriptions","organizations_url":"https://api.github.com/users/niklasi/orgs","repos_url":"https://api.github.com/users/niklasi/repos","events_url":"https://api.github.com/users/niklasi/events{/privacy}","received_events_url":"https://api.github.com/users/niklasi/received_events","type":"User","site_admin":false},"repo":{"id":62728111,"name":"node","full_name":"niklasi/node","owner":{"login":"niklasi","id":1456821,"avatar_url":"https://avatars.githubusercontent.com/u/1456821?v=3","gravatar_id":"","url":"https://api.github.com/users/niklasi","html_url":"https://github.com/niklasi","followers_url":"https://api.github.com/users/niklasi/followers","following_url":"https://api.github.com/users/niklasi/following{/other_user}","gists_url":"https://api.github.com/users/niklasi/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasi/subscriptions","organizations_url":"https://api.github.com/users/niklasi/orgs","repos_url":"https://api.github.com/users/niklasi/repos","events_url":"https://api.github.com/users/niklasi/events{/privacy}","received_events_url":"https://api.github.com/users/niklasi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niklasi/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/niklasi/node","forks_url":"https://api.github.com/repos/niklasi/node/forks","keys_url":"https://api.github.com/repos/niklasi/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niklasi/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niklasi/node/teams","hooks_url":"https://api.github.com/repos/niklasi/node/hooks","issue_events_url":"https://api.github.com/repos/niklasi/node/issues/events{/number}","events_url":"https://api.github.com/repos/niklasi/node/events","assignees_url":"https://api.github.com/repos/niklasi/node/assignees{/user}","branches_url":"https://api.github.com/repos/niklasi/node/branches{/branch}","tags_url":"https://api.github.com/repos/niklasi/node/tags","blobs_url":"https://api.github.com/repos/niklasi/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niklasi/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niklasi/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/niklasi/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niklasi/node/statuses/{sha}","languages_url":"https://api.github.com/repos/niklasi/node/languages","stargazers_url":"https://api.github.com/repos/niklasi/node/stargazers","contributors_url":"https://api.github.com/repos/niklasi/node/contributors","subscribers_url":"https://api.github.com/repos/niklasi/node/subscribers","subscription_url":"https://api.github.com/repos/niklasi/node/subscription","commits_url":"https://api.github.com/repos/niklasi/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/niklasi/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/niklasi/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/niklasi/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/niklasi/node/contents/{+path}","compare_url":"https://api.github.com/repos/niklasi/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niklasi/node/merges","archive_url":"https://api.github.com/repos/niklasi/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niklasi/node/downloads","issues_url":"https://api.github.com/repos/niklasi/node/issues{/number}","pulls_url":"https://api.github.com/repos/niklasi/node/pulls{/number}","milestones_url":"https://api.github.com/repos/niklasi/node/milestones{/number}","notifications_url":"https://api.github.com/repos/niklasi/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niklasi/node/labels{/name}","releases_url":"https://api.github.com/repos/niklasi/node/releases{/id}","deployments_url":"https://api.github.com/repos/niklasi/node/deployments","created_at":"2016-07-06T14:38:09Z","updated_at":"2016-07-06T14:38:39Z","pushed_at":"2016-09-21T11:09:04Z","git_url":"git://github.com/niklasi/node.git","ssh_url":"git@github.com:niklasi/node.git","clone_url":"https://github.com/niklasi/node.git","svn_url":"https://github.com/niklasi/node","homepage":"https://nodejs.org","size":223391,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"b1b1978ec5a533607c5c2decaec44f00ff0a80b4","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-09-21T10:47:47Z","pushed_at":"2016-09-21T11:09:07Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":304369,"stargazers_count":26895,"watchers_count":26895,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4329,"mirror_url":null,"open_issues_count":821,"forks":4329,"open_issues":821,"watchers":26895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/8682"},"html":{"href":"https://github.com/nodejs/node/pull/8682"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/8682"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/8682/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/8682/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/8682/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/8787d21dd2c8efa43456824af4b7ec0631558745"}}}}
{"actor":{"display_login":"niklasi"}}