{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/71561070","id":71561070,"diff_hunk":"@@ -43,6 +43,9 @@ use pf::Portal::Session;\n use pf::web::externalportal;\n use pf::inline;\n \n+use pfconfig::cached_scalar;\n+tie our $portal_request_timeout, 'pfconfig::cached_scalar', 'resource::portal_request_timeout';","path":"lib/pf/web/dispatcher.pm","position":5,"original_position":5,"commit_id":"ad33b8cb291963fa38cbbcf9911a9eaba2d319c4","original_commit_id":"ad33b8cb291963fa38cbbcf9911a9eaba2d319c4","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"body":"Since this is already in $Config{captive_portal}{request_timeout}\r\nWhy the need to add another namespace?","created_at":"2016-07-20T16:40:32Z","updated_at":"2016-07-20T16:40:32Z","html_url":"https://github.com/inverse-inc/packetfence/pull/1590#discussion_r71561070","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1590","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/71561070"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/1590#discussion_r71561070"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1590"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1590","id":75673369,"html_url":"https://github.com/inverse-inc/packetfence/pull/1590","diff_url":"https://github.com/inverse-inc/packetfence/pull/1590.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/1590.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1590","number":1590,"state":"open","locked":false,"title":"Fix/portal timeout","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"# Description\r\nMake captive portal timeout after X amount of seconds.\r\n\r\n# Impacts\r\nCaptive portal\r\n\r\n# Issue\r\nfixes #1570\r\n\r\n# Delete branch after merge\r\nYES\r\n\r\n# NEWS file entries\r\n## Bug Fixes\r\n* Added timeout to captive portal to prevent long running requests (#1570).\r\n\r\n","created_at":"2016-06-29T15:49:54Z","updated_at":"2016-07-20T16:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4e249ee5042fda327a0d3c8eee9000f6401015b","assignee":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/18","html_url":"https://github.com/inverse-inc/packetfence/milestones/PacketFence-6.3","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/18/labels","id":1868389,"number":18,"title":"PacketFence-6.3","description":"","creator":{"login":"dwlfrth","id":633234,"avatar_url":"https://avatars.githubusercontent.com/u/633234?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlfrth","html_url":"https://github.com/dwlfrth","followers_url":"https://api.github.com/users/dwlfrth/followers","following_url":"https://api.github.com/users/dwlfrth/following{/other_user}","gists_url":"https://api.github.com/users/dwlfrth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlfrth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlfrth/subscriptions","organizations_url":"https://api.github.com/users/dwlfrth/orgs","repos_url":"https://api.github.com/users/dwlfrth/repos","events_url":"https://api.github.com/users/dwlfrth/events{/privacy}","received_events_url":"https://api.github.com/users/dwlfrth/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":4,"state":"open","created_at":"2016-07-06T19:30:33Z","updated_at":"2016-07-20T15:07:20Z","due_on":"2016-08-01T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1590/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1590/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1590/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/ad33b8cb291963fa38cbbcf9911a9eaba2d319c4","head":{"label":"julsemaan:fix/portal-timeout","ref":"fix/portal-timeout","sha":"ad33b8cb291963fa38cbbcf9911a9eaba2d319c4","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"repo":{"id":9198603,"name":"packetfence","full_name":"julsemaan/packetfence","owner":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julsemaan/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/julsemaan/packetfence","forks_url":"https://api.github.com/repos/julsemaan/packetfence/forks","keys_url":"https://api.github.com/repos/julsemaan/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julsemaan/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julsemaan/packetfence/teams","hooks_url":"https://api.github.com/repos/julsemaan/packetfence/hooks","issue_events_url":"https://api.github.com/repos/julsemaan/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/julsemaan/packetfence/events","assignees_url":"https://api.github.com/repos/julsemaan/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/julsemaan/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/julsemaan/packetfence/tags","blobs_url":"https://api.github.com/repos/julsemaan/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julsemaan/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julsemaan/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/julsemaan/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julsemaan/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/julsemaan/packetfence/languages","stargazers_url":"https://api.github.com/repos/julsemaan/packetfence/stargazers","contributors_url":"https://api.github.com/repos/julsemaan/packetfence/contributors","subscribers_url":"https://api.github.com/repos/julsemaan/packetfence/subscribers","subscription_url":"https://api.github.com/repos/julsemaan/packetfence/subscription","commits_url":"https://api.github.com/repos/julsemaan/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/julsemaan/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/julsemaan/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/julsemaan/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/julsemaan/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/julsemaan/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julsemaan/packetfence/merges","archive_url":"https://api.github.com/repos/julsemaan/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julsemaan/packetfence/downloads","issues_url":"https://api.github.com/repos/julsemaan/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/julsemaan/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/julsemaan/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/julsemaan/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julsemaan/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/julsemaan/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/julsemaan/packetfence/deployments","created_at":"2013-04-03T15:52:51Z","updated_at":"2014-06-17T14:56:13Z","pushed_at":"2016-07-20T12:59:16Z","git_url":"git://github.com/julsemaan/packetfence.git","ssh_url":"git@github.com:julsemaan/packetfence.git","clone_url":"https://github.com/julsemaan/packetfence.git","svn_url":"https://github.com/julsemaan/packetfence","homepage":"http://www.packetfence.org","size":172274,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"78335c3d792bf4dea300d54c4a0f75420085f5d6","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence/deployments","created_at":"2012-03-01T20:21:13Z","updated_at":"2016-07-14T12:15:01Z","pushed_at":"2016-07-20T12:59:17Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"https://packetfence.org","size":189583,"stargazers_count":205,"watchers_count":205,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":246,"forks":96,"open_issues":246,"watchers":205,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1590"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/1590"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/1590"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/1590/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1590/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1590/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/ad33b8cb291963fa38cbbcf9911a9eaba2d319c4"}}}}
{"actor":{"display_login":"jrouzierinverse"}}