{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/63434294","id":63434294,"diff_hunk":"@@ -8,3 +8,10 @@ If you have implemented a custom admin, you must adapt the signature of the foll\n ## AdminExtension\n If you have implemented a custom admin extension, you must adapt the signature of the following new methods to match the one in `AdminExtensionInterface` again:\n  * `configureActionButtons`\n+\n+## Templates\n+If you extended the ``base_list.html.twig`` (or any child) template, you should replace the following attributes:","path":"UPGRADE-4.0.md","position":6,"original_position":6,"commit_id":"1c538508e81c4f09b27aa8e9ed82bcc4b44e0958","original_commit_id":"1c538508e81c4f09b27aa8e9ed82bcc4b44e0958","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"Only one backtick please.\r\n\r\nSame for lines below.","created_at":"2016-05-16T22:03:55Z","updated_at":"2016-05-16T22:03:56Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3312#discussion_r63434294","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3312","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/63434294"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3312#discussion_r63434294"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3312"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3312","id":46444177,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3312","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3312.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3312.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3312","number":3312,"state":"open","locked":false,"title":"Replace custom attributes with valid w3c attributes","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"body":"According to w3c custom attributes should start with ``data-*``","created_at":"2015-09-30T19:19:02Z","updated_at":"2016-05-16T22:03:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ceabac74e0b29f3803e7ba97307fe6800187cff","assignee":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones/6","html_url":"https://github.com/sonata-project/SonataAdminBundle/milestones/4.0","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones/6/labels","id":1742331,"number":6,"title":"4.0","description":null,"creator":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":3,"state":"open","created_at":"2016-05-02T12:47:01Z","updated_at":"2016-05-16T18:10:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3312/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3312/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3312/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/1c538508e81c4f09b27aa8e9ed82bcc4b44e0958","head":{"label":"core23:data-attributes","ref":"data-attributes","sha":"1c538508e81c4f09b27aa8e9ed82bcc4b44e0958","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"repo":{"id":34207278,"name":"SonataAdminBundle","full_name":"core23/SonataAdminBundle","owner":{"login":"core23","id":3440437,"avatar_url":"https://avatars.githubusercontent.com/u/3440437?v=3","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/core23/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/core23/SonataAdminBundle","forks_url":"https://api.github.com/repos/core23/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/core23/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/core23/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/core23/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/core23/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/core23/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/core23/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/core23/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/core23/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/core23/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/core23/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/core23/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/core23/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/core23/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/core23/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/core23/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/core23/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/core23/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/core23/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/core23/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/core23/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/core23/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/core23/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/core23/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/core23/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/core23/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/core23/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/core23/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/core23/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/core23/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/core23/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/core23/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/core23/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/core23/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/core23/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/core23/SonataAdminBundle/deployments","created_at":"2015-04-19T13:16:21Z","updated_at":"2015-04-19T13:16:23Z","pushed_at":"2016-05-16T15:53:26Z","git_url":"git://github.com/core23/SonataAdminBundle.git","ssh_url":"git@github.com:core23/SonataAdminBundle.git","clone_url":"https://github.com/core23/SonataAdminBundle.git","svn_url":"https://github.com/core23/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":17817,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"041097dab6aa373237fca1c136614a24de58fac1","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2016-05-13T20:58:48Z","pushed_at":"2016-05-16T19:35:53Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":22246,"stargazers_count":1376,"watchers_count":1376,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":974,"mirror_url":null,"open_issues_count":382,"forks":974,"open_issues":382,"watchers":1376,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3312"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3312"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3312"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3312/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3312/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3312/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/1c538508e81c4f09b27aa8e9ed82bcc4b44e0958"}}}}