{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/53811237","id":53811237,"diff_hunk":"@@ -0,0 +1,78 @@\n+\"\"\"\n+Middleware for Mobile APIs\n+\"\"\"\n+from django.conf import settings\n+from django.http import HttpResponse\n+import re\n+from mobile_api.models import MobileAppVersionConfig\n+from openedx.core.lib.mobile_utils import is_request_from_mobile_app\n+\n+\n+class AppVersionUpgrade(object):\n+    \"\"\"\n+    Middleware class to keep track of mobile application version being used\n+    \"\"\"\n+    LATEST_VERSION = \"EDX-APP-LATEST-VERSION\"\n+    UPGRADE_DEADLINE = \"EDX-APP-UPGRADE-DATE\"\n+    MOBILE_PLATFORM_USER_AGENT_REGEX = {\n+        MobileAppVersionConfig.ANDROID: (r'Dalvik/[.0-9]+ \\(Linux; U; Android [.0-9]+; '\n+                                         r'(.*) Build/[0-9a-zA-Z]*\\) (.*)/[0-9]+.[0-9]+.[0-9]+(.[0-9a-zA-Z]*)?'),\n+        MobileAppVersionConfig.IOS: (r'\\([0-9]+.[0-9]+.[0-9]+(.[0-9a-zA-Z]*)?; '\n+                                     r'OS Version [0-9.]+ \\(Build [0-9a-zA-Z]*\\)\\)'),\n+    }\n+    MOBILE_PLATFORM_VERSION = {\n+        # version is found as last entry in android user agent after \"/\"\n+        MobileAppVersionConfig.ANDROID: lambda user_agent: user_agent[user_agent.rfind(\"/\") + 1:],\n+        # version is found between first occurrence ( and ; i.e. (version;\n+        MobileAppVersionConfig.IOS: lambda user_agent: user_agent[user_agent.find(\"(\") + 1:user_agent.find(\";\")],\n+    }\n+\n+    def form_factor(self, user_agent):","path":"lms/djangoapps/mobile_api/middleware.py","position":30,"original_position":30,"commit_id":"6c835ca18767a5719fcda487dae60a119e9a1d81","original_commit_id":"6c835ca18767a5719fcda487dae60a119e9a1d81","user":{"login":"symbolist","id":5305552,"avatar_url":"https://avatars.githubusercontent.com/u/5305552?v=3","gravatar_id":"","url":"https://api.github.com/users/symbolist","html_url":"https://github.com/symbolist","followers_url":"https://api.github.com/users/symbolist/followers","following_url":"https://api.github.com/users/symbolist/following{/other_user}","gists_url":"https://api.github.com/users/symbolist/gists{/gist_id}","starred_url":"https://api.github.com/users/symbolist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symbolist/subscriptions","organizations_url":"https://api.github.com/users/symbolist/orgs","repos_url":"https://api.github.com/users/symbolist/repos","events_url":"https://api.github.com/users/symbolist/events{/privacy}","received_events_url":"https://api.github.com/users/symbolist/received_events","type":"User","site_admin":false},"body":"\"Form factor\" is generally used to describe hardware shape. `parse_version_from_user_agent()` will be a lot more descriptive.","created_at":"2016-02-23T16:57:31Z","updated_at":"2016-02-23T16:57:31Z","html_url":"https://github.com/edx/edx-platform/pull/11612#discussion_r53811237","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/11612","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/53811237"},"html":{"href":"https://github.com/edx/edx-platform/pull/11612#discussion_r53811237"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/11612"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/11612","id":60140280,"html_url":"https://github.com/edx/edx-platform/pull/11612","diff_url":"https://github.com/edx/edx-platform/pull/11612.diff","patch_url":"https://github.com/edx/edx-platform/pull/11612.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/11612","number":11612,"state":"open","locked":false,"title":"MA-1982 and MA-1991 version-based mobile app upgrade","user":{"login":"wajeeha-khalid","id":6745069,"avatar_url":"https://avatars.githubusercontent.com/u/6745069?v=3","gravatar_id":"","url":"https://api.github.com/users/wajeeha-khalid","html_url":"https://github.com/wajeeha-khalid","followers_url":"https://api.github.com/users/wajeeha-khalid/followers","following_url":"https://api.github.com/users/wajeeha-khalid/following{/other_user}","gists_url":"https://api.github.com/users/wajeeha-khalid/gists{/gist_id}","starred_url":"https://api.github.com/users/wajeeha-khalid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wajeeha-khalid/subscriptions","organizations_url":"https://api.github.com/users/wajeeha-khalid/orgs","repos_url":"https://api.github.com/users/wajeeha-khalid/repos","events_url":"https://api.github.com/users/wajeeha-khalid/events{/privacy}","received_events_url":"https://api.github.com/users/wajeeha-khalid/received_events","type":"User","site_admin":false},"body":"MA-1982 and MA-1991 version-based mobile app upgrade","created_at":"2016-02-22T08:40:08Z","updated_at":"2016-02-23T16:57:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7765972a45a17ac4ca22eee6c6be96c711d2f4c4","assignee":{"login":"wajeeha-khalid","id":6745069,"avatar_url":"https://avatars.githubusercontent.com/u/6745069?v=3","gravatar_id":"","url":"https://api.github.com/users/wajeeha-khalid","html_url":"https://github.com/wajeeha-khalid","followers_url":"https://api.github.com/users/wajeeha-khalid/followers","following_url":"https://api.github.com/users/wajeeha-khalid/following{/other_user}","gists_url":"https://api.github.com/users/wajeeha-khalid/gists{/gist_id}","starred_url":"https://api.github.com/users/wajeeha-khalid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wajeeha-khalid/subscriptions","organizations_url":"https://api.github.com/users/wajeeha-khalid/orgs","repos_url":"https://api.github.com/users/wajeeha-khalid/repos","events_url":"https://api.github.com/users/wajeeha-khalid/events{/privacy}","received_events_url":"https://api.github.com/users/wajeeha-khalid/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/11612/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/11612/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/11612/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/6c835ca18767a5719fcda487dae60a119e9a1d81","head":{"label":"edx:jia/MA-1982","ref":"jia/MA-1982","sha":"6c835ca18767a5719fcda487dae60a119e9a1d81","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-02-23T06:10:23Z","pushed_at":"2016-02-23T16:47:24Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":688634,"stargazers_count":2406,"watchers_count":2406,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1465,"mirror_url":null,"open_issues_count":163,"forks":1465,"open_issues":163,"watchers":2406,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"25919f7d576eba4c1581857fd61f84470cfeabee","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-02-23T06:10:23Z","pushed_at":"2016-02-23T16:47:24Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":688634,"stargazers_count":2406,"watchers_count":2406,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1465,"mirror_url":null,"open_issues_count":163,"forks":1465,"open_issues":163,"watchers":2406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/11612"},"html":{"href":"https://github.com/edx/edx-platform/pull/11612"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/11612"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/11612/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/11612/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/11612/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/6c835ca18767a5719fcda487dae60a119e9a1d81"}}}}