{"action":"created","issue":{"url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/55","repository_url":"https://api.github.com/repos/rtfeldman/node-test-runner","labels_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/55/comments","events_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/55/events","html_url":"https://github.com/rtfeldman/node-test-runner/pull/55","id":170958533,"number":55,"title":"Add `module` and `warn` arguments","user":{"login":"bdukes","id":59507,"avatar_url":"https://avatars.githubusercontent.com/u/59507?v=3","gravatar_id":"","url":"https://api.github.com/users/bdukes","html_url":"https://github.com/bdukes","followers_url":"https://api.github.com/users/bdukes/followers","following_url":"https://api.github.com/users/bdukes/following{/other_user}","gists_url":"https://api.github.com/users/bdukes/gists{/gist_id}","starred_url":"https://api.github.com/users/bdukes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdukes/subscriptions","organizations_url":"https://api.github.com/users/bdukes/orgs","repos_url":"https://api.github.com/users/bdukes/repos","events_url":"https://api.github.com/users/bdukes/events{/privacy}","received_events_url":"https://api.github.com/users/bdukes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-12T21:02:06Z","updated_at":"2016-08-16T04:14:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/55","html_url":"https://github.com/rtfeldman/node-test-runner/pull/55","diff_url":"https://github.com/rtfeldman/node-test-runner/pull/55.diff","patch_url":"https://github.com/rtfeldman/node-test-runner/pull/55.patch"},"body":"This updates the command line parsing to use minimist (per the recommendation on #38).  It then adds a pass-through for `--warn`, and adds the ability to pass the module name of the test module.\r\n\r\nThis fixes #54, as well as fixing #38"},"comment":{"url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/comments/239996921","html_url":"https://github.com/rtfeldman/node-test-runner/pull/55#issuecomment-239996921","issue_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/55","id":239996921,"user":{"login":"rtfeldman","id":1094080,"avatar_url":"https://avatars.githubusercontent.com/u/1094080?v=3","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T04:14:36Z","updated_at":"2016-08-16T04:14:36Z","body":"Wow, this code looks GREAT! Thank you so much @bdukes! 😻 \r\n\r\nOne API consideration: I think a nicer API than passing `--module` in is to infer the module based on the file you pass. Otherwise you'll be doing stuff like `elm-test --module Foo.Bar.Baz Foo/Bar/Baz.elm` which seems a big redundant, no?\r\n\r\nThere is [code in `node-elm-compiler`](https://github.com/rtfeldman/node-elm-compiler/blob/master/index.js#L73-L79) that reads the `module` declaration out of a `.elm` file. (I could publicly expose that logic from `node-elm-compiler` if you'd like to use it.) It adds a dependency on [`firstline`](https://github.com/rtfeldman/node-elm-compiler/blob/master/package.json#L29) for this, because `firstline` is the highest-perf way I'm aware of to read just the first line of a file, and that's where the `module` declaration has to go.\r\n\r\nThoughts?"}}
{"actor":{"display_login":"rtfeldman"}}