{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/85808025","pull_request_review_id":6501992,"id":85808025,"diff_hunk":"@@ -365,16 +230,16 @@ func (c *LogClient) GetSTH() (sth *ct.SignedTreeHead, err error) {\n // VerifySTHSignature checks the signature in sth, returning any error encountered or nil if verification is\n // successful.\n func (c *LogClient) VerifySTHSignature(sth ct.SignedTreeHead) error {\n-\tif c.verifier == nil {\n+\tif c.Verifier == nil {","path":"go/client/logclient.go","position":245,"original_position":245,"commit_id":"f3b25bb1366cc0c7c0f769f872249ecec39e84d3","original_commit_id":"e5f2f90fd8e9a2dfdb2a73e643db42dac6a7a981","user":{"login":"daviddrysdale","id":457208,"avatar_url":"https://avatars.githubusercontent.com/u/457208?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false},"body":"Yep, but we could add a forwarding method if you prefer.","created_at":"2016-10-31T18:54:14Z","updated_at":"2016-10-31T18:54:14Z","html_url":"https://github.com/google/certificate-transparency/pull/1325#discussion_r85808025","pull_request_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1325","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/85808025"},"html":{"href":"https://github.com/google/certificate-transparency/pull/1325#discussion_r85808025"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1325"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/1325","id":91609407,"html_url":"https://github.com/google/certificate-transparency/pull/1325","diff_url":"https://github.com/google/certificate-transparency/pull/1325.diff","patch_url":"https://github.com/google/certificate-transparency/pull/1325.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency/issues/1325","number":1325,"state":"open","locked":false,"title":"[RFC] Extract common code in preparation for RFC6962-bis","user":{"login":"daviddrysdale","id":457208,"avatar_url":"https://avatars.githubusercontent.com/u/457208?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false},"body":"Summary:\r\n - create a general TLS encoding/decoding library, analogous to `asn1/`\r\n - copy/move signature code into it\r\n - extract common parts of the `LogClient` into `JSONClient` (and tweak slightly) to allow re-use\r\n - convert existing v1 client code to use the extracted/generalized versions.\r\n\r\nOpinions sought on whether I should do less or more commonization:\r\n - I could commonize less; for example, I could leave the existing `client/` with its own version of `DigitallySigned` by just omitting commit\t 5e8bfae (the current change has knock-on compilation failures for anything that uses `ct.DigitallySigned`, e.g. Trillian).\r\n - I could commonize more, and work through all of the v1 `client` code to replace the hand-rolled TLS-encoding code with use of the `tls/` library. \r\n","created_at":"2016-10-31T13:34:09Z","updated_at":"2016-10-31T18:54:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35f4c69cfe99a66716fe2a5aff26077141d25e44","assignee":{"login":"taknira","id":5446167,"avatar_url":"https://avatars.githubusercontent.com/u/5446167?v=3","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"assignees":[{"login":"taknira","id":5446167,"avatar_url":"https://avatars.githubusercontent.com/u/5446167?v=3","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1325/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1325/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency/issues/1325/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/f3b25bb1366cc0c7c0f769f872249ecec39e84d3","head":{"label":"daviddrysdale:for-review","ref":"for-review","sha":"f3b25bb1366cc0c7c0f769f872249ecec39e84d3","user":{"login":"daviddrysdale","id":457208,"avatar_url":"https://avatars.githubusercontent.com/u/457208?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false},"repo":{"id":59221416,"name":"certificate-transparency","full_name":"daviddrysdale/certificate-transparency","owner":{"login":"daviddrysdale","id":457208,"avatar_url":"https://avatars.githubusercontent.com/u/457208?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daviddrysdale/certificate-transparency","description":"Auditing for TLS certificates.","fork":true,"url":"https://api.github.com/repos/daviddrysdale/certificate-transparency","forks_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/forks","keys_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/events","assignees_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/merges","archive_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/releases{/id}","deployments_url":"https://api.github.com/repos/daviddrysdale/certificate-transparency/deployments","created_at":"2016-05-19T15:57:02Z","updated_at":"2016-05-19T15:57:04Z","pushed_at":"2016-10-31T18:13:07Z","git_url":"git://github.com/daviddrysdale/certificate-transparency.git","ssh_url":"git@github.com:daviddrysdale/certificate-transparency.git","clone_url":"https://github.com/daviddrysdale/certificate-transparency.git","svn_url":"https://github.com/daviddrysdale/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":27420,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"bc5b2ec20f9b00f1b2429bb59fe104dc386b8675","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19989605,"name":"certificate-transparency","full_name":"google/certificate-transparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency","description":"Auditing for TLS certificates.","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency","forks_url":"https://api.github.com/repos/google/certificate-transparency/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency/releases{/id}","deployments_url":"https://api.github.com/repos/google/certificate-transparency/deployments","created_at":"2014-05-20T17:03:47Z","updated_at":"2016-10-26T01:11:58Z","pushed_at":"2016-10-31T18:13:08Z","git_url":"git://github.com/google/certificate-transparency.git","ssh_url":"git@github.com:google/certificate-transparency.git","clone_url":"https://github.com/google/certificate-transparency.git","svn_url":"https://github.com/google/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":29644,"stargazers_count":306,"watchers_count":306,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":95,"forks":117,"open_issues":95,"watchers":306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1325"},"html":{"href":"https://github.com/google/certificate-transparency/pull/1325"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/1325"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/1325/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1325/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1325/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency/statuses/f3b25bb1366cc0c7c0f769f872249ecec39e84d3"}}}}
{"actor":{"display_login":"daviddrysdale"}}