{"action":"created","comment":{"url":"https://api.github.com/repos/Tribler/tribler/pulls/comments/67231329","id":67231329,"diff_hunk":"@@ -761,11 +761,11 @@ def network_shutdown(self):\n \n     def save_download_pstate(self, infohash, pstate):\n         \"\"\" Called by network thread \"\"\"\n-        basename = binascii.hexlify(infohash) + '.state'\n-        filename = os.path.join(self.session.get_downloads_pstate_dir(), basename)\n \n-        self._logger.debug(\"tlm: network checkpointing: to file %s\", filename)\n-        pstate.write_file(filename)\n+        self.downloads[infohash].pstate_for_restart = pstate\n+\n+        self.register_task(\"save_pstate %d\" %len(self.downloads[infohash].deferreds_resume),","path":"Tribler/Core/APIImplementation/LaunchManyCore.py","position":11,"original_position":11,"commit_id":"e7d8392702d9169d6a4c091776221cfcd82e7ca9","original_commit_id":"e7d8392702d9169d6a4c091776221cfcd82e7ca9","user":{"login":"devos50","id":1707075,"avatar_url":"https://avatars.githubusercontent.com/u/1707075?v=3","gravatar_id":"","url":"https://api.github.com/users/devos50","html_url":"https://github.com/devos50","followers_url":"https://api.github.com/users/devos50/followers","following_url":"https://api.github.com/users/devos50/following{/other_user}","gists_url":"https://api.github.com/users/devos50/gists{/gist_id}","starred_url":"https://api.github.com/users/devos50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devos50/subscriptions","organizations_url":"https://api.github.com/users/devos50/orgs","repos_url":"https://api.github.com/users/devos50/repos","events_url":"https://api.github.com/users/devos50/events{/privacy}","received_events_url":"https://api.github.com/users/devos50/received_events","type":"User","site_admin":false},"body":"Please insert a space after the `%`.","created_at":"2016-06-15T19:41:27Z","updated_at":"2016-06-15T19:41:27Z","html_url":"https://github.com/Tribler/tribler/pull/2265#discussion_r67231329","pull_request_url":"https://api.github.com/repos/Tribler/tribler/pulls/2265","_links":{"self":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/comments/67231329"},"html":{"href":"https://github.com/Tribler/tribler/pull/2265#discussion_r67231329"},"pull_request":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/2265"}}},"pull_request":{"url":"https://api.github.com/repos/Tribler/tribler/pulls/2265","id":72902856,"html_url":"https://github.com/Tribler/tribler/pull/2265","diff_url":"https://github.com/Tribler/tribler/pull/2265.diff","patch_url":"https://github.com/Tribler/tribler/pull/2265.patch","issue_url":"https://api.github.com/repos/Tribler/tribler/issues/2265","number":2265,"state":"open","locked":false,"title":"READY: Alert for resume data","user":{"login":"ardhipoetra","id":2739025,"avatar_url":"https://avatars.githubusercontent.com/u/2739025?v=3","gravatar_id":"","url":"https://api.github.com/users/ardhipoetra","html_url":"https://github.com/ardhipoetra","followers_url":"https://api.github.com/users/ardhipoetra/followers","following_url":"https://api.github.com/users/ardhipoetra/following{/other_user}","gists_url":"https://api.github.com/users/ardhipoetra/gists{/gist_id}","starred_url":"https://api.github.com/users/ardhipoetra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ardhipoetra/subscriptions","organizations_url":"https://api.github.com/users/ardhipoetra/orgs","repos_url":"https://api.github.com/users/ardhipoetra/repos","events_url":"https://api.github.com/users/ardhipoetra/events{/privacy}","received_events_url":"https://api.github.com/users/ardhipoetra/received_events","type":"User","site_admin":false},"body":"This PR create alert for `save_resume_data`. I used `Deferred` on `resume_data`. This deferred object will call `lm.start_download` as callback (I don't find other use beside this). Resume data will be stored in `LibtorrentDownloadImpl` attribute if available.\r\n\r\nThe result is, `engineresumedata` is now available in disk-saved state. This to a certain extent, solves #2251. However, I can't get fastresume in libtorrent working, even with my own small program. So #2199 is not solved yet.","created_at":"2016-06-07T16:02:10Z","updated_at":"2016-06-15T19:41:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7541ceefb50a63cbcfa5d844abb501a44c103c59","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Tribler/tribler/pulls/2265/commits","review_comments_url":"https://api.github.com/repos/Tribler/tribler/pulls/2265/comments","review_comment_url":"https://api.github.com/repos/Tribler/tribler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tribler/tribler/issues/2265/comments","statuses_url":"https://api.github.com/repos/Tribler/tribler/statuses/e7d8392702d9169d6a4c091776221cfcd82e7ca9","head":{"label":"ardhipoetra:patch_resume_data","ref":"patch_resume_data","sha":"e7d8392702d9169d6a4c091776221cfcd82e7ca9","user":{"login":"ardhipoetra","id":2739025,"avatar_url":"https://avatars.githubusercontent.com/u/2739025?v=3","gravatar_id":"","url":"https://api.github.com/users/ardhipoetra","html_url":"https://github.com/ardhipoetra","followers_url":"https://api.github.com/users/ardhipoetra/followers","following_url":"https://api.github.com/users/ardhipoetra/following{/other_user}","gists_url":"https://api.github.com/users/ardhipoetra/gists{/gist_id}","starred_url":"https://api.github.com/users/ardhipoetra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ardhipoetra/subscriptions","organizations_url":"https://api.github.com/users/ardhipoetra/orgs","repos_url":"https://api.github.com/users/ardhipoetra/repos","events_url":"https://api.github.com/users/ardhipoetra/events{/privacy}","received_events_url":"https://api.github.com/users/ardhipoetra/received_events","type":"User","site_admin":false},"repo":{"id":47112361,"name":"tribler","full_name":"ardhipoetra/tribler","owner":{"login":"ardhipoetra","id":2739025,"avatar_url":"https://avatars.githubusercontent.com/u/2739025?v=3","gravatar_id":"","url":"https://api.github.com/users/ardhipoetra","html_url":"https://github.com/ardhipoetra","followers_url":"https://api.github.com/users/ardhipoetra/followers","following_url":"https://api.github.com/users/ardhipoetra/following{/other_user}","gists_url":"https://api.github.com/users/ardhipoetra/gists{/gist_id}","starred_url":"https://api.github.com/users/ardhipoetra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ardhipoetra/subscriptions","organizations_url":"https://api.github.com/users/ardhipoetra/orgs","repos_url":"https://api.github.com/users/ardhipoetra/repos","events_url":"https://api.github.com/users/ardhipoetra/events{/privacy}","received_events_url":"https://api.github.com/users/ardhipoetra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ardhipoetra/tribler","description":"Privacy with BitTorrent and resilient to shut down","fork":true,"url":"https://api.github.com/repos/ardhipoetra/tribler","forks_url":"https://api.github.com/repos/ardhipoetra/tribler/forks","keys_url":"https://api.github.com/repos/ardhipoetra/tribler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ardhipoetra/tribler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ardhipoetra/tribler/teams","hooks_url":"https://api.github.com/repos/ardhipoetra/tribler/hooks","issue_events_url":"https://api.github.com/repos/ardhipoetra/tribler/issues/events{/number}","events_url":"https://api.github.com/repos/ardhipoetra/tribler/events","assignees_url":"https://api.github.com/repos/ardhipoetra/tribler/assignees{/user}","branches_url":"https://api.github.com/repos/ardhipoetra/tribler/branches{/branch}","tags_url":"https://api.github.com/repos/ardhipoetra/tribler/tags","blobs_url":"https://api.github.com/repos/ardhipoetra/tribler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ardhipoetra/tribler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ardhipoetra/tribler/git/refs{/sha}","trees_url":"https://api.github.com/repos/ardhipoetra/tribler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ardhipoetra/tribler/statuses/{sha}","languages_url":"https://api.github.com/repos/ardhipoetra/tribler/languages","stargazers_url":"https://api.github.com/repos/ardhipoetra/tribler/stargazers","contributors_url":"https://api.github.com/repos/ardhipoetra/tribler/contributors","subscribers_url":"https://api.github.com/repos/ardhipoetra/tribler/subscribers","subscription_url":"https://api.github.com/repos/ardhipoetra/tribler/subscription","commits_url":"https://api.github.com/repos/ardhipoetra/tribler/commits{/sha}","git_commits_url":"https://api.github.com/repos/ardhipoetra/tribler/git/commits{/sha}","comments_url":"https://api.github.com/repos/ardhipoetra/tribler/comments{/number}","issue_comment_url":"https://api.github.com/repos/ardhipoetra/tribler/issues/comments{/number}","contents_url":"https://api.github.com/repos/ardhipoetra/tribler/contents/{+path}","compare_url":"https://api.github.com/repos/ardhipoetra/tribler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ardhipoetra/tribler/merges","archive_url":"https://api.github.com/repos/ardhipoetra/tribler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ardhipoetra/tribler/downloads","issues_url":"https://api.github.com/repos/ardhipoetra/tribler/issues{/number}","pulls_url":"https://api.github.com/repos/ardhipoetra/tribler/pulls{/number}","milestones_url":"https://api.github.com/repos/ardhipoetra/tribler/milestones{/number}","notifications_url":"https://api.github.com/repos/ardhipoetra/tribler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ardhipoetra/tribler/labels{/name}","releases_url":"https://api.github.com/repos/ardhipoetra/tribler/releases{/id}","deployments_url":"https://api.github.com/repos/ardhipoetra/tribler/deployments","created_at":"2015-11-30T10:47:06Z","updated_at":"2016-01-26T15:20:10Z","pushed_at":"2016-06-15T19:27:45Z","git_url":"git://github.com/ardhipoetra/tribler.git","ssh_url":"git@github.com:ardhipoetra/tribler.git","clone_url":"https://github.com/ardhipoetra/tribler.git","svn_url":"https://github.com/ardhipoetra/tribler","homepage":"http://www.tribler.org","size":114596,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"Tribler:devel","ref":"devel","sha":"c7204c47de55a6c15445c056423800fe796d32a1","user":{"login":"Tribler","id":2913489,"avatar_url":"https://avatars.githubusercontent.com/u/2913489?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"repo":{"id":8411137,"name":"tribler","full_name":"Tribler/tribler","owner":{"login":"Tribler","id":2913489,"avatar_url":"https://avatars.githubusercontent.com/u/2913489?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tribler/tribler","description":"Privacy enhanced BitTorrent client with P2P content discovery","fork":false,"url":"https://api.github.com/repos/Tribler/tribler","forks_url":"https://api.github.com/repos/Tribler/tribler/forks","keys_url":"https://api.github.com/repos/Tribler/tribler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tribler/tribler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tribler/tribler/teams","hooks_url":"https://api.github.com/repos/Tribler/tribler/hooks","issue_events_url":"https://api.github.com/repos/Tribler/tribler/issues/events{/number}","events_url":"https://api.github.com/repos/Tribler/tribler/events","assignees_url":"https://api.github.com/repos/Tribler/tribler/assignees{/user}","branches_url":"https://api.github.com/repos/Tribler/tribler/branches{/branch}","tags_url":"https://api.github.com/repos/Tribler/tribler/tags","blobs_url":"https://api.github.com/repos/Tribler/tribler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tribler/tribler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tribler/tribler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tribler/tribler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tribler/tribler/statuses/{sha}","languages_url":"https://api.github.com/repos/Tribler/tribler/languages","stargazers_url":"https://api.github.com/repos/Tribler/tribler/stargazers","contributors_url":"https://api.github.com/repos/Tribler/tribler/contributors","subscribers_url":"https://api.github.com/repos/Tribler/tribler/subscribers","subscription_url":"https://api.github.com/repos/Tribler/tribler/subscription","commits_url":"https://api.github.com/repos/Tribler/tribler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tribler/tribler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tribler/tribler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tribler/tribler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tribler/tribler/contents/{+path}","compare_url":"https://api.github.com/repos/Tribler/tribler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tribler/tribler/merges","archive_url":"https://api.github.com/repos/Tribler/tribler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tribler/tribler/downloads","issues_url":"https://api.github.com/repos/Tribler/tribler/issues{/number}","pulls_url":"https://api.github.com/repos/Tribler/tribler/pulls{/number}","milestones_url":"https://api.github.com/repos/Tribler/tribler/milestones{/number}","notifications_url":"https://api.github.com/repos/Tribler/tribler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tribler/tribler/labels{/name}","releases_url":"https://api.github.com/repos/Tribler/tribler/releases{/id}","deployments_url":"https://api.github.com/repos/Tribler/tribler/deployments","created_at":"2013-02-25T14:51:58Z","updated_at":"2016-06-13T19:04:18Z","pushed_at":"2016-06-15T19:27:46Z","git_url":"git://github.com/Tribler/tribler.git","ssh_url":"git@github.com:Tribler/tribler.git","clone_url":"https://github.com/Tribler/tribler.git","svn_url":"https://github.com/Tribler/tribler","homepage":"http://www.tribler.org","size":132914,"stargazers_count":1884,"watchers_count":1884,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":292,"forks":202,"open_issues":292,"watchers":1884,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/2265"},"html":{"href":"https://github.com/Tribler/tribler/pull/2265"},"issue":{"href":"https://api.github.com/repos/Tribler/tribler/issues/2265"},"comments":{"href":"https://api.github.com/repos/Tribler/tribler/issues/2265/comments"},"review_comments":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/2265/comments"},"review_comment":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/2265/commits"},"statuses":{"href":"https://api.github.com/repos/Tribler/tribler/statuses/e7d8392702d9169d6a4c091776221cfcd82e7ca9"}}}}
{"actor":{"display_login":"devos50"}}