{"action":"created","issue":{"url":"https://api.github.com/repos/h2o/h2o/issues/1022","repository_url":"https://api.github.com/repos/h2o/h2o","labels_url":"https://api.github.com/repos/h2o/h2o/issues/1022/labels{/name}","comments_url":"https://api.github.com/repos/h2o/h2o/issues/1022/comments","events_url":"https://api.github.com/repos/h2o/h2o/issues/1022/events","html_url":"https://github.com/h2o/h2o/pull/1022","id":170783434,"number":1022,"title":"add include config feature","user":{"login":"i110","id":969287,"avatar_url":"https://avatars.githubusercontent.com/u/969287?v=3","gravatar_id":"","url":"https://api.github.com/users/i110","html_url":"https://github.com/i110","followers_url":"https://api.github.com/users/i110/followers","following_url":"https://api.github.com/users/i110/following{/other_user}","gists_url":"https://api.github.com/users/i110/gists{/gist_id}","starred_url":"https://api.github.com/users/i110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i110/subscriptions","organizations_url":"https://api.github.com/users/i110/orgs","repos_url":"https://api.github.com/users/i110/repos","events_url":"https://api.github.com/users/i110/events{/privacy}","received_events_url":"https://api.github.com/users/i110/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-12T01:38:36Z","updated_at":"2016-08-12T03:15:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/h2o/h2o/pulls/1022","html_url":"https://github.com/h2o/h2o/pull/1022","diff_url":"https://github.com/h2o/h2o/pull/1022.diff","patch_url":"https://github.com/h2o/h2o/pull/1022.patch"},"body":"This add the feature that enables including configuration in other files.\r\n\r\nExample (from https://h2o.examp1e.net/configure/syntax_and_structure.html)\r\n\r\nssl.conf\r\n```yaml\r\nminimum-version: TLSv1.2\r\ncipher-suite: ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256\r\ncertificate-file: /path/to/example.com.crt\r\nkey-file:         /path/to/example.com.crt\r\n```\r\n\r\nh2o.conf\r\n```yaml\r\nhosts:\r\n  \"example.com\":\r\n    listen:\r\n      port: 443\r\n      ssl:\r\n        include: ssl.conf\r\n    paths:\r\n      ...\r\n  \"example.org\":\r\n    listen:\r\n      port: 443\r\n      ssl:\r\n        include: ssl.conf\r\n        certificate-file: /path/to/example.org.crt\r\n        key-file:         /path/to/example.org.crt\r\n    paths:\r\n      ...\r\n```\r\n\r\nAlso nested inclusion is supported.\r\n\r\nAnd I can also support directory inclusion ( `include: conf.d` ) and wildcard matching ( `include conf/*.conf` ) like Apache, but not yet implemented.\r\nWDYT?"},"comment":{"url":"https://api.github.com/repos/h2o/h2o/issues/comments/239351952","html_url":"https://github.com/h2o/h2o/pull/1022#issuecomment-239351952","issue_url":"https://api.github.com/repos/h2o/h2o/issues/1022","id":239351952,"user":{"login":"kazuho","id":41567,"avatar_url":"https://avatars.githubusercontent.com/u/41567?v=3","gravatar_id":"","url":"https://api.github.com/users/kazuho","html_url":"https://github.com/kazuho","followers_url":"https://api.github.com/users/kazuho/followers","following_url":"https://api.github.com/users/kazuho/following{/other_user}","gists_url":"https://api.github.com/users/kazuho/gists{/gist_id}","starred_url":"https://api.github.com/users/kazuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazuho/subscriptions","organizations_url":"https://api.github.com/users/kazuho/orgs","repos_url":"https://api.github.com/users/kazuho/repos","events_url":"https://api.github.com/users/kazuho/events{/privacy}","received_events_url":"https://api.github.com/users/kazuho/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T03:15:39Z","updated_at":"2016-08-12T03:15:39Z","body":"You cannot move calls to libyaml from `src/main.c` to `lib/core/configurator.c`, since libh2o does not depend on libyaml (and that is why the CI failed).\r\n\r\nYou should continue calling libyaml and also resolve the includes in `src/main.c`, then pass the YOML tree to `h2o_configurator_apply`."}}
{"actor":{"display_login":"kazuho"}}