{"action":"reopened","number":9549,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9549","id":63929654,"html_url":"https://github.com/joomla/joomla-cms/pull/9549","diff_url":"https://github.com/joomla/joomla-cms/pull/9549.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9549.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9549","number":9549,"state":"open","locked":false,"title":"Correct utf8mb4 conversion 2016 03 23","user":{"login":"richard67","id":7413183,"avatar_url":"https://avatars.githubusercontent.com/u/7413183?v=3","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"body":"Pull Request for Issues #9509 and #9526 .\r\n\r\nReplaced and extends PR #9510 .\r\n\r\n#### Summary of Changes\r\n\r\nThis PR handles 3 things:\r\n1. Add missing column and index changes as reported in issue #9509 to utf8mb4 conversion scripts so after update these columns and indexes are same as they are after new installation.\r\n2. Change column user_id ot table user_keys to length of 150 for new installation and update so it fits to column username of table users.\r\n3. Change order of processing in the 2nd conversion script so adding back the indexes takes place after all conversions and default character set and collation changes. \r\n\r\nThe changes mentioned with point 1 are:\r\n- Changed column length of column `name` in table `#__users` to 400.\r\n- Changed follwoing indexes (keys) to include column only with 1st 100 chars:\r\n - TABLE `#__menu`, KEY `idx_path`\r\n - TABLE `#__users`, KEY `idx_name`\r\n\r\nColumn `path` of table `#__menu` has already 1024 and was not enlarged in 3.5.0's joomla.sql, and so it is also not enlarged with this PR.\r\n\r\nNote: This PR does not solve the problem that the utf8mb4 or utf8 combersion has to be executed again after an update e.g. from 3.5.0 to the 3.5.x in which this PR will be included. This can be manually done by the SQL statement provided in testing instructions below.\r\n\r\n#### Testing Instructions\r\n\r\nWill follow soon.","created_at":"2016-03-23T18:22:43Z","updated_at":"2016-03-23T18:26:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63f91caded02dcb9138ac3bd3faddc77c213294b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9549/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9549/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9549/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/376327fce5acd0c60bb275a8dca0bee698e766fd","head":{"label":"richard67:correct-utf8mb4-conversion-2016-03-23","ref":"correct-utf8mb4-conversion-2016-03-23","sha":"376327fce5acd0c60bb275a8dca0bee698e766fd","user":{"login":"richard67","id":7413183,"avatar_url":"https://avatars.githubusercontent.com/u/7413183?v=3","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"repo":{"id":27455477,"name":"joomla-cms","full_name":"richard67/joomla-cms","owner":{"login":"richard67","id":7413183,"avatar_url":"https://avatars.githubusercontent.com/u/7413183?v=3","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richard67/joomla-cms","description":"Fork of the Joomla! CMS","fork":true,"url":"https://api.github.com/repos/richard67/joomla-cms","forks_url":"https://api.github.com/repos/richard67/joomla-cms/forks","keys_url":"https://api.github.com/repos/richard67/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richard67/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richard67/joomla-cms/teams","hooks_url":"https://api.github.com/repos/richard67/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/richard67/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/richard67/joomla-cms/events","assignees_url":"https://api.github.com/repos/richard67/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/richard67/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/richard67/joomla-cms/tags","blobs_url":"https://api.github.com/repos/richard67/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richard67/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richard67/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/richard67/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richard67/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/richard67/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/richard67/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/richard67/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/richard67/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/richard67/joomla-cms/subscription","commits_url":"https://api.github.com/repos/richard67/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/richard67/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/richard67/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/richard67/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/richard67/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/richard67/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richard67/joomla-cms/merges","archive_url":"https://api.github.com/repos/richard67/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richard67/joomla-cms/downloads","issues_url":"https://api.github.com/repos/richard67/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/richard67/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/richard67/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/richard67/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richard67/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/richard67/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/richard67/joomla-cms/deployments","created_at":"2014-12-02T21:54:34Z","updated_at":"2016-01-19T12:17:29Z","pushed_at":"2016-03-23T18:08:36Z","git_url":"git://github.com/richard67/joomla-cms.git","ssh_url":"git@github.com:richard67/joomla-cms.git","clone_url":"https://github.com/richard67/joomla-cms.git","svn_url":"https://github.com/richard67/joomla-cms","homepage":"http://joomla.org","size":142583,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"393289905083facda51799e89e7a11cdabb1aa31","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-03-23T17:34:23Z","pushed_at":"2016-03-23T18:22:43Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":268763,"stargazers_count":1923,"watchers_count":1923,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2111,"mirror_url":null,"open_issues_count":633,"forks":2111,"open_issues":633,"watchers":1923,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9549"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/9549"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/9549"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/9549/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9549/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9549/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/376327fce5acd0c60bb275a8dca0bee698e766fd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":3,"additions":50,"deletions":31,"changed_files":5}}