{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-meta/pulls/comments/87892195","pull_request_review_id":8485125,"id":87892195,"diff_hunk":"@@ -28,42 +29,237 @@ function collectGraphicsRenderer() {\n }\n \n function collectBoardInfo() {\n-    let table = { 'System vendor': '/sys/devices/virtual/dmi/id/sys_vendor',\n-\t\t  'Product name': '/sys/devices/virtual/dmi/id/product_name',\n-\t\t  'Product serial': '/sys/devices/virtual/dmi/id/product_uuid',\n-\t\t  'Product version': '/sys/devices/virtual/dmi/id/product_version',\n-\t\t  'Board vendor': '/sys/devices/virtual/dmi/id/board_vendor',\n-\t\t  'Board name': '/sys/devices/virtual/dmi/id/board_name',\n-\t\t  'Board version': '/sys/devices/virtual/dmi/id/board_version',\n-\t\t  'BIOS vendor': '/sys/devices/virtual/dmi/id/bios_vendor',\n-\t\t  'BIOS version': '/sys/devices/virtual/dmi/id/bios_version',\n-\t\t  'BIOS date': '/sys/devices/virtual/dmi/id/bios_date' };\n-\n+    let dmi_info = [ 'sys_vendor', 'product_name', 'product_serial',\n+\t             'product_uuid', 'product_version', 'board_asset_tag',\n+\t             'board_name', 'board_serial', 'board_vendor',\n+\t             'board_version', 'bios_date', 'bios_vendor',\n+\t             'bios_version', 'chassis_asset_tag', 'chassis_serial',\n+\t             'chassis_type', 'chassis_vendor', 'chassis_version' ];\n     let output = '';\n-    let names = Object.keys(table);\n-    names.forEach(function(name) {\n-\tlet file = table[name];\n-\toutput += name;\n-\toutput += ': ';\n+    dmi_info.forEach(function(name) {\n+\tlet file = '/sys/devices/virtual/dmi/id/' + name;\n \n \ttry {\n \t    let [res, contents] = GLib.file_get_contents(file);\n-\t    output += contents;\n+\t    output += name + ': ' + contents;\n \t} catch (e) {\n-\t    if (name == 'Product name') {\n-\t        try {\n-\t\t    file = '/proc/device-tree/compatible';\n-\t\t    let [res, contents] = GLib.file_get_contents(file);\n-\t\t    output += contents + '\\n';\n-\t\t} catch (e) {\n-\t\t    output += 'not available\\n';\n-\t\t}\n-\t    } else {\n-\t        output += 'not available\\n';\n-\t    }\n \t}\n     });\n \n+    try {\n+\tlet [res, contents] = GLib.file_get_contents('/proc/device-tree/compatible');\n+\toutput += 'compatible: ' + contents;\n+    } catch (e) { }\n+\n+    return output;\n+}\n+\n+function collectMmcDevice(dir, level) {\n+    let fileEnum;\n+    let output = '';\n+    let attrs = ['cid', 'manfid', 'oemid', 'name', 'prv', 'serial', 'date',\n+\t         'hwrev', 'fwrev', 'csd', 'scr', 'vendor', 'device'];\n+    let prefix = ' '.repeat(level)\n+    let path = dir.get_path()","path":"eos-tech-support/eos-diagnostics","position":80,"original_position":80,"commit_id":"1b417774dd46ff4f48be75efbc9e2979495379cd","original_commit_id":"1b417774dd46ff4f48be75efbc9e2979495379cd","user":{"login":"cosimoc","id":13906,"avatar_url":"https://avatars.githubusercontent.com/u/13906?v=3","gravatar_id":"","url":"https://api.github.com/users/cosimoc","html_url":"https://github.com/cosimoc","followers_url":"https://api.github.com/users/cosimoc/followers","following_url":"https://api.github.com/users/cosimoc/following{/other_user}","gists_url":"https://api.github.com/users/cosimoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cosimoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosimoc/subscriptions","organizations_url":"https://api.github.com/users/cosimoc/orgs","repos_url":"https://api.github.com/users/cosimoc/repos","events_url":"https://api.github.com/users/cosimoc/events{/privacy}","received_events_url":"https://api.github.com/users/cosimoc/received_events","type":"User","site_admin":false},"body":"Missing semicolon","created_at":"2016-11-14T21:04:08Z","updated_at":"2016-11-14T21:04:08Z","html_url":"https://github.com/endlessm/eos-meta/pull/343#discussion_r87892195","pull_request_url":"https://api.github.com/repos/endlessm/eos-meta/pulls/343","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-meta/pulls/comments/87892195"},"html":{"href":"https://github.com/endlessm/eos-meta/pull/343#discussion_r87892195"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-meta/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-meta/pulls/343","id":93610535,"html_url":"https://github.com/endlessm/eos-meta/pull/343","diff_url":"https://github.com/endlessm/eos-meta/pull/343.diff","patch_url":"https://github.com/endlessm/eos-meta/pull/343.patch","issue_url":"https://api.github.com/repos/endlessm/eos-meta/issues/343","number":343,"state":"open","locked":false,"title":"eos-diagnostics: Add hardware info dump mode","user":{"login":"dsd","id":81864,"avatar_url":"https://avatars.githubusercontent.com/u/81864?v=3","gravatar_id":"","url":"https://api.github.com/users/dsd","html_url":"https://github.com/dsd","followers_url":"https://api.github.com/users/dsd/followers","following_url":"https://api.github.com/users/dsd/following{/other_user}","gists_url":"https://api.github.com/users/dsd/gists{/gist_id}","starred_url":"https://api.github.com/users/dsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsd/subscriptions","organizations_url":"https://api.github.com/users/dsd/orgs","repos_url":"https://api.github.com/users/dsd/repos","events_url":"https://api.github.com/users/dsd/events{/privacy}","received_events_url":"https://api.github.com/users/dsd/received_events","type":"User","site_admin":false},"body":"We currently collect hardware info manually and populate wiki pages for each supported product.\r\n\r\nWith the increased number of 3rd party products, we need something more scalable and we need an easy way of receiving this info from 3rd parties.\r\n\r\nAdd a new mode to eos-diagnostics which only outputs information relevant to hardware enablement efforts, and output in a more organised format (1 file per information item, in a tar archive). This also organises the information a bit better in the standard mode and adds more information to the dumps.\r\nhttps://phabricator.endlessm.com/T14154","created_at":"2016-11-14T17:29:27Z","updated_at":"2016-11-14T21:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed0c6534ca6436bb495ca676468a25d5d03f8cd9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-meta/pulls/343/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-meta/pulls/343/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-meta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-meta/issues/343/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-meta/statuses/1b417774dd46ff4f48be75efbc9e2979495379cd","head":{"label":"endlessm:T14154","ref":"T14154","sha":"1b417774dd46ff4f48be75efbc9e2979495379cd","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":13453106,"name":"eos-meta","full_name":"endlessm/eos-meta","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-meta","description":"Repository for keeping track of changes to the main meta-package for OBS","fork":false,"url":"https://api.github.com/repos/endlessm/eos-meta","forks_url":"https://api.github.com/repos/endlessm/eos-meta/forks","keys_url":"https://api.github.com/repos/endlessm/eos-meta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-meta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-meta/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-meta/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-meta/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-meta/events","assignees_url":"https://api.github.com/repos/endlessm/eos-meta/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-meta/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-meta/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-meta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-meta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-meta/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-meta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-meta/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-meta/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-meta/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-meta/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-meta/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-meta/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-meta/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-meta/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-meta/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-meta/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-meta/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-meta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-meta/merges","archive_url":"https://api.github.com/repos/endlessm/eos-meta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-meta/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-meta/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-meta/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-meta/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-meta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-meta/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-meta/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-meta/deployments","created_at":"2013-10-09T20:19:08Z","updated_at":"2016-10-24T17:02:02Z","pushed_at":"2016-11-14T20:38:58Z","git_url":"git://github.com/endlessm/eos-meta.git","ssh_url":"git@github.com:endlessm/eos-meta.git","clone_url":"https://github.com/endlessm/eos-meta.git","svn_url":"https://github.com/endlessm/eos-meta","homepage":null,"size":4605,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"b7de8f059cfa0c05acdce3def90039d09810f277","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":13453106,"name":"eos-meta","full_name":"endlessm/eos-meta","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-meta","description":"Repository for keeping track of changes to the main meta-package for OBS","fork":false,"url":"https://api.github.com/repos/endlessm/eos-meta","forks_url":"https://api.github.com/repos/endlessm/eos-meta/forks","keys_url":"https://api.github.com/repos/endlessm/eos-meta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-meta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-meta/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-meta/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-meta/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-meta/events","assignees_url":"https://api.github.com/repos/endlessm/eos-meta/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-meta/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-meta/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-meta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-meta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-meta/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-meta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-meta/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-meta/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-meta/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-meta/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-meta/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-meta/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-meta/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-meta/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-meta/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-meta/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-meta/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-meta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-meta/merges","archive_url":"https://api.github.com/repos/endlessm/eos-meta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-meta/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-meta/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-meta/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-meta/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-meta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-meta/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-meta/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-meta/deployments","created_at":"2013-10-09T20:19:08Z","updated_at":"2016-10-24T17:02:02Z","pushed_at":"2016-11-14T20:38:58Z","git_url":"git://github.com/endlessm/eos-meta.git","ssh_url":"git@github.com:endlessm/eos-meta.git","clone_url":"https://github.com/endlessm/eos-meta.git","svn_url":"https://github.com/endlessm/eos-meta","homepage":null,"size":4605,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-meta/pulls/343"},"html":{"href":"https://github.com/endlessm/eos-meta/pull/343"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-meta/issues/343"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-meta/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-meta/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-meta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-meta/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-meta/statuses/1b417774dd46ff4f48be75efbc9e2979495379cd"}}}}
{"actor":{"display_login":"cosimoc"}}