{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/comments/89030269","pull_request_review_id":9582825,"id":89030269,"diff_hunk":"@@ -34,9 +34,9 @@ pub fn main() -> Result<()> {\n \n     // Build command args now while we know whether or not to skip arg 1.\n     let cmd_args: Vec<_> = if toolchain.is_none() {\n-        env::args_os().collect()\n+        env::args_os().skip(1).collect()\n     } else {\n-        env::args_os().take(1).chain(env::args_os().skip(2)).collect()\n+        env::args_os().skip(2).collect()","path":"src/rustup-cli/proxy_mode.rs","position":8,"original_position":8,"commit_id":"bb64297038023d1b32086a0293bca9956f1cc231","original_commit_id":"bb64297038023d1b32086a0293bca9956f1cc231","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"body":"These were incidental changes to improve error reporting in the proxies.","created_at":"2016-11-22T01:58:39Z","updated_at":"2016-11-22T01:58:39Z","html_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/812#discussion_r89030269","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/812","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/comments/89030269"},"html":{"href":"https://github.com/rust-lang-nursery/rustup.rs/pull/812#discussion_r89030269"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/812"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/812","id":93696536,"html_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/812","diff_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/812.diff","patch_url":"https://github.com/rust-lang-nursery/rustup.rs/pull/812.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/812","number":812,"state":"open","locked":false,"title":"Recursive tool invocations should invoke the proxy, not the tool dire…","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"body":"…ctly\r\n\r\nThe way the proxy was setting up the PATH variable contained two bugs:\r\nfirst, that it allowed the toolchain path to precede the value of CARGO_HOME/bin;\r\nbut second that it didn't add CARGO_HOME/bin to the path at all. The result\r\nwas that when e.g. cargo execs rustc, it was directly execing the toolchain\r\nrustc.\r\n\r\nNow it execs the proxy, assuming that CARGO_HOME/bin is set up correctly,\r\nand guaranteeing not to run the toolchain tool directly.\r\n\r\nFixes #809\r\n\r\nr? @Diggsey cc @japaric @michaelwoerister","created_at":"2016-11-15T03:48:10Z","updated_at":"2016-11-22T01:58:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03942c9a3770b55ec498418da4ac1c5cd4bf5bd5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/812/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/812/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/812/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/statuses/bb64297038023d1b32086a0293bca9956f1cc231","head":{"label":"brson:proxy-fix","ref":"proxy-fix","sha":"bb64297038023d1b32086a0293bca9956f1cc231","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"repo":{"id":53914590,"name":"rustup.rs","full_name":"brson/rustup.rs","owner":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brson/rustup.rs","description":"Multirust in rust!","fork":true,"url":"https://api.github.com/repos/brson/rustup.rs","forks_url":"https://api.github.com/repos/brson/rustup.rs/forks","keys_url":"https://api.github.com/repos/brson/rustup.rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brson/rustup.rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brson/rustup.rs/teams","hooks_url":"https://api.github.com/repos/brson/rustup.rs/hooks","issue_events_url":"https://api.github.com/repos/brson/rustup.rs/issues/events{/number}","events_url":"https://api.github.com/repos/brson/rustup.rs/events","assignees_url":"https://api.github.com/repos/brson/rustup.rs/assignees{/user}","branches_url":"https://api.github.com/repos/brson/rustup.rs/branches{/branch}","tags_url":"https://api.github.com/repos/brson/rustup.rs/tags","blobs_url":"https://api.github.com/repos/brson/rustup.rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brson/rustup.rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brson/rustup.rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/brson/rustup.rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brson/rustup.rs/statuses/{sha}","languages_url":"https://api.github.com/repos/brson/rustup.rs/languages","stargazers_url":"https://api.github.com/repos/brson/rustup.rs/stargazers","contributors_url":"https://api.github.com/repos/brson/rustup.rs/contributors","subscribers_url":"https://api.github.com/repos/brson/rustup.rs/subscribers","subscription_url":"https://api.github.com/repos/brson/rustup.rs/subscription","commits_url":"https://api.github.com/repos/brson/rustup.rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/brson/rustup.rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/brson/rustup.rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/brson/rustup.rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/brson/rustup.rs/contents/{+path}","compare_url":"https://api.github.com/repos/brson/rustup.rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brson/rustup.rs/merges","archive_url":"https://api.github.com/repos/brson/rustup.rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brson/rustup.rs/downloads","issues_url":"https://api.github.com/repos/brson/rustup.rs/issues{/number}","pulls_url":"https://api.github.com/repos/brson/rustup.rs/pulls{/number}","milestones_url":"https://api.github.com/repos/brson/rustup.rs/milestones{/number}","notifications_url":"https://api.github.com/repos/brson/rustup.rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brson/rustup.rs/labels{/name}","releases_url":"https://api.github.com/repos/brson/rustup.rs/releases{/id}","deployments_url":"https://api.github.com/repos/brson/rustup.rs/deployments","created_at":"2016-03-15T04:28:17Z","updated_at":"2016-04-14T00:13:45Z","pushed_at":"2016-11-22T01:52:28Z","git_url":"git://github.com/brson/rustup.rs.git","ssh_url":"git@github.com:brson/rustup.rs.git","clone_url":"https://github.com/brson/rustup.rs.git","svn_url":"https://github.com/brson/rustup.rs","homepage":null,"size":2623,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"a6db7a36492e8f9f179f5be450b27c229b4f912e","user":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars.githubusercontent.com/u/14631425?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":43192623,"name":"rustup.rs","full_name":"rust-lang-nursery/rustup.rs","owner":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars.githubusercontent.com/u/14631425?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/rustup.rs","description":"The Rust toolchain installer","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs","forks_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/deployments","created_at":"2015-09-26T04:54:49Z","updated_at":"2016-11-21T15:57:19Z","pushed_at":"2016-11-22T01:52:29Z","git_url":"git://github.com/rust-lang-nursery/rustup.rs.git","ssh_url":"git@github.com:rust-lang-nursery/rustup.rs.git","clone_url":"https://github.com/rust-lang-nursery/rustup.rs.git","svn_url":"https://github.com/rust-lang-nursery/rustup.rs","homepage":"","size":9085,"stargazers_count":783,"watchers_count":783,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":215,"forks":90,"open_issues":215,"watchers":783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/812"},"html":{"href":"https://github.com/rust-lang-nursery/rustup.rs/pull/812"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/812"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/issues/812/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/812/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/pulls/812/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/rustup.rs/statuses/bb64297038023d1b32086a0293bca9956f1cc231"}}}}
{"actor":{"display_login":"brson"}}