{"action":"created","comment":{"url":"https://api.github.com/repos/l20n/l20n.js/pulls/comments/87176356","pull_request_review_id":7797644,"id":87176356,"diff_hunk":"@@ -8,12 +8,12 @@ Components.utils.import('resource://gre/modules/L10nRegistry.jsm');\n Components.utils.import('resource://gre/modules/IntlMessageContext.jsm');\n \n const functions = {\n-  OS: function() {\n+  PLATFORM: function() {\n     switch (Services.appinfo.OS) {\n       case 'WINNT':\n-        return 'win';\n+        return 'windows';\n       case 'Linux':\n-        return 'lin';\n+        return 'linux';\n       case 'Darwin':\n         return 'mac';","path":"src/runtime/gecko/l20n-chrome-xbl.js","position":14,"original_position":14,"commit_id":"73c26a34fbd1777772e9cad995044f8029f91e9c","original_commit_id":"73c26a34fbd1777772e9cad995044f8029f91e9c","user":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"body":"Thanks for using long names for Windows and Linux.  Do you think `macos` would fit better here as well?","created_at":"2016-11-09T11:37:03Z","updated_at":"2016-11-09T11:49:17Z","html_url":"https://github.com/l20n/l20n.js/pull/167#discussion_r87176356","pull_request_url":"https://api.github.com/repos/l20n/l20n.js/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/l20n/l20n.js/pulls/comments/87176356"},"html":{"href":"https://github.com/l20n/l20n.js/pull/167#discussion_r87176356"},"pull_request":{"href":"https://api.github.com/repos/l20n/l20n.js/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/l20n/l20n.js/pulls/167","id":92891277,"html_url":"https://github.com/l20n/l20n.js/pull/167","diff_url":"https://github.com/l20n/l20n.js/pull/167.diff","patch_url":"https://github.com/l20n/l20n.js/pull/167.patch","issue_url":"https://api.github.com/repos/l20n/l20n.js/issues/167","number":167,"state":"open","locked":false,"title":"Rename OS bultin to PLATFORM","user":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-09T01:18:00Z","updated_at":"2016-11-09T11:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a2844209674660e3b90aa9f636d3db3db548fa6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/l20n/l20n.js/pulls/167/commits","review_comments_url":"https://api.github.com/repos/l20n/l20n.js/pulls/167/comments","review_comment_url":"https://api.github.com/repos/l20n/l20n.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/l20n/l20n.js/issues/167/comments","statuses_url":"https://api.github.com/repos/l20n/l20n.js/statuses/73c26a34fbd1777772e9cad995044f8029f91e9c","head":{"label":"zbraniecki:os2platform","ref":"os2platform","sha":"73c26a34fbd1777772e9cad995044f8029f91e9c","user":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"repo":{"id":5379922,"name":"l20n.js","full_name":"zbraniecki/l20n.js","owner":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zbraniecki/l20n.js","description":"L20n implementation in JavaScript","fork":true,"url":"https://api.github.com/repos/zbraniecki/l20n.js","forks_url":"https://api.github.com/repos/zbraniecki/l20n.js/forks","keys_url":"https://api.github.com/repos/zbraniecki/l20n.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zbraniecki/l20n.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zbraniecki/l20n.js/teams","hooks_url":"https://api.github.com/repos/zbraniecki/l20n.js/hooks","issue_events_url":"https://api.github.com/repos/zbraniecki/l20n.js/issues/events{/number}","events_url":"https://api.github.com/repos/zbraniecki/l20n.js/events","assignees_url":"https://api.github.com/repos/zbraniecki/l20n.js/assignees{/user}","branches_url":"https://api.github.com/repos/zbraniecki/l20n.js/branches{/branch}","tags_url":"https://api.github.com/repos/zbraniecki/l20n.js/tags","blobs_url":"https://api.github.com/repos/zbraniecki/l20n.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zbraniecki/l20n.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zbraniecki/l20n.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/zbraniecki/l20n.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zbraniecki/l20n.js/statuses/{sha}","languages_url":"https://api.github.com/repos/zbraniecki/l20n.js/languages","stargazers_url":"https://api.github.com/repos/zbraniecki/l20n.js/stargazers","contributors_url":"https://api.github.com/repos/zbraniecki/l20n.js/contributors","subscribers_url":"https://api.github.com/repos/zbraniecki/l20n.js/subscribers","subscription_url":"https://api.github.com/repos/zbraniecki/l20n.js/subscription","commits_url":"https://api.github.com/repos/zbraniecki/l20n.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/zbraniecki/l20n.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/zbraniecki/l20n.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/zbraniecki/l20n.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/zbraniecki/l20n.js/contents/{+path}","compare_url":"https://api.github.com/repos/zbraniecki/l20n.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zbraniecki/l20n.js/merges","archive_url":"https://api.github.com/repos/zbraniecki/l20n.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zbraniecki/l20n.js/downloads","issues_url":"https://api.github.com/repos/zbraniecki/l20n.js/issues{/number}","pulls_url":"https://api.github.com/repos/zbraniecki/l20n.js/pulls{/number}","milestones_url":"https://api.github.com/repos/zbraniecki/l20n.js/milestones{/number}","notifications_url":"https://api.github.com/repos/zbraniecki/l20n.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zbraniecki/l20n.js/labels{/name}","releases_url":"https://api.github.com/repos/zbraniecki/l20n.js/releases{/id}","deployments_url":"https://api.github.com/repos/zbraniecki/l20n.js/deployments","created_at":"2012-08-11T13:20:14Z","updated_at":"2016-09-20T15:42:04Z","pushed_at":"2016-11-09T01:17:36Z","git_url":"git://github.com/zbraniecki/l20n.js.git","ssh_url":"git@github.com:zbraniecki/l20n.js.git","clone_url":"https://github.com/zbraniecki/l20n.js.git","svn_url":"https://github.com/zbraniecki/l20n.js","homepage":null,"size":4399,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"l20n:master","ref":"master","sha":"49f0105b45ec11fc9b320a7cc70d926079f8e001","user":{"login":"l20n","id":2127587,"avatar_url":"https://avatars.githubusercontent.com/u/2127587?v=3","gravatar_id":"","url":"https://api.github.com/users/l20n","html_url":"https://github.com/l20n","followers_url":"https://api.github.com/users/l20n/followers","following_url":"https://api.github.com/users/l20n/following{/other_user}","gists_url":"https://api.github.com/users/l20n/gists{/gist_id}","starred_url":"https://api.github.com/users/l20n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l20n/subscriptions","organizations_url":"https://api.github.com/users/l20n/orgs","repos_url":"https://api.github.com/users/l20n/repos","events_url":"https://api.github.com/users/l20n/events{/privacy}","received_events_url":"https://api.github.com/users/l20n/received_events","type":"Organization","site_admin":false},"repo":{"id":5366673,"name":"l20n.js","full_name":"l20n/l20n.js","owner":{"login":"l20n","id":2127587,"avatar_url":"https://avatars.githubusercontent.com/u/2127587?v=3","gravatar_id":"","url":"https://api.github.com/users/l20n","html_url":"https://github.com/l20n","followers_url":"https://api.github.com/users/l20n/followers","following_url":"https://api.github.com/users/l20n/following{/other_user}","gists_url":"https://api.github.com/users/l20n/gists{/gist_id}","starred_url":"https://api.github.com/users/l20n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l20n/subscriptions","organizations_url":"https://api.github.com/users/l20n/orgs","repos_url":"https://api.github.com/users/l20n/repos","events_url":"https://api.github.com/users/l20n/events{/privacy}","received_events_url":"https://api.github.com/users/l20n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/l20n/l20n.js","description":"A next-gen localization framework from Mozilla.","fork":false,"url":"https://api.github.com/repos/l20n/l20n.js","forks_url":"https://api.github.com/repos/l20n/l20n.js/forks","keys_url":"https://api.github.com/repos/l20n/l20n.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/l20n/l20n.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/l20n/l20n.js/teams","hooks_url":"https://api.github.com/repos/l20n/l20n.js/hooks","issue_events_url":"https://api.github.com/repos/l20n/l20n.js/issues/events{/number}","events_url":"https://api.github.com/repos/l20n/l20n.js/events","assignees_url":"https://api.github.com/repos/l20n/l20n.js/assignees{/user}","branches_url":"https://api.github.com/repos/l20n/l20n.js/branches{/branch}","tags_url":"https://api.github.com/repos/l20n/l20n.js/tags","blobs_url":"https://api.github.com/repos/l20n/l20n.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/l20n/l20n.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/l20n/l20n.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/l20n/l20n.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/l20n/l20n.js/statuses/{sha}","languages_url":"https://api.github.com/repos/l20n/l20n.js/languages","stargazers_url":"https://api.github.com/repos/l20n/l20n.js/stargazers","contributors_url":"https://api.github.com/repos/l20n/l20n.js/contributors","subscribers_url":"https://api.github.com/repos/l20n/l20n.js/subscribers","subscription_url":"https://api.github.com/repos/l20n/l20n.js/subscription","commits_url":"https://api.github.com/repos/l20n/l20n.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/l20n/l20n.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/l20n/l20n.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/l20n/l20n.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/l20n/l20n.js/contents/{+path}","compare_url":"https://api.github.com/repos/l20n/l20n.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/l20n/l20n.js/merges","archive_url":"https://api.github.com/repos/l20n/l20n.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/l20n/l20n.js/downloads","issues_url":"https://api.github.com/repos/l20n/l20n.js/issues{/number}","pulls_url":"https://api.github.com/repos/l20n/l20n.js/pulls{/number}","milestones_url":"https://api.github.com/repos/l20n/l20n.js/milestones{/number}","notifications_url":"https://api.github.com/repos/l20n/l20n.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/l20n/l20n.js/labels{/name}","releases_url":"https://api.github.com/repos/l20n/l20n.js/releases{/id}","deployments_url":"https://api.github.com/repos/l20n/l20n.js/deployments","created_at":"2012-08-10T08:17:42Z","updated_at":"2016-11-08T18:12:40Z","pushed_at":"2016-11-09T01:18:00Z","git_url":"git://github.com/l20n/l20n.js.git","ssh_url":"git@github.com:l20n/l20n.js.git","clone_url":"https://github.com/l20n/l20n.js.git","svn_url":"https://github.com/l20n/l20n.js","homepage":"http://l20n.org","size":5372,"stargazers_count":846,"watchers_count":846,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":63,"mirror_url":null,"open_issues_count":11,"forks":63,"open_issues":11,"watchers":846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/l20n/l20n.js/pulls/167"},"html":{"href":"https://github.com/l20n/l20n.js/pull/167"},"issue":{"href":"https://api.github.com/repos/l20n/l20n.js/issues/167"},"comments":{"href":"https://api.github.com/repos/l20n/l20n.js/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/l20n/l20n.js/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/l20n/l20n.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/l20n/l20n.js/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/l20n/l20n.js/statuses/73c26a34fbd1777772e9cad995044f8029f91e9c"}}}}
{"actor":{"display_login":"stasm"}}