{"action":"opened","number":1889,"pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1889","id":82588626,"html_url":"https://github.com/rails-api/active_model_serializers/pull/1889","diff_url":"https://github.com/rails-api/active_model_serializers/pull/1889.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/1889.patch","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1889","number":1889,"state":"open","locked":false,"title":"Support key transformation for Attributes adapter","user":{"login":"iancanderson","id":180798,"avatar_url":"https://avatars.githubusercontent.com/u/180798?v=3","gravatar_id":"","url":"https://api.github.com/users/iancanderson","html_url":"https://github.com/iancanderson","followers_url":"https://api.github.com/users/iancanderson/followers","following_url":"https://api.github.com/users/iancanderson/following{/other_user}","gists_url":"https://api.github.com/users/iancanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/iancanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancanderson/subscriptions","organizations_url":"https://api.github.com/users/iancanderson/orgs","repos_url":"https://api.github.com/users/iancanderson/repos","events_url":"https://api.github.com/users/iancanderson/events{/privacy}","received_events_url":"https://api.github.com/users/iancanderson/received_events","type":"User","site_admin":false},"body":"#### Purpose\r\nThe `:attributes` adapter is the default one, but it did not support\r\nkey transformation. This was very surprising behavior, since the\r\n\"Configuration Options\" page in the guides didn't mention that this\r\nbehavior was not supported by the attributes adapter.\r\n\r\n#### Changes\r\nThis PR adds key transform support to the attributes adapter, and\r\nadds documentation about the default transform for the attributes\r\nadapter (which is `:unaltered`).\r\n\r\n#### Caveats\r\nThis could potentially break existing apps that have a `key_transform` set that also use the `Attributes` adapter. Before this change, the `key_transform` setting would be a no-op. After this change, the `key_transform` would take effect and therefore change the behavior of their current apps.\r\n\r\nHowever, the current behavior seems like a bug to me, and I think it is worth fixing.","created_at":"2016-08-24T17:57:59Z","updated_at":"2016-08-24T17:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1889/commits","review_comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1889/comments","review_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1889/comments","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/5a848d73879e64a03e3bb8b05a19052748bc2871","head":{"label":"iancanderson:ia-db-add-key-transform-to-attributes-adapter","ref":"ia-db-add-key-transform-to-attributes-adapter","sha":"5a848d73879e64a03e3bb8b05a19052748bc2871","user":{"login":"iancanderson","id":180798,"avatar_url":"https://avatars.githubusercontent.com/u/180798?v=3","gravatar_id":"","url":"https://api.github.com/users/iancanderson","html_url":"https://github.com/iancanderson","followers_url":"https://api.github.com/users/iancanderson/followers","following_url":"https://api.github.com/users/iancanderson/following{/other_user}","gists_url":"https://api.github.com/users/iancanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/iancanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancanderson/subscriptions","organizations_url":"https://api.github.com/users/iancanderson/orgs","repos_url":"https://api.github.com/users/iancanderson/repos","events_url":"https://api.github.com/users/iancanderson/events{/privacy}","received_events_url":"https://api.github.com/users/iancanderson/received_events","type":"User","site_admin":false},"repo":{"id":66484137,"name":"active_model_serializers","full_name":"iancanderson/active_model_serializers","owner":{"login":"iancanderson","id":180798,"avatar_url":"https://avatars.githubusercontent.com/u/180798?v=3","gravatar_id":"","url":"https://api.github.com/users/iancanderson","html_url":"https://github.com/iancanderson","followers_url":"https://api.github.com/users/iancanderson/followers","following_url":"https://api.github.com/users/iancanderson/following{/other_user}","gists_url":"https://api.github.com/users/iancanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/iancanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancanderson/subscriptions","organizations_url":"https://api.github.com/users/iancanderson/orgs","repos_url":"https://api.github.com/users/iancanderson/repos","events_url":"https://api.github.com/users/iancanderson/events{/privacy}","received_events_url":"https://api.github.com/users/iancanderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iancanderson/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":true,"url":"https://api.github.com/repos/iancanderson/active_model_serializers","forks_url":"https://api.github.com/repos/iancanderson/active_model_serializers/forks","keys_url":"https://api.github.com/repos/iancanderson/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iancanderson/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iancanderson/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/iancanderson/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/iancanderson/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/iancanderson/active_model_serializers/events","assignees_url":"https://api.github.com/repos/iancanderson/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/iancanderson/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/iancanderson/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/iancanderson/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iancanderson/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iancanderson/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/iancanderson/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iancanderson/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/iancanderson/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/iancanderson/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/iancanderson/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/iancanderson/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/iancanderson/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/iancanderson/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/iancanderson/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/iancanderson/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/iancanderson/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/iancanderson/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/iancanderson/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iancanderson/active_model_serializers/merges","archive_url":"https://api.github.com/repos/iancanderson/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iancanderson/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/iancanderson/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/iancanderson/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/iancanderson/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/iancanderson/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iancanderson/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/iancanderson/active_model_serializers/releases{/id}","deployments_url":"https://api.github.com/repos/iancanderson/active_model_serializers/deployments","created_at":"2016-08-24T17:14:28Z","updated_at":"2016-08-24T17:14:29Z","pushed_at":"2016-08-24T17:55:33Z","git_url":"git://github.com/iancanderson/active_model_serializers.git","ssh_url":"git@github.com:iancanderson/active_model_serializers.git","clone_url":"https://github.com/iancanderson/active_model_serializers.git","svn_url":"https://github.com/iancanderson/active_model_serializers","homepage":"","size":5350,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails-api:master","ref":"master","sha":"49ee823a5311799b3e96b0384ca4fd7a9cf39a34","user":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2889230,"name":"active_model_serializers","full_name":"rails-api/active_model_serializers","owner":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-api/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":false,"url":"https://api.github.com/repos/rails-api/active_model_serializers","forks_url":"https://api.github.com/repos/rails-api/active_model_serializers/forks","keys_url":"https://api.github.com/repos/rails-api/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-api/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-api/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/rails-api/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/events","assignees_url":"https://api.github.com/repos/rails-api/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/rails-api/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-api/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/rails-api/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/rails-api/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-api/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/rails-api/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-api/active_model_serializers/merges","archive_url":"https://api.github.com/repos/rails-api/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-api/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-api/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-api/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/rails-api/active_model_serializers/releases{/id}","deployments_url":"https://api.github.com/repos/rails-api/active_model_serializers/deployments","created_at":"2011-12-01T06:39:26Z","updated_at":"2016-08-24T09:10:39Z","pushed_at":"2016-08-24T17:57:59Z","git_url":"git://github.com/rails-api/active_model_serializers.git","ssh_url":"git@github.com:rails-api/active_model_serializers.git","clone_url":"https://github.com/rails-api/active_model_serializers.git","svn_url":"https://github.com/rails-api/active_model_serializers","homepage":"","size":5350,"stargazers_count":3716,"watchers_count":3716,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":998,"mirror_url":null,"open_issues_count":126,"forks":998,"open_issues":126,"watchers":3716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1889"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1889"},"issue":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1889"},"comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1889/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1889/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1889/commits"},"statuses":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/5a848d73879e64a03e3bb8b05a19052748bc2871"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":43,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"iancanderson"}}