{"action":"created","comment":{"url":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/comments/72154206","id":72154206,"diff_hunk":"@@ -786,13 +792,16 @@ export class NgGrid implements OnInit, DoCheck, OnDestroy {\n \t\t\t}\r\n \t\t\t\r\n \t\t\tif (shouldSave) {\r\n-\t\t\t\tcollisions[0].savePosition(itemPos);\r\n+\t\t\t\tconst newItemPos = this._fixGridPosition(itemPos, itemDims);\r\n+\t\t\t\tcollisions[0].savePosition(newItemPos.col, newItemPos.row);\r\n \t\t\t} else {\r\n-\t\t\t\tcollisions[0].setGridPosition(itemPos);\r\n+\t\t                const newItemPos = this._fixGridPosition(itemPos, itemDims);\r","path":"src/directives/NgGrid.ts","position":39,"original_position":39,"commit_id":"f16f88b71d560acf954672b44e2c0905afd85f6d","original_commit_id":"f16f88b71d560acf954672b44e2c0905afd85f6d","user":{"login":"BTMorton","id":9026309,"avatar_url":"https://avatars.githubusercontent.com/u/9026309?v=3","gravatar_id":"","url":"https://api.github.com/users/BTMorton","html_url":"https://github.com/BTMorton","followers_url":"https://api.github.com/users/BTMorton/followers","following_url":"https://api.github.com/users/BTMorton/following{/other_user}","gists_url":"https://api.github.com/users/BTMorton/gists{/gist_id}","starred_url":"https://api.github.com/users/BTMorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTMorton/subscriptions","organizations_url":"https://api.github.com/users/BTMorton/orgs","repos_url":"https://api.github.com/users/BTMorton/repos","events_url":"https://api.github.com/users/BTMorton/events{/privacy}","received_events_url":"https://api.github.com/users/BTMorton/received_events","type":"User","site_admin":false},"body":"Doesn't this line directly conflict with the additional call to `_fixGridCollisions` that occurs two lines below?","created_at":"2016-07-25T22:07:51Z","updated_at":"2016-07-25T22:07:51Z","html_url":"https://github.com/BTMorton/angular2-grid/pull/113#discussion_r72154206","pull_request_url":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/comments/72154206"},"html":{"href":"https://github.com/BTMorton/angular2-grid/pull/113#discussion_r72154206"},"pull_request":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/113","id":78211667,"html_url":"https://github.com/BTMorton/angular2-grid/pull/113","diff_url":"https://github.com/BTMorton/angular2-grid/pull/113.diff","patch_url":"https://github.com/BTMorton/angular2-grid/pull/113.patch","issue_url":"https://api.github.com/repos/BTMorton/angular2-grid/issues/113","number":113,"state":"closed","locked":false,"title":"Update NgGrid.ts | Pushing to 0.8.4 | Dependencies updated","user":{"login":"wuhkuh","id":20139217,"avatar_url":"https://avatars.githubusercontent.com/u/20139217?v=3","gravatar_id":"","url":"https://api.github.com/users/wuhkuh","html_url":"https://github.com/wuhkuh","followers_url":"https://api.github.com/users/wuhkuh/followers","following_url":"https://api.github.com/users/wuhkuh/following{/other_user}","gists_url":"https://api.github.com/users/wuhkuh/gists{/gist_id}","starred_url":"https://api.github.com/users/wuhkuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuhkuh/subscriptions","organizations_url":"https://api.github.com/users/wuhkuh/orgs","repos_url":"https://api.github.com/users/wuhkuh/repos","events_url":"https://api.github.com/users/wuhkuh/events{/privacy}","received_events_url":"https://api.github.com/users/wuhkuh/received_events","type":"User","site_admin":false},"body":"- Fixed mouseDown and mouseMove events. Dragging, resizing, and clicking the items work properly now. Closes #81.\r\n- Fixed out-of-boundary pushing when dropping a GridItem. Fixed out-of-boundary pushing when GridItems are larger than the standard size.\r\n  Closes #107.\r\n- Fixed 'shouldSave' for left and right cascading.\r\n\r\nPackage changes:\r\n- Pushed version to 0.8.4.\r\n\r\nDependencies:\r\n- Angular to RC4\r\n- Typings to 1.3.1","created_at":"2016-07-20T20:15:16Z","updated_at":"2016-07-25T22:07:51Z","closed_at":"2016-07-25T21:59:23Z","merged_at":"2016-07-25T21:59:23Z","merge_commit_sha":"24956093978a4bac6b62cfbff4c04836cc214139","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/113/commits","review_comments_url":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/113/comments","review_comment_url":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BTMorton/angular2-grid/issues/113/comments","statuses_url":"https://api.github.com/repos/BTMorton/angular2-grid/statuses/f16f88b71d560acf954672b44e2c0905afd85f6d","head":{"label":"wuhkuh:master","ref":"master","sha":"f16f88b71d560acf954672b44e2c0905afd85f6d","user":{"login":"wuhkuh","id":20139217,"avatar_url":"https://avatars.githubusercontent.com/u/20139217?v=3","gravatar_id":"","url":"https://api.github.com/users/wuhkuh","html_url":"https://github.com/wuhkuh","followers_url":"https://api.github.com/users/wuhkuh/followers","following_url":"https://api.github.com/users/wuhkuh/following{/other_user}","gists_url":"https://api.github.com/users/wuhkuh/gists{/gist_id}","starred_url":"https://api.github.com/users/wuhkuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuhkuh/subscriptions","organizations_url":"https://api.github.com/users/wuhkuh/orgs","repos_url":"https://api.github.com/users/wuhkuh/repos","events_url":"https://api.github.com/users/wuhkuh/events{/privacy}","received_events_url":"https://api.github.com/users/wuhkuh/received_events","type":"User","site_admin":false},"repo":{"id":63811051,"name":"angular2-grid","full_name":"wuhkuh/angular2-grid","owner":{"login":"wuhkuh","id":20139217,"avatar_url":"https://avatars.githubusercontent.com/u/20139217?v=3","gravatar_id":"","url":"https://api.github.com/users/wuhkuh","html_url":"https://github.com/wuhkuh","followers_url":"https://api.github.com/users/wuhkuh/followers","following_url":"https://api.github.com/users/wuhkuh/following{/other_user}","gists_url":"https://api.github.com/users/wuhkuh/gists{/gist_id}","starred_url":"https://api.github.com/users/wuhkuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuhkuh/subscriptions","organizations_url":"https://api.github.com/users/wuhkuh/orgs","repos_url":"https://api.github.com/users/wuhkuh/repos","events_url":"https://api.github.com/users/wuhkuh/events{/privacy}","received_events_url":"https://api.github.com/users/wuhkuh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wuhkuh/angular2-grid","description":"A drag/drop/resize grid-based plugin directive for angular2","fork":true,"url":"https://api.github.com/repos/wuhkuh/angular2-grid","forks_url":"https://api.github.com/repos/wuhkuh/angular2-grid/forks","keys_url":"https://api.github.com/repos/wuhkuh/angular2-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wuhkuh/angular2-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wuhkuh/angular2-grid/teams","hooks_url":"https://api.github.com/repos/wuhkuh/angular2-grid/hooks","issue_events_url":"https://api.github.com/repos/wuhkuh/angular2-grid/issues/events{/number}","events_url":"https://api.github.com/repos/wuhkuh/angular2-grid/events","assignees_url":"https://api.github.com/repos/wuhkuh/angular2-grid/assignees{/user}","branches_url":"https://api.github.com/repos/wuhkuh/angular2-grid/branches{/branch}","tags_url":"https://api.github.com/repos/wuhkuh/angular2-grid/tags","blobs_url":"https://api.github.com/repos/wuhkuh/angular2-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wuhkuh/angular2-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wuhkuh/angular2-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/wuhkuh/angular2-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wuhkuh/angular2-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/wuhkuh/angular2-grid/languages","stargazers_url":"https://api.github.com/repos/wuhkuh/angular2-grid/stargazers","contributors_url":"https://api.github.com/repos/wuhkuh/angular2-grid/contributors","subscribers_url":"https://api.github.com/repos/wuhkuh/angular2-grid/subscribers","subscription_url":"https://api.github.com/repos/wuhkuh/angular2-grid/subscription","commits_url":"https://api.github.com/repos/wuhkuh/angular2-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/wuhkuh/angular2-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/wuhkuh/angular2-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/wuhkuh/angular2-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/wuhkuh/angular2-grid/contents/{+path}","compare_url":"https://api.github.com/repos/wuhkuh/angular2-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wuhkuh/angular2-grid/merges","archive_url":"https://api.github.com/repos/wuhkuh/angular2-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wuhkuh/angular2-grid/downloads","issues_url":"https://api.github.com/repos/wuhkuh/angular2-grid/issues{/number}","pulls_url":"https://api.github.com/repos/wuhkuh/angular2-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/wuhkuh/angular2-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/wuhkuh/angular2-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wuhkuh/angular2-grid/labels{/name}","releases_url":"https://api.github.com/repos/wuhkuh/angular2-grid/releases{/id}","deployments_url":"https://api.github.com/repos/wuhkuh/angular2-grid/deployments","created_at":"2016-07-20T20:08:28Z","updated_at":"2016-07-20T20:08:28Z","pushed_at":"2016-07-25T14:18:46Z","git_url":"git://github.com/wuhkuh/angular2-grid.git","ssh_url":"git@github.com:wuhkuh/angular2-grid.git","clone_url":"https://github.com/wuhkuh/angular2-grid.git","svn_url":"https://github.com/wuhkuh/angular2-grid","homepage":"https://bmorton.co.uk/angular/","size":371,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BTMorton:master","ref":"master","sha":"7cbda8dd46723b782e98c12920c6b2805b5da924","user":{"login":"BTMorton","id":9026309,"avatar_url":"https://avatars.githubusercontent.com/u/9026309?v=3","gravatar_id":"","url":"https://api.github.com/users/BTMorton","html_url":"https://github.com/BTMorton","followers_url":"https://api.github.com/users/BTMorton/followers","following_url":"https://api.github.com/users/BTMorton/following{/other_user}","gists_url":"https://api.github.com/users/BTMorton/gists{/gist_id}","starred_url":"https://api.github.com/users/BTMorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTMorton/subscriptions","organizations_url":"https://api.github.com/users/BTMorton/orgs","repos_url":"https://api.github.com/users/BTMorton/repos","events_url":"https://api.github.com/users/BTMorton/events{/privacy}","received_events_url":"https://api.github.com/users/BTMorton/received_events","type":"User","site_admin":false},"repo":{"id":40627939,"name":"angular2-grid","full_name":"BTMorton/angular2-grid","owner":{"login":"BTMorton","id":9026309,"avatar_url":"https://avatars.githubusercontent.com/u/9026309?v=3","gravatar_id":"","url":"https://api.github.com/users/BTMorton","html_url":"https://github.com/BTMorton","followers_url":"https://api.github.com/users/BTMorton/followers","following_url":"https://api.github.com/users/BTMorton/following{/other_user}","gists_url":"https://api.github.com/users/BTMorton/gists{/gist_id}","starred_url":"https://api.github.com/users/BTMorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTMorton/subscriptions","organizations_url":"https://api.github.com/users/BTMorton/orgs","repos_url":"https://api.github.com/users/BTMorton/repos","events_url":"https://api.github.com/users/BTMorton/events{/privacy}","received_events_url":"https://api.github.com/users/BTMorton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BTMorton/angular2-grid","description":"A drag/drop/resize grid-based plugin directive for angular2","fork":false,"url":"https://api.github.com/repos/BTMorton/angular2-grid","forks_url":"https://api.github.com/repos/BTMorton/angular2-grid/forks","keys_url":"https://api.github.com/repos/BTMorton/angular2-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BTMorton/angular2-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BTMorton/angular2-grid/teams","hooks_url":"https://api.github.com/repos/BTMorton/angular2-grid/hooks","issue_events_url":"https://api.github.com/repos/BTMorton/angular2-grid/issues/events{/number}","events_url":"https://api.github.com/repos/BTMorton/angular2-grid/events","assignees_url":"https://api.github.com/repos/BTMorton/angular2-grid/assignees{/user}","branches_url":"https://api.github.com/repos/BTMorton/angular2-grid/branches{/branch}","tags_url":"https://api.github.com/repos/BTMorton/angular2-grid/tags","blobs_url":"https://api.github.com/repos/BTMorton/angular2-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BTMorton/angular2-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BTMorton/angular2-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/BTMorton/angular2-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BTMorton/angular2-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/BTMorton/angular2-grid/languages","stargazers_url":"https://api.github.com/repos/BTMorton/angular2-grid/stargazers","contributors_url":"https://api.github.com/repos/BTMorton/angular2-grid/contributors","subscribers_url":"https://api.github.com/repos/BTMorton/angular2-grid/subscribers","subscription_url":"https://api.github.com/repos/BTMorton/angular2-grid/subscription","commits_url":"https://api.github.com/repos/BTMorton/angular2-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/BTMorton/angular2-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/BTMorton/angular2-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/BTMorton/angular2-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/BTMorton/angular2-grid/contents/{+path}","compare_url":"https://api.github.com/repos/BTMorton/angular2-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BTMorton/angular2-grid/merges","archive_url":"https://api.github.com/repos/BTMorton/angular2-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BTMorton/angular2-grid/downloads","issues_url":"https://api.github.com/repos/BTMorton/angular2-grid/issues{/number}","pulls_url":"https://api.github.com/repos/BTMorton/angular2-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/BTMorton/angular2-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/BTMorton/angular2-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BTMorton/angular2-grid/labels{/name}","releases_url":"https://api.github.com/repos/BTMorton/angular2-grid/releases{/id}","deployments_url":"https://api.github.com/repos/BTMorton/angular2-grid/deployments","created_at":"2015-08-12T22:49:09Z","updated_at":"2016-07-22T02:58:42Z","pushed_at":"2016-07-25T21:59:24Z","git_url":"git://github.com/BTMorton/angular2-grid.git","ssh_url":"git@github.com:BTMorton/angular2-grid.git","clone_url":"https://github.com/BTMorton/angular2-grid.git","svn_url":"https://github.com/BTMorton/angular2-grid","homepage":"https://bmorton.co.uk/angular/","size":417,"stargazers_count":111,"watchers_count":111,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":16,"forks":38,"open_issues":16,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/113"},"html":{"href":"https://github.com/BTMorton/angular2-grid/pull/113"},"issue":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/issues/113"},"comments":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/BTMorton/angular2-grid/statuses/f16f88b71d560acf954672b44e2c0905afd85f6d"}}}}
{"actor":{"display_login":"BTMorton"}}