{"action":"created","issue":{"url":"https://api.github.com/repos/robertohuertasm/vscode-icons/issues/485","repository_url":"https://api.github.com/repos/robertohuertasm/vscode-icons","labels_url":"https://api.github.com/repos/robertohuertasm/vscode-icons/issues/485/labels{/name}","comments_url":"https://api.github.com/repos/robertohuertasm/vscode-icons/issues/485/comments","events_url":"https://api.github.com/repos/robertohuertasm/vscode-icons/issues/485/events","html_url":"https://github.com/robertohuertasm/vscode-icons/issues/485","id":193342982,"number":485,"title":"[Proposal] Move 'icons.json' to dist","user":{"login":"JimiC","id":1716442,"avatar_url":"https://avatars.githubusercontent.com/u/1716442?v=3","gravatar_id":"","url":"https://api.github.com/users/JimiC","html_url":"https://github.com/JimiC","followers_url":"https://api.github.com/users/JimiC/followers","following_url":"https://api.github.com/users/JimiC/following{/other_user}","gists_url":"https://api.github.com/users/JimiC/gists{/gist_id}","starred_url":"https://api.github.com/users/JimiC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimiC/subscriptions","organizations_url":"https://api.github.com/users/JimiC/orgs","repos_url":"https://api.github.com/users/JimiC/repos","events_url":"https://api.github.com/users/JimiC/events{/privacy}","received_events_url":"https://api.github.com/users/JimiC/received_events","type":"User","site_admin":false},"labels":[{"id":384977478,"url":"https://api.github.com/repos/robertohuertasm/vscode-icons/labels/question%20/%20debate","name":"question / debate","color":"cc317c","default":false},{"id":398736855,"url":"https://api.github.com/repos/robertohuertasm/vscode-icons/labels/suggestion","name":"suggestion","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-04T10:12:51Z","updated_at":"2016-12-10T11:51:02Z","closed_at":null,"body":"Obviously this is something trivial, but out of build process consistency, any file that is produced by the build script, SHOULD be placed in the `dist` folder.\r\n\r\nAs long as we reflect the move in the `package.json` file and the generated paths, I can't see any issues."},"comment":{"url":"https://api.github.com/repos/robertohuertasm/vscode-icons/issues/comments/266202683","html_url":"https://github.com/robertohuertasm/vscode-icons/issues/485#issuecomment-266202683","issue_url":"https://api.github.com/repos/robertohuertasm/vscode-icons/issues/485","id":266202683,"user":{"login":"JimiC","id":1716442,"avatar_url":"https://avatars.githubusercontent.com/u/1716442?v=3","gravatar_id":"","url":"https://api.github.com/users/JimiC","html_url":"https://github.com/JimiC","followers_url":"https://api.github.com/users/JimiC/followers","following_url":"https://api.github.com/users/JimiC/following{/other_user}","gists_url":"https://api.github.com/users/JimiC/gists{/gist_id}","starred_url":"https://api.github.com/users/JimiC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimiC/subscriptions","organizations_url":"https://api.github.com/users/JimiC/orgs","repos_url":"https://api.github.com/users/JimiC/repos","events_url":"https://api.github.com/users/JimiC/events{/privacy}","received_events_url":"https://api.github.com/users/JimiC/received_events","type":"User","site_admin":false},"created_at":"2016-12-10T11:51:02Z","updated_at":"2016-12-10T11:51:02Z","body":"@jens1o They are practically the same but `mocha-chai` utilizes `Promises` via `chai` which makes the async chaining easier.\r\n\r\nFurther more look at the [trends](http://www.npmtrends.com/mocha-vs-ava-vs-jasmine-core).\r\n\r\nHere is an example of how `mocha-chai` [looks like](https://github.com/JimiC/evetron/blob/master/tests/evetron/scripts/chai/main.ts#L38) vs to how `mocha` [looks like](https://github.com/JimiC/evetron/blob/master/tests/evetron/scripts/mocha/main.ts#L32) vs how `ava` [looks like](https://github.com/JimiC/evetron/blob/master/tests/evetron/scripts/ava/main.ts#L26)."}}
{"actor":{"display_login":"JimiC"}}