{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/65220916","id":65220916,"diff_hunk":"@@ -0,0 +1,177 @@\n+\"\"\"","path":"kolibri/utils/lru_cache.py","position":1,"original_position":1,"commit_id":"1085058894654aed8fe28d66de02937de6a947d9","original_commit_id":"1085058894654aed8fe28d66de02937de6a947d9","user":{"login":"benjaoming","id":374612,"avatar_url":"https://avatars.githubusercontent.com/u/374612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"body":"All of this needs no review, it's been added because it needs to be accessed in setup.py BEFORE any requirement is installed (as for instance Django, which is where it originates from)","created_at":"2016-05-31T16:53:33Z","updated_at":"2016-05-31T16:53:33Z","html_url":"https://github.com/learningequality/kolibri/pull/126#discussion_r65220916","pull_request_url":"https://api.github.com/repos/learningequality/kolibri/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/65220916"},"html":{"href":"https://github.com/learningequality/kolibri/pull/126#discussion_r65220916"},"pull_request":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/126","id":71768409,"html_url":"https://github.com/learningequality/kolibri/pull/126","diff_url":"https://github.com/learningequality/kolibri/pull/126.diff","patch_url":"https://github.com/learningequality/kolibri/pull/126.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/126","number":126,"state":"open","locked":false,"title":"Creating wheel/sdist with static deps bundled in","user":{"login":"benjaoming","id":374612,"avatar_url":"https://avatars.githubusercontent.com/u/374612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nI've added a greatly simplified version of the dependency downloader from KA Lite :) In fact, it's half the size now as it doesn't have to deal with dependency packages as data files.\r\n\r\nThe big leap forwards compared to KA Lite is that we install it in the `kolibri/dist` package, meaning that ALL files from these packages are managed as package files and will be automatically uninstalled and upgraded together with the rest of kolibri, no matter *pyc files etc.\r\n\r\n## TODO\r\n\r\n- [x] Fixes up setup.py to be functional\r\n- [x] Runs `make sdist` conditionally because this PR changes files that trigger the build!\r\n- [x] Factor tests from `tests/` into `utils/tests`\r\n- [x] Handle licenses of included distributions\r\n- [x] Have tests been written for the new code?\r\n- [x] Has documentation been written/updated?\r\n- [x] New dependencies (if any) added to requirements file\r\n- [x] Add an entry to CHANGELOG.rst\r\n- [x] Add yourself it AUTHORS.rst if you don't appear there\r\n\r\n## Reviewer guidance\r\n\r\nPlease make helpful remarks if you can think of better structures for this.\r\n\r\n## How to use\r\n\r\n    python setup.py bdist_wheel --static\r\n\r\nTo clean up:\r\n\r\n    make clean\r\n","created_at":"2016-05-27T20:27:15Z","updated_at":"2016-05-31T16:53:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caf096d8e97118d48343b97a23f72a96e363041a","assignee":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars.githubusercontent.com/u/2367265?v=3","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/126/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/126/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/126/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/1085058894654aed8fe28d66de02937de6a947d9","head":{"label":"benjaoming:sdist-with-static-deps","ref":"sdist-with-static-deps","sha":"1085058894654aed8fe28d66de02937de6a947d9","user":{"login":"benjaoming","id":374612,"avatar_url":"https://avatars.githubusercontent.com/u/374612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"repo":{"id":50074781,"name":"kolibri","full_name":"benjaoming/kolibri","owner":{"login":"benjaoming","id":374612,"avatar_url":"https://avatars.githubusercontent.com/u/374612?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaoming/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":true,"url":"https://api.github.com/repos/benjaoming/kolibri","forks_url":"https://api.github.com/repos/benjaoming/kolibri/forks","keys_url":"https://api.github.com/repos/benjaoming/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaoming/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaoming/kolibri/teams","hooks_url":"https://api.github.com/repos/benjaoming/kolibri/hooks","issue_events_url":"https://api.github.com/repos/benjaoming/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/benjaoming/kolibri/events","assignees_url":"https://api.github.com/repos/benjaoming/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/benjaoming/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/benjaoming/kolibri/tags","blobs_url":"https://api.github.com/repos/benjaoming/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaoming/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaoming/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaoming/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaoming/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaoming/kolibri/languages","stargazers_url":"https://api.github.com/repos/benjaoming/kolibri/stargazers","contributors_url":"https://api.github.com/repos/benjaoming/kolibri/contributors","subscribers_url":"https://api.github.com/repos/benjaoming/kolibri/subscribers","subscription_url":"https://api.github.com/repos/benjaoming/kolibri/subscription","commits_url":"https://api.github.com/repos/benjaoming/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaoming/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaoming/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaoming/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaoming/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/benjaoming/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaoming/kolibri/merges","archive_url":"https://api.github.com/repos/benjaoming/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaoming/kolibri/downloads","issues_url":"https://api.github.com/repos/benjaoming/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/benjaoming/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaoming/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaoming/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaoming/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/benjaoming/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/benjaoming/kolibri/deployments","created_at":"2016-01-21T02:03:13Z","updated_at":"2016-01-21T14:31:46Z","pushed_at":"2016-05-31T12:40:12Z","git_url":"git://github.com/benjaoming/kolibri.git","ssh_url":"git@github.com:benjaoming/kolibri.git","clone_url":"https://github.com/benjaoming/kolibri.git","svn_url":"https://github.com/benjaoming/kolibri","homepage":"http://learningequality.org/kolibri/","size":5542,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"learningequality:master","ref":"master","sha":"81ac8ab4145d5184286065db2c82ef267f016fd1","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2016-04-13T06:45:10Z","pushed_at":"2016-05-31T12:40:12Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":5925,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":25,"forks":21,"open_issues":25,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/126"},"html":{"href":"https://github.com/learningequality/kolibri/pull/126"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/126"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/1085058894654aed8fe28d66de02937de6a947d9"}}}}
{"actor":{"display_login":"benjaoming"}}