{"action":"created","issue":{"url":"https://api.github.com/repos/okta/okta.github.io/issues/500","repository_url":"https://api.github.com/repos/okta/okta.github.io","labels_url":"https://api.github.com/repos/okta/okta.github.io/issues/500/labels{/name}","comments_url":"https://api.github.com/repos/okta/okta.github.io/issues/500/comments","events_url":"https://api.github.com/repos/okta/okta.github.io/issues/500/events","html_url":"https://github.com/okta/okta.github.io/pull/500","id":190383476,"number":500,"title":"Requested updates from Flickerbox","user":{"login":"chrislarrycarl","id":7042731,"avatar_url":"https://avatars.githubusercontent.com/u/7042731?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislarrycarl","html_url":"https://github.com/chrislarrycarl","followers_url":"https://api.github.com/users/chrislarrycarl/followers","following_url":"https://api.github.com/users/chrislarrycarl/following{/other_user}","gists_url":"https://api.github.com/users/chrislarrycarl/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislarrycarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislarrycarl/subscriptions","organizations_url":"https://api.github.com/users/chrislarrycarl/orgs","repos_url":"https://api.github.com/users/chrislarrycarl/repos","events_url":"https://api.github.com/users/chrislarrycarl/events{/privacy}","received_events_url":"https://api.github.com/users/chrislarrycarl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2016-11-18T18:01:22Z","updated_at":"2016-12-08T01:25:17Z","closed_at":"2016-12-08T00:38:34Z","pull_request":{"url":"https://api.github.com/repos/okta/okta.github.io/pulls/500","html_url":"https://github.com/okta/okta.github.io/pull/500","diff_url":"https://github.com/okta/okta.github.io/pull/500.diff","patch_url":"https://github.com/okta/okta.github.io/pull/500.patch"},"body":"Hey John,\r\n\r\nThis pull request includes the following requested changes:\r\n\r\n> It takes too long to render the TOC\r\n\r\nAdd \"loading\" state earlier in the page rendering to avoid content shifting and add demarcation for where the TOC will load\r\n\r\n> TOC can not be opened on \"mobile\" mode, only first level items can be visited\r\n\r\nChange docs.js to fully expand TOC on mobile by default, allowing full access to items (can be adjusted by changing selector in docs.js line 312)\r\n\r\n> Header is too tall on \"mobile\" view\r\n\r\nChange header from 100px to 75px and reduce menu button height on screens < medium\r\n\r\n> Search button doesn't work on mobile view\r\n\r\nChange link to http://developer.okta.com/search/\r\n\r\n> In expanded view, the grey color on sidebar should extend fully to the left, top, and bottom of the page\r\n\r\nChange .Sidebar styles to extend fully to the left, top, and bottom of the page\r\n\r\n> When the level1 TOC content wraps to a second line, it interferes with the line that is displayed to the left of the selected level 2 content.\r\n\r\nChange docs.js to add a bit of cushion for titles > 50 characters\r\n\r\n> One some pages, SOME of the the TOC content disappears when you scroll to the bottom: \r\n\r\nThe preloader now uses the page title as the title for all tables of contents, this pushes the page h1 \"lower\" in the TOC to be equal with the page h2s. This makes the TOC title more context relevant (instead of showing \"Overview\" the title is now \"Sessions\" for example - http://developer.okta.com.dev/docs/api/resources/sessions.html), this additionally fixes the issue where a page with fewer headings loses items when scrolling (a page with a single H1 and only two child H2s as in the api access management page for example).\r\n\r\n> The \"documentation\" page doesn't render properly on IE 11\r\n\r\nFix for grid layout for IE to constrain flex width and address padding expansion of element width\r\n\r\n> Left Nav Style/Behavior Fixes\r\n- Fix Top level titles 400 weight, all caps, underline\r\n- Fix categories style match to top level pages\r\n- Fix remove left border for secondary pages (nested under categories)\r\n- Fix collapse inactive categories, expand active category only\r\n- Fix active page highlighting consistent without regard for page depth\r\n\r\nAdditional Included Change:\r\n\r\nThe master.js file was being included twice on the code pages causing the support dropdown to be disabled (http://developer.okta.com/code/php/). Second include has been removed from _layouts/software.html to resolve the issue.\r\n\r\nThanks!,\r\n-Chris"},"comment":{"url":"https://api.github.com/repos/okta/okta.github.io/issues/comments/265626330","html_url":"https://github.com/okta/okta.github.io/pull/500#issuecomment-265626330","issue_url":"https://api.github.com/repos/okta/okta.github.io/issues/500","id":265626330,"user":{"login":"chrislarrycarl","id":7042731,"avatar_url":"https://avatars.githubusercontent.com/u/7042731?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislarrycarl","html_url":"https://github.com/chrislarrycarl","followers_url":"https://api.github.com/users/chrislarrycarl/followers","following_url":"https://api.github.com/users/chrislarrycarl/following{/other_user}","gists_url":"https://api.github.com/users/chrislarrycarl/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislarrycarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislarrycarl/subscriptions","organizations_url":"https://api.github.com/users/chrislarrycarl/orgs","repos_url":"https://api.github.com/users/chrislarrycarl/repos","events_url":"https://api.github.com/users/chrislarrycarl/events{/privacy}","received_events_url":"https://api.github.com/users/chrislarrycarl/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T01:25:17Z","updated_at":"2016-12-08T01:25:17Z","body":"@johngronberg-okta The change from commit a14db89 should have fixed the scroll lock when loading on mobile, however, in investigating this just now I did see that when on desktop and sizing down to mobile the lock persists. I'll send a new pull request with that fix."}}
{"actor":{"display_login":"chrislarrycarl"}}