{"action":"created","issue":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/569","repository_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/569/labels{/name}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/569/comments","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/569/events","html_url":"https://github.com/JoinMarket-Org/joinmarket/pull/569","id":159772859,"number":569,"title":"yieldgens: fix issue 567 for max_size orders","user":{"login":"AlexCato","id":19202406,"avatar_url":"https://avatars.githubusercontent.com/u/19202406?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexCato","html_url":"https://github.com/AlexCato","followers_url":"https://api.github.com/users/AlexCato/followers","following_url":"https://api.github.com/users/AlexCato/following{/other_user}","gists_url":"https://api.github.com/users/AlexCato/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexCato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexCato/subscriptions","organizations_url":"https://api.github.com/users/AlexCato/orgs","repos_url":"https://api.github.com/users/AlexCato/repos","events_url":"https://api.github.com/users/AlexCato/events{/privacy}","received_events_url":"https://api.github.com/users/AlexCato/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-11T13:10:36Z","updated_at":"2016-06-14T00:45:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/569","html_url":"https://github.com/JoinMarket-Org/joinmarket/pull/569","diff_url":"https://github.com/JoinMarket-Org/joinmarket/pull/569.diff","patch_url":"https://github.com/JoinMarket-Org/joinmarket/pull/569.patch"},"body":"Fixes issue #567 \r\n\r\nProblematic were these lines: https://github.com/JoinMarket-Org/joinmarket/blob/master/yield-generator-mixdepth.py#L157-161\r\n\r\nIf a txfee > the dust_threshold was set and maximum size order was requested, no mixdepth could contain enough coins to cover amount+txfee. This mostly wasnt an issue until now because most makers have a txfee=0 or did not even notice, because this does not crash the yieldgen-bot.\r\n\r\nSo this PR sets the announced maximum order to:\r\nmax_coins_in_one_mixdepth - max(dust_threshold, txfee)"},"comment":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/comments/225750500","html_url":"https://github.com/JoinMarket-Org/joinmarket/pull/569#issuecomment-225750500","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/569","id":225750500,"user":{"login":"chris-belcher","id":8398185,"avatar_url":"https://avatars.githubusercontent.com/u/8398185?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-belcher","html_url":"https://github.com/chris-belcher","followers_url":"https://api.github.com/users/chris-belcher/followers","following_url":"https://api.github.com/users/chris-belcher/following{/other_user}","gists_url":"https://api.github.com/users/chris-belcher/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-belcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-belcher/subscriptions","organizations_url":"https://api.github.com/users/chris-belcher/orgs","repos_url":"https://api.github.com/users/chris-belcher/repos","events_url":"https://api.github.com/users/chris-belcher/events{/privacy}","received_events_url":"https://api.github.com/users/chris-belcher/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T00:45:28Z","updated_at":"2016-06-14T00:45:28Z","body":"looks fine to me"}}
{"actor":{"display_login":"chris-belcher"}}