{"action":"created","comment":{"url":"https://api.github.com/repos/conda/conda-build/pulls/comments/94094298","pull_request_review_id":14624874,"id":94094298,"diff_hunk":"@@ -154,6 +151,16 @@ def build_vcvarsall_cmd(cmd, arch=arch_selector):\n         msvc_env_lines.append('if not \"%WindowsSDKDir%\" == \"{}\" ( {} )'.format(\n             WIN_SDK_71_PATH, build_vcvarsall_cmd(vcvarsall_vs_path)))\n     elif version == '9.0':\n+        # Get the Visual Studio 2008 path (not the Visual C++ for Python path)\n+        # and get the 'vcvars64.bat' from inside the bin (in the directory above\n+        # that returned by distutils_find_vcvarsall)\n+        try:\n+            VCVARS64_VS9_BAT_PATH = os.path.join(os.path.dirname(distutils_find_vcvarsall(9)),\n+                                                'bin', 'vcvars64.bat')","path":"conda_build/windows.py","position":55,"original_position":55,"commit_id":"3dc6416a4efe52c3ec5698286d18d505f021d3c1","original_commit_id":"3dc6416a4efe52c3ec5698286d18d505f021d3c1","user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars.githubusercontent.com/u/3019665?v=3","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"body":"I'm confused. It looks like @patricksnape said this won't work in PR ( https://github.com/conda/conda-build/pull/1189 ) and had fixed it. Yet I'm seeing this showing up in [`master`]( https://github.com/conda/conda-build/blob/327d9a358e2b849a05e1cd33bb5f917dd96b9bb8/conda_build/windows.py#L169-L170 ) anyways. This is likely the cause of the issues [seen]( https://github.com/conda-forge/conda-smithy/pull/392#issuecomment-269534107 ) by @mwcraig . Was this intentional or just a bad merge?","created_at":"2016-12-29T01:40:12Z","updated_at":"2016-12-29T01:40:12Z","html_url":"https://github.com/conda/conda-build/pull/1049#discussion_r94094298","pull_request_url":"https://api.github.com/repos/conda/conda-build/pulls/1049","_links":{"self":{"href":"https://api.github.com/repos/conda/conda-build/pulls/comments/94094298"},"html":{"href":"https://github.com/conda/conda-build/pull/1049#discussion_r94094298"},"pull_request":{"href":"https://api.github.com/repos/conda/conda-build/pulls/1049"}}},"pull_request":{"url":"https://api.github.com/repos/conda/conda-build/pulls/1049","id":75185117,"html_url":"https://github.com/conda/conda-build/pull/1049","diff_url":"https://github.com/conda/conda-build/pull/1049.diff","patch_url":"https://github.com/conda/conda-build/pull/1049.patch","issue_url":"https://api.github.com/repos/conda/conda-build/issues/1049","number":1049,"state":"closed","locked":false,"title":"handle exception when VS2008 is not installed","user":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=3","gravatar_id":"","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"body":"Fixes #1048 - but needs testing.\n","created_at":"2016-06-24T23:05:18Z","updated_at":"2016-12-29T01:40:12Z","closed_at":"2016-06-27T18:59:13Z","merged_at":"2016-06-27T18:59:13Z","merge_commit_sha":"c8e4275f21471c8a3d82f18589ff99a4fd1f14eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/conda/conda-build/pulls/1049/commits","review_comments_url":"https://api.github.com/repos/conda/conda-build/pulls/1049/comments","review_comment_url":"https://api.github.com/repos/conda/conda-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conda/conda-build/issues/1049/comments","statuses_url":"https://api.github.com/repos/conda/conda-build/statuses/3dc6416a4efe52c3ec5698286d18d505f021d3c1","head":{"label":"msarahan:handle_no_vs2008","ref":"handle_no_vs2008","sha":"3dc6416a4efe52c3ec5698286d18d505f021d3c1","user":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=3","gravatar_id":"","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"repo":{"id":47360743,"name":"conda-build","full_name":"msarahan/conda-build","owner":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=3","gravatar_id":"","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msarahan/conda-build","description":"Commands and tools for building conda packages","fork":true,"url":"https://api.github.com/repos/msarahan/conda-build","forks_url":"https://api.github.com/repos/msarahan/conda-build/forks","keys_url":"https://api.github.com/repos/msarahan/conda-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msarahan/conda-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msarahan/conda-build/teams","hooks_url":"https://api.github.com/repos/msarahan/conda-build/hooks","issue_events_url":"https://api.github.com/repos/msarahan/conda-build/issues/events{/number}","events_url":"https://api.github.com/repos/msarahan/conda-build/events","assignees_url":"https://api.github.com/repos/msarahan/conda-build/assignees{/user}","branches_url":"https://api.github.com/repos/msarahan/conda-build/branches{/branch}","tags_url":"https://api.github.com/repos/msarahan/conda-build/tags","blobs_url":"https://api.github.com/repos/msarahan/conda-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msarahan/conda-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msarahan/conda-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/msarahan/conda-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msarahan/conda-build/statuses/{sha}","languages_url":"https://api.github.com/repos/msarahan/conda-build/languages","stargazers_url":"https://api.github.com/repos/msarahan/conda-build/stargazers","contributors_url":"https://api.github.com/repos/msarahan/conda-build/contributors","subscribers_url":"https://api.github.com/repos/msarahan/conda-build/subscribers","subscription_url":"https://api.github.com/repos/msarahan/conda-build/subscription","commits_url":"https://api.github.com/repos/msarahan/conda-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/msarahan/conda-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/msarahan/conda-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/msarahan/conda-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/msarahan/conda-build/contents/{+path}","compare_url":"https://api.github.com/repos/msarahan/conda-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msarahan/conda-build/merges","archive_url":"https://api.github.com/repos/msarahan/conda-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msarahan/conda-build/downloads","issues_url":"https://api.github.com/repos/msarahan/conda-build/issues{/number}","pulls_url":"https://api.github.com/repos/msarahan/conda-build/pulls{/number}","milestones_url":"https://api.github.com/repos/msarahan/conda-build/milestones{/number}","notifications_url":"https://api.github.com/repos/msarahan/conda-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msarahan/conda-build/labels{/name}","releases_url":"https://api.github.com/repos/msarahan/conda-build/releases{/id}","deployments_url":"https://api.github.com/repos/msarahan/conda-build/deployments","created_at":"2015-12-03T21:11:31Z","updated_at":"2016-06-06T02:29:35Z","pushed_at":"2016-12-22T18:35:04Z","git_url":"git://github.com/msarahan/conda-build.git","ssh_url":"git@github.com:msarahan/conda-build.git","clone_url":"https://github.com/msarahan/conda-build.git","svn_url":"https://github.com/msarahan/conda-build","homepage":null,"size":4234,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conda:1.21.x","ref":"1.21.x","sha":"4cfd1f62587a0fdc4a7a04b9bc35104b92a2dc98","user":{"login":"conda","id":6392739,"avatar_url":"https://avatars.githubusercontent.com/u/6392739?v=3","gravatar_id":"","url":"https://api.github.com/users/conda","html_url":"https://github.com/conda","followers_url":"https://api.github.com/users/conda/followers","following_url":"https://api.github.com/users/conda/following{/other_user}","gists_url":"https://api.github.com/users/conda/gists{/gist_id}","starred_url":"https://api.github.com/users/conda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda/subscriptions","organizations_url":"https://api.github.com/users/conda/orgs","repos_url":"https://api.github.com/users/conda/repos","events_url":"https://api.github.com/users/conda/events{/privacy}","received_events_url":"https://api.github.com/users/conda/received_events","type":"Organization","site_admin":false},"repo":{"id":16008423,"name":"conda-build","full_name":"conda/conda-build","owner":{"login":"conda","id":6392739,"avatar_url":"https://avatars.githubusercontent.com/u/6392739?v=3","gravatar_id":"","url":"https://api.github.com/users/conda","html_url":"https://github.com/conda","followers_url":"https://api.github.com/users/conda/followers","following_url":"https://api.github.com/users/conda/following{/other_user}","gists_url":"https://api.github.com/users/conda/gists{/gist_id}","starred_url":"https://api.github.com/users/conda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda/subscriptions","organizations_url":"https://api.github.com/users/conda/orgs","repos_url":"https://api.github.com/users/conda/repos","events_url":"https://api.github.com/users/conda/events{/privacy}","received_events_url":"https://api.github.com/users/conda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conda/conda-build","description":"Commands and tools for building conda packages","fork":false,"url":"https://api.github.com/repos/conda/conda-build","forks_url":"https://api.github.com/repos/conda/conda-build/forks","keys_url":"https://api.github.com/repos/conda/conda-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conda/conda-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conda/conda-build/teams","hooks_url":"https://api.github.com/repos/conda/conda-build/hooks","issue_events_url":"https://api.github.com/repos/conda/conda-build/issues/events{/number}","events_url":"https://api.github.com/repos/conda/conda-build/events","assignees_url":"https://api.github.com/repos/conda/conda-build/assignees{/user}","branches_url":"https://api.github.com/repos/conda/conda-build/branches{/branch}","tags_url":"https://api.github.com/repos/conda/conda-build/tags","blobs_url":"https://api.github.com/repos/conda/conda-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conda/conda-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conda/conda-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/conda/conda-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conda/conda-build/statuses/{sha}","languages_url":"https://api.github.com/repos/conda/conda-build/languages","stargazers_url":"https://api.github.com/repos/conda/conda-build/stargazers","contributors_url":"https://api.github.com/repos/conda/conda-build/contributors","subscribers_url":"https://api.github.com/repos/conda/conda-build/subscribers","subscription_url":"https://api.github.com/repos/conda/conda-build/subscription","commits_url":"https://api.github.com/repos/conda/conda-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/conda/conda-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/conda/conda-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/conda/conda-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/conda/conda-build/contents/{+path}","compare_url":"https://api.github.com/repos/conda/conda-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conda/conda-build/merges","archive_url":"https://api.github.com/repos/conda/conda-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conda/conda-build/downloads","issues_url":"https://api.github.com/repos/conda/conda-build/issues{/number}","pulls_url":"https://api.github.com/repos/conda/conda-build/pulls{/number}","milestones_url":"https://api.github.com/repos/conda/conda-build/milestones{/number}","notifications_url":"https://api.github.com/repos/conda/conda-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conda/conda-build/labels{/name}","releases_url":"https://api.github.com/repos/conda/conda-build/releases{/id}","deployments_url":"https://api.github.com/repos/conda/conda-build/deployments","created_at":"2014-01-17T18:46:21Z","updated_at":"2016-12-20T10:48:24Z","pushed_at":"2016-12-22T18:42:36Z","git_url":"git://github.com/conda/conda-build.git","ssh_url":"git@github.com:conda/conda-build.git","clone_url":"https://github.com/conda/conda-build.git","svn_url":"https://github.com/conda/conda-build","homepage":null,"size":4200,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":369,"forks":125,"open_issues":369,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conda/conda-build/pulls/1049"},"html":{"href":"https://github.com/conda/conda-build/pull/1049"},"issue":{"href":"https://api.github.com/repos/conda/conda-build/issues/1049"},"comments":{"href":"https://api.github.com/repos/conda/conda-build/issues/1049/comments"},"review_comments":{"href":"https://api.github.com/repos/conda/conda-build/pulls/1049/comments"},"review_comment":{"href":"https://api.github.com/repos/conda/conda-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conda/conda-build/pulls/1049/commits"},"statuses":{"href":"https://api.github.com/repos/conda/conda-build/statuses/3dc6416a4efe52c3ec5698286d18d505f021d3c1"}}}}
{"actor":{"display_login":"jakirkham"}}