{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/eidolon/pulls/comments/51967656","id":51967656,"diff_hunk":"@@ -54,3 +54,19 @@ extension Optional where Wrapped: Occupiable {\n         return !isNilOrEmpty\n     }\n }\n+\n+// TODO: PR this into Moya","path":"Kiosk/App/SwiftExtensions.swift","position":5,"original_position":5,"commit_id":"6cb0bbdfc1b4127380ccb2fd3495212157e39479","original_commit_id":"6cb0bbdfc1b4127380ccb2fd3495212157e39479","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"body":"I have so PR'd: https://github.com/Moya/Moya/pull/401\r\n\r\nHowever, we're a major version of Moya behind, and I don't have time to update right now. We'll put this on the back-burner for now.","created_at":"2016-02-05T01:52:47Z","updated_at":"2016-02-05T01:52:47Z","html_url":"https://github.com/artsy/eidolon/pull/584#discussion_r51967656","pull_request_url":"https://api.github.com/repos/artsy/eidolon/pulls/584","_links":{"self":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/comments/51967656"},"html":{"href":"https://github.com/artsy/eidolon/pull/584#discussion_r51967656"},"pull_request":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/584"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/eidolon/pulls/584","id":58378121,"html_url":"https://github.com/artsy/eidolon/pull/584","diff_url":"https://github.com/artsy/eidolon/pull/584.diff","patch_url":"https://github.com/artsy/eidolon/pull/584.patch","issue_url":"https://api.github.com/repos/artsy/eidolon/issues/584","number":584,"state":"open","locked":false,"title":"Fixes problem authenticating with bidder number / phone number","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"body":"The [issue](https://trello.com/c/6IZJd0oU/252-showstopper-kiosk-users-who-enter-bidder-number-should-be-asked-for-pin-and-not-email-address) was caused by a change to Moya's change in error-handling that I missed.\r\n\r\nI took a look around for other places using the old logic, found one, but it was only related to logging. \r\n\r\nOh, also added an admin button to bid the next increment of a sale artwork:\r\n\r\n<img width=\"1137\" alt=\"screen shot 2016-02-04 at 8 45 36 pm\" src=\"https://cloud.githubusercontent.com/assets/498212/12835673/45528e06-cb80-11e5-8b27-dee90f50cb64.png\">\r\n\r\nShould speed up debugging :smiley_cat: ","created_at":"2016-02-05T01:46:42Z","updated_at":"2016-02-05T01:52:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bc8b8aaf86c3b63590f281a3f6e08fa6ccaff69","assignee":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/artsy/eidolon/pulls/584/commits","review_comments_url":"https://api.github.com/repos/artsy/eidolon/pulls/584/comments","review_comment_url":"https://api.github.com/repos/artsy/eidolon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/eidolon/issues/584/comments","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/6cb0bbdfc1b4127380ccb2fd3495212157e39479","head":{"label":"artsy:bug-fix","ref":"bug-fix","sha":"6cb0bbdfc1b4127380ccb2fd3495212157e39479","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22613546,"name":"eidolon","full_name":"artsy/eidolon","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eidolon","description":"The Artsy Auction Kiosk App","fork":false,"url":"https://api.github.com/repos/artsy/eidolon","forks_url":"https://api.github.com/repos/artsy/eidolon/forks","keys_url":"https://api.github.com/repos/artsy/eidolon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eidolon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eidolon/teams","hooks_url":"https://api.github.com/repos/artsy/eidolon/hooks","issue_events_url":"https://api.github.com/repos/artsy/eidolon/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eidolon/events","assignees_url":"https://api.github.com/repos/artsy/eidolon/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eidolon/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eidolon/tags","blobs_url":"https://api.github.com/repos/artsy/eidolon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eidolon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eidolon/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eidolon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eidolon/languages","stargazers_url":"https://api.github.com/repos/artsy/eidolon/stargazers","contributors_url":"https://api.github.com/repos/artsy/eidolon/contributors","subscribers_url":"https://api.github.com/repos/artsy/eidolon/subscribers","subscription_url":"https://api.github.com/repos/artsy/eidolon/subscription","commits_url":"https://api.github.com/repos/artsy/eidolon/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eidolon/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eidolon/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eidolon/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eidolon/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eidolon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eidolon/merges","archive_url":"https://api.github.com/repos/artsy/eidolon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eidolon/downloads","issues_url":"https://api.github.com/repos/artsy/eidolon/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eidolon/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eidolon/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eidolon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eidolon/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eidolon/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/eidolon/deployments","created_at":"2014-08-04T17:38:26Z","updated_at":"2016-02-04T14:41:28Z","pushed_at":"2016-02-05T01:48:37Z","git_url":"git://github.com/artsy/eidolon.git","ssh_url":"git@github.com:artsy/eidolon.git","clone_url":"https://github.com/artsy/eidolon.git","svn_url":"https://github.com/artsy/eidolon","homepage":"http://artsy.github.io/blog/2014/11/13/eidolon-retrospective/","size":80058,"stargazers_count":1002,"watchers_count":1002,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":36,"forks":98,"open_issues":36,"watchers":1002,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"24e36a69bbafb4ef6dbe4d98b575ceb4e1d8345f","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22613546,"name":"eidolon","full_name":"artsy/eidolon","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eidolon","description":"The Artsy Auction Kiosk App","fork":false,"url":"https://api.github.com/repos/artsy/eidolon","forks_url":"https://api.github.com/repos/artsy/eidolon/forks","keys_url":"https://api.github.com/repos/artsy/eidolon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eidolon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eidolon/teams","hooks_url":"https://api.github.com/repos/artsy/eidolon/hooks","issue_events_url":"https://api.github.com/repos/artsy/eidolon/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eidolon/events","assignees_url":"https://api.github.com/repos/artsy/eidolon/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eidolon/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eidolon/tags","blobs_url":"https://api.github.com/repos/artsy/eidolon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eidolon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eidolon/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eidolon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eidolon/languages","stargazers_url":"https://api.github.com/repos/artsy/eidolon/stargazers","contributors_url":"https://api.github.com/repos/artsy/eidolon/contributors","subscribers_url":"https://api.github.com/repos/artsy/eidolon/subscribers","subscription_url":"https://api.github.com/repos/artsy/eidolon/subscription","commits_url":"https://api.github.com/repos/artsy/eidolon/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eidolon/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eidolon/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eidolon/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eidolon/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eidolon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eidolon/merges","archive_url":"https://api.github.com/repos/artsy/eidolon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eidolon/downloads","issues_url":"https://api.github.com/repos/artsy/eidolon/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eidolon/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eidolon/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eidolon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eidolon/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eidolon/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/eidolon/deployments","created_at":"2014-08-04T17:38:26Z","updated_at":"2016-02-04T14:41:28Z","pushed_at":"2016-02-05T01:48:37Z","git_url":"git://github.com/artsy/eidolon.git","ssh_url":"git@github.com:artsy/eidolon.git","clone_url":"https://github.com/artsy/eidolon.git","svn_url":"https://github.com/artsy/eidolon","homepage":"http://artsy.github.io/blog/2014/11/13/eidolon-retrospective/","size":80058,"stargazers_count":1002,"watchers_count":1002,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":36,"forks":98,"open_issues":36,"watchers":1002,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/584"},"html":{"href":"https://github.com/artsy/eidolon/pull/584"},"issue":{"href":"https://api.github.com/repos/artsy/eidolon/issues/584"},"comments":{"href":"https://api.github.com/repos/artsy/eidolon/issues/584/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/584/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/584/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/eidolon/statuses/6cb0bbdfc1b4127380ccb2fd3495212157e39479"}}}}