{"action":"created","issue":{"url":"https://api.github.com/repos/umts/jobapps/issues/234","repository_url":"https://api.github.com/repos/umts/jobapps","labels_url":"https://api.github.com/repos/umts/jobapps/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/umts/jobapps/issues/234/comments","events_url":"https://api.github.com/repos/umts/jobapps/issues/234/events","html_url":"https://github.com/umts/jobapps/pull/234","id":149850157,"number":234,"title":"Added EEO Data page spec","user":{"login":"enragednuke","id":9220151,"avatar_url":"https://avatars.githubusercontent.com/u/9220151?v=3","gravatar_id":"","url":"https://api.github.com/users/enragednuke","html_url":"https://github.com/enragednuke","followers_url":"https://api.github.com/users/enragednuke/followers","following_url":"https://api.github.com/users/enragednuke/following{/other_user}","gists_url":"https://api.github.com/users/enragednuke/gists{/gist_id}","starred_url":"https://api.github.com/users/enragednuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enragednuke/subscriptions","organizations_url":"https://api.github.com/users/enragednuke/orgs","repos_url":"https://api.github.com/users/enragednuke/repos","events_url":"https://api.github.com/users/enragednuke/events{/privacy}","received_events_url":"https://api.github.com/users/enragednuke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-20T18:34:23Z","updated_at":"2016-04-21T15:32:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/umts/jobapps/pulls/234","html_url":"https://github.com/umts/jobapps/pull/234","diff_url":"https://github.com/umts/jobapps/pull/234.diff","patch_url":"https://github.com/umts/jobapps/pull/234.patch"},"body":"Closes #232 \r\n\r\nAlso, as a rule of thumb: CSS IDs should not be duplicated (much like IDs in Rails, which **can't** be duplicated). If you find a situation where you think something should have the same ID, it's likely supposed to be a class instead. Use IDs as a delimiter between objects of the same class or if there is only one object that would reasonably have said ID (like the `data-table`, but even then it seems more like a class than an ID). I've modified the CSS to reflect this as well."},"comment":{"url":"https://api.github.com/repos/umts/jobapps/issues/comments/212975800","html_url":"https://github.com/umts/jobapps/pull/234#issuecomment-212975800","issue_url":"https://api.github.com/repos/umts/jobapps/issues/234","id":212975800,"user":{"login":"enragednuke","id":9220151,"avatar_url":"https://avatars.githubusercontent.com/u/9220151?v=3","gravatar_id":"","url":"https://api.github.com/users/enragednuke","html_url":"https://github.com/enragednuke","followers_url":"https://api.github.com/users/enragednuke/followers","following_url":"https://api.github.com/users/enragednuke/following{/other_user}","gists_url":"https://api.github.com/users/enragednuke/gists{/gist_id}","starred_url":"https://api.github.com/users/enragednuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enragednuke/subscriptions","organizations_url":"https://api.github.com/users/enragednuke/orgs","repos_url":"https://api.github.com/users/enragednuke/repos","events_url":"https://api.github.com/users/enragednuke/events{/privacy}","received_events_url":"https://api.github.com/users/enragednuke/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T15:32:35Z","updated_at":"2016-04-21T15:32:35Z","body":"I like IDs, but only as a delimiting attribute. I think flat out ignoring a major part of CSS is poor practice (in my opinion). It's also useful as a pseudo-comment in which it's a **id**entifier as to what that object is. It is also very useful for readability such that future employees can easily understand what it is without having to look into its content.\r\n\r\nWhat's the reason you dislike shared examples? It's a convenient way of reducing the repetitiveness of specs that are similar. I can't really think how they'd be bad (but I'm sure you have a good reason for thinking so).\r\n\r\nAs for the key inputs, I'll try to have it work like that. Not sure if it's just as simple as giving it the same name as the loop variable in the shared example, but I'll see what I can do. "}}