{"action":"closed","number":105,"pull_request":{"url":"https://api.github.com/repos/HowardHinnant/date/pulls/105","id":96375772,"html_url":"https://github.com/HowardHinnant/date/pull/105","diff_url":"https://github.com/HowardHinnant/date/pull/105.diff","patch_url":"https://github.com/HowardHinnant/date/pull/105.patch","issue_url":"https://api.github.com/repos/HowardHinnant/date/issues/105","number":105,"state":"closed","locked":false,"title":"move file scope static variables into functions to deal with static initialization order problem","user":{"login":"jgzhuang","id":24278694,"avatar_url":"https://avatars.githubusercontent.com/u/24278694?v=3","gravatar_id":"","url":"https://api.github.com/users/jgzhuang","html_url":"https://github.com/jgzhuang","followers_url":"https://api.github.com/users/jgzhuang/followers","following_url":"https://api.github.com/users/jgzhuang/following{/other_user}","gists_url":"https://api.github.com/users/jgzhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/jgzhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgzhuang/subscriptions","organizations_url":"https://api.github.com/users/jgzhuang/orgs","repos_url":"https://api.github.com/users/jgzhuang/repos","events_url":"https://api.github.com/users/jgzhuang/events{/privacy}","received_events_url":"https://api.github.com/users/jgzhuang/received_events","type":"User","site_admin":false},"body":"The problem happened when initializing a file scope static variable in another translation unit and it calls date::locate_zone(), but the static variables in tz.cpp are not initialized yet. \r\n\r\nTHE FOLLOWING DISCLAIMER APPLIES TO ALL SOFTWARE CODE AND OTHER MATERIALS CONTRIBUTED IN CONNECTION WITH THIS SOFTWARE:\r\nTHIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS “AS IS” AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.\r\nONLY THE SOFTWARE CODE AND OTHER MATERIALS CONTRIBUTED IN CONNECTION WITH THIS SOFTWARE, IF ANY, THAT ARE ATTACHED TO (OR OTHERWISE ACCOMPANY) THIS SUBMISSION (AND ORDINARY COURSE CONTRIBUTIONS OF FUTURES PATCHES THERETO) ARE TO BE CONSIDERED A CONTRIBUTION.  NO OTHER SOFTWARE CODE OR MATERIALS ARE A CONTRIBUTION. \r\n","created_at":"2016-12-03T00:19:12Z","updated_at":"2016-12-14T16:01:02Z","closed_at":"2016-12-14T16:01:02Z","merged_at":null,"merge_commit_sha":"a32e30b31bf8d712871e9fd40314d1593a4a2b2a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HowardHinnant/date/pulls/105/commits","review_comments_url":"https://api.github.com/repos/HowardHinnant/date/pulls/105/comments","review_comment_url":"https://api.github.com/repos/HowardHinnant/date/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HowardHinnant/date/issues/105/comments","statuses_url":"https://api.github.com/repos/HowardHinnant/date/statuses/d8bbe6b9bfdd9dd797cbe96b27c803754c33d830","head":{"label":"jgzhuang:staticinit","ref":"staticinit","sha":"d8bbe6b9bfdd9dd797cbe96b27c803754c33d830","user":{"login":"jgzhuang","id":24278694,"avatar_url":"https://avatars.githubusercontent.com/u/24278694?v=3","gravatar_id":"","url":"https://api.github.com/users/jgzhuang","html_url":"https://github.com/jgzhuang","followers_url":"https://api.github.com/users/jgzhuang/followers","following_url":"https://api.github.com/users/jgzhuang/following{/other_user}","gists_url":"https://api.github.com/users/jgzhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/jgzhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgzhuang/subscriptions","organizations_url":"https://api.github.com/users/jgzhuang/orgs","repos_url":"https://api.github.com/users/jgzhuang/repos","events_url":"https://api.github.com/users/jgzhuang/events{/privacy}","received_events_url":"https://api.github.com/users/jgzhuang/received_events","type":"User","site_admin":false},"repo":{"id":75219210,"name":"date","full_name":"jgzhuang/date","owner":{"login":"jgzhuang","id":24278694,"avatar_url":"https://avatars.githubusercontent.com/u/24278694?v=3","gravatar_id":"","url":"https://api.github.com/users/jgzhuang","html_url":"https://github.com/jgzhuang","followers_url":"https://api.github.com/users/jgzhuang/followers","following_url":"https://api.github.com/users/jgzhuang/following{/other_user}","gists_url":"https://api.github.com/users/jgzhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/jgzhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgzhuang/subscriptions","organizations_url":"https://api.github.com/users/jgzhuang/orgs","repos_url":"https://api.github.com/users/jgzhuang/repos","events_url":"https://api.github.com/users/jgzhuang/events{/privacy}","received_events_url":"https://api.github.com/users/jgzhuang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgzhuang/date","description":"A date and time library based on the C++11 (and beyond) <chrono> header","fork":true,"url":"https://api.github.com/repos/jgzhuang/date","forks_url":"https://api.github.com/repos/jgzhuang/date/forks","keys_url":"https://api.github.com/repos/jgzhuang/date/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgzhuang/date/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgzhuang/date/teams","hooks_url":"https://api.github.com/repos/jgzhuang/date/hooks","issue_events_url":"https://api.github.com/repos/jgzhuang/date/issues/events{/number}","events_url":"https://api.github.com/repos/jgzhuang/date/events","assignees_url":"https://api.github.com/repos/jgzhuang/date/assignees{/user}","branches_url":"https://api.github.com/repos/jgzhuang/date/branches{/branch}","tags_url":"https://api.github.com/repos/jgzhuang/date/tags","blobs_url":"https://api.github.com/repos/jgzhuang/date/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgzhuang/date/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgzhuang/date/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgzhuang/date/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgzhuang/date/statuses/{sha}","languages_url":"https://api.github.com/repos/jgzhuang/date/languages","stargazers_url":"https://api.github.com/repos/jgzhuang/date/stargazers","contributors_url":"https://api.github.com/repos/jgzhuang/date/contributors","subscribers_url":"https://api.github.com/repos/jgzhuang/date/subscribers","subscription_url":"https://api.github.com/repos/jgzhuang/date/subscription","commits_url":"https://api.github.com/repos/jgzhuang/date/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgzhuang/date/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgzhuang/date/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgzhuang/date/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgzhuang/date/contents/{+path}","compare_url":"https://api.github.com/repos/jgzhuang/date/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgzhuang/date/merges","archive_url":"https://api.github.com/repos/jgzhuang/date/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgzhuang/date/downloads","issues_url":"https://api.github.com/repos/jgzhuang/date/issues{/number}","pulls_url":"https://api.github.com/repos/jgzhuang/date/pulls{/number}","milestones_url":"https://api.github.com/repos/jgzhuang/date/milestones{/number}","notifications_url":"https://api.github.com/repos/jgzhuang/date/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgzhuang/date/labels{/name}","releases_url":"https://api.github.com/repos/jgzhuang/date/releases{/id}","deployments_url":"https://api.github.com/repos/jgzhuang/date/deployments","created_at":"2016-11-30T19:22:32Z","updated_at":"2016-11-30T19:22:33Z","pushed_at":"2016-12-03T00:12:52Z","git_url":"git://github.com/jgzhuang/date.git","ssh_url":"git@github.com:jgzhuang/date.git","clone_url":"https://github.com/jgzhuang/date.git","svn_url":"https://github.com/jgzhuang/date","homepage":null,"size":1990,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HowardHinnant:master","ref":"master","sha":"8a3aeb566bbf934b03abc042f97480d1e31f30ef","user":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"repo":{"id":39283837,"name":"date","full_name":"HowardHinnant/date","owner":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HowardHinnant/date","description":"A date and time library based on the C++11 (and beyond) <chrono> header","fork":false,"url":"https://api.github.com/repos/HowardHinnant/date","forks_url":"https://api.github.com/repos/HowardHinnant/date/forks","keys_url":"https://api.github.com/repos/HowardHinnant/date/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HowardHinnant/date/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HowardHinnant/date/teams","hooks_url":"https://api.github.com/repos/HowardHinnant/date/hooks","issue_events_url":"https://api.github.com/repos/HowardHinnant/date/issues/events{/number}","events_url":"https://api.github.com/repos/HowardHinnant/date/events","assignees_url":"https://api.github.com/repos/HowardHinnant/date/assignees{/user}","branches_url":"https://api.github.com/repos/HowardHinnant/date/branches{/branch}","tags_url":"https://api.github.com/repos/HowardHinnant/date/tags","blobs_url":"https://api.github.com/repos/HowardHinnant/date/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HowardHinnant/date/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HowardHinnant/date/git/refs{/sha}","trees_url":"https://api.github.com/repos/HowardHinnant/date/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HowardHinnant/date/statuses/{sha}","languages_url":"https://api.github.com/repos/HowardHinnant/date/languages","stargazers_url":"https://api.github.com/repos/HowardHinnant/date/stargazers","contributors_url":"https://api.github.com/repos/HowardHinnant/date/contributors","subscribers_url":"https://api.github.com/repos/HowardHinnant/date/subscribers","subscription_url":"https://api.github.com/repos/HowardHinnant/date/subscription","commits_url":"https://api.github.com/repos/HowardHinnant/date/commits{/sha}","git_commits_url":"https://api.github.com/repos/HowardHinnant/date/git/commits{/sha}","comments_url":"https://api.github.com/repos/HowardHinnant/date/comments{/number}","issue_comment_url":"https://api.github.com/repos/HowardHinnant/date/issues/comments{/number}","contents_url":"https://api.github.com/repos/HowardHinnant/date/contents/{+path}","compare_url":"https://api.github.com/repos/HowardHinnant/date/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HowardHinnant/date/merges","archive_url":"https://api.github.com/repos/HowardHinnant/date/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HowardHinnant/date/downloads","issues_url":"https://api.github.com/repos/HowardHinnant/date/issues{/number}","pulls_url":"https://api.github.com/repos/HowardHinnant/date/pulls{/number}","milestones_url":"https://api.github.com/repos/HowardHinnant/date/milestones{/number}","notifications_url":"https://api.github.com/repos/HowardHinnant/date/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HowardHinnant/date/labels{/name}","releases_url":"https://api.github.com/repos/HowardHinnant/date/releases{/id}","deployments_url":"https://api.github.com/repos/HowardHinnant/date/deployments","created_at":"2015-07-18T02:34:13Z","updated_at":"2016-12-13T22:31:15Z","pushed_at":"2016-12-07T15:48:14Z","git_url":"git://github.com/HowardHinnant/date.git","ssh_url":"git@github.com:HowardHinnant/date.git","clone_url":"https://github.com/HowardHinnant/date.git","svn_url":"https://github.com/HowardHinnant/date","homepage":null,"size":2160,"stargazers_count":440,"watchers_count":440,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":25,"forks":71,"open_issues":25,"watchers":440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HowardHinnant/date/pulls/105"},"html":{"href":"https://github.com/HowardHinnant/date/pull/105"},"issue":{"href":"https://api.github.com/repos/HowardHinnant/date/issues/105"},"comments":{"href":"https://api.github.com/repos/HowardHinnant/date/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/HowardHinnant/date/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/HowardHinnant/date/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HowardHinnant/date/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/HowardHinnant/date/statuses/d8bbe6b9bfdd9dd797cbe96b27c803754c33d830"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":44,"deletions":31,"changed_files":1}}
{"actor":{"display_login":"HowardHinnant"}}