{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/53321450","id":53321450,"diff_hunk":"@@ -0,0 +1,358 @@\n+/* This file is part of VoltDB.\n+ * Copyright (C) 2008-2016 VoltDB Inc.\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining\n+ * a copy of this software and associated documentation files (the\n+ * \"Software\"), to deal in the Software without restriction, including\n+ * without limitation the rights to use, copy, modify, merge, publish,\n+ * distribute, sublicense, and/or sell copies of the Software, and to\n+ * permit persons to whom the Software is furnished to do so, subject to\n+ * the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be\n+ * included in all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.\n+ * IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR\n+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,\n+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR\n+ * OTHER DEALINGS IN THE SOFTWARE.\n+ */\n+package org.voltdb.regressionsuites;\n+\n+import java.io.IOException;\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+import org.voltdb.BackendTarget;\n+import org.voltdb.VoltTable;\n+import org.voltdb.client.Client;\n+import org.voltdb.client.NoConnectionsException;\n+import org.voltdb.client.ProcCallException;\n+import org.voltdb.compiler.VoltProjectBuilder;\n+import org.voltdb.types.GeographyPointValue;\n+import org.voltdb.types.GeographyValue;\n+import org.voltdb.utils.PolygonFactory;\n+\n+import scala.util.Random;\n+\n+public class TestGeospatialIndexes extends RegressionSuite{\n+\n+    public TestGeospatialIndexes(String name) {\n+        super(name);\n+    }\n+\n+    private class PolygonPoints {\n+        private GeographyValue      m_polygon;\n+        private GeographyPointValue m_center;\n+        private GeographyPointValue m_pointInside;                          // point inside polygon which is not the center\n+        private GeographyPointValue m_polygonCellVertex;                    // point which is the vertex of surrounding cell regular convex polygon but is outside the polygon","path":"tests/frontend/org/voltdb/regressionsuites/TestGeospatialIndexes.java","position":51,"original_position":51,"commit_id":"f060de04b25502c248681e189612f07a01738ceb","original_commit_id":"f060de04b25502c248681e189612f07a01738ceb","user":{"login":"hhakimi53","id":13318654,"avatar_url":"https://avatars.githubusercontent.com/u/13318654?v=3","gravatar_id":"","url":"https://api.github.com/users/hhakimi53","html_url":"https://github.com/hhakimi53","followers_url":"https://api.github.com/users/hhakimi53/followers","following_url":"https://api.github.com/users/hhakimi53/following{/other_user}","gists_url":"https://api.github.com/users/hhakimi53/gists{/gist_id}","starred_url":"https://api.github.com/users/hhakimi53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhakimi53/subscriptions","organizations_url":"https://api.github.com/users/hhakimi53/orgs","repos_url":"https://api.github.com/users/hhakimi53/repos","events_url":"https://api.github.com/users/hhakimi53/events{/privacy}","received_events_url":"https://api.github.com/users/hhakimi53/received_events","type":"User","site_admin":false},"body":"Sure, will rename the variable. ","created_at":"2016-02-18T14:39:48Z","updated_at":"2016-02-18T14:39:48Z","html_url":"https://github.com/VoltDB/voltdb/pull/3286#discussion_r53321450","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3286","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/53321450"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/3286#discussion_r53321450"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3286"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3286","id":59653213,"html_url":"https://github.com/VoltDB/voltdb/pull/3286","diff_url":"https://github.com/VoltDB/voltdb/pull/3286.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/3286.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/3286","number":3286,"state":"open","locked":false,"title":"Add regression-test to test end-to-end functionality for Contains() with geospatial index","user":{"login":"hhakimi53","id":13318654,"avatar_url":"https://avatars.githubusercontent.com/u/13318654?v=3","gravatar_id":"","url":"https://api.github.com/users/hhakimi53","html_url":"https://github.com/hhakimi53","followers_url":"https://api.github.com/users/hhakimi53/followers","following_url":"https://api.github.com/users/hhakimi53/following{/other_user}","gists_url":"https://api.github.com/users/hhakimi53/gists{/gist_id}","starred_url":"https://api.github.com/users/hhakimi53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhakimi53/subscriptions","organizations_url":"https://api.github.com/users/hhakimi53/orgs","repos_url":"https://api.github.com/users/hhakimi53/repos","events_url":"https://api.github.com/users/hhakimi53/events{/privacy}","received_events_url":"https://api.github.com/users/hhakimi53/received_events","type":"User","site_admin":false},"body":"Adding test to regression suite to verify the Contains() operation on table which is indexed on geo columns produces correct answer by verify it against the result of contains on data-set using non-indexed table. \r\n\r\nIn this review request create index on geo columns in commented out and can be enabled once the geo indexes are available.","created_at":"2016-02-17T14:44:37Z","updated_at":"2016-02-18T14:39:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e41a4e82885573dc52dd66920c96d4e73c77ab0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3286/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3286/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/3286/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/f060de04b25502c248681e189612f07a01738ceb","head":{"label":"VoltDB:ENG-9300-tests","ref":"ENG-9300-tests","sha":"f060de04b25502c248681e189612f07a01738ceb","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2016-02-17T03:05:20Z","pushed_at":"2016-02-18T12:05:26Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":530444,"stargazers_count":739,"watchers_count":739,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":32,"forks":218,"open_issues":32,"watchers":739,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"c39eca4a006395331f2ff41b7aa861de6afe9d7b","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2016-02-17T03:05:20Z","pushed_at":"2016-02-18T12:05:26Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":530444,"stargazers_count":739,"watchers_count":739,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":32,"forks":218,"open_issues":32,"watchers":739,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3286"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/3286"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/3286"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/3286/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3286/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3286/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/f060de04b25502c248681e189612f07a01738ceb"}}}}