{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7548","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7548/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7548/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7548/events","html_url":"https://github.com/nodejs/node/pull/7548","id":163929732,"number":7548,"title":"fs: fix long symlinks in realpath","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2016-07-05T19:42:03Z","updated_at":"2016-07-11T21:17:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7548","html_url":"https://github.com/nodejs/node/pull/7548","diff_url":"https://github.com/nodejs/node/pull/7548.diff","patch_url":"https://github.com/nodejs/node/pull/7548.patch"},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nfs, uv\r\n\r\n\r\n##### Description of change\r\n```\r\nfs: allow realpath to resolve deep symlinks\r\n\r\nrealpath(3) would fail if the symbolic link depth was too deep. If ELOOP\r\nis encountered then resolve the path in parts until the entire thing is\r\nresolved.\r\n```\r\n```\r\nuv: expose uv_strerror() to JS API\r\n\r\nRetrieving the error message along with the error name is useful. So\r\nexposing to the JS API.\r\n\r\nAlso add additional -UV_ERRNO_MAX range check to ErrName() to help\r\nprevent the following comment from libuv documentation on both\r\nuv_strerror() and uv_err_name():\r\n\r\n   Leaks a few bytes of memory when you call it with an unknown error\r\n   code.\r\n```\r\n\r\nFixes: https://github.com/nodejs/node/issues/7175\r\n\r\nThis definitely isn't the prettiest code I've written. Want to get feedback while I finish up the tests.\r\n\r\nR=@bnoordhuis \r\nR=@saghul \r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/231868120","html_url":"https://github.com/nodejs/node/pull/7548#issuecomment-231868120","issue_url":"https://api.github.com/repos/nodejs/node/issues/7548","id":231868120,"user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T21:17:42Z","updated_at":"2016-07-11T21:17:42Z","body":"@addaleax Heh. I'm somewhere between JS and C++ here. Thanks for the reminder what I'm actually coding."}}
{"actor":{"display_login":"trevnorris"}}