{"action":"closed","number":10924,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10924","id":75171041,"html_url":"https://github.com/joomla/joomla-cms/pull/10924","diff_url":"https://github.com/joomla/joomla-cms/pull/10924.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10924.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10924","number":10924,"state":"closed","locked":false,"title":"Reduce the getModel methods from 3 lines into one","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"body":"#### Summary of Changes\r\n\r\n```php\r\n-\t\t$model = parent::getModel($name, $prefix, $config);\r\n-\r\n-\t\treturn $model;\r\n+\t\treturn parent::getModel($name, $prefix, $config);\r\n``` \r\n\r\nreduce the method from 3 lines into one\r\n\r\n#### Testing Instructions\r\n\r\nCode Review and / or make sure the components still works as before","created_at":"2016-06-24T20:43:52Z","updated_at":"2016-07-16T14:58:09Z","closed_at":"2016-07-16T14:58:09Z","merged_at":"2016-07-16T14:58:09Z","merge_commit_sha":"8ac8c83784e83b605117ab26ac648044c7784594","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/15","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.6.1","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/15/labels","id":1819592,"number":15,"title":"Joomla 3.6.1","description":"","creator":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars.githubusercontent.com/u/1296369?v=3","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":56,"state":"open","created_at":"2016-06-10T09:18:44Z","updated_at":"2016-07-16T14:58:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10924/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10924/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10924/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/5d2f4c72362e7959c684102530dafad16e5b29c7","head":{"label":"zero-24:model","ref":"model","sha":"5d2f4c72362e7959c684102530dafad16e5b29c7","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"repo":{"id":52710604,"name":"joomla-cms","full_name":"zero-24/joomla-cms","owner":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zero-24/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/zero-24/joomla-cms","forks_url":"https://api.github.com/repos/zero-24/joomla-cms/forks","keys_url":"https://api.github.com/repos/zero-24/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero-24/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero-24/joomla-cms/teams","hooks_url":"https://api.github.com/repos/zero-24/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/zero-24/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/zero-24/joomla-cms/events","assignees_url":"https://api.github.com/repos/zero-24/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/zero-24/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/zero-24/joomla-cms/tags","blobs_url":"https://api.github.com/repos/zero-24/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero-24/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero-24/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero-24/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero-24/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/zero-24/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/zero-24/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/zero-24/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/zero-24/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/zero-24/joomla-cms/subscription","commits_url":"https://api.github.com/repos/zero-24/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero-24/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero-24/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero-24/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero-24/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/zero-24/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero-24/joomla-cms/merges","archive_url":"https://api.github.com/repos/zero-24/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero-24/joomla-cms/downloads","issues_url":"https://api.github.com/repos/zero-24/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/zero-24/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/zero-24/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/zero-24/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero-24/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/zero-24/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/zero-24/joomla-cms/deployments","created_at":"2016-02-28T07:45:35Z","updated_at":"2016-02-28T07:45:49Z","pushed_at":"2016-07-16T12:01:14Z","git_url":"git://github.com/zero-24/joomla-cms.git","ssh_url":"git@github.com:zero-24/joomla-cms.git","clone_url":"https://github.com/zero-24/joomla-cms.git","svn_url":"https://github.com/zero-24/joomla-cms","homepage":"https://www.joomla.org","size":158265,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"b2604b120c7f1fd31fdbac045a6fd076cb6d2922","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-07-14T16:27:14Z","pushed_at":"2016-07-16T14:58:09Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":292793,"stargazers_count":2075,"watchers_count":2075,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2229,"mirror_url":null,"open_issues_count":527,"forks":2229,"open_issues":527,"watchers":2075,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10924"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/10924"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10924"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10924/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10924/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10924/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/5d2f4c72362e7959c684102530dafad16e5b29c7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"roland-d","id":359377,"avatar_url":"https://avatars.githubusercontent.com/u/359377?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":15,"deletions":44,"changed_files":15}}
{"actor":{"display_login":"roland-d"}}