{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3705","repository_url":"https://api.github.com/repos/mozilla/fxa-content-server","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3705/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3705/comments","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3705/events","html_url":"https://github.com/mozilla/fxa-content-server/issues/3705","id":153003753,"number":3705,"title":"Sanely handle regeneration of flowId and flowBeginTime after sign-out","user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"labels":[{"id":246046222,"url":"https://api.github.com/repos/mozilla/fxa-content-server/labels/waffle:backlog","name":"waffle:backlog","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones/98","html_url":"https://github.com/mozilla/fxa-content-server/milestones/FxA-41:signin%20funnel%20metrics","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones/98/labels","id":1932998,"number":98,"title":"FxA-41:signin funnel metrics","description":"","creator":{"login":"vladikoff","id":128755,"avatar_url":"https://avatars.githubusercontent.com/u/128755?v=3","gravatar_id":"","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":16,"state":"open","created_at":"2016-08-09T17:52:47Z","updated_at":"2016-11-14T21:33:27Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-05-04T12:51:06Z","updated_at":"2016-11-14T23:43:49Z","closed_at":null,"body":"Currently, `flowId` and `flowBeginTime` are set once, when the view is first loaded. This is fine in most cases but, if a user signs in, signs out and then signs in again, all without refreshing the page, the same values for `flowId` and `flowBeginTime` will be sent to the auth server and emitted in ~~activity~~ flow events.\n\nPerhaps that's not a problem and the metrics queries will be fine regardless. If that is the case, we can happily close this issue.\n\nBut if it is a problem, we need to regenerate the `flowId` and `flowBeginTime` after a user signs out. ~~The `flowId` part is easy because it is already generated client-side. The `flowBeginTime` must come from the server though, which makes the change less clear-cut.~~\n\n~~One option would be to add a `GET /time` route expressly for this purpose. Alternatively, we could modify the existing `GET /config` route to include a timestamp instead.~~\n\n~~Either way, there is some concern about setting `flowBeginTime` on the `metricsContext` model in two different ways. After initialisation, it is rendered into the DOM via the `data-flow-begin` attribute on the `body` element and set on the model from there. Adding an XHR request that sets it again later might be confusing down the line.~~\n\n~~To ease those concerns, it might be prudent ditch the `data-flow-begin` attribute in favour of using an XHR request in all cases. And that change may itself entail some extra handling for the case where a sign-in request is made before the server time response has been received (if such a case is possible).~~\n"},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments/260500743","html_url":"https://github.com/mozilla/fxa-content-server/issues/3705#issuecomment-260500743","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3705","id":260500743,"user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T23:43:49Z","updated_at":"2016-11-14T23:43:49Z","body":"In today's meeting, it was pointed out this probably explains the weird flows reported in [bug 1316463](https://bugzilla.mozilla.org/show_bug.cgi?id=1316463)."}}
{"actor":{"display_login":"philbooth"}}