{"action":"created","issue":{"url":"https://api.github.com/repos/npm/npm/issues/11305","repository_url":"https://api.github.com/repos/npm/npm","labels_url":"https://api.github.com/repos/npm/npm/issues/11305/labels{/name}","comments_url":"https://api.github.com/repos/npm/npm/issues/11305/comments","events_url":"https://api.github.com/repos/npm/npm/issues/11305/events","html_url":"https://github.com/npm/npm/pull/11305","id":129182066,"number":11305,"title":"lifecycle: remove early exit callback if we cannot write to working directory. Also fix log message","user":{"login":"joeferner","id":808857,"avatar_url":"https://avatars.githubusercontent.com/u/808857?v=3","gravatar_id":"","url":"https://api.github.com/users/joeferner","html_url":"https://github.com/joeferner","followers_url":"https://api.github.com/users/joeferner/followers","following_url":"https://api.github.com/users/joeferner/following{/other_user}","gists_url":"https://api.github.com/users/joeferner/gists{/gist_id}","starred_url":"https://api.github.com/users/joeferner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeferner/subscriptions","organizations_url":"https://api.github.com/users/joeferner/orgs","repos_url":"https://api.github.com/users/joeferner/repos","events_url":"https://api.github.com/users/joeferner/events{/privacy}","received_events_url":"https://api.github.com/users/joeferner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/npm/npm/labels/in-progress","name":"in-progress","color":"FF82CE"},{"url":"https://api.github.com/repos/npm/npm/labels/lifecycle","name":"lifecycle","color":"C59782"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-01-27T15:47:12Z","updated_at":"2016-09-15T06:33:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/npm/npm/pulls/11305","html_url":"https://github.com/npm/npm/pull/11305","diff_url":"https://github.com/npm/npm/pull/11305.diff","patch_url":"https://github.com/npm/npm/pull/11305.patch"},"body":"Currently if the working directory is not writable by the current user and you run `sudo npm install`. The warning message and callback referenced in this PR get invoked resulting in a `WARN` message but not a failure of the install (exit code 0), because npm reduces privileges while running.\r\n\r\nThis PR changes this behavior by continuing to try and run and possibly failing the install (exit code 1) if it cannot run to completion.\r\n\r\nThis PR also fixes the existing log message which currently prints `cannot run in wd %s %s (wd=%s)...` instead of performing the proper substitutions."},"comment":{"url":"https://api.github.com/repos/npm/npm/issues/comments/247247292","html_url":"https://github.com/npm/npm/pull/11305#issuecomment-247247292","issue_url":"https://api.github.com/repos/npm/npm/issues/11305","id":247247292,"user":{"login":"brendo","id":69268,"avatar_url":"https://avatars.githubusercontent.com/u/69268?v=3","gravatar_id":"","url":"https://api.github.com/users/brendo","html_url":"https://github.com/brendo","followers_url":"https://api.github.com/users/brendo/followers","following_url":"https://api.github.com/users/brendo/following{/other_user}","gists_url":"https://api.github.com/users/brendo/gists{/gist_id}","starred_url":"https://api.github.com/users/brendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendo/subscriptions","organizations_url":"https://api.github.com/users/brendo/orgs","repos_url":"https://api.github.com/users/brendo/repos","events_url":"https://api.github.com/users/brendo/events{/privacy}","received_events_url":"https://api.github.com/users/brendo/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T06:33:39Z","updated_at":"2016-09-15T06:33:39Z","body":"I really the part of this PR where is corrects the log message and stops this rabbit hole:\r\n\r\n- What's a `wd`?\r\n- What is `%s`, why didn't it get populated? How do I get that to work? Did I do something wrong?\r\n- Where do I even start to debug this?"}}
{"actor":{"display_login":"brendo"}}