{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5626","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5626/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5626/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5626/events","html_url":"https://github.com/cockroachdb/cockroach/pull/5626","id":143848536,"number":5626,"title":"storage: Change sequence cache to an abort cache","user":{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"milestone":null,"comments":20,"created_at":"2016-03-27T21:13:54Z","updated_at":"2016-03-29T21:21:35Z","closed_at":"2016-03-29T20:28:10Z","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5626","html_url":"https://github.com/cockroachdb/cockroach/pull/5626","diff_url":"https://github.com/cockroachdb/cockroach/pull/5626.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/5626.patch"},"body":"… txn\r\n\r\nNothing is dependent on the potentially many sequence cache entries\r\nper transaction so this is just a simplification and for certain use\r\ncases may yield a performance improvement.\r\n\r\nAdded a unittest for copying sequence caches when they may now have\r\nan overlapping entry which must be parsed to determine which entry\r\nhas the highest epoch and sequence numbers. The previous code had a\r\nbug with overcounting stats in the event of overlap.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/5626)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/203110342","html_url":"https://github.com/cockroachdb/cockroach/pull/5626#issuecomment-203110342","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5626","id":203110342,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T21:21:35Z","updated_at":"2016-03-29T21:21:35Z","body":"\n\n\n\nReviewed 8 of 8 files at r7.\nReview status: all files reviewed at latest revision, 7 unresolved discussions.\n\n---\n\n*[keys/keys.go, line 105 \\[r6\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/5626#-KE2q4ouslh7ic9EGi94:-KE3EWO1pya6_sdR3VZi:1715104529) ([raw file](https://github.com/cockroachdb/cockroach/blob/d7cf107f93711dac0f0a6ad6bd9359d942f080bb/keys/keys.go#L105)):*\nheh, that's pretty unclear.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/5626)*\n<!-- Sent from Reviewable.io -->\n"}}