{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/74442499","id":74442499,"diff_hunk":"@@ -186,11 +150,13 @@ void main (void)\n     printf (\"Error: could not look up print function, expression results won't be printed\\n\");\n   }\n \n-  shell_register_app_cmd_handler (shell_cmd_handler);\n-  shell_init (\"js> \", commands);\n-  /* Don't call jerry_cleanup() here, as shell_init() returns after setting\n-     up background task to process shell input, and that task calls\n-     shell_cmd_handler(), etc. as callbacks. This processing happens in\n-     the infinite loop, so JerryScript doesn't need to be de-initialized. */\n+  while (1) {","path":"targets/zephyr/src/main-zephyr.c","position":84,"original_position":84,"commit_id":"0c6577ba7cd0494a7ca7c9b427bf4523899b3a17","original_commit_id":"0c6577ba7cd0494a7ca7c9b427bf4523899b3a17","user":{"login":"akosthekiss","id":9976482,"avatar_url":"https://avatars.githubusercontent.com/u/9976482?v=3","gravatar_id":"","url":"https://api.github.com/users/akosthekiss","html_url":"https://github.com/akosthekiss","followers_url":"https://api.github.com/users/akosthekiss/followers","following_url":"https://api.github.com/users/akosthekiss/following{/other_user}","gists_url":"https://api.github.com/users/akosthekiss/gists{/gist_id}","starred_url":"https://api.github.com/users/akosthekiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akosthekiss/subscriptions","organizations_url":"https://api.github.com/users/akosthekiss/orgs","repos_url":"https://api.github.com/users/akosthekiss/repos","events_url":"https://api.github.com/users/akosthekiss/events{/privacy}","received_events_url":"https://api.github.com/users/akosthekiss/received_events","type":"User","site_admin":false},"body":"(style) put curly brace on a new line","created_at":"2016-08-11T15:20:02Z","updated_at":"2016-08-11T15:20:02Z","html_url":"https://github.com/Samsung/jerryscript/pull/1260#discussion_r74442499","pull_request_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1260","_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/74442499"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/1260#discussion_r74442499"},"pull_request":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1260"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1260","id":80968670,"html_url":"https://github.com/Samsung/jerryscript/pull/1260","diff_url":"https://github.com/Samsung/jerryscript/pull/1260.diff","patch_url":"https://github.com/Samsung/jerryscript/pull/1260.patch","issue_url":"https://api.github.com/repos/Samsung/jerryscript/issues/1260","number":1260,"state":"open","locked":false,"title":"targets/zephyr/Makefile.zephyr: Use zephyr_getline module for line input.","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars.githubusercontent.com/u/500451?v=3","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"body":"The original implementation used shell facility, but it was designed for\r\na unix shell like input, and automatically tokenized it into\r\nspace-separated \"words\", with limit of 10 (i.e. 9 spaces per line). For\r\nJavaScript input, it is quite easy to have more than 9 spaces per line,\r\nand get error:\r\n\r\nToo many parameters (max 10)\r\n\r\nAfter consultation with upstream\r\n(https://jira.zephyrproject.org/browse/ZEP-532) it was decided that the\r\nbest approach is to skip using shell facility and use Zephyr console\r\nfacility. That however requires some Zephyr-specific boilerplate code.\r\nThis code was implemented as reusable modules in\r\nhttps://github.com/pfalcon/zephyr_console_helpers repository, to be\r\nusable for other console-based projects too. zephyr_getline.h/c in this\r\ncommits are direct imports from this repository.\r\n\r\nJerryScript-DCO-1.0-Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org","created_at":"2016-08-11T14:36:13Z","updated_at":"2016-08-11T15:20:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd9b8599a8496b0cedea628ba5626917d11447bd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1260/commits","review_comments_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1260/comments","review_comment_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/issues/1260/comments","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/0c6577ba7cd0494a7ca7c9b427bf4523899b3a17","head":{"label":"pfalcon:zephyr-getline","ref":"zephyr-getline","sha":"0c6577ba7cd0494a7ca7c9b427bf4523899b3a17","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars.githubusercontent.com/u/500451?v=3","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"repo":{"id":63186138,"name":"jerryscript","full_name":"pfalcon/jerryscript","owner":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars.githubusercontent.com/u/500451?v=3","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfalcon/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things. http://samsung.github.io/jerryscript","fork":true,"url":"https://api.github.com/repos/pfalcon/jerryscript","forks_url":"https://api.github.com/repos/pfalcon/jerryscript/forks","keys_url":"https://api.github.com/repos/pfalcon/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfalcon/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfalcon/jerryscript/teams","hooks_url":"https://api.github.com/repos/pfalcon/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/pfalcon/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/pfalcon/jerryscript/events","assignees_url":"https://api.github.com/repos/pfalcon/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/pfalcon/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/pfalcon/jerryscript/tags","blobs_url":"https://api.github.com/repos/pfalcon/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfalcon/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfalcon/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfalcon/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfalcon/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/pfalcon/jerryscript/languages","stargazers_url":"https://api.github.com/repos/pfalcon/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/pfalcon/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/pfalcon/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/pfalcon/jerryscript/subscription","commits_url":"https://api.github.com/repos/pfalcon/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfalcon/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfalcon/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfalcon/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfalcon/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/pfalcon/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfalcon/jerryscript/merges","archive_url":"https://api.github.com/repos/pfalcon/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfalcon/jerryscript/downloads","issues_url":"https://api.github.com/repos/pfalcon/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/pfalcon/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/pfalcon/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/pfalcon/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfalcon/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/pfalcon/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/pfalcon/jerryscript/deployments","created_at":"2016-07-12T19:19:43Z","updated_at":"2016-07-12T19:19:46Z","pushed_at":"2016-08-11T14:42:12Z","git_url":"git://github.com/pfalcon/jerryscript.git","ssh_url":"git@github.com:pfalcon/jerryscript.git","clone_url":"https://github.com/pfalcon/jerryscript.git","svn_url":"https://github.com/pfalcon/jerryscript","homepage":"","size":24799,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"91e29120d29c4a82de555921f1dd2d09e7fe2d7d","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"Samsung/jerryscript","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things. http://samsung.github.io/jerryscript","fork":false,"url":"https://api.github.com/repos/Samsung/jerryscript","forks_url":"https://api.github.com/repos/Samsung/jerryscript/forks","keys_url":"https://api.github.com/repos/Samsung/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/jerryscript/teams","hooks_url":"https://api.github.com/repos/Samsung/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/Samsung/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/jerryscript/events","assignees_url":"https://api.github.com/repos/Samsung/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/jerryscript/tags","blobs_url":"https://api.github.com/repos/Samsung/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/jerryscript/languages","stargazers_url":"https://api.github.com/repos/Samsung/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/Samsung/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/Samsung/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/Samsung/jerryscript/subscription","commits_url":"https://api.github.com/repos/Samsung/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/jerryscript/merges","archive_url":"https://api.github.com/repos/Samsung/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/jerryscript/downloads","issues_url":"https://api.github.com/repos/Samsung/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2016-08-11T12:39:00Z","pushed_at":"2016-08-11T14:59:55Z","git_url":"git://github.com/Samsung/jerryscript.git","ssh_url":"git@github.com:Samsung/jerryscript.git","clone_url":"https://github.com/Samsung/jerryscript.git","svn_url":"https://github.com/Samsung/jerryscript","homepage":"","size":27822,"stargazers_count":1456,"watchers_count":1456,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":165,"mirror_url":null,"open_issues_count":52,"forks":165,"open_issues":52,"watchers":1456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1260"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/1260"},"issue":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/1260"},"comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/1260/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1260/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1260/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/jerryscript/statuses/0c6577ba7cd0494a7ca7c9b427bf4523899b3a17"}}}}
{"actor":{"display_login":"akosthekiss"}}