{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/comments/66712757","id":66712757,"diff_hunk":"@@ -57,26 +58,26 @@ function run(env, args, output, callback) {\n // Note that we're cheating horribly here. Ideally all of this logic is within\n // wct-sauce. The trouble is that we also want WCT's configuration lookup logic,\n // and that's not (yet) cleanly exposed.\n-function runSauceTunnel(env, args, output, callback) {\n-  var done = wrapCallback(output, callback);\n+export function runSauceTunnel(env: void, args: string[], output: NodeJS.WritableStream, callback: (err: any) => void) {\n+  const done = wrapCallback(output, callback);\n \n-  var diskOptions = config.fromDisk();\n-  var baseOptions = diskOptions.plugins && diskOptions.plugins.sauce || diskOptions.sauce || {};\n+  const diskOptions = config.fromDisk();\n+  const baseOptions: config.Config = diskOptions.plugins && diskOptions.plugins['sauce'] || diskOptions.sauce || {};","path":"runner/cli.ts","position":71,"original_position":71,"commit_id":"2f35a9532dfb630327f0c9deed73ad42dc02701c","original_commit_id":"f632c138f8ef60472622be6b082ae1b3ce79363b","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"Wrapped and clarified.","created_at":"2016-06-11T22:40:22Z","updated_at":"2016-06-11T22:40:22Z","html_url":"https://github.com/Polymer/web-component-tester/pull/314#discussion_r66712757","pull_request_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/314","_links":{"self":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/comments/66712757"},"html":{"href":"https://github.com/Polymer/web-component-tester/pull/314#discussion_r66712757"},"pull_request":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/314","id":71337618,"html_url":"https://github.com/Polymer/web-component-tester/pull/314","diff_url":"https://github.com/Polymer/web-component-tester/pull/314.diff","patch_url":"https://github.com/Polymer/web-component-tester/pull/314.patch","issue_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/314","number":314,"state":"open","locked":false,"title":"Convert node portion of WCT to typescript","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"This is a no impact, zero-functionality-changes port. It'll be followed up by more aggressive cleanup steps, but this was easier to do as an incremental step (and also ensured that I'd actually be able to keep up with any changes that may happen on master while this PR is reviewed).\r\n\r\nI followed the conventions in https://github.com/Polymer/tools-common where possible (e.g. not changing the directory structure yet, leaving jshint for js hinting for now, as this PR can only get so large). I also didn't have luck getting noLib compilation working.","created_at":"2016-05-25T06:40:47Z","updated_at":"2016-06-11T22:40:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dd08bb55c123312d3518003e9e718408c686360","assignee":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/314/commits","review_comments_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/314/comments","review_comment_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/314/comments","statuses_url":"https://api.github.com/repos/Polymer/web-component-tester/statuses/2f35a9532dfb630327f0c9deed73ad42dc02701c","head":{"label":"Polymer:typescript","ref":"typescript","sha":"2f35a9532dfb630327f0c9deed73ad42dc02701c","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":23168206,"name":"web-component-tester","full_name":"Polymer/web-component-tester","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/web-component-tester","description":"","fork":false,"url":"https://api.github.com/repos/Polymer/web-component-tester","forks_url":"https://api.github.com/repos/Polymer/web-component-tester/forks","keys_url":"https://api.github.com/repos/Polymer/web-component-tester/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/web-component-tester/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/web-component-tester/teams","hooks_url":"https://api.github.com/repos/Polymer/web-component-tester/hooks","issue_events_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/web-component-tester/events","assignees_url":"https://api.github.com/repos/Polymer/web-component-tester/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/web-component-tester/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/web-component-tester/tags","blobs_url":"https://api.github.com/repos/Polymer/web-component-tester/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/web-component-tester/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/web-component-tester/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/web-component-tester/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/web-component-tester/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/web-component-tester/languages","stargazers_url":"https://api.github.com/repos/Polymer/web-component-tester/stargazers","contributors_url":"https://api.github.com/repos/Polymer/web-component-tester/contributors","subscribers_url":"https://api.github.com/repos/Polymer/web-component-tester/subscribers","subscription_url":"https://api.github.com/repos/Polymer/web-component-tester/subscription","commits_url":"https://api.github.com/repos/Polymer/web-component-tester/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/web-component-tester/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/web-component-tester/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/web-component-tester/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/web-component-tester/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/web-component-tester/merges","archive_url":"https://api.github.com/repos/Polymer/web-component-tester/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/web-component-tester/downloads","issues_url":"https://api.github.com/repos/Polymer/web-component-tester/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/web-component-tester/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/web-component-tester/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/web-component-tester/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/web-component-tester/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/web-component-tester/deployments","created_at":"2014-08-20T23:59:40Z","updated_at":"2016-06-10T09:32:23Z","pushed_at":"2016-06-11T01:27:13Z","git_url":"git://github.com/Polymer/web-component-tester.git","ssh_url":"git@github.com:Polymer/web-component-tester.git","clone_url":"https://github.com/Polymer/web-component-tester.git","svn_url":"https://github.com/Polymer/web-component-tester","homepage":"","size":5607,"stargazers_count":328,"watchers_count":328,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":78,"forks":79,"open_issues":78,"watchers":328,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"f37fc017bbabdbc40b7287bfc1f55865404355ea","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":23168206,"name":"web-component-tester","full_name":"Polymer/web-component-tester","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/web-component-tester","description":"","fork":false,"url":"https://api.github.com/repos/Polymer/web-component-tester","forks_url":"https://api.github.com/repos/Polymer/web-component-tester/forks","keys_url":"https://api.github.com/repos/Polymer/web-component-tester/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/web-component-tester/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/web-component-tester/teams","hooks_url":"https://api.github.com/repos/Polymer/web-component-tester/hooks","issue_events_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/web-component-tester/events","assignees_url":"https://api.github.com/repos/Polymer/web-component-tester/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/web-component-tester/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/web-component-tester/tags","blobs_url":"https://api.github.com/repos/Polymer/web-component-tester/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/web-component-tester/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/web-component-tester/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/web-component-tester/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/web-component-tester/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/web-component-tester/languages","stargazers_url":"https://api.github.com/repos/Polymer/web-component-tester/stargazers","contributors_url":"https://api.github.com/repos/Polymer/web-component-tester/contributors","subscribers_url":"https://api.github.com/repos/Polymer/web-component-tester/subscribers","subscription_url":"https://api.github.com/repos/Polymer/web-component-tester/subscription","commits_url":"https://api.github.com/repos/Polymer/web-component-tester/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/web-component-tester/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/web-component-tester/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/web-component-tester/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/web-component-tester/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/web-component-tester/merges","archive_url":"https://api.github.com/repos/Polymer/web-component-tester/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/web-component-tester/downloads","issues_url":"https://api.github.com/repos/Polymer/web-component-tester/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/web-component-tester/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/web-component-tester/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/web-component-tester/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/web-component-tester/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/web-component-tester/deployments","created_at":"2014-08-20T23:59:40Z","updated_at":"2016-06-10T09:32:23Z","pushed_at":"2016-06-11T01:27:13Z","git_url":"git://github.com/Polymer/web-component-tester.git","ssh_url":"git@github.com:Polymer/web-component-tester.git","clone_url":"https://github.com/Polymer/web-component-tester.git","svn_url":"https://github.com/Polymer/web-component-tester","homepage":"","size":5607,"stargazers_count":328,"watchers_count":328,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":78,"forks":79,"open_issues":78,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/314"},"html":{"href":"https://github.com/Polymer/web-component-tester/pull/314"},"issue":{"href":"https://api.github.com/repos/Polymer/web-component-tester/issues/314"},"comments":{"href":"https://api.github.com/repos/Polymer/web-component-tester/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/web-component-tester/statuses/2f35a9532dfb630327f0c9deed73ad42dc02701c"}}}}
{"actor":{"display_login":"rictic"}}