{"action":"created","issue":{"url":"https://api.github.com/repos/exponentjs/exponent-sdk/issues/5","repository_url":"https://api.github.com/repos/exponentjs/exponent-sdk","labels_url":"https://api.github.com/repos/exponentjs/exponent-sdk/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/exponentjs/exponent-sdk/issues/5/comments","events_url":"https://api.github.com/repos/exponentjs/exponent-sdk/issues/5/events","html_url":"https://github.com/exponentjs/exponent-sdk/issues/5","id":178081284,"number":5,"title":"Flow issues","user":{"login":"sstur","id":369384,"avatar_url":"https://avatars.githubusercontent.com/u/369384?v=3","gravatar_id":"","url":"https://api.github.com/users/sstur","html_url":"https://github.com/sstur","followers_url":"https://api.github.com/users/sstur/followers","following_url":"https://api.github.com/users/sstur/following{/other_user}","gists_url":"https://api.github.com/users/sstur/gists{/gist_id}","starred_url":"https://api.github.com/users/sstur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstur/subscriptions","organizations_url":"https://api.github.com/users/sstur/orgs","repos_url":"https://api.github.com/users/sstur/repos","events_url":"https://api.github.com/users/sstur/events{/privacy}","received_events_url":"https://api.github.com/users/sstur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-20T14:46:14Z","updated_at":"2016-10-04T19:07:32Z","closed_at":null,"body":"When I `npm install` this package in a RN project (latest, v0.33; using Flow v0.30) there are flow errors. I'm not sure if you should be checking in your Flow-ified code and your `.flowconfig` to npm. I think the typical way to use Flow with npm packages is to strip flow types before publishing. But I guess that would mean using flow-typed to include declarations for your library so maybe that's not a solution either.\r\n\r\nJust thought you should be aware of the issue.\r\n\r\n[Edit] To be clear the errors happen when I try to typecheck my project's code using Flow. This is done as part of our CI flow so it is necessary to have this check pass."},"comment":{"url":"https://api.github.com/repos/exponentjs/exponent-sdk/issues/comments/251482847","html_url":"https://github.com/exponentjs/exponent-sdk/issues/5#issuecomment-251482847","issue_url":"https://api.github.com/repos/exponentjs/exponent-sdk/issues/5","id":251482847,"user":{"login":"brunolemos","id":619186,"avatar_url":"https://avatars.githubusercontent.com/u/619186?v=3","gravatar_id":"","url":"https://api.github.com/users/brunolemos","html_url":"https://github.com/brunolemos","followers_url":"https://api.github.com/users/brunolemos/followers","following_url":"https://api.github.com/users/brunolemos/following{/other_user}","gists_url":"https://api.github.com/users/brunolemos/gists{/gist_id}","starred_url":"https://api.github.com/users/brunolemos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunolemos/subscriptions","organizations_url":"https://api.github.com/users/brunolemos/orgs","repos_url":"https://api.github.com/users/brunolemos/repos","events_url":"https://api.github.com/users/brunolemos/events{/privacy}","received_events_url":"https://api.github.com/users/brunolemos/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T19:07:32Z","updated_at":"2016-10-04T19:07:32Z","body":"Currently, you can add this to your `.flowconfig`:\r\n\r\n```\r\n[ignore]\r\n\r\n# ...\r\n\r\n# Ignore some node modules that contain errors\r\n.*/node_modules/@exponent\r\n.*/node_modules/exponent\r\n.*/node_modules/react-native-experimental-navigation\r\n.*/node_modules/react-native-tab-view\r\n```\r\n\r\nYou can also add `.*/node_modules/*` to ignore all external packages."}}
{"actor":{"display_login":"brunolemos"}}