{"action":"created","issue":{"url":"https://api.github.com/repos/dustinryerson/liferay-portal/issues/98","repository_url":"https://api.github.com/repos/dustinryerson/liferay-portal","labels_url":"https://api.github.com/repos/dustinryerson/liferay-portal/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/dustinryerson/liferay-portal/issues/98/comments","events_url":"https://api.github.com/repos/dustinryerson/liferay-portal/issues/98/events","html_url":"https://github.com/dustinryerson/liferay-portal/pull/98","id":197759542,"number":98,"title":"LPS-69852 address where scheduleEntry trigger is not set","user":{"login":"ericyanLr","id":12802270,"avatar_url":"https://avatars.githubusercontent.com/u/12802270?v=3","gravatar_id":"","url":"https://api.github.com/users/ericyanLr","html_url":"https://github.com/ericyanLr","followers_url":"https://api.github.com/users/ericyanLr/followers","following_url":"https://api.github.com/users/ericyanLr/following{/other_user}","gists_url":"https://api.github.com/users/ericyanLr/gists{/gist_id}","starred_url":"https://api.github.com/users/ericyanLr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericyanLr/subscriptions","organizations_url":"https://api.github.com/users/ericyanLr/orgs","repos_url":"https://api.github.com/users/ericyanLr/repos","events_url":"https://api.github.com/users/ericyanLr/events{/privacy}","received_events_url":"https://api.github.com/users/ericyanLr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-27T21:22:04Z","updated_at":"2016-12-27T21:22:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dustinryerson/liferay-portal/pulls/98","html_url":"https://github.com/dustinryerson/liferay-portal/pull/98","diff_url":"https://github.com/dustinryerson/liferay-portal/pull/98.diff","patch_url":"https://github.com/dustinryerson/liferay-portal/pull/98.patch"},"body":"Hi @dustinryerson,\r\n\r\nOriginal ticket: [LPP-23620](https://issues.liferay.com/browse/LPP-23620)\r\nForum Post: [Changes to MEMORY_CLUSTERED jobs cause cluster nodes to fail startup](https://in.liferay.com/web/support/forums/-/message_boards/message/27667801)\r\n\r\n**Main Issue**\r\nCurrently, MEMORY_CLUSTERED jobs are throwing SchedulerExceptions when certain properties are set.\r\nFor Example:\r\n- Announcements - Portal Properties\r\n    - `announcements.entry.check.interval=-1`\r\n- LDAP - System Settings\r\n    - Setting **import-interval = -1** in the LDAP configuratio using System Settings in Liferay DXP\r\n\r\nThis issue was introduced after changes from [LPS-58449](https://issues.liferay.com/browse/LPS-58449), which refactored the scheduler.\r\n\r\n**Fix - Details**\r\nThis fix was made based on the stipulation that a scheduled job should not be scheduled if the quartz trigger is not set.\r\n\r\nIn our case, a quartz trigger is not set when the **time-interval** is less than 0.\r\nFor our examples, the **time-interval** is set to **-1**.\r\nReference: [QuartzTriggerFactory.java#L50](https://github.com/liferay/liferay-portal-ee/blob/fix-pack-de-9-7010/modules/apps/foundation/portal-scheduler/portal-scheduler-quartz/src/main/java/com/liferay/portal/scheduler/quartz/internal/QuartzTriggerFactory.java#L50)\r\n\r\n----\r\n**Note**\r\nPreston mentioned that this pull request should also be reviewed by Tina, since she works on many fixes involving the scheduler and clustering.\r\n\r\nPlease let me know if you have any questions.\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/dustinryerson/liferay-portal/issues/comments/269384494","html_url":"https://github.com/dustinryerson/liferay-portal/pull/98#issuecomment-269384494","issue_url":"https://api.github.com/repos/dustinryerson/liferay-portal/issues/98","id":269384494,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars.githubusercontent.com/u/4502793?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T21:22:24Z","updated_at":"2016-12-27T21:22:24Z","body":"<h1>Build started.</h1><p>Jenkins is currently running tests.</p><h4>Base Branch:</h4><p>Branch Name: <a href=\"https://github.com/liferay/liferay-portal/tree/master\">master</a></p><h4>Job Summary:</h4><p>Job Link: <a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest(master)/863/\">test-portal-acceptance-pullrequest(master)</a></p><p><b>For more details click <a href=\"https://test-1-7.liferay.com//userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/863/jenkins-report.html\">here</a>.</b></p>"}}
{"actor":{"display_login":"liferay-continuous-integration"}}