{"action":"closed","number":1031,"pull_request":{"url":"https://api.github.com/repos/socketio/socket.io-client/pulls/1031","id":95361851,"html_url":"https://github.com/socketio/socket.io-client/pull/1031","diff_url":"https://github.com/socketio/socket.io-client/pull/1031.diff","patch_url":"https://github.com/socketio/socket.io-client/pull/1031.patch","issue_url":"https://api.github.com/repos/socketio/socket.io-client/issues/1031","number":1031,"state":"closed","locked":false,"title":"add some detail about Manager in documentation","user":{"login":"zizyzhang","id":6605411,"avatar_url":"https://avatars.githubusercontent.com/u/6605411?v=3","gravatar_id":"","url":"https://api.github.com/users/zizyzhang","html_url":"https://github.com/zizyzhang","followers_url":"https://api.github.com/users/zizyzhang/followers","following_url":"https://api.github.com/users/zizyzhang/following{/other_user}","gists_url":"https://api.github.com/users/zizyzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/zizyzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizyzhang/subscriptions","organizations_url":"https://api.github.com/users/zizyzhang/orgs","repos_url":"https://api.github.com/users/zizyzhang/repos","events_url":"https://api.github.com/users/zizyzhang/events{/privacy}","received_events_url":"https://api.github.com/users/zizyzhang/received_events","type":"User","site_admin":false},"body":"*Note*: the `socket.io.js` file is the generated output of `make socket.io.js`, and should not be manually modified.\r\n\r\n### The kind of change this PR does introduce\r\n\r\n* [ ] a bug fix\r\n* [ ] a new feature\r\n* [x] an update to the documentation\r\n* [ ] a code change that improves performance\r\n* [ ] other\r\n\r\n### Current behaviour\r\nThe documentation about Manager is not very clear.\r\n\r\n### New behaviour\r\nAdd some detail about Manager in documentation\r\n\r\n### Other information (e.g. related issues)\r\n\r\n\r\n","created_at":"2016-11-26T05:30:06Z","updated_at":"2016-12-10T21:22:13Z","closed_at":"2016-12-10T21:22:13Z","merged_at":null,"merge_commit_sha":"c6ec21a19ed1c6e43681897044c437b78e07b0da","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/socketio/socket.io-client/pulls/1031/commits","review_comments_url":"https://api.github.com/repos/socketio/socket.io-client/pulls/1031/comments","review_comment_url":"https://api.github.com/repos/socketio/socket.io-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socketio/socket.io-client/issues/1031/comments","statuses_url":"https://api.github.com/repos/socketio/socket.io-client/statuses/95d365f79aee1a86219b4c675d394a9165c65175","head":{"label":"zizyzhang:master","ref":"master","sha":"95d365f79aee1a86219b4c675d394a9165c65175","user":{"login":"zizyzhang","id":6605411,"avatar_url":"https://avatars.githubusercontent.com/u/6605411?v=3","gravatar_id":"","url":"https://api.github.com/users/zizyzhang","html_url":"https://github.com/zizyzhang","followers_url":"https://api.github.com/users/zizyzhang/followers","following_url":"https://api.github.com/users/zizyzhang/following{/other_user}","gists_url":"https://api.github.com/users/zizyzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/zizyzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizyzhang/subscriptions","organizations_url":"https://api.github.com/users/zizyzhang/orgs","repos_url":"https://api.github.com/users/zizyzhang/repos","events_url":"https://api.github.com/users/zizyzhang/events{/privacy}","received_events_url":"https://api.github.com/users/zizyzhang/received_events","type":"User","site_admin":false},"repo":{"id":74806125,"name":"socket.io-client","full_name":"zizyzhang/socket.io-client","owner":{"login":"zizyzhang","id":6605411,"avatar_url":"https://avatars.githubusercontent.com/u/6605411?v=3","gravatar_id":"","url":"https://api.github.com/users/zizyzhang","html_url":"https://github.com/zizyzhang","followers_url":"https://api.github.com/users/zizyzhang/followers","following_url":"https://api.github.com/users/zizyzhang/following{/other_user}","gists_url":"https://api.github.com/users/zizyzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/zizyzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizyzhang/subscriptions","organizations_url":"https://api.github.com/users/zizyzhang/orgs","repos_url":"https://api.github.com/users/zizyzhang/repos","events_url":"https://api.github.com/users/zizyzhang/events{/privacy}","received_events_url":"https://api.github.com/users/zizyzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zizyzhang/socket.io-client","description":"Realtime application framework (client)","fork":true,"url":"https://api.github.com/repos/zizyzhang/socket.io-client","forks_url":"https://api.github.com/repos/zizyzhang/socket.io-client/forks","keys_url":"https://api.github.com/repos/zizyzhang/socket.io-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zizyzhang/socket.io-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zizyzhang/socket.io-client/teams","hooks_url":"https://api.github.com/repos/zizyzhang/socket.io-client/hooks","issue_events_url":"https://api.github.com/repos/zizyzhang/socket.io-client/issues/events{/number}","events_url":"https://api.github.com/repos/zizyzhang/socket.io-client/events","assignees_url":"https://api.github.com/repos/zizyzhang/socket.io-client/assignees{/user}","branches_url":"https://api.github.com/repos/zizyzhang/socket.io-client/branches{/branch}","tags_url":"https://api.github.com/repos/zizyzhang/socket.io-client/tags","blobs_url":"https://api.github.com/repos/zizyzhang/socket.io-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zizyzhang/socket.io-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zizyzhang/socket.io-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/zizyzhang/socket.io-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zizyzhang/socket.io-client/statuses/{sha}","languages_url":"https://api.github.com/repos/zizyzhang/socket.io-client/languages","stargazers_url":"https://api.github.com/repos/zizyzhang/socket.io-client/stargazers","contributors_url":"https://api.github.com/repos/zizyzhang/socket.io-client/contributors","subscribers_url":"https://api.github.com/repos/zizyzhang/socket.io-client/subscribers","subscription_url":"https://api.github.com/repos/zizyzhang/socket.io-client/subscription","commits_url":"https://api.github.com/repos/zizyzhang/socket.io-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/zizyzhang/socket.io-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/zizyzhang/socket.io-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/zizyzhang/socket.io-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/zizyzhang/socket.io-client/contents/{+path}","compare_url":"https://api.github.com/repos/zizyzhang/socket.io-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zizyzhang/socket.io-client/merges","archive_url":"https://api.github.com/repos/zizyzhang/socket.io-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zizyzhang/socket.io-client/downloads","issues_url":"https://api.github.com/repos/zizyzhang/socket.io-client/issues{/number}","pulls_url":"https://api.github.com/repos/zizyzhang/socket.io-client/pulls{/number}","milestones_url":"https://api.github.com/repos/zizyzhang/socket.io-client/milestones{/number}","notifications_url":"https://api.github.com/repos/zizyzhang/socket.io-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zizyzhang/socket.io-client/labels{/name}","releases_url":"https://api.github.com/repos/zizyzhang/socket.io-client/releases{/id}","deployments_url":"https://api.github.com/repos/zizyzhang/socket.io-client/deployments","created_at":"2016-11-26T05:13:24Z","updated_at":"2016-11-26T05:13:27Z","pushed_at":"2016-11-26T05:26:24Z","git_url":"git://github.com/zizyzhang/socket.io-client.git","ssh_url":"git@github.com:zizyzhang/socket.io-client.git","clone_url":"https://github.com/zizyzhang/socket.io-client.git","svn_url":"https://github.com/zizyzhang/socket.io-client","homepage":"http://socket.io","size":3988,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"socketio:master","ref":"master","sha":"3ba3fe3034a3564b3313bff8ef03386dd1c7e9cf","user":{"login":"socketio","id":10566080,"avatar_url":"https://avatars.githubusercontent.com/u/10566080?v=3","gravatar_id":"","url":"https://api.github.com/users/socketio","html_url":"https://github.com/socketio","followers_url":"https://api.github.com/users/socketio/followers","following_url":"https://api.github.com/users/socketio/following{/other_user}","gists_url":"https://api.github.com/users/socketio/gists{/gist_id}","starred_url":"https://api.github.com/users/socketio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketio/subscriptions","organizations_url":"https://api.github.com/users/socketio/orgs","repos_url":"https://api.github.com/users/socketio/repos","events_url":"https://api.github.com/users/socketio/events{/privacy}","received_events_url":"https://api.github.com/users/socketio/received_events","type":"Organization","site_admin":false},"repo":{"id":557977,"name":"socket.io-client","full_name":"socketio/socket.io-client","owner":{"login":"socketio","id":10566080,"avatar_url":"https://avatars.githubusercontent.com/u/10566080?v=3","gravatar_id":"","url":"https://api.github.com/users/socketio","html_url":"https://github.com/socketio","followers_url":"https://api.github.com/users/socketio/followers","following_url":"https://api.github.com/users/socketio/following{/other_user}","gists_url":"https://api.github.com/users/socketio/gists{/gist_id}","starred_url":"https://api.github.com/users/socketio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketio/subscriptions","organizations_url":"https://api.github.com/users/socketio/orgs","repos_url":"https://api.github.com/users/socketio/repos","events_url":"https://api.github.com/users/socketio/events{/privacy}","received_events_url":"https://api.github.com/users/socketio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socketio/socket.io-client","description":"Realtime application framework (client)","fork":false,"url":"https://api.github.com/repos/socketio/socket.io-client","forks_url":"https://api.github.com/repos/socketio/socket.io-client/forks","keys_url":"https://api.github.com/repos/socketio/socket.io-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socketio/socket.io-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socketio/socket.io-client/teams","hooks_url":"https://api.github.com/repos/socketio/socket.io-client/hooks","issue_events_url":"https://api.github.com/repos/socketio/socket.io-client/issues/events{/number}","events_url":"https://api.github.com/repos/socketio/socket.io-client/events","assignees_url":"https://api.github.com/repos/socketio/socket.io-client/assignees{/user}","branches_url":"https://api.github.com/repos/socketio/socket.io-client/branches{/branch}","tags_url":"https://api.github.com/repos/socketio/socket.io-client/tags","blobs_url":"https://api.github.com/repos/socketio/socket.io-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socketio/socket.io-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socketio/socket.io-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/socketio/socket.io-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socketio/socket.io-client/statuses/{sha}","languages_url":"https://api.github.com/repos/socketio/socket.io-client/languages","stargazers_url":"https://api.github.com/repos/socketio/socket.io-client/stargazers","contributors_url":"https://api.github.com/repos/socketio/socket.io-client/contributors","subscribers_url":"https://api.github.com/repos/socketio/socket.io-client/subscribers","subscription_url":"https://api.github.com/repos/socketio/socket.io-client/subscription","commits_url":"https://api.github.com/repos/socketio/socket.io-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/socketio/socket.io-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/socketio/socket.io-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/socketio/socket.io-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/socketio/socket.io-client/contents/{+path}","compare_url":"https://api.github.com/repos/socketio/socket.io-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socketio/socket.io-client/merges","archive_url":"https://api.github.com/repos/socketio/socket.io-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socketio/socket.io-client/downloads","issues_url":"https://api.github.com/repos/socketio/socket.io-client/issues{/number}","pulls_url":"https://api.github.com/repos/socketio/socket.io-client/pulls{/number}","milestones_url":"https://api.github.com/repos/socketio/socket.io-client/milestones{/number}","notifications_url":"https://api.github.com/repos/socketio/socket.io-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socketio/socket.io-client/labels{/name}","releases_url":"https://api.github.com/repos/socketio/socket.io-client/releases{/id}","deployments_url":"https://api.github.com/repos/socketio/socket.io-client/deployments","created_at":"2010-03-11T18:23:03Z","updated_at":"2016-12-10T14:03:02Z","pushed_at":"2016-12-08T01:36:27Z","git_url":"git://github.com/socketio/socket.io-client.git","ssh_url":"git@github.com:socketio/socket.io-client.git","clone_url":"https://github.com/socketio/socket.io-client.git","svn_url":"https://github.com/socketio/socket.io-client","homepage":"http://socket.io","size":6053,"stargazers_count":3927,"watchers_count":3927,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1480,"mirror_url":null,"open_issues_count":74,"forks":1480,"open_issues":74,"watchers":3927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/1031"},"html":{"href":"https://github.com/socketio/socket.io-client/pull/1031"},"issue":{"href":"https://api.github.com/repos/socketio/socket.io-client/issues/1031"},"comments":{"href":"https://api.github.com/repos/socketio/socket.io-client/issues/1031/comments"},"review_comments":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/1031/comments"},"review_comment":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/1031/commits"},"statuses":{"href":"https://api.github.com/repos/socketio/socket.io-client/statuses/95d365f79aee1a86219b4c675d394a9165c65175"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":190,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"darrachequesne"}}