{"action":"created","issue":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/281","repository_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/281/labels{/name}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/281/comments","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/281/events","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/281","id":172155364,"number":281,"title":"Whitespace cleanup.","user":{"login":"Mizipzor","id":139879,"avatar_url":"https://avatars.githubusercontent.com/u/139879?v=3","gravatar_id":"","url":"https://api.github.com/users/Mizipzor","html_url":"https://github.com/Mizipzor","followers_url":"https://api.github.com/users/Mizipzor/followers","following_url":"https://api.github.com/users/Mizipzor/following{/other_user}","gists_url":"https://api.github.com/users/Mizipzor/gists{/gist_id}","starred_url":"https://api.github.com/users/Mizipzor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mizipzor/subscriptions","organizations_url":"https://api.github.com/users/Mizipzor/orgs","repos_url":"https://api.github.com/users/Mizipzor/repos","events_url":"https://api.github.com/users/Mizipzor/events{/privacy}","received_events_url":"https://api.github.com/users/Mizipzor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-19T15:18:13Z","updated_at":"2016-08-19T16:53:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/281","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/281","diff_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/281.diff","patch_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/281.patch"},"body":"Replaced tabs with (4) spaces.\r\nRemoved trailing whitespace.\r\n\r\nHeads up, you probably dont want to merge this. :)\r\n\r\nWe agreed on spaces instead of tabs, why is this not enforced? And trailing meaningless whitespace should be implicitly forbidden everywhere. I obviously didnt do this manually, and neither should you. From the project root I ran [tabs2spaces.py](https://gist.github.com/antivanov/59e00f6129725e9b4404) and [trimwhitespace.py](https://gist.github.com/Mizipzor/4da24230e31206650bff2f970a7093f3):\r\n\r\n```\r\n python tabs2spaces.py Assets 4 (.*).cs$ \r\n python trimwhitespace.py Assets (.*).cs$\r\n```\r\n\r\nThis pull request is just to show the extent of the changes these scripts make, for good or bad.\r\n\r\nWe might also want to discuss if tab characters are allowed as long as they are not the first character on the line.\r\n\r\nMaybe add these scripts in a utils folder with a `cleanup.bat`? These are meant for fixing when there is a super clear right and wrong, with no room for interpretation.\r\n\r\nIt's not great doing this as a pull request, its better done by someone with direct access to the repository. Merge all pull requests you want, and run the cleanup once."},"comment":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments/241072349","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/281#issuecomment-241072349","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/281","id":241072349,"user":{"login":"vogonistic","id":159568,"avatar_url":"https://avatars.githubusercontent.com/u/159568?v=3","gravatar_id":"","url":"https://api.github.com/users/vogonistic","html_url":"https://github.com/vogonistic","followers_url":"https://api.github.com/users/vogonistic/followers","following_url":"https://api.github.com/users/vogonistic/following{/other_user}","gists_url":"https://api.github.com/users/vogonistic/gists{/gist_id}","starred_url":"https://api.github.com/users/vogonistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogonistic/subscriptions","organizations_url":"https://api.github.com/users/vogonistic/orgs","repos_url":"https://api.github.com/users/vogonistic/repos","events_url":"https://api.github.com/users/vogonistic/events{/privacy}","received_events_url":"https://api.github.com/users/vogonistic/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T16:53:57Z","updated_at":"2016-08-19T16:53:57Z","body":"I saw those, but a PR is basically a request to have something merged.\r\n\r\n2 better ways (IMO):\r\n  1. Put `[WIP]` in the title. That way (at least people who are used to it) knows that this PR is not done or ready to be merged yet.\r\n  2. If you wanted to demonstrate the extent of changes to someone, you can create a branch with these changes in your repo, find the page that shows the diff and post that link for people to see.\r\n\r\nIt's no hard feelings."}}
{"actor":{"display_login":"vogonistic"}}