{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/88172501","pull_request_review_id":8753034,"id":88172501,"diff_hunk":"@@ -2038,13 +2058,80 @@ MulticopterPositionControl::task_main()\n \t\t\t\t}\n \t\t\t}\n \n-\t\t\t/* control roll and pitch directly if no aiding velocity controller is active */\n \t\t\tif (!_control_mode.flag_control_velocity_enabled) {\n \t\t\t\t_att_sp.roll_body = _manual.y * _params.man_roll_max;\n \t\t\t\t_att_sp.pitch_body = -_manual.x * _params.man_pitch_max;\n \n-\t\t\t\t/* only if optimal recovery is not used, modify roll/pitch */\n-\t\t\t\tif (_params.opt_recover <= 0) {\n+\t\t\t\t/* If ACRO attitude control mode */\n+\t\t\t\tif (_vehicle_status.nav_state == vehicle_status_s::NAVIGATION_STATE_ACRO) {","path":"src/modules/mc_pos_control/mc_pos_control_main.cpp","position":94,"original_position":94,"commit_id":"ee36fc3fadf078922a11a56cd8b76211dd910c9c","original_commit_id":"ee36fc3fadf078922a11a56cd8b76211dd910c9c","user":{"login":"julianoes","id":1419688,"avatar_url":"https://avatars.githubusercontent.com/u/1419688?v=3","gravatar_id":"","url":"https://api.github.com/users/julianoes","html_url":"https://github.com/julianoes","followers_url":"https://api.github.com/users/julianoes/followers","following_url":"https://api.github.com/users/julianoes/following{/other_user}","gists_url":"https://api.github.com/users/julianoes/gists{/gist_id}","starred_url":"https://api.github.com/users/julianoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianoes/subscriptions","organizations_url":"https://api.github.com/users/julianoes/orgs","repos_url":"https://api.github.com/users/julianoes/repos","events_url":"https://api.github.com/users/julianoes/events{/privacy}","received_events_url":"https://api.github.com/users/julianoes/received_events","type":"User","site_admin":false},"body":"In theory, no controller should use the nav_state but only the boolean flags but I see how that gets messy as well.","created_at":"2016-11-16T05:54:49Z","updated_at":"2016-11-16T05:59:32Z","html_url":"https://github.com/PX4/Firmware/pull/5498#discussion_r88172501","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/5498","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/88172501"},"html":{"href":"https://github.com/PX4/Firmware/pull/5498#discussion_r88172501"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/5498"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/5498","id":85444958,"html_url":"https://github.com/PX4/Firmware/pull/5498","diff_url":"https://github.com/PX4/Firmware/pull/5498.diff","patch_url":"https://github.com/PX4/Firmware/pull/5498.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/5498","number":5498,"state":"open","locked":false,"title":"6DOF ACRO mode with sequencing and groundtruth logging","user":{"login":"kd0aij","id":2300221,"avatar_url":"https://avatars.githubusercontent.com/u/2300221?v=3","gravatar_id":"","url":"https://api.github.com/users/kd0aij","html_url":"https://github.com/kd0aij","followers_url":"https://api.github.com/users/kd0aij/followers","following_url":"https://api.github.com/users/kd0aij/following{/other_user}","gists_url":"https://api.github.com/users/kd0aij/gists{/gist_id}","starred_url":"https://api.github.com/users/kd0aij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd0aij/subscriptions","organizations_url":"https://api.github.com/users/kd0aij/orgs","repos_url":"https://api.github.com/users/kd0aij/repos","events_url":"https://api.github.com/users/kd0aij/events{/privacy}","received_events_url":"https://api.github.com/users/kd0aij/received_events","type":"User","site_admin":false},"body":"https://github.com/PX4/Firmware/pull/5476 (branch attSeq_rebased) rebased onto branch hil_state (https://github.com/PX4/Firmware/pull/5492)\n","created_at":"2016-09-15T17:22:29Z","updated_at":"2016-11-16T05:59:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"454cb712abc6abe5786b36fc8bf6b78a85ffd3ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/5498/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/5498/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/5498/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/ee36fc3fadf078922a11a56cd8b76211dd910c9c","head":{"label":"kd0aij:attSeq_hilState","ref":"attSeq_hilState","sha":"ee36fc3fadf078922a11a56cd8b76211dd910c9c","user":{"login":"kd0aij","id":2300221,"avatar_url":"https://avatars.githubusercontent.com/u/2300221?v=3","gravatar_id":"","url":"https://api.github.com/users/kd0aij","html_url":"https://github.com/kd0aij","followers_url":"https://api.github.com/users/kd0aij/followers","following_url":"https://api.github.com/users/kd0aij/following{/other_user}","gists_url":"https://api.github.com/users/kd0aij/gists{/gist_id}","starred_url":"https://api.github.com/users/kd0aij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd0aij/subscriptions","organizations_url":"https://api.github.com/users/kd0aij/orgs","repos_url":"https://api.github.com/users/kd0aij/repos","events_url":"https://api.github.com/users/kd0aij/events{/privacy}","received_events_url":"https://api.github.com/users/kd0aij/received_events","type":"User","site_admin":false},"repo":{"id":12996647,"name":"Firmware","full_name":"kd0aij/Firmware","owner":{"login":"kd0aij","id":2300221,"avatar_url":"https://avatars.githubusercontent.com/u/2300221?v=3","gravatar_id":"","url":"https://api.github.com/users/kd0aij","html_url":"https://github.com/kd0aij","followers_url":"https://api.github.com/users/kd0aij/followers","following_url":"https://api.github.com/users/kd0aij/following{/other_user}","gists_url":"https://api.github.com/users/kd0aij/gists{/gist_id}","starred_url":"https://api.github.com/users/kd0aij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd0aij/subscriptions","organizations_url":"https://api.github.com/users/kd0aij/orgs","repos_url":"https://api.github.com/users/kd0aij/repos","events_url":"https://api.github.com/users/kd0aij/events{/privacy}","received_events_url":"https://api.github.com/users/kd0aij/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kd0aij/Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":true,"url":"https://api.github.com/repos/kd0aij/Firmware","forks_url":"https://api.github.com/repos/kd0aij/Firmware/forks","keys_url":"https://api.github.com/repos/kd0aij/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kd0aij/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kd0aij/Firmware/teams","hooks_url":"https://api.github.com/repos/kd0aij/Firmware/hooks","issue_events_url":"https://api.github.com/repos/kd0aij/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/kd0aij/Firmware/events","assignees_url":"https://api.github.com/repos/kd0aij/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/kd0aij/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/kd0aij/Firmware/tags","blobs_url":"https://api.github.com/repos/kd0aij/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kd0aij/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kd0aij/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/kd0aij/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kd0aij/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/kd0aij/Firmware/languages","stargazers_url":"https://api.github.com/repos/kd0aij/Firmware/stargazers","contributors_url":"https://api.github.com/repos/kd0aij/Firmware/contributors","subscribers_url":"https://api.github.com/repos/kd0aij/Firmware/subscribers","subscription_url":"https://api.github.com/repos/kd0aij/Firmware/subscription","commits_url":"https://api.github.com/repos/kd0aij/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/kd0aij/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/kd0aij/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/kd0aij/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/kd0aij/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/kd0aij/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kd0aij/Firmware/merges","archive_url":"https://api.github.com/repos/kd0aij/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kd0aij/Firmware/downloads","issues_url":"https://api.github.com/repos/kd0aij/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/kd0aij/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/kd0aij/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/kd0aij/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kd0aij/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/kd0aij/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/kd0aij/Firmware/deployments","created_at":"2013-09-21T14:42:14Z","updated_at":"2015-05-07T13:48:23Z","pushed_at":"2016-11-11T19:02:42Z","git_url":"git://github.com/kd0aij/Firmware.git","ssh_url":"git@github.com:kd0aij/Firmware.git","clone_url":"https://github.com/kd0aij/Firmware.git","svn_url":"https://github.com/kd0aij/Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":88084,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"39cc75b4a0c45bc251a4a46ec7766296649d8856","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2016-11-16T05:20:39Z","pushed_at":"2016-11-16T04:36:57Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":218199,"stargazers_count":814,"watchers_count":814,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2774,"mirror_url":null,"open_issues_count":445,"forks":2774,"open_issues":445,"watchers":814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/5498"},"html":{"href":"https://github.com/PX4/Firmware/pull/5498"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/5498"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/5498/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/5498/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/5498/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/ee36fc3fadf078922a11a56cd8b76211dd910c9c"}}}}
{"actor":{"display_login":"julianoes"}}