{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/7262","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/7262/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/7262/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/7262/events","html_url":"https://github.com/highfidelity/hifi/pull/7262","id":139075060,"number":7262,"title":"threadsafe Application::_viewFrustum","user":{"login":"AndrewMeadows","id":2186405,"avatar_url":"https://avatars.githubusercontent.com/u/2186405?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewMeadows","html_url":"https://github.com/AndrewMeadows","followers_url":"https://api.github.com/users/AndrewMeadows/followers","following_url":"https://api.github.com/users/AndrewMeadows/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMeadows/subscriptions","organizations_url":"https://api.github.com/users/AndrewMeadows/orgs","repos_url":"https://api.github.com/users/AndrewMeadows/repos","events_url":"https://api.github.com/users/AndrewMeadows/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMeadows/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-07T19:47:38Z","updated_at":"2016-03-09T17:15:45Z","closed_at":"2016-03-09T17:15:44Z","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/7262","html_url":"https://github.com/highfidelity/hifi/pull/7262","diff_url":"https://github.com/highfidelity/hifi/pull/7262.diff","patch_url":"https://github.com/highfidelity/hifi/pull/7262.patch"},"body":"- ViewFrustum class moves out of octree and into shared lib\r\n- Octree-specific code in ViewFrustum now lives in OctreeUtils\r\n- now make copies of ViewFrustum rather than hand out raw pointers to foreign code/threads\r\n- Application::_viewFrustum and friends are protected by lock on mutex\r\n- RenderArgs uses std::stack<ViewFrustum> so views can be pushed/popped\r\n- cleanup and cruft removal"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/194406109","html_url":"https://github.com/highfidelity/hifi/pull/7262#issuecomment-194406109","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/7262","id":194406109,"user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T17:15:44Z","updated_at":"2016-03-09T17:15:44Z","body":"Andrew - as you point out, this fixes and issue that may not be that big of an issue. Let's not merge this at this point, it's too risky at this point. But we can keep you branch and consider re-opening this PR in the future."}}