{"action":"created","issue":{"url":"https://api.github.com/repos/Rise-Vision/display-activity-extractor/issues/4","repository_url":"https://api.github.com/repos/Rise-Vision/display-activity-extractor","labels_url":"https://api.github.com/repos/Rise-Vision/display-activity-extractor/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/Rise-Vision/display-activity-extractor/issues/4/comments","events_url":"https://api.github.com/repos/Rise-Vision/display-activity-extractor/issues/4/events","html_url":"https://github.com/Rise-Vision/display-activity-extractor/pull/4","id":189286048,"number":4,"title":"Fix displayConnectionInfo table to detect v3 players using Messaging Service","user":{"login":"ezequielc","id":7738553,"avatar_url":"https://avatars.githubusercontent.com/u/7738553?v=3","gravatar_id":"","url":"https://api.github.com/users/ezequielc","html_url":"https://github.com/ezequielc","followers_url":"https://api.github.com/users/ezequielc/followers","following_url":"https://api.github.com/users/ezequielc/following{/other_user}","gists_url":"https://api.github.com/users/ezequielc/gists{/gist_id}","starred_url":"https://api.github.com/users/ezequielc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezequielc/subscriptions","organizations_url":"https://api.github.com/users/ezequielc/orgs","repos_url":"https://api.github.com/users/ezequielc/repos","events_url":"https://api.github.com/users/ezequielc/events{/privacy}","received_events_url":"https://api.github.com/users/ezequielc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-15T02:50:23Z","updated_at":"2016-11-15T15:32:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Rise-Vision/display-activity-extractor/pulls/4","html_url":"https://github.com/Rise-Vision/display-activity-extractor/pull/4","diff_url":"https://github.com/Rise-Vision/display-activity-extractor/pull/4.diff","patch_url":"https://github.com/Rise-Vision/display-activity-extractor/pull/4.patch"},"body":"This is my attempt to fix the data in our dashboards. As v3 players are not contacting Core anymore, they were not being detected by the query, therefore they would not be added to displayConnectionInfo, invalidating the data in our charts.\r\nFor the fix, I combined the data from Core logs with the data from Installer_Events table, which records Player activity and it is being used for our daily display count. \r\n\r\n@alexey-rise  I am not sure how I should test this change as I assume it would duplicate the data. Any suggestion on that? Also, any suggestions on how we could fix the data from the past few days? My initial thought was to manually delete the tables and run the job for each day.\r\nPlease review. Thanks!\r\n\r\n@Rise-Vision/apps  fyi"},"comment":{"url":"https://api.github.com/repos/Rise-Vision/display-activity-extractor/issues/comments/260673296","html_url":"https://github.com/Rise-Vision/display-activity-extractor/pull/4#issuecomment-260673296","issue_url":"https://api.github.com/repos/Rise-Vision/display-activity-extractor/issues/4","id":260673296,"user":{"login":"alexey-rise","id":7119180,"avatar_url":"https://avatars.githubusercontent.com/u/7119180?v=3","gravatar_id":"","url":"https://api.github.com/users/alexey-rise","html_url":"https://github.com/alexey-rise","followers_url":"https://api.github.com/users/alexey-rise/followers","following_url":"https://api.github.com/users/alexey-rise/following{/other_user}","gists_url":"https://api.github.com/users/alexey-rise/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-rise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-rise/subscriptions","organizations_url":"https://api.github.com/users/alexey-rise/orgs","repos_url":"https://api.github.com/users/alexey-rise/repos","events_url":"https://api.github.com/users/alexey-rise/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-rise/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T15:32:38Z","updated_at":"2016-11-15T15:32:38Z","body":"@ezequielc while you are at it you might want to seriously consider recreating `rise-core-log:dashboards.displayConnectionInfo` as partitioned table (https://cloud.google.com/bigquery/docs/partitioned-tables) to better control costs."}}
{"actor":{"display_login":"alexey-rise"}}