{"action":"created","comment":{"url":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/comments/77751116","id":77751116,"diff_hunk":"@@ -7,7 +7,8 @@\n   var xmlParser = require('xml2json');\n   var FundamentalAccountingConcepts = require('./FundamentalAccountingConcepts.js');\n \n-  function parse(pathToXbrlDoc) {\n+  function parse(pathToXbrlDoc, output) {\n+    output = (output=== null)? false : output;\n     var self = this;","path":"index.js","position":7,"original_position":7,"commit_id":"2708365d537f50f224de840bff7db499cb4c361e","original_commit_id":"2708365d537f50f224de840bff7db499cb4c361e","user":{"login":"joeyism","id":7503144,"avatar_url":"https://avatars.githubusercontent.com/u/7503144?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyism","html_url":"https://github.com/joeyism","followers_url":"https://api.github.com/users/joeyism/followers","following_url":"https://api.github.com/users/joeyism/following{/other_user}","gists_url":"https://api.github.com/users/joeyism/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyism/subscriptions","organizations_url":"https://api.github.com/users/joeyism/orgs","repos_url":"https://api.github.com/users/joeyism/repos","events_url":"https://api.github.com/users/joeyism/events{/privacy}","received_events_url":"https://api.github.com/users/joeyism/received_events","type":"User","site_admin":false},"body":"The reason why I set it as such is that if output === true, output should remains true. False is a \"default value\". Using ternary operator wouldn't work in that sense. ","created_at":"2016-09-07T02:21:20Z","updated_at":"2016-09-07T02:21:20Z","html_url":"https://github.com/emilycoco/parse-xbrl/pull/3#discussion_r77751116","pull_request_url":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/comments/77751116"},"html":{"href":"https://github.com/emilycoco/parse-xbrl/pull/3#discussion_r77751116"},"pull_request":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/3","id":83901782,"html_url":"https://github.com/emilycoco/parse-xbrl/pull/3","diff_url":"https://github.com/emilycoco/parse-xbrl/pull/3.diff","patch_url":"https://github.com/emilycoco/parse-xbrl/pull/3.patch","issue_url":"https://api.github.com/repos/emilycoco/parse-xbrl/issues/3","number":3,"state":"open","locked":false,"title":"Added CLI","user":{"login":"joeyism","id":7503144,"avatar_url":"https://avatars.githubusercontent.com/u/7503144?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyism","html_url":"https://github.com/joeyism","followers_url":"https://api.github.com/users/joeyism/followers","following_url":"https://api.github.com/users/joeyism/following{/other_user}","gists_url":"https://api.github.com/users/joeyism/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyism/subscriptions","organizations_url":"https://api.github.com/users/joeyism/orgs","repos_url":"https://api.github.com/users/joeyism/repos","events_url":"https://api.github.com/users/joeyism/events{/privacy}","received_events_url":"https://api.github.com/users/joeyism/received_events","type":"User","site_admin":false},"body":"I came across the need to use this module, but as a CLI tool. So I added a CLI component to it, where one can use it by running\r\n\r\n```\r\nparsexbrl input.xbrl output.json\r\n```","created_at":"2016-09-03T18:02:29Z","updated_at":"2016-09-07T02:21:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db2288b334dee812ea69d26af05d905ccd7922d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/3/commits","review_comments_url":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/3/comments","review_comment_url":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emilycoco/parse-xbrl/issues/3/comments","statuses_url":"https://api.github.com/repos/emilycoco/parse-xbrl/statuses/2708365d537f50f224de840bff7db499cb4c361e","head":{"label":"joeyism:master","ref":"master","sha":"2708365d537f50f224de840bff7db499cb4c361e","user":{"login":"joeyism","id":7503144,"avatar_url":"https://avatars.githubusercontent.com/u/7503144?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyism","html_url":"https://github.com/joeyism","followers_url":"https://api.github.com/users/joeyism/followers","following_url":"https://api.github.com/users/joeyism/following{/other_user}","gists_url":"https://api.github.com/users/joeyism/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyism/subscriptions","organizations_url":"https://api.github.com/users/joeyism/orgs","repos_url":"https://api.github.com/users/joeyism/repos","events_url":"https://api.github.com/users/joeyism/events{/privacy}","received_events_url":"https://api.github.com/users/joeyism/received_events","type":"User","site_admin":false},"repo":{"id":67296271,"name":"parse-xbrl","full_name":"joeyism/parse-xbrl","owner":{"login":"joeyism","id":7503144,"avatar_url":"https://avatars.githubusercontent.com/u/7503144?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyism","html_url":"https://github.com/joeyism","followers_url":"https://api.github.com/users/joeyism/followers","following_url":"https://api.github.com/users/joeyism/following{/other_user}","gists_url":"https://api.github.com/users/joeyism/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyism/subscriptions","organizations_url":"https://api.github.com/users/joeyism/orgs","repos_url":"https://api.github.com/users/joeyism/repos","events_url":"https://api.github.com/users/joeyism/events{/privacy}","received_events_url":"https://api.github.com/users/joeyism/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joeyism/parse-xbrl","description":"Parse xbrl documents to extract tags for common financial data","fork":true,"url":"https://api.github.com/repos/joeyism/parse-xbrl","forks_url":"https://api.github.com/repos/joeyism/parse-xbrl/forks","keys_url":"https://api.github.com/repos/joeyism/parse-xbrl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joeyism/parse-xbrl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joeyism/parse-xbrl/teams","hooks_url":"https://api.github.com/repos/joeyism/parse-xbrl/hooks","issue_events_url":"https://api.github.com/repos/joeyism/parse-xbrl/issues/events{/number}","events_url":"https://api.github.com/repos/joeyism/parse-xbrl/events","assignees_url":"https://api.github.com/repos/joeyism/parse-xbrl/assignees{/user}","branches_url":"https://api.github.com/repos/joeyism/parse-xbrl/branches{/branch}","tags_url":"https://api.github.com/repos/joeyism/parse-xbrl/tags","blobs_url":"https://api.github.com/repos/joeyism/parse-xbrl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joeyism/parse-xbrl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joeyism/parse-xbrl/git/refs{/sha}","trees_url":"https://api.github.com/repos/joeyism/parse-xbrl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joeyism/parse-xbrl/statuses/{sha}","languages_url":"https://api.github.com/repos/joeyism/parse-xbrl/languages","stargazers_url":"https://api.github.com/repos/joeyism/parse-xbrl/stargazers","contributors_url":"https://api.github.com/repos/joeyism/parse-xbrl/contributors","subscribers_url":"https://api.github.com/repos/joeyism/parse-xbrl/subscribers","subscription_url":"https://api.github.com/repos/joeyism/parse-xbrl/subscription","commits_url":"https://api.github.com/repos/joeyism/parse-xbrl/commits{/sha}","git_commits_url":"https://api.github.com/repos/joeyism/parse-xbrl/git/commits{/sha}","comments_url":"https://api.github.com/repos/joeyism/parse-xbrl/comments{/number}","issue_comment_url":"https://api.github.com/repos/joeyism/parse-xbrl/issues/comments{/number}","contents_url":"https://api.github.com/repos/joeyism/parse-xbrl/contents/{+path}","compare_url":"https://api.github.com/repos/joeyism/parse-xbrl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joeyism/parse-xbrl/merges","archive_url":"https://api.github.com/repos/joeyism/parse-xbrl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joeyism/parse-xbrl/downloads","issues_url":"https://api.github.com/repos/joeyism/parse-xbrl/issues{/number}","pulls_url":"https://api.github.com/repos/joeyism/parse-xbrl/pulls{/number}","milestones_url":"https://api.github.com/repos/joeyism/parse-xbrl/milestones{/number}","notifications_url":"https://api.github.com/repos/joeyism/parse-xbrl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joeyism/parse-xbrl/labels{/name}","releases_url":"https://api.github.com/repos/joeyism/parse-xbrl/releases{/id}","deployments_url":"https://api.github.com/repos/joeyism/parse-xbrl/deployments","created_at":"2016-09-03T15:08:14Z","updated_at":"2016-09-03T15:08:16Z","pushed_at":"2016-09-03T18:00:12Z","git_url":"git://github.com/joeyism/parse-xbrl.git","ssh_url":"git@github.com:joeyism/parse-xbrl.git","clone_url":"https://github.com/joeyism/parse-xbrl.git","svn_url":"https://github.com/joeyism/parse-xbrl","homepage":"","size":682,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emilycoco:master","ref":"master","sha":"f3787e9dc36ee3050b0e7f75a1e1b9205318dac4","user":{"login":"emilycoco","id":5327571,"avatar_url":"https://avatars.githubusercontent.com/u/5327571?v=3","gravatar_id":"","url":"https://api.github.com/users/emilycoco","html_url":"https://github.com/emilycoco","followers_url":"https://api.github.com/users/emilycoco/followers","following_url":"https://api.github.com/users/emilycoco/following{/other_user}","gists_url":"https://api.github.com/users/emilycoco/gists{/gist_id}","starred_url":"https://api.github.com/users/emilycoco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilycoco/subscriptions","organizations_url":"https://api.github.com/users/emilycoco/orgs","repos_url":"https://api.github.com/users/emilycoco/repos","events_url":"https://api.github.com/users/emilycoco/events{/privacy}","received_events_url":"https://api.github.com/users/emilycoco/received_events","type":"User","site_admin":false},"repo":{"id":52418118,"name":"parse-xbrl","full_name":"emilycoco/parse-xbrl","owner":{"login":"emilycoco","id":5327571,"avatar_url":"https://avatars.githubusercontent.com/u/5327571?v=3","gravatar_id":"","url":"https://api.github.com/users/emilycoco","html_url":"https://github.com/emilycoco","followers_url":"https://api.github.com/users/emilycoco/followers","following_url":"https://api.github.com/users/emilycoco/following{/other_user}","gists_url":"https://api.github.com/users/emilycoco/gists{/gist_id}","starred_url":"https://api.github.com/users/emilycoco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilycoco/subscriptions","organizations_url":"https://api.github.com/users/emilycoco/orgs","repos_url":"https://api.github.com/users/emilycoco/repos","events_url":"https://api.github.com/users/emilycoco/events{/privacy}","received_events_url":"https://api.github.com/users/emilycoco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emilycoco/parse-xbrl","description":"Parse xbrl documents to extract tags for common financial data","fork":false,"url":"https://api.github.com/repos/emilycoco/parse-xbrl","forks_url":"https://api.github.com/repos/emilycoco/parse-xbrl/forks","keys_url":"https://api.github.com/repos/emilycoco/parse-xbrl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emilycoco/parse-xbrl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emilycoco/parse-xbrl/teams","hooks_url":"https://api.github.com/repos/emilycoco/parse-xbrl/hooks","issue_events_url":"https://api.github.com/repos/emilycoco/parse-xbrl/issues/events{/number}","events_url":"https://api.github.com/repos/emilycoco/parse-xbrl/events","assignees_url":"https://api.github.com/repos/emilycoco/parse-xbrl/assignees{/user}","branches_url":"https://api.github.com/repos/emilycoco/parse-xbrl/branches{/branch}","tags_url":"https://api.github.com/repos/emilycoco/parse-xbrl/tags","blobs_url":"https://api.github.com/repos/emilycoco/parse-xbrl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emilycoco/parse-xbrl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emilycoco/parse-xbrl/git/refs{/sha}","trees_url":"https://api.github.com/repos/emilycoco/parse-xbrl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emilycoco/parse-xbrl/statuses/{sha}","languages_url":"https://api.github.com/repos/emilycoco/parse-xbrl/languages","stargazers_url":"https://api.github.com/repos/emilycoco/parse-xbrl/stargazers","contributors_url":"https://api.github.com/repos/emilycoco/parse-xbrl/contributors","subscribers_url":"https://api.github.com/repos/emilycoco/parse-xbrl/subscribers","subscription_url":"https://api.github.com/repos/emilycoco/parse-xbrl/subscription","commits_url":"https://api.github.com/repos/emilycoco/parse-xbrl/commits{/sha}","git_commits_url":"https://api.github.com/repos/emilycoco/parse-xbrl/git/commits{/sha}","comments_url":"https://api.github.com/repos/emilycoco/parse-xbrl/comments{/number}","issue_comment_url":"https://api.github.com/repos/emilycoco/parse-xbrl/issues/comments{/number}","contents_url":"https://api.github.com/repos/emilycoco/parse-xbrl/contents/{+path}","compare_url":"https://api.github.com/repos/emilycoco/parse-xbrl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emilycoco/parse-xbrl/merges","archive_url":"https://api.github.com/repos/emilycoco/parse-xbrl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emilycoco/parse-xbrl/downloads","issues_url":"https://api.github.com/repos/emilycoco/parse-xbrl/issues{/number}","pulls_url":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls{/number}","milestones_url":"https://api.github.com/repos/emilycoco/parse-xbrl/milestones{/number}","notifications_url":"https://api.github.com/repos/emilycoco/parse-xbrl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emilycoco/parse-xbrl/labels{/name}","releases_url":"https://api.github.com/repos/emilycoco/parse-xbrl/releases{/id}","deployments_url":"https://api.github.com/repos/emilycoco/parse-xbrl/deployments","created_at":"2016-02-24T05:54:34Z","updated_at":"2016-06-08T10:22:21Z","pushed_at":"2016-09-06T03:55:06Z","git_url":"git://github.com/emilycoco/parse-xbrl.git","ssh_url":"git@github.com:emilycoco/parse-xbrl.git","clone_url":"https://github.com/emilycoco/parse-xbrl.git","svn_url":"https://github.com/emilycoco/parse-xbrl","homepage":"","size":835,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/3"},"html":{"href":"https://github.com/emilycoco/parse-xbrl/pull/3"},"issue":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/issues/3"},"comments":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/emilycoco/parse-xbrl/statuses/2708365d537f50f224de840bff7db499cb4c361e"}}}}
{"actor":{"display_login":"joeyism"}}