{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/comments/85493114","pull_request_review_id":6204751,"id":85493114,"diff_hunk":"@@ -33,18 +33,8 @@\n   describe 'with auth configured' do\n     let(:client_token) { 'atoken' }\n     let(:client_key) {\n-      key = <<-END.gsub(/^ +/, \"\").chomp\n-        -----BEGIN RSA PRIVATE KEY-----\n-        MIIBOwIBAAJBAKgRAIAYi4/HbzLcrXf3H3zomuhuimXLWnhqEkCdZ5DBq7ofJpsr\n-        qYv1lPpQUqKhFkAORoj9+w/xM+xIcvFu8t8CAwEAAQJARnKyAf/H6GHRo8FK2WF2\n-        Cna6EDndu2OtLZJQylLwiYVnHs8xLZXdqcAGAv0ZMWEEt2qOBQPxbPQpEWJ6ZhB0\n-        cQIhANE61o8r4DgP15XNI3AYYCbjrgYgxgbKmXJtlK9Vl+f3AiEAzaKXDDGMEVOV\n-        MoFEqkSaIoIiOum28GBj4Soz1gSTolkCIEgDpWff5SvGoCBKXCEv8qBQC0zGqQIb\n-        Z5dQCjYTEtbfAiEAs/pqWbHD9iZBn0Kk5qHEhg+ABjAofZrf0GMvm1HGJYECIQDC\n-        QteHGErMYVksaiuQxrk8I8nbe2JP6UsCd2gyWYazkg==\n-        -----END RSA PRIVATE KEY-----\n-      END\n-      OpenSSL::PKey::RSA.new(key)\n+      key = 'MHcCAQEEIGSsQrYsGnRCEYDNmdXxzBQ8Tq4SpfVWvr5ROPWM29cxoAoGCCqGSM49AwEHoUQDQgAEQ9qVQgr2XA8nupSP7C67pvufywLc2ur11b3bYe7t6+mGAWYM9Pd/L49cI6HWnPVg5UPr1PC+aT4RKW6PGj6BuQ=='","path":"spec/services/nomis/client_spec.rb","position":16,"original_position":16,"commit_id":"0c1e7d2f1be0cf5ee26a90089dba829e94b49623","original_commit_id":"0c1e7d2f1be0cf5ee26a90089dba829e94b49623","user":{"login":"StupidCodeFactory","id":100796,"avatar_url":"https://avatars.githubusercontent.com/u/100796?v=3","gravatar_id":"","url":"https://api.github.com/users/StupidCodeFactory","html_url":"https://github.com/StupidCodeFactory","followers_url":"https://api.github.com/users/StupidCodeFactory/followers","following_url":"https://api.github.com/users/StupidCodeFactory/following{/other_user}","gists_url":"https://api.github.com/users/StupidCodeFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/StupidCodeFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StupidCodeFactory/subscriptions","organizations_url":"https://api.github.com/users/StupidCodeFactory/orgs","repos_url":"https://api.github.com/users/StupidCodeFactory/repos","events_url":"https://api.github.com/users/StupidCodeFactory/events{/privacy}","received_events_url":"https://api.github.com/users/StupidCodeFactory/received_events","type":"User","site_admin":false},"body":"According to to `spec/vcr_cassettes/client-auth.yml` it is requesting 172.22.16.2:8080 which i believe should be the dev server.\r\nShouldn't this have changed the VCR file?","created_at":"2016-10-28T08:49:47Z","updated_at":"2016-10-28T08:51:18Z","html_url":"https://github.com/ministryofjustice/prison-visits-2/pull/582#discussion_r85493114","pull_request_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/582","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/comments/85493114"},"html":{"href":"https://github.com/ministryofjustice/prison-visits-2/pull/582#discussion_r85493114"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/582"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/582","id":91242228,"html_url":"https://github.com/ministryofjustice/prison-visits-2/pull/582","diff_url":"https://github.com/ministryofjustice/prison-visits-2/pull/582.diff","patch_url":"https://github.com/ministryofjustice/prison-visits-2/pull/582.patch","issue_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/582","number":582,"state":"open","locked":false,"title":"Sign NOMIS API requests with ECDSA JWT","user":{"login":"mloughran","id":214,"avatar_url":"https://avatars.githubusercontent.com/u/214?v=3","gravatar_id":"","url":"https://api.github.com/users/mloughran","html_url":"https://github.com/mloughran","followers_url":"https://api.github.com/users/mloughran/followers","following_url":"https://api.github.com/users/mloughran/following{/other_user}","gists_url":"https://api.github.com/users/mloughran/gists{/gist_id}","starred_url":"https://api.github.com/users/mloughran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mloughran/subscriptions","organizations_url":"https://api.github.com/users/mloughran/orgs","repos_url":"https://api.github.com/users/mloughran/repos","events_url":"https://api.github.com/users/mloughran/events{/privacy}","received_events_url":"https://api.github.com/users/mloughran/received_events","type":"User","site_admin":false},"body":"This also updates the required config format for the private key to base64(der), which avoids any confusion with newlines in ENV variables","created_at":"2016-10-27T17:05:27Z","updated_at":"2016-10-28T08:51:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8ead77b4a00a998966786653c9774081119e2a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/582/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/582/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/582/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/statuses/0c1e7d2f1be0cf5ee26a90089dba829e94b49623","head":{"label":"ministryofjustice:update-nomis-auth-signatures-to-ecdsa","ref":"update-nomis-auth-signatures-to-ecdsa","sha":"0c1e7d2f1be0cf5ee26a90089dba829e94b49623","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":44737633,"name":"prison-visits-2","full_name":"ministryofjustice/prison-visits-2","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits-2","description":"Staff interface and internal API for prison visits service","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/deployments","created_at":"2015-10-22T10:12:32Z","updated_at":"2016-10-24T10:05:08Z","pushed_at":"2016-10-28T08:50:46Z","git_url":"git://github.com/ministryofjustice/prison-visits-2.git","ssh_url":"git@github.com:ministryofjustice/prison-visits-2.git","clone_url":"https://github.com/ministryofjustice/prison-visits-2.git","svn_url":"https://github.com/ministryofjustice/prison-visits-2","homepage":"","size":2325,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":4,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"5c116205a46c4fffa7dd5d6de0b51a305850d85d","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":44737633,"name":"prison-visits-2","full_name":"ministryofjustice/prison-visits-2","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits-2","description":"Staff interface and internal API for prison visits service","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/deployments","created_at":"2015-10-22T10:12:32Z","updated_at":"2016-10-24T10:05:08Z","pushed_at":"2016-10-28T08:50:46Z","git_url":"git://github.com/ministryofjustice/prison-visits-2.git","ssh_url":"git@github.com:ministryofjustice/prison-visits-2.git","clone_url":"https://github.com/ministryofjustice/prison-visits-2.git","svn_url":"https://github.com/ministryofjustice/prison-visits-2","homepage":"","size":2325,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/582"},"html":{"href":"https://github.com/ministryofjustice/prison-visits-2/pull/582"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/582"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/statuses/0c1e7d2f1be0cf5ee26a90089dba829e94b49623"}}}}
{"actor":{"display_login":"StupidCodeFactory"}}