{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/73800796","id":73800796,"diff_hunk":"@@ -338,11 +347,68 @@ AgentImpl::~AgentImpl() {\n   data_written_ = nullptr;\n }\n \n+void InspectorConsoleCall(const v8::FunctionCallbackInfo<v8::Value>& info) {\n+  v8::Isolate* isolate = info.GetIsolate();\n+  v8::Local<v8::Context> context = isolate->GetCurrentContext();\n+\n+  CHECK(info.Data()->IsArray());\n+  v8::Local<v8::Array> args = info.Data().As<v8::Array>();\n+  CHECK_EQ(args->Length(), 3);\n+\n+  v8::Local<v8::Value> inspector_method =\n+      args->Get(context, 0).ToLocalChecked();\n+  CHECK(inspector_method->IsFunction());\n+  v8::Local<v8::Value> node_method =\n+      args->Get(context, 1).ToLocalChecked();\n+  CHECK(node_method->IsFunction());\n+  v8::Local<v8::Value> config_value =\n+      args->Get(context, 2).ToLocalChecked();\n+  CHECK(config_value->IsObject());\n+  v8::Local<v8::Object> config_object = config_value.As<v8::Object>();\n+\n+  std::vector<v8::Local<v8::Value>> call_args(info.Length());\n+  for (int i = 0; i < info.Length(); ++i) {\n+      call_args[i] = info[i];","path":"src/inspector_agent.cc","position":55,"original_position":55,"commit_id":"ab0e9d064ae5b93972790b6e6a20c8ba221ced9a","original_commit_id":"ab0e9d064ae5b93972790b6e6a20c8ba221ced9a","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Nit: two space indent.","created_at":"2016-08-07T12:07:20Z","updated_at":"2016-08-07T12:07:20Z","html_url":"https://github.com/nodejs/node/pull/7988#discussion_r73800796","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/7988","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/73800796"},"html":{"href":"https://github.com/nodejs/node/pull/7988#discussion_r73800796"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/7988"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7988","id":80308588,"html_url":"https://github.com/nodejs/node/pull/7988","diff_url":"https://github.com/nodejs/node/pull/7988.diff","patch_url":"https://github.com/nodejs/node/pull/7988.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/7988","number":7988,"state":"open","locked":false,"title":"inspector: add inspector console support for native Console","user":{"login":"ak239","id":426418,"avatar_url":"https://avatars.githubusercontent.com/u/426418?v=3","gravatar_id":"","url":"https://api.github.com/users/ak239","html_url":"https://github.com/ak239","followers_url":"https://api.github.com/users/ak239/followers","following_url":"https://api.github.com/users/ak239/following{/other_user}","gists_url":"https://api.github.com/users/ak239/gists{/gist_id}","starred_url":"https://api.github.com/users/ak239/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak239/subscriptions","organizations_url":"https://api.github.com/users/ak239/orgs","repos_url":"https://api.github.com/users/ak239/repos","events_url":"https://api.github.com/users/ak239/events{/privacy}","received_events_url":"https://api.github.com/users/ak239/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nconsole\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nWhen node is running with --inspect flag, default console.log,\r\nconsole.warn and other methods call inspector console methods in\r\naddition to current behaviour (dump formatted message to stderr\r\nand stdout). Inspector console methods forward message to DevTools and\r\nshow its in DevTools Console with DevTools formatters. Inspector console\r\nmethods not presented on Node console will be added into it.\r\n\r\nOnly own methods on global.console object will be changed while\r\ndebugging session. User still able to redefine it, use console.Console\r\nor change original methods on Console.prototype.","created_at":"2016-08-05T21:18:17Z","updated_at":"2016-08-07T12:07:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4190c4723aeb4f2e0129433fb31ea5a361d68e5f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/7988/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/7988/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7988/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/ab0e9d064ae5b93972790b6e6a20c8ba221ced9a","head":{"label":"ak239:inspector-console-support","ref":"inspector-console-support","sha":"ab0e9d064ae5b93972790b6e6a20c8ba221ced9a","user":{"login":"ak239","id":426418,"avatar_url":"https://avatars.githubusercontent.com/u/426418?v=3","gravatar_id":"","url":"https://api.github.com/users/ak239","html_url":"https://github.com/ak239","followers_url":"https://api.github.com/users/ak239/followers","following_url":"https://api.github.com/users/ak239/following{/other_user}","gists_url":"https://api.github.com/users/ak239/gists{/gist_id}","starred_url":"https://api.github.com/users/ak239/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak239/subscriptions","organizations_url":"https://api.github.com/users/ak239/orgs","repos_url":"https://api.github.com/users/ak239/repos","events_url":"https://api.github.com/users/ak239/events{/privacy}","received_events_url":"https://api.github.com/users/ak239/received_events","type":"User","site_admin":false},"repo":{"id":65046950,"name":"node","full_name":"ak239/node","owner":{"login":"ak239","id":426418,"avatar_url":"https://avatars.githubusercontent.com/u/426418?v=3","gravatar_id":"","url":"https://api.github.com/users/ak239","html_url":"https://github.com/ak239","followers_url":"https://api.github.com/users/ak239/followers","following_url":"https://api.github.com/users/ak239/following{/other_user}","gists_url":"https://api.github.com/users/ak239/gists{/gist_id}","starred_url":"https://api.github.com/users/ak239/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak239/subscriptions","organizations_url":"https://api.github.com/users/ak239/orgs","repos_url":"https://api.github.com/users/ak239/repos","events_url":"https://api.github.com/users/ak239/events{/privacy}","received_events_url":"https://api.github.com/users/ak239/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ak239/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/ak239/node","forks_url":"https://api.github.com/repos/ak239/node/forks","keys_url":"https://api.github.com/repos/ak239/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ak239/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ak239/node/teams","hooks_url":"https://api.github.com/repos/ak239/node/hooks","issue_events_url":"https://api.github.com/repos/ak239/node/issues/events{/number}","events_url":"https://api.github.com/repos/ak239/node/events","assignees_url":"https://api.github.com/repos/ak239/node/assignees{/user}","branches_url":"https://api.github.com/repos/ak239/node/branches{/branch}","tags_url":"https://api.github.com/repos/ak239/node/tags","blobs_url":"https://api.github.com/repos/ak239/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ak239/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ak239/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ak239/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ak239/node/statuses/{sha}","languages_url":"https://api.github.com/repos/ak239/node/languages","stargazers_url":"https://api.github.com/repos/ak239/node/stargazers","contributors_url":"https://api.github.com/repos/ak239/node/contributors","subscribers_url":"https://api.github.com/repos/ak239/node/subscribers","subscription_url":"https://api.github.com/repos/ak239/node/subscription","commits_url":"https://api.github.com/repos/ak239/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ak239/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ak239/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ak239/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ak239/node/contents/{+path}","compare_url":"https://api.github.com/repos/ak239/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ak239/node/merges","archive_url":"https://api.github.com/repos/ak239/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ak239/node/downloads","issues_url":"https://api.github.com/repos/ak239/node/issues{/number}","pulls_url":"https://api.github.com/repos/ak239/node/pulls{/number}","milestones_url":"https://api.github.com/repos/ak239/node/milestones{/number}","notifications_url":"https://api.github.com/repos/ak239/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ak239/node/labels{/name}","releases_url":"https://api.github.com/repos/ak239/node/releases{/id}","deployments_url":"https://api.github.com/repos/ak239/node/deployments","created_at":"2016-08-05T20:27:12Z","updated_at":"2016-08-05T20:27:30Z","pushed_at":"2016-08-06T21:07:58Z","git_url":"git://github.com/ak239/node.git","ssh_url":"git@github.com:ak239/node.git","clone_url":"https://github.com/ak239/node.git","svn_url":"https://github.com/ak239/node","homepage":"https://nodejs.org","size":219812,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"b779eb423dd605fda6ec8847ebe10cca21161749","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-08-07T11:05:25Z","pushed_at":"2016-08-07T10:15:56Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":288175,"stargazers_count":25500,"watchers_count":25500,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3889,"mirror_url":null,"open_issues_count":741,"forks":3889,"open_issues":741,"watchers":25500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/7988"},"html":{"href":"https://github.com/nodejs/node/pull/7988"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/7988"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/7988/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/7988/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/7988/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/ab0e9d064ae5b93972790b6e6a20c8ba221ced9a"}}}}
{"actor":{"display_login":"bnoordhuis"}}