{"push_id":1267458583,"size":10,"distinct_size":10,"ref":"refs/heads/master","head":"029cbb35352ed79805da1b3a089e724b05bd2a80","before":"ae570a2ead7aa5fb78ef823a95ebbc7ed764a467","commits":[{"sha":"a887c9cbb0fbac2689fc4129d3d99af5302f9356","author":{"name":"Sam Phippen","email":"c2da78d483b6ed0dfda0dc04861587fcbe9ddf5b@googlemail.com"},"message":"Allow the `integration_sesion` to be set early on ActionDispatch::Integration::Runner.\n\nIn commit fa63448420d3385dbd043aca22dba973b45b8bb2, @tenderlove changed\nthe behaviour of the way `integration_session` is set up in this object.\nIt used to be the case that the first time it was accessed, it was\nmemoized with nil, however, this means that if it had already been set\nit was not replaced. After that commit, it is now always set to `nil` in\nthe execution of `before_setup`.\n\nIn RSpec, users are able to invoke `host!` in `before(:all)` blocks,\nwhich execute well before `before_setup` is ever invoked (which happens\nin what is equivalent to a `before(:each)` block, for each test. `host!`\ncauses the integration session to be set up to correctly change the\nhost, but after fa63448420d3385dbd043aca22dba973b45b8bb2 the\n`integration_session` gets overwritten, meaning that users lose their\n`host!` configuration (see https://github.com/rspec/rspec-rails/issues/1662).\n\nThis commit changes the behaviour back to memoizing with `nil`, as\nopposed to directly overwriting with `nil`. This causes the correct\nbehaviour to occur in RSpec, and unless I'm mistaken will also ensure\nthat users who want to modify their integration sessions early in rails\nwill also be able to do so.","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/a887c9cbb0fbac2689fc4129d3d99af5302f9356"},{"sha":"25c2bde7117241226d6e140e3a036c707f9ed14a","author":{"name":"Sam Phippen","email":"c2da78d483b6ed0dfda0dc04861587fcbe9ddf5b@googlemail.com"},"message":"Move setting of integration session to constructor.\n\nThis allows us to not `||=` in `before_setup`.","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/25c2bde7117241226d6e140e3a036c707f9ed14a"},{"sha":"3df5173d006f190548d38da3445a0dc3af3858ef","author":{"name":"James Coleman","email":"a4c2ab10343784117e12c22a304f098d6fef86a7@gmail.com"},"message":"Test that AR query cache isn't busted when types are not same object\n\nThis is fixed in 5.0 as an ancillary part of 574f255629a45cd67babcfb9bb8e163e091a53b8\nbut here I also add a test for the condition.\n\nI'd previously backported the fix (and added a test) in the below\ncommit; this brings the fix back up to master.\n\n(cherry picked from commit fce3dbf30241f2a65c777e192a7171b0eea81453)","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/3df5173d006f190548d38da3445a0dc3af3858ef"},{"sha":"dd77e1bbfe36cfa002b009e9596ae0c706fabd11","author":{"name":"Sean Griffin","email":"745a5948f3a29be7b294faa8063f9998c214afbb@seantheprogrammer.com"},"message":"Merge pull request #26235 from samphippen/allow-early-setting-of-integration-session\n\nAllow the `integration_sesion` to be set early on ActionDispatch::Integration::Runner.","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/dd77e1bbfe36cfa002b009e9596ae0c706fabd11"},{"sha":"ef8315ac784aa778b71c803a8aa018676880b396","author":{"name":"Guillermo Iguaran","email":"d646716c9f186b7dabede70ff3a4ad11f2687bb5@gmail.com"},"message":"Merge pull request #26271 from jcoleman/fix-unnecessary-query-cache-busting-test\n\nTest that AR query cache isn't busted when types are not same object","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/ef8315ac784aa778b71c803a8aa018676880b396"},{"sha":"07da5aebb165f824d540fac620d2374b7a3799bb","author":{"name":"Aaron Patterson","email":"bd85a5e1e22acab07dfb17c9ff05b41f9f3fc5d5@gmail.com"},"message":"Simplify cache hit logging\n\nCacheHelper is mixed in to Helpers, Helpers is mixed in to AV::Base.\nThis means we can count on instances of AV::Base to have the \"cache hit\"\nmethod on them, and we can stop setting an ivar for cache logging and\njust ask the view if it was a cache hit.","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/07da5aebb165f824d540fac620d2374b7a3799bb"},{"sha":"c104940363ee616c3ea9e0eeb085e39740211fdf","author":{"name":"Aaron Patterson","email":"bd85a5e1e22acab07dfb17c9ff05b41f9f3fc5d5@gmail.com"},"message":"remove useless freeze\n\nRuby already does this freeze for us.","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/c104940363ee616c3ea9e0eeb085e39740211fdf"},{"sha":"804f5b3c2af90b69a51209c56739a077f3fb632b","author":{"name":"Aaron Patterson","email":"bd85a5e1e22acab07dfb17c9ff05b41f9f3fc5d5@gmail.com"},"message":"kick different instrumentation method\n\nWe can eliminate a conditional by calling a different instrumentation\nmethod depending on the situation.  In this case, we'll call the special\ncase \"!render_template\" instrumentation method and eliminate the case /\nwhen clause from the `instrument` method.","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/804f5b3c2af90b69a51209c56739a077f3fb632b"},{"sha":"0510208dd1ff23baa619884c0abcae4d141fae53","author":{"name":"Rafael Mendonça França","email":"34336d1352eb57c00d6c738f78075df0d11314db@gmail.com"},"message":"Add load hooks to all tests classes\n\nUsually users extends tests classes doing something like:\n\n    ActionView::TestCase.include MyCustomTestHelpers\n\nThis is bad because it will load the ActionView::TestCase right aways\nand this will load ActionController::Base making its on_load hooks to\nexecute early than it should.\n\nOne way to fix this is using the on_load hooks of the components like:\n\n    ActiveSupport.on_load(:action_view) do\n      ActionView::TestCase.include MyCustomTestHelpers\n    end\n\nThe problem with this approach is that the test extension will be only\nload when ActionView::Base is loaded and this may happen too late in the\ntest.\n\nTo fix this we are adding hooks to people extend the test classes that\nwill be loaded exactly when the test classes are needed.","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/0510208dd1ff23baa619884c0abcae4d141fae53"},{"sha":"029cbb35352ed79805da1b3a089e724b05bd2a80","author":{"name":"Rafael Mendonça França","email":"34336d1352eb57c00d6c738f78075df0d11314db@gmail.com"},"message":"Fix typo in the hook name","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/029cbb35352ed79805da1b3a089e724b05bd2a80"}]}
{"actor":{"display_login":"yahonda"}}