{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/tidepool-org/hydrophone/pulls/28","id":80006812,"html_url":"https://github.com/tidepool-org/hydrophone/pull/28","diff_url":"https://github.com/tidepool-org/hydrophone/pull/28.diff","patch_url":"https://github.com/tidepool-org/hydrophone/pull/28.patch","issue_url":"https://api.github.com/repos/tidepool-org/hydrophone/issues/28","number":28,"state":"closed","locked":false,"title":"Allow sending signup confirmation again if email has changed; update tests","user":{"login":"darinkrauss","id":1224433,"avatar_url":"https://avatars.githubusercontent.com/u/1224433?v=3","gravatar_id":"","url":"https://api.github.com/users/darinkrauss","html_url":"https://github.com/darinkrauss","followers_url":"https://api.github.com/users/darinkrauss/followers","following_url":"https://api.github.com/users/darinkrauss/following{/other_user}","gists_url":"https://api.github.com/users/darinkrauss/gists{/gist_id}","starred_url":"https://api.github.com/users/darinkrauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darinkrauss/subscriptions","organizations_url":"https://api.github.com/users/darinkrauss/orgs","repos_url":"https://api.github.com/users/darinkrauss/repos","events_url":"https://api.github.com/users/darinkrauss/events{/privacy}","received_events_url":"https://api.github.com/users/darinkrauss/received_events","type":"User","site_admin":false},"body":"@jh-bate This allows custodians (i.e. a clinic) to update the email of a patient account (not yet verified) and send a new signup verification email to the updated email address. It updates the /confirm/send/signup/{userid} endpoint to check if a confirmation already exists for the user id *with a confirmation email address that differs from the user email address* and then updates the confirmation email to match the user and sends the verification email to the new email address.\r\n\r\nI couldn't figure out how to shoe-horn a test into the test structure for this project without significant effort. I tested manually and it works as designed.","created_at":"2016-08-04T01:48:12Z","updated_at":"2016-08-04T14:35:17Z","closed_at":"2016-08-04T14:35:17Z","merged_at":"2016-08-04T14:35:16Z","merge_commit_sha":"cfc9ecbdd1c0c38e048514dc7c5348e03443b4c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tidepool-org/hydrophone/pulls/28/commits","review_comments_url":"https://api.github.com/repos/tidepool-org/hydrophone/pulls/28/comments","review_comment_url":"https://api.github.com/repos/tidepool-org/hydrophone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tidepool-org/hydrophone/issues/28/comments","statuses_url":"https://api.github.com/repos/tidepool-org/hydrophone/statuses/cfc9ecbdd1c0c38e048514dc7c5348e03443b4c5","head":{"label":"tidepool-org:darinkrauss/send-updated-confirmation","ref":"darinkrauss/send-updated-confirmation","sha":"cfc9ecbdd1c0c38e048514dc7c5348e03443b4c5","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":23680705,"name":"hydrophone","full_name":"tidepool-org/hydrophone","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/hydrophone","description":"This API sends notifications to users for things like forgotten passwords, initial signup, and invitations.","fork":false,"url":"https://api.github.com/repos/tidepool-org/hydrophone","forks_url":"https://api.github.com/repos/tidepool-org/hydrophone/forks","keys_url":"https://api.github.com/repos/tidepool-org/hydrophone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/hydrophone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/hydrophone/teams","hooks_url":"https://api.github.com/repos/tidepool-org/hydrophone/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/hydrophone/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/hydrophone/events","assignees_url":"https://api.github.com/repos/tidepool-org/hydrophone/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/hydrophone/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/hydrophone/tags","blobs_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/hydrophone/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/hydrophone/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/hydrophone/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/hydrophone/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/hydrophone/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/hydrophone/subscription","commits_url":"https://api.github.com/repos/tidepool-org/hydrophone/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/hydrophone/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/hydrophone/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidepool-org/hydrophone/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/hydrophone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/hydrophone/merges","archive_url":"https://api.github.com/repos/tidepool-org/hydrophone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/hydrophone/downloads","issues_url":"https://api.github.com/repos/tidepool-org/hydrophone/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/hydrophone/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/hydrophone/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/hydrophone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/hydrophone/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/hydrophone/releases{/id}","deployments_url":"https://api.github.com/repos/tidepool-org/hydrophone/deployments","created_at":"2014-09-04T21:51:34Z","updated_at":"2016-01-12T18:13:06Z","pushed_at":"2016-08-04T14:35:16Z","git_url":"git://github.com/tidepool-org/hydrophone.git","ssh_url":"git@github.com:tidepool-org/hydrophone.git","clone_url":"https://github.com/tidepool-org/hydrophone.git","svn_url":"https://github.com/tidepool-org/hydrophone","homepage":null,"size":208,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tidepool-org:master","ref":"master","sha":"7127852c0b04cc3aab58b1856e886b1797e3952d","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":23680705,"name":"hydrophone","full_name":"tidepool-org/hydrophone","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/hydrophone","description":"This API sends notifications to users for things like forgotten passwords, initial signup, and invitations.","fork":false,"url":"https://api.github.com/repos/tidepool-org/hydrophone","forks_url":"https://api.github.com/repos/tidepool-org/hydrophone/forks","keys_url":"https://api.github.com/repos/tidepool-org/hydrophone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/hydrophone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/hydrophone/teams","hooks_url":"https://api.github.com/repos/tidepool-org/hydrophone/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/hydrophone/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/hydrophone/events","assignees_url":"https://api.github.com/repos/tidepool-org/hydrophone/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/hydrophone/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/hydrophone/tags","blobs_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/hydrophone/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/hydrophone/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/hydrophone/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/hydrophone/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/hydrophone/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/hydrophone/subscription","commits_url":"https://api.github.com/repos/tidepool-org/hydrophone/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/hydrophone/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/hydrophone/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/hydrophone/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidepool-org/hydrophone/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/hydrophone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/hydrophone/merges","archive_url":"https://api.github.com/repos/tidepool-org/hydrophone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/hydrophone/downloads","issues_url":"https://api.github.com/repos/tidepool-org/hydrophone/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/hydrophone/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/hydrophone/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/hydrophone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/hydrophone/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/hydrophone/releases{/id}","deployments_url":"https://api.github.com/repos/tidepool-org/hydrophone/deployments","created_at":"2014-09-04T21:51:34Z","updated_at":"2016-01-12T18:13:06Z","pushed_at":"2016-08-04T14:35:16Z","git_url":"git://github.com/tidepool-org/hydrophone.git","ssh_url":"git@github.com:tidepool-org/hydrophone.git","clone_url":"https://github.com/tidepool-org/hydrophone.git","svn_url":"https://github.com/tidepool-org/hydrophone","homepage":null,"size":208,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/hydrophone/pulls/28"},"html":{"href":"https://github.com/tidepool-org/hydrophone/pull/28"},"issue":{"href":"https://api.github.com/repos/tidepool-org/hydrophone/issues/28"},"comments":{"href":"https://api.github.com/repos/tidepool-org/hydrophone/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/tidepool-org/hydrophone/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/tidepool-org/hydrophone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tidepool-org/hydrophone/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/tidepool-org/hydrophone/statuses/cfc9ecbdd1c0c38e048514dc7c5348e03443b4c5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"darinkrauss","id":1224433,"avatar_url":"https://avatars.githubusercontent.com/u/1224433?v=3","gravatar_id":"","url":"https://api.github.com/users/darinkrauss","html_url":"https://github.com/darinkrauss","followers_url":"https://api.github.com/users/darinkrauss/followers","following_url":"https://api.github.com/users/darinkrauss/following{/other_user}","gists_url":"https://api.github.com/users/darinkrauss/gists{/gist_id}","starred_url":"https://api.github.com/users/darinkrauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darinkrauss/subscriptions","organizations_url":"https://api.github.com/users/darinkrauss/orgs","repos_url":"https://api.github.com/users/darinkrauss/repos","events_url":"https://api.github.com/users/darinkrauss/events{/privacy}","received_events_url":"https://api.github.com/users/darinkrauss/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":16,"deletions":18,"changed_files":2}}
{"actor":{"display_login":"darinkrauss"}}