{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/66208530","id":66208530,"diff_hunk":"@@ -1407,4 +1416,37 @@ StringTests.test(\"String.replaceSubrange()/string/range\") {\n   }\n }\n \n+StringTests.test(\"String.replaceSubrange()/characters/closedRange\") {\n+  for test in replaceSubrangeTests {\n+    guard let closedExpected = test.closedExpected else {\n+      continue\n+    }\n+    var theString = test.original\n+    let c = test.original.characters\n+    let rangeToReplace = test.rangeSelection.closedRange(in: c)\n+    let newCharacters : [Character] = test.newElements.characters.map { $0 }","path":"validation-test/stdlib/String.swift","position":null,"original_position":88,"commit_id":"30ba084a7066b5772c55c6f83810f82499221e4c","original_commit_id":"9dba3151eb9f4ff11a3ee36f530a84893b0e71f8","user":{"login":"austinzheng","id":3687054,"avatar_url":"https://avatars.githubusercontent.com/u/3687054?v=3","gravatar_id":"","url":"https://api.github.com/users/austinzheng","html_url":"https://github.com/austinzheng","followers_url":"https://api.github.com/users/austinzheng/followers","following_url":"https://api.github.com/users/austinzheng/following{/other_user}","gists_url":"https://api.github.com/users/austinzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/austinzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinzheng/subscriptions","organizations_url":"https://api.github.com/users/austinzheng/orgs","repos_url":"https://api.github.com/users/austinzheng/repos","events_url":"https://api.github.com/users/austinzheng/events{/privacy}","received_events_url":"https://api.github.com/users/austinzheng/received_events","type":"User","site_admin":false},"body":"Thanks for the review. I fixed the formatting and changed the code to use the `Array` initializer.","created_at":"2016-06-08T08:01:44Z","updated_at":"2016-06-08T08:01:44Z","html_url":"https://github.com/apple/swift/pull/2944#discussion_r66208530","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/2944","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/66208530"},"html":{"href":"https://github.com/apple/swift/pull/2944#discussion_r66208530"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/2944"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/2944","id":72980611,"html_url":"https://github.com/apple/swift/pull/2944","diff_url":"https://github.com/apple/swift/pull/2944.diff","patch_url":"https://github.com/apple/swift/pull/2944.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/2944","number":2944,"state":"open","locked":false,"title":"Adding tests for String's replaceSubrange overloads for closed ranges","user":{"login":"austinzheng","id":3687054,"avatar_url":"https://avatars.githubusercontent.com/u/3687054?v=3","gravatar_id":"","url":"https://api.github.com/users/austinzheng","html_url":"https://github.com/austinzheng","followers_url":"https://api.github.com/users/austinzheng/followers","following_url":"https://api.github.com/users/austinzheng/following{/other_user}","gists_url":"https://api.github.com/users/austinzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/austinzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinzheng/subscriptions","organizations_url":"https://api.github.com/users/austinzheng/orgs","repos_url":"https://api.github.com/users/austinzheng/repos","events_url":"https://api.github.com/users/austinzheng/events{/privacy}","received_events_url":"https://api.github.com/users/austinzheng/received_events","type":"User","site_admin":false},"body":"<!-- Please complete this template before creating pull request. -->\r\n#### What's in this pull request?\r\n\r\nTests for `replaceSubrange` overloads on `String` for closed ranges. @gribozavr \r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\n","created_at":"2016-06-08T03:09:47Z","updated_at":"2016-06-08T08:01:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b358df31fc25dd83bd3be6b0aa683b6c0a8ad2f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/2944/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/2944/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/2944/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/30ba084a7066b5772c55c6f83810f82499221e4c","head":{"label":"austinzheng:az-st2","ref":"az-st2","sha":"30ba084a7066b5772c55c6f83810f82499221e4c","user":{"login":"austinzheng","id":3687054,"avatar_url":"https://avatars.githubusercontent.com/u/3687054?v=3","gravatar_id":"","url":"https://api.github.com/users/austinzheng","html_url":"https://github.com/austinzheng","followers_url":"https://api.github.com/users/austinzheng/followers","following_url":"https://api.github.com/users/austinzheng/following{/other_user}","gists_url":"https://api.github.com/users/austinzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/austinzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinzheng/subscriptions","organizations_url":"https://api.github.com/users/austinzheng/orgs","repos_url":"https://api.github.com/users/austinzheng/repos","events_url":"https://api.github.com/users/austinzheng/events{/privacy}","received_events_url":"https://api.github.com/users/austinzheng/received_events","type":"User","site_admin":false},"repo":{"id":47350412,"name":"swift","full_name":"austinzheng/swift","owner":{"login":"austinzheng","id":3687054,"avatar_url":"https://avatars.githubusercontent.com/u/3687054?v=3","gravatar_id":"","url":"https://api.github.com/users/austinzheng","html_url":"https://github.com/austinzheng","followers_url":"https://api.github.com/users/austinzheng/followers","following_url":"https://api.github.com/users/austinzheng/following{/other_user}","gists_url":"https://api.github.com/users/austinzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/austinzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinzheng/subscriptions","organizations_url":"https://api.github.com/users/austinzheng/orgs","repos_url":"https://api.github.com/users/austinzheng/repos","events_url":"https://api.github.com/users/austinzheng/events{/privacy}","received_events_url":"https://api.github.com/users/austinzheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/austinzheng/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/austinzheng/swift","forks_url":"https://api.github.com/repos/austinzheng/swift/forks","keys_url":"https://api.github.com/repos/austinzheng/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/austinzheng/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/austinzheng/swift/teams","hooks_url":"https://api.github.com/repos/austinzheng/swift/hooks","issue_events_url":"https://api.github.com/repos/austinzheng/swift/issues/events{/number}","events_url":"https://api.github.com/repos/austinzheng/swift/events","assignees_url":"https://api.github.com/repos/austinzheng/swift/assignees{/user}","branches_url":"https://api.github.com/repos/austinzheng/swift/branches{/branch}","tags_url":"https://api.github.com/repos/austinzheng/swift/tags","blobs_url":"https://api.github.com/repos/austinzheng/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/austinzheng/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/austinzheng/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/austinzheng/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/austinzheng/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/austinzheng/swift/languages","stargazers_url":"https://api.github.com/repos/austinzheng/swift/stargazers","contributors_url":"https://api.github.com/repos/austinzheng/swift/contributors","subscribers_url":"https://api.github.com/repos/austinzheng/swift/subscribers","subscription_url":"https://api.github.com/repos/austinzheng/swift/subscription","commits_url":"https://api.github.com/repos/austinzheng/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/austinzheng/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/austinzheng/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/austinzheng/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/austinzheng/swift/contents/{+path}","compare_url":"https://api.github.com/repos/austinzheng/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/austinzheng/swift/merges","archive_url":"https://api.github.com/repos/austinzheng/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/austinzheng/swift/downloads","issues_url":"https://api.github.com/repos/austinzheng/swift/issues{/number}","pulls_url":"https://api.github.com/repos/austinzheng/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/austinzheng/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/austinzheng/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/austinzheng/swift/labels{/name}","releases_url":"https://api.github.com/repos/austinzheng/swift/releases{/id}","deployments_url":"https://api.github.com/repos/austinzheng/swift/deployments","created_at":"2015-12-03T18:05:27Z","updated_at":"2016-01-18T23:45:13Z","pushed_at":"2016-06-08T08:01:08Z","git_url":"git://github.com/austinzheng/swift.git","ssh_url":"git@github.com:austinzheng/swift.git","clone_url":"https://github.com/austinzheng/swift.git","svn_url":"https://github.com/austinzheng/swift","homepage":"","size":96406,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"09c0b60e1268950d0cd8810afd423505c2d7be78","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-06-08T07:49:06Z","pushed_at":"2016-06-08T08:01:09Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":150863,"stargazers_count":31004,"watchers_count":31004,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4236,"mirror_url":null,"open_issues_count":101,"forks":4236,"open_issues":101,"watchers":31004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/2944"},"html":{"href":"https://github.com/apple/swift/pull/2944"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/2944"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/2944/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/2944/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/2944/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/30ba084a7066b5772c55c6f83810f82499221e4c"}}}}
{"actor":{"display_login":"austinzheng"}}