{"action":"created","comment":{"url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments/51948208","id":51948208,"diff_hunk":"@@ -600,23 +608,24 @@ def _read_frame(self, frame):\n             for line in f:\n                 if line[:6] == 'ENDMDL':\n                     break\n-                # NOTE - CRYST1 line won't be found if it comes before the MODEL\n-                # line, which is sometimes the case, e.g. output from gromacs\n-                # trjconv\n+                # NOTE - CRYST1 line won't be found if it comes before the\n+                # MODEL line, which is sometimes the case, e.g. output from\n+                # gromacs trjconv\n                 elif line[:6] == 'CRYST1':\n-                    A, B, C = map(float, [line[6:15], line[15:24], line[24:33]])\n-                    alpha, beta, gamma = map(float, [line[33:40], line[40:47],\n+                    A, B, C = np.float32([line[6:15], line[15:24],\n+                                          line[24:33]])\n+                    alpha, beta, gamma = np.float32([line[33:40], line[40:47],\n                                                      line[47:54]])\n                     self.ts._unitcell[:] = A, B, C, alpha, beta, gamma\n                     continue\n                 elif line[:6] in ('ATOM  ', 'HETATM'):\n                     # we only care about coordinates\n-                    self.ts._pos[pos] = list(map(float, [line[30:38],\n-                                                         line[38:46],\n-                                                         line[46:54]]))\n+                    self.ts._pos[pos] = np.float32([line[30:38],","path":"package/MDAnalysis/coordinates/PDB.py","position":136,"original_position":136,"commit_id":"3293cf01df6c1f212d4d393f3f482e75b1e497e2","original_commit_id":"3293cf01df6c1f212d4d393f3f482e75b1e497e2","user":{"login":"jbarnoud","id":1382074,"avatar_url":"https://avatars.githubusercontent.com/u/1382074?v=3","gravatar_id":"","url":"https://api.github.com/users/jbarnoud","html_url":"https://github.com/jbarnoud","followers_url":"https://api.github.com/users/jbarnoud/followers","following_url":"https://api.github.com/users/jbarnoud/following{/other_user}","gists_url":"https://api.github.com/users/jbarnoud/gists{/gist_id}","starred_url":"https://api.github.com/users/jbarnoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbarnoud/subscriptions","organizations_url":"https://api.github.com/users/jbarnoud/orgs","repos_url":"https://api.github.com/users/jbarnoud/repos","events_url":"https://api.github.com/users/jbarnoud/events{/privacy}","received_events_url":"https://api.github.com/users/jbarnoud/received_events","type":"User","site_admin":false},"body":"I think it does. But the type casting is actually not needed as any value you put in an array is first type casted by the array. For instance:\r\n\r\n```python\r\nIn [1]: import numpy as np\r\nIn [2]: a = np.zeros((4, 3))\r\nIn [3]: a[0, :] = '2.3 4.5 1.9'.split()  # The values we insert are strings\r\nIn [4]: a\r\nOut[4]:\r\narray([[ 2.3,  4.5,  1.9],\r\n       [ 0. ,  0. ,  0. ],\r\n       [ 0. ,  0. ,  0. ],\r\n       [ 0. ,  0. ,  0. ]])\r\nIn [5]: a.dtype\r\nOut[5]: dtype('float64')\r\nIn [6]: type(a[0, 0])\r\nOut[6]: numpy.float64\r\n```","created_at":"2016-02-04T22:26:49Z","updated_at":"2016-02-04T22:26:49Z","html_url":"https://github.com/MDAnalysis/mdanalysis/pull/694#discussion_r51948208","pull_request_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments/51948208"},"html":{"href":"https://github.com/MDAnalysis/mdanalysis/pull/694#discussion_r51948208"},"pull_request":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/694","id":58354992,"html_url":"https://github.com/MDAnalysis/mdanalysis/pull/694","diff_url":"https://github.com/MDAnalysis/mdanalysis/pull/694.diff","patch_url":"https://github.com/MDAnalysis/mdanalysis/pull/694.patch","issue_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/694","number":694,"state":"open","locked":false,"title":"Pdb connect fix, fixes #693","user":{"login":"kain88-de","id":4302678,"avatar_url":"https://avatars.githubusercontent.com/u/4302678?v=3","gravatar_id":"","url":"https://api.github.com/users/kain88-de","html_url":"https://github.com/kain88-de","followers_url":"https://api.github.com/users/kain88-de/followers","following_url":"https://api.github.com/users/kain88-de/following{/other_user}","gists_url":"https://api.github.com/users/kain88-de/gists{/gist_id}","starred_url":"https://api.github.com/users/kain88-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kain88-de/subscriptions","organizations_url":"https://api.github.com/users/kain88-de/orgs","repos_url":"https://api.github.com/users/kain88-de/repos","events_url":"https://api.github.com/users/kain88-de/events{/privacy}","received_events_url":"https://api.github.com/users/kain88-de/received_events","type":"User","site_admin":false},"body":"The old split approach didn't work for PDBs with more then 10000 atoms,\r\nbecause there isn't a whitespace anymore between atom ID's. The new\r\napproach works with those as well.\r\n\r\nfixes #693","created_at":"2016-02-04T21:52:24Z","updated_at":"2016-02-04T22:26:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6525e15a8f68f6f469052bd1a2a9815915a7de19","assignee":null,"milestone":{"url":"https://api.github.com/repos/MDAnalysis/mdanalysis/milestones/7","html_url":"https://github.com/MDAnalysis/mdanalysis/milestones/0.14","labels_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/milestones/7/labels","id":1454545,"number":7,"title":"0.14","description":"","creator":{"login":"orbeckst","id":237980,"avatar_url":"https://avatars.githubusercontent.com/u/237980?v=3","gravatar_id":"","url":"https://api.github.com/users/orbeckst","html_url":"https://github.com/orbeckst","followers_url":"https://api.github.com/users/orbeckst/followers","following_url":"https://api.github.com/users/orbeckst/following{/other_user}","gists_url":"https://api.github.com/users/orbeckst/gists{/gist_id}","starred_url":"https://api.github.com/users/orbeckst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbeckst/subscriptions","organizations_url":"https://api.github.com/users/orbeckst/orgs","repos_url":"https://api.github.com/users/orbeckst/repos","events_url":"https://api.github.com/users/orbeckst/events{/privacy}","received_events_url":"https://api.github.com/users/orbeckst/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":36,"state":"open","created_at":"2015-12-10T17:34:28Z","updated_at":"2016-02-04T21:52:31Z","due_on":"2016-01-31T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/694/commits","review_comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/694/comments","review_comment_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/694/comments","statuses_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/3293cf01df6c1f212d4d393f3f482e75b1e497e2","head":{"label":"kain88-de:pdb-connect-fix","ref":"pdb-connect-fix","sha":"3293cf01df6c1f212d4d393f3f482e75b1e497e2","user":{"login":"kain88-de","id":4302678,"avatar_url":"https://avatars.githubusercontent.com/u/4302678?v=3","gravatar_id":"","url":"https://api.github.com/users/kain88-de","html_url":"https://github.com/kain88-de","followers_url":"https://api.github.com/users/kain88-de/followers","following_url":"https://api.github.com/users/kain88-de/following{/other_user}","gists_url":"https://api.github.com/users/kain88-de/gists{/gist_id}","starred_url":"https://api.github.com/users/kain88-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kain88-de/subscriptions","organizations_url":"https://api.github.com/users/kain88-de/orgs","repos_url":"https://api.github.com/users/kain88-de/repos","events_url":"https://api.github.com/users/kain88-de/events{/privacy}","received_events_url":"https://api.github.com/users/kain88-de/received_events","type":"User","site_admin":false},"repo":{"id":40093220,"name":"mdanalysis","full_name":"kain88-de/mdanalysis","owner":{"login":"kain88-de","id":4302678,"avatar_url":"https://avatars.githubusercontent.com/u/4302678?v=3","gravatar_id":"","url":"https://api.github.com/users/kain88-de","html_url":"https://github.com/kain88-de","followers_url":"https://api.github.com/users/kain88-de/followers","following_url":"https://api.github.com/users/kain88-de/following{/other_user}","gists_url":"https://api.github.com/users/kain88-de/gists{/gist_id}","starred_url":"https://api.github.com/users/kain88-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kain88-de/subscriptions","organizations_url":"https://api.github.com/users/kain88-de/orgs","repos_url":"https://api.github.com/users/kain88-de/repos","events_url":"https://api.github.com/users/kain88-de/events{/privacy}","received_events_url":"https://api.github.com/users/kain88-de/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kain88-de/mdanalysis","description":"MDAnalysis is a Python toolkit to analyze molecular dynamics trajectories.","fork":true,"url":"https://api.github.com/repos/kain88-de/mdanalysis","forks_url":"https://api.github.com/repos/kain88-de/mdanalysis/forks","keys_url":"https://api.github.com/repos/kain88-de/mdanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kain88-de/mdanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kain88-de/mdanalysis/teams","hooks_url":"https://api.github.com/repos/kain88-de/mdanalysis/hooks","issue_events_url":"https://api.github.com/repos/kain88-de/mdanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/kain88-de/mdanalysis/events","assignees_url":"https://api.github.com/repos/kain88-de/mdanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/kain88-de/mdanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/kain88-de/mdanalysis/tags","blobs_url":"https://api.github.com/repos/kain88-de/mdanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kain88-de/mdanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kain88-de/mdanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/kain88-de/mdanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kain88-de/mdanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/kain88-de/mdanalysis/languages","stargazers_url":"https://api.github.com/repos/kain88-de/mdanalysis/stargazers","contributors_url":"https://api.github.com/repos/kain88-de/mdanalysis/contributors","subscribers_url":"https://api.github.com/repos/kain88-de/mdanalysis/subscribers","subscription_url":"https://api.github.com/repos/kain88-de/mdanalysis/subscription","commits_url":"https://api.github.com/repos/kain88-de/mdanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/kain88-de/mdanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/kain88-de/mdanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/kain88-de/mdanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/kain88-de/mdanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/kain88-de/mdanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kain88-de/mdanalysis/merges","archive_url":"https://api.github.com/repos/kain88-de/mdanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kain88-de/mdanalysis/downloads","issues_url":"https://api.github.com/repos/kain88-de/mdanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/kain88-de/mdanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/kain88-de/mdanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/kain88-de/mdanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kain88-de/mdanalysis/labels{/name}","releases_url":"https://api.github.com/repos/kain88-de/mdanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/kain88-de/mdanalysis/deployments","created_at":"2015-08-02T21:22:09Z","updated_at":"2015-08-02T21:22:15Z","pushed_at":"2016-02-04T21:51:37Z","git_url":"git://github.com/kain88-de/mdanalysis.git","ssh_url":"git@github.com:kain88-de/mdanalysis.git","clone_url":"https://github.com/kain88-de/mdanalysis.git","svn_url":"https://github.com/kain88-de/mdanalysis","homepage":"http://www.mdanalysis.org","size":168834,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MDAnalysis:develop","ref":"develop","sha":"0c918f4dc7e4edb9a20bfbd1723b5c02096e2397","user":{"login":"MDAnalysis","id":11445951,"avatar_url":"https://avatars.githubusercontent.com/u/11445951?v=3","gravatar_id":"","url":"https://api.github.com/users/MDAnalysis","html_url":"https://github.com/MDAnalysis","followers_url":"https://api.github.com/users/MDAnalysis/followers","following_url":"https://api.github.com/users/MDAnalysis/following{/other_user}","gists_url":"https://api.github.com/users/MDAnalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/MDAnalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDAnalysis/subscriptions","organizations_url":"https://api.github.com/users/MDAnalysis/orgs","repos_url":"https://api.github.com/users/MDAnalysis/repos","events_url":"https://api.github.com/users/MDAnalysis/events{/privacy}","received_events_url":"https://api.github.com/users/MDAnalysis/received_events","type":"Organization","site_admin":false},"repo":{"id":33389183,"name":"mdanalysis","full_name":"MDAnalysis/mdanalysis","owner":{"login":"MDAnalysis","id":11445951,"avatar_url":"https://avatars.githubusercontent.com/u/11445951?v=3","gravatar_id":"","url":"https://api.github.com/users/MDAnalysis","html_url":"https://github.com/MDAnalysis","followers_url":"https://api.github.com/users/MDAnalysis/followers","following_url":"https://api.github.com/users/MDAnalysis/following{/other_user}","gists_url":"https://api.github.com/users/MDAnalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/MDAnalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDAnalysis/subscriptions","organizations_url":"https://api.github.com/users/MDAnalysis/orgs","repos_url":"https://api.github.com/users/MDAnalysis/repos","events_url":"https://api.github.com/users/MDAnalysis/events{/privacy}","received_events_url":"https://api.github.com/users/MDAnalysis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MDAnalysis/mdanalysis","description":"MDAnalysis is a Python library to analyze molecular dynamics trajectories.","fork":false,"url":"https://api.github.com/repos/MDAnalysis/mdanalysis","forks_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/forks","keys_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/teams","hooks_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/hooks","issue_events_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/events","assignees_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/tags","blobs_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/languages","stargazers_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/stargazers","contributors_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/contributors","subscribers_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/subscribers","subscription_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/subscription","commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/merges","archive_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/downloads","issues_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/labels{/name}","releases_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/MDAnalysis/mdanalysis/deployments","created_at":"2015-04-04T00:39:41Z","updated_at":"2016-01-29T11:21:34Z","pushed_at":"2016-02-04T21:52:24Z","git_url":"git://github.com/MDAnalysis/mdanalysis.git","ssh_url":"git@github.com:MDAnalysis/mdanalysis.git","clone_url":"https://github.com/MDAnalysis/mdanalysis.git","svn_url":"https://github.com/MDAnalysis/mdanalysis","homepage":"http://www.mdanalysis.org","size":244602,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":80,"forks":33,"open_issues":80,"watchers":53,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/694"},"html":{"href":"https://github.com/MDAnalysis/mdanalysis/pull/694"},"issue":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/694"},"comments":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/MDAnalysis/mdanalysis/statuses/3293cf01df6c1f212d4d393f3f482e75b1e497e2"}}}}