{"action":"created","comment":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/77945632","id":77945632,"diff_hunk":"@@ -440,6 +440,12 @@ public function forwardHeaderTestsDataProvider()\n                 'requestUri' => 'https://acme.com',\n                 'expectedUri' => 'https://acme.com:80',\n             ),\n+            array(","path":"TYPO3.Flow/Tests/Unit/Http/Component/TrustedProxiesComponentTest.php","position":4,"original_position":4,"commit_id":"5cd10ffb30caf1dcb13f3fa9d3992509ec58578a","original_commit_id":"5cd10ffb30caf1dcb13f3fa9d3992509ec58578a","user":{"login":"daniellienert","id":642226,"avatar_url":"https://avatars.githubusercontent.com/u/642226?v=3","gravatar_id":"","url":"https://api.github.com/users/daniellienert","html_url":"https://github.com/daniellienert","followers_url":"https://api.github.com/users/daniellienert/followers","following_url":"https://api.github.com/users/daniellienert/following{/other_user}","gists_url":"https://api.github.com/users/daniellienert/gists{/gist_id}","starred_url":"https://api.github.com/users/daniellienert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniellienert/subscriptions","organizations_url":"https://api.github.com/users/daniellienert/orgs","repos_url":"https://api.github.com/users/daniellienert/repos","events_url":"https://api.github.com/users/daniellienert/events{/privacy}","received_events_url":"https://api.github.com/users/daniellienert/received_events","type":"User","site_admin":false},"body":"Small nitpick: Use short array syntax.","created_at":"2016-09-08T04:51:57Z","updated_at":"2016-09-08T04:51:57Z","html_url":"https://github.com/neos/flow-development-collection/pull/493#discussion_r77945632","pull_request_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/493","_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/77945632"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/493#discussion_r77945632"},"pull_request":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/493"}}},"pull_request":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/493","id":84364847,"html_url":"https://github.com/neos/flow-development-collection/pull/493","diff_url":"https://github.com/neos/flow-development-collection/pull/493.diff","patch_url":"https://github.com/neos/flow-development-collection/pull/493.patch","issue_url":"https://api.github.com/repos/neos/flow-development-collection/issues/493","number":493,"state":"open","locked":false,"title":"BUGFIX: Port is set correctly when Trusted Proxy only sends protocol override","user":{"login":"albe","id":4259532,"avatar_url":"https://avatars.githubusercontent.com/u/4259532?v=3","gravatar_id":"","url":"https://api.github.com/users/albe","html_url":"https://github.com/albe","followers_url":"https://api.github.com/users/albe/followers","following_url":"https://api.github.com/users/albe/following{/other_user}","gists_url":"https://api.github.com/users/albe/gists{/gist_id}","starred_url":"https://api.github.com/users/albe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albe/subscriptions","organizations_url":"https://api.github.com/users/albe/orgs","repos_url":"https://api.github.com/users/albe/repos","events_url":"https://api.github.com/users/albe/events{/privacy}","received_events_url":"https://api.github.com/users/albe/received_events","type":"User","site_admin":false},"body":"Before the port of the request URI was not set correctly if the Trusted Proxy would \r\nsend an `X-Forwarded-Proto: HTTPS` header without also specifying a forwarded port.\r\nThis resulted in generated URLs like \"https://acme.com:80\".\r\n\r\nThe change fixes that by doing a case insensitive check for the protocol to be\r\n'https' and set port 443 accordingly.","created_at":"2016-09-07T20:09:56Z","updated_at":"2016-09-08T04:51:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55c08ed799fe0477c9913a284ab279158203f2b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/493/commits","review_comments_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/493/comments","review_comment_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/issues/493/comments","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/5cd10ffb30caf1dcb13f3fa9d3992509ec58578a","head":{"label":"albe:https-forwarded-port","ref":"https-forwarded-port","sha":"5cd10ffb30caf1dcb13f3fa9d3992509ec58578a","user":{"login":"albe","id":4259532,"avatar_url":"https://avatars.githubusercontent.com/u/4259532?v=3","gravatar_id":"","url":"https://api.github.com/users/albe","html_url":"https://github.com/albe","followers_url":"https://api.github.com/users/albe/followers","following_url":"https://api.github.com/users/albe/following{/other_user}","gists_url":"https://api.github.com/users/albe/gists{/gist_id}","starred_url":"https://api.github.com/users/albe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albe/subscriptions","organizations_url":"https://api.github.com/users/albe/orgs","repos_url":"https://api.github.com/users/albe/repos","events_url":"https://api.github.com/users/albe/events{/privacy}","received_events_url":"https://api.github.com/users/albe/received_events","type":"User","site_admin":false},"repo":{"id":41612763,"name":"flow-development-collection","full_name":"albe/flow-development-collection","owner":{"login":"albe","id":4259532,"avatar_url":"https://avatars.githubusercontent.com/u/4259532?v=3","gravatar_id":"","url":"https://api.github.com/users/albe","html_url":"https://github.com/albe","followers_url":"https://api.github.com/users/albe/followers","following_url":"https://api.github.com/users/albe/following{/other_user}","gists_url":"https://api.github.com/users/albe/gists{/gist_id}","starred_url":"https://api.github.com/users/albe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albe/subscriptions","organizations_url":"https://api.github.com/users/albe/orgs","repos_url":"https://api.github.com/users/albe/repos","events_url":"https://api.github.com/users/albe/events{/privacy}","received_events_url":"https://api.github.com/users/albe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albe/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":true,"url":"https://api.github.com/repos/albe/flow-development-collection","forks_url":"https://api.github.com/repos/albe/flow-development-collection/forks","keys_url":"https://api.github.com/repos/albe/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albe/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albe/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/albe/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/albe/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/albe/flow-development-collection/events","assignees_url":"https://api.github.com/repos/albe/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/albe/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/albe/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/albe/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albe/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albe/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/albe/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albe/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/albe/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/albe/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/albe/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/albe/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/albe/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/albe/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/albe/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/albe/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/albe/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/albe/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/albe/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albe/flow-development-collection/merges","archive_url":"https://api.github.com/repos/albe/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albe/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/albe/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/albe/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/albe/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/albe/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albe/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/albe/flow-development-collection/releases{/id}","deployments_url":"https://api.github.com/repos/albe/flow-development-collection/deployments","created_at":"2015-08-30T01:29:22Z","updated_at":"2016-02-01T22:49:11Z","pushed_at":"2016-09-07T20:08:38Z","git_url":"git://github.com/albe/flow-development-collection.git","ssh_url":"git@github.com:albe/flow-development-collection.git","clone_url":"https://github.com/albe/flow-development-collection.git","svn_url":"https://github.com/albe/flow-development-collection","homepage":null,"size":37043,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:3.3","ref":"3.3","sha":"97e6f9a4ab24c40de3a28216027a1a41d60f1e00","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40963991,"name":"flow-development-collection","full_name":"neos/flow-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":false,"url":"https://api.github.com/repos/neos/flow-development-collection","forks_url":"https://api.github.com/repos/neos/flow-development-collection/forks","keys_url":"https://api.github.com/repos/neos/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/flow-development-collection/events","assignees_url":"https://api.github.com/repos/neos/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/flow-development-collection/merges","archive_url":"https://api.github.com/repos/neos/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/flow-development-collection/releases{/id}","deployments_url":"https://api.github.com/repos/neos/flow-development-collection/deployments","created_at":"2015-08-18T09:48:13Z","updated_at":"2016-08-30T14:25:38Z","pushed_at":"2016-09-07T20:09:57Z","git_url":"git://github.com/neos/flow-development-collection.git","ssh_url":"git@github.com:neos/flow-development-collection.git","clone_url":"https://github.com/neos/flow-development-collection.git","svn_url":"https://github.com/neos/flow-development-collection","homepage":"https://flow.neos.io/","size":37898,"stargazers_count":40,"watchers_count":40,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":71,"forks":77,"open_issues":71,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/493"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/493"},"issue":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/493"},"comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/neos/flow-development-collection/statuses/5cd10ffb30caf1dcb13f3fa9d3992509ec58578a"}}}}
{"actor":{"display_login":"daniellienert"}}