{"action":"closed","number":10315,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/10315","id":97088252,"html_url":"https://github.com/mrdoob/three.js/pull/10315","diff_url":"https://github.com/mrdoob/three.js/pull/10315.diff","patch_url":"https://github.com/mrdoob/three.js/pull/10315.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/10315","number":10315,"state":"closed","locked":false,"title":"Set key event handler on control DOM element","user":{"login":"charlesfleche","id":2563098,"avatar_url":"https://avatars.githubusercontent.com/u/2563098?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesfleche","html_url":"https://github.com/charlesfleche","followers_url":"https://api.github.com/users/charlesfleche/followers","following_url":"https://api.github.com/users/charlesfleche/following{/other_user}","gists_url":"https://api.github.com/users/charlesfleche/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesfleche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesfleche/subscriptions","organizations_url":"https://api.github.com/users/charlesfleche/orgs","repos_url":"https://api.github.com/users/charlesfleche/repos","events_url":"https://api.github.com/users/charlesfleche/events{/privacy}","received_events_url":"https://api.github.com/users/charlesfleche/received_events","type":"User","site_admin":false},"body":"This PR follows #10302\r\n\r\nThe controls globally listen to keyup / keydown events. That means that even if an<input> element exists outside of the control, moving the text cursor with the key arrows within this <input> will affect the control.\r\n\r\nThis PR ensures that key events are properly scoped.","created_at":"2016-12-08T09:43:05Z","updated_at":"2016-12-09T02:29:13Z","closed_at":"2016-12-09T02:29:13Z","merged_at":"2016-12-09T02:29:13Z","merge_commit_sha":"fdfc14ad6b912d51af4015a1796b76f4b2b49ad8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/10315/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/10315/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/10315/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/465d2afed38e24972f381118eee9916a275a78aa","head":{"label":"charlesfleche:keyevents-on-dom-element","ref":"keyevents-on-dom-element","sha":"465d2afed38e24972f381118eee9916a275a78aa","user":{"login":"charlesfleche","id":2563098,"avatar_url":"https://avatars.githubusercontent.com/u/2563098?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesfleche","html_url":"https://github.com/charlesfleche","followers_url":"https://api.github.com/users/charlesfleche/followers","following_url":"https://api.github.com/users/charlesfleche/following{/other_user}","gists_url":"https://api.github.com/users/charlesfleche/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesfleche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesfleche/subscriptions","organizations_url":"https://api.github.com/users/charlesfleche/orgs","repos_url":"https://api.github.com/users/charlesfleche/repos","events_url":"https://api.github.com/users/charlesfleche/events{/privacy}","received_events_url":"https://api.github.com/users/charlesfleche/received_events","type":"User","site_admin":false},"repo":{"id":65244734,"name":"three.js","full_name":"charlesfleche/three.js","owner":{"login":"charlesfleche","id":2563098,"avatar_url":"https://avatars.githubusercontent.com/u/2563098?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesfleche","html_url":"https://github.com/charlesfleche","followers_url":"https://api.github.com/users/charlesfleche/followers","following_url":"https://api.github.com/users/charlesfleche/following{/other_user}","gists_url":"https://api.github.com/users/charlesfleche/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesfleche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesfleche/subscriptions","organizations_url":"https://api.github.com/users/charlesfleche/orgs","repos_url":"https://api.github.com/users/charlesfleche/repos","events_url":"https://api.github.com/users/charlesfleche/events{/privacy}","received_events_url":"https://api.github.com/users/charlesfleche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charlesfleche/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/charlesfleche/three.js","forks_url":"https://api.github.com/repos/charlesfleche/three.js/forks","keys_url":"https://api.github.com/repos/charlesfleche/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charlesfleche/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charlesfleche/three.js/teams","hooks_url":"https://api.github.com/repos/charlesfleche/three.js/hooks","issue_events_url":"https://api.github.com/repos/charlesfleche/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/charlesfleche/three.js/events","assignees_url":"https://api.github.com/repos/charlesfleche/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/charlesfleche/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/charlesfleche/three.js/tags","blobs_url":"https://api.github.com/repos/charlesfleche/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charlesfleche/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charlesfleche/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/charlesfleche/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charlesfleche/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/charlesfleche/three.js/languages","stargazers_url":"https://api.github.com/repos/charlesfleche/three.js/stargazers","contributors_url":"https://api.github.com/repos/charlesfleche/three.js/contributors","subscribers_url":"https://api.github.com/repos/charlesfleche/three.js/subscribers","subscription_url":"https://api.github.com/repos/charlesfleche/three.js/subscription","commits_url":"https://api.github.com/repos/charlesfleche/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/charlesfleche/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/charlesfleche/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/charlesfleche/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/charlesfleche/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/charlesfleche/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charlesfleche/three.js/merges","archive_url":"https://api.github.com/repos/charlesfleche/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charlesfleche/three.js/downloads","issues_url":"https://api.github.com/repos/charlesfleche/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/charlesfleche/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/charlesfleche/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/charlesfleche/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charlesfleche/three.js/labels{/name}","releases_url":"https://api.github.com/repos/charlesfleche/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/charlesfleche/three.js/deployments","created_at":"2016-08-08T22:43:23Z","updated_at":"2016-08-08T22:43:29Z","pushed_at":"2016-12-08T09:40:11Z","git_url":"git://github.com/charlesfleche/three.js.git","ssh_url":"git@github.com:charlesfleche/three.js.git","clone_url":"https://github.com/charlesfleche/three.js.git","svn_url":"https://github.com/charlesfleche/three.js","homepage":"http://threejs.org/","size":430212,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"40ddc192c76046d0ece4d20391f0f52398d7b0a2","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-12-09T02:29:01Z","pushed_at":"2016-12-09T02:29:13Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":653772,"stargazers_count":29326,"watchers_count":29326,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":10163,"mirror_url":null,"open_issues_count":863,"forks":10163,"open_issues":863,"watchers":29326,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10315"},"html":{"href":"https://github.com/mrdoob/three.js/pull/10315"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/10315"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/10315/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10315/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10315/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/465d2afed38e24972f381118eee9916a275a78aa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":22,"changed_files":5}}
{"actor":{"display_login":"mrdoob"}}