{"action":"created","comment":{"url":"https://api.github.com/repos/chaijs/chai/pulls/comments/92946148","pull_request_review_id":13468437,"id":92946148,"diff_hunk":"@@ -75,13 +75,18 @@ module.exports = function (ctx, name, method, chainingBehavior) {\n   ctx.__methods[name] = chainableBehavior;\n \n   Object.defineProperty(ctx, name,\n-    { get: function () {\n+    { get: function chainableMethodGetter() {\n         chainableBehavior.chainingBehavior.call(this);\n \n-        var assert = function assert() {\n-          var old_ssfi = flag(this, 'ssfi');\n-          if (old_ssfi)\n-            flag(this, 'ssfi', assert);\n+        var chainableMethodWrapper = function () {\n+          // Use this chainable method wrapper as the starting point for\n+          // removing implementation frames from the stack trace of a failed\n+          // assertion. Note that this is the correct starting point even if\n+          // this assertion has been overwritten since overwriting a chainable\n+          // method merely replaces the saved methods in `ctx.__methods` instead\n+          // of completely replacing the overwritten assertion.\n+          flag(this, 'ssfi', chainableMethodWrapper);","path":"lib/chai/utils/addChainableMethod.js","position":28,"original_position":28,"commit_id":"6d13b83f91331ee2e38b435d2ebb71c54032a42f","original_commit_id":"6d13b83f91331ee2e38b435d2ebb71c54032a42f","user":{"login":"meeber","id":17260989,"avatar_url":"https://avatars.githubusercontent.com/u/17260989?v=3","gravatar_id":"","url":"https://api.github.com/users/meeber","html_url":"https://github.com/meeber","followers_url":"https://api.github.com/users/meeber/followers","following_url":"https://api.github.com/users/meeber/following{/other_user}","gists_url":"https://api.github.com/users/meeber/gists{/gist_id}","starred_url":"https://api.github.com/users/meeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeber/subscriptions","organizations_url":"https://api.github.com/users/meeber/orgs","repos_url":"https://api.github.com/users/meeber/repos","events_url":"https://api.github.com/users/meeber/events{/privacy}","received_events_url":"https://api.github.com/users/meeber/received_events","type":"User","site_admin":false},"body":"According to [this comment](https://github.com/chaijs/chai/issues/464#issuecomment-116600541), it's \"start stack function indicator\". Also mentioned on http://chaijs.com/guide/plugins/. I don't feel strongly one way or another about renaming it.","created_at":"2016-12-18T17:32:24Z","updated_at":"2016-12-18T17:32:24Z","html_url":"https://github.com/chaijs/chai/pull/884#discussion_r92946148","pull_request_url":"https://api.github.com/repos/chaijs/chai/pulls/884","_links":{"self":{"href":"https://api.github.com/repos/chaijs/chai/pulls/comments/92946148"},"html":{"href":"https://github.com/chaijs/chai/pull/884#discussion_r92946148"},"pull_request":{"href":"https://api.github.com/repos/chaijs/chai/pulls/884"}}},"pull_request":{"url":"https://api.github.com/repos/chaijs/chai/pulls/884","id":97475850,"html_url":"https://github.com/chaijs/chai/pull/884","diff_url":"https://github.com/chaijs/chai/pull/884.diff","patch_url":"https://github.com/chaijs/chai/pull/884.patch","issue_url":"https://api.github.com/repos/chaijs/chai/issues/884","number":884,"state":"open","locked":false,"title":"Remove proxy frames from stack traces and improve docs/tests","user":{"login":"meeber","id":17260989,"avatar_url":"https://avatars.githubusercontent.com/u/17260989?v=3","gravatar_id":"","url":"https://api.github.com/users/meeber","html_url":"https://github.com/meeber","followers_url":"https://api.github.com/users/meeber/followers","following_url":"https://api.github.com/users/meeber/following{/other_user}","gists_url":"https://api.github.com/users/meeber/gists{/gist_id}","starred_url":"https://api.github.com/users/meeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeber/subscriptions","organizations_url":"https://api.github.com/users/meeber/orgs","repos_url":"https://api.github.com/users/meeber/repos","events_url":"https://api.github.com/users/meeber/events{/privacy}","received_events_url":"https://api.github.com/users/meeber/received_events","type":"User","site_admin":false},"body":"This PR is intentionally split into a number of commits, each one of which has a description within the commit message.\r\n\r\nHighlights of this PR:\r\n\r\n- Remove Chai's internal proxy frames from stack traces of failed property assertions (note: they were already correctly removed from the stack traces of failed method and chainable method assertions)\r\n- Improve tests and inline documentation related to Chai's stack trace wizardry\r\n- Remove dead code related to Chai's stack trace wizardry\r\n\r\nNote that this doesn't address #878 regarding extra frames in stack traces when using the `assert` interface.","created_at":"2016-12-11T22:28:43Z","updated_at":"2016-12-18T17:32:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c36dc9dacc3119b8a76ea3170db365003b3aa632","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chaijs/chai/pulls/884/commits","review_comments_url":"https://api.github.com/repos/chaijs/chai/pulls/884/comments","review_comment_url":"https://api.github.com/repos/chaijs/chai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chaijs/chai/issues/884/comments","statuses_url":"https://api.github.com/repos/chaijs/chai/statuses/6d13b83f91331ee2e38b435d2ebb71c54032a42f","head":{"label":"meeber:fix-stack","ref":"fix-stack","sha":"6d13b83f91331ee2e38b435d2ebb71c54032a42f","user":{"login":"meeber","id":17260989,"avatar_url":"https://avatars.githubusercontent.com/u/17260989?v=3","gravatar_id":"","url":"https://api.github.com/users/meeber","html_url":"https://github.com/meeber","followers_url":"https://api.github.com/users/meeber/followers","following_url":"https://api.github.com/users/meeber/following{/other_user}","gists_url":"https://api.github.com/users/meeber/gists{/gist_id}","starred_url":"https://api.github.com/users/meeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeber/subscriptions","organizations_url":"https://api.github.com/users/meeber/orgs","repos_url":"https://api.github.com/users/meeber/repos","events_url":"https://api.github.com/users/meeber/events{/privacy}","received_events_url":"https://api.github.com/users/meeber/received_events","type":"User","site_admin":false},"repo":{"id":55719600,"name":"chai","full_name":"meeber/chai","owner":{"login":"meeber","id":17260989,"avatar_url":"https://avatars.githubusercontent.com/u/17260989?v=3","gravatar_id":"","url":"https://api.github.com/users/meeber","html_url":"https://github.com/meeber","followers_url":"https://api.github.com/users/meeber/followers","following_url":"https://api.github.com/users/meeber/following{/other_user}","gists_url":"https://api.github.com/users/meeber/gists{/gist_id}","starred_url":"https://api.github.com/users/meeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeber/subscriptions","organizations_url":"https://api.github.com/users/meeber/orgs","repos_url":"https://api.github.com/users/meeber/repos","events_url":"https://api.github.com/users/meeber/events{/privacy}","received_events_url":"https://api.github.com/users/meeber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meeber/chai","description":"BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.","fork":true,"url":"https://api.github.com/repos/meeber/chai","forks_url":"https://api.github.com/repos/meeber/chai/forks","keys_url":"https://api.github.com/repos/meeber/chai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meeber/chai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meeber/chai/teams","hooks_url":"https://api.github.com/repos/meeber/chai/hooks","issue_events_url":"https://api.github.com/repos/meeber/chai/issues/events{/number}","events_url":"https://api.github.com/repos/meeber/chai/events","assignees_url":"https://api.github.com/repos/meeber/chai/assignees{/user}","branches_url":"https://api.github.com/repos/meeber/chai/branches{/branch}","tags_url":"https://api.github.com/repos/meeber/chai/tags","blobs_url":"https://api.github.com/repos/meeber/chai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meeber/chai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meeber/chai/git/refs{/sha}","trees_url":"https://api.github.com/repos/meeber/chai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meeber/chai/statuses/{sha}","languages_url":"https://api.github.com/repos/meeber/chai/languages","stargazers_url":"https://api.github.com/repos/meeber/chai/stargazers","contributors_url":"https://api.github.com/repos/meeber/chai/contributors","subscribers_url":"https://api.github.com/repos/meeber/chai/subscribers","subscription_url":"https://api.github.com/repos/meeber/chai/subscription","commits_url":"https://api.github.com/repos/meeber/chai/commits{/sha}","git_commits_url":"https://api.github.com/repos/meeber/chai/git/commits{/sha}","comments_url":"https://api.github.com/repos/meeber/chai/comments{/number}","issue_comment_url":"https://api.github.com/repos/meeber/chai/issues/comments{/number}","contents_url":"https://api.github.com/repos/meeber/chai/contents/{+path}","compare_url":"https://api.github.com/repos/meeber/chai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meeber/chai/merges","archive_url":"https://api.github.com/repos/meeber/chai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meeber/chai/downloads","issues_url":"https://api.github.com/repos/meeber/chai/issues{/number}","pulls_url":"https://api.github.com/repos/meeber/chai/pulls{/number}","milestones_url":"https://api.github.com/repos/meeber/chai/milestones{/number}","notifications_url":"https://api.github.com/repos/meeber/chai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meeber/chai/labels{/name}","releases_url":"https://api.github.com/repos/meeber/chai/releases{/id}","deployments_url":"https://api.github.com/repos/meeber/chai/deployments","created_at":"2016-04-07T18:50:04Z","updated_at":"2016-04-07T18:50:05Z","pushed_at":"2016-12-11T22:19:45Z","git_url":"git://github.com/meeber/chai.git","ssh_url":"git@github.com:meeber/chai.git","clone_url":"https://github.com/meeber/chai.git","svn_url":"https://github.com/meeber/chai","homepage":"http://chaijs.com","size":2787,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chaijs:master","ref":"master","sha":"b7ff1446a7fc63ee99c4b7bfd8d71fe27b087f45","user":{"login":"chaijs","id":1515293,"avatar_url":"https://avatars.githubusercontent.com/u/1515293?v=3","gravatar_id":"","url":"https://api.github.com/users/chaijs","html_url":"https://github.com/chaijs","followers_url":"https://api.github.com/users/chaijs/followers","following_url":"https://api.github.com/users/chaijs/following{/other_user}","gists_url":"https://api.github.com/users/chaijs/gists{/gist_id}","starred_url":"https://api.github.com/users/chaijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaijs/subscriptions","organizations_url":"https://api.github.com/users/chaijs/orgs","repos_url":"https://api.github.com/users/chaijs/repos","events_url":"https://api.github.com/users/chaijs/events{/privacy}","received_events_url":"https://api.github.com/users/chaijs/received_events","type":"Organization","site_admin":false},"repo":{"id":2931111,"name":"chai","full_name":"chaijs/chai","owner":{"login":"chaijs","id":1515293,"avatar_url":"https://avatars.githubusercontent.com/u/1515293?v=3","gravatar_id":"","url":"https://api.github.com/users/chaijs","html_url":"https://github.com/chaijs","followers_url":"https://api.github.com/users/chaijs/followers","following_url":"https://api.github.com/users/chaijs/following{/other_user}","gists_url":"https://api.github.com/users/chaijs/gists{/gist_id}","starred_url":"https://api.github.com/users/chaijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaijs/subscriptions","organizations_url":"https://api.github.com/users/chaijs/orgs","repos_url":"https://api.github.com/users/chaijs/repos","events_url":"https://api.github.com/users/chaijs/events{/privacy}","received_events_url":"https://api.github.com/users/chaijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chaijs/chai","description":"BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.","fork":false,"url":"https://api.github.com/repos/chaijs/chai","forks_url":"https://api.github.com/repos/chaijs/chai/forks","keys_url":"https://api.github.com/repos/chaijs/chai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaijs/chai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaijs/chai/teams","hooks_url":"https://api.github.com/repos/chaijs/chai/hooks","issue_events_url":"https://api.github.com/repos/chaijs/chai/issues/events{/number}","events_url":"https://api.github.com/repos/chaijs/chai/events","assignees_url":"https://api.github.com/repos/chaijs/chai/assignees{/user}","branches_url":"https://api.github.com/repos/chaijs/chai/branches{/branch}","tags_url":"https://api.github.com/repos/chaijs/chai/tags","blobs_url":"https://api.github.com/repos/chaijs/chai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaijs/chai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaijs/chai/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaijs/chai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaijs/chai/statuses/{sha}","languages_url":"https://api.github.com/repos/chaijs/chai/languages","stargazers_url":"https://api.github.com/repos/chaijs/chai/stargazers","contributors_url":"https://api.github.com/repos/chaijs/chai/contributors","subscribers_url":"https://api.github.com/repos/chaijs/chai/subscribers","subscription_url":"https://api.github.com/repos/chaijs/chai/subscription","commits_url":"https://api.github.com/repos/chaijs/chai/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaijs/chai/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaijs/chai/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaijs/chai/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaijs/chai/contents/{+path}","compare_url":"https://api.github.com/repos/chaijs/chai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaijs/chai/merges","archive_url":"https://api.github.com/repos/chaijs/chai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaijs/chai/downloads","issues_url":"https://api.github.com/repos/chaijs/chai/issues{/number}","pulls_url":"https://api.github.com/repos/chaijs/chai/pulls{/number}","milestones_url":"https://api.github.com/repos/chaijs/chai/milestones{/number}","notifications_url":"https://api.github.com/repos/chaijs/chai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaijs/chai/labels{/name}","releases_url":"https://api.github.com/repos/chaijs/chai/releases{/id}","deployments_url":"https://api.github.com/repos/chaijs/chai/deployments","created_at":"2011-12-07T08:06:35Z","updated_at":"2016-12-18T09:32:03Z","pushed_at":"2016-12-18T16:52:48Z","git_url":"git://github.com/chaijs/chai.git","ssh_url":"git@github.com:chaijs/chai.git","clone_url":"https://github.com/chaijs/chai.git","svn_url":"https://github.com/chaijs/chai","homepage":"http://chaijs.com","size":2836,"stargazers_count":3627,"watchers_count":3627,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"open_issues_count":35,"forks":333,"open_issues":35,"watchers":3627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chaijs/chai/pulls/884"},"html":{"href":"https://github.com/chaijs/chai/pull/884"},"issue":{"href":"https://api.github.com/repos/chaijs/chai/issues/884"},"comments":{"href":"https://api.github.com/repos/chaijs/chai/issues/884/comments"},"review_comments":{"href":"https://api.github.com/repos/chaijs/chai/pulls/884/comments"},"review_comment":{"href":"https://api.github.com/repos/chaijs/chai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chaijs/chai/pulls/884/commits"},"statuses":{"href":"https://api.github.com/repos/chaijs/chai/statuses/6d13b83f91331ee2e38b435d2ebb71c54032a42f"}}}}
{"actor":{"display_login":"meeber"}}