{"action":"opened","number":27,"pull_request":{"url":"https://api.github.com/repos/MarkDHamill/digests/pulls/27","id":91891666,"html_url":"https://github.com/MarkDHamill/digests/pull/27","diff_url":"https://github.com/MarkDHamill/digests/pull/27.diff","patch_url":"https://github.com/MarkDHamill/digests/pull/27.patch","issue_url":"https://api.github.com/repos/MarkDHamill/digests/issues/27","number":27,"state":"open","locked":false,"title":"Total migration redo","user":{"login":"VSEphpbb","id":303711,"avatar_url":"https://avatars.githubusercontent.com/u/303711?v=3","gravatar_id":"","url":"https://api.github.com/users/VSEphpbb","html_url":"https://github.com/VSEphpbb","followers_url":"https://api.github.com/users/VSEphpbb/followers","following_url":"https://api.github.com/users/VSEphpbb/following{/other_user}","gists_url":"https://api.github.com/users/VSEphpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/VSEphpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSEphpbb/subscriptions","organizations_url":"https://api.github.com/users/VSEphpbb/orgs","repos_url":"https://api.github.com/users/VSEphpbb/repos","events_url":"https://api.github.com/users/VSEphpbb/events{/privacy}","received_events_url":"https://api.github.com/users/VSEphpbb/received_events","type":"User","site_admin":false},"body":"This is more like how the migrations should have be written.\r\n\r\nOf course, I've had to rewrite existing migrations, which means if anybody ever installed this...they can't update..they will have to completely uninstall the extension, and reinstall it fresh again. Hopefully you never made this publicly available to anyone. Because I just don't see how one can come back from the original migrations that were here.\r\n\r\nThis is how your migrations should have been handled to update old MOD installations, and handle new installations as well.\r\n\r\nYou can use this, learn from this or whatever. But as I said, this is what you'd need to be doing if you want to submit this to CDB. At the same time, these changes assume nobody except the developers have ever installed this extension.\r\n\r\nThe main mistake in the very first migration was you can not implement DB changes via the effectively installed function. You must use the normal update data and schema methods only. This PR shows how all the changes could have been accomplished this way.","created_at":"2016-11-02T00:47:21Z","updated_at":"2016-11-02T00:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MarkDHamill/digests/pulls/27/commits","review_comments_url":"https://api.github.com/repos/MarkDHamill/digests/pulls/27/comments","review_comment_url":"https://api.github.com/repos/MarkDHamill/digests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkDHamill/digests/issues/27/comments","statuses_url":"https://api.github.com/repos/MarkDHamill/digests/statuses/d7a4675cad1dab539dfb948934192108c63c8333","head":{"label":"VSEphpbb:migration-redo","ref":"migration-redo","sha":"d7a4675cad1dab539dfb948934192108c63c8333","user":{"login":"VSEphpbb","id":303711,"avatar_url":"https://avatars.githubusercontent.com/u/303711?v=3","gravatar_id":"","url":"https://api.github.com/users/VSEphpbb","html_url":"https://github.com/VSEphpbb","followers_url":"https://api.github.com/users/VSEphpbb/followers","following_url":"https://api.github.com/users/VSEphpbb/following{/other_user}","gists_url":"https://api.github.com/users/VSEphpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/VSEphpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSEphpbb/subscriptions","organizations_url":"https://api.github.com/users/VSEphpbb/orgs","repos_url":"https://api.github.com/users/VSEphpbb/repos","events_url":"https://api.github.com/users/VSEphpbb/events{/privacy}","received_events_url":"https://api.github.com/users/VSEphpbb/received_events","type":"User","site_admin":false},"repo":{"id":72588981,"name":"digests","full_name":"VSEphpbb/digests","owner":{"login":"VSEphpbb","id":303711,"avatar_url":"https://avatars.githubusercontent.com/u/303711?v=3","gravatar_id":"","url":"https://api.github.com/users/VSEphpbb","html_url":"https://github.com/VSEphpbb","followers_url":"https://api.github.com/users/VSEphpbb/followers","following_url":"https://api.github.com/users/VSEphpbb/following{/other_user}","gists_url":"https://api.github.com/users/VSEphpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/VSEphpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSEphpbb/subscriptions","organizations_url":"https://api.github.com/users/VSEphpbb/orgs","repos_url":"https://api.github.com/users/VSEphpbb/repos","events_url":"https://api.github.com/users/VSEphpbb/events{/privacy}","received_events_url":"https://api.github.com/users/VSEphpbb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VSEphpbb/digests","description":"Digests extension for phpBB 3.1","fork":true,"url":"https://api.github.com/repos/VSEphpbb/digests","forks_url":"https://api.github.com/repos/VSEphpbb/digests/forks","keys_url":"https://api.github.com/repos/VSEphpbb/digests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VSEphpbb/digests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VSEphpbb/digests/teams","hooks_url":"https://api.github.com/repos/VSEphpbb/digests/hooks","issue_events_url":"https://api.github.com/repos/VSEphpbb/digests/issues/events{/number}","events_url":"https://api.github.com/repos/VSEphpbb/digests/events","assignees_url":"https://api.github.com/repos/VSEphpbb/digests/assignees{/user}","branches_url":"https://api.github.com/repos/VSEphpbb/digests/branches{/branch}","tags_url":"https://api.github.com/repos/VSEphpbb/digests/tags","blobs_url":"https://api.github.com/repos/VSEphpbb/digests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VSEphpbb/digests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VSEphpbb/digests/git/refs{/sha}","trees_url":"https://api.github.com/repos/VSEphpbb/digests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VSEphpbb/digests/statuses/{sha}","languages_url":"https://api.github.com/repos/VSEphpbb/digests/languages","stargazers_url":"https://api.github.com/repos/VSEphpbb/digests/stargazers","contributors_url":"https://api.github.com/repos/VSEphpbb/digests/contributors","subscribers_url":"https://api.github.com/repos/VSEphpbb/digests/subscribers","subscription_url":"https://api.github.com/repos/VSEphpbb/digests/subscription","commits_url":"https://api.github.com/repos/VSEphpbb/digests/commits{/sha}","git_commits_url":"https://api.github.com/repos/VSEphpbb/digests/git/commits{/sha}","comments_url":"https://api.github.com/repos/VSEphpbb/digests/comments{/number}","issue_comment_url":"https://api.github.com/repos/VSEphpbb/digests/issues/comments{/number}","contents_url":"https://api.github.com/repos/VSEphpbb/digests/contents/{+path}","compare_url":"https://api.github.com/repos/VSEphpbb/digests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VSEphpbb/digests/merges","archive_url":"https://api.github.com/repos/VSEphpbb/digests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VSEphpbb/digests/downloads","issues_url":"https://api.github.com/repos/VSEphpbb/digests/issues{/number}","pulls_url":"https://api.github.com/repos/VSEphpbb/digests/pulls{/number}","milestones_url":"https://api.github.com/repos/VSEphpbb/digests/milestones{/number}","notifications_url":"https://api.github.com/repos/VSEphpbb/digests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VSEphpbb/digests/labels{/name}","releases_url":"https://api.github.com/repos/VSEphpbb/digests/releases{/id}","deployments_url":"https://api.github.com/repos/VSEphpbb/digests/deployments","created_at":"2016-11-02T00:35:01Z","updated_at":"2016-11-02T00:35:03Z","pushed_at":"2016-11-02T00:37:39Z","git_url":"git://github.com/VSEphpbb/digests.git","ssh_url":"git@github.com:VSEphpbb/digests.git","clone_url":"https://github.com/VSEphpbb/digests.git","svn_url":"https://github.com/VSEphpbb/digests","homepage":"https://phpbbservices.com/digests_wp/","size":407,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkDHamill:master","ref":"master","sha":"98088cca9c5c21284746c38cad4c535ef8cf5b02","user":{"login":"MarkDHamill","id":7492922,"avatar_url":"https://avatars.githubusercontent.com/u/7492922?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkDHamill","html_url":"https://github.com/MarkDHamill","followers_url":"https://api.github.com/users/MarkDHamill/followers","following_url":"https://api.github.com/users/MarkDHamill/following{/other_user}","gists_url":"https://api.github.com/users/MarkDHamill/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkDHamill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkDHamill/subscriptions","organizations_url":"https://api.github.com/users/MarkDHamill/orgs","repos_url":"https://api.github.com/users/MarkDHamill/repos","events_url":"https://api.github.com/users/MarkDHamill/events{/privacy}","received_events_url":"https://api.github.com/users/MarkDHamill/received_events","type":"User","site_admin":false},"repo":{"id":47524858,"name":"digests","full_name":"MarkDHamill/digests","owner":{"login":"MarkDHamill","id":7492922,"avatar_url":"https://avatars.githubusercontent.com/u/7492922?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkDHamill","html_url":"https://github.com/MarkDHamill","followers_url":"https://api.github.com/users/MarkDHamill/followers","following_url":"https://api.github.com/users/MarkDHamill/following{/other_user}","gists_url":"https://api.github.com/users/MarkDHamill/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkDHamill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkDHamill/subscriptions","organizations_url":"https://api.github.com/users/MarkDHamill/orgs","repos_url":"https://api.github.com/users/MarkDHamill/repos","events_url":"https://api.github.com/users/MarkDHamill/events{/privacy}","received_events_url":"https://api.github.com/users/MarkDHamill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarkDHamill/digests","description":"Digests extension for phpBB 3.1","fork":false,"url":"https://api.github.com/repos/MarkDHamill/digests","forks_url":"https://api.github.com/repos/MarkDHamill/digests/forks","keys_url":"https://api.github.com/repos/MarkDHamill/digests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkDHamill/digests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkDHamill/digests/teams","hooks_url":"https://api.github.com/repos/MarkDHamill/digests/hooks","issue_events_url":"https://api.github.com/repos/MarkDHamill/digests/issues/events{/number}","events_url":"https://api.github.com/repos/MarkDHamill/digests/events","assignees_url":"https://api.github.com/repos/MarkDHamill/digests/assignees{/user}","branches_url":"https://api.github.com/repos/MarkDHamill/digests/branches{/branch}","tags_url":"https://api.github.com/repos/MarkDHamill/digests/tags","blobs_url":"https://api.github.com/repos/MarkDHamill/digests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkDHamill/digests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkDHamill/digests/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkDHamill/digests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkDHamill/digests/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkDHamill/digests/languages","stargazers_url":"https://api.github.com/repos/MarkDHamill/digests/stargazers","contributors_url":"https://api.github.com/repos/MarkDHamill/digests/contributors","subscribers_url":"https://api.github.com/repos/MarkDHamill/digests/subscribers","subscription_url":"https://api.github.com/repos/MarkDHamill/digests/subscription","commits_url":"https://api.github.com/repos/MarkDHamill/digests/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkDHamill/digests/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkDHamill/digests/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkDHamill/digests/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkDHamill/digests/contents/{+path}","compare_url":"https://api.github.com/repos/MarkDHamill/digests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkDHamill/digests/merges","archive_url":"https://api.github.com/repos/MarkDHamill/digests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkDHamill/digests/downloads","issues_url":"https://api.github.com/repos/MarkDHamill/digests/issues{/number}","pulls_url":"https://api.github.com/repos/MarkDHamill/digests/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkDHamill/digests/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkDHamill/digests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkDHamill/digests/labels{/name}","releases_url":"https://api.github.com/repos/MarkDHamill/digests/releases{/id}","deployments_url":"https://api.github.com/repos/MarkDHamill/digests/deployments","created_at":"2015-12-07T02:37:53Z","updated_at":"2016-10-22T19:45:25Z","pushed_at":"2016-10-14T15:22:55Z","git_url":"git://github.com/MarkDHamill/digests.git","ssh_url":"git@github.com:MarkDHamill/digests.git","clone_url":"https://github.com/MarkDHamill/digests.git","svn_url":"https://github.com/MarkDHamill/digests","homepage":"https://phpbbservices.com/digests_wp/","size":407,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkDHamill/digests/pulls/27"},"html":{"href":"https://github.com/MarkDHamill/digests/pull/27"},"issue":{"href":"https://api.github.com/repos/MarkDHamill/digests/issues/27"},"comments":{"href":"https://api.github.com/repos/MarkDHamill/digests/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkDHamill/digests/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkDHamill/digests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkDHamill/digests/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/MarkDHamill/digests/statuses/d7a4675cad1dab539dfb948934192108c63c8333"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":676,"deletions":717,"changed_files":11}}
{"actor":{"display_login":"VSEphpbb"}}