{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments/93555765","pull_request_review_id":14085883,"id":93555765,"diff_hunk":"@@ -0,0 +1,29 @@\n+[Unit]\n+Description=etcd rkt wrapper\n+Documentation=https://github.com/coreos/etcd\n+Wants=network.target\n+\n+[Service]\n+Restart=on-failure\n+RestartSec=10s\n+TimeoutStartSec=0\n+LimitNOFILE=40000\n+\n+ExecStart={{ rkt_bin_dir | default(\"/usr/bin\") }}/rkt run \\\n+--uuid-file-save=/var/run/etcd.uuid \\\n+--volume=etc-ssl-certs,kind=host,source=/etc/ssl/certs,readOnly=true \\\n+--mount=volume=etc-ssl-certs,target=/etc/ssl/certs \\\n+--volume=etcd-cert-dir,kind=host,source={{ etcd_cert_dir }},readOnly=true \\\n+--mount=volume=etcd-cert-dir,target={{ etcd_cert_dir }} \\\n+--volume=var-lib-etcd,kind=host,source=/var/lib/etcd,readOnly=false \\\n+--mount=volume=var-lib-etcd,target=/var/lib/etcd \\\n+--set-env-file=/etc/etcd.env \\\n+--stage1-from-dir=stage1-fly.aci \\\n+{{ etcd_image_repo }}:{{ etcd_image_tag }} \\\n+--name={{ etcd_member_name | default(\"etcd\") }}\n+\n+ExecStartPre=-/usr/bin/rkt rm --uuid-file=/var/run/etcd.uuid","path":"roles/etcd/templates/etcd-rkt.service.j2","position":25,"original_position":25,"commit_id":"12e5c258d6c519f5f18c9a08649fbb109e7331c4","original_commit_id":"12e5c258d6c519f5f18c9a08649fbb109e7331c4","user":{"login":"bradbeam","id":4570765,"avatar_url":"https://avatars.githubusercontent.com/u/4570765?v=3","gravatar_id":"","url":"https://api.github.com/users/bradbeam","html_url":"https://github.com/bradbeam","followers_url":"https://api.github.com/users/bradbeam/followers","following_url":"https://api.github.com/users/bradbeam/following{/other_user}","gists_url":"https://api.github.com/users/bradbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/bradbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradbeam/subscriptions","organizations_url":"https://api.github.com/users/bradbeam/orgs","repos_url":"https://api.github.com/users/bradbeam/repos","events_url":"https://api.github.com/users/bradbeam/events{/privacy}","received_events_url":"https://api.github.com/users/bradbeam/received_events","type":"User","site_admin":false},"body":"rkt doesn't seem to care too much about the container/pod name, I can have X amount of nginx containers named nginx running and rkt is happy with that[1], so that's why I opted to use the `--uuid-file-save` arg with rkt run. \r\n\r\n[1]\r\n```\r\nUUID\t\tAPP\t\t\tIMAGE NAME\t\t\t\t\tSTATE\t\tCREATED\t\tSTARTED\t\tNETWORKS\r\n\r\n3c809c62\tnginx\t\t\tregistry-1.docker.io/library/nginx:latest\trunning\t\t19 seconds ago\t12 seconds ago\t\r\n6e3228d4\tnginx\t\t\tregistry-1.docker.io/library/nginx:latest\trunning\t\t1 minute ago\t30 seconds ago\tdefault:ip4=172.16.28.7\r\naf81e2ec\tnginx\t\t\tregistry-1.docker.io/library/nginx:latest\trunning\t\t1 minute ago\t34 seconds ago\tdefault:ip4=172.16.28.6\r\nb555c8db\tnginx\t\t\tregistry-1.docker.io/library/nginx:latest\trunning\t\t1 minute ago\t1 minute ago\tdefault:ip4=172.16.28.5\r\n```","created_at":"2016-12-22T02:07:12Z","updated_at":"2016-12-22T02:07:12Z","html_url":"https://github.com/kubernetes-incubator/kargo/pull/784#discussion_r93555765","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/784","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments/93555765"},"html":{"href":"https://github.com/kubernetes-incubator/kargo/pull/784#discussion_r93555765"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/784"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/784","id":98663573,"html_url":"https://github.com/kubernetes-incubator/kargo/pull/784","diff_url":"https://github.com/kubernetes-incubator/kargo/pull/784.diff","patch_url":"https://github.com/kubernetes-incubator/kargo/pull/784.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/784","number":784,"state":"open","locked":false,"title":"WIP rkt support","user":{"login":"bradbeam","id":4570765,"avatar_url":"https://avatars.githubusercontent.com/u/4570765?v=3","gravatar_id":"","url":"https://api.github.com/users/bradbeam","html_url":"https://github.com/bradbeam","followers_url":"https://api.github.com/users/bradbeam/followers","following_url":"https://api.github.com/users/bradbeam/following{/other_user}","gists_url":"https://api.github.com/users/bradbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/bradbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradbeam/subscriptions","organizations_url":"https://api.github.com/users/bradbeam/orgs","repos_url":"https://api.github.com/users/bradbeam/repos","events_url":"https://api.github.com/users/bradbeam/events{/privacy}","received_events_url":"https://api.github.com/users/bradbeam/received_events","type":"User","site_admin":false},"body":"Taking a slightly different approach than the rktnetes WIP earlier.\r\n\r\nWe're wanting to run the control plane ( etcd + kubelet ) in rkt but still have kubernetes launch pods via docker. I've only been able to test against ubuntu 16.04 so far, but things look good. ","created_at":"2016-12-20T00:05:31Z","updated_at":"2016-12-22T02:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e9fb3f829870f79df9d540ced67ff46f0060636","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/784/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/784/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/784/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/12e5c258d6c519f5f18c9a08649fbb109e7331c4","head":{"label":"bradbeam:rkt","ref":"rkt","sha":"12e5c258d6c519f5f18c9a08649fbb109e7331c4","user":{"login":"bradbeam","id":4570765,"avatar_url":"https://avatars.githubusercontent.com/u/4570765?v=3","gravatar_id":"","url":"https://api.github.com/users/bradbeam","html_url":"https://github.com/bradbeam","followers_url":"https://api.github.com/users/bradbeam/followers","following_url":"https://api.github.com/users/bradbeam/following{/other_user}","gists_url":"https://api.github.com/users/bradbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/bradbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradbeam/subscriptions","organizations_url":"https://api.github.com/users/bradbeam/orgs","repos_url":"https://api.github.com/users/bradbeam/repos","events_url":"https://api.github.com/users/bradbeam/events{/privacy}","received_events_url":"https://api.github.com/users/bradbeam/received_events","type":"User","site_admin":false},"repo":{"id":76895296,"name":"kargo","full_name":"bradbeam/kargo","owner":{"login":"bradbeam","id":4570765,"avatar_url":"https://avatars.githubusercontent.com/u/4570765?v=3","gravatar_id":"","url":"https://api.github.com/users/bradbeam","html_url":"https://github.com/bradbeam","followers_url":"https://api.github.com/users/bradbeam/followers","following_url":"https://api.github.com/users/bradbeam/following{/other_user}","gists_url":"https://api.github.com/users/bradbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/bradbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradbeam/subscriptions","organizations_url":"https://api.github.com/users/bradbeam/orgs","repos_url":"https://api.github.com/users/bradbeam/repos","events_url":"https://api.github.com/users/bradbeam/events{/privacy}","received_events_url":"https://api.github.com/users/bradbeam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradbeam/kargo","description":"Setup a kubernetes cluster","fork":true,"url":"https://api.github.com/repos/bradbeam/kargo","forks_url":"https://api.github.com/repos/bradbeam/kargo/forks","keys_url":"https://api.github.com/repos/bradbeam/kargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradbeam/kargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradbeam/kargo/teams","hooks_url":"https://api.github.com/repos/bradbeam/kargo/hooks","issue_events_url":"https://api.github.com/repos/bradbeam/kargo/issues/events{/number}","events_url":"https://api.github.com/repos/bradbeam/kargo/events","assignees_url":"https://api.github.com/repos/bradbeam/kargo/assignees{/user}","branches_url":"https://api.github.com/repos/bradbeam/kargo/branches{/branch}","tags_url":"https://api.github.com/repos/bradbeam/kargo/tags","blobs_url":"https://api.github.com/repos/bradbeam/kargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradbeam/kargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradbeam/kargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradbeam/kargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradbeam/kargo/statuses/{sha}","languages_url":"https://api.github.com/repos/bradbeam/kargo/languages","stargazers_url":"https://api.github.com/repos/bradbeam/kargo/stargazers","contributors_url":"https://api.github.com/repos/bradbeam/kargo/contributors","subscribers_url":"https://api.github.com/repos/bradbeam/kargo/subscribers","subscription_url":"https://api.github.com/repos/bradbeam/kargo/subscription","commits_url":"https://api.github.com/repos/bradbeam/kargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradbeam/kargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradbeam/kargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradbeam/kargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradbeam/kargo/contents/{+path}","compare_url":"https://api.github.com/repos/bradbeam/kargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradbeam/kargo/merges","archive_url":"https://api.github.com/repos/bradbeam/kargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradbeam/kargo/downloads","issues_url":"https://api.github.com/repos/bradbeam/kargo/issues{/number}","pulls_url":"https://api.github.com/repos/bradbeam/kargo/pulls{/number}","milestones_url":"https://api.github.com/repos/bradbeam/kargo/milestones{/number}","notifications_url":"https://api.github.com/repos/bradbeam/kargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradbeam/kargo/labels{/name}","releases_url":"https://api.github.com/repos/bradbeam/kargo/releases{/id}","deployments_url":"https://api.github.com/repos/bradbeam/kargo/deployments","created_at":"2016-12-19T20:35:44Z","updated_at":"2016-12-19T20:35:45Z","pushed_at":"2016-12-20T00:00:37Z","git_url":"git://github.com/bradbeam/kargo.git","ssh_url":"git@github.com:bradbeam/kargo.git","clone_url":"https://github.com/bradbeam/kargo.git","svn_url":"https://github.com/bradbeam/kargo","homepage":"","size":4719,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"c1e4cef75b5fa78bbe4800c8e60ca8742758947f","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":43613404,"name":"kargo","full_name":"kubernetes-incubator/kargo","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kargo","description":"Setup a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kargo","forks_url":"https://api.github.com/repos/kubernetes-incubator/kargo/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kargo/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kargo/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kargo/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kargo/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kargo/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kargo/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kargo/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kargo/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kargo/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kargo/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kargo/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kargo/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kargo/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kargo/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kargo/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kargo/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kargo/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/deployments","created_at":"2015-10-03T20:18:11Z","updated_at":"2016-12-18T17:17:32Z","pushed_at":"2016-12-21T20:51:15Z","git_url":"git://github.com/kubernetes-incubator/kargo.git","ssh_url":"git@github.com:kubernetes-incubator/kargo.git","clone_url":"https://github.com/kubernetes-incubator/kargo.git","svn_url":"https://github.com/kubernetes-incubator/kargo","homepage":"","size":4737,"stargazers_count":446,"watchers_count":446,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":101,"forks":148,"open_issues":101,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/784"},"html":{"href":"https://github.com/kubernetes-incubator/kargo/pull/784"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/784"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/784/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/784/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/784/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/12e5c258d6c519f5f18c9a08649fbb109e7331c4"}}}}
{"actor":{"display_login":"bradbeam"}}