{"action":"created","issue":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/347","repository_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/347/labels{/name}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/347/comments","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/347/events","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/347","id":148572043,"number":347,"title":"T/179 Converters API","user":{"login":"scofalik","id":1502228,"avatar_url":"https://avatars.githubusercontent.com/u/1502228?v=3","gravatar_id":"","url":"https://api.github.com/users/scofalik","html_url":"https://github.com/scofalik","followers_url":"https://api.github.com/users/scofalik/followers","following_url":"https://api.github.com/users/scofalik/following{/other_user}","gists_url":"https://api.github.com/users/scofalik/gists{/gist_id}","starred_url":"https://api.github.com/users/scofalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scofalik/subscriptions","organizations_url":"https://api.github.com/users/scofalik/orgs","repos_url":"https://api.github.com/users/scofalik/repos","events_url":"https://api.github.com/users/scofalik/events{/privacy}","received_events_url":"https://api.github.com/users/scofalik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-15T06:56:10Z","updated_at":"2016-04-15T13:56:13Z","closed_at":"2016-04-15T13:56:13Z","pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/347","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/347","diff_url":"https://github.com/ckeditor/ckeditor5-engine/pull/347.diff","patch_url":"https://github.com/ckeditor/ckeditor5-engine/pull/347.patch"},"body":"This PR brings Converters API in `treeController` namespace. Fixes #179 #180 . There will be a number of follow-up issues but the core for converters is already ready to be used.\r\n\r\nFollow-ups:\r\n#296 (This is the main follow-up, this issue should be the next step of taking care of converters.)\r\n#266 (It appeared that it is important to have this feature. We can try to workaround it but it makes some converters complicated and some maybe even impossible.)\r\n#267 (As above.)\r\n\r\n(Refactor stuff. We sooner we will do it, the less we will have to re-write):\r\n#348\r\n#349\r\n#350\r\n#351\r\n#353\r\n#355\r\n#356"},"comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments/210472551","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/347#issuecomment-210472551","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/347","id":210472551,"user":{"login":"pjasiun","id":1166967,"avatar_url":"https://avatars.githubusercontent.com/u/1166967?v=3","gravatar_id":"","url":"https://api.github.com/users/pjasiun","html_url":"https://github.com/pjasiun","followers_url":"https://api.github.com/users/pjasiun/followers","following_url":"https://api.github.com/users/pjasiun/following{/other_user}","gists_url":"https://api.github.com/users/pjasiun/gists{/gist_id}","starred_url":"https://api.github.com/users/pjasiun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjasiun/subscriptions","organizations_url":"https://api.github.com/users/pjasiun/orgs","repos_url":"https://api.github.com/users/pjasiun/repos","events_url":"https://api.github.com/users/pjasiun/events{/privacy}","received_events_url":"https://api.github.com/users/pjasiun/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T13:56:13Z","updated_at":"2016-04-15T13:56:13Z","body":"I like the code, docs, tests and examples. We could now discuss docs, for instance if the `ModelConsumable` should have an example of a `modelConversionDispatcher` listener. But I think that part of this documentation need to be moved to the architecture docs anyway and we will be able to make docs better when we will have architecture docs. We could also spend some time improving advance tests, but their purpose was to prove it is possible what they did.\r\n\r\nI think it is time to close it. Good job!"}}