{"action":"created","comment":{"url":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments/83986874","pull_request_review_id":4793806,"id":83986874,"diff_hunk":"@@ -2636,8 +2606,7 @@ h2o.all <- function(x) {\n #' @seealso \\code{\\link[base]{all}} for the base R implementation.\n #' @export\n h2o.any <- function(x) {\n-  if( is.H2OFrame(x) ) all(x)\n-  else all(x)\n+  all(x)","path":"h2o-r/h2o-package/R/frame.R","position":317,"original_position":317,"commit_id":"b749e099efcf85e3237e1808301a7878143a8314","original_commit_id":"b749e099efcf85e3237e1808301a7878143a8314","user":{"login":"jangorecki","id":3627377,"avatar_url":"https://avatars.githubusercontent.com/u/3627377?v=3","gravatar_id":"","url":"https://api.github.com/users/jangorecki","html_url":"https://github.com/jangorecki","followers_url":"https://api.github.com/users/jangorecki/followers","following_url":"https://api.github.com/users/jangorecki/following{/other_user}","gists_url":"https://api.github.com/users/jangorecki/gists{/gist_id}","starred_url":"https://api.github.com/users/jangorecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jangorecki/subscriptions","organizations_url":"https://api.github.com/users/jangorecki/orgs","repos_url":"https://api.github.com/users/jangorecki/repos","events_url":"https://api.github.com/users/jangorecki/events{/privacy}","received_events_url":"https://api.github.com/users/jangorecki/received_events","type":"User","site_admin":false},"body":"Any idea why it was `all(x)` before your commit? looks like it should be `any`","created_at":"2016-10-19T02:11:53Z","updated_at":"2016-10-19T02:26:38Z","html_url":"https://github.com/h2oai/h2o-3/pull/370#discussion_r83986874","pull_request_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/370","_links":{"self":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments/83986874"},"html":{"href":"https://github.com/h2oai/h2o-3/pull/370#discussion_r83986874"},"pull_request":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/370"}}},"pull_request":{"url":"https://api.github.com/repos/h2oai/h2o-3/pulls/370","id":89925736,"html_url":"https://github.com/h2oai/h2o-3/pull/370","diff_url":"https://github.com/h2oai/h2o-3/pull/370.diff","patch_url":"https://github.com/h2oai/h2o-3/pull/370.patch","issue_url":"https://api.github.com/repos/h2oai/h2o-3/issues/370","number":370,"state":"open","locked":false,"title":"PUBDEV-3568: h2o.max returns NaN even when na.rf condition is set to TRUE","user":{"login":"navdeep-G","id":10055668,"avatar_url":"https://avatars.githubusercontent.com/u/10055668?v=3","gravatar_id":"","url":"https://api.github.com/users/navdeep-G","html_url":"https://github.com/navdeep-G","followers_url":"https://api.github.com/users/navdeep-G/followers","following_url":"https://api.github.com/users/navdeep-G/following{/other_user}","gists_url":"https://api.github.com/users/navdeep-G/gists{/gist_id}","starred_url":"https://api.github.com/users/navdeep-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navdeep-G/subscriptions","organizations_url":"https://api.github.com/users/navdeep-G/orgs","repos_url":"https://api.github.com/users/navdeep-G/repos","events_url":"https://api.github.com/users/navdeep-G/events{/privacy}","received_events_url":"https://api.github.com/users/navdeep-G/received_events","type":"User","site_admin":false},"body":"* Update h2o.* primitives to account for na.rm. \r\n* Also, remove if() clauses in h2o.* primitives as they are not needed since these methods are base primitives for h2o. These wrapper ,i.e. h2o.*, are merely here for completeness and consistency.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/h2oai/h2o-3/370)\n<!-- Reviewable:end -->\n","created_at":"2016-10-19T01:03:56Z","updated_at":"2016-10-19T02:26:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2646a0a8e1dd21e1be6a4bebc06df5f5d186392","assignee":{"login":"jangorecki","id":3627377,"avatar_url":"https://avatars.githubusercontent.com/u/3627377?v=3","gravatar_id":"","url":"https://api.github.com/users/jangorecki","html_url":"https://github.com/jangorecki","followers_url":"https://api.github.com/users/jangorecki/followers","following_url":"https://api.github.com/users/jangorecki/following{/other_user}","gists_url":"https://api.github.com/users/jangorecki/gists{/gist_id}","starred_url":"https://api.github.com/users/jangorecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jangorecki/subscriptions","organizations_url":"https://api.github.com/users/jangorecki/orgs","repos_url":"https://api.github.com/users/jangorecki/repos","events_url":"https://api.github.com/users/jangorecki/events{/privacy}","received_events_url":"https://api.github.com/users/jangorecki/received_events","type":"User","site_admin":false},"assignees":[{"login":"jangorecki","id":3627377,"avatar_url":"https://avatars.githubusercontent.com/u/3627377?v=3","gravatar_id":"","url":"https://api.github.com/users/jangorecki","html_url":"https://github.com/jangorecki","followers_url":"https://api.github.com/users/jangorecki/followers","following_url":"https://api.github.com/users/jangorecki/following{/other_user}","gists_url":"https://api.github.com/users/jangorecki/gists{/gist_id}","starred_url":"https://api.github.com/users/jangorecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jangorecki/subscriptions","organizations_url":"https://api.github.com/users/jangorecki/orgs","repos_url":"https://api.github.com/users/jangorecki/repos","events_url":"https://api.github.com/users/jangorecki/events{/privacy}","received_events_url":"https://api.github.com/users/jangorecki/received_events","type":"User","site_admin":false},{"login":"ledell","id":4073698,"avatar_url":"https://avatars.githubusercontent.com/u/4073698?v=3","gravatar_id":"","url":"https://api.github.com/users/ledell","html_url":"https://github.com/ledell","followers_url":"https://api.github.com/users/ledell/followers","following_url":"https://api.github.com/users/ledell/following{/other_user}","gists_url":"https://api.github.com/users/ledell/gists{/gist_id}","starred_url":"https://api.github.com/users/ledell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledell/subscriptions","organizations_url":"https://api.github.com/users/ledell/orgs","repos_url":"https://api.github.com/users/ledell/repos","events_url":"https://api.github.com/users/ledell/events{/privacy}","received_events_url":"https://api.github.com/users/ledell/received_events","type":"User","site_admin":false},{"login":"arnocandel","id":6147661,"avatar_url":"https://avatars.githubusercontent.com/u/6147661?v=3","gravatar_id":"","url":"https://api.github.com/users/arnocandel","html_url":"https://github.com/arnocandel","followers_url":"https://api.github.com/users/arnocandel/followers","following_url":"https://api.github.com/users/arnocandel/following{/other_user}","gists_url":"https://api.github.com/users/arnocandel/gists{/gist_id}","starred_url":"https://api.github.com/users/arnocandel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnocandel/subscriptions","organizations_url":"https://api.github.com/users/arnocandel/orgs","repos_url":"https://api.github.com/users/arnocandel/repos","events_url":"https://api.github.com/users/arnocandel/events{/privacy}","received_events_url":"https://api.github.com/users/arnocandel/received_events","type":"User","site_admin":false},{"login":"avniwadhwa","id":13669223,"avatar_url":"https://avatars.githubusercontent.com/u/13669223?v=3","gravatar_id":"","url":"https://api.github.com/users/avniwadhwa","html_url":"https://github.com/avniwadhwa","followers_url":"https://api.github.com/users/avniwadhwa/followers","following_url":"https://api.github.com/users/avniwadhwa/following{/other_user}","gists_url":"https://api.github.com/users/avniwadhwa/gists{/gist_id}","starred_url":"https://api.github.com/users/avniwadhwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avniwadhwa/subscriptions","organizations_url":"https://api.github.com/users/avniwadhwa/orgs","repos_url":"https://api.github.com/users/avniwadhwa/repos","events_url":"https://api.github.com/users/avniwadhwa/events{/privacy}","received_events_url":"https://api.github.com/users/avniwadhwa/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/370/commits","review_comments_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/370/comments","review_comment_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/issues/370/comments","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/b749e099efcf85e3237e1808301a7878143a8314","head":{"label":"h2oai:NG_pubdev3568","ref":"NG_pubdev3568","sha":"b749e099efcf85e3237e1808301a7878143a8314","user":{"login":"h2oai","id":1402695,"avatar_url":"https://avatars.githubusercontent.com/u/1402695?v=3","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":17371412,"name":"h2o-3","full_name":"h2oai/h2o-3","owner":{"login":"h2oai","id":1402695,"avatar_url":"https://avatars.githubusercontent.com/u/1402695?v=3","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/h2oai/h2o-3","description":"Open Source Fast Scalable Machine Learning API For Smarter Applications (Deep Learning, Gradient Boosting, Random Forest, Generalized Linear Modeling (Logistic Regression, Elastic Net), K-Means, PCA...)","fork":false,"url":"https://api.github.com/repos/h2oai/h2o-3","forks_url":"https://api.github.com/repos/h2oai/h2o-3/forks","keys_url":"https://api.github.com/repos/h2oai/h2o-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/h2o-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/h2o-3/teams","hooks_url":"https://api.github.com/repos/h2oai/h2o-3/hooks","issue_events_url":"https://api.github.com/repos/h2oai/h2o-3/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/h2o-3/events","assignees_url":"https://api.github.com/repos/h2oai/h2o-3/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/h2o-3/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/h2o-3/tags","blobs_url":"https://api.github.com/repos/h2oai/h2o-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/h2o-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/h2o-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/h2o-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/h2o-3/languages","stargazers_url":"https://api.github.com/repos/h2oai/h2o-3/stargazers","contributors_url":"https://api.github.com/repos/h2oai/h2o-3/contributors","subscribers_url":"https://api.github.com/repos/h2oai/h2o-3/subscribers","subscription_url":"https://api.github.com/repos/h2oai/h2o-3/subscription","commits_url":"https://api.github.com/repos/h2oai/h2o-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/h2o-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/h2o-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/h2o-3/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/h2o-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/h2o-3/merges","archive_url":"https://api.github.com/repos/h2oai/h2o-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/h2o-3/downloads","issues_url":"https://api.github.com/repos/h2oai/h2o-3/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/h2o-3/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/h2o-3/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/h2o-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/h2o-3/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/h2o-3/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/h2o-3/deployments","created_at":"2014-03-03T16:08:07Z","updated_at":"2016-10-18T15:25:20Z","pushed_at":"2016-10-19T01:49:40Z","git_url":"git://github.com/h2oai/h2o-3.git","ssh_url":"git@github.com:h2oai/h2o-3.git","clone_url":"https://github.com/h2oai/h2o-3.git","svn_url":"https://github.com/h2oai/h2o-3","homepage":"http://h2o.ai","size":348631,"stargazers_count":1433,"watchers_count":1433,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":629,"mirror_url":null,"open_issues_count":25,"forks":629,"open_issues":25,"watchers":1433,"default_branch":"master"}},"base":{"label":"h2oai:master","ref":"master","sha":"e439c9115658f785a8cd7c31b89c4bbce93abb32","user":{"login":"h2oai","id":1402695,"avatar_url":"https://avatars.githubusercontent.com/u/1402695?v=3","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":17371412,"name":"h2o-3","full_name":"h2oai/h2o-3","owner":{"login":"h2oai","id":1402695,"avatar_url":"https://avatars.githubusercontent.com/u/1402695?v=3","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/h2oai/h2o-3","description":"Open Source Fast Scalable Machine Learning API For Smarter Applications (Deep Learning, Gradient Boosting, Random Forest, Generalized Linear Modeling (Logistic Regression, Elastic Net), K-Means, PCA...)","fork":false,"url":"https://api.github.com/repos/h2oai/h2o-3","forks_url":"https://api.github.com/repos/h2oai/h2o-3/forks","keys_url":"https://api.github.com/repos/h2oai/h2o-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/h2o-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/h2o-3/teams","hooks_url":"https://api.github.com/repos/h2oai/h2o-3/hooks","issue_events_url":"https://api.github.com/repos/h2oai/h2o-3/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/h2o-3/events","assignees_url":"https://api.github.com/repos/h2oai/h2o-3/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/h2o-3/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/h2o-3/tags","blobs_url":"https://api.github.com/repos/h2oai/h2o-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/h2o-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/h2o-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/h2o-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/h2o-3/languages","stargazers_url":"https://api.github.com/repos/h2oai/h2o-3/stargazers","contributors_url":"https://api.github.com/repos/h2oai/h2o-3/contributors","subscribers_url":"https://api.github.com/repos/h2oai/h2o-3/subscribers","subscription_url":"https://api.github.com/repos/h2oai/h2o-3/subscription","commits_url":"https://api.github.com/repos/h2oai/h2o-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/h2o-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/h2o-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/h2o-3/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/h2o-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/h2o-3/merges","archive_url":"https://api.github.com/repos/h2oai/h2o-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/h2o-3/downloads","issues_url":"https://api.github.com/repos/h2oai/h2o-3/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/h2o-3/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/h2o-3/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/h2o-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/h2o-3/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/h2o-3/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/h2o-3/deployments","created_at":"2014-03-03T16:08:07Z","updated_at":"2016-10-18T15:25:20Z","pushed_at":"2016-10-19T01:49:40Z","git_url":"git://github.com/h2oai/h2o-3.git","ssh_url":"git@github.com:h2oai/h2o-3.git","clone_url":"https://github.com/h2oai/h2o-3.git","svn_url":"https://github.com/h2oai/h2o-3","homepage":"http://h2o.ai","size":348631,"stargazers_count":1433,"watchers_count":1433,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":629,"mirror_url":null,"open_issues_count":25,"forks":629,"open_issues":25,"watchers":1433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/370"},"html":{"href":"https://github.com/h2oai/h2o-3/pull/370"},"issue":{"href":"https://api.github.com/repos/h2oai/h2o-3/issues/370"},"comments":{"href":"https://api.github.com/repos/h2oai/h2o-3/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/h2oai/h2o-3/statuses/b749e099efcf85e3237e1808301a7878143a8314"}}}}
{"actor":{"display_login":"jangorecki"}}