{"action":"created","issue":{"url":"https://api.github.com/repos/nvie/rq/issues/641","repository_url":"https://api.github.com/repos/nvie/rq","labels_url":"https://api.github.com/repos/nvie/rq/issues/641/labels{/name}","comments_url":"https://api.github.com/repos/nvie/rq/issues/641/comments","events_url":"https://api.github.com/repos/nvie/rq/issues/641/events","html_url":"https://github.com/nvie/rq/pull/641","id":125766016,"number":641,"title":"Fix connection stack in stock worker","user":{"login":"kampfschlaefer","id":3831860,"avatar_url":"https://avatars.githubusercontent.com/u/3831860?v=3","gravatar_id":"","url":"https://api.github.com/users/kampfschlaefer","html_url":"https://github.com/kampfschlaefer","followers_url":"https://api.github.com/users/kampfschlaefer/followers","following_url":"https://api.github.com/users/kampfschlaefer/following{/other_user}","gists_url":"https://api.github.com/users/kampfschlaefer/gists{/gist_id}","starred_url":"https://api.github.com/users/kampfschlaefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kampfschlaefer/subscriptions","organizations_url":"https://api.github.com/users/kampfschlaefer/orgs","repos_url":"https://api.github.com/users/kampfschlaefer/repos","events_url":"https://api.github.com/users/kampfschlaefer/events{/privacy}","received_events_url":"https://api.github.com/users/kampfschlaefer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-01-09T15:53:15Z","updated_at":"2016-06-15T23:26:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nvie/rq/pulls/641","html_url":"https://github.com/nvie/rq/pull/641","diff_url":"https://github.com/nvie/rq/pull/641.diff","patch_url":"https://github.com/nvie/rq/pull/641.patch"},"body":"When running the stock worker itself, the `_connection_stack` is empty. Sadly this only shows when the `rqworker` runs in its own python process. The existing tests in test_worker.py and test_cli.py don't do that.\r\n\r\nThis branch adds tests that run the stock worker in its own subprocess, thus showing the problem. And it extends the cli to push (and pop) the redis connection when running the worker.\r\n\r\nAlso I changed the existing `access_self` function to also assert on `get_current_connection`. And this extends the existing worker test to check the failed queue to see that no job failed.\r\n\r\nThis fixes #479."},"comment":{"url":"https://api.github.com/repos/nvie/rq/issues/comments/226348941","html_url":"https://github.com/nvie/rq/pull/641#issuecomment-226348941","issue_url":"https://api.github.com/repos/nvie/rq/issues/641","id":226348941,"user":{"login":"selwin","id":188658,"avatar_url":"https://avatars.githubusercontent.com/u/188658?v=3","gravatar_id":"","url":"https://api.github.com/users/selwin","html_url":"https://github.com/selwin","followers_url":"https://api.github.com/users/selwin/followers","following_url":"https://api.github.com/users/selwin/following{/other_user}","gists_url":"https://api.github.com/users/selwin/gists{/gist_id}","starred_url":"https://api.github.com/users/selwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selwin/subscriptions","organizations_url":"https://api.github.com/users/selwin/orgs","repos_url":"https://api.github.com/users/selwin/repos","events_url":"https://api.github.com/users/selwin/events{/privacy}","received_events_url":"https://api.github.com/users/selwin/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T23:26:14Z","updated_at":"2016-06-15T23:26:14Z","body":"Merged, thanks!"}}
{"actor":{"display_login":"selwin"}}