{"action":"created","comment":{"url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/comments/63851444","id":63851444,"diff_hunk":"@@ -61,32 +61,44 @@ class Status {\n     }\n \n     /**\n-     * Set any status and inform the popup and the icon that they should be updated\n+     * Gets the correct status icon based on StatusCode and size.\n+     * Chrome resizes all icons except for the one in the toolbar.\n+     * That is why we added an extra case.\n+     * @param status        the StatusCode to get the icon for.\n+     * @param size          the size of the icon file (if it does not exist, it returns the largest icon).\n+     * @returns {string}    the relative icon path from the root of the extension.\n+     */\n+    public getIcon(status = StatusCode.OFF, size = 0) {\n+        let sizeString = \"\";\n+        if (size === 19) {\n+            sizeString = `${size}`;\n+        }\n+        return `img/icon/${Status.NAME[status]}${sizeString}.png`;\n+    }\n+\n+    /**\n+     * Set any status and inform the popup and the icon that they should be updated.\n+     * Or it sets the OFF flag if the logging is not enabled.\n      * @param status\n      */\n     public set(status: StatusCode) {\n+        // if (Settings.getLogging()) {\n+            this.setter(status);\n+        // } else {\n+        //     this.setter(StatusCode.OFF);\n+        // }","path":"src/octopeer-github/main/Status.ts","position":30,"original_position":30,"commit_id":"d86b1ab841bb2e95244459689c0cda273c5cb006","original_commit_id":"d86b1ab841bb2e95244459689c0cda273c5cb006","user":{"login":"mpsijm","id":9739541,"avatar_url":"https://avatars.githubusercontent.com/u/9739541?v=3","gravatar_id":"","url":"https://api.github.com/users/mpsijm","html_url":"https://github.com/mpsijm","followers_url":"https://api.github.com/users/mpsijm/followers","following_url":"https://api.github.com/users/mpsijm/following{/other_user}","gists_url":"https://api.github.com/users/mpsijm/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsijm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsijm/subscriptions","organizations_url":"https://api.github.com/users/mpsijm/orgs","repos_url":"https://api.github.com/users/mpsijm/repos","events_url":"https://api.github.com/users/mpsijm/events{/privacy}","received_events_url":"https://api.github.com/users/mpsijm/received_events","type":"User","site_admin":false},"body":"Maybe add a todo here, like \"will be fixed in #44\".","created_at":"2016-05-19T09:57:53Z","updated_at":"2016-05-19T09:57:53Z","html_url":"https://github.com/thervh70/ContextProject_RDD/pull/59#discussion_r63851444","pull_request_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/comments/63851444"},"html":{"href":"https://github.com/thervh70/ContextProject_RDD/pull/59#discussion_r63851444"},"pull_request":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/59","id":70665465,"html_url":"https://github.com/thervh70/ContextProject_RDD/pull/59","diff_url":"https://github.com/thervh70/ContextProject_RDD/pull/59.diff","patch_url":"https://github.com/thervh70/ContextProject_RDD/pull/59.patch","issue_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/59","number":59,"state":"open","locked":false,"title":"46 finalize status","user":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"body":"Will close #46 \r\n\r\nThe basic functionality for the change of icons is there (standby and running in PR) but due to a bug in the Settings (Options) the rest will be done in #44.\r\n\r\nFor now enjoy a fresh set of icons and a proof of concept for icon change!","created_at":"2016-05-19T09:52:36Z","updated_at":"2016-05-19T09:57:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9f43a017df138afabc3095aafa319b40499c9c3","assignee":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/59/commits","review_comments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/59/comments","review_comment_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/59/comments","statuses_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/statuses/d86b1ab841bb2e95244459689c0cda273c5cb006","head":{"label":"thervh70:46-finalize-status","ref":"46-finalize-status","sha":"d86b1ab841bb2e95244459689c0cda273c5cb006","user":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"repo":{"id":56582349,"name":"ContextProject_RDD","full_name":"thervh70/ContextProject_RDD","owner":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thervh70/ContextProject_RDD","description":"","fork":false,"url":"https://api.github.com/repos/thervh70/ContextProject_RDD","forks_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/forks","keys_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/teams","hooks_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/hooks","issue_events_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/events{/number}","events_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/events","assignees_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/assignees{/user}","branches_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/branches{/branch}","tags_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/tags","blobs_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/refs{/sha}","trees_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/statuses/{sha}","languages_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/languages","stargazers_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/stargazers","contributors_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/contributors","subscribers_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/subscribers","subscription_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/subscription","commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/commits{/sha}","git_commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/commits{/sha}","comments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/comments{/number}","issue_comment_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/comments{/number}","contents_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/contents/{+path}","compare_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/merges","archive_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/downloads","issues_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues{/number}","pulls_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls{/number}","milestones_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/milestones{/number}","notifications_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/labels{/name}","releases_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/releases{/id}","deployments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/deployments","created_at":"2016-04-19T09:12:06Z","updated_at":"2016-05-06T15:45:23Z","pushed_at":"2016-05-19T09:54:17Z","git_url":"git://github.com/thervh70/ContextProject_RDD.git","ssh_url":"git@github.com:thervh70/ContextProject_RDD.git","clone_url":"https://github.com/thervh70/ContextProject_RDD.git","svn_url":"https://github.com/thervh70/ContextProject_RDD","homepage":null,"size":3097,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"base":{"label":"thervh70:dev","ref":"dev","sha":"1a6522239e93ac26f8f237bb91af2dc604aeb884","user":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"repo":{"id":56582349,"name":"ContextProject_RDD","full_name":"thervh70/ContextProject_RDD","owner":{"login":"thervh70","id":9721657,"avatar_url":"https://avatars.githubusercontent.com/u/9721657?v=3","gravatar_id":"","url":"https://api.github.com/users/thervh70","html_url":"https://github.com/thervh70","followers_url":"https://api.github.com/users/thervh70/followers","following_url":"https://api.github.com/users/thervh70/following{/other_user}","gists_url":"https://api.github.com/users/thervh70/gists{/gist_id}","starred_url":"https://api.github.com/users/thervh70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thervh70/subscriptions","organizations_url":"https://api.github.com/users/thervh70/orgs","repos_url":"https://api.github.com/users/thervh70/repos","events_url":"https://api.github.com/users/thervh70/events{/privacy}","received_events_url":"https://api.github.com/users/thervh70/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thervh70/ContextProject_RDD","description":"","fork":false,"url":"https://api.github.com/repos/thervh70/ContextProject_RDD","forks_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/forks","keys_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/teams","hooks_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/hooks","issue_events_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/events{/number}","events_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/events","assignees_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/assignees{/user}","branches_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/branches{/branch}","tags_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/tags","blobs_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/refs{/sha}","trees_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/statuses/{sha}","languages_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/languages","stargazers_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/stargazers","contributors_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/contributors","subscribers_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/subscribers","subscription_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/subscription","commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/commits{/sha}","git_commits_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/git/commits{/sha}","comments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/comments{/number}","issue_comment_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/comments{/number}","contents_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/contents/{+path}","compare_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/merges","archive_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/downloads","issues_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues{/number}","pulls_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls{/number}","milestones_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/milestones{/number}","notifications_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/labels{/name}","releases_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/releases{/id}","deployments_url":"https://api.github.com/repos/thervh70/ContextProject_RDD/deployments","created_at":"2016-04-19T09:12:06Z","updated_at":"2016-05-06T15:45:23Z","pushed_at":"2016-05-19T09:54:17Z","git_url":"git://github.com/thervh70/ContextProject_RDD.git","ssh_url":"git@github.com:thervh70/ContextProject_RDD.git","clone_url":"https://github.com/thervh70/ContextProject_RDD.git","svn_url":"https://github.com/thervh70/ContextProject_RDD","homepage":null,"size":3097,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/59"},"html":{"href":"https://github.com/thervh70/ContextProject_RDD/pull/59"},"issue":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/59"},"comments":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/thervh70/ContextProject_RDD/statuses/d86b1ab841bb2e95244459689c0cda273c5cb006"}}}}