{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5573","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5573/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5573/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5573/events","html_url":"https://github.com/cockroachdb/cockroach/pull/5573","id":143504470,"number":5573,"title":"storage: Make add{Write,ReadOnly}Cmd return nil BatchRsponse on error","user":{"login":"kkaneda","id":8353550,"avatar_url":"https://avatars.githubusercontent.com/u/8353550?v=3","gravatar_id":"","url":"https://api.github.com/users/kkaneda","html_url":"https://github.com/kkaneda","followers_url":"https://api.github.com/users/kkaneda/followers","following_url":"https://api.github.com/users/kkaneda/following{/other_user}","gists_url":"https://api.github.com/users/kkaneda/gists{/gist_id}","starred_url":"https://api.github.com/users/kkaneda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkaneda/subscriptions","organizations_url":"https://api.github.com/users/kkaneda/orgs","repos_url":"https://api.github.com/users/kkaneda/repos","events_url":"https://api.github.com/users/kkaneda/events{/privacy}","received_events_url":"https://api.github.com/users/kkaneda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-25T13:58:15Z","updated_at":"2016-03-25T14:00:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5573","html_url":"https://github.com/cockroachdb/cockroach/pull/5573","diff_url":"https://github.com/cockroachdb/cockroach/pull/5573.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/5573.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/5573)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/201293316","html_url":"https://github.com/cockroachdb/cockroach/pull/5573#issuecomment-201293316","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5573","id":201293316,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T14:00:58Z","updated_at":"2016-03-25T14:00:58Z","body":"\n\n\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[storage/replica.go, line 763 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/5573#-KDi3n5QNBFoBtSCkFvt:-KDi3n5QNBFoBtSCkFvu:1118749512) ([raw file](https://github.com/cockroachdb/cockroach/blob/460e853a2fa9d10ea347ab9ce68d14e032c009c5/storage/replica.go#L763)):*\nthis LG\n\nI'd remove the `return nil, pErr` below and change `return br, nil` to `return br, pErr`\n\n---\n\n*[storage/replica.go, line 1032 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/5573#-KDi3gGzbvo8mHVFDcjJ:-KDi3gGzbvo8mHVFDcjK:-1710585508) ([raw file](https://github.com/cockroachdb/cockroach/blob/460e853a2fa9d10ea347ab9ce68d14e032c009c5/storage/replica.go#L1032)):*\n-1 on this, frankly. non-nil errors in go mean \"don't use the other returns\"\n\n---\n\n*[storage/replica.go, line 1122 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/5573#-KDi3ly625ss0zc55g1K:-KDi3ly625ss0zc55g1L:-469765787) ([raw file](https://github.com/cockroachdb/cockroach/blob/460e853a2fa9d10ea347ab9ce68d14e032c009c5/storage/replica.go#L1122)):*\nditto\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/5573)*\n<!-- Sent from Reviewable.io -->\n"}}