{"push_id":1155977519,"size":3,"distinct_size":1,"ref":"refs/heads/github-404-not-cache-authed","head":"3c017e127c52280ce97c791c9e0afaf7b2537018","before":"460d9374e35e1c20aee863c7acdd9721a264364e","commits":[{"sha":"4c82ebdbed92299f8b01be260024c71ab3d8060e","author":{"name":"Alex Saveliev","email":"d0d0dfdd0d02d881983c80ad75341ad1de4a6e9f@codeminders.com"},"message":"Corrected refname => revision resolution\n\nFixes https://app.asana.com/0/87040567695724/140099827375686\nThe reason was the following: there may be multiple refnames ending with the same suffix, for example\n```\n$ git show-ref --heads | grep 1.0.2\n...\nf6c1ff038cd9ff067e344a1194cfb4c8ad194090 refs/heads/1.0.2\n901b3948ffc5f4ea7ad0c5e7d68ecdeb86d4461d refs/heads/rr/146/1.0.2\n...\n```\n\nthen\n\n```\n$ git rev-parse 1.0.2\nwarning: refname '1.0.2' is ambiguous.\ne5fd456075b3318eb7092ff0169a30d1298086d6\n$ git rev-parse refs/heads/1.0.2\nf6c1ff038cd9ff067e344a1194cfb4c8ad194090\n\n```\n\nWhen we are looking for changes, there may be false positive change detected because the results of `git show-ref` and `git rev-parse` may differ.\nI propose to fix it by adding \"refs/heads/\" prefix because refnames there are relative to \"refs/heads/\" anyway","distinct":false,"url":"https://api.github.com/repos/sourcegraph/sourcegraph/commits/4c82ebdbed92299f8b01be260024c71ab3d8060e"},{"sha":"4b33489ff3b449d836b50f7287e27ac3e9b30341","author":{"name":"Keegan Carruthers-Smith","email":"6044037252971a9263f75ca8471daf4a14a9a165@gmail.com"},"message":"Merge pull request #89 from sourcegraph/multiple-builds-fix\n\nCorrected refname => revision resolution","distinct":false,"url":"https://api.github.com/repos/sourcegraph/sourcegraph/commits/4b33489ff3b449d836b50f7287e27ac3e9b30341"},{"sha":"3c017e127c52280ce97c791c9e0afaf7b2537018","author":{"name":"Dmitri Shuralyov","email":"fac853ad62d48665611670fa73144037528a02a0@gmail.com"},"message":"services/ext/github: Test that 404 responses get cached even if user is authed.\n\nThis optimization was introduced in 7f3478a8342c2d2064f631cb0e7171be15d49715.\nCaching 404 responses from authed clients is safe to do, since we're\nonly caching not found responses and not found repositories. This does\nnot reveal sensitive information.\n\nAdd test to enforce it so it doesn't regress.\n\nTry to clear up some existing tests, explain a potentially puzzling\npart of a test.","distinct":true,"url":"https://api.github.com/repos/sourcegraph/sourcegraph/commits/3c017e127c52280ce97c791c9e0afaf7b2537018"}]}
{"actor":{"display_login":"keegancsmith"}}