{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-streams/pulls/comments/88146139","pull_request_review_id":8728881,"id":88146139,"diff_hunk":"@@ -15,69 +15,80 @@\n  * specific language governing permissions and limitations\n  * under the License.\n  */\n+\n package org.apache.streams.facebook.provider.page;\n \n-import com.fasterxml.jackson.databind.ObjectMapper;\n-import com.google.common.annotations.VisibleForTesting;\n-import facebook4j.*;\n-import facebook4j.json.DataObjectFactory;\n import org.apache.streams.core.StreamsDatum;\n import org.apache.streams.facebook.FacebookConfiguration;\n+import org.apache.streams.facebook.FacebookPageProviderConfiguration;\n import org.apache.streams.facebook.IdConfig;\n import org.apache.streams.facebook.provider.FacebookDataCollector;\n import org.apache.streams.jackson.StreamsJacksonMapper;\n+\n+import com.fasterxml.jackson.databind.ObjectMapper;\n+import com.google.common.annotations.VisibleForTesting;\n+import com.google.common.base.Joiner;","path":"streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java","position":20,"original_position":20,"commit_id":"1799fbfc7f64db653a97075e6ba8990e7c97eaa2","original_commit_id":"1799fbfc7f64db653a97075e6ba8990e7c97eaa2","user":{"login":"smarthi","id":3137442,"avatar_url":"https://avatars.githubusercontent.com/u/3137442?v=3","gravatar_id":"","url":"https://api.github.com/users/smarthi","html_url":"https://github.com/smarthi","followers_url":"https://api.github.com/users/smarthi/followers","following_url":"https://api.github.com/users/smarthi/following{/other_user}","gists_url":"https://api.github.com/users/smarthi/gists{/gist_id}","starred_url":"https://api.github.com/users/smarthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarthi/subscriptions","organizations_url":"https://api.github.com/users/smarthi/orgs","repos_url":"https://api.github.com/users/smarthi/repos","events_url":"https://api.github.com/users/smarthi/events{/privacy}","received_events_url":"https://api.github.com/users/smarthi/received_events","type":"User","site_admin":false},"body":"I would use similar method from StringUtils, to minimize Guava usage","created_at":"2016-11-16T00:32:51Z","updated_at":"2016-11-16T00:32:51Z","html_url":"https://github.com/apache/incubator-streams/pull/326#discussion_r88146139","pull_request_url":"https://api.github.com/repos/apache/incubator-streams/pulls/326","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-streams/pulls/comments/88146139"},"html":{"href":"https://github.com/apache/incubator-streams/pull/326#discussion_r88146139"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-streams/pulls/326"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-streams/pulls/326","id":93661382,"html_url":"https://github.com/apache/incubator-streams/pull/326","diff_url":"https://github.com/apache/incubator-streams/pull/326.diff","patch_url":"https://github.com/apache/incubator-streams/pull/326.patch","issue_url":"https://api.github.com/repos/apache/incubator-streams/issues/326","number":326,"state":"open","locked":false,"title":"STREAMS-456: Facebook page provider does not include many fields","user":{"login":"steveblackmon","id":702924,"avatar_url":"https://avatars.githubusercontent.com/u/702924?v=3","gravatar_id":"","url":"https://api.github.com/users/steveblackmon","html_url":"https://github.com/steveblackmon","followers_url":"https://api.github.com/users/steveblackmon/followers","following_url":"https://api.github.com/users/steveblackmon/following{/other_user}","gists_url":"https://api.github.com/users/steveblackmon/gists{/gist_id}","starred_url":"https://api.github.com/users/steveblackmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveblackmon/subscriptions","organizations_url":"https://api.github.com/users/steveblackmon/orgs","repos_url":"https://api.github.com/users/steveblackmon/repos","events_url":"https://api.github.com/users/steveblackmon/events{/privacy}","received_events_url":"https://api.github.com/users/steveblackmon/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-14T22:26:58Z","updated_at":"2016-11-16T00:32:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f87508f70d335abf4fffc8bfde8a7cb798317f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-streams/pulls/326/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-streams/pulls/326/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-streams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-streams/issues/326/comments","statuses_url":"https://api.github.com/repos/apache/incubator-streams/statuses/1799fbfc7f64db653a97075e6ba8990e7c97eaa2","head":{"label":"steveblackmon:STREAMS-456","ref":"STREAMS-456","sha":"1799fbfc7f64db653a97075e6ba8990e7c97eaa2","user":{"login":"steveblackmon","id":702924,"avatar_url":"https://avatars.githubusercontent.com/u/702924?v=3","gravatar_id":"","url":"https://api.github.com/users/steveblackmon","html_url":"https://github.com/steveblackmon","followers_url":"https://api.github.com/users/steveblackmon/followers","following_url":"https://api.github.com/users/steveblackmon/following{/other_user}","gists_url":"https://api.github.com/users/steveblackmon/gists{/gist_id}","starred_url":"https://api.github.com/users/steveblackmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveblackmon/subscriptions","organizations_url":"https://api.github.com/users/steveblackmon/orgs","repos_url":"https://api.github.com/users/steveblackmon/repos","events_url":"https://api.github.com/users/steveblackmon/events{/privacy}","received_events_url":"https://api.github.com/users/steveblackmon/received_events","type":"User","site_admin":false},"repo":{"id":21526212,"name":"incubator-streams","full_name":"steveblackmon/incubator-streams","owner":{"login":"steveblackmon","id":702924,"avatar_url":"https://avatars.githubusercontent.com/u/702924?v=3","gravatar_id":"","url":"https://api.github.com/users/steveblackmon","html_url":"https://github.com/steveblackmon","followers_url":"https://api.github.com/users/steveblackmon/followers","following_url":"https://api.github.com/users/steveblackmon/following{/other_user}","gists_url":"https://api.github.com/users/steveblackmon/gists{/gist_id}","starred_url":"https://api.github.com/users/steveblackmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveblackmon/subscriptions","organizations_url":"https://api.github.com/users/steveblackmon/orgs","repos_url":"https://api.github.com/users/steveblackmon/repos","events_url":"https://api.github.com/users/steveblackmon/events{/privacy}","received_events_url":"https://api.github.com/users/steveblackmon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveblackmon/incubator-streams","description":"Mirror of Apache Streams","fork":true,"url":"https://api.github.com/repos/steveblackmon/incubator-streams","forks_url":"https://api.github.com/repos/steveblackmon/incubator-streams/forks","keys_url":"https://api.github.com/repos/steveblackmon/incubator-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveblackmon/incubator-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveblackmon/incubator-streams/teams","hooks_url":"https://api.github.com/repos/steveblackmon/incubator-streams/hooks","issue_events_url":"https://api.github.com/repos/steveblackmon/incubator-streams/issues/events{/number}","events_url":"https://api.github.com/repos/steveblackmon/incubator-streams/events","assignees_url":"https://api.github.com/repos/steveblackmon/incubator-streams/assignees{/user}","branches_url":"https://api.github.com/repos/steveblackmon/incubator-streams/branches{/branch}","tags_url":"https://api.github.com/repos/steveblackmon/incubator-streams/tags","blobs_url":"https://api.github.com/repos/steveblackmon/incubator-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveblackmon/incubator-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveblackmon/incubator-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveblackmon/incubator-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveblackmon/incubator-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/steveblackmon/incubator-streams/languages","stargazers_url":"https://api.github.com/repos/steveblackmon/incubator-streams/stargazers","contributors_url":"https://api.github.com/repos/steveblackmon/incubator-streams/contributors","subscribers_url":"https://api.github.com/repos/steveblackmon/incubator-streams/subscribers","subscription_url":"https://api.github.com/repos/steveblackmon/incubator-streams/subscription","commits_url":"https://api.github.com/repos/steveblackmon/incubator-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveblackmon/incubator-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveblackmon/incubator-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveblackmon/incubator-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveblackmon/incubator-streams/contents/{+path}","compare_url":"https://api.github.com/repos/steveblackmon/incubator-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveblackmon/incubator-streams/merges","archive_url":"https://api.github.com/repos/steveblackmon/incubator-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveblackmon/incubator-streams/downloads","issues_url":"https://api.github.com/repos/steveblackmon/incubator-streams/issues{/number}","pulls_url":"https://api.github.com/repos/steveblackmon/incubator-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/steveblackmon/incubator-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/steveblackmon/incubator-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveblackmon/incubator-streams/labels{/name}","releases_url":"https://api.github.com/repos/steveblackmon/incubator-streams/releases{/id}","deployments_url":"https://api.github.com/repos/steveblackmon/incubator-streams/deployments","created_at":"2014-07-05T18:58:19Z","updated_at":"2015-05-02T18:08:42Z","pushed_at":"2016-11-14T22:26:34Z","git_url":"git://github.com/steveblackmon/incubator-streams.git","ssh_url":"git@github.com:steveblackmon/incubator-streams.git","clone_url":"https://github.com/steveblackmon/incubator-streams.git","svn_url":"https://github.com/steveblackmon/incubator-streams","homepage":null,"size":70628,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7d9b887edab943de07ad35a04a0dbbc69e00d69b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17856644,"name":"incubator-streams","full_name":"apache/incubator-streams","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-streams","description":"Mirror of Apache Streams","fork":false,"url":"https://api.github.com/repos/apache/incubator-streams","forks_url":"https://api.github.com/repos/apache/incubator-streams/forks","keys_url":"https://api.github.com/repos/apache/incubator-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-streams/teams","hooks_url":"https://api.github.com/repos/apache/incubator-streams/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-streams/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-streams/events","assignees_url":"https://api.github.com/repos/apache/incubator-streams/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-streams/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-streams/tags","blobs_url":"https://api.github.com/repos/apache/incubator-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-streams/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-streams/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-streams/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-streams/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-streams/subscription","commits_url":"https://api.github.com/repos/apache/incubator-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-streams/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-streams/merges","archive_url":"https://api.github.com/repos/apache/incubator-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-streams/downloads","issues_url":"https://api.github.com/repos/apache/incubator-streams/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-streams/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-streams/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-streams/deployments","created_at":"2014-03-18T07:00:06Z","updated_at":"2016-11-01T11:14:18Z","pushed_at":"2016-11-14T22:26:58Z","git_url":"git://github.com/apache/incubator-streams.git","ssh_url":"git@github.com:apache/incubator-streams.git","clone_url":"https://github.com/apache/incubator-streams.git","svn_url":"https://github.com/apache/incubator-streams","homepage":null,"size":76156,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":"git://git.apache.org/incubator-streams.git","open_issues_count":2,"forks":20,"open_issues":2,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-streams/pulls/326"},"html":{"href":"https://github.com/apache/incubator-streams/pull/326"},"issue":{"href":"https://api.github.com/repos/apache/incubator-streams/issues/326"},"comments":{"href":"https://api.github.com/repos/apache/incubator-streams/issues/326/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-streams/pulls/326/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-streams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-streams/pulls/326/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-streams/statuses/1799fbfc7f64db653a97075e6ba8990e7c97eaa2"}}}}
{"actor":{"display_login":"smarthi"}}