{"action":"created","issue":{"url":"https://api.github.com/repos/goldmann/docker-squash/issues/111","repository_url":"https://api.github.com/repos/goldmann/docker-squash","labels_url":"https://api.github.com/repos/goldmann/docker-squash/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/goldmann/docker-squash/issues/111/comments","events_url":"https://api.github.com/repos/goldmann/docker-squash/issues/111/events","html_url":"https://github.com/goldmann/docker-squash/issues/111","id":167879376,"number":111,"title":"Incorrect logic for symlinks","user":{"login":"phpdude","id":340576,"avatar_url":"https://avatars.githubusercontent.com/u/340576?v=3","gravatar_id":"","url":"https://api.github.com/users/phpdude","html_url":"https://github.com/phpdude","followers_url":"https://api.github.com/users/phpdude/followers","following_url":"https://api.github.com/users/phpdude/following{/other_user}","gists_url":"https://api.github.com/users/phpdude/gists{/gist_id}","starred_url":"https://api.github.com/users/phpdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpdude/subscriptions","organizations_url":"https://api.github.com/users/phpdude/orgs","repos_url":"https://api.github.com/users/phpdude/repos","events_url":"https://api.github.com/users/phpdude/events{/privacy}","received_events_url":"https://api.github.com/users/phpdude/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/goldmann/docker-squash/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/goldmann/docker-squash/labels/high%20priority","name":"high priority","color":"f7c6c7"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/goldmann/docker-squash/milestones/6","html_url":"https://github.com/goldmann/docker-squash/milestones/1.0.1","labels_url":"https://api.github.com/repos/goldmann/docker-squash/milestones/6/labels","id":1909093,"number":6,"title":"1.0.1","description":"","creator":{"login":"goldmann","id":43489,"avatar_url":"https://avatars.githubusercontent.com/u/43489?v=3","gravatar_id":"","url":"https://api.github.com/users/goldmann","html_url":"https://github.com/goldmann","followers_url":"https://api.github.com/users/goldmann/followers","following_url":"https://api.github.com/users/goldmann/following{/other_user}","gists_url":"https://api.github.com/users/goldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/goldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldmann/subscriptions","organizations_url":"https://api.github.com/users/goldmann/orgs","repos_url":"https://api.github.com/users/goldmann/repos","events_url":"https://api.github.com/users/goldmann/events{/privacy}","received_events_url":"https://api.github.com/users/goldmann/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2016-07-28T09:27:41Z","updated_at":"2016-07-29T14:29:58Z","due_on":"2016-07-28T22:00:00Z","closed_at":null},"comments":17,"created_at":"2016-07-27T15:12:02Z","updated_at":"2016-07-29T14:31:50Z","closed_at":"2016-07-29T14:29:58Z","body":"Please check commit https://github.com/goldmann/docker-squash/commit/afd81aefb5230ef8f001fec544e8649984427444\r\n\r\nIt is not correct, because you are checking for symlinks' targets in the list `squashed_files` (`member.linkname not in squashed_files`) which CAN BE NOT FILLED YET FOR TARGET FILES. This is incorrect.\r\n\r\nYou need to add symlinks to a temporary list and iterate through them after processing ALL other type of members in `layer_tar`, this will avoid the critical bug you created in the commit :)\r\n\r\nDo you need a help in resolving the issue?"},"comment":{"url":"https://api.github.com/repos/goldmann/docker-squash/issues/comments/236196129","html_url":"https://github.com/goldmann/docker-squash/issues/111#issuecomment-236196129","issue_url":"https://api.github.com/repos/goldmann/docker-squash/issues/111","id":236196129,"user":{"login":"goldmann","id":43489,"avatar_url":"https://avatars.githubusercontent.com/u/43489?v=3","gravatar_id":"","url":"https://api.github.com/users/goldmann","html_url":"https://github.com/goldmann","followers_url":"https://api.github.com/users/goldmann/followers","following_url":"https://api.github.com/users/goldmann/following{/other_user}","gists_url":"https://api.github.com/users/goldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/goldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldmann/subscriptions","organizations_url":"https://api.github.com/users/goldmann/orgs","repos_url":"https://api.github.com/users/goldmann/repos","events_url":"https://api.github.com/users/goldmann/events{/privacy}","received_events_url":"https://api.github.com/users/goldmann/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T14:31:50Z","updated_at":"2016-07-29T14:31:50Z","body":"The PR was merged and this issue was closed. Please try with latest master and reopen if you still see the issue."}}
{"actor":{"display_login":"goldmann"}}