{"action":"closed","number":556,"pull_request":{"url":"https://api.github.com/repos/skatejs/skatejs/pulls/556","id":70175989,"html_url":"https://github.com/skatejs/skatejs/pull/556","diff_url":"https://github.com/skatejs/skatejs/pull/556.diff","patch_url":"https://github.com/skatejs/skatejs/pull/556.patch","issue_url":"https://api.github.com/repos/skatejs/skatejs/issues/556","number":556,"state":"closed","locked":false,"title":"#547 - Remove skate.render() and sync render in skate.state()","user":{"login":"treshugart","id":136556,"avatar_url":"https://avatars.githubusercontent.com/u/136556?v=3","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"body":"Implements option three from #547.\r\n\r\nThis currently does not cater to the case where you may set properties around a call to `state()`:\r\n\r\n```js\r\nelem.someProp = true;\r\nstate(elem, { someOtherProp: true });\r\nelem.someOtherOtherProp = true;\r\n```\r\n\r\nIn that case, `someProp` and `someOtherOtherProp` sets would cause a render to happen async after the call to `state()` while the call to `state()` also invokes a render. In the case above there would be two render calls: one for the property sets and one for the call to `state()`.\r\n\r\nI don't see it worth catering to this use case at this point in time because one would either want to use `state()` or set properties but not both. It's likely also state would be used in apps where they have access to the `state()` function that corresponds to the version of Skate they are using. In environments where Skate is used to distribute web components to end users, `state()` likely wouldn't be used because the consumers would just set properties.\r\n","created_at":"2016-05-16T10:14:23Z","updated_at":"2016-05-17T10:57:31Z","closed_at":"2016-05-17T10:57:31Z","merged_at":"2016-05-17T10:57:31Z","merge_commit_sha":"b2b7391120eb554dbc6c4eb7051e2a0e518319d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skatejs/skatejs/pulls/556/commits","review_comments_url":"https://api.github.com/repos/skatejs/skatejs/pulls/556/comments","review_comment_url":"https://api.github.com/repos/skatejs/skatejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skatejs/skatejs/issues/556/comments","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/a35b094860de39ec41d4cb7ee4a6374f64feff6f","head":{"label":"skatejs:547","ref":"547","sha":"a35b094860de39ec41d4cb7ee4a6374f64feff6f","user":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"repo":{"id":16425042,"name":"skatejs","full_name":"skatejs/skatejs","owner":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skatejs/skatejs","description":"Skate is a library built on top of the W3C web component specs that enables you to write functional and performant web components with a very small footprint.","fork":false,"url":"https://api.github.com/repos/skatejs/skatejs","forks_url":"https://api.github.com/repos/skatejs/skatejs/forks","keys_url":"https://api.github.com/repos/skatejs/skatejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skatejs/skatejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skatejs/skatejs/teams","hooks_url":"https://api.github.com/repos/skatejs/skatejs/hooks","issue_events_url":"https://api.github.com/repos/skatejs/skatejs/issues/events{/number}","events_url":"https://api.github.com/repos/skatejs/skatejs/events","assignees_url":"https://api.github.com/repos/skatejs/skatejs/assignees{/user}","branches_url":"https://api.github.com/repos/skatejs/skatejs/branches{/branch}","tags_url":"https://api.github.com/repos/skatejs/skatejs/tags","blobs_url":"https://api.github.com/repos/skatejs/skatejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skatejs/skatejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skatejs/skatejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/skatejs/skatejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/{sha}","languages_url":"https://api.github.com/repos/skatejs/skatejs/languages","stargazers_url":"https://api.github.com/repos/skatejs/skatejs/stargazers","contributors_url":"https://api.github.com/repos/skatejs/skatejs/contributors","subscribers_url":"https://api.github.com/repos/skatejs/skatejs/subscribers","subscription_url":"https://api.github.com/repos/skatejs/skatejs/subscription","commits_url":"https://api.github.com/repos/skatejs/skatejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/skatejs/skatejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/skatejs/skatejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/skatejs/skatejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/skatejs/skatejs/contents/{+path}","compare_url":"https://api.github.com/repos/skatejs/skatejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skatejs/skatejs/merges","archive_url":"https://api.github.com/repos/skatejs/skatejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skatejs/skatejs/downloads","issues_url":"https://api.github.com/repos/skatejs/skatejs/issues{/number}","pulls_url":"https://api.github.com/repos/skatejs/skatejs/pulls{/number}","milestones_url":"https://api.github.com/repos/skatejs/skatejs/milestones{/number}","notifications_url":"https://api.github.com/repos/skatejs/skatejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skatejs/skatejs/labels{/name}","releases_url":"https://api.github.com/repos/skatejs/skatejs/releases{/id}","deployments_url":"https://api.github.com/repos/skatejs/skatejs/deployments","created_at":"2014-02-01T00:32:47Z","updated_at":"2016-05-14T18:08:11Z","pushed_at":"2016-05-17T10:57:31Z","git_url":"git://github.com/skatejs/skatejs.git","ssh_url":"git@github.com:skatejs/skatejs.git","clone_url":"https://github.com/skatejs/skatejs.git","svn_url":"https://github.com/skatejs/skatejs","homepage":"","size":4510,"stargazers_count":592,"watchers_count":592,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":21,"forks":30,"open_issues":21,"watchers":592,"default_branch":"master"}},"base":{"label":"skatejs:master","ref":"master","sha":"c9db8cea9e005d53c5b89813a3042397d55d8812","user":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"repo":{"id":16425042,"name":"skatejs","full_name":"skatejs/skatejs","owner":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skatejs/skatejs","description":"Skate is a library built on top of the W3C web component specs that enables you to write functional and performant web components with a very small footprint.","fork":false,"url":"https://api.github.com/repos/skatejs/skatejs","forks_url":"https://api.github.com/repos/skatejs/skatejs/forks","keys_url":"https://api.github.com/repos/skatejs/skatejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skatejs/skatejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skatejs/skatejs/teams","hooks_url":"https://api.github.com/repos/skatejs/skatejs/hooks","issue_events_url":"https://api.github.com/repos/skatejs/skatejs/issues/events{/number}","events_url":"https://api.github.com/repos/skatejs/skatejs/events","assignees_url":"https://api.github.com/repos/skatejs/skatejs/assignees{/user}","branches_url":"https://api.github.com/repos/skatejs/skatejs/branches{/branch}","tags_url":"https://api.github.com/repos/skatejs/skatejs/tags","blobs_url":"https://api.github.com/repos/skatejs/skatejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skatejs/skatejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skatejs/skatejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/skatejs/skatejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/{sha}","languages_url":"https://api.github.com/repos/skatejs/skatejs/languages","stargazers_url":"https://api.github.com/repos/skatejs/skatejs/stargazers","contributors_url":"https://api.github.com/repos/skatejs/skatejs/contributors","subscribers_url":"https://api.github.com/repos/skatejs/skatejs/subscribers","subscription_url":"https://api.github.com/repos/skatejs/skatejs/subscription","commits_url":"https://api.github.com/repos/skatejs/skatejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/skatejs/skatejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/skatejs/skatejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/skatejs/skatejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/skatejs/skatejs/contents/{+path}","compare_url":"https://api.github.com/repos/skatejs/skatejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skatejs/skatejs/merges","archive_url":"https://api.github.com/repos/skatejs/skatejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skatejs/skatejs/downloads","issues_url":"https://api.github.com/repos/skatejs/skatejs/issues{/number}","pulls_url":"https://api.github.com/repos/skatejs/skatejs/pulls{/number}","milestones_url":"https://api.github.com/repos/skatejs/skatejs/milestones{/number}","notifications_url":"https://api.github.com/repos/skatejs/skatejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skatejs/skatejs/labels{/name}","releases_url":"https://api.github.com/repos/skatejs/skatejs/releases{/id}","deployments_url":"https://api.github.com/repos/skatejs/skatejs/deployments","created_at":"2014-02-01T00:32:47Z","updated_at":"2016-05-14T18:08:11Z","pushed_at":"2016-05-17T10:57:31Z","git_url":"git://github.com/skatejs/skatejs.git","ssh_url":"git@github.com:skatejs/skatejs.git","clone_url":"https://github.com/skatejs/skatejs.git","svn_url":"https://github.com/skatejs/skatejs","homepage":"","size":4510,"stargazers_count":592,"watchers_count":592,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":21,"forks":30,"open_issues":21,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/556"},"html":{"href":"https://github.com/skatejs/skatejs/pull/556"},"issue":{"href":"https://api.github.com/repos/skatejs/skatejs/issues/556"},"comments":{"href":"https://api.github.com/repos/skatejs/skatejs/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/skatejs/skatejs/statuses/a35b094860de39ec41d4cb7ee4a6374f64feff6f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"treshugart","id":136556,"avatar_url":"https://avatars.githubusercontent.com/u/136556?v=3","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":71,"deletions":62,"changed_files":11}}