{"action":"created","comment":{"url":"https://api.github.com/repos/zurb/inky-rb/pulls/comments/74446507","id":74446507,"diff_hunk":"@@ -6,11 +6,12 @@ class InstallGenerator < ::Rails::Generators::Base\n       desc 'Install Foundation for Emails'\n       source_root File.join(File.dirname(__FILE__), 'templates')\n       argument :layout_name, :type => :string, :default => 'mailer', :banner => 'layout_name'\n+      argument :extension,   :type => :string, :default => 'erb',    :banner => 'extension'\n \n       def preserve_original_mailer_layout\n         return nil unless layout_name == 'mailer'\n \n-        original_mailer = File.join(layouts_base_dir, 'mailer.html.erb')\n+        original_mailer = File.join(layouts_base_dir, \"mailer.html.#{extenstion}\")","path":"lib/generators/inky/install_generator.rb","position":10,"original_position":10,"commit_id":"6e102551623e894e0536cbed88e24fc1ef205079","original_commit_id":"6e102551623e894e0536cbed88e24fc1ef205079","user":{"login":"kball","id":44007,"avatar_url":"https://avatars.githubusercontent.com/u/44007?v=3","gravatar_id":"","url":"https://api.github.com/users/kball","html_url":"https://github.com/kball","followers_url":"https://api.github.com/users/kball/followers","following_url":"https://api.github.com/users/kball/following{/other_user}","gists_url":"https://api.github.com/users/kball/gists{/gist_id}","starred_url":"https://api.github.com/users/kball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kball/subscriptions","organizations_url":"https://api.github.com/users/kball/orgs","repos_url":"https://api.github.com/users/kball/repos","events_url":"https://api.github.com/users/kball/events{/privacy}","received_events_url":"https://api.github.com/users/kball/received_events","type":"User","site_admin":false},"body":"Looks like there's a typo in the extension","created_at":"2016-08-11T15:38:47Z","updated_at":"2016-08-11T15:38:47Z","html_url":"https://github.com/zurb/inky-rb/pull/21#discussion_r74446507","pull_request_url":"https://api.github.com/repos/zurb/inky-rb/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/zurb/inky-rb/pulls/comments/74446507"},"html":{"href":"https://github.com/zurb/inky-rb/pull/21#discussion_r74446507"},"pull_request":{"href":"https://api.github.com/repos/zurb/inky-rb/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/zurb/inky-rb/pulls/21","id":80952600,"html_url":"https://github.com/zurb/inky-rb/pull/21","diff_url":"https://github.com/zurb/inky-rb/pull/21.diff","patch_url":"https://github.com/zurb/inky-rb/pull/21.patch","issue_url":"https://api.github.com/repos/zurb/inky-rb/issues/21","number":21,"state":"open","locked":false,"title":"Add a gem configurator to enable changing target inky template engine","user":{"login":"bobmaerten","id":907274,"avatar_url":"https://avatars.githubusercontent.com/u/907274?v=3","gravatar_id":"","url":"https://api.github.com/users/bobmaerten","html_url":"https://github.com/bobmaerten","followers_url":"https://api.github.com/users/bobmaerten/followers","following_url":"https://api.github.com/users/bobmaerten/following{/other_user}","gists_url":"https://api.github.com/users/bobmaerten/gists{/gist_id}","starred_url":"https://api.github.com/users/bobmaerten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobmaerten/subscriptions","organizations_url":"https://api.github.com/users/bobmaerten/orgs","repos_url":"https://api.github.com/users/bobmaerten/repos","events_url":"https://api.github.com/users/bobmaerten/events{/privacy}","received_events_url":"https://api.github.com/users/bobmaerten/received_events","type":"User","site_admin":false},"body":"Paving the way for other configuration variables, this PR implements\r\nthe \"Configurator Pattern\".\r\n\r\nTo change default ERB template engine, set an initializer like this:\r\n```ruby\r\n# config/initializers/inky.rb\r\nInky.configure do |config|\r\n  config.template_engine = :slim\r\nend\r\n```\r\n\r\nOf course, you have to ensure this template is loaded in you app.\r\n\r\nRails generator is amended to output Slim or Haml versions of mailer_layout.\r\n\r\nAlso updates README files concordantly, and remove remaining references to\r\nREXML after Nokogiri replacement.\r\n\r\nFixes #14","created_at":"2016-08-11T12:57:16Z","updated_at":"2016-08-11T15:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2e340cfe7b856ef0091434138b4c9911adde3e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zurb/inky-rb/pulls/21/commits","review_comments_url":"https://api.github.com/repos/zurb/inky-rb/pulls/21/comments","review_comment_url":"https://api.github.com/repos/zurb/inky-rb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zurb/inky-rb/issues/21/comments","statuses_url":"https://api.github.com/repos/zurb/inky-rb/statuses/6e102551623e894e0536cbed88e24fc1ef205079","head":{"label":"bobmaerten:configure-template-engine","ref":"configure-template-engine","sha":"6e102551623e894e0536cbed88e24fc1ef205079","user":{"login":"bobmaerten","id":907274,"avatar_url":"https://avatars.githubusercontent.com/u/907274?v=3","gravatar_id":"","url":"https://api.github.com/users/bobmaerten","html_url":"https://github.com/bobmaerten","followers_url":"https://api.github.com/users/bobmaerten/followers","following_url":"https://api.github.com/users/bobmaerten/following{/other_user}","gists_url":"https://api.github.com/users/bobmaerten/gists{/gist_id}","starred_url":"https://api.github.com/users/bobmaerten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobmaerten/subscriptions","organizations_url":"https://api.github.com/users/bobmaerten/orgs","repos_url":"https://api.github.com/users/bobmaerten/repos","events_url":"https://api.github.com/users/bobmaerten/events{/privacy}","received_events_url":"https://api.github.com/users/bobmaerten/received_events","type":"User","site_admin":false},"repo":{"id":65468371,"name":"inky-rb","full_name":"bobmaerten/inky-rb","owner":{"login":"bobmaerten","id":907274,"avatar_url":"https://avatars.githubusercontent.com/u/907274?v=3","gravatar_id":"","url":"https://api.github.com/users/bobmaerten","html_url":"https://github.com/bobmaerten","followers_url":"https://api.github.com/users/bobmaerten/followers","following_url":"https://api.github.com/users/bobmaerten/following{/other_user}","gists_url":"https://api.github.com/users/bobmaerten/gists{/gist_id}","starred_url":"https://api.github.com/users/bobmaerten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobmaerten/subscriptions","organizations_url":"https://api.github.com/users/bobmaerten/orgs","repos_url":"https://api.github.com/users/bobmaerten/repos","events_url":"https://api.github.com/users/bobmaerten/events{/privacy}","received_events_url":"https://api.github.com/users/bobmaerten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobmaerten/inky-rb","description":null,"fork":true,"url":"https://api.github.com/repos/bobmaerten/inky-rb","forks_url":"https://api.github.com/repos/bobmaerten/inky-rb/forks","keys_url":"https://api.github.com/repos/bobmaerten/inky-rb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobmaerten/inky-rb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobmaerten/inky-rb/teams","hooks_url":"https://api.github.com/repos/bobmaerten/inky-rb/hooks","issue_events_url":"https://api.github.com/repos/bobmaerten/inky-rb/issues/events{/number}","events_url":"https://api.github.com/repos/bobmaerten/inky-rb/events","assignees_url":"https://api.github.com/repos/bobmaerten/inky-rb/assignees{/user}","branches_url":"https://api.github.com/repos/bobmaerten/inky-rb/branches{/branch}","tags_url":"https://api.github.com/repos/bobmaerten/inky-rb/tags","blobs_url":"https://api.github.com/repos/bobmaerten/inky-rb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobmaerten/inky-rb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobmaerten/inky-rb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobmaerten/inky-rb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobmaerten/inky-rb/statuses/{sha}","languages_url":"https://api.github.com/repos/bobmaerten/inky-rb/languages","stargazers_url":"https://api.github.com/repos/bobmaerten/inky-rb/stargazers","contributors_url":"https://api.github.com/repos/bobmaerten/inky-rb/contributors","subscribers_url":"https://api.github.com/repos/bobmaerten/inky-rb/subscribers","subscription_url":"https://api.github.com/repos/bobmaerten/inky-rb/subscription","commits_url":"https://api.github.com/repos/bobmaerten/inky-rb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobmaerten/inky-rb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobmaerten/inky-rb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobmaerten/inky-rb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobmaerten/inky-rb/contents/{+path}","compare_url":"https://api.github.com/repos/bobmaerten/inky-rb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobmaerten/inky-rb/merges","archive_url":"https://api.github.com/repos/bobmaerten/inky-rb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobmaerten/inky-rb/downloads","issues_url":"https://api.github.com/repos/bobmaerten/inky-rb/issues{/number}","pulls_url":"https://api.github.com/repos/bobmaerten/inky-rb/pulls{/number}","milestones_url":"https://api.github.com/repos/bobmaerten/inky-rb/milestones{/number}","notifications_url":"https://api.github.com/repos/bobmaerten/inky-rb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobmaerten/inky-rb/labels{/name}","releases_url":"https://api.github.com/repos/bobmaerten/inky-rb/releases{/id}","deployments_url":"https://api.github.com/repos/bobmaerten/inky-rb/deployments","created_at":"2016-08-11T12:41:09Z","updated_at":"2016-08-11T12:41:10Z","pushed_at":"2016-08-11T12:52:23Z","git_url":"git://github.com/bobmaerten/inky-rb.git","ssh_url":"git@github.com:bobmaerten/inky-rb.git","clone_url":"https://github.com/bobmaerten/inky-rb.git","svn_url":"https://github.com/bobmaerten/inky-rb","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zurb:develop","ref":"develop","sha":"d8e349af4752e728e7dbc6246dd99f41ebb8d28c","user":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"repo":{"id":55104003,"name":"inky-rb","full_name":"zurb/inky-rb","owner":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zurb/inky-rb","description":"","fork":false,"url":"https://api.github.com/repos/zurb/inky-rb","forks_url":"https://api.github.com/repos/zurb/inky-rb/forks","keys_url":"https://api.github.com/repos/zurb/inky-rb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurb/inky-rb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurb/inky-rb/teams","hooks_url":"https://api.github.com/repos/zurb/inky-rb/hooks","issue_events_url":"https://api.github.com/repos/zurb/inky-rb/issues/events{/number}","events_url":"https://api.github.com/repos/zurb/inky-rb/events","assignees_url":"https://api.github.com/repos/zurb/inky-rb/assignees{/user}","branches_url":"https://api.github.com/repos/zurb/inky-rb/branches{/branch}","tags_url":"https://api.github.com/repos/zurb/inky-rb/tags","blobs_url":"https://api.github.com/repos/zurb/inky-rb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurb/inky-rb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurb/inky-rb/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurb/inky-rb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurb/inky-rb/statuses/{sha}","languages_url":"https://api.github.com/repos/zurb/inky-rb/languages","stargazers_url":"https://api.github.com/repos/zurb/inky-rb/stargazers","contributors_url":"https://api.github.com/repos/zurb/inky-rb/contributors","subscribers_url":"https://api.github.com/repos/zurb/inky-rb/subscribers","subscription_url":"https://api.github.com/repos/zurb/inky-rb/subscription","commits_url":"https://api.github.com/repos/zurb/inky-rb/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurb/inky-rb/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurb/inky-rb/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurb/inky-rb/issues/comments{/number}","contents_url":"https://api.github.com/repos/zurb/inky-rb/contents/{+path}","compare_url":"https://api.github.com/repos/zurb/inky-rb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurb/inky-rb/merges","archive_url":"https://api.github.com/repos/zurb/inky-rb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurb/inky-rb/downloads","issues_url":"https://api.github.com/repos/zurb/inky-rb/issues{/number}","pulls_url":"https://api.github.com/repos/zurb/inky-rb/pulls{/number}","milestones_url":"https://api.github.com/repos/zurb/inky-rb/milestones{/number}","notifications_url":"https://api.github.com/repos/zurb/inky-rb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurb/inky-rb/labels{/name}","releases_url":"https://api.github.com/repos/zurb/inky-rb/releases{/id}","deployments_url":"https://api.github.com/repos/zurb/inky-rb/deployments","created_at":"2016-03-30T23:07:26Z","updated_at":"2016-08-09T19:30:09Z","pushed_at":"2016-08-11T12:57:16Z","git_url":"git://github.com/zurb/inky-rb.git","ssh_url":"git@github.com:zurb/inky-rb.git","clone_url":"https://github.com/zurb/inky-rb.git","svn_url":"https://github.com/zurb/inky-rb","homepage":null,"size":37,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zurb/inky-rb/pulls/21"},"html":{"href":"https://github.com/zurb/inky-rb/pull/21"},"issue":{"href":"https://api.github.com/repos/zurb/inky-rb/issues/21"},"comments":{"href":"https://api.github.com/repos/zurb/inky-rb/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/zurb/inky-rb/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/zurb/inky-rb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zurb/inky-rb/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/zurb/inky-rb/statuses/6e102551623e894e0536cbed88e24fc1ef205079"}}}}
{"actor":{"display_login":"kball"}}