{"action":"created","issue":{"url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/406","repository_url":"https://api.github.com/repos/bvaughn/react-virtualized","labels_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/406/labels{/name}","comments_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/406/comments","events_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/406/events","html_url":"https://github.com/bvaughn/react-virtualized/issues/406","id":178089755,"number":406,"title":"VirtualScroll should honor row keys","user":{"login":"ppershing","id":837681,"avatar_url":"https://avatars.githubusercontent.com/u/837681?v=3","gravatar_id":"","url":"https://api.github.com/users/ppershing","html_url":"https://github.com/ppershing","followers_url":"https://api.github.com/users/ppershing/followers","following_url":"https://api.github.com/users/ppershing/following{/other_user}","gists_url":"https://api.github.com/users/ppershing/gists{/gist_id}","starred_url":"https://api.github.com/users/ppershing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppershing/subscriptions","organizations_url":"https://api.github.com/users/ppershing/orgs","repos_url":"https://api.github.com/users/ppershing/repos","events_url":"https://api.github.com/users/ppershing/events{/privacy}","received_events_url":"https://api.github.com/users/ppershing/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-20T15:14:53Z","updated_at":"2016-09-20T18:02:23Z","closed_at":"2016-09-20T16:03:11Z","body":"Right now, `VirtualScroll` uses `Grid` which generates its own element keys. While this works nice in most cases, having surrogate keys creates a mess once you start shifting the entries (e.g., by inserting to the top of the list) -- optimally, we would like for the components to be reconciled the same way as in React.\r\nMy suggestion is to therefore use `key` from the element `rowRenderer` returns as the underlying key and use the surrogate key only if the `key` prop is not defined there.\r\n"},"comment":{"url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/comments/248382080","html_url":"https://github.com/bvaughn/react-virtualized/issues/406#issuecomment-248382080","issue_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/406","id":248382080,"user":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars.githubusercontent.com/u/29597?v=3","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T18:02:23Z","updated_at":"2016-09-20T18:02:23Z","body":"Woo hoo! That's great. 😁\r\n\r\nI was getting confused 😅\r\n\r\nYou're welcome. Thanks for the kind words."}}
{"actor":{"display_login":"bvaughn"}}