{"action":"created","issue":{"url":"https://api.github.com/repos/macports/macports-ports/issues/76","repository_url":"https://api.github.com/repos/macports/macports-ports","labels_url":"https://api.github.com/repos/macports/macports-ports/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/macports/macports-ports/issues/76/comments","events_url":"https://api.github.com/repos/macports/macports-ports/issues/76/events","html_url":"https://github.com/macports/macports-ports/pull/76","id":193038165,"number":76,"title":"dnsviz: New port","user":{"login":"cdeccio","id":3991892,"avatar_url":"https://avatars.githubusercontent.com/u/3991892?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeccio","html_url":"https://github.com/cdeccio","followers_url":"https://api.github.com/users/cdeccio/followers","following_url":"https://api.github.com/users/cdeccio/following{/other_user}","gists_url":"https://api.github.com/users/cdeccio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeccio/subscriptions","organizations_url":"https://api.github.com/users/cdeccio/orgs","repos_url":"https://api.github.com/users/cdeccio/repos","events_url":"https://api.github.com/users/cdeccio/events{/privacy}","received_events_url":"https://api.github.com/users/cdeccio/received_events","type":"User","site_admin":false},"labels":[{"id":472413808,"url":"https://api.github.com/repos/macports/macports-ports/labels/submission","name":"submission","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-12-02T05:35:42Z","updated_at":"2016-12-03T16:17:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/macports/macports-ports/pulls/76","html_url":"https://github.com/macports/macports-ports/pull/76","diff_url":"https://github.com/macports/macports-ports/pull/76.diff","patch_url":"https://github.com/macports/macports-ports/pull/76.patch"},"body":"Fixes: https://trac.macports.org/attachment/ticket/52441"},"comment":{"url":"https://api.github.com/repos/macports/macports-ports/issues/comments/264648680","html_url":"https://github.com/macports/macports-ports/pull/76#issuecomment-264648680","issue_url":"https://api.github.com/repos/macports/macports-ports/issues/76","id":264648680,"user":{"login":"cdeccio","id":3991892,"avatar_url":"https://avatars.githubusercontent.com/u/3991892?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeccio","html_url":"https://github.com/cdeccio","followers_url":"https://api.github.com/users/cdeccio/followers","following_url":"https://api.github.com/users/cdeccio/following{/other_user}","gists_url":"https://api.github.com/users/cdeccio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeccio/subscriptions","organizations_url":"https://api.github.com/users/cdeccio/orgs","repos_url":"https://api.github.com/users/cdeccio/repos","events_url":"https://api.github.com/users/cdeccio/events{/privacy}","received_events_url":"https://api.github.com/users/cdeccio/received_events","type":"User","site_admin":false},"created_at":"2016-12-03T16:17:21Z","updated_at":"2016-12-03T16:17:21Z","body":"> OK, so the error comes from dot. Fine. (If you know how to fix it, you may open a new ticket or PR. :)\r\n\r\nSounds good.  I believe they are related to fonts missing on the local system.  However, I can't see those errors when I run it.  If there's a log somewhere then I can reference to take a look, then I could see.  If it worked despite the errors, you would see images in the HTML file installed for documentation at: `/opt/local/share/doc/dnsviz/dnsviz-graph.html`\r\n\r\nYou could also run the following after installation:\r\n\r\n```\r\ndnsviz probe . | dnsviz graph -Tpng -O\r\n```\r\n\r\nwhich should produce a png file `root.png` that should include text.\r\n\r\n\r\n>  please align at 20 spaces rather than 19 to comply with the header (my editor's cursor says 21 before the first character, but that's because the next character is going to be 21st)\r\n\r\nOkay, indeed I was one off.  I got it now.  It will be fixed in the next rebase.\r\n\r\n>  I guess it's ok, but I just wanted to double-check: is graphviz really just a build dependency or do you also need it when running the program?\r\n\r\nWell, technically it is required for runtime, but because it is a dependency of pygraphviz, I left it only as a build-time dependency (because pygraphviz isn't needed to build, only for runtime).  If you think I should change that, I can, but my preference was to explicitly define only immediate dependencies and let the others be learned recursively.\r\n\r\n>  I was a bit wrong about -append. The python portgroup only adds python to depends_lib, nothing to depends_build or depends_run. There's nothing wrong with -append though, it's safer in any case. All I wanted to say is that you can make both dependencis either with or without -append.\r\n\r\nThanks for the info.  I've taken it out for now but can re-add if it becomes necessary.\r\n\r\n> I would put build dependency above the runtime ones, but that's personal decision, zero influence on functionality.\r\n\r\nSeems reasonable to me.\r\n\r\n>  Personally I would put python.default_version at any place before calling python.version. I don't think it matters in this case, but from a perspective of a developer (if this was a C program), I would expect the version to be \"known\" before using it.\r\n\r\nThat works.\r\n\r\n>  You may split arguments to destroot.destdir in multiple lines if you want, but again, it's not needed.\r\n\r\nDone."}}
{"actor":{"display_login":"cdeccio"}}