{"action":"created","issue":{"url":"https://api.github.com/repos/andyet/SimpleWebRTC/issues/445","repository_url":"https://api.github.com/repos/andyet/SimpleWebRTC","labels_url":"https://api.github.com/repos/andyet/SimpleWebRTC/issues/445/labels{/name}","comments_url":"https://api.github.com/repos/andyet/SimpleWebRTC/issues/445/comments","events_url":"https://api.github.com/repos/andyet/SimpleWebRTC/issues/445/events","html_url":"https://github.com/andyet/SimpleWebRTC/pull/445","id":159310828,"number":445,"title":"fixing bug related to removing multiple peers while leavin…","user":{"login":"bitnovus","id":2301447,"avatar_url":"https://avatars.githubusercontent.com/u/2301447?v=3","gravatar_id":"","url":"https://api.github.com/users/bitnovus","html_url":"https://github.com/bitnovus","followers_url":"https://api.github.com/users/bitnovus/followers","following_url":"https://api.github.com/users/bitnovus/following{/other_user}","gists_url":"https://api.github.com/users/bitnovus/gists{/gist_id}","starred_url":"https://api.github.com/users/bitnovus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitnovus/subscriptions","organizations_url":"https://api.github.com/users/bitnovus/orgs","repos_url":"https://api.github.com/users/bitnovus/repos","events_url":"https://api.github.com/users/bitnovus/events{/privacy}","received_events_url":"https://api.github.com/users/bitnovus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-09T01:20:58Z","updated_at":"2016-08-11T05:32:36Z","closed_at":"2016-06-11T15:27:29Z","pull_request":{"url":"https://api.github.com/repos/andyet/SimpleWebRTC/pulls/445","html_url":"https://github.com/andyet/SimpleWebRTC/pull/445","diff_url":"https://github.com/andyet/SimpleWebRTC/pull/445.diff","patch_url":"https://github.com/andyet/SimpleWebRTC/pull/445.patch"},"body":"…g a room\r\n\r\n#300 doesn't completely solve #176 because of the \"peers\" Object's mutability. As such, leaveRoom() will not correctly end all peers.\r\n\r\nUsing shift() removes the peer from the \"peers\" Object and calling end() triggers handleStreamRemoved() which in turn searches for an already-removed Peer which leads to a splice(-1,1). This .splice call removes an extra peer at the end of the \"peers\" Object without calling end() on it which in turn leads to a Peer not being cleaned up when leaveRoom() is called.\r\n\r\n@chairmanwow helped debug this.\r\n\r\nJSHint is happy.\r\nAll current tests pass.\r\nThere are no new tests."},"comment":{"url":"https://api.github.com/repos/andyet/SimpleWebRTC/issues/comments/239077136","html_url":"https://github.com/andyet/SimpleWebRTC/pull/445#issuecomment-239077136","issue_url":"https://api.github.com/repos/andyet/SimpleWebRTC/issues/445","id":239077136,"user":{"login":"SuperBlastGainz","id":20716398,"avatar_url":"https://avatars.githubusercontent.com/u/20716398?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperBlastGainz","html_url":"https://github.com/SuperBlastGainz","followers_url":"https://api.github.com/users/SuperBlastGainz/followers","following_url":"https://api.github.com/users/SuperBlastGainz/following{/other_user}","gists_url":"https://api.github.com/users/SuperBlastGainz/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperBlastGainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperBlastGainz/subscriptions","organizations_url":"https://api.github.com/users/SuperBlastGainz/orgs","repos_url":"https://api.github.com/users/SuperBlastGainz/repos","events_url":"https://api.github.com/users/SuperBlastGainz/events{/privacy}","received_events_url":"https://api.github.com/users/SuperBlastGainz/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T05:32:36Z","updated_at":"2016-08-11T05:32:36Z","body":"Weird, I'm still getting this error even though I see the diff'd changes in my files. Any ideas why?"}}
{"actor":{"display_login":"SuperBlastGainz"}}