{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/69826466","id":69826466,"diff_hunk":"@@ -532,25 +537,22 @@ module meteor {\n \n \n   proc solve() {\n-    forall piece in 0..9:uint(8) {\n+    forall piece in piecesDom do\n       solve_helper(piece);\n-    }\n   }\n \n-  proc solve_linear(in depth: int, in cell: int, in board: uint,\n-      in avail: uint(16), solNums: [] uint(8), solMasks: [] uint) {\n-    var pieceNoMask: uint(16);\n-    var maxRots: int;\n-    var pieceMask: uint;\n+  proc solve_linear(in depth, in cell, in board,\n+      in avail, solNums, solMasks) {\n+    var pieceNoMask, maxRots, pieceMask: int;\n \n     if solutionCount.read() >= maxSolutions then\n       return;\n \n     while (board & (1 << cell)) do\n       cell += 1;\n \n-    for piece in 0..9:uint(8) {\n-      pieceNoMask = 1:uint(16) << piece;\n+    for piece in piecesDom {\n+      pieceNoMask = 1 << piece;\n       if !((avail & pieceNoMask):bool) {","path":"test/studies/shootout/meteor/kbrady/meteor-parallel.chpl","position":583,"original_position":583,"commit_id":"b9df74dc6bde54379a27c1c754f5be6a7e5744ed","original_commit_id":"b9df74dc6bde54379a27c1c754f5be6a7e5744ed","user":{"login":"ben-albrecht","id":3595449,"avatar_url":"https://avatars.githubusercontent.com/u/3595449?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-albrecht","html_url":"https://github.com/ben-albrecht","followers_url":"https://api.github.com/users/ben-albrecht/followers","following_url":"https://api.github.com/users/ben-albrecht/following{/other_user}","gists_url":"https://api.github.com/users/ben-albrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-albrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-albrecht/subscriptions","organizations_url":"https://api.github.com/users/ben-albrecht/orgs","repos_url":"https://api.github.com/users/ben-albrecht/repos","events_url":"https://api.github.com/users/ben-albrecht/events{/privacy}","received_events_url":"https://api.github.com/users/ben-albrecht/received_events","type":"User","site_admin":false},"body":"Does this work if we drop the `:bool` cast?","created_at":"2016-07-06T22:56:24Z","updated_at":"2016-07-06T22:56:24Z","html_url":"https://github.com/chapel-lang/chapel/pull/4124#discussion_r69826466","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4124","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/69826466"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/4124#discussion_r69826466"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4124"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4124","id":76313572,"html_url":"https://github.com/chapel-lang/chapel/pull/4124","diff_url":"https://github.com/chapel-lang/chapel/pull/4124.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/4124.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/4124","number":4124,"state":"open","locked":false,"title":"Clean up of elegant (slower) meteor","user":{"login":"lydia-duncan","id":2454710,"avatar_url":"https://avatars.githubusercontent.com/u/2454710?v=3","gravatar_id":"","url":"https://api.github.com/users/lydia-duncan","html_url":"https://github.com/lydia-duncan","followers_url":"https://api.github.com/users/lydia-duncan/followers","following_url":"https://api.github.com/users/lydia-duncan/following{/other_user}","gists_url":"https://api.github.com/users/lydia-duncan/gists{/gist_id}","starred_url":"https://api.github.com/users/lydia-duncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lydia-duncan/subscriptions","organizations_url":"https://api.github.com/users/lydia-duncan/orgs","repos_url":"https://api.github.com/users/lydia-duncan/repos","events_url":"https://api.github.com/users/lydia-duncan/events{/privacy}","received_events_url":"https://api.github.com/users/lydia-duncan/received_events","type":"User","site_admin":false},"body":"No difference in performance was found for these changes on my machine\r\nor on chap04.\r\n\r\nChanges performed on test/studies/shootout/meteor/kbrady/meteor-parallel.chpl\r\nwhich is the source for test/release/examples/benchmarks/shootout/meteor.chpl.\r\n\r\nChanges include:\r\n- fixing some typos that weren't in the release version\r\n- replacing mentions of unsigned long long int and long long int with just int\r\n  and uint.\r\n- made all lines 80 characters or less\r\n- changed comment style to remove middle *s\r\n- removed our reliance on ints and uints of sizes other than the default\r\n- removed all but a couple of the uints\r\n- allowed type inference on arguments, some local and global variables.\r\n- unified our style of for loops with single line bodies\r\n- inserted some spaces between if and their conditional\r\n- replaced some repetitive lines with for loops over the affected indices\r\n  - recorded place where this was not possible due to function resolution\r\n    being unable to handle recursion\r\n- made a couple of lines more readable by saving the index for the third level\r\n  array access and using the local variable instead of the repeated logic.\r\n- converted some now very repetitive local and global definitions into\r\n  multivariable definitions\r\n- replaced some magic numbers with a couple of variables to indicate what\r\n  they represent.\r\n\r\nI could still change the arrays to 1s based indexing but I was exhausted at this\r\npoint so that'll have to happen later.","created_at":"2016-07-05T17:42:34Z","updated_at":"2016-07-06T22:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d01c9a4ef1af3dba700321ad4a1fe84db6073160","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4124/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4124/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/4124/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/b9df74dc6bde54379a27c1c754f5be6a7e5744ed","head":{"label":"lydia-duncan:meteorElegant","ref":"meteorElegant","sha":"b9df74dc6bde54379a27c1c754f5be6a7e5744ed","user":{"login":"lydia-duncan","id":2454710,"avatar_url":"https://avatars.githubusercontent.com/u/2454710?v=3","gravatar_id":"","url":"https://api.github.com/users/lydia-duncan","html_url":"https://github.com/lydia-duncan","followers_url":"https://api.github.com/users/lydia-duncan/followers","following_url":"https://api.github.com/users/lydia-duncan/following{/other_user}","gists_url":"https://api.github.com/users/lydia-duncan/gists{/gist_id}","starred_url":"https://api.github.com/users/lydia-duncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lydia-duncan/subscriptions","organizations_url":"https://api.github.com/users/lydia-duncan/orgs","repos_url":"https://api.github.com/users/lydia-duncan/repos","events_url":"https://api.github.com/users/lydia-duncan/events{/privacy}","received_events_url":"https://api.github.com/users/lydia-duncan/received_events","type":"User","site_admin":false},"repo":{"id":21914939,"name":"chapel","full_name":"lydia-duncan/chapel","owner":{"login":"lydia-duncan","id":2454710,"avatar_url":"https://avatars.githubusercontent.com/u/2454710?v=3","gravatar_id":"","url":"https://api.github.com/users/lydia-duncan","html_url":"https://github.com/lydia-duncan","followers_url":"https://api.github.com/users/lydia-duncan/followers","following_url":"https://api.github.com/users/lydia-duncan/following{/other_user}","gists_url":"https://api.github.com/users/lydia-duncan/gists{/gist_id}","starred_url":"https://api.github.com/users/lydia-duncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lydia-duncan/subscriptions","organizations_url":"https://api.github.com/users/lydia-duncan/orgs","repos_url":"https://api.github.com/users/lydia-duncan/repos","events_url":"https://api.github.com/users/lydia-duncan/events{/privacy}","received_events_url":"https://api.github.com/users/lydia-duncan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lydia-duncan/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/lydia-duncan/chapel","forks_url":"https://api.github.com/repos/lydia-duncan/chapel/forks","keys_url":"https://api.github.com/repos/lydia-duncan/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lydia-duncan/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lydia-duncan/chapel/teams","hooks_url":"https://api.github.com/repos/lydia-duncan/chapel/hooks","issue_events_url":"https://api.github.com/repos/lydia-duncan/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/lydia-duncan/chapel/events","assignees_url":"https://api.github.com/repos/lydia-duncan/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/lydia-duncan/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/lydia-duncan/chapel/tags","blobs_url":"https://api.github.com/repos/lydia-duncan/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lydia-duncan/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lydia-duncan/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/lydia-duncan/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lydia-duncan/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/lydia-duncan/chapel/languages","stargazers_url":"https://api.github.com/repos/lydia-duncan/chapel/stargazers","contributors_url":"https://api.github.com/repos/lydia-duncan/chapel/contributors","subscribers_url":"https://api.github.com/repos/lydia-duncan/chapel/subscribers","subscription_url":"https://api.github.com/repos/lydia-duncan/chapel/subscription","commits_url":"https://api.github.com/repos/lydia-duncan/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/lydia-duncan/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/lydia-duncan/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/lydia-duncan/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/lydia-duncan/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/lydia-duncan/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lydia-duncan/chapel/merges","archive_url":"https://api.github.com/repos/lydia-duncan/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lydia-duncan/chapel/downloads","issues_url":"https://api.github.com/repos/lydia-duncan/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/lydia-duncan/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/lydia-duncan/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/lydia-duncan/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lydia-duncan/chapel/labels{/name}","releases_url":"https://api.github.com/repos/lydia-duncan/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/lydia-duncan/chapel/deployments","created_at":"2014-07-16T19:55:13Z","updated_at":"2016-01-11T17:36:15Z","pushed_at":"2016-07-05T19:08:02Z","git_url":"git://github.com/lydia-duncan/chapel.git","ssh_url":"git@github.com:lydia-duncan/chapel.git","clone_url":"https://github.com/lydia-duncan/chapel.git","svn_url":"https://github.com/lydia-duncan/chapel","homepage":"http://chapel.cray.com/","size":362387,"stargazers_count":1,"watchers_count":1,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"b6c2267fc5024c1a84233855eabaf7fb74ccbf7a","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2016-07-06T00:07:50Z","pushed_at":"2016-07-06T22:54:36Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":475708,"stargazers_count":285,"watchers_count":285,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":17,"forks":104,"open_issues":17,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4124"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/4124"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/4124"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/4124/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4124/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4124/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/b9df74dc6bde54379a27c1c754f5be6a7e5744ed"}}}}
{"actor":{"display_login":"ben-albrecht"}}