{"action":"created","comment":{"url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/comments/90516322","pull_request_review_id":11030737,"id":90516322,"diff_hunk":"@@ -32,58 +35,62 @@ articleView.handleAuthorFilter = function() {\n };\n \n articleView.handleCategoryFilter = function() {\n-  /* TODO: Just like we do for #author-filter above, we should handle change\n+  /* TODONE: Just like we do for #author-filter above, we should handle change\n             events on the #category-filter element. Be sure to reset\n             the #author-filter while you're at it! */\n+  $('#category-filter').on('change', function() {\n+    if ($(this).val()) {\n+      $('article').hide();\n+      $('article[data-category=\"' + $(this).val() + '\"]').fadeIn();\n+    } else {\n+      $('article').not('.template').fadeIn();\n+    }\n+    $('#author-filter').val('');\n+  });\n };\n \n articleView.handleMainNav = function() {\n-  /* TODO: Complete the delegated event handler below to help\n+  /* TODONE: Complete the delegated event handler below to help\n             power the tabs feature.\n       Clicking any .tab element should:\n         1. Hide all the .tab-content sections.\n         2. Fade in the single .tab-content section that is associated with\n             the clicked .tab element's data-content attribute. */\n-  $('.main-nav').on(/* CODE GOES HERE */);\n+  $('.main-nav').on('click', '.tab', function(){\n+    $('.tab-content').hide();\n+    $('#' + $(this).data('content')).fadeIn();\n+  });","path":"starter-code/scripts/articleView.js","position":49,"original_position":49,"commit_id":"0961eb9c4122cec9a84160eb89df88a59903e288","original_commit_id":"0961eb9c4122cec9a84160eb89df88a59903e288","user":{"login":"clessor88","id":14851569,"avatar_url":"https://avatars.githubusercontent.com/u/14851569?v=3","gravatar_id":"","url":"https://api.github.com/users/clessor88","html_url":"https://github.com/clessor88","followers_url":"https://api.github.com/users/clessor88/followers","following_url":"https://api.github.com/users/clessor88/following{/other_user}","gists_url":"https://api.github.com/users/clessor88/gists{/gist_id}","starred_url":"https://api.github.com/users/clessor88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clessor88/subscriptions","organizations_url":"https://api.github.com/users/clessor88/orgs","repos_url":"https://api.github.com/users/clessor88/repos","events_url":"https://api.github.com/users/clessor88/events{/privacy}","received_events_url":"https://api.github.com/users/clessor88/received_events","type":"User","site_admin":false},"body":"Great job hiding all of the tab-content sections and fading in only the selected one","created_at":"2016-12-01T19:16:31Z","updated_at":"2016-12-01T19:16:31Z","html_url":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events/pull/5#discussion_r90516322","pull_request_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/comments/90516322"},"html":{"href":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events/pull/5#discussion_r90516322"},"pull_request":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/5","id":96014261,"html_url":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events/pull/5","diff_url":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events/pull/5.diff","patch_url":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events/pull/5.patch","issue_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/issues/5","number":5,"state":"open","locked":false,"title":"mike-jaren","user":{"login":"mikemiksch","id":21977107,"avatar_url":"https://avatars.githubusercontent.com/u/21977107?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemiksch","html_url":"https://github.com/mikemiksch","followers_url":"https://api.github.com/users/mikemiksch/followers","following_url":"https://api.github.com/users/mikemiksch/following{/other_user}","gists_url":"https://api.github.com/users/mikemiksch/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemiksch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemiksch/subscriptions","organizations_url":"https://api.github.com/users/mikemiksch/orgs","repos_url":"https://api.github.com/users/mikemiksch/repos","events_url":"https://api.github.com/users/mikemiksch/events{/privacy}","received_events_url":"https://api.github.com/users/mikemiksch/received_events","type":"User","site_admin":false},"body":"#### Single-line Summary\r\n**Today, Mike and Jaren paired together. It took about  2 hours**\r\n\r\n#### Reflect and summarize on your process for each `TODO` item :  \r\n  1. First we went for the low hanging fruit and added the JS links into the HTML file.\r\n  2. Then we worked to add the author name as an attribute of the article. We messed it up the first time by concatenating the preexisting category with the author's name, but sorted it out shortly after.\r\n  3. Next we tried to make it so that if the author box had a value, all other articles would be hidden. This was a bit of a wall for a while, but we were able to figure it out on our own. Yay.\r\n4. The category filter was, like, the exact same code only we swapped the data attribute name. Took all of thirty seconds.\r\n5. Getting the about/articles to appear/disappear depending on the link clicked was beyond our abilities to figure out without the assistance of Crystal. We had no idea how to even begin to approach it, and then it turned out to be like three lines.\r\n6. The last bit was getting the truncated articles to show the rest of their content without showing all the other articles. We managed to get it so the button revealed the article on our own, but not without revealing all the others. Again, needed the help of Crystal to pull through.\r\n\r\n#### Checklist (before submitting, fill in each set of square brackets with an 'x')\r\n- [X] We have titled the Pull Request similar to our branch name (ex: 'brian-rick'). \r\n- [X] This PR includes commits from both myself and my partner; e.g. We followed good pair programming practices by switching driver/navigator roles.\r\n- [X] There is no extraneous, unrelated code included in this PR.\r\n- [X] We have summarized our `TODO:` process above.\r\n\r\n","created_at":"2016-12-01T02:18:36Z","updated_at":"2016-12-01T19:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61dc5b88a26cac54b4aa082a97e776475a88a4d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/5/commits","review_comments_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/5/comments","review_comment_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/issues/5/comments","statuses_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/statuses/0961eb9c4122cec9a84160eb89df88a59903e288","head":{"label":"mikemiksch:master","ref":"master","sha":"0961eb9c4122cec9a84160eb89df88a59903e288","user":{"login":"mikemiksch","id":21977107,"avatar_url":"https://avatars.githubusercontent.com/u/21977107?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemiksch","html_url":"https://github.com/mikemiksch","followers_url":"https://api.github.com/users/mikemiksch/followers","following_url":"https://api.github.com/users/mikemiksch/following{/other_user}","gists_url":"https://api.github.com/users/mikemiksch/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemiksch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemiksch/subscriptions","organizations_url":"https://api.github.com/users/mikemiksch/orgs","repos_url":"https://api.github.com/users/mikemiksch/repos","events_url":"https://api.github.com/users/mikemiksch/events{/privacy}","received_events_url":"https://api.github.com/users/mikemiksch/received_events","type":"User","site_admin":false},"repo":{"id":75014840,"name":"03-jquery-and-events","full_name":"mikemiksch/03-jquery-and-events","owner":{"login":"mikemiksch","id":21977107,"avatar_url":"https://avatars.githubusercontent.com/u/21977107?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemiksch","html_url":"https://github.com/mikemiksch","followers_url":"https://api.github.com/users/mikemiksch/followers","following_url":"https://api.github.com/users/mikemiksch/following{/other_user}","gists_url":"https://api.github.com/users/mikemiksch/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemiksch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemiksch/subscriptions","organizations_url":"https://api.github.com/users/mikemiksch/orgs","repos_url":"https://api.github.com/users/mikemiksch/repos","events_url":"https://api.github.com/users/mikemiksch/events{/privacy}","received_events_url":"https://api.github.com/users/mikemiksch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikemiksch/03-jquery-and-events","description":"Add event handling to our blog's functionality!","fork":true,"url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events","forks_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/forks","keys_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/teams","hooks_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/hooks","issue_events_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/issues/events{/number}","events_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/events","assignees_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/assignees{/user}","branches_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/branches{/branch}","tags_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/tags","blobs_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/statuses/{sha}","languages_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/languages","stargazers_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/stargazers","contributors_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/contributors","subscribers_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/subscribers","subscription_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/subscription","commits_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/contents/{+path}","compare_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/merges","archive_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/downloads","issues_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/issues{/number}","pulls_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/pulls{/number}","milestones_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/milestones{/number}","notifications_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/labels{/name}","releases_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/releases{/id}","deployments_url":"https://api.github.com/repos/mikemiksch/03-jquery-and-events/deployments","created_at":"2016-11-28T21:14:20Z","updated_at":"2016-11-28T21:14:21Z","pushed_at":"2016-12-01T02:18:10Z","git_url":"git://github.com/mikemiksch/03-jquery-and-events.git","ssh_url":"git@github.com:mikemiksch/03-jquery-and-events.git","clone_url":"https://github.com/mikemiksch/03-jquery-and-events.git","svn_url":"https://github.com/mikemiksch/03-jquery-and-events","homepage":null,"size":168,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codefellows-seattle-301d7:master","ref":"master","sha":"3fb0086b685404549052cad58aa09f32de372af7","user":{"login":"codefellows-seattle-301d7","id":19618166,"avatar_url":"https://avatars.githubusercontent.com/u/19618166?v=3","gravatar_id":"","url":"https://api.github.com/users/codefellows-seattle-301d7","html_url":"https://github.com/codefellows-seattle-301d7","followers_url":"https://api.github.com/users/codefellows-seattle-301d7/followers","following_url":"https://api.github.com/users/codefellows-seattle-301d7/following{/other_user}","gists_url":"https://api.github.com/users/codefellows-seattle-301d7/gists{/gist_id}","starred_url":"https://api.github.com/users/codefellows-seattle-301d7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefellows-seattle-301d7/subscriptions","organizations_url":"https://api.github.com/users/codefellows-seattle-301d7/orgs","repos_url":"https://api.github.com/users/codefellows-seattle-301d7/repos","events_url":"https://api.github.com/users/codefellows-seattle-301d7/events{/privacy}","received_events_url":"https://api.github.com/users/codefellows-seattle-301d7/received_events","type":"Organization","site_admin":false},"repo":{"id":60665964,"name":"03-jquery-and-events","full_name":"codefellows-seattle-301d7/03-jquery-and-events","owner":{"login":"codefellows-seattle-301d7","id":19618166,"avatar_url":"https://avatars.githubusercontent.com/u/19618166?v=3","gravatar_id":"","url":"https://api.github.com/users/codefellows-seattle-301d7","html_url":"https://github.com/codefellows-seattle-301d7","followers_url":"https://api.github.com/users/codefellows-seattle-301d7/followers","following_url":"https://api.github.com/users/codefellows-seattle-301d7/following{/other_user}","gists_url":"https://api.github.com/users/codefellows-seattle-301d7/gists{/gist_id}","starred_url":"https://api.github.com/users/codefellows-seattle-301d7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefellows-seattle-301d7/subscriptions","organizations_url":"https://api.github.com/users/codefellows-seattle-301d7/orgs","repos_url":"https://api.github.com/users/codefellows-seattle-301d7/repos","events_url":"https://api.github.com/users/codefellows-seattle-301d7/events{/privacy}","received_events_url":"https://api.github.com/users/codefellows-seattle-301d7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events","description":"Add event handling to our blog's functionality!","fork":false,"url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events","forks_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/forks","keys_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/teams","hooks_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/hooks","issue_events_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/issues/events{/number}","events_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/events","assignees_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/assignees{/user}","branches_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/branches{/branch}","tags_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/tags","blobs_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/git/refs{/sha}","trees_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/statuses/{sha}","languages_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/languages","stargazers_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/stargazers","contributors_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/contributors","subscribers_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/subscribers","subscription_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/subscription","commits_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/commits{/sha}","git_commits_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/git/commits{/sha}","comments_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/comments{/number}","issue_comment_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/issues/comments{/number}","contents_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/contents/{+path}","compare_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/merges","archive_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/downloads","issues_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/issues{/number}","pulls_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls{/number}","milestones_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/milestones{/number}","notifications_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/labels{/name}","releases_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/releases{/id}","deployments_url":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/deployments","created_at":"2016-06-08T03:37:47Z","updated_at":"2016-06-08T18:46:05Z","pushed_at":"2016-12-01T02:18:37Z","git_url":"git://github.com/codefellows-seattle-301d7/03-jquery-and-events.git","ssh_url":"git@github.com:codefellows-seattle-301d7/03-jquery-and-events.git","clone_url":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events.git","svn_url":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events","homepage":null,"size":171,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/5"},"html":{"href":"https://github.com/codefellows-seattle-301d7/03-jquery-and-events/pull/5"},"issue":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/issues/5"},"comments":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/codefellows-seattle-301d7/03-jquery-and-events/statuses/0961eb9c4122cec9a84160eb89df88a59903e288"}}}}
{"actor":{"display_login":"clessor88"}}