{"action":"created","comment":{"url":"https://api.github.com/repos/Behat/MinkExtension/pulls/comments/67409274","id":67409274,"diff_hunk":"@@ -159,7 +159,7 @@ public function saveScreenshot($filename = null, $filepath = null)\n         // Under Cygwin, uniqid with more_entropy must be set to true.\n         // No effect in other environments.\n         $filename = $filename ?: sprintf('%s_%s_%s.%s', $this->getMinkParameter('browser_name'), date('c'), uniqid('', true), 'png');\n-        $filepath = $filepath ? $filepath : (ini_get('upload_tmp_dir') ? ini_get('upload_tmp_dir') : sys_get_temp_dir());\n+        $filepath = $filepath ?: (ini_get('upload_tmp_dir') ? ini_get('upload_tmp_dir') : sys_get_temp_dir());","path":"src/Behat/MinkExtension/Context/RawMinkContext.php","position":5,"original_position":5,"commit_id":"779c19486ba5a1306c76a702391f13335a23b36c","original_commit_id":"779c19486ba5a1306c76a702391f13335a23b36c","user":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?v=3","gravatar_id":"","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"body":"Just notices, that this issue was already there and you just removed the `$filepath`.","created_at":"2016-06-16T19:30:12Z","updated_at":"2016-06-16T19:30:12Z","html_url":"https://github.com/Behat/MinkExtension/pull/208#discussion_r67409274","pull_request_url":"https://api.github.com/repos/Behat/MinkExtension/pulls/208","_links":{"self":{"href":"https://api.github.com/repos/Behat/MinkExtension/pulls/comments/67409274"},"html":{"href":"https://github.com/Behat/MinkExtension/pull/208#discussion_r67409274"},"pull_request":{"href":"https://api.github.com/repos/Behat/MinkExtension/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/Behat/MinkExtension/pulls/208","id":34373347,"html_url":"https://github.com/Behat/MinkExtension/pull/208","diff_url":"https://github.com/Behat/MinkExtension/pull/208.diff","patch_url":"https://github.com/Behat/MinkExtension/pull/208.patch","issue_url":"https://api.github.com/repos/Behat/MinkExtension/issues/208","number":208,"state":"open","locked":false,"title":"saveScreenshot function refactoring.","user":{"login":"VincentCATILLON","id":8419208,"avatar_url":"https://avatars.githubusercontent.com/u/8419208?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentCATILLON","html_url":"https://github.com/VincentCATILLON","followers_url":"https://api.github.com/users/VincentCATILLON/followers","following_url":"https://api.github.com/users/VincentCATILLON/following{/other_user}","gists_url":"https://api.github.com/users/VincentCATILLON/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentCATILLON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentCATILLON/subscriptions","organizations_url":"https://api.github.com/users/VincentCATILLON/orgs","repos_url":"https://api.github.com/users/VincentCATILLON/repos","events_url":"https://api.github.com/users/VincentCATILLON/events{/privacy}","received_events_url":"https://api.github.com/users/VincentCATILLON/received_events","type":"User","site_admin":false},"body":"Just to be coherent with the ternary condition above it.","created_at":"2015-04-29T15:15:51Z","updated_at":"2016-06-16T19:30:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d117400240ce38b2f5906aab8fdedbad84ee859c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Behat/MinkExtension/pulls/208/commits","review_comments_url":"https://api.github.com/repos/Behat/MinkExtension/pulls/208/comments","review_comment_url":"https://api.github.com/repos/Behat/MinkExtension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Behat/MinkExtension/issues/208/comments","statuses_url":"https://api.github.com/repos/Behat/MinkExtension/statuses/779c19486ba5a1306c76a702391f13335a23b36c","head":{"label":"VincentCATILLON:raw-mink-context-ternary-condition","ref":"raw-mink-context-ternary-condition","sha":"779c19486ba5a1306c76a702391f13335a23b36c","user":{"login":"VincentCATILLON","id":8419208,"avatar_url":"https://avatars.githubusercontent.com/u/8419208?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentCATILLON","html_url":"https://github.com/VincentCATILLON","followers_url":"https://api.github.com/users/VincentCATILLON/followers","following_url":"https://api.github.com/users/VincentCATILLON/following{/other_user}","gists_url":"https://api.github.com/users/VincentCATILLON/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentCATILLON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentCATILLON/subscriptions","organizations_url":"https://api.github.com/users/VincentCATILLON/orgs","repos_url":"https://api.github.com/users/VincentCATILLON/repos","events_url":"https://api.github.com/users/VincentCATILLON/events{/privacy}","received_events_url":"https://api.github.com/users/VincentCATILLON/received_events","type":"User","site_admin":false},"repo":{"id":34800984,"name":"MinkExtension","full_name":"VincentCATILLON/MinkExtension","owner":{"login":"VincentCATILLON","id":8419208,"avatar_url":"https://avatars.githubusercontent.com/u/8419208?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentCATILLON","html_url":"https://github.com/VincentCATILLON","followers_url":"https://api.github.com/users/VincentCATILLON/followers","following_url":"https://api.github.com/users/VincentCATILLON/following{/other_user}","gists_url":"https://api.github.com/users/VincentCATILLON/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentCATILLON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentCATILLON/subscriptions","organizations_url":"https://api.github.com/users/VincentCATILLON/orgs","repos_url":"https://api.github.com/users/VincentCATILLON/repos","events_url":"https://api.github.com/users/VincentCATILLON/events{/privacy}","received_events_url":"https://api.github.com/users/VincentCATILLON/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VincentCATILLON/MinkExtension","description":"Mink extension (tight integration and configuration) for Behat","fork":true,"url":"https://api.github.com/repos/VincentCATILLON/MinkExtension","forks_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/forks","keys_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/teams","hooks_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/hooks","issue_events_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/issues/events{/number}","events_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/events","assignees_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/assignees{/user}","branches_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/branches{/branch}","tags_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/tags","blobs_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/git/refs{/sha}","trees_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/statuses/{sha}","languages_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/languages","stargazers_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/stargazers","contributors_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/contributors","subscribers_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/subscribers","subscription_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/subscription","commits_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/commits{/sha}","git_commits_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/git/commits{/sha}","comments_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/comments{/number}","issue_comment_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/issues/comments{/number}","contents_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/contents/{+path}","compare_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/merges","archive_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/downloads","issues_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/issues{/number}","pulls_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/pulls{/number}","milestones_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/milestones{/number}","notifications_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/labels{/name}","releases_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/releases{/id}","deployments_url":"https://api.github.com/repos/VincentCATILLON/MinkExtension/deployments","created_at":"2015-04-29T15:11:03Z","updated_at":"2015-04-29T15:11:04Z","pushed_at":"2015-04-29T15:15:23Z","git_url":"git://github.com/VincentCATILLON/MinkExtension.git","ssh_url":"git@github.com:VincentCATILLON/MinkExtension.git","clone_url":"https://github.com/VincentCATILLON/MinkExtension.git","svn_url":"https://github.com/VincentCATILLON/MinkExtension","homepage":"","size":428,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Behat:master","ref":"master","sha":"9bff0ae65f32f9bf9df0afef91057a7bfeeeafc6","user":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=3","gravatar_id":"","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"repo":{"id":4243422,"name":"MinkExtension","full_name":"Behat/MinkExtension","owner":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=3","gravatar_id":"","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Behat/MinkExtension","description":"Mink extension (tight integration and configuration) for Behat","fork":false,"url":"https://api.github.com/repos/Behat/MinkExtension","forks_url":"https://api.github.com/repos/Behat/MinkExtension/forks","keys_url":"https://api.github.com/repos/Behat/MinkExtension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Behat/MinkExtension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Behat/MinkExtension/teams","hooks_url":"https://api.github.com/repos/Behat/MinkExtension/hooks","issue_events_url":"https://api.github.com/repos/Behat/MinkExtension/issues/events{/number}","events_url":"https://api.github.com/repos/Behat/MinkExtension/events","assignees_url":"https://api.github.com/repos/Behat/MinkExtension/assignees{/user}","branches_url":"https://api.github.com/repos/Behat/MinkExtension/branches{/branch}","tags_url":"https://api.github.com/repos/Behat/MinkExtension/tags","blobs_url":"https://api.github.com/repos/Behat/MinkExtension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Behat/MinkExtension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Behat/MinkExtension/git/refs{/sha}","trees_url":"https://api.github.com/repos/Behat/MinkExtension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Behat/MinkExtension/statuses/{sha}","languages_url":"https://api.github.com/repos/Behat/MinkExtension/languages","stargazers_url":"https://api.github.com/repos/Behat/MinkExtension/stargazers","contributors_url":"https://api.github.com/repos/Behat/MinkExtension/contributors","subscribers_url":"https://api.github.com/repos/Behat/MinkExtension/subscribers","subscription_url":"https://api.github.com/repos/Behat/MinkExtension/subscription","commits_url":"https://api.github.com/repos/Behat/MinkExtension/commits{/sha}","git_commits_url":"https://api.github.com/repos/Behat/MinkExtension/git/commits{/sha}","comments_url":"https://api.github.com/repos/Behat/MinkExtension/comments{/number}","issue_comment_url":"https://api.github.com/repos/Behat/MinkExtension/issues/comments{/number}","contents_url":"https://api.github.com/repos/Behat/MinkExtension/contents/{+path}","compare_url":"https://api.github.com/repos/Behat/MinkExtension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Behat/MinkExtension/merges","archive_url":"https://api.github.com/repos/Behat/MinkExtension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Behat/MinkExtension/downloads","issues_url":"https://api.github.com/repos/Behat/MinkExtension/issues{/number}","pulls_url":"https://api.github.com/repos/Behat/MinkExtension/pulls{/number}","milestones_url":"https://api.github.com/repos/Behat/MinkExtension/milestones{/number}","notifications_url":"https://api.github.com/repos/Behat/MinkExtension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Behat/MinkExtension/labels{/name}","releases_url":"https://api.github.com/repos/Behat/MinkExtension/releases{/id}","deployments_url":"https://api.github.com/repos/Behat/MinkExtension/deployments","created_at":"2012-05-06T19:14:48Z","updated_at":"2016-06-10T15:41:40Z","pushed_at":"2016-06-05T10:35:15Z","git_url":"git://github.com/Behat/MinkExtension.git","ssh_url":"git@github.com:Behat/MinkExtension.git","clone_url":"https://github.com/Behat/MinkExtension.git","svn_url":"https://github.com/Behat/MinkExtension","homepage":"","size":644,"stargazers_count":134,"watchers_count":134,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":35,"forks":177,"open_issues":35,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Behat/MinkExtension/pulls/208"},"html":{"href":"https://github.com/Behat/MinkExtension/pull/208"},"issue":{"href":"https://api.github.com/repos/Behat/MinkExtension/issues/208"},"comments":{"href":"https://api.github.com/repos/Behat/MinkExtension/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/Behat/MinkExtension/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/Behat/MinkExtension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Behat/MinkExtension/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/Behat/MinkExtension/statuses/779c19486ba5a1306c76a702391f13335a23b36c"}}}}
{"actor":{"display_login":"aik099"}}