{"action":"created","comment":{"url":"https://api.github.com/repos/google/quiver-dart/pulls/comments/58582245","id":58582245,"diff_hunk":"@@ -627,10 +625,10 @@ class AvlTreeSet<V> extends TreeSet<V> {\n    * See [Set.retainAll]\n    */\n   void retainAll(Iterable<Object> elements) {\n-    List<V> chosen = [];\n+    List<V> chosen = <V>[];\n     for (var target in elements) {\n       if (contains(target)) {\n-        chosen.add(target);\n+        chosen.add(target as V);","path":"lib/src/collection/treeset.dart","position":38,"original_position":38,"commit_id":"9a9c82ee56a63d68d9d4234073262be1a7f6b3a8","original_commit_id":"9a9c82ee56a63d68d9d4234073262be1a7f6b3a8","user":{"login":"yjbanov","id":211513,"avatar_url":"https://avatars.githubusercontent.com/u/211513?v=3","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"body":"`contains`, similar to `remove` feeds the item to the comparator, which could get confused if it received a wrong type. What do you think of:\r\n\r\n```dart\r\nif (target is V && contains(target)) {\r\n  chosen.add(target as V);\r\n}\r\n```\r\n","created_at":"2016-04-05T17:41:47Z","updated_at":"2016-04-05T17:41:47Z","html_url":"https://github.com/google/quiver-dart/pull/290#discussion_r58582245","pull_request_url":"https://api.github.com/repos/google/quiver-dart/pulls/290","_links":{"self":{"href":"https://api.github.com/repos/google/quiver-dart/pulls/comments/58582245"},"html":{"href":"https://github.com/google/quiver-dart/pull/290#discussion_r58582245"},"pull_request":{"href":"https://api.github.com/repos/google/quiver-dart/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/google/quiver-dart/pulls/290","id":65193484,"html_url":"https://github.com/google/quiver-dart/pull/290","diff_url":"https://github.com/google/quiver-dart/pull/290.diff","patch_url":"https://github.com/google/quiver-dart/pull/290.patch","issue_url":"https://api.github.com/repos/google/quiver-dart/issues/290","number":290,"state":"open","locked":false,"title":"Fixes the strong-mode analysis errors.","user":{"login":"emesx","id":7759044,"avatar_url":"https://avatars.githubusercontent.com/u/7759044?v=3","gravatar_id":"","url":"https://api.github.com/users/emesx","html_url":"https://github.com/emesx","followers_url":"https://api.github.com/users/emesx/followers","following_url":"https://api.github.com/users/emesx/following{/other_user}","gists_url":"https://api.github.com/users/emesx/gists{/gist_id}","starred_url":"https://api.github.com/users/emesx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emesx/subscriptions","organizations_url":"https://api.github.com/users/emesx/orgs","repos_url":"https://api.github.com/users/emesx/repos","events_url":"https://api.github.com/users/emesx/events{/privacy}","received_events_url":"https://api.github.com/users/emesx/received_events","type":"User","site_admin":false},"body":"This fixes issues #285 and #286\r\n\r\nRan all tests, all tests pass (except the one reported in #287).\r\nSDK used: 1.16.0-dev.3.0","created_at":"2016-04-04T18:47:17Z","updated_at":"2016-04-05T17:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da3391ba670b67af0380343399c772e250d5102c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/quiver-dart/pulls/290/commits","review_comments_url":"https://api.github.com/repos/google/quiver-dart/pulls/290/comments","review_comment_url":"https://api.github.com/repos/google/quiver-dart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/quiver-dart/issues/290/comments","statuses_url":"https://api.github.com/repos/google/quiver-dart/statuses/9a9c82ee56a63d68d9d4234073262be1a7f6b3a8","head":{"label":"emesx:issue-285-strong-mode-fixes","ref":"issue-285-strong-mode-fixes","sha":"9a9c82ee56a63d68d9d4234073262be1a7f6b3a8","user":{"login":"emesx","id":7759044,"avatar_url":"https://avatars.githubusercontent.com/u/7759044?v=3","gravatar_id":"","url":"https://api.github.com/users/emesx","html_url":"https://github.com/emesx","followers_url":"https://api.github.com/users/emesx/followers","following_url":"https://api.github.com/users/emesx/following{/other_user}","gists_url":"https://api.github.com/users/emesx/gists{/gist_id}","starred_url":"https://api.github.com/users/emesx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emesx/subscriptions","organizations_url":"https://api.github.com/users/emesx/orgs","repos_url":"https://api.github.com/users/emesx/repos","events_url":"https://api.github.com/users/emesx/events{/privacy}","received_events_url":"https://api.github.com/users/emesx/received_events","type":"User","site_admin":false},"repo":{"id":54224895,"name":"quiver-dart","full_name":"emesx/quiver-dart","owner":{"login":"emesx","id":7759044,"avatar_url":"https://avatars.githubusercontent.com/u/7759044?v=3","gravatar_id":"","url":"https://api.github.com/users/emesx","html_url":"https://github.com/emesx","followers_url":"https://api.github.com/users/emesx/followers","following_url":"https://api.github.com/users/emesx/following{/other_user}","gists_url":"https://api.github.com/users/emesx/gists{/gist_id}","starred_url":"https://api.github.com/users/emesx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emesx/subscriptions","organizations_url":"https://api.github.com/users/emesx/orgs","repos_url":"https://api.github.com/users/emesx/repos","events_url":"https://api.github.com/users/emesx/events{/privacy}","received_events_url":"https://api.github.com/users/emesx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emesx/quiver-dart","description":"A set of utility libraries for Dart","fork":true,"url":"https://api.github.com/repos/emesx/quiver-dart","forks_url":"https://api.github.com/repos/emesx/quiver-dart/forks","keys_url":"https://api.github.com/repos/emesx/quiver-dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emesx/quiver-dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emesx/quiver-dart/teams","hooks_url":"https://api.github.com/repos/emesx/quiver-dart/hooks","issue_events_url":"https://api.github.com/repos/emesx/quiver-dart/issues/events{/number}","events_url":"https://api.github.com/repos/emesx/quiver-dart/events","assignees_url":"https://api.github.com/repos/emesx/quiver-dart/assignees{/user}","branches_url":"https://api.github.com/repos/emesx/quiver-dart/branches{/branch}","tags_url":"https://api.github.com/repos/emesx/quiver-dart/tags","blobs_url":"https://api.github.com/repos/emesx/quiver-dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emesx/quiver-dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emesx/quiver-dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/emesx/quiver-dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emesx/quiver-dart/statuses/{sha}","languages_url":"https://api.github.com/repos/emesx/quiver-dart/languages","stargazers_url":"https://api.github.com/repos/emesx/quiver-dart/stargazers","contributors_url":"https://api.github.com/repos/emesx/quiver-dart/contributors","subscribers_url":"https://api.github.com/repos/emesx/quiver-dart/subscribers","subscription_url":"https://api.github.com/repos/emesx/quiver-dart/subscription","commits_url":"https://api.github.com/repos/emesx/quiver-dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/emesx/quiver-dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/emesx/quiver-dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/emesx/quiver-dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/emesx/quiver-dart/contents/{+path}","compare_url":"https://api.github.com/repos/emesx/quiver-dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emesx/quiver-dart/merges","archive_url":"https://api.github.com/repos/emesx/quiver-dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emesx/quiver-dart/downloads","issues_url":"https://api.github.com/repos/emesx/quiver-dart/issues{/number}","pulls_url":"https://api.github.com/repos/emesx/quiver-dart/pulls{/number}","milestones_url":"https://api.github.com/repos/emesx/quiver-dart/milestones{/number}","notifications_url":"https://api.github.com/repos/emesx/quiver-dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emesx/quiver-dart/labels{/name}","releases_url":"https://api.github.com/repos/emesx/quiver-dart/releases{/id}","deployments_url":"https://api.github.com/repos/emesx/quiver-dart/deployments","created_at":"2016-03-18T18:58:40Z","updated_at":"2016-03-18T18:58:41Z","pushed_at":"2016-04-04T18:43:04Z","git_url":"git://github.com/emesx/quiver-dart.git","ssh_url":"git@github.com:emesx/quiver-dart.git","clone_url":"https://github.com/emesx/quiver-dart.git","svn_url":"https://github.com/emesx/quiver-dart","homepage":"https://pub.dartlang.org/packages/quiver","size":593,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"bf96ce4bd63cbf95c33d09ca420c00a1d0652c36","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":12117219,"name":"quiver-dart","full_name":"google/quiver-dart","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/quiver-dart","description":"A set of utility libraries for Dart","fork":false,"url":"https://api.github.com/repos/google/quiver-dart","forks_url":"https://api.github.com/repos/google/quiver-dart/forks","keys_url":"https://api.github.com/repos/google/quiver-dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/quiver-dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/quiver-dart/teams","hooks_url":"https://api.github.com/repos/google/quiver-dart/hooks","issue_events_url":"https://api.github.com/repos/google/quiver-dart/issues/events{/number}","events_url":"https://api.github.com/repos/google/quiver-dart/events","assignees_url":"https://api.github.com/repos/google/quiver-dart/assignees{/user}","branches_url":"https://api.github.com/repos/google/quiver-dart/branches{/branch}","tags_url":"https://api.github.com/repos/google/quiver-dart/tags","blobs_url":"https://api.github.com/repos/google/quiver-dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/quiver-dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/quiver-dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/quiver-dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/quiver-dart/statuses/{sha}","languages_url":"https://api.github.com/repos/google/quiver-dart/languages","stargazers_url":"https://api.github.com/repos/google/quiver-dart/stargazers","contributors_url":"https://api.github.com/repos/google/quiver-dart/contributors","subscribers_url":"https://api.github.com/repos/google/quiver-dart/subscribers","subscription_url":"https://api.github.com/repos/google/quiver-dart/subscription","commits_url":"https://api.github.com/repos/google/quiver-dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/quiver-dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/quiver-dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/quiver-dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/quiver-dart/contents/{+path}","compare_url":"https://api.github.com/repos/google/quiver-dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/quiver-dart/merges","archive_url":"https://api.github.com/repos/google/quiver-dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/quiver-dart/downloads","issues_url":"https://api.github.com/repos/google/quiver-dart/issues{/number}","pulls_url":"https://api.github.com/repos/google/quiver-dart/pulls{/number}","milestones_url":"https://api.github.com/repos/google/quiver-dart/milestones{/number}","notifications_url":"https://api.github.com/repos/google/quiver-dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/quiver-dart/labels{/name}","releases_url":"https://api.github.com/repos/google/quiver-dart/releases{/id}","deployments_url":"https://api.github.com/repos/google/quiver-dart/deployments","created_at":"2013-08-14T19:13:01Z","updated_at":"2016-04-04T11:25:55Z","pushed_at":"2016-04-04T23:34:35Z","git_url":"git://github.com/google/quiver-dart.git","ssh_url":"git@github.com:google/quiver-dart.git","clone_url":"https://github.com/google/quiver-dart.git","svn_url":"https://github.com/google/quiver-dart","homepage":"https://pub.dartlang.org/packages/quiver","size":1151,"stargazers_count":123,"watchers_count":123,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":68,"forks":57,"open_issues":68,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/quiver-dart/pulls/290"},"html":{"href":"https://github.com/google/quiver-dart/pull/290"},"issue":{"href":"https://api.github.com/repos/google/quiver-dart/issues/290"},"comments":{"href":"https://api.github.com/repos/google/quiver-dart/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/google/quiver-dart/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/google/quiver-dart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/quiver-dart/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/google/quiver-dart/statuses/9a9c82ee56a63d68d9d4234073262be1a7f6b3a8"}}}}