{"action":"created","issue":{"url":"https://api.github.com/repos/monero-project/monero/issues/1200","repository_url":"https://api.github.com/repos/monero-project/monero","labels_url":"https://api.github.com/repos/monero-project/monero/issues/1200/labels{/name}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/1200/comments","events_url":"https://api.github.com/repos/monero-project/monero/issues/1200/events","html_url":"https://github.com/monero-project/monero/pull/1200","id":181918771,"number":1200,"title":"Improve wallet naming behaviour","user":{"login":"NanoAkron","id":6762681,"avatar_url":"https://avatars.githubusercontent.com/u/6762681?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoAkron","html_url":"https://github.com/NanoAkron","followers_url":"https://api.github.com/users/NanoAkron/followers","following_url":"https://api.github.com/users/NanoAkron/following{/other_user}","gists_url":"https://api.github.com/users/NanoAkron/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoAkron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoAkron/subscriptions","organizations_url":"https://api.github.com/users/NanoAkron/orgs","repos_url":"https://api.github.com/users/NanoAkron/repos","events_url":"https://api.github.com/users/NanoAkron/events{/privacy}","received_events_url":"https://api.github.com/users/NanoAkron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-10-09T23:17:01Z","updated_at":"2016-10-11T12:31:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/1200","html_url":"https://github.com/monero-project/monero/pull/1200","diff_url":"https://github.com/monero-project/monero/pull/1200.diff","patch_url":"https://github.com/monero-project/monero/pull/1200.patch"},"body":"Added a confirmation step when creating a new wallet, and the option to `exit` during the procedure with improved user notification.\r\n\r\nClosing #1189 \r\n\r\nApologies for the two commits, still no git expert and it looks like changing the name of the branch locally didn't quite have the effect I was expecting."},"comment":{"url":"https://api.github.com/repos/monero-project/monero/issues/comments/252903604","html_url":"https://github.com/monero-project/monero/pull/1200#issuecomment-252903604","issue_url":"https://api.github.com/repos/monero-project/monero/issues/1200","id":252903604,"user":{"login":"NanoAkron","id":6762681,"avatar_url":"https://avatars.githubusercontent.com/u/6762681?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoAkron","html_url":"https://github.com/NanoAkron","followers_url":"https://api.github.com/users/NanoAkron/followers","following_url":"https://api.github.com/users/NanoAkron/following{/other_user}","gists_url":"https://api.github.com/users/NanoAkron/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoAkron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoAkron/subscriptions","organizations_url":"https://api.github.com/users/NanoAkron/orgs","repos_url":"https://api.github.com/users/NanoAkron/repos","events_url":"https://api.github.com/users/NanoAkron/events{/privacy}","received_events_url":"https://api.github.com/users/NanoAkron/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T12:31:42Z","updated_at":"2016-10-11T12:31:42Z","body":"Thanks!\r\n\r\nOn a side issue, I don't see a condition where this function would be called with m_generate_new.empty() equating to false, I just copied that part of the equality from the original function. I suspect we could just test for m_regenerate here."}}
{"actor":{"display_login":"NanoAkron"}}