{"action":"created","issue":{"url":"https://api.github.com/repos/bjweimer/tigerslam/issues/1","repository_url":"https://api.github.com/repos/bjweimer/tigerslam","labels_url":"https://api.github.com/repos/bjweimer/tigerslam/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/bjweimer/tigerslam/issues/1/comments","events_url":"https://api.github.com/repos/bjweimer/tigerslam/issues/1/events","html_url":"https://github.com/bjweimer/tigerslam/pull/1","id":194865212,"number":1,"title":"Initial src update","user":{"login":"bjweimer","id":24359909,"avatar_url":"https://avatars.githubusercontent.com/u/24359909?v=3","gravatar_id":"","url":"https://api.github.com/users/bjweimer","html_url":"https://github.com/bjweimer","followers_url":"https://api.github.com/users/bjweimer/followers","following_url":"https://api.github.com/users/bjweimer/following{/other_user}","gists_url":"https://api.github.com/users/bjweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/bjweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjweimer/subscriptions","organizations_url":"https://api.github.com/users/bjweimer/orgs","repos_url":"https://api.github.com/users/bjweimer/repos","events_url":"https://api.github.com/users/bjweimer/events{/privacy}","received_events_url":"https://api.github.com/users/bjweimer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"wyattjoh","id":633002,"avatar_url":"https://avatars.githubusercontent.com/u/633002?v=3","gravatar_id":"","url":"https://api.github.com/users/wyattjoh","html_url":"https://github.com/wyattjoh","followers_url":"https://api.github.com/users/wyattjoh/followers","following_url":"https://api.github.com/users/wyattjoh/following{/other_user}","gists_url":"https://api.github.com/users/wyattjoh/gists{/gist_id}","starred_url":"https://api.github.com/users/wyattjoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyattjoh/subscriptions","organizations_url":"https://api.github.com/users/wyattjoh/orgs","repos_url":"https://api.github.com/users/wyattjoh/repos","events_url":"https://api.github.com/users/wyattjoh/events{/privacy}","received_events_url":"https://api.github.com/users/wyattjoh/received_events","type":"User","site_admin":false},"assignees":[{"login":"wyattjoh","id":633002,"avatar_url":"https://avatars.githubusercontent.com/u/633002?v=3","gravatar_id":"","url":"https://api.github.com/users/wyattjoh","html_url":"https://github.com/wyattjoh","followers_url":"https://api.github.com/users/wyattjoh/followers","following_url":"https://api.github.com/users/wyattjoh/following{/other_user}","gists_url":"https://api.github.com/users/wyattjoh/gists{/gist_id}","starred_url":"https://api.github.com/users/wyattjoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyattjoh/subscriptions","organizations_url":"https://api.github.com/users/wyattjoh/orgs","repos_url":"https://api.github.com/users/wyattjoh/repos","events_url":"https://api.github.com/users/wyattjoh/events{/privacy}","received_events_url":"https://api.github.com/users/wyattjoh/received_events","type":"User","site_admin":false},{"login":"bjweimer","id":24359909,"avatar_url":"https://avatars.githubusercontent.com/u/24359909?v=3","gravatar_id":"","url":"https://api.github.com/users/bjweimer","html_url":"https://github.com/bjweimer","followers_url":"https://api.github.com/users/bjweimer/followers","following_url":"https://api.github.com/users/bjweimer/following{/other_user}","gists_url":"https://api.github.com/users/bjweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/bjweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjweimer/subscriptions","organizations_url":"https://api.github.com/users/bjweimer/orgs","repos_url":"https://api.github.com/users/bjweimer/repos","events_url":"https://api.github.com/users/bjweimer/events{/privacy}","received_events_url":"https://api.github.com/users/bjweimer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-12-11T23:27:17Z","updated_at":"2016-12-15T14:48:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bjweimer/tigerslam/pulls/1","html_url":"https://github.com/bjweimer/tigerslam/pull/1","diff_url":"https://github.com/bjweimer/tigerslam/pull/1.diff","patch_url":"https://github.com/bjweimer/tigerslam/pull/1.patch"},"body":"I have attempted to update the source code to match the code now running on my robot."},"comment":{"url":"https://api.github.com/repos/bjweimer/tigerslam/issues/comments/267345333","html_url":"https://github.com/bjweimer/tigerslam/pull/1#issuecomment-267345333","issue_url":"https://api.github.com/repos/bjweimer/tigerslam/issues/1","id":267345333,"user":{"login":"bjweimer","id":24359909,"avatar_url":"https://avatars.githubusercontent.com/u/24359909?v=3","gravatar_id":"","url":"https://api.github.com/users/bjweimer","html_url":"https://github.com/bjweimer","followers_url":"https://api.github.com/users/bjweimer/followers","following_url":"https://api.github.com/users/bjweimer/following{/other_user}","gists_url":"https://api.github.com/users/bjweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/bjweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjweimer/subscriptions","organizations_url":"https://api.github.com/users/bjweimer/orgs","repos_url":"https://api.github.com/users/bjweimer/repos","events_url":"https://api.github.com/users/bjweimer/events{/privacy}","received_events_url":"https://api.github.com/users/bjweimer/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T14:48:30Z","updated_at":"2016-12-15T14:48:30Z","body":"Wyatt,\n\nThanks for the comments! I'll try to clean things up a bit this weekend. I\nneeded to create some folders to put some files in, but Windows github\ndoesn't allow you to create empty folders - so I cheated and added the\nReadme files to trick Windows into allowing me to create the folders...\nI'll try to delete the unnecessary Readme files...\n\nBruce.\n\n\nOn Wed, Dec 14, 2016 at 10:04 AM, Wyatt Johnson <notifications@github.com>\nwrote:\n\n> *@wyattjoh* commented on this pull request.\n>\n> I'd also avoid including data files (like the ones in the datasets\n> folder) for the same reason that I'd exclude the config file.\n> ------------------------------\n>\n> In src/assets/config.cfg\n> <https://github.com/bjweimer/tigerslam/pull/1#pullrequestreview-12967675>:\n>\n> > @@ -0,0 +1,99 @@\n> +; Configuration file\n>\n> I tend to avoid putting configuration into source control, specifically as\n> it makes it harder for other users to pick up your code and \"just use it\".\n> Typically what I've seen is using a \"example\" or a template of the config\n> and committing that to source control. Especially as this has\n> username/password details.\n> ------------------------------\n>\n> In src/assets/datasets/readme.md\n> <https://github.com/bjweimer/tigerslam/pull/1#pullrequestreview-12967675>:\n>\n> > @@ -0,0 +1 @@\n> +Add datasets folder\n>\n> I wouldn't put these README.md files here unless there is content to put\n> in them. It makes it harder to understand the purpose of the folder.\n> ------------------------------\n>\n> In src/assets/mapstorage/readme.md\n> <https://github.com/bjweimer/tigerslam/pull/1#pullrequestreview-12967675>:\n>\n> > @@ -0,0 +1 @@\n> +Adding mapstorage folder\n>\n> I wouldn't put these README.md files here unless there is content to put\n> in them. It makes it harder to understand the purpose of the folder.\n> ------------------------------\n>\n> In src/assets/sensorlogs/readme.md\n> <https://github.com/bjweimer/tigerslam/pull/1#pullrequestreview-12967675>:\n>\n> > @@ -0,0 +1 @@\n> +Add sensorlogs folder\n>\n> I wouldn't put these README.md files here unless there is content to put\n> in them. It makes it harder to understand the purpose of the folder.\n>\n> —\n> You are receiving this because you modified the open/close state.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/bjweimer/tigerslam/pull/1#pullrequestreview-12967675>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AXOz5WnT59q-IVRskCeOVOrSFPyRSf8qks5rIC-XgaJpZM4LKEun>\n> .\n>\n"}}
{"actor":{"display_login":"bjweimer"}}