{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/85240619","pull_request_review_id":5967909,"id":85240619,"diff_hunk":"@@ -1,107 +0,0 @@\n--- ","path":"src/test/regress/expected/role_optimizer.out","position":1,"original_position":1,"commit_id":"05401e364bf96ad9a9a5e7596183b3b285a71b89","original_commit_id":"05401e364bf96ad9a9a5e7596183b3b285a71b89","user":{"login":"foyzur","id":1253020,"avatar_url":"https://avatars.githubusercontent.com/u/1253020?v=3","gravatar_id":"","url":"https://api.github.com/users/foyzur","html_url":"https://github.com/foyzur","followers_url":"https://api.github.com/users/foyzur/followers","following_url":"https://api.github.com/users/foyzur/following{/other_user}","gists_url":"https://api.github.com/users/foyzur/gists{/gist_id}","starred_url":"https://api.github.com/users/foyzur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foyzur/subscriptions","organizations_url":"https://api.github.com/users/foyzur/orgs","repos_url":"https://api.github.com/users/foyzur/repos","events_url":"https://api.github.com/users/foyzur/events{/privacy}","received_events_url":"https://api.github.com/users/foyzur/received_events","type":"User","site_admin":false},"body":"Why is this file deleted?","created_at":"2016-10-26T23:20:28Z","updated_at":"2016-10-26T23:20:28Z","html_url":"https://github.com/greenplum-db/gpdb/pull/1247#discussion_r85240619","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1247","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/85240619"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1247#discussion_r85240619"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1247"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1247","id":90712874,"html_url":"https://github.com/greenplum-db/gpdb/pull/1247","diff_url":"https://github.com/greenplum-db/gpdb/pull/1247.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1247.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1247","number":1247,"state":"open","locked":false,"title":"Fix Orca Warning / Error Message","user":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"body":"Using elog::ERROR in GPDB translator might result in a memory leak, as it jump immediately to PostgresMain. Hence when an error happens we print the message as a warning and throw C++ exception to unwind the call stack. But seeing warning followed by the error message is confusing to the user.\r\n\r\nE.g.\r\n```\r\nWARNING:  null value in column \"col3\" violates not-null constraint\r\n-ERROR:  PQO unable to generate a plan, please see the above message for details. (CGPOptimizer.cpp:66)\r\n```\r\n\r\nIn this PR, we introduce the specific exception code for those cases and called elog::ERROR in the last call stack to avoid a memory leak. With this changes, user now see the same error as shown below.\r\n\r\nE.g. \r\n```\r\nERROR:  PQO unable to generate plan, null value in column \"col3\" violates not-null constraint. (CGPOptimizer.cpp:82)\r\n``` \r\n\r\n@vraghavan78 @foyzur @hardikar @armenatzoglou Please take a look when you get chance.\r\n\r\n","created_at":"2016-10-24T23:32:04Z","updated_at":"2016-10-26T23:20:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eeaf6decf7e6deb684a0e4109352f80440c79054","assignee":{"login":"vraghavan78","id":12649877,"avatar_url":"https://avatars.githubusercontent.com/u/12649877?v=3","gravatar_id":"","url":"https://api.github.com/users/vraghavan78","html_url":"https://github.com/vraghavan78","followers_url":"https://api.github.com/users/vraghavan78/followers","following_url":"https://api.github.com/users/vraghavan78/following{/other_user}","gists_url":"https://api.github.com/users/vraghavan78/gists{/gist_id}","starred_url":"https://api.github.com/users/vraghavan78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vraghavan78/subscriptions","organizations_url":"https://api.github.com/users/vraghavan78/orgs","repos_url":"https://api.github.com/users/vraghavan78/repos","events_url":"https://api.github.com/users/vraghavan78/events{/privacy}","received_events_url":"https://api.github.com/users/vraghavan78/received_events","type":"User","site_admin":false},"assignees":[{"login":"vraghavan78","id":12649877,"avatar_url":"https://avatars.githubusercontent.com/u/12649877?v=3","gravatar_id":"","url":"https://api.github.com/users/vraghavan78","html_url":"https://github.com/vraghavan78","followers_url":"https://api.github.com/users/vraghavan78/followers","following_url":"https://api.github.com/users/vraghavan78/following{/other_user}","gists_url":"https://api.github.com/users/vraghavan78/gists{/gist_id}","starred_url":"https://api.github.com/users/vraghavan78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vraghavan78/subscriptions","organizations_url":"https://api.github.com/users/vraghavan78/orgs","repos_url":"https://api.github.com/users/vraghavan78/repos","events_url":"https://api.github.com/users/vraghavan78/events{/privacy}","received_events_url":"https://api.github.com/users/vraghavan78/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1247/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1247/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1247/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/05401e364bf96ad9a9a5e7596183b3b285a71b89","head":{"label":"karthijrk:warning-fix","ref":"warning-fix","sha":"05401e364bf96ad9a9a5e7596183b3b285a71b89","user":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"repo":{"id":46308528,"name":"gpdb","full_name":"karthijrk/gpdb","owner":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karthijrk/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/karthijrk/gpdb","forks_url":"https://api.github.com/repos/karthijrk/gpdb/forks","keys_url":"https://api.github.com/repos/karthijrk/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karthijrk/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karthijrk/gpdb/teams","hooks_url":"https://api.github.com/repos/karthijrk/gpdb/hooks","issue_events_url":"https://api.github.com/repos/karthijrk/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/karthijrk/gpdb/events","assignees_url":"https://api.github.com/repos/karthijrk/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/karthijrk/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/karthijrk/gpdb/tags","blobs_url":"https://api.github.com/repos/karthijrk/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karthijrk/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karthijrk/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/karthijrk/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karthijrk/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/karthijrk/gpdb/languages","stargazers_url":"https://api.github.com/repos/karthijrk/gpdb/stargazers","contributors_url":"https://api.github.com/repos/karthijrk/gpdb/contributors","subscribers_url":"https://api.github.com/repos/karthijrk/gpdb/subscribers","subscription_url":"https://api.github.com/repos/karthijrk/gpdb/subscription","commits_url":"https://api.github.com/repos/karthijrk/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/karthijrk/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/karthijrk/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/karthijrk/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/karthijrk/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/karthijrk/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karthijrk/gpdb/merges","archive_url":"https://api.github.com/repos/karthijrk/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karthijrk/gpdb/downloads","issues_url":"https://api.github.com/repos/karthijrk/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/karthijrk/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/karthijrk/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/karthijrk/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karthijrk/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/karthijrk/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/karthijrk/gpdb/deployments","created_at":"2015-11-16T22:58:20Z","updated_at":"2016-04-13T06:48:19Z","pushed_at":"2016-10-26T17:51:37Z","git_url":"git://github.com/karthijrk/gpdb.git","ssh_url":"git@github.com:karthijrk/gpdb.git","clone_url":"https://github.com/karthijrk/gpdb.git","svn_url":"https://github.com/karthijrk/gpdb","homepage":"http://greenplum.org","size":178624,"stargazers_count":1,"watchers_count":1,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"9353fdec1642e63462e119baf6e4dcd5fcc46ecd","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-10-26T18:05:22Z","pushed_at":"2016-10-26T23:08:24Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":230673,"stargazers_count":1653,"watchers_count":1653,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":474,"mirror_url":null,"open_issues_count":114,"forks":474,"open_issues":114,"watchers":1653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1247"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1247"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1247"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1247/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1247/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1247/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/05401e364bf96ad9a9a5e7596183b3b285a71b89"}}}}
{"actor":{"display_login":"foyzur"}}