{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/84529561","pull_request_review_id":5305129,"id":84529561,"diff_hunk":"@@ -454,6 +455,23 @@ CREATE TABLE test.t(a INT PRIMARY KEY);\n \tif !testutils.IsError(err, \"table is being deleted\") {\n \t\tt.Fatalf(\"got a different error than expected: %v\", err)\n \t}\n+\n+\t// Check that SHOW TABLES marks a deleted table with the \" (deleted)\"\n+\t// suffix.\n+\trows, err := t.db.Query(`SHOW TABLES FROM test`)","path":"pkg/sql/lease_test.go","position":null,"original_position":17,"commit_id":"4004b49c27b00dc692d2f0170b233b5ef6288c2c","original_commit_id":"41ca15e7f93912f69d99e275e0bf83fc967217e5","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-10-21T19:19:09Z","updated_at":"2016-10-21T19:19:09Z","html_url":"https://github.com/cockroachdb/cockroach/pull/10063#discussion_r84529561","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10063","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/84529561"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/10063#discussion_r84529561"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10063"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10063","id":89889353,"html_url":"https://github.com/cockroachdb/cockroach/pull/10063","diff_url":"https://github.com/cockroachdb/cockroach/pull/10063.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10063.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10063","number":10063,"state":"open","locked":false,"title":"sql: SHOW TABLES marks a deleted table with a \" (deleted)\" suffix","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"body":"fixes #9318\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10063)\n<!-- Reviewable:end -->\n","created_at":"2016-10-18T20:10:38Z","updated_at":"2016-10-21T19:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dff9762ea26491a1e943226eb32476aa77e0bd7b","assignee":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10063/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10063/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10063/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/4004b49c27b00dc692d2f0170b233b5ef6288c2c","head":{"label":"vivekmenezes:showtables","ref":"showtables","sha":"4004b49c27b00dc692d2f0170b233b5ef6288c2c","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"repo":{"id":34078715,"name":"cockroach","full_name":"vivekmenezes/cockroach","owner":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vivekmenezes/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach","forks_url":"https://api.github.com/repos/vivekmenezes/cockroach/forks","keys_url":"https://api.github.com/repos/vivekmenezes/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vivekmenezes/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vivekmenezes/cockroach/teams","hooks_url":"https://api.github.com/repos/vivekmenezes/cockroach/hooks","issue_events_url":"https://api.github.com/repos/vivekmenezes/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/vivekmenezes/cockroach/events","assignees_url":"https://api.github.com/repos/vivekmenezes/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/vivekmenezes/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/vivekmenezes/cockroach/tags","blobs_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vivekmenezes/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/vivekmenezes/cockroach/languages","stargazers_url":"https://api.github.com/repos/vivekmenezes/cockroach/stargazers","contributors_url":"https://api.github.com/repos/vivekmenezes/cockroach/contributors","subscribers_url":"https://api.github.com/repos/vivekmenezes/cockroach/subscribers","subscription_url":"https://api.github.com/repos/vivekmenezes/cockroach/subscription","commits_url":"https://api.github.com/repos/vivekmenezes/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/vivekmenezes/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/vivekmenezes/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/vivekmenezes/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/vivekmenezes/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vivekmenezes/cockroach/merges","archive_url":"https://api.github.com/repos/vivekmenezes/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vivekmenezes/cockroach/downloads","issues_url":"https://api.github.com/repos/vivekmenezes/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/vivekmenezes/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/vivekmenezes/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/vivekmenezes/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vivekmenezes/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/vivekmenezes/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/vivekmenezes/cockroach/deployments","created_at":"2015-04-16T20:25:11Z","updated_at":"2016-01-22T03:53:14Z","pushed_at":"2016-10-21T19:17:11Z","git_url":"git://github.com/vivekmenezes/cockroach.git","ssh_url":"git@github.com:vivekmenezes/cockroach.git","clone_url":"https://github.com/vivekmenezes/cockroach.git","svn_url":"https://github.com/vivekmenezes/cockroach","homepage":null,"size":209089,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"27a643c06213a347e856934f5ed35aeca750fe9f","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-10-21T07:51:11Z","pushed_at":"2016-10-21T19:17:16Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":385674,"stargazers_count":7757,"watchers_count":7757,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":773,"mirror_url":null,"open_issues_count":764,"forks":773,"open_issues":764,"watchers":7757,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10063"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/10063"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/10063"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/10063/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10063/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10063/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/4004b49c27b00dc692d2f0170b233b5ef6288c2c"}}}}
{"actor":{"display_login":"vivekmenezes"}}