{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7564","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7564/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7564/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7564/events","html_url":"https://github.com/nodejs/node/pull/7564","id":164111874,"number":7564,"title":"core: normalize malloc, realloc ","user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2016-07-06T15:59:12Z","updated_at":"2016-10-07T12:11:18Z","closed_at":"2016-09-06T13:52:40Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7564","html_url":"https://github.com/nodejs/node/pull/7564","diff_url":"https://github.com/nodejs/node/pull/7564.diff","patch_url":"https://github.com/nodejs/node/pull/7564.patch"},"body":"<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [X] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ncore\r\n\r\n malloc(0) and realloc(ptr, 0) have implementation-defined behavior in\r\n that the standard allows them to either return a unique pointer or a\r\n nullptr for zero-sized allocation requests.  Normalize by always using\r\n a nullptr.\r\n\r\n    - Introduce node::malloc, node::realloc and node::calloc that should\r\n      be used throught our source.\r\n    - Update all existing node source files to use the new functions\r\n      instead of the native allocation functions.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/252236719","html_url":"https://github.com/nodejs/node/pull/7564#issuecomment-252236719","issue_url":"https://api.github.com/repos/nodejs/node/issues/7564","id":252236719,"user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T12:11:17Z","updated_at":"2016-10-07T12:11:17Z","body":"I don’t think this has to be backported, but if it is, it needs to be backported together with https://github.com/nodejs/node/pull/8572 (and maybe, but not necessarily, https://github.com/nodejs/node/pull/8482)."}}
{"actor":{"display_login":"addaleax"}}