{"action":"created","issue":{"url":"https://api.github.com/repos/obilodeau/tomdroid/issues/74","repository_url":"https://api.github.com/repos/obilodeau/tomdroid","labels_url":"https://api.github.com/repos/obilodeau/tomdroid/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/obilodeau/tomdroid/issues/74/comments","events_url":"https://api.github.com/repos/obilodeau/tomdroid/issues/74/events","html_url":"https://github.com/obilodeau/tomdroid/issues/74","id":172605411,"number":74,"title":"Create a interface for the web synchronization code","user":{"login":"obilodeau","id":546325,"avatar_url":"https://avatars.githubusercontent.com/u/546325?v=3","gravatar_id":"","url":"https://api.github.com/users/obilodeau","html_url":"https://github.com/obilodeau","followers_url":"https://api.github.com/users/obilodeau/followers","following_url":"https://api.github.com/users/obilodeau/following{/other_user}","gists_url":"https://api.github.com/users/obilodeau/gists{/gist_id}","starred_url":"https://api.github.com/users/obilodeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilodeau/subscriptions","organizations_url":"https://api.github.com/users/obilodeau/orgs","repos_url":"https://api.github.com/users/obilodeau/repos","events_url":"https://api.github.com/users/obilodeau/events{/privacy}","received_events_url":"https://api.github.com/users/obilodeau/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/obilodeau/tomdroid/labels/Fix%20Released","name":"Fix Released","color":"ddffdd"},{"url":"https://api.github.com/repos/obilodeau/tomdroid/labels/Medium","name":"Medium","color":"ffdddd"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-23T03:38:13Z","updated_at":"2016-08-23T04:25:46Z","closed_at":null,"body":"The current code doesn't provide many cues about what's happening behind the scenes and may confuse the user. It could use some work in order to be able to tell the user about the state of the authentication/sync.\n\nIt could be divided in two subtasks: \n * The first one is the design of the interface with its flow. I don't think it is a good idea to rush blindly without a bit of prior planning, it requires some thought\n * The second one is some code refactoring to be able to extract useful information about the running sync process (http download progress, etc)"},"comment":{"url":"https://api.github.com/repos/obilodeau/tomdroid/issues/comments/241623399","html_url":"https://github.com/obilodeau/tomdroid/issues/74#issuecomment-241623399","issue_url":"https://api.github.com/repos/obilodeau/tomdroid/issues/74","id":241623399,"user":{"login":"obilodeau","id":546325,"avatar_url":"https://avatars.githubusercontent.com/u/546325?v=3","gravatar_id":"","url":"https://api.github.com/users/obilodeau","html_url":"https://github.com/obilodeau","followers_url":"https://api.github.com/users/obilodeau/followers","following_url":"https://api.github.com/users/obilodeau/following{/other_user}","gists_url":"https://api.github.com/users/obilodeau/gists{/gist_id}","starred_url":"https://api.github.com/users/obilodeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilodeau/subscriptions","organizations_url":"https://api.github.com/users/obilodeau/orgs","repos_url":"https://api.github.com/users/obilodeau/repos","events_url":"https://api.github.com/users/obilodeau/events{/privacy}","received_events_url":"https://api.github.com/users/obilodeau/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T04:25:46Z","updated_at":"2016-08-23T04:25:46Z","body":"(by benoit.garret)\nMuch better, I can now at least see that something is happening.\n\nI took a quick look at your animation code, but couldn't spot any obvious mistake. I'm afraid I won't be of much help here.\n\n\nI'm against removing the sync menu icon for two reasons:\n\n * Your bar is only actionable through a touchscreen. My understanding is that it's important for accessibility reasons that the sync can be initiated by a hardware key. I'm not a usability or accessibility expert, if any lurker has experience in any of those fields, their opinion will be much appreciated.\n\n * I prefer to follow the guidelines and tools provided by Google concerning interface design, there's a whole chapter on the development guide dedicated to them.\n\nFeel free to disagree though ;-) . I may not have completely understood your reasons and I would gladly be proven wrong.\n\n\nOne last thing, I'm curious about the reasons that led you to use a custom notification. There are at least two feedback mechanisms that are already implemented by system applications:\n\n * Use the progress bar in the window title : http://developer.android.com/guide/appendix/faq/commontasks.html#progressbar . It is already used by the web browser and looks like super easy to implement.\n\n * Use a status bar notification: http://developer.android.com/guide/topics/ui/notifiers/notifications.html . Something along the lines of what the market app does, it requires a bit more work than the previous one but has the advantage of notifying the user even when the application is hidden.\n\n\nI'm not trying to downplay your work, I'm really, really glad that you stepped up to get in charge of this. I'm just trying to get an understanding of the reasons that led you to your UI choices.\n\n"}}
{"actor":{"display_login":"obilodeau"}}