{"action":"created","comment":{"url":"https://api.github.com/repos/MariaDB/server/pulls/comments/71072748","id":71072748,"diff_hunk":"@@ -317,7 +317,8 @@ END\n our $opt_valgrind= 0;\n my $opt_valgrind_mysqld= 0;\n my $opt_valgrind_mysqltest= 0;\n-my @default_valgrind_args= (\"--show-reachable=yes\");\n+my @default_memcheck_valgrind_args= (\"--show-reachable=yes\",","path":"mysql-test/mysql-test-run.pl","position":5,"original_position":5,"commit_id":"ad7ccd305416781edbc6e2b7ade21cc560127ac0","original_commit_id":"ad7ccd305416781edbc6e2b7ade21cc560127ac0","user":{"login":"elenst","id":6138162,"avatar_url":"https://avatars.githubusercontent.com/u/6138162?v=3","gravatar_id":"","url":"https://api.github.com/users/elenst","html_url":"https://github.com/elenst","followers_url":"https://api.github.com/users/elenst/followers","following_url":"https://api.github.com/users/elenst/following{/other_user}","gists_url":"https://api.github.com/users/elenst/gists{/gist_id}","starred_url":"https://api.github.com/users/elenst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elenst/subscriptions","organizations_url":"https://api.github.com/users/elenst/orgs","repos_url":"https://api.github.com/users/elenst/repos","events_url":"https://api.github.com/users/elenst/events{/privacy}","received_events_url":"https://api.github.com/users/elenst/received_events","type":"User","site_admin":false},"body":"We don't really need it here at all, why not just add the options along with --tool=memcheck?","created_at":"2016-07-16T22:24:41Z","updated_at":"2016-07-16T22:24:41Z","html_url":"https://github.com/MariaDB/server/pull/200#discussion_r71072748","pull_request_url":"https://api.github.com/repos/MariaDB/server/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments/71072748"},"html":{"href":"https://github.com/MariaDB/server/pull/200#discussion_r71072748"},"pull_request":{"href":"https://api.github.com/repos/MariaDB/server/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/MariaDB/server/pulls/200","id":76374826,"html_url":"https://github.com/MariaDB/server/pull/200","diff_url":"https://github.com/MariaDB/server/pull/200.diff","patch_url":"https://github.com/MariaDB/server/pull/200.patch","issue_url":"https://api.github.com/repos/MariaDB/server/issues/200","number":200,"state":"open","locked":false,"title":"MDEV-10294: MTR using --valgrind-option to specify a tool / fixing callgrind [10.1]","user":{"login":"grooverdan","id":462287,"avatar_url":"https://avatars.githubusercontent.com/u/462287?v=3","gravatar_id":"","url":"https://api.github.com/users/grooverdan","html_url":"https://github.com/grooverdan","followers_url":"https://api.github.com/users/grooverdan/followers","following_url":"https://api.github.com/users/grooverdan/following{/other_user}","gists_url":"https://api.github.com/users/grooverdan/gists{/gist_id}","starred_url":"https://api.github.com/users/grooverdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grooverdan/subscriptions","organizations_url":"https://api.github.com/users/grooverdan/orgs","repos_url":"https://api.github.com/users/grooverdan/repos","events_url":"https://api.github.com/users/grooverdan/events{/privacy}","received_events_url":"https://api.github.com/users/grooverdan/received_events","type":"User","site_admin":false},"body":"Based off #194 feedback. Thanks @elenst \r\n\r\nfixed --callgrind by removing --base\r\n\r\ncloses #194\r\n\r\nI submit this under the MCA.","created_at":"2016-07-06T03:37:16Z","updated_at":"2016-07-16T22:24:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c2c83a70e25da36119b90908cea68ac9a779d58","assignee":{"login":"elenst","id":6138162,"avatar_url":"https://avatars.githubusercontent.com/u/6138162?v=3","gravatar_id":"","url":"https://api.github.com/users/elenst","html_url":"https://github.com/elenst","followers_url":"https://api.github.com/users/elenst/followers","following_url":"https://api.github.com/users/elenst/following{/other_user}","gists_url":"https://api.github.com/users/elenst/gists{/gist_id}","starred_url":"https://api.github.com/users/elenst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elenst/subscriptions","organizations_url":"https://api.github.com/users/elenst/orgs","repos_url":"https://api.github.com/users/elenst/repos","events_url":"https://api.github.com/users/elenst/events{/privacy}","received_events_url":"https://api.github.com/users/elenst/received_events","type":"User","site_admin":false},"assignees":[{"login":"elenst","id":6138162,"avatar_url":"https://avatars.githubusercontent.com/u/6138162?v=3","gravatar_id":"","url":"https://api.github.com/users/elenst","html_url":"https://github.com/elenst","followers_url":"https://api.github.com/users/elenst/followers","following_url":"https://api.github.com/users/elenst/following{/other_user}","gists_url":"https://api.github.com/users/elenst/gists{/gist_id}","starred_url":"https://api.github.com/users/elenst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elenst/subscriptions","organizations_url":"https://api.github.com/users/elenst/orgs","repos_url":"https://api.github.com/users/elenst/repos","events_url":"https://api.github.com/users/elenst/events{/privacy}","received_events_url":"https://api.github.com/users/elenst/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MariaDB/server/pulls/200/commits","review_comments_url":"https://api.github.com/repos/MariaDB/server/pulls/200/comments","review_comment_url":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MariaDB/server/issues/200/comments","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/ad7ccd305416781edbc6e2b7ade21cc560127ac0","head":{"label":"grooverdan:10.1-valgrind-v2","ref":"10.1-valgrind-v2","sha":"ad7ccd305416781edbc6e2b7ade21cc560127ac0","user":{"login":"grooverdan","id":462287,"avatar_url":"https://avatars.githubusercontent.com/u/462287?v=3","gravatar_id":"","url":"https://api.github.com/users/grooverdan","html_url":"https://github.com/grooverdan","followers_url":"https://api.github.com/users/grooverdan/followers","following_url":"https://api.github.com/users/grooverdan/following{/other_user}","gists_url":"https://api.github.com/users/grooverdan/gists{/gist_id}","starred_url":"https://api.github.com/users/grooverdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grooverdan/subscriptions","organizations_url":"https://api.github.com/users/grooverdan/orgs","repos_url":"https://api.github.com/users/grooverdan/repos","events_url":"https://api.github.com/users/grooverdan/events{/privacy}","received_events_url":"https://api.github.com/users/grooverdan/received_events","type":"User","site_admin":false},"repo":{"id":46755224,"name":"mariadb-server","full_name":"grooverdan/mariadb-server","owner":{"login":"grooverdan","id":462287,"avatar_url":"https://avatars.githubusercontent.com/u/462287?v=3","gravatar_id":"","url":"https://api.github.com/users/grooverdan","html_url":"https://github.com/grooverdan","followers_url":"https://api.github.com/users/grooverdan/followers","following_url":"https://api.github.com/users/grooverdan/following{/other_user}","gists_url":"https://api.github.com/users/grooverdan/gists{/gist_id}","starred_url":"https://api.github.com/users/grooverdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grooverdan/subscriptions","organizations_url":"https://api.github.com/users/grooverdan/orgs","repos_url":"https://api.github.com/users/grooverdan/repos","events_url":"https://api.github.com/users/grooverdan/events{/privacy}","received_events_url":"https://api.github.com/users/grooverdan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grooverdan/mariadb-server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":true,"url":"https://api.github.com/repos/grooverdan/mariadb-server","forks_url":"https://api.github.com/repos/grooverdan/mariadb-server/forks","keys_url":"https://api.github.com/repos/grooverdan/mariadb-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grooverdan/mariadb-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grooverdan/mariadb-server/teams","hooks_url":"https://api.github.com/repos/grooverdan/mariadb-server/hooks","issue_events_url":"https://api.github.com/repos/grooverdan/mariadb-server/issues/events{/number}","events_url":"https://api.github.com/repos/grooverdan/mariadb-server/events","assignees_url":"https://api.github.com/repos/grooverdan/mariadb-server/assignees{/user}","branches_url":"https://api.github.com/repos/grooverdan/mariadb-server/branches{/branch}","tags_url":"https://api.github.com/repos/grooverdan/mariadb-server/tags","blobs_url":"https://api.github.com/repos/grooverdan/mariadb-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grooverdan/mariadb-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grooverdan/mariadb-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/grooverdan/mariadb-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grooverdan/mariadb-server/statuses/{sha}","languages_url":"https://api.github.com/repos/grooverdan/mariadb-server/languages","stargazers_url":"https://api.github.com/repos/grooverdan/mariadb-server/stargazers","contributors_url":"https://api.github.com/repos/grooverdan/mariadb-server/contributors","subscribers_url":"https://api.github.com/repos/grooverdan/mariadb-server/subscribers","subscription_url":"https://api.github.com/repos/grooverdan/mariadb-server/subscription","commits_url":"https://api.github.com/repos/grooverdan/mariadb-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/grooverdan/mariadb-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/grooverdan/mariadb-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/grooverdan/mariadb-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/grooverdan/mariadb-server/contents/{+path}","compare_url":"https://api.github.com/repos/grooverdan/mariadb-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grooverdan/mariadb-server/merges","archive_url":"https://api.github.com/repos/grooverdan/mariadb-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grooverdan/mariadb-server/downloads","issues_url":"https://api.github.com/repos/grooverdan/mariadb-server/issues{/number}","pulls_url":"https://api.github.com/repos/grooverdan/mariadb-server/pulls{/number}","milestones_url":"https://api.github.com/repos/grooverdan/mariadb-server/milestones{/number}","notifications_url":"https://api.github.com/repos/grooverdan/mariadb-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grooverdan/mariadb-server/labels{/name}","releases_url":"https://api.github.com/repos/grooverdan/mariadb-server/releases{/id}","deployments_url":"https://api.github.com/repos/grooverdan/mariadb-server/deployments","created_at":"2015-11-23T23:46:42Z","updated_at":"2016-01-28T06:41:37Z","pushed_at":"2016-07-06T03:34:39Z","git_url":"git://github.com/grooverdan/mariadb-server.git","ssh_url":"git@github.com:grooverdan/mariadb-server.git","clone_url":"https://github.com/grooverdan/mariadb-server.git","svn_url":"https://github.com/grooverdan/mariadb-server","homepage":"","size":472414,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.1"}},"base":{"label":"MariaDB:10.1","ref":"10.1","sha":"95c286cedf4b9330240a0a91a9fc3e58a17782b9","user":{"login":"MariaDB","id":4739304,"avatar_url":"https://avatars.githubusercontent.com/u/4739304?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"repo":{"id":19816070,"name":"server","full_name":"MariaDB/server","owner":{"login":"MariaDB","id":4739304,"avatar_url":"https://avatars.githubusercontent.com/u/4739304?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MariaDB/server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":false,"url":"https://api.github.com/repos/MariaDB/server","forks_url":"https://api.github.com/repos/MariaDB/server/forks","keys_url":"https://api.github.com/repos/MariaDB/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MariaDB/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MariaDB/server/teams","hooks_url":"https://api.github.com/repos/MariaDB/server/hooks","issue_events_url":"https://api.github.com/repos/MariaDB/server/issues/events{/number}","events_url":"https://api.github.com/repos/MariaDB/server/events","assignees_url":"https://api.github.com/repos/MariaDB/server/assignees{/user}","branches_url":"https://api.github.com/repos/MariaDB/server/branches{/branch}","tags_url":"https://api.github.com/repos/MariaDB/server/tags","blobs_url":"https://api.github.com/repos/MariaDB/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MariaDB/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MariaDB/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/MariaDB/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/{sha}","languages_url":"https://api.github.com/repos/MariaDB/server/languages","stargazers_url":"https://api.github.com/repos/MariaDB/server/stargazers","contributors_url":"https://api.github.com/repos/MariaDB/server/contributors","subscribers_url":"https://api.github.com/repos/MariaDB/server/subscribers","subscription_url":"https://api.github.com/repos/MariaDB/server/subscription","commits_url":"https://api.github.com/repos/MariaDB/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/MariaDB/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/MariaDB/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/MariaDB/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/MariaDB/server/contents/{+path}","compare_url":"https://api.github.com/repos/MariaDB/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MariaDB/server/merges","archive_url":"https://api.github.com/repos/MariaDB/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MariaDB/server/downloads","issues_url":"https://api.github.com/repos/MariaDB/server/issues{/number}","pulls_url":"https://api.github.com/repos/MariaDB/server/pulls{/number}","milestones_url":"https://api.github.com/repos/MariaDB/server/milestones{/number}","notifications_url":"https://api.github.com/repos/MariaDB/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MariaDB/server/labels{/name}","releases_url":"https://api.github.com/repos/MariaDB/server/releases{/id}","deployments_url":"https://api.github.com/repos/MariaDB/server/deployments","created_at":"2014-05-15T10:58:50Z","updated_at":"2016-07-16T18:03:08Z","pushed_at":"2016-07-16T21:42:20Z","git_url":"git://github.com/MariaDB/server.git","ssh_url":"git@github.com:MariaDB/server.git","clone_url":"https://github.com/MariaDB/server.git","svn_url":"https://github.com/MariaDB/server","homepage":"","size":1069923,"stargazers_count":917,"watchers_count":917,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":308,"mirror_url":null,"open_issues_count":22,"forks":308,"open_issues":22,"watchers":917,"default_branch":"10.1"}},"_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/200"},"html":{"href":"https://github.com/MariaDB/server/pull/200"},"issue":{"href":"https://api.github.com/repos/MariaDB/server/issues/200"},"comments":{"href":"https://api.github.com/repos/MariaDB/server/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/MariaDB/server/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MariaDB/server/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/MariaDB/server/statuses/ad7ccd305416781edbc6e2b7ade21cc560127ac0"}}}}
{"actor":{"display_login":"elenst"}}