{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1374","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1374/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1374/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1374/events","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1374","id":159695313,"number":1374,"title":"logging: support native types","user":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/labels/logging","name":"logging","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-06-10T18:34:59Z","updated_at":"2016-06-21T23:24:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1374","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1374","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1374.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1374.patch"},"body":"Fixes #1352\r\n\r\n#### To Dos\r\n\r\n- [ ] Docs\r\n- [ ] Tests\r\n  - [x] System\r\n  - [ ] Unit\r\n\r\nWhen writing a log entry, this will stringify Date, Error, and regex types... or more accurately, anything given will be passed to `String(value)`.\r\n\r\nAlso, this adds a change that will take a raw \"LogEntry\" from \"ListLogEntries()\" and convert the verbose protobuf object into a normal JS object. (See `{module:grpc-service#structToObj_}` and `{module:grpc-service#decodeValue_}`)"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/comments/227601732","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1374#issuecomment-227601732","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1374","id":227601732,"user":{"login":"zbjornson","id":469365,"avatar_url":"https://avatars.githubusercontent.com/u/469365?v=3","gravatar_id":"","url":"https://api.github.com/users/zbjornson","html_url":"https://github.com/zbjornson","followers_url":"https://api.github.com/users/zbjornson/followers","following_url":"https://api.github.com/users/zbjornson/following{/other_user}","gists_url":"https://api.github.com/users/zbjornson/gists{/gist_id}","starred_url":"https://api.github.com/users/zbjornson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbjornson/subscriptions","organizations_url":"https://api.github.com/users/zbjornson/orgs","repos_url":"https://api.github.com/users/zbjornson/repos","events_url":"https://api.github.com/users/zbjornson/events{/privacy}","received_events_url":"https://api.github.com/users/zbjornson/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T23:24:51Z","updated_at":"2016-06-21T23:24:51Z","body":"> Since timestamp representation is just a string, we wouldn't be able to tell what type the given field should be.\r\n\r\nI was looking at this bit that is removed in this PR:\r\n```diff\r\n-      timestampValue: {\r\n-        seconds: secondsRounded,\r\n-        nanos: Math.floor((seconds - secondsRounded) * 1e9)\r\n-      }\r\n```\r\nwhich matches up with the [Timestamp proto](https://github.com/google/protobuf/blob/master/src/google/protobuf/timestamp.proto). It seems like it should be possible to send that timestampValue object and convert back server-side regardless of whether jsonPayload or protoPayload is used? */me doesn't know how the server-side works*"}}
{"actor":{"display_login":"zbjornson"}}