{"action":"created","issue":{"url":"https://api.github.com/repos/textmate/ruby.tmbundle/issues/104","repository_url":"https://api.github.com/repos/textmate/ruby.tmbundle","labels_url":"https://api.github.com/repos/textmate/ruby.tmbundle/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/textmate/ruby.tmbundle/issues/104/comments","events_url":"https://api.github.com/repos/textmate/ruby.tmbundle/issues/104/events","html_url":"https://github.com/textmate/ruby.tmbundle/pull/104","id":172265297,"number":104,"title":"Implement `RubyUtils.find_executable`.","user":{"login":"noniq","id":244158,"avatar_url":"https://avatars.githubusercontent.com/u/244158?v=3","gravatar_id":"","url":"https://api.github.com/users/noniq","html_url":"https://github.com/noniq","followers_url":"https://api.github.com/users/noniq/followers","following_url":"https://api.github.com/users/noniq/following{/other_user}","gists_url":"https://api.github.com/users/noniq/gists{/gist_id}","starred_url":"https://api.github.com/users/noniq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noniq/subscriptions","organizations_url":"https://api.github.com/users/noniq/orgs","repos_url":"https://api.github.com/users/noniq/repos","events_url":"https://api.github.com/users/noniq/events{/privacy}","received_events_url":"https://api.github.com/users/noniq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-08-20T10:43:21Z","updated_at":"2016-08-30T09:18:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/textmate/ruby.tmbundle/pulls/104","html_url":"https://github.com/textmate/ruby.tmbundle/pull/104","diff_url":"https://github.com/textmate/ruby.tmbundle/pull/104.diff","patch_url":"https://github.com/textmate/ruby.tmbundle/pull/104.patch"},"body":"First try on implementing #102. Not sure about the module name `RubyUtils`, though – happy to take suggestions for alternative names!\r\n\r\nTODO: Do we need to do something special to support RVM?\r\n"},"comment":{"url":"https://api.github.com/repos/textmate/ruby.tmbundle/issues/comments/243381516","html_url":"https://github.com/textmate/ruby.tmbundle/pull/104#issuecomment-243381516","issue_url":"https://api.github.com/repos/textmate/ruby.tmbundle/issues/104","id":243381516,"user":{"login":"jacob-carlborg","id":306980,"avatar_url":"https://avatars.githubusercontent.com/u/306980?v=3","gravatar_id":"","url":"https://api.github.com/users/jacob-carlborg","html_url":"https://github.com/jacob-carlborg","followers_url":"https://api.github.com/users/jacob-carlborg/followers","following_url":"https://api.github.com/users/jacob-carlborg/following{/other_user}","gists_url":"https://api.github.com/users/jacob-carlborg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob-carlborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob-carlborg/subscriptions","organizations_url":"https://api.github.com/users/jacob-carlborg/orgs","repos_url":"https://api.github.com/users/jacob-carlborg/repos","events_url":"https://api.github.com/users/jacob-carlborg/events{/privacy}","received_events_url":"https://api.github.com/users/jacob-carlborg/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T09:18:11Z","updated_at":"2016-08-30T09:18:11Z","body":"> In .tm_properties you can presently do this:\r\nFOO = 'no-make'\r\n[ attr.project.make ]\r\nFOO = \"make\"\r\nNow try echo $FOO in a document in a project with a Makefile and one without, and you’ll see different values.\r\n\r\nHmm, then I would need to set something like `TM_RUBOCOP = 'bundle exec rubocop'`, which is not compatible with the current code in this PR, `File.executable?(ENV[env_var])`. I'm also not sure if the system will interpret the whole `bundle exec rubocop` as one single command or as one command with two arguments.\r\n\r\n> For example is it unthinkable that user has a project being run both in Vagrant and on macOS, the Gemfile.lock file would be shared between the two, but something could prevent it from executing w/o issues on the Mac?\r\n\r\nThat's a possibility. I would say that the Gemfile is broken in that case.\r\n\r\n> So I’d rather ask you, why do you set an environment variable for a fallback option instead of adding the location of the fallback executable to PATH?\r\n\r\nI don't know. Maybe because the documentation for most bundles say that the `TM_...` environment variable should be set."}}
{"actor":{"display_login":"jacob-carlborg"}}