{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/67242261","id":67242261,"diff_hunk":"@@ -174,19 +174,21 @@ con_helper_thread_proc2(OMRPortLibrary* portLib, void *info)\n } /* extern \"C\" */\n \n void\n-MM_ConcurrentGC::reportGCCycleStart(MM_EnvironmentStandard *env)\n+MM_ConcurrentGC::reportGCCycleStart(MM_EnvironmentBase *env)\n {\n \t/* TODO CRGTMP - Temporarily move this code to the point when\n \t * we have exclusiveVMAccess so that GC check works.  Move it back\n \t * once we complete JAZZ 33760.\n \t */\n+\tMM_CycleState *previousCycleState = env->_cycleState;\n+\n \t_concurrentCycleState = MM_CycleState();\n \tenv->_cycleState = &_concurrentCycleState;\n \tenv->_cycleState->_type = _cycleType;\n \n \tMM_ParallelGlobalGC::reportGCCycleStart(env);\n \n-\tenv->_cycleState = NULL;\n+\tenv->_cycleState = previousCycleState;","path":"gc/base/standard/ConcurrentGC.cpp","position":29,"original_position":29,"commit_id":"f5a8e2a0395961a69f0a3ba4351d7ec56f80bf73","original_commit_id":"f5a8e2a0395961a69f0a3ba4351d7ec56f80bf73","user":{"login":"ktbriggs","id":18146124,"avatar_url":"https://avatars.githubusercontent.com/u/18146124?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbriggs","html_url":"https://github.com/ktbriggs","followers_url":"https://api.github.com/users/ktbriggs/followers","following_url":"https://api.github.com/users/ktbriggs/following{/other_user}","gists_url":"https://api.github.com/users/ktbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbriggs/subscriptions","organizations_url":"https://api.github.com/users/ktbriggs/orgs","repos_url":"https://api.github.com/users/ktbriggs/repos","events_url":"https://api.github.com/users/ktbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/ktbriggs/received_events","type":"User","site_admin":false},"body":"This was an odd fix. Without it, a segfault will occur when MM_ParallelGlobalGC::reportGCStart() references env->_cycleState when it is called from MM_ParallelGlobalGC::internalPreCollect() after calling this method (MM_ConcurrentGC::reportGCCycleStart()). MM_ConcurrentGC also calls reportGCCycleStart() when it kicks off card cleaning -- in that case I reset env->_cycleState to NULL after the call.","created_at":"2016-06-15T20:45:50Z","updated_at":"2016-06-15T20:45:50Z","html_url":"https://github.com/eclipse/omr/pull/140#discussion_r67242261","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/67242261"},"html":{"href":"https://github.com/eclipse/omr/pull/140#discussion_r67242261"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/140","id":73811567,"html_url":"https://github.com/eclipse/omr/pull/140","diff_url":"https://github.com/eclipse/omr/pull/140.diff","patch_url":"https://github.com/eclipse/omr/pull/140.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/140","number":140,"state":"open","locked":false,"title":"FIX #127: Remove MM_ScanClassesMode and dependencies from OMR","user":{"login":"ktbriggs","id":18146124,"avatar_url":"https://avatars.githubusercontent.com/u/18146124?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbriggs","html_url":"https://github.com/ktbriggs","followers_url":"https://api.github.com/users/ktbriggs/followers","following_url":"https://api.github.com/users/ktbriggs/following{/other_user}","gists_url":"https://api.github.com/users/ktbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbriggs/subscriptions","organizations_url":"https://api.github.com/users/ktbriggs/orgs","repos_url":"https://api.github.com/users/ktbriggs/repos","events_url":"https://api.github.com/users/ktbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/ktbriggs/received_events","type":"User","site_admin":false},"body":"New CollectorLanguageInterface methods for ConcurrentGC:\r\nconcurrentGC_concurrentInitializationComplete(..)\r\nconcurrentGC_kickoffCardCleaning(..)\r\nconcurrentGC_startConcurrentScanning(..)\r\nconcurrentGC_concurrentScanningStarted(..)\r\nconcurrentGC_isConcurrentScanningComplete(..)\r\nconcurrentGC_reportConcurrentScanningMode(..)\r\nProvided Java-side implementations for these, stub implementations for\r\nomr example and glue code; OMR_GC_MODRON_CONCURRRENT_MARK enabled\r\nfor example/glue but ConcurrentGC not fully integrated with example/glue\r\nyet.\r\n\r\nMoved all references to MM_ScanClassesMode (class) and\r\nJ9VM_GC_DYNAMIC_CLASS_UNLOADING (build flag) out of OMR source code.\r\n\r\nCleaned up some logic in MM_ConcurrentGC::concurrentMark() (was not\r\nflushing local buffers if interrupted by another thread requesting VM\r\naccess).\r\n\r\nSigned-off-by: Kim Briggs <briggs@ca.ibm.com>","created_at":"2016-06-14T20:52:22Z","updated_at":"2016-06-15T20:45:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42ad96927ac3d2c0a7b78a60dd4958be372a5057","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/140/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/140/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/140/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/f5a8e2a0395961a69f0a3ba4351d7ec56f80bf73","head":{"label":"ktbriggs:omr-issue-127","ref":"omr-issue-127","sha":"f5a8e2a0395961a69f0a3ba4351d7ec56f80bf73","user":{"login":"ktbriggs","id":18146124,"avatar_url":"https://avatars.githubusercontent.com/u/18146124?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbriggs","html_url":"https://github.com/ktbriggs","followers_url":"https://api.github.com/users/ktbriggs/followers","following_url":"https://api.github.com/users/ktbriggs/following{/other_user}","gists_url":"https://api.github.com/users/ktbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbriggs/subscriptions","organizations_url":"https://api.github.com/users/ktbriggs/orgs","repos_url":"https://api.github.com/users/ktbriggs/repos","events_url":"https://api.github.com/users/ktbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/ktbriggs/received_events","type":"User","site_admin":false},"repo":{"id":55006666,"name":"omr","full_name":"ktbriggs/omr","owner":{"login":"ktbriggs","id":18146124,"avatar_url":"https://avatars.githubusercontent.com/u/18146124?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbriggs","html_url":"https://github.com/ktbriggs","followers_url":"https://api.github.com/users/ktbriggs/followers","following_url":"https://api.github.com/users/ktbriggs/following{/other_user}","gists_url":"https://api.github.com/users/ktbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbriggs/subscriptions","organizations_url":"https://api.github.com/users/ktbriggs/orgs","repos_url":"https://api.github.com/users/ktbriggs/repos","events_url":"https://api.github.com/users/ktbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/ktbriggs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktbriggs/omr","description":"OMR project","fork":true,"url":"https://api.github.com/repos/ktbriggs/omr","forks_url":"https://api.github.com/repos/ktbriggs/omr/forks","keys_url":"https://api.github.com/repos/ktbriggs/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktbriggs/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktbriggs/omr/teams","hooks_url":"https://api.github.com/repos/ktbriggs/omr/hooks","issue_events_url":"https://api.github.com/repos/ktbriggs/omr/issues/events{/number}","events_url":"https://api.github.com/repos/ktbriggs/omr/events","assignees_url":"https://api.github.com/repos/ktbriggs/omr/assignees{/user}","branches_url":"https://api.github.com/repos/ktbriggs/omr/branches{/branch}","tags_url":"https://api.github.com/repos/ktbriggs/omr/tags","blobs_url":"https://api.github.com/repos/ktbriggs/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktbriggs/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktbriggs/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktbriggs/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktbriggs/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/ktbriggs/omr/languages","stargazers_url":"https://api.github.com/repos/ktbriggs/omr/stargazers","contributors_url":"https://api.github.com/repos/ktbriggs/omr/contributors","subscribers_url":"https://api.github.com/repos/ktbriggs/omr/subscribers","subscription_url":"https://api.github.com/repos/ktbriggs/omr/subscription","commits_url":"https://api.github.com/repos/ktbriggs/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktbriggs/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktbriggs/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktbriggs/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktbriggs/omr/contents/{+path}","compare_url":"https://api.github.com/repos/ktbriggs/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktbriggs/omr/merges","archive_url":"https://api.github.com/repos/ktbriggs/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktbriggs/omr/downloads","issues_url":"https://api.github.com/repos/ktbriggs/omr/issues{/number}","pulls_url":"https://api.github.com/repos/ktbriggs/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/ktbriggs/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/ktbriggs/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktbriggs/omr/labels{/name}","releases_url":"https://api.github.com/repos/ktbriggs/omr/releases{/id}","deployments_url":"https://api.github.com/repos/ktbriggs/omr/deployments","created_at":"2016-03-29T19:59:58Z","updated_at":"2016-03-29T20:00:02Z","pushed_at":"2016-06-14T20:29:22Z","git_url":"git://github.com/ktbriggs/omr.git","ssh_url":"git@github.com:ktbriggs/omr.git","clone_url":"https://github.com/ktbriggs/omr.git","svn_url":"https://github.com/ktbriggs/omr","homepage":null,"size":3733,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"fcf61f9eb80734f054fbb2675d0a192d457b91cb","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"OMR project","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2016-06-02T04:31:13Z","pushed_at":"2016-06-15T14:06:15Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":null,"size":5604,"stargazers_count":163,"watchers_count":163,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":26,"forks":47,"open_issues":26,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/140"},"html":{"href":"https://github.com/eclipse/omr/pull/140"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/140"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/f5a8e2a0395961a69f0a3ba4351d7ec56f80bf73"}}}}
{"actor":{"display_login":"ktbriggs"}}