{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/81003763","pull_request_review_id":2016738,"id":81003763,"diff_hunk":"@@ -343,48 +352,77 @@ func (c Config) New() (*GenericAPIServer, error) {\n \t}\n \n \ts.installAPI(&c)\n-\ts.Handler, s.InsecureHandler = s.buildHandlerChains(&c, http.Handler(s.Mux.BaseMux().(*http.ServeMux)))\n+\n+\t// Wire the handler chain:\n+\t// - requests from InsecureHandler are marked with skipAuth in the context\n+\t// - requests first go through UnprotectedContainer\n+\t// - if no route matches:\n+\t//   * if skipAuth is found in the context, the request goes directly to the ProtectedContainer\n+\t//   * if skipAuth is not found in the context, the request goes through authn/authz and then\n+\t//     to the ProtectedContainer\n+\tprotectedHandler := c.ProtectHandlerFunc(s.ProtectedContainer.ServeMux, &c)\n+\ts.UnprotectedContainer.ServeMux.HandleFunc(\"/\", func(w http.ResponseWriter, req *http.Request) {\n+\t\tctx, ok := c.RequestContextMapper.Get(req)\n+\t\tif !ok {\n+\t\t\tinternalError(w, req, errors.New(\"No context found for request\"))\n+\t\t\treturn\n+\t\t}\n+\t\tif skipAuthFrom(ctx) {\n+\t\t\ts.ProtectedContainer.ServeHTTP(w, req)\n+\t\t} else {\n+\t\t\tprotectedHandler.ServeHTTP(w, req)\n+\t\t}\n+\t})\n+\ts.Handler = c.GenericDecorateHandlerFunc(s.UnprotectedContainer.ServeMux, &c)\n+\ts.InsecureHandler = c.GenericDecorateHandlerFunc(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {\n+\t\tctx, ok := c.RequestContextMapper.Get(req)\n+\t\tif !ok {\n+\t\t\tinternalError(w, req, errors.New(\"No context found for request\"))\n+\t\t\treturn\n+\t\t}\n+\t\tc.RequestContextMapper.Update(req, withSkipAuth(ctx))\n+\t\ts.UnprotectedContainer.ServeHTTP(w, req)\n+\t}), &c)\n \n \treturn s, nil\n }\n \n-func (s *GenericAPIServer) buildHandlerChains(c *Config, handler http.Handler) (secure http.Handler, insecure http.Handler) {","path":"pkg/genericapiserver/config.go","position":145,"original_position":145,"commit_id":"843b1b7f2f5486c1028e7632b0d72cdd04ff4b22","original_commit_id":"843b1b7f2f5486c1028e7632b0d72cdd04ff4b22","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"We can discuss whether we really need that downstream: https://github.com/openshift/origin/blob/19ffc82547b383a5811fa7fd9b0990f44647925a/pkg/cmd/server/origin/master.go","created_at":"2016-09-28T19:58:19Z","updated_at":"2016-09-28T19:58:19Z","html_url":"https://github.com/kubernetes/kubernetes/pull/33662#discussion_r81003763","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33662","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/81003763"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33662#discussion_r81003763"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33662"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33662","id":87135525,"html_url":"https://github.com/kubernetes/kubernetes/pull/33662","diff_url":"https://github.com/kubernetes/kubernetes/pull/33662.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33662.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33662","number":33662,"state":"open","locked":false,"title":"genericapiserver: customizable handler chain and protected-vs-unprotected handler distinction","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"**Based on https://github.com/kubernetes/kubernetes/pull/33490**\r\n\r\n- allow handler chain customization through `Config.ProtectHandlerFunc` and `Config.GenericDecorateHandlerFunc`\r\n- remove `GenericApiServer.Mux`\r\n- replace `GenericApiServer.HandlerContainer` with `ProtectedContainer` and `UnprotectedContainer` (without authz/authn), needed by downstream\r\n- abstract container-vs-nonswagger-secret routes in `pkg/genericapiserver/mux.APIContainer`\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/33662)\n<!-- Reviewable:end -->\n","created_at":"2016-09-28T14:49:37Z","updated_at":"2016-09-28T19:58:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"813baf5108cdc8212056490521c4e3b23da97e95","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33662/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33662/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33662/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/843b1b7f2f5486c1028e7632b0d72cdd04ff4b22","head":{"label":"sttts:sttts-customizable-handler-chain","ref":"sttts-customizable-handler-chain","sha":"843b1b7f2f5486c1028e7632b0d72cdd04ff4b22","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"repo":{"id":36099048,"name":"kubernetes","full_name":"sttts/kubernetes","owner":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sttts/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/sttts/kubernetes","forks_url":"https://api.github.com/repos/sttts/kubernetes/forks","keys_url":"https://api.github.com/repos/sttts/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttts/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttts/kubernetes/teams","hooks_url":"https://api.github.com/repos/sttts/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sttts/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sttts/kubernetes/events","assignees_url":"https://api.github.com/repos/sttts/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sttts/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sttts/kubernetes/tags","blobs_url":"https://api.github.com/repos/sttts/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttts/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttts/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttts/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttts/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sttts/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sttts/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sttts/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sttts/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sttts/kubernetes/subscription","commits_url":"https://api.github.com/repos/sttts/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttts/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttts/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttts/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttts/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sttts/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttts/kubernetes/merges","archive_url":"https://api.github.com/repos/sttts/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttts/kubernetes/downloads","issues_url":"https://api.github.com/repos/sttts/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sttts/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sttts/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sttts/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttts/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sttts/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/sttts/kubernetes/deployments","created_at":"2015-05-22T23:09:55Z","updated_at":"2015-05-22T23:10:00Z","pushed_at":"2016-09-28T19:10:05Z","git_url":"git://github.com/sttts/kubernetes.git","ssh_url":"git@github.com:sttts/kubernetes.git","clone_url":"https://github.com/sttts/kubernetes.git","svn_url":"https://github.com/sttts/kubernetes","homepage":null,"size":323276,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c0826a2e7e9532da91c468dceb83790491f9f8e0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-28T18:37:26Z","pushed_at":"2016-09-28T19:38:29Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":573220,"stargazers_count":17154,"watchers_count":17154,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5559,"mirror_url":null,"open_issues_count":4659,"forks":5559,"open_issues":4659,"watchers":17154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33662"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33662"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33662"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33662/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33662/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33662/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/843b1b7f2f5486c1028e7632b0d72cdd04ff4b22"}}}}
{"actor":{"display_login":"sttts"}}