{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/7464","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/7464/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/7464/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/7464/events","html_url":"https://github.com/elastic/kibana/pull/7464","id":160392961,"number":7464,"title":"Added option to display 'Others' buckets in the pie chart","user":{"login":"FlorianLiers","id":2843045,"avatar_url":"https://avatars.githubusercontent.com/u/2843045?v=3","gravatar_id":"","url":"https://api.github.com/users/FlorianLiers","html_url":"https://github.com/FlorianLiers","followers_url":"https://api.github.com/users/FlorianLiers/followers","following_url":"https://api.github.com/users/FlorianLiers/following{/other_user}","gists_url":"https://api.github.com/users/FlorianLiers/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorianLiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorianLiers/subscriptions","organizations_url":"https://api.github.com/users/FlorianLiers/orgs","repos_url":"https://api.github.com/users/FlorianLiers/repos","events_url":"https://api.github.com/users/FlorianLiers/events{/privacy}","received_events_url":"https://api.github.com/users/FlorianLiers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-15T10:50:28Z","updated_at":"2016-06-16T07:57:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/7464","html_url":"https://github.com/elastic/kibana/pull/7464","diff_url":"https://github.com/elastic/kibana/pull/7464.diff","patch_url":"https://github.com/elastic/kibana/pull/7464.patch"},"body":"The change implements the \"Others\" bucket for the pie chart as discussed in #1961 or #3817. Moreover, it provides a work-around for #7451 by showing the \"Others\" buckets.\r\n\r\nThe implementation may be a base for \"Others\" buckets for other charts as well. It is backwards compatible, since it is turned off by default. Original implemented for Kibana 4.5 (with ES 2.3.1) but works for 5 as well.\r\n\r\nThe implementation modifies the results from ES and adds \"Others\" buckets, if possible. In particular, it can not add such buckets in the very first aggregation for non-count metrics. For sub-aggregations, the parent buckets is used as reference for 100%.\r\n\r\nThe new feature looks like this:\r\n![kibana - other buckets](https://cloud.githubusercontent.com/assets/2843045/16077086/f2ac2692-32f6-11e6-91e7-668ba480c4ad.png)\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/226414378","html_url":"https://github.com/elastic/kibana/pull/7464#issuecomment-226414378","issue_url":"https://api.github.com/repos/elastic/kibana/issues/7464","id":226414378,"user":{"login":"FlorianLiers","id":2843045,"avatar_url":"https://avatars.githubusercontent.com/u/2843045?v=3","gravatar_id":"","url":"https://api.github.com/users/FlorianLiers","html_url":"https://github.com/FlorianLiers","followers_url":"https://api.github.com/users/FlorianLiers/followers","following_url":"https://api.github.com/users/FlorianLiers/following{/other_user}","gists_url":"https://api.github.com/users/FlorianLiers/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorianLiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorianLiers/subscriptions","organizations_url":"https://api.github.com/users/FlorianLiers/orgs","repos_url":"https://api.github.com/users/FlorianLiers/repos","events_url":"https://api.github.com/users/FlorianLiers/events{/privacy}","received_events_url":"https://api.github.com/users/FlorianLiers/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T07:57:14Z","updated_at":"2016-06-16T07:57:14Z","body":"You are right, the pull request does not resolve #1961. So maybe my first sentence was a bit too optimistic. I added a general command to #1961. The following comment is more specific for this pull request.\r\n\r\nThe proposed change just uses the information already returned by ES and enhances the visualisation with that. The three options are:\r\n- No: No changes in the visualization for users not interested in \"others\"\r\n- Yes: Adds \"others\" bucket\r\n   - for all aggregations if the metric is a count metric\r\n   - for sub-aggregations if the metric is a non-count metric\r\n- Yes, for all: Maybe the name is missleading. It just fills up the \"outer rings\" visually. It does not perform a real sub-aggregation for the \"others\" bucket (because of the blocking issues you mentioned). I added the option because pie charts sometimes look \"nicer\" if the outer rings are filled up and are a closed circle.\r\n\r\nWhat do you think? Maybe I have to change the names of the options?\r\n- Yes -> \"Yes, if possible\"\r\n- Yes, All -> \"Yes, if possible and fill-up the outer rings\""}}
{"actor":{"display_login":"FlorianLiers"}}