{"action":"created","comment":{"url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/comments/68760206","id":68760206,"diff_hunk":"@@ -7,12 +7,13 @@\n   controller: ($scope) ->\n     this.lowest_points = (modelValue, viewValue) ->","path":"app/assets/javascripts/angular/directives/GradeSchemeDirectives.js.coffee","position":2,"original_position":2,"commit_id":"234dfcdb3f68bf39369b12cd5a1a01cd500680d4","original_commit_id":"234dfcdb3f68bf39369b12cd5a1a01cd500680d4","user":{"login":"zazaian","id":95957,"avatar_url":"https://avatars.githubusercontent.com/u/95957?v=3","gravatar_id":"","url":"https://api.github.com/users/zazaian","html_url":"https://github.com/zazaian","followers_url":"https://api.github.com/users/zazaian/followers","following_url":"https://api.github.com/users/zazaian/following{/other_user}","gists_url":"https://api.github.com/users/zazaian/gists{/gist_id}","starred_url":"https://api.github.com/users/zazaian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zazaian/subscriptions","organizations_url":"https://api.github.com/users/zazaian/orgs","repos_url":"https://api.github.com/users/zazaian/repos","events_url":"https://api.github.com/users/zazaian/events{/privacy}","received_events_url":"https://api.github.com/users/zazaian/received_events","type":"User","site_admin":false},"body":"It seems to me like the fact that we're calling the `GradeSchemeElementService` is being called in both the `lowest_points` method and the `highest_points` method means that both methods should be defined in the service itself rather than in the controller for this directive.","created_at":"2016-06-28T13:54:45Z","updated_at":"2016-06-28T13:54:45Z","html_url":"https://github.com/UM-USElab/gradecraft-development/pull/2164#discussion_r68760206","pull_request_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/2164","_links":{"self":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/comments/68760206"},"html":{"href":"https://github.com/UM-USElab/gradecraft-development/pull/2164#discussion_r68760206"},"pull_request":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/2164"}}},"pull_request":{"url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/2164","id":75193781,"html_url":"https://github.com/UM-USElab/gradecraft-development/pull/2164","diff_url":"https://github.com/UM-USElab/gradecraft-development/pull/2164.diff","patch_url":"https://github.com/UM-USElab/gradecraft-development/pull/2164.patch","issue_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/2164","number":2164,"state":"open","locked":false,"title":"Removed limitation on the upper bound of grade scheme element","user":{"login":"chcholman","id":234276,"avatar_url":"https://avatars.githubusercontent.com/u/234276?v=3","gravatar_id":"","url":"https://api.github.com/users/chcholman","html_url":"https://github.com/chcholman","followers_url":"https://api.github.com/users/chcholman/followers","following_url":"https://api.github.com/users/chcholman/following{/other_user}","gists_url":"https://api.github.com/users/chcholman/gists{/gist_id}","starred_url":"https://api.github.com/users/chcholman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcholman/subscriptions","organizations_url":"https://api.github.com/users/chcholman/orgs","repos_url":"https://api.github.com/users/chcholman/repos","events_url":"https://api.github.com/users/chcholman/events{/privacy}","received_events_url":"https://api.github.com/users/chcholman/received_events","type":"User","site_admin":false},"body":"This bugfix addresses the grade scheme element form rejecting point values that are higher than 1) is set on the Course model, or 2) the total sum of assignments created. Because the grading scheme is often entered far before all of the assignments are in, this is key to the UX feeling functional. It also adds the ability to edit the highest_points value, and for changes here to smartly update the lowest bounds of the above grade scheme element.","created_at":"2016-06-25T02:48:08Z","updated_at":"2016-06-28T13:54:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87c8a9250efb48cfeb947915468857f9c728c9f1","assignee":{"login":"zazaian","id":95957,"avatar_url":"https://avatars.githubusercontent.com/u/95957?v=3","gravatar_id":"","url":"https://api.github.com/users/zazaian","html_url":"https://github.com/zazaian","followers_url":"https://api.github.com/users/zazaian/followers","following_url":"https://api.github.com/users/zazaian/following{/other_user}","gists_url":"https://api.github.com/users/zazaian/gists{/gist_id}","starred_url":"https://api.github.com/users/zazaian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zazaian/subscriptions","organizations_url":"https://api.github.com/users/zazaian/orgs","repos_url":"https://api.github.com/users/zazaian/repos","events_url":"https://api.github.com/users/zazaian/events{/privacy}","received_events_url":"https://api.github.com/users/zazaian/received_events","type":"User","site_admin":false},"assignees":[{"login":"zazaian","id":95957,"avatar_url":"https://avatars.githubusercontent.com/u/95957?v=3","gravatar_id":"","url":"https://api.github.com/users/zazaian","html_url":"https://github.com/zazaian","followers_url":"https://api.github.com/users/zazaian/followers","following_url":"https://api.github.com/users/zazaian/following{/other_user}","gists_url":"https://api.github.com/users/zazaian/gists{/gist_id}","starred_url":"https://api.github.com/users/zazaian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zazaian/subscriptions","organizations_url":"https://api.github.com/users/zazaian/orgs","repos_url":"https://api.github.com/users/zazaian/repos","events_url":"https://api.github.com/users/zazaian/events{/privacy}","received_events_url":"https://api.github.com/users/zazaian/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/UM-USElab/gradecraft-development/milestones/13","html_url":"https://github.com/UM-USElab/gradecraft-development/milestones/End%20of%20Summer","labels_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/milestones/13/labels","id":1719510,"number":13,"title":"End of Summer","description":"","creator":{"login":"chcholman","id":234276,"avatar_url":"https://avatars.githubusercontent.com/u/234276?v=3","gravatar_id":"","url":"https://api.github.com/users/chcholman","html_url":"https://github.com/chcholman","followers_url":"https://api.github.com/users/chcholman/followers","following_url":"https://api.github.com/users/chcholman/following{/other_user}","gists_url":"https://api.github.com/users/chcholman/gists{/gist_id}","starred_url":"https://api.github.com/users/chcholman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcholman/subscriptions","organizations_url":"https://api.github.com/users/chcholman/orgs","repos_url":"https://api.github.com/users/chcholman/repos","events_url":"https://api.github.com/users/chcholman/events{/privacy}","received_events_url":"https://api.github.com/users/chcholman/received_events","type":"User","site_admin":false},"open_issues":107,"closed_issues":85,"state":"open","created_at":"2016-04-20T00:23:41Z","updated_at":"2016-06-25T02:48:14Z","due_on":"2016-08-21T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/2164/commits","review_comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/2164/comments","review_comment_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/2164/comments","statuses_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/statuses/234dfcdb3f68bf39369b12cd5a1a01cd500680d4","head":{"label":"UM-USElab:2161-grade-scheme-high-value-fix","ref":"2161-grade-scheme-high-value-fix","sha":"234dfcdb3f68bf39369b12cd5a1a01cd500680d4","user":{"login":"UM-USElab","id":4459066,"avatar_url":"https://avatars.githubusercontent.com/u/4459066?v=3","gravatar_id":"","url":"https://api.github.com/users/UM-USElab","html_url":"https://github.com/UM-USElab","followers_url":"https://api.github.com/users/UM-USElab/followers","following_url":"https://api.github.com/users/UM-USElab/following{/other_user}","gists_url":"https://api.github.com/users/UM-USElab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-USElab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-USElab/subscriptions","organizations_url":"https://api.github.com/users/UM-USElab/orgs","repos_url":"https://api.github.com/users/UM-USElab/repos","events_url":"https://api.github.com/users/UM-USElab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-USElab/received_events","type":"Organization","site_admin":false},"repo":{"id":8105769,"name":"gradecraft-development","full_name":"UM-USElab/gradecraft-development","owner":{"login":"UM-USElab","id":4459066,"avatar_url":"https://avatars.githubusercontent.com/u/4459066?v=3","gravatar_id":"","url":"https://api.github.com/users/UM-USElab","html_url":"https://github.com/UM-USElab","followers_url":"https://api.github.com/users/UM-USElab/followers","following_url":"https://api.github.com/users/UM-USElab/following{/other_user}","gists_url":"https://api.github.com/users/UM-USElab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-USElab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-USElab/subscriptions","organizations_url":"https://api.github.com/users/UM-USElab/orgs","repos_url":"https://api.github.com/users/UM-USElab/repos","events_url":"https://api.github.com/users/UM-USElab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-USElab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UM-USElab/gradecraft-development","description":"GradeCraft is a gameful learning management system, intended to help motivate students to be more engaged in their own learning.","fork":false,"url":"https://api.github.com/repos/UM-USElab/gradecraft-development","forks_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/forks","keys_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/teams","hooks_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/hooks","issue_events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/events{/number}","events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/events","assignees_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/assignees{/user}","branches_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/branches{/branch}","tags_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/tags","blobs_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/refs{/sha}","trees_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/statuses/{sha}","languages_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/languages","stargazers_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/stargazers","contributors_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/contributors","subscribers_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/subscribers","subscription_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/subscription","commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/commits{/sha}","git_commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/commits{/sha}","comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/comments{/number}","issue_comment_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/comments{/number}","contents_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/contents/{+path}","compare_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/merges","archive_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/downloads","issues_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues{/number}","pulls_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls{/number}","milestones_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/milestones{/number}","notifications_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/labels{/name}","releases_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/releases{/id}","deployments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/deployments","created_at":"2013-02-09T03:44:54Z","updated_at":"2016-05-26T22:07:04Z","pushed_at":"2016-06-28T10:52:01Z","git_url":"git://github.com/UM-USElab/gradecraft-development.git","ssh_url":"git@github.com:UM-USElab/gradecraft-development.git","clone_url":"https://github.com/UM-USElab/gradecraft-development.git","svn_url":"https://github.com/UM-USElab/gradecraft-development","homepage":"","size":69125,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":148,"forks":19,"open_issues":148,"watchers":27,"default_branch":"master"}},"base":{"label":"UM-USElab:master","ref":"master","sha":"f26df16ae0af549b6b95b14a845c64bb86181530","user":{"login":"UM-USElab","id":4459066,"avatar_url":"https://avatars.githubusercontent.com/u/4459066?v=3","gravatar_id":"","url":"https://api.github.com/users/UM-USElab","html_url":"https://github.com/UM-USElab","followers_url":"https://api.github.com/users/UM-USElab/followers","following_url":"https://api.github.com/users/UM-USElab/following{/other_user}","gists_url":"https://api.github.com/users/UM-USElab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-USElab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-USElab/subscriptions","organizations_url":"https://api.github.com/users/UM-USElab/orgs","repos_url":"https://api.github.com/users/UM-USElab/repos","events_url":"https://api.github.com/users/UM-USElab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-USElab/received_events","type":"Organization","site_admin":false},"repo":{"id":8105769,"name":"gradecraft-development","full_name":"UM-USElab/gradecraft-development","owner":{"login":"UM-USElab","id":4459066,"avatar_url":"https://avatars.githubusercontent.com/u/4459066?v=3","gravatar_id":"","url":"https://api.github.com/users/UM-USElab","html_url":"https://github.com/UM-USElab","followers_url":"https://api.github.com/users/UM-USElab/followers","following_url":"https://api.github.com/users/UM-USElab/following{/other_user}","gists_url":"https://api.github.com/users/UM-USElab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-USElab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-USElab/subscriptions","organizations_url":"https://api.github.com/users/UM-USElab/orgs","repos_url":"https://api.github.com/users/UM-USElab/repos","events_url":"https://api.github.com/users/UM-USElab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-USElab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UM-USElab/gradecraft-development","description":"GradeCraft is a gameful learning management system, intended to help motivate students to be more engaged in their own learning.","fork":false,"url":"https://api.github.com/repos/UM-USElab/gradecraft-development","forks_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/forks","keys_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/teams","hooks_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/hooks","issue_events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/events{/number}","events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/events","assignees_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/assignees{/user}","branches_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/branches{/branch}","tags_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/tags","blobs_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/refs{/sha}","trees_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/statuses/{sha}","languages_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/languages","stargazers_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/stargazers","contributors_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/contributors","subscribers_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/subscribers","subscription_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/subscription","commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/commits{/sha}","git_commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/commits{/sha}","comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/comments{/number}","issue_comment_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/comments{/number}","contents_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/contents/{+path}","compare_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/merges","archive_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/downloads","issues_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues{/number}","pulls_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls{/number}","milestones_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/milestones{/number}","notifications_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/labels{/name}","releases_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/releases{/id}","deployments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/deployments","created_at":"2013-02-09T03:44:54Z","updated_at":"2016-05-26T22:07:04Z","pushed_at":"2016-06-28T10:52:01Z","git_url":"git://github.com/UM-USElab/gradecraft-development.git","ssh_url":"git@github.com:UM-USElab/gradecraft-development.git","clone_url":"https://github.com/UM-USElab/gradecraft-development.git","svn_url":"https://github.com/UM-USElab/gradecraft-development","homepage":"","size":69125,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":148,"forks":19,"open_issues":148,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/2164"},"html":{"href":"https://github.com/UM-USElab/gradecraft-development/pull/2164"},"issue":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/2164"},"comments":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/2164/comments"},"review_comments":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/2164/comments"},"review_comment":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/2164/commits"},"statuses":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/statuses/234dfcdb3f68bf39369b12cd5a1a01cd500680d4"}}}}
{"actor":{"display_login":"zazaian"}}