{"action":"created","comment":{"url":"https://api.github.com/repos/tapjs/stack-utils/pulls/comments/49675074","id":49675074,"diff_hunk":"@@ -8,13 +8,13 @@ import {join, fixtureDir} from './_utils';\n \n function internals() {\n \treturn StackUtils.nodeInternals().concat([\n-\t\t/[\\\\\\/]long-stack-traces\\.js:[0-9]+:[0-9]+\\)?$/,\n-\t\t/[\\\\\\/]internal-error\\.js:[0-9]+:[0-9]+\\)?$/,\n-\t\t/[\\\\\\/]internal-then\\.js:[0-9]+:[0-9]+\\)?$/,\n-\t\t/[\\\\\\/]node_modules[\\\\\\/]/,\n+\t\t/\\/long-stack-traces\\.js:[0-9]+:[0-9]+\\)?$/,","path":"test/long-stack-traces.js","position":8,"original_position":8,"commit_id":"df98523cffff683d80401b88f6ad9fbce1e37d9b","original_commit_id":"df98523cffff683d80401b88f6ad9fbce1e37d9b","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"body":"Unrelated to this PR, but `[0-9]` => `\\d`.","created_at":"2016-01-14T00:57:37Z","updated_at":"2016-01-14T00:57:37Z","html_url":"https://github.com/tapjs/stack-utils/pull/10#discussion_r49675074","pull_request_url":"https://api.github.com/repos/tapjs/stack-utils/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/tapjs/stack-utils/pulls/comments/49675074"},"html":{"href":"https://github.com/tapjs/stack-utils/pull/10#discussion_r49675074"},"pull_request":{"href":"https://api.github.com/repos/tapjs/stack-utils/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/tapjs/stack-utils/pulls/10","id":55979317,"html_url":"https://github.com/tapjs/stack-utils/pull/10","diff_url":"https://github.com/tapjs/stack-utils/pull/10.diff","patch_url":"https://github.com/tapjs/stack-utils/pull/10.patch","issue_url":"https://api.github.com/repos/tapjs/stack-utils/issues/10","number":10,"state":"open","locked":false,"title":"Normalize to unix style paths before filtering out \"internals\".","user":{"login":"jamestalmage","id":4082216,"avatar_url":"https://avatars.githubusercontent.com/u/4082216?v=3","gravatar_id":"","url":"https://api.github.com/users/jamestalmage","html_url":"https://github.com/jamestalmage","followers_url":"https://api.github.com/users/jamestalmage/followers","following_url":"https://api.github.com/users/jamestalmage/following{/other_user}","gists_url":"https://api.github.com/users/jamestalmage/gists{/gist_id}","starred_url":"https://api.github.com/users/jamestalmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamestalmage/subscriptions","organizations_url":"https://api.github.com/users/jamestalmage/orgs","repos_url":"https://api.github.com/users/jamestalmage/repos","events_url":"https://api.github.com/users/jamestalmage/events{/privacy}","received_events_url":"https://api.github.com/users/jamestalmage/received_events","type":"User","site_admin":false},"body":"This makes it a little easier to write regular expressions for internals by normalizing the array before applying the filter. This means your regular expression only needs to deal with forward slash separators\n\nFixes #9","created_at":"2016-01-14T00:55:43Z","updated_at":"2016-01-14T00:57:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce70c8683b4de6b2a261e277a25ae431296181bc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tapjs/stack-utils/pulls/10/commits","review_comments_url":"https://api.github.com/repos/tapjs/stack-utils/pulls/10/comments","review_comment_url":"https://api.github.com/repos/tapjs/stack-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tapjs/stack-utils/issues/10/comments","statuses_url":"https://api.github.com/repos/tapjs/stack-utils/statuses/df98523cffff683d80401b88f6ad9fbce1e37d9b","head":{"label":"tapjs:normalize-path-before-filtering-internals","ref":"normalize-path-before-filtering-internals","sha":"df98523cffff683d80401b88f6ad9fbce1e37d9b","user":{"login":"tapjs","id":16528145,"avatar_url":"https://avatars.githubusercontent.com/u/16528145?v=3","gravatar_id":"","url":"https://api.github.com/users/tapjs","html_url":"https://github.com/tapjs","followers_url":"https://api.github.com/users/tapjs/followers","following_url":"https://api.github.com/users/tapjs/following{/other_user}","gists_url":"https://api.github.com/users/tapjs/gists{/gist_id}","starred_url":"https://api.github.com/users/tapjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tapjs/subscriptions","organizations_url":"https://api.github.com/users/tapjs/orgs","repos_url":"https://api.github.com/users/tapjs/repos","events_url":"https://api.github.com/users/tapjs/events{/privacy}","received_events_url":"https://api.github.com/users/tapjs/received_events","type":"Organization","site_admin":false},"repo":{"id":48974178,"name":"stack-utils","full_name":"tapjs/stack-utils","owner":{"login":"tapjs","id":16528145,"avatar_url":"https://avatars.githubusercontent.com/u/16528145?v=3","gravatar_id":"","url":"https://api.github.com/users/tapjs","html_url":"https://github.com/tapjs","followers_url":"https://api.github.com/users/tapjs/followers","following_url":"https://api.github.com/users/tapjs/following{/other_user}","gists_url":"https://api.github.com/users/tapjs/gists{/gist_id}","starred_url":"https://api.github.com/users/tapjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tapjs/subscriptions","organizations_url":"https://api.github.com/users/tapjs/orgs","repos_url":"https://api.github.com/users/tapjs/repos","events_url":"https://api.github.com/users/tapjs/events{/privacy}","received_events_url":"https://api.github.com/users/tapjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tapjs/stack-utils","description":"Captures and cleans stack traces.","fork":false,"url":"https://api.github.com/repos/tapjs/stack-utils","forks_url":"https://api.github.com/repos/tapjs/stack-utils/forks","keys_url":"https://api.github.com/repos/tapjs/stack-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tapjs/stack-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tapjs/stack-utils/teams","hooks_url":"https://api.github.com/repos/tapjs/stack-utils/hooks","issue_events_url":"https://api.github.com/repos/tapjs/stack-utils/issues/events{/number}","events_url":"https://api.github.com/repos/tapjs/stack-utils/events","assignees_url":"https://api.github.com/repos/tapjs/stack-utils/assignees{/user}","branches_url":"https://api.github.com/repos/tapjs/stack-utils/branches{/branch}","tags_url":"https://api.github.com/repos/tapjs/stack-utils/tags","blobs_url":"https://api.github.com/repos/tapjs/stack-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tapjs/stack-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tapjs/stack-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/tapjs/stack-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tapjs/stack-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/tapjs/stack-utils/languages","stargazers_url":"https://api.github.com/repos/tapjs/stack-utils/stargazers","contributors_url":"https://api.github.com/repos/tapjs/stack-utils/contributors","subscribers_url":"https://api.github.com/repos/tapjs/stack-utils/subscribers","subscription_url":"https://api.github.com/repos/tapjs/stack-utils/subscription","commits_url":"https://api.github.com/repos/tapjs/stack-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/tapjs/stack-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/tapjs/stack-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/tapjs/stack-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/tapjs/stack-utils/contents/{+path}","compare_url":"https://api.github.com/repos/tapjs/stack-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tapjs/stack-utils/merges","archive_url":"https://api.github.com/repos/tapjs/stack-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tapjs/stack-utils/downloads","issues_url":"https://api.github.com/repos/tapjs/stack-utils/issues{/number}","pulls_url":"https://api.github.com/repos/tapjs/stack-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/tapjs/stack-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/tapjs/stack-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tapjs/stack-utils/labels{/name}","releases_url":"https://api.github.com/repos/tapjs/stack-utils/releases{/id}","created_at":"2016-01-04T04:10:30Z","updated_at":"2016-01-13T00:11:46Z","pushed_at":"2016-01-14T00:55:43Z","git_url":"git://github.com/tapjs/stack-utils.git","ssh_url":"git@github.com:tapjs/stack-utils.git","clone_url":"https://github.com/tapjs/stack-utils.git","svn_url":"https://github.com/tapjs/stack-utils","homepage":"https://www.npmjs.com/package/stack-utils","size":19,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":38,"default_branch":"master"}},"base":{"label":"tapjs:master","ref":"master","sha":"ac75d4703abb94b1fbce6ed76c78d6d848397645","user":{"login":"tapjs","id":16528145,"avatar_url":"https://avatars.githubusercontent.com/u/16528145?v=3","gravatar_id":"","url":"https://api.github.com/users/tapjs","html_url":"https://github.com/tapjs","followers_url":"https://api.github.com/users/tapjs/followers","following_url":"https://api.github.com/users/tapjs/following{/other_user}","gists_url":"https://api.github.com/users/tapjs/gists{/gist_id}","starred_url":"https://api.github.com/users/tapjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tapjs/subscriptions","organizations_url":"https://api.github.com/users/tapjs/orgs","repos_url":"https://api.github.com/users/tapjs/repos","events_url":"https://api.github.com/users/tapjs/events{/privacy}","received_events_url":"https://api.github.com/users/tapjs/received_events","type":"Organization","site_admin":false},"repo":{"id":48974178,"name":"stack-utils","full_name":"tapjs/stack-utils","owner":{"login":"tapjs","id":16528145,"avatar_url":"https://avatars.githubusercontent.com/u/16528145?v=3","gravatar_id":"","url":"https://api.github.com/users/tapjs","html_url":"https://github.com/tapjs","followers_url":"https://api.github.com/users/tapjs/followers","following_url":"https://api.github.com/users/tapjs/following{/other_user}","gists_url":"https://api.github.com/users/tapjs/gists{/gist_id}","starred_url":"https://api.github.com/users/tapjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tapjs/subscriptions","organizations_url":"https://api.github.com/users/tapjs/orgs","repos_url":"https://api.github.com/users/tapjs/repos","events_url":"https://api.github.com/users/tapjs/events{/privacy}","received_events_url":"https://api.github.com/users/tapjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tapjs/stack-utils","description":"Captures and cleans stack traces.","fork":false,"url":"https://api.github.com/repos/tapjs/stack-utils","forks_url":"https://api.github.com/repos/tapjs/stack-utils/forks","keys_url":"https://api.github.com/repos/tapjs/stack-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tapjs/stack-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tapjs/stack-utils/teams","hooks_url":"https://api.github.com/repos/tapjs/stack-utils/hooks","issue_events_url":"https://api.github.com/repos/tapjs/stack-utils/issues/events{/number}","events_url":"https://api.github.com/repos/tapjs/stack-utils/events","assignees_url":"https://api.github.com/repos/tapjs/stack-utils/assignees{/user}","branches_url":"https://api.github.com/repos/tapjs/stack-utils/branches{/branch}","tags_url":"https://api.github.com/repos/tapjs/stack-utils/tags","blobs_url":"https://api.github.com/repos/tapjs/stack-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tapjs/stack-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tapjs/stack-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/tapjs/stack-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tapjs/stack-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/tapjs/stack-utils/languages","stargazers_url":"https://api.github.com/repos/tapjs/stack-utils/stargazers","contributors_url":"https://api.github.com/repos/tapjs/stack-utils/contributors","subscribers_url":"https://api.github.com/repos/tapjs/stack-utils/subscribers","subscription_url":"https://api.github.com/repos/tapjs/stack-utils/subscription","commits_url":"https://api.github.com/repos/tapjs/stack-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/tapjs/stack-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/tapjs/stack-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/tapjs/stack-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/tapjs/stack-utils/contents/{+path}","compare_url":"https://api.github.com/repos/tapjs/stack-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tapjs/stack-utils/merges","archive_url":"https://api.github.com/repos/tapjs/stack-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tapjs/stack-utils/downloads","issues_url":"https://api.github.com/repos/tapjs/stack-utils/issues{/number}","pulls_url":"https://api.github.com/repos/tapjs/stack-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/tapjs/stack-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/tapjs/stack-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tapjs/stack-utils/labels{/name}","releases_url":"https://api.github.com/repos/tapjs/stack-utils/releases{/id}","created_at":"2016-01-04T04:10:30Z","updated_at":"2016-01-13T00:11:46Z","pushed_at":"2016-01-14T00:55:43Z","git_url":"git://github.com/tapjs/stack-utils.git","ssh_url":"git@github.com:tapjs/stack-utils.git","clone_url":"https://github.com/tapjs/stack-utils.git","svn_url":"https://github.com/tapjs/stack-utils","homepage":"https://www.npmjs.com/package/stack-utils","size":19,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tapjs/stack-utils/pulls/10"},"html":{"href":"https://github.com/tapjs/stack-utils/pull/10"},"issue":{"href":"https://api.github.com/repos/tapjs/stack-utils/issues/10"},"comments":{"href":"https://api.github.com/repos/tapjs/stack-utils/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/tapjs/stack-utils/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/tapjs/stack-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tapjs/stack-utils/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/tapjs/stack-utils/statuses/df98523cffff683d80401b88f6ad9fbce1e37d9b"}}}}