{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-gossip/pulls/comments/69646065","id":69646065,"diff_hunk":"@@ -0,0 +1,243 @@\n+package org.apache.gossip.manager;\n+\n+import java.io.IOException;\n+import java.net.DatagramPacket;\n+import java.net.DatagramSocket;\n+import java.net.InetAddress;\n+import java.net.URI;\n+import java.net.URISyntaxException;\n+import java.util.ArrayList;\n+import java.util.List;\n+import java.util.concurrent.ConcurrentHashMap;\n+import java.util.concurrent.CountDownLatch;\n+import java.util.concurrent.TimeUnit;\n+import java.util.concurrent.atomic.AtomicReference;\n+\n+import org.apache.gossip.GossipMember;\n+import org.apache.gossip.LocalGossipMember;\n+import org.apache.gossip.RemoteGossipMember;\n+import org.apache.gossip.model.Fault;\n+import org.apache.gossip.model.NotAMemberFault;\n+import org.apache.gossip.model.ActiveGossipMessage;\n+import org.apache.gossip.model.ActiveGossipOk;\n+import org.apache.gossip.model.Base;\n+import org.apache.gossip.model.Response;\n+import org.apache.gossip.udp.Trackable;\n+import org.apache.log4j.Logger;\n+import org.codehaus.jackson.map.ObjectMapper;\n+\n+public class GossipCore {\n+  \n+  public static final Logger LOGGER = Logger.getLogger(GossipCore.class);\n+  private static final ObjectMapper MAPPER = new ObjectMapper();\n+  private final GossipManager gossipManager;\n+\n+  private ConcurrentHashMap<String, Base> requests;","path":"src/main/java/org/apache/gossip/manager/GossipCore.java","position":35,"original_position":35,"commit_id":"eedccdc065296a6d67e70eba56756a694765d7b0","original_commit_id":"eedccdc065296a6d67e70eba56756a694765d7b0","user":{"login":"edwardcapriolo","id":1020364,"avatar_url":"https://avatars.githubusercontent.com/u/1020364?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardcapriolo","html_url":"https://github.com/edwardcapriolo","followers_url":"https://api.github.com/users/edwardcapriolo/followers","following_url":"https://api.github.com/users/edwardcapriolo/following{/other_user}","gists_url":"https://api.github.com/users/edwardcapriolo/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardcapriolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardcapriolo/subscriptions","organizations_url":"https://api.github.com/users/edwardcapriolo/orgs","repos_url":"https://api.github.com/users/edwardcapriolo/repos","events_url":"https://api.github.com/users/edwardcapriolo/events{/privacy}","received_events_url":"https://api.github.com/users/edwardcapriolo/received_events","type":"User","site_admin":false},"body":"I can see that one map could be a performance hit.  But I worry about keeping 2 map consistent atomically. Remember for connection oriented protocols we went need this.  I will think of a better abstraction ","created_at":"2016-07-05T22:02:12Z","updated_at":"2016-07-05T22:02:12Z","html_url":"https://github.com/apache/incubator-gossip/pull/7#discussion_r69646065","pull_request_url":"https://api.github.com/repos/apache/incubator-gossip/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/comments/69646065"},"html":{"href":"https://github.com/apache/incubator-gossip/pull/7#discussion_r69646065"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-gossip/pulls/7","id":76312823,"html_url":"https://github.com/apache/incubator-gossip/pull/7","diff_url":"https://github.com/apache/incubator-gossip/pull/7.diff","patch_url":"https://github.com/apache/incubator-gossip/pull/7.patch","issue_url":"https://api.github.com/repos/apache/incubator-gossip/issues/7","number":7,"state":"open","locked":false,"title":"Gossip 13","user":{"login":"edwardcapriolo","id":1020364,"avatar_url":"https://avatars.githubusercontent.com/u/1020364?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardcapriolo","html_url":"https://github.com/edwardcapriolo","followers_url":"https://api.github.com/users/edwardcapriolo/followers","following_url":"https://api.github.com/users/edwardcapriolo/following{/other_user}","gists_url":"https://api.github.com/users/edwardcapriolo/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardcapriolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardcapriolo/subscriptions","organizations_url":"https://api.github.com/users/edwardcapriolo/orgs","repos_url":"https://api.github.com/users/edwardcapriolo/repos","events_url":"https://api.github.com/users/edwardcapriolo/events{/privacy}","received_events_url":"https://api.github.com/users/edwardcapriolo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-05T17:36:39Z","updated_at":"2016-07-05T22:02:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2b0547217f9d5b0ac23daaf5310fae0ebcda3e3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-gossip/pulls/7/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-gossip/pulls/7/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-gossip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-gossip/issues/7/comments","statuses_url":"https://api.github.com/repos/apache/incubator-gossip/statuses/eedccdc065296a6d67e70eba56756a694765d7b0","head":{"label":"edwardcapriolo:GOSSIP-13","ref":"GOSSIP-13","sha":"eedccdc065296a6d67e70eba56756a694765d7b0","user":{"login":"edwardcapriolo","id":1020364,"avatar_url":"https://avatars.githubusercontent.com/u/1020364?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardcapriolo","html_url":"https://github.com/edwardcapriolo","followers_url":"https://api.github.com/users/edwardcapriolo/followers","following_url":"https://api.github.com/users/edwardcapriolo/following{/other_user}","gists_url":"https://api.github.com/users/edwardcapriolo/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardcapriolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardcapriolo/subscriptions","organizations_url":"https://api.github.com/users/edwardcapriolo/orgs","repos_url":"https://api.github.com/users/edwardcapriolo/repos","events_url":"https://api.github.com/users/edwardcapriolo/events{/privacy}","received_events_url":"https://api.github.com/users/edwardcapriolo/received_events","type":"User","site_admin":false},"repo":{"id":60277688,"name":"incubator-gossip","full_name":"edwardcapriolo/incubator-gossip","owner":{"login":"edwardcapriolo","id":1020364,"avatar_url":"https://avatars.githubusercontent.com/u/1020364?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardcapriolo","html_url":"https://github.com/edwardcapriolo","followers_url":"https://api.github.com/users/edwardcapriolo/followers","following_url":"https://api.github.com/users/edwardcapriolo/following{/other_user}","gists_url":"https://api.github.com/users/edwardcapriolo/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardcapriolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardcapriolo/subscriptions","organizations_url":"https://api.github.com/users/edwardcapriolo/orgs","repos_url":"https://api.github.com/users/edwardcapriolo/repos","events_url":"https://api.github.com/users/edwardcapriolo/events{/privacy}","received_events_url":"https://api.github.com/users/edwardcapriolo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edwardcapriolo/incubator-gossip","description":"Mirror of Apache Gossip Incubator","fork":true,"url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip","forks_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/forks","keys_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/teams","hooks_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/hooks","issue_events_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/issues/events{/number}","events_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/events","assignees_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/assignees{/user}","branches_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/branches{/branch}","tags_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/tags","blobs_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/git/refs{/sha}","trees_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/statuses/{sha}","languages_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/languages","stargazers_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/stargazers","contributors_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/contributors","subscribers_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/subscribers","subscription_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/subscription","commits_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/commits{/sha}","git_commits_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/git/commits{/sha}","comments_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/comments{/number}","issue_comment_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/issues/comments{/number}","contents_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/contents/{+path}","compare_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/merges","archive_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/downloads","issues_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/issues{/number}","pulls_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/pulls{/number}","milestones_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/milestones{/number}","notifications_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/labels{/name}","releases_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/releases{/id}","deployments_url":"https://api.github.com/repos/edwardcapriolo/incubator-gossip/deployments","created_at":"2016-06-02T15:58:19Z","updated_at":"2016-06-02T15:58:20Z","pushed_at":"2016-07-03T17:04:14Z","git_url":"git://github.com/edwardcapriolo/incubator-gossip.git","ssh_url":"git@github.com:edwardcapriolo/incubator-gossip.git","clone_url":"https://github.com/edwardcapriolo/incubator-gossip.git","svn_url":"https://github.com/edwardcapriolo/incubator-gossip","homepage":null,"size":193,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d28d9b321cd7eeeca75f23c8847f912b4fb70683","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":59881768,"name":"incubator-gossip","full_name":"apache/incubator-gossip","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-gossip","description":"Mirror of Apache Gossip Incubator","fork":false,"url":"https://api.github.com/repos/apache/incubator-gossip","forks_url":"https://api.github.com/repos/apache/incubator-gossip/forks","keys_url":"https://api.github.com/repos/apache/incubator-gossip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-gossip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-gossip/teams","hooks_url":"https://api.github.com/repos/apache/incubator-gossip/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-gossip/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-gossip/events","assignees_url":"https://api.github.com/repos/apache/incubator-gossip/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-gossip/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-gossip/tags","blobs_url":"https://api.github.com/repos/apache/incubator-gossip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-gossip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-gossip/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-gossip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-gossip/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-gossip/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-gossip/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-gossip/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-gossip/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-gossip/subscription","commits_url":"https://api.github.com/repos/apache/incubator-gossip/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-gossip/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-gossip/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-gossip/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-gossip/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-gossip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-gossip/merges","archive_url":"https://api.github.com/repos/apache/incubator-gossip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-gossip/downloads","issues_url":"https://api.github.com/repos/apache/incubator-gossip/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-gossip/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-gossip/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-gossip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-gossip/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-gossip/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-gossip/deployments","created_at":"2016-05-28T07:00:05Z","updated_at":"2016-06-05T08:51:23Z","pushed_at":"2016-07-05T17:36:39Z","git_url":"git://github.com/apache/incubator-gossip.git","ssh_url":"git@github.com:apache/incubator-gossip.git","clone_url":"https://github.com/apache/incubator-gossip.git","svn_url":"https://github.com/apache/incubator-gossip","homepage":null,"size":192,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":"git://git.apache.org/incubator-gossip.git","open_issues_count":3,"forks":6,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/7"},"html":{"href":"https://github.com/apache/incubator-gossip/pull/7"},"issue":{"href":"https://api.github.com/repos/apache/incubator-gossip/issues/7"},"comments":{"href":"https://api.github.com/repos/apache/incubator-gossip/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-gossip/statuses/eedccdc065296a6d67e70eba56756a694765d7b0"}}}}
{"actor":{"display_login":"edwardcapriolo"}}