{"action":"created","issue":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9328","repository_url":"https://api.github.com/repos/hazelcast/hazelcast","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9328/labels{/name}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9328/comments","events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9328/events","html_url":"https://github.com/hazelcast/hazelcast/pull/9328","id":191778275,"number":9328,"title":"Instantiate and register split brain messages listener once for the lifetime of a node","user":{"login":"vbekiaris","id":1212378,"avatar_url":"https://avatars.githubusercontent.com/u/1212378?v=3","gravatar_id":"","url":"https://api.github.com/users/vbekiaris","html_url":"https://github.com/vbekiaris","followers_url":"https://api.github.com/users/vbekiaris/followers","following_url":"https://api.github.com/users/vbekiaris/following{/other_user}","gists_url":"https://api.github.com/users/vbekiaris/gists{/gist_id}","starred_url":"https://api.github.com/users/vbekiaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbekiaris/subscriptions","organizations_url":"https://api.github.com/users/vbekiaris/orgs","repos_url":"https://api.github.com/users/vbekiaris/repos","events_url":"https://api.github.com/users/vbekiaris/events{/privacy}","received_events_url":"https://api.github.com/users/vbekiaris/received_events","type":"User","site_admin":false},"labels":[{"id":137752575,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team:%20Core","name":"Team: Core","color":"109def","default":false},{"id":1740690,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Defect","name":"Type: Defect","color":"eb6420","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.8","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76/labels","id":1774122,"number":76,"title":"3.8","description":"","creator":{"login":"degerhz","id":8373100,"avatar_url":"https://avatars.githubusercontent.com/u/8373100?v=3","gravatar_id":"","url":"https://api.github.com/users/degerhz","html_url":"https://github.com/degerhz","followers_url":"https://api.github.com/users/degerhz/followers","following_url":"https://api.github.com/users/degerhz/following{/other_user}","gists_url":"https://api.github.com/users/degerhz/gists{/gist_id}","starred_url":"https://api.github.com/users/degerhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degerhz/subscriptions","organizations_url":"https://api.github.com/users/degerhz/orgs","repos_url":"https://api.github.com/users/degerhz/repos","events_url":"https://api.github.com/users/degerhz/events{/privacy}","received_events_url":"https://api.github.com/users/degerhz/received_events","type":"User","site_admin":false},"open_issues":185,"closed_issues":369,"state":"open","created_at":"2016-05-18T14:13:56Z","updated_at":"2016-11-28T16:23:28Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2016-11-26T00:37:53Z","updated_at":"2016-11-28T16:24:02Z","closed_at":"2016-11-28T16:23:28Z","pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9328","html_url":"https://github.com/hazelcast/hazelcast/pull/9328","diff_url":"https://github.com/hazelcast/hazelcast/pull/9328.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/9328.patch"},"body":"This PR promotes the existing anonymous listener in `searchForOtherClusters` to top-level class and instantiates & registers the listener just once, during `MulticastJoiner` construction.\r\n\r\nReasoning:\r\n* do not miss any split-brain join messages sent while listener is not registered\r\n* do not produce litter on each execution of split brain handler"},"comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/263317181","html_url":"https://github.com/hazelcast/hazelcast/pull/9328#issuecomment-263317181","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9328","id":263317181,"user":{"login":"vbekiaris","id":1212378,"avatar_url":"https://avatars.githubusercontent.com/u/1212378?v=3","gravatar_id":"","url":"https://api.github.com/users/vbekiaris","html_url":"https://github.com/vbekiaris","followers_url":"https://api.github.com/users/vbekiaris/followers","following_url":"https://api.github.com/users/vbekiaris/following{/other_user}","gists_url":"https://api.github.com/users/vbekiaris/gists{/gist_id}","starred_url":"https://api.github.com/users/vbekiaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbekiaris/subscriptions","organizations_url":"https://api.github.com/users/vbekiaris/orgs","repos_url":"https://api.github.com/users/vbekiaris/repos","events_url":"https://api.github.com/users/vbekiaris/events{/privacy}","received_events_url":"https://api.github.com/users/vbekiaris/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T16:24:02Z","updated_at":"2016-11-28T16:24:02Z","body":"Thanks @mdogan & @tombujok for your feedback"}}
{"actor":{"display_login":"vbekiaris"}}