{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/ui-element-samples/issues/58","repository_url":"https://api.github.com/repos/GoogleChrome/ui-element-samples","labels_url":"https://api.github.com/repos/GoogleChrome/ui-element-samples/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/ui-element-samples/issues/58/comments","events_url":"https://api.github.com/repos/GoogleChrome/ui-element-samples/issues/58/events","html_url":"https://github.com/GoogleChrome/ui-element-samples/pull/58","id":179902937,"number":58,"title":"Update sc-view.js to render web components","user":{"login":"derekshull","id":5685667,"avatar_url":"https://avatars.githubusercontent.com/u/5685667?v=3","gravatar_id":"","url":"https://api.github.com/users/derekshull","html_url":"https://github.com/derekshull","followers_url":"https://api.github.com/users/derekshull/followers","following_url":"https://api.github.com/users/derekshull/following{/other_user}","gists_url":"https://api.github.com/users/derekshull/gists{/gist_id}","starred_url":"https://api.github.com/users/derekshull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekshull/subscriptions","organizations_url":"https://api.github.com/users/derekshull/orgs","repos_url":"https://api.github.com/users/derekshull/repos","events_url":"https://api.github.com/users/derekshull/events{/privacy}","received_events_url":"https://api.github.com/users/derekshull/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleChrome/ui-element-samples/labels/CLA:%20Yes","name":"CLA: Yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-28T22:04:04Z","updated_at":"2016-09-29T14:35:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/ui-element-samples/pulls/58","html_url":"https://github.com/GoogleChrome/ui-element-samples/pull/58","diff_url":"https://github.com/GoogleChrome/ui-element-samples/pull/58.diff","patch_url":"https://github.com/GoogleChrome/ui-element-samples/pull/58.patch"},"body":"This change allows web components to be rendered using the router by taking the child nodes from newView and using innerHTML to copy the HTML from newView into currentView.  This appears to render the HTML which triggers the web component lifecycle callbacks."},"comment":{"url":"https://api.github.com/repos/GoogleChrome/ui-element-samples/issues/comments/250484693","html_url":"https://github.com/GoogleChrome/ui-element-samples/pull/58#issuecomment-250484693","issue_url":"https://api.github.com/repos/GoogleChrome/ui-element-samples/issues/58","id":250484693,"user":{"login":"derekshull","id":5685667,"avatar_url":"https://avatars.githubusercontent.com/u/5685667?v=3","gravatar_id":"","url":"https://api.github.com/users/derekshull","html_url":"https://github.com/derekshull","followers_url":"https://api.github.com/users/derekshull/followers","following_url":"https://api.github.com/users/derekshull/following{/other_user}","gists_url":"https://api.github.com/users/derekshull/gists{/gist_id}","starred_url":"https://api.github.com/users/derekshull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekshull/subscriptions","organizations_url":"https://api.github.com/users/derekshull/orgs","repos_url":"https://api.github.com/users/derekshull/repos","events_url":"https://api.github.com/users/derekshull/events{/privacy}","received_events_url":"https://api.github.com/users/derekshull/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T14:35:41Z","updated_at":"2016-09-29T14:35:41Z","body":"Here's the code for sc-view: https://github.com/derekshull/styleguide/blob/gh-pages/js/components.js#L116\r\n\r\nAnd here's an example to test: https://derekshull.github.io/styleguide/\r\n\r\nGo to the initial page, then open the side nav and go to the buttons page.  In Chrome the custom elements won't render the shadow dom.  In Safari and FF, they will render properly.  Maybe first child isn't working in Chrome like it does in other browsers?  Or maybe appendChild isn't working in Chrome like other browsers?\r\n\r\nYou'll notice on line 116 that I'm using `document.createElement('div')` instead of `DocumentFragment()`.   I explain why in this issue: https://github.com/GoogleChrome/ui-element-samples/issues/57"}}
{"actor":{"display_login":"derekshull"}}