{"action":"created","comment":{"url":"https://api.github.com/repos/solson/miri/pulls/comments/68285050","id":68285050,"diff_hunk":"@@ -585,3 +591,43 @@ impl UndefMask {\n fn bit_index(bits: usize) -> (usize, usize) {\n     (bits / BLOCK_SIZE, bits % BLOCK_SIZE)\n }\n+\n+trait ReadBytesExt2 {","path":"src/memory.rs","position":79,"original_position":66,"commit_id":"e23fdd1f4951165be7e3b604be6ba742027b0b94","original_commit_id":"0288486b731b3da05dd4b42635bfcf3dae285400","user":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"body":"Can you make these below methods free functions instead of using extension traits? I find the traits a little messy and the method syntax isn't that important.","created_at":"2016-06-23T18:07:05Z","updated_at":"2016-06-23T18:07:05Z","html_url":"https://github.com/solson/miri/pull/36#discussion_r68285050","pull_request_url":"https://api.github.com/repos/solson/miri/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/comments/68285050"},"html":{"href":"https://github.com/solson/miri/pull/36#discussion_r68285050"},"pull_request":{"href":"https://api.github.com/repos/solson/miri/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/solson/miri/pulls/36","id":74957559,"html_url":"https://github.com/solson/miri/pull/36","diff_url":"https://github.com/solson/miri/pull/36.diff","patch_url":"https://github.com/solson/miri/pull/36.patch","issue_url":"https://api.github.com/repos/solson/miri/issues/36","number":36,"state":"open","locked":false,"title":"Use target byte order instead of host byteorder","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"I had to paper over the const int -> pointer transformation, because values smaller than the pointer size on big endian systems were written as if they were a pointer sized integer.\r\n\r\nWe can get rid of the extension traits by inlining the endianess match. This will cause minor code duplication for `read_ptr` (which already contains some duplication b/c of the checks that pointers should not be read as bytes)\r\n\r\nThis was the first time I used [priroda](https://github.com/oli-obk/miri/tree/priroda) to find a bug in miri xD.","created_at":"2016-06-23T13:46:31Z","updated_at":"2016-06-23T18:07:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c615e1ea0cfd684ada226d4b9d7d219b3d2be8a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solson/miri/pulls/36/commits","review_comments_url":"https://api.github.com/repos/solson/miri/pulls/36/comments","review_comment_url":"https://api.github.com/repos/solson/miri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solson/miri/issues/36/comments","statuses_url":"https://api.github.com/repos/solson/miri/statuses/e23fdd1f4951165be7e3b604be6ba742027b0b94","head":{"label":"oli-obk:alignment","ref":"alignment","sha":"e23fdd1f4951165be7e3b604be6ba742027b0b94","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"repo":{"id":51430710,"name":"miri","full_name":"oli-obk/miri","owner":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oli-obk/miri","description":"An experimental interpreter for Rust MIR","fork":true,"url":"https://api.github.com/repos/oli-obk/miri","forks_url":"https://api.github.com/repos/oli-obk/miri/forks","keys_url":"https://api.github.com/repos/oli-obk/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oli-obk/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oli-obk/miri/teams","hooks_url":"https://api.github.com/repos/oli-obk/miri/hooks","issue_events_url":"https://api.github.com/repos/oli-obk/miri/issues/events{/number}","events_url":"https://api.github.com/repos/oli-obk/miri/events","assignees_url":"https://api.github.com/repos/oli-obk/miri/assignees{/user}","branches_url":"https://api.github.com/repos/oli-obk/miri/branches{/branch}","tags_url":"https://api.github.com/repos/oli-obk/miri/tags","blobs_url":"https://api.github.com/repos/oli-obk/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oli-obk/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oli-obk/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/oli-obk/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oli-obk/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/oli-obk/miri/languages","stargazers_url":"https://api.github.com/repos/oli-obk/miri/stargazers","contributors_url":"https://api.github.com/repos/oli-obk/miri/contributors","subscribers_url":"https://api.github.com/repos/oli-obk/miri/subscribers","subscription_url":"https://api.github.com/repos/oli-obk/miri/subscription","commits_url":"https://api.github.com/repos/oli-obk/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/oli-obk/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/oli-obk/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/oli-obk/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/oli-obk/miri/contents/{+path}","compare_url":"https://api.github.com/repos/oli-obk/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oli-obk/miri/merges","archive_url":"https://api.github.com/repos/oli-obk/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oli-obk/miri/downloads","issues_url":"https://api.github.com/repos/oli-obk/miri/issues{/number}","pulls_url":"https://api.github.com/repos/oli-obk/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/oli-obk/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/oli-obk/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oli-obk/miri/labels{/name}","releases_url":"https://api.github.com/repos/oli-obk/miri/releases{/id}","deployments_url":"https://api.github.com/repos/oli-obk/miri/deployments","created_at":"2016-02-10T09:10:02Z","updated_at":"2016-02-10T09:10:02Z","pushed_at":"2016-06-23T15:36:35Z","git_url":"git://github.com/oli-obk/miri.git","ssh_url":"git@github.com:oli-obk/miri.git","clone_url":"https://github.com/oli-obk/miri.git","svn_url":"https://github.com/oli-obk/miri","homepage":null,"size":741,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solson:master","ref":"master","sha":"ba23b8751eb4f5f0dcb0c11eeac45aeb453a35a6","user":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"repo":{"id":46083140,"name":"miri","full_name":"solson/miri","owner":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solson/miri","description":"An interpreter for Rust's mid-level intermediate representation","fork":false,"url":"https://api.github.com/repos/solson/miri","forks_url":"https://api.github.com/repos/solson/miri/forks","keys_url":"https://api.github.com/repos/solson/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solson/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solson/miri/teams","hooks_url":"https://api.github.com/repos/solson/miri/hooks","issue_events_url":"https://api.github.com/repos/solson/miri/issues/events{/number}","events_url":"https://api.github.com/repos/solson/miri/events","assignees_url":"https://api.github.com/repos/solson/miri/assignees{/user}","branches_url":"https://api.github.com/repos/solson/miri/branches{/branch}","tags_url":"https://api.github.com/repos/solson/miri/tags","blobs_url":"https://api.github.com/repos/solson/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solson/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solson/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/solson/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solson/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/solson/miri/languages","stargazers_url":"https://api.github.com/repos/solson/miri/stargazers","contributors_url":"https://api.github.com/repos/solson/miri/contributors","subscribers_url":"https://api.github.com/repos/solson/miri/subscribers","subscription_url":"https://api.github.com/repos/solson/miri/subscription","commits_url":"https://api.github.com/repos/solson/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/solson/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/solson/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/solson/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/solson/miri/contents/{+path}","compare_url":"https://api.github.com/repos/solson/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solson/miri/merges","archive_url":"https://api.github.com/repos/solson/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solson/miri/downloads","issues_url":"https://api.github.com/repos/solson/miri/issues{/number}","pulls_url":"https://api.github.com/repos/solson/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/solson/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/solson/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solson/miri/labels{/name}","releases_url":"https://api.github.com/repos/solson/miri/releases{/id}","deployments_url":"https://api.github.com/repos/solson/miri/deployments","created_at":"2015-11-12T21:51:25Z","updated_at":"2016-06-23T14:06:08Z","pushed_at":"2016-06-23T13:46:31Z","git_url":"git://github.com/solson/miri.git","ssh_url":"git@github.com:solson/miri.git","clone_url":"https://github.com/solson/miri.git","svn_url":"https://github.com/solson/miri","homepage":"","size":668,"stargazers_count":74,"watchers_count":74,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":10,"forks":13,"open_issues":10,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/36"},"html":{"href":"https://github.com/solson/miri/pull/36"},"issue":{"href":"https://api.github.com/repos/solson/miri/issues/36"},"comments":{"href":"https://api.github.com/repos/solson/miri/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/solson/miri/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/solson/miri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solson/miri/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/solson/miri/statuses/e23fdd1f4951165be7e3b604be6ba742027b0b94"}}}}
{"actor":{"display_login":"solson"}}