{"action":"created","issue":{"url":"https://api.github.com/repos/osuosl/streamwebs/issues/35","repository_url":"https://api.github.com/repos/osuosl/streamwebs","labels_url":"https://api.github.com/repos/osuosl/streamwebs/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/osuosl/streamwebs/issues/35/comments","events_url":"https://api.github.com/repos/osuosl/streamwebs/issues/35/events","html_url":"https://github.com/osuosl/streamwebs/pull/35","id":158020712,"number":35,"title":"Datasheet: Water Quality Model","user":{"login":"athai","id":6801364,"avatar_url":"https://avatars.githubusercontent.com/u/6801364?v=3","gravatar_id":"","url":"https://api.github.com/users/athai","html_url":"https://github.com/athai","followers_url":"https://api.github.com/users/athai/followers","following_url":"https://api.github.com/users/athai/following{/other_user}","gists_url":"https://api.github.com/users/athai/gists{/gist_id}","starred_url":"https://api.github.com/users/athai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athai/subscriptions","organizations_url":"https://api.github.com/users/athai/orgs","repos_url":"https://api.github.com/users/athai/repos","events_url":"https://api.github.com/users/athai/events{/privacy}","received_events_url":"https://api.github.com/users/athai/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/osuosl/streamwebs/labels/Ready%20for%20Review","name":"Ready for Review","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/osuosl/streamwebs/milestones/1","html_url":"https://github.com/osuosl/streamwebs/milestones/Sprint%202","labels_url":"https://api.github.com/repos/osuosl/streamwebs/milestones/1/labels","id":1839346,"number":1,"title":"Sprint 2","description":"1) Finish and merge the user model from sprint 1\r\n2) Finish and merge any remaining docs from sprint 1\r\n3) Test and implement (a goal of) three datasheets -- complete the template, model, and view for each","creator":{"login":"athai","id":6801364,"avatar_url":"https://avatars.githubusercontent.com/u/6801364?v=3","gravatar_id":"","url":"https://api.github.com/users/athai","html_url":"https://github.com/athai","followers_url":"https://api.github.com/users/athai/followers","following_url":"https://api.github.com/users/athai/following{/other_user}","gists_url":"https://api.github.com/users/athai/gists{/gist_id}","starred_url":"https://api.github.com/users/athai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athai/subscriptions","organizations_url":"https://api.github.com/users/athai/orgs","repos_url":"https://api.github.com/users/athai/repos","events_url":"https://api.github.com/users/athai/events{/privacy}","received_events_url":"https://api.github.com/users/athai/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":6,"state":"open","created_at":"2016-06-20T22:08:30Z","updated_at":"2016-06-28T22:49:28Z","due_on":"2016-07-05T07:00:00Z","closed_at":null},"comments":4,"created_at":"2016-06-01T22:24:47Z","updated_at":"2016-06-29T19:29:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/osuosl/streamwebs/pulls/35","html_url":"https://github.com/osuosl/streamwebs/pull/35","diff_url":"https://github.com/osuosl/streamwebs/pull/35.diff","patch_url":"https://github.com/osuosl/streamwebs/pull/35.patch"},"body":"Fixes issue #21 \r\n\r\n## Changes in this PR.\r\n<!--\r\n  Please include a list of all things this PR will accomplish\r\n  Use the checkbox syntax to show what is done and what is yet to be completed.\r\n  This gives context to the diff.\r\n-->\r\n\r\n- [X] Write tests for the water quality datasheet (model)\r\n- [x] Write tests for the measurements table (containing air_temp, water_temp, celcius, vernier, etc.)\r\n- [x] Implement\r\n\r\n## Testing this PR.\r\n<!--\r\n  Please include a list of explicit instructions for testing this PR.\r\n  If the instructions are 'run `make test`' say that,\r\n  If they are more complicated be thorough.\r\n-->\r\n\r\n1. Run ``docker-compose run web bash`` to open up an interactive shell\r\n2. Cd to streamwebs_front/\r\n3. Run ``python manage.py test streamwebs/tests/models`` \r\n\r\n### Expected Output.\r\n<!--\r\n  Please insert either a description of what should happen when testing\r\n  your PR or a code-block with terminal output.\r\n\r\n-->\r\nTests pass w/ the following output --\r\n```\r\n(venv) [root@dbcc3dfd733a streamwebs_frontend]# python manage.py test streamwebs/tests/models/\r\nCreating test database for alias 'default'...\r\n....................\r\n----------------------------------------------------------------------\r\nRan 20 tests in 0.471s\r\n\r\nOK\r\nDestroying test database for alias 'default'...\r\n```\r\n\r\n**UPDATED**\r\nThe water quality model (and associated tests) have been rewritten to better reflect the way the views *should* look/work. So rather than abstracting out a measurements table, foreign key relations are being made between the datasheet and its corresponding samples instead.\r\n\r\n* Here's what part of the data entry (on the admin panel) looks like: http://i.imgur.com/1O1WEfW.png\r\n* ``sample_<number>`` is where the user the user will fill out the necessary sample info. That form will look like this:  http://i.imgur.com/JvPMzMA.png"},"comment":{"url":"https://api.github.com/repos/osuosl/streamwebs/issues/comments/229462697","html_url":"https://github.com/osuosl/streamwebs/pull/35#issuecomment-229462697","issue_url":"https://api.github.com/repos/osuosl/streamwebs/issues/35","id":229462697,"user":{"login":"subnomo","id":1390653,"avatar_url":"https://avatars.githubusercontent.com/u/1390653?v=3","gravatar_id":"","url":"https://api.github.com/users/subnomo","html_url":"https://github.com/subnomo","followers_url":"https://api.github.com/users/subnomo/followers","following_url":"https://api.github.com/users/subnomo/following{/other_user}","gists_url":"https://api.github.com/users/subnomo/gists{/gist_id}","starred_url":"https://api.github.com/users/subnomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subnomo/subscriptions","organizations_url":"https://api.github.com/users/subnomo/orgs","repos_url":"https://api.github.com/users/subnomo/repos","events_url":"https://api.github.com/users/subnomo/events{/privacy}","received_events_url":"https://api.github.com/users/subnomo/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T19:29:39Z","updated_at":"2016-06-29T19:29:39Z","body":"Small suggestion, other than that, looks good :+1: "}}
{"actor":{"display_login":"subnomo"}}