{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/hawkbit/pulls/comments/59165182","id":59165182,"diff_hunk":"@@ -38,38 +37,31 @@\n     protected void doBegin(final Object transaction, final TransactionDefinition definition) {\n         super.doBegin(transaction, definition);\n \n+        // ignore transactions on tenant independent calls","path":"hawkbit-repository/src/main/java/org/eclipse/hawkbit/MultiTenantJpaTransactionManager.java","position":12,"original_position":12,"commit_id":"cf8e4fd2fd55909a8fe66c43a2e59d422da1596e","original_commit_id":"cf8e4fd2fd55909a8fe66c43a2e59d422da1596e","user":{"login":"SirWayne","id":6340898,"avatar_url":"https://avatars.githubusercontent.com/u/6340898?v=3","gravatar_id":"","url":"https://api.github.com/users/SirWayne","html_url":"https://github.com/SirWayne","followers_url":"https://api.github.com/users/SirWayne/followers","following_url":"https://api.github.com/users/SirWayne/following{/other_user}","gists_url":"https://api.github.com/users/SirWayne/gists{/gist_id}","starred_url":"https://api.github.com/users/SirWayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirWayne/subscriptions","organizations_url":"https://api.github.com/users/SirWayne/orgs","repos_url":"https://api.github.com/users/SirWayne/repos","events_url":"https://api.github.com/users/SirWayne/events{/privacy}","received_events_url":"https://api.github.com/users/SirWayne/received_events","type":"User","site_admin":false},"body":"For this comment you can write a method, which explains the code e.g. `isTenantIndependent`","created_at":"2016-04-11T07:50:11Z","updated_at":"2016-04-11T07:50:11Z","html_url":"https://github.com/eclipse/hawkbit/pull/132#discussion_r59165182","pull_request_url":"https://api.github.com/repos/eclipse/hawkbit/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/comments/59165182"},"html":{"href":"https://github.com/eclipse/hawkbit/pull/132#discussion_r59165182"},"pull_request":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/hawkbit/pulls/132","id":65734550,"html_url":"https://github.com/eclipse/hawkbit/pull/132","diff_url":"https://github.com/eclipse/hawkbit/pull/132.diff","patch_url":"https://github.com/eclipse/hawkbit/pull/132.patch","issue_url":"https://api.github.com/repos/eclipse/hawkbit/issues/132","number":132,"state":"open","locked":false,"title":"Eclipselink tenancy","user":{"login":"kaizimmerm","id":9153035,"avatar_url":"https://avatars.githubusercontent.com/u/9153035?v=3","gravatar_id":"","url":"https://api.github.com/users/kaizimmerm","html_url":"https://github.com/kaizimmerm","followers_url":"https://api.github.com/users/kaizimmerm/followers","following_url":"https://api.github.com/users/kaizimmerm/following{/other_user}","gists_url":"https://api.github.com/users/kaizimmerm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaizimmerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaizimmerm/subscriptions","organizations_url":"https://api.github.com/users/kaizimmerm/orgs","repos_url":"https://api.github.com/users/kaizimmerm/repos","events_url":"https://api.github.com/users/kaizimmerm/events{/privacy}","received_events_url":"https://api.github.com/users/kaizimmerm/received_events","type":"User","site_admin":false},"body":"I removed two of the multi tenancy exceptions. This was rather strange.\r\n\r\n- The rollout management method was in another class and not even transactional anymore. I think the exception is not required (anymore?).\r\n- the getOrCreate tenant method I was not able to find, not even in git history.\r\n\r\nI hate this exception mechanism. It is far to error-prone.\r\n\r\n@SirWayne and @michahirsch I think these two exceptions have been added by you originally. Can you please check if they are still needed and if yes use the correct/current transactional methods.","created_at":"2016-04-08T04:10:59Z","updated_at":"2016-04-11T07:50:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2f73391b2740d383e353c7b0aac165cf38d27c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/hawkbit/pulls/132/commits","review_comments_url":"https://api.github.com/repos/eclipse/hawkbit/pulls/132/comments","review_comment_url":"https://api.github.com/repos/eclipse/hawkbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/hawkbit/issues/132/comments","statuses_url":"https://api.github.com/repos/eclipse/hawkbit/statuses/cf8e4fd2fd55909a8fe66c43a2e59d422da1596e","head":{"label":"bsinno:eclipselink-tenancy","ref":"eclipselink-tenancy","sha":"cf8e4fd2fd55909a8fe66c43a2e59d422da1596e","user":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":50108079,"name":"hawkbit","full_name":"bsinno/hawkbit","owner":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsinno/hawkbit","description":"","fork":true,"url":"https://api.github.com/repos/bsinno/hawkbit","forks_url":"https://api.github.com/repos/bsinno/hawkbit/forks","keys_url":"https://api.github.com/repos/bsinno/hawkbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/hawkbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/hawkbit/teams","hooks_url":"https://api.github.com/repos/bsinno/hawkbit/hooks","issue_events_url":"https://api.github.com/repos/bsinno/hawkbit/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/hawkbit/events","assignees_url":"https://api.github.com/repos/bsinno/hawkbit/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/hawkbit/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/hawkbit/tags","blobs_url":"https://api.github.com/repos/bsinno/hawkbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/hawkbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/hawkbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/hawkbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/hawkbit/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/hawkbit/languages","stargazers_url":"https://api.github.com/repos/bsinno/hawkbit/stargazers","contributors_url":"https://api.github.com/repos/bsinno/hawkbit/contributors","subscribers_url":"https://api.github.com/repos/bsinno/hawkbit/subscribers","subscription_url":"https://api.github.com/repos/bsinno/hawkbit/subscription","commits_url":"https://api.github.com/repos/bsinno/hawkbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/hawkbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/hawkbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/hawkbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/hawkbit/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/hawkbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/hawkbit/merges","archive_url":"https://api.github.com/repos/bsinno/hawkbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/hawkbit/downloads","issues_url":"https://api.github.com/repos/bsinno/hawkbit/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/hawkbit/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/hawkbit/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/hawkbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/hawkbit/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/hawkbit/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/hawkbit/deployments","created_at":"2016-01-21T13:05:15Z","updated_at":"2016-03-29T16:29:41Z","pushed_at":"2016-04-11T05:52:03Z","git_url":"git://github.com/bsinno/hawkbit.git","ssh_url":"git@github.com:bsinno/hawkbit.git","clone_url":"https://github.com/bsinno/hawkbit.git","svn_url":"https://github.com/bsinno/hawkbit","homepage":null,"size":3476,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"cadf67ad6c8beafe24f805a3b6c592a03fe90865","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":45860898,"name":"hawkbit","full_name":"eclipse/hawkbit","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/hawkbit","description":"","fork":false,"url":"https://api.github.com/repos/eclipse/hawkbit","forks_url":"https://api.github.com/repos/eclipse/hawkbit/forks","keys_url":"https://api.github.com/repos/eclipse/hawkbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/hawkbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/hawkbit/teams","hooks_url":"https://api.github.com/repos/eclipse/hawkbit/hooks","issue_events_url":"https://api.github.com/repos/eclipse/hawkbit/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/hawkbit/events","assignees_url":"https://api.github.com/repos/eclipse/hawkbit/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/hawkbit/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/hawkbit/tags","blobs_url":"https://api.github.com/repos/eclipse/hawkbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/hawkbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/hawkbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/hawkbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/hawkbit/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/hawkbit/languages","stargazers_url":"https://api.github.com/repos/eclipse/hawkbit/stargazers","contributors_url":"https://api.github.com/repos/eclipse/hawkbit/contributors","subscribers_url":"https://api.github.com/repos/eclipse/hawkbit/subscribers","subscription_url":"https://api.github.com/repos/eclipse/hawkbit/subscription","commits_url":"https://api.github.com/repos/eclipse/hawkbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/hawkbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/hawkbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/hawkbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/hawkbit/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/hawkbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/hawkbit/merges","archive_url":"https://api.github.com/repos/eclipse/hawkbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/hawkbit/downloads","issues_url":"https://api.github.com/repos/eclipse/hawkbit/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/hawkbit/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/hawkbit/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/hawkbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/hawkbit/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/hawkbit/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/hawkbit/deployments","created_at":"2015-11-09T19:19:06Z","updated_at":"2016-04-08T15:19:30Z","pushed_at":"2016-04-11T06:58:21Z","git_url":"git://github.com/eclipse/hawkbit.git","ssh_url":"git@github.com:eclipse/hawkbit.git","clone_url":"https://github.com/eclipse/hawkbit.git","svn_url":"https://github.com/eclipse/hawkbit","homepage":null,"size":3717,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/132"},"html":{"href":"https://github.com/eclipse/hawkbit/pull/132"},"issue":{"href":"https://api.github.com/repos/eclipse/hawkbit/issues/132"},"comments":{"href":"https://api.github.com/repos/eclipse/hawkbit/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/hawkbit/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/hawkbit/statuses/cf8e4fd2fd55909a8fe66c43a2e59d422da1596e"}}}}