{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan/pulls/comments/93458475","pull_request_review_id":13979854,"id":93458475,"diff_hunk":"@@ -368,26 +368,33 @@ inline String<int> _getNumbersFromString(std::string const & str)\n // Function _readVersionString()\n // ----------------------------------------------------------------------------\n \n-inline std::string _readVersionString(VersionCheck & me, std::string const & version_file)\n+inline void _readVersionStrings(std::vector<std::string> & versions,\n+                                VersionCheck & me,\n+                                std::string const & version_file)\n {\n     std::ifstream myfile;\n     myfile.open(version_file.c_str());\n-    std::string line;\n+    std::string app_version;\n+    std::string seqan_version;\n     if (myfile.is_open())\n     {\n-        std::getline(myfile,line); // get first line which should only contain the version number\n-        if (!(std::regex_match(line, std::regex(\"^[[:digit:]]+\\\\.[[:digit:]]+\\\\.[[:digit:]]+$\"))))\n-        {\n-            line.clear();\n-        }\n-        if (line == VersionControlTags_<>::UNREGISTERED_APP)\n-        {\n+        std::getline(myfile, app_version); // get first line which should only contain the version number of the app\n+\n+#if !defined(NDEBUG) || defined(SEQAN_TEST_VERSION_CHECK_)\n+        if (app_version == VersionControlTags_<>::UNREGISTERED_APP)\n             me.errorStream << VersionControlTags_<>::MESSAGE_UNREGISTERED_APP;\n-            line.clear();\n-        }\n+#endif // !defined(NDEBUG) || defined(SEQAN_TEST_VERSION_CHECK_)\n+\n+        if (std::regex_match(app_version, std::regex(\"^[[:digit:]]+\\\\.[[:digit:]]+\\\\.[[:digit:]]+$\")))\n+            versions[0] = app_version;","path":"include/seqan/arg_parse/arg_parse_version_check.h","position":42,"original_position":42,"commit_id":"cc0a5a67ae6d4fd7f71a699fc4e42885570217ae","original_commit_id":"cc0a5a67ae6d4fd7f71a699fc4e42885570217ae","user":{"login":"rrahn","id":1529364,"avatar_url":"https://avatars.githubusercontent.com/u/1529364?v=3","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"body":"this can be put into the debug mode section","created_at":"2016-12-21T15:27:48Z","updated_at":"2016-12-21T15:27:48Z","html_url":"https://github.com/seqan/seqan/pull/1983#discussion_r93458475","pull_request_url":"https://api.github.com/repos/seqan/seqan/pulls/1983","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan/pulls/comments/93458475"},"html":{"href":"https://github.com/seqan/seqan/pull/1983#discussion_r93458475"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan/pulls/1983"}}},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan/pulls/1983","id":98908091,"html_url":"https://github.com/seqan/seqan/pull/1983","diff_url":"https://github.com/seqan/seqan/pull/1983.diff","patch_url":"https://github.com/seqan/seqan/pull/1983.patch","issue_url":"https://api.github.com/repos/seqan/seqan/issues/1983","number":1983,"state":"open","locked":false,"title":"[HOTFIX] Change Version Check Option to bool and manage messages via macros.","user":{"login":"smehringer","id":7955878,"avatar_url":"https://avatars.githubusercontent.com/u/7955878?v=3","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"body":"This includes the following changes:\r\n- the version-check option is now a bool and can be turned off/on by specifying off/on/yes/no/1/0...\r\n- The server is only once asked for the current versions of both app and library (result is stored in one app.version file. This might fix #1980 since it could be cause by file handling conflicts of the seqan.version file)\r\n- The command line messages were restricted in the following way:\r\n   - app users will not be notified of new library versions, nor whether the app is not registered\r\n   - app developers (DEBUG mode) will not be notified about \"new app versions\" they are working on, but only on new library versions and whether they want to register their app to priovide easy version updates for their users","created_at":"2016-12-21T10:32:40Z","updated_at":"2016-12-21T15:30:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"179158512481557a0d4ce7243e86929e4ed6bf51","assignee":{"login":"rrahn","id":1529364,"avatar_url":"https://avatars.githubusercontent.com/u/1529364?v=3","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"assignees":[{"login":"rrahn","id":1529364,"avatar_url":"https://avatars.githubusercontent.com/u/1529364?v=3","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan/pulls/1983/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan/pulls/1983/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan/issues/1983/comments","statuses_url":"https://api.github.com/repos/seqan/seqan/statuses/cc0a5a67ae6d4fd7f71a699fc4e42885570217ae","head":{"label":"smehringer:hotfix/version_check_benhaviour","ref":"hotfix/version_check_benhaviour","sha":"cc0a5a67ae6d4fd7f71a699fc4e42885570217ae","user":{"login":"smehringer","id":7955878,"avatar_url":"https://avatars.githubusercontent.com/u/7955878?v=3","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"repo":{"id":36857370,"name":"seqan","full_name":"smehringer/seqan","owner":{"login":"smehringer","id":7955878,"avatar_url":"https://avatars.githubusercontent.com/u/7955878?v=3","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smehringer/seqan","description":"SeqAn's official repository.","fork":true,"url":"https://api.github.com/repos/smehringer/seqan","forks_url":"https://api.github.com/repos/smehringer/seqan/forks","keys_url":"https://api.github.com/repos/smehringer/seqan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smehringer/seqan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smehringer/seqan/teams","hooks_url":"https://api.github.com/repos/smehringer/seqan/hooks","issue_events_url":"https://api.github.com/repos/smehringer/seqan/issues/events{/number}","events_url":"https://api.github.com/repos/smehringer/seqan/events","assignees_url":"https://api.github.com/repos/smehringer/seqan/assignees{/user}","branches_url":"https://api.github.com/repos/smehringer/seqan/branches{/branch}","tags_url":"https://api.github.com/repos/smehringer/seqan/tags","blobs_url":"https://api.github.com/repos/smehringer/seqan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smehringer/seqan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smehringer/seqan/git/refs{/sha}","trees_url":"https://api.github.com/repos/smehringer/seqan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smehringer/seqan/statuses/{sha}","languages_url":"https://api.github.com/repos/smehringer/seqan/languages","stargazers_url":"https://api.github.com/repos/smehringer/seqan/stargazers","contributors_url":"https://api.github.com/repos/smehringer/seqan/contributors","subscribers_url":"https://api.github.com/repos/smehringer/seqan/subscribers","subscription_url":"https://api.github.com/repos/smehringer/seqan/subscription","commits_url":"https://api.github.com/repos/smehringer/seqan/commits{/sha}","git_commits_url":"https://api.github.com/repos/smehringer/seqan/git/commits{/sha}","comments_url":"https://api.github.com/repos/smehringer/seqan/comments{/number}","issue_comment_url":"https://api.github.com/repos/smehringer/seqan/issues/comments{/number}","contents_url":"https://api.github.com/repos/smehringer/seqan/contents/{+path}","compare_url":"https://api.github.com/repos/smehringer/seqan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smehringer/seqan/merges","archive_url":"https://api.github.com/repos/smehringer/seqan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smehringer/seqan/downloads","issues_url":"https://api.github.com/repos/smehringer/seqan/issues{/number}","pulls_url":"https://api.github.com/repos/smehringer/seqan/pulls{/number}","milestones_url":"https://api.github.com/repos/smehringer/seqan/milestones{/number}","notifications_url":"https://api.github.com/repos/smehringer/seqan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smehringer/seqan/labels{/name}","releases_url":"https://api.github.com/repos/smehringer/seqan/releases{/id}","deployments_url":"https://api.github.com/repos/smehringer/seqan/deployments","created_at":"2015-06-04T08:16:07Z","updated_at":"2016-03-07T16:20:35Z","pushed_at":"2016-12-21T10:21:53Z","git_url":"git://github.com/smehringer/seqan.git","ssh_url":"git@github.com:smehringer/seqan.git","clone_url":"https://github.com/smehringer/seqan.git","svn_url":"https://github.com/smehringer/seqan","homepage":"www.seqan.de","size":151445,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"eecbb982c29815cd04837802f45391578458bc3c","user":{"login":"seqan","id":1752144,"avatar_url":"https://avatars.githubusercontent.com/u/1752144?v=3","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":6383869,"name":"seqan","full_name":"seqan/seqan","owner":{"login":"seqan","id":1752144,"avatar_url":"https://avatars.githubusercontent.com/u/1752144?v=3","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seqan/seqan","description":"SeqAn's official repository.","fork":false,"url":"https://api.github.com/repos/seqan/seqan","forks_url":"https://api.github.com/repos/seqan/seqan/forks","keys_url":"https://api.github.com/repos/seqan/seqan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan/teams","hooks_url":"https://api.github.com/repos/seqan/seqan/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan/events","assignees_url":"https://api.github.com/repos/seqan/seqan/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan/tags","blobs_url":"https://api.github.com/repos/seqan/seqan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan/subscription","commits_url":"https://api.github.com/repos/seqan/seqan/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan/merges","archive_url":"https://api.github.com/repos/seqan/seqan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan/downloads","issues_url":"https://api.github.com/repos/seqan/seqan/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan/deployments","created_at":"2012-10-25T08:02:15Z","updated_at":"2016-12-06T20:14:05Z","pushed_at":"2016-12-21T10:32:41Z","git_url":"git://github.com/seqan/seqan.git","ssh_url":"git@github.com:seqan/seqan.git","clone_url":"https://github.com/seqan/seqan.git","svn_url":"https://github.com/seqan/seqan","homepage":"www.seqan.de","size":150738,"stargazers_count":173,"watchers_count":173,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":129,"forks":91,"open_issues":129,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan/pulls/1983"},"html":{"href":"https://github.com/seqan/seqan/pull/1983"},"issue":{"href":"https://api.github.com/repos/seqan/seqan/issues/1983"},"comments":{"href":"https://api.github.com/repos/seqan/seqan/issues/1983/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan/pulls/1983/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan/pulls/1983/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan/statuses/cc0a5a67ae6d4fd7f71a699fc4e42885570217ae"}}}}
{"actor":{"display_login":"rrahn"}}