{"action":"closed","number":270,"pull_request":{"url":"https://api.github.com/repos/brndnmtthws/conky/pulls/270","id":71497578,"html_url":"https://github.com/brndnmtthws/conky/pull/270","diff_url":"https://github.com/brndnmtthws/conky/pull/270.diff","patch_url":"https://github.com/brndnmtthws/conky/pull/270.patch","issue_url":"https://api.github.com/repos/brndnmtthws/conky/issues/270","number":270,"state":"closed","locked":false,"title":"Rewrite the nvidia docs and add the rest of the arguments to nvidia_barval","user":{"login":"MattSturgeon","id":5046562,"avatar_url":"https://avatars.githubusercontent.com/u/5046562?v=3","gravatar_id":"","url":"https://api.github.com/users/MattSturgeon","html_url":"https://github.com/MattSturgeon","followers_url":"https://api.github.com/users/MattSturgeon/followers","following_url":"https://api.github.com/users/MattSturgeon/following{/other_user}","gists_url":"https://api.github.com/users/MattSturgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/MattSturgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattSturgeon/subscriptions","organizations_url":"https://api.github.com/users/MattSturgeon/orgs","repos_url":"https://api.github.com/users/MattSturgeon/repos","events_url":"https://api.github.com/users/MattSturgeon/events{/privacy}","received_events_url":"https://api.github.com/users/MattSturgeon/received_events","type":"User","site_admin":false},"body":"**Warning: Largely untested** - I have compiled and run with these changes, and I have compiled the docs to HTML, but since I'm away from my main (nvidia) machine, that's the limit of what I've been able to test. There may be runtime bugs lurking in my code changes, but I've tried to keep everything simple and readable :)\r\n\r\n#### Updated the docs in variables.xml to reflect the current nvidia object.\r\n\r\nBasically just copied the inline comments into the XML document\r\n\r\nOnly thing I'm not sure about is the spacing rendered between columns in the `<simplelist/>` table.\r\n\r\n#### Added the last of the compatible nvidia arguments to nvidiabar\r\n\r\nThe following arguments were added to `get_nvidia_barval`:\r\n\r\n* memfree\r\n* ambienttemp\r\n* gpufreq\r\n* memfreq\r\n* mtrfreq\r\n* imagequality\r\n\r\nThis should leave only incompatible arguments unsupported (e.g. min/max values - see new docs).\r\n\r\nDecided to base percentages off of zero rather than the specified minimum values.\r\n\r\n#### Coming soon...\r\n\r\nI've also [done some work][1] on adding some error messages to `$nvidia`*, so far only where I've made changes already but I might look into adding some other error messages if needed.\r\n\r\n[1]: /MattSturgeon/conky/compare/nvidia-ext1...MattSturgeon:nvidia-debug","created_at":"2016-05-26T04:06:11Z","updated_at":"2016-06-04T04:58:22Z","closed_at":"2016-06-04T04:58:22Z","merged_at":null,"merge_commit_sha":"2139a82c4091e07dee5cf645ca3637244414723c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/270/commits","review_comments_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/270/comments","review_comment_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brndnmtthws/conky/issues/270/comments","statuses_url":"https://api.github.com/repos/brndnmtthws/conky/statuses/7877dd98cd167d46aa3ffe65c25a2abe1936e884","head":{"label":"MattSturgeon:nvidia-ext1","ref":"nvidia-ext1","sha":"7877dd98cd167d46aa3ffe65c25a2abe1936e884","user":{"login":"MattSturgeon","id":5046562,"avatar_url":"https://avatars.githubusercontent.com/u/5046562?v=3","gravatar_id":"","url":"https://api.github.com/users/MattSturgeon","html_url":"https://github.com/MattSturgeon","followers_url":"https://api.github.com/users/MattSturgeon/followers","following_url":"https://api.github.com/users/MattSturgeon/following{/other_user}","gists_url":"https://api.github.com/users/MattSturgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/MattSturgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattSturgeon/subscriptions","organizations_url":"https://api.github.com/users/MattSturgeon/orgs","repos_url":"https://api.github.com/users/MattSturgeon/repos","events_url":"https://api.github.com/users/MattSturgeon/events{/privacy}","received_events_url":"https://api.github.com/users/MattSturgeon/received_events","type":"User","site_admin":false},"repo":{"id":51945372,"name":"conky","full_name":"MattSturgeon/conky","owner":{"login":"MattSturgeon","id":5046562,"avatar_url":"https://avatars.githubusercontent.com/u/5046562?v=3","gravatar_id":"","url":"https://api.github.com/users/MattSturgeon","html_url":"https://github.com/MattSturgeon","followers_url":"https://api.github.com/users/MattSturgeon/followers","following_url":"https://api.github.com/users/MattSturgeon/following{/other_user}","gists_url":"https://api.github.com/users/MattSturgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/MattSturgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattSturgeon/subscriptions","organizations_url":"https://api.github.com/users/MattSturgeon/orgs","repos_url":"https://api.github.com/users/MattSturgeon/repos","events_url":"https://api.github.com/users/MattSturgeon/events{/privacy}","received_events_url":"https://api.github.com/users/MattSturgeon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattSturgeon/conky","description":"Light-weight system monitor for X.","fork":true,"url":"https://api.github.com/repos/MattSturgeon/conky","forks_url":"https://api.github.com/repos/MattSturgeon/conky/forks","keys_url":"https://api.github.com/repos/MattSturgeon/conky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattSturgeon/conky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattSturgeon/conky/teams","hooks_url":"https://api.github.com/repos/MattSturgeon/conky/hooks","issue_events_url":"https://api.github.com/repos/MattSturgeon/conky/issues/events{/number}","events_url":"https://api.github.com/repos/MattSturgeon/conky/events","assignees_url":"https://api.github.com/repos/MattSturgeon/conky/assignees{/user}","branches_url":"https://api.github.com/repos/MattSturgeon/conky/branches{/branch}","tags_url":"https://api.github.com/repos/MattSturgeon/conky/tags","blobs_url":"https://api.github.com/repos/MattSturgeon/conky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattSturgeon/conky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattSturgeon/conky/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattSturgeon/conky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattSturgeon/conky/statuses/{sha}","languages_url":"https://api.github.com/repos/MattSturgeon/conky/languages","stargazers_url":"https://api.github.com/repos/MattSturgeon/conky/stargazers","contributors_url":"https://api.github.com/repos/MattSturgeon/conky/contributors","subscribers_url":"https://api.github.com/repos/MattSturgeon/conky/subscribers","subscription_url":"https://api.github.com/repos/MattSturgeon/conky/subscription","commits_url":"https://api.github.com/repos/MattSturgeon/conky/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattSturgeon/conky/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattSturgeon/conky/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattSturgeon/conky/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattSturgeon/conky/contents/{+path}","compare_url":"https://api.github.com/repos/MattSturgeon/conky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattSturgeon/conky/merges","archive_url":"https://api.github.com/repos/MattSturgeon/conky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattSturgeon/conky/downloads","issues_url":"https://api.github.com/repos/MattSturgeon/conky/issues{/number}","pulls_url":"https://api.github.com/repos/MattSturgeon/conky/pulls{/number}","milestones_url":"https://api.github.com/repos/MattSturgeon/conky/milestones{/number}","notifications_url":"https://api.github.com/repos/MattSturgeon/conky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattSturgeon/conky/labels{/name}","releases_url":"https://api.github.com/repos/MattSturgeon/conky/releases{/id}","deployments_url":"https://api.github.com/repos/MattSturgeon/conky/deployments","created_at":"2016-02-17T18:31:19Z","updated_at":"2016-02-17T18:31:22Z","pushed_at":"2016-06-04T04:58:22Z","git_url":"git://github.com/MattSturgeon/conky.git","ssh_url":"git@github.com:MattSturgeon/conky.git","clone_url":"https://github.com/MattSturgeon/conky.git","svn_url":"https://github.com/MattSturgeon/conky","homepage":null,"size":14566,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brndnmtthws:master","ref":"master","sha":"7d6004f5908797ff22838b5598f1019fe047621a","user":{"login":"brndnmtthws","id":3129093,"avatar_url":"https://avatars.githubusercontent.com/u/3129093?v=3","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"repo":{"id":7331227,"name":"conky","full_name":"brndnmtthws/conky","owner":{"login":"brndnmtthws","id":3129093,"avatar_url":"https://avatars.githubusercontent.com/u/3129093?v=3","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brndnmtthws/conky","description":"Light-weight system monitor for X.","fork":false,"url":"https://api.github.com/repos/brndnmtthws/conky","forks_url":"https://api.github.com/repos/brndnmtthws/conky/forks","keys_url":"https://api.github.com/repos/brndnmtthws/conky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brndnmtthws/conky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brndnmtthws/conky/teams","hooks_url":"https://api.github.com/repos/brndnmtthws/conky/hooks","issue_events_url":"https://api.github.com/repos/brndnmtthws/conky/issues/events{/number}","events_url":"https://api.github.com/repos/brndnmtthws/conky/events","assignees_url":"https://api.github.com/repos/brndnmtthws/conky/assignees{/user}","branches_url":"https://api.github.com/repos/brndnmtthws/conky/branches{/branch}","tags_url":"https://api.github.com/repos/brndnmtthws/conky/tags","blobs_url":"https://api.github.com/repos/brndnmtthws/conky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brndnmtthws/conky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brndnmtthws/conky/git/refs{/sha}","trees_url":"https://api.github.com/repos/brndnmtthws/conky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brndnmtthws/conky/statuses/{sha}","languages_url":"https://api.github.com/repos/brndnmtthws/conky/languages","stargazers_url":"https://api.github.com/repos/brndnmtthws/conky/stargazers","contributors_url":"https://api.github.com/repos/brndnmtthws/conky/contributors","subscribers_url":"https://api.github.com/repos/brndnmtthws/conky/subscribers","subscription_url":"https://api.github.com/repos/brndnmtthws/conky/subscription","commits_url":"https://api.github.com/repos/brndnmtthws/conky/commits{/sha}","git_commits_url":"https://api.github.com/repos/brndnmtthws/conky/git/commits{/sha}","comments_url":"https://api.github.com/repos/brndnmtthws/conky/comments{/number}","issue_comment_url":"https://api.github.com/repos/brndnmtthws/conky/issues/comments{/number}","contents_url":"https://api.github.com/repos/brndnmtthws/conky/contents/{+path}","compare_url":"https://api.github.com/repos/brndnmtthws/conky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brndnmtthws/conky/merges","archive_url":"https://api.github.com/repos/brndnmtthws/conky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brndnmtthws/conky/downloads","issues_url":"https://api.github.com/repos/brndnmtthws/conky/issues{/number}","pulls_url":"https://api.github.com/repos/brndnmtthws/conky/pulls{/number}","milestones_url":"https://api.github.com/repos/brndnmtthws/conky/milestones{/number}","notifications_url":"https://api.github.com/repos/brndnmtthws/conky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brndnmtthws/conky/labels{/name}","releases_url":"https://api.github.com/repos/brndnmtthws/conky/releases{/id}","deployments_url":"https://api.github.com/repos/brndnmtthws/conky/deployments","created_at":"2012-12-26T19:50:17Z","updated_at":"2016-06-03T19:49:49Z","pushed_at":"2016-05-28T00:41:55Z","git_url":"git://github.com/brndnmtthws/conky.git","ssh_url":"git@github.com:brndnmtthws/conky.git","clone_url":"https://github.com/brndnmtthws/conky.git","svn_url":"https://github.com/brndnmtthws/conky","homepage":null,"size":15969,"stargazers_count":823,"watchers_count":823,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":125,"forks":152,"open_issues":125,"watchers":823,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/270"},"html":{"href":"https://github.com/brndnmtthws/conky/pull/270"},"issue":{"href":"https://api.github.com/repos/brndnmtthws/conky/issues/270"},"comments":{"href":"https://api.github.com/repos/brndnmtthws/conky/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/brndnmtthws/conky/statuses/7877dd98cd167d46aa3ffe65c25a2abe1936e884"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":265,"deletions":31,"changed_files":2}}
{"actor":{"display_login":"MattSturgeon"}}