{"action":"opened","issue":{"url":"https://api.github.com/repos/spring-projects/spring-session/issues/626","repository_url":"https://api.github.com/repos/spring-projects/spring-session","labels_url":"https://api.github.com/repos/spring-projects/spring-session/issues/626/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-session/issues/626/comments","events_url":"https://api.github.com/repos/spring-projects/spring-session/issues/626/events","html_url":"https://github.com/spring-projects/spring-session/issues/626","id":176542550,"number":626,"title":"config command leaks","user":{"login":"hikoma","id":366073,"avatar_url":"https://avatars.githubusercontent.com/u/366073?v=3","gravatar_id":"","url":"https://api.github.com/users/hikoma","html_url":"https://github.com/hikoma","followers_url":"https://api.github.com/users/hikoma/followers","following_url":"https://api.github.com/users/hikoma/following{/other_user}","gists_url":"https://api.github.com/users/hikoma/gists{/gist_id}","starred_url":"https://api.github.com/users/hikoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hikoma/subscriptions","organizations_url":"https://api.github.com/users/hikoma/orgs","repos_url":"https://api.github.com/users/hikoma/repos","events_url":"https://api.github.com/users/hikoma/events{/privacy}","received_events_url":"https://api.github.com/users/hikoma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-13T03:54:51Z","updated_at":"2016-09-13T03:54:51Z","closed_at":null,"body":"I use spring-session 1.2.1 with springboot 1.4.0.\r\nI check client list using redis-cli, config command does not closed.\r\n\r\n```\r\n127.0.0.1:6379> client list\r\nid=388 addr=127.0.0.1:37054 fd=5 name= age=682 idle=667 flags=N db=0 sub=0 psub=0 multi=-1 qbuf=0 qbuf-free=0 obl=0 oll=0 omem=0 events=r cmd=config\r\n```\r\n\r\nI guess EnableRedisKeyspaceNotificationsInitializer should be close after configure.\r\n\r\n```\r\n\tstatic class EnableRedisKeyspaceNotificationsInitializer implements InitializingBean {\r\n\t\tprivate final RedisConnectionFactory connectionFactory;\r\n\r\n\t\tprivate ConfigureRedisAction configure;\r\n\r\n\t\tEnableRedisKeyspaceNotificationsInitializer(\r\n\t\t\t\tRedisConnectionFactory connectionFactory,\r\n\t\t\t\tConfigureRedisAction configure) {\r\n\t\t\tthis.connectionFactory = connectionFactory;\r\n\t\t\tthis.configure = configure;\r\n\t\t}\r\n\r\n\t\tpublic void afterPropertiesSet() throws Exception {\r\n\t\t\tRedisConnection connection = this.connectionFactory.getConnection();\r\n\t\t\tthis.configure.configure(connection);\r\n\t\t}\r\n\t}\r\n```"}}
{"actor":{"display_login":"hikoma"}}