{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls/25","id":48800108,"html_url":"https://github.com/PHPGangsta/GoogleAuthenticator/pull/25","diff_url":"https://github.com/PHPGangsta/GoogleAuthenticator/pull/25.diff","patch_url":"https://github.com/PHPGangsta/GoogleAuthenticator/pull/25.patch","issue_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/issues/25","number":25,"state":"closed","locked":false,"title":"Avoid timing attacks and fix #24","user":{"login":"leandro-lugaresi","id":858713,"avatar_url":"https://avatars.githubusercontent.com/u/858713?v=3","gravatar_id":"","url":"https://api.github.com/users/leandro-lugaresi","html_url":"https://github.com/leandro-lugaresi","followers_url":"https://api.github.com/users/leandro-lugaresi/followers","following_url":"https://api.github.com/users/leandro-lugaresi/following{/other_user}","gists_url":"https://api.github.com/users/leandro-lugaresi/gists{/gist_id}","starred_url":"https://api.github.com/users/leandro-lugaresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leandro-lugaresi/subscriptions","organizations_url":"https://api.github.com/users/leandro-lugaresi/orgs","repos_url":"https://api.github.com/users/leandro-lugaresi/repos","events_url":"https://api.github.com/users/leandro-lugaresi/events{/privacy}","received_events_url":"https://api.github.com/users/leandro-lugaresi/received_events","type":"User","site_admin":false},"body":"Time attacks can be used to improve one Brute Force attack\r\nMore info can be found here:\r\nhttp://blog.ircmaxell.com/2014/11/its-all-about-time.html\r\nhttp://sakurity.com/blog/2015/07/18/2fa.html\r\n\r\nThis comparison will also avoid the problem of leading zeros  (#24) :)","created_at":"2015-10-26T21:30:32Z","updated_at":"2016-10-08T12:43:03Z","closed_at":"2016-10-08T12:43:03Z","merged_at":"2016-10-08T12:43:03Z","merge_commit_sha":"62ccff4baf48c868eabfbdb8697cfb33d51a8f7a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls/25/commits","review_comments_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls/25/comments","review_comment_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/issues/25/comments","statuses_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/statuses/546a0e2d4e5d70f82910c5ad37161a0eddb1ecb8","head":{"label":"leandro-lugaresi:master","ref":"master","sha":"546a0e2d4e5d70f82910c5ad37161a0eddb1ecb8","user":{"login":"leandro-lugaresi","id":858713,"avatar_url":"https://avatars.githubusercontent.com/u/858713?v=3","gravatar_id":"","url":"https://api.github.com/users/leandro-lugaresi","html_url":"https://github.com/leandro-lugaresi","followers_url":"https://api.github.com/users/leandro-lugaresi/followers","following_url":"https://api.github.com/users/leandro-lugaresi/following{/other_user}","gists_url":"https://api.github.com/users/leandro-lugaresi/gists{/gist_id}","starred_url":"https://api.github.com/users/leandro-lugaresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leandro-lugaresi/subscriptions","organizations_url":"https://api.github.com/users/leandro-lugaresi/orgs","repos_url":"https://api.github.com/users/leandro-lugaresi/repos","events_url":"https://api.github.com/users/leandro-lugaresi/events{/privacy}","received_events_url":"https://api.github.com/users/leandro-lugaresi/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"PHPGangsta:master","ref":"master","sha":"b64898d6da9d06dda03a0a82b00c02316d9cd4c8","user":{"login":"PHPGangsta","id":608408,"avatar_url":"https://avatars.githubusercontent.com/u/608408?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPGangsta","html_url":"https://github.com/PHPGangsta","followers_url":"https://api.github.com/users/PHPGangsta/followers","following_url":"https://api.github.com/users/PHPGangsta/following{/other_user}","gists_url":"https://api.github.com/users/PHPGangsta/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPGangsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPGangsta/subscriptions","organizations_url":"https://api.github.com/users/PHPGangsta/orgs","repos_url":"https://api.github.com/users/PHPGangsta/repos","events_url":"https://api.github.com/users/PHPGangsta/events{/privacy}","received_events_url":"https://api.github.com/users/PHPGangsta/received_events","type":"User","site_admin":false},"repo":{"id":3690423,"name":"GoogleAuthenticator","full_name":"PHPGangsta/GoogleAuthenticator","owner":{"login":"PHPGangsta","id":608408,"avatar_url":"https://avatars.githubusercontent.com/u/608408?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPGangsta","html_url":"https://github.com/PHPGangsta","followers_url":"https://api.github.com/users/PHPGangsta/followers","following_url":"https://api.github.com/users/PHPGangsta/following{/other_user}","gists_url":"https://api.github.com/users/PHPGangsta/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPGangsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPGangsta/subscriptions","organizations_url":"https://api.github.com/users/PHPGangsta/orgs","repos_url":"https://api.github.com/users/PHPGangsta/repos","events_url":"https://api.github.com/users/PHPGangsta/events{/privacy}","received_events_url":"https://api.github.com/users/PHPGangsta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PHPGangsta/GoogleAuthenticator","description":"PHP class to generate and verify Google Authenticator 2-factor authentication","fork":false,"url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator","forks_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/forks","keys_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/teams","hooks_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/hooks","issue_events_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/issues/events{/number}","events_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/events","assignees_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/assignees{/user}","branches_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/branches{/branch}","tags_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/tags","blobs_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/languages","stargazers_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/stargazers","contributors_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/contributors","subscribers_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/subscribers","subscription_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/subscription","commits_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/contents/{+path}","compare_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/merges","archive_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/downloads","issues_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/issues{/number}","pulls_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/labels{/name}","releases_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/releases{/id}","deployments_url":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/deployments","created_at":"2012-03-11T23:12:04Z","updated_at":"2016-10-08T10:28:56Z","pushed_at":"2016-10-08T12:43:03Z","git_url":"git://github.com/PHPGangsta/GoogleAuthenticator.git","ssh_url":"git@github.com:PHPGangsta/GoogleAuthenticator.git","clone_url":"https://github.com/PHPGangsta/GoogleAuthenticator.git","svn_url":"https://github.com/PHPGangsta/GoogleAuthenticator","homepage":"http://phpgangsta.de/4376","size":285,"stargazers_count":665,"watchers_count":665,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"open_issues_count":22,"forks":207,"open_issues":22,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls/25"},"html":{"href":"https://github.com/PHPGangsta/GoogleAuthenticator/pull/25"},"issue":{"href":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/issues/25"},"comments":{"href":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/PHPGangsta/GoogleAuthenticator/statuses/546a0e2d4e5d70f82910c5ad37161a0eddb1ecb8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PHPGangsta","id":608408,"avatar_url":"https://avatars.githubusercontent.com/u/608408?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPGangsta","html_url":"https://github.com/PHPGangsta","followers_url":"https://api.github.com/users/PHPGangsta/followers","following_url":"https://api.github.com/users/PHPGangsta/following{/other_user}","gists_url":"https://api.github.com/users/PHPGangsta/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPGangsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPGangsta/subscriptions","organizations_url":"https://api.github.com/users/PHPGangsta/orgs","repos_url":"https://api.github.com/users/PHPGangsta/repos","events_url":"https://api.github.com/users/PHPGangsta/events{/privacy}","received_events_url":"https://api.github.com/users/PHPGangsta/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":46,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"PHPGangsta"}}