{"action":"created","issue":{"url":"https://api.github.com/repos/careteditor/caret/issues/101","repository_url":"https://api.github.com/repos/careteditor/caret","labels_url":"https://api.github.com/repos/careteditor/caret/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/careteditor/caret/issues/101/comments","events_url":"https://api.github.com/repos/careteditor/caret/issues/101/events","html_url":"https://github.com/careteditor/caret/issues/101","id":169292652,"number":101,"title":"TOC not creating link to heading sections correctly","user":{"login":"jasondavis","id":186818,"avatar_url":"https://avatars.githubusercontent.com/u/186818?v=3","gravatar_id":"","url":"https://api.github.com/users/jasondavis","html_url":"https://github.com/jasondavis","followers_url":"https://api.github.com/users/jasondavis/followers","following_url":"https://api.github.com/users/jasondavis/following{/other_user}","gists_url":"https://api.github.com/users/jasondavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondavis/subscriptions","organizations_url":"https://api.github.com/users/jasondavis/orgs","repos_url":"https://api.github.com/users/jasondavis/repos","events_url":"https://api.github.com/users/jasondavis/events{/privacy}","received_events_url":"https://api.github.com/users/jasondavis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/careteditor/caret/labels/bug","name":"bug","color":"f7c6c7"},{"url":"https://api.github.com/repos/careteditor/caret/labels/resolved","name":"resolved","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":{"login":"astoilkov","id":884810,"avatar_url":"https://avatars.githubusercontent.com/u/884810?v=3","gravatar_id":"","url":"https://api.github.com/users/astoilkov","html_url":"https://github.com/astoilkov","followers_url":"https://api.github.com/users/astoilkov/followers","following_url":"https://api.github.com/users/astoilkov/following{/other_user}","gists_url":"https://api.github.com/users/astoilkov/gists{/gist_id}","starred_url":"https://api.github.com/users/astoilkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astoilkov/subscriptions","organizations_url":"https://api.github.com/users/astoilkov/orgs","repos_url":"https://api.github.com/users/astoilkov/repos","events_url":"https://api.github.com/users/astoilkov/events{/privacy}","received_events_url":"https://api.github.com/users/astoilkov/received_events","type":"User","site_admin":false},"assignees":[{"login":"astoilkov","id":884810,"avatar_url":"https://avatars.githubusercontent.com/u/884810?v=3","gravatar_id":"","url":"https://api.github.com/users/astoilkov","html_url":"https://github.com/astoilkov","followers_url":"https://api.github.com/users/astoilkov/followers","following_url":"https://api.github.com/users/astoilkov/following{/other_user}","gists_url":"https://api.github.com/users/astoilkov/gists{/gist_id}","starred_url":"https://api.github.com/users/astoilkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astoilkov/subscriptions","organizations_url":"https://api.github.com/users/astoilkov/orgs","repos_url":"https://api.github.com/users/astoilkov/repos","events_url":"https://api.github.com/users/astoilkov/events{/privacy}","received_events_url":"https://api.github.com/users/astoilkov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-08-04T05:14:23Z","updated_at":"2016-08-17T16:44:02Z","closed_at":"2016-08-05T16:06:46Z","body":"I just realized that the HTML for the new TOC tag seems to correctly have an id attribute on the heading item however the links in the TOC menu all link to the current file instead of linking to the heading section:\r\n\r\n`<a href=\"filename\">Heading 1</a>`\r\n  \r\ninstead of  \r\n  \r\n`<a href=\"#heading1\">Heading 1</a>`\r\n\r\nnot sure if it is a windows only issue or not but here is a link from the TOC HTML on Windows:  \r\n\r\n`<a href=\"E:\\New folder\\node_modules\\nightmare\\\">Nightmare</a>`"},"comment":{"url":"https://api.github.com/repos/careteditor/caret/issues/comments/240472322","html_url":"https://github.com/careteditor/caret/issues/101#issuecomment-240472322","issue_url":"https://api.github.com/repos/careteditor/caret/issues/101","id":240472322,"user":{"login":"jasondavis","id":186818,"avatar_url":"https://avatars.githubusercontent.com/u/186818?v=3","gravatar_id":"","url":"https://api.github.com/users/jasondavis","html_url":"https://github.com/jasondavis","followers_url":"https://api.github.com/users/jasondavis/followers","following_url":"https://api.github.com/users/jasondavis/following{/other_user}","gists_url":"https://api.github.com/users/jasondavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondavis/subscriptions","organizations_url":"https://api.github.com/users/jasondavis/orgs","repos_url":"https://api.github.com/users/jasondavis/repos","events_url":"https://api.github.com/users/jasondavis/events{/privacy}","received_events_url":"https://api.github.com/users/jasondavis/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T16:44:02Z","updated_at":"2016-08-17T16:44:02Z","body":"Sorry I wasn't sure if I should post here or start a new issue as it is related to this issue.  \r\n\r\nJust a comment on the `H3` and `H4`.  Here is the particular situation where I needed it most recently.\r\n\r\nI have a document with an `H1` heading of **Project Media Items**.  It then has an `H2` heading of **Project Media Types**.  Under **Project Media Types** I have about 10 `H3` heading items which explain in detail info about each **Project Media Type** so in this case the TOC to the list of **Project Media Types** for `H3` headings would come in handy.\r\n\r\nI respect your decision for only `H1` and `H2` for now but thought AI would at least pitch a scenario as to why it could be useful for more.  I also like the idea of `[[toc maxLevel=4]]` .\r\n\r\nAlso another idea.  Not sure how to best implement it but might be worth thinking about someday... The ability to have multiple TOC on a document.  Basically would allow you to have sub menus under different headings.  For example an `H2` heading might have its own TOC which list just the `H3` heading that are under that particular H2 heading.  Sounds complicated but would be a cool feature down the line!\r\n\r\nLook forward to the future, keep it going!"}}
{"actor":{"display_login":"jasondavis"}}