{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/js-xpath/pulls/comments/49660915","id":49660915,"diff_hunk":"@@ -456,7 +456,7 @@ var makeXPathModels = function(hashtagConfig) {\n         };\n         this.toHashtag = _combine;\n         this.getChildren = function () {\n-           return this.steps;\n+           return [];","path":"models.js","position":5,"original_position":5,"commit_id":"371d81c363d47841f923cb8fd951e26823e82ce9","original_commit_id":"371d81c363d47841f923cb8fd951e26823e82ce9","user":{"login":"emord","id":1471773,"avatar_url":"https://avatars.githubusercontent.com/u/1471773?v=3","gravatar_id":"","url":"https://api.github.com/users/emord","html_url":"https://github.com/emord","followers_url":"https://api.github.com/users/emord/followers","following_url":"https://api.github.com/users/emord/following{/other_user}","gists_url":"https://api.github.com/users/emord/gists{/gist_id}","starred_url":"https://api.github.com/users/emord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emord/subscriptions","organizations_url":"https://api.github.com/users/emord/orgs","repos_url":"https://api.github.com/users/emord/repos","events_url":"https://api.github.com/users/emord/events{/privacy}","received_events_url":"https://api.github.com/users/emord/received_events","type":"User","site_admin":false},"body":"This was implemented incorrectly as hashtags don't actually support children (predicates) at the moment","created_at":"2016-01-13T22:27:06Z","updated_at":"2016-01-13T22:27:06Z","html_url":"https://github.com/dimagi/js-xpath/pull/10#discussion_r49660915","pull_request_url":"https://api.github.com/repos/dimagi/js-xpath/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/dimagi/js-xpath/pulls/comments/49660915"},"html":{"href":"https://github.com/dimagi/js-xpath/pull/10#discussion_r49660915"},"pull_request":{"href":"https://api.github.com/repos/dimagi/js-xpath/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/js-xpath/pulls/10","id":55965358,"html_url":"https://github.com/dimagi/js-xpath/pull/10","diff_url":"https://github.com/dimagi/js-xpath/pull/10.diff","patch_url":"https://github.com/dimagi/js-xpath/pull/10.patch","issue_url":"https://api.github.com/repos/dimagi/js-xpath/issues/10","number":10,"state":"open","locked":false,"title":"Cleanup","user":{"login":"emord","id":1471773,"avatar_url":"https://avatars.githubusercontent.com/u/1471773?v=3","gravatar_id":"","url":"https://api.github.com/users/emord","html_url":"https://github.com/emord","followers_url":"https://api.github.com/users/emord/followers","following_url":"https://api.github.com/users/emord/following{/other_user}","gists_url":"https://api.github.com/users/emord/gists{/gist_id}","starred_url":"https://api.github.com/users/emord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emord/subscriptions","organizations_url":"https://api.github.com/users/emord/orgs","repos_url":"https://api.github.com/users/emord/repos","events_url":"https://api.github.com/users/emord/events{/privacy}","received_events_url":"https://api.github.com/users/emord/received_events","type":"User","site_admin":false},"body":"@millerdev \r\n\r\nThis encapsulates xpath models within the parser, which should allow vellum to have multiple xpath parsers for a more proper plugin interface\r\n\r\nReading commit by commit will be easier since I moved the autogenerated file/added another\r\n\r\ncc: @sravfeyn ","created_at":"2016-01-13T22:25:21Z","updated_at":"2016-01-13T22:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ed5fcecba1c10778785f98f301b3b5ff05e3b8d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/js-xpath/pulls/10/commits","review_comments_url":"https://api.github.com/repos/dimagi/js-xpath/pulls/10/comments","review_comment_url":"https://api.github.com/repos/dimagi/js-xpath/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/js-xpath/issues/10/comments","statuses_url":"https://api.github.com/repos/dimagi/js-xpath/statuses/371d81c363d47841f923cb8fd951e26823e82ce9","head":{"label":"dimagi:cleanup","ref":"cleanup","sha":"371d81c363d47841f923cb8fd951e26823e82ce9","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":2522498,"name":"js-xpath","full_name":"dimagi/js-xpath","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/js-xpath","description":"XPath Parser for Javascript","fork":false,"url":"https://api.github.com/repos/dimagi/js-xpath","forks_url":"https://api.github.com/repos/dimagi/js-xpath/forks","keys_url":"https://api.github.com/repos/dimagi/js-xpath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/js-xpath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/js-xpath/teams","hooks_url":"https://api.github.com/repos/dimagi/js-xpath/hooks","issue_events_url":"https://api.github.com/repos/dimagi/js-xpath/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/js-xpath/events","assignees_url":"https://api.github.com/repos/dimagi/js-xpath/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/js-xpath/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/js-xpath/tags","blobs_url":"https://api.github.com/repos/dimagi/js-xpath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/js-xpath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/js-xpath/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/js-xpath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/js-xpath/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/js-xpath/languages","stargazers_url":"https://api.github.com/repos/dimagi/js-xpath/stargazers","contributors_url":"https://api.github.com/repos/dimagi/js-xpath/contributors","subscribers_url":"https://api.github.com/repos/dimagi/js-xpath/subscribers","subscription_url":"https://api.github.com/repos/dimagi/js-xpath/subscription","commits_url":"https://api.github.com/repos/dimagi/js-xpath/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/js-xpath/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/js-xpath/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/js-xpath/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/js-xpath/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/js-xpath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/js-xpath/merges","archive_url":"https://api.github.com/repos/dimagi/js-xpath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/js-xpath/downloads","issues_url":"https://api.github.com/repos/dimagi/js-xpath/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/js-xpath/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/js-xpath/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/js-xpath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/js-xpath/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/js-xpath/releases{/id}","created_at":"2011-10-05T21:57:01Z","updated_at":"2015-11-04T15:01:08Z","pushed_at":"2016-01-13T22:25:22Z","git_url":"git://github.com/dimagi/js-xpath.git","ssh_url":"git@github.com:dimagi/js-xpath.git","clone_url":"https://github.com/dimagi/js-xpath.git","svn_url":"https://github.com/dimagi/js-xpath","homepage":"","size":273,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":10,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"497936c13bf6f25d94e21c3a640b97aee54e65be","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":2522498,"name":"js-xpath","full_name":"dimagi/js-xpath","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/js-xpath","description":"XPath Parser for Javascript","fork":false,"url":"https://api.github.com/repos/dimagi/js-xpath","forks_url":"https://api.github.com/repos/dimagi/js-xpath/forks","keys_url":"https://api.github.com/repos/dimagi/js-xpath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/js-xpath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/js-xpath/teams","hooks_url":"https://api.github.com/repos/dimagi/js-xpath/hooks","issue_events_url":"https://api.github.com/repos/dimagi/js-xpath/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/js-xpath/events","assignees_url":"https://api.github.com/repos/dimagi/js-xpath/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/js-xpath/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/js-xpath/tags","blobs_url":"https://api.github.com/repos/dimagi/js-xpath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/js-xpath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/js-xpath/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/js-xpath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/js-xpath/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/js-xpath/languages","stargazers_url":"https://api.github.com/repos/dimagi/js-xpath/stargazers","contributors_url":"https://api.github.com/repos/dimagi/js-xpath/contributors","subscribers_url":"https://api.github.com/repos/dimagi/js-xpath/subscribers","subscription_url":"https://api.github.com/repos/dimagi/js-xpath/subscription","commits_url":"https://api.github.com/repos/dimagi/js-xpath/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/js-xpath/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/js-xpath/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/js-xpath/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/js-xpath/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/js-xpath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/js-xpath/merges","archive_url":"https://api.github.com/repos/dimagi/js-xpath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/js-xpath/downloads","issues_url":"https://api.github.com/repos/dimagi/js-xpath/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/js-xpath/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/js-xpath/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/js-xpath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/js-xpath/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/js-xpath/releases{/id}","created_at":"2011-10-05T21:57:01Z","updated_at":"2015-11-04T15:01:08Z","pushed_at":"2016-01-13T22:25:22Z","git_url":"git://github.com/dimagi/js-xpath.git","ssh_url":"git@github.com:dimagi/js-xpath.git","clone_url":"https://github.com/dimagi/js-xpath.git","svn_url":"https://github.com/dimagi/js-xpath","homepage":"","size":273,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/js-xpath/pulls/10"},"html":{"href":"https://github.com/dimagi/js-xpath/pull/10"},"issue":{"href":"https://api.github.com/repos/dimagi/js-xpath/issues/10"},"comments":{"href":"https://api.github.com/repos/dimagi/js-xpath/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/js-xpath/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/js-xpath/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/js-xpath/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/js-xpath/statuses/371d81c363d47841f923cb8fd951e26823e82ce9"}}}}