{"action":"created","issue":{"url":"https://api.github.com/repos/flarum/flarum-ext-subscriptions/issues/9","repository_url":"https://api.github.com/repos/flarum/flarum-ext-subscriptions","labels_url":"https://api.github.com/repos/flarum/flarum-ext-subscriptions/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/flarum/flarum-ext-subscriptions/issues/9/comments","events_url":"https://api.github.com/repos/flarum/flarum-ext-subscriptions/issues/9/events","html_url":"https://github.com/flarum/flarum-ext-subscriptions/pull/9","id":148583027,"number":9,"title":"added FollowNewDiscussions option","user":{"login":"oscarotero","id":377873,"avatar_url":"https://avatars.githubusercontent.com/u/377873?v=3","gravatar_id":"","url":"https://api.github.com/users/oscarotero","html_url":"https://github.com/oscarotero","followers_url":"https://api.github.com/users/oscarotero/followers","following_url":"https://api.github.com/users/oscarotero/following{/other_user}","gists_url":"https://api.github.com/users/oscarotero/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarotero/subscriptions","organizations_url":"https://api.github.com/users/oscarotero/orgs","repos_url":"https://api.github.com/users/oscarotero/repos","events_url":"https://api.github.com/users/oscarotero/events{/privacy}","received_events_url":"https://api.github.com/users/oscarotero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-04-15T07:42:57Z","updated_at":"2016-07-23T16:46:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/flarum/flarum-ext-subscriptions/pulls/9","html_url":"https://github.com/flarum/flarum-ext-subscriptions/pull/9","diff_url":"https://github.com/flarum/flarum-ext-subscriptions/pull/9.diff","patch_url":"https://github.com/flarum/flarum-ext-subscriptions/pull/9.patch"},"body":"With this option, all users will be subscribed and notified for every discussion started."},"comment":{"url":"https://api.github.com/repos/flarum/flarum-ext-subscriptions/issues/comments/234727970","html_url":"https://github.com/flarum/flarum-ext-subscriptions/pull/9#issuecomment-234727970","issue_url":"https://api.github.com/repos/flarum/flarum-ext-subscriptions/issues/9","id":234727970,"user":{"login":"oscarotero","id":377873,"avatar_url":"https://avatars.githubusercontent.com/u/377873?v=3","gravatar_id":"","url":"https://api.github.com/users/oscarotero","html_url":"https://github.com/oscarotero","followers_url":"https://api.github.com/users/oscarotero/followers","following_url":"https://api.github.com/users/oscarotero/following{/other_user}","gists_url":"https://api.github.com/users/oscarotero/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarotero/subscriptions","organizations_url":"https://api.github.com/users/oscarotero/orgs","repos_url":"https://api.github.com/users/oscarotero/repos","events_url":"https://api.github.com/users/oscarotero/events{/privacy}","received_events_url":"https://api.github.com/users/oscarotero/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T16:46:13Z","updated_at":"2016-07-23T16:46:13Z","body":"@franzliedke I've found a security issue that I've fixed temporarily in a different branch (used in my private installation), related with the ability of the tags plugin to hide some discussions under specific tags.\r\n\r\nAs you can see here: https://github.com/oscarotero/flarum-ext-subscriptions/blob/galician-locale/src/Listener/FollowNewDiscussions.php#L67 I check whether the discussion has tags and discard the users without permissions to view discussions under any of these tags.\r\n\r\nI don't know if there's a better way to handle this, not dependent of a specific plugin (there might be other plugins changing the view permissions). How about a more agnostic `$discussion->hasPermission('user.[id].view')`?\r\n\r\nBTW, May this issue be present also in the other options provided by this plugin (users receiving notifications of discussions can not see?)"}}
{"actor":{"display_login":"oscarotero"}}