{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/comments/50461359","id":50461359,"diff_hunk":"@@ -361,10 +351,19 @@ def source(self):\n \n     @property\n     def name(self):\n-        return smart_unicode(self.display_name or self.username)\n+        if self.display_name:\n+            return smart_unicode(self.display_name)\n+        elif self.has_anonymous_username:\n+            return _('Anonymous')\n+        else:\n+            return smart_unicode(self.username)\n \n     welcome_name = name\n \n+    @property","path":"apps/users/models.py","position":68,"original_position":68,"commit_id":"3114f404b63e306ebe28906fc3bb3101255308ee","original_commit_id":"3114f404b63e306ebe28906fc3bb3101255308ee","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"Does this have to be a property? I don't really like making things properties unless it's needed to satisfy some kind of external interface constraint. Properties conceal the fact that you're executing code without adding any benefits.","created_at":"2016-01-21T20:47:33Z","updated_at":"2016-01-21T20:47:33Z","html_url":"https://github.com/mozilla/olympia/pull/1436#discussion_r50461359","pull_request_url":"https://api.github.com/repos/mozilla/olympia/pulls/1436","_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments/50461359"},"html":{"href":"https://github.com/mozilla/olympia/pull/1436#discussion_r50461359"},"pull_request":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/1436"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/1436","id":56396585,"html_url":"https://github.com/mozilla/olympia/pull/1436","diff_url":"https://github.com/mozilla/olympia/pull/1436.diff","patch_url":"https://github.com/mozilla/olympia/pull/1436.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/1436","number":1436,"state":"open","locked":false,"title":"Generate anonymous usernames for FxA (fixes #1000)","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"body":"This changes how usernames are generated to be `anonymous-{random-data}`. When a `username` matches this pattern and there is no `display_name` the `welcome_name` is set to `_('Anonymous')`.\r\n\r\nThe demo includes changes from #1173.\r\n\r\n![fxa-register-three mov](https://cloud.githubusercontent.com/assets/211578/12098697/7a9764ce-b2e9-11e5-96f1-d19f85bddcca.gif)\r\n\r\nThis fixes #1000.","created_at":"2016-01-18T22:01:39Z","updated_at":"2016-01-21T20:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4848caf6701298ee6e7eebb117683a45c838200c","assignee":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/1436/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/1436/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/1436/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/3114f404b63e306ebe28906fc3bb3101255308ee","head":{"label":"mstriemer:better-anonymous-accounts-1000","ref":"better-anonymous-accounts-1000","sha":"3114f404b63e306ebe28906fc3bb3101255308ee","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"repo":{"id":18221347,"name":"olympia","full_name":"mstriemer/olympia","owner":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mstriemer/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/mstriemer/olympia","forks_url":"https://api.github.com/repos/mstriemer/olympia/forks","keys_url":"https://api.github.com/repos/mstriemer/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstriemer/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstriemer/olympia/teams","hooks_url":"https://api.github.com/repos/mstriemer/olympia/hooks","issue_events_url":"https://api.github.com/repos/mstriemer/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mstriemer/olympia/events","assignees_url":"https://api.github.com/repos/mstriemer/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mstriemer/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mstriemer/olympia/tags","blobs_url":"https://api.github.com/repos/mstriemer/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstriemer/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstriemer/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstriemer/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstriemer/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mstriemer/olympia/languages","stargazers_url":"https://api.github.com/repos/mstriemer/olympia/stargazers","contributors_url":"https://api.github.com/repos/mstriemer/olympia/contributors","subscribers_url":"https://api.github.com/repos/mstriemer/olympia/subscribers","subscription_url":"https://api.github.com/repos/mstriemer/olympia/subscription","commits_url":"https://api.github.com/repos/mstriemer/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstriemer/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstriemer/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstriemer/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mstriemer/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mstriemer/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstriemer/olympia/merges","archive_url":"https://api.github.com/repos/mstriemer/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstriemer/olympia/downloads","issues_url":"https://api.github.com/repos/mstriemer/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mstriemer/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mstriemer/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mstriemer/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstriemer/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mstriemer/olympia/releases{/id}","created_at":"2014-03-28T17:58:28Z","updated_at":"2015-08-04T16:05:57Z","pushed_at":"2016-01-21T20:25:45Z","git_url":"git://github.com/mstriemer/olympia.git","ssh_url":"git@github.com:mstriemer/olympia.git","clone_url":"https://github.com/mstriemer/olympia.git","svn_url":"https://github.com/mstriemer/olympia","homepage":"","size":466381,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"6dd196a0578e06355bc2bb92f780e7cf81f58c69","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2016-01-12T21:47:23Z","pushed_at":"2016-01-21T20:26:36Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":469144,"stargazers_count":72,"watchers_count":72,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":141,"forks":135,"open_issues":141,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/1436"},"html":{"href":"https://github.com/mozilla/olympia/pull/1436"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/1436"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/1436/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/1436/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/1436/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/3114f404b63e306ebe28906fc3bb3101255308ee"}}}}