{"action":"closed","issue":{"url":"https://api.github.com/repos/tmalsburg/helm-bibtex/issues/100","repository_url":"https://api.github.com/repos/tmalsburg/helm-bibtex","labels_url":"https://api.github.com/repos/tmalsburg/helm-bibtex/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/tmalsburg/helm-bibtex/issues/100/comments","events_url":"https://api.github.com/repos/tmalsburg/helm-bibtex/issues/100/events","html_url":"https://github.com/tmalsburg/helm-bibtex/issues/100","id":140453084,"number":100,"title":"Allow finding PDFs from `helm-bibtex-library-path` with user defined file name","user":{"login":"zzjjzzgggg","id":1131404,"avatar_url":"https://avatars.githubusercontent.com/u/1131404?v=3","gravatar_id":"","url":"https://api.github.com/users/zzjjzzgggg","html_url":"https://github.com/zzjjzzgggg","followers_url":"https://api.github.com/users/zzjjzzgggg/followers","following_url":"https://api.github.com/users/zzjjzzgggg/following{/other_user}","gists_url":"https://api.github.com/users/zzjjzzgggg/gists{/gist_id}","starred_url":"https://api.github.com/users/zzjjzzgggg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzjjzzgggg/subscriptions","organizations_url":"https://api.github.com/users/zzjjzzgggg/orgs","repos_url":"https://api.github.com/users/zzjjzzgggg/repos","events_url":"https://api.github.com/users/zzjjzzgggg/events{/privacy}","received_events_url":"https://api.github.com/users/zzjjzzgggg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-13T06:04:38Z","updated_at":"2016-04-17T23:58:23Z","closed_at":"2016-04-17T23:58:23Z","body":"The function `helm-bibtex-find-pdf-in-field (key-or-entry)` should also try to find PDFs in directories specified by `helm-bibtex-library-path` when the relative path of a PDF is provided in the `file` field of an entry.\r\n\r\nAs a JabRef user, this situation is very common. For example, my `helm-bibtex-library-path` is \"~/papers\", and an entry's `file` field is `file = {:docs/p1087.pdf:PDF}`. The full path of the PDF is `~/papers/docs/p1087.pdf`. I find that helm-bibtex failed finding the PDF if the file name is not the key of current entry.\r\n\r\nConsider adding some judgement like \r\n```\r\n         else if (f-file? (f-full (f-join helm-bibtex-library-path path)))\r\n         collect (f-full (f-join helm-bibtex-library-path path))\r\n```\r\nin the function `helm-bibtex-find-pdf-in-field (key-or-entry)`. Also notice that I simply treat `helm-bibtex-library-path` as a variable not a list, since I don't know how to write a nested loop in elisp, sigh..."}}