{"action":"created","comment":{"url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/comments/67280638","id":67280638,"diff_hunk":"@@ -16,12 +16,9 @@ function toAccount (doc, options) {\n   var account = {\n     id: accountId,\n     username: username,\n+    profile: doc.profile || {},\n     roles: findCustomRoles(roles)\n   }\n \n-  if (options.includeProfile) {\n-    account.profile = doc.profile\n-  }","path":"api/utils/doc-to-account.js","position":null,"original_position":10,"commit_id":"ed53fe9f7d45c50efe286849ab133f7a96da9f15","original_commit_id":"1a7a9b608bae507dbb5303ccb4fb979977526219","user":{"login":"jameswestnz","id":726513,"avatar_url":"https://avatars.githubusercontent.com/u/726513?v=3","gravatar_id":"","url":"https://api.github.com/users/jameswestnz","html_url":"https://github.com/jameswestnz","followers_url":"https://api.github.com/users/jameswestnz/followers","following_url":"https://api.github.com/users/jameswestnz/following{/other_user}","gists_url":"https://api.github.com/users/jameswestnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jameswestnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameswestnz/subscriptions","organizations_url":"https://api.github.com/users/jameswestnz/orgs","repos_url":"https://api.github.com/users/jameswestnz/repos","events_url":"https://api.github.com/users/jameswestnz/events{/privacy}","received_events_url":"https://api.github.com/users/jameswestnz/received_events","type":"User","site_admin":false},"body":"Restored here: https://github.com/hoodiehq/hoodie-account-server/pull/158/commits/cb223fa22e433e07bf37478bec4d518dfffcd2f8","created_at":"2016-06-16T02:55:18Z","updated_at":"2016-06-16T02:55:18Z","html_url":"https://github.com/hoodiehq/hoodie-account-server/pull/158#discussion_r67280638","pull_request_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/158","_links":{"self":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/comments/67280638"},"html":{"href":"https://github.com/hoodiehq/hoodie-account-server/pull/158#discussion_r67280638"},"pull_request":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/158","id":72285294,"html_url":"https://github.com/hoodiehq/hoodie-account-server/pull/158","diff_url":"https://github.com/hoodiehq/hoodie-account-server/pull/158.diff","patch_url":"https://github.com/hoodiehq/hoodie-account-server/pull/158.patch","issue_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/issues/158","number":158,"state":"open","locked":false,"title":"Proof of concept for account profiles.","user":{"login":"jameswestnz","id":726513,"avatar_url":"https://avatars.githubusercontent.com/u/726513?v=3","gravatar_id":"","url":"https://api.github.com/users/jameswestnz","html_url":"https://github.com/jameswestnz","followers_url":"https://api.github.com/users/jameswestnz/followers","following_url":"https://api.github.com/users/jameswestnz/following{/other_user}","gists_url":"https://api.github.com/users/jameswestnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jameswestnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameswestnz/subscriptions","organizations_url":"https://api.github.com/users/jameswestnz/orgs","repos_url":"https://api.github.com/users/jameswestnz/repos","events_url":"https://api.github.com/users/jameswestnz/events{/privacy}","received_events_url":"https://api.github.com/users/jameswestnz/received_events","type":"User","site_admin":false},"body":"Some notes on this PR:\r\n- Tests have not yet been completed.\r\n- I have assumed that profiles will be a permanent part of all account requests. I.e. this information is always included in get requests.\r\n- Have only focussed on initial sign-up and session/account retrieval. So currently no `profile` requests have been dealt to.\r\n\r\nTo do:\r\n- [x] `PATCH /session/account/profile`\r\n- [x] Code tests\r\n- [ ] Docs for `hoodie-account-server`\r\n- [ ] Update JSON API spec: https://github.com/hoodiehq/account-json-api\r\n- [ ] PR `hoodie-account`\r\n\r\nMore than happy for someone to add to this PR ;)","created_at":"2016-06-02T03:42:38Z","updated_at":"2016-06-16T02:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58a6ac00f4015002aa3cfe8fa74fe12c74d71386","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/158/commits","review_comments_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/158/comments","review_comment_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/issues/158/comments","statuses_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/statuses/ed53fe9f7d45c50efe286849ab133f7a96da9f15","head":{"label":"agtract:profile","ref":"profile","sha":"ed53fe9f7d45c50efe286849ab133f7a96da9f15","user":{"login":"agtract","id":19158616,"avatar_url":"https://avatars.githubusercontent.com/u/19158616?v=3","gravatar_id":"","url":"https://api.github.com/users/agtract","html_url":"https://github.com/agtract","followers_url":"https://api.github.com/users/agtract/followers","following_url":"https://api.github.com/users/agtract/following{/other_user}","gists_url":"https://api.github.com/users/agtract/gists{/gist_id}","starred_url":"https://api.github.com/users/agtract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agtract/subscriptions","organizations_url":"https://api.github.com/users/agtract/orgs","repos_url":"https://api.github.com/users/agtract/repos","events_url":"https://api.github.com/users/agtract/events{/privacy}","received_events_url":"https://api.github.com/users/agtract/received_events","type":"Organization","site_admin":false},"repo":{"id":60224985,"name":"hoodie-account-server","full_name":"agtract/hoodie-account-server","owner":{"login":"agtract","id":19158616,"avatar_url":"https://avatars.githubusercontent.com/u/19158616?v=3","gravatar_id":"","url":"https://api.github.com/users/agtract","html_url":"https://github.com/agtract","followers_url":"https://api.github.com/users/agtract/followers","following_url":"https://api.github.com/users/agtract/following{/other_user}","gists_url":"https://api.github.com/users/agtract/gists{/gist_id}","starred_url":"https://api.github.com/users/agtract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agtract/subscriptions","organizations_url":"https://api.github.com/users/agtract/orgs","repos_url":"https://api.github.com/users/agtract/repos","events_url":"https://api.github.com/users/agtract/events{/privacy}","received_events_url":"https://api.github.com/users/agtract/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/agtract/hoodie-account-server","description":":dog: Account JSON API backed by PouchDB","fork":true,"url":"https://api.github.com/repos/agtract/hoodie-account-server","forks_url":"https://api.github.com/repos/agtract/hoodie-account-server/forks","keys_url":"https://api.github.com/repos/agtract/hoodie-account-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agtract/hoodie-account-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agtract/hoodie-account-server/teams","hooks_url":"https://api.github.com/repos/agtract/hoodie-account-server/hooks","issue_events_url":"https://api.github.com/repos/agtract/hoodie-account-server/issues/events{/number}","events_url":"https://api.github.com/repos/agtract/hoodie-account-server/events","assignees_url":"https://api.github.com/repos/agtract/hoodie-account-server/assignees{/user}","branches_url":"https://api.github.com/repos/agtract/hoodie-account-server/branches{/branch}","tags_url":"https://api.github.com/repos/agtract/hoodie-account-server/tags","blobs_url":"https://api.github.com/repos/agtract/hoodie-account-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agtract/hoodie-account-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agtract/hoodie-account-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/agtract/hoodie-account-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agtract/hoodie-account-server/statuses/{sha}","languages_url":"https://api.github.com/repos/agtract/hoodie-account-server/languages","stargazers_url":"https://api.github.com/repos/agtract/hoodie-account-server/stargazers","contributors_url":"https://api.github.com/repos/agtract/hoodie-account-server/contributors","subscribers_url":"https://api.github.com/repos/agtract/hoodie-account-server/subscribers","subscription_url":"https://api.github.com/repos/agtract/hoodie-account-server/subscription","commits_url":"https://api.github.com/repos/agtract/hoodie-account-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/agtract/hoodie-account-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/agtract/hoodie-account-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/agtract/hoodie-account-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/agtract/hoodie-account-server/contents/{+path}","compare_url":"https://api.github.com/repos/agtract/hoodie-account-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agtract/hoodie-account-server/merges","archive_url":"https://api.github.com/repos/agtract/hoodie-account-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agtract/hoodie-account-server/downloads","issues_url":"https://api.github.com/repos/agtract/hoodie-account-server/issues{/number}","pulls_url":"https://api.github.com/repos/agtract/hoodie-account-server/pulls{/number}","milestones_url":"https://api.github.com/repos/agtract/hoodie-account-server/milestones{/number}","notifications_url":"https://api.github.com/repos/agtract/hoodie-account-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agtract/hoodie-account-server/labels{/name}","releases_url":"https://api.github.com/repos/agtract/hoodie-account-server/releases{/id}","deployments_url":"https://api.github.com/repos/agtract/hoodie-account-server/deployments","created_at":"2016-06-02T02:09:16Z","updated_at":"2016-06-02T02:09:18Z","pushed_at":"2016-06-16T02:51:09Z","git_url":"git://github.com/agtract/hoodie-account-server.git","ssh_url":"git@github.com:agtract/hoodie-account-server.git","clone_url":"https://github.com/agtract/hoodie-account-server.git","svn_url":"https://github.com/agtract/hoodie-account-server","homepage":"","size":317,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hoodiehq:master","ref":"master","sha":"84e03b84a57a43f2f3049b64c5d2c56d1b47fb04","user":{"login":"hoodiehq","id":1888826,"avatar_url":"https://avatars.githubusercontent.com/u/1888826?v=3","gravatar_id":"","url":"https://api.github.com/users/hoodiehq","html_url":"https://github.com/hoodiehq","followers_url":"https://api.github.com/users/hoodiehq/followers","following_url":"https://api.github.com/users/hoodiehq/following{/other_user}","gists_url":"https://api.github.com/users/hoodiehq/gists{/gist_id}","starred_url":"https://api.github.com/users/hoodiehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoodiehq/subscriptions","organizations_url":"https://api.github.com/users/hoodiehq/orgs","repos_url":"https://api.github.com/users/hoodiehq/repos","events_url":"https://api.github.com/users/hoodiehq/events{/privacy}","received_events_url":"https://api.github.com/users/hoodiehq/received_events","type":"Organization","site_admin":false},"repo":{"id":45084146,"name":"hoodie-account-server","full_name":"hoodiehq/hoodie-account-server","owner":{"login":"hoodiehq","id":1888826,"avatar_url":"https://avatars.githubusercontent.com/u/1888826?v=3","gravatar_id":"","url":"https://api.github.com/users/hoodiehq","html_url":"https://github.com/hoodiehq","followers_url":"https://api.github.com/users/hoodiehq/followers","following_url":"https://api.github.com/users/hoodiehq/following{/other_user}","gists_url":"https://api.github.com/users/hoodiehq/gists{/gist_id}","starred_url":"https://api.github.com/users/hoodiehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoodiehq/subscriptions","organizations_url":"https://api.github.com/users/hoodiehq/orgs","repos_url":"https://api.github.com/users/hoodiehq/repos","events_url":"https://api.github.com/users/hoodiehq/events{/privacy}","received_events_url":"https://api.github.com/users/hoodiehq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hoodiehq/hoodie-account-server","description":":dog: Account JSON API backed by PouchDB","fork":false,"url":"https://api.github.com/repos/hoodiehq/hoodie-account-server","forks_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/forks","keys_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/teams","hooks_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/hooks","issue_events_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/issues/events{/number}","events_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/events","assignees_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/assignees{/user}","branches_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/branches{/branch}","tags_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/tags","blobs_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/statuses/{sha}","languages_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/languages","stargazers_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/stargazers","contributors_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/contributors","subscribers_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/subscribers","subscription_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/subscription","commits_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/contents/{+path}","compare_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/merges","archive_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/downloads","issues_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/issues{/number}","pulls_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls{/number}","milestones_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/milestones{/number}","notifications_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/labels{/name}","releases_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/releases{/id}","deployments_url":"https://api.github.com/repos/hoodiehq/hoodie-account-server/deployments","created_at":"2015-10-28T02:37:41Z","updated_at":"2016-06-14T19:35:59Z","pushed_at":"2016-06-16T02:51:09Z","git_url":"git://github.com/hoodiehq/hoodie-account-server.git","ssh_url":"git@github.com:hoodiehq/hoodie-account-server.git","clone_url":"https://github.com/hoodiehq/hoodie-account-server.git","svn_url":"https://github.com/hoodiehq/hoodie-account-server","homepage":"","size":492,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":12,"forks":34,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/158"},"html":{"href":"https://github.com/hoodiehq/hoodie-account-server/pull/158"},"issue":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/issues/158"},"comments":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/hoodiehq/hoodie-account-server/statuses/ed53fe9f7d45c50efe286849ab133f7a96da9f15"}}}}
{"actor":{"display_login":"jameswestnz"}}