{"action":"created","comment":{"url":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/comments/93158138","pull_request_review_id":13679882,"id":93158138,"diff_hunk":"@@ -83,9 +83,15 @@ protected Object lookupNative(final Name name) throws NamingException {\n             }\n         }\n         if (beanName == null) {\n+            if (size == 3) {\n+                // name is of the form appName/moduleName/distinctName\n+                return new RelativeContext(new FastHashtable<>(getEnvironment()), this, SimpleName.of(name));\n+            }","path":"src/main/java/org/jboss/ejb/client/EJBRootContext.java","position":26,"original_position":26,"commit_id":"41997b9d6748883921e7383b3a596c4f71606c37","original_commit_id":"41997b9d6748883921e7383b3a596c4f71606c37","user":{"login":"dmlloyd","id":124581,"avatar_url":"https://avatars.githubusercontent.com/u/124581?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlloyd","html_url":"https://github.com/dmlloyd","followers_url":"https://api.github.com/users/dmlloyd/followers","following_url":"https://api.github.com/users/dmlloyd/following{/other_user}","gists_url":"https://api.github.com/users/dmlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlloyd/subscriptions","organizations_url":"https://api.github.com/users/dmlloyd/orgs","repos_url":"https://api.github.com/users/dmlloyd/repos","events_url":"https://api.github.com/users/dmlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/dmlloyd/received_events","type":"User","site_admin":false},"body":"I think that this suffers from a problem where you cannot disambiguate between app/module/distinct vs app/module/bean, doesn't it?","created_at":"2016-12-20T01:49:16Z","updated_at":"2016-12-20T01:49:16Z","html_url":"https://github.com/jbossas/jboss-ejb-client/pull/180#discussion_r93158138","pull_request_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/comments/93158138"},"html":{"href":"https://github.com/jbossas/jboss-ejb-client/pull/180#discussion_r93158138"},"pull_request":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/180","id":98666219,"html_url":"https://github.com/jbossas/jboss-ejb-client/pull/180","diff_url":"https://github.com/jbossas/jboss-ejb-client/pull/180.diff","patch_url":"https://github.com/jbossas/jboss-ejb-client/pull/180.patch","issue_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/issues/180","number":180,"state":"open","locked":false,"title":"[EJBCLIENT-178] Fix EJB JNDI parsing to be able to handle the case where an empty distinct name is not included in the JNDI name","user":{"login":"fjuma","id":1486286,"avatar_url":"https://avatars.githubusercontent.com/u/1486286?v=3","gravatar_id":"","url":"https://api.github.com/users/fjuma","html_url":"https://github.com/fjuma","followers_url":"https://api.github.com/users/fjuma/followers","following_url":"https://api.github.com/users/fjuma/following{/other_user}","gists_url":"https://api.github.com/users/fjuma/gists{/gist_id}","starred_url":"https://api.github.com/users/fjuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjuma/subscriptions","organizations_url":"https://api.github.com/users/fjuma/orgs","repos_url":"https://api.github.com/users/fjuma/repos","events_url":"https://api.github.com/users/fjuma/events{/privacy}","received_events_url":"https://api.github.com/users/fjuma/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/EJBCLIENT-178","created_at":"2016-12-20T00:32:13Z","updated_at":"2016-12-20T01:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a7344ac96125c85e0ffe389f6755e5a60716edf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/180/commits","review_comments_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/180/comments","review_comment_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/issues/180/comments","statuses_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/statuses/41997b9d6748883921e7383b3a596c4f71606c37","head":{"label":"fjuma:EJBCLIENT-178","ref":"EJBCLIENT-178","sha":"41997b9d6748883921e7383b3a596c4f71606c37","user":{"login":"fjuma","id":1486286,"avatar_url":"https://avatars.githubusercontent.com/u/1486286?v=3","gravatar_id":"","url":"https://api.github.com/users/fjuma","html_url":"https://github.com/fjuma","followers_url":"https://api.github.com/users/fjuma/followers","following_url":"https://api.github.com/users/fjuma/following{/other_user}","gists_url":"https://api.github.com/users/fjuma/gists{/gist_id}","starred_url":"https://api.github.com/users/fjuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjuma/subscriptions","organizations_url":"https://api.github.com/users/fjuma/orgs","repos_url":"https://api.github.com/users/fjuma/repos","events_url":"https://api.github.com/users/fjuma/events{/privacy}","received_events_url":"https://api.github.com/users/fjuma/received_events","type":"User","site_admin":false},"repo":{"id":38834211,"name":"jboss-ejb-client","full_name":"fjuma/jboss-ejb-client","owner":{"login":"fjuma","id":1486286,"avatar_url":"https://avatars.githubusercontent.com/u/1486286?v=3","gravatar_id":"","url":"https://api.github.com/users/fjuma","html_url":"https://github.com/fjuma","followers_url":"https://api.github.com/users/fjuma/followers","following_url":"https://api.github.com/users/fjuma/following{/other_user}","gists_url":"https://api.github.com/users/fjuma/gists{/gist_id}","starred_url":"https://api.github.com/users/fjuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjuma/subscriptions","organizations_url":"https://api.github.com/users/fjuma/orgs","repos_url":"https://api.github.com/users/fjuma/repos","events_url":"https://api.github.com/users/fjuma/events{/privacy}","received_events_url":"https://api.github.com/users/fjuma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjuma/jboss-ejb-client","description":"JBoss EJB client for AS7","fork":true,"url":"https://api.github.com/repos/fjuma/jboss-ejb-client","forks_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/forks","keys_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/teams","hooks_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/hooks","issue_events_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/issues/events{/number}","events_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/events","assignees_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/assignees{/user}","branches_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/branches{/branch}","tags_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/tags","blobs_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/statuses/{sha}","languages_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/languages","stargazers_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/stargazers","contributors_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/contributors","subscribers_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/subscribers","subscription_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/subscription","commits_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/contents/{+path}","compare_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/merges","archive_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/downloads","issues_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/issues{/number}","pulls_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/pulls{/number}","milestones_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/milestones{/number}","notifications_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/labels{/name}","releases_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/releases{/id}","deployments_url":"https://api.github.com/repos/fjuma/jboss-ejb-client/deployments","created_at":"2015-07-09T17:10:12Z","updated_at":"2015-07-09T17:10:13Z","pushed_at":"2016-12-20T00:23:17Z","git_url":"git://github.com/fjuma/jboss-ejb-client.git","ssh_url":"git@github.com:fjuma/jboss-ejb-client.git","clone_url":"https://github.com/fjuma/jboss-ejb-client.git","svn_url":"https://github.com/fjuma/jboss-ejb-client","homepage":"","size":6730,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbossas:master","ref":"master","sha":"f9191ea9e482313a99015d3ef69374f245c23138","user":{"login":"jbossas","id":326816,"avatar_url":"https://avatars.githubusercontent.com/u/326816?v=3","gravatar_id":"","url":"https://api.github.com/users/jbossas","html_url":"https://github.com/jbossas","followers_url":"https://api.github.com/users/jbossas/followers","following_url":"https://api.github.com/users/jbossas/following{/other_user}","gists_url":"https://api.github.com/users/jbossas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbossas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbossas/subscriptions","organizations_url":"https://api.github.com/users/jbossas/orgs","repos_url":"https://api.github.com/users/jbossas/repos","events_url":"https://api.github.com/users/jbossas/events{/privacy}","received_events_url":"https://api.github.com/users/jbossas/received_events","type":"Organization","site_admin":false},"repo":{"id":2334210,"name":"jboss-ejb-client","full_name":"jbossas/jboss-ejb-client","owner":{"login":"jbossas","id":326816,"avatar_url":"https://avatars.githubusercontent.com/u/326816?v=3","gravatar_id":"","url":"https://api.github.com/users/jbossas","html_url":"https://github.com/jbossas","followers_url":"https://api.github.com/users/jbossas/followers","following_url":"https://api.github.com/users/jbossas/following{/other_user}","gists_url":"https://api.github.com/users/jbossas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbossas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbossas/subscriptions","organizations_url":"https://api.github.com/users/jbossas/orgs","repos_url":"https://api.github.com/users/jbossas/repos","events_url":"https://api.github.com/users/jbossas/events{/privacy}","received_events_url":"https://api.github.com/users/jbossas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbossas/jboss-ejb-client","description":"JBoss EJB client for AS7","fork":false,"url":"https://api.github.com/repos/jbossas/jboss-ejb-client","forks_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/forks","keys_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/teams","hooks_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/hooks","issue_events_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/issues/events{/number}","events_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/events","assignees_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/assignees{/user}","branches_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/branches{/branch}","tags_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/tags","blobs_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/statuses/{sha}","languages_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/languages","stargazers_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/stargazers","contributors_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/contributors","subscribers_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/subscribers","subscription_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/subscription","commits_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/contents/{+path}","compare_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/merges","archive_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/downloads","issues_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/issues{/number}","pulls_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls{/number}","milestones_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/milestones{/number}","notifications_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/labels{/name}","releases_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/releases{/id}","deployments_url":"https://api.github.com/repos/jbossas/jboss-ejb-client/deployments","created_at":"2011-09-06T12:19:54Z","updated_at":"2016-10-31T16:05:10Z","pushed_at":"2016-12-20T00:32:13Z","git_url":"git://github.com/jbossas/jboss-ejb-client.git","ssh_url":"git@github.com:jbossas/jboss-ejb-client.git","clone_url":"https://github.com/jbossas/jboss-ejb-client.git","svn_url":"https://github.com/jbossas/jboss-ejb-client","homepage":"","size":2376,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":5,"forks":82,"open_issues":5,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/180"},"html":{"href":"https://github.com/jbossas/jboss-ejb-client/pull/180"},"issue":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/issues/180"},"comments":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/jbossas/jboss-ejb-client/statuses/41997b9d6748883921e7383b3a596c4f71606c37"}}}}
{"actor":{"display_login":"dmlloyd"}}