{"action":"closed","number":1745,"pull_request":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1745","id":71922537,"html_url":"https://github.com/ImageEngine/gaffer/pull/1745","diff_url":"https://github.com/ImageEngine/gaffer/pull/1745.diff","patch_url":"https://github.com/ImageEngine/gaffer/pull/1745.patch","issue_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1745","number":1745,"state":"closed","locked":false,"title":"SceneReader : Remove scene:path from context","user":{"login":"ivanimanishi","id":4992829,"avatar_url":"https://avatars.githubusercontent.com/u/4992829?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanimanishi","html_url":"https://github.com/ivanimanishi","followers_url":"https://api.github.com/users/ivanimanishi/followers","following_url":"https://api.github.com/users/ivanimanishi/following{/other_user}","gists_url":"https://api.github.com/users/ivanimanishi/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanimanishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanimanishi/subscriptions","organizations_url":"https://api.github.com/users/ivanimanishi/orgs","repos_url":"https://api.github.com/users/ivanimanishi/repos","events_url":"https://api.github.com/users/ivanimanishi/events{/privacy}","received_events_url":"https://api.github.com/users/ivanimanishi/received_events","type":"User","site_admin":false},"body":"Hashing the fileName plug for every scene location can cause significant\r\nperformance loss, in particular in situations where we are dynamically setting\r\nthe fileName using an expression.\r\nThis has the downside of preventing us from changing the fileName per\r\nscene location, but giving that up seems like worth the advantage gained in\r\nperformance, given that we don't actually have a practical use for such feature.\r\n\r\n---\r\n@johnhaddon, I made this pull request based on your suggestion, and indeed it had a noticeable impact in performance in the dynamic scene builder.\r\nHowever, given my lack of experience in the details of the code I changed, feel free to close the PR and make a new one yourself if you feel that patching the PR is more work :smile: \r\n\r\n","created_at":"2016-05-30T16:47:18Z","updated_at":"2016-06-03T10:14:43Z","closed_at":"2016-06-03T10:14:43Z","merged_at":null,"merge_commit_sha":"7ed1b728a9cdf1ed7c760834644b21acb9f586df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1745/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1745/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1745/comments","statuses_url":"https://api.github.com/repos/ImageEngine/gaffer/statuses/e3d25272359ec125695782984d4122e999dfd4fe","head":{"label":"ivanimanishi:removeScenePathFromContext","ref":"removeScenePathFromContext","sha":"e3d25272359ec125695782984d4122e999dfd4fe","user":{"login":"ivanimanishi","id":4992829,"avatar_url":"https://avatars.githubusercontent.com/u/4992829?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanimanishi","html_url":"https://github.com/ivanimanishi","followers_url":"https://api.github.com/users/ivanimanishi/followers","following_url":"https://api.github.com/users/ivanimanishi/following{/other_user}","gists_url":"https://api.github.com/users/ivanimanishi/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanimanishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanimanishi/subscriptions","organizations_url":"https://api.github.com/users/ivanimanishi/orgs","repos_url":"https://api.github.com/users/ivanimanishi/repos","events_url":"https://api.github.com/users/ivanimanishi/events{/privacy}","received_events_url":"https://api.github.com/users/ivanimanishi/received_events","type":"User","site_admin":false},"repo":{"id":11776382,"name":"gaffer","full_name":"ivanimanishi/gaffer","owner":{"login":"ivanimanishi","id":4992829,"avatar_url":"https://avatars.githubusercontent.com/u/4992829?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanimanishi","html_url":"https://github.com/ivanimanishi","followers_url":"https://api.github.com/users/ivanimanishi/followers","following_url":"https://api.github.com/users/ivanimanishi/following{/other_user}","gists_url":"https://api.github.com/users/ivanimanishi/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanimanishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanimanishi/subscriptions","organizations_url":"https://api.github.com/users/ivanimanishi/orgs","repos_url":"https://api.github.com/users/ivanimanishi/repos","events_url":"https://api.github.com/users/ivanimanishi/events{/privacy}","received_events_url":"https://api.github.com/users/ivanimanishi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivanimanishi/gaffer","description":"Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.","fork":true,"url":"https://api.github.com/repos/ivanimanishi/gaffer","forks_url":"https://api.github.com/repos/ivanimanishi/gaffer/forks","keys_url":"https://api.github.com/repos/ivanimanishi/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanimanishi/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanimanishi/gaffer/teams","hooks_url":"https://api.github.com/repos/ivanimanishi/gaffer/hooks","issue_events_url":"https://api.github.com/repos/ivanimanishi/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/ivanimanishi/gaffer/events","assignees_url":"https://api.github.com/repos/ivanimanishi/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/ivanimanishi/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/ivanimanishi/gaffer/tags","blobs_url":"https://api.github.com/repos/ivanimanishi/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanimanishi/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanimanishi/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanimanishi/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanimanishi/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanimanishi/gaffer/languages","stargazers_url":"https://api.github.com/repos/ivanimanishi/gaffer/stargazers","contributors_url":"https://api.github.com/repos/ivanimanishi/gaffer/contributors","subscribers_url":"https://api.github.com/repos/ivanimanishi/gaffer/subscribers","subscription_url":"https://api.github.com/repos/ivanimanishi/gaffer/subscription","commits_url":"https://api.github.com/repos/ivanimanishi/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanimanishi/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanimanishi/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanimanishi/gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivanimanishi/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/ivanimanishi/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanimanishi/gaffer/merges","archive_url":"https://api.github.com/repos/ivanimanishi/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanimanishi/gaffer/downloads","issues_url":"https://api.github.com/repos/ivanimanishi/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/ivanimanishi/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanimanishi/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanimanishi/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanimanishi/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/ivanimanishi/gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/ivanimanishi/gaffer/deployments","created_at":"2013-07-30T21:46:38Z","updated_at":"2015-07-16T22:21:14Z","pushed_at":"2016-06-02T19:47:11Z","git_url":"git://github.com/ivanimanishi/gaffer.git","ssh_url":"git@github.com:ivanimanishi/gaffer.git","clone_url":"https://github.com/ivanimanishi/gaffer.git","svn_url":"https://github.com/ivanimanishi/gaffer","homepage":"","size":23045,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"53dbbce98831addba9fc26a98ca2ef341823dfa3","user":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?v=3","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":9043124,"name":"gaffer","full_name":"ImageEngine/gaffer","owner":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?v=3","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImageEngine/gaffer","description":"Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.","fork":false,"url":"https://api.github.com/repos/ImageEngine/gaffer","forks_url":"https://api.github.com/repos/ImageEngine/gaffer/forks","keys_url":"https://api.github.com/repos/ImageEngine/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/gaffer/teams","hooks_url":"https://api.github.com/repos/ImageEngine/gaffer/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/gaffer/events","assignees_url":"https://api.github.com/repos/ImageEngine/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/gaffer/tags","blobs_url":"https://api.github.com/repos/ImageEngine/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/gaffer/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/gaffer/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/gaffer/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/gaffer/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/gaffer/subscription","commits_url":"https://api.github.com/repos/ImageEngine/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImageEngine/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/gaffer/merges","archive_url":"https://api.github.com/repos/ImageEngine/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/gaffer/downloads","issues_url":"https://api.github.com/repos/ImageEngine/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/ImageEngine/gaffer/deployments","created_at":"2013-03-27T00:04:53Z","updated_at":"2016-05-26T18:27:50Z","pushed_at":"2016-06-03T01:03:01Z","git_url":"git://github.com/ImageEngine/gaffer.git","ssh_url":"git@github.com:ImageEngine/gaffer.git","clone_url":"https://github.com/ImageEngine/gaffer.git","svn_url":"https://github.com/ImageEngine/gaffer","homepage":"http://imageengine.github.io/gaffer/","size":108636,"stargazers_count":205,"watchers_count":205,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"open_issues_count":202,"forks":77,"open_issues":202,"watchers":205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1745"},"html":{"href":"https://github.com/ImageEngine/gaffer/pull/1745"},"issue":{"href":"https://api.github.com/repos/ImageEngine/gaffer/issues/1745"},"comments":{"href":"https://api.github.com/repos/ImageEngine/gaffer/issues/1745/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1745/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1745/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/gaffer/statuses/e3d25272359ec125695782984d4122e999dfd4fe"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":10,"review_comments":3,"commits":1,"additions":109,"deletions":23,"changed_files":3}}
{"actor":{"display_login":"johnhaddon"}}