{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/Microsoft/Ironclad/pulls/1","id":59585976,"html_url":"https://github.com/Microsoft/Ironclad/pull/1","diff_url":"https://github.com/Microsoft/Ironclad/pull/1.diff","patch_url":"https://github.com/Microsoft/Ironclad/pull/1.patch","issue_url":"https://api.github.com/repos/Microsoft/Ironclad/issues/1","number":1,"state":"closed","locked":false,"title":"Fix NuBuild bug that causes it to falsely report that verification succeeds","user":{"login":"pfons","id":17170177,"avatar_url":"https://avatars.githubusercontent.com/u/17170177?v=3","gravatar_id":"","url":"https://api.github.com/users/pfons","html_url":"https://github.com/pfons","followers_url":"https://api.github.com/users/pfons/followers","following_url":"https://api.github.com/users/pfons/following{/other_user}","gists_url":"https://api.github.com/users/pfons/gists{/gist_id}","starred_url":"https://api.github.com/users/pfons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfons/subscriptions","organizations_url":"https://api.github.com/users/pfons/orgs","repos_url":"https://api.github.com/users/pfons/repos","events_url":"https://api.github.com/users/pfons/events{/privacy}","received_events_url":"https://api.github.com/users/pfons/received_events","type":"User","site_admin":false},"body":"These commits fix a bug that causes NuBuild to falsely report to the user that the verification checks validate when, for example, the checks fail because the prover dies. The bug is caused by the order used to match regular expressions against Dafny's output in ironfleet/tools/NuBuild/NuBuild/VerificationResultDafnyParser.cs. A similar problem exists for the code that parses Boogie's output in VerificationResultBoogieParser.cs.\r\n\r\nThis bug is triggered in the current ironfleet repository because of another problem -- the included z3.exe binary was built for 64-bit while the included dll's where built for 32-bit architectures. This architecture mismatch causes z3 to fail to execute. More importantly, this mismatch triggers the NuBuild bug.\r\n\r\nThe following commits fix the NuBuild *source code* bug:\r\n  f63fc765b8281cfefb83c3193f403d4ca4a894c7\r\n  642512d56d29419932057c150936b9b9ecac36e1\r\n\r\nThe following commit fixes the z3.exe compatibility problem by reverting a commit made in October:\r\n  5516eb515b1fcc78f4db9ba7d35dfff49cbebb35\r\n\r\nIn addition, the NuBuild binary included in the repository (/ironfleet/bin_tools/NuBuild/NuBuild.exe) should be updated. I presume that you would want someone from Microsoft to build the binary so I have not included a patch for this.\r\n","created_at":"2016-02-17T02:02:16Z","updated_at":"2016-02-20T22:54:41Z","closed_at":"2016-02-20T22:54:41Z","merged_at":"2016-02-20T22:54:41Z","merge_commit_sha":"56b1e159e65a0b58d72fe1afa51aa16c5fc20b27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/Ironclad/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Microsoft/Ironclad/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Microsoft/Ironclad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/Ironclad/issues/1/comments","statuses_url":"https://api.github.com/repos/Microsoft/Ironclad/statuses/5516eb515b1fcc78f4db9ba7d35dfff49cbebb35","head":{"label":"pfons:master","ref":"master","sha":"5516eb515b1fcc78f4db9ba7d35dfff49cbebb35","user":{"login":"pfons","id":17170177,"avatar_url":"https://avatars.githubusercontent.com/u/17170177?v=3","gravatar_id":"","url":"https://api.github.com/users/pfons","html_url":"https://github.com/pfons","followers_url":"https://api.github.com/users/pfons/followers","following_url":"https://api.github.com/users/pfons/following{/other_user}","gists_url":"https://api.github.com/users/pfons/gists{/gist_id}","starred_url":"https://api.github.com/users/pfons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfons/subscriptions","organizations_url":"https://api.github.com/users/pfons/orgs","repos_url":"https://api.github.com/users/pfons/repos","events_url":"https://api.github.com/users/pfons/events{/privacy}","received_events_url":"https://api.github.com/users/pfons/received_events","type":"User","site_admin":false},"repo":{"id":51486165,"name":"Ironclad","full_name":"pfons/Ironclad","owner":{"login":"pfons","id":17170177,"avatar_url":"https://avatars.githubusercontent.com/u/17170177?v=3","gravatar_id":"","url":"https://api.github.com/users/pfons","html_url":"https://github.com/pfons","followers_url":"https://api.github.com/users/pfons/followers","following_url":"https://api.github.com/users/pfons/following{/other_user}","gists_url":"https://api.github.com/users/pfons/gists{/gist_id}","starred_url":"https://api.github.com/users/pfons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfons/subscriptions","organizations_url":"https://api.github.com/users/pfons/orgs","repos_url":"https://api.github.com/users/pfons/repos","events_url":"https://api.github.com/users/pfons/events{/privacy}","received_events_url":"https://api.github.com/users/pfons/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfons/Ironclad","description":"The MSR Ironclad project builds provably secure and reliable systems.","fork":true,"url":"https://api.github.com/repos/pfons/Ironclad","forks_url":"https://api.github.com/repos/pfons/Ironclad/forks","keys_url":"https://api.github.com/repos/pfons/Ironclad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfons/Ironclad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfons/Ironclad/teams","hooks_url":"https://api.github.com/repos/pfons/Ironclad/hooks","issue_events_url":"https://api.github.com/repos/pfons/Ironclad/issues/events{/number}","events_url":"https://api.github.com/repos/pfons/Ironclad/events","assignees_url":"https://api.github.com/repos/pfons/Ironclad/assignees{/user}","branches_url":"https://api.github.com/repos/pfons/Ironclad/branches{/branch}","tags_url":"https://api.github.com/repos/pfons/Ironclad/tags","blobs_url":"https://api.github.com/repos/pfons/Ironclad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfons/Ironclad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfons/Ironclad/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfons/Ironclad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfons/Ironclad/statuses/{sha}","languages_url":"https://api.github.com/repos/pfons/Ironclad/languages","stargazers_url":"https://api.github.com/repos/pfons/Ironclad/stargazers","contributors_url":"https://api.github.com/repos/pfons/Ironclad/contributors","subscribers_url":"https://api.github.com/repos/pfons/Ironclad/subscribers","subscription_url":"https://api.github.com/repos/pfons/Ironclad/subscription","commits_url":"https://api.github.com/repos/pfons/Ironclad/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfons/Ironclad/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfons/Ironclad/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfons/Ironclad/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfons/Ironclad/contents/{+path}","compare_url":"https://api.github.com/repos/pfons/Ironclad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfons/Ironclad/merges","archive_url":"https://api.github.com/repos/pfons/Ironclad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfons/Ironclad/downloads","issues_url":"https://api.github.com/repos/pfons/Ironclad/issues{/number}","pulls_url":"https://api.github.com/repos/pfons/Ironclad/pulls{/number}","milestones_url":"https://api.github.com/repos/pfons/Ironclad/milestones{/number}","notifications_url":"https://api.github.com/repos/pfons/Ironclad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfons/Ironclad/labels{/name}","releases_url":"https://api.github.com/repos/pfons/Ironclad/releases{/id}","deployments_url":"https://api.github.com/repos/pfons/Ironclad/deployments","created_at":"2016-02-11T01:11:18Z","updated_at":"2016-02-11T01:11:27Z","pushed_at":"2016-02-17T01:06:13Z","git_url":"git://github.com/pfons/Ironclad.git","ssh_url":"git@github.com:pfons/Ironclad.git","clone_url":"https://github.com/pfons/Ironclad.git","svn_url":"https://github.com/pfons/Ironclad","homepage":"http://research.microsoft.com/en-us/projects/ironclad/","size":67519,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0b366a4c3f4357b8fdbafef83f402cbddb8972c1","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":43025771,"name":"Ironclad","full_name":"Microsoft/Ironclad","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/Ironclad","description":"The MSR Ironclad project builds provably secure and reliable systems.","fork":false,"url":"https://api.github.com/repos/Microsoft/Ironclad","forks_url":"https://api.github.com/repos/Microsoft/Ironclad/forks","keys_url":"https://api.github.com/repos/Microsoft/Ironclad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/Ironclad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/Ironclad/teams","hooks_url":"https://api.github.com/repos/Microsoft/Ironclad/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/Ironclad/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/Ironclad/events","assignees_url":"https://api.github.com/repos/Microsoft/Ironclad/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/Ironclad/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/Ironclad/tags","blobs_url":"https://api.github.com/repos/Microsoft/Ironclad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/Ironclad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/Ironclad/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/Ironclad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/Ironclad/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/Ironclad/languages","stargazers_url":"https://api.github.com/repos/Microsoft/Ironclad/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/Ironclad/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/Ironclad/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/Ironclad/subscription","commits_url":"https://api.github.com/repos/Microsoft/Ironclad/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/Ironclad/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/Ironclad/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/Ironclad/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/Ironclad/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/Ironclad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/Ironclad/merges","archive_url":"https://api.github.com/repos/Microsoft/Ironclad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/Ironclad/downloads","issues_url":"https://api.github.com/repos/Microsoft/Ironclad/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/Ironclad/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/Ironclad/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/Ironclad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/Ironclad/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/Ironclad/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/Ironclad/deployments","created_at":"2015-09-23T20:44:40Z","updated_at":"2016-02-16T06:22:21Z","pushed_at":"2016-02-20T22:54:41Z","git_url":"git://github.com/Microsoft/Ironclad.git","ssh_url":"git@github.com:Microsoft/Ironclad.git","clone_url":"https://github.com/Microsoft/Ironclad.git","svn_url":"https://github.com/Microsoft/Ironclad","homepage":"http://research.microsoft.com/en-us/projects/ironclad/","size":67515,"stargazers_count":74,"watchers_count":74,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Ironclad/pulls/1"},"html":{"href":"https://github.com/Microsoft/Ironclad/pull/1"},"issue":{"href":"https://api.github.com/repos/Microsoft/Ironclad/issues/1"},"comments":{"href":"https://api.github.com/repos/Microsoft/Ironclad/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/Ironclad/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/Ironclad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/Ironclad/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/Ironclad/statuses/5516eb515b1fcc78f4db9ba7d35dfff49cbebb35"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"parno","id":1816417,"avatar_url":"https://avatars.githubusercontent.com/u/1816417?v=3","gravatar_id":"","url":"https://api.github.com/users/parno","html_url":"https://github.com/parno","followers_url":"https://api.github.com/users/parno/followers","following_url":"https://api.github.com/users/parno/following{/other_user}","gists_url":"https://api.github.com/users/parno/gists{/gist_id}","starred_url":"https://api.github.com/users/parno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parno/subscriptions","organizations_url":"https://api.github.com/users/parno/orgs","repos_url":"https://api.github.com/users/parno/repos","events_url":"https://api.github.com/users/parno/events{/privacy}","received_events_url":"https://api.github.com/users/parno/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":4,"additions":18,"deletions":18,"changed_files":4}}