{"push_id":997916349,"size":140,"distinct_size":1,"ref":"refs/heads/OneCore","head":"3312cce39ad81cdd189276dab18f3ce42d2a4f5b","before":"0b442a1de503856f281bb22146dbd38870511433","commits":[{"sha":"db4d650c93d83f613d89e6944bb8679a0993b5ea","author":{"email":"e9cb831f769ffd9c5f213f54a9462b8867751925@comcast.net","name":"Vance Morrison"},"message":"Revert \"Revert \"Remove useless security checks\"\"\n\nThis reverts commit a5e803cf70d861022f3b6cddb9045edb8a222e78.\nRemove more calls to PerformSecurityCheck","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/db4d650c93d83f613d89e6944bb8679a0993b5ea"},{"sha":"a4d72ac431ca439d79fb61b92480a499216b3f35","author":{"email":"3556ac400b2fa32d6fe0c2b1f0bfeaf2c52439f9@gmx.com","name":"Kamil Rytarowski"},"message":"Fix NetBSD build: Define PAL_STDCPP_COMPAT=1 for twowaypipe.cpp\n\nAfter recent changes in twowaypipe.cpp, this file started to use <pal.h>.\nIf we are mixing <pal.h> and system headers we need to define PAL_STDCPP_COMPAT\nby a preprocessor.\n\nRegression has been introduced with https://github.com/dotnet/coreclr/pull/3219\nGIT commit ID 4fee7ae253a271cc70028202104e92128d1a5bd8","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/a4d72ac431ca439d79fb61b92480a499216b3f35"},{"sha":"d47f6dce43ce951e48c431a7ececd9e0c54cb925","author":{"email":"999dfd9dcb6ec44d1c38d40e0b1591f62b17c6dc@microsoft.com","name":"Vance Morrison"},"message":"Add in code to do NullArgumentChecks for compatibiity","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/d47f6dce43ce951e48c431a7ececd9e0c54cb925"},{"sha":"6f387a835b4da5fce3bc199bd4286f15467e2f52","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Fix Guid.TryParse to not throw FormatException\n\nIn certain situations, e.g.\n```\nGuid g;\nGuid.TryParse(\"{0xdddddddd, 0xdddd, 0xdddd,{0xdd0xdd,0xdd,0xdd,0xdd,0xdd,0xdd,0xdd}}\", out g);\n```\nGuid.TryParse is throwing a FormatException rather than returning false.  This is due to a call to Convert.ToInt32 on one code path that's throwing.","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/6f387a835b4da5fce3bc199bd4286f15467e2f52"},{"sha":"d0ede1557b29f833268845ba85fd27bb66fcb23b","author":{"email":"a22b4474de9ac3ccbed81e5dd89fbfba42934a62@microsoft.com","name":"Andrew Schwartzmeyer"},"message":"Remove mask of SIGCHLD\n\nWhen a .NET Core program invoked a process that invoked its own child,\nthe masking of SIGCHLD prevented the process from recognizing its child\nhad exited, which some processes require. This caused the .NET Core app\nto hang in certain internal scenarios.","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/d0ede1557b29f833268845ba85fd27bb66fcb23b"},{"sha":"5c8e36a432f78f6535121b3e271804d49e8e6814","author":{"email":"3556ac400b2fa32d6fe0c2b1f0bfeaf2c52439f9@gmx.com","name":"Kamil Rytarowski"},"message":"Fix build issue on NetBSD: Include <stdarg.h> for va_list\n\nThis has been triggered during llilc build.","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/5c8e36a432f78f6535121b3e271804d49e8e6814"},{"sha":"21db33e10cfee04f914fdaceefa1ed2fd2ad1f52","author":{"email":"81ee8470e98a47362ed5f670b9c71e9136d75203@microsoft.com","name":"Lubomir Litchev"},"message":"Fix a hole in the GC generated for PutArgStructStk.\n\nOn System V there is a hole (tanks @CarolEidt for pointing it out) where\nwhile copying struct to the stack in the OutgoingParamArea the GC-ness\nfor the register used to copy the struct is not  properly set.\nThis change fixes the issue.\n\nThis change also makes sure when copying to/from stack, an emitAttr of\nEA_PTRSIZE is used - stack variables are never moved by GC, so using this\ntype in such case should is fine.","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/21db33e10cfee04f914fdaceefa1ed2fd2ad1f52"},{"sha":"e1a873cc9215fe92831c4b8c665fc07d60746b43","author":{"email":"fb7deaa9e792809fc3553a64020838ad5aa0b736@microsoft.com","name":"Rahul Kumar"},"message":"Add xunit.performance.core to core_root. required for few jit tests","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/e1a873cc9215fe92831c4b8c665fc07d60746b43"},{"sha":"0b1b9f4052de4019bb111f835771dfbba9c814c9","author":{"email":"202bfdaf89d4929b26015b6e3335e051707b8d9a@microsoft.com","name":"Jan Kotas"},"message":"Merge pull request #3304 from andschwa/sigchld\n\nRemove mask of SIGCHLD","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/0b1b9f4052de4019bb111f835771dfbba9c814c9"},{"sha":"bdd5be00414fc53d427a03f515e447f73f4fd5c5","author":{"email":"e3a3fd6809105b51407b0d7f47269f26ac1a7e92@users.noreply.github.com","name":"Lubomir Litchev"},"message":"Merge pull request #3303 from LLITCHEV/PutArgStk-GC-hole\n\nFix a hole in the GC generated for PutArgStructStk.\r\nThanks all!","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/bdd5be00414fc53d427a03f515e447f73f4fd5c5"},{"sha":"fff03183878a074539544f9b3c3d1cda8176fc85","author":{"email":"04b66ffb2360c42ea91fdf2fb99d31cafab10efd@microsoft.com","name":"Andy Ayers"},"message":"InlineRefactoring: capture remaining failing cases in inline tree\n\nThe main ininling loop in `fgInline` currently only looks at calls\nthat are inline candidates and at top-level in their statements.\nThis is sensible since any call that is an inline candidate has been\nhoisted to top-level during importing.\n\nHowever, to find all the failed inline cases, the jit also needs to\nlook through the full tree to find calls that were not identified as\ncandidates.\n\nFor instance, in the Secant test, the jit decides to inline `TestBase`\ninto `Main`. While importing the code for `TestBase` for inlining, the\njit sees that the call to `Bench` is marked with\n`[MethodImpl(MethodImplOptions.NoInlining)]` and so the call is not\nconsidered to be an inline candidate. And because `Bench` returns a\nvalue, the call expression is in a subtree under an assign expression.\nThus the failure to inline `Bench` is overlooked by the current code.\n\n```\n;; current code\nInlines into Secant:Main():int\n  [IL=0000 TR=000001] [below ALWAYS_INLINE size] Secant:TestBase():bool\n```\n\nWith this change, under DEBUG, the main inline control loop in `fgInline`\nnow also scans the tree for non-candidates, and adds their failures\nto the InlineContext tree in appropriate locations.\n\n`fgMorphInline` and `fgMorphInlineHelper` are now simpified since they\ncan assume any call they see must be a candidate.\n\nThe jit now also only notes failures for `CT_USER_FUNC` calls, since\notherwise the trees would be full of failed calls to helpers and the\nlike.\n\nWith this change, the jit can now report that `Bench` is a failed inline\ninto `Main`.\n\n```\n;; new code\nInlines into Secant:Main():int\n  [IL=0000 TR=000001] [below ALWAYS_INLINE size] Secant:TestBase():bool\n    [IL=0000 TR=000021] [FAILED: noinline per IL/cached result] Secant:Bench():bool\n```","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/fff03183878a074539544f9b3c3d1cda8176fc85"},{"sha":"c9dc9eab848e88142329435348538feedf9af03f","author":{"email":"202bfdaf89d4929b26015b6e3335e051707b8d9a@microsoft.com","name":"Jan Kotas"},"message":"Merge pull request #3307 from krytarowski/netbsd-support-56\n\nFix build issue on NetBSD: Include <stdarg.h> for va_list","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/c9dc9eab848e88142329435348538feedf9af03f"},{"sha":"b8f49126e79e850382d8837241b0dd27566de91f","author":{"email":"202bfdaf89d4929b26015b6e3335e051707b8d9a@microsoft.com","name":"Jan Kotas"},"message":"Merge pull request #3301 from stephentoub/fix_guid_tryparse\n\nFix Guid.TryParse to not throw FormatException","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/b8f49126e79e850382d8837241b0dd27566de91f"},{"sha":"e9fa953a295d16b7e00e9192b4973743398358e9","author":{"email":"04b66ffb2360c42ea91fdf2fb99d31cafab10efd@microsoft.com","name":"Andy Ayers"},"message":"Merge pull request #3300 from dotnet/InlineRefactor4f\n\nInlineRefactoring: capture remaining failing cases in inline tree","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/e9fa953a295d16b7e00e9192b4973743398358e9"},{"sha":"d5d25db5934520997ef085bd5f973451fd15a947","author":{"email":"04b66ffb2360c42ea91fdf2fb99d31cafab10efd@microsoft.com","name":"Andy Ayers"},"message":"InlineRefactoring: introducing InlinePolicy\n\nSplit the policy aspect of the InlineResult into a separate\npolicy object, acessed from the InlineResult via a base class.\n\nImplement a LegacyPolicy to capture today's behavior.\n\nCreate a factory method for determining what policy to use. Right\nnow it always creates a LegacyPolicy. This is newed up for each\nInline decision, but since the InlineResult has relatively short\nlifetime, we should probably recycle policy objects (might be\nmore desirable once they start having a bit more state).\n\nSplit out a bunch of the InlineDecision helper methods that lived\non InlineResult into global methods since policies will want to refer\nto them too. Shame that enum classes don't allow member functions.","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/d5d25db5934520997ef085bd5f973451fd15a947"},{"sha":"1ef30f932c1092ead58f7923f6dda999ae77780a","author":{"email":"b916ba105e4c59b94b07170a0d72274d0bb72d9b@microsoft.com","name":"Pallavi Taneja"},"message":"Expose necessary surface area required for API Convergence effort for System.Reflection\n\n[tfs-changeset: 1578145]","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/1ef30f932c1092ead58f7923f6dda999ae77780a"},{"sha":"89945b63fb8984326f30f4014bcea596df40a191","author":{"email":"2dfd39b59a5cc3dfc0e76b8fa77cf2409a993cc9@microsoft.com","name":"Carol Eidt"},"message":"Handle long operators with non-leaf operands on RyuJIT/x86\n\nFor non-leaf operands, we need to reorder more than just single nodes.\nMore complex handling is required if the two nodes being reordered\nhave side effects (that is NYI for now). Otherwise, we need to link\nthe first node in each sub-tree with the previous sub-tree.\n\nFixes #3292","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/89945b63fb8984326f30f4014bcea596df40a191"},{"sha":"73e596d0a44df010b6c66dc4f0a7342cb7955ee0","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Fix Guid.TryParse to not throw FormatException\n\nIn certain situations, e.g.\n```\nGuid g;\nGuid.TryParse(\"{0xdddddddd, 0xdddd, 0xdddd,{0xdd0xdd,0xdd,0xdd,0xdd,0xdd,0xdd,0xdd}}\", out g);\n```\nGuid.TryParse is throwing a FormatException rather than returning false.  This is due to a call to Convert.ToInt32 on one code path that's throwing.","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/73e596d0a44df010b6c66dc4f0a7342cb7955ee0"},{"sha":"ac71f8a8a4ed23bbcacb449537a8bce2053c9f29","author":{"email":"912754483933a2b0e99f82f04ef3d6d551431637@gmail.com","name":"tijoytom"},"message":"Adding more interop tests.","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/ac71f8a8a4ed23bbcacb449537a8bce2053c9f29"},{"sha":"bd1025e4b603655a239b15bcc93d817cb1caec8d","author":{"email":"0a64d801e9c9a4c0b032feabb5e728f05c3a2ece@microsoft.com","name":"Jose Perez Rodriguez"},"message":"Correctly cleaning up the ToolRuntime folder once a new version is required","distinct":false,"url":"https://api.github.com/repos/gkhanna79/coreclr/commits/bd1025e4b603655a239b15bcc93d817cb1caec8d"}]}