{"action":"created","issue":{"url":"https://api.github.com/repos/auraphp/Aura.Sql/issues/116","repository_url":"https://api.github.com/repos/auraphp/Aura.Sql","labels_url":"https://api.github.com/repos/auraphp/Aura.Sql/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/auraphp/Aura.Sql/issues/116/comments","events_url":"https://api.github.com/repos/auraphp/Aura.Sql/issues/116/events","html_url":"https://github.com/auraphp/Aura.Sql/pull/116","id":139406851,"number":116,"title":"split lazy connections into LazyExtendedPdo","user":{"login":"pavarnos","id":589595,"avatar_url":"https://avatars.githubusercontent.com/u/589595?v=3","gravatar_id":"","url":"https://api.github.com/users/pavarnos","html_url":"https://github.com/pavarnos","followers_url":"https://api.github.com/users/pavarnos/followers","following_url":"https://api.github.com/users/pavarnos/following{/other_user}","gists_url":"https://api.github.com/users/pavarnos/gists{/gist_id}","starred_url":"https://api.github.com/users/pavarnos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavarnos/subscriptions","organizations_url":"https://api.github.com/users/pavarnos/orgs","repos_url":"https://api.github.com/users/pavarnos/repos","events_url":"https://api.github.com/users/pavarnos/events{/privacy}","received_events_url":"https://api.github.com/users/pavarnos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-08T22:04:22Z","updated_at":"2016-03-10T15:33:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/auraphp/Aura.Sql/pulls/116","html_url":"https://github.com/auraphp/Aura.Sql/pull/116","diff_url":"https://github.com/auraphp/Aura.Sql/pull/116.diff","patch_url":"https://github.com/auraphp/Aura.Sql/pull/116.patch"},"body":"for #114"},"comment":{"url":"https://api.github.com/repos/auraphp/Aura.Sql/issues/comments/194906471","html_url":"https://github.com/auraphp/Aura.Sql/pull/116#issuecomment-194906471","issue_url":"https://api.github.com/repos/auraphp/Aura.Sql/issues/116","id":194906471,"user":{"login":"pmjones","id":25754,"avatar_url":"https://avatars.githubusercontent.com/u/25754?v=3","gravatar_id":"","url":"https://api.github.com/users/pmjones","html_url":"https://github.com/pmjones","followers_url":"https://api.github.com/users/pmjones/followers","following_url":"https://api.github.com/users/pmjones/following{/other_user}","gists_url":"https://api.github.com/users/pmjones/gists{/gist_id}","starred_url":"https://api.github.com/users/pmjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmjones/subscriptions","organizations_url":"https://api.github.com/users/pmjones/orgs","repos_url":"https://api.github.com/users/pmjones/repos","events_url":"https://api.github.com/users/pmjones/events{/privacy}","received_events_url":"https://api.github.com/users/pmjones/received_events","type":"User","site_admin":false},"created_at":"2016-03-10T15:33:11Z","updated_at":"2016-03-10T15:33:11Z","body":"All righty, next round of critique:\r\n\r\nSplitting up the single ExtendedPdo from 2.x into two classes in 3.x leaves us with what are essentially several duplicated methods between the two classes (only 1 line of difference in a lot of them). My bet is that you can get away with putting a couple of stub or empty methods in ExtendedPdo, that only LazyExtendedPdo will use; or, perhaps, override perform() in LazyExtendedPdo() to connect(), then call parent::perform(). In any case, the goal would be to consolidate as much as possible into a single class, and let LazyExtendedPdo override only the bits it needs.\r\n\r\nDo you see what I'm getting at there?\r\n\r\nAgain, thanks for your work here."}}