{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/mediawiki-title/issues/3","repository_url":"https://api.github.com/repos/wikimedia/mediawiki-title","labels_url":"https://api.github.com/repos/wikimedia/mediawiki-title/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/mediawiki-title/issues/3/comments","events_url":"https://api.github.com/repos/wikimedia/mediawiki-title/issues/3/events","html_url":"https://github.com/wikimedia/mediawiki-title/pull/3","id":139976129,"number":3,"title":"Don't include the fragment","user":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars.githubusercontent.com/u/814754?v=3","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-10T18:42:15Z","updated_at":"2016-03-11T18:09:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/mediawiki-title/pulls/3","html_url":"https://github.com/wikimedia/mediawiki-title/pull/3","diff_url":"https://github.com/wikimedia/mediawiki-title/pull/3.diff","patch_url":"https://github.com/wikimedia/mediawiki-title/pull/3.patch"},"body":"Some more thinking made me reconsider. We don't need to include a fragment in the normalised title, as the primary user of the library is RESTBase and Parsoid, and those fragments mean nothing for them. So, we need ti strip out the fragment as nobody should actually send them. Also fragment stripping doesn't work in varnish for us -> one more reason to strip them.\r\n\r\ncc @wikimedia/services "},"comment":{"url":"https://api.github.com/repos/wikimedia/mediawiki-title/issues/comments/195481972","html_url":"https://github.com/wikimedia/mediawiki-title/pull/3#issuecomment-195481972","issue_url":"https://api.github.com/repos/wikimedia/mediawiki-title/issues/3","id":195481972,"user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"created_at":"2016-03-11T18:09:58Z","updated_at":"2016-03-11T18:09:58Z","body":"We discussed this in the office. While we agreed that handling %23 the same as a literal # is broken, it has been implemented this way in MediaWiki for a long time. Another aspect is that broken clients might just send the href attribute from HTML, which would also result in originally bare hashes being encoded to %23.\r\n\r\nSo, lets be bug-for-bug compatible."}}