{"action":"created","comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/72443562","id":72443562,"diff_hunk":"@@ -36,6 +36,8 @@ def gen_classes():\n             pass\n         elif member is configtypes.MappingType:\n             pass\n+        elif member in [configtypes.List, configtypes.LengthList]:\n+            pass","path":"tests/unit/config/test_configtypes_hypothesis.py","position":5,"original_position":5,"commit_id":"a3c7ed51d4b935683d99b87aa2063cfb2f721db5","original_commit_id":"a3c7ed51d4b935683d99b87aa2063cfb2f721db5","user":{"login":"mlochbaum","id":1320219,"avatar_url":"https://avatars.githubusercontent.com/u/1320219?v=3","gravatar_id":"","url":"https://api.github.com/users/mlochbaum","html_url":"https://github.com/mlochbaum","followers_url":"https://api.github.com/users/mlochbaum/followers","following_url":"https://api.github.com/users/mlochbaum/following{/other_user}","gists_url":"https://api.github.com/users/mlochbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/mlochbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlochbaum/subscriptions","organizations_url":"https://api.github.com/users/mlochbaum/orgs","repos_url":"https://api.github.com/users/mlochbaum/repos","events_url":"https://api.github.com/users/mlochbaum/events{/privacy}","received_events_url":"https://api.github.com/users/mlochbaum/received_events","type":"User","site_admin":false},"body":"The reason is that I didn't know how to do that. On it...","created_at":"2016-07-27T13:57:58Z","updated_at":"2016-07-27T13:57:58Z","html_url":"https://github.com/The-Compiler/qutebrowser/pull/1691#discussion_r72443562","pull_request_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1691","_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/72443562"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/1691#discussion_r72443562"},"pull_request":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1691"}}},"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1691","id":78962789,"html_url":"https://github.com/The-Compiler/qutebrowser/pull/1691","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/1691.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/1691.patch","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1691","number":1691,"state":"open","locked":false,"title":"Generalize configtypes.List","user":{"login":"mlochbaum","id":1320219,"avatar_url":"https://avatars.githubusercontent.com/u/1320219?v=3","gravatar_id":"","url":"https://api.github.com/users/mlochbaum","html_url":"https://github.com/mlochbaum","followers_url":"https://api.github.com/users/mlochbaum/followers","following_url":"https://api.github.com/users/mlochbaum/following{/other_user}","gists_url":"https://api.github.com/users/mlochbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/mlochbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlochbaum/subscriptions","organizations_url":"https://api.github.com/users/mlochbaum/orgs","repos_url":"https://api.github.com/users/mlochbaum/repos","events_url":"https://api.github.com/users/mlochbaum/events{/privacy}","received_events_url":"https://api.github.com/users/mlochbaum/received_events","type":"User","site_admin":false},"body":"As promised, code for #989. In addition to the `List` type, which is basically the same as the one described there, I implemented `LengthList` (no pun intended, seriously) which enforces a length on the value provided it isn't empty. Everything was tested for compatibility by recreating the old classes as subclasses of the new ones, and then those versions and their tests were deleted.\r\n\r\nThe old classes mostly conflated the inner `none_ok` with the outer one, and I haven't given serious thought to which one is required in all cases. Probably worth looking over. Also, three of the values just used plain `List` when they should probably have stricter requirements; for now they use a new class `BaseList`.","created_at":"2016-07-27T04:10:54Z","updated_at":"2016-07-27T13:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84f3f8fd1d88f3253a2ae6eb39fbfca37e221f23","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1691/commits","review_comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1691/comments","review_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1691/comments","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/a3c7ed51d4b935683d99b87aa2063cfb2f721db5","head":{"label":"mlochbaum:generalize-list-type","ref":"generalize-list-type","sha":"a3c7ed51d4b935683d99b87aa2063cfb2f721db5","user":{"login":"mlochbaum","id":1320219,"avatar_url":"https://avatars.githubusercontent.com/u/1320219?v=3","gravatar_id":"","url":"https://api.github.com/users/mlochbaum","html_url":"https://github.com/mlochbaum","followers_url":"https://api.github.com/users/mlochbaum/followers","following_url":"https://api.github.com/users/mlochbaum/following{/other_user}","gists_url":"https://api.github.com/users/mlochbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/mlochbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlochbaum/subscriptions","organizations_url":"https://api.github.com/users/mlochbaum/orgs","repos_url":"https://api.github.com/users/mlochbaum/repos","events_url":"https://api.github.com/users/mlochbaum/events{/privacy}","received_events_url":"https://api.github.com/users/mlochbaum/received_events","type":"User","site_admin":false},"repo":{"id":63917546,"name":"qutebrowser","full_name":"mlochbaum/qutebrowser","owner":{"login":"mlochbaum","id":1320219,"avatar_url":"https://avatars.githubusercontent.com/u/1320219?v=3","gravatar_id":"","url":"https://api.github.com/users/mlochbaum","html_url":"https://github.com/mlochbaum","followers_url":"https://api.github.com/users/mlochbaum/followers","following_url":"https://api.github.com/users/mlochbaum/following{/other_user}","gists_url":"https://api.github.com/users/mlochbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/mlochbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlochbaum/subscriptions","organizations_url":"https://api.github.com/users/mlochbaum/orgs","repos_url":"https://api.github.com/users/mlochbaum/repos","events_url":"https://api.github.com/users/mlochbaum/events{/privacy}","received_events_url":"https://api.github.com/users/mlochbaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlochbaum/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":true,"url":"https://api.github.com/repos/mlochbaum/qutebrowser","forks_url":"https://api.github.com/repos/mlochbaum/qutebrowser/forks","keys_url":"https://api.github.com/repos/mlochbaum/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlochbaum/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlochbaum/qutebrowser/teams","hooks_url":"https://api.github.com/repos/mlochbaum/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/mlochbaum/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/mlochbaum/qutebrowser/events","assignees_url":"https://api.github.com/repos/mlochbaum/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/mlochbaum/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/mlochbaum/qutebrowser/tags","blobs_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlochbaum/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/mlochbaum/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/mlochbaum/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/mlochbaum/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/mlochbaum/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/mlochbaum/qutebrowser/subscription","commits_url":"https://api.github.com/repos/mlochbaum/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlochbaum/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlochbaum/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlochbaum/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/mlochbaum/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlochbaum/qutebrowser/merges","archive_url":"https://api.github.com/repos/mlochbaum/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlochbaum/qutebrowser/downloads","issues_url":"https://api.github.com/repos/mlochbaum/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/mlochbaum/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/mlochbaum/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/mlochbaum/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlochbaum/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/mlochbaum/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/mlochbaum/qutebrowser/deployments","created_at":"2016-07-22T02:36:22Z","updated_at":"2016-07-22T02:36:24Z","pushed_at":"2016-07-27T04:01:23Z","git_url":"git://github.com/mlochbaum/qutebrowser.git","ssh_url":"git@github.com:mlochbaum/qutebrowser.git","clone_url":"https://github.com/mlochbaum/qutebrowser.git","svn_url":"https://github.com/mlochbaum/qutebrowser","homepage":"https://www.qutebrowser.org/","size":18176,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"The-Compiler:master","ref":"master","sha":"f460a225ef4d14e43d1f6803642e20864b957c27","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"The-Compiler/qutebrowser","owner":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Compiler/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":false,"url":"https://api.github.com/repos/The-Compiler/qutebrowser","forks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/forks","keys_url":"https://api.github.com/repos/The-Compiler/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Compiler/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Compiler/qutebrowser/teams","hooks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/events","assignees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/The-Compiler/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/tags","blobs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Compiler/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscription","commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/The-Compiler/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Compiler/qutebrowser/merges","archive_url":"https://api.github.com/repos/The-Compiler/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Compiler/qutebrowser/downloads","issues_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Compiler/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Compiler/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/The-Compiler/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/deployments","created_at":"2014-06-26T14:59:34Z","updated_at":"2016-07-27T13:20:27Z","pushed_at":"2016-07-27T11:05:13Z","git_url":"git://github.com/The-Compiler/qutebrowser.git","ssh_url":"git@github.com:The-Compiler/qutebrowser.git","clone_url":"https://github.com/The-Compiler/qutebrowser.git","svn_url":"https://github.com/The-Compiler/qutebrowser","homepage":"https://www.qutebrowser.org/","size":21834,"stargazers_count":1285,"watchers_count":1285,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":405,"forks":203,"open_issues":405,"watchers":1285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1691"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/1691"},"issue":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1691"},"comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1691/comments"},"review_comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1691/comments"},"review_comment":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1691/commits"},"statuses":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/a3c7ed51d4b935683d99b87aa2063cfb2f721db5"}}}}
{"actor":{"display_login":"mlochbaum"}}