{"action":"created","issue":{"url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2193","repository_url":"https://api.github.com/repos/PhilJay/MPAndroidChart","labels_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2193/labels{/name}","comments_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2193/comments","events_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2193/events","html_url":"https://github.com/PhilJay/MPAndroidChart/pull/2193","id":172960823,"number":2193,"title":"Pie chart, fix for small values appearing as background","user":{"login":"relair","id":13729116,"avatar_url":"https://avatars.githubusercontent.com/u/13729116?v=3","gravatar_id":"","url":"https://api.github.com/users/relair","html_url":"https://github.com/relair","followers_url":"https://api.github.com/users/relair/followers","following_url":"https://api.github.com/users/relair/following{/other_user}","gists_url":"https://api.github.com/users/relair/gists{/gist_id}","starred_url":"https://api.github.com/users/relair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relair/subscriptions","organizations_url":"https://api.github.com/users/relair/orgs","repos_url":"https://api.github.com/users/relair/repos","events_url":"https://api.github.com/users/relair/events{/privacy}","received_events_url":"https://api.github.com/users/relair/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-24T14:04:45Z","updated_at":"2016-08-30T13:14:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/2193","html_url":"https://github.com/PhilJay/MPAndroidChart/pull/2193","diff_url":"https://github.com/PhilJay/MPAndroidChart/pull/2193.diff","patch_url":"https://github.com/PhilJay/MPAndroidChart/pull/2193.patch"},"body":"This fix is so small values won't appear as \"background\" (which really is a huge circle) when slice space is used.\r\nI've found out that because sweepAngleOuter is negative it gets set to 0 which then causes arcStartPointX and arcStartPointY not to be set. Both arcStartPointX and arcStartPointY are used in calculateMinimumRadiusForSpacedSlice which calculates huge negative value because of that, which is then turned into huge positive value in the next line.\r\nIn the end we end up with a tiny value creating huge circle that looks like a background."},"comment":{"url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/comments/243434193","html_url":"https://github.com/PhilJay/MPAndroidChart/pull/2193#issuecomment-243434193","issue_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2193","id":243434193,"user":{"login":"relair","id":13729116,"avatar_url":"https://avatars.githubusercontent.com/u/13729116?v=3","gravatar_id":"","url":"https://api.github.com/users/relair","html_url":"https://github.com/relair","followers_url":"https://api.github.com/users/relair/followers","following_url":"https://api.github.com/users/relair/following{/other_user}","gists_url":"https://api.github.com/users/relair/gists{/gist_id}","starred_url":"https://api.github.com/users/relair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relair/subscriptions","organizations_url":"https://api.github.com/users/relair/orgs","repos_url":"https://api.github.com/users/relair/repos","events_url":"https://api.github.com/users/relair/events{/privacy}","received_events_url":"https://api.github.com/users/relair/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T13:14:05Z","updated_at":"2016-08-30T13:14:05Z","body":"I tested it for several cases different cases  - with separator, and no separator. I currently have it like that as an overridden method and it seems to work fine - we have it on production right now.\r\nEssentially I found out the solution by comparing this library with its iOS mirror, as the issue didn't happen there.\r\nI am not sure what other kinds of data could I test it with, could you please clarify?\r\n"}}
{"actor":{"display_login":"relair"}}