{"action":"created","issue":{"url":"https://api.github.com/repos/pdebuyl/fortran_tester/issues/4","repository_url":"https://api.github.com/repos/pdebuyl/fortran_tester","labels_url":"https://api.github.com/repos/pdebuyl/fortran_tester/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/pdebuyl/fortran_tester/issues/4/comments","events_url":"https://api.github.com/repos/pdebuyl/fortran_tester/issues/4/events","html_url":"https://github.com/pdebuyl/fortran_tester/pull/4","id":183023579,"number":4,"title":"Improve support for multi kinds and add portable kinds","user":{"login":"szaghi","id":1661942,"avatar_url":"https://avatars.githubusercontent.com/u/1661942?v=3","gravatar_id":"","url":"https://api.github.com/users/szaghi","html_url":"https://github.com/szaghi","followers_url":"https://api.github.com/users/szaghi/followers","following_url":"https://api.github.com/users/szaghi/following{/other_user}","gists_url":"https://api.github.com/users/szaghi/gists{/gist_id}","starred_url":"https://api.github.com/users/szaghi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szaghi/subscriptions","organizations_url":"https://api.github.com/users/szaghi/orgs","repos_url":"https://api.github.com/users/szaghi/repos","events_url":"https://api.github.com/users/szaghi/events{/privacy}","received_events_url":"https://api.github.com/users/szaghi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-14T11:07:01Z","updated_at":"2016-10-14T14:03:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pdebuyl/fortran_tester/pulls/4","html_url":"https://github.com/pdebuyl/fortran_tester/pull/4","diff_url":"https://github.com/pdebuyl/fortran_tester/pull/4.diff","patch_url":"https://github.com/pdebuyl/fortran_tester/pull/4.patch"},"body":"### Introduction\r\n\r\nDear @pdebuyl your are a *Wiseman*, I like the exploitation of dynamic dispatch, but not all kinds for both integer and real were previously supported. Moreover, there is not real support for portable kinds (real and double precision definition can mean different things on different *architectures*).\r\n\r\nThis patch adds support for all integer kinds and for 32/64 bits real kinds (128 bits will be added in future if necessary).\r\n\r\n**Public API is fully backward compatible, only internal API has been changed.**\r\n\r\nI have also added a complete support for rank 1 arrays that was only partial previously.\r\n\r\n### Why\r\n\r\nI need at least integer with 64 bits, but instead of adding only int64 support I prefer to complete the support for all kinds.\r\n\r\n### This change addresses the need by\r\n\r\nList of main modifications:\r\n\r\n+ minor changes:\r\n  + add *docstrings* to anything: this is a preliminary step to add API\r\n  html doc;\r\n  + initialize *tester_* members;\r\n  + trim out `double precision` in flavor of `real(real64)`;\r\n+ major changes:\r\n  + `assert_equal`\r\n    + add support for integer(8/16/32/64 bits);\r\n    + add support for real(32/64 bits);\r\n    + add support for arrays of integer(8/16/32/64 bits);\r\n    + add support for arrays of real(32/64 bits);\r\n  + `assert_positive`\r\n    + add support for integer(8/16/32/64 bits);\r\n    + add support for real(32/64 bits);\r\n    + add support for arrays of integer(8/16/32/64 bits);\r\n    + add support for arrays of real(32/64 bits);\r\n  + `assert_close`\r\n    + add support for real(32/64 bits);\r\n    + add support for arrays of real(32/64 bits);\r\n\r\n### Side effects\r\n\r\nNothing observed. \r\n\r\n### TODO\r\n\r\nAdd new tests for all the new kinds introduced.\r\n\r\n## Feel free to not accept this patch if you do not like, do not worry to offend me :smile: "},"comment":{"url":"https://api.github.com/repos/pdebuyl/fortran_tester/issues/comments/253808629","html_url":"https://github.com/pdebuyl/fortran_tester/pull/4#issuecomment-253808629","issue_url":"https://api.github.com/repos/pdebuyl/fortran_tester/issues/4","id":253808629,"user":{"login":"szaghi","id":1661942,"avatar_url":"https://avatars.githubusercontent.com/u/1661942?v=3","gravatar_id":"","url":"https://api.github.com/users/szaghi","html_url":"https://github.com/szaghi","followers_url":"https://api.github.com/users/szaghi/followers","following_url":"https://api.github.com/users/szaghi/following{/other_user}","gists_url":"https://api.github.com/users/szaghi/gists{/gist_id}","starred_url":"https://api.github.com/users/szaghi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szaghi/subscriptions","organizations_url":"https://api.github.com/users/szaghi/orgs","repos_url":"https://api.github.com/users/szaghi/repos","events_url":"https://api.github.com/users/szaghi/events{/privacy}","received_events_url":"https://api.github.com/users/szaghi/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T14:03:33Z","updated_at":"2016-10-14T14:03:33Z","body":"@pdebuyl \r\n\r\nYour tester is really **amazing**, thank to you!\r\n\r\nFor the license no problem, I simply miss your BSD-like; in the future all my poor contributes will be bsd-licensed.\r\n\r\nFor the DOC: I have used a syntax for FORD that should be usable with also doxygen... The duplication of README is my bad addiction... with projects using many libraries I put there a link of all readmes... I'll trim it out soon."}}
{"actor":{"display_login":"szaghi"}}