{"action":"closed","number":830,"pull_request":{"url":"https://api.github.com/repos/atom/settings-view/pulls/830","id":81574152,"html_url":"https://github.com/atom/settings-view/pull/830","diff_url":"https://github.com/atom/settings-view/pull/830.diff","patch_url":"https://github.com/atom/settings-view/pull/830.patch","issue_url":"https://api.github.com/repos/atom/settings-view/issues/830","number":830,"state":"closed","locked":false,"title":"Fix the problem that tabLength of language scope jumps back to global…","user":{"login":"taot","id":1867783,"avatar_url":"https://avatars.githubusercontent.com/u/1867783?v=3","gravatar_id":"","url":"https://api.github.com/users/taot","html_url":"https://github.com/taot","followers_url":"https://api.github.com/users/taot/followers","following_url":"https://api.github.com/users/taot/following{/other_user}","gists_url":"https://api.github.com/users/taot/gists{/gist_id}","starred_url":"https://api.github.com/users/taot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taot/subscriptions","organizations_url":"https://api.github.com/users/taot/orgs","repos_url":"https://api.github.com/users/taot/repos","events_url":"https://api.github.com/users/taot/events{/privacy}","received_events_url":"https://api.github.com/users/taot/received_events","type":"User","site_admin":false},"body":"When I set tabLength to 4 in global editor setting, and set it to 2 in language scope setting (such as coffeescript or scala), the one in language setting immediately jumps back to 4. Even when I set it in config file, it still jumps back. It turned out the settings-view does not look at global settings when resetting to default.\n\nSo I made this small patch. However I could not make up a valid unit test for this successfully. I tried to reproduce the issue with a jasmine spec, but with no success. I think I am still not familiar enough with Atom yet. So I plan to look at Atom code. And I will be grateful if someone is familiar with Atom and also willing to give me some advice on the unit test.\n","created_at":"2016-08-17T02:09:37Z","updated_at":"2016-12-08T02:59:06Z","closed_at":"2016-12-08T02:59:06Z","merged_at":null,"merge_commit_sha":"629cdda2540685a3a2b0f390785cedd70d29d2f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/settings-view/pulls/830/commits","review_comments_url":"https://api.github.com/repos/atom/settings-view/pulls/830/comments","review_comment_url":"https://api.github.com/repos/atom/settings-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/settings-view/issues/830/comments","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/38617c916994ce05ce9611b0337057d1fb8bb8e3","head":{"label":"taot:master","ref":"master","sha":"38617c916994ce05ce9611b0337057d1fb8bb8e3","user":{"login":"taot","id":1867783,"avatar_url":"https://avatars.githubusercontent.com/u/1867783?v=3","gravatar_id":"","url":"https://api.github.com/users/taot","html_url":"https://github.com/taot","followers_url":"https://api.github.com/users/taot/followers","following_url":"https://api.github.com/users/taot/following{/other_user}","gists_url":"https://api.github.com/users/taot/gists{/gist_id}","starred_url":"https://api.github.com/users/taot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taot/subscriptions","organizations_url":"https://api.github.com/users/taot/orgs","repos_url":"https://api.github.com/users/taot/repos","events_url":"https://api.github.com/users/taot/events{/privacy}","received_events_url":"https://api.github.com/users/taot/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"atom:master","ref":"master","sha":"38cb3e969a8e417909a4b9649e46502fa7b72707","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":12090329,"name":"settings-view","full_name":"atom/settings-view","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/settings-view","description":"Edit Atom settings","fork":false,"url":"https://api.github.com/repos/atom/settings-view","forks_url":"https://api.github.com/repos/atom/settings-view/forks","keys_url":"https://api.github.com/repos/atom/settings-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/settings-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/settings-view/teams","hooks_url":"https://api.github.com/repos/atom/settings-view/hooks","issue_events_url":"https://api.github.com/repos/atom/settings-view/issues/events{/number}","events_url":"https://api.github.com/repos/atom/settings-view/events","assignees_url":"https://api.github.com/repos/atom/settings-view/assignees{/user}","branches_url":"https://api.github.com/repos/atom/settings-view/branches{/branch}","tags_url":"https://api.github.com/repos/atom/settings-view/tags","blobs_url":"https://api.github.com/repos/atom/settings-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/settings-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/settings-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/settings-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/settings-view/languages","stargazers_url":"https://api.github.com/repos/atom/settings-view/stargazers","contributors_url":"https://api.github.com/repos/atom/settings-view/contributors","subscribers_url":"https://api.github.com/repos/atom/settings-view/subscribers","subscription_url":"https://api.github.com/repos/atom/settings-view/subscription","commits_url":"https://api.github.com/repos/atom/settings-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/settings-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/settings-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/settings-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/settings-view/contents/{+path}","compare_url":"https://api.github.com/repos/atom/settings-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/settings-view/merges","archive_url":"https://api.github.com/repos/atom/settings-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/settings-view/downloads","issues_url":"https://api.github.com/repos/atom/settings-view/issues{/number}","pulls_url":"https://api.github.com/repos/atom/settings-view/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/settings-view/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/settings-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/settings-view/labels{/name}","releases_url":"https://api.github.com/repos/atom/settings-view/releases{/id}","deployments_url":"https://api.github.com/repos/atom/settings-view/deployments","created_at":"2013-08-13T19:16:23Z","updated_at":"2016-11-28T14:10:42Z","pushed_at":"2016-12-08T02:17:43Z","git_url":"git://github.com/atom/settings-view.git","ssh_url":"git@github.com:atom/settings-view.git","clone_url":"https://github.com/atom/settings-view.git","svn_url":"https://github.com/atom/settings-view","homepage":null,"size":2407,"stargazers_count":100,"watchers_count":100,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":140,"forks":98,"open_issues":140,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/settings-view/pulls/830"},"html":{"href":"https://github.com/atom/settings-view/pull/830"},"issue":{"href":"https://api.github.com/repos/atom/settings-view/issues/830"},"comments":{"href":"https://api.github.com/repos/atom/settings-view/issues/830/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/settings-view/pulls/830/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/settings-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/settings-view/pulls/830/commits"},"statuses":{"href":"https://api.github.com/repos/atom/settings-view/statuses/38617c916994ce05ce9611b0337057d1fb8bb8e3"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"50Wliu"}}