{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/71851623","id":71851623,"diff_hunk":"@@ -765,14 +758,14 @@ emptyBenchmark = mempty\n hasBenchmarks :: PackageDescription -> Bool\n hasBenchmarks = any (buildable . benchmarkBuildInfo) . benchmarks\n \n--- | Get all the enabled benchmarks from a package.\n-enabledBenchmarks :: PackageDescription -> [Benchmark]\n-enabledBenchmarks = filter benchmarkEnabled . benchmarks\n-\n -- | Perform an action on each buildable 'Benchmark' in a package.\n+-- You probably want 'withBenchLBI' if you have a 'LocalBuildInfo', see the note in\n+-- \"Distribution.Simple.LocalBuildInfo#buildable_vs_enabled_components\"","path":"Cabal/Distribution/PackageDescription.hs","position":148,"original_position":148,"commit_id":"193f49da018c7f91cf551f4cd606abb9ba4b3da5","original_commit_id":"193f49da018c7f91cf551f4cd606abb9ba4b3da5","user":{"login":"23Skidoo","id":47439,"avatar_url":"https://avatars.githubusercontent.com/u/47439?v=3","gravatar_id":"","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"body":"This note lives in `Cabal/Distribution/Types/ComponentEnabledSpec.hs` now.","created_at":"2016-07-22T09:30:12Z","updated_at":"2016-07-22T09:30:12Z","html_url":"https://github.com/haskell/cabal/pull/3542#discussion_r71851623","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/3542","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/71851623"},"html":{"href":"https://github.com/haskell/cabal/pull/3542#discussion_r71851623"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3542"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/3542","id":77070795,"html_url":"https://github.com/haskell/cabal/pull/3542","diff_url":"https://github.com/haskell/cabal/pull/3542.diff","patch_url":"https://github.com/haskell/cabal/pull/3542.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/3542","number":3542,"state":"closed","locked":false,"title":"Introduce new ComponentEnabledSpec, removing testEnabled/benchmarkEna…","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"…bled.\r\n\r\nAs per an existing TODO in the code, the use of\r\ntestEnabled/benchmarkEnabled to indicate if a component\r\nwas enabled/disabled by the user command line was an\r\negregious violation of abstraction.  This commit removes\r\nthese two fields, instead passing along the necessary\r\nenabling information with ComponentEnabledSpec instead.\r\n\r\nAs there were not many uses of testEnabled/benchmarkEnabled,\r\nthis was not too difficult to do.\r\n\r\nSigned-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>","created_at":"2016-07-12T07:05:46Z","updated_at":"2016-07-22T09:30:12Z","closed_at":"2016-07-21T21:41:47Z","merged_at":"2016-07-21T21:41:47Z","merge_commit_sha":"313edf53594fe5603086a6aea0d493329a18aa64","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/3542/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/3542/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/3542/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/193f49da018c7f91cf551f4cd606abb9ba4b3da5","head":{"label":"ezyang:enabled-refactor","ref":"enabled-refactor","sha":"193f49da018c7f91cf551f4cd606abb9ba4b3da5","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"repo":{"id":6343207,"name":"cabal","full_name":"ezyang/cabal","owner":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ezyang/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":true,"url":"https://api.github.com/repos/ezyang/cabal","forks_url":"https://api.github.com/repos/ezyang/cabal/forks","keys_url":"https://api.github.com/repos/ezyang/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezyang/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezyang/cabal/teams","hooks_url":"https://api.github.com/repos/ezyang/cabal/hooks","issue_events_url":"https://api.github.com/repos/ezyang/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/ezyang/cabal/events","assignees_url":"https://api.github.com/repos/ezyang/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/ezyang/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/ezyang/cabal/tags","blobs_url":"https://api.github.com/repos/ezyang/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezyang/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezyang/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezyang/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezyang/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/ezyang/cabal/languages","stargazers_url":"https://api.github.com/repos/ezyang/cabal/stargazers","contributors_url":"https://api.github.com/repos/ezyang/cabal/contributors","subscribers_url":"https://api.github.com/repos/ezyang/cabal/subscribers","subscription_url":"https://api.github.com/repos/ezyang/cabal/subscription","commits_url":"https://api.github.com/repos/ezyang/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezyang/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezyang/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezyang/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezyang/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/ezyang/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezyang/cabal/merges","archive_url":"https://api.github.com/repos/ezyang/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezyang/cabal/downloads","issues_url":"https://api.github.com/repos/ezyang/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/ezyang/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/ezyang/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/ezyang/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezyang/cabal/labels{/name}","releases_url":"https://api.github.com/repos/ezyang/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/ezyang/cabal/deployments","created_at":"2012-10-22T22:12:16Z","updated_at":"2016-07-19T16:21:03Z","pushed_at":"2016-07-22T08:54:06Z","git_url":"git://github.com/ezyang/cabal.git","ssh_url":"git@github.com:ezyang/cabal.git","clone_url":"https://github.com/ezyang/cabal.git","svn_url":"https://github.com/ezyang/cabal","homepage":"http://haskell.org/cabal","size":31077,"stargazers_count":7,"watchers_count":7,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"019ef6f6e92bede745e20d96274d5aa7f717f87b","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2016-07-19T16:21:18Z","pushed_at":"2016-07-22T07:40:54Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":39429,"stargazers_count":621,"watchers_count":621,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":732,"forks":328,"open_issues":732,"watchers":621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3542"},"html":{"href":"https://github.com/haskell/cabal/pull/3542"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/3542"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/3542/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3542/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3542/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/193f49da018c7f91cf551f4cd606abb9ba4b3da5"}}}}
{"actor":{"display_login":"23Skidoo"}}