{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/77116089","id":77116089,"diff_hunk":"@@ -1,3 +1,35 @@\n+/** \\ingroup core\n+ * Holder for the widget type and its configuration for a field.\n+ */\n+class QgsEditorWidgetSetup","path":"python/core/qgsfield.sip","position":4,"original_position":4,"commit_id":"c2798875e65c12cdc05829714682ef9fce72bafe","original_commit_id":"c2798875e65c12cdc05829714682ef9fce72bafe","user":{"login":"m-kuhn","id":588407,"avatar_url":"https://avatars.githubusercontent.com/u/588407?v=3","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"body":"Can this also be moved to qgseditorwidgetsetup.sip","created_at":"2016-09-01T05:32:00Z","updated_at":"2016-09-01T05:32:00Z","html_url":"https://github.com/qgis/QGIS/pull/3439#discussion_r77116089","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/3439","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/77116089"},"html":{"href":"https://github.com/qgis/QGIS/pull/3439#discussion_r77116089"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3439"}}},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/3439","id":83220181,"html_url":"https://github.com/qgis/QGIS/pull/3439","diff_url":"https://github.com/qgis/QGIS/pull/3439.diff","patch_url":"https://github.com/qgis/QGIS/pull/3439.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/3439","number":3439,"state":"open","locked":false,"title":"Smarter default edit widgets with plugins to pick them (take 2)","user":{"login":"pvalsecc","id":1180608,"avatar_url":"https://avatars.githubusercontent.com/u/1180608?v=3","gravatar_id":"","url":"https://api.github.com/users/pvalsecc","html_url":"https://github.com/pvalsecc","followers_url":"https://api.github.com/users/pvalsecc/followers","following_url":"https://api.github.com/users/pvalsecc/following{/other_user}","gists_url":"https://api.github.com/users/pvalsecc/gists{/gist_id}","starred_url":"https://api.github.com/users/pvalsecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvalsecc/subscriptions","organizations_url":"https://api.github.com/users/pvalsecc/orgs","repos_url":"https://api.github.com/users/pvalsecc/repos","events_url":"https://api.github.com/users/pvalsecc/events{/privacy}","received_events_url":"https://api.github.com/users/pvalsecc/received_events","type":"User","site_admin":false},"body":"I've fixed https://github.com/qgis/QGIS/pull/3338 to have QgsEditorWidgetSetup to use the correct export macro and to move it in another file.\r\n\r\nNow the widgets factories can give a score on how good they could handle\r\na widget.\r\n\r\nAdditionaly, plugins can be added to choose a widget factory in function\r\nof an external information. One of them uses a table in PostgresQL to\r\nallow specification of the widget type and configuration.\r\n\r\nI took the opportunity to remove a few deprecated method in relation to\r\nthis.","created_at":"2016-08-30T07:22:41Z","updated_at":"2016-09-01T05:32:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb8d7fa628f3a3a253bd525dcc3a75ced1425cbc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/3439/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/3439/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/3439/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/c2798875e65c12cdc05829714682ef9fce72bafe","head":{"label":"pvalsecc:editor_widgets_selection","ref":"editor_widgets_selection","sha":"c2798875e65c12cdc05829714682ef9fce72bafe","user":{"login":"pvalsecc","id":1180608,"avatar_url":"https://avatars.githubusercontent.com/u/1180608?v=3","gravatar_id":"","url":"https://api.github.com/users/pvalsecc","html_url":"https://github.com/pvalsecc","followers_url":"https://api.github.com/users/pvalsecc/followers","following_url":"https://api.github.com/users/pvalsecc/following{/other_user}","gists_url":"https://api.github.com/users/pvalsecc/gists{/gist_id}","starred_url":"https://api.github.com/users/pvalsecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvalsecc/subscriptions","organizations_url":"https://api.github.com/users/pvalsecc/orgs","repos_url":"https://api.github.com/users/pvalsecc/repos","events_url":"https://api.github.com/users/pvalsecc/events{/privacy}","received_events_url":"https://api.github.com/users/pvalsecc/received_events","type":"User","site_admin":false},"repo":{"id":49560586,"name":"QGIS","full_name":"pvalsecc/QGIS","owner":{"login":"pvalsecc","id":1180608,"avatar_url":"https://avatars.githubusercontent.com/u/1180608?v=3","gravatar_id":"","url":"https://api.github.com/users/pvalsecc","html_url":"https://github.com/pvalsecc","followers_url":"https://api.github.com/users/pvalsecc/followers","following_url":"https://api.github.com/users/pvalsecc/following{/other_user}","gists_url":"https://api.github.com/users/pvalsecc/gists{/gist_id}","starred_url":"https://api.github.com/users/pvalsecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvalsecc/subscriptions","organizations_url":"https://api.github.com/users/pvalsecc/orgs","repos_url":"https://api.github.com/users/pvalsecc/repos","events_url":"https://api.github.com/users/pvalsecc/events{/privacy}","received_events_url":"https://api.github.com/users/pvalsecc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvalsecc/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/pvalsecc/QGIS","forks_url":"https://api.github.com/repos/pvalsecc/QGIS/forks","keys_url":"https://api.github.com/repos/pvalsecc/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvalsecc/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvalsecc/QGIS/teams","hooks_url":"https://api.github.com/repos/pvalsecc/QGIS/hooks","issue_events_url":"https://api.github.com/repos/pvalsecc/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/pvalsecc/QGIS/events","assignees_url":"https://api.github.com/repos/pvalsecc/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/pvalsecc/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/pvalsecc/QGIS/tags","blobs_url":"https://api.github.com/repos/pvalsecc/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvalsecc/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvalsecc/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvalsecc/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvalsecc/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/pvalsecc/QGIS/languages","stargazers_url":"https://api.github.com/repos/pvalsecc/QGIS/stargazers","contributors_url":"https://api.github.com/repos/pvalsecc/QGIS/contributors","subscribers_url":"https://api.github.com/repos/pvalsecc/QGIS/subscribers","subscription_url":"https://api.github.com/repos/pvalsecc/QGIS/subscription","commits_url":"https://api.github.com/repos/pvalsecc/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvalsecc/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvalsecc/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvalsecc/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvalsecc/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/pvalsecc/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvalsecc/QGIS/merges","archive_url":"https://api.github.com/repos/pvalsecc/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvalsecc/QGIS/downloads","issues_url":"https://api.github.com/repos/pvalsecc/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/pvalsecc/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/pvalsecc/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/pvalsecc/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvalsecc/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/pvalsecc/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/pvalsecc/QGIS/deployments","created_at":"2016-01-13T08:32:57Z","updated_at":"2016-07-31T18:22:39Z","pushed_at":"2016-08-31T07:20:27Z","git_url":"git://github.com/pvalsecc/QGIS.git","ssh_url":"git@github.com:pvalsecc/QGIS.git","clone_url":"https://github.com/pvalsecc/QGIS.git","svn_url":"https://github.com/pvalsecc/QGIS","homepage":"http://qgis.org","size":1198546,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"15dd29564ceae82266b9d4a8adf2e12bd184a70f","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2016-09-01T02:19:59Z","pushed_at":"2016-08-31T23:39:01Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1264574,"stargazers_count":1084,"watchers_count":1084,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":892,"mirror_url":null,"open_issues_count":54,"forks":892,"open_issues":54,"watchers":1084,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3439"},"html":{"href":"https://github.com/qgis/QGIS/pull/3439"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/3439"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/3439/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3439/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3439/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/c2798875e65c12cdc05829714682ef9fce72bafe"}}}}
{"actor":{"display_login":"m-kuhn"}}