{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/61693326","id":61693326,"diff_hunk":"@@ -684,10 +684,12 @@ function workerInit() {\n \n   Worker.prototype.destroy = function() {\n     this.exitedAfterDisconnect = true;\n-    if (!this.isConnected()) process.exit(0);\n-    var exit = process.exit.bind(null, 0);\n-    send({ act: 'exitedAfterDisconnect' }, () => process.disconnect());\n-    process.once('disconnect', exit);\n+    if (!this.isConnected()) {\n+      process.exit();","path":"lib/cluster.js","position":9,"original_position":9,"commit_id":"b2f586751786536dee043b0fd0183c879f748416","original_commit_id":"b2f586751786536dee043b0fd0183c879f748416","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"body":"Ah, right... good point :-) \r\n\r\n@yorkie ... this should be `process.exit(0)` and below","created_at":"2016-05-01T21:21:45Z","updated_at":"2016-05-01T21:21:45Z","html_url":"https://github.com/nodejs/node/pull/6502#discussion_r61693326","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/6502","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/61693326"},"html":{"href":"https://github.com/nodejs/node/pull/6502#discussion_r61693326"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/6502"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6502","id":68498101,"html_url":"https://github.com/nodejs/node/pull/6502","diff_url":"https://github.com/nodejs/node/pull/6502.diff","patch_url":"https://github.com/nodejs/node/pull/6502.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6502","number":6502,"state":"open","locked":false,"title":"cluster: refine worker.destroy function","user":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?v=3","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for submitting a pull request to Node.js. Before you submit, please\r\nreview below requirements and walk through the checklist. You can 'tick'\r\na box by using the letter \"x\": [x].\r\n\r\nRun the test suite by invoking: `make -j4 lint test` on linux or\r\n`vcbuild test nosign` on Windows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. Finally – if possible – a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n\r\n<!-- remove lines that do not apply to you -->\r\n\r\n- [x] tests and code linting passes\r\n- [ ] a test and/or benchmark is included\r\n- [ ] documentation is changed or added\r\n- [x] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\n\r\n- cluster\r\n\r\n##### Description of change\r\n\r\n<!-- provide a description of the change below this comment -->\r\n\r\nThis PR just refines a cluster function and make the duplicated exit functions to be shared, so there is no tests or benchmarks could be provided :-)","created_at":"2016-05-01T15:06:33Z","updated_at":"2016-05-01T21:21:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17971aac649eb9888d03db9c365c262522543631","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6502/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6502/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6502/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b2f586751786536dee043b0fd0183c879f748416","head":{"label":"yorkie:refine/cluster-worker","ref":"refine/cluster-worker","sha":"b2f586751786536dee043b0fd0183c879f748416","user":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?v=3","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"repo":{"id":40772284,"name":"node","full_name":"yorkie/node","owner":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?v=3","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yorkie/node","description":"Future Node.js releases will be from this repo.","fork":true,"url":"https://api.github.com/repos/yorkie/node","forks_url":"https://api.github.com/repos/yorkie/node/forks","keys_url":"https://api.github.com/repos/yorkie/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yorkie/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yorkie/node/teams","hooks_url":"https://api.github.com/repos/yorkie/node/hooks","issue_events_url":"https://api.github.com/repos/yorkie/node/issues/events{/number}","events_url":"https://api.github.com/repos/yorkie/node/events","assignees_url":"https://api.github.com/repos/yorkie/node/assignees{/user}","branches_url":"https://api.github.com/repos/yorkie/node/branches{/branch}","tags_url":"https://api.github.com/repos/yorkie/node/tags","blobs_url":"https://api.github.com/repos/yorkie/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yorkie/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yorkie/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/yorkie/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yorkie/node/statuses/{sha}","languages_url":"https://api.github.com/repos/yorkie/node/languages","stargazers_url":"https://api.github.com/repos/yorkie/node/stargazers","contributors_url":"https://api.github.com/repos/yorkie/node/contributors","subscribers_url":"https://api.github.com/repos/yorkie/node/subscribers","subscription_url":"https://api.github.com/repos/yorkie/node/subscription","commits_url":"https://api.github.com/repos/yorkie/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/yorkie/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/yorkie/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/yorkie/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/yorkie/node/contents/{+path}","compare_url":"https://api.github.com/repos/yorkie/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yorkie/node/merges","archive_url":"https://api.github.com/repos/yorkie/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yorkie/node/downloads","issues_url":"https://api.github.com/repos/yorkie/node/issues{/number}","pulls_url":"https://api.github.com/repos/yorkie/node/pulls{/number}","milestones_url":"https://api.github.com/repos/yorkie/node/milestones{/number}","notifications_url":"https://api.github.com/repos/yorkie/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yorkie/node/labels{/name}","releases_url":"https://api.github.com/repos/yorkie/node/releases{/id}","deployments_url":"https://api.github.com/repos/yorkie/node/deployments","created_at":"2015-08-15T16:54:25Z","updated_at":"2015-08-15T16:54:29Z","pushed_at":"2016-05-01T16:17:39Z","git_url":"git://github.com/yorkie/node.git","ssh_url":"git@github.com:yorkie/node.git","clone_url":"https://github.com/yorkie/node.git","svn_url":"https://github.com/yorkie/node","homepage":"https://iojs.org","size":181187,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"bcce05dba4b5107343661e880d235b3777e19594","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-05-01T19:56:43Z","pushed_at":"2016-05-01T20:29:31Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":251369,"stargazers_count":22747,"watchers_count":22747,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3152,"mirror_url":null,"open_issues_count":670,"forks":3152,"open_issues":670,"watchers":22747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6502"},"html":{"href":"https://github.com/nodejs/node/pull/6502"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6502"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6502/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6502/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6502/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b2f586751786536dee043b0fd0183c879f748416"}}}}