{"action":"created","comment":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/82230564","pull_request_review_id":3152506,"id":82230564,"diff_hunk":"@@ -477,7 +477,7 @@ export class uProxyCore implements uproxy_core_api.CoreApi {\n             return 'NAT classification timed out.';\n           }),\n           nat_probe.probe().then((natType:string) => {\n-            globals.natType = natType;\n+            globals.setGlobalNatType(natType);","path":"src/generic_core/uproxy_core.ts","position":55,"original_position":55,"commit_id":"3417cddb595f6f842e0aeee2c94494d3e2597f55","original_commit_id":"3417cddb595f6f842e0aeee2c94494d3e2597f55","user":{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false},"body":"This is another place I had to edit due to globals being mutated.","created_at":"2016-10-06T16:38:06Z","updated_at":"2016-10-06T16:38:06Z","html_url":"https://github.com/uProxy/uproxy/pull/2777#discussion_r82230564","pull_request_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2777","_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/82230564"},"html":{"href":"https://github.com/uProxy/uproxy/pull/2777#discussion_r82230564"},"pull_request":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2777"}}},"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/2777","id":88296542,"html_url":"https://github.com/uProxy/uproxy/pull/2777","diff_url":"https://github.com/uProxy/uproxy/pull/2777.diff","patch_url":"https://github.com/uProxy/uproxy/pull/2777.patch","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/2777","number":2777,"state":"open","locked":false,"title":"Migrate uProxy to ES6 imports","user":{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false},"body":"We use `require` everywhere, but that's not valid ES6 code. The Typescript team recommended using the ES6 import format to reduce divergence.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/2777)\n<!-- Reviewable:end -->\n","created_at":"2016-10-06T16:27:51Z","updated_at":"2016-10-06T16:38:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"430861fdac6766a20f690e9b2c499394c743003b","assignee":{"login":"trevj","id":5142116,"avatar_url":"https://avatars.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false},"assignees":[{"login":"trevj","id":5142116,"avatar_url":"https://avatars.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2777/commits","review_comments_url":"https://api.github.com/repos/uProxy/uproxy/pulls/2777/comments","review_comment_url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/2777/comments","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/3417cddb595f6f842e0aeee2c94494d3e2597f55","head":{"label":"fortuna:es6-imports","ref":"es6-imports","sha":"3417cddb595f6f842e0aeee2c94494d3e2597f55","user":{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false},"repo":{"id":67895012,"name":"uproxy","full_name":"fortuna/uproxy","owner":{"login":"fortuna","id":113565,"avatar_url":"https://avatars.githubusercontent.com/u/113565?v=3","gravatar_id":"","url":"https://api.github.com/users/fortuna","html_url":"https://github.com/fortuna","followers_url":"https://api.github.com/users/fortuna/followers","following_url":"https://api.github.com/users/fortuna/following{/other_user}","gists_url":"https://api.github.com/users/fortuna/gists{/gist_id}","starred_url":"https://api.github.com/users/fortuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortuna/subscriptions","organizations_url":"https://api.github.com/users/fortuna/orgs","repos_url":"https://api.github.com/users/fortuna/repos","events_url":"https://api.github.com/users/fortuna/events{/privacy}","received_events_url":"https://api.github.com/users/fortuna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fortuna/uproxy","description":"Internet without borders","fork":true,"url":"https://api.github.com/repos/fortuna/uproxy","forks_url":"https://api.github.com/repos/fortuna/uproxy/forks","keys_url":"https://api.github.com/repos/fortuna/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fortuna/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fortuna/uproxy/teams","hooks_url":"https://api.github.com/repos/fortuna/uproxy/hooks","issue_events_url":"https://api.github.com/repos/fortuna/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/fortuna/uproxy/events","assignees_url":"https://api.github.com/repos/fortuna/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/fortuna/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/fortuna/uproxy/tags","blobs_url":"https://api.github.com/repos/fortuna/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fortuna/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fortuna/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/fortuna/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fortuna/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/fortuna/uproxy/languages","stargazers_url":"https://api.github.com/repos/fortuna/uproxy/stargazers","contributors_url":"https://api.github.com/repos/fortuna/uproxy/contributors","subscribers_url":"https://api.github.com/repos/fortuna/uproxy/subscribers","subscription_url":"https://api.github.com/repos/fortuna/uproxy/subscription","commits_url":"https://api.github.com/repos/fortuna/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/fortuna/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/fortuna/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/fortuna/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/fortuna/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/fortuna/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fortuna/uproxy/merges","archive_url":"https://api.github.com/repos/fortuna/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fortuna/uproxy/downloads","issues_url":"https://api.github.com/repos/fortuna/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/fortuna/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/fortuna/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/fortuna/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fortuna/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/fortuna/uproxy/releases{/id}","deployments_url":"https://api.github.com/repos/fortuna/uproxy/deployments","created_at":"2016-09-10T21:19:46Z","updated_at":"2016-09-10T21:19:48Z","pushed_at":"2016-10-06T16:27:33Z","git_url":"git://github.com/fortuna/uproxy.git","ssh_url":"git@github.com:fortuna/uproxy.git","clone_url":"https://github.com/fortuna/uproxy.git","svn_url":"https://github.com/fortuna/uproxy","homepage":"https://www.uproxy.org/","size":21179,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uProxy:master","ref":"master","sha":"889fcaccf2d8da97dac8e9adb7929ea9ab5e2abb","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Internet without borders","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","deployments_url":"https://api.github.com/repos/uProxy/uproxy/deployments","created_at":"2014-04-07T20:34:40Z","updated_at":"2016-10-06T16:29:23Z","pushed_at":"2016-10-06T16:33:15Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":28722,"stargazers_count":443,"watchers_count":443,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":565,"forks":107,"open_issues":565,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2777"},"html":{"href":"https://github.com/uProxy/uproxy/pull/2777"},"issue":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/2777"},"comments":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/2777/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2777/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/2777/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/uproxy/statuses/3417cddb595f6f842e0aeee2c94494d3e2597f55"}}}}
{"actor":{"display_login":"fortuna"}}