{"action":"created","issue":{"url":"https://api.github.com/repos/cmangos/issues/issues/850","labels_url":"https://api.github.com/repos/cmangos/issues/issues/850/labels{/name}","comments_url":"https://api.github.com/repos/cmangos/issues/issues/850/comments","events_url":"https://api.github.com/repos/cmangos/issues/issues/850/events","html_url":"https://github.com/cmangos/issues/issues/850","id":130162005,"number":850,"title":"Quest autocompletion after gossip","user":{"login":"killerwife","id":7995382,"avatar_url":"https://avatars.githubusercontent.com/u/7995382?v=3","gravatar_id":"","url":"https://api.github.com/users/killerwife","html_url":"https://github.com/killerwife","followers_url":"https://api.github.com/users/killerwife/followers","following_url":"https://api.github.com/users/killerwife/following{/other_user}","gists_url":"https://api.github.com/users/killerwife/gists{/gist_id}","starred_url":"https://api.github.com/users/killerwife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerwife/subscriptions","organizations_url":"https://api.github.com/users/killerwife/orgs","repos_url":"https://api.github.com/users/killerwife/repos","events_url":"https://api.github.com/users/killerwife/events{/privacy}","received_events_url":"https://api.github.com/users/killerwife/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-31T18:14:07Z","updated_at":"2016-01-31T19:07:43Z","closed_at":null,"body":"If a gossip_menu_option is -1 and quest has the same NPC in reqcreatureorGOid as the gossip_menu,\r\na quest is autocompleted after talking to NPC.\r\nProblematic code  TalkedToCreature(pSource->GetEntry(), pSource->GetObjectGuid());\r\nin void Player::OnGossipSelect(WorldObject* pSource, uint32 gossipListId, uint32 menuId)\r\nin Player.cpp\r\nIt conflicts with quests like this https://www.youtube.com/watch?v=DdtsK8WGVMM&feature=youtu.be\r\nThe quest completion should be awarded several seconds into the script. This kind of behaviour is supported by dbscripts, and is out of place in code. Without removing this \"remnant\" which seems to be from before scriptdev was implemented, one cannot make nice/proper scripts.\r\nIdeas?"},"comment":{"url":"https://api.github.com/repos/cmangos/issues/issues/comments/177586379","html_url":"https://github.com/cmangos/issues/issues/850#issuecomment-177586379","issue_url":"https://api.github.com/repos/cmangos/issues/issues/850","id":177586379,"user":{"login":"killerwife","id":7995382,"avatar_url":"https://avatars.githubusercontent.com/u/7995382?v=3","gravatar_id":"","url":"https://api.github.com/users/killerwife","html_url":"https://github.com/killerwife","followers_url":"https://api.github.com/users/killerwife/followers","following_url":"https://api.github.com/users/killerwife/following{/other_user}","gists_url":"https://api.github.com/users/killerwife/gists{/gist_id}","starred_url":"https://api.github.com/users/killerwife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerwife/subscriptions","organizations_url":"https://api.github.com/users/killerwife/orgs","repos_url":"https://api.github.com/users/killerwife/repos","events_url":"https://api.github.com/users/killerwife/events{/privacy}","received_events_url":"https://api.github.com/users/killerwife/received_events","type":"User","site_admin":false},"created_at":"2016-01-31T19:07:43Z","updated_at":"2016-01-31T19:07:43Z","body":"Ive devised a query that checks all quests that are impacted by this\r\nselect * from gossip_menu_option a join gossip_menu b on (a.menu_id=b.entry) join creature_template c on (b.entry=c.GossipMenuId) \r\njoin quest_template d on(c.entry=d.ReqCreatureOrGOId1) where a.action_menu_id=-1; \r\nand on a new tbc-db it will not break a single quest. All of them already have a dbscript for \"award kill objective\" or have a different means of achieving it. Therefore we can change this without problems I think."}}