{"action":"created","issue":{"url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/15","repository_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper","labels_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/15/comments","events_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/15/events","html_url":"https://github.com/behance/nbd.php-gatekeeper/pull/15","id":159471715,"number":15,"title":"Percentage rule: properly handle null identifier","user":{"login":"DFoxinator","id":1854657,"avatar_url":"https://avatars.githubusercontent.com/u/1854657?v=3","gravatar_id":"","url":"https://api.github.com/users/DFoxinator","html_url":"https://github.com/DFoxinator","followers_url":"https://api.github.com/users/DFoxinator/followers","following_url":"https://api.github.com/users/DFoxinator/following{/other_user}","gists_url":"https://api.github.com/users/DFoxinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DFoxinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFoxinator/subscriptions","organizations_url":"https://api.github.com/users/DFoxinator/orgs","repos_url":"https://api.github.com/users/DFoxinator/repos","events_url":"https://api.github.com/users/DFoxinator/events{/privacy}","received_events_url":"https://api.github.com/users/DFoxinator/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-09T18:05:55Z","updated_at":"2016-06-09T18:18:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/15","html_url":"https://github.com/behance/nbd.php-gatekeeper/pull/15","diff_url":"https://github.com/behance/nbd.php-gatekeeper/pull/15.diff","patch_url":"https://github.com/behance/nbd.php-gatekeeper/pull/15.patch"},"body":"@markdunphy \r\n@eugenebond \r\n@amy \r\n@be-dmitry \r\n\r\n@be-dmitry and I talked about this a bit, and we both ended up agreeing that even if at 100 percent, a percentage rule provided a null identifier will return false.\r\n\r\nWe think that there could be some further discussion on the actual behavior of sending a percentage rule a null identifier. While it doesn't really make sense to send null to a percentage rule as the identifier, it is a completely valid use-case to be sent in from the library because of the multiple-rule-per-feature capability. Ex. you want to expose 50% of the userbase to a feature, but you also want 100% of users to be able to see it starting at a specific data or time.\r\n\r\nDmitry suggested we can think about throwing an exception just to make this clear, and catch it somewhere else, which I think we should think about but right now I'd like to finish up the implementation into network."},"comment":{"url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/comments/224981930","html_url":"https://github.com/behance/nbd.php-gatekeeper/pull/15#issuecomment-224981930","issue_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/15","id":224981930,"user":{"login":"eugenebond","id":1640934,"avatar_url":"https://avatars.githubusercontent.com/u/1640934?v=3","gravatar_id":"","url":"https://api.github.com/users/eugenebond","html_url":"https://github.com/eugenebond","followers_url":"https://api.github.com/users/eugenebond/followers","following_url":"https://api.github.com/users/eugenebond/following{/other_user}","gists_url":"https://api.github.com/users/eugenebond/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenebond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenebond/subscriptions","organizations_url":"https://api.github.com/users/eugenebond/orgs","repos_url":"https://api.github.com/users/eugenebond/repos","events_url":"https://api.github.com/users/eugenebond/events{/privacy}","received_events_url":"https://api.github.com/users/eugenebond/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T18:18:50Z","updated_at":"2016-06-09T18:18:50Z","body":"👍 "}}
{"actor":{"display_login":"eugenebond"}}