{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/89382560","pull_request_review_id":9928652,"id":89382560,"diff_hunk":"@@ -71,6 +71,10 @@ func env(b *Builder, args []string, attributes map[string]bool, original string)\n \t\t\treturn errBlankCommandNames(\"ENV\")\n \t\t}\n \n+\t\tif runtime.GOOS == \"windows\" {\n+\t\t\t// Case insensitive environment variables on Windows\n+\t\t\targs[j] = strings.ToUpper(args[j])","path":"builder/dockerfile/dispatchers.go","position":6,"original_position":6,"commit_id":"52bcaed7741df275b8a3007c3666104d6f1b27f0","original_commit_id":"52bcaed7741df275b8a3007c3666104d6f1b27f0","user":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars.githubusercontent.com/u/585223?v=3","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"body":"Why do we need to force a case in commit? Isn't case insensitive comparison enough?","created_at":"2016-11-23T19:15:41Z","updated_at":"2016-11-23T19:15:41Z","html_url":"https://github.com/docker/docker/pull/28725#discussion_r89382560","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/28725","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/89382560"},"html":{"href":"https://github.com/docker/docker/pull/28725#discussion_r89382560"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/28725"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/28725","id":94893873,"html_url":"https://github.com/docker/docker/pull/28725","diff_url":"https://github.com/docker/docker/pull/28725.diff","patch_url":"https://github.com/docker/docker/pull/28725.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/28725","number":28725,"state":"open","locked":false,"title":"Windows: Builder case insensitive env","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n\r\n@duglin - Addresses your comment https://github.com/docker/docker/pull/28667#issuecomment-262026383. Specifically the builder piece of the whole puzzle. I'll look at -e for `docker run` in a follow-up PR to keep things a little more succinct and by area.\r\n\r\nThis PR ensures that on Windows, environment variables in the builder (both as an `ENV` command and for variable substitution) are treated case-insensitive.\r\n\r\n@thaJeztah @vieux As for https://github.com/docker/docker/pull/28667, this probably also should make it into 1.13. ","created_at":"2016-11-22T20:40:26Z","updated_at":"2016-11-23T19:15:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ed9eb38c9882a81282fd01d7d740a2fd717c9d7","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":111,"closed_issues":985,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-23T17:37:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/28725/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/28725/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/28725/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/52bcaed7741df275b8a3007c3666104d6f1b27f0","head":{"label":"Microsoft:jjh/builderenvcaseinsensitive","ref":"jjh/builderenvcaseinsensitive","sha":"52bcaed7741df275b8a3007c3666104d6f1b27f0","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":30096470,"name":"docker","full_name":"Microsoft/docker","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/Microsoft/docker","forks_url":"https://api.github.com/repos/Microsoft/docker/forks","keys_url":"https://api.github.com/repos/Microsoft/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/docker/teams","hooks_url":"https://api.github.com/repos/Microsoft/docker/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/docker/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/docker/events","assignees_url":"https://api.github.com/repos/Microsoft/docker/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/docker/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/docker/tags","blobs_url":"https://api.github.com/repos/Microsoft/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/docker/languages","stargazers_url":"https://api.github.com/repos/Microsoft/docker/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/docker/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/docker/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/docker/subscription","commits_url":"https://api.github.com/repos/Microsoft/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/docker/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/docker/merges","archive_url":"https://api.github.com/repos/Microsoft/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/docker/downloads","issues_url":"https://api.github.com/repos/Microsoft/docker/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/docker/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/docker/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/docker/deployments","created_at":"2015-01-31T00:05:16Z","updated_at":"2016-11-22T22:56:58Z","pushed_at":"2016-11-23T18:59:02Z","git_url":"git://github.com/Microsoft/docker.git","ssh_url":"git@github.com:Microsoft/docker.git","clone_url":"https://github.com/Microsoft/docker.git","svn_url":"https://github.com/Microsoft/docker","homepage":"http://www.docker.com","size":128652,"stargazers_count":293,"watchers_count":293,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":0,"forks":65,"open_issues":0,"watchers":293,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"1640bb23b1127b76c4f0bf97bb265238b7574da9","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-11-23T19:10:44Z","pushed_at":"2016-11-23T19:05:14Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":233636,"stargazers_count":37150,"watchers_count":37150,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11006,"mirror_url":null,"open_issues_count":1958,"forks":11006,"open_issues":1958,"watchers":37150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/28725"},"html":{"href":"https://github.com/docker/docker/pull/28725"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/28725"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/28725/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/28725/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/28725/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/52bcaed7741df275b8a3007c3666104d6f1b27f0"}}}}
{"actor":{"display_login":"tonistiigi"}}