{"action":"closed","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5635","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5635/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5635/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5635/events","html_url":"https://github.com/NREL/EnergyPlus/issues/5635","id":151924139,"number":5635,"title":"WaterHeater:Stratified with HorizontalCylinder tank shape uses incorrect height to check if heaters are inside the tank","user":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Priority","name":"Priority","color":"e11d21"},{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/S1%20-%20High","name":"S1 - High","color":"e11d21"}],"state":"closed","locked":false,"assignee":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars.githubusercontent.com/u/849824?v=3","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"assignees":[{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars.githubusercontent.com/u/849824?v=3","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/4","html_url":"https://github.com/NREL/EnergyPlus/milestones/EnergyPlus%208.6.0","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/4/labels","id":1634827,"number":4,"title":"EnergyPlus 8.6.0","description":"The EnergyPlus 8.6.0 public release at the end of FY16Q4.","creator":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"open_issues":103,"closed_issues":141,"state":"open","created_at":"2016-03-09T17:04:23Z","updated_at":"2016-09-24T13:20:41Z","due_on":"2016-09-30T05:00:00Z","closed_at":null},"comments":2,"created_at":"2016-04-29T17:10:14Z","updated_at":"2016-09-24T13:20:41Z","closed_at":"2016-09-24T13:20:41Z","body":"Issue overview\r\n--------------\r\nUser file with this tank input\r\n```\r\nWaterHeater:Stratified,\r\n    Storage Tank,            !- Name\r\n    Water Heater,            !- End-Use Subcategory\r\n    0.360,                       !- Tank Volume {m3}\r\n    0.4,                !- Tank Height {m}\r\n    HorizontalCylinder,      !- Tank Shape\r\n    ,                        !- Tank Perimeter {m}\r\n    100,                     !- Maximum Temperature Limit {C}\r\n    MasterSlave,             !- Heater Priority Control\r\n    Standard Tariff,      !- Heater 1 Setpoint Temperature Schedule Name\r\n    8,                       !- Heater 1 Deadband Temperature Difference {deltaC}\r\n    3000,                       !- Heater 1 Capacity {W}\r\n    0.535,                       !- Heater 1 Height {m}\r\n```\r\nthrows this fatal error:\r\n```\r\n   ** Severe  ** WaterHeater:Stratified = STORAGE TANK: Heater 1 is located higher than overall tank height.\r\n   **   ~~~   ** Tank Height = 0.4000\r\n   **   ~~~   ** Heater 1 Height = 0.5350\r\n   **  Fatal  ** Errors found in getting WaterHeater:Stratified input. Preceding condition causes termination.\r\n```\r\n\r\nThis check needs to use the true tank height (diameter) which is 2*SQRT((0.36/0.4)/Pi)=1.07m not the input value of 0.4 which is the horizontal \"height\".  Quick look at the code finds two places where the true height is calculated from the input height and neither place saves this into the data structure so the variable names gets confusing WaterThermalTank.Height (input value) and TankHeight (local height dependent upon shape input).  Seems this calculation could be done once and stored in a new structure variable like ActualHeight  and WaterThermalTank.Height should be renamed to something like WaterThermalTank.InputHeightOrLength.  Then this error check could simply be changed to use .ActualHeight instead of .Height.\r\n\r\nAnd perhaps change the field name to \"Tank Height or Length\"?\r\n\r\n\r\n### Details\r\nSome additional details for this issue (if relevant):\r\n - Platform Win64\r\n - Version of EnergyPlus 8.5.0\r\n - Helpdesk ticket 11313\r\n\r\n### Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [x] Defect file added (reproduced with an example file, attached here)\r\n[WaterHeaterStandAlone-Horizontal.idf.txt](https://github.com/NREL/EnergyPlus/files/242889/WaterHeaterStandAlone-Horizontal.idf.txt)\r\n\r\n - [ ] Ticket added to Pivotal for defect (development team task)\r\n - [ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)\r\n\r\n"}}
{"actor":{"display_login":"Myoldmopar"}}