{"action":"created","issue":{"url":"https://api.github.com/repos/HawaiiStateDigitalArchives/PID-webservice/issues/22","repository_url":"https://api.github.com/repos/HawaiiStateDigitalArchives/PID-webservice","labels_url":"https://api.github.com/repos/HawaiiStateDigitalArchives/PID-webservice/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/HawaiiStateDigitalArchives/PID-webservice/issues/22/comments","events_url":"https://api.github.com/repos/HawaiiStateDigitalArchives/PID-webservice/issues/22/events","html_url":"https://github.com/HawaiiStateDigitalArchives/PID-webservice/pull/22","id":163830406,"number":22,"title":"Issue 4","user":{"login":"Khyzad","id":6704811,"avatar_url":"https://avatars.githubusercontent.com/u/6704811?v=3","gravatar_id":"","url":"https://api.github.com/users/Khyzad","html_url":"https://github.com/Khyzad","followers_url":"https://api.github.com/users/Khyzad/followers","following_url":"https://api.github.com/users/Khyzad/following{/other_user}","gists_url":"https://api.github.com/users/Khyzad/gists{/gist_id}","starred_url":"https://api.github.com/users/Khyzad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khyzad/subscriptions","organizations_url":"https://api.github.com/users/Khyzad/orgs","repos_url":"https://api.github.com/users/Khyzad/repos","events_url":"https://api.github.com/users/Khyzad/events{/privacy}","received_events_url":"https://api.github.com/users/Khyzad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-05T11:35:53Z","updated_at":"2016-07-06T04:43:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HawaiiStateDigitalArchives/PID-webservice/pulls/22","html_url":"https://github.com/HawaiiStateDigitalArchives/PID-webservice/pull/22","diff_url":"https://github.com/HawaiiStateDigitalArchives/PID-webservice/pull/22.diff","patch_url":"https://github.com/HawaiiStateDigitalArchives/PID-webservice/pull/22.patch"},"body":"Chained if-statements together in DefaultSettings.equals()\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/hawaiistatedigitalarchives/pid-webservice/22)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/HawaiiStateDigitalArchives/PID-webservice/issues/comments/230669750","html_url":"https://github.com/HawaiiStateDigitalArchives/PID-webservice/pull/22#issuecomment-230669750","issue_url":"https://api.github.com/repos/HawaiiStateDigitalArchives/PID-webservice/issues/22","id":230669750,"user":{"login":"dagnir","id":261310,"avatar_url":"https://avatars.githubusercontent.com/u/261310?v=3","gravatar_id":"","url":"https://api.github.com/users/dagnir","html_url":"https://github.com/dagnir","followers_url":"https://api.github.com/users/dagnir/followers","following_url":"https://api.github.com/users/dagnir/following{/other_user}","gists_url":"https://api.github.com/users/dagnir/gists{/gist_id}","starred_url":"https://api.github.com/users/dagnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagnir/subscriptions","organizations_url":"https://api.github.com/users/dagnir/orgs","repos_url":"https://api.github.com/users/dagnir/repos","events_url":"https://api.github.com/users/dagnir/events{/privacy}","received_events_url":"https://api.github.com/users/dagnir/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T04:43:20Z","updated_at":"2016-07-06T04:43:20Z","body":"\n\n\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[Minter/src/main/java/com/hida/model/DefaultSetting.java, line 81 \\[r1\\]](https://reviewable.io:443/reviews/hawaiistatedigitalarchives/pid-webservice/22#-KLyV7vizyctLcPOxFZq:-KLyV7vizyctLcPOxFZr:1490620556) ([raw file](https://github.com/hawaiistatedigitalarchives/pid-webservice/blob/56c92a5f052db860a93df8acbb507b7d03a3af18/Minter/src/main/java/com/hida/model/DefaultSetting.java#L81)):*\n> ```Java\n>         final DefaultSetting other = (DefaultSetting) obj;\n>         \n>         return !(!Objects.equals(this.getPrepend(), other.getPrepend())\n> ```\n\nInstead of the double negation we can just return result of the equality test\n\n```java\nreturn Objects.equals(this.getPrepend(), other.getPrepend())\n    && Objects.equals(this.getPrefix(), other.getPrefix())\n    && ...\n```\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/hawaiistatedigitalarchives/pid-webservice/22)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dagnir"}}