{"action":"created","issue":{"url":"https://api.github.com/repos/cristiantanas/TODOMan/issues/12","repository_url":"https://api.github.com/repos/cristiantanas/TODOMan","labels_url":"https://api.github.com/repos/cristiantanas/TODOMan/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/cristiantanas/TODOMan/issues/12/comments","events_url":"https://api.github.com/repos/cristiantanas/TODOMan/issues/12/events","html_url":"https://github.com/cristiantanas/TODOMan/pull/12","id":188632191,"number":12,"title":"PULL REQUEST - Actividad2","user":{"login":"herrerameri","id":22835487,"avatar_url":"https://avatars.githubusercontent.com/u/22835487?v=3","gravatar_id":"","url":"https://api.github.com/users/herrerameri","html_url":"https://github.com/herrerameri","followers_url":"https://api.github.com/users/herrerameri/followers","following_url":"https://api.github.com/users/herrerameri/following{/other_user}","gists_url":"https://api.github.com/users/herrerameri/gists{/gist_id}","starred_url":"https://api.github.com/users/herrerameri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herrerameri/subscriptions","organizations_url":"https://api.github.com/users/herrerameri/orgs","repos_url":"https://api.github.com/users/herrerameri/repos","events_url":"https://api.github.com/users/herrerameri/events{/privacy}","received_events_url":"https://api.github.com/users/herrerameri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-10T22:10:26Z","updated_at":"2016-11-26T10:33:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cristiantanas/TODOMan/pulls/12","html_url":"https://github.com/cristiantanas/TODOMan/pull/12","diff_url":"https://github.com/cristiantanas/TODOMan/pull/12.diff","patch_url":"https://github.com/cristiantanas/TODOMan/pull/12.patch"},"body":"- Choose date & time for the tasks\r\n- Show tasks in listview, with a green side if it is completed and task information (custom layout)\r\n- Style changes\r\n- Toast to show error/success (custom layout)\r\n- Simple field validation before saving into local DB\r\n- Refreshing the adapter when user is back on tasks' list\r\n- Formatting date & time\r\n- Adding uses to CANCEL and CLEAR buttons\r\n\r\n![screen shot 11-10-16 at 05 04 pm](https://cloud.githubusercontent.com/assets/22835487/20196149/b340888c-a799-11e6-9759-f0ddec889c45.JPG)\r\n![screen shot 11-10-16 at 05 10 pm](https://cloud.githubusercontent.com/assets/22835487/20196150/b37469fe-a799-11e6-87d0-195d0424c01d.JPG)\r\n![screen shot 11-10-16 at 05 32 pm](https://cloud.githubusercontent.com/assets/22835487/20196151/b3e82b64-a799-11e6-85b5-458e52a2c1bb.JPG)\r\n![screen shot 11-10-16 at 05 33 pm](https://cloud.githubusercontent.com/assets/22835487/20196152/b4414d66-a799-11e6-8223-16f44ce3a671.JPG)\r\n![screen shot 11-10-16 at 05 43 pm](https://cloud.githubusercontent.com/assets/22835487/20196153/b4612e24-a799-11e6-9158-96cc9ac57fe1.JPG)\r\n"},"comment":{"url":"https://api.github.com/repos/cristiantanas/TODOMan/issues/comments/263056202","html_url":"https://github.com/cristiantanas/TODOMan/pull/12#issuecomment-263056202","issue_url":"https://api.github.com/repos/cristiantanas/TODOMan/issues/12","id":263056202,"user":{"login":"cristiantanas","id":6471990,"avatar_url":"https://avatars.githubusercontent.com/u/6471990?v=3","gravatar_id":"","url":"https://api.github.com/users/cristiantanas","html_url":"https://github.com/cristiantanas","followers_url":"https://api.github.com/users/cristiantanas/followers","following_url":"https://api.github.com/users/cristiantanas/following{/other_user}","gists_url":"https://api.github.com/users/cristiantanas/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiantanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiantanas/subscriptions","organizations_url":"https://api.github.com/users/cristiantanas/orgs","repos_url":"https://api.github.com/users/cristiantanas/repos","events_url":"https://api.github.com/users/cristiantanas/events{/privacy}","received_events_url":"https://api.github.com/users/cristiantanas/received_events","type":"User","site_admin":false},"created_at":"2016-11-26T10:33:21Z","updated_at":"2016-11-26T10:33:21Z","body":"## Comentarios para la Actividad 2\r\n\r\n¡Un muy buen trabajo Mariana! Enhorabuena. Está todo perfecto, pero si me permites un par de apuntes:\r\n\r\n- En la clase `HomeActivity` tienes el siguiente código `listTaskAdapter.changeCursor(presenter.getTasks());`. En verdad no hace falta volver a llamar a la función `getTasks()` del presenter ya que tienes estos datos en la variable `cursorTasks`.\r\n\r\n- En la clase `NewTaskActivity`, en la función `showMessage()` puedes guardar el `LayoutInflater` en una variable privada y hacer el inflatado de la vista sólo la primera vez que la creas. El \"inflatado\" de una vista en realidad es una operación costosa y si nos las podemos ahorrar mejor :).\r\n\r\n- En el siguiente caso\r\n```Java\r\ntry {\r\n     DatePickerFragment datePickerFragment = new DatePickerFragment();\r\n     datePickerFragment.show(getSupportFragmentManager(), \"datePickerFragment\");\r\n}\r\ncatch(ClassCastException exception) {\r\n     throw new ClassCastException(\"The activity does not implement the interface.\");\r\n}\r\n```\r\nNo veo que operación podría lanzar un `ClassCastException`, ya que no estamos haciendo un cast en ningún sitio. Lo mismo para el `TimePickerFragment`."}}
{"actor":{"display_login":"cristiantanas"}}