{"action":"created","comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/67157031","id":67157031,"diff_hunk":"@@ -358,7 +373,36 @@ function search(req, res, next) {\n     req.query.uuid = db.bid(req.query.uuid);\n   }\n \n-  let queryObject = util.queryCondtion(sql, req.query);\n+  if(req.query.reference){\n+    additionalTokenQuery.push(' CONCAT(project.abbr, invoice.reference) = ?');\n+    additionalTokenCondition = additionalTokenCondition.concat(req.query.reference);\n+    delete req.query.reference;\n+  }\n+\n+  if(req.query.billingDateFrom && req.query.billingDateTo){\n+\n+      additionalTokenQuery.push(' DATE(invoice.date) >= DATE(?)');\n+      additionalTokenCondition = additionalTokenCondition.concat(req.query.billingDateFrom);\n+      delete req.query.billingDateFrom;\n+\n+      additionalTokenQuery.push(' DATE(invoice.date) <= DATE(?)');\n+      additionalTokenCondition = additionalTokenCondition.concat(req.query.billingDateTo);\n+      delete req.query.billingDateTo;\n+  }\n+\n+  if(req.query.is_distributable && req.query.is_distributable === 'all'){","path":"server/controllers/finance/patientInvoice.js","position":63,"original_position":63,"commit_id":"7cb17e831608ba75acf0d45cbcb1b52e58ffe006","original_commit_id":"7cb17e831608ba75acf0d45cbcb1b52e58ffe006","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"body":"`is_distributable = 'all'` is the same as not filtering on `is_distributable`, correct?  Why have this option?","created_at":"2016-06-15T13:06:16Z","updated_at":"2016-06-15T13:06:16Z","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/499#discussion_r67157031","pull_request_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/499","_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/67157031"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/499#discussion_r67157031"},"pull_request":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/499","id":73895595,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/499","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/499.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/499.patch","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/499","number":499,"state":"open","locked":false,"title":"Registry of invoices","user":{"login":"DedrickEnc","id":5418919,"avatar_url":"https://avatars.githubusercontent.com/u/5418919?v=3","gravatar_id":"","url":"https://api.github.com/users/DedrickEnc","html_url":"https://github.com/DedrickEnc","followers_url":"https://api.github.com/users/DedrickEnc/followers","following_url":"https://api.github.com/users/DedrickEnc/following{/other_user}","gists_url":"https://api.github.com/users/DedrickEnc/gists{/gist_id}","starred_url":"https://api.github.com/users/DedrickEnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DedrickEnc/subscriptions","organizations_url":"https://api.github.com/users/DedrickEnc/orgs","repos_url":"https://api.github.com/users/DedrickEnc/repos","events_url":"https://api.github.com/users/DedrickEnc/events{/privacy}","received_events_url":"https://api.github.com/users/DedrickEnc/received_events","type":"User","site_admin":false},"body":"This pull request is implementing the registry of invoices,  this module is responsible of listing or filtering invoices based on parameters provided by the user, it should help user managing invoices at one place.\r\nHere are some importants informations :\r\n\r\n- The ```moment``` function is moved to ```util.js``` a service at the client side\r\n\r\n- The files ```patient_invoice/registry.js``` and the ```patient_invoice/registry.html``` are added\r\n\r\n- The filtering are based on : date of the bill, reference, service, user, distributable flag\r\n\r\n- ```services/PatientService.js``` was touched to avoid closing the dialog by pressing escape key\r\n\r\n- some files are added for the e2e test such as :  ```receip_modal/receiptModal.page.js```, ```receipt_invoice/invoiceRegistry.page.js```, ```modal.page.js```\r\n\r\n@jniles @sfount \r\n\r\n \r\n\r\n \r\n \r\nThank you for contributing!\r\n\r\nBefore submitting this pull request, please verify that you have:\r\n - [ ] Run your code through JSHint.  [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md).\r\n - [x] Run integration tests.\r\n - [x] Run end-to-end tests.\r\n - [x] Accurately described the changes your are making in this pull request.\r\n\r\nFor a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against.\r\n\r\nEnsuring that the above checkboxes are completed will help speed the review process and help build a stronger application.  Thanks!\r\n","created_at":"2016-06-15T11:34:17Z","updated_at":"2016-06-15T13:06:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17e81969ba4880e5fff4b86874c043f02931a9df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/499/commits","review_comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/499/comments","review_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/499/comments","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/7cb17e831608ba75acf0d45cbcb1b52e58ffe006","head":{"label":"DedrickEnc:invoices","ref":"invoices","sha":"7cb17e831608ba75acf0d45cbcb1b52e58ffe006","user":{"login":"DedrickEnc","id":5418919,"avatar_url":"https://avatars.githubusercontent.com/u/5418919?v=3","gravatar_id":"","url":"https://api.github.com/users/DedrickEnc","html_url":"https://github.com/DedrickEnc","followers_url":"https://api.github.com/users/DedrickEnc/followers","following_url":"https://api.github.com/users/DedrickEnc/following{/other_user}","gists_url":"https://api.github.com/users/DedrickEnc/gists{/gist_id}","starred_url":"https://api.github.com/users/DedrickEnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DedrickEnc/subscriptions","organizations_url":"https://api.github.com/users/DedrickEnc/orgs","repos_url":"https://api.github.com/users/DedrickEnc/repos","events_url":"https://api.github.com/users/DedrickEnc/events{/privacy}","received_events_url":"https://api.github.com/users/DedrickEnc/received_events","type":"User","site_admin":false},"repo":{"id":49414970,"name":"bhima-2.X","full_name":"DedrickEnc/bhima-2.X","owner":{"login":"DedrickEnc","id":5418919,"avatar_url":"https://avatars.githubusercontent.com/u/5418919?v=3","gravatar_id":"","url":"https://api.github.com/users/DedrickEnc","html_url":"https://github.com/DedrickEnc","followers_url":"https://api.github.com/users/DedrickEnc/followers","following_url":"https://api.github.com/users/DedrickEnc/following{/other_user}","gists_url":"https://api.github.com/users/DedrickEnc/gists{/gist_id}","starred_url":"https://api.github.com/users/DedrickEnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DedrickEnc/subscriptions","organizations_url":"https://api.github.com/users/DedrickEnc/orgs","repos_url":"https://api.github.com/users/DedrickEnc/repos","events_url":"https://api.github.com/users/DedrickEnc/events{/privacy}","received_events_url":"https://api.github.com/users/DedrickEnc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DedrickEnc/bhima-2.X","description":"A fresh start for bhima to remove large commits","fork":true,"url":"https://api.github.com/repos/DedrickEnc/bhima-2.X","forks_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/forks","keys_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/events","assignees_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/merges","archive_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/DedrickEnc/bhima-2.X/deployments","created_at":"2016-01-11T09:17:30Z","updated_at":"2016-01-11T09:17:33Z","pushed_at":"2016-06-15T11:39:37Z","git_url":"git://github.com/DedrickEnc/bhima-2.X.git","ssh_url":"git@github.com:DedrickEnc/bhima-2.X.git","clone_url":"https://github.com/DedrickEnc/bhima-2.X.git","svn_url":"https://github.com/DedrickEnc/bhima-2.X","homepage":null,"size":4722,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IMA-WorldHealth:master","ref":"master","sha":"375561e01cd7a29c5678925b2dccf37717854235","user":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":49052669,"name":"bhima-2.X","full_name":"IMA-WorldHealth/bhima-2.X","owner":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X","description":"A fresh start for bhima to remove large commits","fork":false,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","forks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/forks","keys_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/events","assignees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/merges","archive_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/deployments","created_at":"2016-01-05T08:30:30Z","updated_at":"2016-05-25T12:28:41Z","pushed_at":"2016-06-15T12:18:00Z","git_url":"git://github.com/IMA-WorldHealth/bhima-2.X.git","ssh_url":"git@github.com:IMA-WorldHealth/bhima-2.X.git","clone_url":"https://github.com/IMA-WorldHealth/bhima-2.X.git","svn_url":"https://github.com/IMA-WorldHealth/bhima-2.X","homepage":null,"size":4943,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":104,"forks":6,"open_issues":104,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/499"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/499"},"issue":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/499"},"comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/7cb17e831608ba75acf0d45cbcb1b52e58ffe006"}}}}
{"actor":{"display_login":"jniles"}}