{"action":"created","issue":{"url":"https://api.github.com/repos/iTowns/itowns2/issues/200","repository_url":"https://api.github.com/repos/iTowns/itowns2","labels_url":"https://api.github.com/repos/iTowns/itowns2/issues/200/labels{/name}","comments_url":"https://api.github.com/repos/iTowns/itowns2/issues/200/comments","events_url":"https://api.github.com/repos/iTowns/itowns2/issues/200/events","html_url":"https://github.com/iTowns/itowns2/pull/200","id":188220665,"number":200,"title":"Rework LayeredMaterial","user":{"login":"gchoqueux","id":11291849,"avatar_url":"https://avatars.githubusercontent.com/u/11291849?v=3","gravatar_id":"","url":"https://api.github.com/users/gchoqueux","html_url":"https://github.com/gchoqueux","followers_url":"https://api.github.com/users/gchoqueux/followers","following_url":"https://api.github.com/users/gchoqueux/following{/other_user}","gists_url":"https://api.github.com/users/gchoqueux/gists{/gist_id}","starred_url":"https://api.github.com/users/gchoqueux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchoqueux/subscriptions","organizations_url":"https://api.github.com/users/gchoqueux/orgs","repos_url":"https://api.github.com/users/gchoqueux/repos","events_url":"https://api.github.com/users/gchoqueux/events{/privacy}","received_events_url":"https://api.github.com/users/gchoqueux/received_events","type":"User","site_admin":false},"labels":[{"id":284711787,"url":"https://api.github.com/repos/iTowns/itowns2/labels/ready","name":"ready","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"gchoqueux","id":11291849,"avatar_url":"https://avatars.githubusercontent.com/u/11291849?v=3","gravatar_id":"","url":"https://api.github.com/users/gchoqueux","html_url":"https://github.com/gchoqueux","followers_url":"https://api.github.com/users/gchoqueux/followers","following_url":"https://api.github.com/users/gchoqueux/following{/other_user}","gists_url":"https://api.github.com/users/gchoqueux/gists{/gist_id}","starred_url":"https://api.github.com/users/gchoqueux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchoqueux/subscriptions","organizations_url":"https://api.github.com/users/gchoqueux/orgs","repos_url":"https://api.github.com/users/gchoqueux/repos","events_url":"https://api.github.com/users/gchoqueux/events{/privacy}","received_events_url":"https://api.github.com/users/gchoqueux/received_events","type":"User","site_admin":false},"assignees":[{"login":"gchoqueux","id":11291849,"avatar_url":"https://avatars.githubusercontent.com/u/11291849?v=3","gravatar_id":"","url":"https://api.github.com/users/gchoqueux","html_url":"https://github.com/gchoqueux","followers_url":"https://api.github.com/users/gchoqueux/followers","following_url":"https://api.github.com/users/gchoqueux/following{/other_user}","gists_url":"https://api.github.com/users/gchoqueux/gists{/gist_id}","starred_url":"https://api.github.com/users/gchoqueux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchoqueux/subscriptions","organizations_url":"https://api.github.com/users/gchoqueux/orgs","repos_url":"https://api.github.com/users/gchoqueux/repos","events_url":"https://api.github.com/users/gchoqueux/events{/privacy}","received_events_url":"https://api.github.com/users/gchoqueux/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-11-09T11:06:36Z","updated_at":"2016-11-17T20:39:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/200","html_url":"https://github.com/iTowns/itowns2/pull/200","diff_url":"https://github.com/iTowns/itowns2/pull/200.diff","patch_url":"https://github.com/iTowns/itowns2/pull/200.patch"},"body":"- **Add `Style` object to WFS**\r\n- **Rework LayeredMaterial**\r\n  - All textures and parameters are ordered by display order.\r\n  - `this.Layers` contains all layers by display order\r\n  - The slots's texture management is done internally, now, to set texture uses `layerId`\r\n  - Fix bug : Remove color layer doesn't dispose textures colors\r\n- **Uniform changes** (`LayeredMaterial` and `BasicMaterial`)\r\n  - use`THREE.Uniform` in material\r\n  - `int RTC`          becomes `bool useRTC`\r\n  - `int lightingOn` becomes `bool lightingOn`\r\n  - `int debug`       becomes `bool debug`\r\n  - `int lightingOn` becomes `bool lightingOn`\r\n  - `int selected`    becomes `bool selected`\r\n- **Remove slot texture** in `NodeProcess` is replaced by `layerId`\r\n- **Change Skirt size** influence performance rendering, minimize pixel shader pass\r\n- **Fix typos and add Binary Tools**"},"comment":{"url":"https://api.github.com/repos/iTowns/itowns2/issues/comments/261362766","html_url":"https://github.com/iTowns/itowns2/pull/200#issuecomment-261362766","issue_url":"https://api.github.com/repos/iTowns/itowns2/issues/200","id":261362766,"user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars.githubusercontent.com/u/2198295?v=3","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T20:39:11Z","updated_at":"2016-11-17T20:39:11Z","body":"I left a few comments regarding style.\r\nBut I have a more important one: I think this PR introduces a regression in texture loading/flickering.\r\n\r\nHere's an example of the issue. During zooming you can see the time where the child tile used a worse quality texture than its parent (red square):\r\n\r\n![crappy gif showing the bug](https://cloud.githubusercontent.com/assets/2198295/20406551/0d172112-ad0e-11e6-8744-d7ae1fd500d4.gif)\r\n\r\n\r\n"}}
{"actor":{"display_login":"peppsac"}}