{"action":"created","comment":{"url":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/comments/58298484","id":58298484,"diff_hunk":"@@ -69,6 +75,8 @@ After writing this method, our new result should be:\n \n **think**: Where should we call `strip_punctuation`? Does it matter? Why?\n \n+The strip_punctuation method should be called before the loop, because we want to remove punctuation before we add to the values of happy or sad variables. It could technically be put anywhere before the loop though.\n+","path":"README.md","position":83,"original_position":83,"commit_id":"7b1e82417650a57caaa4a01b21193abea576b35b","original_commit_id":"7b1e82417650a57caaa4a01b21193abea576b35b","user":{"login":"sudocrystal","id":7967247,"avatar_url":"https://avatars.githubusercontent.com/u/7967247?v=3","gravatar_id":"","url":"https://api.github.com/users/sudocrystal","html_url":"https://github.com/sudocrystal","followers_url":"https://api.github.com/users/sudocrystal/followers","following_url":"https://api.github.com/users/sudocrystal/following{/other_user}","gists_url":"https://api.github.com/users/sudocrystal/gists{/gist_id}","starred_url":"https://api.github.com/users/sudocrystal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudocrystal/subscriptions","organizations_url":"https://api.github.com/users/sudocrystal/orgs","repos_url":"https://api.github.com/users/sudocrystal/repos","events_url":"https://api.github.com/users/sudocrystal/events{/privacy}","received_events_url":"https://api.github.com/users/sudocrystal/received_events","type":"User","site_admin":false},"body":"True. This is a great observation. I should have additionally asked, \"Should you call strip_punctuation inside or outside of analyze_mood? Why?\"","created_at":"2016-04-02T19:36:48Z","updated_at":"2016-04-02T19:36:48Z","html_url":"https://github.com/Ada-C5/mood-analysis/pull/6#discussion_r58298484","pull_request_url":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/comments/58298484"},"html":{"href":"https://github.com/Ada-C5/mood-analysis/pull/6#discussion_r58298484"},"pull_request":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/6","id":64973263,"html_url":"https://github.com/Ada-C5/mood-analysis/pull/6","diff_url":"https://github.com/Ada-C5/mood-analysis/pull/6.diff","patch_url":"https://github.com/Ada-C5/mood-analysis/pull/6.patch","issue_url":"https://api.github.com/repos/Ada-C5/mood-analysis/issues/6","number":6,"state":"open","locked":false,"title":"Jess' Mood Analysis","user":{"login":"jweeber","id":13111507,"avatar_url":"https://avatars.githubusercontent.com/u/13111507?v=3","gravatar_id":"","url":"https://api.github.com/users/jweeber","html_url":"https://github.com/jweeber","followers_url":"https://api.github.com/users/jweeber/followers","following_url":"https://api.github.com/users/jweeber/following{/other_user}","gists_url":"https://api.github.com/users/jweeber/gists{/gist_id}","starred_url":"https://api.github.com/users/jweeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jweeber/subscriptions","organizations_url":"https://api.github.com/users/jweeber/orgs","repos_url":"https://api.github.com/users/jweeber/repos","events_url":"https://api.github.com/users/jweeber/events{/privacy}","received_events_url":"https://api.github.com/users/jweeber/received_events","type":"User","site_admin":false},"body":"Here are some feelings.","created_at":"2016-04-01T16:50:24Z","updated_at":"2016-04-02T19:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09645273001fd45495fee92a6c38733766501821","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C5/mood-analysis/issues/6/comments","statuses_url":"https://api.github.com/repos/Ada-C5/mood-analysis/statuses/7b1e82417650a57caaa4a01b21193abea576b35b","head":{"label":"jweeber:master","ref":"master","sha":"7b1e82417650a57caaa4a01b21193abea576b35b","user":{"login":"jweeber","id":13111507,"avatar_url":"https://avatars.githubusercontent.com/u/13111507?v=3","gravatar_id":"","url":"https://api.github.com/users/jweeber","html_url":"https://github.com/jweeber","followers_url":"https://api.github.com/users/jweeber/followers","following_url":"https://api.github.com/users/jweeber/following{/other_user}","gists_url":"https://api.github.com/users/jweeber/gists{/gist_id}","starred_url":"https://api.github.com/users/jweeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jweeber/subscriptions","organizations_url":"https://api.github.com/users/jweeber/orgs","repos_url":"https://api.github.com/users/jweeber/repos","events_url":"https://api.github.com/users/jweeber/events{/privacy}","received_events_url":"https://api.github.com/users/jweeber/received_events","type":"User","site_admin":false},"repo":{"id":55188480,"name":"mood-analysis","full_name":"jweeber/mood-analysis","owner":{"login":"jweeber","id":13111507,"avatar_url":"https://avatars.githubusercontent.com/u/13111507?v=3","gravatar_id":"","url":"https://api.github.com/users/jweeber","html_url":"https://github.com/jweeber","followers_url":"https://api.github.com/users/jweeber/followers","following_url":"https://api.github.com/users/jweeber/following{/other_user}","gists_url":"https://api.github.com/users/jweeber/gists{/gist_id}","starred_url":"https://api.github.com/users/jweeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jweeber/subscriptions","organizations_url":"https://api.github.com/users/jweeber/orgs","repos_url":"https://api.github.com/users/jweeber/repos","events_url":"https://api.github.com/users/jweeber/events{/privacy}","received_events_url":"https://api.github.com/users/jweeber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jweeber/mood-analysis","description":"Hash Practice using an NLP-like example","fork":true,"url":"https://api.github.com/repos/jweeber/mood-analysis","forks_url":"https://api.github.com/repos/jweeber/mood-analysis/forks","keys_url":"https://api.github.com/repos/jweeber/mood-analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jweeber/mood-analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jweeber/mood-analysis/teams","hooks_url":"https://api.github.com/repos/jweeber/mood-analysis/hooks","issue_events_url":"https://api.github.com/repos/jweeber/mood-analysis/issues/events{/number}","events_url":"https://api.github.com/repos/jweeber/mood-analysis/events","assignees_url":"https://api.github.com/repos/jweeber/mood-analysis/assignees{/user}","branches_url":"https://api.github.com/repos/jweeber/mood-analysis/branches{/branch}","tags_url":"https://api.github.com/repos/jweeber/mood-analysis/tags","blobs_url":"https://api.github.com/repos/jweeber/mood-analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jweeber/mood-analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jweeber/mood-analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/jweeber/mood-analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jweeber/mood-analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/jweeber/mood-analysis/languages","stargazers_url":"https://api.github.com/repos/jweeber/mood-analysis/stargazers","contributors_url":"https://api.github.com/repos/jweeber/mood-analysis/contributors","subscribers_url":"https://api.github.com/repos/jweeber/mood-analysis/subscribers","subscription_url":"https://api.github.com/repos/jweeber/mood-analysis/subscription","commits_url":"https://api.github.com/repos/jweeber/mood-analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/jweeber/mood-analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/jweeber/mood-analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/jweeber/mood-analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/jweeber/mood-analysis/contents/{+path}","compare_url":"https://api.github.com/repos/jweeber/mood-analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jweeber/mood-analysis/merges","archive_url":"https://api.github.com/repos/jweeber/mood-analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jweeber/mood-analysis/downloads","issues_url":"https://api.github.com/repos/jweeber/mood-analysis/issues{/number}","pulls_url":"https://api.github.com/repos/jweeber/mood-analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/jweeber/mood-analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/jweeber/mood-analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jweeber/mood-analysis/labels{/name}","releases_url":"https://api.github.com/repos/jweeber/mood-analysis/releases{/id}","deployments_url":"https://api.github.com/repos/jweeber/mood-analysis/deployments","created_at":"2016-03-31T22:59:51Z","updated_at":"2016-03-31T22:59:52Z","pushed_at":"2016-04-01T16:49:09Z","git_url":"git://github.com/jweeber/mood-analysis.git","ssh_url":"git@github.com:jweeber/mood-analysis.git","clone_url":"https://github.com/jweeber/mood-analysis.git","svn_url":"https://github.com/jweeber/mood-analysis","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C5:master","ref":"master","sha":"22d4fdc1c1baceae50e2b0d302fd44913e1903a5","user":{"login":"Ada-C5","id":16655720,"avatar_url":"https://avatars.githubusercontent.com/u/16655720?v=3","gravatar_id":"","url":"https://api.github.com/users/Ada-C5","html_url":"https://github.com/Ada-C5","followers_url":"https://api.github.com/users/Ada-C5/followers","following_url":"https://api.github.com/users/Ada-C5/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C5/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C5/subscriptions","organizations_url":"https://api.github.com/users/Ada-C5/orgs","repos_url":"https://api.github.com/users/Ada-C5/repos","events_url":"https://api.github.com/users/Ada-C5/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C5/received_events","type":"Organization","site_admin":false},"repo":{"id":55122595,"name":"mood-analysis","full_name":"Ada-C5/mood-analysis","owner":{"login":"Ada-C5","id":16655720,"avatar_url":"https://avatars.githubusercontent.com/u/16655720?v=3","gravatar_id":"","url":"https://api.github.com/users/Ada-C5","html_url":"https://github.com/Ada-C5","followers_url":"https://api.github.com/users/Ada-C5/followers","following_url":"https://api.github.com/users/Ada-C5/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C5/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C5/subscriptions","organizations_url":"https://api.github.com/users/Ada-C5/orgs","repos_url":"https://api.github.com/users/Ada-C5/repos","events_url":"https://api.github.com/users/Ada-C5/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ada-C5/mood-analysis","description":"Hash Practice using an NLP-like example","fork":true,"url":"https://api.github.com/repos/Ada-C5/mood-analysis","forks_url":"https://api.github.com/repos/Ada-C5/mood-analysis/forks","keys_url":"https://api.github.com/repos/Ada-C5/mood-analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C5/mood-analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C5/mood-analysis/teams","hooks_url":"https://api.github.com/repos/Ada-C5/mood-analysis/hooks","issue_events_url":"https://api.github.com/repos/Ada-C5/mood-analysis/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C5/mood-analysis/events","assignees_url":"https://api.github.com/repos/Ada-C5/mood-analysis/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C5/mood-analysis/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C5/mood-analysis/tags","blobs_url":"https://api.github.com/repos/Ada-C5/mood-analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C5/mood-analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C5/mood-analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C5/mood-analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C5/mood-analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C5/mood-analysis/languages","stargazers_url":"https://api.github.com/repos/Ada-C5/mood-analysis/stargazers","contributors_url":"https://api.github.com/repos/Ada-C5/mood-analysis/contributors","subscribers_url":"https://api.github.com/repos/Ada-C5/mood-analysis/subscribers","subscription_url":"https://api.github.com/repos/Ada-C5/mood-analysis/subscription","commits_url":"https://api.github.com/repos/Ada-C5/mood-analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C5/mood-analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C5/mood-analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C5/mood-analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C5/mood-analysis/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C5/mood-analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C5/mood-analysis/merges","archive_url":"https://api.github.com/repos/Ada-C5/mood-analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C5/mood-analysis/downloads","issues_url":"https://api.github.com/repos/Ada-C5/mood-analysis/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C5/mood-analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C5/mood-analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C5/mood-analysis/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C5/mood-analysis/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C5/mood-analysis/deployments","created_at":"2016-03-31T05:23:52Z","updated_at":"2016-03-31T05:23:53Z","pushed_at":"2016-04-01T22:37:59Z","git_url":"git://github.com/Ada-C5/mood-analysis.git","ssh_url":"git@github.com:Ada-C5/mood-analysis.git","clone_url":"https://github.com/Ada-C5/mood-analysis.git","svn_url":"https://github.com/Ada-C5/mood-analysis","homepage":null,"size":68,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":20,"forks":23,"open_issues":20,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/6"},"html":{"href":"https://github.com/Ada-C5/mood-analysis/pull/6"},"issue":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/issues/6"},"comments":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C5/mood-analysis/statuses/7b1e82417650a57caaa4a01b21193abea576b35b"}}}}