{"action":"closed","issue":{"url":"https://api.github.com/repos/edisch/mmt-assignment/issues/24","repository_url":"https://api.github.com/repos/edisch/mmt-assignment","labels_url":"https://api.github.com/repos/edisch/mmt-assignment/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/edisch/mmt-assignment/issues/24/comments","events_url":"https://api.github.com/repos/edisch/mmt-assignment/issues/24/events","html_url":"https://github.com/edisch/mmt-assignment/issues/24","id":176515388,"number":24,"title":"Refactor","user":{"login":"edisch","id":1893118,"avatar_url":"https://avatars.githubusercontent.com/u/1893118?v=3","gravatar_id":"","url":"https://api.github.com/users/edisch","html_url":"https://github.com/edisch","followers_url":"https://api.github.com/users/edisch/followers","following_url":"https://api.github.com/users/edisch/following{/other_user}","gists_url":"https://api.github.com/users/edisch/gists{/gist_id}","starred_url":"https://api.github.com/users/edisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edisch/subscriptions","organizations_url":"https://api.github.com/users/edisch/orgs","repos_url":"https://api.github.com/users/edisch/repos","events_url":"https://api.github.com/users/edisch/events{/privacy}","received_events_url":"https://api.github.com/users/edisch/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-13T00:03:19Z","updated_at":"2016-09-16T10:07:12Z","closed_at":"2016-09-16T10:07:12Z","body":"Refactor HTML to standardise some properties:\r\n- All full page components aka. features (full screen width) should not be wrapped in content wrappers\r\n- All top margins should be done on the body\r\n\r\n# Project Structure\r\n## Pages and Routes\r\n- All twig templates which are referenced by routes and are traversable by users (accessible via links on the site) should be in the pages directory\r\n- The exception to this is API view transformers. These templates which are also referenced by routes are not \"pages\". They are requested by the clients through AJAX calls.\r\n- The twig files for API view transformers should live inside their respective components. An example being the \"gallery\" component.\r\n\r\n## Components and Features\r\n- Features are full page components which may or may not implement other components.\r\n- Components are sub level building blocks. They are not to be used in the page directly except through features.\r\n- An example of the use of features and components is the feature-header. The header incorporates the button component and adds extra information such as \"title\" and \"subtitle\" as well as \"bgImg\" to construct a full page feature."}}
{"actor":{"display_login":"edisch"}}