{"action":"created","comment":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/comments/89563632","pull_request_review_id":10109092,"id":89563632,"diff_hunk":"@@ -570,8 +570,8 @@ def on_notify\n                   else\n                     @buffer << @io.readpartial(2048, @iobuf)\n                   end\n-                  while line = @buffer.slice!(/.*?\\n/m)\n-                    @lines << line\n+                  while idx = @buffer.index(\"\\n\")","path":"lib/fluent/plugin/in_tail.rb","position":6,"original_position":6,"commit_id":"06d2d410c3b2a85302a4855dcfe159324c68be54","original_commit_id":"06d2d410c3b2a85302a4855dcfe159324c68be54","user":{"login":"repeatedly","id":16928,"avatar_url":"https://avatars.githubusercontent.com/u/16928?v=3","gravatar_id":"","url":"https://api.github.com/users/repeatedly","html_url":"https://github.com/repeatedly","followers_url":"https://api.github.com/users/repeatedly/followers","following_url":"https://api.github.com/users/repeatedly/following{/other_user}","gists_url":"https://api.github.com/users/repeatedly/gists{/gist_id}","starred_url":"https://api.github.com/users/repeatedly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repeatedly/subscriptions","organizations_url":"https://api.github.com/users/repeatedly/orgs","repos_url":"https://api.github.com/users/repeatedly/repos","events_url":"https://api.github.com/users/repeatedly/events{/privacy}","received_events_url":"https://api.github.com/users/repeatedly/received_events","type":"User","site_admin":false},"body":"For more small optimization, `\"\\n\".freeze` is better,","created_at":"2016-11-25T04:27:12Z","updated_at":"2016-11-25T04:27:12Z","html_url":"https://github.com/fluent/fluentd/pull/1325#discussion_r89563632","pull_request_url":"https://api.github.com/repos/fluent/fluentd/pulls/1325","_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments/89563632"},"html":{"href":"https://github.com/fluent/fluentd/pull/1325#discussion_r89563632"},"pull_request":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/1325"}}},"pull_request":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/1325","id":95248122,"html_url":"https://github.com/fluent/fluentd/pull/1325","diff_url":"https://github.com/fluent/fluentd/pull/1325.diff","patch_url":"https://github.com/fluent/fluentd/pull/1325.patch","issue_url":"https://api.github.com/repos/fluent/fluentd/issues/1325","number":1325,"state":"open","locked":false,"title":"optimize to split lines","user":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=3","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"body":"fixes #1324.","created_at":"2016-11-25T04:10:30Z","updated_at":"2016-11-25T04:27:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0483b53338961b71bb5240a05cdc6b8429a1bec","assignee":{"login":"repeatedly","id":16928,"avatar_url":"https://avatars.githubusercontent.com/u/16928?v=3","gravatar_id":"","url":"https://api.github.com/users/repeatedly","html_url":"https://github.com/repeatedly","followers_url":"https://api.github.com/users/repeatedly/followers","following_url":"https://api.github.com/users/repeatedly/following{/other_user}","gists_url":"https://api.github.com/users/repeatedly/gists{/gist_id}","starred_url":"https://api.github.com/users/repeatedly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repeatedly/subscriptions","organizations_url":"https://api.github.com/users/repeatedly/orgs","repos_url":"https://api.github.com/users/repeatedly/repos","events_url":"https://api.github.com/users/repeatedly/events{/privacy}","received_events_url":"https://api.github.com/users/repeatedly/received_events","type":"User","site_admin":false},"assignees":[{"login":"repeatedly","id":16928,"avatar_url":"https://avatars.githubusercontent.com/u/16928?v=3","gravatar_id":"","url":"https://api.github.com/users/repeatedly","html_url":"https://github.com/repeatedly","followers_url":"https://api.github.com/users/repeatedly/followers","following_url":"https://api.github.com/users/repeatedly/following{/other_user}","gists_url":"https://api.github.com/users/repeatedly/gists{/gist_id}","starred_url":"https://api.github.com/users/repeatedly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repeatedly/subscriptions","organizations_url":"https://api.github.com/users/repeatedly/orgs","repos_url":"https://api.github.com/users/repeatedly/repos","events_url":"https://api.github.com/users/repeatedly/events{/privacy}","received_events_url":"https://api.github.com/users/repeatedly/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fluent/fluentd/pulls/1325/commits","review_comments_url":"https://api.github.com/repos/fluent/fluentd/pulls/1325/comments","review_comment_url":"https://api.github.com/repos/fluent/fluentd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluent/fluentd/issues/1325/comments","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/06d2d410c3b2a85302a4855dcfe159324c68be54","head":{"label":"fluent:optimize-split-lines-in_tail","ref":"optimize-split-lines-in_tail","sha":"06d2d410c3b2a85302a4855dcfe159324c68be54","user":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=3","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"repo":{"id":1918677,"name":"fluentd","full_name":"fluent/fluentd","owner":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=3","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluent/fluentd","description":"Fluentd data collector (project under CNCF)","fork":false,"url":"https://api.github.com/repos/fluent/fluentd","forks_url":"https://api.github.com/repos/fluent/fluentd/forks","keys_url":"https://api.github.com/repos/fluent/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluent/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluent/fluentd/teams","hooks_url":"https://api.github.com/repos/fluent/fluentd/hooks","issue_events_url":"https://api.github.com/repos/fluent/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/fluent/fluentd/events","assignees_url":"https://api.github.com/repos/fluent/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/fluent/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/fluent/fluentd/tags","blobs_url":"https://api.github.com/repos/fluent/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluent/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluent/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluent/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/fluent/fluentd/languages","stargazers_url":"https://api.github.com/repos/fluent/fluentd/stargazers","contributors_url":"https://api.github.com/repos/fluent/fluentd/contributors","subscribers_url":"https://api.github.com/repos/fluent/fluentd/subscribers","subscription_url":"https://api.github.com/repos/fluent/fluentd/subscription","commits_url":"https://api.github.com/repos/fluent/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluent/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluent/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluent/fluentd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluent/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/fluent/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluent/fluentd/merges","archive_url":"https://api.github.com/repos/fluent/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluent/fluentd/downloads","issues_url":"https://api.github.com/repos/fluent/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/fluent/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/fluent/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/fluent/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluent/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/fluent/fluentd/releases{/id}","deployments_url":"https://api.github.com/repos/fluent/fluentd/deployments","created_at":"2011-06-19T08:41:40Z","updated_at":"2016-11-24T02:16:16Z","pushed_at":"2016-11-25T04:10:30Z","git_url":"git://github.com/fluent/fluentd.git","ssh_url":"git@github.com:fluent/fluentd.git","clone_url":"https://github.com/fluent/fluentd.git","svn_url":"https://github.com/fluent/fluentd","homepage":"http://www.fluentd.org/","size":19085,"stargazers_count":4719,"watchers_count":4719,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":564,"mirror_url":null,"open_issues_count":45,"forks":564,"open_issues":45,"watchers":4719,"default_branch":"master"}},"base":{"label":"fluent:master","ref":"master","sha":"eb839f9d6b1163c5d900d0c2d87b9d82a75d8bc8","user":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=3","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"repo":{"id":1918677,"name":"fluentd","full_name":"fluent/fluentd","owner":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=3","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluent/fluentd","description":"Fluentd data collector (project under CNCF)","fork":false,"url":"https://api.github.com/repos/fluent/fluentd","forks_url":"https://api.github.com/repos/fluent/fluentd/forks","keys_url":"https://api.github.com/repos/fluent/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluent/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluent/fluentd/teams","hooks_url":"https://api.github.com/repos/fluent/fluentd/hooks","issue_events_url":"https://api.github.com/repos/fluent/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/fluent/fluentd/events","assignees_url":"https://api.github.com/repos/fluent/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/fluent/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/fluent/fluentd/tags","blobs_url":"https://api.github.com/repos/fluent/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluent/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluent/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluent/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/fluent/fluentd/languages","stargazers_url":"https://api.github.com/repos/fluent/fluentd/stargazers","contributors_url":"https://api.github.com/repos/fluent/fluentd/contributors","subscribers_url":"https://api.github.com/repos/fluent/fluentd/subscribers","subscription_url":"https://api.github.com/repos/fluent/fluentd/subscription","commits_url":"https://api.github.com/repos/fluent/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluent/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluent/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluent/fluentd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluent/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/fluent/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluent/fluentd/merges","archive_url":"https://api.github.com/repos/fluent/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluent/fluentd/downloads","issues_url":"https://api.github.com/repos/fluent/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/fluent/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/fluent/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/fluent/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluent/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/fluent/fluentd/releases{/id}","deployments_url":"https://api.github.com/repos/fluent/fluentd/deployments","created_at":"2011-06-19T08:41:40Z","updated_at":"2016-11-24T02:16:16Z","pushed_at":"2016-11-25T04:10:30Z","git_url":"git://github.com/fluent/fluentd.git","ssh_url":"git@github.com:fluent/fluentd.git","clone_url":"https://github.com/fluent/fluentd.git","svn_url":"https://github.com/fluent/fluentd","homepage":"http://www.fluentd.org/","size":19085,"stargazers_count":4719,"watchers_count":4719,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":564,"mirror_url":null,"open_issues_count":45,"forks":564,"open_issues":45,"watchers":4719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/1325"},"html":{"href":"https://github.com/fluent/fluentd/pull/1325"},"issue":{"href":"https://api.github.com/repos/fluent/fluentd/issues/1325"},"comments":{"href":"https://api.github.com/repos/fluent/fluentd/issues/1325/comments"},"review_comments":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/1325/comments"},"review_comment":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/1325/commits"},"statuses":{"href":"https://api.github.com/repos/fluent/fluentd/statuses/06d2d410c3b2a85302a4855dcfe159324c68be54"}}}}
{"actor":{"display_login":"repeatedly"}}