{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6253","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6253/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6253/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6253/events","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/6253","id":175161035,"number":6253,"title":"[core] [notready] Better handling for undefined icon|text-rotation-alignment","user":{"login":"yhahn","id":83384,"avatar_url":"https://avatars.githubusercontent.com/u/83384?v=3","gravatar_id":"","url":"https://api.github.com/users/yhahn","html_url":"https://github.com/yhahn","followers_url":"https://api.github.com/users/yhahn/followers","following_url":"https://api.github.com/users/yhahn/following{/other_user}","gists_url":"https://api.github.com/users/yhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/yhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhahn/subscriptions","organizations_url":"https://api.github.com/users/yhahn/orgs","repos_url":"https://api.github.com/users/yhahn/repos","events_url":"https://api.github.com/users/yhahn/events{/privacy}","received_events_url":"https://api.github.com/users/yhahn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Core%20GL","name":"Core GL","color":"000000"},{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/navigation","name":"navigation","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"boundsj","id":63186,"avatar_url":"https://avatars.githubusercontent.com/u/63186?v=3","gravatar_id":"","url":"https://api.github.com/users/boundsj","html_url":"https://github.com/boundsj","followers_url":"https://api.github.com/users/boundsj/followers","following_url":"https://api.github.com/users/boundsj/following{/other_user}","gists_url":"https://api.github.com/users/boundsj/gists{/gist_id}","starred_url":"https://api.github.com/users/boundsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundsj/subscriptions","organizations_url":"https://api.github.com/users/boundsj/orgs","repos_url":"https://api.github.com/users/boundsj/repos","events_url":"https://api.github.com/users/boundsj/events{/privacy}","received_events_url":"https://api.github.com/users/boundsj/received_events","type":"User","site_admin":false},"assignees":[{"login":"boundsj","id":63186,"avatar_url":"https://avatars.githubusercontent.com/u/63186?v=3","gravatar_id":"","url":"https://api.github.com/users/boundsj","html_url":"https://github.com/boundsj","followers_url":"https://api.github.com/users/boundsj/followers","following_url":"https://api.github.com/users/boundsj/following{/other_user}","gists_url":"https://api.github.com/users/boundsj/gists{/gist_id}","starred_url":"https://api.github.com/users/boundsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundsj/subscriptions","organizations_url":"https://api.github.com/users/boundsj/orgs","repos_url":"https://api.github.com/users/boundsj/repos","events_url":"https://api.github.com/users/boundsj/events{/privacy}","received_events_url":"https://api.github.com/users/boundsj/received_events","type":"User","site_admin":false},{"login":"lbud","id":3170312,"avatar_url":"https://avatars.githubusercontent.com/u/3170312?v=3","gravatar_id":"","url":"https://api.github.com/users/lbud","html_url":"https://github.com/lbud","followers_url":"https://api.github.com/users/lbud/followers","following_url":"https://api.github.com/users/lbud/following{/other_user}","gists_url":"https://api.github.com/users/lbud/gists{/gist_id}","starred_url":"https://api.github.com/users/lbud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbud/subscriptions","organizations_url":"https://api.github.com/users/lbud/orgs","repos_url":"https://api.github.com/users/lbud/repos","events_url":"https://api.github.com/users/lbud/events{/privacy}","received_events_url":"https://api.github.com/users/lbud/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/37","html_url":"https://github.com/mapbox/mapbox-gl-native/milestones/ios-v3.4.0","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/37/labels","id":1783804,"number":37,"title":"ios-v3.4.0","description":"The release will go through a series of alpha and beta versions until it reaches a stable state and is made generally available. In the alpha phase, we publish a version that have enough new features as to be useful for developers who would like to test and help report issues. In the beta phase, we've locked down new feature development and are focused mostly on stability issues. In general, after the first alpha, we aim to release a new alpha (or beta) version once per week.\r\n\r\n## Releases\r\n\r\n- Alpha 1: 8/11\r\n- Alpha 2: 8/18 (planned)\r\n","creator":{"login":"friedbunny","id":1198851,"avatar_url":"https://avatars.githubusercontent.com/u/1198851?v=3","gravatar_id":"","url":"https://api.github.com/users/friedbunny","html_url":"https://github.com/friedbunny","followers_url":"https://api.github.com/users/friedbunny/followers","following_url":"https://api.github.com/users/friedbunny/following{/other_user}","gists_url":"https://api.github.com/users/friedbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/friedbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedbunny/subscriptions","organizations_url":"https://api.github.com/users/friedbunny/orgs","repos_url":"https://api.github.com/users/friedbunny/repos","events_url":"https://api.github.com/users/friedbunny/events{/privacy}","received_events_url":"https://api.github.com/users/friedbunny/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":101,"state":"open","created_at":"2016-05-23T22:50:20Z","updated_at":"2016-09-15T17:34:42Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-09-06T05:05:57Z","updated_at":"2016-09-16T17:56:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/6253","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/6253","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/6253.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/6253.patch"},"body":"I believe this addresses the root cause behind https://github.com/mapbox/mapbox-gl-native/issues/5683.\r\n\r\n- Updates GL style spec to remove an explicit `default` from `text-rotation-alignment` and `icon-rotation-alignment`. This value was a lie given that renderers currently derive the default in coordination with `symbol-placement`\r\n- Update logic in GL native to set the default value for these properties only when they are undefined.\r\n\r\n### Remaining backlog \r\n\r\n- [ ] @yhahn Render tests to lockdown expected behavior\r\n- [ ] @yhahn Vet style spec change, esp possible effect on GL JS and other integrators\r\n- [ ] Review @1ec5 @jfirebaugh "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/247665877","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/6253#issuecomment-247665877","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/6253","id":247665877,"user":{"login":"jfirebaugh","id":98601,"avatar_url":"https://avatars.githubusercontent.com/u/98601?v=3","gravatar_id":"","url":"https://api.github.com/users/jfirebaugh","html_url":"https://github.com/jfirebaugh","followers_url":"https://api.github.com/users/jfirebaugh/followers","following_url":"https://api.github.com/users/jfirebaugh/following{/other_user}","gists_url":"https://api.github.com/users/jfirebaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/jfirebaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfirebaugh/subscriptions","organizations_url":"https://api.github.com/users/jfirebaugh/orgs","repos_url":"https://api.github.com/users/jfirebaugh/repos","events_url":"https://api.github.com/users/jfirebaugh/events{/privacy}","received_events_url":"https://api.github.com/users/jfirebaugh/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T17:56:43Z","updated_at":"2016-09-16T17:56:43Z","body":"Changes here look good. Do we have a test case for the original issue #5683?"}}
{"actor":{"display_login":"jfirebaugh"}}