{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/50756462","id":50756462,"diff_hunk":"@@ -59,13 +59,11 @@ def initialize(routes)\n         @routes = routes\n       end\n \n-      def format(formatter, filter = nil)\n-        routes_to_display = filter_routes(filter)\n-\n+      def format(formatter, **options)\n+        routes_to_display = filter_routes(options)\n         routes = collect_routes(routes_to_display)\n-\n         if routes.none?\n-          formatter.no_routes(collect_routes(@routes), filter)\n+          formatter.no_routes(collect_routes(@routes), options[:pattern])","path":"actionpack/lib/action_dispatch/routing/inspector.rb","position":13,"original_position":13,"commit_id":"212bf9233c8ec0dddfd3b97da8fc53cce83a6cd2","original_commit_id":"6711fa7a3ddfa1b1e243e84a27f266bccedda117","user":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"body":"Let's look at making the no_routes message better instead. I don't think we should output the controller name because then we'd have to worry about escaping as @matthewd said in the original pull request.","created_at":"2016-01-25T21:10:03Z","updated_at":"2016-01-25T21:10:03Z","html_url":"https://github.com/rails/rails/pull/23225#discussion_r50756462","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/23225","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/50756462"},"html":{"href":"https://github.com/rails/rails/pull/23225#discussion_r50756462"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/23225"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/23225","id":57012562,"html_url":"https://github.com/rails/rails/pull/23225","diff_url":"https://github.com/rails/rails/pull/23225.diff","patch_url":"https://github.com/rails/rails/pull/23225.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/23225","number":23225,"state":"open","locked":false,"title":"Add options for rake routes task","user":{"login":"vipulnsward","id":567626,"avatar_url":"https://avatars.githubusercontent.com/u/567626?v=3","gravatar_id":"","url":"https://api.github.com/users/vipulnsward","html_url":"https://github.com/vipulnsward","followers_url":"https://api.github.com/users/vipulnsward/followers","following_url":"https://api.github.com/users/vipulnsward/following{/other_user}","gists_url":"https://api.github.com/users/vipulnsward/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulnsward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulnsward/subscriptions","organizations_url":"https://api.github.com/users/vipulnsward/orgs","repos_url":"https://api.github.com/users/vipulnsward/repos","events_url":"https://api.github.com/users/vipulnsward/events{/privacy}","received_events_url":"https://api.github.com/users/vipulnsward/received_events","type":"User","site_admin":false},"body":"Add two options: `-c` and `-g`.\r\n`-g` option returns the urls name, verb and path fields that match the pattern.\r\n`-c` option returns the urls for specific controller.\r\n\r\nFixes #20420 & Fixes #18902","created_at":"2016-01-24T20:18:41Z","updated_at":"2016-01-25T21:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d01282b99e3b1dc6351b66f91e41d77cd7a8d4ca","assignee":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/rails/rails/milestones/47","html_url":"https://github.com/rails/rails/milestones/5.0.0","labels_url":"https://api.github.com/repos/rails/rails/milestones/47/labels","id":1467326,"number":47,"title":"5.0.0","description":"","creator":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":278,"state":"open","created_at":"2015-12-18T21:17:59Z","updated_at":"2016-01-25T20:56:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/rails/rails/pulls/23225/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/23225/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/23225/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/212bf9233c8ec0dddfd3b97da8fc53cce83a6cd2","head":{"label":"vipulnsward:20420-rake-routes-options","ref":"20420-rake-routes-options","sha":"212bf9233c8ec0dddfd3b97da8fc53cce83a6cd2","user":{"login":"vipulnsward","id":567626,"avatar_url":"https://avatars.githubusercontent.com/u/567626?v=3","gravatar_id":"","url":"https://api.github.com/users/vipulnsward","html_url":"https://github.com/vipulnsward","followers_url":"https://api.github.com/users/vipulnsward/followers","following_url":"https://api.github.com/users/vipulnsward/following{/other_user}","gists_url":"https://api.github.com/users/vipulnsward/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulnsward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulnsward/subscriptions","organizations_url":"https://api.github.com/users/vipulnsward/orgs","repos_url":"https://api.github.com/users/vipulnsward/repos","events_url":"https://api.github.com/users/vipulnsward/events{/privacy}","received_events_url":"https://api.github.com/users/vipulnsward/received_events","type":"User","site_admin":false},"repo":{"id":6652536,"name":"rails","full_name":"vipulnsward/rails","owner":{"login":"vipulnsward","id":567626,"avatar_url":"https://avatars.githubusercontent.com/u/567626?v=3","gravatar_id":"","url":"https://api.github.com/users/vipulnsward","html_url":"https://github.com/vipulnsward","followers_url":"https://api.github.com/users/vipulnsward/followers","following_url":"https://api.github.com/users/vipulnsward/following{/other_user}","gists_url":"https://api.github.com/users/vipulnsward/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulnsward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulnsward/subscriptions","organizations_url":"https://api.github.com/users/vipulnsward/orgs","repos_url":"https://api.github.com/users/vipulnsward/repos","events_url":"https://api.github.com/users/vipulnsward/events{/privacy}","received_events_url":"https://api.github.com/users/vipulnsward/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vipulnsward/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/vipulnsward/rails","forks_url":"https://api.github.com/repos/vipulnsward/rails/forks","keys_url":"https://api.github.com/repos/vipulnsward/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vipulnsward/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vipulnsward/rails/teams","hooks_url":"https://api.github.com/repos/vipulnsward/rails/hooks","issue_events_url":"https://api.github.com/repos/vipulnsward/rails/issues/events{/number}","events_url":"https://api.github.com/repos/vipulnsward/rails/events","assignees_url":"https://api.github.com/repos/vipulnsward/rails/assignees{/user}","branches_url":"https://api.github.com/repos/vipulnsward/rails/branches{/branch}","tags_url":"https://api.github.com/repos/vipulnsward/rails/tags","blobs_url":"https://api.github.com/repos/vipulnsward/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vipulnsward/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vipulnsward/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/vipulnsward/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vipulnsward/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/vipulnsward/rails/languages","stargazers_url":"https://api.github.com/repos/vipulnsward/rails/stargazers","contributors_url":"https://api.github.com/repos/vipulnsward/rails/contributors","subscribers_url":"https://api.github.com/repos/vipulnsward/rails/subscribers","subscription_url":"https://api.github.com/repos/vipulnsward/rails/subscription","commits_url":"https://api.github.com/repos/vipulnsward/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/vipulnsward/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/vipulnsward/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/vipulnsward/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/vipulnsward/rails/contents/{+path}","compare_url":"https://api.github.com/repos/vipulnsward/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vipulnsward/rails/merges","archive_url":"https://api.github.com/repos/vipulnsward/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vipulnsward/rails/downloads","issues_url":"https://api.github.com/repos/vipulnsward/rails/issues{/number}","pulls_url":"https://api.github.com/repos/vipulnsward/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/vipulnsward/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/vipulnsward/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vipulnsward/rails/labels{/name}","releases_url":"https://api.github.com/repos/vipulnsward/rails/releases{/id}","deployments_url":"https://api.github.com/repos/vipulnsward/rails/deployments","created_at":"2012-11-12T11:42:33Z","updated_at":"2015-01-14T06:40:25Z","pushed_at":"2016-01-25T20:20:59Z","git_url":"git://github.com/vipulnsward/rails.git","ssh_url":"git@github.com:vipulnsward/rails.git","clone_url":"https://github.com/vipulnsward/rails.git","svn_url":"https://github.com/vipulnsward/rails","homepage":"http://rubyonrails.org","size":112952,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"6dfab475ca230dfcad7a603483431c8e7a8f908e","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-01-25T18:24:32Z","pushed_at":"2016-01-25T20:22:25Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":323241,"stargazers_count":29366,"watchers_count":29366,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11920,"mirror_url":null,"open_issues_count":849,"forks":11920,"open_issues":849,"watchers":29366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/23225"},"html":{"href":"https://github.com/rails/rails/pull/23225"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/23225"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/23225/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/23225/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/23225/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/212bf9233c8ec0dddfd3b97da8fc53cce83a6cd2"}}}}