{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls/1","id":62133670,"html_url":"https://github.com/SUSE-Cloud/cookbook-openstack-network/pull/1","diff_url":"https://github.com/SUSE-Cloud/cookbook-openstack-network/pull/1.diff","patch_url":"https://github.com/SUSE-Cloud/cookbook-openstack-network/pull/1.patch","issue_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/issues/1","number":1,"state":"closed","locked":false,"title":"many neutron-ha-tool fixes","user":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"body":"**In a Crowbar environment, the retry commit requires https://github.com/crowbar/crowbar-openstack/pull/344 and also https://review.openstack.org/#/c/297664/ in order to be effective.**\r\n\r\nWhilst looking into [bsc#965886 (L3: neutron-ha-tool not migrating dhcp networks during failover)](https://bugzilla.suse.com/show_bug.cgi?id=965886), I discovered many instances of braindead code in `neutron-ha-tool`.  In particular, previous authors seemed to think that `LOG.exception()` aborts the code flow, which it doesn't, so several corner cases just completely fail.\r\n\r\nRather than submitting all these changes as individual rpm patches like it's 1995, I've forked the original upstream git repo to this fork, resurrected the Icehouse branch (which was tagged as `eol-icehouse`) and created a new `neutron-ha-tool-maintenance` branch from it which can be subject to the normal code review process.  We can then easily repoint https://build.suse.de/package/show/Devel:Cloud:6:Staging/openstack-neutron at it.  Similarly for Cloud 5.","created_at":"2016-03-08T20:48:17Z","updated_at":"2016-03-31T09:01:14Z","closed_at":"2016-03-31T09:01:14Z","merged_at":"2016-03-31T09:01:14Z","merge_commit_sha":"551dadd0d8b14e83aef1cfe7162219a6a2f269f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/issues/1/comments","statuses_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/statuses/5be4099b02914aedf978db3e23dceee2f25bbad4","head":{"label":"aspiers:neutron-ha-tool-maintenance","ref":"neutron-ha-tool-maintenance","sha":"5be4099b02914aedf978db3e23dceee2f25bbad4","user":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"repo":{"id":53419936,"name":"cookbook-openstack-network","full_name":"aspiers/cookbook-openstack-network","owner":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aspiers/cookbook-openstack-network","description":"Chef Cookbook - OpenStack Network","fork":true,"url":"https://api.github.com/repos/aspiers/cookbook-openstack-network","forks_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/forks","keys_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/teams","hooks_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/hooks","issue_events_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/issues/events{/number}","events_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/events","assignees_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/assignees{/user}","branches_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/branches{/branch}","tags_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/tags","blobs_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/statuses/{sha}","languages_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/languages","stargazers_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/stargazers","contributors_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/contributors","subscribers_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/subscribers","subscription_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/subscription","commits_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/contents/{+path}","compare_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/merges","archive_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/downloads","issues_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/issues{/number}","pulls_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/pulls{/number}","milestones_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/milestones{/number}","notifications_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/labels{/name}","releases_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/releases{/id}","deployments_url":"https://api.github.com/repos/aspiers/cookbook-openstack-network/deployments","created_at":"2016-03-08T14:47:16Z","updated_at":"2016-03-08T14:47:16Z","pushed_at":"2016-03-24T23:41:08Z","git_url":"git://github.com/aspiers/cookbook-openstack-network.git","ssh_url":"git@github.com:aspiers/cookbook-openstack-network.git","clone_url":"https://github.com/aspiers/cookbook-openstack-network.git","svn_url":"https://github.com/aspiers/cookbook-openstack-network","homepage":"http://openstack.org","size":873,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE-Cloud:neutron-ha-tool-maintenance","ref":"neutron-ha-tool-maintenance","sha":"26a7df46b1129184c9a8b6ce359618968be101c2","user":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":53420028,"name":"cookbook-openstack-network","full_name":"SUSE-Cloud/cookbook-openstack-network","owner":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE-Cloud/cookbook-openstack-network","description":"Chef Cookbook - OpenStack Network","fork":true,"url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network","forks_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/forks","keys_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/teams","hooks_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/hooks","issue_events_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/events","assignees_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/tags","blobs_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/languages","stargazers_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/stargazers","contributors_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/contributors","subscribers_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/subscribers","subscription_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/subscription","commits_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/merges","archive_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/downloads","issues_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/labels{/name}","releases_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/deployments","created_at":"2016-03-08T14:48:28Z","updated_at":"2016-03-08T14:48:29Z","pushed_at":"2016-03-31T09:01:14Z","git_url":"git://github.com/SUSE-Cloud/cookbook-openstack-network.git","ssh_url":"git@github.com:SUSE-Cloud/cookbook-openstack-network.git","clone_url":"https://github.com/SUSE-Cloud/cookbook-openstack-network.git","svn_url":"https://github.com/SUSE-Cloud/cookbook-openstack-network","homepage":"http://openstack.org","size":845,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"neutron-ha-tool-maintenance"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls/1"},"html":{"href":"https://github.com/SUSE-Cloud/cookbook-openstack-network/pull/1"},"issue":{"href":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/issues/1"},"comments":{"href":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE-Cloud/cookbook-openstack-network/statuses/5be4099b02914aedf978db3e23dceee2f25bbad4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"comments":15,"review_comments":28,"commits":20,"additions":255,"deletions":158,"changed_files":1}}