{"action":"created","comment":{"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments/85448268","pull_request_review_id":6165277,"id":85448268,"diff_hunk":"@@ -77,20 +75,16 @@ module.exports = {\n      * Responsible for fixing the indentation issue fix\n      * @param {ASTNode} node Node violating the indent rule\n      * @param {Number} needed Expected indentation character count\n-     * @param {Number} gotten Indentation character count in the actual node/code\n      * @returns {Function} function to be executed by the fixer\n      * @private\n      */\n-    function getFixerFunction(node, needed, gotten) {\n-      if (needed > gotten) {\n-        var spaces = indentChar.repeat(needed - gotten);","path":"lib/rules/jsx-indent.js","position":19,"original_position":19,"commit_id":"4e577d2e5ec130f6568a8969b6c8f80dc00d1293","original_commit_id":"224c5ba2bb5ae9ee0e5aed16f2f26d7efe6f8405","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"In general, `left-pad` in no way changes that more deps is better. `left-pad` was only a problem for people that were already ignoring a decade of best practices and depending on third-party registries for their dependencies.\r\n\r\nIn this case, keeping your join trick is fine too.","created_at":"2016-10-27T23:28:19Z","updated_at":"2016-10-27T23:28:19Z","html_url":"https://github.com/yannickcr/eslint-plugin-react/pull/608#discussion_r85448268","pull_request_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/608","_links":{"self":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments/85448268"},"html":{"href":"https://github.com/yannickcr/eslint-plugin-react/pull/608#discussion_r85448268"},"pull_request":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/608"}}},"pull_request":{"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/608","id":70929519,"html_url":"https://github.com/yannickcr/eslint-plugin-react/pull/608","diff_url":"https://github.com/yannickcr/eslint-plugin-react/pull/608.diff","patch_url":"https://github.com/yannickcr/eslint-plugin-react/pull/608.patch","issue_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/608","number":608,"state":"open","locked":false,"title":"Autofix: `jsx-indent`: Add support for tabs","user":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"body":"Everything seems correct except for the very last test. \r\n\r\nThe real output is:\r\n```js\r\nfunction App() {\r\n  return (\r\n    <App>\r\n  <Foo />\r\n</App>\r\n  );\r\n}\r\n```\r\n\r\nBut I would _expect_ the output to be:\r\n\r\n```js\r\nfunction App() {\r\n  return (\r\n    <App>\r\n        <Foo />\r\n    </App>\r\n  );\r\n}\r\n```\r\n\r\nAnyone have any ideas what I'm doing wrong or if somehow this is indeed expected behavior?","created_at":"2016-05-20T23:18:25Z","updated_at":"2016-10-27T23:28:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80d469900bd451ef3c4296dce94432d4dcd63ff8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/608/commits","review_comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/608/comments","review_comment_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/608/comments","statuses_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/4e577d2e5ec130f6568a8969b6c8f80dc00d1293","head":{"label":"jayphelps:jsx-indent-fix","ref":"jsx-indent-fix","sha":"4e577d2e5ec130f6568a8969b6c8f80dc00d1293","user":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"repo":{"id":59331182,"name":"eslint-plugin-react","full_name":"jayphelps/eslint-plugin-react","owner":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayphelps/eslint-plugin-react","description":"React specific linting rules for ESLint","fork":true,"url":"https://api.github.com/repos/jayphelps/eslint-plugin-react","forks_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/forks","keys_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/teams","hooks_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/hooks","issue_events_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/issues/events{/number}","events_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/events","assignees_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/assignees{/user}","branches_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/branches{/branch}","tags_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/tags","blobs_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/statuses/{sha}","languages_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/languages","stargazers_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/stargazers","contributors_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/contributors","subscribers_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/subscribers","subscription_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/subscription","commits_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/contents/{+path}","compare_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/merges","archive_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/downloads","issues_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/issues{/number}","pulls_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/pulls{/number}","milestones_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/milestones{/number}","notifications_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/labels{/name}","releases_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/releases{/id}","deployments_url":"https://api.github.com/repos/jayphelps/eslint-plugin-react/deployments","created_at":"2016-05-20T23:00:59Z","updated_at":"2016-05-20T23:01:00Z","pushed_at":"2016-10-27T20:30:41Z","git_url":"git://github.com/jayphelps/eslint-plugin-react.git","ssh_url":"git@github.com:jayphelps/eslint-plugin-react.git","clone_url":"https://github.com/jayphelps/eslint-plugin-react.git","svn_url":"https://github.com/jayphelps/eslint-plugin-react","homepage":null,"size":1285,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yannickcr:master","ref":"master","sha":"99cec3e158039292f69d058361b218e40a918846","user":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"repo":{"id":28061676,"name":"eslint-plugin-react","full_name":"yannickcr/eslint-plugin-react","owner":{"login":"yannickcr","id":13209,"avatar_url":"https://avatars.githubusercontent.com/u/13209?v=3","gravatar_id":"","url":"https://api.github.com/users/yannickcr","html_url":"https://github.com/yannickcr","followers_url":"https://api.github.com/users/yannickcr/followers","following_url":"https://api.github.com/users/yannickcr/following{/other_user}","gists_url":"https://api.github.com/users/yannickcr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickcr/subscriptions","organizations_url":"https://api.github.com/users/yannickcr/orgs","repos_url":"https://api.github.com/users/yannickcr/repos","events_url":"https://api.github.com/users/yannickcr/events{/privacy}","received_events_url":"https://api.github.com/users/yannickcr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yannickcr/eslint-plugin-react","description":"React specific linting rules for ESLint","fork":false,"url":"https://api.github.com/repos/yannickcr/eslint-plugin-react","forks_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/forks","keys_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/teams","hooks_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/hooks","issue_events_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/events{/number}","events_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/events","assignees_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/assignees{/user}","branches_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/branches{/branch}","tags_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/tags","blobs_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/{sha}","languages_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/languages","stargazers_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/stargazers","contributors_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/contributors","subscribers_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/subscribers","subscription_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/subscription","commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/contents/{+path}","compare_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/merges","archive_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/downloads","issues_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues{/number}","pulls_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls{/number}","milestones_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/milestones{/number}","notifications_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/labels{/name}","releases_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/releases{/id}","deployments_url":"https://api.github.com/repos/yannickcr/eslint-plugin-react/deployments","created_at":"2014-12-15T23:44:14Z","updated_at":"2016-10-27T12:27:49Z","pushed_at":"2016-10-27T20:30:42Z","git_url":"git://github.com/yannickcr/eslint-plugin-react.git","ssh_url":"git@github.com:yannickcr/eslint-plugin-react.git","clone_url":"https://github.com/yannickcr/eslint-plugin-react.git","svn_url":"https://github.com/yannickcr/eslint-plugin-react","homepage":null,"size":1647,"stargazers_count":1894,"watchers_count":1894,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":372,"mirror_url":null,"open_issues_count":198,"forks":372,"open_issues":198,"watchers":1894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/608"},"html":{"href":"https://github.com/yannickcr/eslint-plugin-react/pull/608"},"issue":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/608"},"comments":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/yannickcr/eslint-plugin-react/statuses/4e577d2e5ec130f6568a8969b6c8f80dc00d1293"}}}}
{"actor":{"display_login":"ljharb"}}