{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/89456141","pull_request_review_id":10000842,"id":89456141,"diff_hunk":"@@ -417,12 +417,13 @@ Java_com_mapswithme_maps_editor_Editor_nativeClearLocalEdits(JNIEnv * env, jclas\n   Editor::Instance().ClearAllLocalEdits();\n }\n \n-JNIEXPORT void JNICALL\n-Java_com_mapswithme_maps_editor_Editor_nativeStartEdit(JNIEnv *, jclass)\n+JNIEXPORT void JNICALL Java_com_mapswithme_maps_editor_Editor_nativeStartEdit(JNIEnv *, jclass,\n+                                                                              jint drawScale = -1)\n {\n   ::Framework * frm = g_framework->NativeFramework();\n   place_page::Info const & info = g_framework->GetPlacePageInfo();\n-  CHECK(frm->GetEditableMapObject(info.GetID(), g_editableMapObject), (\"Invalid feature in the place page.\"));\n+  CHECK(frm->GetEditableMapObject(info.GetID(), g_editableMapObject, drawScale),\n+        (\"Invalid feature in the place page.\"));","path":"android/jni/com/mapswithme/maps/editor/Editor.cpp","position":13,"original_position":13,"commit_id":"e197c059713ee2edbeccadc2a5a9f3cc042a12bb","original_commit_id":"b0a18a24a427b7b4aea4ca2df18c31a6be57d388","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"body":"Вы не поняли меня, видимо, я говорю не про инициализацию платформы, а про инициализацию движка рендеринга карты, который зависит от наличия SurfaceView. На экране редактора объекта - нет SurfaceView с картой, соответственно, при восстановлении этого экрана после уничтожения приложения системой, движок рендеринга, в принципе не будет проинициализирован.","created_at":"2016-11-24T09:00:50Z","updated_at":"2016-11-24T09:00:50Z","html_url":"https://github.com/mapsme/omim/pull/4744#discussion_r89456141","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/4744","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/89456141"},"html":{"href":"https://github.com/mapsme/omim/pull/4744#discussion_r89456141"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/4744"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/4744","id":94315068,"html_url":"https://github.com/mapsme/omim/pull/4744","diff_url":"https://github.com/mapsme/omim/pull/4744.diff","patch_url":"https://github.com/mapsme/omim/pull/4744.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/4744","number":4744,"state":"open","locked":false,"title":"[android] Fixed editor restore state.","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"body":"[android] Fixed editor restore state(https://jira.mail.ru/browse/MAPSME-2972).\r\n\r\n@alexzatsepin \r\n@mpimenov ","created_at":"2016-11-18T07:30:14Z","updated_at":"2016-11-24T09:00:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5ae34d85fa04856c993275cf7db8f8b928d76bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/4744/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/4744/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/4744/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/e197c059713ee2edbeccadc2a5a9f3cc042a12bb","head":{"label":"goblinr:MAPSME-87-ext-fix-editor-restore-state","ref":"MAPSME-87-ext-fix-editor-restore-state","sha":"e197c059713ee2edbeccadc2a5a9f3cc042a12bb","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"repo":{"id":68004519,"name":"omim","full_name":"goblinr/omim","owner":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goblinr/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/goblinr/omim","forks_url":"https://api.github.com/repos/goblinr/omim/forks","keys_url":"https://api.github.com/repos/goblinr/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goblinr/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goblinr/omim/teams","hooks_url":"https://api.github.com/repos/goblinr/omim/hooks","issue_events_url":"https://api.github.com/repos/goblinr/omim/issues/events{/number}","events_url":"https://api.github.com/repos/goblinr/omim/events","assignees_url":"https://api.github.com/repos/goblinr/omim/assignees{/user}","branches_url":"https://api.github.com/repos/goblinr/omim/branches{/branch}","tags_url":"https://api.github.com/repos/goblinr/omim/tags","blobs_url":"https://api.github.com/repos/goblinr/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goblinr/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goblinr/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/goblinr/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goblinr/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/goblinr/omim/languages","stargazers_url":"https://api.github.com/repos/goblinr/omim/stargazers","contributors_url":"https://api.github.com/repos/goblinr/omim/contributors","subscribers_url":"https://api.github.com/repos/goblinr/omim/subscribers","subscription_url":"https://api.github.com/repos/goblinr/omim/subscription","commits_url":"https://api.github.com/repos/goblinr/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/goblinr/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/goblinr/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/goblinr/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/goblinr/omim/contents/{+path}","compare_url":"https://api.github.com/repos/goblinr/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goblinr/omim/merges","archive_url":"https://api.github.com/repos/goblinr/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goblinr/omim/downloads","issues_url":"https://api.github.com/repos/goblinr/omim/issues{/number}","pulls_url":"https://api.github.com/repos/goblinr/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/goblinr/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/goblinr/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goblinr/omim/labels{/name}","releases_url":"https://api.github.com/repos/goblinr/omim/releases{/id}","deployments_url":"https://api.github.com/repos/goblinr/omim/deployments","created_at":"2016-09-12T11:50:39Z","updated_at":"2016-09-12T11:52:10Z","pushed_at":"2016-11-24T05:12:14Z","git_url":"git://github.com/goblinr/omim.git","ssh_url":"git@github.com:goblinr/omim.git","clone_url":"https://github.com/goblinr/omim.git","svn_url":"https://github.com/goblinr/omim","homepage":null,"size":2818978,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"5172c94d2c549ca6dec37606e55d807b3dd490c8","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2016-11-24T08:40:46Z","pushed_at":"2016-11-24T08:34:29Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":2900450,"stargazers_count":2047,"watchers_count":2047,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":405,"mirror_url":null,"open_issues_count":364,"forks":405,"open_issues":364,"watchers":2047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/4744"},"html":{"href":"https://github.com/mapsme/omim/pull/4744"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/4744"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/4744/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/4744/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/4744/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/e197c059713ee2edbeccadc2a5a9f3cc042a12bb"}}}}
{"actor":{"display_login":"goblinr"}}