{"action":"created","issue":{"url":"https://api.github.com/repos/ocf/services/issues/2","repository_url":"https://api.github.com/repos/ocf/services","labels_url":"https://api.github.com/repos/ocf/services/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ocf/services/issues/2/comments","events_url":"https://api.github.com/repos/ocf/services/issues/2/events","html_url":"https://github.com/ocf/services/pull/2","id":193890630,"number":2,"title":"Add test for healthchecks","user":{"login":"chriskuehl","id":665269,"avatar_url":"https://avatars.githubusercontent.com/u/665269?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskuehl","html_url":"https://github.com/chriskuehl","followers_url":"https://api.github.com/users/chriskuehl/followers","following_url":"https://api.github.com/users/chriskuehl/following{/other_user}","gists_url":"https://api.github.com/users/chriskuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskuehl/subscriptions","organizations_url":"https://api.github.com/users/chriskuehl/orgs","repos_url":"https://api.github.com/users/chriskuehl/repos","events_url":"https://api.github.com/users/chriskuehl/events{/privacy}","received_events_url":"https://api.github.com/users/chriskuehl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-06T21:30:57Z","updated_at":"2016-12-06T21:42:55Z","closed_at":"2016-12-06T21:42:20Z","pull_request":{"url":"https://api.github.com/repos/ocf/services/pulls/2","html_url":"https://github.com/ocf/services/pull/2","diff_url":"https://github.com/ocf/services/pull/2.diff","patch_url":"https://github.com/ocf/services/pull/2.patch"},"body":"This enforces that each port a service defines at least has a healthcheck (though not necessarily that it's a good healthcheck).\r\n\r\nI also removed some port definitions from services that don't provide a Docker mapping (meaning they were claiming that as their port to Marathon, but nothing was bound to that port ever). These were just auto-added by the UI.\r\n\r\nHere's an example failure:\r\n\r\n```\r\nE               AssertionError: No healthcheck for \"/ocfweb/worker\" port index 0:\r\nE                   {'port': 10003, 'protocol': 'tcp', 'labels': {}}\r\n```"},"comment":{"url":"https://api.github.com/repos/ocf/services/issues/comments/265281804","html_url":"https://github.com/ocf/services/pull/2#issuecomment-265281804","issue_url":"https://api.github.com/repos/ocf/services/issues/2","id":265281804,"user":{"login":"chriskuehl","id":665269,"avatar_url":"https://avatars.githubusercontent.com/u/665269?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskuehl","html_url":"https://github.com/chriskuehl","followers_url":"https://api.github.com/users/chriskuehl/followers","following_url":"https://api.github.com/users/chriskuehl/following{/other_user}","gists_url":"https://api.github.com/users/chriskuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskuehl/subscriptions","organizations_url":"https://api.github.com/users/chriskuehl/orgs","repos_url":"https://api.github.com/users/chriskuehl/repos","events_url":"https://api.github.com/users/chriskuehl/events{/privacy}","received_events_url":"https://api.github.com/users/chriskuehl/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T21:42:55Z","updated_at":"2016-12-06T21:42:55Z","body":"yeah, it's hard to have a worse healthcheck than no healthcheck, but i get your point"}}
{"actor":{"display_login":"chriskuehl"}}