{"action":"created","comment":{"url":"https://api.github.com/repos/derekparker/delve/pulls/comments/89205753","pull_request_review_id":9753444,"id":89205753,"diff_hunk":"@@ -151,9 +161,10 @@ func execSpecialOpcode(sm *StateMachine, instr byte) {\n \n \tsm.lastDelta = int(sm.dbl.Prologue.LineBase + int8(decoded%sm.dbl.Prologue.LineRange))\n \tsm.line += sm.lastDelta\n-\tsm.address += uint64(decoded / sm.dbl.Prologue.LineRange)\n+\tsm.address += uint64(decoded/sm.dbl.Prologue.LineRange) * uint64(sm.dbl.Prologue.MinInstrLength)","path":"dwarf/line/state_machine.go","position":38,"original_position":38,"commit_id":"9ba155051ec70748c135c4abab5ffbafbade0597","original_commit_id":"614fae20865b8a8508960b8578ba3e47aa987ad3","user":{"login":"dr2chase","id":1928999,"avatar_url":"https://avatars.githubusercontent.com/u/1928999?v=3","gravatar_id":"","url":"https://api.github.com/users/dr2chase","html_url":"https://github.com/dr2chase","followers_url":"https://api.github.com/users/dr2chase/followers","following_url":"https://api.github.com/users/dr2chase/following{/other_user}","gists_url":"https://api.github.com/users/dr2chase/gists{/gist_id}","starred_url":"https://api.github.com/users/dr2chase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr2chase/subscriptions","organizations_url":"https://api.github.com/users/dr2chase/orgs","repos_url":"https://api.github.com/users/dr2chase/repos","events_url":"https://api.github.com/users/dr2chase/events{/privacy}","received_events_url":"https://api.github.com/users/dr2chase/received_events","type":"User","site_admin":false},"body":"I'm doubtful about this change.  I ended up with this, instead:\r\n```\r\n                sm.isStmt = true\r\n        }\r\n \r\n-       sm.lastDelta = int(sm.dbl.Prologue.LineBase + int8(decoded%sm.dbl.Prologue.LineRange))\r\n+       var deltapc uint64\r\n+       var deltaline int\r\n+\r\n+       switch opcode {\r\n+       case 249:\r\n+               deltaline = 5\r\n+               deltapc = 23\r\n+       case 255:\r\n+               deltaline = 1\r\n+               deltapc = 24\r\n+       default:\r\n+               deltaline = int(sm.dbl.Prologue.LineBase + int8(decoded%sm.dbl.Prologue.LineRange))\r\n+               deltapc = uint64(decoded / sm.dbl.Prologue.LineRange)\r\n+       }\r\n+\r\n+       sm.lastDelta = deltaline\r\n        sm.line += sm.lastDelta\r\n-       sm.address += uint64(decoded / sm.dbl.Prologue.LineRange)\r\n+       sm.address += deltapc\r\n        sm.basicBlock = false\r\n        sm.lastWasStandard = false\r\n```\r\nI got this from https://go.googlesource.com/go/+/f9feaffdf51967bc5cf3c9363db9ddee98c9b3a0/src/cmd/link/internal/ld/dwarf.go#918\r\n\r\n```\r\n\t\t} else {\r\n\t\t\t// Use opcode 249 (pc+=23, lc+=5) or 255 (pc+=24, lc+=1).\r\n\t\t\t//\r\n```\r\nand I don't see any way that the change proposed here takes us from a state where the PC increments were not 23 and 24 to one where they are (because 23 and 24 have no common factors other than 1).\r\n","created_at":"2016-11-22T20:42:05Z","updated_at":"2016-11-22T20:42:05Z","html_url":"https://github.com/derekparker/delve/pull/667#discussion_r89205753","pull_request_url":"https://api.github.com/repos/derekparker/delve/pulls/667","_links":{"self":{"href":"https://api.github.com/repos/derekparker/delve/pulls/comments/89205753"},"html":{"href":"https://github.com/derekparker/delve/pull/667#discussion_r89205753"},"pull_request":{"href":"https://api.github.com/repos/derekparker/delve/pulls/667"}}},"pull_request":{"url":"https://api.github.com/repos/derekparker/delve/pulls/667","id":92496049,"html_url":"https://github.com/derekparker/delve/pull/667","diff_url":"https://github.com/derekparker/delve/pull/667.diff","patch_url":"https://github.com/derekparker/delve/pull/667.patch","issue_url":"https://api.github.com/repos/derekparker/delve/issues/667","number":667,"state":"open","locked":false,"title":"Go 1.8 compatibility (part 2)","user":{"login":"aarzilli","id":303620,"avatar_url":"https://avatars.githubusercontent.com/u/303620?v=3","gravatar_id":"","url":"https://api.github.com/users/aarzilli","html_url":"https://github.com/aarzilli","followers_url":"https://api.github.com/users/aarzilli/followers","following_url":"https://api.github.com/users/aarzilli/following{/other_user}","gists_url":"https://api.github.com/users/aarzilli/gists{/gist_id}","starred_url":"https://api.github.com/users/aarzilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarzilli/subscriptions","organizations_url":"https://api.github.com/users/aarzilli/orgs","repos_url":"https://api.github.com/users/aarzilli/repos","events_url":"https://api.github.com/users/aarzilli/events{/privacy}","received_events_url":"https://api.github.com/users/aarzilli/received_events","type":"User","site_admin":false},"body":"Do not commit / Do not review.","created_at":"2016-11-06T17:54:29Z","updated_at":"2016-11-22T20:42:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97d41a3e081b0c374aa2896f9043359459ba3178","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/derekparker/delve/pulls/667/commits","review_comments_url":"https://api.github.com/repos/derekparker/delve/pulls/667/comments","review_comment_url":"https://api.github.com/repos/derekparker/delve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/derekparker/delve/issues/667/comments","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/9ba155051ec70748c135c4abab5ffbafbade0597","head":{"label":"aarzilli:go18p2","ref":"go18p2","sha":"9ba155051ec70748c135c4abab5ffbafbade0597","user":{"login":"aarzilli","id":303620,"avatar_url":"https://avatars.githubusercontent.com/u/303620?v=3","gravatar_id":"","url":"https://api.github.com/users/aarzilli","html_url":"https://github.com/aarzilli","followers_url":"https://api.github.com/users/aarzilli/followers","following_url":"https://api.github.com/users/aarzilli/following{/other_user}","gists_url":"https://api.github.com/users/aarzilli/gists{/gist_id}","starred_url":"https://api.github.com/users/aarzilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarzilli/subscriptions","organizations_url":"https://api.github.com/users/aarzilli/orgs","repos_url":"https://api.github.com/users/aarzilli/repos","events_url":"https://api.github.com/users/aarzilli/events{/privacy}","received_events_url":"https://api.github.com/users/aarzilli/received_events","type":"User","site_admin":false},"repo":{"id":37608792,"name":"delve","full_name":"aarzilli/delve","owner":{"login":"aarzilli","id":303620,"avatar_url":"https://avatars.githubusercontent.com/u/303620?v=3","gravatar_id":"","url":"https://api.github.com/users/aarzilli","html_url":"https://github.com/aarzilli","followers_url":"https://api.github.com/users/aarzilli/followers","following_url":"https://api.github.com/users/aarzilli/following{/other_user}","gists_url":"https://api.github.com/users/aarzilli/gists{/gist_id}","starred_url":"https://api.github.com/users/aarzilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarzilli/subscriptions","organizations_url":"https://api.github.com/users/aarzilli/orgs","repos_url":"https://api.github.com/users/aarzilli/repos","events_url":"https://api.github.com/users/aarzilli/events{/privacy}","received_events_url":"https://api.github.com/users/aarzilli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aarzilli/delve","description":"Delve is a debugger for the Go programming language.","fork":true,"url":"https://api.github.com/repos/aarzilli/delve","forks_url":"https://api.github.com/repos/aarzilli/delve/forks","keys_url":"https://api.github.com/repos/aarzilli/delve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aarzilli/delve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aarzilli/delve/teams","hooks_url":"https://api.github.com/repos/aarzilli/delve/hooks","issue_events_url":"https://api.github.com/repos/aarzilli/delve/issues/events{/number}","events_url":"https://api.github.com/repos/aarzilli/delve/events","assignees_url":"https://api.github.com/repos/aarzilli/delve/assignees{/user}","branches_url":"https://api.github.com/repos/aarzilli/delve/branches{/branch}","tags_url":"https://api.github.com/repos/aarzilli/delve/tags","blobs_url":"https://api.github.com/repos/aarzilli/delve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aarzilli/delve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aarzilli/delve/git/refs{/sha}","trees_url":"https://api.github.com/repos/aarzilli/delve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aarzilli/delve/statuses/{sha}","languages_url":"https://api.github.com/repos/aarzilli/delve/languages","stargazers_url":"https://api.github.com/repos/aarzilli/delve/stargazers","contributors_url":"https://api.github.com/repos/aarzilli/delve/contributors","subscribers_url":"https://api.github.com/repos/aarzilli/delve/subscribers","subscription_url":"https://api.github.com/repos/aarzilli/delve/subscription","commits_url":"https://api.github.com/repos/aarzilli/delve/commits{/sha}","git_commits_url":"https://api.github.com/repos/aarzilli/delve/git/commits{/sha}","comments_url":"https://api.github.com/repos/aarzilli/delve/comments{/number}","issue_comment_url":"https://api.github.com/repos/aarzilli/delve/issues/comments{/number}","contents_url":"https://api.github.com/repos/aarzilli/delve/contents/{+path}","compare_url":"https://api.github.com/repos/aarzilli/delve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aarzilli/delve/merges","archive_url":"https://api.github.com/repos/aarzilli/delve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aarzilli/delve/downloads","issues_url":"https://api.github.com/repos/aarzilli/delve/issues{/number}","pulls_url":"https://api.github.com/repos/aarzilli/delve/pulls{/number}","milestones_url":"https://api.github.com/repos/aarzilli/delve/milestones{/number}","notifications_url":"https://api.github.com/repos/aarzilli/delve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aarzilli/delve/labels{/name}","releases_url":"https://api.github.com/repos/aarzilli/delve/releases{/id}","deployments_url":"https://api.github.com/repos/aarzilli/delve/deployments","created_at":"2015-06-17T17:05:12Z","updated_at":"2016-11-12T11:01:51Z","pushed_at":"2016-11-22T08:22:33Z","git_url":"git://github.com/aarzilli/delve.git","ssh_url":"git@github.com:aarzilli/delve.git","clone_url":"https://github.com/aarzilli/delve.git","svn_url":"https://github.com/aarzilli/delve","homepage":"","size":10973,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"derekparker:master","ref":"master","sha":"6bff4d19706b46b7bd350212048e4a140caad271","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"repo":{"id":19994257,"name":"delve","full_name":"derekparker/delve","owner":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekparker/delve","description":"Delve is a debugger for the Go programming language.","fork":false,"url":"https://api.github.com/repos/derekparker/delve","forks_url":"https://api.github.com/repos/derekparker/delve/forks","keys_url":"https://api.github.com/repos/derekparker/delve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekparker/delve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekparker/delve/teams","hooks_url":"https://api.github.com/repos/derekparker/delve/hooks","issue_events_url":"https://api.github.com/repos/derekparker/delve/issues/events{/number}","events_url":"https://api.github.com/repos/derekparker/delve/events","assignees_url":"https://api.github.com/repos/derekparker/delve/assignees{/user}","branches_url":"https://api.github.com/repos/derekparker/delve/branches{/branch}","tags_url":"https://api.github.com/repos/derekparker/delve/tags","blobs_url":"https://api.github.com/repos/derekparker/delve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekparker/delve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekparker/delve/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekparker/delve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/{sha}","languages_url":"https://api.github.com/repos/derekparker/delve/languages","stargazers_url":"https://api.github.com/repos/derekparker/delve/stargazers","contributors_url":"https://api.github.com/repos/derekparker/delve/contributors","subscribers_url":"https://api.github.com/repos/derekparker/delve/subscribers","subscription_url":"https://api.github.com/repos/derekparker/delve/subscription","commits_url":"https://api.github.com/repos/derekparker/delve/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekparker/delve/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekparker/delve/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekparker/delve/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekparker/delve/contents/{+path}","compare_url":"https://api.github.com/repos/derekparker/delve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekparker/delve/merges","archive_url":"https://api.github.com/repos/derekparker/delve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekparker/delve/downloads","issues_url":"https://api.github.com/repos/derekparker/delve/issues{/number}","pulls_url":"https://api.github.com/repos/derekparker/delve/pulls{/number}","milestones_url":"https://api.github.com/repos/derekparker/delve/milestones{/number}","notifications_url":"https://api.github.com/repos/derekparker/delve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekparker/delve/labels{/name}","releases_url":"https://api.github.com/repos/derekparker/delve/releases{/id}","deployments_url":"https://api.github.com/repos/derekparker/delve/deployments","created_at":"2014-05-20T19:24:43Z","updated_at":"2016-11-22T09:33:21Z","pushed_at":"2016-11-22T08:22:34Z","git_url":"git://github.com/derekparker/delve.git","ssh_url":"git@github.com:derekparker/delve.git","clone_url":"https://github.com/derekparker/delve.git","svn_url":"https://github.com/derekparker/delve","homepage":"","size":12552,"stargazers_count":4579,"watchers_count":4579,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"open_issues_count":84,"forks":327,"open_issues":84,"watchers":4579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/derekparker/delve/pulls/667"},"html":{"href":"https://github.com/derekparker/delve/pull/667"},"issue":{"href":"https://api.github.com/repos/derekparker/delve/issues/667"},"comments":{"href":"https://api.github.com/repos/derekparker/delve/issues/667/comments"},"review_comments":{"href":"https://api.github.com/repos/derekparker/delve/pulls/667/comments"},"review_comment":{"href":"https://api.github.com/repos/derekparker/delve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/derekparker/delve/pulls/667/commits"},"statuses":{"href":"https://api.github.com/repos/derekparker/delve/statuses/9ba155051ec70748c135c4abab5ffbafbade0597"}}}}
{"actor":{"display_login":"dr2chase"}}