{"action":"created","comment":{"url":"https://api.github.com/repos/bikalabs/bika.lims/pulls/comments/49445668","id":49445668,"diff_hunk":"@@ -200,7 +200,12 @@ function CalculationUtils() {\n                         if (result.result_str.indexOf(\".\") > -1){\n                             decimals = result.result_str.split('.')[1].length;\n                         }\n-                        var result_with_decimals = parseFloat(result.result_str).toFixed(decimals)\n+                        if (result.result_str == \"\"){\n+                            var result_with_decimals = \"\"\n+                        };\n+                        else {\n+                            var result_with_decimals = parseFloat(result.result_str).toFixed(decimals)\n+                        };","path":"bika/lims/browser/js/bika.lims.utils.calcs.js","position":10,"original_position":10,"commit_id":"917a4e740922a9778b55c2f8b578157fd83e4884","original_commit_id":"917a4e740922a9778b55c2f8b578157fd83e4884","user":{"login":"xispa","id":832627,"avatar_url":"https://avatars.githubusercontent.com/u/832627?v=3","gravatar_id":"","url":"https://api.github.com/users/xispa","html_url":"https://github.com/xispa","followers_url":"https://api.github.com/users/xispa/followers","following_url":"https://api.github.com/users/xispa/following{/other_user}","gists_url":"https://api.github.com/users/xispa/gists{/gist_id}","starred_url":"https://api.github.com/users/xispa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xispa/subscriptions","organizations_url":"https://api.github.com/users/xispa/orgs","repos_url":"https://api.github.com/users/xispa/repos","events_url":"https://api.github.com/users/xispa/events{/privacy}","received_events_url":"https://api.github.com/users/xispa/received_events","type":"User","site_admin":false},"body":"Syntaxis incoherences, mainly:\r\n```javascript\r\nif (result.result_str == \"\"){\r\n    result_with_decimals = \"\";\r\n} else {\r\n    result_with_decimals = parseFloat(result.result_str).toFixed(decimals);\r\n}\r\n```","created_at":"2016-01-12T12:04:44Z","updated_at":"2016-01-12T12:04:44Z","html_url":"https://github.com/bikalabs/bika.lims/pull/1741#discussion_r49445668","pull_request_url":"https://api.github.com/repos/bikalabs/bika.lims/pulls/1741","_links":{"self":{"href":"https://api.github.com/repos/bikalabs/bika.lims/pulls/comments/49445668"},"html":{"href":"https://github.com/bikalabs/bika.lims/pull/1741#discussion_r49445668"},"pull_request":{"href":"https://api.github.com/repos/bikalabs/bika.lims/pulls/1741"}}},"pull_request":{"url":"https://api.github.com/repos/bikalabs/bika.lims/pulls/1741","id":55746011,"html_url":"https://github.com/bikalabs/bika.lims/pull/1741","diff_url":"https://github.com/bikalabs/bika.lims/pull/1741.diff","patch_url":"https://github.com/bikalabs/bika.lims/pull/1741.patch","issue_url":"https://api.github.com/repos/bikalabs/bika.lims/issues/1741","number":1741,"state":"closed","locked":false,"title":"LIMS-2175 \"NaN\" is shown automatically for result fields that have AS…","user":{"login":"Espurna","id":7425587,"avatar_url":"https://avatars.githubusercontent.com/u/7425587?v=3","gravatar_id":"","url":"https://api.github.com/users/Espurna","html_url":"https://github.com/Espurna","followers_url":"https://api.github.com/users/Espurna/followers","following_url":"https://api.github.com/users/Espurna/following{/other_user}","gists_url":"https://api.github.com/users/Espurna/gists{/gist_id}","starred_url":"https://api.github.com/users/Espurna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Espurna/subscriptions","organizations_url":"https://api.github.com/users/Espurna/orgs","repos_url":"https://api.github.com/users/Espurna/repos","events_url":"https://api.github.com/users/Espurna/events{/privacy}","received_events_url":"https://api.github.com/users/Espurna/received_events","type":"User","site_admin":false},"body":"… with \"LDL\" enabled and then an error is shown after submitting a result\r\n\r\n[JIRA](https://jira.bikalabs.com/browse/LIMS-2175)","created_at":"2016-01-12T11:36:01Z","updated_at":"2016-01-12T12:04:44Z","closed_at":"2016-01-12T12:00:31Z","merged_at":"2016-01-12T12:00:31Z","merge_commit_sha":"d31fe4786a279388e8ec5dfff2be0b6363a19e83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bikalabs/bika.lims/pulls/1741/commits","review_comments_url":"https://api.github.com/repos/bikalabs/bika.lims/pulls/1741/comments","review_comment_url":"https://api.github.com/repos/bikalabs/bika.lims/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bikalabs/bika.lims/issues/1741/comments","statuses_url":"https://api.github.com/repos/bikalabs/bika.lims/statuses/917a4e740922a9778b55c2f8b578157fd83e4884","head":{"label":"labsanmartin:issue/LIMS-2175-nan-analysisrequest-error","ref":"issue/LIMS-2175-nan-analysisrequest-error","sha":"917a4e740922a9778b55c2f8b578157fd83e4884","user":{"login":"labsanmartin","id":9529471,"avatar_url":"https://avatars.githubusercontent.com/u/9529471?v=3","gravatar_id":"","url":"https://api.github.com/users/labsanmartin","html_url":"https://github.com/labsanmartin","followers_url":"https://api.github.com/users/labsanmartin/followers","following_url":"https://api.github.com/users/labsanmartin/following{/other_user}","gists_url":"https://api.github.com/users/labsanmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/labsanmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labsanmartin/subscriptions","organizations_url":"https://api.github.com/users/labsanmartin/orgs","repos_url":"https://api.github.com/users/labsanmartin/repos","events_url":"https://api.github.com/users/labsanmartin/events{/privacy}","received_events_url":"https://api.github.com/users/labsanmartin/received_events","type":"Organization","site_admin":false},"repo":{"id":26114989,"name":"Bika-LIMS","full_name":"labsanmartin/Bika-LIMS","owner":{"login":"labsanmartin","id":9529471,"avatar_url":"https://avatars.githubusercontent.com/u/9529471?v=3","gravatar_id":"","url":"https://api.github.com/users/labsanmartin","html_url":"https://github.com/labsanmartin","followers_url":"https://api.github.com/users/labsanmartin/followers","following_url":"https://api.github.com/users/labsanmartin/following{/other_user}","gists_url":"https://api.github.com/users/labsanmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/labsanmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labsanmartin/subscriptions","organizations_url":"https://api.github.com/users/labsanmartin/orgs","repos_url":"https://api.github.com/users/labsanmartin/repos","events_url":"https://api.github.com/users/labsanmartin/events{/privacy}","received_events_url":"https://api.github.com/users/labsanmartin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labsanmartin/Bika-LIMS","description":"Web-based Laboratory Information Management System","fork":true,"url":"https://api.github.com/repos/labsanmartin/Bika-LIMS","forks_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/forks","keys_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/teams","hooks_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/hooks","issue_events_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/issues/events{/number}","events_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/events","assignees_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/assignees{/user}","branches_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/branches{/branch}","tags_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/tags","blobs_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/statuses/{sha}","languages_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/languages","stargazers_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/stargazers","contributors_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/contributors","subscribers_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/subscribers","subscription_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/subscription","commits_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/contents/{+path}","compare_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/merges","archive_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/downloads","issues_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/issues{/number}","pulls_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/pulls{/number}","milestones_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/milestones{/number}","notifications_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/labels{/name}","releases_url":"https://api.github.com/repos/labsanmartin/Bika-LIMS/releases{/id}","created_at":"2014-11-03T11:05:34Z","updated_at":"2015-05-07T12:46:40Z","pushed_at":"2016-01-12T11:37:10Z","git_url":"git://github.com/labsanmartin/Bika-LIMS.git","ssh_url":"git@github.com:labsanmartin/Bika-LIMS.git","clone_url":"https://github.com/labsanmartin/Bika-LIMS.git","svn_url":"https://github.com/labsanmartin/Bika-LIMS","homepage":"http://www.bikalabs.com/","size":55509,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bikalabs:master","ref":"master","sha":"2a2a029c0ec67fdb792b3b7208f81d108b01e13a","user":{"login":"bikalabs","id":1191551,"avatar_url":"https://avatars.githubusercontent.com/u/1191551?v=3","gravatar_id":"","url":"https://api.github.com/users/bikalabs","html_url":"https://github.com/bikalabs","followers_url":"https://api.github.com/users/bikalabs/followers","following_url":"https://api.github.com/users/bikalabs/following{/other_user}","gists_url":"https://api.github.com/users/bikalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/bikalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bikalabs/subscriptions","organizations_url":"https://api.github.com/users/bikalabs/orgs","repos_url":"https://api.github.com/users/bikalabs/repos","events_url":"https://api.github.com/users/bikalabs/events{/privacy}","received_events_url":"https://api.github.com/users/bikalabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2766100,"name":"bika.lims","full_name":"bikalabs/bika.lims","owner":{"login":"bikalabs","id":1191551,"avatar_url":"https://avatars.githubusercontent.com/u/1191551?v=3","gravatar_id":"","url":"https://api.github.com/users/bikalabs","html_url":"https://github.com/bikalabs","followers_url":"https://api.github.com/users/bikalabs/followers","following_url":"https://api.github.com/users/bikalabs/following{/other_user}","gists_url":"https://api.github.com/users/bikalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/bikalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bikalabs/subscriptions","organizations_url":"https://api.github.com/users/bikalabs/orgs","repos_url":"https://api.github.com/users/bikalabs/repos","events_url":"https://api.github.com/users/bikalabs/events{/privacy}","received_events_url":"https://api.github.com/users/bikalabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bikalabs/bika.lims","description":"Open Source Web-based Laboratory Information Management System","fork":false,"url":"https://api.github.com/repos/bikalabs/bika.lims","forks_url":"https://api.github.com/repos/bikalabs/bika.lims/forks","keys_url":"https://api.github.com/repos/bikalabs/bika.lims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bikalabs/bika.lims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bikalabs/bika.lims/teams","hooks_url":"https://api.github.com/repos/bikalabs/bika.lims/hooks","issue_events_url":"https://api.github.com/repos/bikalabs/bika.lims/issues/events{/number}","events_url":"https://api.github.com/repos/bikalabs/bika.lims/events","assignees_url":"https://api.github.com/repos/bikalabs/bika.lims/assignees{/user}","branches_url":"https://api.github.com/repos/bikalabs/bika.lims/branches{/branch}","tags_url":"https://api.github.com/repos/bikalabs/bika.lims/tags","blobs_url":"https://api.github.com/repos/bikalabs/bika.lims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bikalabs/bika.lims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bikalabs/bika.lims/git/refs{/sha}","trees_url":"https://api.github.com/repos/bikalabs/bika.lims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bikalabs/bika.lims/statuses/{sha}","languages_url":"https://api.github.com/repos/bikalabs/bika.lims/languages","stargazers_url":"https://api.github.com/repos/bikalabs/bika.lims/stargazers","contributors_url":"https://api.github.com/repos/bikalabs/bika.lims/contributors","subscribers_url":"https://api.github.com/repos/bikalabs/bika.lims/subscribers","subscription_url":"https://api.github.com/repos/bikalabs/bika.lims/subscription","commits_url":"https://api.github.com/repos/bikalabs/bika.lims/commits{/sha}","git_commits_url":"https://api.github.com/repos/bikalabs/bika.lims/git/commits{/sha}","comments_url":"https://api.github.com/repos/bikalabs/bika.lims/comments{/number}","issue_comment_url":"https://api.github.com/repos/bikalabs/bika.lims/issues/comments{/number}","contents_url":"https://api.github.com/repos/bikalabs/bika.lims/contents/{+path}","compare_url":"https://api.github.com/repos/bikalabs/bika.lims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bikalabs/bika.lims/merges","archive_url":"https://api.github.com/repos/bikalabs/bika.lims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bikalabs/bika.lims/downloads","issues_url":"https://api.github.com/repos/bikalabs/bika.lims/issues{/number}","pulls_url":"https://api.github.com/repos/bikalabs/bika.lims/pulls{/number}","milestones_url":"https://api.github.com/repos/bikalabs/bika.lims/milestones{/number}","notifications_url":"https://api.github.com/repos/bikalabs/bika.lims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bikalabs/bika.lims/labels{/name}","releases_url":"https://api.github.com/repos/bikalabs/bika.lims/releases{/id}","created_at":"2011-11-13T11:41:06Z","updated_at":"2016-01-02T06:01:44Z","pushed_at":"2016-01-12T12:00:32Z","git_url":"git://github.com/bikalabs/bika.lims.git","ssh_url":"git@github.com:bikalabs/bika.lims.git","clone_url":"https://github.com/bikalabs/bika.lims.git","svn_url":"https://github.com/bikalabs/bika.lims","homepage":"http://www.bikalims.org","size":58342,"stargazers_count":76,"watchers_count":76,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":103,"forks":102,"open_issues":103,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bikalabs/bika.lims/pulls/1741"},"html":{"href":"https://github.com/bikalabs/bika.lims/pull/1741"},"issue":{"href":"https://api.github.com/repos/bikalabs/bika.lims/issues/1741"},"comments":{"href":"https://api.github.com/repos/bikalabs/bika.lims/issues/1741/comments"},"review_comments":{"href":"https://api.github.com/repos/bikalabs/bika.lims/pulls/1741/comments"},"review_comment":{"href":"https://api.github.com/repos/bikalabs/bika.lims/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bikalabs/bika.lims/pulls/1741/commits"},"statuses":{"href":"https://api.github.com/repos/bikalabs/bika.lims/statuses/917a4e740922a9778b55c2f8b578157fd83e4884"}}}}