{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/54466432","id":54466432,"diff_hunk":"@@ -86,10 +86,12 @@ ifneq ($(DEBUG_LEVEL), 2)\n OPT += -O2 -fno-omit-frame-pointer\n ifeq (,$(findstring ppc64,$(MACHINE))) # ppc64[le] doesn't support -momit-leaf-frame-pointer\n ifneq ($(MACHINE),armv7l)\n+ifneq ($(MACHINE),s390x)","path":"Makefile","position":null,"original_position":4,"commit_id":"990509045f450baa2e523eb4bd00b4b5302e54d4","original_commit_id":"21f17aaa60deb3c77e487f079621a6993efddd60","user":{"login":"gongsu832","id":15215715,"avatar_url":"https://avatars.githubusercontent.com/u/15215715?v=3","gravatar_id":"","url":"https://api.github.com/users/gongsu832","html_url":"https://github.com/gongsu832","followers_url":"https://api.github.com/users/gongsu832/followers","following_url":"https://api.github.com/users/gongsu832/following{/other_user}","gists_url":"https://api.github.com/users/gongsu832/gists{/gist_id}","starred_url":"https://api.github.com/users/gongsu832/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gongsu832/subscriptions","organizations_url":"https://api.github.com/users/gongsu832/orgs","repos_url":"https://api.github.com/users/gongsu832/repos","events_url":"https://api.github.com/users/gongsu832/events{/privacy}","received_events_url":"https://api.github.com/users/gongsu832/received_events","type":"User","site_admin":false},"body":"Thanks. I just rebased. The build_tools/build_detect_platform file still\nneeds to be patched. I'll submit another pull request.\n\nOn Mon, Feb 29, 2016 at 2:07 PM, Igor Canadi <notifications@github.com>\nwrote:\n\n> In Makefile\n> <https://github.com/facebook/rocksdb/pull/1020#discussion_r54459758>:\n>\n> > @@ -86,10 +86,12 @@ ifneq ($(DEBUG_LEVEL), 2)\n> >  OPT += -O2 -fno-omit-frame-pointer\n> >  ifeq (,$(findstring ppc64,$(MACHINE))) # ppc64[le] doesn't support -momit-leaf-frame-pointer\n> >  ifneq ($(MACHINE),armv7l)\n> > +ifneq ($(MACHINE),s390x)\n>\n> this should be fixed with #1019\n> <https://github.com/facebook/rocksdb/pull/1019>. can you rebase?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/facebook/rocksdb/pull/1020/files#r54459758>.\n>\n","created_at":"2016-02-29T19:50:26Z","updated_at":"2016-02-29T19:50:26Z","html_url":"https://github.com/facebook/rocksdb/pull/1020#discussion_r54466432","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1020","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/54466432"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1020#discussion_r54466432"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1020"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/1020","id":61126854,"html_url":"https://github.com/facebook/rocksdb/pull/1020","diff_url":"https://github.com/facebook/rocksdb/pull/1020.diff","patch_url":"https://github.com/facebook/rocksdb/pull/1020.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/1020","number":1020,"state":"open","locked":false,"title":"Modified Makefile and build_tools/build_detect_platform to compile on…","user":{"login":"gongsu832","id":15215715,"avatar_url":"https://avatars.githubusercontent.com/u/15215715?v=3","gravatar_id":"","url":"https://api.github.com/users/gongsu832","html_url":"https://github.com/gongsu832","followers_url":"https://api.github.com/users/gongsu832/followers","following_url":"https://api.github.com/users/gongsu832/following{/other_user}","gists_url":"https://api.github.com/users/gongsu832/gists{/gist_id}","starred_url":"https://api.github.com/users/gongsu832/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gongsu832/subscriptions","organizations_url":"https://api.github.com/users/gongsu832/orgs","repos_url":"https://api.github.com/users/gongsu832/repos","events_url":"https://api.github.com/users/gongsu832/events{/privacy}","received_events_url":"https://api.github.com/users/gongsu832/received_events","type":"User","site_admin":false},"body":"I made two small changes so that it could compile on Linux s390x (IBM's mainframe) out of the box. I'm wondering if it can be merged into the base code so that I don't have to maintain a separate fork. Thanks.","created_at":"2016-02-29T19:04:14Z","updated_at":"2016-02-29T19:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"614d18e2cc0e84790e6490cc037628b530d19750","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1020/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1020/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/1020/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/990509045f450baa2e523eb4bd00b4b5302e54d4","head":{"label":"gongsu832:master","ref":"master","sha":"990509045f450baa2e523eb4bd00b4b5302e54d4","user":{"login":"gongsu832","id":15215715,"avatar_url":"https://avatars.githubusercontent.com/u/15215715?v=3","gravatar_id":"","url":"https://api.github.com/users/gongsu832","html_url":"https://github.com/gongsu832","followers_url":"https://api.github.com/users/gongsu832/followers","following_url":"https://api.github.com/users/gongsu832/following{/other_user}","gists_url":"https://api.github.com/users/gongsu832/gists{/gist_id}","starred_url":"https://api.github.com/users/gongsu832/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gongsu832/subscriptions","organizations_url":"https://api.github.com/users/gongsu832/orgs","repos_url":"https://api.github.com/users/gongsu832/repos","events_url":"https://api.github.com/users/gongsu832/events{/privacy}","received_events_url":"https://api.github.com/users/gongsu832/received_events","type":"User","site_admin":false},"repo":{"id":52636457,"name":"rocksdb","full_name":"gongsu832/rocksdb","owner":{"login":"gongsu832","id":15215715,"avatar_url":"https://avatars.githubusercontent.com/u/15215715?v=3","gravatar_id":"","url":"https://api.github.com/users/gongsu832","html_url":"https://github.com/gongsu832","followers_url":"https://api.github.com/users/gongsu832/followers","following_url":"https://api.github.com/users/gongsu832/following{/other_user}","gists_url":"https://api.github.com/users/gongsu832/gists{/gist_id}","starred_url":"https://api.github.com/users/gongsu832/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gongsu832/subscriptions","organizations_url":"https://api.github.com/users/gongsu832/orgs","repos_url":"https://api.github.com/users/gongsu832/repos","events_url":"https://api.github.com/users/gongsu832/events{/privacy}","received_events_url":"https://api.github.com/users/gongsu832/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gongsu832/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/gongsu832/rocksdb","forks_url":"https://api.github.com/repos/gongsu832/rocksdb/forks","keys_url":"https://api.github.com/repos/gongsu832/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gongsu832/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gongsu832/rocksdb/teams","hooks_url":"https://api.github.com/repos/gongsu832/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/gongsu832/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/gongsu832/rocksdb/events","assignees_url":"https://api.github.com/repos/gongsu832/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/gongsu832/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/gongsu832/rocksdb/tags","blobs_url":"https://api.github.com/repos/gongsu832/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gongsu832/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gongsu832/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/gongsu832/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gongsu832/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/gongsu832/rocksdb/languages","stargazers_url":"https://api.github.com/repos/gongsu832/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/gongsu832/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/gongsu832/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/gongsu832/rocksdb/subscription","commits_url":"https://api.github.com/repos/gongsu832/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/gongsu832/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/gongsu832/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/gongsu832/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/gongsu832/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/gongsu832/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gongsu832/rocksdb/merges","archive_url":"https://api.github.com/repos/gongsu832/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gongsu832/rocksdb/downloads","issues_url":"https://api.github.com/repos/gongsu832/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/gongsu832/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/gongsu832/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/gongsu832/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gongsu832/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/gongsu832/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/gongsu832/rocksdb/deployments","created_at":"2016-02-26T22:17:27Z","updated_at":"2016-02-26T22:17:30Z","pushed_at":"2016-02-29T19:47:16Z","git_url":"git://github.com/gongsu832/rocksdb.git","ssh_url":"git@github.com:gongsu832/rocksdb.git","clone_url":"https://github.com/gongsu832/rocksdb.git","svn_url":"https://github.com/gongsu832/rocksdb","homepage":"http://rocksdb.org","size":88881,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"3492889ab858ff25aa6d12aac3a08200366a50e2","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2016-02-29T14:36:36Z","pushed_at":"2016-02-29T19:47:17Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":90164,"stargazers_count":4872,"watchers_count":4872,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":962,"mirror_url":null,"open_issues_count":194,"forks":962,"open_issues":194,"watchers":4872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1020"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1020"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1020"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1020/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1020/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1020/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/990509045f450baa2e523eb4bd00b4b5302e54d4"}}}}