{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/71820104","id":71820104,"diff_hunk":"@@ -277,6 +277,41 @@ message UpdateConfig {\n \n \t// Amount of time between updates.\n \tDuration delay = 2 [(gogoproto.nullable) = false];\n+\n+\tenum OnFailure {\n+\t\tPAUSE = 0;\n+\t\tCONTINUE = 1;\n+\t\t// TODO(aaronl): Add ROLLBACK as a supported failure mode.\n+\t\t// (#486)\n+\t}\n+\n+\t// OnFailure is the action to take when an update failures. Currently,\n+\t// a failure is defined as a single updated task failing to reach the\n+\t// RUNNING state. In the future, there will be configuration to define\n+\t// what is treated as a failure (see #486 for a proposal).\n+\tOnFailure on_failure = 3;\n+}\n+\n+// UpdateStatus is the status of an update in progress.\n+message UpdateStatus {\n+\tenum UpdateState {\n+\t\tNEW = 0;\n+\t\tRUNNING = 1;","path":"api/types.proto","position":23,"original_position":23,"commit_id":"ade92c98a9729983856b15327850b3f324a65eec","original_commit_id":"ade92c98a9729983856b15327850b3f324a65eec","user":{"login":"dongluochen","id":14985073,"avatar_url":"https://avatars.githubusercontent.com/u/14985073?v=3","gravatar_id":"","url":"https://api.github.com/users/dongluochen","html_url":"https://github.com/dongluochen","followers_url":"https://api.github.com/users/dongluochen/followers","following_url":"https://api.github.com/users/dongluochen/following{/other_user}","gists_url":"https://api.github.com/users/dongluochen/gists{/gist_id}","starred_url":"https://api.github.com/users/dongluochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongluochen/subscriptions","organizations_url":"https://api.github.com/users/dongluochen/orgs","repos_url":"https://api.github.com/users/dongluochen/repos","events_url":"https://api.github.com/users/dongluochen/events{/privacy}","received_events_url":"https://api.github.com/users/dongluochen/received_events","type":"User","site_admin":false},"body":"How about `INPROGRESS` instead of `RUNNING`?  ","created_at":"2016-07-22T02:48:41Z","updated_at":"2016-07-22T02:48:41Z","html_url":"https://github.com/docker/swarmkit/pull/1204#discussion_r71820104","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/1204","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/71820104"},"html":{"href":"https://github.com/docker/swarmkit/pull/1204#discussion_r71820104"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1204"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/1204","id":78372717,"html_url":"https://github.com/docker/swarmkit/pull/1204","diff_url":"https://github.com/docker/swarmkit/pull/1204.diff","patch_url":"https://github.com/docker/swarmkit/pull/1204.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/1204","number":1204,"state":"open","locked":false,"title":"Option for rolling updates not to proceed on failure","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"body":"Add an enum to UpdateConfig that controls whether the update proceeds or pauses on a failure. This will be extended to support additional settings and modes in the future, such as failure thresholds and automatic rollback.\r\n\r\nAdd UpdateStatus to the Service object. This contains the state that keeps track of whether the update is running, finished, or paused. It also contains a human-readable message about the update status.\r\n\r\nChange the updater to pause the update if OnFailure is set to pause, and a task started by the updater stops running or fails to start while the update is happening.\r\n\r\nUpdate swarmctl to support a new option to control the action on update failure, and to print out the update state in \"service inspect\".\r\n\r\nAdd an updater test covering both modes.","created_at":"2016-07-21T19:24:42Z","updated_at":"2016-07-22T02:48:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"114e820fbc7221c546dab44ebcc66c6d45cff753","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/1204/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/1204/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/1204/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/ade92c98a9729983856b15327850b3f324a65eec","head":{"label":"aaronlehmann:rolling-updates","ref":"rolling-updates","sha":"ade92c98a9729983856b15327850b3f324a65eec","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"repo":{"id":61081831,"name":"swarmkit","full_name":"aaronlehmann/swarmkit","owner":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaronlehmann/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit","forks_url":"https://api.github.com/repos/aaronlehmann/swarmkit/forks","keys_url":"https://api.github.com/repos/aaronlehmann/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronlehmann/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronlehmann/swarmkit/teams","hooks_url":"https://api.github.com/repos/aaronlehmann/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/aaronlehmann/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/aaronlehmann/swarmkit/events","assignees_url":"https://api.github.com/repos/aaronlehmann/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/aaronlehmann/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/aaronlehmann/swarmkit/tags","blobs_url":"https://api.github.com/repos/aaronlehmann/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronlehmann/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronlehmann/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronlehmann/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronlehmann/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronlehmann/swarmkit/languages","stargazers_url":"https://api.github.com/repos/aaronlehmann/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/aaronlehmann/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/aaronlehmann/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/aaronlehmann/swarmkit/subscription","commits_url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronlehmann/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronlehmann/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronlehmann/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronlehmann/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/aaronlehmann/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronlehmann/swarmkit/merges","archive_url":"https://api.github.com/repos/aaronlehmann/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronlehmann/swarmkit/downloads","issues_url":"https://api.github.com/repos/aaronlehmann/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/aaronlehmann/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronlehmann/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronlehmann/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronlehmann/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/aaronlehmann/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/aaronlehmann/swarmkit/deployments","created_at":"2016-06-14T01:29:55Z","updated_at":"2016-06-14T01:29:56Z","pushed_at":"2016-07-22T02:45:16Z","git_url":"git://github.com/aaronlehmann/swarmkit.git","ssh_url":"git@github.com:aaronlehmann/swarmkit.git","clone_url":"https://github.com/aaronlehmann/swarmkit.git","svn_url":"https://github.com/aaronlehmann/swarmkit","homepage":"","size":8434,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"b3d7a486a8fa6495281e6daf8b89eaeca29bdc66","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"name":"swarmkit","full_name":"docker/swarmkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2016-07-22T01:21:16Z","pushed_at":"2016-07-22T02:45:16Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":18425,"stargazers_count":830,"watchers_count":830,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":133,"mirror_url":null,"open_issues_count":153,"forks":133,"open_issues":153,"watchers":830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1204"},"html":{"href":"https://github.com/docker/swarmkit/pull/1204"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1204"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1204/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1204/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1204/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/ade92c98a9729983856b15327850b3f324a65eec"}}}}
{"actor":{"display_login":"dongluochen"}}