{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/52141863","id":52141863,"diff_hunk":"@@ -75,12 +100,23 @@ MeshComponentMap::MeshComponentMap(\n                 // mesh items are ordered first by node, cell, ....\n                 for (std::size_t j=0; j<mesh_subset.getNNodes(); j++)\n                 {\n-                    const GlobalIndexType global_id = static_cast<GlobalIndexType>(global_index_offset\n+                    GlobalIndexType global_id = static_cast<GlobalIndexType>(global_index_offset\n                                                           + mesh.getGlobalNodeID(j) );\n-                    const GlobalIndexType signed_global_id = mesh.isGhostNode( mesh.getNode(j)->getID() )\n-                                                    ? -global_id : global_id;\n+                    const bool is_ghost = mesh.isGhostNode( mesh.getNode(j)->getID() );\n+                    if (is_ghost)\n+                    {\n+                        _ghosts_indices.push_back(global_id);\n+                        global_id = -global_id;\n+                        // If the ghost entry has an index of 0,\n+                        // its index is set to the negative value of unknowns.\n+                        if (global_id == 0)\n+                             global_id = -num_unknowns;","path":"AssemblerLib/MeshComponentMap.cpp","position":83,"original_position":83,"commit_id":"bf1f9dd219f08da2976ea39df83e4c2ef2c49cdf","original_commit_id":"bf1f9dd219f08da2976ea39df83e4c2ef2c49cdf","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"body":"Must the `_ghost_indices` entry be altered then, too?","created_at":"2016-02-08T08:30:30Z","updated_at":"2016-02-08T08:30:30Z","html_url":"https://github.com/ufz/ogs/pull/1006#discussion_r52141863","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1006","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/52141863"},"html":{"href":"https://github.com/ufz/ogs/pull/1006#discussion_r52141863"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1006"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1006","id":57659600,"html_url":"https://github.com/ufz/ogs/pull/1006","diff_url":"https://github.com/ufz/ogs/pull/1006.diff","patch_url":"https://github.com/ufz/ogs/pull/1006.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1006","number":1006,"state":"open","locked":false,"title":"Improvement in the usage of PETSc matrix and vector","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"body":"- Create vector with ghost entries\r\n\r\n     To save memory when the solution is fetched.\r\n- Use local size to create vector and matrix\r\n\r\n    To improve the computational and communication load balance in the global assembly and the linear solver.\r\n\r\n(c.f. issue #965)","created_at":"2016-01-29T15:16:58Z","updated_at":"2016-02-08T08:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edf76cd9d6097cb9e9303c6b0a431a49970025e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1006/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1006/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1006/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/bf1f9dd219f08da2976ea39df83e4c2ef2c49cdf","head":{"label":"wenqing:create_ghost_vector","ref":"create_ghost_vector","sha":"bf1f9dd219f08da2976ea39df83e4c2ef2c49cdf","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"repo":{"id":12785911,"name":"ogs","full_name":"wenqing/ogs","owner":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wenqing/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/wenqing/ogs","forks_url":"https://api.github.com/repos/wenqing/ogs/forks","keys_url":"https://api.github.com/repos/wenqing/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wenqing/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wenqing/ogs/teams","hooks_url":"https://api.github.com/repos/wenqing/ogs/hooks","issue_events_url":"https://api.github.com/repos/wenqing/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/wenqing/ogs/events","assignees_url":"https://api.github.com/repos/wenqing/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/wenqing/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/wenqing/ogs/tags","blobs_url":"https://api.github.com/repos/wenqing/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wenqing/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wenqing/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wenqing/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wenqing/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/wenqing/ogs/languages","stargazers_url":"https://api.github.com/repos/wenqing/ogs/stargazers","contributors_url":"https://api.github.com/repos/wenqing/ogs/contributors","subscribers_url":"https://api.github.com/repos/wenqing/ogs/subscribers","subscription_url":"https://api.github.com/repos/wenqing/ogs/subscription","commits_url":"https://api.github.com/repos/wenqing/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wenqing/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wenqing/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wenqing/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/wenqing/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/wenqing/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wenqing/ogs/merges","archive_url":"https://api.github.com/repos/wenqing/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wenqing/ogs/downloads","issues_url":"https://api.github.com/repos/wenqing/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/wenqing/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/wenqing/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/wenqing/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wenqing/ogs/labels{/name}","releases_url":"https://api.github.com/repos/wenqing/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/wenqing/ogs/deployments","created_at":"2013-09-12T14:33:21Z","updated_at":"2015-02-25T13:44:13Z","pushed_at":"2016-02-03T16:50:11Z","git_url":"git://github.com/wenqing/ogs.git","ssh_url":"git@github.com:wenqing/ogs.git","clone_url":"https://github.com/wenqing/ogs.git","svn_url":"https://github.com/wenqing/ogs","homepage":"www.opengeosys.org","size":11414,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"87690b260d5f59d97d9d7800452bdf10afb762b9","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2015-10-23T03:43:52Z","pushed_at":"2016-02-05T17:05:59Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":12421,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":89,"forks":39,"open_issues":89,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1006"},"html":{"href":"https://github.com/ufz/ogs/pull/1006"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1006"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1006/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1006/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1006/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/bf1f9dd219f08da2976ea39df83e4c2ef2c49cdf"}}}}