{"action":"created","comment":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments/63064510","id":63064510,"diff_hunk":"@@ -176,7 +176,7 @@ class DateField extends React.Component {\n     }\n \n     let errorComponent;\n-    if (error) {\n+    if (errorMessage) {","path":"gulp/src/common/ui/DateField.jsx","position":null,"original_position":5,"commit_id":"ce6555b6857e52e60ed81c28d6d9f193800e84bc","original_commit_id":"ce6555b6857e52e60ed81c28d6d9f193800e84bc","user":{"login":"lemniscate613","id":15107331,"avatar_url":"https://avatars.githubusercontent.com/u/15107331?v=3","gravatar_id":"","url":"https://api.github.com/users/lemniscate613","html_url":"https://github.com/lemniscate613","followers_url":"https://api.github.com/users/lemniscate613/followers","following_url":"https://api.github.com/users/lemniscate613/following{/other_user}","gists_url":"https://api.github.com/users/lemniscate613/gists{/gist_id}","starred_url":"https://api.github.com/users/lemniscate613/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemniscate613/subscriptions","organizations_url":"https://api.github.com/users/lemniscate613/orgs","repos_url":"https://api.github.com/users/lemniscate613/repos","events_url":"https://api.github.com/users/lemniscate613/events{/privacy}","received_events_url":"https://api.github.com/users/lemniscate613/received_events","type":"User","site_admin":false},"body":"For example, within this component we are checking that the date is valid (MM/DD/YYYY). Reporting code which uses the `DateField` component has other validation to confirm one ending date is *after* another beginning date.","created_at":"2016-05-12T17:43:45Z","updated_at":"2016-05-12T17:43:45Z","html_url":"https://github.com/DirectEmployers/MyJobs/pull/2311#discussion_r63064510","pull_request_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2311","_links":{"self":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments/63064510"},"html":{"href":"https://github.com/DirectEmployers/MyJobs/pull/2311#discussion_r63064510"},"pull_request":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2311"}}},"pull_request":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2311","id":69860367,"html_url":"https://github.com/DirectEmployers/MyJobs/pull/2311","diff_url":"https://github.com/DirectEmployers/MyJobs/pull/2311.diff","patch_url":"https://github.com/DirectEmployers/MyJobs/pull/2311.patch","issue_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/2311","number":2311,"state":"open","locked":false,"title":"[PD-2294] Improve DateField component; add to Reporting","user":{"login":"lemniscate613","id":15107331,"avatar_url":"https://avatars.githubusercontent.com/u/15107331?v=3","gravatar_id":"","url":"https://api.github.com/users/lemniscate613","html_url":"https://github.com/lemniscate613","followers_url":"https://api.github.com/users/lemniscate613/followers","following_url":"https://api.github.com/users/lemniscate613/following{/other_user}","gists_url":"https://api.github.com/users/lemniscate613/gists{/gist_id}","starred_url":"https://api.github.com/users/lemniscate613/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemniscate613/subscriptions","organizations_url":"https://api.github.com/users/lemniscate613/orgs","repos_url":"https://api.github.com/users/lemniscate613/repos","events_url":"https://api.github.com/users/lemniscate613/events{/privacy}","received_events_url":"https://api.github.com/users/lemniscate613/received_events","type":"User","site_admin":false},"body":"# This PR:\r\n\r\n* adds DateField to reporting\r\n* enables the DateField to display errors as props from above ( https://github.com/DirectEmployers/MyJobs/pull/2311/files#diff-c5b207334a4c11ac32df04a2b0ba657cR177 ) which enables validation like...\r\n* adds a new validation to confirm end date is after begin date ( https://github.com/DirectEmployers/MyJobs/pull/2311/files#diff-d50ed71fb5078e252db0450db9459aedR54 ).\r\n\r\n# Future\r\n\r\nI'll create another ticket to update export so it takes this date range into account.\r\n\r\nI *can* create another ticket to improve the implementation of this component, if that's important. For example, enable free-text editing (and not just selecting the date fromt he popup).\r\n\r\n# Old\r\n![screen shot 2016-05-12 at 11 44 32 am](https://cloud.githubusercontent.com/assets/15107331/15220855/0ec8c644-1837-11e6-9f33-4eee79f49080.png)\r\n\r\nWhich opens:\r\n\r\n![screen shot 2016-05-12 at 11 44 38 am](https://cloud.githubusercontent.com/assets/15107331/15220862/11cf70d6-1837-11e6-80a0-12d189ca1f7d.png)\r\n\r\n\r\n# New\r\n![screen shot 2016-05-12 at 11 44 48 am](https://cloud.githubusercontent.com/assets/15107331/15220867/1449f066-1837-11e6-83cb-8740910938f1.png)\r\n\r\nWhich opens:\r\n\r\n![screen shot 2016-05-12 at 11 44 52 am](https://cloud.githubusercontent.com/assets/15107331/15220873/1736031e-1837-11e6-93a0-b1de0e4d76d9.png)\r\n","created_at":"2016-05-12T15:46:15Z","updated_at":"2016-05-12T17:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82cba85571e21950ab3e8c33d935e2f6cd5de2fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2311/commits","review_comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2311/comments","review_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/2311/comments","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/ce6555b6857e52e60ed81c28d6d9f193800e84bc","head":{"label":"DirectEmployers:2294_date_field_in_reporting","ref":"2294_date_field_in_reporting","sha":"ce6555b6857e52e60ed81c28d6d9f193800e84bc","user":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"repo":{"id":2867982,"name":"MyJobs","full_name":"DirectEmployers/MyJobs","owner":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DirectEmployers/MyJobs","description":"Multi-user website designed to assist job seekers in their search for employment","fork":false,"url":"https://api.github.com/repos/DirectEmployers/MyJobs","forks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/forks","keys_url":"https://api.github.com/repos/DirectEmployers/MyJobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectEmployers/MyJobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectEmployers/MyJobs/teams","hooks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/hooks","issue_events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/events{/number}","events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/events","assignees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/assignees{/user}","branches_url":"https://api.github.com/repos/DirectEmployers/MyJobs/branches{/branch}","tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/tags","blobs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectEmployers/MyJobs/languages","stargazers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/stargazers","contributors_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contributors","subscribers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscribers","subscription_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscription","commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contents/{+path}","compare_url":"https://api.github.com/repos/DirectEmployers/MyJobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectEmployers/MyJobs/merges","archive_url":"https://api.github.com/repos/DirectEmployers/MyJobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectEmployers/MyJobs/downloads","issues_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues{/number}","pulls_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectEmployers/MyJobs/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectEmployers/MyJobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectEmployers/MyJobs/labels{/name}","releases_url":"https://api.github.com/repos/DirectEmployers/MyJobs/releases{/id}","deployments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/deployments","created_at":"2011-11-28T15:22:36Z","updated_at":"2016-04-05T20:47:26Z","pushed_at":"2016-05-12T17:37:39Z","git_url":"git://github.com/DirectEmployers/MyJobs.git","ssh_url":"git@github.com:DirectEmployers/MyJobs.git","clone_url":"https://github.com/DirectEmployers/MyJobs.git","svn_url":"https://github.com/DirectEmployers/MyJobs","homepage":"http://my.jobs","size":32702,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":8,"default_branch":"quality-control"}},"base":{"label":"DirectEmployers:quality-control","ref":"quality-control","sha":"ec55f9e6b63f7ff2d01efd45fdc636477acf230d","user":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"repo":{"id":2867982,"name":"MyJobs","full_name":"DirectEmployers/MyJobs","owner":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DirectEmployers/MyJobs","description":"Multi-user website designed to assist job seekers in their search for employment","fork":false,"url":"https://api.github.com/repos/DirectEmployers/MyJobs","forks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/forks","keys_url":"https://api.github.com/repos/DirectEmployers/MyJobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectEmployers/MyJobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectEmployers/MyJobs/teams","hooks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/hooks","issue_events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/events{/number}","events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/events","assignees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/assignees{/user}","branches_url":"https://api.github.com/repos/DirectEmployers/MyJobs/branches{/branch}","tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/tags","blobs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectEmployers/MyJobs/languages","stargazers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/stargazers","contributors_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contributors","subscribers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscribers","subscription_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscription","commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contents/{+path}","compare_url":"https://api.github.com/repos/DirectEmployers/MyJobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectEmployers/MyJobs/merges","archive_url":"https://api.github.com/repos/DirectEmployers/MyJobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectEmployers/MyJobs/downloads","issues_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues{/number}","pulls_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectEmployers/MyJobs/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectEmployers/MyJobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectEmployers/MyJobs/labels{/name}","releases_url":"https://api.github.com/repos/DirectEmployers/MyJobs/releases{/id}","deployments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/deployments","created_at":"2011-11-28T15:22:36Z","updated_at":"2016-04-05T20:47:26Z","pushed_at":"2016-05-12T17:37:39Z","git_url":"git://github.com/DirectEmployers/MyJobs.git","ssh_url":"git@github.com:DirectEmployers/MyJobs.git","clone_url":"https://github.com/DirectEmployers/MyJobs.git","svn_url":"https://github.com/DirectEmployers/MyJobs","homepage":"http://my.jobs","size":32702,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":8,"default_branch":"quality-control"}},"_links":{"self":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2311"},"html":{"href":"https://github.com/DirectEmployers/MyJobs/pull/2311"},"issue":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/2311"},"comments":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/2311/comments"},"review_comments":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2311/comments"},"review_comment":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2311/commits"},"statuses":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/ce6555b6857e52e60ed81c28d6d9f193800e84bc"}}}}