{"action":"created","issue":{"url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/108","repository_url":"https://api.github.com/repos/weppos/publicsuffix-ruby","labels_url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/108/comments","events_url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/108/events","html_url":"https://github.com/weppos/publicsuffix-ruby/pull/108","id":160460189,"number":108,"title":"Introduce List.default_rule getter/setter, update 2.0 upgrade docs","user":{"login":"trevorturk","id":402,"avatar_url":"https://avatars.githubusercontent.com/u/402?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorturk","html_url":"https://github.com/trevorturk","followers_url":"https://api.github.com/users/trevorturk/followers","following_url":"https://api.github.com/users/trevorturk/following{/other_user}","gists_url":"https://api.github.com/users/trevorturk/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorturk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorturk/subscriptions","organizations_url":"https://api.github.com/users/trevorturk/orgs","repos_url":"https://api.github.com/users/trevorturk/repos","events_url":"https://api.github.com/users/trevorturk/events{/privacy}","received_events_url":"https://api.github.com/users/trevorturk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-06-15T16:02:14Z","updated_at":"2016-06-15T16:43:18Z","closed_at":"2016-06-15T16:43:18Z","pull_request":{"url":"https://api.github.com/repos/weppos/publicsuffix-ruby/pulls/108","html_url":"https://github.com/weppos/publicsuffix-ruby/pull/108","diff_url":"https://github.com/weppos/publicsuffix-ruby/pull/108.diff","patch_url":"https://github.com/weppos/publicsuffix-ruby/pull/108.patch"},"body":"First of all, thank you for this library, and apologies for this difficult-to-read pull request 😁 \r\n\r\nThis is a first attempt to introduce a new setting that would allow users of the library to carry on using the 1.x style behavior if needed. I found myself doing this:\r\n\r\n```ruby\r\nmodule PublicSuffix\r\n  class List\r\n    def default_rule\r\n      nil\r\n    end\r\n  end\r\nend\r\n```\r\n\r\n...and thought it worth checking in to see if you'd accept something along the lines of what I propose. \r\n\r\nThis PR also changes the 2.0 upgrade documentation to be more clear about the breaking changes, and to provide more examples of how to maintain the preexisting 1.x behavior. It took me a while to understand what had changed between 1.x and 2.x, so I'm hoping to pass along my learnings to others. \r\n\r\nPlease view the proposed `2.0-Upgrade.md` on its own, as opposed to reading the diff, and see `list_test.rb` for a clear example of how to use the new setting. \r\n\r\nThanks for your consideration. I'm happy to work up changes if you like, and no offense if you don't like this proposal. I could work up a documentation change on its own if you prefer. "},"comment":{"url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/comments/226246698","html_url":"https://github.com/weppos/publicsuffix-ruby/pull/108#issuecomment-226246698","issue_url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/108","id":226246698,"user":{"login":"trevorturk","id":402,"avatar_url":"https://avatars.githubusercontent.com/u/402?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorturk","html_url":"https://github.com/trevorturk","followers_url":"https://api.github.com/users/trevorturk/followers","following_url":"https://api.github.com/users/trevorturk/following{/other_user}","gists_url":"https://api.github.com/users/trevorturk/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorturk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorturk/subscriptions","organizations_url":"https://api.github.com/users/trevorturk/orgs","repos_url":"https://api.github.com/users/trevorturk/repos","events_url":"https://api.github.com/users/trevorturk/events{/privacy}","received_events_url":"https://api.github.com/users/trevorturk/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T16:43:17Z","updated_at":"2016-06-15T16:43:17Z","body":"Ok, I'll work that up now. "}}
{"actor":{"display_login":"trevorturk"}}