{"action":"created","comment":{"url":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/comments/55691694","id":55691694,"diff_hunk":"@@ -728,16 +737,14 @@ if(MSVC)\n           COMPONENT SDK)\n   if(CMAKE_BUILD_TYPE STREQUAL \"Debug\")","path":"CMakeLists.txt","position":27,"original_position":27,"commit_id":"a0792fc728c76eab4214254ebb71c314d0133d3c","original_commit_id":"a0792fc728c76eab4214254ebb71c314d0133d3c","user":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars.githubusercontent.com/u/4346993?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"body":"> So on Windows that condition will never true?\r\n\r\nNot exactly. It can be true if user add `-DCMAKE_BUILD_TYPE=Debug` but Debug/Release types switches differently for single (like NMake) and multi-configuration (like Visual Studio) generators. See SO link for details.\r\n\r\nThe right way to handle it usually is use [generator-expressions](https://cmake.org/cmake/help/v3.5/manual/cmake-generator-expressions.7.html) (like `$<CONFIG:Debug>`) or in case of `install` command is to add `install(... CONFIGURATION Debug)` (see [documentation](https://cmake.org/cmake/help/v3.5/command/install.html)).\r\n\r\nAlso see [CMAKE_CFG_INTDIR](https://cmake.org/cmake/help/v3.5/variable/CMAKE_CFG_INTDIR.html).","created_at":"2016-03-10T15:05:09Z","updated_at":"2016-03-10T15:05:09Z","html_url":"https://github.com/hunter-packages/zeromq4-1/pull/1#discussion_r55691694","pull_request_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/comments/55691694"},"html":{"href":"https://github.com/hunter-packages/zeromq4-1/pull/1#discussion_r55691694"},"pull_request":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/1","id":62371435,"html_url":"https://github.com/hunter-packages/zeromq4-1/pull/1","diff_url":"https://github.com/hunter-packages/zeromq4-1/pull/1.diff","patch_url":"https://github.com/hunter-packages/zeromq4-1/pull/1.patch","issue_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/issues/1","number":1,"state":"open","locked":false,"title":"Windows build fix","user":{"login":"tatraian","id":17123842,"avatar_url":"https://avatars.githubusercontent.com/u/17123842?v=3","gravatar_id":"","url":"https://api.github.com/users/tatraian","html_url":"https://github.com/tatraian","followers_url":"https://api.github.com/users/tatraian/followers","following_url":"https://api.github.com/users/tatraian/following{/other_user}","gists_url":"https://api.github.com/users/tatraian/gists{/gist_id}","starred_url":"https://api.github.com/users/tatraian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatraian/subscriptions","organizations_url":"https://api.github.com/users/tatraian/orgs","repos_url":"https://api.github.com/users/tatraian/repos","events_url":"https://api.github.com/users/tatraian/events{/privacy}","received_events_url":"https://api.github.com/users/tatraian/received_events","type":"User","site_admin":false},"body":"I fixed some issues. I can build the hunter example app with dyncamic linking but I cannot with static linklinkg. I used VS2015 community edition.","created_at":"2016-03-10T10:52:35Z","updated_at":"2016-03-10T15:05:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a22752194383a031793cc28fc315080c339b16d","assignee":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars.githubusercontent.com/u/4346993?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/1/commits","review_comments_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/1/comments","review_comment_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/issues/1/comments","statuses_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/statuses/a0792fc728c76eab4214254ebb71c314d0133d3c","head":{"label":"tatraian:windows_build_fix","ref":"windows_build_fix","sha":"a0792fc728c76eab4214254ebb71c314d0133d3c","user":{"login":"tatraian","id":17123842,"avatar_url":"https://avatars.githubusercontent.com/u/17123842?v=3","gravatar_id":"","url":"https://api.github.com/users/tatraian","html_url":"https://github.com/tatraian","followers_url":"https://api.github.com/users/tatraian/followers","following_url":"https://api.github.com/users/tatraian/following{/other_user}","gists_url":"https://api.github.com/users/tatraian/gists{/gist_id}","starred_url":"https://api.github.com/users/tatraian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatraian/subscriptions","organizations_url":"https://api.github.com/users/tatraian/orgs","repos_url":"https://api.github.com/users/tatraian/repos","events_url":"https://api.github.com/users/tatraian/events{/privacy}","received_events_url":"https://api.github.com/users/tatraian/received_events","type":"User","site_admin":false},"repo":{"id":53197928,"name":"zeromq4-1","full_name":"tatraian/zeromq4-1","owner":{"login":"tatraian","id":17123842,"avatar_url":"https://avatars.githubusercontent.com/u/17123842?v=3","gravatar_id":"","url":"https://api.github.com/users/tatraian","html_url":"https://github.com/tatraian","followers_url":"https://api.github.com/users/tatraian/followers","following_url":"https://api.github.com/users/tatraian/following{/other_user}","gists_url":"https://api.github.com/users/tatraian/gists{/gist_id}","starred_url":"https://api.github.com/users/tatraian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatraian/subscriptions","organizations_url":"https://api.github.com/users/tatraian/orgs","repos_url":"https://api.github.com/users/tatraian/repos","events_url":"https://api.github.com/users/tatraian/events{/privacy}","received_events_url":"https://api.github.com/users/tatraian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tatraian/zeromq4-1","description":"ZeroMQ 4.1.x stable release branch - bug fixes only","fork":true,"url":"https://api.github.com/repos/tatraian/zeromq4-1","forks_url":"https://api.github.com/repos/tatraian/zeromq4-1/forks","keys_url":"https://api.github.com/repos/tatraian/zeromq4-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatraian/zeromq4-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatraian/zeromq4-1/teams","hooks_url":"https://api.github.com/repos/tatraian/zeromq4-1/hooks","issue_events_url":"https://api.github.com/repos/tatraian/zeromq4-1/issues/events{/number}","events_url":"https://api.github.com/repos/tatraian/zeromq4-1/events","assignees_url":"https://api.github.com/repos/tatraian/zeromq4-1/assignees{/user}","branches_url":"https://api.github.com/repos/tatraian/zeromq4-1/branches{/branch}","tags_url":"https://api.github.com/repos/tatraian/zeromq4-1/tags","blobs_url":"https://api.github.com/repos/tatraian/zeromq4-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatraian/zeromq4-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatraian/zeromq4-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatraian/zeromq4-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatraian/zeromq4-1/statuses/{sha}","languages_url":"https://api.github.com/repos/tatraian/zeromq4-1/languages","stargazers_url":"https://api.github.com/repos/tatraian/zeromq4-1/stargazers","contributors_url":"https://api.github.com/repos/tatraian/zeromq4-1/contributors","subscribers_url":"https://api.github.com/repos/tatraian/zeromq4-1/subscribers","subscription_url":"https://api.github.com/repos/tatraian/zeromq4-1/subscription","commits_url":"https://api.github.com/repos/tatraian/zeromq4-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatraian/zeromq4-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatraian/zeromq4-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatraian/zeromq4-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/tatraian/zeromq4-1/contents/{+path}","compare_url":"https://api.github.com/repos/tatraian/zeromq4-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatraian/zeromq4-1/merges","archive_url":"https://api.github.com/repos/tatraian/zeromq4-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatraian/zeromq4-1/downloads","issues_url":"https://api.github.com/repos/tatraian/zeromq4-1/issues{/number}","pulls_url":"https://api.github.com/repos/tatraian/zeromq4-1/pulls{/number}","milestones_url":"https://api.github.com/repos/tatraian/zeromq4-1/milestones{/number}","notifications_url":"https://api.github.com/repos/tatraian/zeromq4-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatraian/zeromq4-1/labels{/name}","releases_url":"https://api.github.com/repos/tatraian/zeromq4-1/releases{/id}","deployments_url":"https://api.github.com/repos/tatraian/zeromq4-1/deployments","created_at":"2016-03-05T11:22:01Z","updated_at":"2016-03-05T11:22:05Z","pushed_at":"2016-03-10T10:50:12Z","git_url":"git://github.com/tatraian/zeromq4-1.git","ssh_url":"git@github.com:tatraian/zeromq4-1.git","clone_url":"https://github.com/tatraian/zeromq4-1.git","svn_url":"https://github.com/tatraian/zeromq4-1","homepage":null,"size":13221,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hunter-packages:hunter_v4.1.4","ref":"hunter_v4.1.4","sha":"8ea89930e19c8c6a79f2759cc7ca5980f3a96f6d","user":{"login":"hunter-packages","id":5978149,"avatar_url":"https://avatars.githubusercontent.com/u/5978149?v=3","gravatar_id":"","url":"https://api.github.com/users/hunter-packages","html_url":"https://github.com/hunter-packages","followers_url":"https://api.github.com/users/hunter-packages/followers","following_url":"https://api.github.com/users/hunter-packages/following{/other_user}","gists_url":"https://api.github.com/users/hunter-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/hunter-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunter-packages/subscriptions","organizations_url":"https://api.github.com/users/hunter-packages/orgs","repos_url":"https://api.github.com/users/hunter-packages/repos","events_url":"https://api.github.com/users/hunter-packages/events{/privacy}","received_events_url":"https://api.github.com/users/hunter-packages/received_events","type":"Organization","site_admin":false},"repo":{"id":53015745,"name":"zeromq4-1","full_name":"hunter-packages/zeromq4-1","owner":{"login":"hunter-packages","id":5978149,"avatar_url":"https://avatars.githubusercontent.com/u/5978149?v=3","gravatar_id":"","url":"https://api.github.com/users/hunter-packages","html_url":"https://github.com/hunter-packages","followers_url":"https://api.github.com/users/hunter-packages/followers","following_url":"https://api.github.com/users/hunter-packages/following{/other_user}","gists_url":"https://api.github.com/users/hunter-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/hunter-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunter-packages/subscriptions","organizations_url":"https://api.github.com/users/hunter-packages/orgs","repos_url":"https://api.github.com/users/hunter-packages/repos","events_url":"https://api.github.com/users/hunter-packages/events{/privacy}","received_events_url":"https://api.github.com/users/hunter-packages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hunter-packages/zeromq4-1","description":"ZeroMQ 4.1.x stable release branch - bug fixes only","fork":true,"url":"https://api.github.com/repos/hunter-packages/zeromq4-1","forks_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/forks","keys_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/teams","hooks_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/hooks","issue_events_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/issues/events{/number}","events_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/events","assignees_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/assignees{/user}","branches_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/branches{/branch}","tags_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/tags","blobs_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/statuses/{sha}","languages_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/languages","stargazers_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/stargazers","contributors_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/contributors","subscribers_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/subscribers","subscription_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/subscription","commits_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/contents/{+path}","compare_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/merges","archive_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/downloads","issues_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/issues{/number}","pulls_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls{/number}","milestones_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/milestones{/number}","notifications_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/labels{/name}","releases_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/releases{/id}","deployments_url":"https://api.github.com/repos/hunter-packages/zeromq4-1/deployments","created_at":"2016-03-03T02:59:13Z","updated_at":"2016-03-03T02:59:17Z","pushed_at":"2016-03-10T10:52:36Z","git_url":"git://github.com/hunter-packages/zeromq4-1.git","ssh_url":"git@github.com:hunter-packages/zeromq4-1.git","clone_url":"https://github.com/hunter-packages/zeromq4-1.git","svn_url":"https://github.com/hunter-packages/zeromq4-1","homepage":null,"size":13193,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/1"},"html":{"href":"https://github.com/hunter-packages/zeromq4-1/pull/1"},"issue":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/issues/1"},"comments":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/hunter-packages/zeromq4-1/statuses/a0792fc728c76eab4214254ebb71c314d0133d3c"}}}}