{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero/pulls/comments/79309157","id":79309157,"diff_hunk":"@@ -365,37 +366,46 @@ else()\n     set(COVERAGE_FLAGS \"-fprofile-arcs -ftest-coverage --coverage\")\n   endif()\n \n-  set(CMAKE_C_FLAGS \"${CMAKE_C_FLAGS} -std=c11 -D_GNU_SOURCE ${MINGW_FLAG} ${STATIC_ASSERT_FLAG} ${WARNINGS} ${C_WARNINGS} ${ARCH_FLAG} ${COVERAGE_FLAGS}\")\n-  set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -std=c++11 -D_GNU_SOURCE ${MINGW_FLAG} ${WARNINGS} ${CXX_WARNINGS} ${ARCH_FLAG} ${COVERAGE_FLAGS}\")\n-\n-  # With GCC 6.1.1 the compiled binary malfunctions due to aliasing. Until that\n-  # is fixed in the code (Issue #847), force compiler to be conservative.\n-  set(CMAKE_C_FLAGS \"${CMAKE_C_FLAGS} -fno-strict-aliasing\")\n-  set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -fno-strict-aliasing\")\n-\n   option(NO_AES \"Explicitly disable AES support\" ${NO_AES})\n \n   if(NOT NO_AES AND NOT ARM)\n     message(STATUS \"AES support enabled\")\n     set(CMAKE_C_FLAGS \"${CMAKE_C_FLAGS} -maes\")\n     set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -maes\")\n-  elseif(ARM) #NB ARMv8 DOES support AES, but not yet coded\n-    message(STATUS \"AES support disabled (not available on ARM)\")\n+  elseif(ARM6)\n+    message(STATUS \"AES support not available on ARMv6\")\n+  elseif(ARM7)\n+    message(STATUS \"AES support not available on ARMv7\")\n+  elseif(ARM8)\n+    CHECK_CXX_ACCEPTS_FLAG(\"-march=${ARCH}+crypto\" ARCH_PLUS_CRYPTO)","path":"CMakeLists.txt","position":42,"original_position":42,"commit_id":"7f00a4abf41456dea6c51c0797f899901efb4877","original_commit_id":"7f00a4abf41456dea6c51c0797f899901efb4877","user":{"login":"NanoAkron","id":6762681,"avatar_url":"https://avatars.githubusercontent.com/u/6762681?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoAkron","html_url":"https://github.com/NanoAkron","followers_url":"https://api.github.com/users/NanoAkron/followers","following_url":"https://api.github.com/users/NanoAkron/following{/other_user}","gists_url":"https://api.github.com/users/NanoAkron/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoAkron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoAkron/subscriptions","organizations_url":"https://api.github.com/users/NanoAkron/orgs","repos_url":"https://api.github.com/users/NanoAkron/repos","events_url":"https://api.github.com/users/NanoAkron/events{/privacy}","received_events_url":"https://api.github.com/users/NanoAkron/received_events","type":"User","site_admin":false},"body":"That pathway only gets activated is ARM8 is true, which is only true if the architecture is aarch64 (see the top of CMakeLists.txt), which is by definition armv8-a compatible at this time.\r\n\r\nAnd don't worry about what I said about native+crypto not working - that's just for my Odroid C2 which happens to have an ARMv8-A chip that doesn't have the crypto extensions.","created_at":"2016-09-18T16:13:28Z","updated_at":"2016-09-18T16:13:28Z","html_url":"https://github.com/monero-project/monero/pull/1088#discussion_r79309157","pull_request_url":"https://api.github.com/repos/monero-project/monero/pulls/1088","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments/79309157"},"html":{"href":"https://github.com/monero-project/monero/pull/1088#discussion_r79309157"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1088"}}},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/1088","id":85687346,"html_url":"https://github.com/monero-project/monero/pull/1088","diff_url":"https://github.com/monero-project/monero/pull/1088.diff","patch_url":"https://github.com/monero-project/monero/pull/1088.patch","issue_url":"https://api.github.com/repos/monero-project/monero/issues/1088","number":1088,"state":"open","locked":false,"title":"Add +crypto flag for ARMv8-a","user":{"login":"NanoAkron","id":6762681,"avatar_url":"https://avatars.githubusercontent.com/u/6762681?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoAkron","html_url":"https://github.com/NanoAkron","followers_url":"https://api.github.com/users/NanoAkron/followers","following_url":"https://api.github.com/users/NanoAkron/following{/other_user}","gists_url":"https://api.github.com/users/NanoAkron/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoAkron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoAkron/subscriptions","organizations_url":"https://api.github.com/users/NanoAkron/orgs","repos_url":"https://api.github.com/users/NanoAkron/repos","events_url":"https://api.github.com/users/NanoAkron/events{/privacy}","received_events_url":"https://api.github.com/users/NanoAkron/received_events","type":"User","site_admin":false},"body":"Belt-and-braces change to use @hyc's new ARM ASM code on ARMv8-a\r\n\r\nAnyone working on ARMv7 will have to make their own PR - I don't have a system to test against","created_at":"2016-09-17T21:16:24Z","updated_at":"2016-09-18T16:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af6d60230b04e3de71cd864f770c87ec70a3cc78","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero/pulls/1088/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero/pulls/1088/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/1088/comments","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/7f00a4abf41456dea6c51c0797f899901efb4877","head":{"label":"NanoAkron:armv8-march-crypto","ref":"armv8-march-crypto","sha":"7f00a4abf41456dea6c51c0797f899901efb4877","user":{"login":"NanoAkron","id":6762681,"avatar_url":"https://avatars.githubusercontent.com/u/6762681?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoAkron","html_url":"https://github.com/NanoAkron","followers_url":"https://api.github.com/users/NanoAkron/followers","following_url":"https://api.github.com/users/NanoAkron/following{/other_user}","gists_url":"https://api.github.com/users/NanoAkron/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoAkron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoAkron/subscriptions","organizations_url":"https://api.github.com/users/NanoAkron/orgs","repos_url":"https://api.github.com/users/NanoAkron/repos","events_url":"https://api.github.com/users/NanoAkron/events{/privacy}","received_events_url":"https://api.github.com/users/NanoAkron/received_events","type":"User","site_admin":false},"repo":{"id":66832706,"name":"monero","full_name":"NanoAkron/monero","owner":{"login":"NanoAkron","id":6762681,"avatar_url":"https://avatars.githubusercontent.com/u/6762681?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoAkron","html_url":"https://github.com/NanoAkron","followers_url":"https://api.github.com/users/NanoAkron/followers","following_url":"https://api.github.com/users/NanoAkron/following{/other_user}","gists_url":"https://api.github.com/users/NanoAkron/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoAkron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoAkron/subscriptions","organizations_url":"https://api.github.com/users/NanoAkron/orgs","repos_url":"https://api.github.com/users/NanoAkron/repos","events_url":"https://api.github.com/users/NanoAkron/events{/privacy}","received_events_url":"https://api.github.com/users/NanoAkron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NanoAkron/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/NanoAkron/monero","forks_url":"https://api.github.com/repos/NanoAkron/monero/forks","keys_url":"https://api.github.com/repos/NanoAkron/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NanoAkron/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NanoAkron/monero/teams","hooks_url":"https://api.github.com/repos/NanoAkron/monero/hooks","issue_events_url":"https://api.github.com/repos/NanoAkron/monero/issues/events{/number}","events_url":"https://api.github.com/repos/NanoAkron/monero/events","assignees_url":"https://api.github.com/repos/NanoAkron/monero/assignees{/user}","branches_url":"https://api.github.com/repos/NanoAkron/monero/branches{/branch}","tags_url":"https://api.github.com/repos/NanoAkron/monero/tags","blobs_url":"https://api.github.com/repos/NanoAkron/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NanoAkron/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NanoAkron/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/NanoAkron/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NanoAkron/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/NanoAkron/monero/languages","stargazers_url":"https://api.github.com/repos/NanoAkron/monero/stargazers","contributors_url":"https://api.github.com/repos/NanoAkron/monero/contributors","subscribers_url":"https://api.github.com/repos/NanoAkron/monero/subscribers","subscription_url":"https://api.github.com/repos/NanoAkron/monero/subscription","commits_url":"https://api.github.com/repos/NanoAkron/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/NanoAkron/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/NanoAkron/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/NanoAkron/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/NanoAkron/monero/contents/{+path}","compare_url":"https://api.github.com/repos/NanoAkron/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NanoAkron/monero/merges","archive_url":"https://api.github.com/repos/NanoAkron/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NanoAkron/monero/downloads","issues_url":"https://api.github.com/repos/NanoAkron/monero/issues{/number}","pulls_url":"https://api.github.com/repos/NanoAkron/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/NanoAkron/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/NanoAkron/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NanoAkron/monero/labels{/name}","releases_url":"https://api.github.com/repos/NanoAkron/monero/releases{/id}","deployments_url":"https://api.github.com/repos/NanoAkron/monero/deployments","created_at":"2016-08-29T10:06:03Z","updated_at":"2016-09-03T12:31:07Z","pushed_at":"2016-09-18T02:27:01Z","git_url":"git://github.com/NanoAkron/monero.git","ssh_url":"git@github.com:NanoAkron/monero.git","clone_url":"https://github.com/NanoAkron/monero.git","svn_url":"https://github.com/NanoAkron/monero","homepage":"https://getmonero.org","size":64601,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"77224bbf4842f3c7fb53ad7685f45cf768f5ec38","user":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=3","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":19316619,"name":"monero","full_name":"monero-project/monero","owner":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=3","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monero-project/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero","forks_url":"https://api.github.com/repos/monero-project/monero/forks","keys_url":"https://api.github.com/repos/monero-project/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero/teams","hooks_url":"https://api.github.com/repos/monero-project/monero/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero/events","assignees_url":"https://api.github.com/repos/monero-project/monero/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero/tags","blobs_url":"https://api.github.com/repos/monero-project/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero/subscription","commits_url":"https://api.github.com/repos/monero-project/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero/merges","archive_url":"https://api.github.com/repos/monero-project/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero/downloads","issues_url":"https://api.github.com/repos/monero-project/monero/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero/deployments","created_at":"2014-04-30T14:38:28Z","updated_at":"2016-09-18T13:44:33Z","pushed_at":"2016-09-18T15:42:40Z","git_url":"git://github.com/monero-project/monero.git","ssh_url":"git@github.com:monero-project/monero.git","clone_url":"https://github.com/monero-project/monero.git","svn_url":"https://github.com/monero-project/monero","homepage":"https://getmonero.org","size":67384,"stargazers_count":268,"watchers_count":268,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":104,"forks":180,"open_issues":104,"watchers":268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1088"},"html":{"href":"https://github.com/monero-project/monero/pull/1088"},"issue":{"href":"https://api.github.com/repos/monero-project/monero/issues/1088"},"comments":{"href":"https://api.github.com/repos/monero-project/monero/issues/1088/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1088/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1088/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero/statuses/7f00a4abf41456dea6c51c0797f899901efb4877"}}}}
{"actor":{"display_login":"NanoAkron"}}