{"action":"created","issue":{"url":"https://api.github.com/repos/c4fcm/DataBasic/issues/211","repository_url":"https://api.github.com/repos/c4fcm/DataBasic","labels_url":"https://api.github.com/repos/c4fcm/DataBasic/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/c4fcm/DataBasic/issues/211/comments","events_url":"https://api.github.com/repos/c4fcm/DataBasic/issues/211/events","html_url":"https://github.com/c4fcm/DataBasic/issues/211","id":153112081,"number":211,"title":"Check on file upload limits","user":{"login":"kanarinka","id":1102550,"avatar_url":"https://avatars.githubusercontent.com/u/1102550?v=3","gravatar_id":"","url":"https://api.github.com/users/kanarinka","html_url":"https://github.com/kanarinka","followers_url":"https://api.github.com/users/kanarinka/followers","following_url":"https://api.github.com/users/kanarinka/following{/other_user}","gists_url":"https://api.github.com/users/kanarinka/gists{/gist_id}","starred_url":"https://api.github.com/users/kanarinka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanarinka/subscriptions","organizations_url":"https://api.github.com/users/kanarinka/orgs","repos_url":"https://api.github.com/users/kanarinka/repos","events_url":"https://api.github.com/users/kanarinka/events{/privacy}","received_events_url":"https://api.github.com/users/kanarinka/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/c4fcm/DataBasic/labels/SameDiff","name":"SameDiff","color":"009800"},{"url":"https://api.github.com/repos/c4fcm/DataBasic/labels/WordCounter","name":"WordCounter","color":"f7c6c7"},{"url":"https://api.github.com/repos/c4fcm/DataBasic/labels/WTFcsv","name":"WTFcsv","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/c4fcm/DataBasic/milestones/8","html_url":"https://github.com/c4fcm/DataBasic/milestones/v1.3%20-%20Next%20Big%20Release","labels_url":"https://api.github.com/repos/c4fcm/DataBasic/milestones/8/labels","id":1605665,"number":8,"title":"v1.3 - Next Big Release","description":"","creator":{"login":"rahulbot","id":673178,"avatar_url":"https://avatars.githubusercontent.com/u/673178?v=3","gravatar_id":"","url":"https://api.github.com/users/rahulbot","html_url":"https://github.com/rahulbot","followers_url":"https://api.github.com/users/rahulbot/followers","following_url":"https://api.github.com/users/rahulbot/following{/other_user}","gists_url":"https://api.github.com/users/rahulbot/gists{/gist_id}","starred_url":"https://api.github.com/users/rahulbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rahulbot/subscriptions","organizations_url":"https://api.github.com/users/rahulbot/orgs","repos_url":"https://api.github.com/users/rahulbot/repos","events_url":"https://api.github.com/users/rahulbot/events{/privacy}","received_events_url":"https://api.github.com/users/rahulbot/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":4,"state":"open","created_at":"2016-02-25T16:53:57Z","updated_at":"2016-06-28T21:34:45Z","due_on":"2016-03-30T04:00:00Z","closed_at":null},"comments":1,"created_at":"2016-05-04T20:52:26Z","updated_at":"2016-06-28T21:34:45Z","closed_at":"2016-06-28T21:34:45Z","body":"Make sure that files over the limit do NOT get processed by the system. Seems that uploading some large CSVs inadvertantly blew out our memory (see #209). Make sure we are checking file size before uploading and/or dumping file out of memory if it exceeds the size limit instead of still running it through the analysis."},"comment":{"url":"https://api.github.com/repos/c4fcm/DataBasic/issues/comments/229191138","html_url":"https://github.com/c4fcm/DataBasic/issues/211#issuecomment-229191138","issue_url":"https://api.github.com/repos/c4fcm/DataBasic/issues/211","id":229191138,"user":{"login":"kanarinka","id":1102550,"avatar_url":"https://avatars.githubusercontent.com/u/1102550?v=3","gravatar_id":"","url":"https://api.github.com/users/kanarinka","html_url":"https://github.com/kanarinka","followers_url":"https://api.github.com/users/kanarinka/followers","following_url":"https://api.github.com/users/kanarinka/following{/other_user}","gists_url":"https://api.github.com/users/kanarinka/gists{/gist_id}","starred_url":"https://api.github.com/users/kanarinka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanarinka/subscriptions","organizations_url":"https://api.github.com/users/kanarinka/orgs","repos_url":"https://api.github.com/users/kanarinka/repos","events_url":"https://api.github.com/users/kanarinka/events{/privacy}","received_events_url":"https://api.github.com/users/kanarinka/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T21:34:45Z","updated_at":"2016-06-28T21:34:45Z","body":"I checked and we ARE catching file size at the interface level and giving a good error message so I am closing out this bug. But to make it a little more transparent and configurable, I added the file size limit as an app/environment variable in the development.py settings file. @rahulbot you just need to make sure you add this new variable into the config file for any new builds we do."}}
{"actor":{"display_login":"kanarinka"}}