{"action":"closed","number":936,"pull_request":{"url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/936","id":80937533,"html_url":"https://github.com/rspec/rspec-expectations/pull/936","diff_url":"https://github.com/rspec/rspec-expectations/pull/936.diff","patch_url":"https://github.com/rspec/rspec-expectations/pull/936.patch","issue_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/936","number":936,"state":"closed","locked":false,"title":"Reduce allocations","user":{"login":"nathell","id":43891,"avatar_url":"https://avatars.githubusercontent.com/u/43891?v=3","gravatar_id":"","url":"https://api.github.com/users/nathell","html_url":"https://github.com/nathell","followers_url":"https://api.github.com/users/nathell/followers","following_url":"https://api.github.com/users/nathell/following{/other_user}","gists_url":"https://api.github.com/users/nathell/gists{/gist_id}","starred_url":"https://api.github.com/users/nathell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathell/subscriptions","organizations_url":"https://api.github.com/users/nathell/orgs","repos_url":"https://api.github.com/users/nathell/repos","events_url":"https://api.github.com/users/nathell/events{/privacy}","received_events_url":"https://api.github.com/users/nathell/received_events","type":"User","site_admin":false},"body":"I and @k3rni have profiled rspec-expectations' test suite for memory allocations using `allocation_stats`. The results are at http://danieljanus.pl/rspec-allocations.txt. Most are non-trivial to change, but we did find some (not much) low-hanging fruit. This is a PR for #766.\r\n\r\nSpecific changes are documented in individual commit messages.","created_at":"2016-08-11T10:53:12Z","updated_at":"2016-09-07T01:01:53Z","closed_at":"2016-09-07T01:01:53Z","merged_at":null,"merge_commit_sha":"a89f6b9afbc06bbbefdef6190fe64a86864171ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/936/commits","review_comments_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/936/comments","review_comment_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/936/comments","statuses_url":"https://api.github.com/repos/rspec/rspec-expectations/statuses/7ae380ea43ee5414ca069434bb5f01167a2bd396","head":{"label":"nathell:reduce-allocations","ref":"reduce-allocations","sha":"7ae380ea43ee5414ca069434bb5f01167a2bd396","user":{"login":"nathell","id":43891,"avatar_url":"https://avatars.githubusercontent.com/u/43891?v=3","gravatar_id":"","url":"https://api.github.com/users/nathell","html_url":"https://github.com/nathell","followers_url":"https://api.github.com/users/nathell/followers","following_url":"https://api.github.com/users/nathell/following{/other_user}","gists_url":"https://api.github.com/users/nathell/gists{/gist_id}","starred_url":"https://api.github.com/users/nathell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathell/subscriptions","organizations_url":"https://api.github.com/users/nathell/orgs","repos_url":"https://api.github.com/users/nathell/repos","events_url":"https://api.github.com/users/nathell/events{/privacy}","received_events_url":"https://api.github.com/users/nathell/received_events","type":"User","site_admin":false},"repo":{"id":65033057,"name":"rspec-expectations","full_name":"nathell/rspec-expectations","owner":{"login":"nathell","id":43891,"avatar_url":"https://avatars.githubusercontent.com/u/43891?v=3","gravatar_id":"","url":"https://api.github.com/users/nathell","html_url":"https://github.com/nathell","followers_url":"https://api.github.com/users/nathell/followers","following_url":"https://api.github.com/users/nathell/following{/other_user}","gists_url":"https://api.github.com/users/nathell/gists{/gist_id}","starred_url":"https://api.github.com/users/nathell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathell/subscriptions","organizations_url":"https://api.github.com/users/nathell/orgs","repos_url":"https://api.github.com/users/nathell/repos","events_url":"https://api.github.com/users/nathell/events{/privacy}","received_events_url":"https://api.github.com/users/nathell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathell/rspec-expectations","description":"Provides a readable API to express expected outcomes of a code example","fork":true,"url":"https://api.github.com/repos/nathell/rspec-expectations","forks_url":"https://api.github.com/repos/nathell/rspec-expectations/forks","keys_url":"https://api.github.com/repos/nathell/rspec-expectations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathell/rspec-expectations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathell/rspec-expectations/teams","hooks_url":"https://api.github.com/repos/nathell/rspec-expectations/hooks","issue_events_url":"https://api.github.com/repos/nathell/rspec-expectations/issues/events{/number}","events_url":"https://api.github.com/repos/nathell/rspec-expectations/events","assignees_url":"https://api.github.com/repos/nathell/rspec-expectations/assignees{/user}","branches_url":"https://api.github.com/repos/nathell/rspec-expectations/branches{/branch}","tags_url":"https://api.github.com/repos/nathell/rspec-expectations/tags","blobs_url":"https://api.github.com/repos/nathell/rspec-expectations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathell/rspec-expectations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathell/rspec-expectations/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathell/rspec-expectations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathell/rspec-expectations/statuses/{sha}","languages_url":"https://api.github.com/repos/nathell/rspec-expectations/languages","stargazers_url":"https://api.github.com/repos/nathell/rspec-expectations/stargazers","contributors_url":"https://api.github.com/repos/nathell/rspec-expectations/contributors","subscribers_url":"https://api.github.com/repos/nathell/rspec-expectations/subscribers","subscription_url":"https://api.github.com/repos/nathell/rspec-expectations/subscription","commits_url":"https://api.github.com/repos/nathell/rspec-expectations/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathell/rspec-expectations/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathell/rspec-expectations/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathell/rspec-expectations/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathell/rspec-expectations/contents/{+path}","compare_url":"https://api.github.com/repos/nathell/rspec-expectations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathell/rspec-expectations/merges","archive_url":"https://api.github.com/repos/nathell/rspec-expectations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathell/rspec-expectations/downloads","issues_url":"https://api.github.com/repos/nathell/rspec-expectations/issues{/number}","pulls_url":"https://api.github.com/repos/nathell/rspec-expectations/pulls{/number}","milestones_url":"https://api.github.com/repos/nathell/rspec-expectations/milestones{/number}","notifications_url":"https://api.github.com/repos/nathell/rspec-expectations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathell/rspec-expectations/labels{/name}","releases_url":"https://api.github.com/repos/nathell/rspec-expectations/releases{/id}","deployments_url":"https://api.github.com/repos/nathell/rspec-expectations/deployments","created_at":"2016-08-05T16:25:34Z","updated_at":"2016-08-05T16:25:35Z","pushed_at":"2016-08-11T22:39:23Z","git_url":"git://github.com/nathell/rspec-expectations.git","ssh_url":"git@github.com:nathell/rspec-expectations.git","clone_url":"https://github.com/nathell/rspec-expectations.git","svn_url":"https://github.com/nathell/rspec-expectations","homepage":"http://relishapp.com/rspec/rspec-expectations","size":4470,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rspec:master","ref":"master","sha":"a271631e9b8e1749be876dbcc65dbd7a6a40d2db","user":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?v=3","gravatar_id":"","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"repo":{"id":238986,"name":"rspec-expectations","full_name":"rspec/rspec-expectations","owner":{"login":"rspec","id":22388,"avatar_url":"https://avatars.githubusercontent.com/u/22388?v=3","gravatar_id":"","url":"https://api.github.com/users/rspec","html_url":"https://github.com/rspec","followers_url":"https://api.github.com/users/rspec/followers","following_url":"https://api.github.com/users/rspec/following{/other_user}","gists_url":"https://api.github.com/users/rspec/gists{/gist_id}","starred_url":"https://api.github.com/users/rspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspec/subscriptions","organizations_url":"https://api.github.com/users/rspec/orgs","repos_url":"https://api.github.com/users/rspec/repos","events_url":"https://api.github.com/users/rspec/events{/privacy}","received_events_url":"https://api.github.com/users/rspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rspec/rspec-expectations","description":"Provides a readable API to express expected outcomes of a code example","fork":false,"url":"https://api.github.com/repos/rspec/rspec-expectations","forks_url":"https://api.github.com/repos/rspec/rspec-expectations/forks","keys_url":"https://api.github.com/repos/rspec/rspec-expectations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rspec/rspec-expectations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rspec/rspec-expectations/teams","hooks_url":"https://api.github.com/repos/rspec/rspec-expectations/hooks","issue_events_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/events{/number}","events_url":"https://api.github.com/repos/rspec/rspec-expectations/events","assignees_url":"https://api.github.com/repos/rspec/rspec-expectations/assignees{/user}","branches_url":"https://api.github.com/repos/rspec/rspec-expectations/branches{/branch}","tags_url":"https://api.github.com/repos/rspec/rspec-expectations/tags","blobs_url":"https://api.github.com/repos/rspec/rspec-expectations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rspec/rspec-expectations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rspec/rspec-expectations/git/refs{/sha}","trees_url":"https://api.github.com/repos/rspec/rspec-expectations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rspec/rspec-expectations/statuses/{sha}","languages_url":"https://api.github.com/repos/rspec/rspec-expectations/languages","stargazers_url":"https://api.github.com/repos/rspec/rspec-expectations/stargazers","contributors_url":"https://api.github.com/repos/rspec/rspec-expectations/contributors","subscribers_url":"https://api.github.com/repos/rspec/rspec-expectations/subscribers","subscription_url":"https://api.github.com/repos/rspec/rspec-expectations/subscription","commits_url":"https://api.github.com/repos/rspec/rspec-expectations/commits{/sha}","git_commits_url":"https://api.github.com/repos/rspec/rspec-expectations/git/commits{/sha}","comments_url":"https://api.github.com/repos/rspec/rspec-expectations/comments{/number}","issue_comment_url":"https://api.github.com/repos/rspec/rspec-expectations/issues/comments{/number}","contents_url":"https://api.github.com/repos/rspec/rspec-expectations/contents/{+path}","compare_url":"https://api.github.com/repos/rspec/rspec-expectations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rspec/rspec-expectations/merges","archive_url":"https://api.github.com/repos/rspec/rspec-expectations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rspec/rspec-expectations/downloads","issues_url":"https://api.github.com/repos/rspec/rspec-expectations/issues{/number}","pulls_url":"https://api.github.com/repos/rspec/rspec-expectations/pulls{/number}","milestones_url":"https://api.github.com/repos/rspec/rspec-expectations/milestones{/number}","notifications_url":"https://api.github.com/repos/rspec/rspec-expectations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rspec/rspec-expectations/labels{/name}","releases_url":"https://api.github.com/repos/rspec/rspec-expectations/releases{/id}","deployments_url":"https://api.github.com/repos/rspec/rspec-expectations/deployments","created_at":"2009-06-29T15:58:17Z","updated_at":"2016-08-31T01:46:41Z","pushed_at":"2016-09-07T01:00:28Z","git_url":"git://github.com/rspec/rspec-expectations.git","ssh_url":"git@github.com:rspec/rspec-expectations.git","clone_url":"https://github.com/rspec/rspec-expectations.git","svn_url":"https://github.com/rspec/rspec-expectations","homepage":"http://relishapp.com/rspec/rspec-expectations","size":5508,"stargazers_count":806,"watchers_count":806,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":275,"mirror_url":null,"open_issues_count":24,"forks":275,"open_issues":24,"watchers":806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/936"},"html":{"href":"https://github.com/rspec/rspec-expectations/pull/936"},"issue":{"href":"https://api.github.com/repos/rspec/rspec-expectations/issues/936"},"comments":{"href":"https://api.github.com/repos/rspec/rspec-expectations/issues/936/comments"},"review_comments":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/936/comments"},"review_comment":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rspec/rspec-expectations/pulls/936/commits"},"statuses":{"href":"https://api.github.com/repos/rspec/rspec-expectations/statuses/7ae380ea43ee5414ca069434bb5f01167a2bd396"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":9,"commits":8,"additions":14,"deletions":8,"changed_files":5}}
{"actor":{"display_login":"JonRowe"}}