{"action":"created","issue":{"url":"https://api.github.com/repos/PointyCastle/pointycastle/issues/85","labels_url":"https://api.github.com/repos/PointyCastle/pointycastle/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/PointyCastle/pointycastle/issues/85/comments","events_url":"https://api.github.com/repos/PointyCastle/pointycastle/issues/85/events","html_url":"https://github.com/PointyCastle/pointycastle/issues/85","id":128876832,"number":85,"title":"Fixed issue with initializing deterministic ECDSASigner.","user":{"login":"stevenroose","id":853468,"avatar_url":"https://avatars.githubusercontent.com/u/853468?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenroose","html_url":"https://github.com/stevenroose","followers_url":"https://api.github.com/users/stevenroose/followers","following_url":"https://api.github.com/users/stevenroose/following{/other_user}","gists_url":"https://api.github.com/users/stevenroose/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenroose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenroose/subscriptions","organizations_url":"https://api.github.com/users/stevenroose/orgs","repos_url":"https://api.github.com/users/stevenroose/repos","events_url":"https://api.github.com/users/stevenroose/events{/privacy}","received_events_url":"https://api.github.com/users/stevenroose/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-26T16:52:42Z","updated_at":"2016-01-26T16:52:43Z","closed_at":null,"body":"_From @stevenroose on June 25, 2014 13:30_\n\n\n\n_Copied from original issue: izaera/cipher/pull/85_"},"comment":{"url":"https://api.github.com/repos/PointyCastle/pointycastle/issues/comments/175112395","html_url":"https://github.com/PointyCastle/pointycastle/issues/85#issuecomment-175112395","issue_url":"https://api.github.com/repos/PointyCastle/pointycastle/issues/85","id":175112395,"user":{"login":"stevenroose","id":853468,"avatar_url":"https://avatars.githubusercontent.com/u/853468?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenroose","html_url":"https://github.com/stevenroose","followers_url":"https://api.github.com/users/stevenroose/followers","following_url":"https://api.github.com/users/stevenroose/following{/other_user}","gists_url":"https://api.github.com/users/stevenroose/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenroose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenroose/subscriptions","organizations_url":"https://api.github.com/users/stevenroose/orgs","repos_url":"https://api.github.com/users/stevenroose/repos","events_url":"https://api.github.com/users/stevenroose/events{/privacy}","received_events_url":"https://api.github.com/users/stevenroose/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T16:52:43Z","updated_at":"2016-01-26T16:52:43Z","body":"_From @izaera on November 27, 2014 9:15_\n\nI tried to go that way in my first attempt. The problem is that some\r\nparameters may be shared among several algorithms when you chain them.\r\nFor example, if you chain a MAC and a BlockCipher, they normally use the\r\nsame key, so you want to have just one Param.Key in your hashmap when\r\nyou configure the chain.\r\n\r\nThus, I created Param for well known parameters and let the possibility\r\nof extending it for more specific parameters (I think that I have a\r\nPbkdf2Param class for example with parameters specific to that algorithm).\r\n\r\nAlso, having many usual params in Param makes autocompletion easier for\r\nnew users of cipher, because you just need to type Param. and the IDE\r\nshows you the more usual options.\r\n\r\nRegarding how to document used params, I planned to use plain\r\ndocumentation (as they do in Javascript). In the end, it's not so bad,\r\nbecause you wouldn't even need to look at the documentation at all. I\r\nmean, its implicit in every algorithm which parameters you need.\r\nExample: AES needs a symmetric key, RSA needs a public or private key,\r\nand so on. So, IMO, it's not so bad not to type it."}}