{"action":"created","comment":{"url":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments/77146534","id":77146534,"diff_hunk":"@@ -666,10 +666,15 @@ def _get_http_defaults(default_address=None, timeout=None, retrieve_resources=No\n             parsed_url = parse.urlsplit(default_address)\n             if parsed_url.scheme:\n                 cfg.append(JMX._string_prop(\"HTTPSampler.protocol\", parsed_url.scheme))\n-            if parsed_url.hostname:\n-                cfg.append(JMX._string_prop(\"HTTPSampler.domain\", parsed_url.hostname))\n-            if parsed_url.port:\n-                cfg.append(JMX._string_prop(\"HTTPSampler.port\", parsed_url.port))\n+\n+            if parsed_url.netloc:\n+                netloc = parsed_url.netloc\n+                if ':' in netloc:\n+                    index = netloc.rfind(':')\n+                    cfg.append(JMX._string_prop(\"HTTPSampler.port\", netloc[index+1:]))","path":"bzt/jmx.py","position":13,"original_position":13,"commit_id":"1d208fe9020560d334651cd8a6d21a9a2f0c849b","original_commit_id":"1d208fe9020560d334651cd8a6d21a9a2f0c849b","user":{"login":"dmand","id":668589,"avatar_url":"https://avatars.githubusercontent.com/u/668589?v=3","gravatar_id":"","url":"https://api.github.com/users/dmand","html_url":"https://github.com/dmand","followers_url":"https://api.github.com/users/dmand/followers","following_url":"https://api.github.com/users/dmand/following{/other_user}","gists_url":"https://api.github.com/users/dmand/gists{/gist_id}","starred_url":"https://api.github.com/users/dmand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmand/subscriptions","organizations_url":"https://api.github.com/users/dmand/orgs","repos_url":"https://api.github.com/users/dmand/repos","events_url":"https://api.github.com/users/dmand/events{/privacy}","received_events_url":"https://api.github.com/users/dmand/received_events","type":"User","site_admin":false},"body":"You can use `str.split(\":\")` for that.","created_at":"2016-09-01T10:02:22Z","updated_at":"2016-09-01T10:02:22Z","html_url":"https://github.com/Blazemeter/taurus/pull/321#discussion_r77146534","pull_request_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/321","_links":{"self":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments/77146534"},"html":{"href":"https://github.com/Blazemeter/taurus/pull/321#discussion_r77146534"},"pull_request":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/Blazemeter/taurus/pulls/321","id":83596247,"html_url":"https://github.com/Blazemeter/taurus/pull/321","diff_url":"https://github.com/Blazemeter/taurus/pull/321.diff","patch_url":"https://github.com/Blazemeter/taurus/pull/321.patch","issue_url":"https://api.github.com/repos/Blazemeter/taurus/issues/321","number":321,"state":"open","locked":false,"title":"Handle properties in default-address for JMeter","user":{"login":"undera","id":2026469,"avatar_url":"https://avatars.githubusercontent.com/u/2026469?v=3","gravatar_id":"","url":"https://api.github.com/users/undera","html_url":"https://github.com/undera","followers_url":"https://api.github.com/users/undera/followers","following_url":"https://api.github.com/users/undera/following{/other_user}","gists_url":"https://api.github.com/users/undera/gists{/gist_id}","starred_url":"https://api.github.com/users/undera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undera/subscriptions","organizations_url":"https://api.github.com/users/undera/orgs","repos_url":"https://api.github.com/users/undera/repos","events_url":"https://api.github.com/users/undera/events{/privacy}","received_events_url":"https://api.github.com/users/undera/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-01T09:11:18Z","updated_at":"2016-09-01T10:02:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a01d32a13944148dac676a793b48e920fb1dfd51","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/321/commits","review_comments_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/321/comments","review_comment_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Blazemeter/taurus/issues/321/comments","statuses_url":"https://api.github.com/repos/Blazemeter/taurus/statuses/1d208fe9020560d334651cd8a6d21a9a2f0c849b","head":{"label":"Blazemeter:fix/default-address-property","ref":"fix/default-address-property","sha":"1d208fe9020560d334651cd8a6d21a9a2f0c849b","user":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"repo":{"id":30940272,"name":"taurus","full_name":"Blazemeter/taurus","owner":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blazemeter/taurus","description":"Automation-friendly framework for Continuous Testing by","fork":false,"url":"https://api.github.com/repos/Blazemeter/taurus","forks_url":"https://api.github.com/repos/Blazemeter/taurus/forks","keys_url":"https://api.github.com/repos/Blazemeter/taurus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blazemeter/taurus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blazemeter/taurus/teams","hooks_url":"https://api.github.com/repos/Blazemeter/taurus/hooks","issue_events_url":"https://api.github.com/repos/Blazemeter/taurus/issues/events{/number}","events_url":"https://api.github.com/repos/Blazemeter/taurus/events","assignees_url":"https://api.github.com/repos/Blazemeter/taurus/assignees{/user}","branches_url":"https://api.github.com/repos/Blazemeter/taurus/branches{/branch}","tags_url":"https://api.github.com/repos/Blazemeter/taurus/tags","blobs_url":"https://api.github.com/repos/Blazemeter/taurus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blazemeter/taurus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blazemeter/taurus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blazemeter/taurus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blazemeter/taurus/statuses/{sha}","languages_url":"https://api.github.com/repos/Blazemeter/taurus/languages","stargazers_url":"https://api.github.com/repos/Blazemeter/taurus/stargazers","contributors_url":"https://api.github.com/repos/Blazemeter/taurus/contributors","subscribers_url":"https://api.github.com/repos/Blazemeter/taurus/subscribers","subscription_url":"https://api.github.com/repos/Blazemeter/taurus/subscription","commits_url":"https://api.github.com/repos/Blazemeter/taurus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blazemeter/taurus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blazemeter/taurus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blazemeter/taurus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blazemeter/taurus/contents/{+path}","compare_url":"https://api.github.com/repos/Blazemeter/taurus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blazemeter/taurus/merges","archive_url":"https://api.github.com/repos/Blazemeter/taurus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blazemeter/taurus/downloads","issues_url":"https://api.github.com/repos/Blazemeter/taurus/issues{/number}","pulls_url":"https://api.github.com/repos/Blazemeter/taurus/pulls{/number}","milestones_url":"https://api.github.com/repos/Blazemeter/taurus/milestones{/number}","notifications_url":"https://api.github.com/repos/Blazemeter/taurus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blazemeter/taurus/labels{/name}","releases_url":"https://api.github.com/repos/Blazemeter/taurus/releases{/id}","deployments_url":"https://api.github.com/repos/Blazemeter/taurus/deployments","created_at":"2015-02-17T22:05:08Z","updated_at":"2016-09-01T03:52:18Z","pushed_at":"2016-09-01T09:51:07Z","git_url":"git://github.com/Blazemeter/taurus.git","ssh_url":"git@github.com:Blazemeter/taurus.git","clone_url":"https://github.com/Blazemeter/taurus.git","svn_url":"https://github.com/Blazemeter/taurus","homepage":"http://gettaurus.org","size":8318,"stargazers_count":219,"watchers_count":219,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":5,"forks":52,"open_issues":5,"watchers":219,"default_branch":"master"}},"base":{"label":"Blazemeter:master","ref":"master","sha":"1e32b45a7c2c0b86cc05e428beccf7c3c0fbc41a","user":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"repo":{"id":30940272,"name":"taurus","full_name":"Blazemeter/taurus","owner":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blazemeter/taurus","description":"Automation-friendly framework for Continuous Testing by","fork":false,"url":"https://api.github.com/repos/Blazemeter/taurus","forks_url":"https://api.github.com/repos/Blazemeter/taurus/forks","keys_url":"https://api.github.com/repos/Blazemeter/taurus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blazemeter/taurus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blazemeter/taurus/teams","hooks_url":"https://api.github.com/repos/Blazemeter/taurus/hooks","issue_events_url":"https://api.github.com/repos/Blazemeter/taurus/issues/events{/number}","events_url":"https://api.github.com/repos/Blazemeter/taurus/events","assignees_url":"https://api.github.com/repos/Blazemeter/taurus/assignees{/user}","branches_url":"https://api.github.com/repos/Blazemeter/taurus/branches{/branch}","tags_url":"https://api.github.com/repos/Blazemeter/taurus/tags","blobs_url":"https://api.github.com/repos/Blazemeter/taurus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blazemeter/taurus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blazemeter/taurus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blazemeter/taurus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blazemeter/taurus/statuses/{sha}","languages_url":"https://api.github.com/repos/Blazemeter/taurus/languages","stargazers_url":"https://api.github.com/repos/Blazemeter/taurus/stargazers","contributors_url":"https://api.github.com/repos/Blazemeter/taurus/contributors","subscribers_url":"https://api.github.com/repos/Blazemeter/taurus/subscribers","subscription_url":"https://api.github.com/repos/Blazemeter/taurus/subscription","commits_url":"https://api.github.com/repos/Blazemeter/taurus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blazemeter/taurus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blazemeter/taurus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blazemeter/taurus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blazemeter/taurus/contents/{+path}","compare_url":"https://api.github.com/repos/Blazemeter/taurus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blazemeter/taurus/merges","archive_url":"https://api.github.com/repos/Blazemeter/taurus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blazemeter/taurus/downloads","issues_url":"https://api.github.com/repos/Blazemeter/taurus/issues{/number}","pulls_url":"https://api.github.com/repos/Blazemeter/taurus/pulls{/number}","milestones_url":"https://api.github.com/repos/Blazemeter/taurus/milestones{/number}","notifications_url":"https://api.github.com/repos/Blazemeter/taurus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blazemeter/taurus/labels{/name}","releases_url":"https://api.github.com/repos/Blazemeter/taurus/releases{/id}","deployments_url":"https://api.github.com/repos/Blazemeter/taurus/deployments","created_at":"2015-02-17T22:05:08Z","updated_at":"2016-09-01T03:52:18Z","pushed_at":"2016-09-01T09:51:07Z","git_url":"git://github.com/Blazemeter/taurus.git","ssh_url":"git@github.com:Blazemeter/taurus.git","clone_url":"https://github.com/Blazemeter/taurus.git","svn_url":"https://github.com/Blazemeter/taurus","homepage":"http://gettaurus.org","size":8318,"stargazers_count":219,"watchers_count":219,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":5,"forks":52,"open_issues":5,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/321"},"html":{"href":"https://github.com/Blazemeter/taurus/pull/321"},"issue":{"href":"https://api.github.com/repos/Blazemeter/taurus/issues/321"},"comments":{"href":"https://api.github.com/repos/Blazemeter/taurus/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/Blazemeter/taurus/statuses/1d208fe9020560d334651cd8a6d21a9a2f0c849b"}}}}
{"actor":{"display_login":"dmand"}}