{"action":"created","comment":{"url":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/comments/74379512","id":74379512,"diff_hunk":"@@ -135,11 +140,29 @@ class Dropdown extends hx.EventEmitter\n     if @isOpen() then @hide(cb) else @show(cb)\n     this\n \n+  dropdownContent: (dropdownContent, cb) ->\n+    if arguments.length\n+      setupDropdown = dropdownContentToSetupDropdown dropdownContent\n+      @_.dropdownContent = dropdownContent\n+      @_ = hx.shallowMerge @_, {\n+        setupDropdown,\n+        dropdownContent\n+      }","path":"modules/dropdown/main/index.coffee","position":55,"original_position":55,"commit_id":"45ba93705674049a3f9fd95c5dd7ed82dc99b250","original_commit_id":"45ba93705674049a3f9fd95c5dd7ed82dc99b250","user":{"login":"c-frater","id":3194349,"avatar_url":"https://avatars.githubusercontent.com/u/3194349?v=3","gravatar_id":"","url":"https://api.github.com/users/c-frater","html_url":"https://github.com/c-frater","followers_url":"https://api.github.com/users/c-frater/followers","following_url":"https://api.github.com/users/c-frater/following{/other_user}","gists_url":"https://api.github.com/users/c-frater/gists{/gist_id}","starred_url":"https://api.github.com/users/c-frater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-frater/subscriptions","organizations_url":"https://api.github.com/users/c-frater/orgs","repos_url":"https://api.github.com/users/c-frater/repos","events_url":"https://api.github.com/users/c-frater/events{/privacy}","received_events_url":"https://api.github.com/users/c-frater/received_events","type":"User","site_admin":false},"body":"Unless I've misunderstood why we're doing this, you're essentially setting dropdown content twice - we could remove the `shallowMerge` and just set `@_.setupDropdown` if `setupDropdown` is defined?\r\n\r\nAlso, if you set `setupDropdown` to be invalid, should we still attempt to render?","created_at":"2016-08-11T07:44:08Z","updated_at":"2016-08-11T07:44:08Z","html_url":"https://github.com/ocadotechnology/hexagonjs/pull/294#discussion_r74379512","pull_request_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/comments/74379512"},"html":{"href":"https://github.com/ocadotechnology/hexagonjs/pull/294#discussion_r74379512"},"pull_request":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/294","id":80824968,"html_url":"https://github.com/ocadotechnology/hexagonjs/pull/294","diff_url":"https://github.com/ocadotechnology/hexagonjs/pull/294.diff","patch_url":"https://github.com/ocadotechnology/hexagonjs/pull/294.patch","issue_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues/294","number":294,"state":"open","locked":false,"title":"#180: Make dropdowns reusable","user":{"login":"georgesimms","id":7927477,"avatar_url":"https://avatars.githubusercontent.com/u/7927477?v=3","gravatar_id":"","url":"https://api.github.com/users/georgesimms","html_url":"https://github.com/georgesimms","followers_url":"https://api.github.com/users/georgesimms/followers","following_url":"https://api.github.com/users/georgesimms/following{/other_user}","gists_url":"https://api.github.com/users/georgesimms/gists{/gist_id}","starred_url":"https://api.github.com/users/georgesimms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgesimms/subscriptions","organizations_url":"https://api.github.com/users/georgesimms/orgs","repos_url":"https://api.github.com/users/georgesimms/repos","events_url":"https://api.github.com/users/georgesimms/events{/privacy}","received_events_url":"https://api.github.com/users/georgesimms/received_events","type":"User","site_admin":false},"body":"resolves #180 ","created_at":"2016-08-10T16:25:52Z","updated_at":"2016-08-11T07:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ee95ce8439618c50ba8b51c7cd12bff656fbc69","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/294/commits","review_comments_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/294/comments","review_comment_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues/294/comments","statuses_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/statuses/45ba93705674049a3f9fd95c5dd7ed82dc99b250","head":{"label":"ocadotechnology:180-reusability-of-dropdowns","ref":"180-reusability-of-dropdowns","sha":"45ba93705674049a3f9fd95c5dd7ed82dc99b250","user":{"login":"ocadotechnology","id":2088731,"avatar_url":"https://avatars.githubusercontent.com/u/2088731?v=3","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":47334865,"name":"hexagonjs","full_name":"ocadotechnology/hexagonjs","owner":{"login":"ocadotechnology","id":2088731,"avatar_url":"https://avatars.githubusercontent.com/u/2088731?v=3","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocadotechnology/hexagonjs","description":"A modular, themable collection of components for modern browsers","fork":false,"url":"https://api.github.com/repos/ocadotechnology/hexagonjs","forks_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/forks","keys_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/teams","hooks_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/hooks","issue_events_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues/events{/number}","events_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/events","assignees_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/assignees{/user}","branches_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/branches{/branch}","tags_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/tags","blobs_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/languages","stargazers_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/stargazers","contributors_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/contributors","subscribers_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/subscribers","subscription_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/subscription","commits_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/contents/{+path}","compare_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/merges","archive_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/downloads","issues_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues{/number}","pulls_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/labels{/name}","releases_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/releases{/id}","deployments_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/deployments","created_at":"2015-12-03T13:49:12Z","updated_at":"2016-07-13T17:13:05Z","pushed_at":"2016-08-10T16:25:52Z","git_url":"git://github.com/ocadotechnology/hexagonjs.git","ssh_url":"git@github.com:ocadotechnology/hexagonjs.git","clone_url":"https://github.com/ocadotechnology/hexagonjs.git","svn_url":"https://github.com/ocadotechnology/hexagonjs","homepage":"https://www.hexagonjs.io","size":2235,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":108,"forks":9,"open_issues":108,"watchers":39,"default_branch":"master"}},"base":{"label":"ocadotechnology:master","ref":"master","sha":"3ea6abd2b647b0fe226ac10627efa199ea2e8536","user":{"login":"ocadotechnology","id":2088731,"avatar_url":"https://avatars.githubusercontent.com/u/2088731?v=3","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":47334865,"name":"hexagonjs","full_name":"ocadotechnology/hexagonjs","owner":{"login":"ocadotechnology","id":2088731,"avatar_url":"https://avatars.githubusercontent.com/u/2088731?v=3","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocadotechnology/hexagonjs","description":"A modular, themable collection of components for modern browsers","fork":false,"url":"https://api.github.com/repos/ocadotechnology/hexagonjs","forks_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/forks","keys_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/teams","hooks_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/hooks","issue_events_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues/events{/number}","events_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/events","assignees_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/assignees{/user}","branches_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/branches{/branch}","tags_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/tags","blobs_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/languages","stargazers_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/stargazers","contributors_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/contributors","subscribers_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/subscribers","subscription_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/subscription","commits_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/contents/{+path}","compare_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/merges","archive_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/downloads","issues_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues{/number}","pulls_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/labels{/name}","releases_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/releases{/id}","deployments_url":"https://api.github.com/repos/ocadotechnology/hexagonjs/deployments","created_at":"2015-12-03T13:49:12Z","updated_at":"2016-07-13T17:13:05Z","pushed_at":"2016-08-10T16:25:52Z","git_url":"git://github.com/ocadotechnology/hexagonjs.git","ssh_url":"git@github.com:ocadotechnology/hexagonjs.git","clone_url":"https://github.com/ocadotechnology/hexagonjs.git","svn_url":"https://github.com/ocadotechnology/hexagonjs","homepage":"https://www.hexagonjs.io","size":2235,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":108,"forks":9,"open_issues":108,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/294"},"html":{"href":"https://github.com/ocadotechnology/hexagonjs/pull/294"},"issue":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues/294"},"comments":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/ocadotechnology/hexagonjs/statuses/45ba93705674049a3f9fd95c5dd7ed82dc99b250"}}}}
{"actor":{"display_login":"c-frater"}}