{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments/91450619","pull_request_review_id":11958386,"id":91450619,"diff_hunk":"@@ -32,7 +32,9 @@ install:\n   - npm install && npm run lint\n \n script:\n-  - npm run build_spec && npm run test_mocha && node ./node_modules/markdown-doctest/bin/cmd.js\n+  - npm install typescript@2.0.7 && npm run build_spec && npm run test_mocha\n+  - npm install typescript@latest && npm run build_spec && npm run test_mocha","path":".travis.yml","position":6,"original_position":6,"commit_id":"58b357c92d003a25012486d355d6f8048e362c63","original_commit_id":"58b357c92d003a25012486d355d6f8048e362c63","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"body":"If it's certain new feature like module argumentation, I'd agree that. But for this case, I see no strong reason to not to keep compatibility between 2 versions, especially given custom object is expected to inherit Error Object itself. This test is guarding 'current' change to be safe with previous version of TS, while further version comes out and if decided to introduce version specific breaking changes can be taken out.","created_at":"2016-12-08T06:06:22Z","updated_at":"2016-12-08T06:06:22Z","html_url":"https://github.com/ReactiveX/rxjs/pull/2181#discussion_r91450619","pull_request_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2181","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments/91450619"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/2181#discussion_r91450619"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2181"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2181","id":97056722,"html_url":"https://github.com/ReactiveX/rxjs/pull/2181","diff_url":"https://github.com/ReactiveX/rxjs/pull/2181.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/2181.patch","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2181","number":2181,"state":"open","locked":false,"title":"Patch custom Error object to inherit base Error","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you very much for your pull request!\r\n\r\nIf your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:\r\n\r\n- [ ] Add the operator to Rx\r\n- [ ] It must have a `-spec.ts` tests file covering the canonical corner cases, with marble diagram tests\r\n- [ ] If possible, write a `asDiagram` test case too, for PNG diagram generation purposes\r\n- [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases\r\n- [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image\r\n- [ ] The operator should be listed in `doc/operators.md` in a category of operators\r\n- [ ] It should also be inserted in the operator decision tree file `doc/decision-tree-widget/tree.yml`\r\n- [ ] You may need to update `MIGRATION.md` if the operator differs from the corresponding one in RxJS v4\r\n-->\r\n\r\n**Description:**\r\nPer breaking changes of TS 2.1 (https://github.com/Microsoft/TypeScript-wiki/blob/master/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work) Inheriting built in object no longer gives prototype chain. This PR updates each custom error object to have prototype of Error.\r\n\r\n**Related issue (if exists):**\r\n#2178 \r\n\r\n*BREAKING CHANGE*: This change drops support of IE 10 and prior\r\n","created_at":"2016-12-08T04:18:59Z","updated_at":"2016-12-08T06:06:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"267ac953e091b515f3ebc25dd5c62d652e858fe0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2181/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2181/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2181/comments","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/58b357c92d003a25012486d355d6f8048e362c63","head":{"label":"kwonoj:fix-error-object","ref":"fix-error-object","sha":"58b357c92d003a25012486d355d6f8048e362c63","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"repo":{"id":41501851,"name":"RxJS","full_name":"kwonoj/RxJS","owner":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwonoj/RxJS","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/kwonoj/RxJS","forks_url":"https://api.github.com/repos/kwonoj/RxJS/forks","keys_url":"https://api.github.com/repos/kwonoj/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwonoj/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwonoj/RxJS/teams","hooks_url":"https://api.github.com/repos/kwonoj/RxJS/hooks","issue_events_url":"https://api.github.com/repos/kwonoj/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/kwonoj/RxJS/events","assignees_url":"https://api.github.com/repos/kwonoj/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/kwonoj/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/kwonoj/RxJS/tags","blobs_url":"https://api.github.com/repos/kwonoj/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwonoj/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwonoj/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwonoj/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwonoj/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/kwonoj/RxJS/languages","stargazers_url":"https://api.github.com/repos/kwonoj/RxJS/stargazers","contributors_url":"https://api.github.com/repos/kwonoj/RxJS/contributors","subscribers_url":"https://api.github.com/repos/kwonoj/RxJS/subscribers","subscription_url":"https://api.github.com/repos/kwonoj/RxJS/subscription","commits_url":"https://api.github.com/repos/kwonoj/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwonoj/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwonoj/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwonoj/RxJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwonoj/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/kwonoj/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwonoj/RxJS/merges","archive_url":"https://api.github.com/repos/kwonoj/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwonoj/RxJS/downloads","issues_url":"https://api.github.com/repos/kwonoj/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/kwonoj/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/kwonoj/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/kwonoj/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwonoj/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/kwonoj/RxJS/releases{/id}","deployments_url":"https://api.github.com/repos/kwonoj/RxJS/deployments","created_at":"2015-08-27T17:41:24Z","updated_at":"2016-03-01T17:53:11Z","pushed_at":"2016-12-08T04:16:22Z","git_url":"git://github.com/kwonoj/RxJS.git","ssh_url":"git@github.com:kwonoj/RxJS.git","clone_url":"https://github.com/kwonoj/RxJS.git","svn_url":"https://github.com/kwonoj/RxJS","homepage":null,"size":6403,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:master","ref":"master","sha":"89b506d20485b7e849f53cc34a7d35f16773d27c","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"name":"rxjs","full_name":"ReactiveX/rxjs","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/rxjs","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/rxjs","forks_url":"https://api.github.com/repos/ReactiveX/rxjs/forks","keys_url":"https://api.github.com/repos/ReactiveX/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/rxjs/teams","hooks_url":"https://api.github.com/repos/ReactiveX/rxjs/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/rxjs/events","assignees_url":"https://api.github.com/repos/ReactiveX/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/rxjs/tags","blobs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/rxjs/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/rxjs/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/rxjs/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/rxjs/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/rxjs/subscription","commits_url":"https://api.github.com/repos/ReactiveX/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/rxjs/merges","archive_url":"https://api.github.com/repos/ReactiveX/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/rxjs/downloads","issues_url":"https://api.github.com/repos/ReactiveX/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/rxjs/deployments","created_at":"2015-03-15T06:17:10Z","updated_at":"2016-12-08T03:07:01Z","pushed_at":"2016-12-08T05:43:58Z","git_url":"git://github.com/ReactiveX/rxjs.git","ssh_url":"git@github.com:ReactiveX/rxjs.git","clone_url":"https://github.com/ReactiveX/rxjs.git","svn_url":"https://github.com/ReactiveX/rxjs","homepage":"http://reactivex.io/rxjs","size":58596,"stargazers_count":4164,"watchers_count":4164,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":368,"mirror_url":null,"open_issues_count":152,"forks":368,"open_issues":152,"watchers":4164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2181"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/2181"},"issue":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/2181"},"comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/2181/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2181/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2181/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/rxjs/statuses/58b357c92d003a25012486d355d6f8048e362c63"}}}}
{"actor":{"display_login":"kwonoj"}}