{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/comments/68038796","id":68038796,"diff_hunk":"@@ -78,14 +78,16 @@ YUI.add('ez-richtext-resolveembed', function (Y) {\n      * @param {eZ.FieldView|eZ.FieldEditView} view\n      */\n     ResolveEmbed.prototype._loadEmbeds = function (mapNode, view) {\n-        view.fire('contentSearch', {\n-            viewName: 'resolveembed-field-' + view.get('field').id,\n-            search: {\n-                criteria: {'ContentIdCriterion': Object.keys(mapNode).join(',')},\n-                offset: 0,\n-            },\n-            callback: Y.bind(this._renderEmbed, this, mapNode),\n-        });\n+        if(0 !== Object.keys(mapNode).length) {","path":"Resources/public/js/views/fields/richtext/ez-richtext-resolveembed.js","position":12,"original_position":12,"commit_id":"6853cc0f67333ec35b16cc9c0d9c446d9f75b08e","original_commit_id":"6853cc0f67333ec35b16cc9c0d9c446d9f75b08e","user":{"login":"dpobel","id":305563,"avatar_url":"https://avatars.githubusercontent.com/u/305563?v=3","gravatar_id":"","url":"https://api.github.com/users/dpobel","html_url":"https://github.com/dpobel","followers_url":"https://api.github.com/users/dpobel/followers","following_url":"https://api.github.com/users/dpobel/following{/other_user}","gists_url":"https://api.github.com/users/dpobel/gists{/gist_id}","starred_url":"https://api.github.com/users/dpobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpobel/subscriptions","organizations_url":"https://api.github.com/users/dpobel/orgs","repos_url":"https://api.github.com/users/dpobel/repos","events_url":"https://api.github.com/users/dpobel/events{/privacy}","received_events_url":"https://api.github.com/users/dpobel/received_events","type":"User","site_admin":false},"body":"I think this is not the correct place for the condition. I would instead check `embeds.size()` in `ResolveEmbed.prototype.process` that way both resolver would be fixed with one change.","created_at":"2016-06-22T11:49:12Z","updated_at":"2016-06-22T11:49:12Z","html_url":"https://github.com/ezsystems/PlatformUIBundle/pull/623#discussion_r68038796","pull_request_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/623","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/comments/68038796"},"html":{"href":"https://github.com/ezsystems/PlatformUIBundle/pull/623#discussion_r68038796"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/623"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/623","id":74562991,"html_url":"https://github.com/ezsystems/PlatformUIBundle/pull/623","diff_url":"https://github.com/ezsystems/PlatformUIBundle/pull/623.diff","patch_url":"https://github.com/ezsystems/PlatformUIBundle/pull/623.patch","issue_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/623","number":623,"state":"open","locked":false,"title":"Call api only if content id is not empty and reformat list","user":{"login":"mathieupoulenard","id":7288473,"avatar_url":"https://avatars.githubusercontent.com/u/7288473?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieupoulenard","html_url":"https://github.com/mathieupoulenard","followers_url":"https://api.github.com/users/mathieupoulenard/followers","following_url":"https://api.github.com/users/mathieupoulenard/following{/other_user}","gists_url":"https://api.github.com/users/mathieupoulenard/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieupoulenard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieupoulenard/subscriptions","organizations_url":"https://api.github.com/users/mathieupoulenard/orgs","repos_url":"https://api.github.com/users/mathieupoulenard/repos","events_url":"https://api.github.com/users/mathieupoulenard/events{/privacy}","received_events_url":"https://api.github.com/users/mathieupoulenard/received_events","type":"User","site_admin":false},"body":"richtext embed : call api only if object contains ids\r\nsearch-plugin : avoid list ids start with a comma (cause bad SQL request\r\nand fail on postgresql databases)","created_at":"2016-06-21T07:27:55Z","updated_at":"2016-06-22T11:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e672e24858f5424693846bc3532ca83323a5a39f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/623/commits","review_comments_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/623/comments","review_comment_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/623/comments","statuses_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/statuses/6853cc0f67333ec35b16cc9c0d9c446d9f75b08e","head":{"label":"mathieupoulenard:avoid_call_api_empty_id","ref":"avoid_call_api_empty_id","sha":"6853cc0f67333ec35b16cc9c0d9c446d9f75b08e","user":{"login":"mathieupoulenard","id":7288473,"avatar_url":"https://avatars.githubusercontent.com/u/7288473?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieupoulenard","html_url":"https://github.com/mathieupoulenard","followers_url":"https://api.github.com/users/mathieupoulenard/followers","following_url":"https://api.github.com/users/mathieupoulenard/following{/other_user}","gists_url":"https://api.github.com/users/mathieupoulenard/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieupoulenard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieupoulenard/subscriptions","organizations_url":"https://api.github.com/users/mathieupoulenard/orgs","repos_url":"https://api.github.com/users/mathieupoulenard/repos","events_url":"https://api.github.com/users/mathieupoulenard/events{/privacy}","received_events_url":"https://api.github.com/users/mathieupoulenard/received_events","type":"User","site_admin":false},"repo":{"id":61610155,"name":"PlatformUIBundle","full_name":"mathieupoulenard/PlatformUIBundle","owner":{"login":"mathieupoulenard","id":7288473,"avatar_url":"https://avatars.githubusercontent.com/u/7288473?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieupoulenard","html_url":"https://github.com/mathieupoulenard","followers_url":"https://api.github.com/users/mathieupoulenard/followers","following_url":"https://api.github.com/users/mathieupoulenard/following{/other_user}","gists_url":"https://api.github.com/users/mathieupoulenard/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieupoulenard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieupoulenard/subscriptions","organizations_url":"https://api.github.com/users/mathieupoulenard/orgs","repos_url":"https://api.github.com/users/mathieupoulenard/repos","events_url":"https://api.github.com/users/mathieupoulenard/events{/privacy}","received_events_url":"https://api.github.com/users/mathieupoulenard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathieupoulenard/PlatformUIBundle","description":"Main Bundle to provide editorial/admin UI for eZ Platform","fork":true,"url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle","forks_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/forks","keys_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/teams","hooks_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/hooks","issue_events_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/issues/events{/number}","events_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/events","assignees_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/assignees{/user}","branches_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/branches{/branch}","tags_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/tags","blobs_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/languages","stargazers_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/stargazers","contributors_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/contributors","subscribers_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/subscribers","subscription_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/subscription","commits_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/contents/{+path}","compare_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/merges","archive_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/downloads","issues_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/issues{/number}","pulls_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/labels{/name}","releases_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/releases{/id}","deployments_url":"https://api.github.com/repos/mathieupoulenard/PlatformUIBundle/deployments","created_at":"2016-06-21T06:59:39Z","updated_at":"2016-06-21T06:59:43Z","pushed_at":"2016-06-22T08:27:31Z","git_url":"git://github.com/mathieupoulenard/PlatformUIBundle.git","ssh_url":"git@github.com:mathieupoulenard/PlatformUIBundle.git","clone_url":"https://github.com/mathieupoulenard/PlatformUIBundle.git","svn_url":"https://github.com/mathieupoulenard/PlatformUIBundle","homepage":"http://ezplatform.com/","size":5796,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"b8277d6e33d6ac84111c04c4741677a90ee0904d","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":11221607,"name":"PlatformUIBundle","full_name":"ezsystems/PlatformUIBundle","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/PlatformUIBundle","description":"Main Bundle to provide editorial/admin UI for eZ Platform","fork":false,"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle","forks_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/forks","keys_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/teams","hooks_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/events","assignees_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/tags","blobs_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/languages","stargazers_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/subscription","commits_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/merges","archive_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/downloads","issues_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/deployments","created_at":"2013-07-06T17:21:40Z","updated_at":"2016-05-09T21:15:01Z","pushed_at":"2016-06-22T11:27:57Z","git_url":"git://github.com/ezsystems/PlatformUIBundle.git","ssh_url":"git@github.com:ezsystems/PlatformUIBundle.git","clone_url":"https://github.com/ezsystems/PlatformUIBundle.git","svn_url":"https://github.com/ezsystems/PlatformUIBundle","homepage":"http://ezplatform.com/","size":6999,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":18,"forks":31,"open_issues":18,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/623"},"html":{"href":"https://github.com/ezsystems/PlatformUIBundle/pull/623"},"issue":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/623"},"comments":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/PlatformUIBundle/statuses/6853cc0f67333ec35b16cc9c0d9c446d9f75b08e"}}}}
{"actor":{"display_login":"dpobel"}}