{"action":"created","comment":{"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments/91297588","pull_request_review_id":11805274,"id":91297588,"diff_hunk":"@@ -1,18 +1,25 @@\n import React from 'react';\n import Button from '/imports/ui/components/button/component';\n+import styles from '../styles.scss';\n \n export default class MuteAudioComponent extends React.Component {\n \n   render() {\n-    const { isMuted, muteUser, unmuteUser } = this.props;\n+    const { isInAudio, isMuted, muteUser, unmuteUser } = this.props;\n     let onClick = muteUser;\n     let label = 'Mute';\n+    let cn = !isInAudio ? styles.invisible : null;\n+    let ti = !isInAudio ? -1 : 0;","path":"bigbluebutton-html5/imports/ui/components/actions-bar/mute-button/component.jsx","position":13,"original_position":13,"commit_id":"6f300b4832c21ed405c196df42cd661615c4cf41","original_commit_id":"6f300b4832c21ed405c196df42cd661615c4cf41","user":{"login":"oswaldoacauan","id":1268518,"avatar_url":"https://avatars.githubusercontent.com/u/1268518?v=3","gravatar_id":"","url":"https://api.github.com/users/oswaldoacauan","html_url":"https://github.com/oswaldoacauan","followers_url":"https://api.github.com/users/oswaldoacauan/followers","following_url":"https://api.github.com/users/oswaldoacauan/following{/other_user}","gists_url":"https://api.github.com/users/oswaldoacauan/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldoacauan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldoacauan/subscriptions","organizations_url":"https://api.github.com/users/oswaldoacauan/orgs","repos_url":"https://api.github.com/users/oswaldoacauan/repos","events_url":"https://api.github.com/users/oswaldoacauan/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldoacauan/received_events","type":"User","site_admin":false},"body":"Always prefer long but meaningful variable names than short ones meaningless.\r\n\r\n`classNames` and `tabIndex` would be my suggestions.","created_at":"2016-12-07T14:00:25Z","updated_at":"2016-12-07T14:07:31Z","html_url":"https://github.com/bigbluebutton/bigbluebutton/pull/3497#discussion_r91297588","pull_request_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3497","_links":{"self":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments/91297588"},"html":{"href":"https://github.com/bigbluebutton/bigbluebutton/pull/3497#discussion_r91297588"},"pull_request":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3497"}}},"pull_request":{"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3497","id":96808463,"html_url":"https://github.com/bigbluebutton/bigbluebutton/pull/3497","diff_url":"https://github.com/bigbluebutton/bigbluebutton/pull/3497.diff","patch_url":"https://github.com/bigbluebutton/bigbluebutton/pull/3497.patch","issue_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/3497","number":3497,"state":"open","locked":false,"title":"Action bar & join audio improvements","user":{"login":"mmarangoni","id":19309282,"avatar_url":"https://avatars.githubusercontent.com/u/19309282?v=3","gravatar_id":"","url":"https://api.github.com/users/mmarangoni","html_url":"https://github.com/mmarangoni","followers_url":"https://api.github.com/users/mmarangoni/followers","following_url":"https://api.github.com/users/mmarangoni/following{/other_user}","gists_url":"https://api.github.com/users/mmarangoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarangoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarangoni/subscriptions","organizations_url":"https://api.github.com/users/mmarangoni/orgs","repos_url":"https://api.github.com/users/mmarangoni/repos","events_url":"https://api.github.com/users/mmarangoni/events{/privacy}","received_events_url":"https://api.github.com/users/mmarangoni/received_events","type":"User","site_admin":false},"body":"- isolated mute audio container, no longer depends on join audio button\r\n- join audio modal closes automatically after joining in listen only mode\r\n- mute button appearing/disappearing after joining/leaving audio no longer causes the other buttons on the actions bar to change location (if a button label changes it will still slightly shift other buttons around if the text is longer or shorter)","created_at":"2016-12-06T21:24:15Z","updated_at":"2016-12-07T14:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d550986dc120a96ec9bf84d70653f18e358f3110","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3497/commits","review_comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3497/comments","review_comment_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/3497/comments","statuses_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/6f300b4832c21ed405c196df42cd661615c4cf41","head":{"label":"mmarangoni:html5-stun-audio","ref":"html5-stun-audio","sha":"6f300b4832c21ed405c196df42cd661615c4cf41","user":{"login":"mmarangoni","id":19309282,"avatar_url":"https://avatars.githubusercontent.com/u/19309282?v=3","gravatar_id":"","url":"https://api.github.com/users/mmarangoni","html_url":"https://github.com/mmarangoni","followers_url":"https://api.github.com/users/mmarangoni/followers","following_url":"https://api.github.com/users/mmarangoni/following{/other_user}","gists_url":"https://api.github.com/users/mmarangoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarangoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarangoni/subscriptions","organizations_url":"https://api.github.com/users/mmarangoni/orgs","repos_url":"https://api.github.com/users/mmarangoni/repos","events_url":"https://api.github.com/users/mmarangoni/events{/privacy}","received_events_url":"https://api.github.com/users/mmarangoni/received_events","type":"User","site_admin":false},"repo":{"id":59234666,"name":"bigbluebutton","full_name":"mmarangoni/bigbluebutton","owner":{"login":"mmarangoni","id":19309282,"avatar_url":"https://avatars.githubusercontent.com/u/19309282?v=3","gravatar_id":"","url":"https://api.github.com/users/mmarangoni","html_url":"https://github.com/mmarangoni","followers_url":"https://api.github.com/users/mmarangoni/followers","following_url":"https://api.github.com/users/mmarangoni/following{/other_user}","gists_url":"https://api.github.com/users/mmarangoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarangoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarangoni/subscriptions","organizations_url":"https://api.github.com/users/mmarangoni/orgs","repos_url":"https://api.github.com/users/mmarangoni/repos","events_url":"https://api.github.com/users/mmarangoni/events{/privacy}","received_events_url":"https://api.github.com/users/mmarangoni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmarangoni/bigbluebutton","description":"BigBlueButton is an open source web conferencing system for on-line learning.","fork":true,"url":"https://api.github.com/repos/mmarangoni/bigbluebutton","forks_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/forks","keys_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/teams","hooks_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/hooks","issue_events_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/issues/events{/number}","events_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/events","assignees_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/assignees{/user}","branches_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/branches{/branch}","tags_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/tags","blobs_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/statuses/{sha}","languages_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/languages","stargazers_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/stargazers","contributors_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/contributors","subscribers_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/subscribers","subscription_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/subscription","commits_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/contents/{+path}","compare_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/merges","archive_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/downloads","issues_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/issues{/number}","pulls_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/pulls{/number}","milestones_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/milestones{/number}","notifications_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/labels{/name}","releases_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/releases{/id}","deployments_url":"https://api.github.com/repos/mmarangoni/bigbluebutton/deployments","created_at":"2016-05-19T19:12:10Z","updated_at":"2016-05-19T19:12:22Z","pushed_at":"2016-12-06T21:15:50Z","git_url":"git://github.com/mmarangoni/bigbluebutton.git","ssh_url":"git@github.com:mmarangoni/bigbluebutton.git","clone_url":"https://github.com/mmarangoni/bigbluebutton.git","svn_url":"https://github.com/mmarangoni/bigbluebutton","homepage":"www.bigbluebutton.org","size":499405,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigbluebutton:master","ref":"master","sha":"7d982caf99a51f2f0d23599378fe5585008dcb51","user":{"login":"bigbluebutton","id":230228,"avatar_url":"https://avatars.githubusercontent.com/u/230228?v=3","gravatar_id":"","url":"https://api.github.com/users/bigbluebutton","html_url":"https://github.com/bigbluebutton","followers_url":"https://api.github.com/users/bigbluebutton/followers","following_url":"https://api.github.com/users/bigbluebutton/following{/other_user}","gists_url":"https://api.github.com/users/bigbluebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/bigbluebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigbluebutton/subscriptions","organizations_url":"https://api.github.com/users/bigbluebutton/orgs","repos_url":"https://api.github.com/users/bigbluebutton/repos","events_url":"https://api.github.com/users/bigbluebutton/events{/privacy}","received_events_url":"https://api.github.com/users/bigbluebutton/received_events","type":"Organization","site_admin":false},"repo":{"id":684382,"name":"bigbluebutton","full_name":"bigbluebutton/bigbluebutton","owner":{"login":"bigbluebutton","id":230228,"avatar_url":"https://avatars.githubusercontent.com/u/230228?v=3","gravatar_id":"","url":"https://api.github.com/users/bigbluebutton","html_url":"https://github.com/bigbluebutton","followers_url":"https://api.github.com/users/bigbluebutton/followers","following_url":"https://api.github.com/users/bigbluebutton/following{/other_user}","gists_url":"https://api.github.com/users/bigbluebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/bigbluebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigbluebutton/subscriptions","organizations_url":"https://api.github.com/users/bigbluebutton/orgs","repos_url":"https://api.github.com/users/bigbluebutton/repos","events_url":"https://api.github.com/users/bigbluebutton/events{/privacy}","received_events_url":"https://api.github.com/users/bigbluebutton/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigbluebutton/bigbluebutton","description":"BigBlueButton is an open source web conferencing system for on-line learning.","fork":false,"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton","forks_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/forks","keys_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/teams","hooks_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/hooks","issue_events_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/events{/number}","events_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/events","assignees_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/assignees{/user}","branches_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/branches{/branch}","tags_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/tags","blobs_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/{sha}","languages_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/languages","stargazers_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/stargazers","contributors_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/contributors","subscribers_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/subscribers","subscription_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/subscription","commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/contents/{+path}","compare_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/merges","archive_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/downloads","issues_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues{/number}","pulls_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls{/number}","milestones_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/milestones{/number}","notifications_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/labels{/name}","releases_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/releases{/id}","deployments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/deployments","created_at":"2010-05-25T01:42:41Z","updated_at":"2016-12-06T09:21:00Z","pushed_at":"2016-12-07T13:53:32Z","git_url":"git://github.com/bigbluebutton/bigbluebutton.git","ssh_url":"git@github.com:bigbluebutton/bigbluebutton.git","clone_url":"https://github.com/bigbluebutton/bigbluebutton.git","svn_url":"https://github.com/bigbluebutton/bigbluebutton","homepage":"www.bigbluebutton.org","size":550227,"stargazers_count":1683,"watchers_count":1683,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3217,"mirror_url":null,"open_issues_count":389,"forks":3217,"open_issues":389,"watchers":1683,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3497"},"html":{"href":"https://github.com/bigbluebutton/bigbluebutton/pull/3497"},"issue":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/3497"},"comments":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/3497/comments"},"review_comments":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3497/comments"},"review_comment":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3497/commits"},"statuses":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/6f300b4832c21ed405c196df42cd661615c4cf41"}}}}
{"actor":{"display_login":"oswaldoacauan"}}