{"action":"created","issue":{"url":"https://api.github.com/repos/NancyFx/Nancy/issues/2471","repository_url":"https://api.github.com/repos/NancyFx/Nancy","labels_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2471/labels{/name}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2471/comments","events_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2471/events","html_url":"https://github.com/NancyFx/Nancy/issues/2471","id":157422562,"number":2471,"title":"Should ConfigureAwait(false) be called in NancyHost?","user":{"login":"xt0rted","id":831974,"avatar_url":"https://avatars.githubusercontent.com/u/831974?v=3","gravatar_id":"","url":"https://api.github.com/users/xt0rted","html_url":"https://github.com/xt0rted","followers_url":"https://api.github.com/users/xt0rted/followers","following_url":"https://api.github.com/users/xt0rted/following{/other_user}","gists_url":"https://api.github.com/users/xt0rted/gists{/gist_id}","starred_url":"https://api.github.com/users/xt0rted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xt0rted/subscriptions","organizations_url":"https://api.github.com/users/xt0rted/orgs","repos_url":"https://api.github.com/users/xt0rted/repos","events_url":"https://api.github.com/users/xt0rted/events{/privacy}","received_events_url":"https://api.github.com/users/xt0rted/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NancyFx/Nancy/milestones/48","html_url":"https://github.com/NancyFx/Nancy/milestones/2.0-clinteastwood","labels_url":"https://api.github.com/repos/NancyFx/Nancy/milestones/48/labels","id":1883192,"number":48,"title":"2.0-clinteastwood","description":"","creator":{"login":"jchannon","id":105126,"avatar_url":"https://avatars.githubusercontent.com/u/105126?v=3","gravatar_id":"","url":"https://api.github.com/users/jchannon","html_url":"https://github.com/jchannon","followers_url":"https://api.github.com/users/jchannon/followers","following_url":"https://api.github.com/users/jchannon/following{/other_user}","gists_url":"https://api.github.com/users/jchannon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchannon/subscriptions","organizations_url":"https://api.github.com/users/jchannon/orgs","repos_url":"https://api.github.com/users/jchannon/repos","events_url":"https://api.github.com/users/jchannon/events{/privacy}","received_events_url":"https://api.github.com/users/jchannon/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":14,"state":"open","created_at":"2016-07-14T12:37:56Z","updated_at":"2016-08-30T11:40:21Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-05-30T02:47:01Z","updated_at":"2016-08-30T11:41:46Z","closed_at":null,"body":"While looking through the code and using the ReSharper [ConfigureAwait Checker](https://github.com/aelij/ConfigureAwaitChecker/) plugin I came across [Nancy.Hosting.Self/NancyHost.cs#L133-134](https://github.com/NancyFx/Nancy/blob/bc44cd30d58ce1b6c7930452304d187248038e18/src/Nancy.Hosting.Self/NancyHost.cs#L133-134).\r\n\r\nShould line 133 and/or 134 call `.ConfigureAwait(false)`? The other warning I'm getting is on line 134 because it's not awaited but I wasn't sure if that should be or not.\r\n\r\nThose are the only two spots outside of the test projects that don't call ConfigureAwait."},"comment":{"url":"https://api.github.com/repos/NancyFx/Nancy/issues/comments/243412885","html_url":"https://github.com/NancyFx/Nancy/issues/2471#issuecomment-243412885","issue_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2471","id":243412885,"user":{"login":"thecodejunkie","id":50543,"avatar_url":"https://avatars.githubusercontent.com/u/50543?v=3","gravatar_id":"","url":"https://api.github.com/users/thecodejunkie","html_url":"https://github.com/thecodejunkie","followers_url":"https://api.github.com/users/thecodejunkie/followers","following_url":"https://api.github.com/users/thecodejunkie/following{/other_user}","gists_url":"https://api.github.com/users/thecodejunkie/gists{/gist_id}","starred_url":"https://api.github.com/users/thecodejunkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecodejunkie/subscriptions","organizations_url":"https://api.github.com/users/thecodejunkie/orgs","repos_url":"https://api.github.com/users/thecodejunkie/repos","events_url":"https://api.github.com/users/thecodejunkie/events{/privacy}","received_events_url":"https://api.github.com/users/thecodejunkie/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T11:41:46Z","updated_at":"2016-08-30T11:41:46Z","body":"Been out of the loop a bit, but would adding that `ConfigureAwait` call fix #2534 ?"}}
{"actor":{"display_login":"thecodejunkie"}}