{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/comments/73006009","id":73006009,"diff_hunk":"@@ -64,43 +55,31 @@ public void execute(IProgressMonitor monitor) throws InvocationTargetException,\n         description, \"Creating new App Engine Project\");\n     try {\n       operation.execute(progress.newChild(20), uiInfoAdapter);\n-      \n-      IFacetedProject facetedProject = ProjectFacetsManager.create(\n-          newProject, true, progress.newChild(20));\n-      \n-      installJavaFacet(facetedProject, progress.newChild(10));\n-      \n       CodeTemplates.materialize(newProject, config, progress.newChild(20));\n-      \n-      installWebFacet(facetedProject, progress.newChild(10));\n-      \n-      // must happen after other two facets because the appengine facet requires them\n-      FacetInstallDelegate.installAppEngineFacet(facetedProject, progress.newChild(10));\n-      FacetInstallDelegate.installAppEngineRuntime(facetedProject, progress.newChild(20));\n+\n+      Job facetInstallJob = new Job(\"Install App Engine Facet and runtimes in \" + newProject.getName()) {\n+\n+        @Override\n+        protected IStatus run(IProgressMonitor monitor) {\n+          try {\n+            final IFacetedProject facetedProject = ProjectFacetsManager.create(\n+                newProject, true, monitor);\n+            AppEngineStandardFacet.installAppEngineFacet(\n+                facetedProject, true /* installDependentFacets */, monitor);\n+            AppEngineStandardFacet.installAllAppEngineRuntimes(facetedProject, true, monitor);\n+          } catch (CoreException e) {\n+            return e.getStatus();\n+          }\n+          return Status.OK_STATUS;\n+        }\n+  \n+      };\n+      facetInstallJob.schedule();","path":"plugins/com.google.cloud.tools.eclipse.appengine.newproject/src/com/google/cloud/tools/eclipse/appengine/newproject/CreateAppEngineStandardWtpProject.java","position":79,"original_position":79,"commit_id":"63401ba690cb0d5d20a11f267ae125b2752a1d3b","original_commit_id":"63401ba690cb0d5d20a11f267ae125b2752a1d3b","user":{"login":"akerekes","id":3378942,"avatar_url":"https://avatars.githubusercontent.com/u/3378942?v=3","gravatar_id":"","url":"https://api.github.com/users/akerekes","html_url":"https://github.com/akerekes","followers_url":"https://api.github.com/users/akerekes/followers","following_url":"https://api.github.com/users/akerekes/following{/other_user}","gists_url":"https://api.github.com/users/akerekes/gists{/gist_id}","starred_url":"https://api.github.com/users/akerekes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akerekes/subscriptions","organizations_url":"https://api.github.com/users/akerekes/orgs","repos_url":"https://api.github.com/users/akerekes/repos","events_url":"https://api.github.com/users/akerekes/events{/privacy}","received_events_url":"https://api.github.com/users/akerekes/received_events","type":"User","site_admin":false},"body":"Will the progress monitor behave as expected by the user? The progress for this monitor will be complete on line 81, but the job might still run in the background. Wouldn't this be confusing?","created_at":"2016-08-01T16:12:00Z","updated_at":"2016-08-01T16:12:00Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/450#discussion_r73006009","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/450","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/comments/73006009"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/450#discussion_r73006009"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/450"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/450","id":78853849,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/450","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/450.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/450.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/450","number":450,"state":"open","locked":false,"title":"GAE Facet revamp","user":{"login":"nbashirbello","id":6805942,"avatar_url":"https://avatars.githubusercontent.com/u/6805942?v=3","gravatar_id":"","url":"https://api.github.com/users/nbashirbello","html_url":"https://github.com/nbashirbello","followers_url":"https://api.github.com/users/nbashirbello/followers","following_url":"https://api.github.com/users/nbashirbello/following{/other_user}","gists_url":"https://api.github.com/users/nbashirbello/gists{/gist_id}","starred_url":"https://api.github.com/users/nbashirbello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbashirbello/subscriptions","organizations_url":"https://api.github.com/users/nbashirbello/orgs","repos_url":"https://api.github.com/users/nbashirbello/repos","events_url":"https://api.github.com/users/nbashirbello/events{/privacy}","received_events_url":"https://api.github.com/users/nbashirbello/received_events","type":"User","site_admin":false},"body":"The App Engine Standard facet is used to expose the App Engine functionality (run, debug and deploy). To use the App Engine runtime, the project must have the App Engine facet. This means that adding the App Engine runtime without first adding the facet, would cause the facet to be added to the project.\r\n- Installing the App Engine facet does the following\r\n-- Adds the App Engine Runtime and SDK jars to the project's classpath\r\n-- Adds the appengine-web.xml if it doesn't exist\r\n- Uninstalling the App Engine facet does the following\r\n-- Removes the App Engine runtimes from the project\r\n-- Removes the App Engine Runtime and SDK jars from the project's classpath\r\n\r\nCreating new App Engine projects would also include adding the runtimes but it doesn't need to happen when users are adding the facet to an already existing project. The runtimes would be available to projects with the App Engine facet","created_at":"2016-07-26T13:44:03Z","updated_at":"2016-08-01T16:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2dfecaf39dde0e3740dadbe0c912d51df114ccf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/450/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/450/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/450/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/statuses/63401ba690cb0d5d20a11f267ae125b2752a1d3b","head":{"label":"GoogleCloudPlatform:gaeFacetRedo","ref":"gaeFacetRedo","sha":"63401ba690cb0d5d20a11f267ae125b2752a1d3b","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":53369484,"name":"gcloud-eclipse-tools","full_name":"GoogleCloudPlatform/gcloud-eclipse-tools","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools","description":"Google Cloud Platform plugin for Eclipse","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/deployments","created_at":"2016-03-08T00:30:03Z","updated_at":"2016-07-27T09:14:17Z","pushed_at":"2016-08-01T15:39:39Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-eclipse-tools.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-eclipse-tools.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools","homepage":"","size":3936,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":94,"forks":2,"open_issues":94,"watchers":9,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"5a989e93cf9e1bd867fed9da3de4b95fb648fee2","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":53369484,"name":"gcloud-eclipse-tools","full_name":"GoogleCloudPlatform/gcloud-eclipse-tools","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools","description":"Google Cloud Platform plugin for Eclipse","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/deployments","created_at":"2016-03-08T00:30:03Z","updated_at":"2016-07-27T09:14:17Z","pushed_at":"2016-08-01T15:39:39Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-eclipse-tools.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-eclipse-tools.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools","homepage":"","size":3936,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":94,"forks":2,"open_issues":94,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/450"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/pull/450"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/450"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-eclipse-tools/statuses/63401ba690cb0d5d20a11f267ae125b2752a1d3b"}}}}
{"actor":{"display_login":"akerekes"}}