{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/12685","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/12685/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/12685/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/12685/events","html_url":"https://github.com/dotnet/roslyn/pull/12685","id":167143299,"number":12685,"title":"Fix crash in inline rename","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-22T22:19:50Z","updated_at":"2016-07-22T22:58:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/12685","html_url":"https://github.com/dotnet/roslyn/pull/12685","diff_url":"https://github.com/dotnet/roslyn/pull/12685.diff","patch_url":"https://github.com/dotnet/roslyn/pull/12685.patch"},"body":"This change fixes #7566\r\n\r\nThe change adds a check for null after trying to get the snapshot of a supposedly open document. This can fail due to the weak reference map used to associate source texts with their editor text snapshots.\r\n\r\n@rchande @tmat @Pilchie  please review"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/234676815","html_url":"https://github.com/dotnet/roslyn/pull/12685#issuecomment-234676815","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/12685","id":234676815,"user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T22:58:39Z","updated_at":"2016-07-22T22:58:39Z","body":"Yes, something seems very wonky here.  If we're getting the open documents, then we should be able to get their SourceTexts without blocking, and those SourceTexts should map to ITextSnapshots which are the .CurrentSnapshot of the open text buffers.\r\n\r\n@jasonmalinowski Does that match your understanding as well?"}}
{"actor":{"display_login":"CyrusNajmabadi"}}