{"action":"created","comment":{"url":"https://api.github.com/repos/bendalab/thunderfish/pulls/comments/65807096","id":65807096,"diff_hunk":"@@ -43,49 +44,49 @@ def load_data(filepath, channel=0, verbose=0) :\n         unit (string): the unit of the data\n     \"\"\"\n     # check types:\n-    if not isinstance(filepath, basestring) :\n+    if not isinstance(filepath, basestring):\n         raise NameError('load_data(): input argument filepath must be a string!')\n-    if not isinstance(channel, int) :\n+    if not isinstance(channel, int):\n         raise NameError('load_data(): input argument channel must be an int!')\n \n     # check values:\n     data = np.array([])\n     freq = 0.0\n     unit = ''\n-    if len(filepath) == 0 :\n+    if len(filepath) == 0:\n         print('load_data(): input argument filepath is empty string!')","path":"thunderfish/dataloader.py","position":49,"original_position":49,"commit_id":"a0de3f3f2ec0c8b8349043cbb3bf8ccbc48fa73a","original_commit_id":"a0de3f3f2ec0c8b8349043cbb3bf8ccbc48fa73a","user":{"login":"janscience","id":12050052,"avatar_url":"https://avatars.githubusercontent.com/u/12050052?v=3","gravatar_id":"","url":"https://api.github.com/users/janscience","html_url":"https://github.com/janscience","followers_url":"https://api.github.com/users/janscience/followers","following_url":"https://api.github.com/users/janscience/following{/other_user}","gists_url":"https://api.github.com/users/janscience/gists{/gist_id}","starred_url":"https://api.github.com/users/janscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janscience/subscriptions","organizations_url":"https://api.github.com/users/janscience/orgs","repos_url":"https://api.github.com/users/janscience/repos","events_url":"https://api.github.com/users/janscience/events{/privacy}","received_events_url":"https://api.github.com/users/janscience/received_events","type":"User","site_admin":false},"body":"and all these prints should be warnings.warn","created_at":"2016-06-04T20:14:32Z","updated_at":"2016-06-04T20:14:32Z","html_url":"https://github.com/bendalab/thunderfish/pull/26#discussion_r65807096","pull_request_url":"https://api.github.com/repos/bendalab/thunderfish/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/bendalab/thunderfish/pulls/comments/65807096"},"html":{"href":"https://github.com/bendalab/thunderfish/pull/26#discussion_r65807096"},"pull_request":{"href":"https://api.github.com/repos/bendalab/thunderfish/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/bendalab/thunderfish/pulls/26","id":72606413,"html_url":"https://github.com/bendalab/thunderfish/pull/26","diff_url":"https://github.com/bendalab/thunderfish/pull/26.diff","patch_url":"https://github.com/bendalab/thunderfish/pull/26.patch","issue_url":"https://api.github.com/repos/bendalab/thunderfish/issues/26","number":26,"state":"open","locked":false,"title":"thunderfish.py reformated for using independent modules. Type-sorting algorithm added. Peak-detection threshold set using percentiles now","user":{"login":"jfsehuanes","id":8696677,"avatar_url":"https://avatars.githubusercontent.com/u/8696677?v=3","gravatar_id":"","url":"https://api.github.com/users/jfsehuanes","html_url":"https://github.com/jfsehuanes","followers_url":"https://api.github.com/users/jfsehuanes/followers","following_url":"https://api.github.com/users/jfsehuanes/following{/other_user}","gists_url":"https://api.github.com/users/jfsehuanes/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsehuanes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsehuanes/subscriptions","organizations_url":"https://api.github.com/users/jfsehuanes/orgs","repos_url":"https://api.github.com/users/jfsehuanes/repos","events_url":"https://api.github.com/users/jfsehuanes/events{/privacy}","received_events_url":"https://api.github.com/users/jfsehuanes/received_events","type":"User","site_admin":false},"body":"- thunderfish.py is now able to use the independent modules we're developing. There are still some more modules to add to the main, though.\r\n\r\n- The Fish-type sorting algorithm (peak2trough / peak2peak) was now added under sortfishtype.py. This is a full documented and independent module that segregates pulse- from wave-type fishes.\r\n\r\n- The peak-detection threshold is now determined by a percentile approach instead of using the std. Default threshold is set to 99 percentile.\r\n\r\n- Some code-reformat was also performed on other scripts.\r\n\r\nPeace!","created_at":"2016-06-04T16:26:54Z","updated_at":"2016-06-04T20:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ae580ebbe03326091f93a7da08a3f2130a6940c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bendalab/thunderfish/pulls/26/commits","review_comments_url":"https://api.github.com/repos/bendalab/thunderfish/pulls/26/comments","review_comment_url":"https://api.github.com/repos/bendalab/thunderfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bendalab/thunderfish/issues/26/comments","statuses_url":"https://api.github.com/repos/bendalab/thunderfish/statuses/a0de3f3f2ec0c8b8349043cbb3bf8ccbc48fa73a","head":{"label":"jfsehuanes:master","ref":"master","sha":"a0de3f3f2ec0c8b8349043cbb3bf8ccbc48fa73a","user":{"login":"jfsehuanes","id":8696677,"avatar_url":"https://avatars.githubusercontent.com/u/8696677?v=3","gravatar_id":"","url":"https://api.github.com/users/jfsehuanes","html_url":"https://github.com/jfsehuanes","followers_url":"https://api.github.com/users/jfsehuanes/followers","following_url":"https://api.github.com/users/jfsehuanes/following{/other_user}","gists_url":"https://api.github.com/users/jfsehuanes/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsehuanes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsehuanes/subscriptions","organizations_url":"https://api.github.com/users/jfsehuanes/orgs","repos_url":"https://api.github.com/users/jfsehuanes/repos","events_url":"https://api.github.com/users/jfsehuanes/events{/privacy}","received_events_url":"https://api.github.com/users/jfsehuanes/received_events","type":"User","site_admin":false},"repo":{"id":50344638,"name":"thunderfish","full_name":"jfsehuanes/thunderfish","owner":{"login":"jfsehuanes","id":8696677,"avatar_url":"https://avatars.githubusercontent.com/u/8696677?v=3","gravatar_id":"","url":"https://api.github.com/users/jfsehuanes","html_url":"https://github.com/jfsehuanes","followers_url":"https://api.github.com/users/jfsehuanes/followers","following_url":"https://api.github.com/users/jfsehuanes/following{/other_user}","gists_url":"https://api.github.com/users/jfsehuanes/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsehuanes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsehuanes/subscriptions","organizations_url":"https://api.github.com/users/jfsehuanes/orgs","repos_url":"https://api.github.com/users/jfsehuanes/repos","events_url":"https://api.github.com/users/jfsehuanes/events{/privacy}","received_events_url":"https://api.github.com/users/jfsehuanes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jfsehuanes/thunderfish","description":"python scripts for analyzing recordings of efish electric fields.","fork":true,"url":"https://api.github.com/repos/jfsehuanes/thunderfish","forks_url":"https://api.github.com/repos/jfsehuanes/thunderfish/forks","keys_url":"https://api.github.com/repos/jfsehuanes/thunderfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfsehuanes/thunderfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfsehuanes/thunderfish/teams","hooks_url":"https://api.github.com/repos/jfsehuanes/thunderfish/hooks","issue_events_url":"https://api.github.com/repos/jfsehuanes/thunderfish/issues/events{/number}","events_url":"https://api.github.com/repos/jfsehuanes/thunderfish/events","assignees_url":"https://api.github.com/repos/jfsehuanes/thunderfish/assignees{/user}","branches_url":"https://api.github.com/repos/jfsehuanes/thunderfish/branches{/branch}","tags_url":"https://api.github.com/repos/jfsehuanes/thunderfish/tags","blobs_url":"https://api.github.com/repos/jfsehuanes/thunderfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfsehuanes/thunderfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfsehuanes/thunderfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfsehuanes/thunderfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfsehuanes/thunderfish/statuses/{sha}","languages_url":"https://api.github.com/repos/jfsehuanes/thunderfish/languages","stargazers_url":"https://api.github.com/repos/jfsehuanes/thunderfish/stargazers","contributors_url":"https://api.github.com/repos/jfsehuanes/thunderfish/contributors","subscribers_url":"https://api.github.com/repos/jfsehuanes/thunderfish/subscribers","subscription_url":"https://api.github.com/repos/jfsehuanes/thunderfish/subscription","commits_url":"https://api.github.com/repos/jfsehuanes/thunderfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfsehuanes/thunderfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfsehuanes/thunderfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfsehuanes/thunderfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfsehuanes/thunderfish/contents/{+path}","compare_url":"https://api.github.com/repos/jfsehuanes/thunderfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfsehuanes/thunderfish/merges","archive_url":"https://api.github.com/repos/jfsehuanes/thunderfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfsehuanes/thunderfish/downloads","issues_url":"https://api.github.com/repos/jfsehuanes/thunderfish/issues{/number}","pulls_url":"https://api.github.com/repos/jfsehuanes/thunderfish/pulls{/number}","milestones_url":"https://api.github.com/repos/jfsehuanes/thunderfish/milestones{/number}","notifications_url":"https://api.github.com/repos/jfsehuanes/thunderfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfsehuanes/thunderfish/labels{/name}","releases_url":"https://api.github.com/repos/jfsehuanes/thunderfish/releases{/id}","deployments_url":"https://api.github.com/repos/jfsehuanes/thunderfish/deployments","created_at":"2016-01-25T10:53:25Z","updated_at":"2016-01-25T10:53:27Z","pushed_at":"2016-06-04T16:16:09Z","git_url":"git://github.com/jfsehuanes/thunderfish.git","ssh_url":"git@github.com:jfsehuanes/thunderfish.git","clone_url":"https://github.com/jfsehuanes/thunderfish.git","svn_url":"https://github.com/jfsehuanes/thunderfish","homepage":null,"size":504,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bendalab:master","ref":"master","sha":"d26a06d46f4cb7835448b3ed5d312b48a45ec282","user":{"login":"bendalab","id":10567758,"avatar_url":"https://avatars.githubusercontent.com/u/10567758?v=3","gravatar_id":"","url":"https://api.github.com/users/bendalab","html_url":"https://github.com/bendalab","followers_url":"https://api.github.com/users/bendalab/followers","following_url":"https://api.github.com/users/bendalab/following{/other_user}","gists_url":"https://api.github.com/users/bendalab/gists{/gist_id}","starred_url":"https://api.github.com/users/bendalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendalab/subscriptions","organizations_url":"https://api.github.com/users/bendalab/orgs","repos_url":"https://api.github.com/users/bendalab/repos","events_url":"https://api.github.com/users/bendalab/events{/privacy}","received_events_url":"https://api.github.com/users/bendalab/received_events","type":"Organization","site_admin":false},"repo":{"id":50343080,"name":"thunderfish","full_name":"bendalab/thunderfish","owner":{"login":"bendalab","id":10567758,"avatar_url":"https://avatars.githubusercontent.com/u/10567758?v=3","gravatar_id":"","url":"https://api.github.com/users/bendalab","html_url":"https://github.com/bendalab","followers_url":"https://api.github.com/users/bendalab/followers","following_url":"https://api.github.com/users/bendalab/following{/other_user}","gists_url":"https://api.github.com/users/bendalab/gists{/gist_id}","starred_url":"https://api.github.com/users/bendalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendalab/subscriptions","organizations_url":"https://api.github.com/users/bendalab/orgs","repos_url":"https://api.github.com/users/bendalab/repos","events_url":"https://api.github.com/users/bendalab/events{/privacy}","received_events_url":"https://api.github.com/users/bendalab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bendalab/thunderfish","description":"python scripts for analyzing recordings of efish electric fields.","fork":false,"url":"https://api.github.com/repos/bendalab/thunderfish","forks_url":"https://api.github.com/repos/bendalab/thunderfish/forks","keys_url":"https://api.github.com/repos/bendalab/thunderfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bendalab/thunderfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bendalab/thunderfish/teams","hooks_url":"https://api.github.com/repos/bendalab/thunderfish/hooks","issue_events_url":"https://api.github.com/repos/bendalab/thunderfish/issues/events{/number}","events_url":"https://api.github.com/repos/bendalab/thunderfish/events","assignees_url":"https://api.github.com/repos/bendalab/thunderfish/assignees{/user}","branches_url":"https://api.github.com/repos/bendalab/thunderfish/branches{/branch}","tags_url":"https://api.github.com/repos/bendalab/thunderfish/tags","blobs_url":"https://api.github.com/repos/bendalab/thunderfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bendalab/thunderfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bendalab/thunderfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/bendalab/thunderfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bendalab/thunderfish/statuses/{sha}","languages_url":"https://api.github.com/repos/bendalab/thunderfish/languages","stargazers_url":"https://api.github.com/repos/bendalab/thunderfish/stargazers","contributors_url":"https://api.github.com/repos/bendalab/thunderfish/contributors","subscribers_url":"https://api.github.com/repos/bendalab/thunderfish/subscribers","subscription_url":"https://api.github.com/repos/bendalab/thunderfish/subscription","commits_url":"https://api.github.com/repos/bendalab/thunderfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/bendalab/thunderfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/bendalab/thunderfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/bendalab/thunderfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/bendalab/thunderfish/contents/{+path}","compare_url":"https://api.github.com/repos/bendalab/thunderfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bendalab/thunderfish/merges","archive_url":"https://api.github.com/repos/bendalab/thunderfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bendalab/thunderfish/downloads","issues_url":"https://api.github.com/repos/bendalab/thunderfish/issues{/number}","pulls_url":"https://api.github.com/repos/bendalab/thunderfish/pulls{/number}","milestones_url":"https://api.github.com/repos/bendalab/thunderfish/milestones{/number}","notifications_url":"https://api.github.com/repos/bendalab/thunderfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bendalab/thunderfish/labels{/name}","releases_url":"https://api.github.com/repos/bendalab/thunderfish/releases{/id}","deployments_url":"https://api.github.com/repos/bendalab/thunderfish/deployments","created_at":"2016-01-25T10:22:55Z","updated_at":"2016-01-25T10:51:51Z","pushed_at":"2016-06-04T16:26:54Z","git_url":"git://github.com/bendalab/thunderfish.git","ssh_url":"git@github.com:bendalab/thunderfish.git","clone_url":"https://github.com/bendalab/thunderfish.git","svn_url":"https://github.com/bendalab/thunderfish","homepage":null,"size":496,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":12,"forks":5,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bendalab/thunderfish/pulls/26"},"html":{"href":"https://github.com/bendalab/thunderfish/pull/26"},"issue":{"href":"https://api.github.com/repos/bendalab/thunderfish/issues/26"},"comments":{"href":"https://api.github.com/repos/bendalab/thunderfish/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/bendalab/thunderfish/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/bendalab/thunderfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bendalab/thunderfish/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/bendalab/thunderfish/statuses/a0de3f3f2ec0c8b8349043cbb3bf8ccbc48fa73a"}}}}
{"actor":{"display_login":"janscience"}}