{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/comments/58929348","id":58929348,"diff_hunk":"@@ -59,15 +59,21 @@ define([\n \t\t\t}\n \t\t},\n \n+\t\thasValidLocation : function() {\n+\t\t\treturn (this.has('location') &&\n+\t\t\t\t((this.attributes.location.latitude) ? true : false) &&\n+\t\t\t\t((this.attributes.location.longitude) ? true : false));\n+\t\t\t\t\n+\t\t},\n+\n \t\t/*\n \t\t * Returns the bounding box as an object with west, east, north, and south properties.\n \t\t * Return undefined if the model's properties do not contain a valid bounding box\n \t\t * @return {Object} - has west, east, north, south properties or undefined\n \t\t */\n \t\tgetBoundingBox : function() {\n \t\t\tvar result = undefined;\n-\t\t\tif ((this.attributes.radius) && (this.attributes.location) &&\n-\t\t\t\t(this.attributes.location.latitude) && (this.attributes.location.longitude)) {\n+\t\t\tif ((this.attributes.radius) && this.hasValidLocation()) {","path":"src/main/webapp/js/models/WorkflowStateModel.js","position":29,"original_position":29,"commit_id":"167947f6b0dcd4473fc514ca73fe4ebeea63d81c","original_commit_id":"167947f6b0dcd4473fc514ca73fe4ebeea63d81c","user":{"login":"instantsoup","id":6976939,"avatar_url":"https://avatars.githubusercontent.com/u/6976939?v=3","gravatar_id":"","url":"https://api.github.com/users/instantsoup","html_url":"https://github.com/instantsoup","followers_url":"https://api.github.com/users/instantsoup/followers","following_url":"https://api.github.com/users/instantsoup/following{/other_user}","gists_url":"https://api.github.com/users/instantsoup/gists{/gist_id}","starred_url":"https://api.github.com/users/instantsoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instantsoup/subscriptions","organizations_url":"https://api.github.com/users/instantsoup/orgs","repos_url":"https://api.github.com/users/instantsoup/repos","events_url":"https://api.github.com/users/instantsoup/events{/privacy}","received_events_url":"https://api.github.com/users/instantsoup/received_events","type":"User","site_admin":false},"body":"Yeah, but how's it different than the comparison in the hasValidLocation() method? Why is that one ternary?","created_at":"2016-04-07T19:20:42Z","updated_at":"2016-04-07T19:20:42Z","html_url":"https://github.com/USGS-CIDA/enddat_web/pull/40#discussion_r58929348","pull_request_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/comments/58929348"},"html":{"href":"https://github.com/USGS-CIDA/enddat_web/pull/40#discussion_r58929348"},"pull_request":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/40","id":65636974,"html_url":"https://github.com/USGS-CIDA/enddat_web/pull/40","diff_url":"https://github.com/USGS-CIDA/enddat_web/pull/40.diff","patch_url":"https://github.com/USGS-CIDA/enddat_web/pull/40.patch","issue_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/issues/40","number":40,"state":"open","locked":false,"title":"Enddat 152","user":{"login":"mbucknell","id":8104736,"avatar_url":"https://avatars.githubusercontent.com/u/8104736?v=3","gravatar_id":"","url":"https://api.github.com/users/mbucknell","html_url":"https://github.com/mbucknell","followers_url":"https://api.github.com/users/mbucknell/followers","following_url":"https://api.github.com/users/mbucknell/following{/other_user}","gists_url":"https://api.github.com/users/mbucknell/gists{/gist_id}","starred_url":"https://api.github.com/users/mbucknell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbucknell/subscriptions","organizations_url":"https://api.github.com/users/mbucknell/orgs","repos_url":"https://api.github.com/users/mbucknell/repos","events_url":"https://api.github.com/users/mbucknell/events{/privacy}","received_events_url":"https://api.github.com/users/mbucknell/received_events","type":"User","site_admin":false},"body":"Added the ability to click on a precipitation grid point. This creates a circle marker at that point and shows the PrecipDataView which allows the user to examine the data and select it for processing. The select state is saved within the precipitation data model.","created_at":"2016-04-07T14:14:05Z","updated_at":"2016-04-07T19:20:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c852a034d683431aa13bd0d4176a8d1338b99c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/40/commits","review_comments_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/40/comments","review_comment_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/issues/40/comments","statuses_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/statuses/167947f6b0dcd4473fc514ca73fe4ebeea63d81c","head":{"label":"mbucknell:ENDDAT-152","ref":"ENDDAT-152","sha":"167947f6b0dcd4473fc514ca73fe4ebeea63d81c","user":{"login":"mbucknell","id":8104736,"avatar_url":"https://avatars.githubusercontent.com/u/8104736?v=3","gravatar_id":"","url":"https://api.github.com/users/mbucknell","html_url":"https://github.com/mbucknell","followers_url":"https://api.github.com/users/mbucknell/followers","following_url":"https://api.github.com/users/mbucknell/following{/other_user}","gists_url":"https://api.github.com/users/mbucknell/gists{/gist_id}","starred_url":"https://api.github.com/users/mbucknell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbucknell/subscriptions","organizations_url":"https://api.github.com/users/mbucknell/orgs","repos_url":"https://api.github.com/users/mbucknell/repos","events_url":"https://api.github.com/users/mbucknell/events{/privacy}","received_events_url":"https://api.github.com/users/mbucknell/received_events","type":"User","site_admin":false},"repo":{"id":52115920,"name":"enddat_web","full_name":"mbucknell/enddat_web","owner":{"login":"mbucknell","id":8104736,"avatar_url":"https://avatars.githubusercontent.com/u/8104736?v=3","gravatar_id":"","url":"https://api.github.com/users/mbucknell","html_url":"https://github.com/mbucknell","followers_url":"https://api.github.com/users/mbucknell/followers","following_url":"https://api.github.com/users/mbucknell/following{/other_user}","gists_url":"https://api.github.com/users/mbucknell/gists{/gist_id}","starred_url":"https://api.github.com/users/mbucknell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbucknell/subscriptions","organizations_url":"https://api.github.com/users/mbucknell/orgs","repos_url":"https://api.github.com/users/mbucknell/repos","events_url":"https://api.github.com/users/mbucknell/events{/privacy}","received_events_url":"https://api.github.com/users/mbucknell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbucknell/enddat_web","description":"Web UI for ENDDaT","fork":true,"url":"https://api.github.com/repos/mbucknell/enddat_web","forks_url":"https://api.github.com/repos/mbucknell/enddat_web/forks","keys_url":"https://api.github.com/repos/mbucknell/enddat_web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbucknell/enddat_web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbucknell/enddat_web/teams","hooks_url":"https://api.github.com/repos/mbucknell/enddat_web/hooks","issue_events_url":"https://api.github.com/repos/mbucknell/enddat_web/issues/events{/number}","events_url":"https://api.github.com/repos/mbucknell/enddat_web/events","assignees_url":"https://api.github.com/repos/mbucknell/enddat_web/assignees{/user}","branches_url":"https://api.github.com/repos/mbucknell/enddat_web/branches{/branch}","tags_url":"https://api.github.com/repos/mbucknell/enddat_web/tags","blobs_url":"https://api.github.com/repos/mbucknell/enddat_web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbucknell/enddat_web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbucknell/enddat_web/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbucknell/enddat_web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbucknell/enddat_web/statuses/{sha}","languages_url":"https://api.github.com/repos/mbucknell/enddat_web/languages","stargazers_url":"https://api.github.com/repos/mbucknell/enddat_web/stargazers","contributors_url":"https://api.github.com/repos/mbucknell/enddat_web/contributors","subscribers_url":"https://api.github.com/repos/mbucknell/enddat_web/subscribers","subscription_url":"https://api.github.com/repos/mbucknell/enddat_web/subscription","commits_url":"https://api.github.com/repos/mbucknell/enddat_web/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbucknell/enddat_web/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbucknell/enddat_web/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbucknell/enddat_web/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbucknell/enddat_web/contents/{+path}","compare_url":"https://api.github.com/repos/mbucknell/enddat_web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbucknell/enddat_web/merges","archive_url":"https://api.github.com/repos/mbucknell/enddat_web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbucknell/enddat_web/downloads","issues_url":"https://api.github.com/repos/mbucknell/enddat_web/issues{/number}","pulls_url":"https://api.github.com/repos/mbucknell/enddat_web/pulls{/number}","milestones_url":"https://api.github.com/repos/mbucknell/enddat_web/milestones{/number}","notifications_url":"https://api.github.com/repos/mbucknell/enddat_web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbucknell/enddat_web/labels{/name}","releases_url":"https://api.github.com/repos/mbucknell/enddat_web/releases{/id}","deployments_url":"https://api.github.com/repos/mbucknell/enddat_web/deployments","created_at":"2016-02-19T20:56:21Z","updated_at":"2016-03-04T21:23:10Z","pushed_at":"2016-04-07T14:10:55Z","git_url":"git://github.com/mbucknell/enddat_web.git","ssh_url":"git@github.com:mbucknell/enddat_web.git","clone_url":"https://github.com/mbucknell/enddat_web.git","svn_url":"https://github.com/mbucknell/enddat_web","homepage":null,"size":450,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-CIDA:master","ref":"master","sha":"593bc0310d7b2165da8edaa24695e353212b5e20","user":{"login":"USGS-CIDA","id":918179,"avatar_url":"https://avatars.githubusercontent.com/u/918179?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-CIDA","html_url":"https://github.com/USGS-CIDA","followers_url":"https://api.github.com/users/USGS-CIDA/followers","following_url":"https://api.github.com/users/USGS-CIDA/following{/other_user}","gists_url":"https://api.github.com/users/USGS-CIDA/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-CIDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-CIDA/subscriptions","organizations_url":"https://api.github.com/users/USGS-CIDA/orgs","repos_url":"https://api.github.com/users/USGS-CIDA/repos","events_url":"https://api.github.com/users/USGS-CIDA/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-CIDA/received_events","type":"Organization","site_admin":false},"repo":{"id":50872438,"name":"enddat_web","full_name":"USGS-CIDA/enddat_web","owner":{"login":"USGS-CIDA","id":918179,"avatar_url":"https://avatars.githubusercontent.com/u/918179?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-CIDA","html_url":"https://github.com/USGS-CIDA","followers_url":"https://api.github.com/users/USGS-CIDA/followers","following_url":"https://api.github.com/users/USGS-CIDA/following{/other_user}","gists_url":"https://api.github.com/users/USGS-CIDA/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-CIDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-CIDA/subscriptions","organizations_url":"https://api.github.com/users/USGS-CIDA/orgs","repos_url":"https://api.github.com/users/USGS-CIDA/repos","events_url":"https://api.github.com/users/USGS-CIDA/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-CIDA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-CIDA/enddat_web","description":"Web UI for ENDDaT","fork":false,"url":"https://api.github.com/repos/USGS-CIDA/enddat_web","forks_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/forks","keys_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/teams","hooks_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/hooks","issue_events_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/events","assignees_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/tags","blobs_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/languages","stargazers_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/stargazers","contributors_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/contributors","subscribers_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/subscribers","subscription_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/subscription","commits_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/merges","archive_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/downloads","issues_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/labels{/name}","releases_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-CIDA/enddat_web/deployments","created_at":"2016-02-01T21:26:56Z","updated_at":"2016-02-29T16:41:54Z","pushed_at":"2016-04-07T14:14:07Z","git_url":"git://github.com/USGS-CIDA/enddat_web.git","ssh_url":"git@github.com:USGS-CIDA/enddat_web.git","clone_url":"https://github.com/USGS-CIDA/enddat_web.git","svn_url":"https://github.com/USGS-CIDA/enddat_web","homepage":null,"size":422,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/40"},"html":{"href":"https://github.com/USGS-CIDA/enddat_web/pull/40"},"issue":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/issues/40"},"comments":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-CIDA/enddat_web/statuses/167947f6b0dcd4473fc514ca73fe4ebeea63d81c"}}}}