{"action":"reopened","number":3538,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/3538","id":87256445,"html_url":"https://github.com/qgis/QGIS/pull/3538","diff_url":"https://github.com/qgis/QGIS/pull/3538.diff","patch_url":"https://github.com/qgis/QGIS/pull/3538.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/3538","number":3538,"state":"open","locked":false,"title":"[FEATURE] QgsTextRenderer","user":{"login":"nyalldawson","id":1829991,"avatar_url":"https://avatars.githubusercontent.com/u/1829991?v=3","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"body":"This PR splits the rendering part of the labeling engine out to its own class so that it can be reused by other parts of the codebase.  This allows other parts of the code to utilise all the advanced formatting options that labeling supports, eg rendering text with shadows, buffers and backgrounds.\r\n\r\nAdditionally, the way text formatting options for labeling are stored has been optimised through the use of new implicitly shared text setting classes. Since the current labeling implementation makes many copies of QgsPalLayerSettings (which is a HUGE object) this should be a performance win. It's also nicer api.\r\n\r\nTODO:\r\n- rework the label preview + labelling gui to use the new text settings classes and be usable outside of labeling\r\n- make composer map annotations render using QgsTextRenderer so that annotations can have buffers, shadows, backgrounds, etc\r\n- api break docs\r\n- expose other render units (eg pixels) to labeling gui","created_at":"2016-09-29T07:01:25Z","updated_at":"2016-09-30T20:58:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4113e1e5b52fc18c245971b8195340addc0c0b7b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/3538/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/3538/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/3538/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/9df0ce2d64920852c486f5d5dcad549c1bdd8f30","head":{"label":"nyalldawson:text_rendererv99","ref":"text_rendererv99","sha":"9df0ce2d64920852c486f5d5dcad549c1bdd8f30","user":{"login":"nyalldawson","id":1829991,"avatar_url":"https://avatars.githubusercontent.com/u/1829991?v=3","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"repo":{"id":8490349,"name":"QGIS","full_name":"nyalldawson/QGIS","owner":{"login":"nyalldawson","id":1829991,"avatar_url":"https://avatars.githubusercontent.com/u/1829991?v=3","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyalldawson/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/nyalldawson/QGIS","forks_url":"https://api.github.com/repos/nyalldawson/QGIS/forks","keys_url":"https://api.github.com/repos/nyalldawson/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyalldawson/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyalldawson/QGIS/teams","hooks_url":"https://api.github.com/repos/nyalldawson/QGIS/hooks","issue_events_url":"https://api.github.com/repos/nyalldawson/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/nyalldawson/QGIS/events","assignees_url":"https://api.github.com/repos/nyalldawson/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/nyalldawson/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/nyalldawson/QGIS/tags","blobs_url":"https://api.github.com/repos/nyalldawson/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyalldawson/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyalldawson/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyalldawson/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyalldawson/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/nyalldawson/QGIS/languages","stargazers_url":"https://api.github.com/repos/nyalldawson/QGIS/stargazers","contributors_url":"https://api.github.com/repos/nyalldawson/QGIS/contributors","subscribers_url":"https://api.github.com/repos/nyalldawson/QGIS/subscribers","subscription_url":"https://api.github.com/repos/nyalldawson/QGIS/subscription","commits_url":"https://api.github.com/repos/nyalldawson/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyalldawson/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyalldawson/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyalldawson/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyalldawson/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/nyalldawson/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyalldawson/QGIS/merges","archive_url":"https://api.github.com/repos/nyalldawson/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyalldawson/QGIS/downloads","issues_url":"https://api.github.com/repos/nyalldawson/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/nyalldawson/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/nyalldawson/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/nyalldawson/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyalldawson/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/nyalldawson/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/nyalldawson/QGIS/deployments","created_at":"2013-02-28T23:20:44Z","updated_at":"2016-09-23T01:56:48Z","pushed_at":"2016-09-30T04:33:59Z","git_url":"git://github.com/nyalldawson/QGIS.git","ssh_url":"git@github.com:nyalldawson/QGIS.git","clone_url":"https://github.com/nyalldawson/QGIS.git","svn_url":"https://github.com/nyalldawson/QGIS","homepage":"http://qgis.org","size":1109224,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"67d5e1930384abaf3cba21238f7e0dfaf0dc9ecc","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2016-09-30T09:50:56Z","pushed_at":"2016-09-30T18:54:42Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1271659,"stargazers_count":1118,"watchers_count":1118,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":907,"mirror_url":null,"open_issues_count":67,"forks":907,"open_issues":67,"watchers":1118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3538"},"html":{"href":"https://github.com/qgis/QGIS/pull/3538"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/3538"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/3538/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3538/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3538/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/9df0ce2d64920852c486f5d5dcad549c1bdd8f30"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":8,"additions":7872,"deletions":2267,"changed_files":169}}
{"actor":{"display_login":"nyalldawson"}}