{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/92666860","pull_request_review_id":13186916,"id":92666860,"diff_hunk":"@@ -0,0 +1,144 @@\n+/*global define*/\n+define([\n+    './defaultValue',\n+    './defined',\n+    './DeveloperError',\n+    './isArray'\n+    ], function(\n+        defaultValue,\n+        defined,\n+        DeveloperError,\n+        isArray) {\n+    'use strict';\n+\n+    /**\n+     * Contains functions for checking that supplied arguments are of a specified type\n+     * or meet specified conditions\n+     * @private\n+     *\n+     * @exports Check\n+     */\n+    var Check = {};","path":"Source/Core/Check.js","position":21,"original_position":21,"commit_id":"4cf758500e56816d9f73a60771f17d12bc46bc52","original_commit_id":"4cf758500e56816d9f73a60771f17d12bc46bc52","user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"body":"Ah, I probably even wrote the `Transform` one.  In practice, it might not matter for these cases so don't bother changing.","created_at":"2016-12-15T18:13:44Z","updated_at":"2016-12-15T18:13:44Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726#discussion_r92666860","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/92666860"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726#discussion_r92666860"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726","id":96850873,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726","number":4726,"state":"open","locked":false,"title":"More concise parameter validation","user":{"login":"erikmaarten","id":4586719,"avatar_url":"https://avatars.githubusercontent.com/u/4586719?v=3","gravatar_id":"","url":"https://api.github.com/users/erikmaarten","html_url":"https://github.com/erikmaarten","followers_url":"https://api.github.com/users/erikmaarten/followers","following_url":"https://api.github.com/users/erikmaarten/following{/other_user}","gists_url":"https://api.github.com/users/erikmaarten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikmaarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikmaarten/subscriptions","organizations_url":"https://api.github.com/users/erikmaarten/orgs","repos_url":"https://api.github.com/users/erikmaarten/repos","events_url":"https://api.github.com/users/erikmaarten/events{/privacy}","received_events_url":"https://api.github.com/users/erikmaarten/received_events","type":"User","site_admin":false},"body":"This PR introduces a module that exposes a `check` module that is useful mostly to check that function parameters have the correct type and shape.\r\n\r\n- [ ] Update the coding guide (https://github.com/AnalyticalGraphicsInc/cesium/tree/master/Documentation/Contributors/CodingGuide#throwing-exceptions)\r\n\r\nCurrently supported\r\n- Primitive types\r\n- Arrays\r\n- Numeric checks: min, max and minMax\r\n\r\nTo show how this will work, I've changed most parameter checks in `Cartesian3` to use `check`.","created_at":"2016-12-07T03:08:12Z","updated_at":"2016-12-15T18:13:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"809139aa979446321bf3faf431780cf24a766260","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/4cf758500e56816d9f73a60771f17d12bc46bc52","head":{"label":"erikmaarten:parameter-validation","ref":"parameter-validation","sha":"4cf758500e56816d9f73a60771f17d12bc46bc52","user":{"login":"erikmaarten","id":4586719,"avatar_url":"https://avatars.githubusercontent.com/u/4586719?v=3","gravatar_id":"","url":"https://api.github.com/users/erikmaarten","html_url":"https://github.com/erikmaarten","followers_url":"https://api.github.com/users/erikmaarten/followers","following_url":"https://api.github.com/users/erikmaarten/following{/other_user}","gists_url":"https://api.github.com/users/erikmaarten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikmaarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikmaarten/subscriptions","organizations_url":"https://api.github.com/users/erikmaarten/orgs","repos_url":"https://api.github.com/users/erikmaarten/repos","events_url":"https://api.github.com/users/erikmaarten/events{/privacy}","received_events_url":"https://api.github.com/users/erikmaarten/received_events","type":"User","site_admin":false},"repo":{"id":71780855,"name":"cesium","full_name":"erikmaarten/cesium","owner":{"login":"erikmaarten","id":4586719,"avatar_url":"https://avatars.githubusercontent.com/u/4586719?v=3","gravatar_id":"","url":"https://api.github.com/users/erikmaarten","html_url":"https://github.com/erikmaarten","followers_url":"https://api.github.com/users/erikmaarten/followers","following_url":"https://api.github.com/users/erikmaarten/following{/other_user}","gists_url":"https://api.github.com/users/erikmaarten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikmaarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikmaarten/subscriptions","organizations_url":"https://api.github.com/users/erikmaarten/orgs","repos_url":"https://api.github.com/users/erikmaarten/repos","events_url":"https://api.github.com/users/erikmaarten/events{/privacy}","received_events_url":"https://api.github.com/users/erikmaarten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikmaarten/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":true,"url":"https://api.github.com/repos/erikmaarten/cesium","forks_url":"https://api.github.com/repos/erikmaarten/cesium/forks","keys_url":"https://api.github.com/repos/erikmaarten/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikmaarten/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikmaarten/cesium/teams","hooks_url":"https://api.github.com/repos/erikmaarten/cesium/hooks","issue_events_url":"https://api.github.com/repos/erikmaarten/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/erikmaarten/cesium/events","assignees_url":"https://api.github.com/repos/erikmaarten/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/erikmaarten/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/erikmaarten/cesium/tags","blobs_url":"https://api.github.com/repos/erikmaarten/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikmaarten/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikmaarten/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikmaarten/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikmaarten/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/erikmaarten/cesium/languages","stargazers_url":"https://api.github.com/repos/erikmaarten/cesium/stargazers","contributors_url":"https://api.github.com/repos/erikmaarten/cesium/contributors","subscribers_url":"https://api.github.com/repos/erikmaarten/cesium/subscribers","subscription_url":"https://api.github.com/repos/erikmaarten/cesium/subscription","commits_url":"https://api.github.com/repos/erikmaarten/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikmaarten/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikmaarten/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikmaarten/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikmaarten/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/erikmaarten/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikmaarten/cesium/merges","archive_url":"https://api.github.com/repos/erikmaarten/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikmaarten/cesium/downloads","issues_url":"https://api.github.com/repos/erikmaarten/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/erikmaarten/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/erikmaarten/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/erikmaarten/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikmaarten/cesium/labels{/name}","releases_url":"https://api.github.com/repos/erikmaarten/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/erikmaarten/cesium/deployments","created_at":"2016-10-24T11:09:37Z","updated_at":"2016-10-24T11:09:50Z","pushed_at":"2016-12-14T22:53:43Z","git_url":"git://github.com/erikmaarten/cesium.git","ssh_url":"git@github.com:erikmaarten/cesium.git","clone_url":"https://github.com/erikmaarten/cesium.git","svn_url":"https://github.com/erikmaarten/cesium","homepage":"http://cesiumjs.org/","size":235723,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"571dca3f3a7b857315d6201bcd4949a71ef65b85","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2016-12-15T10:46:44Z","pushed_at":"2016-12-15T15:57:33Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"http://cesiumjs.org/","size":263599,"stargazers_count":1864,"watchers_count":1864,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":887,"mirror_url":null,"open_issues_count":494,"forks":887,"open_issues":494,"watchers":1864,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4726"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4726/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4726/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/4cf758500e56816d9f73a60771f17d12bc46bc52"}}}}
{"actor":{"display_login":"pjcozzi"}}