{"action":"created","issue":{"url":"https://api.github.com/repos/ranisalt/node-argon2/issues/49","repository_url":"https://api.github.com/repos/ranisalt/node-argon2","labels_url":"https://api.github.com/repos/ranisalt/node-argon2/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/ranisalt/node-argon2/issues/49/comments","events_url":"https://api.github.com/repos/ranisalt/node-argon2/issues/49/events","html_url":"https://github.com/ranisalt/node-argon2/issues/49","id":164202316,"number":49,"title":"C++11 issues with clang at install time","user":{"login":"jdconley","id":264746,"avatar_url":"https://avatars.githubusercontent.com/u/264746?v=3","gravatar_id":"","url":"https://api.github.com/users/jdconley","html_url":"https://github.com/jdconley","followers_url":"https://api.github.com/users/jdconley/followers","following_url":"https://api.github.com/users/jdconley/following{/other_user}","gists_url":"https://api.github.com/users/jdconley/gists{/gist_id}","starred_url":"https://api.github.com/users/jdconley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdconley/subscriptions","organizations_url":"https://api.github.com/users/jdconley/orgs","repos_url":"https://api.github.com/users/jdconley/repos","events_url":"https://api.github.com/users/jdconley/events{/privacy}","received_events_url":"https://api.github.com/users/jdconley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-07T00:07:00Z","updated_at":"2016-07-07T02:00:33Z","closed_at":null,"body":"### Steps to reproduce\r\n1. Followed the basic instructions for node-argon2 v0.12.0 and tried to install with: `CXX=clang++ npm install argon2 --save`\r\n\r\n### Expected behaviour\r\nThe module should install without error.\r\n\r\n### Actual behaviour\r\nThe module failed to install with the following error:\r\n\r\n```\r\n../src/argon2_node.cpp:6:10: fatal error: 'tuple' file not found\r\n#include <tuple>\r\n         ^\r\n```\r\nThis led me to believe the C++11 stdlib wasn't being loaded.\r\n\r\nI confirmed by adding the following to the installation command line:\r\n\r\n```\r\nCXX='clang++ -std=c++11 -stdlib=libc++' npm install argon2 --save\r\n```\r\n\r\nThis workaround was successful. But, it seems there is an issue with the targets in the gyp configuration. I found an interesting SO on how to setup the targets in the gyp config. http://stackoverflow.com/questions/25645057/node-gyp-cannot-compile-a-nodejs-extension-fatal-error-thread-file-not-found\r\n\r\n### Environment\r\nOSX 10.11.5\r\n\r\n**Node version:**\r\n6.3.0\r\n\r\n**Compiler version:**\r\nnode-gyp=3.4.0\r\nclang++=Apple LLVM version 7.3.0 (clang-703.0.31)"},"comment":{"url":"https://api.github.com/repos/ranisalt/node-argon2/issues/comments/230959272","html_url":"https://github.com/ranisalt/node-argon2/issues/49#issuecomment-230959272","issue_url":"https://api.github.com/repos/ranisalt/node-argon2/issues/49","id":230959272,"user":{"login":"jdconley","id":264746,"avatar_url":"https://avatars.githubusercontent.com/u/264746?v=3","gravatar_id":"","url":"https://api.github.com/users/jdconley","html_url":"https://github.com/jdconley","followers_url":"https://api.github.com/users/jdconley/followers","following_url":"https://api.github.com/users/jdconley/following{/other_user}","gists_url":"https://api.github.com/users/jdconley/gists{/gist_id}","starred_url":"https://api.github.com/users/jdconley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdconley/subscriptions","organizations_url":"https://api.github.com/users/jdconley/orgs","repos_url":"https://api.github.com/users/jdconley/repos","events_url":"https://api.github.com/users/jdconley/events{/privacy}","received_events_url":"https://api.github.com/users/jdconley/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T02:00:33Z","updated_at":"2016-07-07T02:00:33Z","body":"I'm working on the PR right now to override the defaults. Unfortunately, just adding the \"cflags\" wasn't enough. It was the \"OTHER_CPLUSPLUSFLAGS\" under the \"xcode_settings\" option that I had to set.\r\n\r\nOn this system, this is what gets output with `node-gyp rebuild --loglevel=silly`. Looks like this system is setup to do `-std=gnu++0x` by default. This was likely something with when I was messing with early C++11, or Unity, or something...\r\n\r\n```\r\n  c++ '-DNODE_GYP_MODULE_NAME=argon2' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_DARWIN_USE_64_BIT_INODE=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DBUILDING_NODE_EXTENSION' '-DNDEBUG' -I/Users/jdconley/.node-gyp/6.3.0/include/node -I/Users/jdconley/.node-gyp/6.3.0/src -I/Users/jdconley/.node-gyp/6.3.0/deps/uv/include -I/Users/jdconley/.node-gyp/6.3.0/deps/v8/include -I../node_modules/nan -I../argon2/include  -Os -gdwarf-2 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF ./Release/.deps/Release/obj.target/argon2/src/argon2_node.o.d.raw   -c -o Release/obj.target/argon2/src/argon2_node.o ../src/argon2_node.cpp\r\n../src/argon2_node.cpp:6:10: fatal error: 'tuple' file not found\r\n#include <tuple>\r\n         ^\r\n```"}}
{"actor":{"display_login":"jdconley"}}