{"action":"closed","number":1087,"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/1087","id":87936412,"html_url":"https://github.com/dotnet/buildtools/pull/1087","diff_url":"https://github.com/dotnet/buildtools/pull/1087.diff","patch_url":"https://github.com/dotnet/buildtools/pull/1087.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/1087","number":1087,"state":"closed","locked":false,"title":"Add support for commands to have a \"default alias\"","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"body":"- Create a new property on Command that allows specifying a \"DefaultAlias\" value where Aliases are listed.  This value is only used if no other flags are provided.  \r\n\r\nIn this incarnation still allows things to continue if the user fails to specify an alias because there might be a scenario where that makes some kind of sense  (I haven't found that yet).   This was inspired by what happened when a user called \"clean.cmd --all.   Since Clean.cmd was explicitly matching on \"-all\", this ended up passing \"clean --all\" to Run.exe, which failed to match the letters to the actual aliases allowed (b, p, c), and since these aliases were needed to pick a build target, no  build target gets specified, and thus \"Build\" is invoked.  \r\n\r\nOnce this change is in CoreFX / other repos, we simply need to tweak their config.json files like:\r\n\r\n  \"clean\": {\r\n      \"alias\": {\r\n        \"b\": { ...        },\r\n        \"p\": {...        },\r\n        \"c\": {... }\r\n        }\r\n      },\r\n      \"defaultAlias\" : \"b\",\r\n      ...\r\nAllowing us to specify the same default behavior as clean.cmd was going to use on a case-by-case basis.","created_at":"2016-10-04T17:15:37Z","updated_at":"2016-10-04T20:00:03Z","closed_at":"2016-10-04T20:00:03Z","merged_at":"2016-10-04T20:00:03Z","merge_commit_sha":"b6e756dcf93cd79c3ccd39e2caf6ccc984faa6e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/1087/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/1087/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/1087/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/728a5cec06172d4e6f70b3a9c357e4a887239cec","head":{"label":"MattGal:clean_cmd_args_1080","ref":"clean_cmd_args_1080","sha":"728a5cec06172d4e6f70b3a9c357e4a887239cec","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"repo":{"id":53159521,"name":"buildtools","full_name":"MattGal/buildtools","owner":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattGal/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/MattGal/buildtools","forks_url":"https://api.github.com/repos/MattGal/buildtools/forks","keys_url":"https://api.github.com/repos/MattGal/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattGal/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattGal/buildtools/teams","hooks_url":"https://api.github.com/repos/MattGal/buildtools/hooks","issue_events_url":"https://api.github.com/repos/MattGal/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/MattGal/buildtools/events","assignees_url":"https://api.github.com/repos/MattGal/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/MattGal/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/MattGal/buildtools/tags","blobs_url":"https://api.github.com/repos/MattGal/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattGal/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattGal/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattGal/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattGal/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/MattGal/buildtools/languages","stargazers_url":"https://api.github.com/repos/MattGal/buildtools/stargazers","contributors_url":"https://api.github.com/repos/MattGal/buildtools/contributors","subscribers_url":"https://api.github.com/repos/MattGal/buildtools/subscribers","subscription_url":"https://api.github.com/repos/MattGal/buildtools/subscription","commits_url":"https://api.github.com/repos/MattGal/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattGal/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattGal/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattGal/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattGal/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/MattGal/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattGal/buildtools/merges","archive_url":"https://api.github.com/repos/MattGal/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattGal/buildtools/downloads","issues_url":"https://api.github.com/repos/MattGal/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/MattGal/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/MattGal/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/MattGal/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattGal/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/MattGal/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/MattGal/buildtools/deployments","created_at":"2016-03-04T19:15:10Z","updated_at":"2016-03-04T19:15:12Z","pushed_at":"2016-10-04T17:48:15Z","git_url":"git://github.com/MattGal/buildtools.git","ssh_url":"git@github.com:MattGal/buildtools.git","clone_url":"https://github.com/MattGal/buildtools.git","svn_url":"https://github.com/MattGal/buildtools","homepage":"","size":3935,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"094e239b8c1e7f1495abf8c7dc96c71e56bf6c96","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2016-10-02T11:47:27Z","pushed_at":"2016-10-04T20:00:03Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":5098,"stargazers_count":426,"watchers_count":426,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":216,"mirror_url":null,"open_issues_count":124,"forks":216,"open_issues":124,"watchers":426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1087"},"html":{"href":"https://github.com/dotnet/buildtools/pull/1087"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/1087"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/1087/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1087/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1087/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/728a5cec06172d4e6f70b3a9c357e4a887239cec"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":25,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"MattGal"}}