{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/1289","repository_url":"https://api.github.com/repos/tensorflow/tensorflow","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/1289/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/1289/comments","events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/1289/events","html_url":"https://github.com/tensorflow/tensorflow/pull/1289","id":136523525,"number":1289,"title":"Use external repository for protobuf dependency.","user":{"login":"davidzchen","id":5283042,"avatar_url":"https://avatars.githubusercontent.com/u/5283042?v=3","gravatar_id":"","url":"https://api.github.com/users/davidzchen","html_url":"https://github.com/davidzchen","followers_url":"https://api.github.com/users/davidzchen/followers","following_url":"https://api.github.com/users/davidzchen/following{/other_user}","gists_url":"https://api.github.com/users/davidzchen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidzchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidzchen/subscriptions","organizations_url":"https://api.github.com/users/davidzchen/orgs","repos_url":"https://api.github.com/users/davidzchen/repos","events_url":"https://api.github.com/users/davidzchen/events{/privacy}","received_events_url":"https://api.github.com/users/davidzchen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-02-25T21:53:25Z","updated_at":"2016-04-09T00:20:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/1289","html_url":"https://github.com/tensorflow/tensorflow/pull/1289","diff_url":"https://github.com/tensorflow/tensorflow/pull/1289.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/1289.patch"},"body":"Currently, TensorFlow uses a Git submodule for its dependency on\r\nprotobuf. This was due to the hack used in protobuf for building Python\r\nsupport with Bazel, which was required since Bazel's Python rules did\r\nnot support adding directories to `PYTHONPATH`. Now that the new\r\n`imports` attribute has been added to the Python rules in Bazel 0.2 and\r\nthe hack for Python support in protobuf has been removed, this change\r\nremoves the `google/protobuf` Git submodule and adds an external\r\nrepository for including protobuf.\r\n\r\nFixes #1069"},"comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments/207660951","html_url":"https://github.com/tensorflow/tensorflow/pull/1289#issuecomment-207660951","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/1289","id":207660951,"user":{"login":"martinwicke","id":577277,"avatar_url":"https://avatars.githubusercontent.com/u/577277?v=3","gravatar_id":"","url":"https://api.github.com/users/martinwicke","html_url":"https://github.com/martinwicke","followers_url":"https://api.github.com/users/martinwicke/followers","following_url":"https://api.github.com/users/martinwicke/following{/other_user}","gists_url":"https://api.github.com/users/martinwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/martinwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinwicke/subscriptions","organizations_url":"https://api.github.com/users/martinwicke/orgs","repos_url":"https://api.github.com/users/martinwicke/repos","events_url":"https://api.github.com/users/martinwicke/events{/privacy}","received_events_url":"https://api.github.com/users/martinwicke/received_events","type":"User","site_admin":false},"created_at":"2016-04-09T00:20:58Z","updated_at":"2016-04-09T00:20:58Z","body":"The exact command is in the log, but the main point is bazel test\n//tensorflow/...\n\n\nOn Fri, Apr 8, 2016 at 14:13 David Z. Chen <notifications@github.com> wrote:\n\n> Opened google/protobuf#1402 <https://github.com/google/protobuf/pull/1402>.\n>\n>\n> What is the Bazel command run for\n> http://ci.tensorflow.org/job/tensorflow-pull-requests-cpu-python3/262/consoleFull?\n> I tried bazel test //... but I got an error about the BUILD file for\n> gmock not being found:\n>\n> ❯❯❯ bazel test //...\n> ERROR: /usr/local/google/home/dzc/Projects/tensorflow/tensorflow/tensorflow/workspace.bzl:21:3: no such package '@gmock_archive//': In new_http_archive rule //external:gmock_archive the 'build_file' attribute does not specify an existing file (/usr/local/google/home/dzc/Projects/tensorflow/tensorflow/google/protobuf/gmock.BUILD does not exist) and referenced by '//external:gtest'.\n> ERROR: Loading failed; build aborted.\n> INFO: Elapsed time: 0.190s\n> ERROR: Couldn't start the build. Unable to run tests.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n> Reply to this email directly or view it on GitHub\n> <https://github.com/tensorflow/tensorflow/pull/1289#issuecomment-207608299>\n>\n"}}