{"action":"opened","issue":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/12710","repository_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin","labels_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/12710/labels{/name}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/12710/comments","events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/12710/events","html_url":"https://github.com/phpmyadmin/phpmyadmin/issues/12710","id":189584658,"number":12710,"title":"unneeded check for <","user":{"login":"emanuelb","id":1792055,"avatar_url":"https://avatars.githubusercontent.com/u/1792055?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuelb","html_url":"https://github.com/emanuelb","followers_url":"https://api.github.com/users/emanuelb/followers","following_url":"https://api.github.com/users/emanuelb/following{/other_user}","gists_url":"https://api.github.com/users/emanuelb/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuelb/subscriptions","organizations_url":"https://api.github.com/users/emanuelb/orgs","repos_url":"https://api.github.com/users/emanuelb/repos","events_url":"https://api.github.com/users/emanuelb/events{/privacy}","received_events_url":"https://api.github.com/users/emanuelb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-16T04:27:57Z","updated_at":"2016-11-16T04:27:57Z","closed_at":null,"body":"1. in:\r\nhttps://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/LanguageManager.php#L846\r\n```\r\n        if ($accepted_languages && false === mb_strpos($accepted_languages, '<')) {\r\n```\r\nThe matchesAcceptLanguage function use the value of $accepted_languages in preg_match call that will determinate if $language will be returned (it match the $accepted_languages)\r\nThus, the below:\r\n```\r\n && false === mb_strpos($accepted_languages, '<')\r\n```\r\nneed to be removed.\r\n\r\n2. in:\r\nhttps://github.com/phpmyadmin/phpmyadmin/blob/9517695eb4774abea799cc4e8abc0c4247dea915/libraries/plugins/auth/AuthenticationHttp.php#L129\r\n```\r\n                && false === strpos(PMA_getenv('HTTP_AUTHORIZATION'), '<')\r\n```\r\nalso look useless (exists only in parsing of one of AUTHORIZATION headers, username can contain <)"}}
{"actor":{"display_login":"emanuelb"}}