{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/go-systemd/pulls/comments/70823540","id":70823540,"diff_hunk":"@@ -2,30 +2,37 @@\n package daemon\n \n import (\n-\t\"errors\"\n \t\"net\"\n \t\"os\"\n )\n \n-var SdNotifyNoSocket = errors.New(\"No socket\")\n-\n // SdNotify sends a message to the init daemon. It is common to ignore the error.\n-func SdNotify(state string) error {\n+// It returns one of the following:\n+// (false, nil) - notification not supported","path":"daemon/sdnotify.go","position":14,"original_position":14,"commit_id":"6d582d3cd31cb08a4f245f25472ecf1b77896aca","original_commit_id":"6d582d3cd31cb08a4f245f25472ecf1b77896aca","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":" (i.e. NOTIFY_SOCKET is unset)","created_at":"2016-07-14T15:11:16Z","updated_at":"2016-07-14T15:11:16Z","html_url":"https://github.com/coreos/go-systemd/pull/185#discussion_r70823540","pull_request_url":"https://api.github.com/repos/coreos/go-systemd/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/comments/70823540"},"html":{"href":"https://github.com/coreos/go-systemd/pull/185#discussion_r70823540"},"pull_request":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/go-systemd/pulls/185","id":74793438,"html_url":"https://github.com/coreos/go-systemd/pull/185","diff_url":"https://github.com/coreos/go-systemd/pull/185.diff","patch_url":"https://github.com/coreos/go-systemd/pull/185.patch","issue_url":"https://api.github.com/repos/coreos/go-systemd/issues/185","number":185,"state":"open","locked":false,"title":"daemon: improve SdNotify errors signaling","user":{"login":"alepuccetti","id":6577391,"avatar_url":"https://avatars.githubusercontent.com/u/6577391?v=3","gravatar_id":"","url":"https://api.github.com/users/alepuccetti","html_url":"https://github.com/alepuccetti","followers_url":"https://api.github.com/users/alepuccetti/followers","following_url":"https://api.github.com/users/alepuccetti/following{/other_user}","gists_url":"https://api.github.com/users/alepuccetti/gists{/gist_id}","starred_url":"https://api.github.com/users/alepuccetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alepuccetti/subscriptions","organizations_url":"https://api.github.com/users/alepuccetti/orgs","repos_url":"https://api.github.com/users/alepuccetti/repos","events_url":"https://api.github.com/users/alepuccetti/events{/privacy}","received_events_url":"https://api.github.com/users/alepuccetti/received_events","type":"User","site_admin":false},"body":"This patch makes SdNotify return value compliant to the sd_notify()\r\ndocumentation. See sd_notify(3) man page.\r\n\r\nFixes: https://github.com/coreos/go-systemd/issues/184","created_at":"2016-06-22T14:24:44Z","updated_at":"2016-07-14T15:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c564f340d4fe19ba21dd7d31743ee1bb7d93bb4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/go-systemd/pulls/185/commits","review_comments_url":"https://api.github.com/repos/coreos/go-systemd/pulls/185/comments","review_comment_url":"https://api.github.com/repos/coreos/go-systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/go-systemd/issues/185/comments","statuses_url":"https://api.github.com/repos/coreos/go-systemd/statuses/6d582d3cd31cb08a4f245f25472ecf1b77896aca","head":{"label":"kinvolk:alessandro/sdnotify","ref":"alessandro/sdnotify","sha":"6d582d3cd31cb08a4f245f25472ecf1b77896aca","user":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":48180290,"name":"go-systemd","full_name":"kinvolk/go-systemd","owner":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinvolk/go-systemd","description":"Go bindings to systemd socket activation, journal, D-Bus, and unit files","fork":true,"url":"https://api.github.com/repos/kinvolk/go-systemd","forks_url":"https://api.github.com/repos/kinvolk/go-systemd/forks","keys_url":"https://api.github.com/repos/kinvolk/go-systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/go-systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/go-systemd/teams","hooks_url":"https://api.github.com/repos/kinvolk/go-systemd/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/go-systemd/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/go-systemd/events","assignees_url":"https://api.github.com/repos/kinvolk/go-systemd/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/go-systemd/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/go-systemd/tags","blobs_url":"https://api.github.com/repos/kinvolk/go-systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/go-systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/go-systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/go-systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/go-systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/go-systemd/languages","stargazers_url":"https://api.github.com/repos/kinvolk/go-systemd/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/go-systemd/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/go-systemd/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/go-systemd/subscription","commits_url":"https://api.github.com/repos/kinvolk/go-systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/go-systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/go-systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/go-systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/go-systemd/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/go-systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/go-systemd/merges","archive_url":"https://api.github.com/repos/kinvolk/go-systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/go-systemd/downloads","issues_url":"https://api.github.com/repos/kinvolk/go-systemd/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/go-systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/go-systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/go-systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/go-systemd/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/go-systemd/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/go-systemd/deployments","created_at":"2015-12-17T14:53:48Z","updated_at":"2015-12-17T14:53:49Z","pushed_at":"2016-07-14T14:08:16Z","git_url":"git://github.com/kinvolk/go-systemd.git","ssh_url":"git@github.com:kinvolk/go-systemd.git","clone_url":"https://github.com/kinvolk/go-systemd.git","svn_url":"https://github.com/kinvolk/go-systemd","homepage":"","size":363,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"d4039021cfc2d0ea21d34afda21631314e83f75a","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":12821303,"name":"go-systemd","full_name":"coreos/go-systemd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/go-systemd","description":"Go bindings to systemd socket activation, journal, D-Bus, and unit files","fork":false,"url":"https://api.github.com/repos/coreos/go-systemd","forks_url":"https://api.github.com/repos/coreos/go-systemd/forks","keys_url":"https://api.github.com/repos/coreos/go-systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/go-systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/go-systemd/teams","hooks_url":"https://api.github.com/repos/coreos/go-systemd/hooks","issue_events_url":"https://api.github.com/repos/coreos/go-systemd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/go-systemd/events","assignees_url":"https://api.github.com/repos/coreos/go-systemd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/go-systemd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/go-systemd/tags","blobs_url":"https://api.github.com/repos/coreos/go-systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/go-systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/go-systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/go-systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/go-systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/go-systemd/languages","stargazers_url":"https://api.github.com/repos/coreos/go-systemd/stargazers","contributors_url":"https://api.github.com/repos/coreos/go-systemd/contributors","subscribers_url":"https://api.github.com/repos/coreos/go-systemd/subscribers","subscription_url":"https://api.github.com/repos/coreos/go-systemd/subscription","commits_url":"https://api.github.com/repos/coreos/go-systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/go-systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/go-systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/go-systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/go-systemd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/go-systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/go-systemd/merges","archive_url":"https://api.github.com/repos/coreos/go-systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/go-systemd/downloads","issues_url":"https://api.github.com/repos/coreos/go-systemd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/go-systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/go-systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/go-systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/go-systemd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/go-systemd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/go-systemd/deployments","created_at":"2013-09-13T23:13:51Z","updated_at":"2016-07-11T03:15:18Z","pushed_at":"2016-07-14T14:08:17Z","git_url":"git://github.com/coreos/go-systemd.git","ssh_url":"git@github.com:coreos/go-systemd.git","clone_url":"https://github.com/coreos/go-systemd.git","svn_url":"https://github.com/coreos/go-systemd","homepage":"","size":553,"stargazers_count":288,"watchers_count":288,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":16,"forks":92,"open_issues":16,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/185"},"html":{"href":"https://github.com/coreos/go-systemd/pull/185"},"issue":{"href":"https://api.github.com/repos/coreos/go-systemd/issues/185"},"comments":{"href":"https://api.github.com/repos/coreos/go-systemd/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/go-systemd/statuses/6d582d3cd31cb08a4f245f25472ecf1b77896aca"}}}}
{"actor":{"display_login":"jonboulle"}}