{"action":"created","issue":{"url":"https://api.github.com/repos/apollostack/apollo-client/issues/139","repository_url":"https://api.github.com/repos/apollostack/apollo-client","labels_url":"https://api.github.com/repos/apollostack/apollo-client/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/issues/139/comments","events_url":"https://api.github.com/repos/apollostack/apollo-client/issues/139/events","html_url":"https://github.com/apollostack/apollo-client/issues/139","id":150055405,"number":139,"title":"Changing observable response structure","user":{"login":"Urigo","id":1297448,"avatar_url":"https://avatars.githubusercontent.com/u/1297448?v=3","gravatar_id":"","url":"https://api.github.com/users/Urigo","html_url":"https://github.com/Urigo","followers_url":"https://api.github.com/users/Urigo/followers","following_url":"https://api.github.com/users/Urigo/following{/other_user}","gists_url":"https://api.github.com/users/Urigo/gists{/gist_id}","starred_url":"https://api.github.com/users/Urigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Urigo/subscriptions","organizations_url":"https://api.github.com/users/Urigo/orgs","repos_url":"https://api.github.com/users/Urigo/repos","events_url":"https://api.github.com/users/Urigo/events{/privacy}","received_events_url":"https://api.github.com/users/Urigo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-21T12:11:33Z","updated_at":"2016-04-21T12:14:40Z","closed_at":null,"body":"Right now from the Observable we return the data in the following format:\r\n`data.queryName`\r\n\r\nthat makes the need of another pipe in Angular 2.0 on top of the default `async` pipe that handles observables.\r\n\r\nAs we are always returning one query, maybe it's a good idea to return the observable without those prefixes.\r\nThe question is how to handle errors.\r\nI think that we should use the stadard way with supplying an `error` function hanlder, as specified here:\r\nhttps://github.com/zenparsing/es-observable\r\nand here: http://reactivex.io/rxjs/class/es6/Observable.js~Observable.html\r\n\r\n@martijnwalraven @stubailo \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apollostack/apollo-client/issues/comments/212887367","html_url":"https://github.com/apollostack/apollo-client/issues/139#issuecomment-212887367","issue_url":"https://api.github.com/repos/apollostack/apollo-client/issues/139","id":212887367,"user":{"login":"martijnwalraven","id":54485,"avatar_url":"https://avatars.githubusercontent.com/u/54485?v=3","gravatar_id":"","url":"https://api.github.com/users/martijnwalraven","html_url":"https://github.com/martijnwalraven","followers_url":"https://api.github.com/users/martijnwalraven/followers","following_url":"https://api.github.com/users/martijnwalraven/following{/other_user}","gists_url":"https://api.github.com/users/martijnwalraven/gists{/gist_id}","starred_url":"https://api.github.com/users/martijnwalraven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martijnwalraven/subscriptions","organizations_url":"https://api.github.com/users/martijnwalraven/orgs","repos_url":"https://api.github.com/users/martijnwalraven/repos","events_url":"https://api.github.com/users/martijnwalraven/events{/privacy}","received_events_url":"https://api.github.com/users/martijnwalraven/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T12:14:40Z","updated_at":"2016-04-21T12:14:40Z","body":"We already use the `error` handler for true errors like network errors, but the question is what to do with graphql errors.\r\n\r\nThe issue is that a graphql response can include both partial results and a list of errors. So we would have to either not support partial results or include some other way of getting access to the errors."}}