{"action":"created","comment":{"url":"https://api.github.com/repos/i3/i3/pulls/comments/48710701","id":48710701,"diff_hunk":"@@ -857,8 +859,21 @@ sub launch_with_config {\n         restart => $ENV{RESTART},\n         cv => $cv,\n         dont_create_temp_dir => $args{dont_create_temp_dir},\n+        validate => $args{validate},\n     );\n \n+    # If we called i3 with -C, we wait for it to exit and then return as\n+    # there's nothing else we need to do.\n+    if ($args{validate}) {\n+        $cv->recv;\n+        waitpid $i3_pid, 0;\n+\n+        # We need this since exit_gracefully will not be called in this case.\n+        undef $i3_pid;\n+\n+        return undef;","path":"testcases/lib/i3test.pm","position":32,"original_position":32,"commit_id":"cd4bd637cee3357dc4e5d95a96163154576f0a3b","original_commit_id":"cd4bd637cee3357dc4e5d95a96163154576f0a3b","user":{"login":"stapelberg","id":55506,"avatar_url":"https://avatars.githubusercontent.com/u/55506?v=3","gravatar_id":"","url":"https://api.github.com/users/stapelberg","html_url":"https://github.com/stapelberg","followers_url":"https://api.github.com/users/stapelberg/followers","following_url":"https://api.github.com/users/stapelberg/following{/other_user}","gists_url":"https://api.github.com/users/stapelberg/gists{/gist_id}","starred_url":"https://api.github.com/users/stapelberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stapelberg/subscriptions","organizations_url":"https://api.github.com/users/stapelberg/orgs","repos_url":"https://api.github.com/users/stapelberg/repos","events_url":"https://api.github.com/users/stapelberg/events{/privacy}","received_events_url":"https://api.github.com/users/stapelberg/received_events","type":"User","site_admin":false},"body":"Wouldn’t it make sense to return `$?` (or `${^CHILD_ERROR_NATIVE}` if you prefer the expressive forms) so that we can check the exit code as well?","created_at":"2016-01-04T08:18:46Z","updated_at":"2016-01-04T08:18:46Z","html_url":"https://github.com/i3/i3/pull/2145#discussion_r48710701","pull_request_url":"https://api.github.com/repos/i3/i3/pulls/2145","_links":{"self":{"href":"https://api.github.com/repos/i3/i3/pulls/comments/48710701"},"html":{"href":"https://github.com/i3/i3/pull/2145#discussion_r48710701"},"pull_request":{"href":"https://api.github.com/repos/i3/i3/pulls/2145"}}},"pull_request":{"url":"https://api.github.com/repos/i3/i3/pulls/2145","id":54901261,"html_url":"https://github.com/i3/i3/pull/2145","diff_url":"https://github.com/i3/i3/pull/2145.diff","patch_url":"https://github.com/i3/i3/pull/2145.patch","issue_url":"https://api.github.com/repos/i3/i3/issues/2145","number":2145,"state":"open","locked":false,"title":"Fix segfault when calling \"i3 -C\".","user":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"body":"Commit 287a0b4 introduced a segfault when validating the i3 config\r\nas the root_screen will not be set in this case, causing a null\r\npointer dereference.\r\n\r\nfixes #2144","created_at":"2016-01-02T05:04:52Z","updated_at":"2016-01-04T08:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c103708cbba4882aad63b488d47b2856e48e15ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/i3/i3/pulls/2145/commits","review_comments_url":"https://api.github.com/repos/i3/i3/pulls/2145/comments","review_comment_url":"https://api.github.com/repos/i3/i3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/i3/i3/issues/2145/comments","statuses_url":"https://api.github.com/repos/i3/i3/statuses/cd4bd637cee3357dc4e5d95a96163154576f0a3b","head":{"label":"Airblader:bug-2144","ref":"bug-2144","sha":"cd4bd637cee3357dc4e5d95a96163154576f0a3b","user":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"repo":{"id":30594072,"name":"i3-original","full_name":"Airblader/i3-original","owner":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Airblader/i3-original","description":"Plain fork of vanilla i3 to submit pull requests","fork":true,"url":"https://api.github.com/repos/Airblader/i3-original","forks_url":"https://api.github.com/repos/Airblader/i3-original/forks","keys_url":"https://api.github.com/repos/Airblader/i3-original/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Airblader/i3-original/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Airblader/i3-original/teams","hooks_url":"https://api.github.com/repos/Airblader/i3-original/hooks","issue_events_url":"https://api.github.com/repos/Airblader/i3-original/issues/events{/number}","events_url":"https://api.github.com/repos/Airblader/i3-original/events","assignees_url":"https://api.github.com/repos/Airblader/i3-original/assignees{/user}","branches_url":"https://api.github.com/repos/Airblader/i3-original/branches{/branch}","tags_url":"https://api.github.com/repos/Airblader/i3-original/tags","blobs_url":"https://api.github.com/repos/Airblader/i3-original/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Airblader/i3-original/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Airblader/i3-original/git/refs{/sha}","trees_url":"https://api.github.com/repos/Airblader/i3-original/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Airblader/i3-original/statuses/{sha}","languages_url":"https://api.github.com/repos/Airblader/i3-original/languages","stargazers_url":"https://api.github.com/repos/Airblader/i3-original/stargazers","contributors_url":"https://api.github.com/repos/Airblader/i3-original/contributors","subscribers_url":"https://api.github.com/repos/Airblader/i3-original/subscribers","subscription_url":"https://api.github.com/repos/Airblader/i3-original/subscription","commits_url":"https://api.github.com/repos/Airblader/i3-original/commits{/sha}","git_commits_url":"https://api.github.com/repos/Airblader/i3-original/git/commits{/sha}","comments_url":"https://api.github.com/repos/Airblader/i3-original/comments{/number}","issue_comment_url":"https://api.github.com/repos/Airblader/i3-original/issues/comments{/number}","contents_url":"https://api.github.com/repos/Airblader/i3-original/contents/{+path}","compare_url":"https://api.github.com/repos/Airblader/i3-original/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Airblader/i3-original/merges","archive_url":"https://api.github.com/repos/Airblader/i3-original/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Airblader/i3-original/downloads","issues_url":"https://api.github.com/repos/Airblader/i3-original/issues{/number}","pulls_url":"https://api.github.com/repos/Airblader/i3-original/pulls{/number}","milestones_url":"https://api.github.com/repos/Airblader/i3-original/milestones{/number}","notifications_url":"https://api.github.com/repos/Airblader/i3-original/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Airblader/i3-original/labels{/name}","releases_url":"https://api.github.com/repos/Airblader/i3-original/releases{/id}","created_at":"2015-02-10T13:49:15Z","updated_at":"2015-05-02T20:20:17Z","pushed_at":"2016-01-04T02:48:53Z","git_url":"git://github.com/Airblader/i3-original.git","ssh_url":"git@github.com:Airblader/i3-original.git","clone_url":"https://github.com/Airblader/i3-original.git","svn_url":"https://github.com/Airblader/i3-original","homepage":"","size":8154,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"next"}},"base":{"label":"i3:next","ref":"next","sha":"98875fda762142419d557e7d99dde39eaa52f4bf","user":{"login":"i3","id":7904352,"avatar_url":"https://avatars.githubusercontent.com/u/7904352?v=3","gravatar_id":"","url":"https://api.github.com/users/i3","html_url":"https://github.com/i3","followers_url":"https://api.github.com/users/i3/followers","following_url":"https://api.github.com/users/i3/following{/other_user}","gists_url":"https://api.github.com/users/i3/gists{/gist_id}","starred_url":"https://api.github.com/users/i3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3/subscriptions","organizations_url":"https://api.github.com/users/i3/orgs","repos_url":"https://api.github.com/users/i3/repos","events_url":"https://api.github.com/users/i3/events{/privacy}","received_events_url":"https://api.github.com/users/i3/received_events","type":"Organization","site_admin":false},"repo":{"id":30291090,"name":"i3","full_name":"i3/i3","owner":{"login":"i3","id":7904352,"avatar_url":"https://avatars.githubusercontent.com/u/7904352?v=3","gravatar_id":"","url":"https://api.github.com/users/i3","html_url":"https://github.com/i3","followers_url":"https://api.github.com/users/i3/followers","following_url":"https://api.github.com/users/i3/following{/other_user}","gists_url":"https://api.github.com/users/i3/gists{/gist_id}","starred_url":"https://api.github.com/users/i3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3/subscriptions","organizations_url":"https://api.github.com/users/i3/orgs","repos_url":"https://api.github.com/users/i3/repos","events_url":"https://api.github.com/users/i3/events{/privacy}","received_events_url":"https://api.github.com/users/i3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/i3/i3","description":"A better tiling and dynamic window manager","fork":false,"url":"https://api.github.com/repos/i3/i3","forks_url":"https://api.github.com/repos/i3/i3/forks","keys_url":"https://api.github.com/repos/i3/i3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/i3/i3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/i3/i3/teams","hooks_url":"https://api.github.com/repos/i3/i3/hooks","issue_events_url":"https://api.github.com/repos/i3/i3/issues/events{/number}","events_url":"https://api.github.com/repos/i3/i3/events","assignees_url":"https://api.github.com/repos/i3/i3/assignees{/user}","branches_url":"https://api.github.com/repos/i3/i3/branches{/branch}","tags_url":"https://api.github.com/repos/i3/i3/tags","blobs_url":"https://api.github.com/repos/i3/i3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/i3/i3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/i3/i3/git/refs{/sha}","trees_url":"https://api.github.com/repos/i3/i3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/i3/i3/statuses/{sha}","languages_url":"https://api.github.com/repos/i3/i3/languages","stargazers_url":"https://api.github.com/repos/i3/i3/stargazers","contributors_url":"https://api.github.com/repos/i3/i3/contributors","subscribers_url":"https://api.github.com/repos/i3/i3/subscribers","subscription_url":"https://api.github.com/repos/i3/i3/subscription","commits_url":"https://api.github.com/repos/i3/i3/commits{/sha}","git_commits_url":"https://api.github.com/repos/i3/i3/git/commits{/sha}","comments_url":"https://api.github.com/repos/i3/i3/comments{/number}","issue_comment_url":"https://api.github.com/repos/i3/i3/issues/comments{/number}","contents_url":"https://api.github.com/repos/i3/i3/contents/{+path}","compare_url":"https://api.github.com/repos/i3/i3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/i3/i3/merges","archive_url":"https://api.github.com/repos/i3/i3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/i3/i3/downloads","issues_url":"https://api.github.com/repos/i3/i3/issues{/number}","pulls_url":"https://api.github.com/repos/i3/i3/pulls{/number}","milestones_url":"https://api.github.com/repos/i3/i3/milestones{/number}","notifications_url":"https://api.github.com/repos/i3/i3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/i3/i3/labels{/name}","releases_url":"https://api.github.com/repos/i3/i3/releases{/id}","created_at":"2015-02-04T09:23:51Z","updated_at":"2016-01-03T22:01:13Z","pushed_at":"2016-01-04T08:04:52Z","git_url":"git://github.com/i3/i3.git","ssh_url":"git@github.com:i3/i3.git","clone_url":"https://github.com/i3/i3.git","svn_url":"https://github.com/i3/i3","homepage":"http://i3wm.org/","size":8491,"stargazers_count":906,"watchers_count":906,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":66,"forks":122,"open_issues":66,"watchers":906,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/i3/i3/pulls/2145"},"html":{"href":"https://github.com/i3/i3/pull/2145"},"issue":{"href":"https://api.github.com/repos/i3/i3/issues/2145"},"comments":{"href":"https://api.github.com/repos/i3/i3/issues/2145/comments"},"review_comments":{"href":"https://api.github.com/repos/i3/i3/pulls/2145/comments"},"review_comment":{"href":"https://api.github.com/repos/i3/i3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/i3/i3/pulls/2145/commits"},"statuses":{"href":"https://api.github.com/repos/i3/i3/statuses/cd4bd637cee3357dc4e5d95a96163154576f0a3b"}}}}