{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3383","repository_url":"https://api.github.com/repos/ansible/ansible-modules-core","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3383/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3383/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3383/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/3383","id":146584753,"number":3383,"title":"Add provider network parameters to openstack os_network","user":{"login":"dalees","id":242824,"avatar_url":"https://avatars.githubusercontent.com/u/242824?v=3","gravatar_id":"","url":"https://api.github.com/users/dalees","html_url":"https://github.com/dalees","followers_url":"https://api.github.com/users/dalees/followers","following_url":"https://api.github.com/users/dalees/following{/other_user}","gists_url":"https://api.github.com/users/dalees/gists{/gist_id}","starred_url":"https://api.github.com/users/dalees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalees/subscriptions","organizations_url":"https://api.github.com/users/dalees/orgs","repos_url":"https://api.github.com/users/dalees/repos","events_url":"https://api.github.com/users/dalees/events{/privacy}","received_events_url":"https://api.github.com/users/dalees/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/cloud","name":"cloud","color":"c7def8"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/community_review","name":"community_review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-07T11:09:50Z","updated_at":"2016-04-07T18:07:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3383","html_url":"https://github.com/ansible/ansible-modules-core/pull/3383","diff_url":"https://github.com/ansible/ansible-modules-core/pull/3383.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/3383.patch"},"body":"##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\ncloud/openstack/os_network.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.0.1.0\r\n  config file = \r\n  configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\nShade now supports a provider dict as argument to create_network\r\nso we can support a few extra optional arguments for os_network:\r\n* provider_network_type\r\n* provider_physical_network\r\n* provider_segmentation_id\r\n\r\nThis is an exhaustive list of the arguments that Shade implemented in the following commit:\r\nhttps://github.com/openstack-infra/shade/commit/11a8527558fed6943b583b14dffc1c24818ce9a4\r\n\r\nThis allows a playbook to contain the following structure, to create a flat network whereas previously this was not possible.\r\n```\r\n  os_network:\r\n    cloud: admincloud\r\n    state: present\r\n    name: public\r\n    external: True\r\n    provider_network_type: flat\r\n    provider_physical_network: external\r\n```"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/207031891","html_url":"https://github.com/ansible/ansible-modules-core/pull/3383#issuecomment-207031891","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3383","id":207031891,"user":{"login":"Shrews","id":925883,"avatar_url":"https://avatars.githubusercontent.com/u/925883?v=3","gravatar_id":"","url":"https://api.github.com/users/Shrews","html_url":"https://github.com/Shrews","followers_url":"https://api.github.com/users/Shrews/followers","following_url":"https://api.github.com/users/Shrews/following{/other_user}","gists_url":"https://api.github.com/users/Shrews/gists{/gist_id}","starred_url":"https://api.github.com/users/Shrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shrews/subscriptions","organizations_url":"https://api.github.com/users/Shrews/orgs","repos_url":"https://api.github.com/users/Shrews/repos","events_url":"https://api.github.com/users/Shrews/events{/privacy}","received_events_url":"https://api.github.com/users/Shrews/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T18:07:32Z","updated_at":"2016-04-07T18:07:32Z","body":"Thanks @dalees.\r\n\r\nActually, I have this exact same change available because someone in the community asked for it, but have not submitted a PR for it yet. I was waiting for feedback from the community member as to whether it worked for them, but they never responded. It's almost identical to your change. We can do one of two things here: A) use your change, but make the modifications I suggested (also, we need to document the new parameters), or B) I'll just submit mine as a PR if you can verify that it works for you. Mine can be found here:\r\n\r\nhttps://github.com/Shrews/ansible-modules-core/blob/os_network_provider/cloud/openstack/os_network.py"}}