{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/48992793","id":48992793,"diff_hunk":"@@ -27,7 +28,7 @@ void GenerateMacAddress(const MACConsumer type, u8* mac)\n \t\tbreak;\n \t}\n \n-\tsrand((unsigned int)time(nullptr));\n+\tsrand(Common::Timer::GetTimeMs());","path":"Source/Core/Common/Network.cpp","position":13,"original_position":13,"commit_id":"268aadca3e4f7fc75fc6f0efe136a9bac48f9cbb","original_commit_id":"268aadca3e4f7fc75fc6f0efe136a9bac48f9cbb","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"It would be nice to replace srand with the corresponding functionality in the `<random>` header.","created_at":"2016-01-06T18:46:23Z","updated_at":"2016-01-06T18:46:23Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3432#discussion_r48992793","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3432","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/48992793"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3432#discussion_r48992793"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3432"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3432","id":54905412,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3432","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3432.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3432.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3432","number":3432,"state":"open","locked":false,"title":"[Testing required] EXI: Refactor Windows BBA-TAP interface to use IO completion ports","user":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars.githubusercontent.com/u/11288319?v=3","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"body":"The old interface apparently had performance issues, and was prone to crashes (one of them due to the fact that writes to the tap interface were done asynchronously, using an OVERLAPPED structure on the stack, which obviously does not exist once the method returned)\r\n\r\nI don't have many ways of testing this, I've tried with sockettest.dol, and this works okay. Keep in mind, some people have observed that this is slower to get an address on Windows over Linux.\r\n\r\nI believe this is correct behavior, because Windows runs spanning tree on its bridge interface, dropping all packets for 20 seconds or so (L2 loop protection). Apparently there's a registry tweak to disable STP, but I had no luck with that as I only got the bridge to work once (seems it's flaky in W10, or my install is hosed). Running NAT on the interface instead brings the time down to around 4-5 seconds (comparable to Linux?)","created_at":"2016-01-02T12:20:44Z","updated_at":"2016-01-06T18:46:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"876dd254793a6718efa4ec7ad1cc1ff5a517da9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3432/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3432/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3432/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/268aadca3e4f7fc75fc6f0efe136a9bac48f9cbb","head":{"label":"stenzek:bba-tap-win","ref":"bba-tap-win","sha":"268aadca3e4f7fc75fc6f0efe136a9bac48f9cbb","user":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars.githubusercontent.com/u/11288319?v=3","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"repo":{"id":46777992,"name":"dolphin","full_name":"stenzek/dolphin","owner":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars.githubusercontent.com/u/11288319?v=3","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stenzek/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/stenzek/dolphin","forks_url":"https://api.github.com/repos/stenzek/dolphin/forks","keys_url":"https://api.github.com/repos/stenzek/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stenzek/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stenzek/dolphin/teams","hooks_url":"https://api.github.com/repos/stenzek/dolphin/hooks","issue_events_url":"https://api.github.com/repos/stenzek/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/stenzek/dolphin/events","assignees_url":"https://api.github.com/repos/stenzek/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/stenzek/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/stenzek/dolphin/tags","blobs_url":"https://api.github.com/repos/stenzek/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stenzek/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stenzek/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/stenzek/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stenzek/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/stenzek/dolphin/languages","stargazers_url":"https://api.github.com/repos/stenzek/dolphin/stargazers","contributors_url":"https://api.github.com/repos/stenzek/dolphin/contributors","subscribers_url":"https://api.github.com/repos/stenzek/dolphin/subscribers","subscription_url":"https://api.github.com/repos/stenzek/dolphin/subscription","commits_url":"https://api.github.com/repos/stenzek/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/stenzek/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/stenzek/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/stenzek/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/stenzek/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/stenzek/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stenzek/dolphin/merges","archive_url":"https://api.github.com/repos/stenzek/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stenzek/dolphin/downloads","issues_url":"https://api.github.com/repos/stenzek/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/stenzek/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/stenzek/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/stenzek/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stenzek/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/stenzek/dolphin/releases{/id}","created_at":"2015-11-24T08:34:41Z","updated_at":"2015-11-24T08:35:22Z","pushed_at":"2016-01-06T13:39:26Z","git_url":"git://github.com/stenzek/dolphin.git","ssh_url":"git@github.com:stenzek/dolphin.git","clone_url":"https://github.com/stenzek/dolphin.git","svn_url":"https://github.com/stenzek/dolphin","homepage":"https://dolphin-emu.org/","size":234508,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"7c2c73a5fd38de40e7176a4f14a504856b45b635","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-01-06T18:19:21Z","pushed_at":"2016-01-06T18:37:04Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":251838,"stargazers_count":1922,"watchers_count":1922,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":81,"forks":588,"open_issues":81,"watchers":1922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3432"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3432"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3432"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3432/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3432/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3432/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/268aadca3e4f7fc75fc6f0efe136a9bac48f9cbb"}}}}