{"action":"created","issue":{"url":"https://api.github.com/repos/theo-lanman/sidecar/issues/1","repository_url":"https://api.github.com/repos/theo-lanman/sidecar","labels_url":"https://api.github.com/repos/theo-lanman/sidecar/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/theo-lanman/sidecar/issues/1/comments","events_url":"https://api.github.com/repos/theo-lanman/sidecar/issues/1/events","html_url":"https://github.com/theo-lanman/sidecar/pull/1","id":147087069,"number":1,"title":"Feature/tweaks","user":{"login":"StabbyCutyou","id":1528618,"avatar_url":"https://avatars.githubusercontent.com/u/1528618?v=3","gravatar_id":"","url":"https://api.github.com/users/StabbyCutyou","html_url":"https://github.com/StabbyCutyou","followers_url":"https://api.github.com/users/StabbyCutyou/followers","following_url":"https://api.github.com/users/StabbyCutyou/following{/other_user}","gists_url":"https://api.github.com/users/StabbyCutyou/gists{/gist_id}","starred_url":"https://api.github.com/users/StabbyCutyou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StabbyCutyou/subscriptions","organizations_url":"https://api.github.com/users/StabbyCutyou/orgs","repos_url":"https://api.github.com/users/StabbyCutyou/repos","events_url":"https://api.github.com/users/StabbyCutyou/events{/privacy}","received_events_url":"https://api.github.com/users/StabbyCutyou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-09T04:19:42Z","updated_at":"2016-04-10T23:46:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theo-lanman/sidecar/pulls/1","html_url":"https://github.com/theo-lanman/sidecar/pull/1","diff_url":"https://github.com/theo-lanman/sidecar/pull/1.diff","patch_url":"https://github.com/theo-lanman/sidecar/pull/1.patch"},"body":"Small stuff - this seemed pretty good overall man. Couple of things outside of the PR:\r\n\r\n1. Hook up gofmt to your editor of choice. Seriously. It sounds dumb, but it's a very good idea. Always run it on your files as you save, and there are vim plugins to make it easy.\r\n2. You've got the right approach with how you wrote your http handlers, but look at a library called gorilla. it's the same bare bones api as the stdlib, but it's a lot more full-featured.\r\n3. You should always catch every error and decide to log it, ignore it, or pass it up the chain explicitly. \r\n4. Keep in mind that normal channel reads block - so if the intent is \"Wait until this channel sees a message, then continue (and maybe quit what i'm doing entirely)\", just do a regular read on it - it'll block. I used an example below - likewise, if you want to push the result of another blocking call onto a channel to inform the other side, just have the channel push up be the receiver of the blocking call. Again, theres an example below.\r\n\r\nOverall, really good stuff, go-wise."},"comment":{"url":"https://api.github.com/repos/theo-lanman/sidecar/issues/comments/208094058","html_url":"https://github.com/theo-lanman/sidecar/pull/1#issuecomment-208094058","issue_url":"https://api.github.com/repos/theo-lanman/sidecar/issues/1","id":208094058,"user":{"login":"StabbyCutyou","id":1528618,"avatar_url":"https://avatars.githubusercontent.com/u/1528618?v=3","gravatar_id":"","url":"https://api.github.com/users/StabbyCutyou","html_url":"https://github.com/StabbyCutyou","followers_url":"https://api.github.com/users/StabbyCutyou/followers","following_url":"https://api.github.com/users/StabbyCutyou/following{/other_user}","gists_url":"https://api.github.com/users/StabbyCutyou/gists{/gist_id}","starred_url":"https://api.github.com/users/StabbyCutyou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StabbyCutyou/subscriptions","organizations_url":"https://api.github.com/users/StabbyCutyou/orgs","repos_url":"https://api.github.com/users/StabbyCutyou/repos","events_url":"https://api.github.com/users/StabbyCutyou/events{/privacy}","received_events_url":"https://api.github.com/users/StabbyCutyou/received_events","type":"User","site_admin":false},"created_at":"2016-04-10T23:46:46Z","updated_at":"2016-04-10T23:46:46Z","body":"rebased"}}