{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29596","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29596/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29596/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29596/events","html_url":"https://github.com/kubernetes/kubernetes/pull/29596","id":167517357,"number":29596,"title":"pkg/various: plug leaky time.New{Timer,Ticker}s","user":{"login":"matttproud","id":46149,"avatar_url":"https://avatars.githubusercontent.com/u/46149?v=3","gravatar_id":"","url":"https://api.github.com/users/matttproud","html_url":"https://github.com/matttproud","followers_url":"https://api.github.com/users/matttproud/followers","following_url":"https://api.github.com/users/matttproud/following{/other_user}","gists_url":"https://api.github.com/users/matttproud/gists{/gist_id}","starred_url":"https://api.github.com/users/matttproud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matttproud/subscriptions","organizations_url":"https://api.github.com/users/matttproud/orgs","repos_url":"https://api.github.com/users/matttproud/repos","events_url":"https://api.github.com/users/matttproud/events{/privacy}","received_events_url":"https://api.github.com/users/matttproud/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900"}],"state":"open","locked":false,"assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"assignees":[{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2016-07-26T04:11:59Z","updated_at":"2016-07-29T21:06:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29596","html_url":"https://github.com/kubernetes/kubernetes/pull/29596","diff_url":"https://github.com/kubernetes/kubernetes/pull/29596.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/29596.patch"},"body":"According to the documentation for Go package time, `time.Ticker` and\r\n`time.Timer` are uncollectable by garbage collector finalizers.  They\r\nleak until otherwise stopped.  This commit ensures that all remaining\r\ninstances are stopped upon departure from their relative scopes.\r\n\r\nSimilar efforts were incrementally done in #29439 and #29114.\r\n\r\n```release-note\r\n* pkg/various: plugged various time.Ticker and time.Timer leaks.\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/236293485","html_url":"https://github.com/kubernetes/kubernetes/pull/29596#issuecomment-236293485","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29596","id":236293485,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T21:06:10Z","updated_at":"2016-07-29T21:06:10Z","body":"GCE e2e build/test **passed** for commit 5c6292c074e21f91507b04a2ee7284f7f03eac3b.\n* [Test Results](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/29596/kubernetes-pull-build-test-e2e-gce/51026)\n* [Build Log](http://pr-test.k8s.io/29596/kubernetes-pull-build-test-e2e-gce/51026/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/29596/kubernetes-pull-build-test-e2e-gce/51026/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//51026)\n\n"}}
{"actor":{"display_login":"k8s-bot"}}