{"action":"created","issue":{"url":"https://api.github.com/repos/phalcon/cphalcon/issues/12268","repository_url":"https://api.github.com/repos/phalcon/cphalcon","labels_url":"https://api.github.com/repos/phalcon/cphalcon/issues/12268/labels{/name}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/issues/12268/comments","events_url":"https://api.github.com/repos/phalcon/cphalcon/issues/12268/events","html_url":"https://github.com/phalcon/cphalcon/issues/12268","id":180016445,"number":12268,"title":"isAllowed produces different return type than Acl:ALLOWED","user":{"login":"cbichis","id":6471173,"avatar_url":"https://avatars.githubusercontent.com/u/6471173?v=3","gravatar_id":"","url":"https://api.github.com/users/cbichis","html_url":"https://github.com/cbichis","followers_url":"https://api.github.com/users/cbichis/followers","following_url":"https://api.github.com/users/cbichis/following{/other_user}","gists_url":"https://api.github.com/users/cbichis/gists{/gist_id}","starred_url":"https://api.github.com/users/cbichis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbichis/subscriptions","organizations_url":"https://api.github.com/users/cbichis/orgs","repos_url":"https://api.github.com/users/cbichis/repos","events_url":"https://api.github.com/users/cbichis/events{/privacy}","received_events_url":"https://api.github.com/users/cbichis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-29T10:55:00Z","updated_at":"2016-09-29T10:58:50Z","closed_at":null,"body":"Hi,\r\n\r\nINVO is comparing type strict isAllowed with Acl::ALLOW.\r\n\r\nUnfortunately one uses boolean and the other one uses int...\r\n\r\nI think this is not an INVO issue but rather a problem on Phalcon\\Acl."},"comment":{"url":"https://api.github.com/repos/phalcon/cphalcon/issues/comments/250434746","html_url":"https://github.com/phalcon/cphalcon/issues/12268#issuecomment-250434746","issue_url":"https://api.github.com/repos/phalcon/cphalcon/issues/12268","id":250434746,"user":{"login":"Jurigag","id":10086991,"avatar_url":"https://avatars.githubusercontent.com/u/10086991?v=3","gravatar_id":"","url":"https://api.github.com/users/Jurigag","html_url":"https://github.com/Jurigag","followers_url":"https://api.github.com/users/Jurigag/followers","following_url":"https://api.github.com/users/Jurigag/following{/other_user}","gists_url":"https://api.github.com/users/Jurigag/gists{/gist_id}","starred_url":"https://api.github.com/users/Jurigag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jurigag/subscriptions","organizations_url":"https://api.github.com/users/Jurigag/orgs","repos_url":"https://api.github.com/users/Jurigag/repos","events_url":"https://api.github.com/users/Jurigag/events{/privacy}","received_events_url":"https://api.github.com/users/Jurigag/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T10:58:50Z","updated_at":"2016-09-29T10:58:50Z","body":"Well, im guessing we could just change here:\r\n\r\nhttps://github.com/phalcon/cphalcon/blob/master/phalcon/acl.zep#L71\r\nhttps://github.com/phalcon/cphalcon/blob/master/phalcon/acl.zep#L73\r\n\r\nto true/false, it shouldn't cause a problem. But what if someone currently is comparing in his app like:\r\n`=== Acl::ALLOW`\r\n\r\nThen his app will break, so this is pretty much 4.0.0 change."}}
{"actor":{"display_login":"Jurigag"}}