{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/89673029","pull_request_review_id":10216462,"id":89673029,"diff_hunk":"@@ -357,6 +357,8 @@ public function testInsertAfter()\n      */\n     public function testRender()\n     {\n+        $this->assertEmpty($this->breadcrumbs->render());","path":"tests/TestCase/View/Helper/BreadcrumbsHelperTest.php","position":4,"original_position":4,"commit_id":"dc14d4761520c52a9946863eba2e61cba7dafc6c","original_commit_id":"dc14d4761520c52a9946863eba2e61cba7dafc6c","user":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"body":"You might want `assertSame('', $this->breadcrumbs->render())` or `assertNull()`.","created_at":"2016-11-26T15:14:33Z","updated_at":"2016-11-26T15:14:38Z","html_url":"https://github.com/cakephp/cakephp/pull/9801#discussion_r89673029","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9801","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/89673029"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9801#discussion_r89673029"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9801"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/9801","id":95367027,"html_url":"https://github.com/cakephp/cakephp/pull/9801","diff_url":"https://github.com/cakephp/cakephp/pull/9801.diff","patch_url":"https://github.com/cakephp/cakephp/pull/9801.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/9801","number":9801,"state":"open","locked":false,"title":"BreadcrumbsHelper::render() returns null with no crumbs","user":{"login":"mirko-pagliai","id":293199,"avatar_url":"https://avatars.githubusercontent.com/u/293199?v=3","gravatar_id":"","url":"https://api.github.com/users/mirko-pagliai","html_url":"https://github.com/mirko-pagliai","followers_url":"https://api.github.com/users/mirko-pagliai/followers","following_url":"https://api.github.com/users/mirko-pagliai/following{/other_user}","gists_url":"https://api.github.com/users/mirko-pagliai/gists{/gist_id}","starred_url":"https://api.github.com/users/mirko-pagliai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirko-pagliai/subscriptions","organizations_url":"https://api.github.com/users/mirko-pagliai/orgs","repos_url":"https://api.github.com/users/mirko-pagliai/repos","events_url":"https://api.github.com/users/mirko-pagliai/events{/privacy}","received_events_url":"https://api.github.com/users/mirko-pagliai/received_events","type":"User","site_admin":false},"body":"See https://github.com/cakephp/cakephp/issues/9798\r\n\r\nThe `render()` method should return `null` (or a blank string) if empty (now it returns the string `<ul></ul>`), in other words if you have not added any crumb.","created_at":"2016-11-26T09:56:22Z","updated_at":"2016-11-26T15:14:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"836948df1e0ff22869ea616bcb3032a977eee13f","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/113","html_url":"https://github.com/cakephp/cakephp/milestones/3.3.10","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/113/labels","id":2150435,"number":113,"title":"3.3.10","description":"Bugfixes and minor features for 3.3.x","creator":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":5,"state":"open","created_at":"2016-11-22T02:25:52Z","updated_at":"2016-11-26T15:12:38Z","due_on":"2016-12-11T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9801/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9801/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/9801/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/dc14d4761520c52a9946863eba2e61cba7dafc6c","head":{"label":"mirko-pagliai:breadcrumbs","ref":"breadcrumbs","sha":"dc14d4761520c52a9946863eba2e61cba7dafc6c","user":{"login":"mirko-pagliai","id":293199,"avatar_url":"https://avatars.githubusercontent.com/u/293199?v=3","gravatar_id":"","url":"https://api.github.com/users/mirko-pagliai","html_url":"https://github.com/mirko-pagliai","followers_url":"https://api.github.com/users/mirko-pagliai/followers","following_url":"https://api.github.com/users/mirko-pagliai/following{/other_user}","gists_url":"https://api.github.com/users/mirko-pagliai/gists{/gist_id}","starred_url":"https://api.github.com/users/mirko-pagliai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirko-pagliai/subscriptions","organizations_url":"https://api.github.com/users/mirko-pagliai/orgs","repos_url":"https://api.github.com/users/mirko-pagliai/repos","events_url":"https://api.github.com/users/mirko-pagliai/events{/privacy}","received_events_url":"https://api.github.com/users/mirko-pagliai/received_events","type":"User","site_admin":false},"repo":{"id":53579267,"name":"cakephp","full_name":"mirko-pagliai/cakephp","owner":{"login":"mirko-pagliai","id":293199,"avatar_url":"https://avatars.githubusercontent.com/u/293199?v=3","gravatar_id":"","url":"https://api.github.com/users/mirko-pagliai","html_url":"https://github.com/mirko-pagliai","followers_url":"https://api.github.com/users/mirko-pagliai/followers","following_url":"https://api.github.com/users/mirko-pagliai/following{/other_user}","gists_url":"https://api.github.com/users/mirko-pagliai/gists{/gist_id}","starred_url":"https://api.github.com/users/mirko-pagliai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirko-pagliai/subscriptions","organizations_url":"https://api.github.com/users/mirko-pagliai/orgs","repos_url":"https://api.github.com/users/mirko-pagliai/repos","events_url":"https://api.github.com/users/mirko-pagliai/events{/privacy}","received_events_url":"https://api.github.com/users/mirko-pagliai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mirko-pagliai/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/mirko-pagliai/cakephp","forks_url":"https://api.github.com/repos/mirko-pagliai/cakephp/forks","keys_url":"https://api.github.com/repos/mirko-pagliai/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirko-pagliai/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirko-pagliai/cakephp/teams","hooks_url":"https://api.github.com/repos/mirko-pagliai/cakephp/hooks","issue_events_url":"https://api.github.com/repos/mirko-pagliai/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/mirko-pagliai/cakephp/events","assignees_url":"https://api.github.com/repos/mirko-pagliai/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/mirko-pagliai/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/mirko-pagliai/cakephp/tags","blobs_url":"https://api.github.com/repos/mirko-pagliai/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirko-pagliai/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirko-pagliai/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirko-pagliai/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirko-pagliai/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/mirko-pagliai/cakephp/languages","stargazers_url":"https://api.github.com/repos/mirko-pagliai/cakephp/stargazers","contributors_url":"https://api.github.com/repos/mirko-pagliai/cakephp/contributors","subscribers_url":"https://api.github.com/repos/mirko-pagliai/cakephp/subscribers","subscription_url":"https://api.github.com/repos/mirko-pagliai/cakephp/subscription","commits_url":"https://api.github.com/repos/mirko-pagliai/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirko-pagliai/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirko-pagliai/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirko-pagliai/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirko-pagliai/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/mirko-pagliai/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirko-pagliai/cakephp/merges","archive_url":"https://api.github.com/repos/mirko-pagliai/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirko-pagliai/cakephp/downloads","issues_url":"https://api.github.com/repos/mirko-pagliai/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/mirko-pagliai/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/mirko-pagliai/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/mirko-pagliai/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirko-pagliai/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/mirko-pagliai/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/mirko-pagliai/cakephp/deployments","created_at":"2016-03-10T11:28:54Z","updated_at":"2016-03-10T11:29:02Z","pushed_at":"2016-11-26T09:54:56Z","git_url":"git://github.com/mirko-pagliai/cakephp.git","ssh_url":"git@github.com:mirko-pagliai/cakephp.git","clone_url":"https://github.com/mirko-pagliai/cakephp.git","svn_url":"https://github.com/mirko-pagliai/cakephp","homepage":"http://cakephp.org","size":65346,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"f78ed4c267898847d0f5ead938350df59150f901","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2016-11-26T01:32:26Z","pushed_at":"2016-11-26T09:56:22Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":134781,"stargazers_count":6808,"watchers_count":6808,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3081,"mirror_url":null,"open_issues_count":175,"forks":3081,"open_issues":175,"watchers":6808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9801"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9801"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9801"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9801/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9801/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9801/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/dc14d4761520c52a9946863eba2e61cba7dafc6c"}}}}
{"actor":{"display_login":"markstory"}}