{"action":"created","issue":{"url":"https://api.github.com/repos/woodruffw/screenfetch-c/issues/24","repository_url":"https://api.github.com/repos/woodruffw/screenfetch-c","labels_url":"https://api.github.com/repos/woodruffw/screenfetch-c/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/woodruffw/screenfetch-c/issues/24/comments","events_url":"https://api.github.com/repos/woodruffw/screenfetch-c/issues/24/events","html_url":"https://github.com/woodruffw/screenfetch-c/issues/24","id":171903804,"number":24,"title":"Desktop environment on Windows","user":{"login":"darealshinji","id":5700937,"avatar_url":"https://avatars.githubusercontent.com/u/5700937?v=3","gravatar_id":"","url":"https://api.github.com/users/darealshinji","html_url":"https://github.com/darealshinji","followers_url":"https://api.github.com/users/darealshinji/followers","following_url":"https://api.github.com/users/darealshinji/following{/other_user}","gists_url":"https://api.github.com/users/darealshinji/gists{/gist_id}","starred_url":"https://api.github.com/users/darealshinji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darealshinji/subscriptions","organizations_url":"https://api.github.com/users/darealshinji/orgs","repos_url":"https://api.github.com/users/darealshinji/repos","events_url":"https://api.github.com/users/darealshinji/events{/privacy}","received_events_url":"https://api.github.com/users/darealshinji/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/woodruffw/screenfetch-c/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-18T13:41:31Z","updated_at":"2016-08-19T17:18:22Z","closed_at":null,"body":"The Windows version detection in `detect_de()` from `src/plat/win32/detect.c` is a bit wrong.\r\nThe version numbers don't equal exactly the release numbers: https://msdn.microsoft.com/en-us/library/ms724832%28VS.85%29.aspx\r\n\r\nThe detection should probably be more like this:\r\n``` c\r\n\tif ((major == 6 && minor <= 1) || major == 10)\r\n\t\tsafe_strncpy(de_str, \"Aero\", MAX_STRLEN);\r\n\telse if (major == 6 && minor >= 2)\r\n\t\tsafe_strncpy(de_str, \"Metro\", MAX_STRLEN);\r\n\telse\r\n\t\tsafe_strncpy(de_str, \"Luna\", MAX_STRLEN);\r\n```"},"comment":{"url":"https://api.github.com/repos/woodruffw/screenfetch-c/issues/comments/241078666","html_url":"https://github.com/woodruffw/screenfetch-c/issues/24#issuecomment-241078666","issue_url":"https://api.github.com/repos/woodruffw/screenfetch-c/issues/24","id":241078666,"user":{"login":"darealshinji","id":5700937,"avatar_url":"https://avatars.githubusercontent.com/u/5700937?v=3","gravatar_id":"","url":"https://api.github.com/users/darealshinji","html_url":"https://github.com/darealshinji","followers_url":"https://api.github.com/users/darealshinji/followers","following_url":"https://api.github.com/users/darealshinji/following{/other_user}","gists_url":"https://api.github.com/users/darealshinji/gists{/gist_id}","starred_url":"https://api.github.com/users/darealshinji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darealshinji/subscriptions","organizations_url":"https://api.github.com/users/darealshinji/orgs","repos_url":"https://api.github.com/users/darealshinji/repos","events_url":"https://api.github.com/users/darealshinji/events{/privacy}","received_events_url":"https://api.github.com/users/darealshinji/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T17:18:22Z","updated_at":"2016-08-19T17:18:22Z","body":"A quick lookup on Google reveals that Metro is now referred to as \"Modern UI\". Maybe the Windows 8/10 DE should be listed as `Modern UI/Metro`?"}}
{"actor":{"display_login":"darealshinji"}}