{"action":"created","issue":{"url":"https://api.github.com/repos/pandegroup/openmm/issues/1484","repository_url":"https://api.github.com/repos/pandegroup/openmm","labels_url":"https://api.github.com/repos/pandegroup/openmm/issues/1484/labels{/name}","comments_url":"https://api.github.com/repos/pandegroup/openmm/issues/1484/comments","events_url":"https://api.github.com/repos/pandegroup/openmm/issues/1484/events","html_url":"https://github.com/pandegroup/openmm/pull/1484","id":154144469,"number":1484,"title":"Fix error check for GBneck parameters","user":{"login":"swails","id":779022,"avatar_url":"https://avatars.githubusercontent.com/u/779022?v=3","gravatar_id":"","url":"https://api.github.com/users/swails","html_url":"https://github.com/swails","followers_url":"https://api.github.com/users/swails/followers","following_url":"https://api.github.com/users/swails/following{/other_user}","gists_url":"https://api.github.com/users/swails/gists{/gist_id}","starred_url":"https://api.github.com/users/swails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swails/subscriptions","organizations_url":"https://api.github.com/users/swails/orgs","repos_url":"https://api.github.com/users/swails/repos","events_url":"https://api.github.com/users/swails/events{/privacy}","received_events_url":"https://api.github.com/users/swails/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-11T01:59:49Z","updated_at":"2016-05-11T02:21:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pandegroup/openmm/pulls/1484","html_url":"https://github.com/pandegroup/openmm/pull/1484","diff_url":"https://github.com/pandegroup/openmm/pull/1484.diff","patch_url":"https://github.com/pandegroup/openmm/pull/1484.patch"},"body":"This doesn't lead to incorrect results, but it does erroneously flag some radii\r\nas being illegal when they aren't (making it impossible to run some suggested\r\nsystems).\r\n\r\nThe parameters need to be compared to the table limits *before* subtracting off\r\nthe offset, whereas it's currently being done after.\r\n\r\nReported by Alberto Perez in a private email to me."},"comment":{"url":"https://api.github.com/repos/pandegroup/openmm/issues/comments/218345228","html_url":"https://github.com/pandegroup/openmm/pull/1484#issuecomment-218345228","issue_url":"https://api.github.com/repos/pandegroup/openmm/issues/1484","id":218345228,"user":{"login":"jlmaccal","id":108119,"avatar_url":"https://avatars.githubusercontent.com/u/108119?v=3","gravatar_id":"","url":"https://api.github.com/users/jlmaccal","html_url":"https://github.com/jlmaccal","followers_url":"https://api.github.com/users/jlmaccal/followers","following_url":"https://api.github.com/users/jlmaccal/following{/other_user}","gists_url":"https://api.github.com/users/jlmaccal/gists{/gist_id}","starred_url":"https://api.github.com/users/jlmaccal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlmaccal/subscriptions","organizations_url":"https://api.github.com/users/jlmaccal/orgs","repos_url":"https://api.github.com/users/jlmaccal/repos","events_url":"https://api.github.com/users/jlmaccal/events{/privacy}","received_events_url":"https://api.github.com/users/jlmaccal/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T02:21:28Z","updated_at":"2016-05-11T02:21:28Z","body":"Great! I've been meaning to look into this."}}