{"action":"created","comment":{"url":"https://api.github.com/repos/superpowers/superpowers-game/pulls/comments/77434743","id":77434743,"diff_hunk":"@@ -55,6 +58,10 @@ export default class P2BodyConfig extends SupCore.Data.Base.ComponentConfig {\n       if (pub.shape === \"rectangle\") pub.shape = \"box\";\n     }\n \n+    if (pub.formatVersion === 1) {\n+      pub.angle = 0;","path":"plugins/extra/p2js/componentConfigs/P2BodyConfig.ts","position":37,"original_position":37,"commit_id":"735f951d5dc96288c78d4482080d89c7874ab779","original_commit_id":"735f951d5dc96288c78d4482080d89c7874ab779","user":{"login":"bilou84","id":11774622,"avatar_url":"https://avatars.githubusercontent.com/u/11774622?v=3","gravatar_id":"","url":"https://api.github.com/users/bilou84","html_url":"https://github.com/bilou84","followers_url":"https://api.github.com/users/bilou84/followers","following_url":"https://api.github.com/users/bilou84/following{/other_user}","gists_url":"https://api.github.com/users/bilou84/gists{/gist_id}","starred_url":"https://api.github.com/users/bilou84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilou84/subscriptions","organizations_url":"https://api.github.com/users/bilou84/orgs","repos_url":"https://api.github.com/users/bilou84/repos","events_url":"https://api.github.com/users/bilou84/events{/privacy}","received_events_url":"https://api.github.com/users/bilou84/received_events","type":"User","site_admin":false},"body":"Like above, we need to update the formatVersion. So we should have the following line:\r\n`pub.formatVersion = 2;`\r\n\r\nUsually, we put this line at the top of the condition.","created_at":"2016-09-03T10:09:30Z","updated_at":"2016-09-03T10:09:30Z","html_url":"https://github.com/superpowers/superpowers-game/pull/140#discussion_r77434743","pull_request_url":"https://api.github.com/repos/superpowers/superpowers-game/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/superpowers/superpowers-game/pulls/comments/77434743"},"html":{"href":"https://github.com/superpowers/superpowers-game/pull/140#discussion_r77434743"},"pull_request":{"href":"https://api.github.com/repos/superpowers/superpowers-game/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/superpowers/superpowers-game/pulls/140","id":83502457,"html_url":"https://github.com/superpowers/superpowers-game/pull/140","diff_url":"https://github.com/superpowers/superpowers-game/pull/140.diff","patch_url":"https://github.com/superpowers/superpowers-game/pull/140.patch","issue_url":"https://api.github.com/repos/superpowers/superpowers-game/issues/140","number":140,"state":"open","locked":false,"title":"P2js: allow box collider to be at an angle","user":{"login":"Ikalou","id":3008001,"avatar_url":"https://avatars.githubusercontent.com/u/3008001?v=3","gravatar_id":"","url":"https://api.github.com/users/Ikalou","html_url":"https://github.com/Ikalou","followers_url":"https://api.github.com/users/Ikalou/followers","following_url":"https://api.github.com/users/Ikalou/following{/other_user}","gists_url":"https://api.github.com/users/Ikalou/gists{/gist_id}","starred_url":"https://api.github.com/users/Ikalou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ikalou/subscriptions","organizations_url":"https://api.github.com/users/Ikalou/orgs","repos_url":"https://api.github.com/users/Ikalou/repos","events_url":"https://api.github.com/users/Ikalou/events{/privacy}","received_events_url":"https://api.github.com/users/Ikalou/received_events","type":"User","site_admin":false},"body":"It's sometimes useful to have a box collider at an angle relative to the actor. While it would be possible to draw all the sprites perfectly horizontal and rotate the actor instead, I find this process very tedious. The picture bellow shows an example.\r\n\r\n![ps_box_angle](https://cloud.githubusercontent.com/assets/3008001/18140537/4577f076-6fb6-11e6-95d4-878f5f800593.png)\r\n\r\nThis is my first time contributing to superpowers. Please tell me if I should do anything different.\r\n\r\nIn particular, I'm very unsure about two things:\r\n- Is the migration bit in P2BodyConfig alright? I'm not too sure how it works.\r\n- Is it ok to hardcode the z axis the way I did?\r\n\r\nThanks for your feedback.","created_at":"2016-08-31T18:15:50Z","updated_at":"2016-09-03T10:09:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"704a73b565ec4dae00036ba0b034d75be097bba4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/superpowers/superpowers-game/pulls/140/commits","review_comments_url":"https://api.github.com/repos/superpowers/superpowers-game/pulls/140/comments","review_comment_url":"https://api.github.com/repos/superpowers/superpowers-game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superpowers/superpowers-game/issues/140/comments","statuses_url":"https://api.github.com/repos/superpowers/superpowers-game/statuses/735f951d5dc96288c78d4482080d89c7874ab779","head":{"label":"Ikalou:p2js-box-angle","ref":"p2js-box-angle","sha":"735f951d5dc96288c78d4482080d89c7874ab779","user":{"login":"Ikalou","id":3008001,"avatar_url":"https://avatars.githubusercontent.com/u/3008001?v=3","gravatar_id":"","url":"https://api.github.com/users/Ikalou","html_url":"https://github.com/Ikalou","followers_url":"https://api.github.com/users/Ikalou/followers","following_url":"https://api.github.com/users/Ikalou/following{/other_user}","gists_url":"https://api.github.com/users/Ikalou/gists{/gist_id}","starred_url":"https://api.github.com/users/Ikalou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ikalou/subscriptions","organizations_url":"https://api.github.com/users/Ikalou/orgs","repos_url":"https://api.github.com/users/Ikalou/repos","events_url":"https://api.github.com/users/Ikalou/events{/privacy}","received_events_url":"https://api.github.com/users/Ikalou/received_events","type":"User","site_admin":false},"repo":{"id":67053293,"name":"superpowers-game","full_name":"Ikalou/superpowers-game","owner":{"login":"Ikalou","id":3008001,"avatar_url":"https://avatars.githubusercontent.com/u/3008001?v=3","gravatar_id":"","url":"https://api.github.com/users/Ikalou","html_url":"https://github.com/Ikalou","followers_url":"https://api.github.com/users/Ikalou/followers","following_url":"https://api.github.com/users/Ikalou/following{/other_user}","gists_url":"https://api.github.com/users/Ikalou/gists{/gist_id}","starred_url":"https://api.github.com/users/Ikalou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ikalou/subscriptions","organizations_url":"https://api.github.com/users/Ikalou/orgs","repos_url":"https://api.github.com/users/Ikalou/repos","events_url":"https://api.github.com/users/Ikalou/events{/privacy}","received_events_url":"https://api.github.com/users/Ikalou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ikalou/superpowers-game","description":":video_game: Make 2D and 3D games in live collaboration with Superpowers","fork":true,"url":"https://api.github.com/repos/Ikalou/superpowers-game","forks_url":"https://api.github.com/repos/Ikalou/superpowers-game/forks","keys_url":"https://api.github.com/repos/Ikalou/superpowers-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ikalou/superpowers-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ikalou/superpowers-game/teams","hooks_url":"https://api.github.com/repos/Ikalou/superpowers-game/hooks","issue_events_url":"https://api.github.com/repos/Ikalou/superpowers-game/issues/events{/number}","events_url":"https://api.github.com/repos/Ikalou/superpowers-game/events","assignees_url":"https://api.github.com/repos/Ikalou/superpowers-game/assignees{/user}","branches_url":"https://api.github.com/repos/Ikalou/superpowers-game/branches{/branch}","tags_url":"https://api.github.com/repos/Ikalou/superpowers-game/tags","blobs_url":"https://api.github.com/repos/Ikalou/superpowers-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ikalou/superpowers-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ikalou/superpowers-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ikalou/superpowers-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ikalou/superpowers-game/statuses/{sha}","languages_url":"https://api.github.com/repos/Ikalou/superpowers-game/languages","stargazers_url":"https://api.github.com/repos/Ikalou/superpowers-game/stargazers","contributors_url":"https://api.github.com/repos/Ikalou/superpowers-game/contributors","subscribers_url":"https://api.github.com/repos/Ikalou/superpowers-game/subscribers","subscription_url":"https://api.github.com/repos/Ikalou/superpowers-game/subscription","commits_url":"https://api.github.com/repos/Ikalou/superpowers-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ikalou/superpowers-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ikalou/superpowers-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ikalou/superpowers-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ikalou/superpowers-game/contents/{+path}","compare_url":"https://api.github.com/repos/Ikalou/superpowers-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ikalou/superpowers-game/merges","archive_url":"https://api.github.com/repos/Ikalou/superpowers-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ikalou/superpowers-game/downloads","issues_url":"https://api.github.com/repos/Ikalou/superpowers-game/issues{/number}","pulls_url":"https://api.github.com/repos/Ikalou/superpowers-game/pulls{/number}","milestones_url":"https://api.github.com/repos/Ikalou/superpowers-game/milestones{/number}","notifications_url":"https://api.github.com/repos/Ikalou/superpowers-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ikalou/superpowers-game/labels{/name}","releases_url":"https://api.github.com/repos/Ikalou/superpowers-game/releases{/id}","deployments_url":"https://api.github.com/repos/Ikalou/superpowers-game/deployments","created_at":"2016-08-31T16:08:09Z","updated_at":"2016-08-31T16:08:12Z","pushed_at":"2016-09-01T13:30:42Z","git_url":"git://github.com/Ikalou/superpowers-game.git","ssh_url":"git@github.com:Ikalou/superpowers-game.git","clone_url":"https://github.com/Ikalou/superpowers-game.git","svn_url":"https://github.com/Ikalou/superpowers-game","homepage":"http://superpowers-html5.com/","size":7799,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superpowers:master","ref":"master","sha":"ba9dd96eaebc217440e5581c77a95fa8211e2a23","user":{"login":"superpowers","id":10992418,"avatar_url":"https://avatars.githubusercontent.com/u/10992418?v=3","gravatar_id":"","url":"https://api.github.com/users/superpowers","html_url":"https://github.com/superpowers","followers_url":"https://api.github.com/users/superpowers/followers","following_url":"https://api.github.com/users/superpowers/following{/other_user}","gists_url":"https://api.github.com/users/superpowers/gists{/gist_id}","starred_url":"https://api.github.com/users/superpowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superpowers/subscriptions","organizations_url":"https://api.github.com/users/superpowers/orgs","repos_url":"https://api.github.com/users/superpowers/repos","events_url":"https://api.github.com/users/superpowers/events{/privacy}","received_events_url":"https://api.github.com/users/superpowers/received_events","type":"Organization","site_admin":false},"repo":{"id":47674501,"name":"superpowers-game","full_name":"superpowers/superpowers-game","owner":{"login":"superpowers","id":10992418,"avatar_url":"https://avatars.githubusercontent.com/u/10992418?v=3","gravatar_id":"","url":"https://api.github.com/users/superpowers","html_url":"https://github.com/superpowers","followers_url":"https://api.github.com/users/superpowers/followers","following_url":"https://api.github.com/users/superpowers/following{/other_user}","gists_url":"https://api.github.com/users/superpowers/gists{/gist_id}","starred_url":"https://api.github.com/users/superpowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superpowers/subscriptions","organizations_url":"https://api.github.com/users/superpowers/orgs","repos_url":"https://api.github.com/users/superpowers/repos","events_url":"https://api.github.com/users/superpowers/events{/privacy}","received_events_url":"https://api.github.com/users/superpowers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superpowers/superpowers-game","description":":video_game: Make 2D and 3D games in live collaboration with Superpowers","fork":false,"url":"https://api.github.com/repos/superpowers/superpowers-game","forks_url":"https://api.github.com/repos/superpowers/superpowers-game/forks","keys_url":"https://api.github.com/repos/superpowers/superpowers-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superpowers/superpowers-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superpowers/superpowers-game/teams","hooks_url":"https://api.github.com/repos/superpowers/superpowers-game/hooks","issue_events_url":"https://api.github.com/repos/superpowers/superpowers-game/issues/events{/number}","events_url":"https://api.github.com/repos/superpowers/superpowers-game/events","assignees_url":"https://api.github.com/repos/superpowers/superpowers-game/assignees{/user}","branches_url":"https://api.github.com/repos/superpowers/superpowers-game/branches{/branch}","tags_url":"https://api.github.com/repos/superpowers/superpowers-game/tags","blobs_url":"https://api.github.com/repos/superpowers/superpowers-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superpowers/superpowers-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superpowers/superpowers-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/superpowers/superpowers-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superpowers/superpowers-game/statuses/{sha}","languages_url":"https://api.github.com/repos/superpowers/superpowers-game/languages","stargazers_url":"https://api.github.com/repos/superpowers/superpowers-game/stargazers","contributors_url":"https://api.github.com/repos/superpowers/superpowers-game/contributors","subscribers_url":"https://api.github.com/repos/superpowers/superpowers-game/subscribers","subscription_url":"https://api.github.com/repos/superpowers/superpowers-game/subscription","commits_url":"https://api.github.com/repos/superpowers/superpowers-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/superpowers/superpowers-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/superpowers/superpowers-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/superpowers/superpowers-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/superpowers/superpowers-game/contents/{+path}","compare_url":"https://api.github.com/repos/superpowers/superpowers-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superpowers/superpowers-game/merges","archive_url":"https://api.github.com/repos/superpowers/superpowers-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superpowers/superpowers-game/downloads","issues_url":"https://api.github.com/repos/superpowers/superpowers-game/issues{/number}","pulls_url":"https://api.github.com/repos/superpowers/superpowers-game/pulls{/number}","milestones_url":"https://api.github.com/repos/superpowers/superpowers-game/milestones{/number}","notifications_url":"https://api.github.com/repos/superpowers/superpowers-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superpowers/superpowers-game/labels{/name}","releases_url":"https://api.github.com/repos/superpowers/superpowers-game/releases{/id}","deployments_url":"https://api.github.com/repos/superpowers/superpowers-game/deployments","created_at":"2015-12-09T07:00:11Z","updated_at":"2016-08-31T21:18:01Z","pushed_at":"2016-09-03T10:02:54Z","git_url":"git://github.com/superpowers/superpowers-game.git","ssh_url":"git@github.com:superpowers/superpowers-game.git","clone_url":"https://github.com/superpowers/superpowers-game.git","svn_url":"https://github.com/superpowers/superpowers-game","homepage":"http://superpowers-html5.com/","size":7934,"stargazers_count":226,"watchers_count":226,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":61,"forks":47,"open_issues":61,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superpowers/superpowers-game/pulls/140"},"html":{"href":"https://github.com/superpowers/superpowers-game/pull/140"},"issue":{"href":"https://api.github.com/repos/superpowers/superpowers-game/issues/140"},"comments":{"href":"https://api.github.com/repos/superpowers/superpowers-game/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/superpowers/superpowers-game/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/superpowers/superpowers-game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superpowers/superpowers-game/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/superpowers/superpowers-game/statuses/735f951d5dc96288c78d4482080d89c7874ab779"}}}}
{"actor":{"display_login":"bilou84"}}