{"action":"created","issue":{"url":"https://api.github.com/repos/LogicalError/realtime-CSG-for-unity/issues/93","repository_url":"https://api.github.com/repos/LogicalError/realtime-CSG-for-unity","labels_url":"https://api.github.com/repos/LogicalError/realtime-CSG-for-unity/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/LogicalError/realtime-CSG-for-unity/issues/93/comments","events_url":"https://api.github.com/repos/LogicalError/realtime-CSG-for-unity/issues/93/events","html_url":"https://github.com/LogicalError/realtime-CSG-for-unity/issues/93","id":188615176,"number":93,"title":"Baked GI Issues","user":{"login":"Drexen","id":22818547,"avatar_url":"https://avatars.githubusercontent.com/u/22818547?v=3","gravatar_id":"","url":"https://api.github.com/users/Drexen","html_url":"https://github.com/Drexen","followers_url":"https://api.github.com/users/Drexen/followers","following_url":"https://api.github.com/users/Drexen/following{/other_user}","gists_url":"https://api.github.com/users/Drexen/gists{/gist_id}","starred_url":"https://api.github.com/users/Drexen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drexen/subscriptions","organizations_url":"https://api.github.com/users/Drexen/orgs","repos_url":"https://api.github.com/users/Drexen/repos","events_url":"https://api.github.com/users/Drexen/events{/privacy}","received_events_url":"https://api.github.com/users/Drexen/received_events","type":"User","site_admin":false},"labels":[{"id":473588039,"url":"https://api.github.com/repos/LogicalError/realtime-CSG-for-unity/labels/Investigating","name":"Investigating","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"LogicalError","id":157976,"avatar_url":"https://avatars.githubusercontent.com/u/157976?v=3","gravatar_id":"","url":"https://api.github.com/users/LogicalError","html_url":"https://github.com/LogicalError","followers_url":"https://api.github.com/users/LogicalError/followers","following_url":"https://api.github.com/users/LogicalError/following{/other_user}","gists_url":"https://api.github.com/users/LogicalError/gists{/gist_id}","starred_url":"https://api.github.com/users/LogicalError/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogicalError/subscriptions","organizations_url":"https://api.github.com/users/LogicalError/orgs","repos_url":"https://api.github.com/users/LogicalError/repos","events_url":"https://api.github.com/users/LogicalError/events{/privacy}","received_events_url":"https://api.github.com/users/LogicalError/received_events","type":"User","site_admin":false},"assignees":[{"login":"LogicalError","id":157976,"avatar_url":"https://avatars.githubusercontent.com/u/157976?v=3","gravatar_id":"","url":"https://api.github.com/users/LogicalError","html_url":"https://github.com/LogicalError","followers_url":"https://api.github.com/users/LogicalError/followers","following_url":"https://api.github.com/users/LogicalError/following{/other_user}","gists_url":"https://api.github.com/users/LogicalError/gists{/gist_id}","starred_url":"https://api.github.com/users/LogicalError/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogicalError/subscriptions","organizations_url":"https://api.github.com/users/LogicalError/orgs","repos_url":"https://api.github.com/users/LogicalError/repos","events_url":"https://api.github.com/users/LogicalError/events{/privacy}","received_events_url":"https://api.github.com/users/LogicalError/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-11-10T20:51:06Z","updated_at":"2016-11-28T13:04:28Z","closed_at":null,"body":"https://www.youtube.com/watch?v=LTunq-4elgc\r\n\r\n\r\n````\r\n(texGenFlags[texGenIndex] & TexGenFlags.Discarded) == TexGenFlags.Discarded\r\n````\r\n\r\nLightmaps completely break when you modify some geometry. Also modifying geometry is really slow. Everything in the scene is static using baked lighting for everything.\r\n\r\nAlso I undo the deletion of the floor brush and it takes a good 5 seconds on a very sparse scene."},"comment":{"url":"https://api.github.com/repos/LogicalError/realtime-CSG-for-unity/issues/comments/263266187","html_url":"https://github.com/LogicalError/realtime-CSG-for-unity/issues/93#issuecomment-263266187","issue_url":"https://api.github.com/repos/LogicalError/realtime-CSG-for-unity/issues/93","id":263266187,"user":{"login":"LogicalError","id":157976,"avatar_url":"https://avatars.githubusercontent.com/u/157976?v=3","gravatar_id":"","url":"https://api.github.com/users/LogicalError","html_url":"https://github.com/LogicalError","followers_url":"https://api.github.com/users/LogicalError/followers","following_url":"https://api.github.com/users/LogicalError/following{/other_user}","gists_url":"https://api.github.com/users/LogicalError/gists{/gist_id}","starred_url":"https://api.github.com/users/LogicalError/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogicalError/subscriptions","organizations_url":"https://api.github.com/users/LogicalError/orgs","repos_url":"https://api.github.com/users/LogicalError/repos","events_url":"https://api.github.com/users/LogicalError/events{/privacy}","received_events_url":"https://api.github.com/users/LogicalError/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T13:04:28Z","updated_at":"2016-11-28T13:04:28Z","body":"I think is partially related to #116 and I think the other part is just .. Unity :-/\r\n\r\nThe thing is Unity will rebuild the lightmap for the generated mesh once it changes .. so if you modify a brush, the mesh that's generated for that brush will be changed & Unity will rebuild the lightmaps (hopefully only a subset) and I have no control over that.\r\n\r\nThe garbage you see when modifying the brushes is the existing lightmap being used for a modified mesh that has different uv coordinates for the next lightmap being created by Unity.\r\nMaybe I can just stop that lightmap from being shown *somehow*, but other than that there's nothing I can do about that.\r\n\r\nAt first I thought the baking stopped working but in that video when you look in the bottom right corner you see that the lighting is being recalculated, and it's just .. slow\r\n(Unity 5.5+ should be a lot faster by the way)\r\n\r\nThe Undo being slow is a different issue entirely (and there's another ticket for that #29 )\r\n\r\nThe slowness of modifying geometry while baking is partially my fault (which I will fix today), and partially the lighting being recalculated in the background."}}
{"actor":{"display_login":"LogicalError"}}