{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/cf-release/issues/1090","repository_url":"https://api.github.com/repos/cloudfoundry/cf-release","labels_url":"https://api.github.com/repos/cloudfoundry/cf-release/issues/1090/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/cf-release/issues/1090/comments","events_url":"https://api.github.com/repos/cloudfoundry/cf-release/issues/1090/events","html_url":"https://github.com/cloudfoundry/cf-release/pull/1090","id":186804514,"number":1090,"title":"Allow configuration of artifacts directory for smoke tests","user":{"login":"henrytk","id":8709339,"avatar_url":"https://avatars.githubusercontent.com/u/8709339?v=3","gravatar_id":"","url":"https://api.github.com/users/henrytk","html_url":"https://github.com/henrytk","followers_url":"https://api.github.com/users/henrytk/followers","following_url":"https://api.github.com/users/henrytk/following{/other_user}","gists_url":"https://api.github.com/users/henrytk/gists{/gist_id}","starred_url":"https://api.github.com/users/henrytk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrytk/subscriptions","organizations_url":"https://api.github.com/users/henrytk/orgs","repos_url":"https://api.github.com/users/henrytk/repos","events_url":"https://api.github.com/users/henrytk/events{/privacy}","received_events_url":"https://api.github.com/users/henrytk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-02T13:45:25Z","updated_at":"2016-11-02T13:45:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudfoundry/cf-release/pulls/1090","html_url":"https://github.com/cloudfoundry/cf-release/pull/1090","diff_url":"https://github.com/cloudfoundry/cf-release/pull/1090.diff","patch_url":"https://github.com/cloudfoundry/cf-release/pull/1090.patch"},"body":"## Why\r\n\r\nThis pull request has been raised regarding https://github.com/cloudfoundry/cf-release/issues/1089\r\n\r\nIt is useful to be able to ship the CF_TRACE output to temporary storage, so it can be used to debug failed tests. This pull request has been raised to allow the configuration of the artifacts directory from the manifest, which will enable the logging more easily.\r\n\r\n## What\r\n\r\nAdd some logic to check if the `smoke_tests.artifacts_directory` property is set and add it to the smoke test configuration. This makes it possible to turn on logging of CF_TRACE output from the manifest.\r\n\r\nOnce the template is rendered you will be left with some fairly hideous whitespace (a linefeed before and after the artifacts directory key). I did not implement trimming of this because the Bosh repository shows inconsistent support for the `trim_mode` parameters in ERB[1].\r\n\r\nThe artifacts directory is hard coded for the acceptance tests job[2]. Other than a mild inconsistency there is no reason to change this behaviour.\r\n\r\n[1] http://ruby-doc.org/stdlib-2.3.1/libdoc/erb/rdoc/ERB.html#method-c-new\r\n[2] https://github.com/cloudfoundry/cf-release/blob/v245/jobs/acceptance-tests/templates/config.json.erb#L24"},"comment":{"url":"https://api.github.com/repos/cloudfoundry/cf-release/issues/comments/257868059","html_url":"https://github.com/cloudfoundry/cf-release/pull/1090#issuecomment-257868059","issue_url":"https://api.github.com/repos/cloudfoundry/cf-release/issues/1090","id":257868059,"user":{"login":"cfdreddbot","id":5149451,"avatar_url":"https://avatars.githubusercontent.com/u/5149451?v=3","gravatar_id":"","url":"https://api.github.com/users/cfdreddbot","html_url":"https://github.com/cfdreddbot","followers_url":"https://api.github.com/users/cfdreddbot/followers","following_url":"https://api.github.com/users/cfdreddbot/following{/other_user}","gists_url":"https://api.github.com/users/cfdreddbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cfdreddbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfdreddbot/subscriptions","organizations_url":"https://api.github.com/users/cfdreddbot/orgs","repos_url":"https://api.github.com/users/cfdreddbot/repos","events_url":"https://api.github.com/users/cfdreddbot/events{/privacy}","received_events_url":"https://api.github.com/users/cfdreddbot/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T13:45:27Z","updated_at":"2016-11-02T13:45:27Z","body":"Hey henrytk!\n\nThanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.\n"}}
{"actor":{"display_login":"cfdreddbot"}}