{"action":"created","issue":{"url":"https://api.github.com/repos/shakacode/react_on_rails/issues/518","repository_url":"https://api.github.com/repos/shakacode/react_on_rails","labels_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/518/labels{/name}","comments_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/518/comments","events_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/518/events","html_url":"https://github.com/shakacode/react_on_rails/pull/518","id":170711911,"number":518,"title":"Fix Encoding::UndefinedConversionError for IE browsers","user":{"login":"lucke84","id":783937,"avatar_url":"https://avatars.githubusercontent.com/u/783937?v=3","gravatar_id":"","url":"https://api.github.com/users/lucke84","html_url":"https://github.com/lucke84","followers_url":"https://api.github.com/users/lucke84/followers","following_url":"https://api.github.com/users/lucke84/following{/other_user}","gists_url":"https://api.github.com/users/lucke84/gists{/gist_id}","starred_url":"https://api.github.com/users/lucke84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucke84/subscriptions","organizations_url":"https://api.github.com/users/lucke84/orgs","repos_url":"https://api.github.com/users/lucke84/repos","events_url":"https://api.github.com/users/lucke84/events{/privacy}","received_events_url":"https://api.github.com/users/lucke84/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/shakacode/react_on_rails/milestones/14","html_url":"https://github.com/shakacode/react_on_rails/milestones/6.1","labels_url":"https://api.github.com/repos/shakacode/react_on_rails/milestones/14/labels","id":1786301,"number":14,"title":"6.1","description":null,"creator":{"login":"justin808","id":1118459,"avatar_url":"https://avatars.githubusercontent.com/u/1118459?v=3","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":2,"state":"open","created_at":"2016-05-25T00:02:04Z","updated_at":"2016-08-12T03:50:17Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-08-11T18:21:11Z","updated_at":"2016-08-12T08:21:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/518","html_url":"https://github.com/shakacode/react_on_rails/pull/518","diff_url":"https://github.com/shakacode/react_on_rails/pull/518.diff","patch_url":"https://github.com/shakacode/react_on_rails/pull/518.patch"},"body":"Check for encoding failure of the request's original_url and try to recover by force-encoding the URLs inside the payload as UTF-8, assuming they were encoded in Windows Latin-2. \r\nThis situation can only occur in browsers that do not encode the entire URL as UTF-8 already, meaning IE11 and lower. This is quite a common config as many people on Windows 7 still use IE11.\r\n\r\nHere's the relevant part of the backtrace:\r\n```\r\nEncoding::UndefinedConversionError: \"\\xC3\" from ASCII-8BIT to UTF-8\r\n  from active_support/core_ext/object/json.rb:34:in `encode'\r\n  from active_support/core_ext/object/json.rb:34:in `to_json'\r\n  from active_support/core_ext/object/json.rb:34:in `to_json_with_active_support_encoder'\r\n  from active_support/json/encoding.rb:57:in `to_json'\r\n  from json/common.rb:224:in `generate'\r\n  from json/common.rb:224:in `generate'\r\n  from active_support/json/encoding.rb:101:in `stringify'\r\n  from active_support/json/encoding.rb:35:in `encode'\r\n  from active_support/json/encoding.rb:22:in `encode'\r\n  from active_support/core_ext/object/json.rb:37:in `to_json_with_active_support_encoder'\r\n  from react_on_rails_helper.rb:285:in `server_rendered_react_component_html'\r\n  from react_on_rails_helper.rb:112:in `react_component'\r\n  from app/views/hotels/list.html.erb:1:in `_app_views_hotels_list_html_erb___3550728304780922533_32214600'\r\n  [ .. ]  \r\n```\r\n\r\nThis is a patch we have already successfully applied to our codebase in other components. Truth to be told, though, I still have to try the fix within the ReactOnRails context. I will do it tomorrow, but I'd appreciate an initial round of feedback. Thanks!\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/shakacode/react_on_rails/518)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/shakacode/react_on_rails/issues/comments/239388797","html_url":"https://github.com/shakacode/react_on_rails/pull/518#issuecomment-239388797","issue_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/518","id":239388797,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T08:21:06Z","updated_at":"2016-08-12T08:21:06Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7418475/badge)](https://coveralls.io/builds/7418475)\n\nChanges Unknown when pulling **b7a6d66f0433a0ed6d5ab8def8fb9d9b8530ba4e on FindHotel:fix_undefined_conversion_error** into ** on shakacode:master**.\n"}}
{"actor":{"display_login":"coveralls"}}