{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments/51410740","id":51410740,"diff_hunk":"@@ -529,43 +525,102 @@ public boolean verifyNewRankOptionsQuestionFormIsDisplayed() {\n         WebElement contribForm = browser.driver.findElement(By.id(\"rankOptionsForm\"));\n         return contribForm.isDisplayed() && addNewQuestionButton.isDisplayed();\n     }\n+    \n     public boolean verifyNewRankRecipientsQuestionFormIsDisplayed() {\n         WebElement contribForm = browser.driver.findElement(By.id(\"rankRecipientsForm\"));\n         return contribForm.isDisplayed() && addNewQuestionButton.isDisplayed();\n     }\n-    \n-    public boolean verifyEndDatesBeforeTodayAreDisabled() {\n-        Calendar cal = Calendar.getInstance();\n-        \n-        // if today is the 1st day of the month, the datepicker cannot navigate to the previous month (yesterday) \n-        if (cal.get(Calendar.DATE) != 1) {\n-            cal.add(Calendar.DATE, -1);       \n \n-            // get month names\n-            DateFormatSymbols dfs = new DateFormatSymbols();\n-            String[] months = dfs.getMonths();        \n+    public boolean isDatesOfPreviousCurrentAndNextMonthEnabled() throws ParseException {\n+        return isDatesOfPreviousCurrentAndNextMonthEnabled(startDateBox) \n+               && isDatesOfPreviousCurrentAndNextMonthEnabled(endDateBox);\n+    }\n+\n+    /**\n+     * @param dateBox is a {@link WebElement} that triggers a datepicker\n+     * @return true if the dates of previous, current and next month are\n+     *         enabled, otherwise false\n+     * @throws ParseException if the string in {@code dateBox} cannot be parsed\n+     */\n+    private boolean isDatesOfPreviousCurrentAndNextMonthEnabled(WebElement dateBox) throws ParseException {\n+\n+        Calendar previousMonth = Calendar.getInstance();\n+        previousMonth.add(Calendar.MONTH, -1);\n+\n+        // Navigate to the previous month\n+        if (!navigate(dateBox, previousMonth)) {\n+            return false;","path":"src/test/java/teammates/test/pageobjects/InstructorFeedbackEditPage.java","position":65,"original_position":65,"commit_id":"d013ef2be23c7566627b5e701a93dbb39d0e74ab","original_commit_id":"d013ef2be23c7566627b5e701a93dbb39d0e74ab","user":{"login":"unyoungwax","id":10228385,"avatar_url":"https://avatars.githubusercontent.com/u/10228385?v=3","gravatar_id":"","url":"https://api.github.com/users/unyoungwax","html_url":"https://github.com/unyoungwax","followers_url":"https://api.github.com/users/unyoungwax/followers","following_url":"https://api.github.com/users/unyoungwax/following{/other_user}","gists_url":"https://api.github.com/users/unyoungwax/gists{/gist_id}","starred_url":"https://api.github.com/users/unyoungwax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unyoungwax/subscriptions","organizations_url":"https://api.github.com/users/unyoungwax/orgs","repos_url":"https://api.github.com/users/unyoungwax/repos","events_url":"https://api.github.com/users/unyoungwax/events{/privacy}","received_events_url":"https://api.github.com/users/unyoungwax/received_events","type":"User","site_admin":false},"body":"After I replaced `return false;` with `fail(\"Cannot navigate to the previous month\");` in the if-statement, do I need to rename the `isDatesOfPreviousCurrentAndNextMonthEnabled()` method to `verify...` as well? ","created_at":"2016-02-01T12:10:09Z","updated_at":"2016-02-01T12:10:09Z","html_url":"https://github.com/TEAMMATES/repo/pull/4663#discussion_r51410740","pull_request_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/4663","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments/51410740"},"html":{"href":"https://github.com/TEAMMATES/repo/pull/4663#discussion_r51410740"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/4663"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/repo/pulls/4663","id":57205754,"html_url":"https://github.com/TEAMMATES/repo/pull/4663","diff_url":"https://github.com/TEAMMATES/repo/pull/4663.diff","patch_url":"https://github.com/TEAMMATES/repo/pull/4663.patch","issue_url":"https://api.github.com/repos/TEAMMATES/repo/issues/4663","number":4663,"state":"open","locked":false,"title":"Instructor session edit: allow setting end time to a time in the past #4644","user":{"login":"unyoungwax","id":10228385,"avatar_url":"https://avatars.githubusercontent.com/u/10228385?v=3","gravatar_id":"","url":"https://api.github.com/users/unyoungwax","html_url":"https://github.com/unyoungwax","followers_url":"https://api.github.com/users/unyoungwax/followers","following_url":"https://api.github.com/users/unyoungwax/following{/other_user}","gists_url":"https://api.github.com/users/unyoungwax/gists{/gist_id}","starred_url":"https://api.github.com/users/unyoungwax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unyoungwax/subscriptions","organizations_url":"https://api.github.com/users/unyoungwax/orgs","repos_url":"https://api.github.com/users/unyoungwax/repos","events_url":"https://api.github.com/users/unyoungwax/events{/privacy}","received_events_url":"https://api.github.com/users/unyoungwax/received_events","type":"User","site_admin":false},"body":"Fixes #4644","created_at":"2016-01-26T12:41:00Z","updated_at":"2016-02-01T12:10:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cf041e30eb8efa320c82a9e61200c820edf2dab","assignee":{"login":"kanghj","id":2216119,"avatar_url":"https://avatars.githubusercontent.com/u/2216119?v=3","gravatar_id":"","url":"https://api.github.com/users/kanghj","html_url":"https://github.com/kanghj","followers_url":"https://api.github.com/users/kanghj/followers","following_url":"https://api.github.com/users/kanghj/following{/other_user}","gists_url":"https://api.github.com/users/kanghj/gists{/gist_id}","starred_url":"https://api.github.com/users/kanghj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanghj/subscriptions","organizations_url":"https://api.github.com/users/kanghj/orgs","repos_url":"https://api.github.com/users/kanghj/repos","events_url":"https://api.github.com/users/kanghj/events{/privacy}","received_events_url":"https://api.github.com/users/kanghj/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/4663/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/4663/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/repo/issues/4663/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/repo/statuses/d013ef2be23c7566627b5e701a93dbb39d0e74ab","head":{"label":"nus-fboa2016-TM:4644-allow-picking-past-dates","ref":"4644-allow-picking-past-dates","sha":"d013ef2be23c7566627b5e701a93dbb39d0e74ab","user":{"login":"nus-fboa2016-TM","id":16642227,"avatar_url":"https://avatars.githubusercontent.com/u/16642227?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-fboa2016-TM","html_url":"https://github.com/nus-fboa2016-TM","followers_url":"https://api.github.com/users/nus-fboa2016-TM/followers","following_url":"https://api.github.com/users/nus-fboa2016-TM/following{/other_user}","gists_url":"https://api.github.com/users/nus-fboa2016-TM/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-fboa2016-TM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-fboa2016-TM/subscriptions","organizations_url":"https://api.github.com/users/nus-fboa2016-TM/orgs","repos_url":"https://api.github.com/users/nus-fboa2016-TM/repos","events_url":"https://api.github.com/users/nus-fboa2016-TM/events{/privacy}","received_events_url":"https://api.github.com/users/nus-fboa2016-TM/received_events","type":"Organization","site_admin":false},"repo":{"id":49403164,"name":"repo","full_name":"nus-fboa2016-TM/repo","owner":{"login":"nus-fboa2016-TM","id":16642227,"avatar_url":"https://avatars.githubusercontent.com/u/16642227?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-fboa2016-TM","html_url":"https://github.com/nus-fboa2016-TM","followers_url":"https://api.github.com/users/nus-fboa2016-TM/followers","following_url":"https://api.github.com/users/nus-fboa2016-TM/following{/other_user}","gists_url":"https://api.github.com/users/nus-fboa2016-TM/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-fboa2016-TM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-fboa2016-TM/subscriptions","organizations_url":"https://api.github.com/users/nus-fboa2016-TM/orgs","repos_url":"https://api.github.com/users/nus-fboa2016-TM/repos","events_url":"https://api.github.com/users/nus-fboa2016-TM/events{/privacy}","received_events_url":"https://api.github.com/users/nus-fboa2016-TM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-fboa2016-TM/repo","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/nus-fboa2016-TM/repo","forks_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/forks","keys_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/teams","hooks_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/hooks","issue_events_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/issues/events{/number}","events_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/events","assignees_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/assignees{/user}","branches_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/branches{/branch}","tags_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/tags","blobs_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/languages","stargazers_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/stargazers","contributors_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/contributors","subscribers_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/subscribers","subscription_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/subscription","commits_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/contents/{+path}","compare_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/merges","archive_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/downloads","issues_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/issues{/number}","pulls_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/labels{/name}","releases_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/releases{/id}","deployments_url":"https://api.github.com/repos/nus-fboa2016-TM/repo/deployments","created_at":"2016-01-11T05:00:54Z","updated_at":"2016-01-11T05:01:00Z","pushed_at":"2016-02-01T11:39:01Z","git_url":"git://github.com/nus-fboa2016-TM/repo.git","ssh_url":"git@github.com:nus-fboa2016-TM/repo.git","clone_url":"https://github.com/nus-fboa2016-TM/repo.git","svn_url":"https://github.com/nus-fboa2016-TM/repo","homepage":"http://teammatesv4.appspot.com/","size":136304,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"7d141030619b6b50496fe11ec2c0ec70fca982fa","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"repo","full_name":"TEAMMATES/repo","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/repo","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/repo","forks_url":"https://api.github.com/repos/TEAMMATES/repo/forks","keys_url":"https://api.github.com/repos/TEAMMATES/repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/repo/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/repo/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/repo/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/repo/events","assignees_url":"https://api.github.com/repos/TEAMMATES/repo/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/repo/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/repo/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/repo/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/repo/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/repo/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/repo/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/repo/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/repo/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/repo/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/repo/merges","archive_url":"https://api.github.com/repos/TEAMMATES/repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/repo/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/repo/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/repo/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/repo/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/repo/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/repo/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/repo/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2016-01-25T04:17:14Z","pushed_at":"2016-02-01T11:39:02Z","git_url":"git://github.com/TEAMMATES/repo.git","ssh_url":"git@github.com:TEAMMATES/repo.git","clone_url":"https://github.com/TEAMMATES/repo.git","svn_url":"https://github.com/TEAMMATES/repo","homepage":"http://teammatesv4.appspot.com/","size":138962,"stargazers_count":62,"watchers_count":62,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":547,"forks":149,"open_issues":547,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/4663"},"html":{"href":"https://github.com/TEAMMATES/repo/pull/4663"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/repo/issues/4663"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/repo/issues/4663/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/4663/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/4663/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/repo/statuses/d013ef2be23c7566627b5e701a93dbb39d0e74ab"}}}}