{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/82538992","pull_request_review_id":3439756,"id":82538992,"diff_hunk":"@@ -140,39 +146,45 @@ func New(config *api.Config, overrides build.Overrides) (*STI, error) {\n \tif builder.source == nil && !config.Usage {\n \t\tdownloader, sourceURL, err := scm.DownloaderForSource(config.Source, config.ForceCopy)\n \t\tif err != nil {\n-\t\t\treturn nil, err\n+\t\t\tbuildInfo = updater.UpdateFailureReason(buildInfo, api.ReasonGenericS2IBuildFailed)\n+\t\t\treturn nil, buildInfo, err\n \t\t}\n \t\tbuilder.source = downloader\n \t\tconfig.Source = sourceURL\n \t}\n-\n \tbuilder.garbage = build.NewDefaultCleaner(builder.fs, builder.docker)\n-\tbuilder.layered, err = layered.New(config, builder, overrides)\n+\tbuilder.layered, buildInfo, err = layered.New(config, builder, overrides)\n+\n+\t// NOTE: shouldn't the above error be properly handled? if the layered build\n+\t// failed, then it means the build failed. the buildInfo is already updated\n+\t// with failure reasons so there's nothing more to be done here but to return\n+\t// it up the stack","path":"pkg/build/strategies/sti/sti.go","position":61,"original_position":61,"commit_id":"1da9a8e7eaeb80fa8e6adfbf14aab4aa7f37fe1a","original_commit_id":"1da9a8e7eaeb80fa8e6adfbf14aab4aa7f37fe1a","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"yes it should.  please handle it.","created_at":"2016-10-10T02:28:06Z","updated_at":"2016-10-10T02:44:05Z","html_url":"https://github.com/openshift/source-to-image/pull/593#discussion_r82538992","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/593","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/82538992"},"html":{"href":"https://github.com/openshift/source-to-image/pull/593#discussion_r82538992"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/593"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/593","id":86762739,"html_url":"https://github.com/openshift/source-to-image/pull/593","diff_url":"https://github.com/openshift/source-to-image/pull/593.diff","patch_url":"https://github.com/openshift/source-to-image/pull/593.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/593","number":593,"state":"open","locked":false,"title":"[WIP] Additional build information ","user":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"body":"This PR adds additional build information so that S2I can tell OpenShift a couple of things:\r\nWhy did the build fail. (besides fetch source, [which is implemented on the OpenShift side], container commit, builder image pull, runtime image pull, assemble runtime failed, assemble failed, etc. )\r\n\r\nIt's related to: https://github.com/openshift/origin/pull/10817","created_at":"2016-09-26T15:17:54Z","updated_at":"2016-10-10T02:44:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7625c4357284783dd9417c324b32e4012be5bee4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/593/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/593/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/593/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/1da9a8e7eaeb80fa8e6adfbf14aab4aa7f37fe1a","head":{"label":"PI-Victor:additional_status","ref":"additional_status","sha":"1da9a8e7eaeb80fa8e6adfbf14aab4aa7f37fe1a","user":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"repo":{"id":63790091,"name":"source-to-image","full_name":"PI-Victor/source-to-image","owner":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PI-Victor/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/PI-Victor/source-to-image","forks_url":"https://api.github.com/repos/PI-Victor/source-to-image/forks","keys_url":"https://api.github.com/repos/PI-Victor/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PI-Victor/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PI-Victor/source-to-image/teams","hooks_url":"https://api.github.com/repos/PI-Victor/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/PI-Victor/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/PI-Victor/source-to-image/events","assignees_url":"https://api.github.com/repos/PI-Victor/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/PI-Victor/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/PI-Victor/source-to-image/tags","blobs_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PI-Victor/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/PI-Victor/source-to-image/languages","stargazers_url":"https://api.github.com/repos/PI-Victor/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/PI-Victor/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/PI-Victor/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/PI-Victor/source-to-image/subscription","commits_url":"https://api.github.com/repos/PI-Victor/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/PI-Victor/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/PI-Victor/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/PI-Victor/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/PI-Victor/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PI-Victor/source-to-image/merges","archive_url":"https://api.github.com/repos/PI-Victor/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PI-Victor/source-to-image/downloads","issues_url":"https://api.github.com/repos/PI-Victor/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/PI-Victor/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/PI-Victor/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/PI-Victor/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PI-Victor/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/PI-Victor/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/PI-Victor/source-to-image/deployments","created_at":"2016-07-20T14:54:06Z","updated_at":"2016-07-20T14:54:07Z","pushed_at":"2016-10-07T11:40:13Z","git_url":"git://github.com/PI-Victor/source-to-image.git","ssh_url":"git@github.com:PI-Victor/source-to-image.git","clone_url":"https://github.com/PI-Victor/source-to-image.git","svn_url":"https://github.com/PI-Victor/source-to-image","homepage":"","size":15371,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"b3909eab89664d39e62cecfda4c255e87e1c061f","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/source-to-image/deployments","created_at":"2014-01-28T19:32:40Z","updated_at":"2016-10-07T13:59:03Z","pushed_at":"2016-10-07T14:36:53Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":15539,"stargazers_count":305,"watchers_count":305,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":21,"forks":149,"open_issues":21,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/593"},"html":{"href":"https://github.com/openshift/source-to-image/pull/593"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/593"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/593/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/593/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/593/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/1da9a8e7eaeb80fa8e6adfbf14aab4aa7f37fe1a"}}}}
{"actor":{"display_login":"bparees"}}