{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab/pulls/comments/79704824","id":79704824,"diff_hunk":"@@ -198,16 +198,15 @@ private void setCoil(Command command, ModbusBindingConfig config)\n      * @throws ModbusException ModbusIOException on IO errors, ModbusSlaveException with protocol level exceptions\r\n      * @throws ModbusUnexpectedTransactionIdException when response transaction id does not match the request\r\n      */\r\n-    protected void setRegister(Command command, ModbusBindingConfig config)\r\n+    protected void setRegister(Command command, int readIndex, int writeRegister)\r\n             throws ModbusConnectionException, ModbusException, ModbusUnexpectedTransactionIdException {\r\n-        int readIndex = config.readIndex;\r\n-        int writeRegister = getStart() + config.writeIndex;\r\n+        writeRegister += getStart();\r\n \r\n         Register newValue;\r\n         if (command instanceof IncreaseDecreaseType) {\r\n             newValue = readCachedRegisterValue(readIndex);\r\n             if (newValue == null) {\r\n-                logger.warn(\"Not polled value for item {}. Cannot process command {}\", config.getItemName(), command);\r\n+                logger.warn(\"Not polled value. Cannot process command {}\", command);\r","path":"bundles/binding/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/ModbusSlave.java","position":null,"original_position":51,"commit_id":"26a63ef7e8e81d8134db3655fb9c43594e198e69","original_commit_id":"4314c0deb8398a2485447fd6761817c20aee7ecd","user":{"login":"yellowmm","id":16188328,"avatar_url":"https://avatars.githubusercontent.com/u/16188328?v=3","gravatar_id":"","url":"https://api.github.com/users/yellowmm","html_url":"https://github.com/yellowmm","followers_url":"https://api.github.com/users/yellowmm/followers","following_url":"https://api.github.com/users/yellowmm/following{/other_user}","gists_url":"https://api.github.com/users/yellowmm/gists{/gist_id}","starred_url":"https://api.github.com/users/yellowmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yellowmm/subscriptions","organizations_url":"https://api.github.com/users/yellowmm/orgs","repos_url":"https://api.github.com/users/yellowmm/repos","events_url":"https://api.github.com/users/yellowmm/events{/privacy}","received_events_url":"https://api.github.com/users/yellowmm/received_events","type":"User","site_admin":false},"body":"My 1st approach was w/o the config param in this call to keep the API small. \r\nSince it is back I can revert this.","created_at":"2016-09-20T20:31:02Z","updated_at":"2016-09-20T20:31:02Z","html_url":"https://github.com/openhab/openhab/pull/4654#discussion_r79704824","pull_request_url":"https://api.github.com/repos/openhab/openhab/pulls/4654","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments/79704824"},"html":{"href":"https://github.com/openhab/openhab/pull/4654#discussion_r79704824"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4654"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab/pulls/4654","id":85814095,"html_url":"https://github.com/openhab/openhab/pull/4654","diff_url":"https://github.com/openhab/openhab/pull/4654.diff","patch_url":"https://github.com/openhab/openhab/pull/4654.patch","issue_url":"https://api.github.com/repos/openhab/openhab/issues/4654","number":4654,"state":"open","locked":false,"title":"[modbus] enhance modbus binding for rollershutter items","user":{"login":"yellowmm","id":16188328,"avatar_url":"https://avatars.githubusercontent.com/u/16188328?v=3","gravatar_id":"","url":"https://api.github.com/users/yellowmm","html_url":"https://github.com/yellowmm","followers_url":"https://api.github.com/users/yellowmm/followers","following_url":"https://api.github.com/users/yellowmm/following{/other_user}","gists_url":"https://api.github.com/users/yellowmm/gists{/gist_id}","starred_url":"https://api.github.com/users/yellowmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yellowmm/subscriptions","organizations_url":"https://api.github.com/users/yellowmm/orgs","repos_url":"https://api.github.com/users/yellowmm/repos","events_url":"https://api.github.com/users/yellowmm/events{/privacy}","received_events_url":"https://api.github.com/users/yellowmm/received_events","type":"User","site_admin":false},"body":"\r\n\r\n\r\n\r\n\r\n\r\nimplement usage of RollerShutter item for modbus binding\r\n\r\naddress enhancement #4653 ","created_at":"2016-09-19T15:21:39Z","updated_at":"2016-09-20T20:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b9167c72fe302141230e614ab56c1dcca0b5a4c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openhab/openhab/milestones/12","html_url":"https://github.com/openhab/openhab/milestones/1.9.0","labels_url":"https://api.github.com/repos/openhab/openhab/milestones/12/labels","id":1479830,"number":12,"title":"1.9.0","description":"","creator":{"login":"teichsta","id":2108636,"avatar_url":"https://avatars.githubusercontent.com/u/2108636?v=3","gravatar_id":"","url":"https://api.github.com/users/teichsta","html_url":"https://github.com/teichsta","followers_url":"https://api.github.com/users/teichsta/followers","following_url":"https://api.github.com/users/teichsta/following{/other_user}","gists_url":"https://api.github.com/users/teichsta/gists{/gist_id}","starred_url":"https://api.github.com/users/teichsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teichsta/subscriptions","organizations_url":"https://api.github.com/users/teichsta/orgs","repos_url":"https://api.github.com/users/teichsta/repos","events_url":"https://api.github.com/users/teichsta/events{/privacy}","received_events_url":"https://api.github.com/users/teichsta/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":255,"state":"open","created_at":"2016-01-01T16:37:00Z","updated_at":"2016-09-19T15:53:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openhab/openhab/pulls/4654/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab/pulls/4654/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab/issues/4654/comments","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/26a63ef7e8e81d8134db3655fb9c43594e198e69","head":{"label":"yellowmm:4653-modbus-rollershutter-enhancement","ref":"4653-modbus-rollershutter-enhancement","sha":"26a63ef7e8e81d8134db3655fb9c43594e198e69","user":{"login":"yellowmm","id":16188328,"avatar_url":"https://avatars.githubusercontent.com/u/16188328?v=3","gravatar_id":"","url":"https://api.github.com/users/yellowmm","html_url":"https://github.com/yellowmm","followers_url":"https://api.github.com/users/yellowmm/followers","following_url":"https://api.github.com/users/yellowmm/following{/other_user}","gists_url":"https://api.github.com/users/yellowmm/gists{/gist_id}","starred_url":"https://api.github.com/users/yellowmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yellowmm/subscriptions","organizations_url":"https://api.github.com/users/yellowmm/orgs","repos_url":"https://api.github.com/users/yellowmm/repos","events_url":"https://api.github.com/users/yellowmm/events{/privacy}","received_events_url":"https://api.github.com/users/yellowmm/received_events","type":"User","site_admin":false},"repo":{"id":68610662,"name":"openhab","full_name":"yellowmm/openhab","owner":{"login":"yellowmm","id":16188328,"avatar_url":"https://avatars.githubusercontent.com/u/16188328?v=3","gravatar_id":"","url":"https://api.github.com/users/yellowmm","html_url":"https://github.com/yellowmm","followers_url":"https://api.github.com/users/yellowmm/followers","following_url":"https://api.github.com/users/yellowmm/following{/other_user}","gists_url":"https://api.github.com/users/yellowmm/gists{/gist_id}","starred_url":"https://api.github.com/users/yellowmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yellowmm/subscriptions","organizations_url":"https://api.github.com/users/yellowmm/orgs","repos_url":"https://api.github.com/users/yellowmm/repos","events_url":"https://api.github.com/users/yellowmm/events{/privacy}","received_events_url":"https://api.github.com/users/yellowmm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yellowmm/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/yellowmm/openhab","forks_url":"https://api.github.com/repos/yellowmm/openhab/forks","keys_url":"https://api.github.com/repos/yellowmm/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yellowmm/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yellowmm/openhab/teams","hooks_url":"https://api.github.com/repos/yellowmm/openhab/hooks","issue_events_url":"https://api.github.com/repos/yellowmm/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/yellowmm/openhab/events","assignees_url":"https://api.github.com/repos/yellowmm/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/yellowmm/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/yellowmm/openhab/tags","blobs_url":"https://api.github.com/repos/yellowmm/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yellowmm/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yellowmm/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/yellowmm/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yellowmm/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/yellowmm/openhab/languages","stargazers_url":"https://api.github.com/repos/yellowmm/openhab/stargazers","contributors_url":"https://api.github.com/repos/yellowmm/openhab/contributors","subscribers_url":"https://api.github.com/repos/yellowmm/openhab/subscribers","subscription_url":"https://api.github.com/repos/yellowmm/openhab/subscription","commits_url":"https://api.github.com/repos/yellowmm/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/yellowmm/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/yellowmm/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/yellowmm/openhab/issues/comments{/number}","contents_url":"https://api.github.com/repos/yellowmm/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/yellowmm/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yellowmm/openhab/merges","archive_url":"https://api.github.com/repos/yellowmm/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yellowmm/openhab/downloads","issues_url":"https://api.github.com/repos/yellowmm/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/yellowmm/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/yellowmm/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/yellowmm/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yellowmm/openhab/labels{/name}","releases_url":"https://api.github.com/repos/yellowmm/openhab/releases{/id}","deployments_url":"https://api.github.com/repos/yellowmm/openhab/deployments","created_at":"2016-09-19T13:51:39Z","updated_at":"2016-09-19T13:51:55Z","pushed_at":"2016-09-19T21:14:53Z","git_url":"git://github.com/yellowmm/openhab.git","ssh_url":"git@github.com:yellowmm/openhab.git","clone_url":"https://github.com/yellowmm/openhab.git","svn_url":"https://github.com/yellowmm/openhab","homepage":null,"size":203154,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"305e54f90625173720b621b65644ba94e25d5558","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":12983151,"name":"openhab","full_name":"openhab/openhab","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":false,"url":"https://api.github.com/repos/openhab/openhab","forks_url":"https://api.github.com/repos/openhab/openhab/forks","keys_url":"https://api.github.com/repos/openhab/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab/teams","hooks_url":"https://api.github.com/repos/openhab/openhab/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab/events","assignees_url":"https://api.github.com/repos/openhab/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab/tags","blobs_url":"https://api.github.com/repos/openhab/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab/subscription","commits_url":"https://api.github.com/repos/openhab/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab/merges","archive_url":"https://api.github.com/repos/openhab/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab/downloads","issues_url":"https://api.github.com/repos/openhab/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab/deployments","created_at":"2013-09-20T20:28:43Z","updated_at":"2016-09-20T18:59:21Z","pushed_at":"2016-09-20T17:50:33Z","git_url":"git://github.com/openhab/openhab.git","ssh_url":"git@github.com:openhab/openhab.git","clone_url":"https://github.com/openhab/openhab.git","svn_url":"https://github.com/openhab/openhab","homepage":null,"size":301461,"stargazers_count":3019,"watchers_count":3019,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1451,"mirror_url":null,"open_issues_count":348,"forks":1451,"open_issues":348,"watchers":3019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4654"},"html":{"href":"https://github.com/openhab/openhab/pull/4654"},"issue":{"href":"https://api.github.com/repos/openhab/openhab/issues/4654"},"comments":{"href":"https://api.github.com/repos/openhab/openhab/issues/4654/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4654/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4654/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab/statuses/26a63ef7e8e81d8134db3655fb9c43594e198e69"}}}}
{"actor":{"display_login":"yellowmm"}}