{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/comments/74727163","id":74727163,"diff_hunk":"@@ -157,5 +157,5 @@ end\n function mstatement(ex::Expr)\n     ss = IOBuffer()\n     write_mstatement(ss, ex)\n-    bytestring(ss)\n+    ASCIIString(ss)","path":"src/mstatements.jl","position":14,"original_position":14,"commit_id":"e2e69545bb74130691f1e22fe229ce65e81cb17c","original_commit_id":"e2e69545bb74130691f1e22fe229ce65e81cb17c","user":{"login":"yuyichao","id":712232,"avatar_url":"https://avatars.githubusercontent.com/u/712232?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyichao","html_url":"https://github.com/yuyichao","followers_url":"https://api.github.com/users/yuyichao/followers","following_url":"https://api.github.com/users/yuyichao/following{/other_user}","gists_url":"https://api.github.com/users/yuyichao/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyichao/subscriptions","organizations_url":"https://api.github.com/users/yuyichao/orgs","repos_url":"https://api.github.com/users/yuyichao/repos","events_url":"https://api.github.com/users/yuyichao/events{/privacy}","received_events_url":"https://api.github.com/users/yuyichao/received_events","type":"User","site_admin":false},"body":"`takebuf_string`","created_at":"2016-08-15T07:21:26Z","updated_at":"2016-08-15T07:21:26Z","html_url":"https://github.com/JuliaLang/MATLAB.jl/pull/44#discussion_r74727163","pull_request_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/comments/74727163"},"html":{"href":"https://github.com/JuliaLang/MATLAB.jl/pull/44#discussion_r74727163"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/44","id":81277023,"html_url":"https://github.com/JuliaLang/MATLAB.jl/pull/44","diff_url":"https://github.com/JuliaLang/MATLAB.jl/pull/44.diff","patch_url":"https://github.com/JuliaLang/MATLAB.jl/pull/44.patch","issue_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/issues/44","number":44,"state":"open","locked":false,"title":"Fix deprecation warnings on v0.5","user":{"login":"musm","id":4319522,"avatar_url":"https://avatars.githubusercontent.com/u/4319522?v=3","gravatar_id":"","url":"https://api.github.com/users/musm","html_url":"https://github.com/musm","followers_url":"https://api.github.com/users/musm/followers","following_url":"https://api.github.com/users/musm/following{/other_user}","gists_url":"https://api.github.com/users/musm/gists{/gist_id}","starred_url":"https://api.github.com/users/musm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musm/subscriptions","organizations_url":"https://api.github.com/users/musm/orgs","repos_url":"https://api.github.com/users/musm/repos","events_url":"https://api.github.com/users/musm/events{/privacy}","received_events_url":"https://api.github.com/users/musm/received_events","type":"User","site_admin":false},"body":"This fixes deprecation warnings on v0.5. Passes all tests locally on v0.5. Nonetheless, would be good for someone else to check or test.\r\n\r\nEdit fails on v0.4 with error\r\n```julia\r\nERROR: MethodError: `convert` has no method matching convert(::Type{ASCIIString}, ::Base.AbstractIOBuffer{Array{UInt8,1}})\r\nThis may have arisen from a call to the constructor ASCIIString(...),\r\nsince type constructors fall back to convert methods.\r\nClosest candidates are:\r\n  call{T}(::Type{T}, ::Any)\r\n  convert(::Type{ASCIIString}, ::ASCIIString)\r\n  convert(::Type{ASCIIString}, ::UTF8String)\r\n```","created_at":"2016-08-15T07:03:37Z","updated_at":"2016-08-15T07:21:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d70107da72ea020a518d52577a33594beb439a79","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/44/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/44/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/issues/44/comments","statuses_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/statuses/e2e69545bb74130691f1e22fe229ce65e81cb17c","head":{"label":"musm:fixdep","ref":"fixdep","sha":"e2e69545bb74130691f1e22fe229ce65e81cb17c","user":{"login":"musm","id":4319522,"avatar_url":"https://avatars.githubusercontent.com/u/4319522?v=3","gravatar_id":"","url":"https://api.github.com/users/musm","html_url":"https://github.com/musm","followers_url":"https://api.github.com/users/musm/followers","following_url":"https://api.github.com/users/musm/following{/other_user}","gists_url":"https://api.github.com/users/musm/gists{/gist_id}","starred_url":"https://api.github.com/users/musm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musm/subscriptions","organizations_url":"https://api.github.com/users/musm/orgs","repos_url":"https://api.github.com/users/musm/repos","events_url":"https://api.github.com/users/musm/events{/privacy}","received_events_url":"https://api.github.com/users/musm/received_events","type":"User","site_admin":false},"repo":{"id":64705658,"name":"MATLAB.jl","full_name":"musm/MATLAB.jl","owner":{"login":"musm","id":4319522,"avatar_url":"https://avatars.githubusercontent.com/u/4319522?v=3","gravatar_id":"","url":"https://api.github.com/users/musm","html_url":"https://github.com/musm","followers_url":"https://api.github.com/users/musm/followers","following_url":"https://api.github.com/users/musm/following{/other_user}","gists_url":"https://api.github.com/users/musm/gists{/gist_id}","starred_url":"https://api.github.com/users/musm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musm/subscriptions","organizations_url":"https://api.github.com/users/musm/orgs","repos_url":"https://api.github.com/users/musm/repos","events_url":"https://api.github.com/users/musm/events{/privacy}","received_events_url":"https://api.github.com/users/musm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/musm/MATLAB.jl","description":"Calling MATLAB in Julia through MATLAB Engine","fork":true,"url":"https://api.github.com/repos/musm/MATLAB.jl","forks_url":"https://api.github.com/repos/musm/MATLAB.jl/forks","keys_url":"https://api.github.com/repos/musm/MATLAB.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musm/MATLAB.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musm/MATLAB.jl/teams","hooks_url":"https://api.github.com/repos/musm/MATLAB.jl/hooks","issue_events_url":"https://api.github.com/repos/musm/MATLAB.jl/issues/events{/number}","events_url":"https://api.github.com/repos/musm/MATLAB.jl/events","assignees_url":"https://api.github.com/repos/musm/MATLAB.jl/assignees{/user}","branches_url":"https://api.github.com/repos/musm/MATLAB.jl/branches{/branch}","tags_url":"https://api.github.com/repos/musm/MATLAB.jl/tags","blobs_url":"https://api.github.com/repos/musm/MATLAB.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musm/MATLAB.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musm/MATLAB.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/musm/MATLAB.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musm/MATLAB.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/musm/MATLAB.jl/languages","stargazers_url":"https://api.github.com/repos/musm/MATLAB.jl/stargazers","contributors_url":"https://api.github.com/repos/musm/MATLAB.jl/contributors","subscribers_url":"https://api.github.com/repos/musm/MATLAB.jl/subscribers","subscription_url":"https://api.github.com/repos/musm/MATLAB.jl/subscription","commits_url":"https://api.github.com/repos/musm/MATLAB.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/musm/MATLAB.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/musm/MATLAB.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/musm/MATLAB.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/musm/MATLAB.jl/contents/{+path}","compare_url":"https://api.github.com/repos/musm/MATLAB.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musm/MATLAB.jl/merges","archive_url":"https://api.github.com/repos/musm/MATLAB.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musm/MATLAB.jl/downloads","issues_url":"https://api.github.com/repos/musm/MATLAB.jl/issues{/number}","pulls_url":"https://api.github.com/repos/musm/MATLAB.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/musm/MATLAB.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/musm/MATLAB.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musm/MATLAB.jl/labels{/name}","releases_url":"https://api.github.com/repos/musm/MATLAB.jl/releases{/id}","deployments_url":"https://api.github.com/repos/musm/MATLAB.jl/deployments","created_at":"2016-08-01T22:23:03Z","updated_at":"2016-08-01T22:23:03Z","pushed_at":"2016-08-15T06:57:56Z","git_url":"git://github.com/musm/MATLAB.jl.git","ssh_url":"git@github.com:musm/MATLAB.jl.git","clone_url":"https://github.com/musm/MATLAB.jl.git","svn_url":"https://github.com/musm/MATLAB.jl","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"cc44a6e48f27a5585a113b3510207095a261f9da","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":8545501,"name":"MATLAB.jl","full_name":"JuliaLang/MATLAB.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/MATLAB.jl","description":"Calling MATLAB in Julia through MATLAB Engine","fork":false,"url":"https://api.github.com/repos/JuliaLang/MATLAB.jl","forks_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/MATLAB.jl/deployments","created_at":"2013-03-04T01:02:25Z","updated_at":"2016-08-08T20:13:36Z","pushed_at":"2016-08-15T07:03:37Z","git_url":"git://github.com/JuliaLang/MATLAB.jl.git","ssh_url":"git@github.com:JuliaLang/MATLAB.jl.git","clone_url":"https://github.com/JuliaLang/MATLAB.jl.git","svn_url":"https://github.com/JuliaLang/MATLAB.jl","homepage":null,"size":133,"stargazers_count":57,"watchers_count":57,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":8,"forks":20,"open_issues":8,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/44"},"html":{"href":"https://github.com/JuliaLang/MATLAB.jl/pull/44"},"issue":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/issues/44"},"comments":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/MATLAB.jl/statuses/e2e69545bb74130691f1e22fe229ce65e81cb17c"}}}}
{"actor":{"display_login":"yuyichao"}}