{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/logstash/issues/5781","repository_url":"https://api.github.com/repos/elastic/logstash","labels_url":"https://api.github.com/repos/elastic/logstash/issues/5781/labels{/name}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5781/comments","events_url":"https://api.github.com/repos/elastic/logstash/issues/5781/events","html_url":"https://github.com/elastic/logstash/issues/5781","id":172019264,"number":5781,"title":"Log4j1.x and SLF4j compatibility jars in classpath need to be included","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/logstash/labels/logging%20improvements","name":"logging improvements","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"assignees":[{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-18T22:52:13Z","updated_at":"2016-08-28T16:51:56Z","closed_at":null,"body":"work in https://github.com/elastic/logstash/issues/5650 leads to a mismatch between the popular slf4j and log4j1.x logging libraries. It should be the responsibility of the plugin to include adapters if it knows it needs them. Logstash could potentially include them at runtime for all, but this feels wasteful since they will only be used against a select set of plugins.\r\n \r\nre discussion: https://github.com/elastic/logstash/pull/5651#discussion_r75302743"},"comment":{"url":"https://api.github.com/repos/elastic/logstash/issues/comments/242985278","html_url":"https://github.com/elastic/logstash/issues/5781#issuecomment-242985278","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5781","id":242985278,"user":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"created_at":"2016-08-28T16:51:56Z","updated_at":"2016-08-28T16:51:56Z","body":"My feeling is that we should onlyship log4j2 because we need it. It feels\nlike we can't solve the problem for other libraries. For example, what if a\nplugin or dependency needs a conflicting version of a logging library? Or\nwhat if they shade an incompatible logging jar within the dependency?\n\nI don't have enough recent experience with Java build/releng practices to\nknow what dangers lie in wait for us, but I do have too much uncertainty\naround this proposal to agree with it yet -- can you help me understand?\n\nOn Sunday, August 28, 2016, Fabien Baligand <notifications@github.com>\nwrote:\n\n> Here's my opinion about it :\n>\n>    - in logstash, logging system and its configuration is common and\n>    shared with everybody : core code and plugins (contrary to an applications\n>    server for example)\n>    - manage this shared logging system and its integration is logstash's\n>    responsibility, and not each plugin's responsibility.\n>    - if it's not done, some plugin logs will be lost, some others will\n>    arrive anywhere.\n>    - in particular for slf4j, it's important that slf4j \"api\" and \"impl\"\n>    versions are aligned. And logstash-core is the best place to ensure that.\n>\n> => That's why I think it is relevant to add these JARs to logtash-core :\n>\n>    - slf4j-api\n>    - log4j-slf4j-impl\n>    - log4j-1.2-api\n>    - and optionally (if some plugins/libraries use Java Util Logging\n>    framework) : log4j-jul\n>\n> @ph <https://github.com/ph> @suyograo <https://github.com/suyograo>\n> @jordansissel <https://github.com/jordansissel>\n> Any opinion on that subject ?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/elastic/logstash/issues/5781#issuecomment-242982266>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAIC6jeyYyyd9kzzhjcb960qBcIlP38mks5qka_8gaJpZM4Jn_mQ>\n> .\n>\n"}}
{"actor":{"display_login":"jordansissel"}}