{"action":"created","comment":{"url":"https://api.github.com/repos/BoD/android-prefs/pulls/comments/78542645","id":78542645,"diff_hunk":"@@ -59,7 +60,21 @@ public class ${prefWrapperClassName} extends SharedPreferencesWrapper {\n     <#if !disableNullable && pref.defaultValue == \"null\">\n     @Nullable\n     </#if><#t>\n+    @Deprecated","path":"prefs-compiler/src/main/resources/org/jraf/android/prefs/compiler/prefwrapper.ftl","position":12,"original_position":12,"commit_id":"949dd1f0ae4fffd05cf261c26ce2f548e3e5483d","original_commit_id":"949dd1f0ae4fffd05cf261c26ce2f548e3e5483d","user":{"login":"BoD","id":372852,"avatar_url":"https://avatars.githubusercontent.com/u/372852?v=3","gravatar_id":"","url":"https://api.github.com/users/BoD","html_url":"https://github.com/BoD","followers_url":"https://api.github.com/users/BoD/followers","following_url":"https://api.github.com/users/BoD/following{/other_user}","gists_url":"https://api.github.com/users/BoD/gists{/gist_id}","starred_url":"https://api.github.com/users/BoD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoD/subscriptions","organizations_url":"https://api.github.com/users/BoD/orgs","repos_url":"https://api.github.com/users/BoD/repos","events_url":"https://api.github.com/users/BoD/events{/privacy}","received_events_url":"https://api.github.com/users/BoD/received_events","type":"User","site_admin":false},"body":"That's not very nice! Generating deprecated code. Please remove it, the rest looks good, 'll accept the PR.","created_at":"2016-09-13T11:47:37Z","updated_at":"2016-09-13T11:47:37Z","html_url":"https://github.com/BoD/android-prefs/pull/9#discussion_r78542645","pull_request_url":"https://api.github.com/repos/BoD/android-prefs/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/BoD/android-prefs/pulls/comments/78542645"},"html":{"href":"https://github.com/BoD/android-prefs/pull/9#discussion_r78542645"},"pull_request":{"href":"https://api.github.com/repos/BoD/android-prefs/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/BoD/android-prefs/pulls/9","id":82455343,"html_url":"https://github.com/BoD/android-prefs/pull/9","diff_url":"https://github.com/BoD/android-prefs/pull/9.diff","patch_url":"https://github.com/BoD/android-prefs/pull/9.patch","issue_url":"https://api.github.com/repos/BoD/android-prefs/issues/9","number":9,"state":"open","locked":false,"title":"Feature - change getter for Boolean type to isFieldName();","user":{"login":"sosite","id":2025949,"avatar_url":"https://avatars.githubusercontent.com/u/2025949?v=3","gravatar_id":"","url":"https://api.github.com/users/sosite","html_url":"https://github.com/sosite","followers_url":"https://api.github.com/users/sosite/followers","following_url":"https://api.github.com/users/sosite/following{/other_user}","gists_url":"https://api.github.com/users/sosite/gists{/gist_id}","starred_url":"https://api.github.com/users/sosite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosite/subscriptions","organizations_url":"https://api.github.com/users/sosite/orgs","repos_url":"https://api.github.com/users/sosite/repos","events_url":"https://api.github.com/users/sosite/events{/privacy}","received_events_url":"https://api.github.com/users/sosite/received_events","type":"User","site_admin":false},"body":"Change getter to `Boolean` fields to match the [JavaBean Specification (8.3.2)](http://www.oracle.com/technetwork/java/javase/documentation/spec-136004.html)\r\n\r\n> **8.3.2 Boolean properties**\r\n> In addition, for boolean properties, we allow a getter method to match the pattern:\r\n> `public boolean is<PropertyName>();`\r\n> This “is<PropertyName>” method may be provided instead of a “get<PropertyName>” method, or it may be provided in addition to a “get<PropertyName>” method.\r\n> In either case, if the “is<PropertyName>” method is present for a boolean property then we will use the “is<PropertyName>” method to read the property value.\r\n> An example boolean property might be:\r\n> ```public boolean isMarsupial();```\r\n> ```public void setMarsupial(boolean m);```","created_at":"2016-08-23T22:55:10Z","updated_at":"2016-09-13T11:47:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64f212e6db424d7b3f5e798ed071a5fad34052bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BoD/android-prefs/pulls/9/commits","review_comments_url":"https://api.github.com/repos/BoD/android-prefs/pulls/9/comments","review_comment_url":"https://api.github.com/repos/BoD/android-prefs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BoD/android-prefs/issues/9/comments","statuses_url":"https://api.github.com/repos/BoD/android-prefs/statuses/949dd1f0ae4fffd05cf261c26ce2f548e3e5483d","head":{"label":"sosite:feature/boolean_getter","ref":"feature/boolean_getter","sha":"949dd1f0ae4fffd05cf261c26ce2f548e3e5483d","user":{"login":"sosite","id":2025949,"avatar_url":"https://avatars.githubusercontent.com/u/2025949?v=3","gravatar_id":"","url":"https://api.github.com/users/sosite","html_url":"https://github.com/sosite","followers_url":"https://api.github.com/users/sosite/followers","following_url":"https://api.github.com/users/sosite/following{/other_user}","gists_url":"https://api.github.com/users/sosite/gists{/gist_id}","starred_url":"https://api.github.com/users/sosite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosite/subscriptions","organizations_url":"https://api.github.com/users/sosite/orgs","repos_url":"https://api.github.com/users/sosite/repos","events_url":"https://api.github.com/users/sosite/events{/privacy}","received_events_url":"https://api.github.com/users/sosite/received_events","type":"User","site_admin":false},"repo":{"id":66303819,"name":"android-prefs","full_name":"sosite/android-prefs","owner":{"login":"sosite","id":2025949,"avatar_url":"https://avatars.githubusercontent.com/u/2025949?v=3","gravatar_id":"","url":"https://api.github.com/users/sosite","html_url":"https://github.com/sosite","followers_url":"https://api.github.com/users/sosite/followers","following_url":"https://api.github.com/users/sosite/following{/other_user}","gists_url":"https://api.github.com/users/sosite/gists{/gist_id}","starred_url":"https://api.github.com/users/sosite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosite/subscriptions","organizations_url":"https://api.github.com/users/sosite/orgs","repos_url":"https://api.github.com/users/sosite/repos","events_url":"https://api.github.com/users/sosite/events{/privacy}","received_events_url":"https://api.github.com/users/sosite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sosite/android-prefs","description":"Android preferences for WINNERS!","fork":true,"url":"https://api.github.com/repos/sosite/android-prefs","forks_url":"https://api.github.com/repos/sosite/android-prefs/forks","keys_url":"https://api.github.com/repos/sosite/android-prefs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sosite/android-prefs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sosite/android-prefs/teams","hooks_url":"https://api.github.com/repos/sosite/android-prefs/hooks","issue_events_url":"https://api.github.com/repos/sosite/android-prefs/issues/events{/number}","events_url":"https://api.github.com/repos/sosite/android-prefs/events","assignees_url":"https://api.github.com/repos/sosite/android-prefs/assignees{/user}","branches_url":"https://api.github.com/repos/sosite/android-prefs/branches{/branch}","tags_url":"https://api.github.com/repos/sosite/android-prefs/tags","blobs_url":"https://api.github.com/repos/sosite/android-prefs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sosite/android-prefs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sosite/android-prefs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sosite/android-prefs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sosite/android-prefs/statuses/{sha}","languages_url":"https://api.github.com/repos/sosite/android-prefs/languages","stargazers_url":"https://api.github.com/repos/sosite/android-prefs/stargazers","contributors_url":"https://api.github.com/repos/sosite/android-prefs/contributors","subscribers_url":"https://api.github.com/repos/sosite/android-prefs/subscribers","subscription_url":"https://api.github.com/repos/sosite/android-prefs/subscription","commits_url":"https://api.github.com/repos/sosite/android-prefs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sosite/android-prefs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sosite/android-prefs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sosite/android-prefs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sosite/android-prefs/contents/{+path}","compare_url":"https://api.github.com/repos/sosite/android-prefs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sosite/android-prefs/merges","archive_url":"https://api.github.com/repos/sosite/android-prefs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sosite/android-prefs/downloads","issues_url":"https://api.github.com/repos/sosite/android-prefs/issues{/number}","pulls_url":"https://api.github.com/repos/sosite/android-prefs/pulls{/number}","milestones_url":"https://api.github.com/repos/sosite/android-prefs/milestones{/number}","notifications_url":"https://api.github.com/repos/sosite/android-prefs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sosite/android-prefs/labels{/name}","releases_url":"https://api.github.com/repos/sosite/android-prefs/releases{/id}","deployments_url":"https://api.github.com/repos/sosite/android-prefs/deployments","created_at":"2016-08-22T19:59:56Z","updated_at":"2016-08-22T19:59:57Z","pushed_at":"2016-08-23T22:59:24Z","git_url":"git://github.com/sosite/android-prefs.git","ssh_url":"git@github.com:sosite/android-prefs.git","clone_url":"https://github.com/sosite/android-prefs.git","svn_url":"https://github.com/sosite/android-prefs","homepage":"","size":185,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BoD:master","ref":"master","sha":"3cdb63aff51b6265d66d9fe0de1259b4ae8c6d84","user":{"login":"BoD","id":372852,"avatar_url":"https://avatars.githubusercontent.com/u/372852?v=3","gravatar_id":"","url":"https://api.github.com/users/BoD","html_url":"https://github.com/BoD","followers_url":"https://api.github.com/users/BoD/followers","following_url":"https://api.github.com/users/BoD/following{/other_user}","gists_url":"https://api.github.com/users/BoD/gists{/gist_id}","starred_url":"https://api.github.com/users/BoD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoD/subscriptions","organizations_url":"https://api.github.com/users/BoD/orgs","repos_url":"https://api.github.com/users/BoD/repos","events_url":"https://api.github.com/users/BoD/events{/privacy}","received_events_url":"https://api.github.com/users/BoD/received_events","type":"User","site_admin":false},"repo":{"id":34575845,"name":"android-prefs","full_name":"BoD/android-prefs","owner":{"login":"BoD","id":372852,"avatar_url":"https://avatars.githubusercontent.com/u/372852?v=3","gravatar_id":"","url":"https://api.github.com/users/BoD","html_url":"https://github.com/BoD","followers_url":"https://api.github.com/users/BoD/followers","following_url":"https://api.github.com/users/BoD/following{/other_user}","gists_url":"https://api.github.com/users/BoD/gists{/gist_id}","starred_url":"https://api.github.com/users/BoD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoD/subscriptions","organizations_url":"https://api.github.com/users/BoD/orgs","repos_url":"https://api.github.com/users/BoD/repos","events_url":"https://api.github.com/users/BoD/events{/privacy}","received_events_url":"https://api.github.com/users/BoD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BoD/android-prefs","description":"Android preferences for WINNERS!","fork":false,"url":"https://api.github.com/repos/BoD/android-prefs","forks_url":"https://api.github.com/repos/BoD/android-prefs/forks","keys_url":"https://api.github.com/repos/BoD/android-prefs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BoD/android-prefs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BoD/android-prefs/teams","hooks_url":"https://api.github.com/repos/BoD/android-prefs/hooks","issue_events_url":"https://api.github.com/repos/BoD/android-prefs/issues/events{/number}","events_url":"https://api.github.com/repos/BoD/android-prefs/events","assignees_url":"https://api.github.com/repos/BoD/android-prefs/assignees{/user}","branches_url":"https://api.github.com/repos/BoD/android-prefs/branches{/branch}","tags_url":"https://api.github.com/repos/BoD/android-prefs/tags","blobs_url":"https://api.github.com/repos/BoD/android-prefs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BoD/android-prefs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BoD/android-prefs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BoD/android-prefs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BoD/android-prefs/statuses/{sha}","languages_url":"https://api.github.com/repos/BoD/android-prefs/languages","stargazers_url":"https://api.github.com/repos/BoD/android-prefs/stargazers","contributors_url":"https://api.github.com/repos/BoD/android-prefs/contributors","subscribers_url":"https://api.github.com/repos/BoD/android-prefs/subscribers","subscription_url":"https://api.github.com/repos/BoD/android-prefs/subscription","commits_url":"https://api.github.com/repos/BoD/android-prefs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BoD/android-prefs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BoD/android-prefs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BoD/android-prefs/issues/comments{/number}","contents_url":"https://api.github.com/repos/BoD/android-prefs/contents/{+path}","compare_url":"https://api.github.com/repos/BoD/android-prefs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BoD/android-prefs/merges","archive_url":"https://api.github.com/repos/BoD/android-prefs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BoD/android-prefs/downloads","issues_url":"https://api.github.com/repos/BoD/android-prefs/issues{/number}","pulls_url":"https://api.github.com/repos/BoD/android-prefs/pulls{/number}","milestones_url":"https://api.github.com/repos/BoD/android-prefs/milestones{/number}","notifications_url":"https://api.github.com/repos/BoD/android-prefs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BoD/android-prefs/labels{/name}","releases_url":"https://api.github.com/repos/BoD/android-prefs/releases{/id}","deployments_url":"https://api.github.com/repos/BoD/android-prefs/deployments","created_at":"2015-04-25T16:21:23Z","updated_at":"2016-08-28T02:05:46Z","pushed_at":"2016-08-23T22:59:24Z","git_url":"git://github.com/BoD/android-prefs.git","ssh_url":"git@github.com:BoD/android-prefs.git","clone_url":"https://github.com/BoD/android-prefs.git","svn_url":"https://github.com/BoD/android-prefs","homepage":"","size":187,"stargazers_count":169,"watchers_count":169,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":5,"forks":17,"open_issues":5,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BoD/android-prefs/pulls/9"},"html":{"href":"https://github.com/BoD/android-prefs/pull/9"},"issue":{"href":"https://api.github.com/repos/BoD/android-prefs/issues/9"},"comments":{"href":"https://api.github.com/repos/BoD/android-prefs/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/BoD/android-prefs/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/BoD/android-prefs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BoD/android-prefs/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/BoD/android-prefs/statuses/949dd1f0ae4fffd05cf261c26ce2f548e3e5483d"}}}}
{"actor":{"display_login":"BoD"}}