{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/5100","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/5100/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/5100/comments","events_url":"https://api.github.com/repos/apple/swift/issues/5100/events","html_url":"https://github.com/apple/swift/pull/5100","id":180650377,"number":5100,"title":"[cmake] Use is_darwin_sdk over CMAKE_SYSTEM_NAME","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"assignees":[{"login":"gottesmm","id":499423,"avatar_url":"https://avatars.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},{"login":"llvm-beanz","id":15788759,"avatar_url":"https://avatars.githubusercontent.com/u/15788759?v=3","gravatar_id":"","url":"https://api.github.com/users/llvm-beanz","html_url":"https://github.com/llvm-beanz","followers_url":"https://api.github.com/users/llvm-beanz/followers","following_url":"https://api.github.com/users/llvm-beanz/following{/other_user}","gists_url":"https://api.github.com/users/llvm-beanz/gists{/gist_id}","starred_url":"https://api.github.com/users/llvm-beanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llvm-beanz/subscriptions","organizations_url":"https://api.github.com/users/llvm-beanz/orgs","repos_url":"https://api.github.com/users/llvm-beanz/repos","events_url":"https://api.github.com/users/llvm-beanz/events{/privacy}","received_events_url":"https://api.github.com/users/llvm-beanz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-10-03T14:11:01Z","updated_at":"2016-10-05T19:29:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5100","html_url":"https://github.com/apple/swift/pull/5100","diff_url":"https://github.com/apple/swift/pull/5100.diff","patch_url":"https://github.com/apple/swift/pull/5100.patch"},"body":"<!-- What's in this pull request? -->\r\nChecking `CMAKE_SYSTEM_NAME` to append Darwin-specific flags happens to work when cross-compiling from one Darwinian system to another -- like using a macOS host to build the standard library for iOS. It doesn't work, however, when cross-compiling from macOS to Android, for example.\r\n\r\nInstead of checking the host system name, check whether the SDK target is Darwinian.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nThis pull request was split out of https://github.com/apple/swift/pull/4972, which addresses [SR-1362](https://bugs.swift.org/browse/SR-1362).\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/251774488","html_url":"https://github.com/apple/swift/pull/5100#issuecomment-251774488","issue_url":"https://api.github.com/repos/apple/swift/issues/5100","id":251774488,"user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T19:29:18Z","updated_at":"2016-10-05T19:29:18Z","body":"Oh right, CI outage. My bad! :)"}}
{"actor":{"display_login":"modocache"}}