{"action":"created","comment":{"url":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/comments/64007802","id":64007802,"diff_hunk":"@@ -639,6 +639,24 @@ var LoaderProtoMethods = {\n     },\n \n     /**\n+     * Reports a mismatched anonymous module error. Depending on the value of the configuration property\n+     * `__CONFIG__.reportMismatchedAnonymousModules`, this method will throw an error, use the console[level]\n+     * method to log the message or silently ignore it.\n+     *\n+     * @param  {string} msg Additional information to log with the error.\n+     */\n+    _reportMismatchedAnonymousModules: function(msg) {\n+        var errorMessage = 'Mismatched anonymous define() module: ' + msg;\n+        var reportLevel = this._config.reportMismatchedAnonymousModules;\n+\n+        if (!reportLevel || reportLevel === 'exception') {\n+            throw new Error(errorMessage);\n+        } else if (console && console[reportLevel]) {\n+            console[reportLevel].call(console, errorMessage);","path":"src/js/script-loader.js","position":33,"original_position":33,"commit_id":"7d5e7b45921096e97ef812e8b3aefcb634f0e35a","original_commit_id":"7d5e7b45921096e97ef812e8b3aefcb634f0e35a","user":{"login":"jbalsas","id":905006,"avatar_url":"https://avatars.githubusercontent.com/u/905006?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalsas","html_url":"https://github.com/jbalsas","followers_url":"https://api.github.com/users/jbalsas/followers","following_url":"https://api.github.com/users/jbalsas/following{/other_user}","gists_url":"https://api.github.com/users/jbalsas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalsas/subscriptions","organizations_url":"https://api.github.com/users/jbalsas/orgs","repos_url":"https://api.github.com/users/jbalsas/repos","events_url":"https://api.github.com/users/jbalsas/events{/privacy}","received_events_url":"https://api.github.com/users/jbalsas/received_events","type":"User","site_admin":false},"body":"Definitely! 😅 I think @ipeychev might take care of that while reviewing","created_at":"2016-05-20T08:42:52Z","updated_at":"2016-05-20T08:42:52Z","html_url":"https://github.com/liferay/liferay-amd-loader/pull/67#discussion_r64007802","pull_request_url":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/comments/64007802"},"html":{"href":"https://github.com/liferay/liferay-amd-loader/pull/67#discussion_r64007802"},"pull_request":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/67","id":70814032,"html_url":"https://github.com/liferay/liferay-amd-loader/pull/67","diff_url":"https://github.com/liferay/liferay-amd-loader/pull/67.diff","patch_url":"https://github.com/liferay/liferay-amd-loader/pull/67.patch","issue_url":"https://api.github.com/repos/liferay/liferay-amd-loader/issues/67","number":67,"state":"open","locked":false,"title":"Allow mismatched anonymous module report log level to be configured","user":{"login":"jbalsas","id":905006,"avatar_url":"https://avatars.githubusercontent.com/u/905006?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalsas","html_url":"https://github.com/jbalsas","followers_url":"https://api.github.com/users/jbalsas/followers","following_url":"https://api.github.com/users/jbalsas/following{/other_user}","gists_url":"https://api.github.com/users/jbalsas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalsas/subscriptions","organizations_url":"https://api.github.com/users/jbalsas/orgs","repos_url":"https://api.github.com/users/jbalsas/repos","events_url":"https://api.github.com/users/jbalsas/events{/privacy}","received_events_url":"https://api.github.com/users/jbalsas/received_events","type":"User","site_admin":false},"body":"Hey @ipeychev, this adds the configurable log level for `mismatched anonymous modules`. The behaviour will be as follow:\r\n\r\n```javascript\r\n// By default, if not configured, will throw an exception\r\n\r\n// Throw an exception\r\n__CONFIG__.reportMismatchedAnonymousModules = 'exception';\r\n\r\n// Log the error using console.log\r\n__CONFIG__.reportMismatchedAnonymousModules = 'log';\r\n\r\n// Log the error using console.info\r\n__CONFIG__.reportMismatchedAnonymousModules = 'info';\r\n\r\n// Log the error using console.warn\r\n__CONFIG__.reportMismatchedAnonymousModules = 'warn';\r\n\r\n// Log the error using console.error\r\n__CONFIG__.reportMismatchedAnonymousModules = 'error';\r\n\r\n// Ignore the error\r\n__CONFIG__.reportMismatchedAnonymousModules = 'off';\r\n```","created_at":"2016-05-20T07:59:07Z","updated_at":"2016-05-20T08:42:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35052f89715e49dbb3d996bef350b7412efc3465","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/67/commits","review_comments_url":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/67/comments","review_comment_url":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liferay/liferay-amd-loader/issues/67/comments","statuses_url":"https://api.github.com/repos/liferay/liferay-amd-loader/statuses/7d5e7b45921096e97ef812e8b3aefcb634f0e35a","head":{"label":"jbalsas:LL-65-Logging_anon_error","ref":"LL-65-Logging_anon_error","sha":"7d5e7b45921096e97ef812e8b3aefcb634f0e35a","user":{"login":"jbalsas","id":905006,"avatar_url":"https://avatars.githubusercontent.com/u/905006?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalsas","html_url":"https://github.com/jbalsas","followers_url":"https://api.github.com/users/jbalsas/followers","following_url":"https://api.github.com/users/jbalsas/following{/other_user}","gists_url":"https://api.github.com/users/jbalsas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalsas/subscriptions","organizations_url":"https://api.github.com/users/jbalsas/orgs","repos_url":"https://api.github.com/users/jbalsas/repos","events_url":"https://api.github.com/users/jbalsas/events{/privacy}","received_events_url":"https://api.github.com/users/jbalsas/received_events","type":"User","site_admin":false},"repo":{"id":46577952,"name":"liferay-amd-loader","full_name":"jbalsas/liferay-amd-loader","owner":{"login":"jbalsas","id":905006,"avatar_url":"https://avatars.githubusercontent.com/u/905006?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalsas","html_url":"https://github.com/jbalsas","followers_url":"https://api.github.com/users/jbalsas/followers","following_url":"https://api.github.com/users/jbalsas/following{/other_user}","gists_url":"https://api.github.com/users/jbalsas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalsas/subscriptions","organizations_url":"https://api.github.com/users/jbalsas/orgs","repos_url":"https://api.github.com/users/jbalsas/repos","events_url":"https://api.github.com/users/jbalsas/events{/privacy}","received_events_url":"https://api.github.com/users/jbalsas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbalsas/liferay-amd-loader","description":"","fork":true,"url":"https://api.github.com/repos/jbalsas/liferay-amd-loader","forks_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/forks","keys_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/teams","hooks_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/hooks","issue_events_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/issues/events{/number}","events_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/events","assignees_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/assignees{/user}","branches_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/branches{/branch}","tags_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/tags","blobs_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/languages","stargazers_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/stargazers","contributors_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/contributors","subscribers_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/subscribers","subscription_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/subscription","commits_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/contents/{+path}","compare_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/merges","archive_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/downloads","issues_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/issues{/number}","pulls_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/labels{/name}","releases_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/releases{/id}","deployments_url":"https://api.github.com/repos/jbalsas/liferay-amd-loader/deployments","created_at":"2015-11-20T17:55:12Z","updated_at":"2016-01-29T10:49:58Z","pushed_at":"2016-05-20T07:59:07Z","git_url":"git://github.com/jbalsas/liferay-amd-loader.git","ssh_url":"git@github.com:jbalsas/liferay-amd-loader.git","clone_url":"https://github.com/jbalsas/liferay-amd-loader.git","svn_url":"https://github.com/jbalsas/liferay-amd-loader","homepage":null,"size":1917,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"liferay:master","ref":"master","sha":"29ffaadf971d2bea1807e9f1e7c906da22f60dec","user":{"login":"liferay","id":131436,"avatar_url":"https://avatars.githubusercontent.com/u/131436?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay","html_url":"https://github.com/liferay","followers_url":"https://api.github.com/users/liferay/followers","following_url":"https://api.github.com/users/liferay/following{/other_user}","gists_url":"https://api.github.com/users/liferay/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay/subscriptions","organizations_url":"https://api.github.com/users/liferay/orgs","repos_url":"https://api.github.com/users/liferay/repos","events_url":"https://api.github.com/users/liferay/events{/privacy}","received_events_url":"https://api.github.com/users/liferay/received_events","type":"Organization","site_admin":false},"repo":{"id":26091923,"name":"liferay-amd-loader","full_name":"liferay/liferay-amd-loader","owner":{"login":"liferay","id":131436,"avatar_url":"https://avatars.githubusercontent.com/u/131436?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay","html_url":"https://github.com/liferay","followers_url":"https://api.github.com/users/liferay/followers","following_url":"https://api.github.com/users/liferay/following{/other_user}","gists_url":"https://api.github.com/users/liferay/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay/subscriptions","organizations_url":"https://api.github.com/users/liferay/orgs","repos_url":"https://api.github.com/users/liferay/repos","events_url":"https://api.github.com/users/liferay/events{/privacy}","received_events_url":"https://api.github.com/users/liferay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liferay/liferay-amd-loader","description":"","fork":false,"url":"https://api.github.com/repos/liferay/liferay-amd-loader","forks_url":"https://api.github.com/repos/liferay/liferay-amd-loader/forks","keys_url":"https://api.github.com/repos/liferay/liferay-amd-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liferay/liferay-amd-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liferay/liferay-amd-loader/teams","hooks_url":"https://api.github.com/repos/liferay/liferay-amd-loader/hooks","issue_events_url":"https://api.github.com/repos/liferay/liferay-amd-loader/issues/events{/number}","events_url":"https://api.github.com/repos/liferay/liferay-amd-loader/events","assignees_url":"https://api.github.com/repos/liferay/liferay-amd-loader/assignees{/user}","branches_url":"https://api.github.com/repos/liferay/liferay-amd-loader/branches{/branch}","tags_url":"https://api.github.com/repos/liferay/liferay-amd-loader/tags","blobs_url":"https://api.github.com/repos/liferay/liferay-amd-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liferay/liferay-amd-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liferay/liferay-amd-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/liferay/liferay-amd-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liferay/liferay-amd-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/liferay/liferay-amd-loader/languages","stargazers_url":"https://api.github.com/repos/liferay/liferay-amd-loader/stargazers","contributors_url":"https://api.github.com/repos/liferay/liferay-amd-loader/contributors","subscribers_url":"https://api.github.com/repos/liferay/liferay-amd-loader/subscribers","subscription_url":"https://api.github.com/repos/liferay/liferay-amd-loader/subscription","commits_url":"https://api.github.com/repos/liferay/liferay-amd-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/liferay/liferay-amd-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/liferay/liferay-amd-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/liferay/liferay-amd-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/liferay/liferay-amd-loader/contents/{+path}","compare_url":"https://api.github.com/repos/liferay/liferay-amd-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liferay/liferay-amd-loader/merges","archive_url":"https://api.github.com/repos/liferay/liferay-amd-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liferay/liferay-amd-loader/downloads","issues_url":"https://api.github.com/repos/liferay/liferay-amd-loader/issues{/number}","pulls_url":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/liferay/liferay-amd-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/liferay/liferay-amd-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liferay/liferay-amd-loader/labels{/name}","releases_url":"https://api.github.com/repos/liferay/liferay-amd-loader/releases{/id}","deployments_url":"https://api.github.com/repos/liferay/liferay-amd-loader/deployments","created_at":"2014-11-02T20:12:44Z","updated_at":"2016-04-29T07:12:44Z","pushed_at":"2016-05-20T07:59:08Z","git_url":"git://github.com/liferay/liferay-amd-loader.git","ssh_url":"git@github.com:liferay/liferay-amd-loader.git","clone_url":"https://github.com/liferay/liferay-amd-loader.git","svn_url":"https://github.com/liferay/liferay-amd-loader","homepage":null,"size":1918,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/67"},"html":{"href":"https://github.com/liferay/liferay-amd-loader/pull/67"},"issue":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/issues/67"},"comments":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/liferay/liferay-amd-loader/statuses/7d5e7b45921096e97ef812e8b3aefcb634f0e35a"}}}}
{"actor":{"display_login":"jbalsas"}}