{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/85001653","pull_request_review_id":5744350,"id":85001653,"diff_hunk":"@@ -214,7 +214,7 @@ class Assembly\n    * Returns the reference to the current neighbor volume\n    * @return A _reference_.  Make sure to store this as a reference!\n    */\n-  const Real & neighborVolume() { return _current_neighbor_volume; }\n+  const Real & neighborVolume() { _need_neighbor_elem_volume = true; return _current_neighbor_volume; }","path":"framework/include/base/Assembly.h","position":5,"original_position":5,"commit_id":"5e54bef693590abc9bd0df41560649bc4547d120","original_commit_id":"5e54bef693590abc9bd0df41560649bc4547d120","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"I suppose this is ok. This method is probably getting big enough to move to the .C file.","created_at":"2016-10-25T21:10:02Z","updated_at":"2016-10-25T21:10:02Z","html_url":"https://github.com/idaholab/moose/pull/7942#discussion_r85001653","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/7942","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/85001653"},"html":{"href":"https://github.com/idaholab/moose/pull/7942#discussion_r85001653"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7942"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/7942","id":90889882,"html_url":"https://github.com/idaholab/moose/pull/7942","diff_url":"https://github.com/idaholab/moose/pull/7942.diff","patch_url":"https://github.com/idaholab/moose/pull/7942.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/7942","number":7942,"state":"open","locked":false,"title":"Compute neighbor element volume on demand","user":{"login":"andrsd","id":85632,"avatar_url":"https://avatars.githubusercontent.com/u/85632?v=3","gravatar_id":"","url":"https://api.github.com/users/andrsd","html_url":"https://github.com/andrsd","followers_url":"https://api.github.com/users/andrsd/followers","following_url":"https://api.github.com/users/andrsd/following{/other_user}","gists_url":"https://api.github.com/users/andrsd/gists{/gist_id}","starred_url":"https://api.github.com/users/andrsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrsd/subscriptions","organizations_url":"https://api.github.com/users/andrsd/orgs","repos_url":"https://api.github.com/users/andrsd/repos","events_url":"https://api.github.com/users/andrsd/events{/privacy}","received_events_url":"https://api.github.com/users/andrsd/received_events","type":"User","site_admin":false},"body":"MOOSE was computing the neighbor element volume even though it was not\r\nreally needed. The computation is quite expensive and shows up in\r\nprofiling.  If the volume is needed in a DG kernel, users can obtain it\r\nby:\r\n\r\n```\r\n.h:\r\nconst Real & _neighbor_volume;\r\n\r\n.C:\r\n_neighbor_volume(getNeighborElemVolume())\r\n```\r\n\r\nThis will tell MOOSE to compute the volume. The same holds for `InternalSideUserObject`s.\r\n\r\nRefs #3661, #6788","created_at":"2016-10-25T20:55:51Z","updated_at":"2016-10-25T21:11:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c81cc50e70e62b0294cd0f07670cf74c6d847f56","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/7942/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/7942/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/7942/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/5e54bef693590abc9bd0df41560649bc4547d120","head":{"label":"andrsd:neighbor_volume_optional","ref":"neighbor_volume_optional","sha":"5e54bef693590abc9bd0df41560649bc4547d120","user":{"login":"andrsd","id":85632,"avatar_url":"https://avatars.githubusercontent.com/u/85632?v=3","gravatar_id":"","url":"https://api.github.com/users/andrsd","html_url":"https://github.com/andrsd","followers_url":"https://api.github.com/users/andrsd/followers","following_url":"https://api.github.com/users/andrsd/following{/other_user}","gists_url":"https://api.github.com/users/andrsd/gists{/gist_id}","starred_url":"https://api.github.com/users/andrsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrsd/subscriptions","organizations_url":"https://api.github.com/users/andrsd/orgs","repos_url":"https://api.github.com/users/andrsd/repos","events_url":"https://api.github.com/users/andrsd/events{/privacy}","received_events_url":"https://api.github.com/users/andrsd/received_events","type":"User","site_admin":false},"repo":{"id":17845085,"name":"moose","full_name":"andrsd/moose","owner":{"login":"andrsd","id":85632,"avatar_url":"https://avatars.githubusercontent.com/u/85632?v=3","gravatar_id":"","url":"https://api.github.com/users/andrsd","html_url":"https://github.com/andrsd","followers_url":"https://api.github.com/users/andrsd/followers","following_url":"https://api.github.com/users/andrsd/following{/other_user}","gists_url":"https://api.github.com/users/andrsd/gists{/gist_id}","starred_url":"https://api.github.com/users/andrsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrsd/subscriptions","organizations_url":"https://api.github.com/users/andrsd/orgs","repos_url":"https://api.github.com/users/andrsd/repos","events_url":"https://api.github.com/users/andrsd/events{/privacy}","received_events_url":"https://api.github.com/users/andrsd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrsd/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/andrsd/moose","forks_url":"https://api.github.com/repos/andrsd/moose/forks","keys_url":"https://api.github.com/repos/andrsd/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrsd/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrsd/moose/teams","hooks_url":"https://api.github.com/repos/andrsd/moose/hooks","issue_events_url":"https://api.github.com/repos/andrsd/moose/issues/events{/number}","events_url":"https://api.github.com/repos/andrsd/moose/events","assignees_url":"https://api.github.com/repos/andrsd/moose/assignees{/user}","branches_url":"https://api.github.com/repos/andrsd/moose/branches{/branch}","tags_url":"https://api.github.com/repos/andrsd/moose/tags","blobs_url":"https://api.github.com/repos/andrsd/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrsd/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrsd/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrsd/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrsd/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/andrsd/moose/languages","stargazers_url":"https://api.github.com/repos/andrsd/moose/stargazers","contributors_url":"https://api.github.com/repos/andrsd/moose/contributors","subscribers_url":"https://api.github.com/repos/andrsd/moose/subscribers","subscription_url":"https://api.github.com/repos/andrsd/moose/subscription","commits_url":"https://api.github.com/repos/andrsd/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrsd/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrsd/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrsd/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrsd/moose/contents/{+path}","compare_url":"https://api.github.com/repos/andrsd/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrsd/moose/merges","archive_url":"https://api.github.com/repos/andrsd/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrsd/moose/downloads","issues_url":"https://api.github.com/repos/andrsd/moose/issues{/number}","pulls_url":"https://api.github.com/repos/andrsd/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/andrsd/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/andrsd/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrsd/moose/labels{/name}","releases_url":"https://api.github.com/repos/andrsd/moose/releases{/id}","deployments_url":"https://api.github.com/repos/andrsd/moose/deployments","created_at":"2014-03-17T22:08:56Z","updated_at":"2015-04-20T23:07:27Z","pushed_at":"2016-10-25T20:53:50Z","git_url":"git://github.com/andrsd/moose.git","ssh_url":"git@github.com:andrsd/moose.git","clone_url":"https://github.com/andrsd/moose.git","svn_url":"https://github.com/andrsd/moose","homepage":null,"size":147692,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"b7fdc8229267248f085dc317e0dfd93bb53e3dec","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2016-10-24T14:16:04Z","pushed_at":"2016-10-25T21:06:37Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":164524,"stargazers_count":174,"watchers_count":174,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":700,"forks":288,"open_issues":700,"watchers":174,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7942"},"html":{"href":"https://github.com/idaholab/moose/pull/7942"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/7942"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/7942/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7942/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/7942/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/5e54bef693590abc9bd0df41560649bc4547d120"}}}}
{"actor":{"display_login":"permcody"}}