{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/72609832","id":72609832,"diff_hunk":"@@ -483,15 +524,232 @@ def plot_signal(x, offset):\n plt.show()\n \n ###############################################################################\n-# Filtering in MNE-Python\n-# =======================\n+# Some pitfalls of filtering\n+# ==========================\n+# Multiple recent papers have noted potential risks of drawing\n+# errant inferences due to misapplication of filters.\n+#\n+# Low-pass problems\n+# -----------------\n+# Filters in general, especially those that are acausal (zero-phase), can make\n+# activity appear to occur earlier or later than it truly did. As\n+# mentioned in VanRullen 2011 [3]_, investigations of commonly (at the time)\n+# used low-pass filters created artifacts. However, such deleterious effects","path":"tutorials/plot_background_filtering.py","position":185,"original_position":185,"commit_id":"59dd25b1ab50a23fd0e78a7ded9812bffa349f49","original_commit_id":"59dd25b1ab50a23fd0e78a7ded9812bffa349f49","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"Cool, I'll look into it because it is indeed not obvious. Still need to\npush a commit to address comments then we should be good.\n","created_at":"2016-07-28T12:08:58Z","updated_at":"2016-07-28T12:08:58Z","html_url":"https://github.com/mne-tools/mne-python/pull/3449#discussion_r72609832","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3449","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/72609832"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3449#discussion_r72609832"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3449"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3449","id":78563635,"html_url":"https://github.com/mne-tools/mne-python/pull/3449","diff_url":"https://github.com/mne-tools/mne-python/pull/3449.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3449.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3449","number":3449,"state":"open","locked":false,"title":"MRG: Add filtering default","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"Closes #3239.\r\n\r\nStill need to update the background tutorial a bit, plus update `whats_new.py`.\r\n\r\nSorry in advance for the big diff...","created_at":"2016-07-23T05:11:54Z","updated_at":"2016-07-28T12:08:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de2bb6db5fe285a12579c2c2db91173bf74d2e0e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mne-tools/mne-python/milestones/9","html_url":"https://github.com/mne-tools/mne-python/milestones/0.13","labels_url":"https://api.github.com/repos/mne-tools/mne-python/milestones/9/labels","id":1648503,"number":9,"title":"0.13","description":"","creator":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":68,"state":"open","created_at":"2016-03-16T17:14:08Z","updated_at":"2016-07-27T08:41:09Z","due_on":"2016-10-28T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3449/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3449/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3449/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/59dd25b1ab50a23fd0e78a7ded9812bffa349f49","head":{"label":"Eric89GXL:filt-def","ref":"filt-def","sha":"59dd25b1ab50a23fd0e78a7ded9812bffa349f49","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"repo":{"id":5848067,"name":"mne-python","full_name":"Eric89GXL/mne-python","owner":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eric89GXL/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/Eric89GXL/mne-python","forks_url":"https://api.github.com/repos/Eric89GXL/mne-python/forks","keys_url":"https://api.github.com/repos/Eric89GXL/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eric89GXL/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eric89GXL/mne-python/teams","hooks_url":"https://api.github.com/repos/Eric89GXL/mne-python/hooks","issue_events_url":"https://api.github.com/repos/Eric89GXL/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/Eric89GXL/mne-python/events","assignees_url":"https://api.github.com/repos/Eric89GXL/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/Eric89GXL/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/Eric89GXL/mne-python/tags","blobs_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eric89GXL/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Eric89GXL/mne-python/languages","stargazers_url":"https://api.github.com/repos/Eric89GXL/mne-python/stargazers","contributors_url":"https://api.github.com/repos/Eric89GXL/mne-python/contributors","subscribers_url":"https://api.github.com/repos/Eric89GXL/mne-python/subscribers","subscription_url":"https://api.github.com/repos/Eric89GXL/mne-python/subscription","commits_url":"https://api.github.com/repos/Eric89GXL/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eric89GXL/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eric89GXL/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eric89GXL/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/Eric89GXL/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eric89GXL/mne-python/merges","archive_url":"https://api.github.com/repos/Eric89GXL/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eric89GXL/mne-python/downloads","issues_url":"https://api.github.com/repos/Eric89GXL/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/Eric89GXL/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Eric89GXL/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Eric89GXL/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eric89GXL/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/Eric89GXL/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/Eric89GXL/mne-python/deployments","created_at":"2012-09-17T22:08:11Z","updated_at":"2015-05-07T15:05:01Z","pushed_at":"2016-07-27T03:18:26Z","git_url":"git://github.com/Eric89GXL/mne-python.git","ssh_url":"git@github.com:Eric89GXL/mne-python.git","clone_url":"https://github.com/Eric89GXL/mne-python.git","svn_url":"https://github.com/Eric89GXL/mne-python","homepage":"http://martinos.org/mne/","size":87878,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"7fe99df50119d06803cdd929c512a8d799ecd962","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-07-13T13:08:57Z","pushed_at":"2016-07-28T08:06:54Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":180097,"stargazers_count":215,"watchers_count":215,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":206,"mirror_url":null,"open_issues_count":191,"forks":206,"open_issues":191,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3449"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3449"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3449"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3449/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3449/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3449/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/59dd25b1ab50a23fd0e78a7ded9812bffa349f49"}}}}
{"actor":{"display_login":"Eric89GXL"}}