{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/69104015","id":69104015,"diff_hunk":"@@ -60,7 +67,7 @@ else(no_yasm)\n     COMMAND uname -m\n     OUTPUT_VARIABLE arch\n     OUTPUT_STRIP_TRAILING_WHITESPACE)\n-  if(arch STREQUAL \"x86_64\")\n+  if((arch STREQUAL \"x86_64\") OR (arch STREQUAL \"amd64\"))","path":"src/CMakeLists.txt","position":19,"original_position":19,"commit_id":"0c5d7b9318066f27ca1a1e6dff507d5c5a049017","original_commit_id":"0d2a9de0287e83015ea22f7c09ad4fdab7f0a0f9","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"might want to use\r\n```cmake\r\nif(arch MATCHES \"amd64|x86_64\")\r\n```","created_at":"2016-06-30T09:49:58Z","updated_at":"2016-06-30T09:49:58Z","html_url":"https://github.com/ceph/ceph/pull/10024#discussion_r69104015","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10024","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/69104015"},"html":{"href":"https://github.com/ceph/ceph/pull/10024#discussion_r69104015"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10024"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10024","id":75683031,"html_url":"https://github.com/ceph/ceph/pull/10024","diff_url":"https://github.com/ceph/ceph/pull/10024.diff","patch_url":"https://github.com/ceph/ceph/pull/10024.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10024","number":10024,"state":"open","locked":false,"title":"cmake FreeBSD changes","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"body":" - Clang has different warning requirements\r\n - add /usr/local for include and libs\r\n - UDEV is not the same on FreeBSD\r\n - No blkid, keyutils\r\n - Several libs (dl, uuid, resolv) are in clib, so no need to link explicit\r\n - uname returns amd64\r\n - use EventKqueue.* in msg/async\r\n\r\n\r\nItems excluded because porting is not done.\r\n - Bluestore, due to incompatible AIO\r\n - CephFS due to keystore dependancy??\r\n - RBD excluded because of incomplete porting\r\n","created_at":"2016-06-29T16:49:02Z","updated_at":"2016-06-30T09:49:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a11c02db0a2293d6f4ebba748385405eed11cc46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10024/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10024/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10024/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/0c5d7b9318066f27ca1a1e6dff507d5c5a049017","head":{"label":"wjwithagen:wip-wjw-freebsd-cmake","ref":"wip-wjw-freebsd-cmake","sha":"0c5d7b9318066f27ca1a1e6dff507d5c5a049017","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"repo":{"id":50789401,"name":"ceph","full_name":"wjwithagen/ceph","owner":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wjwithagen/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/wjwithagen/ceph","forks_url":"https://api.github.com/repos/wjwithagen/ceph/forks","keys_url":"https://api.github.com/repos/wjwithagen/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wjwithagen/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wjwithagen/ceph/teams","hooks_url":"https://api.github.com/repos/wjwithagen/ceph/hooks","issue_events_url":"https://api.github.com/repos/wjwithagen/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/wjwithagen/ceph/events","assignees_url":"https://api.github.com/repos/wjwithagen/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/wjwithagen/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/wjwithagen/ceph/tags","blobs_url":"https://api.github.com/repos/wjwithagen/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wjwithagen/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wjwithagen/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/wjwithagen/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wjwithagen/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/wjwithagen/ceph/languages","stargazers_url":"https://api.github.com/repos/wjwithagen/ceph/stargazers","contributors_url":"https://api.github.com/repos/wjwithagen/ceph/contributors","subscribers_url":"https://api.github.com/repos/wjwithagen/ceph/subscribers","subscription_url":"https://api.github.com/repos/wjwithagen/ceph/subscription","commits_url":"https://api.github.com/repos/wjwithagen/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/wjwithagen/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/wjwithagen/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/wjwithagen/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/wjwithagen/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/wjwithagen/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wjwithagen/ceph/merges","archive_url":"https://api.github.com/repos/wjwithagen/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wjwithagen/ceph/downloads","issues_url":"https://api.github.com/repos/wjwithagen/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/wjwithagen/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/wjwithagen/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/wjwithagen/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wjwithagen/ceph/labels{/name}","releases_url":"https://api.github.com/repos/wjwithagen/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/wjwithagen/ceph/deployments","created_at":"2016-01-31T18:48:17Z","updated_at":"2016-06-10T05:43:45Z","pushed_at":"2016-06-29T20:34:38Z","git_url":"git://github.com/wjwithagen/ceph.git","ssh_url":"git@github.com:wjwithagen/ceph.git","clone_url":"https://github.com/wjwithagen/ceph.git","svn_url":"https://github.com/wjwithagen/ceph","homepage":"http://ceph.com","size":168459,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"ee7949f1e50354df432c285ffb06d0306689cec7","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-06-30T04:28:14Z","pushed_at":"2016-06-30T09:49:34Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":224470,"stargazers_count":2266,"watchers_count":2266,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1349,"mirror_url":null,"open_issues_count":436,"forks":1349,"open_issues":436,"watchers":2266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10024"},"html":{"href":"https://github.com/ceph/ceph/pull/10024"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10024"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10024/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10024/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10024/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/0c5d7b9318066f27ca1a1e6dff507d5c5a049017"}}}}
{"actor":{"display_login":"tchaikov"}}