{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/14332","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/14332/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/14332/comments","events_url":"https://api.github.com/repos/servo/servo/issues/14332/events","html_url":"https://github.com/servo/servo/pull/14332","id":191179489,"number":14332,"title":"Add keyword \"auto\" to flexbox min-size property","user":{"login":"shinglyu","id":3250983,"avatar_url":"https://avatars.githubusercontent.com/u/3250983?v=3","gravatar_id":"","url":"https://api.github.com/users/shinglyu","html_url":"https://github.com/shinglyu","followers_url":"https://api.github.com/users/shinglyu/followers","following_url":"https://api.github.com/users/shinglyu/following{/other_user}","gists_url":"https://api.github.com/users/shinglyu/gists{/gist_id}","starred_url":"https://api.github.com/users/shinglyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinglyu/subscriptions","organizations_url":"https://api.github.com/users/shinglyu/orgs","repos_url":"https://api.github.com/users/shinglyu/repos","events_url":"https://api.github.com/users/shinglyu/events{/privacy}","received_events_url":"https://api.github.com/users/shinglyu/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"assignees":[{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-23T03:07:47Z","updated_at":"2016-11-28T09:08:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/14332","html_url":"https://github.com/servo/servo/pull/14332","diff_url":"https://github.com/servo/servo/pull/14332.diff","patch_url":"https://github.com/servo/servo/pull/14332.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\nThis is the first patch for #12610, the algorithm itself took longer than I expected, so I'm landing this foundational work first.\r\n\r\nThis adds a new initial value `auto` to the `min-width` and `min-height` specified on a flexitem. It also provides a fallback of \"0px\" if we try to get the `min-width/height` on a non-flexitem box using `getComputedStyle`. \r\n\r\nThe `auto` resolution algorithm is not ready yet, so we fall back to `0px` during layout.\r\n\r\nr?@stshine\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [x] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/14332)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/263218308","html_url":"https://github.com/servo/servo/pull/14332#issuecomment-263218308","issue_url":"https://api.github.com/repos/servo/servo/issues/14332","id":263218308,"user":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T09:08:47Z","updated_at":"2016-11-28T09:08:47Z","body":"\n\n\n\nReviewed 8 of 8 files at r1, 1 of 1 files at r2, 2 of 2 files at r3.\nReview status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.\n\n---\n\n*[components/layout/model.rs, line 460 at r3](https://reviewable.io:443/reviews/servo/servo/14332#-KXE8xRO_wnSYqvNyEWG-r3-460:-KXe7sDqlklEvJCGNl4v:bjzeazs) ([raw file](https://github.com/servo/servo/blob/e7b518d7f9888a11f5495919b1ad93ff3a5596d9/components/layout/model.rs#L460)):*\n<details><summary><i>Previously, stshine wrote…</i></summary><blockquote>\n\nThis function is unnessasary, and its name is quite confusing, hinting that it will return a `MaybeAuto` type. Use `MaybeAuto::from_style().specified_or_zero()` should be enough.\n</blockquote></details>\n\nI agree that the name should indicate that 'auto' is treated as zero.\n\n---\n\n*[components/style/properties/properties.mako.rs, line 1706 at r2](https://reviewable.io:443/reviews/servo/servo/14332#-KXe9nk_4R_sh1zO6DMQ:-KXe9nk_4R_sh1zO6DMR:bv6kigj) ([raw file](https://github.com/servo/servo/blob/095de770f72fa2d7509c7ca2a85c52c75c2ce007/components/style/properties/properties.mako.rs#L1706)):*\nThis is more specific than flex items:\n\nhttps://drafts.csswg.org/css-flexbox/#valdef-min-width-auto\n> On a flex item whose overflow is visible in the main axis, when specified on the flex item’s main-axis min-size property\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/14332)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"SimonSapin"}}