{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/52526732","id":52526732,"diff_hunk":"@@ -31,6 +32,10 @@ class Railtie < Rails::Engine # :nodoc:\n           self.cable = Rails.application.config_for(config_path).with_indifferent_access\n         end\n \n+        self.connection_class = ApplicationCable::Connection","path":"actioncable/lib/action_cable/engine.rb","position":12,"original_position":12,"commit_id":"e464f8e3607d31c4096cfe4616e4966452170c84","original_commit_id":"e464f8e3607d31c4096cfe4616e4966452170c84","user":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"body":"Killed the error message since from the point of the final release the file with this constant has been generated.","created_at":"2016-02-10T21:20:38Z","updated_at":"2016-02-10T21:20:38Z","html_url":"https://github.com/rails/rails/pull/23505#discussion_r52526732","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/23505","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/52526732"},"html":{"href":"https://github.com/rails/rails/pull/23505#discussion_r52526732"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/23505"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/23505","id":58496399,"html_url":"https://github.com/rails/rails/pull/23505","diff_url":"https://github.com/rails/rails/pull/23505.diff","patch_url":"https://github.com/rails/rails/pull/23505.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/23505","number":23505,"state":"open","locked":false,"title":"Inject Rails related configuration through Railtie","user":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"body":"Instead of direct coupling we can inject configuration. This also spares us some setup in tests.\r\n\r\nWork in progress. Need to consider better error messages, better docs, tests.\r\n\r\nWould also like to tackle the `inner_logger` + `TaggedLoggerProxy.new` test setup, but unsure what to do there at the moment. Maybe we can move `new_tagged_logger` to the server?\r\n\r\ncc @rafaelfranca @matthewd ","created_at":"2016-02-05T22:58:08Z","updated_at":"2016-02-10T21:20:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc0cc8ef1532e0cb2f7cac35d61bda619bbf2cf0","assignee":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/rails/rails/milestones/47","html_url":"https://github.com/rails/rails/milestones/5.0.0","labels_url":"https://api.github.com/repos/rails/rails/milestones/47/labels","id":1467326,"number":47,"title":"5.0.0","description":"","creator":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":314,"state":"open","created_at":"2015-12-18T21:17:59Z","updated_at":"2016-02-10T21:05:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/rails/rails/pulls/23505/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/23505/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/23505/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/e464f8e3607d31c4096cfe4616e4966452170c84","head":{"label":"kaspth:inject-rails-config-through-railtie","ref":"inject-rails-config-through-railtie","sha":"e464f8e3607d31c4096cfe4616e4966452170c84","user":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"repo":{"id":10581672,"name":"rails","full_name":"kaspth/rails","owner":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaspth/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/kaspth/rails","forks_url":"https://api.github.com/repos/kaspth/rails/forks","keys_url":"https://api.github.com/repos/kaspth/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaspth/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaspth/rails/teams","hooks_url":"https://api.github.com/repos/kaspth/rails/hooks","issue_events_url":"https://api.github.com/repos/kaspth/rails/issues/events{/number}","events_url":"https://api.github.com/repos/kaspth/rails/events","assignees_url":"https://api.github.com/repos/kaspth/rails/assignees{/user}","branches_url":"https://api.github.com/repos/kaspth/rails/branches{/branch}","tags_url":"https://api.github.com/repos/kaspth/rails/tags","blobs_url":"https://api.github.com/repos/kaspth/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaspth/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaspth/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaspth/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaspth/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/kaspth/rails/languages","stargazers_url":"https://api.github.com/repos/kaspth/rails/stargazers","contributors_url":"https://api.github.com/repos/kaspth/rails/contributors","subscribers_url":"https://api.github.com/repos/kaspth/rails/subscribers","subscription_url":"https://api.github.com/repos/kaspth/rails/subscription","commits_url":"https://api.github.com/repos/kaspth/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaspth/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaspth/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaspth/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaspth/rails/contents/{+path}","compare_url":"https://api.github.com/repos/kaspth/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaspth/rails/merges","archive_url":"https://api.github.com/repos/kaspth/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaspth/rails/downloads","issues_url":"https://api.github.com/repos/kaspth/rails/issues{/number}","pulls_url":"https://api.github.com/repos/kaspth/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/kaspth/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/kaspth/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaspth/rails/labels{/name}","releases_url":"https://api.github.com/repos/kaspth/rails/releases{/id}","deployments_url":"https://api.github.com/repos/kaspth/rails/deployments","created_at":"2013-06-09T10:20:15Z","updated_at":"2015-05-04T19:09:39Z","pushed_at":"2016-02-10T21:19:54Z","git_url":"git://github.com/kaspth/rails.git","ssh_url":"git@github.com:kaspth/rails.git","clone_url":"https://github.com/kaspth/rails.git","svn_url":"https://github.com/kaspth/rails","homepage":"http://rubyonrails.org","size":118845,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"391061a30d7ab2923ea342048fe643469de3f1a9","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-02-10T20:59:51Z","pushed_at":"2016-02-10T21:19:59Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":325586,"stargazers_count":29619,"watchers_count":29619,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12023,"mirror_url":null,"open_issues_count":868,"forks":12023,"open_issues":868,"watchers":29619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/23505"},"html":{"href":"https://github.com/rails/rails/pull/23505"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/23505"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/23505/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/23505/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/23505/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/e464f8e3607d31c4096cfe4616e4966452170c84"}}}}