{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/64776117","id":64776117,"diff_hunk":"@@ -302,6 +302,26 @@ describe('injector', function() {\n           expect(instance.aVal()).toEqual('a-value');\n         });\n \n+        if (/chrome/.test(navigator.userAgent)) {","path":"test/auto/injectorSpec.js","position":4,"original_position":4,"commit_id":"8a647ef3593f8b821fe2c416886b2846bb9b24c1","original_commit_id":"8a647ef3593f8b821fe2c416886b2846bb9b24c1","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"body":"The situation in tests is a little different; in jQuery e.g. we don't sniff in source but if a specific bug exists in a specific browser & version we do sniff in tests. This is not only because it's simpler to do but also to rule out the possibility that a broken support check will make the tests be skipped - we do want to verify that in these specific browsers they're being run.\r\n\r\nI agree with you here, though as we're talking about a bleeding-edge feature that browsers are only implementing now and more & more of them will have it in a working state. That's different.","created_at":"2016-05-26T16:22:36Z","updated_at":"2016-05-26T16:22:36Z","html_url":"https://github.com/angular/angular.js/pull/14533#discussion_r64776117","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/14533","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/64776117"},"html":{"href":"https://github.com/angular/angular.js/pull/14533#discussion_r64776117"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14533"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/14533","id":68210153,"html_url":"https://github.com/angular/angular.js/pull/14533","diff_url":"https://github.com/angular/angular.js/pull/14533.diff","patch_url":"https://github.com/angular/angular.js/pull/14533.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/14533","number":14533,"state":"open","locked":false,"title":"fix($injector): fix class detection RegExp","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"**What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)**\r\nBug fix\r\n\r\n**What is the current behavior? (You can also link to an open issue here)**\r\nES6 classes are not properly detected unless `class` is followed by a whitespace character.\r\n\r\n**What is the new behavior (if this is a feature change)?**\r\nES6 classes are properly detected, even if class is **not** followed by a whitespace character.\r\nE.g. `class{}` or `class/* ... */ {}`.\r\n\r\n**Does this PR introduce a breaking change?**\r\nNo\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] ~~Docs have been added / updated (for bug fixes / features)~~\r\n\r\n**Other information**:\r\nMentioned in https://github.com/angular/angular.js/pull/14531#discussion_r61410683.","created_at":"2016-04-28T12:14:55Z","updated_at":"2016-05-26T16:22:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"935e3622bb9fc8c23237bde2f62aeebf45c5f1ee","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/123","html_url":"https://github.com/angular/angular.js/milestones/1.5.6","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/123/labels","id":1714449,"number":123,"title":"1.5.6","description":"","creator":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":18,"state":"open","created_at":"2016-04-18T17:54:51Z","updated_at":"2016-05-25T11:20:00Z","due_on":"2016-04-24T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/14533/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/14533/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/14533/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/8a647ef3593f8b821fe2c416886b2846bb9b24c1","head":{"label":"gkalpak:fix-injector-fix-class-detection-regexp","ref":"fix-injector-fix-class-detection-regexp","sha":"8a647ef3593f8b821fe2c416886b2846bb9b24c1","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"repo":{"id":23513120,"name":"angular.js","full_name":"gkalpak/angular.js","owner":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkalpak/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/gkalpak/angular.js","forks_url":"https://api.github.com/repos/gkalpak/angular.js/forks","keys_url":"https://api.github.com/repos/gkalpak/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkalpak/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkalpak/angular.js/teams","hooks_url":"https://api.github.com/repos/gkalpak/angular.js/hooks","issue_events_url":"https://api.github.com/repos/gkalpak/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/gkalpak/angular.js/events","assignees_url":"https://api.github.com/repos/gkalpak/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/gkalpak/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/gkalpak/angular.js/tags","blobs_url":"https://api.github.com/repos/gkalpak/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkalpak/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkalpak/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkalpak/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkalpak/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/gkalpak/angular.js/languages","stargazers_url":"https://api.github.com/repos/gkalpak/angular.js/stargazers","contributors_url":"https://api.github.com/repos/gkalpak/angular.js/contributors","subscribers_url":"https://api.github.com/repos/gkalpak/angular.js/subscribers","subscription_url":"https://api.github.com/repos/gkalpak/angular.js/subscription","commits_url":"https://api.github.com/repos/gkalpak/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkalpak/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkalpak/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkalpak/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkalpak/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/gkalpak/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkalpak/angular.js/merges","archive_url":"https://api.github.com/repos/gkalpak/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkalpak/angular.js/downloads","issues_url":"https://api.github.com/repos/gkalpak/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/gkalpak/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/gkalpak/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/gkalpak/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkalpak/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/gkalpak/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/gkalpak/angular.js/deployments","created_at":"2014-08-31T12:31:10Z","updated_at":"2016-01-11T10:14:26Z","pushed_at":"2016-05-25T22:44:17Z","git_url":"git://github.com/gkalpak/angular.js.git","ssh_url":"git@github.com:gkalpak/angular.js.git","clone_url":"https://github.com/gkalpak/angular.js.git","svn_url":"https://github.com/gkalpak/angular.js","homepage":"http://angularjs.org","size":82920,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"707664a3c448732443bf54027dacda39babdd0c4","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular.js/deployments","created_at":"2010-01-06T00:34:37Z","updated_at":"2016-05-26T15:45:26Z","pushed_at":"2016-05-26T16:10:19Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":185863,"stargazers_count":49502,"watchers_count":49502,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23829,"mirror_url":null,"open_issues_count":1089,"forks":23829,"open_issues":1089,"watchers":49502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14533"},"html":{"href":"https://github.com/angular/angular.js/pull/14533"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/14533"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/14533/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14533/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/14533/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/8a647ef3593f8b821fe2c416886b2846bb9b24c1"}}}}
{"actor":{"display_login":"mgol"}}