{"push_id":948664658,"size":2,"distinct_size":2,"ref":"refs/heads/2.3","head":"e8acf9120c15c19ec4d9a7c5304fb87a68cb9245","before":"17ba0afa16b840992eef981e668a6db41bb3c243","commits":[{"sha":"9c84d2946b3dc50201225b20a59623f17f232684","author":{"email":"1d3764b91b902f6b45836e2498da81fe35caf6d6@zalas.pl","name":"Jakub Zalas"},"message":"[HttpKernel] Lookup the response even if the lock was released after 2 seconds","distinct":true,"url":"https://api.github.com/repos/symfony/http-kernel/commits/9c84d2946b3dc50201225b20a59623f17f232684"},{"sha":"e8acf9120c15c19ec4d9a7c5304fb87a68cb9245","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #16274 [HttpKernel] Lookup the response even if the lock was released after two second wait (jakzal)\n\nThis PR was merged into the 2.3 branch.\n\nDiscussion\n----------\n\n[HttpKernel] Lookup the response even if the lock was released after two second wait\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nWhile looking into #15813 I noticed that we [wait for the lock to be released for five seconds, but then only do a lookup if the lock was released in two seconds](https://github.com/symfony/symfony/blob/fa604d3c6f16f264863a42c200391ab996640296/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php#L540-L562), no more.\n\nI think it's worth to make both values the same (so either two or five seconds). I see no reason why we should wait for the lock for five seconds, but then only do a lookup if we waited for two. One way the wait either takes too long, the other way we loose the opportunity to actually return a response.\n\nCommits\n-------\n\n9963170 [HttpKernel] Lookup the response even if the lock was released after 2 seconds","distinct":true,"url":"https://api.github.com/repos/symfony/http-kernel/commits/e8acf9120c15c19ec4d9a7c5304fb87a68cb9245"}]}