{"action":"created","comment":{"url":"https://api.github.com/repos/diacritics/database/pulls/comments/88516079","pull_request_review_id":9088161,"id":88516079,"diff_hunk":"@@ -13,21 +13,27 @@\n             \"properties\": {\n                 \"alphabet\": {\n                     \"type\": \"string\",\n-                    \"minlength\": 4,\n-                    \"maxlength\": 4\n+                    \"pattern\": \"^[A-Z]{1}[a-z]{3}$\"\n                 },\n                 \"continent\": {\n-                    \"type\": \"string\",\n-                    \"minimum\": 4,\n-                    \"maximum\": 4\n+                    \"anyOf\": [{\n+                        \"type\": \"string\",\n+                        \"pattern\": \"^[A-Z]{2}$\"\n+                    }, {\n+                        \"type\": \"array\",\n+                        \"items\": {\n+                            \"type\": \"string\",\n+                            \"pattern\": \"^[A-Z]{2}$\"\n+                        }\n+                    }]\n                 },\n                 \"language\": {\n                     \"type\": \"string\",\n-                    \"minlength\": 1\n+                    \"pattern\": \"^[A-Za-z]+$\"","path":"build/schema.js","position":26,"original_position":26,"commit_id":"ff263805fa930acf113296515ffec0abe111b1a6","original_commit_id":"ff263805fa930acf113296515ffec0abe111b1a6","user":{"login":"julmot","id":8310677,"avatar_url":"https://avatars.githubusercontent.com/u/8310677?v=3","gravatar_id":"","url":"https://api.github.com/users/julmot","html_url":"https://github.com/julmot","followers_url":"https://api.github.com/users/julmot/followers","following_url":"https://api.github.com/users/julmot/following{/other_user}","gists_url":"https://api.github.com/users/julmot/gists{/gist_id}","starred_url":"https://api.github.com/users/julmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julmot/subscriptions","organizations_url":"https://api.github.com/users/julmot/orgs","repos_url":"https://api.github.com/users/julmot/repos","events_url":"https://api.github.com/users/julmot/events{/privacy}","received_events_url":"https://api.github.com/users/julmot/received_events","type":"User","site_admin":false},"body":"Good catch. I've forgot language variants in the API too.\r\n\r\nFor the language variants it may be helpful to have another property that indicates what you've said, e.g. `Mexico` in case of `Spanish`. What do you think? And if you agree, what would be a correct property name?","created_at":"2016-11-17T18:33:13Z","updated_at":"2016-11-17T18:33:13Z","html_url":"https://github.com/diacritics/database/pull/7#discussion_r88516079","pull_request_url":"https://api.github.com/repos/diacritics/database/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/diacritics/database/pulls/comments/88516079"},"html":{"href":"https://github.com/diacritics/database/pull/7#discussion_r88516079"},"pull_request":{"href":"https://api.github.com/repos/diacritics/database/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/diacritics/database/pulls/7","id":94190571,"html_url":"https://github.com/diacritics/database/pull/7","diff_url":"https://github.com/diacritics/database/pull/7.diff","patch_url":"https://github.com/diacritics/database/pull/7.patch","issue_url":"https://api.github.com/repos/diacritics/database/issues/7","number":7,"state":"open","locked":false,"title":"Update schema","user":{"login":"julmot","id":8310677,"avatar_url":"https://avatars.githubusercontent.com/u/8310677?v=3","gravatar_id":"","url":"https://api.github.com/users/julmot","html_url":"https://github.com/julmot","followers_url":"https://api.github.com/users/julmot/followers","following_url":"https://api.github.com/users/julmot/following{/other_user}","gists_url":"https://api.github.com/users/julmot/gists{/gist_id}","starred_url":"https://api.github.com/users/julmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julmot/subscriptions","organizations_url":"https://api.github.com/users/julmot/orgs","repos_url":"https://api.github.com/users/julmot/repos","events_url":"https://api.github.com/users/julmot/events{/privacy}","received_events_url":"https://api.github.com/users/julmot/received_events","type":"User","site_admin":false},"body":"@Mottie Could you please review?","created_at":"2016-11-17T15:37:02Z","updated_at":"2016-11-17T18:33:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4e26a1fec9a59461ce1a09e3b5c4c9adebd1439","assignee":{"login":"julmot","id":8310677,"avatar_url":"https://avatars.githubusercontent.com/u/8310677?v=3","gravatar_id":"","url":"https://api.github.com/users/julmot","html_url":"https://github.com/julmot","followers_url":"https://api.github.com/users/julmot/followers","following_url":"https://api.github.com/users/julmot/following{/other_user}","gists_url":"https://api.github.com/users/julmot/gists{/gist_id}","starred_url":"https://api.github.com/users/julmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julmot/subscriptions","organizations_url":"https://api.github.com/users/julmot/orgs","repos_url":"https://api.github.com/users/julmot/repos","events_url":"https://api.github.com/users/julmot/events{/privacy}","received_events_url":"https://api.github.com/users/julmot/received_events","type":"User","site_admin":false},"assignees":[{"login":"julmot","id":8310677,"avatar_url":"https://avatars.githubusercontent.com/u/8310677?v=3","gravatar_id":"","url":"https://api.github.com/users/julmot","html_url":"https://github.com/julmot","followers_url":"https://api.github.com/users/julmot/followers","following_url":"https://api.github.com/users/julmot/following{/other_user}","gists_url":"https://api.github.com/users/julmot/gists{/gist_id}","starred_url":"https://api.github.com/users/julmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julmot/subscriptions","organizations_url":"https://api.github.com/users/julmot/orgs","repos_url":"https://api.github.com/users/julmot/repos","events_url":"https://api.github.com/users/julmot/events{/privacy}","received_events_url":"https://api.github.com/users/julmot/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/diacritics/database/milestones/1","html_url":"https://github.com/diacritics/database/milestones/Initial","labels_url":"https://api.github.com/repos/diacritics/database/milestones/1/labels","id":2107377,"number":1,"title":"Initial","description":"Completion concept, specification and initial setup","creator":{"login":"julmot","id":8310677,"avatar_url":"https://avatars.githubusercontent.com/u/8310677?v=3","gravatar_id":"","url":"https://api.github.com/users/julmot","html_url":"https://github.com/julmot","followers_url":"https://api.github.com/users/julmot/followers","following_url":"https://api.github.com/users/julmot/following{/other_user}","gists_url":"https://api.github.com/users/julmot/gists{/gist_id}","starred_url":"https://api.github.com/users/julmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julmot/subscriptions","organizations_url":"https://api.github.com/users/julmot/orgs","repos_url":"https://api.github.com/users/julmot/repos","events_url":"https://api.github.com/users/julmot/events{/privacy}","received_events_url":"https://api.github.com/users/julmot/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2016-11-01T17:10:36Z","updated_at":"2016-11-17T15:37:02Z","due_on":"2016-12-31T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/diacritics/database/pulls/7/commits","review_comments_url":"https://api.github.com/repos/diacritics/database/pulls/7/comments","review_comment_url":"https://api.github.com/repos/diacritics/database/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diacritics/database/issues/7/comments","statuses_url":"https://api.github.com/repos/diacritics/database/statuses/ff263805fa930acf113296515ffec0abe111b1a6","head":{"label":"diacritics:schema","ref":"schema","sha":"ff263805fa930acf113296515ffec0abe111b1a6","user":{"login":"diacritics","id":21911793,"avatar_url":"https://avatars.githubusercontent.com/u/21911793?v=3","gravatar_id":"","url":"https://api.github.com/users/diacritics","html_url":"https://github.com/diacritics","followers_url":"https://api.github.com/users/diacritics/followers","following_url":"https://api.github.com/users/diacritics/following{/other_user}","gists_url":"https://api.github.com/users/diacritics/gists{/gist_id}","starred_url":"https://api.github.com/users/diacritics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diacritics/subscriptions","organizations_url":"https://api.github.com/users/diacritics/orgs","repos_url":"https://api.github.com/users/diacritics/repos","events_url":"https://api.github.com/users/diacritics/events{/privacy}","received_events_url":"https://api.github.com/users/diacritics/received_events","type":"Organization","site_admin":false},"repo":{"id":65442313,"name":"database","full_name":"diacritics/database","owner":{"login":"diacritics","id":21911793,"avatar_url":"https://avatars.githubusercontent.com/u/21911793?v=3","gravatar_id":"","url":"https://api.github.com/users/diacritics","html_url":"https://github.com/diacritics","followers_url":"https://api.github.com/users/diacritics/followers","following_url":"https://api.github.com/users/diacritics/following{/other_user}","gists_url":"https://api.github.com/users/diacritics/gists{/gist_id}","starred_url":"https://api.github.com/users/diacritics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diacritics/subscriptions","organizations_url":"https://api.github.com/users/diacritics/orgs","repos_url":"https://api.github.com/users/diacritics/repos","events_url":"https://api.github.com/users/diacritics/events{/privacy}","received_events_url":"https://api.github.com/users/diacritics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diacritics/database","description":"A database to map diacritics with their associated ASCII characters","fork":false,"url":"https://api.github.com/repos/diacritics/database","forks_url":"https://api.github.com/repos/diacritics/database/forks","keys_url":"https://api.github.com/repos/diacritics/database/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diacritics/database/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diacritics/database/teams","hooks_url":"https://api.github.com/repos/diacritics/database/hooks","issue_events_url":"https://api.github.com/repos/diacritics/database/issues/events{/number}","events_url":"https://api.github.com/repos/diacritics/database/events","assignees_url":"https://api.github.com/repos/diacritics/database/assignees{/user}","branches_url":"https://api.github.com/repos/diacritics/database/branches{/branch}","tags_url":"https://api.github.com/repos/diacritics/database/tags","blobs_url":"https://api.github.com/repos/diacritics/database/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diacritics/database/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diacritics/database/git/refs{/sha}","trees_url":"https://api.github.com/repos/diacritics/database/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diacritics/database/statuses/{sha}","languages_url":"https://api.github.com/repos/diacritics/database/languages","stargazers_url":"https://api.github.com/repos/diacritics/database/stargazers","contributors_url":"https://api.github.com/repos/diacritics/database/contributors","subscribers_url":"https://api.github.com/repos/diacritics/database/subscribers","subscription_url":"https://api.github.com/repos/diacritics/database/subscription","commits_url":"https://api.github.com/repos/diacritics/database/commits{/sha}","git_commits_url":"https://api.github.com/repos/diacritics/database/git/commits{/sha}","comments_url":"https://api.github.com/repos/diacritics/database/comments{/number}","issue_comment_url":"https://api.github.com/repos/diacritics/database/issues/comments{/number}","contents_url":"https://api.github.com/repos/diacritics/database/contents/{+path}","compare_url":"https://api.github.com/repos/diacritics/database/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diacritics/database/merges","archive_url":"https://api.github.com/repos/diacritics/database/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diacritics/database/downloads","issues_url":"https://api.github.com/repos/diacritics/database/issues{/number}","pulls_url":"https://api.github.com/repos/diacritics/database/pulls{/number}","milestones_url":"https://api.github.com/repos/diacritics/database/milestones{/number}","notifications_url":"https://api.github.com/repos/diacritics/database/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diacritics/database/labels{/name}","releases_url":"https://api.github.com/repos/diacritics/database/releases{/id}","deployments_url":"https://api.github.com/repos/diacritics/database/deployments","created_at":"2016-08-11T05:52:37Z","updated_at":"2016-11-11T20:31:54Z","pushed_at":"2016-11-17T15:37:02Z","git_url":"git://github.com/diacritics/database.git","ssh_url":"git@github.com:diacritics/database.git","clone_url":"https://github.com/diacritics/database.git","svn_url":"https://github.com/diacritics/database","homepage":"http://diacritics.io/","size":71,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"diacritics:master","ref":"master","sha":"45ace42f09674f7977cb74a125877c8c603ae793","user":{"login":"diacritics","id":21911793,"avatar_url":"https://avatars.githubusercontent.com/u/21911793?v=3","gravatar_id":"","url":"https://api.github.com/users/diacritics","html_url":"https://github.com/diacritics","followers_url":"https://api.github.com/users/diacritics/followers","following_url":"https://api.github.com/users/diacritics/following{/other_user}","gists_url":"https://api.github.com/users/diacritics/gists{/gist_id}","starred_url":"https://api.github.com/users/diacritics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diacritics/subscriptions","organizations_url":"https://api.github.com/users/diacritics/orgs","repos_url":"https://api.github.com/users/diacritics/repos","events_url":"https://api.github.com/users/diacritics/events{/privacy}","received_events_url":"https://api.github.com/users/diacritics/received_events","type":"Organization","site_admin":false},"repo":{"id":65442313,"name":"database","full_name":"diacritics/database","owner":{"login":"diacritics","id":21911793,"avatar_url":"https://avatars.githubusercontent.com/u/21911793?v=3","gravatar_id":"","url":"https://api.github.com/users/diacritics","html_url":"https://github.com/diacritics","followers_url":"https://api.github.com/users/diacritics/followers","following_url":"https://api.github.com/users/diacritics/following{/other_user}","gists_url":"https://api.github.com/users/diacritics/gists{/gist_id}","starred_url":"https://api.github.com/users/diacritics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diacritics/subscriptions","organizations_url":"https://api.github.com/users/diacritics/orgs","repos_url":"https://api.github.com/users/diacritics/repos","events_url":"https://api.github.com/users/diacritics/events{/privacy}","received_events_url":"https://api.github.com/users/diacritics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diacritics/database","description":"A database to map diacritics with their associated ASCII characters","fork":false,"url":"https://api.github.com/repos/diacritics/database","forks_url":"https://api.github.com/repos/diacritics/database/forks","keys_url":"https://api.github.com/repos/diacritics/database/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diacritics/database/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diacritics/database/teams","hooks_url":"https://api.github.com/repos/diacritics/database/hooks","issue_events_url":"https://api.github.com/repos/diacritics/database/issues/events{/number}","events_url":"https://api.github.com/repos/diacritics/database/events","assignees_url":"https://api.github.com/repos/diacritics/database/assignees{/user}","branches_url":"https://api.github.com/repos/diacritics/database/branches{/branch}","tags_url":"https://api.github.com/repos/diacritics/database/tags","blobs_url":"https://api.github.com/repos/diacritics/database/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diacritics/database/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diacritics/database/git/refs{/sha}","trees_url":"https://api.github.com/repos/diacritics/database/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diacritics/database/statuses/{sha}","languages_url":"https://api.github.com/repos/diacritics/database/languages","stargazers_url":"https://api.github.com/repos/diacritics/database/stargazers","contributors_url":"https://api.github.com/repos/diacritics/database/contributors","subscribers_url":"https://api.github.com/repos/diacritics/database/subscribers","subscription_url":"https://api.github.com/repos/diacritics/database/subscription","commits_url":"https://api.github.com/repos/diacritics/database/commits{/sha}","git_commits_url":"https://api.github.com/repos/diacritics/database/git/commits{/sha}","comments_url":"https://api.github.com/repos/diacritics/database/comments{/number}","issue_comment_url":"https://api.github.com/repos/diacritics/database/issues/comments{/number}","contents_url":"https://api.github.com/repos/diacritics/database/contents/{+path}","compare_url":"https://api.github.com/repos/diacritics/database/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diacritics/database/merges","archive_url":"https://api.github.com/repos/diacritics/database/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diacritics/database/downloads","issues_url":"https://api.github.com/repos/diacritics/database/issues{/number}","pulls_url":"https://api.github.com/repos/diacritics/database/pulls{/number}","milestones_url":"https://api.github.com/repos/diacritics/database/milestones{/number}","notifications_url":"https://api.github.com/repos/diacritics/database/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diacritics/database/labels{/name}","releases_url":"https://api.github.com/repos/diacritics/database/releases{/id}","deployments_url":"https://api.github.com/repos/diacritics/database/deployments","created_at":"2016-08-11T05:52:37Z","updated_at":"2016-11-11T20:31:54Z","pushed_at":"2016-11-17T15:37:02Z","git_url":"git://github.com/diacritics/database.git","ssh_url":"git@github.com:diacritics/database.git","clone_url":"https://github.com/diacritics/database.git","svn_url":"https://github.com/diacritics/database","homepage":"http://diacritics.io/","size":71,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diacritics/database/pulls/7"},"html":{"href":"https://github.com/diacritics/database/pull/7"},"issue":{"href":"https://api.github.com/repos/diacritics/database/issues/7"},"comments":{"href":"https://api.github.com/repos/diacritics/database/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/diacritics/database/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/diacritics/database/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diacritics/database/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/diacritics/database/statuses/ff263805fa930acf113296515ffec0abe111b1a6"}}}}
{"actor":{"display_login":"julmot"}}