{"action":"created","comment":{"url":"https://api.github.com/repos/launchdarkly/java-client/pulls/comments/72503029","id":72503029,"diff_hunk":"@@ -51,9 +53,6 @@ static FeatureFlag fromJson(String json) {\n   }\n \n   EvalResult evaluate(LDUser user, FeatureStore featureStore) throws EvaluationException {\n-    if (user == null || user.getKey() == null) {","path":"src/main/java/com/launchdarkly/client/FeatureFlag.java","position":15,"original_position":15,"commit_id":"ef393c7512d85343b2b1250a119cbec37122e026","original_commit_id":"ef393c7512d85343b2b1250a119cbec37122e026","user":{"login":"drichelson","id":602409,"avatar_url":"https://avatars.githubusercontent.com/u/602409?v=3","gravatar_id":"","url":"https://api.github.com/users/drichelson","html_url":"https://github.com/drichelson","followers_url":"https://api.github.com/users/drichelson/followers","following_url":"https://api.github.com/users/drichelson/following{/other_user}","gists_url":"https://api.github.com/users/drichelson/gists{/gist_id}","starred_url":"https://api.github.com/users/drichelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drichelson/subscriptions","organizations_url":"https://api.github.com/users/drichelson/orgs","repos_url":"https://api.github.com/users/drichelson/repos","events_url":"https://api.github.com/users/drichelson/events{/privacy}","received_events_url":"https://api.github.com/users/drichelson/received_events","type":"User","site_admin":false},"body":"I pushed this up into the client code so it happens first thing. This is more consistent with the go client behavior and avoids a call to the feature store.","created_at":"2016-07-27T19:06:43Z","updated_at":"2016-07-27T19:06:43Z","html_url":"https://github.com/launchdarkly/java-client/pull/63#discussion_r72503029","pull_request_url":"https://api.github.com/repos/launchdarkly/java-client/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/launchdarkly/java-client/pulls/comments/72503029"},"html":{"href":"https://github.com/launchdarkly/java-client/pull/63#discussion_r72503029"},"pull_request":{"href":"https://api.github.com/repos/launchdarkly/java-client/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/launchdarkly/java-client/pulls/63","id":79079533,"html_url":"https://github.com/launchdarkly/java-client/pull/63","diff_url":"https://github.com/launchdarkly/java-client/pull/63.diff","patch_url":"https://github.com/launchdarkly/java-client/pull/63.patch","issue_url":"https://api.github.com/repos/launchdarkly/java-client/issues/63","number":63,"state":"open","locked":false,"title":"V2 final polish","user":{"login":"drichelson","id":602409,"avatar_url":"https://avatars.githubusercontent.com/u/602409?v=3","gravatar_id":"","url":"https://api.github.com/users/drichelson","html_url":"https://github.com/drichelson","followers_url":"https://api.github.com/users/drichelson/followers","following_url":"https://api.github.com/users/drichelson/following{/other_user}","gists_url":"https://api.github.com/users/drichelson/gists{/gist_id}","starred_url":"https://api.github.com/users/drichelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drichelson/subscriptions","organizations_url":"https://api.github.com/users/drichelson/orgs","repos_url":"https://api.github.com/users/drichelson/repos","events_url":"https://api.github.com/users/drichelson/events{/privacy}","received_events_url":"https://api.github.com/users/drichelson/received_events","type":"User","site_admin":false},"body":"See https://catamorphic.quip.com/Ggk6AbylpJBf for details. Passes v2 integration harness locally (with version comparison)","created_at":"2016-07-27T19:05:35Z","updated_at":"2016-07-27T19:06:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcb5eab890c3d34391ca86cdcf224e76bdf3bebd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/launchdarkly/java-client/pulls/63/commits","review_comments_url":"https://api.github.com/repos/launchdarkly/java-client/pulls/63/comments","review_comment_url":"https://api.github.com/repos/launchdarkly/java-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/launchdarkly/java-client/issues/63/comments","statuses_url":"https://api.github.com/repos/launchdarkly/java-client/statuses/ef393c7512d85343b2b1250a119cbec37122e026","head":{"label":"launchdarkly:dr/v2polish","ref":"dr/v2polish","sha":"ef393c7512d85343b2b1250a119cbec37122e026","user":{"login":"launchdarkly","id":8039656,"avatar_url":"https://avatars.githubusercontent.com/u/8039656?v=3","gravatar_id":"","url":"https://api.github.com/users/launchdarkly","html_url":"https://github.com/launchdarkly","followers_url":"https://api.github.com/users/launchdarkly/followers","following_url":"https://api.github.com/users/launchdarkly/following{/other_user}","gists_url":"https://api.github.com/users/launchdarkly/gists{/gist_id}","starred_url":"https://api.github.com/users/launchdarkly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/launchdarkly/subscriptions","organizations_url":"https://api.github.com/users/launchdarkly/orgs","repos_url":"https://api.github.com/users/launchdarkly/repos","events_url":"https://api.github.com/users/launchdarkly/events{/privacy}","received_events_url":"https://api.github.com/users/launchdarkly/received_events","type":"Organization","site_admin":false},"repo":{"id":22655271,"name":"java-client","full_name":"launchdarkly/java-client","owner":{"login":"launchdarkly","id":8039656,"avatar_url":"https://avatars.githubusercontent.com/u/8039656?v=3","gravatar_id":"","url":"https://api.github.com/users/launchdarkly","html_url":"https://github.com/launchdarkly","followers_url":"https://api.github.com/users/launchdarkly/followers","following_url":"https://api.github.com/users/launchdarkly/following{/other_user}","gists_url":"https://api.github.com/users/launchdarkly/gists{/gist_id}","starred_url":"https://api.github.com/users/launchdarkly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/launchdarkly/subscriptions","organizations_url":"https://api.github.com/users/launchdarkly/orgs","repos_url":"https://api.github.com/users/launchdarkly/repos","events_url":"https://api.github.com/users/launchdarkly/events{/privacy}","received_events_url":"https://api.github.com/users/launchdarkly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/launchdarkly/java-client","description":"LaunchDarkly SDK for Java","fork":false,"url":"https://api.github.com/repos/launchdarkly/java-client","forks_url":"https://api.github.com/repos/launchdarkly/java-client/forks","keys_url":"https://api.github.com/repos/launchdarkly/java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/launchdarkly/java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/launchdarkly/java-client/teams","hooks_url":"https://api.github.com/repos/launchdarkly/java-client/hooks","issue_events_url":"https://api.github.com/repos/launchdarkly/java-client/issues/events{/number}","events_url":"https://api.github.com/repos/launchdarkly/java-client/events","assignees_url":"https://api.github.com/repos/launchdarkly/java-client/assignees{/user}","branches_url":"https://api.github.com/repos/launchdarkly/java-client/branches{/branch}","tags_url":"https://api.github.com/repos/launchdarkly/java-client/tags","blobs_url":"https://api.github.com/repos/launchdarkly/java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/launchdarkly/java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/launchdarkly/java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/launchdarkly/java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/launchdarkly/java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/launchdarkly/java-client/languages","stargazers_url":"https://api.github.com/repos/launchdarkly/java-client/stargazers","contributors_url":"https://api.github.com/repos/launchdarkly/java-client/contributors","subscribers_url":"https://api.github.com/repos/launchdarkly/java-client/subscribers","subscription_url":"https://api.github.com/repos/launchdarkly/java-client/subscription","commits_url":"https://api.github.com/repos/launchdarkly/java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/launchdarkly/java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/launchdarkly/java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/launchdarkly/java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/launchdarkly/java-client/contents/{+path}","compare_url":"https://api.github.com/repos/launchdarkly/java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/launchdarkly/java-client/merges","archive_url":"https://api.github.com/repos/launchdarkly/java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/launchdarkly/java-client/downloads","issues_url":"https://api.github.com/repos/launchdarkly/java-client/issues{/number}","pulls_url":"https://api.github.com/repos/launchdarkly/java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/launchdarkly/java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/launchdarkly/java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/launchdarkly/java-client/labels{/name}","releases_url":"https://api.github.com/repos/launchdarkly/java-client/releases{/id}","deployments_url":"https://api.github.com/repos/launchdarkly/java-client/deployments","created_at":"2014-08-05T18:47:24Z","updated_at":"2016-03-01T05:43:41Z","pushed_at":"2016-07-27T19:05:36Z","git_url":"git://github.com/launchdarkly/java-client.git","ssh_url":"git@github.com:launchdarkly/java-client.git","clone_url":"https://github.com/launchdarkly/java-client.git","svn_url":"https://github.com/launchdarkly/java-client","homepage":"","size":817,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"launchdarkly:v2","ref":"v2","sha":"0a87431562eef76bd1a319ad19339929ed5c4fa2","user":{"login":"launchdarkly","id":8039656,"avatar_url":"https://avatars.githubusercontent.com/u/8039656?v=3","gravatar_id":"","url":"https://api.github.com/users/launchdarkly","html_url":"https://github.com/launchdarkly","followers_url":"https://api.github.com/users/launchdarkly/followers","following_url":"https://api.github.com/users/launchdarkly/following{/other_user}","gists_url":"https://api.github.com/users/launchdarkly/gists{/gist_id}","starred_url":"https://api.github.com/users/launchdarkly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/launchdarkly/subscriptions","organizations_url":"https://api.github.com/users/launchdarkly/orgs","repos_url":"https://api.github.com/users/launchdarkly/repos","events_url":"https://api.github.com/users/launchdarkly/events{/privacy}","received_events_url":"https://api.github.com/users/launchdarkly/received_events","type":"Organization","site_admin":false},"repo":{"id":22655271,"name":"java-client","full_name":"launchdarkly/java-client","owner":{"login":"launchdarkly","id":8039656,"avatar_url":"https://avatars.githubusercontent.com/u/8039656?v=3","gravatar_id":"","url":"https://api.github.com/users/launchdarkly","html_url":"https://github.com/launchdarkly","followers_url":"https://api.github.com/users/launchdarkly/followers","following_url":"https://api.github.com/users/launchdarkly/following{/other_user}","gists_url":"https://api.github.com/users/launchdarkly/gists{/gist_id}","starred_url":"https://api.github.com/users/launchdarkly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/launchdarkly/subscriptions","organizations_url":"https://api.github.com/users/launchdarkly/orgs","repos_url":"https://api.github.com/users/launchdarkly/repos","events_url":"https://api.github.com/users/launchdarkly/events{/privacy}","received_events_url":"https://api.github.com/users/launchdarkly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/launchdarkly/java-client","description":"LaunchDarkly SDK for Java","fork":false,"url":"https://api.github.com/repos/launchdarkly/java-client","forks_url":"https://api.github.com/repos/launchdarkly/java-client/forks","keys_url":"https://api.github.com/repos/launchdarkly/java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/launchdarkly/java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/launchdarkly/java-client/teams","hooks_url":"https://api.github.com/repos/launchdarkly/java-client/hooks","issue_events_url":"https://api.github.com/repos/launchdarkly/java-client/issues/events{/number}","events_url":"https://api.github.com/repos/launchdarkly/java-client/events","assignees_url":"https://api.github.com/repos/launchdarkly/java-client/assignees{/user}","branches_url":"https://api.github.com/repos/launchdarkly/java-client/branches{/branch}","tags_url":"https://api.github.com/repos/launchdarkly/java-client/tags","blobs_url":"https://api.github.com/repos/launchdarkly/java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/launchdarkly/java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/launchdarkly/java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/launchdarkly/java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/launchdarkly/java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/launchdarkly/java-client/languages","stargazers_url":"https://api.github.com/repos/launchdarkly/java-client/stargazers","contributors_url":"https://api.github.com/repos/launchdarkly/java-client/contributors","subscribers_url":"https://api.github.com/repos/launchdarkly/java-client/subscribers","subscription_url":"https://api.github.com/repos/launchdarkly/java-client/subscription","commits_url":"https://api.github.com/repos/launchdarkly/java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/launchdarkly/java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/launchdarkly/java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/launchdarkly/java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/launchdarkly/java-client/contents/{+path}","compare_url":"https://api.github.com/repos/launchdarkly/java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/launchdarkly/java-client/merges","archive_url":"https://api.github.com/repos/launchdarkly/java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/launchdarkly/java-client/downloads","issues_url":"https://api.github.com/repos/launchdarkly/java-client/issues{/number}","pulls_url":"https://api.github.com/repos/launchdarkly/java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/launchdarkly/java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/launchdarkly/java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/launchdarkly/java-client/labels{/name}","releases_url":"https://api.github.com/repos/launchdarkly/java-client/releases{/id}","deployments_url":"https://api.github.com/repos/launchdarkly/java-client/deployments","created_at":"2014-08-05T18:47:24Z","updated_at":"2016-03-01T05:43:41Z","pushed_at":"2016-07-27T19:05:36Z","git_url":"git://github.com/launchdarkly/java-client.git","ssh_url":"git@github.com:launchdarkly/java-client.git","clone_url":"https://github.com/launchdarkly/java-client.git","svn_url":"https://github.com/launchdarkly/java-client","homepage":"","size":817,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/launchdarkly/java-client/pulls/63"},"html":{"href":"https://github.com/launchdarkly/java-client/pull/63"},"issue":{"href":"https://api.github.com/repos/launchdarkly/java-client/issues/63"},"comments":{"href":"https://api.github.com/repos/launchdarkly/java-client/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/launchdarkly/java-client/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/launchdarkly/java-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/launchdarkly/java-client/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/launchdarkly/java-client/statuses/ef393c7512d85343b2b1250a119cbec37122e026"}}}}
{"actor":{"display_login":"drichelson"}}