{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/components/pulls/comments/91252679","pull_request_review_id":11760164,"id":91252679,"diff_hunk":"@@ -79,8 +79,8 @@ public AllSetting getRuntimeSetting() {\n         setting.setDriverClass(datastoreProperties.getCurrentDriverClass());\n         setting.setJdbcUrl(datastoreProperties.jdbcUrl.getValue());\n \n-        setting.setUsername(datastoreProperties.userId.getValue());\n-        setting.setPassword(datastoreProperties.password.getValue());\n+        setting.setUsername(datastoreProperties.userPassword.userId.getValue());","path":"components-jdbc/src/main/java/org/talend/components/jdbc/dataprep/JDBCInputProperties.java","position":6,"original_position":6,"commit_id":"1c6bab39e8ad9b3d18a0ca036ce81bbb8d9d2ab9","original_commit_id":"1c6bab39e8ad9b3d18a0ca036ce81bbb8d9d2ab9","user":{"login":"bchen-talend","id":7734020,"avatar_url":"https://avatars.githubusercontent.com/u/7734020?v=3","gravatar_id":"","url":"https://api.github.com/users/bchen-talend","html_url":"https://github.com/bchen-talend","followers_url":"https://api.github.com/users/bchen-talend/followers","following_url":"https://api.github.com/users/bchen-talend/following{/other_user}","gists_url":"https://api.github.com/users/bchen-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/bchen-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchen-talend/subscriptions","organizations_url":"https://api.github.com/users/bchen-talend/orgs","repos_url":"https://api.github.com/users/bchen-talend/repos","events_url":"https://api.github.com/users/bchen-talend/events{/privacy}","received_events_url":"https://api.github.com/users/bchen-talend/received_events","type":"User","site_admin":false},"body":"Hi @francisu , independent userId and password added by @wwang-talend for displayName issue, he want to set special displayName in jdbc, seems no way for now to override, is there a way?","created_at":"2016-12-07T09:18:34Z","updated_at":"2016-12-07T09:18:34Z","html_url":"https://github.com/Talend/components/pull/343#discussion_r91252679","pull_request_url":"https://api.github.com/repos/Talend/components/pulls/343","_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/comments/91252679"},"html":{"href":"https://github.com/Talend/components/pull/343#discussion_r91252679"},"pull_request":{"href":"https://api.github.com/repos/Talend/components/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/components/pulls/343","id":95682484,"html_url":"https://github.com/Talend/components/pull/343","diff_url":"https://github.com/Talend/components/pull/343.diff","patch_url":"https://github.com/Talend/components/pull/343.patch","issue_url":"https://api.github.com/repos/Talend/components/issues/343","number":343,"state":"open","locked":false,"title":"feat(TFD-148): add JDBC input/output beam runtime","user":{"login":"bchen-talend","id":7734020,"avatar_url":"https://avatars.githubusercontent.com/u/7734020?v=3","gravatar_id":"","url":"https://api.github.com/users/bchen-talend","html_url":"https://github.com/bchen-talend","followers_url":"https://api.github.com/users/bchen-talend/followers","following_url":"https://api.github.com/users/bchen-talend/following{/other_user}","gists_url":"https://api.github.com/users/bchen-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/bchen-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchen-talend/subscriptions","organizations_url":"https://api.github.com/users/bchen-talend/orgs","repos_url":"https://api.github.com/users/bchen-talend/repos","events_url":"https://api.github.com/users/bchen-talend/events{/privacy}","received_events_url":"https://api.github.com/users/bchen-talend/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n- [x] The commit message follows Talend standard\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\nhttps://jira.talendforge.org/browse/TFD-148\r\n\r\n\r\n**What is the new behavior?**\r\nAdd beam runtime for jdbc input component\r\nAdd jdbc output component based on datastore/dataset, and runtime\r\nAdd table name in dataset, which for jdbc output component\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [x] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\nAs the jdbc dataset reused for DataPrep team, need to check with them about the change, I have wrote comment on the relate [jira](https://jira.talendforge.org/browse/TDI-37885?focusedCommentId=450132&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-450132)\r\n","created_at":"2016-11-29T12:27:06Z","updated_at":"2016-12-07T09:18:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe6a796e4824d7d4a02c23a15dac9c2150540e3c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/components/pulls/343/commits","review_comments_url":"https://api.github.com/repos/Talend/components/pulls/343/comments","review_comment_url":"https://api.github.com/repos/Talend/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/components/issues/343/comments","statuses_url":"https://api.github.com/repos/Talend/components/statuses/1c6bab39e8ad9b3d18a0ca036ce81bbb8d9d2ab9","head":{"label":"Talend:feature/TFD-148-jdbc","ref":"feature/TFD-148-jdbc","sha":"1c6bab39e8ad9b3d18a0ca036ce81bbb8d9d2ab9","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2016-11-14T15:37:02Z","pushed_at":"2016-12-07T08:10:25Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":8353,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":11,"forks":19,"open_issues":11,"watchers":7,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"a94df2578a42145eb461f15422c8a1c9f1f1ec8e","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2016-11-14T15:37:02Z","pushed_at":"2016-12-07T08:10:25Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":8353,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":11,"forks":19,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/343"},"html":{"href":"https://github.com/Talend/components/pull/343"},"issue":{"href":"https://api.github.com/repos/Talend/components/issues/343"},"comments":{"href":"https://api.github.com/repos/Talend/components/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/components/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/components/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/components/statuses/1c6bab39e8ad9b3d18a0ca036ce81bbb8d9d2ab9"}}}}
{"actor":{"display_login":"bchen-talend"}}