{"action":"created","issue":{"url":"https://api.github.com/repos/cobrateam/splinter/issues/509","repository_url":"https://api.github.com/repos/cobrateam/splinter","labels_url":"https://api.github.com/repos/cobrateam/splinter/issues/509/labels{/name}","comments_url":"https://api.github.com/repos/cobrateam/splinter/issues/509/comments","events_url":"https://api.github.com/repos/cobrateam/splinter/issues/509/events","html_url":"https://github.com/cobrateam/splinter/issues/509","id":173372722,"number":509,"title":"status_code is only ever 200 - OK.","user":{"login":"lexual","id":410907,"avatar_url":"https://avatars.githubusercontent.com/u/410907?v=3","gravatar_id":"","url":"https://api.github.com/users/lexual","html_url":"https://github.com/lexual","followers_url":"https://api.github.com/users/lexual/followers","following_url":"https://api.github.com/users/lexual/following{/other_user}","gists_url":"https://api.github.com/users/lexual/gists{/gist_id}","starred_url":"https://api.github.com/users/lexual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexual/subscriptions","organizations_url":"https://api.github.com/users/lexual/orgs","repos_url":"https://api.github.com/users/lexual/repos","events_url":"https://api.github.com/users/lexual/events{/privacy}","received_events_url":"https://api.github.com/users/lexual/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cobrateam/splinter/labels/bug","name":"bug","color":"ed1313"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-26T05:27:29Z","updated_at":"2016-09-12T11:37:58Z","closed_at":null,"body":"See attached testcase.\r\n\r\nA status_code of 200 seems to be hard-coded since this commit?\r\n\r\nhttps://github.com/cobrateam/splinter/commit/d151c565c1068c6f0ac3f09ff010353b9b1a9de2\r\n\r\n```\r\nimport splinter\r\n\r\nwith splinter.Browser('firefox') as browser:\r\n    # should be 200\r\n    browser.visit('http://google.com')\r\n    print(browser.status_code.code)\r\n    print(browser.status_code.is_success())\r\n\r\n    browser.visit('http://google.com/is_this_a_bug')\r\n    print(browser.status_code.code)\r\n    print(browser.status_code.is_success())\r\n\r\n    browser.visit('http://github.com/is_this_a_bug/is_this_a_bug_project')\r\n    print(browser.status_code.code)\r\n    print(browser.status_code.is_success())\r\n\r\n    browser.visit('http://this_domain_doesnt_even_exist.coma')\r\n    print(browser.status_code.code)\r\n    print(browser.status_code.is_success())\r\n```\r\n\r\nGives this output:\r\n\r\n```\r\n$ python ./testcase.py \r\n200\r\nTrue\r\n200\r\nTrue\r\n200\r\nTrue\r\n200\r\nTrue\r\n```\r\n\r\nThis should be returning 404 for all but the 1st example."},"comment":{"url":"https://api.github.com/repos/cobrateam/splinter/issues/comments/246321672","html_url":"https://github.com/cobrateam/splinter/issues/509#issuecomment-246321672","issue_url":"https://api.github.com/repos/cobrateam/splinter/issues/509","id":246321672,"user":{"login":"samuelcolvin","id":4039449,"avatar_url":"https://avatars.githubusercontent.com/u/4039449?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelcolvin","html_url":"https://github.com/samuelcolvin","followers_url":"https://api.github.com/users/samuelcolvin/followers","following_url":"https://api.github.com/users/samuelcolvin/following{/other_user}","gists_url":"https://api.github.com/users/samuelcolvin/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelcolvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelcolvin/subscriptions","organizations_url":"https://api.github.com/users/samuelcolvin/orgs","repos_url":"https://api.github.com/users/samuelcolvin/repos","events_url":"https://api.github.com/users/samuelcolvin/events{/privacy}","received_events_url":"https://api.github.com/users/samuelcolvin/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T11:37:58Z","updated_at":"2016-09-12T11:37:58Z","body":"Do we have an update on when this is going to be fixed? \r\n\r\nFor me this is about the most serious issue imaginable with splinter: the primary test of server response is incorrect such that tests are likely to pass when they should fail! \r\n\r\n:ghost: :scream: :imp: :hankey: :bug: :japanese_ogre: :no_good:"}}
{"actor":{"display_login":"samuelcolvin"}}