{"action":"created","comment":{"url":"https://api.github.com/repos/containers/image/pulls/comments/78387355","id":78387355,"diff_hunk":"@@ -127,13 +128,13 @@ func createManifest(m []byte) ([]byte, string, error) {\n \t\t}\n \t\treturn b, om.MediaType, nil\n \tcase manifest.DockerV2ListMediaType:\n-\t\treturn nil, \"\", fmt.Errorf(\"can't create OCI manifest from Docker V2 schema 2 manifest list\")\n+\t\treturn nil, \"\", errors.New(\"can't create an OCI manifest from Docker V2 schema 2 manifest list\")\n \tcase imgspecv1.MediaTypeImageManifestList:\n-\t\treturn nil, \"\", fmt.Errorf(\"can't create OCI manifest from OCI manifest list\")\n+\t\treturn nil, \"\", errors.New(\"can't create an OCI manifest from OCI manifest list\")\n \tcase imgspecv1.MediaTypeImageManifest:\n \t\treturn m, mt, nil\n \t}\n-\treturn nil, \"\", fmt.Errorf(\"Unrecognized manifest media type: %q\", mt)\n+\treturn nil, \"\", errors.New(\"unrecognized manifest media type\")","path":"oci/layout/oci_dest.go","position":36,"original_position":36,"commit_id":"38f9a6b2d3429e3d6497b4de0fe344a32492b23d","original_commit_id":"38f9a6b2d3429e3d6497b4de0fe344a32492b23d","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"body":"nevermind, fixing","created_at":"2016-09-12T14:49:48Z","updated_at":"2016-09-12T14:49:48Z","html_url":"https://github.com/containers/image/pull/84#discussion_r78387355","pull_request_url":"https://api.github.com/repos/containers/image/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/containers/image/pulls/comments/78387355"},"html":{"href":"https://github.com/containers/image/pull/84#discussion_r78387355"},"pull_request":{"href":"https://api.github.com/repos/containers/image/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/containers/image/pulls/84","id":84883266,"html_url":"https://github.com/containers/image/pull/84","diff_url":"https://github.com/containers/image/pull/84.diff","patch_url":"https://github.com/containers/image/pull/84.patch","issue_url":"https://api.github.com/repos/containers/image/issues/84","number":84,"state":"open","locked":false,"title":"Signed v2s1 oci skip","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"body":"alright @mtrmac this should be the right fix for projectatomic/skopeo#198 - note that `GuessManifestMIMEType cannot actually return a meaningful string to be printed when the mime type isn't recognized so - we may just debug print the manifest.","created_at":"2016-09-12T14:39:52Z","updated_at":"2016-09-12T14:49:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dd2293566b51dc925917a702fa05a691146597c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/containers/image/pulls/84/commits","review_comments_url":"https://api.github.com/repos/containers/image/pulls/84/comments","review_comment_url":"https://api.github.com/repos/containers/image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containers/image/issues/84/comments","statuses_url":"https://api.github.com/repos/containers/image/statuses/38f9a6b2d3429e3d6497b4de0fe344a32492b23d","head":{"label":"runcom:signed-v2s1-oci-skip","ref":"signed-v2s1-oci-skip","sha":"38f9a6b2d3429e3d6497b4de0fe344a32492b23d","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"repo":{"id":62058436,"name":"image","full_name":"runcom/image","owner":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runcom/image","description":null,"fork":true,"url":"https://api.github.com/repos/runcom/image","forks_url":"https://api.github.com/repos/runcom/image/forks","keys_url":"https://api.github.com/repos/runcom/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runcom/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runcom/image/teams","hooks_url":"https://api.github.com/repos/runcom/image/hooks","issue_events_url":"https://api.github.com/repos/runcom/image/issues/events{/number}","events_url":"https://api.github.com/repos/runcom/image/events","assignees_url":"https://api.github.com/repos/runcom/image/assignees{/user}","branches_url":"https://api.github.com/repos/runcom/image/branches{/branch}","tags_url":"https://api.github.com/repos/runcom/image/tags","blobs_url":"https://api.github.com/repos/runcom/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runcom/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runcom/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/runcom/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runcom/image/statuses/{sha}","languages_url":"https://api.github.com/repos/runcom/image/languages","stargazers_url":"https://api.github.com/repos/runcom/image/stargazers","contributors_url":"https://api.github.com/repos/runcom/image/contributors","subscribers_url":"https://api.github.com/repos/runcom/image/subscribers","subscription_url":"https://api.github.com/repos/runcom/image/subscription","commits_url":"https://api.github.com/repos/runcom/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/runcom/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/runcom/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/runcom/image/issues/comments{/number}","contents_url":"https://api.github.com/repos/runcom/image/contents/{+path}","compare_url":"https://api.github.com/repos/runcom/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runcom/image/merges","archive_url":"https://api.github.com/repos/runcom/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runcom/image/downloads","issues_url":"https://api.github.com/repos/runcom/image/issues{/number}","pulls_url":"https://api.github.com/repos/runcom/image/pulls{/number}","milestones_url":"https://api.github.com/repos/runcom/image/milestones{/number}","notifications_url":"https://api.github.com/repos/runcom/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runcom/image/labels{/name}","releases_url":"https://api.github.com/repos/runcom/image/releases{/id}","deployments_url":"https://api.github.com/repos/runcom/image/deployments","created_at":"2016-06-27T13:31:58Z","updated_at":"2016-06-27T13:31:59Z","pushed_at":"2016-09-12T14:38:57Z","git_url":"git://github.com/runcom/image.git","ssh_url":"git@github.com:runcom/image.git","clone_url":"https://github.com/runcom/image.git","svn_url":"https://github.com/runcom/image","homepage":null,"size":1918,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containers:master","ref":"master","sha":"9c223749f96da8942b04e15a32b61319cdc6aee8","user":{"login":"containers","id":5874934,"avatar_url":"https://avatars.githubusercontent.com/u/5874934?v=3","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"repo":{"id":61739430,"name":"image","full_name":"containers/image","owner":{"login":"containers","id":5874934,"avatar_url":"https://avatars.githubusercontent.com/u/5874934?v=3","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containers/image","description":"Work with containers' images","fork":false,"url":"https://api.github.com/repos/containers/image","forks_url":"https://api.github.com/repos/containers/image/forks","keys_url":"https://api.github.com/repos/containers/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containers/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containers/image/teams","hooks_url":"https://api.github.com/repos/containers/image/hooks","issue_events_url":"https://api.github.com/repos/containers/image/issues/events{/number}","events_url":"https://api.github.com/repos/containers/image/events","assignees_url":"https://api.github.com/repos/containers/image/assignees{/user}","branches_url":"https://api.github.com/repos/containers/image/branches{/branch}","tags_url":"https://api.github.com/repos/containers/image/tags","blobs_url":"https://api.github.com/repos/containers/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containers/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containers/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/containers/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containers/image/statuses/{sha}","languages_url":"https://api.github.com/repos/containers/image/languages","stargazers_url":"https://api.github.com/repos/containers/image/stargazers","contributors_url":"https://api.github.com/repos/containers/image/contributors","subscribers_url":"https://api.github.com/repos/containers/image/subscribers","subscription_url":"https://api.github.com/repos/containers/image/subscription","commits_url":"https://api.github.com/repos/containers/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/containers/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/containers/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/containers/image/issues/comments{/number}","contents_url":"https://api.github.com/repos/containers/image/contents/{+path}","compare_url":"https://api.github.com/repos/containers/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containers/image/merges","archive_url":"https://api.github.com/repos/containers/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containers/image/downloads","issues_url":"https://api.github.com/repos/containers/image/issues{/number}","pulls_url":"https://api.github.com/repos/containers/image/pulls{/number}","milestones_url":"https://api.github.com/repos/containers/image/milestones{/number}","notifications_url":"https://api.github.com/repos/containers/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containers/image/labels{/name}","releases_url":"https://api.github.com/repos/containers/image/releases{/id}","deployments_url":"https://api.github.com/repos/containers/image/deployments","created_at":"2016-06-22T17:46:41Z","updated_at":"2016-09-08T11:16:28Z","pushed_at":"2016-09-12T14:39:52Z","git_url":"git://github.com/containers/image.git","ssh_url":"git@github.com:containers/image.git","clone_url":"https://github.com/containers/image.git","svn_url":"https://github.com/containers/image","homepage":"","size":1954,"stargazers_count":23,"watchers_count":23,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":21,"forks":11,"open_issues":21,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containers/image/pulls/84"},"html":{"href":"https://github.com/containers/image/pull/84"},"issue":{"href":"https://api.github.com/repos/containers/image/issues/84"},"comments":{"href":"https://api.github.com/repos/containers/image/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/containers/image/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/containers/image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containers/image/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/containers/image/statuses/38f9a6b2d3429e3d6497b4de0fe344a32492b23d"}}}}
{"actor":{"display_login":"runcom"}}