{"action":"created","comment":{"url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/comments/60850255","id":60850255,"diff_hunk":"@@ -4,3 +4,4 @@\n \n obj-m\t\t\t\t\t+= bal.o\n ccflags-y := -I$(src)/include\n+EXTRA_CFLAGS += -Wno-error=date-time","path":"bal/Makefile","position":4,"original_position":4,"commit_id":"7ff31579667912be89f6b2d26da512fb9b412a8c","original_commit_id":"7ff31579667912be89f6b2d26da512fb9b412a8c","user":{"login":"PavolCelko","id":5708729,"avatar_url":"https://avatars.githubusercontent.com/u/5708729?v=3","gravatar_id":"","url":"https://api.github.com/users/PavolCelko","html_url":"https://github.com/PavolCelko","followers_url":"https://api.github.com/users/PavolCelko/followers","following_url":"https://api.github.com/users/PavolCelko/following{/other_user}","gists_url":"https://api.github.com/users/PavolCelko/gists{/gist_id}","starred_url":"https://api.github.com/users/PavolCelko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavolCelko/subscriptions","organizations_url":"https://api.github.com/users/PavolCelko/orgs","repos_url":"https://api.github.com/users/PavolCelko/repos","events_url":"https://api.github.com/users/PavolCelko/events{/privacy}","received_events_url":"https://api.github.com/users/PavolCelko/received_events","type":"User","site_admin":false},"body":"This laine makes that usage of the __TIME__ macro returns warning in commpilation istead error.\r\nThe __TIME__ was used for debugging, to be sure which BAL module was inserted. The line will be removed from the Makefile.","created_at":"2016-04-24T19:24:50Z","updated_at":"2016-04-24T19:24:50Z","html_url":"https://github.com/christianeisendle/nxprdlib-kernel-bal/pull/8#discussion_r60850255","pull_request_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/comments/60850255"},"html":{"href":"https://github.com/christianeisendle/nxprdlib-kernel-bal/pull/8#discussion_r60850255"},"pull_request":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/8","id":67498864,"html_url":"https://github.com/christianeisendle/nxprdlib-kernel-bal/pull/8","diff_url":"https://github.com/christianeisendle/nxprdlib-kernel-bal/pull/8.diff","patch_url":"https://github.com/christianeisendle/nxprdlib-kernel-bal/pull/8.patch","issue_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/issues/8","number":8,"state":"closed","locked":false,"title":"BAL kernel module - support for RC663 and PN512","user":{"login":"PavolCelko","id":5708729,"avatar_url":"https://avatars.githubusercontent.com/u/5708729?v=3","gravatar_id":"","url":"https://api.github.com/users/PavolCelko","html_url":"https://github.com/PavolCelko","followers_url":"https://api.github.com/users/PavolCelko/followers","following_url":"https://api.github.com/users/PavolCelko/following{/other_user}","gists_url":"https://api.github.com/users/PavolCelko/gists{/gist_id}","starred_url":"https://api.github.com/users/PavolCelko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavolCelko/subscriptions","organizations_url":"https://api.github.com/users/PavolCelko/orgs","repos_url":"https://api.github.com/users/PavolCelko/repos","events_url":"https://api.github.com/users/PavolCelko/events{/privacy}","received_events_url":"https://api.github.com/users/PavolCelko/received_events","type":"User","site_admin":false},"body":"Christian, please do a review of the code.\r\nI tested the module with the nine Examples and it worked.\r\n\r\nThese is an issue with the baldev_ioctl. It does not accept 2 as second (cmd) argument. Can you look at it?\r\n\r\nAnother issue is, I do not know how to #include symbols  like PHBAL_REG_CONFIG_HAL_HW_TYPE from phbalReg.h to the BAL sources. So for now there are hardcoded numbers in the baldev_ioctl().\r\n\r\nPavol","created_at":"2016-04-22T11:44:30Z","updated_at":"2016-04-24T19:24:50Z","closed_at":"2016-04-23T18:42:20Z","merged_at":null,"merge_commit_sha":"688a1c5f50fedede2c49ed7475a787327e432792","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/8/commits","review_comments_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/8/comments","review_comment_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/issues/8/comments","statuses_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/statuses/7ff31579667912be89f6b2d26da512fb9b412a8c","head":{"label":"PavolCelko:master","ref":"master","sha":"7ff31579667912be89f6b2d26da512fb9b412a8c","user":{"login":"PavolCelko","id":5708729,"avatar_url":"https://avatars.githubusercontent.com/u/5708729?v=3","gravatar_id":"","url":"https://api.github.com/users/PavolCelko","html_url":"https://github.com/PavolCelko","followers_url":"https://api.github.com/users/PavolCelko/followers","following_url":"https://api.github.com/users/PavolCelko/following{/other_user}","gists_url":"https://api.github.com/users/PavolCelko/gists{/gist_id}","starred_url":"https://api.github.com/users/PavolCelko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavolCelko/subscriptions","organizations_url":"https://api.github.com/users/PavolCelko/orgs","repos_url":"https://api.github.com/users/PavolCelko/repos","events_url":"https://api.github.com/users/PavolCelko/events{/privacy}","received_events_url":"https://api.github.com/users/PavolCelko/received_events","type":"User","site_admin":false},"repo":{"id":56320182,"name":"nxprdlib-kernel-bal","full_name":"PavolCelko/nxprdlib-kernel-bal","owner":{"login":"PavolCelko","id":5708729,"avatar_url":"https://avatars.githubusercontent.com/u/5708729?v=3","gravatar_id":"","url":"https://api.github.com/users/PavolCelko","html_url":"https://github.com/PavolCelko","followers_url":"https://api.github.com/users/PavolCelko/followers","following_url":"https://api.github.com/users/PavolCelko/following{/other_user}","gists_url":"https://api.github.com/users/PavolCelko/gists{/gist_id}","starred_url":"https://api.github.com/users/PavolCelko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavolCelko/subscriptions","organizations_url":"https://api.github.com/users/PavolCelko/orgs","repos_url":"https://api.github.com/users/PavolCelko/repos","events_url":"https://api.github.com/users/PavolCelko/events{/privacy}","received_events_url":"https://api.github.com/users/PavolCelko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PavolCelko/nxprdlib-kernel-bal","description":"NXP NFCRdLib Kernel BAL Module","fork":true,"url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal","forks_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/forks","keys_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/teams","hooks_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/hooks","issue_events_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/issues/events{/number}","events_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/events","assignees_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/assignees{/user}","branches_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/branches{/branch}","tags_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/tags","blobs_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/git/refs{/sha}","trees_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/statuses/{sha}","languages_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/languages","stargazers_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/stargazers","contributors_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/contributors","subscribers_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/subscribers","subscription_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/subscription","commits_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/commits{/sha}","git_commits_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/git/commits{/sha}","comments_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/comments{/number}","issue_comment_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/issues/comments{/number}","contents_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/contents/{+path}","compare_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/merges","archive_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/downloads","issues_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/issues{/number}","pulls_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/pulls{/number}","milestones_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/milestones{/number}","notifications_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/labels{/name}","releases_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/releases{/id}","deployments_url":"https://api.github.com/repos/PavolCelko/nxprdlib-kernel-bal/deployments","created_at":"2016-04-15T12:56:27Z","updated_at":"2016-04-15T12:56:28Z","pushed_at":"2016-04-22T09:57:07Z","git_url":"git://github.com/PavolCelko/nxprdlib-kernel-bal.git","ssh_url":"git@github.com:PavolCelko/nxprdlib-kernel-bal.git","clone_url":"https://github.com/PavolCelko/nxprdlib-kernel-bal.git","svn_url":"https://github.com/PavolCelko/nxprdlib-kernel-bal","homepage":null,"size":32,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"christianeisendle:master","ref":"master","sha":"06d25d5fafdfbbf6c4cb8db4f5069824a3b39457","user":{"login":"christianeisendle","id":13840934,"avatar_url":"https://avatars.githubusercontent.com/u/13840934?v=3","gravatar_id":"","url":"https://api.github.com/users/christianeisendle","html_url":"https://github.com/christianeisendle","followers_url":"https://api.github.com/users/christianeisendle/followers","following_url":"https://api.github.com/users/christianeisendle/following{/other_user}","gists_url":"https://api.github.com/users/christianeisendle/gists{/gist_id}","starred_url":"https://api.github.com/users/christianeisendle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianeisendle/subscriptions","organizations_url":"https://api.github.com/users/christianeisendle/orgs","repos_url":"https://api.github.com/users/christianeisendle/repos","events_url":"https://api.github.com/users/christianeisendle/events{/privacy}","received_events_url":"https://api.github.com/users/christianeisendle/received_events","type":"User","site_admin":false},"repo":{"id":53974021,"name":"nxprdlib-kernel-bal","full_name":"christianeisendle/nxprdlib-kernel-bal","owner":{"login":"christianeisendle","id":13840934,"avatar_url":"https://avatars.githubusercontent.com/u/13840934?v=3","gravatar_id":"","url":"https://api.github.com/users/christianeisendle","html_url":"https://github.com/christianeisendle","followers_url":"https://api.github.com/users/christianeisendle/followers","following_url":"https://api.github.com/users/christianeisendle/following{/other_user}","gists_url":"https://api.github.com/users/christianeisendle/gists{/gist_id}","starred_url":"https://api.github.com/users/christianeisendle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianeisendle/subscriptions","organizations_url":"https://api.github.com/users/christianeisendle/orgs","repos_url":"https://api.github.com/users/christianeisendle/repos","events_url":"https://api.github.com/users/christianeisendle/events{/privacy}","received_events_url":"https://api.github.com/users/christianeisendle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christianeisendle/nxprdlib-kernel-bal","description":"NXP NFCRdLib Kernel BAL Module","fork":false,"url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal","forks_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/forks","keys_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/teams","hooks_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/hooks","issue_events_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/issues/events{/number}","events_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/events","assignees_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/assignees{/user}","branches_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/branches{/branch}","tags_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/tags","blobs_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/git/refs{/sha}","trees_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/statuses/{sha}","languages_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/languages","stargazers_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/stargazers","contributors_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/contributors","subscribers_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/subscribers","subscription_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/subscription","commits_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/commits{/sha}","git_commits_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/git/commits{/sha}","comments_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/comments{/number}","issue_comment_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/issues/comments{/number}","contents_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/contents/{+path}","compare_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/merges","archive_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/downloads","issues_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/issues{/number}","pulls_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls{/number}","milestones_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/milestones{/number}","notifications_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/labels{/name}","releases_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/releases{/id}","deployments_url":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/deployments","created_at":"2016-03-15T19:52:53Z","updated_at":"2016-03-15T20:09:06Z","pushed_at":"2016-04-23T19:13:40Z","git_url":"git://github.com/christianeisendle/nxprdlib-kernel-bal.git","ssh_url":"git@github.com:christianeisendle/nxprdlib-kernel-bal.git","clone_url":"https://github.com/christianeisendle/nxprdlib-kernel-bal.git","svn_url":"https://github.com/christianeisendle/nxprdlib-kernel-bal","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/8"},"html":{"href":"https://github.com/christianeisendle/nxprdlib-kernel-bal/pull/8"},"issue":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/issues/8"},"comments":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/christianeisendle/nxprdlib-kernel-bal/statuses/7ff31579667912be89f6b2d26da512fb9b412a8c"}}}}