{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jigasi/pulls/comments/65807412","id":65807412,"diff_hunk":"@@ -122,6 +122,16 @@ public void start(BundleContext bundleContext)\n         ConfigurationService config\n             = ServiceUtils.getService(\n                     bundleContext, ConfigurationService.class);\n+        \n+        Boolean always_trust_mode = config.getBoolean(\n+                \"net.java.sip.communicator.service.gui.ALWAYS_TRUST_MODE_ENABLED\",false);","path":"src/main/java/org/jitsi/jigasi/xmpp/CallControlComponent.java","position":6,"original_position":6,"commit_id":"50a1211bd086221b6e7b6d6446b1fd4d736d173c","original_commit_id":"50a1211bd086221b6e7b6d6446b1fd4d736d173c","user":{"login":"ibauersachs","id":949783,"avatar_url":"https://avatars.githubusercontent.com/u/949783?v=3","gravatar_id":"","url":"https://api.github.com/users/ibauersachs","html_url":"https://github.com/ibauersachs","followers_url":"https://api.github.com/users/ibauersachs/followers","following_url":"https://api.github.com/users/ibauersachs/following{/other_user}","gists_url":"https://api.github.com/users/ibauersachs/gists{/gist_id}","starred_url":"https://api.github.com/users/ibauersachs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibauersachs/subscriptions","organizations_url":"https://api.github.com/users/ibauersachs/orgs","repos_url":"https://api.github.com/users/ibauersachs/repos","events_url":"https://api.github.com/users/ibauersachs/events{/privacy}","received_events_url":"https://api.github.com/users/ibauersachs/received_events","type":"User","site_admin":false},"body":"@damencho I strongly disagree with that. The default should be secure. If someone needs to connect with TLS insecurely, he should have the option to set that.","created_at":"2016-06-04T20:42:09Z","updated_at":"2016-06-04T20:42:09Z","html_url":"https://github.com/jitsi/jigasi/pull/35#discussion_r65807412","pull_request_url":"https://api.github.com/repos/jitsi/jigasi/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/comments/65807412"},"html":{"href":"https://github.com/jitsi/jigasi/pull/35#discussion_r65807412"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/jigasi/pulls/35","id":72608941,"html_url":"https://github.com/jitsi/jigasi/pull/35","diff_url":"https://github.com/jitsi/jigasi/pull/35.diff","patch_url":"https://github.com/jitsi/jigasi/pull/35.patch","issue_url":"https://api.github.com/repos/jitsi/jigasi/issues/35","number":35,"state":"open","locked":false,"title":"net.java.sip.communicator.service.gui.ALWAYS_TRUST_MODE_ENABLED is se…","user":{"login":"psaavedra","id":376838,"avatar_url":"https://avatars.githubusercontent.com/u/376838?v=3","gravatar_id":"","url":"https://api.github.com/users/psaavedra","html_url":"https://github.com/psaavedra","followers_url":"https://api.github.com/users/psaavedra/followers","following_url":"https://api.github.com/users/psaavedra/following{/other_user}","gists_url":"https://api.github.com/users/psaavedra/gists{/gist_id}","starred_url":"https://api.github.com/users/psaavedra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psaavedra/subscriptions","organizations_url":"https://api.github.com/users/psaavedra/orgs","repos_url":"https://api.github.com/users/psaavedra/repos","events_url":"https://api.github.com/users/psaavedra/events{/privacy}","received_events_url":"https://api.github.com/users/psaavedra/received_events","type":"User","site_admin":false},"body":"net.java.sip.communicator.service.gui.ALWAYS_TRUST_MODE_ENABLED is set in sip-communicator.properties\r\n\r\nI could suggest this trivial change in the jigasi code as consequence of the topic discussed on this thread: http://lists.jitsi.org/pipermail/users/2016-June/011191.html (http://lists.jitsi.org/pipermail/users/2016-June/thread.html#11191)\r\n\r\nThe reason: move the configuration of  the ALWAYS_TRUST_MODE_ENABLED property to the sip-communicator.properties, so as sysadmin you can take the decision of trust or not in all the certificates. By default, I considered the ALWAYS_TRUST_MODE_ENABLED=false as a more secure option in order to prevent MiM attacks.","created_at":"2016-06-04T18:12:57Z","updated_at":"2016-06-04T20:42:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e86528d9281205f426dd6b0b61704f493d763513","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jigasi/pulls/35/commits","review_comments_url":"https://api.github.com/repos/jitsi/jigasi/pulls/35/comments","review_comment_url":"https://api.github.com/repos/jitsi/jigasi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jigasi/issues/35/comments","statuses_url":"https://api.github.com/repos/jitsi/jigasi/statuses/50a1211bd086221b6e7b6d6446b1fd4d736d173c","head":{"label":"psaavedra:master","ref":"master","sha":"50a1211bd086221b6e7b6d6446b1fd4d736d173c","user":{"login":"psaavedra","id":376838,"avatar_url":"https://avatars.githubusercontent.com/u/376838?v=3","gravatar_id":"","url":"https://api.github.com/users/psaavedra","html_url":"https://github.com/psaavedra","followers_url":"https://api.github.com/users/psaavedra/followers","following_url":"https://api.github.com/users/psaavedra/following{/other_user}","gists_url":"https://api.github.com/users/psaavedra/gists{/gist_id}","starred_url":"https://api.github.com/users/psaavedra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psaavedra/subscriptions","organizations_url":"https://api.github.com/users/psaavedra/orgs","repos_url":"https://api.github.com/users/psaavedra/repos","events_url":"https://api.github.com/users/psaavedra/events{/privacy}","received_events_url":"https://api.github.com/users/psaavedra/received_events","type":"User","site_admin":false},"repo":{"id":60400956,"name":"jigasi","full_name":"psaavedra/jigasi","owner":{"login":"psaavedra","id":376838,"avatar_url":"https://avatars.githubusercontent.com/u/376838?v=3","gravatar_id":"","url":"https://api.github.com/users/psaavedra","html_url":"https://github.com/psaavedra","followers_url":"https://api.github.com/users/psaavedra/followers","following_url":"https://api.github.com/users/psaavedra/following{/other_user}","gists_url":"https://api.github.com/users/psaavedra/gists{/gist_id}","starred_url":"https://api.github.com/users/psaavedra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psaavedra/subscriptions","organizations_url":"https://api.github.com/users/psaavedra/orgs","repos_url":"https://api.github.com/users/psaavedra/repos","events_url":"https://api.github.com/users/psaavedra/events{/privacy}","received_events_url":"https://api.github.com/users/psaavedra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psaavedra/jigasi","description":"JItsi GAteway to SIP : a server-side application that links allows regular SIP clients to join JitMeet conferences hosted by Jitsi Videobridge.","fork":true,"url":"https://api.github.com/repos/psaavedra/jigasi","forks_url":"https://api.github.com/repos/psaavedra/jigasi/forks","keys_url":"https://api.github.com/repos/psaavedra/jigasi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psaavedra/jigasi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psaavedra/jigasi/teams","hooks_url":"https://api.github.com/repos/psaavedra/jigasi/hooks","issue_events_url":"https://api.github.com/repos/psaavedra/jigasi/issues/events{/number}","events_url":"https://api.github.com/repos/psaavedra/jigasi/events","assignees_url":"https://api.github.com/repos/psaavedra/jigasi/assignees{/user}","branches_url":"https://api.github.com/repos/psaavedra/jigasi/branches{/branch}","tags_url":"https://api.github.com/repos/psaavedra/jigasi/tags","blobs_url":"https://api.github.com/repos/psaavedra/jigasi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psaavedra/jigasi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psaavedra/jigasi/git/refs{/sha}","trees_url":"https://api.github.com/repos/psaavedra/jigasi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psaavedra/jigasi/statuses/{sha}","languages_url":"https://api.github.com/repos/psaavedra/jigasi/languages","stargazers_url":"https://api.github.com/repos/psaavedra/jigasi/stargazers","contributors_url":"https://api.github.com/repos/psaavedra/jigasi/contributors","subscribers_url":"https://api.github.com/repos/psaavedra/jigasi/subscribers","subscription_url":"https://api.github.com/repos/psaavedra/jigasi/subscription","commits_url":"https://api.github.com/repos/psaavedra/jigasi/commits{/sha}","git_commits_url":"https://api.github.com/repos/psaavedra/jigasi/git/commits{/sha}","comments_url":"https://api.github.com/repos/psaavedra/jigasi/comments{/number}","issue_comment_url":"https://api.github.com/repos/psaavedra/jigasi/issues/comments{/number}","contents_url":"https://api.github.com/repos/psaavedra/jigasi/contents/{+path}","compare_url":"https://api.github.com/repos/psaavedra/jigasi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psaavedra/jigasi/merges","archive_url":"https://api.github.com/repos/psaavedra/jigasi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psaavedra/jigasi/downloads","issues_url":"https://api.github.com/repos/psaavedra/jigasi/issues{/number}","pulls_url":"https://api.github.com/repos/psaavedra/jigasi/pulls{/number}","milestones_url":"https://api.github.com/repos/psaavedra/jigasi/milestones{/number}","notifications_url":"https://api.github.com/repos/psaavedra/jigasi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psaavedra/jigasi/labels{/name}","releases_url":"https://api.github.com/repos/psaavedra/jigasi/releases{/id}","deployments_url":"https://api.github.com/repos/psaavedra/jigasi/deployments","created_at":"2016-06-04T08:32:21Z","updated_at":"2016-06-04T08:32:22Z","pushed_at":"2016-06-04T18:03:05Z","git_url":"git://github.com/psaavedra/jigasi.git","ssh_url":"git@github.com:psaavedra/jigasi.git","clone_url":"https://github.com/psaavedra/jigasi.git","svn_url":"https://github.com/psaavedra/jigasi","homepage":null,"size":111231,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"18777e0b4253a2e3287c20a6f6549d147166dff0","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":22720188,"name":"jigasi","full_name":"jitsi/jigasi","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jigasi","description":"JItsi GAteway to SIP : a server-side application that links allows regular SIP clients to join JitMeet conferences hosted by Jitsi Videobridge.","fork":false,"url":"https://api.github.com/repos/jitsi/jigasi","forks_url":"https://api.github.com/repos/jitsi/jigasi/forks","keys_url":"https://api.github.com/repos/jitsi/jigasi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jigasi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jigasi/teams","hooks_url":"https://api.github.com/repos/jitsi/jigasi/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jigasi/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jigasi/events","assignees_url":"https://api.github.com/repos/jitsi/jigasi/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jigasi/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jigasi/tags","blobs_url":"https://api.github.com/repos/jitsi/jigasi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jigasi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jigasi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jigasi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jigasi/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jigasi/languages","stargazers_url":"https://api.github.com/repos/jitsi/jigasi/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jigasi/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jigasi/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jigasi/subscription","commits_url":"https://api.github.com/repos/jitsi/jigasi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jigasi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jigasi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jigasi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jigasi/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jigasi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jigasi/merges","archive_url":"https://api.github.com/repos/jitsi/jigasi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jigasi/downloads","issues_url":"https://api.github.com/repos/jitsi/jigasi/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jigasi/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jigasi/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jigasi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jigasi/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jigasi/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jigasi/deployments","created_at":"2014-08-07T12:20:09Z","updated_at":"2016-05-28T02:00:48Z","pushed_at":"2016-06-04T18:12:57Z","git_url":"git://github.com/jitsi/jigasi.git","ssh_url":"git@github.com:jitsi/jigasi.git","clone_url":"https://github.com/jitsi/jigasi.git","svn_url":"https://github.com/jitsi/jigasi","homepage":null,"size":119837,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":11,"forks":24,"open_issues":11,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/35"},"html":{"href":"https://github.com/jitsi/jigasi/pull/35"},"issue":{"href":"https://api.github.com/repos/jitsi/jigasi/issues/35"},"comments":{"href":"https://api.github.com/repos/jitsi/jigasi/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jigasi/statuses/50a1211bd086221b6e7b6d6446b1fd4d736d173c"}}}}
{"actor":{"display_login":"ibauersachs"}}