{"action":"created","comment":{"url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/comments/86801426","pull_request_review_id":7440270,"id":86801426,"diff_hunk":"@@ -276,8 +277,41 @@ public void shouldAlwaysPickSameElementFromAnEnumWithSingleElement() {\n         final Generator<SingleEnum> enumGenerator = randomEnum(SingleEnum.class);\n \n         // then\n-        typeCheck(enumGenerator, s -> enumGenerator.next().compareTo(enumGenerator.next()) == 0).verify(times(NUMBER_OF_TIMES));\n+        typeCheck(enumGenerator, s -> enumGenerator.next().compareTo(enumGenerator.next()) == 0)\n+                        .verify(times(NUMBER_OF_TIMES));\n     }\n \n-    enum SingleEnum {SINGLE_VALUE}\n-}\n\\ No newline at end of file\n+    @Test\n+    public void shouldReturnAnInstanceEmailAddressGenerator() {","path":"test-utils/test-utils-core/src/test/java/uk/gov/justice/services/test/utils/core/random/RandomGeneratorTest.java","position":262,"original_position":262,"commit_id":"74731d65b777ca585e29637818724440675050d3","original_commit_id":"74731d65b777ca585e29637818724440675050d3","user":{"login":"deepakhalale","id":11889009,"avatar_url":"https://avatars.githubusercontent.com/u/11889009?v=3","gravatar_id":"","url":"https://api.github.com/users/deepakhalale","html_url":"https://github.com/deepakhalale","followers_url":"https://api.github.com/users/deepakhalale/followers","following_url":"https://api.github.com/users/deepakhalale/following{/other_user}","gists_url":"https://api.github.com/users/deepakhalale/gists{/gist_id}","starred_url":"https://api.github.com/users/deepakhalale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepakhalale/subscriptions","organizations_url":"https://api.github.com/users/deepakhalale/orgs","repos_url":"https://api.github.com/users/deepakhalale/repos","events_url":"https://api.github.com/users/deepakhalale/events{/privacy}","received_events_url":"https://api.github.com/users/deepakhalale/received_events","type":"User","site_admin":false},"body":"Don't see much value in these tests. I think testing EMAIL_ADDRESS that it generates valid email address would naturally test that we get an instance of EMAIL_ADDRESS object!. Same applies for below tests. ","created_at":"2016-11-07T15:43:39Z","updated_at":"2016-11-07T15:43:39Z","html_url":"https://github.com/CJSCommonPlatform/microservice_framework/pull/258#discussion_r86801426","pull_request_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/258","_links":{"self":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/comments/86801426"},"html":{"href":"https://github.com/CJSCommonPlatform/microservice_framework/pull/258#discussion_r86801426"},"pull_request":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/258"}}},"pull_request":{"url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/258","id":92598940,"html_url":"https://github.com/CJSCommonPlatform/microservice_framework/pull/258","diff_url":"https://github.com/CJSCommonPlatform/microservice_framework/pull/258.diff","patch_url":"https://github.com/CJSCommonPlatform/microservice_framework/pull/258.patch","issue_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/258","number":258,"state":"open","locked":false,"title":"Refactor Random Generator Test","user":{"login":"gogit","id":843859,"avatar_url":"https://avatars.githubusercontent.com/u/843859?v=3","gravatar_id":"","url":"https://api.github.com/users/gogit","html_url":"https://github.com/gogit","followers_url":"https://api.github.com/users/gogit/followers","following_url":"https://api.github.com/users/gogit/following{/other_user}","gists_url":"https://api.github.com/users/gogit/gists{/gist_id}","starred_url":"https://api.github.com/users/gogit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogit/subscriptions","organizations_url":"https://api.github.com/users/gogit/orgs","repos_url":"https://api.github.com/users/gogit/repos","events_url":"https://api.github.com/users/gogit/events{/privacy}","received_events_url":"https://api.github.com/users/gogit/received_events","type":"User","site_admin":false},"body":"Refactor random generator test (Step1) and formatted code to confirm to style","created_at":"2016-11-07T15:03:04Z","updated_at":"2016-11-07T15:43:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b62586e8a3114a8a3e3c08d30561655db0b798f","assignee":{"login":"jaceko","id":5623398,"avatar_url":"https://avatars.githubusercontent.com/u/5623398?v=3","gravatar_id":"","url":"https://api.github.com/users/jaceko","html_url":"https://github.com/jaceko","followers_url":"https://api.github.com/users/jaceko/followers","following_url":"https://api.github.com/users/jaceko/following{/other_user}","gists_url":"https://api.github.com/users/jaceko/gists{/gist_id}","starred_url":"https://api.github.com/users/jaceko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaceko/subscriptions","organizations_url":"https://api.github.com/users/jaceko/orgs","repos_url":"https://api.github.com/users/jaceko/repos","events_url":"https://api.github.com/users/jaceko/events{/privacy}","received_events_url":"https://api.github.com/users/jaceko/received_events","type":"User","site_admin":false},"assignees":[{"login":"jaceko","id":5623398,"avatar_url":"https://avatars.githubusercontent.com/u/5623398?v=3","gravatar_id":"","url":"https://api.github.com/users/jaceko","html_url":"https://github.com/jaceko","followers_url":"https://api.github.com/users/jaceko/followers","following_url":"https://api.github.com/users/jaceko/following{/other_user}","gists_url":"https://api.github.com/users/jaceko/gists{/gist_id}","starred_url":"https://api.github.com/users/jaceko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaceko/subscriptions","organizations_url":"https://api.github.com/users/jaceko/orgs","repos_url":"https://api.github.com/users/jaceko/repos","events_url":"https://api.github.com/users/jaceko/events{/privacy}","received_events_url":"https://api.github.com/users/jaceko/received_events","type":"User","site_admin":false},{"login":"deepakhalale","id":11889009,"avatar_url":"https://avatars.githubusercontent.com/u/11889009?v=3","gravatar_id":"","url":"https://api.github.com/users/deepakhalale","html_url":"https://github.com/deepakhalale","followers_url":"https://api.github.com/users/deepakhalale/followers","following_url":"https://api.github.com/users/deepakhalale/following{/other_user}","gists_url":"https://api.github.com/users/deepakhalale/gists{/gist_id}","starred_url":"https://api.github.com/users/deepakhalale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepakhalale/subscriptions","organizations_url":"https://api.github.com/users/deepakhalale/orgs","repos_url":"https://api.github.com/users/deepakhalale/repos","events_url":"https://api.github.com/users/deepakhalale/events{/privacy}","received_events_url":"https://api.github.com/users/deepakhalale/received_events","type":"User","site_admin":false},{"login":"allanmckenzie","id":19711205,"avatar_url":"https://avatars.githubusercontent.com/u/19711205?v=3","gravatar_id":"","url":"https://api.github.com/users/allanmckenzie","html_url":"https://github.com/allanmckenzie","followers_url":"https://api.github.com/users/allanmckenzie/followers","following_url":"https://api.github.com/users/allanmckenzie/following{/other_user}","gists_url":"https://api.github.com/users/allanmckenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/allanmckenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanmckenzie/subscriptions","organizations_url":"https://api.github.com/users/allanmckenzie/orgs","repos_url":"https://api.github.com/users/allanmckenzie/repos","events_url":"https://api.github.com/users/allanmckenzie/events{/privacy}","received_events_url":"https://api.github.com/users/allanmckenzie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/258/commits","review_comments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/258/comments","review_comment_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/258/comments","statuses_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/statuses/74731d65b777ca585e29637818724440675050d3","head":{"label":"CJSCommonPlatform:refactor-random-generators-step1","ref":"refactor-random-generators-step1","sha":"74731d65b777ca585e29637818724440675050d3","user":{"login":"CJSCommonPlatform","id":16131145,"avatar_url":"https://avatars.githubusercontent.com/u/16131145?v=3","gravatar_id":"","url":"https://api.github.com/users/CJSCommonPlatform","html_url":"https://github.com/CJSCommonPlatform","followers_url":"https://api.github.com/users/CJSCommonPlatform/followers","following_url":"https://api.github.com/users/CJSCommonPlatform/following{/other_user}","gists_url":"https://api.github.com/users/CJSCommonPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/CJSCommonPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJSCommonPlatform/subscriptions","organizations_url":"https://api.github.com/users/CJSCommonPlatform/orgs","repos_url":"https://api.github.com/users/CJSCommonPlatform/repos","events_url":"https://api.github.com/users/CJSCommonPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/CJSCommonPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":51292541,"name":"microservice_framework","full_name":"CJSCommonPlatform/microservice_framework","owner":{"login":"CJSCommonPlatform","id":16131145,"avatar_url":"https://avatars.githubusercontent.com/u/16131145?v=3","gravatar_id":"","url":"https://api.github.com/users/CJSCommonPlatform","html_url":"https://github.com/CJSCommonPlatform","followers_url":"https://api.github.com/users/CJSCommonPlatform/followers","following_url":"https://api.github.com/users/CJSCommonPlatform/following{/other_user}","gists_url":"https://api.github.com/users/CJSCommonPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/CJSCommonPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJSCommonPlatform/subscriptions","organizations_url":"https://api.github.com/users/CJSCommonPlatform/orgs","repos_url":"https://api.github.com/users/CJSCommonPlatform/repos","events_url":"https://api.github.com/users/CJSCommonPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/CJSCommonPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CJSCommonPlatform/microservice_framework","description":null,"fork":false,"url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework","forks_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/forks","keys_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/teams","hooks_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/hooks","issue_events_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/events{/number}","events_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/events","assignees_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/assignees{/user}","branches_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/branches{/branch}","tags_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/tags","blobs_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/statuses/{sha}","languages_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/languages","stargazers_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/stargazers","contributors_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/contributors","subscribers_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/subscribers","subscription_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/subscription","commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/contents/{+path}","compare_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/merges","archive_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/downloads","issues_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues{/number}","pulls_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls{/number}","milestones_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/milestones{/number}","notifications_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/labels{/name}","releases_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/releases{/id}","deployments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/deployments","created_at":"2016-02-08T10:51:31Z","updated_at":"2016-11-02T17:15:19Z","pushed_at":"2016-11-07T15:03:04Z","git_url":"git://github.com/CJSCommonPlatform/microservice_framework.git","ssh_url":"git@github.com:CJSCommonPlatform/microservice_framework.git","clone_url":"https://github.com/CJSCommonPlatform/microservice_framework.git","svn_url":"https://github.com/CJSCommonPlatform/microservice_framework","homepage":null,"size":4029,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":8,"default_branch":"master"}},"base":{"label":"CJSCommonPlatform:master","ref":"master","sha":"815dcb9953a10b16959ee3030b91c42b1345acdc","user":{"login":"CJSCommonPlatform","id":16131145,"avatar_url":"https://avatars.githubusercontent.com/u/16131145?v=3","gravatar_id":"","url":"https://api.github.com/users/CJSCommonPlatform","html_url":"https://github.com/CJSCommonPlatform","followers_url":"https://api.github.com/users/CJSCommonPlatform/followers","following_url":"https://api.github.com/users/CJSCommonPlatform/following{/other_user}","gists_url":"https://api.github.com/users/CJSCommonPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/CJSCommonPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJSCommonPlatform/subscriptions","organizations_url":"https://api.github.com/users/CJSCommonPlatform/orgs","repos_url":"https://api.github.com/users/CJSCommonPlatform/repos","events_url":"https://api.github.com/users/CJSCommonPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/CJSCommonPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":51292541,"name":"microservice_framework","full_name":"CJSCommonPlatform/microservice_framework","owner":{"login":"CJSCommonPlatform","id":16131145,"avatar_url":"https://avatars.githubusercontent.com/u/16131145?v=3","gravatar_id":"","url":"https://api.github.com/users/CJSCommonPlatform","html_url":"https://github.com/CJSCommonPlatform","followers_url":"https://api.github.com/users/CJSCommonPlatform/followers","following_url":"https://api.github.com/users/CJSCommonPlatform/following{/other_user}","gists_url":"https://api.github.com/users/CJSCommonPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/CJSCommonPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJSCommonPlatform/subscriptions","organizations_url":"https://api.github.com/users/CJSCommonPlatform/orgs","repos_url":"https://api.github.com/users/CJSCommonPlatform/repos","events_url":"https://api.github.com/users/CJSCommonPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/CJSCommonPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CJSCommonPlatform/microservice_framework","description":null,"fork":false,"url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework","forks_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/forks","keys_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/teams","hooks_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/hooks","issue_events_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/events{/number}","events_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/events","assignees_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/assignees{/user}","branches_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/branches{/branch}","tags_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/tags","blobs_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/statuses/{sha}","languages_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/languages","stargazers_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/stargazers","contributors_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/contributors","subscribers_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/subscribers","subscription_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/subscription","commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/contents/{+path}","compare_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/merges","archive_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/downloads","issues_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues{/number}","pulls_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls{/number}","milestones_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/milestones{/number}","notifications_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/labels{/name}","releases_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/releases{/id}","deployments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/deployments","created_at":"2016-02-08T10:51:31Z","updated_at":"2016-11-02T17:15:19Z","pushed_at":"2016-11-07T15:03:04Z","git_url":"git://github.com/CJSCommonPlatform/microservice_framework.git","ssh_url":"git@github.com:CJSCommonPlatform/microservice_framework.git","clone_url":"https://github.com/CJSCommonPlatform/microservice_framework.git","svn_url":"https://github.com/CJSCommonPlatform/microservice_framework","homepage":null,"size":4029,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/258"},"html":{"href":"https://github.com/CJSCommonPlatform/microservice_framework/pull/258"},"issue":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/258"},"comments":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/statuses/74731d65b777ca585e29637818724440675050d3"}}}}
{"actor":{"display_login":"deepakhalale"}}