{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/18587","labels_url":"https://api.github.com/repos/docker/docker/issues/18587/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/18587/comments","events_url":"https://api.github.com/repos/docker/docker/issues/18587/events","html_url":"https://github.com/docker/docker/pull/18587","id":121603252,"number":18587,"title":"Allow to set daemon and server configurations in a file.","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/44","html_url":"https://github.com/docker/docker/milestones/1.10.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/44/labels","id":1351533,"number":44,"title":"1.10.0","description":"Code freeze / feature freeze January 14th 2016\r\nPlanned release: February 4th, 2016\r\nhttps://github.com/docker/docker/wiki","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":127,"state":"open","created_at":"2015-10-12T18:21:55Z","updated_at":"2016-01-11T19:15:43Z","due_on":"2016-01-13T23:00:00Z","closed_at":null},"comments":53,"created_at":"2015-12-10T23:39:44Z","updated_at":"2016-01-11T19:35:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/18587","html_url":"https://github.com/docker/docker/pull/18587","diff_url":"https://github.com/docker/docker/pull/18587.diff","patch_url":"https://github.com/docker/docker/pull/18587.patch"},"body":"Still a work in progress but I thought it could be a good idea to show this now that mostly works.\r\n\r\nRead configuration after flags making this the priority:\r\n\r\n1- Apply configuration from file.\r\n2- Apply configuration from flags.\r\n\r\nReload configuration when it a signal is received, HUP in Linux:\r\n\r\n- Reload router if the debug configuration changes.\r\n- Reload daemon labels.\r\n- Reconfigure and restart cluster discovery.\r\n\r\n![daemon-config](https://cloud.githubusercontent.com/assets/1050/12132395/1b06cd5a-b3d0-11e5-84ee-dfa2ab041278.gif)\r\n\r\nCloses #17559\r\nSigned-off-by: David Calavera <david.calavera@gmail.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/170665246","html_url":"https://github.com/docker/docker/pull/18587#issuecomment-170665246","issue_url":"https://api.github.com/repos/docker/docker/issues/18587","id":170665246,"user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"created_at":"2016-01-11T19:35:15Z","updated_at":"2016-01-11T19:35:15Z","body":"I added some documentation, the changes might make more sense with it. Notice that the keys in the configuration file match the flags in the CLI, that way, we don't expose our internal structure to users and their transition is easier. Example: `--storage-opt` in the cli matches with `\"storage-opt\"` in the configuration file.\r\n\r\nhttps://github.com/docker/docker/pull/18587/files#diff-991890e619874cd6bb0277584bb7f7a4"}}