{"action":"opened","number":1816,"pull_request":{"url":"https://api.github.com/repos/ExactTarget/fuelux/pulls/1816","id":71096129,"html_url":"https://github.com/ExactTarget/fuelux/pull/1816","diff_url":"https://github.com/ExactTarget/fuelux/pull/1816.diff","patch_url":"https://github.com/ExactTarget/fuelux/pull/1816.patch","issue_url":"https://api.github.com/repos/ExactTarget/fuelux/issues/1816","number":1816,"state":"open","locked":false,"title":"Repeater combobox events","user":{"login":"interactivellama","id":1290832,"avatar_url":"https://avatars.githubusercontent.com/u/1290832?v=3","gravatar_id":"","url":"https://api.github.com/users/interactivellama","html_url":"https://github.com/interactivellama","followers_url":"https://api.github.com/users/interactivellama/followers","following_url":"https://api.github.com/users/interactivellama/following{/other_user}","gists_url":"https://api.github.com/users/interactivellama/gists{/gist_id}","starred_url":"https://api.github.com/users/interactivellama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interactivellama/subscriptions","organizations_url":"https://api.github.com/users/interactivellama/orgs","repos_url":"https://api.github.com/users/interactivellama/repos","events_url":"https://api.github.com/users/interactivellama/events{/privacy}","received_events_url":"https://api.github.com/users/interactivellama/received_events","type":"User","site_admin":false},"body":"Fixes #1790 for @dkilgore \r\n\r\n`pageChanged.fu.repeater` should now only fire once. Repeater's `pageChanged` event will now return an object with a `{ value: [number], data: [object] }` shape instead of an array. Previously an array was returned.\r\n\r\n**Additional help with paging and multiple `combobox` events**\r\nIf repeater only has two pages of data, the combobox will be present. If a `3` is entered into the combobox the data key will return the data from the combobox's `changed` event \r\n\r\n`{ notFound: true, text: '3'}`\r\n\r\nThe `3` is not present (since there are only two pages), therefore a `notFound` will be present in the data returned from the `combobox`. A 3 (or really a zero index 2, will still be passed into the repeater, but you can now check for the `notFound` key in order to revert to a valid page if you so choose.\r\n\r\nCombobox was refactored, so that that `changed.fu.combobox` event did not fire twice when changed after typing and then using the enter key. Issues were also present that created multiple selected menu items due to previous item with `.selected` class were not being removed, but still determining what item selection by a query selector for `.selected:first`.\r\n\r\n**Individual tests**\r\nIndividual tests for combobox were not being \"taken down\" and therefore tests were affecting each other and not isolated. It's a `noop/return` if you run `.combobox()` on a DOM element that has already been initialized.","created_at":"2016-05-23T18:17:13Z","updated_at":"2016-05-23T18:17:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf9676accb1cab13b4a755934390def28e3f2e44","assignee":{"login":"swilliamset","id":347227,"avatar_url":"https://avatars.githubusercontent.com/u/347227?v=3","gravatar_id":"","url":"https://api.github.com/users/swilliamset","html_url":"https://github.com/swilliamset","followers_url":"https://api.github.com/users/swilliamset/followers","following_url":"https://api.github.com/users/swilliamset/following{/other_user}","gists_url":"https://api.github.com/users/swilliamset/gists{/gist_id}","starred_url":"https://api.github.com/users/swilliamset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swilliamset/subscriptions","organizations_url":"https://api.github.com/users/swilliamset/orgs","repos_url":"https://api.github.com/users/swilliamset/repos","events_url":"https://api.github.com/users/swilliamset/events{/privacy}","received_events_url":"https://api.github.com/users/swilliamset/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ExactTarget/fuelux/milestones/57","html_url":"https://github.com/ExactTarget/fuelux/milestones/3.15.4","labels_url":"https://api.github.com/repos/ExactTarget/fuelux/milestones/57/labels","id":1748319,"number":57,"title":"3.15.4","description":"","creator":{"login":"swilliamset","id":347227,"avatar_url":"https://avatars.githubusercontent.com/u/347227?v=3","gravatar_id":"","url":"https://api.github.com/users/swilliamset","html_url":"https://github.com/swilliamset","followers_url":"https://api.github.com/users/swilliamset/followers","following_url":"https://api.github.com/users/swilliamset/following{/other_user}","gists_url":"https://api.github.com/users/swilliamset/gists{/gist_id}","starred_url":"https://api.github.com/users/swilliamset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swilliamset/subscriptions","organizations_url":"https://api.github.com/users/swilliamset/orgs","repos_url":"https://api.github.com/users/swilliamset/repos","events_url":"https://api.github.com/users/swilliamset/events{/privacy}","received_events_url":"https://api.github.com/users/swilliamset/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-05-04T18:38:54Z","updated_at":"2016-05-23T18:17:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ExactTarget/fuelux/pulls/1816/commits","review_comments_url":"https://api.github.com/repos/ExactTarget/fuelux/pulls/1816/comments","review_comment_url":"https://api.github.com/repos/ExactTarget/fuelux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ExactTarget/fuelux/issues/1816/comments","statuses_url":"https://api.github.com/repos/ExactTarget/fuelux/statuses/6f69d11e1d17a1c0aeeef2766c92554a501fc827","head":{"label":"interactivellama:repeater-combobox-events","ref":"repeater-combobox-events","sha":"6f69d11e1d17a1c0aeeef2766c92554a501fc827","user":{"login":"interactivellama","id":1290832,"avatar_url":"https://avatars.githubusercontent.com/u/1290832?v=3","gravatar_id":"","url":"https://api.github.com/users/interactivellama","html_url":"https://github.com/interactivellama","followers_url":"https://api.github.com/users/interactivellama/followers","following_url":"https://api.github.com/users/interactivellama/following{/other_user}","gists_url":"https://api.github.com/users/interactivellama/gists{/gist_id}","starred_url":"https://api.github.com/users/interactivellama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interactivellama/subscriptions","organizations_url":"https://api.github.com/users/interactivellama/orgs","repos_url":"https://api.github.com/users/interactivellama/repos","events_url":"https://api.github.com/users/interactivellama/events{/privacy}","received_events_url":"https://api.github.com/users/interactivellama/received_events","type":"User","site_admin":false},"repo":{"id":25417369,"name":"fuelux","full_name":"interactivellama/fuelux","owner":{"login":"interactivellama","id":1290832,"avatar_url":"https://avatars.githubusercontent.com/u/1290832?v=3","gravatar_id":"","url":"https://api.github.com/users/interactivellama","html_url":"https://github.com/interactivellama","followers_url":"https://api.github.com/users/interactivellama/followers","following_url":"https://api.github.com/users/interactivellama/following{/other_user}","gists_url":"https://api.github.com/users/interactivellama/gists{/gist_id}","starred_url":"https://api.github.com/users/interactivellama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interactivellama/subscriptions","organizations_url":"https://api.github.com/users/interactivellama/orgs","repos_url":"https://api.github.com/users/interactivellama/repos","events_url":"https://api.github.com/users/interactivellama/events{/privacy}","received_events_url":"https://api.github.com/users/interactivellama/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/interactivellama/fuelux","description":"Extends Twitter Bootstrap with additional lightweight JavaScript controls. Easy to install, customize, update, and optimize. All functionality covered by live documentation and unit tests.","fork":true,"url":"https://api.github.com/repos/interactivellama/fuelux","forks_url":"https://api.github.com/repos/interactivellama/fuelux/forks","keys_url":"https://api.github.com/repos/interactivellama/fuelux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interactivellama/fuelux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interactivellama/fuelux/teams","hooks_url":"https://api.github.com/repos/interactivellama/fuelux/hooks","issue_events_url":"https://api.github.com/repos/interactivellama/fuelux/issues/events{/number}","events_url":"https://api.github.com/repos/interactivellama/fuelux/events","assignees_url":"https://api.github.com/repos/interactivellama/fuelux/assignees{/user}","branches_url":"https://api.github.com/repos/interactivellama/fuelux/branches{/branch}","tags_url":"https://api.github.com/repos/interactivellama/fuelux/tags","blobs_url":"https://api.github.com/repos/interactivellama/fuelux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interactivellama/fuelux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interactivellama/fuelux/git/refs{/sha}","trees_url":"https://api.github.com/repos/interactivellama/fuelux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interactivellama/fuelux/statuses/{sha}","languages_url":"https://api.github.com/repos/interactivellama/fuelux/languages","stargazers_url":"https://api.github.com/repos/interactivellama/fuelux/stargazers","contributors_url":"https://api.github.com/repos/interactivellama/fuelux/contributors","subscribers_url":"https://api.github.com/repos/interactivellama/fuelux/subscribers","subscription_url":"https://api.github.com/repos/interactivellama/fuelux/subscription","commits_url":"https://api.github.com/repos/interactivellama/fuelux/commits{/sha}","git_commits_url":"https://api.github.com/repos/interactivellama/fuelux/git/commits{/sha}","comments_url":"https://api.github.com/repos/interactivellama/fuelux/comments{/number}","issue_comment_url":"https://api.github.com/repos/interactivellama/fuelux/issues/comments{/number}","contents_url":"https://api.github.com/repos/interactivellama/fuelux/contents/{+path}","compare_url":"https://api.github.com/repos/interactivellama/fuelux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interactivellama/fuelux/merges","archive_url":"https://api.github.com/repos/interactivellama/fuelux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interactivellama/fuelux/downloads","issues_url":"https://api.github.com/repos/interactivellama/fuelux/issues{/number}","pulls_url":"https://api.github.com/repos/interactivellama/fuelux/pulls{/number}","milestones_url":"https://api.github.com/repos/interactivellama/fuelux/milestones{/number}","notifications_url":"https://api.github.com/repos/interactivellama/fuelux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interactivellama/fuelux/labels{/name}","releases_url":"https://api.github.com/repos/interactivellama/fuelux/releases{/id}","deployments_url":"https://api.github.com/repos/interactivellama/fuelux/deployments","created_at":"2014-10-19T04:03:22Z","updated_at":"2015-08-11T00:02:02Z","pushed_at":"2016-05-23T18:09:49Z","git_url":"git://github.com/interactivellama/fuelux.git","ssh_url":"git@github.com:interactivellama/fuelux.git","clone_url":"https://github.com/interactivellama/fuelux.git","svn_url":"https://github.com/interactivellama/fuelux","homepage":"http://getFuelUX.com","size":168053,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ExactTarget:master","ref":"master","sha":"2da1dd9cd03a361c0a95db995d49aae6237ecad1","user":{"login":"ExactTarget","id":1648421,"avatar_url":"https://avatars.githubusercontent.com/u/1648421?v=3","gravatar_id":"","url":"https://api.github.com/users/ExactTarget","html_url":"https://github.com/ExactTarget","followers_url":"https://api.github.com/users/ExactTarget/followers","following_url":"https://api.github.com/users/ExactTarget/following{/other_user}","gists_url":"https://api.github.com/users/ExactTarget/gists{/gist_id}","starred_url":"https://api.github.com/users/ExactTarget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExactTarget/subscriptions","organizations_url":"https://api.github.com/users/ExactTarget/orgs","repos_url":"https://api.github.com/users/ExactTarget/repos","events_url":"https://api.github.com/users/ExactTarget/events{/privacy}","received_events_url":"https://api.github.com/users/ExactTarget/received_events","type":"Organization","site_admin":false},"repo":{"id":4924151,"name":"fuelux","full_name":"ExactTarget/fuelux","owner":{"login":"ExactTarget","id":1648421,"avatar_url":"https://avatars.githubusercontent.com/u/1648421?v=3","gravatar_id":"","url":"https://api.github.com/users/ExactTarget","html_url":"https://github.com/ExactTarget","followers_url":"https://api.github.com/users/ExactTarget/followers","following_url":"https://api.github.com/users/ExactTarget/following{/other_user}","gists_url":"https://api.github.com/users/ExactTarget/gists{/gist_id}","starred_url":"https://api.github.com/users/ExactTarget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExactTarget/subscriptions","organizations_url":"https://api.github.com/users/ExactTarget/orgs","repos_url":"https://api.github.com/users/ExactTarget/repos","events_url":"https://api.github.com/users/ExactTarget/events{/privacy}","received_events_url":"https://api.github.com/users/ExactTarget/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ExactTarget/fuelux","description":"Extends Twitter Bootstrap with additional lightweight JavaScript controls. Easy to install, customize, update, and optimize. All functionality covered by live documentation and unit tests.","fork":false,"url":"https://api.github.com/repos/ExactTarget/fuelux","forks_url":"https://api.github.com/repos/ExactTarget/fuelux/forks","keys_url":"https://api.github.com/repos/ExactTarget/fuelux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExactTarget/fuelux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExactTarget/fuelux/teams","hooks_url":"https://api.github.com/repos/ExactTarget/fuelux/hooks","issue_events_url":"https://api.github.com/repos/ExactTarget/fuelux/issues/events{/number}","events_url":"https://api.github.com/repos/ExactTarget/fuelux/events","assignees_url":"https://api.github.com/repos/ExactTarget/fuelux/assignees{/user}","branches_url":"https://api.github.com/repos/ExactTarget/fuelux/branches{/branch}","tags_url":"https://api.github.com/repos/ExactTarget/fuelux/tags","blobs_url":"https://api.github.com/repos/ExactTarget/fuelux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExactTarget/fuelux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExactTarget/fuelux/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExactTarget/fuelux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExactTarget/fuelux/statuses/{sha}","languages_url":"https://api.github.com/repos/ExactTarget/fuelux/languages","stargazers_url":"https://api.github.com/repos/ExactTarget/fuelux/stargazers","contributors_url":"https://api.github.com/repos/ExactTarget/fuelux/contributors","subscribers_url":"https://api.github.com/repos/ExactTarget/fuelux/subscribers","subscription_url":"https://api.github.com/repos/ExactTarget/fuelux/subscription","commits_url":"https://api.github.com/repos/ExactTarget/fuelux/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExactTarget/fuelux/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExactTarget/fuelux/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExactTarget/fuelux/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExactTarget/fuelux/contents/{+path}","compare_url":"https://api.github.com/repos/ExactTarget/fuelux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExactTarget/fuelux/merges","archive_url":"https://api.github.com/repos/ExactTarget/fuelux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExactTarget/fuelux/downloads","issues_url":"https://api.github.com/repos/ExactTarget/fuelux/issues{/number}","pulls_url":"https://api.github.com/repos/ExactTarget/fuelux/pulls{/number}","milestones_url":"https://api.github.com/repos/ExactTarget/fuelux/milestones{/number}","notifications_url":"https://api.github.com/repos/ExactTarget/fuelux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExactTarget/fuelux/labels{/name}","releases_url":"https://api.github.com/repos/ExactTarget/fuelux/releases{/id}","deployments_url":"https://api.github.com/repos/ExactTarget/fuelux/deployments","created_at":"2012-07-06T12:12:47Z","updated_at":"2016-05-23T14:28:28Z","pushed_at":"2016-05-23T18:17:13Z","git_url":"git://github.com/ExactTarget/fuelux.git","ssh_url":"git@github.com:ExactTarget/fuelux.git","clone_url":"https://github.com/ExactTarget/fuelux.git","svn_url":"https://github.com/ExactTarget/fuelux","homepage":"http://getFuelUX.com","size":175560,"stargazers_count":5127,"watchers_count":5127,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1124,"mirror_url":null,"open_issues_count":125,"forks":1124,"open_issues":125,"watchers":5127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ExactTarget/fuelux/pulls/1816"},"html":{"href":"https://github.com/ExactTarget/fuelux/pull/1816"},"issue":{"href":"https://api.github.com/repos/ExactTarget/fuelux/issues/1816"},"comments":{"href":"https://api.github.com/repos/ExactTarget/fuelux/issues/1816/comments"},"review_comments":{"href":"https://api.github.com/repos/ExactTarget/fuelux/pulls/1816/comments"},"review_comment":{"href":"https://api.github.com/repos/ExactTarget/fuelux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ExactTarget/fuelux/pulls/1816/commits"},"statuses":{"href":"https://api.github.com/repos/ExactTarget/fuelux/statuses/6f69d11e1d17a1c0aeeef2766c92554a501fc827"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":41,"deletions":18,"changed_files":4}}
{"actor":{"display_login":"interactivellama"}}