{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/3792","repository_url":"https://api.github.com/repos/concrete5/concrete5","labels_url":"https://api.github.com/repos/concrete5/concrete5/issues/3792/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/3792/comments","events_url":"https://api.github.com/repos/concrete5/concrete5/issues/3792/events","html_url":"https://github.com/concrete5/concrete5/issues/3792","id":154845421,"number":3792,"title":"Concrete5 version 8 package compability issues","user":{"login":"MichaelMaar","id":1224538,"avatar_url":"https://avatars.githubusercontent.com/u/1224538?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelMaar","html_url":"https://github.com/MichaelMaar","followers_url":"https://api.github.com/users/MichaelMaar/followers","following_url":"https://api.github.com/users/MichaelMaar/following{/other_user}","gists_url":"https://api.github.com/users/MichaelMaar/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelMaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelMaar/subscriptions","organizations_url":"https://api.github.com/users/MichaelMaar/orgs","repos_url":"https://api.github.com/users/MichaelMaar/repos","events_url":"https://api.github.com/users/MichaelMaar/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelMaar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2016-05-14T10:08:35Z","updated_at":"2016-06-13T23:03:14Z","closed_at":"2016-05-16T23:40:59Z","body":"We are beginning to go through our C5DK Blog package regrading compability. And we found the following first issue in the package controller:\r\n\r\n// Add C5DK Blog page attribute Set if not already exist\r\n\t\t$bas = AttributeSet::getByHandle('c5dk_blog');\r\n\t\tif (!$bas instanceof AttributeSet){\r\n\t\t\t$cakc = AttributeKeyCategory::getByHandle('collection');\r\n\t\t\t$cakc->setAllowAttributeSets(AttributeKeyCategory::ASET_ALLOW_MULTIPLE);\r\n\t\t\t$bas = $cakc->addSet('c5dk_blog', t('C5DK Blog'));\r\n\t\t}\r\n\r\nIt goes bad in: $cakc->setAllowAttributeSets(AttributeKeyCategory::ASET_ALLOW_MULTIPLE);\r\n\r\n![screenshot_51](https://cloud.githubusercontent.com/assets/1224538/15267808/8fb1e5f6-19cc-11e6-812b-a47cd156a4f0.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/comments/225734172","html_url":"https://github.com/concrete5/concrete5/issues/3792#issuecomment-225734172","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/3792","id":225734172,"user":{"login":"Mesuva","id":1079600,"avatar_url":"https://avatars.githubusercontent.com/u/1079600?v=3","gravatar_id":"","url":"https://api.github.com/users/Mesuva","html_url":"https://github.com/Mesuva","followers_url":"https://api.github.com/users/Mesuva/followers","following_url":"https://api.github.com/users/Mesuva/following{/other_user}","gists_url":"https://api.github.com/users/Mesuva/gists{/gist_id}","starred_url":"https://api.github.com/users/Mesuva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mesuva/subscriptions","organizations_url":"https://api.github.com/users/Mesuva/orgs","repos_url":"https://api.github.com/users/Mesuva/repos","events_url":"https://api.github.com/users/Mesuva/events{/privacy}","received_events_url":"https://api.github.com/users/Mesuva/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T23:03:14Z","updated_at":"2016-06-13T23:03:14Z","body":"I reckon that would be the way to go. \r\n\r\nI'm not even sure how such a change could be made noticeable be devs - I'm wondering if an object's direct access to property can be marked as deprecated, to be picked up by PHPStorm and others... "}}
{"actor":{"display_login":"Mesuva"}}