{"action":"created","comment":{"url":"https://api.github.com/repos/ten24/slatwall/pulls/comments/57925636","id":57925636,"diff_hunk":"@@ -117,24 +117,24 @@ component entityname=\"SlatwallShippingMethodOption\" table=\"SwShippingMethodOptio\n \t}\n \n \t// =============  END:  Bidirectional Helper Methods ===================\n-\t\n+\n \t// =============== START: Custom Validation Methods ====================\n-\t\n+\n \t// ===============  END: Custom Validation Methods =====================\n-\t\n+\n \t// =============== START: Custom Formatting Methods ====================\n-\t\n+\n \t// ===============  END: Custom Formatting Methods =====================\n \n \t// ================== START: Overridden Methods ========================\n-\t\n+\n \tpublic any function getSimpleRepresentation() {\n-\t\treturn '#getShippingMethodRate().getShippingMethod().getShippingMethodName()# - #getFormattedValue(\"totalChargeAfterDiscount\")#';\t\n+\t\treturn '#getShippingMethodRate().getShippingMethod().getShippingMethodName()# - #getShippingMethodRate().getShippingMethodRateName()# - #getFormattedValue(\"totalChargeAfterDiscount\")#';","path":"model/entity/ShippingMethodOption.cfc","position":141,"original_position":141,"commit_id":"2ec1a1964ed8d78eab8e57cba801a9fa02e7f8db","original_commit_id":"2ec1a1964ed8d78eab8e57cba801a9fa02e7f8db","user":{"login":"gregmoser","id":363820,"avatar_url":"https://avatars.githubusercontent.com/u/363820?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmoser","html_url":"https://github.com/gregmoser","followers_url":"https://api.github.com/users/gregmoser/followers","following_url":"https://api.github.com/users/gregmoser/following{/other_user}","gists_url":"https://api.github.com/users/gregmoser/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmoser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmoser/subscriptions","organizations_url":"https://api.github.com/users/gregmoser/orgs","repos_url":"https://api.github.com/users/gregmoser/repos","events_url":"https://api.github.com/users/gregmoser/events{/privacy}","received_events_url":"https://api.github.com/users/gregmoser/received_events","type":"User","site_admin":false},"body":"There is also a helper function in the base hibachi object to do:\r\n\r\n```\r\nvar shippingMethodRateName = nullReplace(getShippingMethodRate().getShippingMethodRateName(), \"\");\r\n```\r\nor just\r\n\r\n```\r\nreturn '#getShippingMethodRate().getShippingMethod().getShippingMethodName()# - #nullReplace(getShippingMethodRate().getShippingMethodRateName(), \"\")# - #getFormattedValue(\"totalChargeAfterDiscount\")#'\r\n```\r\n\r\nso that this can all be done inline","created_at":"2016-03-30T17:07:38Z","updated_at":"2016-03-30T17:07:38Z","html_url":"https://github.com/ten24/slatwall/pull/4260#discussion_r57925636","pull_request_url":"https://api.github.com/repos/ten24/slatwall/pulls/4260","_links":{"self":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/comments/57925636"},"html":{"href":"https://github.com/ten24/slatwall/pull/4260#discussion_r57925636"},"pull_request":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4260"}}},"pull_request":{"url":"https://api.github.com/repos/ten24/slatwall/pulls/4260","id":62803601,"html_url":"https://github.com/ten24/slatwall/pull/4260","diff_url":"https://github.com/ten24/slatwall/pull/4260.diff","patch_url":"https://github.com/ten24/slatwall/pull/4260.patch","issue_url":"https://api.github.com/repos/ten24/slatwall/issues/4260","number":4260,"state":"open","locked":false,"title":"adding rate name to simple representation property to display in place order","user":{"login":"jasperboyd","id":2353662,"avatar_url":"https://avatars.githubusercontent.com/u/2353662?v=3","gravatar_id":"","url":"https://api.github.com/users/jasperboyd","html_url":"https://github.com/jasperboyd","followers_url":"https://api.github.com/users/jasperboyd/followers","following_url":"https://api.github.com/users/jasperboyd/following{/other_user}","gists_url":"https://api.github.com/users/jasperboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/jasperboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasperboyd/subscriptions","organizations_url":"https://api.github.com/users/jasperboyd/orgs","repos_url":"https://api.github.com/users/jasperboyd/repos","events_url":"https://api.github.com/users/jasperboyd/events{/privacy}","received_events_url":"https://api.github.com/users/jasperboyd/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-14T19:27:47Z","updated_at":"2016-03-30T17:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af6cc2d4f7e1246f9ee8f32ee630fd17a2431016","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ten24/slatwall/pulls/4260/commits","review_comments_url":"https://api.github.com/repos/ten24/slatwall/pulls/4260/comments","review_comment_url":"https://api.github.com/repos/ten24/slatwall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ten24/slatwall/issues/4260/comments","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/2ec1a1964ed8d78eab8e57cba801a9fa02e7f8db","head":{"label":"ten24:hotfix-jb-shipping-origin","ref":"hotfix-jb-shipping-origin","sha":"2ec1a1964ed8d78eab8e57cba801a9fa02e7f8db","user":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"repo":{"id":1483572,"name":"slatwall","full_name":"ten24/slatwall","owner":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ten24/slatwall","description":"Slatwall - An Open Source Commerce Platform","fork":false,"url":"https://api.github.com/repos/ten24/slatwall","forks_url":"https://api.github.com/repos/ten24/slatwall/forks","keys_url":"https://api.github.com/repos/ten24/slatwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ten24/slatwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ten24/slatwall/teams","hooks_url":"https://api.github.com/repos/ten24/slatwall/hooks","issue_events_url":"https://api.github.com/repos/ten24/slatwall/issues/events{/number}","events_url":"https://api.github.com/repos/ten24/slatwall/events","assignees_url":"https://api.github.com/repos/ten24/slatwall/assignees{/user}","branches_url":"https://api.github.com/repos/ten24/slatwall/branches{/branch}","tags_url":"https://api.github.com/repos/ten24/slatwall/tags","blobs_url":"https://api.github.com/repos/ten24/slatwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ten24/slatwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ten24/slatwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/ten24/slatwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/{sha}","languages_url":"https://api.github.com/repos/ten24/slatwall/languages","stargazers_url":"https://api.github.com/repos/ten24/slatwall/stargazers","contributors_url":"https://api.github.com/repos/ten24/slatwall/contributors","subscribers_url":"https://api.github.com/repos/ten24/slatwall/subscribers","subscription_url":"https://api.github.com/repos/ten24/slatwall/subscription","commits_url":"https://api.github.com/repos/ten24/slatwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/ten24/slatwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/ten24/slatwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/ten24/slatwall/issues/comments{/number}","contents_url":"https://api.github.com/repos/ten24/slatwall/contents/{+path}","compare_url":"https://api.github.com/repos/ten24/slatwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ten24/slatwall/merges","archive_url":"https://api.github.com/repos/ten24/slatwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ten24/slatwall/downloads","issues_url":"https://api.github.com/repos/ten24/slatwall/issues{/number}","pulls_url":"https://api.github.com/repos/ten24/slatwall/pulls{/number}","milestones_url":"https://api.github.com/repos/ten24/slatwall/milestones{/number}","notifications_url":"https://api.github.com/repos/ten24/slatwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ten24/slatwall/labels{/name}","releases_url":"https://api.github.com/repos/ten24/slatwall/releases{/id}","deployments_url":"https://api.github.com/repos/ten24/slatwall/deployments","created_at":"2011-03-15T16:58:28Z","updated_at":"2016-03-30T04:12:27Z","pushed_at":"2016-03-30T15:36:03Z","git_url":"git://github.com/ten24/slatwall.git","ssh_url":"git@github.com:ten24/slatwall.git","clone_url":"https://github.com/ten24/slatwall.git","svn_url":"https://github.com/ten24/slatwall","homepage":"http://www.slatwallcommerce.com","size":129885,"stargazers_count":100,"watchers_count":100,"language":"ColdFusion","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":298,"forks":64,"open_issues":298,"watchers":100,"default_branch":"master"}},"base":{"label":"ten24:hotfix","ref":"hotfix","sha":"c2c18ddf3179b11dcacfefee1209d6d2825789dd","user":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"repo":{"id":1483572,"name":"slatwall","full_name":"ten24/slatwall","owner":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ten24/slatwall","description":"Slatwall - An Open Source Commerce Platform","fork":false,"url":"https://api.github.com/repos/ten24/slatwall","forks_url":"https://api.github.com/repos/ten24/slatwall/forks","keys_url":"https://api.github.com/repos/ten24/slatwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ten24/slatwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ten24/slatwall/teams","hooks_url":"https://api.github.com/repos/ten24/slatwall/hooks","issue_events_url":"https://api.github.com/repos/ten24/slatwall/issues/events{/number}","events_url":"https://api.github.com/repos/ten24/slatwall/events","assignees_url":"https://api.github.com/repos/ten24/slatwall/assignees{/user}","branches_url":"https://api.github.com/repos/ten24/slatwall/branches{/branch}","tags_url":"https://api.github.com/repos/ten24/slatwall/tags","blobs_url":"https://api.github.com/repos/ten24/slatwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ten24/slatwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ten24/slatwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/ten24/slatwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/{sha}","languages_url":"https://api.github.com/repos/ten24/slatwall/languages","stargazers_url":"https://api.github.com/repos/ten24/slatwall/stargazers","contributors_url":"https://api.github.com/repos/ten24/slatwall/contributors","subscribers_url":"https://api.github.com/repos/ten24/slatwall/subscribers","subscription_url":"https://api.github.com/repos/ten24/slatwall/subscription","commits_url":"https://api.github.com/repos/ten24/slatwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/ten24/slatwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/ten24/slatwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/ten24/slatwall/issues/comments{/number}","contents_url":"https://api.github.com/repos/ten24/slatwall/contents/{+path}","compare_url":"https://api.github.com/repos/ten24/slatwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ten24/slatwall/merges","archive_url":"https://api.github.com/repos/ten24/slatwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ten24/slatwall/downloads","issues_url":"https://api.github.com/repos/ten24/slatwall/issues{/number}","pulls_url":"https://api.github.com/repos/ten24/slatwall/pulls{/number}","milestones_url":"https://api.github.com/repos/ten24/slatwall/milestones{/number}","notifications_url":"https://api.github.com/repos/ten24/slatwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ten24/slatwall/labels{/name}","releases_url":"https://api.github.com/repos/ten24/slatwall/releases{/id}","deployments_url":"https://api.github.com/repos/ten24/slatwall/deployments","created_at":"2011-03-15T16:58:28Z","updated_at":"2016-03-30T04:12:27Z","pushed_at":"2016-03-30T15:36:03Z","git_url":"git://github.com/ten24/slatwall.git","ssh_url":"git@github.com:ten24/slatwall.git","clone_url":"https://github.com/ten24/slatwall.git","svn_url":"https://github.com/ten24/slatwall","homepage":"http://www.slatwallcommerce.com","size":129885,"stargazers_count":100,"watchers_count":100,"language":"ColdFusion","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":298,"forks":64,"open_issues":298,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4260"},"html":{"href":"https://github.com/ten24/slatwall/pull/4260"},"issue":{"href":"https://api.github.com/repos/ten24/slatwall/issues/4260"},"comments":{"href":"https://api.github.com/repos/ten24/slatwall/issues/4260/comments"},"review_comments":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4260/comments"},"review_comment":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4260/commits"},"statuses":{"href":"https://api.github.com/repos/ten24/slatwall/statuses/2ec1a1964ed8d78eab8e57cba801a9fa02e7f8db"}}}}