{"action":"created","comment":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/comments/83653910","pull_request_review_id":4482667,"id":83653910,"diff_hunk":"@@ -0,0 +1,108 @@\n+<?\n+$items = $this->driver->getItems();","path":"themes/root/templates/RecordDriver/EDS/export-ris.phtml","position":2,"original_position":2,"commit_id":"c5a2cd45dc4fe60ae1bff536aca423dc5abc79d6","original_commit_id":"ea0cd38342ee2572f922b27e4bbbd0bc01f4a147","user":{"login":"powerriegel","id":11870663,"avatar_url":"https://avatars.githubusercontent.com/u/11870663?v=3","gravatar_id":"","url":"https://api.github.com/users/powerriegel","html_url":"https://github.com/powerriegel","followers_url":"https://api.github.com/users/powerriegel/followers","following_url":"https://api.github.com/users/powerriegel/following{/other_user}","gists_url":"https://api.github.com/users/powerriegel/gists{/gist_id}","starred_url":"https://api.github.com/users/powerriegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerriegel/subscriptions","organizations_url":"https://api.github.com/users/powerriegel/orgs","repos_url":"https://api.github.com/users/powerriegel/repos","events_url":"https://api.github.com/users/powerriegel/events{/privacy}","received_events_url":"https://api.github.com/users/powerriegel/received_events","type":"User","site_admin":false},"body":"I've implemented an example for this. There's still one problem. Items is an array of fields. The 2nd key won't always be the language. So we need a mechanism to configure an iteration. \r\n\r\nI'll ask my Ebsco contact if RecordInfo *always* contains the same Info as Items. If so, we might just drop Items support as it makes EDS really hard to read. ","created_at":"2016-10-17T14:22:46Z","updated_at":"2016-10-17T14:22:46Z","html_url":"https://github.com/vufind-org/vufind/pull/825#discussion_r83653910","pull_request_url":"https://api.github.com/repos/vufind-org/vufind/pulls/825","_links":{"self":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/comments/83653910"},"html":{"href":"https://github.com/vufind-org/vufind/pull/825#discussion_r83653910"},"pull_request":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/825"}}},"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/825","id":89166017,"html_url":"https://github.com/vufind-org/vufind/pull/825","diff_url":"https://github.com/vufind-org/vufind/pull/825.diff","patch_url":"https://github.com/vufind-org/vufind/pull/825.patch","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/825","number":825,"state":"open","locked":false,"title":"Added export for EDS records","user":{"login":"powerriegel","id":11870663,"avatar_url":"https://avatars.githubusercontent.com/u/11870663?v=3","gravatar_id":"","url":"https://api.github.com/users/powerriegel","html_url":"https://github.com/powerriegel","followers_url":"https://api.github.com/users/powerriegel/followers","following_url":"https://api.github.com/users/powerriegel/following{/other_user}","gists_url":"https://api.github.com/users/powerriegel/gists{/gist_id}","starred_url":"https://api.github.com/users/powerriegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerriegel/subscriptions","organizations_url":"https://api.github.com/users/powerriegel/orgs","repos_url":"https://api.github.com/users/powerriegel/repos","events_url":"https://api.github.com/users/powerriegel/events{/privacy}","received_events_url":"https://api.github.com/users/powerriegel/received_events","type":"User","site_admin":false},"body":"As asked on the german VuFind community meeting, I've added a recursive method to fetch atomic information from deeply nested RecordInfo array, This is neccessary to provide an export functionality for EDS records but it could be useful on other places as well. \r\n\r\nExport files should work in Citavi, all important fields are recognized. \r\n\r\nI hope everything is OK so far. Please report any problems. \r\n\r\n","created_at":"2016-10-13T09:30:33Z","updated_at":"2016-10-17T14:22:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e8a3481a7a92031c2f11335f7ee5037d8b21a0d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vufind-org/vufind/pulls/825/commits","review_comments_url":"https://api.github.com/repos/vufind-org/vufind/pulls/825/comments","review_comment_url":"https://api.github.com/repos/vufind-org/vufind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/825/comments","statuses_url":"https://api.github.com/repos/vufind-org/vufind/statuses/c5a2cd45dc4fe60ae1bff536aca423dc5abc79d6","head":{"label":"BSZBW:eds-export","ref":"eds-export","sha":"c5a2cd45dc4fe60ae1bff536aca423dc5abc79d6","user":{"login":"BSZBW","id":11870805,"avatar_url":"https://avatars.githubusercontent.com/u/11870805?v=3","gravatar_id":"","url":"https://api.github.com/users/BSZBW","html_url":"https://github.com/BSZBW","followers_url":"https://api.github.com/users/BSZBW/followers","following_url":"https://api.github.com/users/BSZBW/following{/other_user}","gists_url":"https://api.github.com/users/BSZBW/gists{/gist_id}","starred_url":"https://api.github.com/users/BSZBW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BSZBW/subscriptions","organizations_url":"https://api.github.com/users/BSZBW/orgs","repos_url":"https://api.github.com/users/BSZBW/repos","events_url":"https://api.github.com/users/BSZBW/events{/privacy}","received_events_url":"https://api.github.com/users/BSZBW/received_events","type":"Organization","site_admin":false},"repo":{"id":70789896,"name":"vufind","full_name":"BSZBW/vufind","owner":{"login":"BSZBW","id":11870805,"avatar_url":"https://avatars.githubusercontent.com/u/11870805?v=3","gravatar_id":"","url":"https://api.github.com/users/BSZBW","html_url":"https://github.com/BSZBW","followers_url":"https://api.github.com/users/BSZBW/followers","following_url":"https://api.github.com/users/BSZBW/following{/other_user}","gists_url":"https://api.github.com/users/BSZBW/gists{/gist_id}","starred_url":"https://api.github.com/users/BSZBW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BSZBW/subscriptions","organizations_url":"https://api.github.com/users/BSZBW/orgs","repos_url":"https://api.github.com/users/BSZBW/repos","events_url":"https://api.github.com/users/BSZBW/events{/privacy}","received_events_url":"https://api.github.com/users/BSZBW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BSZBW/vufind","description":"A library resource discovery portal designed and developed for libraries by libraries","fork":true,"url":"https://api.github.com/repos/BSZBW/vufind","forks_url":"https://api.github.com/repos/BSZBW/vufind/forks","keys_url":"https://api.github.com/repos/BSZBW/vufind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BSZBW/vufind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BSZBW/vufind/teams","hooks_url":"https://api.github.com/repos/BSZBW/vufind/hooks","issue_events_url":"https://api.github.com/repos/BSZBW/vufind/issues/events{/number}","events_url":"https://api.github.com/repos/BSZBW/vufind/events","assignees_url":"https://api.github.com/repos/BSZBW/vufind/assignees{/user}","branches_url":"https://api.github.com/repos/BSZBW/vufind/branches{/branch}","tags_url":"https://api.github.com/repos/BSZBW/vufind/tags","blobs_url":"https://api.github.com/repos/BSZBW/vufind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BSZBW/vufind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BSZBW/vufind/git/refs{/sha}","trees_url":"https://api.github.com/repos/BSZBW/vufind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BSZBW/vufind/statuses/{sha}","languages_url":"https://api.github.com/repos/BSZBW/vufind/languages","stargazers_url":"https://api.github.com/repos/BSZBW/vufind/stargazers","contributors_url":"https://api.github.com/repos/BSZBW/vufind/contributors","subscribers_url":"https://api.github.com/repos/BSZBW/vufind/subscribers","subscription_url":"https://api.github.com/repos/BSZBW/vufind/subscription","commits_url":"https://api.github.com/repos/BSZBW/vufind/commits{/sha}","git_commits_url":"https://api.github.com/repos/BSZBW/vufind/git/commits{/sha}","comments_url":"https://api.github.com/repos/BSZBW/vufind/comments{/number}","issue_comment_url":"https://api.github.com/repos/BSZBW/vufind/issues/comments{/number}","contents_url":"https://api.github.com/repos/BSZBW/vufind/contents/{+path}","compare_url":"https://api.github.com/repos/BSZBW/vufind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BSZBW/vufind/merges","archive_url":"https://api.github.com/repos/BSZBW/vufind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BSZBW/vufind/downloads","issues_url":"https://api.github.com/repos/BSZBW/vufind/issues{/number}","pulls_url":"https://api.github.com/repos/BSZBW/vufind/pulls{/number}","milestones_url":"https://api.github.com/repos/BSZBW/vufind/milestones{/number}","notifications_url":"https://api.github.com/repos/BSZBW/vufind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BSZBW/vufind/labels{/name}","releases_url":"https://api.github.com/repos/BSZBW/vufind/releases{/id}","deployments_url":"https://api.github.com/repos/BSZBW/vufind/deployments","created_at":"2016-10-13T09:18:29Z","updated_at":"2016-10-13T09:18:38Z","pushed_at":"2016-10-17T14:18:34Z","git_url":"git://github.com/BSZBW/vufind.git","ssh_url":"git@github.com:BSZBW/vufind.git","clone_url":"https://github.com/BSZBW/vufind.git","svn_url":"https://github.com/BSZBW/vufind","homepage":null,"size":321678,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vufind-org:master","ref":"master","sha":"1e4f8b10b23c7c462107f7f6a9c200024af32770","user":{"login":"vufind-org","id":5072328,"avatar_url":"https://avatars.githubusercontent.com/u/5072328?v=3","gravatar_id":"","url":"https://api.github.com/users/vufind-org","html_url":"https://github.com/vufind-org","followers_url":"https://api.github.com/users/vufind-org/followers","following_url":"https://api.github.com/users/vufind-org/following{/other_user}","gists_url":"https://api.github.com/users/vufind-org/gists{/gist_id}","starred_url":"https://api.github.com/users/vufind-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vufind-org/subscriptions","organizations_url":"https://api.github.com/users/vufind-org/orgs","repos_url":"https://api.github.com/users/vufind-org/repos","events_url":"https://api.github.com/users/vufind-org/events{/privacy}","received_events_url":"https://api.github.com/users/vufind-org/received_events","type":"Organization","site_admin":false},"repo":{"id":11680792,"name":"vufind","full_name":"vufind-org/vufind","owner":{"login":"vufind-org","id":5072328,"avatar_url":"https://avatars.githubusercontent.com/u/5072328?v=3","gravatar_id":"","url":"https://api.github.com/users/vufind-org","html_url":"https://github.com/vufind-org","followers_url":"https://api.github.com/users/vufind-org/followers","following_url":"https://api.github.com/users/vufind-org/following{/other_user}","gists_url":"https://api.github.com/users/vufind-org/gists{/gist_id}","starred_url":"https://api.github.com/users/vufind-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vufind-org/subscriptions","organizations_url":"https://api.github.com/users/vufind-org/orgs","repos_url":"https://api.github.com/users/vufind-org/repos","events_url":"https://api.github.com/users/vufind-org/events{/privacy}","received_events_url":"https://api.github.com/users/vufind-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vufind-org/vufind","description":"A library resource discovery portal designed and developed for libraries by libraries","fork":false,"url":"https://api.github.com/repos/vufind-org/vufind","forks_url":"https://api.github.com/repos/vufind-org/vufind/forks","keys_url":"https://api.github.com/repos/vufind-org/vufind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vufind-org/vufind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vufind-org/vufind/teams","hooks_url":"https://api.github.com/repos/vufind-org/vufind/hooks","issue_events_url":"https://api.github.com/repos/vufind-org/vufind/issues/events{/number}","events_url":"https://api.github.com/repos/vufind-org/vufind/events","assignees_url":"https://api.github.com/repos/vufind-org/vufind/assignees{/user}","branches_url":"https://api.github.com/repos/vufind-org/vufind/branches{/branch}","tags_url":"https://api.github.com/repos/vufind-org/vufind/tags","blobs_url":"https://api.github.com/repos/vufind-org/vufind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vufind-org/vufind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vufind-org/vufind/git/refs{/sha}","trees_url":"https://api.github.com/repos/vufind-org/vufind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vufind-org/vufind/statuses/{sha}","languages_url":"https://api.github.com/repos/vufind-org/vufind/languages","stargazers_url":"https://api.github.com/repos/vufind-org/vufind/stargazers","contributors_url":"https://api.github.com/repos/vufind-org/vufind/contributors","subscribers_url":"https://api.github.com/repos/vufind-org/vufind/subscribers","subscription_url":"https://api.github.com/repos/vufind-org/vufind/subscription","commits_url":"https://api.github.com/repos/vufind-org/vufind/commits{/sha}","git_commits_url":"https://api.github.com/repos/vufind-org/vufind/git/commits{/sha}","comments_url":"https://api.github.com/repos/vufind-org/vufind/comments{/number}","issue_comment_url":"https://api.github.com/repos/vufind-org/vufind/issues/comments{/number}","contents_url":"https://api.github.com/repos/vufind-org/vufind/contents/{+path}","compare_url":"https://api.github.com/repos/vufind-org/vufind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vufind-org/vufind/merges","archive_url":"https://api.github.com/repos/vufind-org/vufind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vufind-org/vufind/downloads","issues_url":"https://api.github.com/repos/vufind-org/vufind/issues{/number}","pulls_url":"https://api.github.com/repos/vufind-org/vufind/pulls{/number}","milestones_url":"https://api.github.com/repos/vufind-org/vufind/milestones{/number}","notifications_url":"https://api.github.com/repos/vufind-org/vufind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vufind-org/vufind/labels{/name}","releases_url":"https://api.github.com/repos/vufind-org/vufind/releases{/id}","deployments_url":"https://api.github.com/repos/vufind-org/vufind/deployments","created_at":"2013-07-26T08:05:45Z","updated_at":"2016-10-14T11:21:08Z","pushed_at":"2016-10-17T14:18:34Z","git_url":"git://github.com/vufind-org/vufind.git","ssh_url":"git@github.com:vufind-org/vufind.git","clone_url":"https://github.com/vufind-org/vufind.git","svn_url":"https://github.com/vufind-org/vufind","homepage":null,"size":555539,"stargazers_count":103,"watchers_count":103,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":178,"mirror_url":null,"open_issues_count":29,"forks":178,"open_issues":29,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/825"},"html":{"href":"https://github.com/vufind-org/vufind/pull/825"},"issue":{"href":"https://api.github.com/repos/vufind-org/vufind/issues/825"},"comments":{"href":"https://api.github.com/repos/vufind-org/vufind/issues/825/comments"},"review_comments":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/825/comments"},"review_comment":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/825/commits"},"statuses":{"href":"https://api.github.com/repos/vufind-org/vufind/statuses/c5a2cd45dc4fe60ae1bff536aca423dc5abc79d6"}}}}
{"actor":{"display_login":"powerriegel"}}