{"action":"created","issue":{"url":"https://api.github.com/repos/socketio/engine.io/issues/452","repository_url":"https://api.github.com/repos/socketio/engine.io","labels_url":"https://api.github.com/repos/socketio/engine.io/issues/452/labels{/name}","comments_url":"https://api.github.com/repos/socketio/engine.io/issues/452/comments","events_url":"https://api.github.com/repos/socketio/engine.io/issues/452/events","html_url":"https://github.com/socketio/engine.io/pull/452","id":192974465,"number":452,"title":"`allowRequest` failures now return 403 Forbidden","user":{"login":"darrachequesne","id":13031701,"avatar_url":"https://avatars.githubusercontent.com/u/13031701?v=3","gravatar_id":"","url":"https://api.github.com/users/darrachequesne","html_url":"https://github.com/darrachequesne","followers_url":"https://api.github.com/users/darrachequesne/followers","following_url":"https://api.github.com/users/darrachequesne/following{/other_user}","gists_url":"https://api.github.com/users/darrachequesne/gists{/gist_id}","starred_url":"https://api.github.com/users/darrachequesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrachequesne/subscriptions","organizations_url":"https://api.github.com/users/darrachequesne/orgs","repos_url":"https://api.github.com/users/darrachequesne/repos","events_url":"https://api.github.com/users/darrachequesne/events{/privacy}","received_events_url":"https://api.github.com/users/darrachequesne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-01T21:59:54Z","updated_at":"2016-12-01T22:03:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/socketio/engine.io/pulls/452","html_url":"https://github.com/socketio/engine.io/pull/452","diff_url":"https://github.com/socketio/engine.io/pull/452.diff","patch_url":"https://github.com/socketio/engine.io/pull/452.patch"},"body":"### The kind of change this PR does introduce\r\n\r\n* [ ] a bug fix\r\n* [x] a new feature\r\n* [ ] an update to the documentation\r\n* [ ] a code change that improves performance\r\n* [ ] other\r\n\r\n### Current behaviour\r\n\r\nWhen `allowRequest` option is provided and fails for a request (for example when checking the allowed origins in `socket.io`), the client receives:\r\n\r\n```\r\n400 Bad Request\r\nAccess-Control-Allow-Credentials: true\r\nAccess-Control-Allow-Origin: http://b.local /* but only a.local is allowed */\r\n```\r\n\r\n### New behaviour\r\n\r\nThe client will now receive a 403 response, without CORS headers.\r\n\r\n### Other information (e.g. related issues)\r\n\r\nCloses https://github.com/socketio/engine.io/issues/449\r\nRelated:  #211 & #281\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/socketio/engine.io/issues/comments/264309705","html_url":"https://github.com/socketio/engine.io/pull/452#issuecomment-264309705","issue_url":"https://api.github.com/repos/socketio/engine.io/issues/452","id":264309705,"user":{"login":"darrachequesne","id":13031701,"avatar_url":"https://avatars.githubusercontent.com/u/13031701?v=3","gravatar_id":"","url":"https://api.github.com/users/darrachequesne","html_url":"https://github.com/darrachequesne","followers_url":"https://api.github.com/users/darrachequesne/followers","following_url":"https://api.github.com/users/darrachequesne/following{/other_user}","gists_url":"https://api.github.com/users/darrachequesne/gists{/gist_id}","starred_url":"https://api.github.com/users/darrachequesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrachequesne/subscriptions","organizations_url":"https://api.github.com/users/darrachequesne/orgs","repos_url":"https://api.github.com/users/darrachequesne/repos","events_url":"https://api.github.com/users/darrachequesne/events{/privacy}","received_events_url":"https://api.github.com/users/darrachequesne/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T22:03:30Z","updated_at":"2016-12-01T22:03:30Z","body":"cc @akamensky @jdolega"}}
{"actor":{"display_login":"darrachequesne"}}