{"action":"created","comment":{"url":"https://api.github.com/repos/twigphp/Twig/pulls/comments/87770531","pull_request_review_id":8368342,"id":87770531,"diff_hunk":"@@ -10,10 +10,6 @@\n  * file that was distributed with this source code.\n  */\n \n-if (PHP_VERSION_ID >= 50600) {\n-    require_once __DIR__.'/twig_call_method.php';","path":"lib/Twig/Template.php","position":5,"original_position":5,"commit_id":"d64d320b4a3ac1bc8168a8c395a3e4297d9fd53e","original_commit_id":"d64d320b4a3ac1bc8168a8c395a3e4297d9fd53e","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"hmm, undefined constants are indeed fine in non-executed paths. I forgot that","created_at":"2016-11-14T10:13:13Z","updated_at":"2016-11-14T10:13:14Z","html_url":"https://github.com/twigphp/Twig/pull/2249#discussion_r87770531","pull_request_url":"https://api.github.com/repos/twigphp/Twig/pulls/2249","_links":{"self":{"href":"https://api.github.com/repos/twigphp/Twig/pulls/comments/87770531"},"html":{"href":"https://github.com/twigphp/Twig/pull/2249#discussion_r87770531"},"pull_request":{"href":"https://api.github.com/repos/twigphp/Twig/pulls/2249"}}},"pull_request":{"url":"https://api.github.com/repos/twigphp/Twig/pulls/2249","id":93460755,"html_url":"https://github.com/twigphp/Twig/pull/2249","diff_url":"https://github.com/twigphp/Twig/pull/2249.diff","patch_url":"https://github.com/twigphp/Twig/pull/2249.patch","issue_url":"https://api.github.com/repos/twigphp/Twig/issues/2249","number":2249,"state":"closed","locked":false,"title":"Remove optimization as it's not compatible with Symfony cache system","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"fixes #2243\r\n\r\n@nicolas-grekas Instead of fixing Symfony cache system (which will only happen in a new patch release), I propose to revert these changes. It means no optimization for Twig 1.x, but the optimization is the default in Twig 2.0. So, I don't think this is a big deal.\r\n","created_at":"2016-11-13T03:22:29Z","updated_at":"2016-11-14T10:13:14Z","closed_at":"2016-11-13T15:13:03Z","merged_at":"2016-11-13T15:13:03Z","merge_commit_sha":"d64d320b4a3ac1bc8168a8c395a3e4297d9fd53e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twigphp/Twig/pulls/2249/commits","review_comments_url":"https://api.github.com/repos/twigphp/Twig/pulls/2249/comments","review_comment_url":"https://api.github.com/repos/twigphp/Twig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twigphp/Twig/issues/2249/comments","statuses_url":"https://api.github.com/repos/twigphp/Twig/statuses/d64d320b4a3ac1bc8168a8c395a3e4297d9fd53e","head":{"label":"fabpot:hotfix","ref":"hotfix","sha":"d64d320b4a3ac1bc8168a8c395a3e4297d9fd53e","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"repo":{"id":25424710,"name":"Twig","full_name":"fabpot/Twig","owner":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabpot/Twig","description":"Twig, the flexible, fast, and secure template language for PHP","fork":true,"url":"https://api.github.com/repos/fabpot/Twig","forks_url":"https://api.github.com/repos/fabpot/Twig/forks","keys_url":"https://api.github.com/repos/fabpot/Twig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabpot/Twig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabpot/Twig/teams","hooks_url":"https://api.github.com/repos/fabpot/Twig/hooks","issue_events_url":"https://api.github.com/repos/fabpot/Twig/issues/events{/number}","events_url":"https://api.github.com/repos/fabpot/Twig/events","assignees_url":"https://api.github.com/repos/fabpot/Twig/assignees{/user}","branches_url":"https://api.github.com/repos/fabpot/Twig/branches{/branch}","tags_url":"https://api.github.com/repos/fabpot/Twig/tags","blobs_url":"https://api.github.com/repos/fabpot/Twig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabpot/Twig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabpot/Twig/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabpot/Twig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabpot/Twig/statuses/{sha}","languages_url":"https://api.github.com/repos/fabpot/Twig/languages","stargazers_url":"https://api.github.com/repos/fabpot/Twig/stargazers","contributors_url":"https://api.github.com/repos/fabpot/Twig/contributors","subscribers_url":"https://api.github.com/repos/fabpot/Twig/subscribers","subscription_url":"https://api.github.com/repos/fabpot/Twig/subscription","commits_url":"https://api.github.com/repos/fabpot/Twig/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabpot/Twig/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabpot/Twig/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabpot/Twig/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabpot/Twig/contents/{+path}","compare_url":"https://api.github.com/repos/fabpot/Twig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabpot/Twig/merges","archive_url":"https://api.github.com/repos/fabpot/Twig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabpot/Twig/downloads","issues_url":"https://api.github.com/repos/fabpot/Twig/issues{/number}","pulls_url":"https://api.github.com/repos/fabpot/Twig/pulls{/number}","milestones_url":"https://api.github.com/repos/fabpot/Twig/milestones{/number}","notifications_url":"https://api.github.com/repos/fabpot/Twig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabpot/Twig/labels{/name}","releases_url":"https://api.github.com/repos/fabpot/Twig/releases{/id}","deployments_url":"https://api.github.com/repos/fabpot/Twig/deployments","created_at":"2014-10-19T11:11:25Z","updated_at":"2016-10-18T01:45:38Z","pushed_at":"2016-11-13T15:41:40Z","git_url":"git://github.com/fabpot/Twig.git","ssh_url":"git@github.com:fabpot/Twig.git","clone_url":"https://github.com/fabpot/Twig.git","svn_url":"https://github.com/fabpot/Twig","homepage":"http://twig.sensiolabs.org/","size":7709,"stargazers_count":53,"watchers_count":53,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":0,"forks":20,"open_issues":0,"watchers":53,"default_branch":"master"}},"base":{"label":"twigphp:1.x","ref":"1.x","sha":"4419ff3ae4279141798095d4bdc47ac15577cc3d","user":{"login":"twigphp","id":5296178,"avatar_url":"https://avatars.githubusercontent.com/u/5296178?v=3","gravatar_id":"","url":"https://api.github.com/users/twigphp","html_url":"https://github.com/twigphp","followers_url":"https://api.github.com/users/twigphp/followers","following_url":"https://api.github.com/users/twigphp/following{/other_user}","gists_url":"https://api.github.com/users/twigphp/gists{/gist_id}","starred_url":"https://api.github.com/users/twigphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twigphp/subscriptions","organizations_url":"https://api.github.com/users/twigphp/orgs","repos_url":"https://api.github.com/users/twigphp/repos","events_url":"https://api.github.com/users/twigphp/events{/privacy}","received_events_url":"https://api.github.com/users/twigphp/received_events","type":"Organization","site_admin":false},"repo":{"id":330275,"name":"Twig","full_name":"twigphp/Twig","owner":{"login":"twigphp","id":5296178,"avatar_url":"https://avatars.githubusercontent.com/u/5296178?v=3","gravatar_id":"","url":"https://api.github.com/users/twigphp","html_url":"https://github.com/twigphp","followers_url":"https://api.github.com/users/twigphp/followers","following_url":"https://api.github.com/users/twigphp/following{/other_user}","gists_url":"https://api.github.com/users/twigphp/gists{/gist_id}","starred_url":"https://api.github.com/users/twigphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twigphp/subscriptions","organizations_url":"https://api.github.com/users/twigphp/orgs","repos_url":"https://api.github.com/users/twigphp/repos","events_url":"https://api.github.com/users/twigphp/events{/privacy}","received_events_url":"https://api.github.com/users/twigphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twigphp/Twig","description":"Twig, the flexible, fast, and secure template language for PHP","fork":false,"url":"https://api.github.com/repos/twigphp/Twig","forks_url":"https://api.github.com/repos/twigphp/Twig/forks","keys_url":"https://api.github.com/repos/twigphp/Twig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twigphp/Twig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twigphp/Twig/teams","hooks_url":"https://api.github.com/repos/twigphp/Twig/hooks","issue_events_url":"https://api.github.com/repos/twigphp/Twig/issues/events{/number}","events_url":"https://api.github.com/repos/twigphp/Twig/events","assignees_url":"https://api.github.com/repos/twigphp/Twig/assignees{/user}","branches_url":"https://api.github.com/repos/twigphp/Twig/branches{/branch}","tags_url":"https://api.github.com/repos/twigphp/Twig/tags","blobs_url":"https://api.github.com/repos/twigphp/Twig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twigphp/Twig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twigphp/Twig/git/refs{/sha}","trees_url":"https://api.github.com/repos/twigphp/Twig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twigphp/Twig/statuses/{sha}","languages_url":"https://api.github.com/repos/twigphp/Twig/languages","stargazers_url":"https://api.github.com/repos/twigphp/Twig/stargazers","contributors_url":"https://api.github.com/repos/twigphp/Twig/contributors","subscribers_url":"https://api.github.com/repos/twigphp/Twig/subscribers","subscription_url":"https://api.github.com/repos/twigphp/Twig/subscription","commits_url":"https://api.github.com/repos/twigphp/Twig/commits{/sha}","git_commits_url":"https://api.github.com/repos/twigphp/Twig/git/commits{/sha}","comments_url":"https://api.github.com/repos/twigphp/Twig/comments{/number}","issue_comment_url":"https://api.github.com/repos/twigphp/Twig/issues/comments{/number}","contents_url":"https://api.github.com/repos/twigphp/Twig/contents/{+path}","compare_url":"https://api.github.com/repos/twigphp/Twig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twigphp/Twig/merges","archive_url":"https://api.github.com/repos/twigphp/Twig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twigphp/Twig/downloads","issues_url":"https://api.github.com/repos/twigphp/Twig/issues{/number}","pulls_url":"https://api.github.com/repos/twigphp/Twig/pulls{/number}","milestones_url":"https://api.github.com/repos/twigphp/Twig/milestones{/number}","notifications_url":"https://api.github.com/repos/twigphp/Twig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twigphp/Twig/labels{/name}","releases_url":"https://api.github.com/repos/twigphp/Twig/releases{/id}","deployments_url":"https://api.github.com/repos/twigphp/Twig/deployments","created_at":"2009-10-07T21:23:38Z","updated_at":"2016-11-14T09:35:44Z","pushed_at":"2016-11-13T15:13:01Z","git_url":"git://github.com/twigphp/Twig.git","ssh_url":"git@github.com:twigphp/Twig.git","clone_url":"https://github.com/twigphp/Twig.git","svn_url":"https://github.com/twigphp/Twig","homepage":"http://twig.sensiolabs.org/","size":9789,"stargazers_count":3469,"watchers_count":3469,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":861,"mirror_url":null,"open_issues_count":70,"forks":861,"open_issues":70,"watchers":3469,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/twigphp/Twig/pulls/2249"},"html":{"href":"https://github.com/twigphp/Twig/pull/2249"},"issue":{"href":"https://api.github.com/repos/twigphp/Twig/issues/2249"},"comments":{"href":"https://api.github.com/repos/twigphp/Twig/issues/2249/comments"},"review_comments":{"href":"https://api.github.com/repos/twigphp/Twig/pulls/2249/comments"},"review_comment":{"href":"https://api.github.com/repos/twigphp/Twig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twigphp/Twig/pulls/2249/commits"},"statuses":{"href":"https://api.github.com/repos/twigphp/Twig/statuses/d64d320b4a3ac1bc8168a8c395a3e4297d9fd53e"}}}}
{"actor":{"display_login":"stof"}}