{"action":"created","issue":{"url":"https://api.github.com/repos/servo/saltfs/issues/264","repository_url":"https://api.github.com/repos/servo/saltfs","labels_url":"https://api.github.com/repos/servo/saltfs/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/servo/saltfs/issues/264/comments","events_url":"https://api.github.com/repos/servo/saltfs/issues/264/events","html_url":"https://github.com/servo/saltfs/issues/264","id":142647842,"number":264,"title":"Use Salt gitfs to keep master synced with repo","user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-22T13:20:43Z","updated_at":"2016-04-07T21:13:31Z","closed_at":null,"body":"Docs: https://docs.saltstack.com/en/2015.5/topics/tutorials/gitfs.html\r\n\r\nSalt has a built-in backend that uses a git repo (such as this one) to provide the files in the /srv/salt tree (the fileserver).\r\n\r\nWe should use it instead of manually `git pull`ing on the master."},"comment":{"url":"https://api.github.com/repos/servo/saltfs/issues/comments/207090635","html_url":"https://github.com/servo/saltfs/issues/264#issuecomment-207090635","issue_url":"https://api.github.com/repos/servo/saltfs/issues/264","id":207090635,"user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T21:13:31Z","updated_at":"2016-04-07T21:13:31Z","body":"We can pass a command line flag to the `salt` command to point to a different configuration directory, which lets us set up test configurations that point at local files to use interactively. This way, regular `salt` commands continue to use the gitfs fileserver backend, and we can set up separate temporary directories for testing. I'd recommend putting such directories in `/tmp` so they don't stick around too long.\r\n\r\nThat being said, testing in production makes me uneasy and I'd prefer to build a better testing story for our configurations, both making testing inside Vagrant easier and adding more automated functional tests. It's just too easy to forget to pass a command line flag to Salt (I've done this more times on my own setup than I'd like to admit)."}}