{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments/90389367","pull_request_review_id":10907345,"id":90389367,"diff_hunk":"@@ -82,15 +82,15 @@ protected bool IsDirty\n         /// </summary>\n         private T WaitForAsync<T>(Func<Task<T>> asyncFunc)\n         {\n-            return _threadHandling.ExecuteSynchronously<T>(asyncFunc);\n+            return _threadHandling != null ? _threadHandling.ExecuteSynchronously<T>(asyncFunc) : default(T);","path":"src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/PropertyPages/PropertyPage.cs","position":5,"original_position":5,"commit_id":"04fa4f5b4ee9d55702c6491838943a242e46777c","original_commit_id":"7299caf1caa63b6e9245cf913c68f0ab3e47d947","user":{"login":"davkean","id":1103906,"avatar_url":"https://avatars.githubusercontent.com/u/1103906?v=3","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},"body":"Hmm that doesn't seem right, you no longer execute the func. There's already a bug on this - I'd rather a fix that fixes calling this method in those cases.","created_at":"2016-12-01T06:20:42Z","updated_at":"2016-12-01T06:20:42Z","html_url":"https://github.com/dotnet/roslyn-project-system/pull/858#discussion_r90389367","pull_request_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/858","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments/90389367"},"html":{"href":"https://github.com/dotnet/roslyn-project-system/pull/858#discussion_r90389367"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/858"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/858","id":95993537,"html_url":"https://github.com/dotnet/roslyn-project-system/pull/858","diff_url":"https://github.com/dotnet/roslyn-project-system/pull/858.diff","patch_url":"https://github.com/dotnet/roslyn-project-system/pull/858.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/858","number":858,"state":"open","locked":false,"title":"Fix build events crash","user":{"login":"RaulPerez1","id":19919028,"avatar_url":"https://avatars.githubusercontent.com/u/19919028?v=3","gravatar_id":"","url":"https://api.github.com/users/RaulPerez1","html_url":"https://github.com/RaulPerez1","followers_url":"https://api.github.com/users/RaulPerez1/followers","following_url":"https://api.github.com/users/RaulPerez1/following{/other_user}","gists_url":"https://api.github.com/users/RaulPerez1/gists{/gist_id}","starred_url":"https://api.github.com/users/RaulPerez1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaulPerez1/subscriptions","organizations_url":"https://api.github.com/users/RaulPerez1/orgs","repos_url":"https://api.github.com/users/RaulPerez1/repos","events_url":"https://api.github.com/users/RaulPerez1/events{/privacy}","received_events_url":"https://api.github.com/users/RaulPerez1/received_events","type":"User","site_admin":false},"body":"Fixes the Visual Studio crash when the user tries to edit pre/post build events. Note that they still can't be edited (changes aren't saved) due to #857\r\n\r\nEscrow Template:\r\nCustomer scenario – Visual Studio crashes when the user tries clicking edit Pre/Post build events. \r\nBugs this fixes: #405 \r\nWorkarounds - N/A\r\nRisk – Low. This implements a COM interface (IVsBuildMacro) for the IVsHierarchy object for the project\r\nPerformance impact - None. This only executes when the hierarchy is casted to the interface  which only happens for the scenario above.\r\nIs this a regression? - From the old project system.\r\nRoot cause analysis - The old project system implemented this interface on the IVsHierarchy object and that hadn't been implemented in the new project system.\r\nHow was the bug found? - N/A","created_at":"2016-11-30T23:10:49Z","updated_at":"2016-12-01T06:20:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6803a75d7413e4a2db734fb8fa17eae693502ec3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/858/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/858/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/858/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/04fa4f5b4ee9d55702c6491838943a242e46777c","head":{"label":"RaulPerez1:FixBuildEventsCrash","ref":"FixBuildEventsCrash","sha":"04fa4f5b4ee9d55702c6491838943a242e46777c","user":{"login":"RaulPerez1","id":19919028,"avatar_url":"https://avatars.githubusercontent.com/u/19919028?v=3","gravatar_id":"","url":"https://api.github.com/users/RaulPerez1","html_url":"https://github.com/RaulPerez1","followers_url":"https://api.github.com/users/RaulPerez1/followers","following_url":"https://api.github.com/users/RaulPerez1/following{/other_user}","gists_url":"https://api.github.com/users/RaulPerez1/gists{/gist_id}","starred_url":"https://api.github.com/users/RaulPerez1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaulPerez1/subscriptions","organizations_url":"https://api.github.com/users/RaulPerez1/orgs","repos_url":"https://api.github.com/users/RaulPerez1/repos","events_url":"https://api.github.com/users/RaulPerez1/events{/privacy}","received_events_url":"https://api.github.com/users/RaulPerez1/received_events","type":"User","site_admin":false},"repo":{"id":73860347,"name":"roslyn-project-system","full_name":"RaulPerez1/roslyn-project-system","owner":{"login":"RaulPerez1","id":19919028,"avatar_url":"https://avatars.githubusercontent.com/u/19919028?v=3","gravatar_id":"","url":"https://api.github.com/users/RaulPerez1","html_url":"https://github.com/RaulPerez1","followers_url":"https://api.github.com/users/RaulPerez1/followers","following_url":"https://api.github.com/users/RaulPerez1/following{/other_user}","gists_url":"https://api.github.com/users/RaulPerez1/gists{/gist_id}","starred_url":"https://api.github.com/users/RaulPerez1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaulPerez1/subscriptions","organizations_url":"https://api.github.com/users/RaulPerez1/orgs","repos_url":"https://api.github.com/users/RaulPerez1/repos","events_url":"https://api.github.com/users/RaulPerez1/events{/privacy}","received_events_url":"https://api.github.com/users/RaulPerez1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RaulPerez1/roslyn-project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":true,"url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system","forks_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/forks","keys_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/teams","hooks_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/hooks","issue_events_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/issues/events{/number}","events_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/events","assignees_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/assignees{/user}","branches_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/branches{/branch}","tags_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/tags","blobs_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/languages","stargazers_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/stargazers","contributors_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/contributors","subscribers_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/subscribers","subscription_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/subscription","commits_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/contents/{+path}","compare_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/merges","archive_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/downloads","issues_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/issues{/number}","pulls_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/labels{/name}","releases_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/releases{/id}","deployments_url":"https://api.github.com/repos/RaulPerez1/roslyn-project-system/deployments","created_at":"2016-11-15T22:19:54Z","updated_at":"2016-11-15T22:19:57Z","pushed_at":"2016-12-01T03:31:13Z","git_url":"git://github.com/RaulPerez1/roslyn-project-system.git","ssh_url":"git@github.com:RaulPerez1/roslyn-project-system.git","clone_url":"https://github.com/RaulPerez1/roslyn-project-system.git","svn_url":"https://github.com/RaulPerez1/roslyn-project-system","homepage":null,"size":7707,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev15-rc2","ref":"dev15-rc2","sha":"a538286b3fd9b0c285b4f550b82933efeb3f49f6","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":56740275,"name":"roslyn-project-system","full_name":"dotnet/roslyn-project-system","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn-project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn-project-system","forks_url":"https://api.github.com/repos/dotnet/roslyn-project-system/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn-project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn-project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn-project-system/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn-project-system/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn-project-system/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn-project-system/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn-project-system/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn-project-system/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn-project-system/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn-project-system/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn-project-system/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn-project-system/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn-project-system/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn-project-system/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn-project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn-project-system/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn-project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn-project-system/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn-project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn-project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn-project-system/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn-project-system/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/deployments","created_at":"2016-04-21T03:40:18Z","updated_at":"2016-11-30T04:13:13Z","pushed_at":"2016-12-01T03:31:14Z","git_url":"git://github.com/dotnet/roslyn-project-system.git","ssh_url":"git@github.com:dotnet/roslyn-project-system.git","clone_url":"https://github.com/dotnet/roslyn-project-system.git","svn_url":"https://github.com/dotnet/roslyn-project-system","homepage":null,"size":9122,"stargazers_count":180,"watchers_count":180,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":305,"forks":45,"open_issues":305,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/858"},"html":{"href":"https://github.com/dotnet/roslyn-project-system/pull/858"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/858"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/858/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/858/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/858/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/04fa4f5b4ee9d55702c6491838943a242e46777c"}}}}
{"actor":{"display_login":"davkean"}}