{"action":"closed","issue":{"url":"https://api.github.com/repos/mate-desktop/caja/issues/683","repository_url":"https://api.github.com/repos/mate-desktop/caja","labels_url":"https://api.github.com/repos/mate-desktop/caja/issues/683/labels{/name}","comments_url":"https://api.github.com/repos/mate-desktop/caja/issues/683/comments","events_url":"https://api.github.com/repos/mate-desktop/caja/issues/683/events","html_url":"https://github.com/mate-desktop/caja/issues/683","id":190393963,"number":683,"title":"gtk3-migration-branch","user":{"login":"raveit65","id":961604,"avatar_url":"https://avatars.githubusercontent.com/u/961604?v=3","gravatar_id":"","url":"https://api.github.com/users/raveit65","html_url":"https://github.com/raveit65","followers_url":"https://api.github.com/users/raveit65/followers","following_url":"https://api.github.com/users/raveit65/following{/other_user}","gists_url":"https://api.github.com/users/raveit65/gists{/gist_id}","starred_url":"https://api.github.com/users/raveit65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raveit65/subscriptions","organizations_url":"https://api.github.com/users/raveit65/orgs","repos_url":"https://api.github.com/users/raveit65/repos","events_url":"https://api.github.com/users/raveit65/events{/privacy}","received_events_url":"https://api.github.com/users/raveit65/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":54,"created_at":"2016-11-18T18:52:14Z","updated_at":"2016-11-22T21:34:50Z","closed_at":"2016-11-22T21:34:50Z","body":"origin comment from @lukefromdc \r\nhttps://github.com/mate-desktop/caja/pull/618#issuecomment-261607255\r\n\r\nHere are some anwsers to questions raised in commit comments that can be difficult to find because of the length of that page. They appeared under indivdual changed files, of which there are 105 listed.\r\n\r\n1: A GTK_VERSION_CHECK inside a negation of it was found in the removal of the GTK3 selectors. This was almost certainly a result of using Pluma to replace all libunique selectors with GTK version selectors in the first commit. That gave very screwy results but somehow still built. That should all be gone with the next commit, the only remaining GTK_VERSION_CHECK instances should be those for specific GTK 3 versions. Those for 3.14 probably can go too, since previous discussion has indicated that only 3.14 and newer are to be supported and I've got configure.ac set up to require 3.14 or later\r\n\r\n2: init_css was removed from caja-application.c because that function is in the removed libunique block, in the GtkApplication block the equivalalent function is called init_icons_and_styles as there is more in it\r\n\r\n3: The caja-main.h file is not used in GtkApplication builds because the original Nautilus commits for GtkApplication removed nautilus-main.h and most of the porting was an application of these commits to Caja with only the changes needed\r\nto accomodate changes in Caja since it was forked off.\r\n\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/39364372-gtk3-migration-branch?utm_campaign=plugin&utm_content=tracker%2F651521&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F651521&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"}}
{"actor":{"display_login":"lukefromdc"}}