{"action":"created","comment":{"url":"https://api.github.com/repos/h2oai/sparkling-water/pulls/comments/92918265","pull_request_review_id":13443563,"id":92918265,"diff_hunk":"@@ -27,7 +28,7 @@ import org.apache.spark.repl.h2o.H2OInterpreter\n   * Configuration holder which is representing\n   * properties passed from user to Sparkling Water.\n   */\n-class H2OConf(@transient val sc: SparkContext) extends Logging with InternalBackendConf {\n+class H2OConf(@transient val sc: SparkContext) extends Logging with ExternalBackendConf with InternalBackendConf {","path":"core/src/main/scala/org/apache/spark/h2o/H2OConf.scala","position":13,"original_position":13,"commit_id":"4bdfac21d4dcd75c6eac8810a4006dc6d05b519a","original_commit_id":"4bdfac21d4dcd75c6eac8810a4006dc6d05b519a","user":{"login":"jakubhava","id":4374603,"avatar_url":"https://avatars.githubusercontent.com/u/4374603?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubhava","html_url":"https://github.com/jakubhava","followers_url":"https://api.github.com/users/jakubhava/followers","following_url":"https://api.github.com/users/jakubhava/following{/other_user}","gists_url":"https://api.github.com/users/jakubhava/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubhava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubhava/subscriptions","organizations_url":"https://api.github.com/users/jakubhava/orgs","repos_url":"https://api.github.com/users/jakubhava/repos","events_url":"https://api.github.com/users/jakubhava/events{/privacy}","received_events_url":"https://api.github.com/users/jakubhava/received_events","type":"User","site_admin":false},"body":"yup, I would prefer 2nd idea because it's also previous API and it's easier to call H2OConf(sc) then H2OConf(sc.conf)","created_at":"2016-12-17T08:53:02Z","updated_at":"2016-12-17T08:53:02Z","html_url":"https://github.com/h2oai/sparkling-water/pull/87#discussion_r92918265","pull_request_url":"https://api.github.com/repos/h2oai/sparkling-water/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/h2oai/sparkling-water/pulls/comments/92918265"},"html":{"href":"https://github.com/h2oai/sparkling-water/pull/87#discussion_r92918265"},"pull_request":{"href":"https://api.github.com/repos/h2oai/sparkling-water/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/h2oai/sparkling-water/pulls/87","id":86884980,"html_url":"https://github.com/h2oai/sparkling-water/pull/87","diff_url":"https://github.com/h2oai/sparkling-water/pull/87.diff","patch_url":"https://github.com/h2oai/sparkling-water/pull/87.patch","issue_url":"https://api.github.com/repos/h2oai/sparkling-water/issues/87","number":87,"state":"open","locked":false,"title":"External cluster implementation","user":{"login":"jakubhava","id":4374603,"avatar_url":"https://avatars.githubusercontent.com/u/4374603?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubhava","html_url":"https://github.com/jakubhava","followers_url":"https://api.github.com/users/jakubhava/followers","following_url":"https://api.github.com/users/jakubhava/following{/other_user}","gists_url":"https://api.github.com/users/jakubhava/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubhava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubhava/subscriptions","organizations_url":"https://api.github.com/users/jakubhava/orgs","repos_url":"https://api.github.com/users/jakubhava/repos","events_url":"https://api.github.com/users/jakubhava/events{/privacy}","received_events_url":"https://api.github.com/users/jakubhava/received_events","type":"User","site_admin":false},"body":"- implements core external cluster functionality\r\n- add support for testing external cluster locally with existing tests\r\n- add support to start h2o instances on yarn from sparkling-water\r\n\r\nTest can be run both locally and on yarn. Locally means that h2o cluster is started on the same machine and on yarn means the the cluster is started on yarn. In both cases we  need to set H2O_EXTENDED_JAR environmental property to path to either extended h2o jar or h2o driver jar.\r\n\r\nTo run tests on external backend locally:\r\n```export H2O_EXTENDED_JAR=`./gradlew -q extendJar -PdownloadH2O`\r\n ./gradlew build -x check -PbackendMod=external```\r\n\r\nTo run tests on external backend on yarn:\r\n```export H2O_EXTENDED_JAR=`./gradlew -q extendJar -PdownloadH2O=hadoop_version`\r\n ./gradlew build -x check -PbackendMode=external -PstartH2OClusterOnYarn```","created_at":"2016-09-27T08:41:11Z","updated_at":"2016-12-17T08:53:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"795da8cfdbdb08ac553ba1e0bb2ad98ba58b64c1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/h2oai/sparkling-water/pulls/87/commits","review_comments_url":"https://api.github.com/repos/h2oai/sparkling-water/pulls/87/comments","review_comment_url":"https://api.github.com/repos/h2oai/sparkling-water/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h2oai/sparkling-water/issues/87/comments","statuses_url":"https://api.github.com/repos/h2oai/sparkling-water/statuses/4bdfac21d4dcd75c6eac8810a4006dc6d05b519a","head":{"label":"h2oai:JH_SW-178_external_cluster","ref":"JH_SW-178_external_cluster","sha":"4bdfac21d4dcd75c6eac8810a4006dc6d05b519a","user":{"login":"h2oai","id":1402695,"avatar_url":"https://avatars.githubusercontent.com/u/1402695?v=3","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":25181584,"name":"sparkling-water","full_name":"h2oai/sparkling-water","owner":{"login":"h2oai","id":1402695,"avatar_url":"https://avatars.githubusercontent.com/u/1402695?v=3","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/h2oai/sparkling-water","description":"Sparkling Water provides H2O functionality inside Spark cluster","fork":false,"url":"https://api.github.com/repos/h2oai/sparkling-water","forks_url":"https://api.github.com/repos/h2oai/sparkling-water/forks","keys_url":"https://api.github.com/repos/h2oai/sparkling-water/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/sparkling-water/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/sparkling-water/teams","hooks_url":"https://api.github.com/repos/h2oai/sparkling-water/hooks","issue_events_url":"https://api.github.com/repos/h2oai/sparkling-water/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/sparkling-water/events","assignees_url":"https://api.github.com/repos/h2oai/sparkling-water/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/sparkling-water/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/sparkling-water/tags","blobs_url":"https://api.github.com/repos/h2oai/sparkling-water/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/sparkling-water/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/sparkling-water/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/sparkling-water/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/sparkling-water/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/sparkling-water/languages","stargazers_url":"https://api.github.com/repos/h2oai/sparkling-water/stargazers","contributors_url":"https://api.github.com/repos/h2oai/sparkling-water/contributors","subscribers_url":"https://api.github.com/repos/h2oai/sparkling-water/subscribers","subscription_url":"https://api.github.com/repos/h2oai/sparkling-water/subscription","commits_url":"https://api.github.com/repos/h2oai/sparkling-water/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/sparkling-water/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/sparkling-water/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/sparkling-water/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/sparkling-water/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/sparkling-water/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/sparkling-water/merges","archive_url":"https://api.github.com/repos/h2oai/sparkling-water/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/sparkling-water/downloads","issues_url":"https://api.github.com/repos/h2oai/sparkling-water/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/sparkling-water/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/sparkling-water/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/sparkling-water/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/sparkling-water/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/sparkling-water/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/sparkling-water/deployments","created_at":"2014-10-13T23:06:35Z","updated_at":"2016-12-15T14:33:29Z","pushed_at":"2016-12-17T00:01:14Z","git_url":"git://github.com/h2oai/sparkling-water.git","ssh_url":"git@github.com:h2oai/sparkling-water.git","clone_url":"https://github.com/h2oai/sparkling-water.git","svn_url":"https://github.com/h2oai/sparkling-water","homepage":"","size":12256,"stargazers_count":425,"watchers_count":425,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":22,"forks":180,"open_issues":22,"watchers":425,"default_branch":"master"}},"base":{"label":"h2oai:master","ref":"master","sha":"1489e2a762ba5559c4962cb3fe27c1ddd618a98f","user":{"login":"h2oai","id":1402695,"avatar_url":"https://avatars.githubusercontent.com/u/1402695?v=3","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":25181584,"name":"sparkling-water","full_name":"h2oai/sparkling-water","owner":{"login":"h2oai","id":1402695,"avatar_url":"https://avatars.githubusercontent.com/u/1402695?v=3","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/h2oai/sparkling-water","description":"Sparkling Water provides H2O functionality inside Spark cluster","fork":false,"url":"https://api.github.com/repos/h2oai/sparkling-water","forks_url":"https://api.github.com/repos/h2oai/sparkling-water/forks","keys_url":"https://api.github.com/repos/h2oai/sparkling-water/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/sparkling-water/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/sparkling-water/teams","hooks_url":"https://api.github.com/repos/h2oai/sparkling-water/hooks","issue_events_url":"https://api.github.com/repos/h2oai/sparkling-water/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/sparkling-water/events","assignees_url":"https://api.github.com/repos/h2oai/sparkling-water/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/sparkling-water/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/sparkling-water/tags","blobs_url":"https://api.github.com/repos/h2oai/sparkling-water/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/sparkling-water/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/sparkling-water/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/sparkling-water/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/sparkling-water/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/sparkling-water/languages","stargazers_url":"https://api.github.com/repos/h2oai/sparkling-water/stargazers","contributors_url":"https://api.github.com/repos/h2oai/sparkling-water/contributors","subscribers_url":"https://api.github.com/repos/h2oai/sparkling-water/subscribers","subscription_url":"https://api.github.com/repos/h2oai/sparkling-water/subscription","commits_url":"https://api.github.com/repos/h2oai/sparkling-water/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/sparkling-water/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/sparkling-water/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/sparkling-water/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/sparkling-water/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/sparkling-water/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/sparkling-water/merges","archive_url":"https://api.github.com/repos/h2oai/sparkling-water/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/sparkling-water/downloads","issues_url":"https://api.github.com/repos/h2oai/sparkling-water/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/sparkling-water/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/sparkling-water/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/sparkling-water/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/sparkling-water/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/sparkling-water/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/sparkling-water/deployments","created_at":"2014-10-13T23:06:35Z","updated_at":"2016-12-15T14:33:29Z","pushed_at":"2016-12-17T00:01:14Z","git_url":"git://github.com/h2oai/sparkling-water.git","ssh_url":"git@github.com:h2oai/sparkling-water.git","clone_url":"https://github.com/h2oai/sparkling-water.git","svn_url":"https://github.com/h2oai/sparkling-water","homepage":"","size":12256,"stargazers_count":425,"watchers_count":425,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":22,"forks":180,"open_issues":22,"watchers":425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2oai/sparkling-water/pulls/87"},"html":{"href":"https://github.com/h2oai/sparkling-water/pull/87"},"issue":{"href":"https://api.github.com/repos/h2oai/sparkling-water/issues/87"},"comments":{"href":"https://api.github.com/repos/h2oai/sparkling-water/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/h2oai/sparkling-water/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/h2oai/sparkling-water/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h2oai/sparkling-water/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/h2oai/sparkling-water/statuses/4bdfac21d4dcd75c6eac8810a4006dc6d05b519a"}}}}
{"actor":{"display_login":"jakubhava"}}