{"action":"created","comment":{"url":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments/61693283","id":61693283,"diff_hunk":"@@ -13,7 +14,15 @@\n # fva: function VA of decoding routine, global_address: VA of string if address is in global memory\n # or False\n # TODO va == global_address?","path":"floss/decoding_manager.py","position":11,"original_position":11,"commit_id":"9e6f0e20ad58ab0029d995bbd9b4534ffdfc4b85","original_commit_id":"9e6f0e20ad58ab0029d995bbd9b4534ffdfc4b85","user":{"login":"williballenthin","id":156560,"avatar_url":"https://avatars.githubusercontent.com/u/156560?v=3","gravatar_id":"","url":"https://api.github.com/users/williballenthin","html_url":"https://github.com/williballenthin","followers_url":"https://api.github.com/users/williballenthin/followers","following_url":"https://api.github.com/users/williballenthin/following{/other_user}","gists_url":"https://api.github.com/users/williballenthin/gists{/gist_id}","starred_url":"https://api.github.com/users/williballenthin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williballenthin/subscriptions","organizations_url":"https://api.github.com/users/williballenthin/orgs","repos_url":"https://api.github.com/users/williballenthin/repos","events_url":"https://api.github.com/users/williballenthin/events{/privacy}","received_events_url":"https://api.github.com/users/williballenthin/received_events","type":"User","site_admin":false},"body":"is global_address gone now?","created_at":"2016-05-01T21:18:11Z","updated_at":"2016-05-01T21:18:11Z","html_url":"https://github.com/fireeye/flare-floss/pull/125#discussion_r61693283","pull_request_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments/61693283"},"html":{"href":"https://github.com/fireeye/flare-floss/pull/125#discussion_r61693283"},"pull_request":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/fireeye/flare-floss/pulls/125","id":68482784,"html_url":"https://github.com/fireeye/flare-floss/pull/125","diff_url":"https://github.com/fireeye/flare-floss/pull/125.diff","patch_url":"https://github.com/fireeye/flare-floss/pull/125.patch","issue_url":"https://api.github.com/repos/fireeye/flare-floss/issues/125","number":125,"state":"open","locked":false,"title":"Include characteristics in DecodedString","user":{"login":"mr-tz","id":17606537,"avatar_url":"https://avatars.githubusercontent.com/u/17606537?v=3","gravatar_id":"","url":"https://api.github.com/users/mr-tz","html_url":"https://github.com/mr-tz","followers_url":"https://api.github.com/users/mr-tz/followers","following_url":"https://api.github.com/users/mr-tz/following{/other_user}","gists_url":"https://api.github.com/users/mr-tz/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-tz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-tz/subscriptions","organizations_url":"https://api.github.com/users/mr-tz/orgs","repos_url":"https://api.github.com/users/mr-tz/repos","events_url":"https://api.github.com/users/mr-tz/events{/privacy}","received_events_url":"https://api.github.com/users/mr-tz/received_events","type":"User","site_admin":false},"body":"Addresses #22. \r\nDisplay [STACK] or [HEAP] instead of more meaningless offsets, global addresses are still displayed.\r\nThe DecodedString tuple now includes a characteristics dictionary.","created_at":"2016-05-01T00:08:37Z","updated_at":"2016-05-01T21:18:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"529f22803df00260514a567c2b1baa3a4641a203","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/125/commits","review_comments_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/125/comments","review_comment_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/issues/125/comments","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/9e6f0e20ad58ab0029d995bbd9b4534ffdfc4b85","head":{"label":"fireeye:feature/string-characteristics","ref":"feature/string-characteristics","sha":"9e6f0e20ad58ab0029d995bbd9b4534ffdfc4b85","user":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"repo":{"id":52993349,"name":"flare-floss","full_name":"fireeye/flare-floss","owner":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fireeye/flare-floss","description":"FireEye Labs Obfuscated String Solver - Automatically extract obfuscated strings from malware.","fork":false,"url":"https://api.github.com/repos/fireeye/flare-floss","forks_url":"https://api.github.com/repos/fireeye/flare-floss/forks","keys_url":"https://api.github.com/repos/fireeye/flare-floss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireeye/flare-floss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireeye/flare-floss/teams","hooks_url":"https://api.github.com/repos/fireeye/flare-floss/hooks","issue_events_url":"https://api.github.com/repos/fireeye/flare-floss/issues/events{/number}","events_url":"https://api.github.com/repos/fireeye/flare-floss/events","assignees_url":"https://api.github.com/repos/fireeye/flare-floss/assignees{/user}","branches_url":"https://api.github.com/repos/fireeye/flare-floss/branches{/branch}","tags_url":"https://api.github.com/repos/fireeye/flare-floss/tags","blobs_url":"https://api.github.com/repos/fireeye/flare-floss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireeye/flare-floss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireeye/flare-floss/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireeye/flare-floss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/{sha}","languages_url":"https://api.github.com/repos/fireeye/flare-floss/languages","stargazers_url":"https://api.github.com/repos/fireeye/flare-floss/stargazers","contributors_url":"https://api.github.com/repos/fireeye/flare-floss/contributors","subscribers_url":"https://api.github.com/repos/fireeye/flare-floss/subscribers","subscription_url":"https://api.github.com/repos/fireeye/flare-floss/subscription","commits_url":"https://api.github.com/repos/fireeye/flare-floss/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireeye/flare-floss/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireeye/flare-floss/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireeye/flare-floss/contents/{+path}","compare_url":"https://api.github.com/repos/fireeye/flare-floss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireeye/flare-floss/merges","archive_url":"https://api.github.com/repos/fireeye/flare-floss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireeye/flare-floss/downloads","issues_url":"https://api.github.com/repos/fireeye/flare-floss/issues{/number}","pulls_url":"https://api.github.com/repos/fireeye/flare-floss/pulls{/number}","milestones_url":"https://api.github.com/repos/fireeye/flare-floss/milestones{/number}","notifications_url":"https://api.github.com/repos/fireeye/flare-floss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireeye/flare-floss/labels{/name}","releases_url":"https://api.github.com/repos/fireeye/flare-floss/releases{/id}","deployments_url":"https://api.github.com/repos/fireeye/flare-floss/deployments","created_at":"2016-03-02T20:16:10Z","updated_at":"2016-04-30T15:25:51Z","pushed_at":"2016-05-01T00:08:37Z","git_url":"git://github.com/fireeye/flare-floss.git","ssh_url":"git@github.com:fireeye/flare-floss.git","clone_url":"https://github.com/fireeye/flare-floss.git","svn_url":"https://github.com/fireeye/flare-floss","homepage":"","size":235,"stargazers_count":171,"watchers_count":171,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":27,"forks":25,"open_issues":27,"watchers":171,"default_branch":"master"}},"base":{"label":"fireeye:master","ref":"master","sha":"c277c87f379f0a44513acbca29a71740d463d8a5","user":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"repo":{"id":52993349,"name":"flare-floss","full_name":"fireeye/flare-floss","owner":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fireeye/flare-floss","description":"FireEye Labs Obfuscated String Solver - Automatically extract obfuscated strings from malware.","fork":false,"url":"https://api.github.com/repos/fireeye/flare-floss","forks_url":"https://api.github.com/repos/fireeye/flare-floss/forks","keys_url":"https://api.github.com/repos/fireeye/flare-floss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireeye/flare-floss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireeye/flare-floss/teams","hooks_url":"https://api.github.com/repos/fireeye/flare-floss/hooks","issue_events_url":"https://api.github.com/repos/fireeye/flare-floss/issues/events{/number}","events_url":"https://api.github.com/repos/fireeye/flare-floss/events","assignees_url":"https://api.github.com/repos/fireeye/flare-floss/assignees{/user}","branches_url":"https://api.github.com/repos/fireeye/flare-floss/branches{/branch}","tags_url":"https://api.github.com/repos/fireeye/flare-floss/tags","blobs_url":"https://api.github.com/repos/fireeye/flare-floss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireeye/flare-floss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireeye/flare-floss/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireeye/flare-floss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/{sha}","languages_url":"https://api.github.com/repos/fireeye/flare-floss/languages","stargazers_url":"https://api.github.com/repos/fireeye/flare-floss/stargazers","contributors_url":"https://api.github.com/repos/fireeye/flare-floss/contributors","subscribers_url":"https://api.github.com/repos/fireeye/flare-floss/subscribers","subscription_url":"https://api.github.com/repos/fireeye/flare-floss/subscription","commits_url":"https://api.github.com/repos/fireeye/flare-floss/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireeye/flare-floss/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireeye/flare-floss/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireeye/flare-floss/contents/{+path}","compare_url":"https://api.github.com/repos/fireeye/flare-floss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireeye/flare-floss/merges","archive_url":"https://api.github.com/repos/fireeye/flare-floss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireeye/flare-floss/downloads","issues_url":"https://api.github.com/repos/fireeye/flare-floss/issues{/number}","pulls_url":"https://api.github.com/repos/fireeye/flare-floss/pulls{/number}","milestones_url":"https://api.github.com/repos/fireeye/flare-floss/milestones{/number}","notifications_url":"https://api.github.com/repos/fireeye/flare-floss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireeye/flare-floss/labels{/name}","releases_url":"https://api.github.com/repos/fireeye/flare-floss/releases{/id}","deployments_url":"https://api.github.com/repos/fireeye/flare-floss/deployments","created_at":"2016-03-02T20:16:10Z","updated_at":"2016-04-30T15:25:51Z","pushed_at":"2016-05-01T00:08:37Z","git_url":"git://github.com/fireeye/flare-floss.git","ssh_url":"git@github.com:fireeye/flare-floss.git","clone_url":"https://github.com/fireeye/flare-floss.git","svn_url":"https://github.com/fireeye/flare-floss","homepage":"","size":235,"stargazers_count":171,"watchers_count":171,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":27,"forks":25,"open_issues":27,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/125"},"html":{"href":"https://github.com/fireeye/flare-floss/pull/125"},"issue":{"href":"https://api.github.com/repos/fireeye/flare-floss/issues/125"},"comments":{"href":"https://api.github.com/repos/fireeye/flare-floss/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/fireeye/flare-floss/statuses/9e6f0e20ad58ab0029d995bbd9b4534ffdfc4b85"}}}}