{"action":"created","comment":{"url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/comments/80905072","pull_request_review_id":1924570,"id":80905072,"diff_hunk":"@@ -21,13 +21,26 @@\n \n # The COSMOSCatalog doesn't need anything special other than registration as a valid input type.\n # However, we do make a custom Loader so that we can add a logger line with some information about\n-# the number of objects in the catalog that passed the initial cuts.\n+# the number of objects in the catalog that passed the initial cuts and other basic catalog info.\n from .input import RegisterInputType, InputLoader\n class COSMOSLoader(InputLoader):\n     def setupImage(self, cosmos_cat, config, base, logger):\n         if logger:\n-            logger.info(\"file %d: COSMOS catalog has %d total objects; %d passed initial cuts.\",\n-                        base['file_num'], cosmos_cat.getNTot(), cosmos_cat.getNObjects())\n+            if 'input' in base:\n+                if 'cosmos_catalog' in base['input']:\n+                    out_str = ''\n+                    if 'sample' in base['input']['cosmos_catalog'][0]:\n+                        out_str += '\\n  sample = %s'%base['input']['cosmos_catalog'][0]['sample']\n+                    if 'dir' in base['input']['cosmos_catalog'][0]:\n+                        out_str += '\\n  dir = %s'%base['input']['cosmos_catalog'][0]['dir']\n+                    if out_str != '':\n+                        logger.warning('Using user-specified COSMOSCatalog: %s',out_str)\n+            logger.warning(\"file %d: COSMOS catalog has %d total objects; %d passed initial cuts.\",\n+                           base['file_num'], cosmos_cat.getNTot(), cosmos_cat.getNObjects())","path":"galsim/config/input_cosmos.py","position":null,"original_position":22,"commit_id":"5da05b60bca51abdf752b300c7786b919f38f39b","original_commit_id":"b08ee40bed0e9a190d887f2864e415105ac03ab3","user":{"login":"rmandelb","id":1454906,"avatar_url":"https://avatars.githubusercontent.com/u/1454906?v=3","gravatar_id":"","url":"https://api.github.com/users/rmandelb","html_url":"https://github.com/rmandelb","followers_url":"https://api.github.com/users/rmandelb/followers","following_url":"https://api.github.com/users/rmandelb/following{/other_user}","gists_url":"https://api.github.com/users/rmandelb/gists{/gist_id}","starred_url":"https://api.github.com/users/rmandelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmandelb/subscriptions","organizations_url":"https://api.github.com/users/rmandelb/orgs","repos_url":"https://api.github.com/users/rmandelb/repos","events_url":"https://api.github.com/users/rmandelb/events{/privacy}","received_events_url":"https://api.github.com/users/rmandelb/received_events","type":"User","site_admin":false},"body":"> OTOH, perhaps it would make more sense to leave this particular line as info.\r\n\r\nGood point.  I just made that change.","created_at":"2016-09-28T12:39:07Z","updated_at":"2016-09-28T12:39:07Z","html_url":"https://github.com/GalSim-developers/GalSim/pull/807#discussion_r80905072","pull_request_url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/807","_links":{"self":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/comments/80905072"},"html":{"href":"https://github.com/GalSim-developers/GalSim/pull/807#discussion_r80905072"},"pull_request":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/807"}}},"pull_request":{"url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/807","id":87013435,"html_url":"https://github.com/GalSim-developers/GalSim/pull/807","diff_url":"https://github.com/GalSim-developers/GalSim/pull/807.diff","patch_url":"https://github.com/GalSim-developers/GalSim/pull/807.patch","issue_url":"https://api.github.com/repos/GalSim-developers/GalSim/issues/807","number":807,"state":"open","locked":false,"title":"#804 and #805","user":{"login":"rmandelb","id":1454906,"avatar_url":"https://avatars.githubusercontent.com/u/1454906?v=3","gravatar_id":"","url":"https://api.github.com/users/rmandelb","html_url":"https://github.com/rmandelb","followers_url":"https://api.github.com/users/rmandelb/followers","following_url":"https://api.github.com/users/rmandelb/following{/other_user}","gists_url":"https://api.github.com/users/rmandelb/gists{/gist_id}","starred_url":"https://api.github.com/users/rmandelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmandelb/subscriptions","organizations_url":"https://api.github.com/users/rmandelb/orgs","repos_url":"https://api.github.com/users/rmandelb/repos","events_url":"https://api.github.com/users/rmandelb/events{/privacy}","received_events_url":"https://api.github.com/users/rmandelb/received_events","type":"User","site_admin":false},"body":"This is a small PR that addresses both #804 and #805 (where work was done on branch #805).\r\n\r\nFor #805, the solution is exactly as written in the issue.\r\n\r\nFor #804, there were two changes:\r\n- make config say the basic info about the COSMOS catalog at the default verbosity level\r\n- make it say a bit more information as well\r\n\r\nSo for example, on master if I run cgc.yaml and tell it to use my version of the catalog sitting in a non-default directory, the output says nothing whatsoever about the catalog that is being used (you don't get that information until verbosity=2).  On branch #805, the output includes the following:\r\n```\r\nUsing user-specified COSMOSCatalog: \r\n  sample = 23.5\r\n  dir = /Users/rmandelb/great3/data-23.5/update_tarball/COSMOS_23.5_training_sample\r\nfile 0: COSMOS catalog has 56062 total objects; 21883 passed initial cuts.\r\nUsing parametric galaxies.\r\n```\r\n","created_at":"2016-09-27T21:13:49Z","updated_at":"2016-09-28T12:39:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ef8e2b8ff3c12a0aa9b1bdd5119ab7022611776","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/807/commits","review_comments_url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/807/comments","review_comment_url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GalSim-developers/GalSim/issues/807/comments","statuses_url":"https://api.github.com/repos/GalSim-developers/GalSim/statuses/5da05b60bca51abdf752b300c7786b919f38f39b","head":{"label":"GalSim-developers:#805","ref":"#805","sha":"5da05b60bca51abdf752b300c7786b919f38f39b","user":{"login":"GalSim-developers","id":1462196,"avatar_url":"https://avatars.githubusercontent.com/u/1462196?v=3","gravatar_id":"","url":"https://api.github.com/users/GalSim-developers","html_url":"https://github.com/GalSim-developers","followers_url":"https://api.github.com/users/GalSim-developers/followers","following_url":"https://api.github.com/users/GalSim-developers/following{/other_user}","gists_url":"https://api.github.com/users/GalSim-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/GalSim-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalSim-developers/subscriptions","organizations_url":"https://api.github.com/users/GalSim-developers/orgs","repos_url":"https://api.github.com/users/GalSim-developers/repos","events_url":"https://api.github.com/users/GalSim-developers/events{/privacy}","received_events_url":"https://api.github.com/users/GalSim-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":3510804,"name":"GalSim","full_name":"GalSim-developers/GalSim","owner":{"login":"GalSim-developers","id":1462196,"avatar_url":"https://avatars.githubusercontent.com/u/1462196?v=3","gravatar_id":"","url":"https://api.github.com/users/GalSim-developers","html_url":"https://github.com/GalSim-developers","followers_url":"https://api.github.com/users/GalSim-developers/followers","following_url":"https://api.github.com/users/GalSim-developers/following{/other_user}","gists_url":"https://api.github.com/users/GalSim-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/GalSim-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalSim-developers/subscriptions","organizations_url":"https://api.github.com/users/GalSim-developers/orgs","repos_url":"https://api.github.com/users/GalSim-developers/repos","events_url":"https://api.github.com/users/GalSim-developers/events{/privacy}","received_events_url":"https://api.github.com/users/GalSim-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GalSim-developers/GalSim","description":"The modular galaxy image simulation toolkit","fork":false,"url":"https://api.github.com/repos/GalSim-developers/GalSim","forks_url":"https://api.github.com/repos/GalSim-developers/GalSim/forks","keys_url":"https://api.github.com/repos/GalSim-developers/GalSim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GalSim-developers/GalSim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GalSim-developers/GalSim/teams","hooks_url":"https://api.github.com/repos/GalSim-developers/GalSim/hooks","issue_events_url":"https://api.github.com/repos/GalSim-developers/GalSim/issues/events{/number}","events_url":"https://api.github.com/repos/GalSim-developers/GalSim/events","assignees_url":"https://api.github.com/repos/GalSim-developers/GalSim/assignees{/user}","branches_url":"https://api.github.com/repos/GalSim-developers/GalSim/branches{/branch}","tags_url":"https://api.github.com/repos/GalSim-developers/GalSim/tags","blobs_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/refs{/sha}","trees_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GalSim-developers/GalSim/statuses/{sha}","languages_url":"https://api.github.com/repos/GalSim-developers/GalSim/languages","stargazers_url":"https://api.github.com/repos/GalSim-developers/GalSim/stargazers","contributors_url":"https://api.github.com/repos/GalSim-developers/GalSim/contributors","subscribers_url":"https://api.github.com/repos/GalSim-developers/GalSim/subscribers","subscription_url":"https://api.github.com/repos/GalSim-developers/GalSim/subscription","commits_url":"https://api.github.com/repos/GalSim-developers/GalSim/commits{/sha}","git_commits_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/commits{/sha}","comments_url":"https://api.github.com/repos/GalSim-developers/GalSim/comments{/number}","issue_comment_url":"https://api.github.com/repos/GalSim-developers/GalSim/issues/comments{/number}","contents_url":"https://api.github.com/repos/GalSim-developers/GalSim/contents/{+path}","compare_url":"https://api.github.com/repos/GalSim-developers/GalSim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GalSim-developers/GalSim/merges","archive_url":"https://api.github.com/repos/GalSim-developers/GalSim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GalSim-developers/GalSim/downloads","issues_url":"https://api.github.com/repos/GalSim-developers/GalSim/issues{/number}","pulls_url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls{/number}","milestones_url":"https://api.github.com/repos/GalSim-developers/GalSim/milestones{/number}","notifications_url":"https://api.github.com/repos/GalSim-developers/GalSim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GalSim-developers/GalSim/labels{/name}","releases_url":"https://api.github.com/repos/GalSim-developers/GalSim/releases{/id}","deployments_url":"https://api.github.com/repos/GalSim-developers/GalSim/deployments","created_at":"2012-02-22T02:51:45Z","updated_at":"2016-09-28T00:48:31Z","pushed_at":"2016-09-28T12:37:52Z","git_url":"git://github.com/GalSim-developers/GalSim.git","ssh_url":"git@github.com:GalSim-developers/GalSim.git","clone_url":"https://github.com/GalSim-developers/GalSim.git","svn_url":"https://github.com/GalSim-developers/GalSim","homepage":"","size":128939,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":56,"forks":37,"open_issues":56,"watchers":56,"default_branch":"releases/1.4"}},"base":{"label":"GalSim-developers:master","ref":"master","sha":"f5613e32a07f637af01197817a3e1dded44c6a44","user":{"login":"GalSim-developers","id":1462196,"avatar_url":"https://avatars.githubusercontent.com/u/1462196?v=3","gravatar_id":"","url":"https://api.github.com/users/GalSim-developers","html_url":"https://github.com/GalSim-developers","followers_url":"https://api.github.com/users/GalSim-developers/followers","following_url":"https://api.github.com/users/GalSim-developers/following{/other_user}","gists_url":"https://api.github.com/users/GalSim-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/GalSim-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalSim-developers/subscriptions","organizations_url":"https://api.github.com/users/GalSim-developers/orgs","repos_url":"https://api.github.com/users/GalSim-developers/repos","events_url":"https://api.github.com/users/GalSim-developers/events{/privacy}","received_events_url":"https://api.github.com/users/GalSim-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":3510804,"name":"GalSim","full_name":"GalSim-developers/GalSim","owner":{"login":"GalSim-developers","id":1462196,"avatar_url":"https://avatars.githubusercontent.com/u/1462196?v=3","gravatar_id":"","url":"https://api.github.com/users/GalSim-developers","html_url":"https://github.com/GalSim-developers","followers_url":"https://api.github.com/users/GalSim-developers/followers","following_url":"https://api.github.com/users/GalSim-developers/following{/other_user}","gists_url":"https://api.github.com/users/GalSim-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/GalSim-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalSim-developers/subscriptions","organizations_url":"https://api.github.com/users/GalSim-developers/orgs","repos_url":"https://api.github.com/users/GalSim-developers/repos","events_url":"https://api.github.com/users/GalSim-developers/events{/privacy}","received_events_url":"https://api.github.com/users/GalSim-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GalSim-developers/GalSim","description":"The modular galaxy image simulation toolkit","fork":false,"url":"https://api.github.com/repos/GalSim-developers/GalSim","forks_url":"https://api.github.com/repos/GalSim-developers/GalSim/forks","keys_url":"https://api.github.com/repos/GalSim-developers/GalSim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GalSim-developers/GalSim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GalSim-developers/GalSim/teams","hooks_url":"https://api.github.com/repos/GalSim-developers/GalSim/hooks","issue_events_url":"https://api.github.com/repos/GalSim-developers/GalSim/issues/events{/number}","events_url":"https://api.github.com/repos/GalSim-developers/GalSim/events","assignees_url":"https://api.github.com/repos/GalSim-developers/GalSim/assignees{/user}","branches_url":"https://api.github.com/repos/GalSim-developers/GalSim/branches{/branch}","tags_url":"https://api.github.com/repos/GalSim-developers/GalSim/tags","blobs_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/refs{/sha}","trees_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GalSim-developers/GalSim/statuses/{sha}","languages_url":"https://api.github.com/repos/GalSim-developers/GalSim/languages","stargazers_url":"https://api.github.com/repos/GalSim-developers/GalSim/stargazers","contributors_url":"https://api.github.com/repos/GalSim-developers/GalSim/contributors","subscribers_url":"https://api.github.com/repos/GalSim-developers/GalSim/subscribers","subscription_url":"https://api.github.com/repos/GalSim-developers/GalSim/subscription","commits_url":"https://api.github.com/repos/GalSim-developers/GalSim/commits{/sha}","git_commits_url":"https://api.github.com/repos/GalSim-developers/GalSim/git/commits{/sha}","comments_url":"https://api.github.com/repos/GalSim-developers/GalSim/comments{/number}","issue_comment_url":"https://api.github.com/repos/GalSim-developers/GalSim/issues/comments{/number}","contents_url":"https://api.github.com/repos/GalSim-developers/GalSim/contents/{+path}","compare_url":"https://api.github.com/repos/GalSim-developers/GalSim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GalSim-developers/GalSim/merges","archive_url":"https://api.github.com/repos/GalSim-developers/GalSim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GalSim-developers/GalSim/downloads","issues_url":"https://api.github.com/repos/GalSim-developers/GalSim/issues{/number}","pulls_url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls{/number}","milestones_url":"https://api.github.com/repos/GalSim-developers/GalSim/milestones{/number}","notifications_url":"https://api.github.com/repos/GalSim-developers/GalSim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GalSim-developers/GalSim/labels{/name}","releases_url":"https://api.github.com/repos/GalSim-developers/GalSim/releases{/id}","deployments_url":"https://api.github.com/repos/GalSim-developers/GalSim/deployments","created_at":"2012-02-22T02:51:45Z","updated_at":"2016-09-28T00:48:31Z","pushed_at":"2016-09-28T12:37:52Z","git_url":"git://github.com/GalSim-developers/GalSim.git","ssh_url":"git@github.com:GalSim-developers/GalSim.git","clone_url":"https://github.com/GalSim-developers/GalSim.git","svn_url":"https://github.com/GalSim-developers/GalSim","homepage":"","size":128939,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":56,"forks":37,"open_issues":56,"watchers":56,"default_branch":"releases/1.4"}},"_links":{"self":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/807"},"html":{"href":"https://github.com/GalSim-developers/GalSim/pull/807"},"issue":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/issues/807"},"comments":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/statuses/5da05b60bca51abdf752b300c7786b919f38f39b"}}}}
{"actor":{"display_login":"rmandelb"}}