{"push_id":1121312782,"size":81,"distinct_size":1,"ref":"refs/heads/pmattis/batch-builder","head":"40b531d7a72f773f8bc84ab406908d2c763254ee","before":"691aac1dc9188ecabf745629ef8b5db811a8f96e","commits":[{"sha":"c0f9b5629fcbf02aac66b479096ee16a2546c6d1","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: fix a bug in purging old leases\n\nIterating over an aliased slice caused some leases to not be removed.\n\nA test for this will be added in the later commit with the other tests\nbecause it needs some methods in the LeaseManager that don't exist yet.","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/c0f9b5629fcbf02aac66b479096ee16a2546c6d1"},{"sha":"e18db5d657f94fc6cd2484cb44a3bcd904d37d01","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: integrate the table name cache with the leases\n\nSo here the problem: before this change, the planner had a cache used\nto resolve table names to descriptor ids. This cache was updated by\ngossip, async wrt the schema change transaction. This meant that the\nname of a deleted table could be resolved to the old id for a while\nafter the drop committed. #5483\n\nThis change moves the cache into the leasing subsystem - a name is only\nresolved to a table we have lease on, guaranteeing that the name is\nvalid.\n\nThis change in isolation makes things slightly worse than they were for\nRENAME: RENAME is not a schema change; leases are not retracted when\nwe're about to perform a rename. RENAME does however trigger a gossip\nupdate, which used to update the name cache. Now, the new cache is only\nupdated as a result of new descriptor versions being published, which is\nnot the case. The next commit makes RENAME be a proper schema change\nthat increments the descriptor version.\n\nfixes #5483","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/e18db5d657f94fc6cd2484cb44a3bcd904d37d01"},{"sha":"0f259058bbe636c240a0ff9aba65822813fc9c2b","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: make RENAME TABLE a schema change\n\nSplitting the RENAME into a sync part (updating the descriptor) and an\nasync part (deleting the mapping of the old name to the id) makes it so\nthat the table name cache in LeaseManager can be reliably used to\nresolve names: the schema changer waits until the old name is not in\nuse any more before removing the mapping, and the name cache is\nguaranteed to have been updated when the transaction doing the RENAME\nreturns.","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/0f259058bbe636c240a0ff9aba65822813fc9c2b"},{"sha":"463b6ffb1a1b134fcee1ea2d588ae721663ba38f","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: move getTableID to its only user - sql/internal","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/463b6ffb1a1b134fcee1ea2d588ae721663ba38f"},{"sha":"cf124cf6ae20a5bf2f223708bdc842096bbe3787","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: testing knobs improvements\n\n- expose the LeaseManager through the testing shim\n- expose the clock through the testing shim\n- add a new notification type for rename schema changes","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/cf124cf6ae20a5bf2f223708bdc842096bbe3787"},{"sha":"6bf3fe379d91fbc0b3c383762e7595a16afc5b75","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: add more leasing and rename tests","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/6bf3fe379d91fbc0b3c383762e7595a16afc5b75"},{"sha":"29b5b77f31c51f67d12ea76725491e24ecdf1364","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: panic on unreachable SimpleTableExpr type","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/29b5b77f31c51f67d12ea76725491e24ecdf1364"},{"sha":"84ff5f4b3d34b863d1ae977ff351860031ccce0c","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Add issue number into join error message","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/84ff5f4b3d34b863d1ae977ff351860031ccce0c"},{"sha":"a7e445699e28b8c4404350c0b3279463fae84081","author":{"email":"ec1657b07dda0ff6262dc7efd2e7e3cc188a9ea2@gmail.com","name":"Radu Berinde"},"message":"sql: don't show sql.go in reviewable diffs\n\nReviewable won't show autogenerated files in diffs, and one way it figures that\nout is to look for a `GENERATED FILE DO NOT EDIT` comment (see\nhttps://github.com/Reviewable/Reviewable/wiki/FAQ#how-do-i-tell-reviewable-that-a-file-is-generated-and-should-not-be-reviewed).\n\nAdding it to sql.go.","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/a7e445699e28b8c4404350c0b3279463fae84081"},{"sha":"4f2312acaf7032d99f3020cd564f5fd8f64a277f","author":{"email":"2e212ebba9302a65e9fd21f6772368fe60592fe8@cockroachlabs.com","name":"Tristan Rice"},"message":"server: refactor most of status endpoints to be provided over grpc as well as over HTTP\n\nThis fixes most of #5530 by proxying requests over the standard grpc\nconnection instead of the http admin interface on a different port.\n\nMost of these changes are automatically generated protobuf output.\n\nConverted endpoints:\n- /_status/details/{node_id}\n- /health\n- /_status/nodes\n- /_status/nodes/{node_id}\n- /_status/ranges/{node_id}\n- /_status/gossip/{node_id}\n\nThings that remain as http and will be converted in a later PR:\n- /_status/logs/{node_id}\n- /_status/logfiles/{node_id}\n- /_status/logfiles/{node_id}/{file}\n- /_status/metrics/{node_id}\n- /_status/stacks/{node_id} - Will probably remain as just HTTP.","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/4f2312acaf7032d99f3020cd564f5fd8f64a277f"},{"sha":"bd230b99e6200684d945de6d82bcf6186e80be6b","author":{"email":"2e212ebba9302a65e9fd21f6772368fe60592fe8@cockroachlabs.com","name":"Tristan Rice"},"message":"Converted /_status/gossip/{node_id} to use grpc","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/bd230b99e6200684d945de6d82bcf6186e80be6b"},{"sha":"7db3c55f42305b226307e2fe665231e134d3c885","author":{"email":"6939278d66e34fcfb23131504217025e78249a8b@fn.lc","name":"Tristan Rice"},"message":"Merge pull request #6702 from d4l3k/status-redirects\n\nserver: refactor most of status endpoints to be provided over grpc with grpc-gateway for http","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/7db3c55f42305b226307e2fe665231e134d3c885"},{"sha":"dbbf27bb38187f15f21c2cd165cc1c697af518ce","author":{"email":"5a8372f5628deb22ab258f403701c7c55f2b695f@gmail.com","name":"Andrei Matei"},"message":"Merge pull request #6595 from andreimatei/rename\n\nsql: integrate the name cache with the lease system; remove rename races","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/dbbf27bb38187f15f21c2cd165cc1c697af518ce"},{"sha":"33d66464bff8a226f3363d1465f11ed14a15cddb","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"storage: Give up lease acquisition when draining\n\nThis establishes parity with the other case (in which the task does not even\nget started) and should address a relatively common reason for an invocation\nof `./cockroach quit` to run into the hard limit.","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/33d66464bff8a226f3363d1465f11ed14a15cddb"},{"sha":"12475580960aac81038850fb78b7e857b11f4871","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"Merge pull request #6777 from tschottdorf/lease-quit\n\nstorage: Give up lease acquisition when draining","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/12475580960aac81038850fb78b7e857b11f4871"},{"sha":"0707de0f091b988f80cb0c57d302232a64f98f35","author":{"email":"1fa2ef4755a9226cb9a0a4840bd89b158ac71391@cockroachlabs.com","name":"Matt Tracy"},"message":"ui next: Nodes Graphs Tab, StackedAreaChart\n\nConvert existing graphs from nodes graphs page.\n\n`GraphGroup` has been promoted to its own component, shared by any page which\ndisplays multiple graphs.\n\n`Metric` can now specify max/min for both downsampler and source aggregator.\n\nCommit also creates `StackedAreaGraph`, an alternative to `LineGraph` which was\nindicated in the previous UI by a `.stacked()` option on the normal LineGraph.\nThere is some apparent code duplication, but due to the lack of a common\ninterface between NVD3's LineChart and StackedAreaChart components, some of this\nduplication is inevitable. A suggestion has been logged in the app.tsx","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/0707de0f091b988f80cb0c57d302232a64f98f35"},{"sha":"a15c56fb54ffd188625a64b4017f90a9b5d207bd","author":{"email":"b916e94d63c4d551e8d54e7a93ea400ef994acf0@gmail.com","name":"David Taylor"},"message":"Revert \"acceptance: disable TestDockerFinagle\"\n\nThis reverts commit a54ff6997ba5da3ee02eb93c533da2bf49ca2476.\n\nThe flakiness looked like the DROP TABLE issue fixed by #6215.\n\nCloses #5951.","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/a15c56fb54ffd188625a64b4017f90a9b5d207bd"},{"sha":"b1e6096f671db2acde3feed22e6e70541600d0da","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Create new BenchmarkSelect3 that quantifies numeric type processing","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/b1e6096f671db2acde3feed22e6e70541600d0da"},{"sha":"e296195aae74cda5c4752e82ed0ad46ffc807291","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql/parser: Switch default numeric value to DECIMAL\n\nResolves #6369.\n\nThis change switches the default non-int constant value to DECIMAL.\nThis prevents any information loss for constant literals.\n\nThe test changes focused on explicitly casting old constants to FLOAT\nto prevent code coverage regressions.","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/e296195aae74cda5c4752e82ed0ad46ffc807291"},{"sha":"79ea73814e3d652fdb28fa5bd62c79e50fb4f241","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"cli: remove `exterminate`\n\nWhether we ultimately want a command like that is not determined (see #6197),\nbut the code isn't currently working correctly (#6196) and it's set up in the\nlegacy way, which hinders the upcoming migration of the `quit` command.\nA re-implementation of the code would likely want to erase the data on the\nserver side (and not from the cli).\n\ncc @BramGruneir\ncc @jseldess for documentation\n\nCloses #6197, closes #6198.","distinct":false,"url":"https://api.github.com/repos/petermattis/cockroach/commits/79ea73814e3d652fdb28fa5bd62c79e50fb4f241"}]}
{"actor":{"display_login":"petermattis"}}