{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/78864619","id":78864619,"diff_hunk":"@@ -399,9 +407,8 @@ def _fit_ovo_binary(estimator, X, y, i, j):\n     y_binary = np.empty(y.shape, np.int)\n     y_binary[y == i] = 0\n     y_binary[y == j] = 1\n-    ind = np.arange(X.shape[0])\n-    return _fit_binary(estimator, X[ind[cond]], y_binary, classes=[i, j])\n-\n+    indcond = np.arange(X.shape[0])[cond]\n+    return _fit_binary(estimator, _safe_split(estimator, X, None, indices=indcond)[0], y_binary, classes=[i, j]) , indcond","path":"sklearn/multiclass.py","position":37,"original_position":37,"commit_id":"bbb2122cb09fb0c36b6250b66db6108793daddd0","original_commit_id":"efae07a196e866d0b3d02d93f9e4aa5c963ad968","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"PEP8","created_at":"2016-09-14T23:36:36Z","updated_at":"2016-09-14T23:38:20Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7350#discussion_r78864619","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7350","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/78864619"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7350#discussion_r78864619"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7350"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7350","id":84179924,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/7350","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7350.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7350.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7350","number":7350,"state":"open","locked":false,"title":"[MRG] Add OneVs{One,All}Classifier._pairwise: fix for #7306","user":{"login":"rsmith54","id":8311342,"avatar_url":"https://avatars.githubusercontent.com/u/8311342?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmith54","html_url":"https://github.com/rsmith54","followers_url":"https://api.github.com/users/rsmith54/followers","following_url":"https://api.github.com/users/rsmith54/following{/other_user}","gists_url":"https://api.github.com/users/rsmith54/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmith54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmith54/subscriptions","organizations_url":"https://api.github.com/users/rsmith54/orgs","repos_url":"https://api.github.com/users/rsmith54/repos","events_url":"https://api.github.com/users/rsmith54/events{/privacy}","received_events_url":"https://api.github.com/users/rsmith54/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n<!-- Example: Fixes #1234 -->\r\n\r\nFixes #7306.\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nAdds ```_pairwise``` to ```OneVsOneClassifier``` and ```OneVsAllClassifier```  and adds a test to check this is properly set.\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n\r\n","created_at":"2016-09-06T19:17:58Z","updated_at":"2016-09-14T23:38:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"668232647dd320ab94ea836889244f828a254fcb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7350/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7350/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7350/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/bbb2122cb09fb0c36b6250b66db6108793daddd0","head":{"label":"rsmith54:bugfix/pairwise","ref":"bugfix/pairwise","sha":"bbb2122cb09fb0c36b6250b66db6108793daddd0","user":{"login":"rsmith54","id":8311342,"avatar_url":"https://avatars.githubusercontent.com/u/8311342?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmith54","html_url":"https://github.com/rsmith54","followers_url":"https://api.github.com/users/rsmith54/followers","following_url":"https://api.github.com/users/rsmith54/following{/other_user}","gists_url":"https://api.github.com/users/rsmith54/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmith54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmith54/subscriptions","organizations_url":"https://api.github.com/users/rsmith54/orgs","repos_url":"https://api.github.com/users/rsmith54/repos","events_url":"https://api.github.com/users/rsmith54/events{/privacy}","received_events_url":"https://api.github.com/users/rsmith54/received_events","type":"User","site_admin":false},"repo":{"id":67516960,"name":"scikit-learn","full_name":"rsmith54/scikit-learn","owner":{"login":"rsmith54","id":8311342,"avatar_url":"https://avatars.githubusercontent.com/u/8311342?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmith54","html_url":"https://github.com/rsmith54","followers_url":"https://api.github.com/users/rsmith54/followers","following_url":"https://api.github.com/users/rsmith54/following{/other_user}","gists_url":"https://api.github.com/users/rsmith54/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmith54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmith54/subscriptions","organizations_url":"https://api.github.com/users/rsmith54/orgs","repos_url":"https://api.github.com/users/rsmith54/repos","events_url":"https://api.github.com/users/rsmith54/events{/privacy}","received_events_url":"https://api.github.com/users/rsmith54/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsmith54/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/rsmith54/scikit-learn","forks_url":"https://api.github.com/repos/rsmith54/scikit-learn/forks","keys_url":"https://api.github.com/repos/rsmith54/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsmith54/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsmith54/scikit-learn/teams","hooks_url":"https://api.github.com/repos/rsmith54/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/rsmith54/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/rsmith54/scikit-learn/events","assignees_url":"https://api.github.com/repos/rsmith54/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/rsmith54/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/rsmith54/scikit-learn/tags","blobs_url":"https://api.github.com/repos/rsmith54/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsmith54/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsmith54/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsmith54/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsmith54/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/rsmith54/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/rsmith54/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/rsmith54/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/rsmith54/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/rsmith54/scikit-learn/subscription","commits_url":"https://api.github.com/repos/rsmith54/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsmith54/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsmith54/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsmith54/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsmith54/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/rsmith54/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsmith54/scikit-learn/merges","archive_url":"https://api.github.com/repos/rsmith54/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsmith54/scikit-learn/downloads","issues_url":"https://api.github.com/repos/rsmith54/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/rsmith54/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/rsmith54/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/rsmith54/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsmith54/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/rsmith54/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/rsmith54/scikit-learn/deployments","created_at":"2016-09-06T14:44:02Z","updated_at":"2016-09-06T14:44:10Z","pushed_at":"2016-09-14T23:36:30Z","git_url":"git://github.com/rsmith54/scikit-learn.git","ssh_url":"git@github.com:rsmith54/scikit-learn.git","clone_url":"https://github.com/rsmith54/scikit-learn.git","svn_url":"https://github.com/rsmith54/scikit-learn","homepage":"http://scikit-learn.org","size":74863,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"016f3d522f005ad41fa61ffba72bd985c4e0cac3","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-09-14T22:37:53Z","pushed_at":"2016-09-14T23:36:31Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":123983,"stargazers_count":13399,"watchers_count":13399,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7710,"mirror_url":null,"open_issues_count":1228,"forks":7710,"open_issues":1228,"watchers":13399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7350"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7350"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7350"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7350/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7350/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7350/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/bbb2122cb09fb0c36b6250b66db6108793daddd0"}}}}
{"actor":{"display_login":"jnothman"}}