{"action":"created","comment":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/87702897","pull_request_review_id":8306877,"id":87702897,"diff_hunk":"@@ -0,0 +1,110 @@\n+# Copyright 1999-2016 Gentoo Foundation\n+# Distributed under the terms of the GNU General Public License v2\n+# $Id$\n+\n+EAPI=6\n+\n+PYTHON_COMPAT=( python{2_7,3_4,3_5} )\n+\n+inherit qmake-utils python-r1\n+\n+DESCRIPTION=\"A dynamic Python binding for the Qt framework\"\n+HOMEPAGE=\"http://pythonqt.sourceforge.net/\"\n+SRC_URI=\"mirror://sourceforge/pythonqt/pythonqt/${PN}-${PV}/${PN}${PV}.zip\"\n+\n+LICENSE=\"LGPL-2.1\"\n+SLOT=\"0\"\n+KEYWORDS=\"~x86 ~amd64\"\n+IUSE=\"doc examples +extensions tests webkit\"\n+REQUIRED_USE=\"webkit? ( extensions ) ${PYTHON_REQUIRED_USE}\"\n+\n+RDEPEND=\"${PYTHON_DEPS}\n+\tdev-qt/qtcore:5\n+\tdev-qt/qtgui:5\n+\tdev-qt/qtwidgets:5\n+\textensions? (\n+\t\tdev-qt/qtsvg:5\n+\t\tdev-qt/qtsql:5\n+\t\tdev-qt/qtnetwork:5\n+\t\tdev-qt/qtxml:5\n+\t\tdev-qt/qtxmlpatterns:5\n+\t\tdev-qt/qtopengl:5\n+\t\tdev-qt/qtprintsupport:5\n+\t\tdev-qt/qtmultimedia:5[widgets]\n+\t\tdev-qt/qtdeclarative:5[widgets]\n+\t\tdev-qt/designer:5\n+\t)\n+\twebkit? ( dev-qt/qtwebkit:5 )\n+\t\"\n+DEPEND=\"${RDEPEND}\n+\t!extensions? ( dev-qt/qtxml:5 )\n+\tdoc? ( app-doc/doxygen )\n+\tvirtual/pkgconfig\"\n+\n+S=\"${WORKDIR}/${PN}${PV}\"\n+\n+# Bring uitools back, backport other fixes from trunk\n+PATCHES=( \"${FILESDIR}/${P}-commit-433-441.patch\" )\n+\n+src_prepare() {\n+\tdefault\n+\n+\tif ! use extensions ; then\n+\t\tsed -i 's/extensions//' ${PN}.pro || die \"sed for extensions\"\n+\tfi\n+\tif ! use tests ; then\n+\t\tsed -i 's/tests//' ${PN}.pro || die \"sed for tests\"\n+\tfi\n+\tif ! use examples ; then\n+\t\tsed -i 's/examples//' ${PN}.pro || die \"sed for examples\"\n+\tfi\n+\tif ! use webkit ; then\n+\t\t# Remove webkit support if not used\n+\t\tsed -i '/qtHaveModule(webkit):CONFIG += PythonQtWebKit/d' \\\n+\t\t\textensions/PythonQt_QtAll/PythonQt_QtAll.pro \\\n+\t\t\t|| die \"sed for webkit\"\n+\tfi\n+\n+\t# Set python version to use\n+\tpython_foreach_impl \\\n+\t\tsed -i \"s/unix:PYTHON_VERSION=2.7/unix:PYTHON_VERSION=${EPYTHON/#python/}/\" \\","path":"dev-python/PythonQt/PythonQt-3.1.ebuild","position":null,"original_position":70,"commit_id":"fe7327f4ed45810e4abb72c7bb4a3afa75c4ca3d","original_commit_id":"e9921124aaf653a2490cb96745cf76bc578200ef","user":{"login":"SpiderX","id":277573,"avatar_url":"https://avatars.githubusercontent.com/u/277573?v=3","gravatar_id":"","url":"https://api.github.com/users/SpiderX","html_url":"https://github.com/SpiderX","followers_url":"https://api.github.com/users/SpiderX/followers","following_url":"https://api.github.com/users/SpiderX/following{/other_user}","gists_url":"https://api.github.com/users/SpiderX/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderX/subscriptions","organizations_url":"https://api.github.com/users/SpiderX/orgs","repos_url":"https://api.github.com/users/SpiderX/repos","events_url":"https://api.github.com/users/SpiderX/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderX/received_events","type":"User","site_admin":false},"body":"You a partially right.\r\nBash really substitutes EPYTHON before python_foreach_imp, and sed's execution results in unseted PYTHON_VERSION variable.\r\nBut ebuild was tested and worked, because later (after PYTHON_VERSION=\"\") it used an active python version:\r\n\r\n> unix:LIBS += $$system(python$${PYTHON_VERSION}-config --libs)\r\n\r\nThat's why I think that it will be better just unset PYTHON_VERSION and use active python-config.\r\nAll other your comments took into account and implemented.","created_at":"2016-11-13T00:14:02Z","updated_at":"2016-11-13T00:14:02Z","html_url":"https://github.com/gentoo/gentoo/pull/2634#discussion_r87702897","pull_request_url":"https://api.github.com/repos/gentoo/gentoo/pulls/2634","_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/87702897"},"html":{"href":"https://github.com/gentoo/gentoo/pull/2634#discussion_r87702897"},"pull_request":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/2634"}}},"pull_request":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/2634","id":90488090,"html_url":"https://github.com/gentoo/gentoo/pull/2634","diff_url":"https://github.com/gentoo/gentoo/pull/2634.diff","patch_url":"https://github.com/gentoo/gentoo/pull/2634.patch","issue_url":"https://api.github.com/repos/gentoo/gentoo/issues/2634","number":2634,"state":"open","locked":false,"title":"dev-python/PythonQt: new ebuild","user":{"login":"SpiderX","id":277573,"avatar_url":"https://avatars.githubusercontent.com/u/277573?v=3","gravatar_id":"","url":"https://api.github.com/users/SpiderX","html_url":"https://github.com/SpiderX","followers_url":"https://api.github.com/users/SpiderX/followers","following_url":"https://api.github.com/users/SpiderX/following{/other_user}","gists_url":"https://api.github.com/users/SpiderX/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderX/subscriptions","organizations_url":"https://api.github.com/users/SpiderX/orgs","repos_url":"https://api.github.com/users/SpiderX/repos","events_url":"https://api.github.com/users/SpiderX/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderX/received_events","type":"User","site_admin":false},"body":"PythonQt is a dynamic Python binding for the Qt framework.\nIt offers an easy way to embed the Python scripting language\ninto your C++ Qt applications.\nThe focus of PythonQt is on embedding Python into\nan existing C++ application, not on writing the whole\napplication completely in Python.\n\nBase for ebuild from https://github.com/SpiderX/portage-overlay/tree/master/dev-python/PythonQt\n\nGentoo-Bug: https://bugs.gentoo.org/214331\n\nPackage-Manager: portage-2.3.0\n","created_at":"2016-10-22T16:58:05Z","updated_at":"2016-11-13T00:14:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3438f940d4e12476a110c2dfe9621a3498a4f6c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gentoo/gentoo/pulls/2634/commits","review_comments_url":"https://api.github.com/repos/gentoo/gentoo/pulls/2634/comments","review_comment_url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gentoo/gentoo/issues/2634/comments","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/fe7327f4ed45810e4abb72c7bb4a3afa75c4ca3d","head":{"label":"SpiderX:dev-python/PythonQt","ref":"dev-python/PythonQt","sha":"fe7327f4ed45810e4abb72c7bb4a3afa75c4ca3d","user":{"login":"SpiderX","id":277573,"avatar_url":"https://avatars.githubusercontent.com/u/277573?v=3","gravatar_id":"","url":"https://api.github.com/users/SpiderX","html_url":"https://github.com/SpiderX","followers_url":"https://api.github.com/users/SpiderX/followers","following_url":"https://api.github.com/users/SpiderX/following{/other_user}","gists_url":"https://api.github.com/users/SpiderX/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderX/subscriptions","organizations_url":"https://api.github.com/users/SpiderX/orgs","repos_url":"https://api.github.com/users/SpiderX/repos","events_url":"https://api.github.com/users/SpiderX/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderX/received_events","type":"User","site_admin":false},"repo":{"id":71079074,"name":"gentoo","full_name":"SpiderX/gentoo","owner":{"login":"SpiderX","id":277573,"avatar_url":"https://avatars.githubusercontent.com/u/277573?v=3","gravatar_id":"","url":"https://api.github.com/users/SpiderX","html_url":"https://github.com/SpiderX","followers_url":"https://api.github.com/users/SpiderX/followers","following_url":"https://api.github.com/users/SpiderX/following{/other_user}","gists_url":"https://api.github.com/users/SpiderX/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderX/subscriptions","organizations_url":"https://api.github.com/users/SpiderX/orgs","repos_url":"https://api.github.com/users/SpiderX/repos","events_url":"https://api.github.com/users/SpiderX/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SpiderX/gentoo","description":"The official mirror the Gentoo ebuild repository","fork":true,"url":"https://api.github.com/repos/SpiderX/gentoo","forks_url":"https://api.github.com/repos/SpiderX/gentoo/forks","keys_url":"https://api.github.com/repos/SpiderX/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpiderX/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpiderX/gentoo/teams","hooks_url":"https://api.github.com/repos/SpiderX/gentoo/hooks","issue_events_url":"https://api.github.com/repos/SpiderX/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/SpiderX/gentoo/events","assignees_url":"https://api.github.com/repos/SpiderX/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/SpiderX/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/SpiderX/gentoo/tags","blobs_url":"https://api.github.com/repos/SpiderX/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpiderX/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpiderX/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpiderX/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpiderX/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/SpiderX/gentoo/languages","stargazers_url":"https://api.github.com/repos/SpiderX/gentoo/stargazers","contributors_url":"https://api.github.com/repos/SpiderX/gentoo/contributors","subscribers_url":"https://api.github.com/repos/SpiderX/gentoo/subscribers","subscription_url":"https://api.github.com/repos/SpiderX/gentoo/subscription","commits_url":"https://api.github.com/repos/SpiderX/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpiderX/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpiderX/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpiderX/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpiderX/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/SpiderX/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpiderX/gentoo/merges","archive_url":"https://api.github.com/repos/SpiderX/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpiderX/gentoo/downloads","issues_url":"https://api.github.com/repos/SpiderX/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/SpiderX/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/SpiderX/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/SpiderX/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpiderX/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/SpiderX/gentoo/releases{/id}","deployments_url":"https://api.github.com/repos/SpiderX/gentoo/deployments","created_at":"2016-10-16T21:44:42Z","updated_at":"2016-10-15T20:03:55Z","pushed_at":"2016-11-12T23:50:06Z","git_url":"git://github.com/SpiderX/gentoo.git","ssh_url":"git@github.com:SpiderX/gentoo.git","clone_url":"https://github.com/SpiderX/gentoo.git","svn_url":"https://github.com/SpiderX/gentoo","homepage":"https://wiki.gentoo.org/wiki/Gentoo_Github","size":236290,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gentoo:master","ref":"master","sha":"ad94a35329260b47c825372672f522fc9ca4bf3f","user":{"login":"gentoo","id":52242,"avatar_url":"https://avatars.githubusercontent.com/u/52242?v=3","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"repo":{"id":40499714,"name":"gentoo","full_name":"gentoo/gentoo","owner":{"login":"gentoo","id":52242,"avatar_url":"https://avatars.githubusercontent.com/u/52242?v=3","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gentoo/gentoo","description":"The official mirror the Gentoo ebuild repository","fork":false,"url":"https://api.github.com/repos/gentoo/gentoo","forks_url":"https://api.github.com/repos/gentoo/gentoo/forks","keys_url":"https://api.github.com/repos/gentoo/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoo/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoo/gentoo/teams","hooks_url":"https://api.github.com/repos/gentoo/gentoo/hooks","issue_events_url":"https://api.github.com/repos/gentoo/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/gentoo/gentoo/events","assignees_url":"https://api.github.com/repos/gentoo/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/gentoo/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/gentoo/gentoo/tags","blobs_url":"https://api.github.com/repos/gentoo/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoo/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoo/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoo/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoo/gentoo/languages","stargazers_url":"https://api.github.com/repos/gentoo/gentoo/stargazers","contributors_url":"https://api.github.com/repos/gentoo/gentoo/contributors","subscribers_url":"https://api.github.com/repos/gentoo/gentoo/subscribers","subscription_url":"https://api.github.com/repos/gentoo/gentoo/subscription","commits_url":"https://api.github.com/repos/gentoo/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoo/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoo/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoo/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoo/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/gentoo/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoo/gentoo/merges","archive_url":"https://api.github.com/repos/gentoo/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoo/gentoo/downloads","issues_url":"https://api.github.com/repos/gentoo/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/gentoo/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoo/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoo/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoo/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/gentoo/gentoo/releases{/id}","deployments_url":"https://api.github.com/repos/gentoo/gentoo/deployments","created_at":"2015-08-10T18:47:32Z","updated_at":"2016-11-08T21:52:13Z","pushed_at":"2016-11-13T00:13:45Z","git_url":"git://github.com/gentoo/gentoo.git","ssh_url":"git@github.com:gentoo/gentoo.git","clone_url":"https://github.com/gentoo/gentoo.git","svn_url":"https://github.com/gentoo/gentoo","homepage":"https://wiki.gentoo.org/wiki/Gentoo_Github","size":277792,"stargazers_count":356,"watchers_count":356,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":341,"mirror_url":null,"open_issues_count":97,"forks":341,"open_issues":97,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/2634"},"html":{"href":"https://github.com/gentoo/gentoo/pull/2634"},"issue":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/2634"},"comments":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/2634/comments"},"review_comments":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/2634/comments"},"review_comment":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/2634/commits"},"statuses":{"href":"https://api.github.com/repos/gentoo/gentoo/statuses/fe7327f4ed45810e4abb72c7bb4a3afa75c4ca3d"}}}}
{"actor":{"display_login":"SpiderX"}}