{"action":"created","issue":{"url":"https://api.github.com/repos/ello/ello-android/issues/14","repository_url":"https://api.github.com/repos/ello/ello-android","labels_url":"https://api.github.com/repos/ello/ello-android/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/ello/ello-android/issues/14/comments","events_url":"https://api.github.com/repos/ello/ello-android/issues/14/events","html_url":"https://github.com/ello/ello-android/pull/14","id":144992706,"number":14,"title":"Use CrossWalk in place of Android WebView","user":{"login":"steam","id":12459,"avatar_url":"https://avatars.githubusercontent.com/u/12459?v=3","gravatar_id":"","url":"https://api.github.com/users/steam","html_url":"https://github.com/steam","followers_url":"https://api.github.com/users/steam/followers","following_url":"https://api.github.com/users/steam/following{/other_user}","gists_url":"https://api.github.com/users/steam/gists{/gist_id}","starred_url":"https://api.github.com/users/steam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steam/subscriptions","organizations_url":"https://api.github.com/users/steam/orgs","repos_url":"https://api.github.com/users/steam/repos","events_url":"https://api.github.com/users/steam/events{/privacy}","received_events_url":"https://api.github.com/users/steam/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ello/ello-android/labels/reviewed","name":"reviewed","color":"159818"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-31T19:18:40Z","updated_at":"2016-03-31T21:08:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ello/ello-android/pulls/14","html_url":"https://github.com/ello/ello-android/pull/14","diff_url":"https://github.com/ello/ello-android/pull/14.diff","patch_url":"https://github.com/ello/ello-android/pull/14.patch"},"body":"Android's `WebView` is inconsistent across Android devices and OS versions. This PR completely replaces `WebView` with [CrossWalk](https://crosswalk-project.org/documentation/android.html), a Chromium based HTML application runtime that is baked into the application apk. This should streamline the experience across Android devices and OS's. So far it looks to be a great swap. Content loads quickly and renders as expected. Previously, some Android devices would not load post images using `srcset` and some Android devices were not integrating with the file chooser correctly. CrossWalk also gave us the ability to use the device's camera for image uploads out of the box.\r\n\r\nIn order to restrict image uploads to allowed types we had to link against a canary build of CrossWalk (19.48.503.0). This required using Maven to build the canary version and a configuration change in `app/build.gradle` using `mavenLocal()` rather than linking to one of the stable or beta builds of Crosswalk available in the online repos. Hopefully we can remove the local build requirement in the future.\r\n\r\nTesting this code is going to require a lot of app use on different devices with different OS versions."},"comment":{"url":"https://api.github.com/repos/ello/ello-android/issues/comments/204130346","html_url":"https://github.com/ello/ello-android/pull/14#issuecomment-204130346","issue_url":"https://api.github.com/repos/ello/ello-android/issues/14","id":204130346,"user":{"login":"steam","id":12459,"avatar_url":"https://avatars.githubusercontent.com/u/12459?v=3","gravatar_id":"","url":"https://api.github.com/users/steam","html_url":"https://github.com/steam","followers_url":"https://api.github.com/users/steam/followers","following_url":"https://api.github.com/users/steam/following{/other_user}","gists_url":"https://api.github.com/users/steam/gists{/gist_id}","starred_url":"https://api.github.com/users/steam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steam/subscriptions","organizations_url":"https://api.github.com/users/steam/orgs","repos_url":"https://api.github.com/users/steam/repos","events_url":"https://api.github.com/users/steam/events{/privacy}","received_events_url":"https://api.github.com/users/steam/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T21:08:13Z","updated_at":"2016-03-31T21:08:13Z","body":"Thanks for the SH review @jayzes :eyes: "}}