{"action":"created","comment":{"url":"https://api.github.com/repos/elmot/spring-demo7/pulls/comments/84048654","pull_request_review_id":4849784,"id":84048654,"diff_hunk":"@@ -0,0 +1,203 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+    xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+    <parent>\n+        <artifactId>spring-demo7</artifactId>\n+        <groupId>com.vaadin.framework7</groupId>\n+        <version>1.1</version>\n+    </parent>\n+    <modelVersion>4.0.0</modelVersion>\n+\n+    <artifactId>spring-demo-ui-legacy-boot</artifactId>\n+    <name>Spring-Boot Demo Legacy Navigation</name>\n+\n+    <dependencyManagement>\n+        <dependencies>\n+            <dependency>\n+                <groupId>com.vaadin</groupId>\n+                <artifactId>vaadin-server</artifactId>\n+                <version>${vaadin.version}</version>\n+            </dependency>\n+        </dependencies>\n+    </dependencyManagement>\n+\n+    <dependencies>\n+\n+        <dependency>\n+            <groupId>${project.groupId}</groupId>\n+            <artifactId>spring-demo-backend</artifactId>\n+            <version>${project.version}</version>\n+        </dependency>\n+\n+        <dependency>\n+            <groupId>com.vaadin</groupId>\n+            <artifactId>vaadin-spring-boot-starter</artifactId>\n+            <version>1.1-SNAPSHOT</version>\n+            <exclusions>\n+                <exclusion>\n+                    <groupId>org.hibernate</groupId>\n+                    <artifactId>hibernate-validator</artifactId>\n+                </exclusion>\n+                <exclusion>\n+                    <groupId>org.springframework.boot</groupId>\n+                    <artifactId>spring-boot-autoconfigure</artifactId>\n+                </exclusion>\n+            </exclusions>\n+        </dependency>\n+\n+        <!-- This version is important regarding used Vaadin plugin versions \n+            and Sring boot verions ! 1.2.2 spring boot version doesn't prvide JMX admin \n+            beans so integration testing (proper start/stop server) won't work with this \n+            version. 1.4.0 Spring boot doesn't work with with Vaadin Spring boot. -->","path":"spring-demo-ui-legacy-boot/pom.xml","position":51,"original_position":51,"commit_id":"6797bc3531dbc7298982d5c8f1bca993b633dbe2","original_commit_id":"6797bc3531dbc7298982d5c8f1bca993b633dbe2","user":{"login":"hesara","id":1335918,"avatar_url":"https://avatars.githubusercontent.com/u/1335918?v=3","gravatar_id":"","url":"https://api.github.com/users/hesara","html_url":"https://github.com/hesara","followers_url":"https://api.github.com/users/hesara/followers","following_url":"https://api.github.com/users/hesara/following{/other_user}","gists_url":"https://api.github.com/users/hesara/gists{/gist_id}","starred_url":"https://api.github.com/users/hesara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hesara/subscriptions","organizations_url":"https://api.github.com/users/hesara/orgs","repos_url":"https://api.github.com/users/hesara/repos","events_url":"https://api.github.com/users/hesara/events{/privacy}","received_events_url":"https://api.github.com/users/hesara/received_events","type":"User","site_admin":false},"body":"Is this still true? What is the problem with 1.4? We should probably fix that and use 1.4.1 rather than making workarounds.","created_at":"2016-10-19T11:25:47Z","updated_at":"2016-10-19T11:25:47Z","html_url":"https://github.com/elmot/spring-demo7/pull/1#discussion_r84048654","pull_request_url":"https://api.github.com/repos/elmot/spring-demo7/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/elmot/spring-demo7/pulls/comments/84048654"},"html":{"href":"https://github.com/elmot/spring-demo7/pull/1#discussion_r84048654"},"pull_request":{"href":"https://api.github.com/repos/elmot/spring-demo7/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/elmot/spring-demo7/pulls/1","id":89987170,"html_url":"https://github.com/elmot/spring-demo7/pull/1","diff_url":"https://github.com/elmot/spring-demo7/pull/1.diff","patch_url":"https://github.com/elmot/spring-demo7/pull/1.patch","issue_url":"https://api.github.com/repos/elmot/spring-demo7/issues/1","number":1,"state":"open","locked":false,"title":"Master spring 1.1","user":{"login":"elmot","id":5366945,"avatar_url":"https://avatars.githubusercontent.com/u/5366945?v=3","gravatar_id":"","url":"https://api.github.com/users/elmot","html_url":"https://github.com/elmot","followers_url":"https://api.github.com/users/elmot/followers","following_url":"https://api.github.com/users/elmot/following{/other_user}","gists_url":"https://api.github.com/users/elmot/gists{/gist_id}","starred_url":"https://api.github.com/users/elmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmot/subscriptions","organizations_url":"https://api.github.com/users/elmot/orgs","repos_url":"https://api.github.com/users/elmot/repos","events_url":"https://api.github.com/users/elmot/events{/privacy}","received_events_url":"https://api.github.com/users/elmot/received_events","type":"User","site_admin":false},"body":"Refactor project to be able to test different Spring approaches","created_at":"2016-10-19T11:06:08Z","updated_at":"2016-10-19T11:30:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdaf070513f24d2febc3f9a9b8991df8b6a59cb7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elmot/spring-demo7/pulls/1/commits","review_comments_url":"https://api.github.com/repos/elmot/spring-demo7/pulls/1/comments","review_comment_url":"https://api.github.com/repos/elmot/spring-demo7/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elmot/spring-demo7/issues/1/comments","statuses_url":"https://api.github.com/repos/elmot/spring-demo7/statuses/6797bc3531dbc7298982d5c8f1bca993b633dbe2","head":{"label":"elmot:master-spring-1.1","ref":"master-spring-1.1","sha":"6797bc3531dbc7298982d5c8f1bca993b633dbe2","user":{"login":"elmot","id":5366945,"avatar_url":"https://avatars.githubusercontent.com/u/5366945?v=3","gravatar_id":"","url":"https://api.github.com/users/elmot","html_url":"https://github.com/elmot","followers_url":"https://api.github.com/users/elmot/followers","following_url":"https://api.github.com/users/elmot/following{/other_user}","gists_url":"https://api.github.com/users/elmot/gists{/gist_id}","starred_url":"https://api.github.com/users/elmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmot/subscriptions","organizations_url":"https://api.github.com/users/elmot/orgs","repos_url":"https://api.github.com/users/elmot/repos","events_url":"https://api.github.com/users/elmot/events{/privacy}","received_events_url":"https://api.github.com/users/elmot/received_events","type":"User","site_admin":false},"repo":{"id":70585592,"name":"spring-demo7","full_name":"elmot/spring-demo7","owner":{"login":"elmot","id":5366945,"avatar_url":"https://avatars.githubusercontent.com/u/5366945?v=3","gravatar_id":"","url":"https://api.github.com/users/elmot","html_url":"https://github.com/elmot","followers_url":"https://api.github.com/users/elmot/followers","following_url":"https://api.github.com/users/elmot/following{/other_user}","gists_url":"https://api.github.com/users/elmot/gists{/gist_id}","starred_url":"https://api.github.com/users/elmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmot/subscriptions","organizations_url":"https://api.github.com/users/elmot/orgs","repos_url":"https://api.github.com/users/elmot/repos","events_url":"https://api.github.com/users/elmot/events{/privacy}","received_events_url":"https://api.github.com/users/elmot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elmot/spring-demo7","description":null,"fork":false,"url":"https://api.github.com/repos/elmot/spring-demo7","forks_url":"https://api.github.com/repos/elmot/spring-demo7/forks","keys_url":"https://api.github.com/repos/elmot/spring-demo7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elmot/spring-demo7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elmot/spring-demo7/teams","hooks_url":"https://api.github.com/repos/elmot/spring-demo7/hooks","issue_events_url":"https://api.github.com/repos/elmot/spring-demo7/issues/events{/number}","events_url":"https://api.github.com/repos/elmot/spring-demo7/events","assignees_url":"https://api.github.com/repos/elmot/spring-demo7/assignees{/user}","branches_url":"https://api.github.com/repos/elmot/spring-demo7/branches{/branch}","tags_url":"https://api.github.com/repos/elmot/spring-demo7/tags","blobs_url":"https://api.github.com/repos/elmot/spring-demo7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elmot/spring-demo7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elmot/spring-demo7/git/refs{/sha}","trees_url":"https://api.github.com/repos/elmot/spring-demo7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elmot/spring-demo7/statuses/{sha}","languages_url":"https://api.github.com/repos/elmot/spring-demo7/languages","stargazers_url":"https://api.github.com/repos/elmot/spring-demo7/stargazers","contributors_url":"https://api.github.com/repos/elmot/spring-demo7/contributors","subscribers_url":"https://api.github.com/repos/elmot/spring-demo7/subscribers","subscription_url":"https://api.github.com/repos/elmot/spring-demo7/subscription","commits_url":"https://api.github.com/repos/elmot/spring-demo7/commits{/sha}","git_commits_url":"https://api.github.com/repos/elmot/spring-demo7/git/commits{/sha}","comments_url":"https://api.github.com/repos/elmot/spring-demo7/comments{/number}","issue_comment_url":"https://api.github.com/repos/elmot/spring-demo7/issues/comments{/number}","contents_url":"https://api.github.com/repos/elmot/spring-demo7/contents/{+path}","compare_url":"https://api.github.com/repos/elmot/spring-demo7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elmot/spring-demo7/merges","archive_url":"https://api.github.com/repos/elmot/spring-demo7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elmot/spring-demo7/downloads","issues_url":"https://api.github.com/repos/elmot/spring-demo7/issues{/number}","pulls_url":"https://api.github.com/repos/elmot/spring-demo7/pulls{/number}","milestones_url":"https://api.github.com/repos/elmot/spring-demo7/milestones{/number}","notifications_url":"https://api.github.com/repos/elmot/spring-demo7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elmot/spring-demo7/labels{/name}","releases_url":"https://api.github.com/repos/elmot/spring-demo7/releases{/id}","deployments_url":"https://api.github.com/repos/elmot/spring-demo7/deployments","created_at":"2016-10-11T11:15:35Z","updated_at":"2016-10-18T13:40:41Z","pushed_at":"2016-10-19T11:12:59Z","git_url":"git://github.com/elmot/spring-demo7.git","ssh_url":"git@github.com:elmot/spring-demo7.git","clone_url":"https://github.com/elmot/spring-demo7.git","svn_url":"https://github.com/elmot/spring-demo7","homepage":null,"size":224,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"elmot:master","ref":"master","sha":"22f24d805a8b4eacbdec7ff590b6200a852b3505","user":{"login":"elmot","id":5366945,"avatar_url":"https://avatars.githubusercontent.com/u/5366945?v=3","gravatar_id":"","url":"https://api.github.com/users/elmot","html_url":"https://github.com/elmot","followers_url":"https://api.github.com/users/elmot/followers","following_url":"https://api.github.com/users/elmot/following{/other_user}","gists_url":"https://api.github.com/users/elmot/gists{/gist_id}","starred_url":"https://api.github.com/users/elmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmot/subscriptions","organizations_url":"https://api.github.com/users/elmot/orgs","repos_url":"https://api.github.com/users/elmot/repos","events_url":"https://api.github.com/users/elmot/events{/privacy}","received_events_url":"https://api.github.com/users/elmot/received_events","type":"User","site_admin":false},"repo":{"id":70585592,"name":"spring-demo7","full_name":"elmot/spring-demo7","owner":{"login":"elmot","id":5366945,"avatar_url":"https://avatars.githubusercontent.com/u/5366945?v=3","gravatar_id":"","url":"https://api.github.com/users/elmot","html_url":"https://github.com/elmot","followers_url":"https://api.github.com/users/elmot/followers","following_url":"https://api.github.com/users/elmot/following{/other_user}","gists_url":"https://api.github.com/users/elmot/gists{/gist_id}","starred_url":"https://api.github.com/users/elmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmot/subscriptions","organizations_url":"https://api.github.com/users/elmot/orgs","repos_url":"https://api.github.com/users/elmot/repos","events_url":"https://api.github.com/users/elmot/events{/privacy}","received_events_url":"https://api.github.com/users/elmot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elmot/spring-demo7","description":null,"fork":false,"url":"https://api.github.com/repos/elmot/spring-demo7","forks_url":"https://api.github.com/repos/elmot/spring-demo7/forks","keys_url":"https://api.github.com/repos/elmot/spring-demo7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elmot/spring-demo7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elmot/spring-demo7/teams","hooks_url":"https://api.github.com/repos/elmot/spring-demo7/hooks","issue_events_url":"https://api.github.com/repos/elmot/spring-demo7/issues/events{/number}","events_url":"https://api.github.com/repos/elmot/spring-demo7/events","assignees_url":"https://api.github.com/repos/elmot/spring-demo7/assignees{/user}","branches_url":"https://api.github.com/repos/elmot/spring-demo7/branches{/branch}","tags_url":"https://api.github.com/repos/elmot/spring-demo7/tags","blobs_url":"https://api.github.com/repos/elmot/spring-demo7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elmot/spring-demo7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elmot/spring-demo7/git/refs{/sha}","trees_url":"https://api.github.com/repos/elmot/spring-demo7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elmot/spring-demo7/statuses/{sha}","languages_url":"https://api.github.com/repos/elmot/spring-demo7/languages","stargazers_url":"https://api.github.com/repos/elmot/spring-demo7/stargazers","contributors_url":"https://api.github.com/repos/elmot/spring-demo7/contributors","subscribers_url":"https://api.github.com/repos/elmot/spring-demo7/subscribers","subscription_url":"https://api.github.com/repos/elmot/spring-demo7/subscription","commits_url":"https://api.github.com/repos/elmot/spring-demo7/commits{/sha}","git_commits_url":"https://api.github.com/repos/elmot/spring-demo7/git/commits{/sha}","comments_url":"https://api.github.com/repos/elmot/spring-demo7/comments{/number}","issue_comment_url":"https://api.github.com/repos/elmot/spring-demo7/issues/comments{/number}","contents_url":"https://api.github.com/repos/elmot/spring-demo7/contents/{+path}","compare_url":"https://api.github.com/repos/elmot/spring-demo7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elmot/spring-demo7/merges","archive_url":"https://api.github.com/repos/elmot/spring-demo7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elmot/spring-demo7/downloads","issues_url":"https://api.github.com/repos/elmot/spring-demo7/issues{/number}","pulls_url":"https://api.github.com/repos/elmot/spring-demo7/pulls{/number}","milestones_url":"https://api.github.com/repos/elmot/spring-demo7/milestones{/number}","notifications_url":"https://api.github.com/repos/elmot/spring-demo7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elmot/spring-demo7/labels{/name}","releases_url":"https://api.github.com/repos/elmot/spring-demo7/releases{/id}","deployments_url":"https://api.github.com/repos/elmot/spring-demo7/deployments","created_at":"2016-10-11T11:15:35Z","updated_at":"2016-10-18T13:40:41Z","pushed_at":"2016-10-19T11:12:59Z","git_url":"git://github.com/elmot/spring-demo7.git","ssh_url":"git@github.com:elmot/spring-demo7.git","clone_url":"https://github.com/elmot/spring-demo7.git","svn_url":"https://github.com/elmot/spring-demo7","homepage":null,"size":224,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elmot/spring-demo7/pulls/1"},"html":{"href":"https://github.com/elmot/spring-demo7/pull/1"},"issue":{"href":"https://api.github.com/repos/elmot/spring-demo7/issues/1"},"comments":{"href":"https://api.github.com/repos/elmot/spring-demo7/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/elmot/spring-demo7/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/elmot/spring-demo7/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elmot/spring-demo7/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/elmot/spring-demo7/statuses/6797bc3531dbc7298982d5c8f1bca993b633dbe2"}}}}
{"actor":{"display_login":"hesara"}}