{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/12","id":63268626,"html_url":"https://github.com/feedhenry/grunt-fh-build/pull/12","diff_url":"https://github.com/feedhenry/grunt-fh-build/pull/12.diff","patch_url":"https://github.com/feedhenry/grunt-fh-build/pull/12.patch","issue_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12","number":12,"state":"closed","locked":false,"title":"[RHMAP-5128] Change grunt-fh-build to use ESLint instead of JSHint","user":{"login":"paolobueno","id":1294893,"avatar_url":"https://avatars.githubusercontent.com/u/1294893?v=3","gravatar_id":"","url":"https://api.github.com/users/paolobueno","html_url":"https://github.com/paolobueno","followers_url":"https://api.github.com/users/paolobueno/followers","following_url":"https://api.github.com/users/paolobueno/following{/other_user}","gists_url":"https://api.github.com/users/paolobueno/gists{/gist_id}","starred_url":"https://api.github.com/users/paolobueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolobueno/subscriptions","organizations_url":"https://api.github.com/users/paolobueno/orgs","repos_url":"https://api.github.com/users/paolobueno/repos","events_url":"https://api.github.com/users/paolobueno/events{/privacy}","received_events_url":"https://api.github.com/users/paolobueno/received_events","type":"User","site_admin":false},"body":"Also removed `plato` since AFAIK `eslint` has a builtin rule for complexity.\r\n\r\nI have a question: why do we target the `lib/` and `bin/` directories specifically? on `fh-fhc` for instance we have a lot of small rule violations inside `test/`, for instance. I tried changing the target configuration to `['**/*.js']` but the task broke for some reason.\r\n\r\nI've also tried creating another variation of the task like `grunt eslint:fix`, but I think it would always run alongside the main task, and we should probably run `eslint --fix` straight from the cli anyways.\r\n\r\nI've bumped the minor in this PR, since it's kind of a breaking change. I'll also squash the commits before merging.\r\n\r\nping @jasonmadigan, @wei-lee, @wtrocki, @ziccardi, @odra","created_at":"2016-03-17T18:15:46Z","updated_at":"2016-04-11T11:18:09Z","closed_at":"2016-04-11T11:18:09Z","merged_at":null,"merge_commit_sha":"5fe3efb1b28190afba924bfc470f702dbaf36c0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/12/commits","review_comments_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/12/comments","review_comment_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12/comments","statuses_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/statuses/36ab1a54e98fa9f2fc06b4bd20e13ff07e10dae4","head":{"label":"paolobueno:RHMAP-5128","ref":"RHMAP-5128","sha":"36ab1a54e98fa9f2fc06b4bd20e13ff07e10dae4","user":{"login":"paolobueno","id":1294893,"avatar_url":"https://avatars.githubusercontent.com/u/1294893?v=3","gravatar_id":"","url":"https://api.github.com/users/paolobueno","html_url":"https://github.com/paolobueno","followers_url":"https://api.github.com/users/paolobueno/followers","following_url":"https://api.github.com/users/paolobueno/following{/other_user}","gists_url":"https://api.github.com/users/paolobueno/gists{/gist_id}","starred_url":"https://api.github.com/users/paolobueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolobueno/subscriptions","organizations_url":"https://api.github.com/users/paolobueno/orgs","repos_url":"https://api.github.com/users/paolobueno/repos","events_url":"https://api.github.com/users/paolobueno/events{/privacy}","received_events_url":"https://api.github.com/users/paolobueno/received_events","type":"User","site_admin":false},"repo":{"id":54136771,"name":"grunt-fh-build","full_name":"paolobueno/grunt-fh-build","owner":{"login":"paolobueno","id":1294893,"avatar_url":"https://avatars.githubusercontent.com/u/1294893?v=3","gravatar_id":"","url":"https://api.github.com/users/paolobueno","html_url":"https://github.com/paolobueno","followers_url":"https://api.github.com/users/paolobueno/followers","following_url":"https://api.github.com/users/paolobueno/following{/other_user}","gists_url":"https://api.github.com/users/paolobueno/gists{/gist_id}","starred_url":"https://api.github.com/users/paolobueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolobueno/subscriptions","organizations_url":"https://api.github.com/users/paolobueno/orgs","repos_url":"https://api.github.com/users/paolobueno/repos","events_url":"https://api.github.com/users/paolobueno/events{/privacy}","received_events_url":"https://api.github.com/users/paolobueno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paolobueno/grunt-fh-build","description":"A plugin for development and build lifecycle of FeedHenry components","fork":true,"url":"https://api.github.com/repos/paolobueno/grunt-fh-build","forks_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/forks","keys_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/teams","hooks_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/hooks","issue_events_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/issues/events{/number}","events_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/events","assignees_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/assignees{/user}","branches_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/branches{/branch}","tags_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/tags","blobs_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/statuses/{sha}","languages_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/languages","stargazers_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/stargazers","contributors_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/contributors","subscribers_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/subscribers","subscription_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/subscription","commits_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/contents/{+path}","compare_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/merges","archive_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/downloads","issues_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/issues{/number}","pulls_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/pulls{/number}","milestones_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/milestones{/number}","notifications_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/labels{/name}","releases_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/releases{/id}","deployments_url":"https://api.github.com/repos/paolobueno/grunt-fh-build/deployments","created_at":"2016-03-17T17:11:37Z","updated_at":"2016-03-17T17:11:38Z","pushed_at":"2016-03-17T18:01:46Z","git_url":"git://github.com/paolobueno/grunt-fh-build.git","ssh_url":"git@github.com:paolobueno/grunt-fh-build.git","clone_url":"https://github.com/paolobueno/grunt-fh-build.git","svn_url":"https://github.com/paolobueno/grunt-fh-build","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"7af374c3bd1c9951d5a6b837b9cdb11c5c4b0fc5","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":44312586,"name":"grunt-fh-build","full_name":"feedhenry/grunt-fh-build","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/grunt-fh-build","description":"A plugin for development and build lifecycle of FeedHenry components","fork":false,"url":"https://api.github.com/repos/feedhenry/grunt-fh-build","forks_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/forks","keys_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/teams","hooks_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/events","assignees_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/tags","blobs_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/languages","stargazers_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/subscription","commits_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/merges","archive_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/downloads","issues_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry/grunt-fh-build/deployments","created_at":"2015-10-15T11:19:03Z","updated_at":"2016-01-12T11:45:19Z","pushed_at":"2016-04-11T10:42:07Z","git_url":"git://github.com/feedhenry/grunt-fh-build.git","ssh_url":"git@github.com:feedhenry/grunt-fh-build.git","clone_url":"https://github.com/feedhenry/grunt-fh-build.git","svn_url":"https://github.com/feedhenry/grunt-fh-build","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/12"},"html":{"href":"https://github.com/feedhenry/grunt-fh-build/pull/12"},"issue":{"href":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12"},"comments":{"href":"https://api.github.com/repos/feedhenry/grunt-fh-build/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/grunt-fh-build/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/grunt-fh-build/statuses/36ab1a54e98fa9f2fc06b4bd20e13ff07e10dae4"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":11,"review_comments":2,"commits":7,"additions":46,"deletions":66,"changed_files":6}}