{"action":"created","comment":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments/85247080","pull_request_review_id":5974011,"id":85247080,"diff_hunk":"@@ -75,6 +75,10 @@ additionalProperties:\n     'options':\n       type: dictionary\n \n+    'fusion':","path":"TYPO3.TYPO3CR/Resources/Private/Schema/NodeTypes.schema.yaml","position":4,"original_position":4,"commit_id":"532d85c3d55a4860689fa3f3097b3eac3c7fa9ab","original_commit_id":"532d85c3d55a4860689fa3f3097b3eac3c7fa9ab","user":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars.githubusercontent.com/u/324408?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"body":"I was almost about to merge this, but this IMHO cannot happen, it implicitly binds CR to Fusion, which it shouldn't be. SORRY :/\r\n\r\nThe configuration should go under \"options\" and not be mentioned in this schema.","created_at":"2016-10-27T00:24:58Z","updated_at":"2016-10-27T00:27:17Z","html_url":"https://github.com/neos/neos-development-collection/pull/767#discussion_r85247080","pull_request_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/767","_links":{"self":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments/85247080"},"html":{"href":"https://github.com/neos/neos-development-collection/pull/767#discussion_r85247080"},"pull_request":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/767"}}},"pull_request":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/767","id":86125895,"html_url":"https://github.com/neos/neos-development-collection/pull/767","diff_url":"https://github.com/neos/neos-development-collection/pull/767.diff","patch_url":"https://github.com/neos/neos-development-collection/pull/767.patch","issue_url":"https://api.github.com/repos/neos/neos-development-collection/issues/767","number":767,"state":"open","locked":false,"title":"!!! FEATURE: Configurable Fusion node type prototype generators","user":{"login":"mficzel","id":1309380,"avatar_url":"https://avatars.githubusercontent.com/u/1309380?v=3","gravatar_id":"","url":"https://api.github.com/users/mficzel","html_url":"https://github.com/mficzel","followers_url":"https://api.github.com/users/mficzel/followers","following_url":"https://api.github.com/users/mficzel/following{/other_user}","gists_url":"https://api.github.com/users/mficzel/gists{/gist_id}","starred_url":"https://api.github.com/users/mficzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mficzel/subscriptions","organizations_url":"https://api.github.com/users/mficzel/orgs","repos_url":"https://api.github.com/users/mficzel/repos","events_url":"https://api.github.com/users/mficzel/events{/privacy}","received_events_url":"https://api.github.com/users/mficzel/received_events","type":"User","site_admin":false},"body":"- If ``fusion.prototypeGenerator`` is set to a className the class has to implement the interface\r\n``\\TYPO3\\Neos\\Domain\\Service\\DefaultPrototypeGeneratorInterface`` and is used to generate the prototype-code\r\nfor this node.\r\n- If ``fusion.prototypeGenerator`` is set to ``null`` no prototype is created for this type.\r\n\r\nFor nodeTypes based on ``TYPO3.Neos:Node``, ``TYPO3.Neos:Document`` or ``TYPO3.Neos:Content`` a backwards compatible implementation is added to the configuration and a new prototype generator for ``TYPO3.Neos:Plugin`` is added.","created_at":"2016-09-21T09:21:54Z","updated_at":"2016-10-27T00:27:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92e0deaed5bda65afefeaed054df2e1bb33fc3b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/767/commits","review_comments_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/767/comments","review_comment_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/issues/767/comments","statuses_url":"https://api.github.com/repos/neos/neos-development-collection/statuses/532d85c3d55a4860689fa3f3097b3eac3c7fa9ab","head":{"label":"mficzel:feature/makeFusionPrototypeGeneratorConfigurable","ref":"feature/makeFusionPrototypeGeneratorConfigurable","sha":"532d85c3d55a4860689fa3f3097b3eac3c7fa9ab","user":{"login":"mficzel","id":1309380,"avatar_url":"https://avatars.githubusercontent.com/u/1309380?v=3","gravatar_id":"","url":"https://api.github.com/users/mficzel","html_url":"https://github.com/mficzel","followers_url":"https://api.github.com/users/mficzel/followers","following_url":"https://api.github.com/users/mficzel/following{/other_user}","gists_url":"https://api.github.com/users/mficzel/gists{/gist_id}","starred_url":"https://api.github.com/users/mficzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mficzel/subscriptions","organizations_url":"https://api.github.com/users/mficzel/orgs","repos_url":"https://api.github.com/users/mficzel/repos","events_url":"https://api.github.com/users/mficzel/events{/privacy}","received_events_url":"https://api.github.com/users/mficzel/received_events","type":"User","site_admin":false},"repo":{"id":41537149,"name":"neos-development-collection","full_name":"mficzel/neos-development-collection","owner":{"login":"mficzel","id":1309380,"avatar_url":"https://avatars.githubusercontent.com/u/1309380?v=3","gravatar_id":"","url":"https://api.github.com/users/mficzel","html_url":"https://github.com/mficzel","followers_url":"https://api.github.com/users/mficzel/followers","following_url":"https://api.github.com/users/mficzel/following{/other_user}","gists_url":"https://api.github.com/users/mficzel/gists{/gist_id}","starred_url":"https://api.github.com/users/mficzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mficzel/subscriptions","organizations_url":"https://api.github.com/users/mficzel/orgs","repos_url":"https://api.github.com/users/mficzel/repos","events_url":"https://api.github.com/users/mficzel/events{/privacy}","received_events_url":"https://api.github.com/users/mficzel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mficzel/neos-development-collection","description":"The unified repository containing the Neos core packages, used for Neos development.","fork":true,"url":"https://api.github.com/repos/mficzel/neos-development-collection","forks_url":"https://api.github.com/repos/mficzel/neos-development-collection/forks","keys_url":"https://api.github.com/repos/mficzel/neos-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mficzel/neos-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mficzel/neos-development-collection/teams","hooks_url":"https://api.github.com/repos/mficzel/neos-development-collection/hooks","issue_events_url":"https://api.github.com/repos/mficzel/neos-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/mficzel/neos-development-collection/events","assignees_url":"https://api.github.com/repos/mficzel/neos-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/mficzel/neos-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/mficzel/neos-development-collection/tags","blobs_url":"https://api.github.com/repos/mficzel/neos-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mficzel/neos-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mficzel/neos-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/mficzel/neos-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mficzel/neos-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/mficzel/neos-development-collection/languages","stargazers_url":"https://api.github.com/repos/mficzel/neos-development-collection/stargazers","contributors_url":"https://api.github.com/repos/mficzel/neos-development-collection/contributors","subscribers_url":"https://api.github.com/repos/mficzel/neos-development-collection/subscribers","subscription_url":"https://api.github.com/repos/mficzel/neos-development-collection/subscription","commits_url":"https://api.github.com/repos/mficzel/neos-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/mficzel/neos-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/mficzel/neos-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/mficzel/neos-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/mficzel/neos-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/mficzel/neos-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mficzel/neos-development-collection/merges","archive_url":"https://api.github.com/repos/mficzel/neos-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mficzel/neos-development-collection/downloads","issues_url":"https://api.github.com/repos/mficzel/neos-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/mficzel/neos-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/mficzel/neos-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/mficzel/neos-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mficzel/neos-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/mficzel/neos-development-collection/releases{/id}","deployments_url":"https://api.github.com/repos/mficzel/neos-development-collection/deployments","created_at":"2015-08-28T08:50:39Z","updated_at":"2016-05-18T07:02:40Z","pushed_at":"2016-10-17T08:43:08Z","git_url":"git://github.com/mficzel/neos-development-collection.git","ssh_url":"git@github.com:mficzel/neos-development-collection.git","clone_url":"https://github.com/mficzel/neos-development-collection.git","svn_url":"https://github.com/mficzel/neos-development-collection","homepage":null,"size":65723,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:master","ref":"master","sha":"e4c735b60794ff56e90daa5a7414f438bc43dcf0","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40964014,"name":"neos-development-collection","full_name":"neos/neos-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/neos-development-collection","description":"The unified repository containing the Neos core packages, used for Neos development.","fork":false,"url":"https://api.github.com/repos/neos/neos-development-collection","forks_url":"https://api.github.com/repos/neos/neos-development-collection/forks","keys_url":"https://api.github.com/repos/neos/neos-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/neos-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/neos-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/neos-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/neos-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/neos-development-collection/events","assignees_url":"https://api.github.com/repos/neos/neos-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/neos-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/neos-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/neos-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/neos-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/neos-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/neos-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/neos-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/neos-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/neos-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/neos-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/neos-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/neos-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/neos-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/neos-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/neos-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/neos-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/neos-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/neos-development-collection/merges","archive_url":"https://api.github.com/repos/neos/neos-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/neos-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/neos-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/neos-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/neos-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/neos-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/neos-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/neos-development-collection/releases{/id}","deployments_url":"https://api.github.com/repos/neos/neos-development-collection/deployments","created_at":"2015-08-18T09:48:35Z","updated_at":"2016-10-25T16:31:52Z","pushed_at":"2016-10-26T22:00:57Z","git_url":"git://github.com/neos/neos-development-collection.git","ssh_url":"git@github.com:neos/neos-development-collection.git","clone_url":"https://github.com/neos/neos-development-collection.git","svn_url":"https://github.com/neos/neos-development-collection","homepage":"https://www.neos.io/","size":78785,"stargazers_count":102,"watchers_count":102,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":442,"forks":91,"open_issues":442,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/767"},"html":{"href":"https://github.com/neos/neos-development-collection/pull/767"},"issue":{"href":"https://api.github.com/repos/neos/neos-development-collection/issues/767"},"comments":{"href":"https://api.github.com/repos/neos/neos-development-collection/issues/767/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/767/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/767/commits"},"statuses":{"href":"https://api.github.com/repos/neos/neos-development-collection/statuses/532d85c3d55a4860689fa3f3097b3eac3c7fa9ab"}}}}
{"actor":{"display_login":"kitsunet"}}