{"action":"created","issue":{"url":"https://api.github.com/repos/eidheim/Simple-WebSocket-Server/issues/48","repository_url":"https://api.github.com/repos/eidheim/Simple-WebSocket-Server","labels_url":"https://api.github.com/repos/eidheim/Simple-WebSocket-Server/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/eidheim/Simple-WebSocket-Server/issues/48/comments","events_url":"https://api.github.com/repos/eidheim/Simple-WebSocket-Server/issues/48/events","html_url":"https://github.com/eidheim/Simple-WebSocket-Server/pull/48","id":187927913,"number":48,"title":"Fixes some compiler errors in MSVS 2012 and a crash if server gets deleted directly after calling io_service->stop()","user":{"login":"classix-do","id":23314584,"avatar_url":"https://avatars.githubusercontent.com/u/23314584?v=3","gravatar_id":"","url":"https://api.github.com/users/classix-do","html_url":"https://github.com/classix-do","followers_url":"https://api.github.com/users/classix-do/followers","following_url":"https://api.github.com/users/classix-do/following{/other_user}","gists_url":"https://api.github.com/users/classix-do/gists{/gist_id}","starred_url":"https://api.github.com/users/classix-do/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/classix-do/subscriptions","organizations_url":"https://api.github.com/users/classix-do/orgs","repos_url":"https://api.github.com/users/classix-do/repos","events_url":"https://api.github.com/users/classix-do/events{/privacy}","received_events_url":"https://api.github.com/users/classix-do/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-08T08:17:14Z","updated_at":"2016-11-17T12:54:01Z","closed_at":"2016-11-10T09:14:31Z","pull_request":{"url":"https://api.github.com/repos/eidheim/Simple-WebSocket-Server/pulls/48","html_url":"https://github.com/eidheim/Simple-WebSocket-Server/pull/48","diff_url":"https://github.com/eidheim/Simple-WebSocket-Server/pull/48.diff","patch_url":"https://github.com/eidheim/Simple-WebSocket-Server/pull/48.patch"},"body":"I know, you are not so much into supporting non C++11-standard compilers, so I can understand if you don't want to pull in the first commit 560cb90 (which looks a bit ugly).\r\n\r\nThe commit 6f6c1c9 should be important on any compiler (I am wondering, why this is compiling with other versions as `std::mutex` isn't copy- or movable and therefore Endpoint can't be used in an `std::map<>` like this).\r\n\r\ncfa4f1f is a minor fix, for a problem, which is caused, by using a global `io_service`, which lives longer than the WebsocketServer instance. After calling `io_service::stop()` the acceptor gets notified of the stop, which ends in an access violation because he tries to call `accept()` on a deleted object.\r\n"},"comment":{"url":"https://api.github.com/repos/eidheim/Simple-WebSocket-Server/issues/comments/261239475","html_url":"https://github.com/eidheim/Simple-WebSocket-Server/pull/48#issuecomment-261239475","issue_url":"https://api.github.com/repos/eidheim/Simple-WebSocket-Server/issues/48","id":261239475,"user":{"login":"eidheim","id":5269318,"avatar_url":"https://avatars.githubusercontent.com/u/5269318?v=3","gravatar_id":"","url":"https://api.github.com/users/eidheim","html_url":"https://github.com/eidheim","followers_url":"https://api.github.com/users/eidheim/followers","following_url":"https://api.github.com/users/eidheim/following{/other_user}","gists_url":"https://api.github.com/users/eidheim/gists{/gist_id}","starred_url":"https://api.github.com/users/eidheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eidheim/subscriptions","organizations_url":"https://api.github.com/users/eidheim/orgs","repos_url":"https://api.github.com/users/eidheim/repos","events_url":"https://api.github.com/users/eidheim/events{/privacy}","received_events_url":"https://api.github.com/users/eidheim/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T12:54:01Z","updated_at":"2016-11-17T12:54:01Z","body":"Ok, so it is reasonable to belive that if one write C++11 one uses at least VS2013? Is there a reason why your project needs to support VS2012? Again, just curious, since this might be related to other users as well. "}}
{"actor":{"display_login":"eidheim"}}