{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/solidity/issues/856","repository_url":"https://api.github.com/repos/ethereum/solidity","labels_url":"https://api.github.com/repos/ethereum/solidity/issues/856/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/856/comments","events_url":"https://api.github.com/repos/ethereum/solidity/issues/856/events","html_url":"https://github.com/ethereum/solidity/pull/856","id":170413151,"number":856,"title":"Fix JSON AST structure","user":{"login":"asinyagin","id":700837,"avatar_url":"https://avatars.githubusercontent.com/u/700837?v=3","gravatar_id":"","url":"https://api.github.com/users/asinyagin","html_url":"https://github.com/asinyagin","followers_url":"https://api.github.com/users/asinyagin/followers","following_url":"https://api.github.com/users/asinyagin/following{/other_user}","gists_url":"https://api.github.com/users/asinyagin/gists{/gist_id}","starred_url":"https://api.github.com/users/asinyagin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asinyagin/subscriptions","organizations_url":"https://api.github.com/users/asinyagin/orgs","repos_url":"https://api.github.com/users/asinyagin/repos","events_url":"https://api.github.com/users/asinyagin/events{/privacy}","received_events_url":"https://api.github.com/users/asinyagin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/solidity/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/ethereum/solidity/labels/looks%20good","name":"looks good","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-10T13:10:57Z","updated_at":"2016-08-11T16:52:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/856","html_url":"https://github.com/ethereum/solidity/pull/856","diff_url":"https://github.com/ethereum/solidity/pull/856.diff","patch_url":"https://github.com/ethereum/solidity/pull/856.patch"},"body":"Fixes https://github.com/ethereum/solidity/issues/853\r\n\r\nSolc with `--combined-json` key prints incorrect AST.\r\n\r\nFor example, AST for this contract:\r\n```js\r\ncontract Contract {\r\n  uint i;\r\n  function a() {}\r\n}\r\n```\r\nis\r\n```json\r\n{\r\n    \"children\": [{\r\n        \"attributes\": {\r\n            \"name\": \"Contract\"\r\n        },\r\n        \"children\": [{\r\n            \"attributes\": {\r\n                \"name\": \"i\"\r\n            },\r\n            \"children\": [{\r\n                \"attributes\": {\r\n                    \"name\": \"uint\"\r\n                },\r\n                \"name\": \"ElementaryTypeName\"\r\n            }, {\r\n                \"attributes\": {\r\n                    \"const\": false,\r\n                    \"name\": \"a\",\r\n                    \"public\": true\r\n                },\r\n                \"children\": [{\r\n                    \"children\": [],\r\n                    \"name\": \"ParameterList\"\r\n                }, {\r\n                    \"children\": [],\r\n                    \"name\": \"ParameterList\"\r\n                }, {\r\n                    \"children\": [],\r\n                    \"name\": \"Block\"\r\n                }],\r\n                \"name\": \"Function\"\r\n            }],\r\n            \"name\": \"VariableDeclaration\"\r\n        }],\r\n        \"name\": \"Contract\"\r\n    }],\r\n    \"name\": \"root\"\r\n}\r\n```\r\nHere `function a()` is a child of `uint i`.\r\n\r\nThis PR won't work without the fix #794."},"comment":{"url":"https://api.github.com/repos/ethereum/solidity/issues/comments/239221162","html_url":"https://github.com/ethereum/solidity/pull/856#issuecomment-239221162","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/856","id":239221162,"user":{"login":"asinyagin","id":700837,"avatar_url":"https://avatars.githubusercontent.com/u/700837?v=3","gravatar_id":"","url":"https://api.github.com/users/asinyagin","html_url":"https://github.com/asinyagin","followers_url":"https://api.github.com/users/asinyagin/followers","following_url":"https://api.github.com/users/asinyagin/following{/other_user}","gists_url":"https://api.github.com/users/asinyagin/gists{/gist_id}","starred_url":"https://api.github.com/users/asinyagin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asinyagin/subscriptions","organizations_url":"https://api.github.com/users/asinyagin/orgs","repos_url":"https://api.github.com/users/asinyagin/repos","events_url":"https://api.github.com/users/asinyagin/events{/privacy}","received_events_url":"https://api.github.com/users/asinyagin/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T16:52:20Z","updated_at":"2016-08-11T16:52:20Z","body":"@chriseth I've added all the missing `goUp`s. Should I move everything to 1 commit or is it's ok to leave the merges?\r\n\r\nAlso, I want to add the missing elements like `InheritanceSpecifier`, `UsingForDirective`, etc. Is it better to do that in another PR?"}}
{"actor":{"display_login":"asinyagin"}}