{"action":"created","comment":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/54134657","id":54134657,"diff_hunk":"@@ -580,13 +622,48 @@ def ser_reader(filename, objects=None, verbose=False, *args, **kwds):\n         'mapping': mapping}\n     return dictionary\n \n-\n-def get_mode(mode):\n+def guess_units_from_mode(objects_dict, header, verbose=False):","path":"hyperspy/io_plugins/fei.py","position":151,"original_position":151,"commit_id":"781c91ce4483da0be3c079a6471ee3870b828fbd","original_commit_id":"781c91ce4483da0be3c079a6471ee3870b828fbd","user":{"login":"francisco-dlp","id":989719,"avatar_url":"https://avatars.githubusercontent.com/u/989719?v=3","gravatar_id":"","url":"https://api.github.com/users/francisco-dlp","html_url":"https://github.com/francisco-dlp","followers_url":"https://api.github.com/users/francisco-dlp/followers","following_url":"https://api.github.com/users/francisco-dlp/following{/other_user}","gists_url":"https://api.github.com/users/francisco-dlp/gists{/gist_id}","starred_url":"https://api.github.com/users/francisco-dlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisco-dlp/subscriptions","organizations_url":"https://api.github.com/users/francisco-dlp/orgs","repos_url":"https://api.github.com/users/francisco-dlp/repos","events_url":"https://api.github.com/users/francisco-dlp/events{/privacy}","received_events_url":"https://api.github.com/users/francisco-dlp/received_events","type":"User","site_admin":false},"body":"I think that this isn't going to work because the xmls are not stored in the order of the ser file numbers. Instead they use UUIDs to match the ser files to the xml objects. In order to match them we need to know how to generate those UUIDs.","created_at":"2016-02-25T17:49:10Z","updated_at":"2016-02-25T17:49:10Z","html_url":"https://github.com/hyperspy/hyperspy/pull/883#discussion_r54134657","pull_request_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/883","_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/54134657"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/883#discussion_r54134657"},"pull_request":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/883"}}},"pull_request":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/883","id":60585557,"html_url":"https://github.com/hyperspy/hyperspy/pull/883","diff_url":"https://github.com/hyperspy/hyperspy/pull/883.diff","patch_url":"https://github.com/hyperspy/hyperspy/pull/883.patch","issue_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/883","number":883,"state":"open","locked":false,"title":"Support for new fei format and scale/units for diffraction","user":{"login":"ericpre","id":11851990,"avatar_url":"https://avatars.githubusercontent.com/u/11851990?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpre","html_url":"https://github.com/ericpre","followers_url":"https://api.github.com/users/ericpre/followers","following_url":"https://api.github.com/users/ericpre/following{/other_user}","gists_url":"https://api.github.com/users/ericpre/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpre/subscriptions","organizations_url":"https://api.github.com/users/ericpre/orgs","repos_url":"https://api.github.com/users/ericpre/repos","events_url":"https://api.github.com/users/ericpre/events{/privacy}","received_events_url":"https://api.github.com/users/ericpre/received_events","type":"User","site_admin":false},"body":"- add support for emi/ser files with versions >= 544, i.e. for files acquired on windows 64 bits, fix #397\r\n- add several kinds of emi/ser example files acquired on different microscopes for testing\r\n- add tests for fei reader, fix #662\r\n- add support for the scale/units of diffractions\r\n\r\nWhen I tried to use the xml data in the emi files to get informations about the detectors, it was not able to get it work nicely and I suspect the xml data are not parsed correctly. For example, for a file containing an EDS and a diffraction acquisition, the xml data about the EDS detector are parsed to the diffraction signal and vice versa.","created_at":"2016-02-24T21:55:41Z","updated_at":"2016-02-25T17:49:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f04bb2bf3437e647d5efdeccf3855a72384cc8c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/883/commits","review_comments_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/883/comments","review_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/883/comments","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/781c91ce4483da0be3c079a6471ee3870b828fbd","head":{"label":"ericpre:support_for_new_fei_format_and_scale_unit_diffraction","ref":"support_for_new_fei_format_and_scale_unit_diffraction","sha":"781c91ce4483da0be3c079a6471ee3870b828fbd","user":{"login":"ericpre","id":11851990,"avatar_url":"https://avatars.githubusercontent.com/u/11851990?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpre","html_url":"https://github.com/ericpre","followers_url":"https://api.github.com/users/ericpre/followers","following_url":"https://api.github.com/users/ericpre/following{/other_user}","gists_url":"https://api.github.com/users/ericpre/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpre/subscriptions","organizations_url":"https://api.github.com/users/ericpre/orgs","repos_url":"https://api.github.com/users/ericpre/repos","events_url":"https://api.github.com/users/ericpre/events{/privacy}","received_events_url":"https://api.github.com/users/ericpre/received_events","type":"User","site_admin":false},"repo":{"id":41250647,"name":"hyperspy","full_name":"ericpre/hyperspy","owner":{"login":"ericpre","id":11851990,"avatar_url":"https://avatars.githubusercontent.com/u/11851990?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpre","html_url":"https://github.com/ericpre","followers_url":"https://api.github.com/users/ericpre/followers","following_url":"https://api.github.com/users/ericpre/following{/other_user}","gists_url":"https://api.github.com/users/ericpre/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpre/subscriptions","organizations_url":"https://api.github.com/users/ericpre/orgs","repos_url":"https://api.github.com/users/ericpre/repos","events_url":"https://api.github.com/users/ericpre/events{/privacy}","received_events_url":"https://api.github.com/users/ericpre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericpre/hyperspy","description":"Multidimensional data analysis","fork":true,"url":"https://api.github.com/repos/ericpre/hyperspy","forks_url":"https://api.github.com/repos/ericpre/hyperspy/forks","keys_url":"https://api.github.com/repos/ericpre/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericpre/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericpre/hyperspy/teams","hooks_url":"https://api.github.com/repos/ericpre/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/ericpre/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/ericpre/hyperspy/events","assignees_url":"https://api.github.com/repos/ericpre/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/ericpre/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/ericpre/hyperspy/tags","blobs_url":"https://api.github.com/repos/ericpre/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericpre/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericpre/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericpre/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericpre/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/ericpre/hyperspy/languages","stargazers_url":"https://api.github.com/repos/ericpre/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/ericpre/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/ericpre/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/ericpre/hyperspy/subscription","commits_url":"https://api.github.com/repos/ericpre/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericpre/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericpre/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericpre/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericpre/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/ericpre/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericpre/hyperspy/merges","archive_url":"https://api.github.com/repos/ericpre/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericpre/hyperspy/downloads","issues_url":"https://api.github.com/repos/ericpre/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/ericpre/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/ericpre/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/ericpre/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericpre/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/ericpre/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/ericpre/hyperspy/deployments","created_at":"2015-08-23T13:30:33Z","updated_at":"2016-02-15T23:28:47Z","pushed_at":"2016-02-25T00:35:29Z","git_url":"git://github.com/ericpre/hyperspy.git","ssh_url":"git@github.com:ericpre/hyperspy.git","clone_url":"https://github.com/ericpre/hyperspy.git","svn_url":"https://github.com/ericpre/hyperspy","homepage":"http://www.hyperspy.org","size":76626,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperspy:master","ref":"master","sha":"242e587a6be4d9c8c24c9c37ba3928f00aa409a8","user":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"repo":{"id":2233998,"name":"hyperspy","full_name":"hyperspy/hyperspy","owner":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperspy/hyperspy","description":"Multidimensional data analysis","fork":false,"url":"https://api.github.com/repos/hyperspy/hyperspy","forks_url":"https://api.github.com/repos/hyperspy/hyperspy/forks","keys_url":"https://api.github.com/repos/hyperspy/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperspy/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperspy/hyperspy/teams","hooks_url":"https://api.github.com/repos/hyperspy/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/hyperspy/hyperspy/events","assignees_url":"https://api.github.com/repos/hyperspy/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/hyperspy/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/hyperspy/hyperspy/tags","blobs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperspy/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperspy/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperspy/hyperspy/languages","stargazers_url":"https://api.github.com/repos/hyperspy/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/hyperspy/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/hyperspy/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/hyperspy/hyperspy/subscription","commits_url":"https://api.github.com/repos/hyperspy/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperspy/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperspy/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/hyperspy/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperspy/hyperspy/merges","archive_url":"https://api.github.com/repos/hyperspy/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperspy/hyperspy/downloads","issues_url":"https://api.github.com/repos/hyperspy/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperspy/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperspy/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/hyperspy/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/hyperspy/hyperspy/deployments","created_at":"2011-08-19T13:14:36Z","updated_at":"2016-02-03T08:59:10Z","pushed_at":"2016-02-25T17:23:36Z","git_url":"git://github.com/hyperspy/hyperspy.git","ssh_url":"git@github.com:hyperspy/hyperspy.git","clone_url":"https://github.com/hyperspy/hyperspy.git","svn_url":"https://github.com/hyperspy/hyperspy","homepage":"http://www.hyperspy.org","size":80555,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":137,"forks":40,"open_issues":137,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/883"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/883"},"issue":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/883"},"comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/883/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/883/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/883/commits"},"statuses":{"href":"https://api.github.com/repos/hyperspy/hyperspy/statuses/781c91ce4483da0be3c079a6471ee3870b828fbd"}}}}