{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/52560232","id":52560232,"diff_hunk":"@@ -3338,17 +3340,26 @@ void PostVisitBlock(ParseNode *pnode, ByteCodeGenerator *byteCodeGenerator)\n         return;\n     }\n \n+    Scope *scope = pnode->sxBlock.scope;\n     if (pnode->sxBlock.GetCallsEval() || pnode->sxBlock.GetChildCallsEval() || (byteCodeGenerator->GetFlags() & (fscrEval | fscrImplicitThis | fscrImplicitParents)))\n     {\n-        Scope *scope = pnode->sxBlock.scope;\n         bool scopeIsEmpty = scope->IsEmpty();\n         scope->SetIsObject();\n         scope->SetCapturesAll(true);\n         scope->SetMustInstantiate(!scopeIsEmpty);\n     }\n \n-    byteCodeGenerator->PopScope();\n-    byteCodeGenerator->PopBlock();\n+    if (scope->GetScopeType() != ScopeType_Parameter)\n+    {\n+        byteCodeGenerator->PopScope();\n+        byteCodeGenerator->PopBlock();\n+    }\n+    else\n+    {\n+        // If current block is a param scope then it was not pushed in during PreVisitBlock. So let's not do a pop here.","path":"lib/Runtime/ByteCode/ByteCodeGenerator.cpp","position":113,"original_position":113,"commit_id":"2513c5ffe67fb4b9c5d049b6b3cce077c8f81c55","original_commit_id":"2513c5ffe67fb4b9c5d049b6b3cce077c8f81c55","user":{"login":"ianwjhalliday","id":906649,"avatar_url":"https://avatars.githubusercontent.com/u/906649?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwjhalliday","html_url":"https://github.com/ianwjhalliday","followers_url":"https://api.github.com/users/ianwjhalliday/followers","following_url":"https://api.github.com/users/ianwjhalliday/following{/other_user}","gists_url":"https://api.github.com/users/ianwjhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwjhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwjhalliday/subscriptions","organizations_url":"https://api.github.com/users/ianwjhalliday/orgs","repos_url":"https://api.github.com/users/ianwjhalliday/repos","events_url":"https://api.github.com/users/ianwjhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ianwjhalliday/received_events","type":"User","site_admin":false},"body":"Ah gotcha","created_at":"2016-02-11T03:09:47Z","updated_at":"2016-02-11T03:09:47Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/289#discussion_r52560232","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/289","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/52560232"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/289#discussion_r52560232"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/289"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/289","id":58838663,"html_url":"https://github.com/Microsoft/ChakraCore/pull/289","diff_url":"https://github.com/Microsoft/ChakraCore/pull/289.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/289.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/289","number":289,"state":"open","locked":false,"title":"Enabling split scope in lambda and adding more test cases","user":{"login":"aneeshdk","id":5985960,"avatar_url":"https://avatars.githubusercontent.com/u/5985960?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshdk","html_url":"https://github.com/aneeshdk","followers_url":"https://api.github.com/users/aneeshdk/followers","following_url":"https://api.github.com/users/aneeshdk/following{/other_user}","gists_url":"https://api.github.com/users/aneeshdk/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshdk/subscriptions","organizations_url":"https://api.github.com/users/aneeshdk/orgs","repos_url":"https://api.github.com/users/aneeshdk/repos","events_url":"https://api.github.com/users/aneeshdk/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshdk/received_events","type":"User","site_admin":false},"body":"Contains the following changes for split scope,\n1. Enabled split scope in lambdas.\n2. Created a separate test file for default param's split scope tests.\n3. Changed the logic for marking the split scope creation. With this\nchange the split scope will be created only if one of the formal parameter\nis captured by a function definition in the param scope.\n4. Fixed couple of issues with nested split scopes.\n","created_at":"2016-02-10T01:57:04Z","updated_at":"2016-02-11T03:09:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"736de78e3d3912d675dd99d580a29c02684672c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/289/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/289/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/289/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/2513c5ffe67fb4b9c5d049b6b3cce077c8f81c55","head":{"label":"aneeshdk:SplitScopeTests","ref":"SplitScopeTests","sha":"2513c5ffe67fb4b9c5d049b6b3cce077c8f81c55","user":{"login":"aneeshdk","id":5985960,"avatar_url":"https://avatars.githubusercontent.com/u/5985960?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshdk","html_url":"https://github.com/aneeshdk","followers_url":"https://api.github.com/users/aneeshdk/followers","following_url":"https://api.github.com/users/aneeshdk/following{/other_user}","gists_url":"https://api.github.com/users/aneeshdk/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshdk/subscriptions","organizations_url":"https://api.github.com/users/aneeshdk/orgs","repos_url":"https://api.github.com/users/aneeshdk/repos","events_url":"https://api.github.com/users/aneeshdk/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshdk/received_events","type":"User","site_admin":false},"repo":{"id":49697798,"name":"ChakraCore","full_name":"aneeshdk/ChakraCore","owner":{"login":"aneeshdk","id":5985960,"avatar_url":"https://avatars.githubusercontent.com/u/5985960?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshdk","html_url":"https://github.com/aneeshdk","followers_url":"https://api.github.com/users/aneeshdk/followers","following_url":"https://api.github.com/users/aneeshdk/following{/other_user}","gists_url":"https://api.github.com/users/aneeshdk/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshdk/subscriptions","organizations_url":"https://api.github.com/users/aneeshdk/orgs","repos_url":"https://api.github.com/users/aneeshdk/repos","events_url":"https://api.github.com/users/aneeshdk/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshdk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aneeshdk/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/aneeshdk/ChakraCore","forks_url":"https://api.github.com/repos/aneeshdk/ChakraCore/forks","keys_url":"https://api.github.com/repos/aneeshdk/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aneeshdk/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aneeshdk/ChakraCore/teams","hooks_url":"https://api.github.com/repos/aneeshdk/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/aneeshdk/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/aneeshdk/ChakraCore/events","assignees_url":"https://api.github.com/repos/aneeshdk/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/aneeshdk/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/aneeshdk/ChakraCore/tags","blobs_url":"https://api.github.com/repos/aneeshdk/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aneeshdk/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aneeshdk/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aneeshdk/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aneeshdk/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aneeshdk/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/aneeshdk/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/aneeshdk/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/aneeshdk/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/aneeshdk/ChakraCore/subscription","commits_url":"https://api.github.com/repos/aneeshdk/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aneeshdk/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aneeshdk/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aneeshdk/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aneeshdk/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/aneeshdk/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aneeshdk/ChakraCore/merges","archive_url":"https://api.github.com/repos/aneeshdk/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aneeshdk/ChakraCore/downloads","issues_url":"https://api.github.com/repos/aneeshdk/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/aneeshdk/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aneeshdk/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aneeshdk/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aneeshdk/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/aneeshdk/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/aneeshdk/ChakraCore/deployments","created_at":"2016-01-15T05:11:05Z","updated_at":"2016-01-15T18:15:44Z","pushed_at":"2016-02-10T18:57:31Z","git_url":"git://github.com/aneeshdk/ChakraCore.git","ssh_url":"git@github.com:aneeshdk/ChakraCore.git","clone_url":"https://github.com/aneeshdk/ChakraCore.git","svn_url":"https://github.com/aneeshdk/ChakraCore","homepage":null,"size":17817,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"afcd72b76831fe20ac5d6ee10669d34914e77299","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-02-11T02:38:07Z","pushed_at":"2016-02-11T02:14:26Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":19738,"stargazers_count":4839,"watchers_count":4839,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":480,"mirror_url":null,"open_issues_count":71,"forks":480,"open_issues":71,"watchers":4839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/289"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/289"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/289"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/2513c5ffe67fb4b9c5d049b6b3cce077c8f81c55"}}}}