{"action":"created","comment":{"url":"https://api.github.com/repos/twitter-fabric/galley/pulls/comments/68271370","id":68271370,"diff_hunk":"@@ -135,22 +135,27 @@ maybeInspectContainer = (docker, name) ->\n # Helper method to check and see if the running container's links differ from the ones we would\n # want to create it with. If they do differ, the only recourse is to remove and recreate the\n # container, since you may not (currently) modify links of a running container.\n-isLinkMissing = (containerInfo, createOpts) ->\n-  # These are the links as reported back by Docker, which have the format:\n-  #  /sourceContainer:/destContainer/alias\n-  # We do a bit of splitting and joining to convert them back to /sourceContainer:alias so that\n-  # we can compare them directly with the Links parameter we provide to create.\n-  currentLinks = _.map (containerInfo?.HostConfig?.Links or []), (link) ->\n-    [source, dest] = link.split(':')\n-    \"#{source}:#{dest.split('/').pop()}\"\n+isLinkMissing = (containerInfo, createOpts, servicesConfig) ->\n+  service = containerInfo.Name.split(\"/\")[1].split(\".\")[0]\n+  env = containerInfo.Name.split(\"/\")[1].split(\".\")[1]\n+  prereqs = ServiceHelpers.generatePrereqServices(service, servicesConfig)","path":"lib/commands/run.coffee","position":15,"original_position":15,"commit_id":"c4529c41915573bf66832c9d42f2c95bcd74fdb2","original_commit_id":"c4529c41915573bf66832c9d42f2c95bcd74fdb2","user":{"login":"finneganh","id":260837,"avatar_url":"https://avatars.githubusercontent.com/u/260837?v=3","gravatar_id":"","url":"https://api.github.com/users/finneganh","html_url":"https://github.com/finneganh","followers_url":"https://api.github.com/users/finneganh/followers","following_url":"https://api.github.com/users/finneganh/following{/other_user}","gists_url":"https://api.github.com/users/finneganh/gists{/gist_id}","starred_url":"https://api.github.com/users/finneganh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finneganh/subscriptions","organizations_url":"https://api.github.com/users/finneganh/orgs","repos_url":"https://api.github.com/users/finneganh/repos","events_url":"https://api.github.com/users/finneganh/events{/privacy}","received_events_url":"https://api.github.com/users/finneganh/received_events","type":"User","site_admin":false},"body":"Shouldn't necessarily need to go back here. Isn't the info you need all in `createOpts.HostConfig.Links`? (See: old implementation of `requestedLinks`)","created_at":"2016-06-23T16:52:20Z","updated_at":"2016-06-23T16:52:20Z","html_url":"https://github.com/twitter-fabric/galley/pull/44#discussion_r68271370","pull_request_url":"https://api.github.com/repos/twitter-fabric/galley/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/twitter-fabric/galley/pulls/comments/68271370"},"html":{"href":"https://github.com/twitter-fabric/galley/pull/44#discussion_r68271370"},"pull_request":{"href":"https://api.github.com/repos/twitter-fabric/galley/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/twitter-fabric/galley/pulls/44","id":74879727,"html_url":"https://github.com/twitter-fabric/galley/pull/44","diff_url":"https://github.com/twitter-fabric/galley/pull/44.diff","patch_url":"https://github.com/twitter-fabric/galley/pull/44.patch","issue_url":"https://api.github.com/repos/twitter-fabric/galley/issues/44","number":44,"state":"open","locked":false,"title":"WIP","user":{"login":"adamvduke","id":94930,"avatar_url":"https://avatars.githubusercontent.com/u/94930?v=3","gravatar_id":"","url":"https://api.github.com/users/adamvduke","html_url":"https://github.com/adamvduke","followers_url":"https://api.github.com/users/adamvduke/followers","following_url":"https://api.github.com/users/adamvduke/following{/other_user}","gists_url":"https://api.github.com/users/adamvduke/gists{/gist_id}","starred_url":"https://api.github.com/users/adamvduke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamvduke/subscriptions","organizations_url":"https://api.github.com/users/adamvduke/orgs","repos_url":"https://api.github.com/users/adamvduke/repos","events_url":"https://api.github.com/users/adamvduke/events{/privacy}","received_events_url":"https://api.github.com/users/adamvduke/received_events","type":"User","site_admin":false},"body":"WIP at using the strategy of examining container created time to determine if the container is missing a link","created_at":"2016-06-23T00:32:59Z","updated_at":"2016-06-23T16:52:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e900be8afbd5acc45f41ac01b21236ed0f82e94f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter-fabric/galley/pulls/44/commits","review_comments_url":"https://api.github.com/repos/twitter-fabric/galley/pulls/44/comments","review_comment_url":"https://api.github.com/repos/twitter-fabric/galley/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter-fabric/galley/issues/44/comments","statuses_url":"https://api.github.com/repos/twitter-fabric/galley/statuses/c4529c41915573bf66832c9d42f2c95bcd74fdb2","head":{"label":"twitter-fabric:adamvduke/first-1.10-fix-attempt","ref":"adamvduke/first-1.10-fix-attempt","sha":"c4529c41915573bf66832c9d42f2c95bcd74fdb2","user":{"login":"twitter-fabric","id":14279844,"avatar_url":"https://avatars.githubusercontent.com/u/14279844?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter-fabric","html_url":"https://github.com/twitter-fabric","followers_url":"https://api.github.com/users/twitter-fabric/followers","following_url":"https://api.github.com/users/twitter-fabric/following{/other_user}","gists_url":"https://api.github.com/users/twitter-fabric/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter-fabric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter-fabric/subscriptions","organizations_url":"https://api.github.com/users/twitter-fabric/orgs","repos_url":"https://api.github.com/users/twitter-fabric/repos","events_url":"https://api.github.com/users/twitter-fabric/events{/privacy}","received_events_url":"https://api.github.com/users/twitter-fabric/received_events","type":"Organization","site_admin":false},"repo":{"id":42675994,"name":"galley","full_name":"twitter-fabric/galley","owner":{"login":"twitter-fabric","id":14279844,"avatar_url":"https://avatars.githubusercontent.com/u/14279844?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter-fabric","html_url":"https://github.com/twitter-fabric","followers_url":"https://api.github.com/users/twitter-fabric/followers","following_url":"https://api.github.com/users/twitter-fabric/following{/other_user}","gists_url":"https://api.github.com/users/twitter-fabric/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter-fabric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter-fabric/subscriptions","organizations_url":"https://api.github.com/users/twitter-fabric/orgs","repos_url":"https://api.github.com/users/twitter-fabric/repos","events_url":"https://api.github.com/users/twitter-fabric/events{/privacy}","received_events_url":"https://api.github.com/users/twitter-fabric/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter-fabric/galley","description":"Orchestrator for local Docker containers","fork":false,"url":"https://api.github.com/repos/twitter-fabric/galley","forks_url":"https://api.github.com/repos/twitter-fabric/galley/forks","keys_url":"https://api.github.com/repos/twitter-fabric/galley/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter-fabric/galley/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter-fabric/galley/teams","hooks_url":"https://api.github.com/repos/twitter-fabric/galley/hooks","issue_events_url":"https://api.github.com/repos/twitter-fabric/galley/issues/events{/number}","events_url":"https://api.github.com/repos/twitter-fabric/galley/events","assignees_url":"https://api.github.com/repos/twitter-fabric/galley/assignees{/user}","branches_url":"https://api.github.com/repos/twitter-fabric/galley/branches{/branch}","tags_url":"https://api.github.com/repos/twitter-fabric/galley/tags","blobs_url":"https://api.github.com/repos/twitter-fabric/galley/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter-fabric/galley/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter-fabric/galley/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter-fabric/galley/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter-fabric/galley/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter-fabric/galley/languages","stargazers_url":"https://api.github.com/repos/twitter-fabric/galley/stargazers","contributors_url":"https://api.github.com/repos/twitter-fabric/galley/contributors","subscribers_url":"https://api.github.com/repos/twitter-fabric/galley/subscribers","subscription_url":"https://api.github.com/repos/twitter-fabric/galley/subscription","commits_url":"https://api.github.com/repos/twitter-fabric/galley/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter-fabric/galley/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter-fabric/galley/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter-fabric/galley/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter-fabric/galley/contents/{+path}","compare_url":"https://api.github.com/repos/twitter-fabric/galley/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter-fabric/galley/merges","archive_url":"https://api.github.com/repos/twitter-fabric/galley/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter-fabric/galley/downloads","issues_url":"https://api.github.com/repos/twitter-fabric/galley/issues{/number}","pulls_url":"https://api.github.com/repos/twitter-fabric/galley/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter-fabric/galley/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter-fabric/galley/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter-fabric/galley/labels{/name}","releases_url":"https://api.github.com/repos/twitter-fabric/galley/releases{/id}","deployments_url":"https://api.github.com/repos/twitter-fabric/galley/deployments","created_at":"2015-09-17T19:05:12Z","updated_at":"2016-06-07T04:35:19Z","pushed_at":"2016-06-23T00:32:59Z","git_url":"git://github.com/twitter-fabric/galley.git","ssh_url":"git@github.com:twitter-fabric/galley.git","clone_url":"https://github.com/twitter-fabric/galley.git","svn_url":"https://github.com/twitter-fabric/galley","homepage":null,"size":218,"stargazers_count":139,"watchers_count":139,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":139,"default_branch":"master"}},"base":{"label":"twitter-fabric:master","ref":"master","sha":"9313c5991ad43dc825fed7b2c22021f794c8a299","user":{"login":"twitter-fabric","id":14279844,"avatar_url":"https://avatars.githubusercontent.com/u/14279844?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter-fabric","html_url":"https://github.com/twitter-fabric","followers_url":"https://api.github.com/users/twitter-fabric/followers","following_url":"https://api.github.com/users/twitter-fabric/following{/other_user}","gists_url":"https://api.github.com/users/twitter-fabric/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter-fabric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter-fabric/subscriptions","organizations_url":"https://api.github.com/users/twitter-fabric/orgs","repos_url":"https://api.github.com/users/twitter-fabric/repos","events_url":"https://api.github.com/users/twitter-fabric/events{/privacy}","received_events_url":"https://api.github.com/users/twitter-fabric/received_events","type":"Organization","site_admin":false},"repo":{"id":42675994,"name":"galley","full_name":"twitter-fabric/galley","owner":{"login":"twitter-fabric","id":14279844,"avatar_url":"https://avatars.githubusercontent.com/u/14279844?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter-fabric","html_url":"https://github.com/twitter-fabric","followers_url":"https://api.github.com/users/twitter-fabric/followers","following_url":"https://api.github.com/users/twitter-fabric/following{/other_user}","gists_url":"https://api.github.com/users/twitter-fabric/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter-fabric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter-fabric/subscriptions","organizations_url":"https://api.github.com/users/twitter-fabric/orgs","repos_url":"https://api.github.com/users/twitter-fabric/repos","events_url":"https://api.github.com/users/twitter-fabric/events{/privacy}","received_events_url":"https://api.github.com/users/twitter-fabric/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter-fabric/galley","description":"Orchestrator for local Docker containers","fork":false,"url":"https://api.github.com/repos/twitter-fabric/galley","forks_url":"https://api.github.com/repos/twitter-fabric/galley/forks","keys_url":"https://api.github.com/repos/twitter-fabric/galley/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter-fabric/galley/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter-fabric/galley/teams","hooks_url":"https://api.github.com/repos/twitter-fabric/galley/hooks","issue_events_url":"https://api.github.com/repos/twitter-fabric/galley/issues/events{/number}","events_url":"https://api.github.com/repos/twitter-fabric/galley/events","assignees_url":"https://api.github.com/repos/twitter-fabric/galley/assignees{/user}","branches_url":"https://api.github.com/repos/twitter-fabric/galley/branches{/branch}","tags_url":"https://api.github.com/repos/twitter-fabric/galley/tags","blobs_url":"https://api.github.com/repos/twitter-fabric/galley/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter-fabric/galley/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter-fabric/galley/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter-fabric/galley/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter-fabric/galley/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter-fabric/galley/languages","stargazers_url":"https://api.github.com/repos/twitter-fabric/galley/stargazers","contributors_url":"https://api.github.com/repos/twitter-fabric/galley/contributors","subscribers_url":"https://api.github.com/repos/twitter-fabric/galley/subscribers","subscription_url":"https://api.github.com/repos/twitter-fabric/galley/subscription","commits_url":"https://api.github.com/repos/twitter-fabric/galley/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter-fabric/galley/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter-fabric/galley/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter-fabric/galley/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter-fabric/galley/contents/{+path}","compare_url":"https://api.github.com/repos/twitter-fabric/galley/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter-fabric/galley/merges","archive_url":"https://api.github.com/repos/twitter-fabric/galley/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter-fabric/galley/downloads","issues_url":"https://api.github.com/repos/twitter-fabric/galley/issues{/number}","pulls_url":"https://api.github.com/repos/twitter-fabric/galley/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter-fabric/galley/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter-fabric/galley/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter-fabric/galley/labels{/name}","releases_url":"https://api.github.com/repos/twitter-fabric/galley/releases{/id}","deployments_url":"https://api.github.com/repos/twitter-fabric/galley/deployments","created_at":"2015-09-17T19:05:12Z","updated_at":"2016-06-07T04:35:19Z","pushed_at":"2016-06-23T00:32:59Z","git_url":"git://github.com/twitter-fabric/galley.git","ssh_url":"git@github.com:twitter-fabric/galley.git","clone_url":"https://github.com/twitter-fabric/galley.git","svn_url":"https://github.com/twitter-fabric/galley","homepage":null,"size":218,"stargazers_count":139,"watchers_count":139,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter-fabric/galley/pulls/44"},"html":{"href":"https://github.com/twitter-fabric/galley/pull/44"},"issue":{"href":"https://api.github.com/repos/twitter-fabric/galley/issues/44"},"comments":{"href":"https://api.github.com/repos/twitter-fabric/galley/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter-fabric/galley/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter-fabric/galley/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter-fabric/galley/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/twitter-fabric/galley/statuses/c4529c41915573bf66832c9d42f2c95bcd74fdb2"}}}}
{"actor":{"display_login":"finneganh"}}