{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/1517","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/1517/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/1517/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/1517/events","html_url":"https://github.com/apache/cloudstack/pull/1517","id":150800858,"number":1517,"title":"engine/schema: fix upgrade path to work with MySQL 5.7","user":{"login":"rhtyd","id":95203,"avatar_url":"https://avatars.githubusercontent.com/u/95203?v=3","gravatar_id":"","url":"https://api.github.com/users/rhtyd","html_url":"https://github.com/rhtyd","followers_url":"https://api.github.com/users/rhtyd/followers","following_url":"https://api.github.com/users/rhtyd/following{/other_user}","gists_url":"https://api.github.com/users/rhtyd/gists{/gist_id}","starred_url":"https://api.github.com/users/rhtyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhtyd/subscriptions","organizations_url":"https://api.github.com/users/rhtyd/orgs","repos_url":"https://api.github.com/users/rhtyd/repos","events_url":"https://api.github.com/users/rhtyd/events{/privacy}","received_events_url":"https://api.github.com/users/rhtyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-25T09:26:50Z","updated_at":"2016-04-26T00:47:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/1517","html_url":"https://github.com/apache/cloudstack/pull/1517","diff_url":"https://github.com/apache/cloudstack/pull/1517.diff","patch_url":"https://github.com/apache/cloudstack/pull/1517.patch"},"body":"Found this issue when using MySQL 5.7 with Ubuntu 16.04. The upgrade path fix removes an invalid `IGNORE` param that is deprecated now, in the upgrade path we run the alter statement to add an index only if it does not exist so we're good.\r\n\r\nFor MySQL 5.7, we'll also need to update the docs at some point to include `server-id` along with other parameters. Some of the SQL statements used throughout engine/schema don't adhere to SQL 99 standard which is enforced by default in MySQL 5.7, therefore the following sql-mode (for backward compatibility with mysql 5.6 modes) will be necessary for anyone willing to use MySQL 5.7 (until we fix codebase wide raw and generated sql statements to be SQL99 compliant):\r\n\r\nsql-mode=\"STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION,ERROR_FOR_DIVISION_BY_ZERO,NO_ZERO_DATE,NO_ZERO_IN_DATE,NO_ENGINE_SUBSTITUTION\"\r\nserver-id   = 1\r\ninnodb_rollback_on_timeout=1\r\ninnodb_lock_wait_timeout=600\r\nmax_connections=350\r\nlog-bin=mysql-bin\r\nbinlog-format = 'ROW'\r\n\r\n/cc @swill @jburwell @agneya2001 @wido @DaanHoogland  and others"},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/214574233","html_url":"https://github.com/apache/cloudstack/pull/1517#issuecomment-214574233","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/1517","id":214574233,"user":{"login":"jburwell","id":285646,"avatar_url":"https://avatars.githubusercontent.com/u/285646?v=3","gravatar_id":"","url":"https://api.github.com/users/jburwell","html_url":"https://github.com/jburwell","followers_url":"https://api.github.com/users/jburwell/followers","following_url":"https://api.github.com/users/jburwell/following{/other_user}","gists_url":"https://api.github.com/users/jburwell/gists{/gist_id}","starred_url":"https://api.github.com/users/jburwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburwell/subscriptions","organizations_url":"https://api.github.com/users/jburwell/orgs","repos_url":"https://api.github.com/users/jburwell/repos","events_url":"https://api.github.com/users/jburwell/events{/privacy}","received_events_url":"https://api.github.com/users/jburwell/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T00:47:03Z","updated_at":"2016-04-26T00:47:03Z","body":"Do these instructions apply to MariaDB as well?"}}