{"action":"created","comment":{"url":"https://api.github.com/repos/control-center/serviced/pulls/comments/84820810","pull_request_review_id":5573361,"id":84820810,"diff_hunk":"@@ -329,81 +329,35 @@\n                 // children and ask the user to choose to start all\n                 // children or only the top service\n                 $scope.clickRunning = function (service, state) {","path":"web/ui/src/Services/ServiceDetailsController.js","position":3,"original_position":3,"commit_id":"9ff6432a673c35b2bc18f1d4437c4e80f95f66c2","original_commit_id":"9ff6432a673c35b2bc18f1d4437c4e80f95f66c2","user":{"login":"rDr4g0n","id":1927558,"avatar_url":"https://avatars.githubusercontent.com/u/1927558?v=3","gravatar_id":"","url":"https://api.github.com/users/rDr4g0n","html_url":"https://github.com/rDr4g0n","followers_url":"https://api.github.com/users/rDr4g0n/followers","following_url":"https://api.github.com/users/rDr4g0n/following{/other_user}","gists_url":"https://api.github.com/users/rDr4g0n/gists{/gist_id}","starred_url":"https://api.github.com/users/rDr4g0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rDr4g0n/subscriptions","organizations_url":"https://api.github.com/users/rDr4g0n/orgs","repos_url":"https://api.github.com/users/rDr4g0n/repos","events_url":"https://api.github.com/users/rDr4g0n/events{/privacy}","received_events_url":"https://api.github.com/users/rDr4g0n/received_events","type":"User","site_admin":false},"body":"this all gets moved into `Service.js` as a class method","created_at":"2016-10-25T02:22:25Z","updated_at":"2016-10-25T02:22:25Z","html_url":"https://github.com/control-center/serviced/pull/3143#discussion_r84820810","pull_request_url":"https://api.github.com/repos/control-center/serviced/pulls/3143","_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments/84820810"},"html":{"href":"https://github.com/control-center/serviced/pull/3143#discussion_r84820810"},"pull_request":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3143"}}},"pull_request":{"url":"https://api.github.com/repos/control-center/serviced/pulls/3143","id":90696606,"html_url":"https://github.com/control-center/serviced/pull/3143","diff_url":"https://github.com/control-center/serviced/pull/3143.diff","patch_url":"https://github.com/control-center/serviced/pull/3143.patch","issue_url":"https://api.github.com/repos/control-center/serviced/issues/3143","number":3143,"state":"open","locked":false,"title":"Feature/cc 2825","user":{"login":"rDr4g0n","id":1927558,"avatar_url":"https://avatars.githubusercontent.com/u/1927558?v=3","gravatar_id":"","url":"https://api.github.com/users/rDr4g0n","html_url":"https://github.com/rDr4g0n","followers_url":"https://api.github.com/users/rDr4g0n/followers","following_url":"https://api.github.com/users/rDr4g0n/following{/other_user}","gists_url":"https://api.github.com/users/rDr4g0n/gists{/gist_id}","starred_url":"https://api.github.com/users/rDr4g0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rDr4g0n/subscriptions","organizations_url":"https://api.github.com/users/rDr4g0n/orgs","repos_url":"https://api.github.com/users/rDr4g0n/repos","events_url":"https://api.github.com/users/rDr4g0n/events{/privacy}","received_events_url":"https://api.github.com/users/rDr4g0n/received_events","type":"User","site_admin":false},"body":"Fixing https://jira.zenoss.com/browse/CC-2825\r\n\r\nWhen stop, start, or restart are clicked for a service, a request is made to the backend to count the number of descendants that will be affected by the change. However, if the network connection between the UI and serviced is slow, then the user can end up waiting for a number of seconds. The user needs immediate feedback that something is happening so that they know their click was received. \r\n\r\nThis change does a few things to give the user immediate feedback on the click:\r\n\r\n1) Shows a \"one moment please\" modal while waiting on the child count\r\n2) Shows a modal even if the number of affected services is only 1  \r\n\r\n![modal](https://cloud.githubusercontent.com/assets/1927558/19664650/088a6d6c-9a07-11e6-8282-d7a239a89555.gif)\r\n\r\nTo support these features, a few changes needed to be made\r\n\r\n* A new \"unclosable\" modal feature was added so that the \"one moment please\" modal cant just be closed, resulting in unexpected behavior\r\n* When modals are displayed one-after-another, the UI flashes in a yucko way, so the bootstrap modal background was removed and replaced with our own modal background, which lets us control how it shows/hides more closely\r\n* some codemirror textarea issues popped up in modals with this change, so those were tightened up\r\n* most of this code needs to be shared with the Apps page, so it was moved into a shared location","created_at":"2016-10-24T21:29:31Z","updated_at":"2016-10-25T02:22:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f49bc590a55fd49f7b1c16175d2cbb18a9cffcee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/control-center/serviced/pulls/3143/commits","review_comments_url":"https://api.github.com/repos/control-center/serviced/pulls/3143/comments","review_comment_url":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/control-center/serviced/issues/3143/comments","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/9ff6432a673c35b2bc18f1d4437c4e80f95f66c2","head":{"label":"control-center:feature/CC-2825","ref":"feature/CC-2825","sha":"9ff6432a673c35b2bc18f1d4437c4e80f95f66c2","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","deployments_url":"https://api.github.com/repos/control-center/serviced/deployments","created_at":"2013-08-06T16:45:00Z","updated_at":"2016-10-24T15:25:20Z","pushed_at":"2016-10-24T23:33:33Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":89243,"stargazers_count":95,"watchers_count":95,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":8,"forks":14,"open_issues":8,"watchers":95,"default_branch":"develop"}},"base":{"label":"control-center:develop","ref":"develop","sha":"634df3778d36deef1f6570f17cba5b1e2471b0b1","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","deployments_url":"https://api.github.com/repos/control-center/serviced/deployments","created_at":"2013-08-06T16:45:00Z","updated_at":"2016-10-24T15:25:20Z","pushed_at":"2016-10-24T23:33:33Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":89243,"stargazers_count":95,"watchers_count":95,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":8,"forks":14,"open_issues":8,"watchers":95,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3143"},"html":{"href":"https://github.com/control-center/serviced/pull/3143"},"issue":{"href":"https://api.github.com/repos/control-center/serviced/issues/3143"},"comments":{"href":"https://api.github.com/repos/control-center/serviced/issues/3143/comments"},"review_comments":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3143/comments"},"review_comment":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3143/commits"},"statuses":{"href":"https://api.github.com/repos/control-center/serviced/statuses/9ff6432a673c35b2bc18f1d4437c4e80f95f66c2"}}}}
{"actor":{"display_login":"rDr4g0n"}}