{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17878","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17878/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17878/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17878/events","html_url":"https://github.com/TrinityCore/TrinityCore/issues/17878","id":174262653,"number":17878,"title":"MMaps improvements","user":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Priority-FutureFeatureRequest","name":"Priority-FutureFeatureRequest","color":"e102d8"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Sub-Maps/MMaps/Vmaps","name":"Sub-Maps/MMaps/Vmaps","color":"e10c02"}],"state":"open","locked":false,"assignee":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"assignees":[{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-08-31T12:40:18Z","updated_at":"2016-09-03T08:19:59Z","closed_at":null,"body":"**Description**:\r\nCurrent MMap settings and algorithms could be modified in attempt to improve overall pathfinding behavior. Current point of interests are:\r\n- [ ] Z coordinate returned by Detour is incremented with += 0.5f for no apparent reason https://github.com/TrinityCore/TrinityCore/blame/ccdca7774023e7570f17cf15456384b316322420/src/server/game/Movement/PathGenerator.cpp#L734 and https://github.com/TrinityCore/TrinityCore/blame/ccdca7774023e7570f17cf15456384b316322420/src/server/game/Movement/PathGenerator.cpp#L779 . This could be related to a recent commit that increased/decreased GetHeight() ray Z position by 0.5f\r\n- [ ] detailSampleMaxError and detailSampleDist could be lowered to get a more accurate Z from Detour that will still help getting the correct Z from maps/vmaps . https://github.com/jackpoz/recastnavigation can be used to test different values. Detail Mesh quality shouldn't affect node count in the A* algorithm and increase only mmaps generation times and memory usage. More infos about Detail Mesh at http://digestingduck.blogspot.it/2009_07_01_archive.html and http://digestingduck.blogspot.it/2009_08_01_archive.html\r\n\r\n\r\n**Branch(es)**:\r\n3.3.5\r\n\r\n**TC hash/commit**:  \r\nc0de28b045f6c7d31652262c9b96d0739fec8110\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/244534099","html_url":"https://github.com/TrinityCore/TrinityCore/issues/17878#issuecomment-244534099","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17878","id":244534099,"user":{"login":"r00ty-tc","id":173349,"avatar_url":"https://avatars.githubusercontent.com/u/173349?v=3","gravatar_id":"","url":"https://api.github.com/users/r00ty-tc","html_url":"https://github.com/r00ty-tc","followers_url":"https://api.github.com/users/r00ty-tc/followers","following_url":"https://api.github.com/users/r00ty-tc/following{/other_user}","gists_url":"https://api.github.com/users/r00ty-tc/gists{/gist_id}","starred_url":"https://api.github.com/users/r00ty-tc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r00ty-tc/subscriptions","organizations_url":"https://api.github.com/users/r00ty-tc/orgs","repos_url":"https://api.github.com/users/r00ty-tc/repos","events_url":"https://api.github.com/users/r00ty-tc/events{/privacy}","received_events_url":"https://api.github.com/users/r00ty-tc/received_events","type":"User","site_admin":false},"created_at":"2016-09-03T08:19:59Z","updated_at":"2016-09-03T08:19:59Z","body":"Some good ideas. Maybe that explains why when I tried to make a method to obtain vmap hints from mmaps (in order to avoid false underground ground levels).there were a few places with huge differences.\r\n\r\nI don't know why there would be the +0.5 though. For vmap rays it makes sense, but for the navmesh it doesn't."}}
{"actor":{"display_login":"r00ty-tc"}}