{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/Tapjoy/chore/pulls/30","id":63905018,"html_url":"https://github.com/Tapjoy/chore/pull/30","diff_url":"https://github.com/Tapjoy/chore/pull/30.diff","patch_url":"https://github.com/Tapjoy/chore/pull/30.patch","issue_url":"https://api.github.com/repos/Tapjoy/chore/issues/30","number":30,"state":"closed","locked":false,"title":"Change batch timeouts to be both configurable and based on the time oldest message","user":{"login":"obrie","id":6991,"avatar_url":"https://avatars.githubusercontent.com/u/6991?v=3","gravatar_id":"","url":"https://api.github.com/users/obrie","html_url":"https://github.com/obrie","followers_url":"https://api.github.com/users/obrie/followers","following_url":"https://api.github.com/users/obrie/following{/other_user}","gists_url":"https://api.github.com/users/obrie/gists{/gist_id}","starred_url":"https://api.github.com/users/obrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obrie/subscriptions","organizations_url":"https://api.github.com/users/obrie/orgs","repos_url":"https://api.github.com/users/obrie/repos","events_url":"https://api.github.com/users/obrie/events{/privacy}","received_events_url":"https://api.github.com/users/obrie/received_events","type":"User","site_admin":false},"body":"This makes two changes:\r\n1. The batch timeouts are now configurable instead of being hard-coded to 20s\r\n2. We now run `execute` when the oldest message in the batcher has exceeded the timeout.\r\n\r\nTo provide a little context, the current behavior of the timeout is that it is based on the newest message in the batcher.  Consider the scenario where batch size = 10 and timeout = 1m.  If a message came in every 30s, then the batch wouldn't be processed until 5m has passed (because the batch size will then be 10).\r\n\r\nI will also be looking for feedback / guidance on whether this should be a minor or major rev change.\r\n\r\n/to @gregorysabatino @theo-lanman @StabbyCutyou ","created_at":"2016-03-23T15:51:49Z","updated_at":"2016-03-24T16:37:22Z","closed_at":"2016-03-24T16:37:22Z","merged_at":"2016-03-24T16:37:22Z","merge_commit_sha":"1f9bfbc1a6435e774471923c0d26c69804fce18f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Tapjoy/chore/pulls/30/commits","review_comments_url":"https://api.github.com/repos/Tapjoy/chore/pulls/30/comments","review_comment_url":"https://api.github.com/repos/Tapjoy/chore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tapjoy/chore/issues/30/comments","statuses_url":"https://api.github.com/repos/Tapjoy/chore/statuses/ad60933fe713ee450e644493ea78501ef93da0d6","head":{"label":"Tapjoy:fix/batcher_timeouts","ref":"fix/batcher_timeouts","sha":"ad60933fe713ee450e644493ea78501ef93da0d6","user":{"login":"Tapjoy","id":716849,"avatar_url":"https://avatars.githubusercontent.com/u/716849?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapjoy","html_url":"https://github.com/Tapjoy","followers_url":"https://api.github.com/users/Tapjoy/followers","following_url":"https://api.github.com/users/Tapjoy/following{/other_user}","gists_url":"https://api.github.com/users/Tapjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapjoy/subscriptions","organizations_url":"https://api.github.com/users/Tapjoy/orgs","repos_url":"https://api.github.com/users/Tapjoy/repos","events_url":"https://api.github.com/users/Tapjoy/events{/privacy}","received_events_url":"https://api.github.com/users/Tapjoy/received_events","type":"Organization","site_admin":false},"repo":{"id":24512598,"name":"chore","full_name":"Tapjoy/chore","owner":{"login":"Tapjoy","id":716849,"avatar_url":"https://avatars.githubusercontent.com/u/716849?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapjoy","html_url":"https://github.com/Tapjoy","followers_url":"https://api.github.com/users/Tapjoy/followers","following_url":"https://api.github.com/users/Tapjoy/following{/other_user}","gists_url":"https://api.github.com/users/Tapjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapjoy/subscriptions","organizations_url":"https://api.github.com/users/Tapjoy/orgs","repos_url":"https://api.github.com/users/Tapjoy/repos","events_url":"https://api.github.com/users/Tapjoy/events{/privacy}","received_events_url":"https://api.github.com/users/Tapjoy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tapjoy/chore","description":"Job processing...for the future!","fork":false,"url":"https://api.github.com/repos/Tapjoy/chore","forks_url":"https://api.github.com/repos/Tapjoy/chore/forks","keys_url":"https://api.github.com/repos/Tapjoy/chore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tapjoy/chore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tapjoy/chore/teams","hooks_url":"https://api.github.com/repos/Tapjoy/chore/hooks","issue_events_url":"https://api.github.com/repos/Tapjoy/chore/issues/events{/number}","events_url":"https://api.github.com/repos/Tapjoy/chore/events","assignees_url":"https://api.github.com/repos/Tapjoy/chore/assignees{/user}","branches_url":"https://api.github.com/repos/Tapjoy/chore/branches{/branch}","tags_url":"https://api.github.com/repos/Tapjoy/chore/tags","blobs_url":"https://api.github.com/repos/Tapjoy/chore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tapjoy/chore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tapjoy/chore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tapjoy/chore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tapjoy/chore/statuses/{sha}","languages_url":"https://api.github.com/repos/Tapjoy/chore/languages","stargazers_url":"https://api.github.com/repos/Tapjoy/chore/stargazers","contributors_url":"https://api.github.com/repos/Tapjoy/chore/contributors","subscribers_url":"https://api.github.com/repos/Tapjoy/chore/subscribers","subscription_url":"https://api.github.com/repos/Tapjoy/chore/subscription","commits_url":"https://api.github.com/repos/Tapjoy/chore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tapjoy/chore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tapjoy/chore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tapjoy/chore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tapjoy/chore/contents/{+path}","compare_url":"https://api.github.com/repos/Tapjoy/chore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tapjoy/chore/merges","archive_url":"https://api.github.com/repos/Tapjoy/chore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tapjoy/chore/downloads","issues_url":"https://api.github.com/repos/Tapjoy/chore/issues{/number}","pulls_url":"https://api.github.com/repos/Tapjoy/chore/pulls{/number}","milestones_url":"https://api.github.com/repos/Tapjoy/chore/milestones{/number}","notifications_url":"https://api.github.com/repos/Tapjoy/chore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tapjoy/chore/labels{/name}","releases_url":"https://api.github.com/repos/Tapjoy/chore/releases{/id}","deployments_url":"https://api.github.com/repos/Tapjoy/chore/deployments","created_at":"2014-09-26T19:27:36Z","updated_at":"2016-03-22T22:22:58Z","pushed_at":"2016-03-24T16:37:23Z","git_url":"git://github.com/Tapjoy/chore.git","ssh_url":"git@github.com:Tapjoy/chore.git","clone_url":"https://github.com/Tapjoy/chore.git","svn_url":"https://github.com/Tapjoy/chore","homepage":"","size":1031,"stargazers_count":16,"watchers_count":16,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":16,"default_branch":"master"}},"base":{"label":"Tapjoy:master","ref":"master","sha":"6fd14ea56dec4f1939a55e7524ef80c1b7a05dbd","user":{"login":"Tapjoy","id":716849,"avatar_url":"https://avatars.githubusercontent.com/u/716849?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapjoy","html_url":"https://github.com/Tapjoy","followers_url":"https://api.github.com/users/Tapjoy/followers","following_url":"https://api.github.com/users/Tapjoy/following{/other_user}","gists_url":"https://api.github.com/users/Tapjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapjoy/subscriptions","organizations_url":"https://api.github.com/users/Tapjoy/orgs","repos_url":"https://api.github.com/users/Tapjoy/repos","events_url":"https://api.github.com/users/Tapjoy/events{/privacy}","received_events_url":"https://api.github.com/users/Tapjoy/received_events","type":"Organization","site_admin":false},"repo":{"id":24512598,"name":"chore","full_name":"Tapjoy/chore","owner":{"login":"Tapjoy","id":716849,"avatar_url":"https://avatars.githubusercontent.com/u/716849?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapjoy","html_url":"https://github.com/Tapjoy","followers_url":"https://api.github.com/users/Tapjoy/followers","following_url":"https://api.github.com/users/Tapjoy/following{/other_user}","gists_url":"https://api.github.com/users/Tapjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapjoy/subscriptions","organizations_url":"https://api.github.com/users/Tapjoy/orgs","repos_url":"https://api.github.com/users/Tapjoy/repos","events_url":"https://api.github.com/users/Tapjoy/events{/privacy}","received_events_url":"https://api.github.com/users/Tapjoy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tapjoy/chore","description":"Job processing...for the future!","fork":false,"url":"https://api.github.com/repos/Tapjoy/chore","forks_url":"https://api.github.com/repos/Tapjoy/chore/forks","keys_url":"https://api.github.com/repos/Tapjoy/chore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tapjoy/chore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tapjoy/chore/teams","hooks_url":"https://api.github.com/repos/Tapjoy/chore/hooks","issue_events_url":"https://api.github.com/repos/Tapjoy/chore/issues/events{/number}","events_url":"https://api.github.com/repos/Tapjoy/chore/events","assignees_url":"https://api.github.com/repos/Tapjoy/chore/assignees{/user}","branches_url":"https://api.github.com/repos/Tapjoy/chore/branches{/branch}","tags_url":"https://api.github.com/repos/Tapjoy/chore/tags","blobs_url":"https://api.github.com/repos/Tapjoy/chore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tapjoy/chore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tapjoy/chore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tapjoy/chore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tapjoy/chore/statuses/{sha}","languages_url":"https://api.github.com/repos/Tapjoy/chore/languages","stargazers_url":"https://api.github.com/repos/Tapjoy/chore/stargazers","contributors_url":"https://api.github.com/repos/Tapjoy/chore/contributors","subscribers_url":"https://api.github.com/repos/Tapjoy/chore/subscribers","subscription_url":"https://api.github.com/repos/Tapjoy/chore/subscription","commits_url":"https://api.github.com/repos/Tapjoy/chore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tapjoy/chore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tapjoy/chore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tapjoy/chore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tapjoy/chore/contents/{+path}","compare_url":"https://api.github.com/repos/Tapjoy/chore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tapjoy/chore/merges","archive_url":"https://api.github.com/repos/Tapjoy/chore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tapjoy/chore/downloads","issues_url":"https://api.github.com/repos/Tapjoy/chore/issues{/number}","pulls_url":"https://api.github.com/repos/Tapjoy/chore/pulls{/number}","milestones_url":"https://api.github.com/repos/Tapjoy/chore/milestones{/number}","notifications_url":"https://api.github.com/repos/Tapjoy/chore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tapjoy/chore/labels{/name}","releases_url":"https://api.github.com/repos/Tapjoy/chore/releases{/id}","deployments_url":"https://api.github.com/repos/Tapjoy/chore/deployments","created_at":"2014-09-26T19:27:36Z","updated_at":"2016-03-22T22:22:58Z","pushed_at":"2016-03-24T16:37:23Z","git_url":"git://github.com/Tapjoy/chore.git","ssh_url":"git@github.com:Tapjoy/chore.git","clone_url":"https://github.com/Tapjoy/chore.git","svn_url":"https://github.com/Tapjoy/chore","homepage":"","size":1031,"stargazers_count":16,"watchers_count":16,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tapjoy/chore/pulls/30"},"html":{"href":"https://github.com/Tapjoy/chore/pull/30"},"issue":{"href":"https://api.github.com/repos/Tapjoy/chore/issues/30"},"comments":{"href":"https://api.github.com/repos/Tapjoy/chore/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/Tapjoy/chore/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/Tapjoy/chore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tapjoy/chore/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/Tapjoy/chore/statuses/ad60933fe713ee450e644493ea78501ef93da0d6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"obrie","id":6991,"avatar_url":"https://avatars.githubusercontent.com/u/6991?v=3","gravatar_id":"","url":"https://api.github.com/users/obrie","html_url":"https://github.com/obrie","followers_url":"https://api.github.com/users/obrie/followers","following_url":"https://api.github.com/users/obrie/following{/other_user}","gists_url":"https://api.github.com/users/obrie/gists{/gist_id}","starred_url":"https://api.github.com/users/obrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obrie/subscriptions","organizations_url":"https://api.github.com/users/obrie/orgs","repos_url":"https://api.github.com/users/obrie/repos","events_url":"https://api.github.com/users/obrie/events{/privacy}","received_events_url":"https://api.github.com/users/obrie/received_events","type":"User","site_admin":false},"comments":10,"review_comments":5,"commits":1,"additions":73,"deletions":10,"changed_files":7}}