{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/84392215","pull_request_review_id":5174224,"id":84392215,"diff_hunk":"@@ -589,13 +589,15 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo\n         determinedSandboxState = true;\n     }, [&, wantsSandboxRunning]() {\n         qCDebug(interfaceapp) << \"Home sandbox does not appear to be running....\";\n-        determinedSandboxState = true;\n         if (wantsSandboxRunning) {\n             QString contentPath = getRunServerPath();\n             SandboxUtils::runLocalSandbox(contentPath, true, RUNNING_MARKER_FILENAME);\n         }\n+        determinedSandboxState = true;","path":"interface/src/Application.cpp","position":9,"original_position":9,"commit_id":"ab02fd79a0dc2541a5a1da2264d454bccd558421","original_commit_id":"ab02fd79a0dc2541a5a1da2264d454bccd558421","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"If `wantsSandboxRunning` is false, the sandbox won't really be up. I think we need another boolean to indicate whether the server is up or not, and use that down below when deciding where to go.","created_at":"2016-10-20T22:54:46Z","updated_at":"2016-10-20T22:54:46Z","html_url":"https://github.com/highfidelity/hifi/pull/8860#discussion_r84392215","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8860","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/84392215"},"html":{"href":"https://github.com/highfidelity/hifi/pull/8860#discussion_r84392215"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8860"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/8860","id":90088540,"html_url":"https://github.com/highfidelity/hifi/pull/8860","diff_url":"https://github.com/highfidelity/hifi/pull/8860.diff","patch_url":"https://github.com/highfidelity/hifi/pull/8860.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/8860","number":8860,"state":"open","locked":false,"title":"Fix for sandbox startup issue","user":{"login":"davidkelly","id":1072532,"avatar_url":"https://avatars.githubusercontent.com/u/1072532?v=3","gravatar_id":"","url":"https://api.github.com/users/davidkelly","html_url":"https://github.com/davidkelly","followers_url":"https://api.github.com/users/davidkelly/followers","following_url":"https://api.github.com/users/davidkelly/following{/other_user}","gists_url":"https://api.github.com/users/davidkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkelly/subscriptions","organizations_url":"https://api.github.com/users/davidkelly/orgs","repos_url":"https://api.github.com/users/davidkelly/repos","events_url":"https://api.github.com/users/davidkelly/events{/privacy}","received_events_url":"https://api.github.com/users/davidkelly/received_events","type":"User","site_admin":false},"body":"Move `determinedSandboxState=true` until after we spawn it.   ","created_at":"2016-10-19T20:54:16Z","updated_at":"2016-10-20T22:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e955d47522f75bc3ed177af2ba7cc89b0adcc79c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8860/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8860/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/8860/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/ab02fd79a0dc2541a5a1da2264d454bccd558421","head":{"label":"davidkelly:dk/2004","ref":"dk/2004","sha":"ab02fd79a0dc2541a5a1da2264d454bccd558421","user":{"login":"davidkelly","id":1072532,"avatar_url":"https://avatars.githubusercontent.com/u/1072532?v=3","gravatar_id":"","url":"https://api.github.com/users/davidkelly","html_url":"https://github.com/davidkelly","followers_url":"https://api.github.com/users/davidkelly/followers","following_url":"https://api.github.com/users/davidkelly/following{/other_user}","gists_url":"https://api.github.com/users/davidkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkelly/subscriptions","organizations_url":"https://api.github.com/users/davidkelly/orgs","repos_url":"https://api.github.com/users/davidkelly/repos","events_url":"https://api.github.com/users/davidkelly/events{/privacy}","received_events_url":"https://api.github.com/users/davidkelly/received_events","type":"User","site_admin":false},"repo":{"id":62350098,"name":"hifi","full_name":"davidkelly/hifi","owner":{"login":"davidkelly","id":1072532,"avatar_url":"https://avatars.githubusercontent.com/u/1072532?v=3","gravatar_id":"","url":"https://api.github.com/users/davidkelly","html_url":"https://github.com/davidkelly","followers_url":"https://api.github.com/users/davidkelly/followers","following_url":"https://api.github.com/users/davidkelly/following{/other_user}","gists_url":"https://api.github.com/users/davidkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkelly/subscriptions","organizations_url":"https://api.github.com/users/davidkelly/orgs","repos_url":"https://api.github.com/users/davidkelly/repos","events_url":"https://api.github.com/users/davidkelly/events{/privacy}","received_events_url":"https://api.github.com/users/davidkelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidkelly/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/davidkelly/hifi","forks_url":"https://api.github.com/repos/davidkelly/hifi/forks","keys_url":"https://api.github.com/repos/davidkelly/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidkelly/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidkelly/hifi/teams","hooks_url":"https://api.github.com/repos/davidkelly/hifi/hooks","issue_events_url":"https://api.github.com/repos/davidkelly/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/davidkelly/hifi/events","assignees_url":"https://api.github.com/repos/davidkelly/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/davidkelly/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/davidkelly/hifi/tags","blobs_url":"https://api.github.com/repos/davidkelly/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidkelly/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidkelly/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidkelly/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidkelly/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/davidkelly/hifi/languages","stargazers_url":"https://api.github.com/repos/davidkelly/hifi/stargazers","contributors_url":"https://api.github.com/repos/davidkelly/hifi/contributors","subscribers_url":"https://api.github.com/repos/davidkelly/hifi/subscribers","subscription_url":"https://api.github.com/repos/davidkelly/hifi/subscription","commits_url":"https://api.github.com/repos/davidkelly/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidkelly/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidkelly/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidkelly/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidkelly/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/davidkelly/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidkelly/hifi/merges","archive_url":"https://api.github.com/repos/davidkelly/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidkelly/hifi/downloads","issues_url":"https://api.github.com/repos/davidkelly/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/davidkelly/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/davidkelly/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/davidkelly/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidkelly/hifi/labels{/name}","releases_url":"https://api.github.com/repos/davidkelly/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/davidkelly/hifi/deployments","created_at":"2016-07-01T00:16:16Z","updated_at":"2016-07-01T00:16:24Z","pushed_at":"2016-10-20T17:13:15Z","git_url":"git://github.com/davidkelly/hifi.git","ssh_url":"git@github.com:davidkelly/hifi.git","clone_url":"https://github.com/davidkelly/hifi.git","svn_url":"https://github.com/davidkelly/hifi","homepage":"","size":233940,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"3f4ca27e76607fada674b3951477a35d4403f58b","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2016-10-18T23:49:47Z","pushed_at":"2016-10-20T22:50:11Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":283296,"stargazers_count":435,"watchers_count":435,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":48,"forks":256,"open_issues":48,"watchers":435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8860"},"html":{"href":"https://github.com/highfidelity/hifi/pull/8860"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/8860"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/8860/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8860/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8860/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/ab02fd79a0dc2541a5a1da2264d454bccd558421"}}}}
{"actor":{"display_login":"huffman"}}