{"action":"created","issue":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826","repository_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826/labels{/name}","comments_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826/comments","events_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826/events","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826","id":169118554,"number":826,"title":"#819 added basic AppContext functions","user":{"login":"baydet","id":1755124,"avatar_url":"https://avatars.githubusercontent.com/u/1755124?v=3","gravatar_id":"","url":"https://api.github.com/users/baydet","html_url":"https://github.com/baydet","followers_url":"https://api.github.com/users/baydet/followers","following_url":"https://api.github.com/users/baydet/following{/other_user}","gists_url":"https://api.github.com/users/baydet/gists{/gist_id}","starred_url":"https://api.github.com/users/baydet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baydet/subscriptions","organizations_url":"https://api.github.com/users/baydet/orgs","repos_url":"https://api.github.com/users/baydet/repos","events_url":"https://api.github.com/users/baydet/events{/privacy}","received_events_url":"https://api.github.com/users/baydet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/3%20-%20Working","name":"3 - Working","color":"CCCCCC"},{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/cla-signed","name":"cla-signed","color":"207de5"},{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"assignees":[{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/milestones/7","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/milestones/New%20Infra","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/milestones/7/labels","id":1498038,"number":7,"title":"New Infra","description":"This will be the first release of the new infrastructure working end to end.\r\n\r\n<!---\r\n@huboard:{\"order\":0.25}\r\n-->\r\n","creator":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"open_issues":71,"closed_issues":247,"state":"open","created_at":"2016-01-11T19:12:00Z","updated_at":"2016-08-22T11:59:25Z","due_on":null,"closed_at":null},"comments":45,"created_at":"2016-08-03T12:23:09Z","updated_at":"2016-08-22T13:23:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/pulls/826","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826","diff_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826.diff","patch_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/thaliproject/thali_cordovaplugin/826)\n<!-- Reviewable:end -->\n\r\n\r\n<!---\r\n@huboard:{\"order\":4.4275900586456207e-16,\"milestone_order\":826.0,\"custom_state\":\"\"}\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/comments/241410897","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826#issuecomment-241410897","issue_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826","id":241410897,"user":{"login":"larryonoff","id":372616,"avatar_url":"https://avatars.githubusercontent.com/u/372616?v=3","gravatar_id":"","url":"https://api.github.com/users/larryonoff","html_url":"https://github.com/larryonoff","followers_url":"https://api.github.com/users/larryonoff/followers","following_url":"https://api.github.com/users/larryonoff/following{/other_user}","gists_url":"https://api.github.com/users/larryonoff/gists{/gist_id}","starred_url":"https://api.github.com/users/larryonoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larryonoff/subscriptions","organizations_url":"https://api.github.com/users/larryonoff/orgs","repos_url":"https://api.github.com/users/larryonoff/repos","events_url":"https://api.github.com/users/larryonoff/events{/privacy}","received_events_url":"https://api.github.com/users/larryonoff/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T13:23:52Z","updated_at":"2016-08-22T13:23:52Z","body":"\n\n\n\nReview status: 59 of 62 files reviewed at latest revision, 16 unresolved discussions.\n\n---\n\n*[src/ios/AppContext.swift, line 79 \\[r13\\]](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/826#-KPmPgmOFKLXfkEu4pWK:-KPmPgmOFKLXfkEu4pWL:bv5z2a2) ([raw file](https://github.com/thaliproject/thali_cordovaplugin/blob/21030057b84f01bffec174e4e511ded2f6295d25/src/ios/AppContext.swift#L79)):*\n> ```Swift\n>     private var networkChangedRegistered: Bool = false\n> \n>     private func updateNetworkStatus() {\n> ```\n\nAll these methods just for raising events, so I recommend rename them into something like ```notifyOnDidUpdateNetworkStatus```.\n\n---\n\n*[src/ios/AppContext.swift, line 83 \\[r13\\]](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/826#-KPmMpTZ9aCajJ5XxNcz:-KPmMpTZ9aCajJ5XxNd-:b-ltrj5y) ([raw file](https://github.com/thaliproject/thali_cordovaplugin/blob/21030057b84f01bffec174e4e511ded2f6295d25/src/ios/AppContext.swift#L83)):*\n> ```Swift\n>         do {\n>             delegate?.context(self, didChangeNetworkStatus: try jsonValue([:])!)\n>         } catch _ {\n> ```\n\nI assume that we should put assert in the catch if the case assumed to be unreachable.\n\n---\n\n*[src/ios/AppContext.swift, line 153 \\[r13\\]](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/826#-KPmOuAmYZKVOz46btbd:-KPmOuAmYZKVOz46btbe:bc4ks71) ([raw file](https://github.com/thaliproject/thali_cordovaplugin/blob/21030057b84f01bffec174e4e511ded2f6295d25/src/ios/AppContext.swift#L153)):*\n> ```Swift\n> }\n> \n> /// Node functions names\n> ```\n\nI think we need to expose node functions names in a calls with the name like `AppContextJSEvent`, but not the same as it is, because the current names are confusing.\n\nI also recommend trying to replace these constants as class variables and not as methods if bridged into obj-c.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/826)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"larryonoff"}}