{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/72862111","id":72862111,"diff_hunk":"@@ -17,6 +17,15 @@\n # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n # GNU Library Public License for more details.\n #\n+if [ x\"$SRC_PATH\"x = xx ]; then\n+  CEPH_DIR=`dirname $0`\n+  CEPH_DIR=`(cd $CEPH_DIR/../..; pwd)`\n+fi\n+\n+CEPH_SRC=$CEPH_DIR/src\n+CEPH_BIN=$CEPH_SRC","path":"qa/workunits/ceph-helpers.sh","position":10,"original_position":10,"commit_id":"5c3a389b1a5cb1222399b7140d20ebc53d0f1b86","original_commit_id":"5c3a389b1a5cb1222399b7140d20ebc53d0f1b86","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"body":"@liewegas @tchaikov \r\nHow desperate are we that the scripts can still be executed standalone?\r\n\r\nI can construct `CEPH_{ROOT,BIN,LIB}` relatively easy for standalone, cmake and autobuild,\r\n(updated the commit to match that)\r\nbut getting PYTHONPATH requires (in Cmake env):\r\n    `./build/lib/cython_modules/lib.freebsd-11.0-CURRENT-amd64-2.7/`\r\nto find `rados.so` \r\nWhich is sort a far fetched path. \r\n\r\nI see a few solutions, but one relatively nice one would be to Cmake to actually install rados.so into something like `./build/lib` or `./build/lib/pybind`  OR replace `lib` with `bin`","created_at":"2016-07-29T21:16:01Z","updated_at":"2016-07-29T21:16:01Z","html_url":"https://github.com/ceph/ceph/pull/10022#discussion_r72862111","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10022","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/72862111"},"html":{"href":"https://github.com/ceph/ceph/pull/10022#discussion_r72862111"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10022"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10022","id":75675286,"html_url":"https://github.com/ceph/ceph/pull/10022","diff_url":"https://github.com/ceph/ceph/pull/10022.diff","patch_url":"https://github.com/ceph/ceph/pull/10022.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10022","number":10022,"state":"open","locked":false,"title":"../qa/workunits/ceph-helpers.sh: Allow TESTS to run standalone","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"body":"Still falllout of the move to cmake building\r\n\r\nSigned-off-by: Willem Jan Withagen <wjw@digiware.nl>","created_at":"2016-06-29T16:00:20Z","updated_at":"2016-07-29T21:16:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b531be658f83822d489cef3526bfaacbfdd6d97","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10022/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10022/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10022/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/5c3a389b1a5cb1222399b7140d20ebc53d0f1b86","head":{"label":"wjwithagen:wip-wjw-debug-testing","ref":"wip-wjw-debug-testing","sha":"5c3a389b1a5cb1222399b7140d20ebc53d0f1b86","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"repo":{"id":50789401,"name":"ceph","full_name":"wjwithagen/ceph","owner":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wjwithagen/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/wjwithagen/ceph","forks_url":"https://api.github.com/repos/wjwithagen/ceph/forks","keys_url":"https://api.github.com/repos/wjwithagen/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wjwithagen/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wjwithagen/ceph/teams","hooks_url":"https://api.github.com/repos/wjwithagen/ceph/hooks","issue_events_url":"https://api.github.com/repos/wjwithagen/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/wjwithagen/ceph/events","assignees_url":"https://api.github.com/repos/wjwithagen/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/wjwithagen/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/wjwithagen/ceph/tags","blobs_url":"https://api.github.com/repos/wjwithagen/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wjwithagen/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wjwithagen/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/wjwithagen/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wjwithagen/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/wjwithagen/ceph/languages","stargazers_url":"https://api.github.com/repos/wjwithagen/ceph/stargazers","contributors_url":"https://api.github.com/repos/wjwithagen/ceph/contributors","subscribers_url":"https://api.github.com/repos/wjwithagen/ceph/subscribers","subscription_url":"https://api.github.com/repos/wjwithagen/ceph/subscription","commits_url":"https://api.github.com/repos/wjwithagen/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/wjwithagen/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/wjwithagen/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/wjwithagen/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/wjwithagen/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/wjwithagen/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wjwithagen/ceph/merges","archive_url":"https://api.github.com/repos/wjwithagen/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wjwithagen/ceph/downloads","issues_url":"https://api.github.com/repos/wjwithagen/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/wjwithagen/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/wjwithagen/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/wjwithagen/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wjwithagen/ceph/labels{/name}","releases_url":"https://api.github.com/repos/wjwithagen/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/wjwithagen/ceph/deployments","created_at":"2016-01-31T18:48:17Z","updated_at":"2016-07-28T08:35:18Z","pushed_at":"2016-07-29T18:58:14Z","git_url":"git://github.com/wjwithagen/ceph.git","ssh_url":"git@github.com:wjwithagen/ceph.git","clone_url":"https://github.com/wjwithagen/ceph.git","svn_url":"https://github.com/wjwithagen/ceph","homepage":"http://ceph.com","size":171718,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"ee7949f1e50354df432c285ffb06d0306689cec7","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-07-29T20:11:32Z","pushed_at":"2016-07-29T21:05:55Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":230334,"stargazers_count":2335,"watchers_count":2335,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1390,"mirror_url":null,"open_issues_count":483,"forks":1390,"open_issues":483,"watchers":2335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10022"},"html":{"href":"https://github.com/ceph/ceph/pull/10022"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10022"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10022/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10022/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10022/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/5c3a389b1a5cb1222399b7140d20ebc53d0f1b86"}}}}
{"actor":{"display_login":"wjwithagen"}}