{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/12191","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/12191/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/12191/comments","events_url":"https://api.github.com/repos/apache/spark/issues/12191/events","html_url":"https://github.com/apache/spark/pull/12191","id":146150871,"number":12191,"title":"[SPARK-14398] [SQL] Audit non-reserved keyword list in ANTLR4 parser","user":{"login":"bomeng","id":295781,"avatar_url":"https://avatars.githubusercontent.com/u/295781?v=3","gravatar_id":"","url":"https://api.github.com/users/bomeng","html_url":"https://github.com/bomeng","followers_url":"https://api.github.com/users/bomeng/followers","following_url":"https://api.github.com/users/bomeng/following{/other_user}","gists_url":"https://api.github.com/users/bomeng/gists{/gist_id}","starred_url":"https://api.github.com/users/bomeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bomeng/subscriptions","organizations_url":"https://api.github.com/users/bomeng/orgs","repos_url":"https://api.github.com/users/bomeng/repos","events_url":"https://api.github.com/users/bomeng/events{/privacy}","received_events_url":"https://api.github.com/users/bomeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-04-06T00:40:58Z","updated_at":"2016-04-07T23:17:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12191","html_url":"https://github.com/apache/spark/pull/12191","diff_url":"https://github.com/apache/spark/pull/12191.diff","patch_url":"https://github.com/apache/spark/pull/12191.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nI have compared non-reserved list in Antlr3 and Antlr4 one by one, added the missing non-reserved that were defined in Antlr3 to the new Antlr4 file.\r\n\r\nThe keywords related to data types are not added, here is the list:\r\n`KW_LONG, KW_STRING, KW_STRUCT, KW_TINYINT, KW_UNIONTYPE, KW_UNSIGNED\r\n`\r\n\r\nThe keywords related to time/date are added to Antlr4, here is the list:\r\n`KW_DAY, KW_DATETIME, KW_HOUR, KW_YEAR, KW_UTC, KW_UTCTIMESTAMP\r\n`\r\n\r\nThe keywords that were introduced in Antlr3 but not the official keywords, are not added to Antlr4 for now, here is the list:\r\n`KW_ANTI, KW_WEEK, KW_MILLISECOND, KW_MICROSECOND, KW_CLEAR, KW_LAZY, KW_CACHE, KW_UNCACHE, KW_DFS\r\n `\r\n\r\nAny recommendation for the above is welcome. \r\n\r\n## How was this patch tested?\r\n\r\nI manually checked the keywords one by one. Please let me know if there is a better way to test.\r\n\r\nAnother thought: I suggest to put all the keywords definition and non-reserved list in order, that will be much easier to check in the future. \r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/207134445","html_url":"https://github.com/apache/spark/pull/12191#issuecomment-207134445","issue_url":"https://api.github.com/repos/apache/spark/issues/12191","id":207134445,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T23:17:52Z","updated_at":"2016-04-07T23:17:52Z","body":"Merged build finished. Test PASSed."}}