{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls/1","id":90477999,"html_url":"https://github.com/FHeilmann/OctoPrint/pull/1","diff_url":"https://github.com/FHeilmann/OctoPrint/pull/1.diff","patch_url":"https://github.com/FHeilmann/OctoPrint/pull/1.patch","issue_url":"https://api.github.com/repos/FHeilmann/OctoPrint/issues/1","number":1,"state":"closed","locked":false,"title":"Adjust output of values() classmethod","user":{"login":"FHeilmann","id":4352664,"avatar_url":"https://avatars.githubusercontent.com/u/4352664?v=3","gravatar_id":"","url":"https://api.github.com/users/FHeilmann","html_url":"https://github.com/FHeilmann","followers_url":"https://api.github.com/users/FHeilmann/followers","following_url":"https://api.github.com/users/FHeilmann/following{/other_user}","gists_url":"https://api.github.com/users/FHeilmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FHeilmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHeilmann/subscriptions","organizations_url":"https://api.github.com/users/FHeilmann/orgs","repos_url":"https://api.github.com/users/FHeilmann/repos","events_url":"https://api.github.com/users/FHeilmann/events{/privacy}","received_events_url":"https://api.github.com/users/FHeilmann/received_events","type":"User","site_admin":false},"body":"#### What does this PR do and why is it necessary?\r\n\r\nThe way values() works right now, the resulting array will also return itself. This isn't really a problem here, but if someone takes this function as a guide (like me) they can run into problems when iterating over the returned array, as it contains an element representing \"values()\" itself. As such, the change is more of a cosmetic nature, but since the fix is trivial I feel it makes sense.\r\n\r\n#### How was it tested? How can it be tested by the reviewer?\r\n\r\nIn the plug-in I am currently developing, adjusting the output this way yields the expected result array.\r\n\r\n#### Any background context you want to provide?\r\n\r\n#### What are the relevant tickets if any?\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n#### Further notes\r\n\r\nAnother approach would be make use of the inspect package and replace name=\"values\" with inspect.ismethod(name)","created_at":"2016-10-22T10:39:30Z","updated_at":"2016-10-22T10:44:17Z","closed_at":"2016-10-22T10:44:17Z","merged_at":"2016-10-22T10:44:17Z","merge_commit_sha":"d11db6e2979a43bb05498393de6756d6c0a088c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls/1/commits","review_comments_url":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls/1/comments","review_comment_url":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FHeilmann/OctoPrint/issues/1/comments","statuses_url":"https://api.github.com/repos/FHeilmann/OctoPrint/statuses/fd1016695f834294886496a889c92982cf7b1395","head":{"label":"FHeilmann:FHeilmann-adjust_values_func","ref":"FHeilmann-adjust_values_func","sha":"fd1016695f834294886496a889c92982cf7b1395","user":{"login":"FHeilmann","id":4352664,"avatar_url":"https://avatars.githubusercontent.com/u/4352664?v=3","gravatar_id":"","url":"https://api.github.com/users/FHeilmann","html_url":"https://github.com/FHeilmann","followers_url":"https://api.github.com/users/FHeilmann/followers","following_url":"https://api.github.com/users/FHeilmann/following{/other_user}","gists_url":"https://api.github.com/users/FHeilmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FHeilmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHeilmann/subscriptions","organizations_url":"https://api.github.com/users/FHeilmann/orgs","repos_url":"https://api.github.com/users/FHeilmann/repos","events_url":"https://api.github.com/users/FHeilmann/events{/privacy}","received_events_url":"https://api.github.com/users/FHeilmann/received_events","type":"User","site_admin":false},"repo":{"id":71632538,"name":"OctoPrint","full_name":"FHeilmann/OctoPrint","owner":{"login":"FHeilmann","id":4352664,"avatar_url":"https://avatars.githubusercontent.com/u/4352664?v=3","gravatar_id":"","url":"https://api.github.com/users/FHeilmann","html_url":"https://github.com/FHeilmann","followers_url":"https://api.github.com/users/FHeilmann/followers","following_url":"https://api.github.com/users/FHeilmann/following{/other_user}","gists_url":"https://api.github.com/users/FHeilmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FHeilmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHeilmann/subscriptions","organizations_url":"https://api.github.com/users/FHeilmann/orgs","repos_url":"https://api.github.com/users/FHeilmann/repos","events_url":"https://api.github.com/users/FHeilmann/events{/privacy}","received_events_url":"https://api.github.com/users/FHeilmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FHeilmann/OctoPrint","description":"OctoPrint is the snappy web interface for your 3D printer!","fork":true,"url":"https://api.github.com/repos/FHeilmann/OctoPrint","forks_url":"https://api.github.com/repos/FHeilmann/OctoPrint/forks","keys_url":"https://api.github.com/repos/FHeilmann/OctoPrint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FHeilmann/OctoPrint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FHeilmann/OctoPrint/teams","hooks_url":"https://api.github.com/repos/FHeilmann/OctoPrint/hooks","issue_events_url":"https://api.github.com/repos/FHeilmann/OctoPrint/issues/events{/number}","events_url":"https://api.github.com/repos/FHeilmann/OctoPrint/events","assignees_url":"https://api.github.com/repos/FHeilmann/OctoPrint/assignees{/user}","branches_url":"https://api.github.com/repos/FHeilmann/OctoPrint/branches{/branch}","tags_url":"https://api.github.com/repos/FHeilmann/OctoPrint/tags","blobs_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/refs{/sha}","trees_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FHeilmann/OctoPrint/statuses/{sha}","languages_url":"https://api.github.com/repos/FHeilmann/OctoPrint/languages","stargazers_url":"https://api.github.com/repos/FHeilmann/OctoPrint/stargazers","contributors_url":"https://api.github.com/repos/FHeilmann/OctoPrint/contributors","subscribers_url":"https://api.github.com/repos/FHeilmann/OctoPrint/subscribers","subscription_url":"https://api.github.com/repos/FHeilmann/OctoPrint/subscription","commits_url":"https://api.github.com/repos/FHeilmann/OctoPrint/commits{/sha}","git_commits_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/commits{/sha}","comments_url":"https://api.github.com/repos/FHeilmann/OctoPrint/comments{/number}","issue_comment_url":"https://api.github.com/repos/FHeilmann/OctoPrint/issues/comments{/number}","contents_url":"https://api.github.com/repos/FHeilmann/OctoPrint/contents/{+path}","compare_url":"https://api.github.com/repos/FHeilmann/OctoPrint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FHeilmann/OctoPrint/merges","archive_url":"https://api.github.com/repos/FHeilmann/OctoPrint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FHeilmann/OctoPrint/downloads","issues_url":"https://api.github.com/repos/FHeilmann/OctoPrint/issues{/number}","pulls_url":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls{/number}","milestones_url":"https://api.github.com/repos/FHeilmann/OctoPrint/milestones{/number}","notifications_url":"https://api.github.com/repos/FHeilmann/OctoPrint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FHeilmann/OctoPrint/labels{/name}","releases_url":"https://api.github.com/repos/FHeilmann/OctoPrint/releases{/id}","deployments_url":"https://api.github.com/repos/FHeilmann/OctoPrint/deployments","created_at":"2016-10-22T10:35:29Z","updated_at":"2016-10-22T10:35:31Z","pushed_at":"2016-10-22T10:44:17Z","git_url":"git://github.com/FHeilmann/OctoPrint.git","ssh_url":"git@github.com:FHeilmann/OctoPrint.git","clone_url":"https://github.com/FHeilmann/OctoPrint.git","svn_url":"https://github.com/FHeilmann/OctoPrint","homepage":"http://octoprint.org","size":75474,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FHeilmann:devel","ref":"devel","sha":"d3cc96523e786e32956b2787b077b36fa44251ea","user":{"login":"FHeilmann","id":4352664,"avatar_url":"https://avatars.githubusercontent.com/u/4352664?v=3","gravatar_id":"","url":"https://api.github.com/users/FHeilmann","html_url":"https://github.com/FHeilmann","followers_url":"https://api.github.com/users/FHeilmann/followers","following_url":"https://api.github.com/users/FHeilmann/following{/other_user}","gists_url":"https://api.github.com/users/FHeilmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FHeilmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHeilmann/subscriptions","organizations_url":"https://api.github.com/users/FHeilmann/orgs","repos_url":"https://api.github.com/users/FHeilmann/repos","events_url":"https://api.github.com/users/FHeilmann/events{/privacy}","received_events_url":"https://api.github.com/users/FHeilmann/received_events","type":"User","site_admin":false},"repo":{"id":71632538,"name":"OctoPrint","full_name":"FHeilmann/OctoPrint","owner":{"login":"FHeilmann","id":4352664,"avatar_url":"https://avatars.githubusercontent.com/u/4352664?v=3","gravatar_id":"","url":"https://api.github.com/users/FHeilmann","html_url":"https://github.com/FHeilmann","followers_url":"https://api.github.com/users/FHeilmann/followers","following_url":"https://api.github.com/users/FHeilmann/following{/other_user}","gists_url":"https://api.github.com/users/FHeilmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FHeilmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHeilmann/subscriptions","organizations_url":"https://api.github.com/users/FHeilmann/orgs","repos_url":"https://api.github.com/users/FHeilmann/repos","events_url":"https://api.github.com/users/FHeilmann/events{/privacy}","received_events_url":"https://api.github.com/users/FHeilmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FHeilmann/OctoPrint","description":"OctoPrint is the snappy web interface for your 3D printer!","fork":true,"url":"https://api.github.com/repos/FHeilmann/OctoPrint","forks_url":"https://api.github.com/repos/FHeilmann/OctoPrint/forks","keys_url":"https://api.github.com/repos/FHeilmann/OctoPrint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FHeilmann/OctoPrint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FHeilmann/OctoPrint/teams","hooks_url":"https://api.github.com/repos/FHeilmann/OctoPrint/hooks","issue_events_url":"https://api.github.com/repos/FHeilmann/OctoPrint/issues/events{/number}","events_url":"https://api.github.com/repos/FHeilmann/OctoPrint/events","assignees_url":"https://api.github.com/repos/FHeilmann/OctoPrint/assignees{/user}","branches_url":"https://api.github.com/repos/FHeilmann/OctoPrint/branches{/branch}","tags_url":"https://api.github.com/repos/FHeilmann/OctoPrint/tags","blobs_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/refs{/sha}","trees_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FHeilmann/OctoPrint/statuses/{sha}","languages_url":"https://api.github.com/repos/FHeilmann/OctoPrint/languages","stargazers_url":"https://api.github.com/repos/FHeilmann/OctoPrint/stargazers","contributors_url":"https://api.github.com/repos/FHeilmann/OctoPrint/contributors","subscribers_url":"https://api.github.com/repos/FHeilmann/OctoPrint/subscribers","subscription_url":"https://api.github.com/repos/FHeilmann/OctoPrint/subscription","commits_url":"https://api.github.com/repos/FHeilmann/OctoPrint/commits{/sha}","git_commits_url":"https://api.github.com/repos/FHeilmann/OctoPrint/git/commits{/sha}","comments_url":"https://api.github.com/repos/FHeilmann/OctoPrint/comments{/number}","issue_comment_url":"https://api.github.com/repos/FHeilmann/OctoPrint/issues/comments{/number}","contents_url":"https://api.github.com/repos/FHeilmann/OctoPrint/contents/{+path}","compare_url":"https://api.github.com/repos/FHeilmann/OctoPrint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FHeilmann/OctoPrint/merges","archive_url":"https://api.github.com/repos/FHeilmann/OctoPrint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FHeilmann/OctoPrint/downloads","issues_url":"https://api.github.com/repos/FHeilmann/OctoPrint/issues{/number}","pulls_url":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls{/number}","milestones_url":"https://api.github.com/repos/FHeilmann/OctoPrint/milestones{/number}","notifications_url":"https://api.github.com/repos/FHeilmann/OctoPrint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FHeilmann/OctoPrint/labels{/name}","releases_url":"https://api.github.com/repos/FHeilmann/OctoPrint/releases{/id}","deployments_url":"https://api.github.com/repos/FHeilmann/OctoPrint/deployments","created_at":"2016-10-22T10:35:29Z","updated_at":"2016-10-22T10:35:31Z","pushed_at":"2016-10-22T10:44:17Z","git_url":"git://github.com/FHeilmann/OctoPrint.git","ssh_url":"git@github.com:FHeilmann/OctoPrint.git","clone_url":"https://github.com/FHeilmann/OctoPrint.git","svn_url":"https://github.com/FHeilmann/OctoPrint","homepage":"http://octoprint.org","size":75474,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls/1"},"html":{"href":"https://github.com/FHeilmann/OctoPrint/pull/1"},"issue":{"href":"https://api.github.com/repos/FHeilmann/OctoPrint/issues/1"},"comments":{"href":"https://api.github.com/repos/FHeilmann/OctoPrint/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FHeilmann/OctoPrint/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/FHeilmann/OctoPrint/statuses/fd1016695f834294886496a889c92982cf7b1395"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"FHeilmann","id":4352664,"avatar_url":"https://avatars.githubusercontent.com/u/4352664?v=3","gravatar_id":"","url":"https://api.github.com/users/FHeilmann","html_url":"https://github.com/FHeilmann","followers_url":"https://api.github.com/users/FHeilmann/followers","following_url":"https://api.github.com/users/FHeilmann/following{/other_user}","gists_url":"https://api.github.com/users/FHeilmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FHeilmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHeilmann/subscriptions","organizations_url":"https://api.github.com/users/FHeilmann/orgs","repos_url":"https://api.github.com/users/FHeilmann/repos","events_url":"https://api.github.com/users/FHeilmann/events{/privacy}","received_events_url":"https://api.github.com/users/FHeilmann/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"FHeilmann"}}