{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/3779","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/3779/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/3779/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/3779/events","html_url":"https://github.com/fastlane/fastlane/issues/3779","id":141261850,"number":3779,"title":"Deliver: add preview upload","user":{"login":"lacostej","id":24282,"avatar_url":"https://avatars.githubusercontent.com/u/24282?v=3","gravatar_id":"","url":"https://api.github.com/users/lacostej","html_url":"https://github.com/lacostej","followers_url":"https://api.github.com/users/lacostej/followers","following_url":"https://api.github.com/users/lacostej/following{/other_user}","gists_url":"https://api.github.com/users/lacostej/gists{/gist_id}","starred_url":"https://api.github.com/users/lacostej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lacostej/subscriptions","organizations_url":"https://api.github.com/users/lacostej/orgs","repos_url":"https://api.github.com/users/lacostej/repos","events_url":"https://api.github.com/users/lacostej/events{/privacy}","received_events_url":"https://api.github.com/users/lacostej/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fastlane/fastlane/labels/deliver","name":"deliver","color":"e11d21"},{"url":"https://api.github.com/repos/fastlane/fastlane/labels/spaceship","name":"spaceship","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-16T12:44:19Z","updated_at":"2016-05-22T18:29:49Z","closed_at":null,"body":"# Description:\r\n\r\nspaceship supports uploading preview video, a feature only available on safari right now.\r\n\r\nWe want to integrate this into deliver.\r\n\r\nRelated to #2251 (cc @Ged2323).\r\nSee also #1690\r\n\r\nSpaceship supports 2 modes:\r\n* with a given preview image\r\n* without. In this case it will generate one using ffmpeg tools.\r\n\r\nAt start we want to only support the use case of the user specifying the preview image. Because we assume ffmpeg might not be present. \r\n\r\nCare needs to be taken to support the new sync infra (using MD5). Take care of looking how that affects the preview image upload as well.\r\n\r\n# Questions: \r\n* should the preview video have its own skip parameter ?\r\n\r\n# Scenarios:\r\n\r\nif we are not skipping videos:\r\n* preview video and image are available and not yet . Automatically upload them\r\n* preview video has already been uploaded, but image has changed. Update the image.\r\n* preview video and images have already been uploaded. Do nothing.\r\n* one of 2 preview video and image is missing. UI.user_error! (before we start uploading anything)\r\n* preview.html should contain the preview image in a new video section (unless skip_preview_video I guess ? check how other section are filled in or not).\r\n** BONUS would be to use some CSS magic to show a player button but that's not necessary or link to the local video using HTML5 :) \r\n\r\n# Future ideas:\r\n\r\n* we might expose the extraction of the image through deliver. We could add to spaceship `Utilities.can_extract_video_preview?` or something like that to detect the feature and fail up front.\r\n* We could also provide the extraction of the video preview as a fastlane action. I don't personally need that.\r\n\r\n# Notes:\r\n\r\nwe're starting on this."},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/220847929","html_url":"https://github.com/fastlane/fastlane/issues/3779#issuecomment-220847929","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/3779","id":220847929,"user":{"login":"marat00","id":3979866,"avatar_url":"https://avatars.githubusercontent.com/u/3979866?v=3","gravatar_id":"","url":"https://api.github.com/users/marat00","html_url":"https://github.com/marat00","followers_url":"https://api.github.com/users/marat00/followers","following_url":"https://api.github.com/users/marat00/following{/other_user}","gists_url":"https://api.github.com/users/marat00/gists{/gist_id}","starred_url":"https://api.github.com/users/marat00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marat00/subscriptions","organizations_url":"https://api.github.com/users/marat00/orgs","repos_url":"https://api.github.com/users/marat00/repos","events_url":"https://api.github.com/users/marat00/events{/privacy}","received_events_url":"https://api.github.com/users/marat00/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T18:29:49Z","updated_at":"2016-05-22T18:29:49Z","body":"@KrauseFx, I was trying to do that, but the underlying code is not simple, and it would take some effort to integrate it with Jenkins and the HTML generator that you use for deliver. Plus, there is very limited documentation or code examples on video uploads if any."}}
{"actor":{"display_login":"marat00"}}