{"action":"created","comment":{"url":"https://api.github.com/repos/01org/ciao/pulls/comments/80731525","pull_request_review_id":1767013,"id":80731525,"diff_hunk":"@@ -563,7 +564,7 @@ DONE:\n \t\t\tglog.Flush()\n \n \t\t\t/* We panic here to see which naughty go routines are still running. */\n-\n+\t\t\tdebug.SetTraceback(\"all\")","path":"ciao-launcher/main.go","position":117,"original_position":13,"commit_id":"e15c803f439d9ab39470cea772151080322b21c7","original_commit_id":"11d357ee66b2cd3ff0ceff282bb6f7de30f56da1","user":{"login":"markdryan","id":984073,"avatar_url":"https://avatars.githubusercontent.com/u/984073?v=3","gravatar_id":"","url":"https://api.github.com/users/markdryan","html_url":"https://github.com/markdryan","followers_url":"https://api.github.com/users/markdryan/followers","following_url":"https://api.github.com/users/markdryan/following{/other_user}","gists_url":"https://api.github.com/users/markdryan/gists{/gist_id}","starred_url":"https://api.github.com/users/markdryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdryan/subscriptions","organizations_url":"https://api.github.com/users/markdryan/orgs","repos_url":"https://api.github.com/users/markdryan/repos","events_url":"https://api.github.com/users/markdryan/events{/privacy}","received_events_url":"https://api.github.com/users/markdryan/received_events","type":"User","site_admin":false},"body":"Hidden away in a dark corner of the launcher docs we have this.\r\n\r\nhttps://github.com/01org/ciao/blob/master/ciao-launcher/doc.go#L47\r\n\r\nCould you just delete those two sentences.","created_at":"2016-09-27T16:12:05Z","updated_at":"2016-09-27T16:12:05Z","html_url":"https://github.com/01org/ciao/pull/601#discussion_r80731525","pull_request_url":"https://api.github.com/repos/01org/ciao/pulls/601","_links":{"self":{"href":"https://api.github.com/repos/01org/ciao/pulls/comments/80731525"},"html":{"href":"https://github.com/01org/ciao/pull/601#discussion_r80731525"},"pull_request":{"href":"https://api.github.com/repos/01org/ciao/pulls/601"}}},"pull_request":{"url":"https://api.github.com/repos/01org/ciao/pulls/601","id":86791530,"html_url":"https://github.com/01org/ciao/pull/601","diff_url":"https://github.com/01org/ciao/pull/601.diff","patch_url":"https://github.com/01org/ciao/pull/601.patch","issue_url":"https://api.github.com/repos/01org/ciao/issues/601","number":601,"state":"open","locked":false,"title":"Fix launcher deadlock","user":{"login":"rbradford","id":588224,"avatar_url":"https://avatars.githubusercontent.com/u/588224?v=3","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"body":"This change addresses the deadlock in #591. Tested via singlevm & and ciao-launcher-server/ciaolc","created_at":"2016-09-26T18:13:07Z","updated_at":"2016-09-27T16:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ba7d3e3716d1537eb1ff055e402a65af47ad3be","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/ciao/pulls/601/commits","review_comments_url":"https://api.github.com/repos/01org/ciao/pulls/601/comments","review_comment_url":"https://api.github.com/repos/01org/ciao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/ciao/issues/601/comments","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/e15c803f439d9ab39470cea772151080322b21c7","head":{"label":"rbradford:fix-launcher-deadlock","ref":"fix-launcher-deadlock","sha":"e15c803f439d9ab39470cea772151080322b21c7","user":{"login":"rbradford","id":588224,"avatar_url":"https://avatars.githubusercontent.com/u/588224?v=3","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"repo":{"id":67804093,"name":"ciao","full_name":"rbradford/ciao","owner":{"login":"rbradford","id":588224,"avatar_url":"https://avatars.githubusercontent.com/u/588224?v=3","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbradford/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":true,"url":"https://api.github.com/repos/rbradford/ciao","forks_url":"https://api.github.com/repos/rbradford/ciao/forks","keys_url":"https://api.github.com/repos/rbradford/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbradford/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbradford/ciao/teams","hooks_url":"https://api.github.com/repos/rbradford/ciao/hooks","issue_events_url":"https://api.github.com/repos/rbradford/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/rbradford/ciao/events","assignees_url":"https://api.github.com/repos/rbradford/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/rbradford/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/rbradford/ciao/tags","blobs_url":"https://api.github.com/repos/rbradford/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbradford/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbradford/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbradford/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbradford/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/rbradford/ciao/languages","stargazers_url":"https://api.github.com/repos/rbradford/ciao/stargazers","contributors_url":"https://api.github.com/repos/rbradford/ciao/contributors","subscribers_url":"https://api.github.com/repos/rbradford/ciao/subscribers","subscription_url":"https://api.github.com/repos/rbradford/ciao/subscription","commits_url":"https://api.github.com/repos/rbradford/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbradford/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbradford/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbradford/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbradford/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/rbradford/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbradford/ciao/merges","archive_url":"https://api.github.com/repos/rbradford/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbradford/ciao/downloads","issues_url":"https://api.github.com/repos/rbradford/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/rbradford/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/rbradford/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/rbradford/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbradford/ciao/labels{/name}","releases_url":"https://api.github.com/repos/rbradford/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/rbradford/ciao/deployments","created_at":"2016-09-09T14:07:04Z","updated_at":"2016-09-09T14:07:06Z","pushed_at":"2016-09-27T14:39:42Z","git_url":"git://github.com/rbradford/ciao.git","ssh_url":"git@github.com:rbradford/ciao.git","clone_url":"https://github.com/rbradford/ciao.git","svn_url":"https://github.com/rbradford/ciao","homepage":"","size":8826,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"db032035fe997bf500410a9dcec04e0b5b2fc60d","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":54660486,"name":"ciao","full_name":"01org/ciao","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":false,"url":"https://api.github.com/repos/01org/ciao","forks_url":"https://api.github.com/repos/01org/ciao/forks","keys_url":"https://api.github.com/repos/01org/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/ciao/teams","hooks_url":"https://api.github.com/repos/01org/ciao/hooks","issue_events_url":"https://api.github.com/repos/01org/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/01org/ciao/events","assignees_url":"https://api.github.com/repos/01org/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/01org/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/01org/ciao/tags","blobs_url":"https://api.github.com/repos/01org/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/ciao/languages","stargazers_url":"https://api.github.com/repos/01org/ciao/stargazers","contributors_url":"https://api.github.com/repos/01org/ciao/contributors","subscribers_url":"https://api.github.com/repos/01org/ciao/subscribers","subscription_url":"https://api.github.com/repos/01org/ciao/subscription","commits_url":"https://api.github.com/repos/01org/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/01org/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/ciao/merges","archive_url":"https://api.github.com/repos/01org/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/ciao/downloads","issues_url":"https://api.github.com/repos/01org/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/01org/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/ciao/labels{/name}","releases_url":"https://api.github.com/repos/01org/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/01org/ciao/deployments","created_at":"2016-03-24T17:19:34Z","updated_at":"2016-09-25T22:08:32Z","pushed_at":"2016-09-27T14:39:42Z","git_url":"git://github.com/01org/ciao.git","ssh_url":"git@github.com:01org/ciao.git","clone_url":"https://github.com/01org/ciao.git","svn_url":"https://github.com/01org/ciao","homepage":"","size":9034,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":162,"forks":31,"open_issues":162,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/ciao/pulls/601"},"html":{"href":"https://github.com/01org/ciao/pull/601"},"issue":{"href":"https://api.github.com/repos/01org/ciao/issues/601"},"comments":{"href":"https://api.github.com/repos/01org/ciao/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/ciao/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/ciao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/ciao/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/01org/ciao/statuses/e15c803f439d9ab39470cea772151080322b21c7"}}}}
{"actor":{"display_login":"markdryan"}}