{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/12739","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12739/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12739/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12739/events","html_url":"https://github.com/joomla/joomla-cms/pull/12739","id":187168864,"number":12739,"title":"[com_fields] Fix text-value being reverse for fields: list, radio, checkbox. Fix fields: radio, checkboxes not showing","user":{"login":"ggppdk","id":5092940,"avatar_url":"https://avatars.githubusercontent.com/u/5092940?v=3","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"labels":[{"id":198658453,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-11-03T19:35:05Z","updated_at":"2016-11-05T11:10:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12739","html_url":"https://github.com/joomla/joomla-cms/pull/12739","diff_url":"https://github.com/joomla/joomla-cms/pull/12739.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12739.patch"},"body":"Pull Request for Issue #12725 \r\n\r\n### Summary of Changes\r\n- Fix text-value pair **being reversed** for fields: list, radio, checkbox, (both in form and when viewing)\r\n- Fix fields: radio, checkboxes not showing (...)\r\n- Fix label of checkboxes (field type selector) showing as 'Checkbox'\r\n- Change Label 'Name' to 'Text' for **List Field configuration** for \"Add values\" popup\r\n- Change Label 'Key' to 'Text' for **Radio / Checkboxes Fields configuration** for \"Add values\" popup\r\n- Added missing display layout file for radio field\r\n\r\nNOTE: zero (single character '0') is not yet usable as field value, do not use it yet (there will be another)\r\n\r\n(...) they used name=\"key\" inside their XML file, instead of name=\"name\" **that php code expects** in:\r\n_libraries/joomla/form/abstractlist.php_\r\n\r\n### Testing Instructions\r\n1. Create 3 fields: radio, checkboxes, list and add values to them (important if you have created them already then redit the values and save)\r\n2. Add values to the 3 fields in article form and save\r\n3. View the article in frontend\r\n\r\n### Documentation Changes Required\r\nNone"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/258605080","html_url":"https://github.com/joomla/joomla-cms/pull/12739#issuecomment-258605080","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12739","id":258605080,"user":{"login":"ggppdk","id":5092940,"avatar_url":"https://avatars.githubusercontent.com/u/5092940?v=3","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"created_at":"2016-11-05T11:10:47Z","updated_at":"2016-11-05T11:10:47Z","body":"value: show_no_link\r\nvalue: show_with_link\r\n\r\nso value will not be translated, \r\n\r\nonly \"Text\" will be translated,  do we also want to translate the \"value\" ?\r\nmaybe i am missing some usage scenario,\r\n\r\nif both need to be translated then some extra coding will be needed, \r\nif it is about displaying, then the view layout can do anything"}}
{"actor":{"display_login":"ggppdk"}}