{"action":"created","issue":{"url":"https://api.github.com/repos/cstb/citygml-energy/issues/106","repository_url":"https://api.github.com/repos/cstb/citygml-energy","labels_url":"https://api.github.com/repos/cstb/citygml-energy/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/cstb/citygml-energy/issues/106/comments","events_url":"https://api.github.com/repos/cstb/citygml-energy/issues/106/events","html_url":"https://github.com/cstb/citygml-energy/issues/106","id":148040407,"number":106,"title":"Relation \"correspondsTo\" from ThermalBoundary to _BoundarySurface","user":{"login":"JoachimBenner","id":6430204,"avatar_url":"https://avatars.githubusercontent.com/u/6430204?v=3","gravatar_id":"","url":"https://api.github.com/users/JoachimBenner","html_url":"https://github.com/JoachimBenner","followers_url":"https://api.github.com/users/JoachimBenner/followers","following_url":"https://api.github.com/users/JoachimBenner/following{/other_user}","gists_url":"https://api.github.com/users/JoachimBenner/gists{/gist_id}","starred_url":"https://api.github.com/users/JoachimBenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoachimBenner/subscriptions","organizations_url":"https://api.github.com/users/JoachimBenner/orgs","repos_url":"https://api.github.com/users/JoachimBenner/repos","events_url":"https://api.github.com/users/JoachimBenner/events{/privacy}","received_events_url":"https://api.github.com/users/JoachimBenner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cstb/citygml-energy/labels/ADE%20core","name":"ADE core","color":"5319e7"},{"url":"https://api.github.com/repos/cstb/citygml-energy/labels/Validated%20by%20TC","name":"Validated by TC","color":"207de5"},{"url":"https://api.github.com/repos/cstb/citygml-energy/labels/Validated%20by%20WG","name":"Validated by WG","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-13T12:09:49Z","updated_at":"2016-06-14T08:33:12Z","closed_at":null,"body":"The ADE class ThermalBoundary has a relation *correspondsTo* of carnilality 0..1 to the CityGML base class _BoundarySurface. In case on an LOD4 model with Room, InteriorWallSurface, FloorSurface and CeilingSurface objects, this is problematic, because a ThermalBoundry will be related with **two** _BoundarySurface objects:\r\n\r\n- For exterior thermal boundaries, it is related with one exterior boundary surface (e.g. a WallSurface) and one interior boundary surface (e.g. a InteriorWallSurface)\r\n- For interior thermal boundaries, it is related with two interior boundary surfaces (e.g. two objects InteriorWallSurface)\r\n\r\nTherefore, I propose to change the cardinality of *correspondsTo* to **0..2**."},"comment":{"url":"https://api.github.com/repos/cstb/citygml-energy/issues/comments/225814744","html_url":"https://github.com/cstb/citygml-energy/issues/106#issuecomment-225814744","issue_url":"https://api.github.com/repos/cstb/citygml-energy/issues/106","id":225814744,"user":{"login":"gioagu","id":15018017,"avatar_url":"https://avatars.githubusercontent.com/u/15018017?v=3","gravatar_id":"","url":"https://api.github.com/users/gioagu","html_url":"https://github.com/gioagu","followers_url":"https://api.github.com/users/gioagu/followers","following_url":"https://api.github.com/users/gioagu/following{/other_user}","gists_url":"https://api.github.com/users/gioagu/gists{/gist_id}","starred_url":"https://api.github.com/users/gioagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gioagu/subscriptions","organizations_url":"https://api.github.com/users/gioagu/orgs","repos_url":"https://api.github.com/users/gioagu/repos","events_url":"https://api.github.com/users/gioagu/events{/privacy}","received_events_url":"https://api.github.com/users/gioagu/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T08:33:12Z","updated_at":"2016-06-14T08:33:12Z","body":"My humble opinion is, it makes sense to encode the relation as \"gml:ReferenceType\".\r\nAs a matter of fact, the building's boundary surfaces (Wall, Roof, Ground surface etc.) are supposed to be reached by xlinks only, not to be embedded in the ThermalBoundary.\r\nThis would reduce the (unwanted) degrees of freedom in this specific case.\r\n\r\n\r\n "}}
{"actor":{"display_login":"gioagu"}}