{"action":"created","comment":{"url":"https://api.github.com/repos/lovell/sharp/pulls/comments/80355242","id":80355242,"diff_hunk":"@@ -20,9 +20,14 @@ var vipsHeaderPath = path.join(__dirname, 'include', 'vips', 'vips.h');\n var platform = process.env.npm_config_platform || process.platform;\n \n var arch = process.env.npm_config_arch || process.arch;\n-if (arch === 'armhf') arch = 'arm';\n-\n-var arm_version = process.env.npm_config_armv || process.config.variables.arm_version;\n+var arm_version = process.env.npm_config_armv || process.config.variables.arm_version || '7';\n+\n+switch (arch) {\n+  case 'aarch64':\n+    arm_version = '8';\n+  case 'armhf':","path":"binding.js","position":12,"original_position":12,"commit_id":"9f42e3292bd757026fbbd70665a5b752f112fb1b","original_commit_id":"9f42e3292bd757026fbbd70665a5b752f112fb1b","user":{"login":"lovell","id":210965,"avatar_url":"https://avatars.githubusercontent.com/u/210965?v=3","gravatar_id":"","url":"https://api.github.com/users/lovell","html_url":"https://github.com/lovell","followers_url":"https://api.github.com/users/lovell/followers","following_url":"https://api.github.com/users/lovell/following{/other_user}","gists_url":"https://api.github.com/users/lovell/gists{/gist_id}","starred_url":"https://api.github.com/users/lovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovell/subscriptions","organizations_url":"https://api.github.com/users/lovell/orgs","repos_url":"https://api.github.com/users/lovell/repos","events_url":"https://api.github.com/users/lovell/events{/privacy}","received_events_url":"https://api.github.com/users/lovell/received_events","type":"User","site_admin":false},"body":"Missing `break;` ","created_at":"2016-09-24T07:56:26Z","updated_at":"2016-09-24T07:56:52Z","html_url":"https://github.com/lovell/sharp/pull/581#discussion_r80355242","pull_request_url":"https://api.github.com/repos/lovell/sharp/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/lovell/sharp/pulls/comments/80355242"},"html":{"href":"https://github.com/lovell/sharp/pull/581#discussion_r80355242"},"pull_request":{"href":"https://api.github.com/repos/lovell/sharp/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/lovell/sharp/pulls/581","id":86422974,"html_url":"https://github.com/lovell/sharp/pull/581","diff_url":"https://github.com/lovell/sharp/pull/581.diff","patch_url":"https://github.com/lovell/sharp/pull/581.patch","issue_url":"https://api.github.com/repos/lovell/sharp/issues/581","number":581,"state":"open","locked":false,"title":"Allow for overriding platform, arch and arm_version","user":{"login":"gigafied","id":849972,"avatar_url":"https://avatars.githubusercontent.com/u/849972?v=3","gravatar_id":"","url":"https://api.github.com/users/gigafied","html_url":"https://github.com/gigafied","followers_url":"https://api.github.com/users/gigafied/followers","following_url":"https://api.github.com/users/gigafied/following{/other_user}","gists_url":"https://api.github.com/users/gigafied/gists{/gist_id}","starred_url":"https://api.github.com/users/gigafied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigafied/subscriptions","organizations_url":"https://api.github.com/users/gigafied/orgs","repos_url":"https://api.github.com/users/gigafied/repos","events_url":"https://api.github.com/users/gigafied/events{/privacy}","received_events_url":"https://api.github.com/users/gigafied/received_events","type":"User","site_admin":false},"body":"We are using sharp on an embedded platform, and we need to cross compile on Jenkins when we create a debian package. Right now, binding.js reads the host's arch, arm_version and platform, this enables us to specify them as command line args to `npm install` i.e. `npm install --arch=arm --armv=7 --platform=linux`","created_at":"2016-09-22T22:05:04Z","updated_at":"2016-09-24T07:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d133d06f75fc61264131e24c90bf001c996d04b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lovell/sharp/pulls/581/commits","review_comments_url":"https://api.github.com/repos/lovell/sharp/pulls/581/comments","review_comment_url":"https://api.github.com/repos/lovell/sharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lovell/sharp/issues/581/comments","statuses_url":"https://api.github.com/repos/lovell/sharp/statuses/9f42e3292bd757026fbbd70665a5b752f112fb1b","head":{"label":"gigafied:master","ref":"master","sha":"9f42e3292bd757026fbbd70665a5b752f112fb1b","user":{"login":"gigafied","id":849972,"avatar_url":"https://avatars.githubusercontent.com/u/849972?v=3","gravatar_id":"","url":"https://api.github.com/users/gigafied","html_url":"https://github.com/gigafied","followers_url":"https://api.github.com/users/gigafied/followers","following_url":"https://api.github.com/users/gigafied/following{/other_user}","gists_url":"https://api.github.com/users/gigafied/gists{/gist_id}","starred_url":"https://api.github.com/users/gigafied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigafied/subscriptions","organizations_url":"https://api.github.com/users/gigafied/orgs","repos_url":"https://api.github.com/users/gigafied/repos","events_url":"https://api.github.com/users/gigafied/events{/privacy}","received_events_url":"https://api.github.com/users/gigafied/received_events","type":"User","site_admin":false},"repo":{"id":68962517,"name":"sharp","full_name":"gigafied/sharp","owner":{"login":"gigafied","id":849972,"avatar_url":"https://avatars.githubusercontent.com/u/849972?v=3","gravatar_id":"","url":"https://api.github.com/users/gigafied","html_url":"https://github.com/gigafied","followers_url":"https://api.github.com/users/gigafied/followers","following_url":"https://api.github.com/users/gigafied/following{/other_user}","gists_url":"https://api.github.com/users/gigafied/gists{/gist_id}","starred_url":"https://api.github.com/users/gigafied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigafied/subscriptions","organizations_url":"https://api.github.com/users/gigafied/orgs","repos_url":"https://api.github.com/users/gigafied/repos","events_url":"https://api.github.com/users/gigafied/events{/privacy}","received_events_url":"https://api.github.com/users/gigafied/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gigafied/sharp","description":"High performance Node.js image processing, the fastest module to resize JPEG, PNG, WebP and TIFF images. Uses the libvips library.","fork":true,"url":"https://api.github.com/repos/gigafied/sharp","forks_url":"https://api.github.com/repos/gigafied/sharp/forks","keys_url":"https://api.github.com/repos/gigafied/sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigafied/sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigafied/sharp/teams","hooks_url":"https://api.github.com/repos/gigafied/sharp/hooks","issue_events_url":"https://api.github.com/repos/gigafied/sharp/issues/events{/number}","events_url":"https://api.github.com/repos/gigafied/sharp/events","assignees_url":"https://api.github.com/repos/gigafied/sharp/assignees{/user}","branches_url":"https://api.github.com/repos/gigafied/sharp/branches{/branch}","tags_url":"https://api.github.com/repos/gigafied/sharp/tags","blobs_url":"https://api.github.com/repos/gigafied/sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigafied/sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigafied/sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigafied/sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigafied/sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/gigafied/sharp/languages","stargazers_url":"https://api.github.com/repos/gigafied/sharp/stargazers","contributors_url":"https://api.github.com/repos/gigafied/sharp/contributors","subscribers_url":"https://api.github.com/repos/gigafied/sharp/subscribers","subscription_url":"https://api.github.com/repos/gigafied/sharp/subscription","commits_url":"https://api.github.com/repos/gigafied/sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigafied/sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigafied/sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigafied/sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigafied/sharp/contents/{+path}","compare_url":"https://api.github.com/repos/gigafied/sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigafied/sharp/merges","archive_url":"https://api.github.com/repos/gigafied/sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigafied/sharp/downloads","issues_url":"https://api.github.com/repos/gigafied/sharp/issues{/number}","pulls_url":"https://api.github.com/repos/gigafied/sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/gigafied/sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/gigafied/sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigafied/sharp/labels{/name}","releases_url":"https://api.github.com/repos/gigafied/sharp/releases{/id}","deployments_url":"https://api.github.com/repos/gigafied/sharp/deployments","created_at":"2016-09-22T21:11:29Z","updated_at":"2016-09-22T21:11:30Z","pushed_at":"2016-09-23T21:14:46Z","git_url":"git://github.com/gigafied/sharp.git","ssh_url":"git@github.com:gigafied/sharp.git","clone_url":"https://github.com/gigafied/sharp.git","svn_url":"https://github.com/gigafied/sharp","homepage":"http://sharp.dimens.io/","size":20346,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lovell:master","ref":"master","sha":"28ce33feb3e176bb8498cc857712c9cde7d3a7ec","user":{"login":"lovell","id":210965,"avatar_url":"https://avatars.githubusercontent.com/u/210965?v=3","gravatar_id":"","url":"https://api.github.com/users/lovell","html_url":"https://github.com/lovell","followers_url":"https://api.github.com/users/lovell/followers","following_url":"https://api.github.com/users/lovell/following{/other_user}","gists_url":"https://api.github.com/users/lovell/gists{/gist_id}","starred_url":"https://api.github.com/users/lovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovell/subscriptions","organizations_url":"https://api.github.com/users/lovell/orgs","repos_url":"https://api.github.com/users/lovell/repos","events_url":"https://api.github.com/users/lovell/events{/privacy}","received_events_url":"https://api.github.com/users/lovell/received_events","type":"User","site_admin":false},"repo":{"id":12226786,"name":"sharp","full_name":"lovell/sharp","owner":{"login":"lovell","id":210965,"avatar_url":"https://avatars.githubusercontent.com/u/210965?v=3","gravatar_id":"","url":"https://api.github.com/users/lovell","html_url":"https://github.com/lovell","followers_url":"https://api.github.com/users/lovell/followers","following_url":"https://api.github.com/users/lovell/following{/other_user}","gists_url":"https://api.github.com/users/lovell/gists{/gist_id}","starred_url":"https://api.github.com/users/lovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovell/subscriptions","organizations_url":"https://api.github.com/users/lovell/orgs","repos_url":"https://api.github.com/users/lovell/repos","events_url":"https://api.github.com/users/lovell/events{/privacy}","received_events_url":"https://api.github.com/users/lovell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lovell/sharp","description":"High performance Node.js image processing, the fastest module to resize JPEG, PNG, WebP and TIFF images. Uses the libvips library.","fork":false,"url":"https://api.github.com/repos/lovell/sharp","forks_url":"https://api.github.com/repos/lovell/sharp/forks","keys_url":"https://api.github.com/repos/lovell/sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lovell/sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lovell/sharp/teams","hooks_url":"https://api.github.com/repos/lovell/sharp/hooks","issue_events_url":"https://api.github.com/repos/lovell/sharp/issues/events{/number}","events_url":"https://api.github.com/repos/lovell/sharp/events","assignees_url":"https://api.github.com/repos/lovell/sharp/assignees{/user}","branches_url":"https://api.github.com/repos/lovell/sharp/branches{/branch}","tags_url":"https://api.github.com/repos/lovell/sharp/tags","blobs_url":"https://api.github.com/repos/lovell/sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lovell/sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lovell/sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lovell/sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lovell/sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/lovell/sharp/languages","stargazers_url":"https://api.github.com/repos/lovell/sharp/stargazers","contributors_url":"https://api.github.com/repos/lovell/sharp/contributors","subscribers_url":"https://api.github.com/repos/lovell/sharp/subscribers","subscription_url":"https://api.github.com/repos/lovell/sharp/subscription","commits_url":"https://api.github.com/repos/lovell/sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lovell/sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lovell/sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lovell/sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/lovell/sharp/contents/{+path}","compare_url":"https://api.github.com/repos/lovell/sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lovell/sharp/merges","archive_url":"https://api.github.com/repos/lovell/sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lovell/sharp/downloads","issues_url":"https://api.github.com/repos/lovell/sharp/issues{/number}","pulls_url":"https://api.github.com/repos/lovell/sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/lovell/sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/lovell/sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lovell/sharp/labels{/name}","releases_url":"https://api.github.com/repos/lovell/sharp/releases{/id}","deployments_url":"https://api.github.com/repos/lovell/sharp/deployments","created_at":"2013-08-19T20:24:24Z","updated_at":"2016-09-23T15:22:37Z","pushed_at":"2016-09-23T21:14:46Z","git_url":"git://github.com/lovell/sharp.git","ssh_url":"git@github.com:lovell/sharp.git","clone_url":"https://github.com/lovell/sharp.git","svn_url":"https://github.com/lovell/sharp","homepage":"http://sharp.dimens.io/","size":25186,"stargazers_count":3627,"watchers_count":3627,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":212,"mirror_url":null,"open_issues_count":43,"forks":212,"open_issues":43,"watchers":3627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lovell/sharp/pulls/581"},"html":{"href":"https://github.com/lovell/sharp/pull/581"},"issue":{"href":"https://api.github.com/repos/lovell/sharp/issues/581"},"comments":{"href":"https://api.github.com/repos/lovell/sharp/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/lovell/sharp/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/lovell/sharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lovell/sharp/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/lovell/sharp/statuses/9f42e3292bd757026fbbd70665a5b752f112fb1b"}}}}
{"actor":{"display_login":"lovell"}}