{"action":"closed","number":3439,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5/pulls/3439","id":57179578,"html_url":"https://github.com/concrete5/concrete5/pull/3439","diff_url":"https://github.com/concrete5/concrete5/pull/3439.diff","patch_url":"https://github.com/concrete5/concrete5/pull/3439.patch","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/3439","number":3439,"state":"closed","locked":false,"title":"restrict maximum row height in file manager to match thumbnail height","user":{"login":"Remo","id":129864,"avatar_url":"https://avatars.githubusercontent.com/u/129864?v=3","gravatar_id":"","url":"https://api.github.com/users/Remo","html_url":"https://github.com/Remo","followers_url":"https://api.github.com/users/Remo/followers","following_url":"https://api.github.com/users/Remo/following{/other_user}","gists_url":"https://api.github.com/users/Remo/gists{/gist_id}","starred_url":"https://api.github.com/users/Remo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remo/subscriptions","organizations_url":"https://api.github.com/users/Remo/orgs","repos_url":"https://api.github.com/users/Remo/repos","events_url":"https://api.github.com/users/Remo/events{/privacy}","received_events_url":"https://api.github.com/users/Remo/received_events","type":"User","site_admin":false},"body":"I had a quick look at how we could restrict the row height in the file manager.\r\n* I tried to set the height attribute of the img tag, but that's a bit tricky since we create the markup in JavaScript `file.resultsThumbnailImg` in https://github.com/ortic/concrete5-5.7.0/blob/b0f9f083e814e74080a116a4bd9efc0f3a4034a6/web/concrete/elements/files/search.php#L118\r\n* I was also a bit confused that `Config::get('concrete.icons.file_manager_listing.height')` would return 60 despite that I've set the thumbnail height to 100 and also cleared the cache.\r\n* I ended up with this tad bit ugly long line of inline CSS\r\n\r\nMight replace https://github.com/concrete5/concrete5/pull/3438","created_at":"2016-01-26T08:01:39Z","updated_at":"2016-02-03T18:05:04Z","closed_at":"2016-02-03T18:05:04Z","merged_at":null,"merge_commit_sha":"8a402e6bf6fd10f1cdc41c3e10a1702f9aa6ff15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/concrete5/concrete5/pulls/3439/commits","review_comments_url":"https://api.github.com/repos/concrete5/concrete5/pulls/3439/comments","review_comment_url":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/3439/comments","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/b0f9f083e814e74080a116a4bd9efc0f3a4034a6","head":{"label":"ortic:fix/thumb-max-height","ref":"fix/thumb-max-height","sha":"b0f9f083e814e74080a116a4bd9efc0f3a4034a6","user":{"login":"ortic","id":6050633,"avatar_url":"https://avatars.githubusercontent.com/u/6050633?v=3","gravatar_id":"","url":"https://api.github.com/users/ortic","html_url":"https://github.com/ortic","followers_url":"https://api.github.com/users/ortic/followers","following_url":"https://api.github.com/users/ortic/following{/other_user}","gists_url":"https://api.github.com/users/ortic/gists{/gist_id}","starred_url":"https://api.github.com/users/ortic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ortic/subscriptions","organizations_url":"https://api.github.com/users/ortic/orgs","repos_url":"https://api.github.com/users/ortic/repos","events_url":"https://api.github.com/users/ortic/events{/privacy}","received_events_url":"https://api.github.com/users/ortic/received_events","type":"Organization","site_admin":false},"repo":{"id":32724869,"name":"concrete5-5.7.0","full_name":"ortic/concrete5-5.7.0","owner":{"login":"ortic","id":6050633,"avatar_url":"https://avatars.githubusercontent.com/u/6050633?v=3","gravatar_id":"","url":"https://api.github.com/users/ortic","html_url":"https://github.com/ortic","followers_url":"https://api.github.com/users/ortic/followers","following_url":"https://api.github.com/users/ortic/following{/other_user}","gists_url":"https://api.github.com/users/ortic/gists{/gist_id}","starred_url":"https://api.github.com/users/ortic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ortic/subscriptions","organizations_url":"https://api.github.com/users/ortic/orgs","repos_url":"https://api.github.com/users/ortic/repos","events_url":"https://api.github.com/users/ortic/events{/privacy}","received_events_url":"https://api.github.com/users/ortic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ortic/concrete5-5.7.0","description":"Official repository for concrete5 5.7 development","fork":true,"url":"https://api.github.com/repos/ortic/concrete5-5.7.0","forks_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/forks","keys_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/teams","hooks_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/hooks","issue_events_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/issues/events{/number}","events_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/events","assignees_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/assignees{/user}","branches_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/branches{/branch}","tags_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/tags","blobs_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/statuses/{sha}","languages_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/languages","stargazers_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/stargazers","contributors_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/contributors","subscribers_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/subscribers","subscription_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/subscription","commits_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/issues/comments{/number}","contents_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/contents/{+path}","compare_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/merges","archive_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/downloads","issues_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/issues{/number}","pulls_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/pulls{/number}","milestones_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/milestones{/number}","notifications_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/labels{/name}","releases_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/releases{/id}","deployments_url":"https://api.github.com/repos/ortic/concrete5-5.7.0/deployments","created_at":"2015-03-23T10:18:28Z","updated_at":"2016-01-11T09:11:50Z","pushed_at":"2016-01-26T15:58:54Z","git_url":"git://github.com/ortic/concrete5-5.7.0.git","ssh_url":"git@github.com:ortic/concrete5-5.7.0.git","clone_url":"https://github.com/ortic/concrete5-5.7.0.git","svn_url":"https://github.com/ortic/concrete5-5.7.0","homepage":"","size":156046,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"concrete5:develop","ref":"develop","sha":"d8b8174735d3f745ebc87d75cceaa5acd5315194","user":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?v=3","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"repo":{"id":19040482,"name":"concrete5","full_name":"concrete5/concrete5","owner":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?v=3","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concrete5/concrete5","description":"Official repository for concrete5 development","fork":false,"url":"https://api.github.com/repos/concrete5/concrete5","forks_url":"https://api.github.com/repos/concrete5/concrete5/forks","keys_url":"https://api.github.com/repos/concrete5/concrete5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concrete5/concrete5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concrete5/concrete5/teams","hooks_url":"https://api.github.com/repos/concrete5/concrete5/hooks","issue_events_url":"https://api.github.com/repos/concrete5/concrete5/issues/events{/number}","events_url":"https://api.github.com/repos/concrete5/concrete5/events","assignees_url":"https://api.github.com/repos/concrete5/concrete5/assignees{/user}","branches_url":"https://api.github.com/repos/concrete5/concrete5/branches{/branch}","tags_url":"https://api.github.com/repos/concrete5/concrete5/tags","blobs_url":"https://api.github.com/repos/concrete5/concrete5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concrete5/concrete5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concrete5/concrete5/git/refs{/sha}","trees_url":"https://api.github.com/repos/concrete5/concrete5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/{sha}","languages_url":"https://api.github.com/repos/concrete5/concrete5/languages","stargazers_url":"https://api.github.com/repos/concrete5/concrete5/stargazers","contributors_url":"https://api.github.com/repos/concrete5/concrete5/contributors","subscribers_url":"https://api.github.com/repos/concrete5/concrete5/subscribers","subscription_url":"https://api.github.com/repos/concrete5/concrete5/subscription","commits_url":"https://api.github.com/repos/concrete5/concrete5/commits{/sha}","git_commits_url":"https://api.github.com/repos/concrete5/concrete5/git/commits{/sha}","comments_url":"https://api.github.com/repos/concrete5/concrete5/comments{/number}","issue_comment_url":"https://api.github.com/repos/concrete5/concrete5/issues/comments{/number}","contents_url":"https://api.github.com/repos/concrete5/concrete5/contents/{+path}","compare_url":"https://api.github.com/repos/concrete5/concrete5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concrete5/concrete5/merges","archive_url":"https://api.github.com/repos/concrete5/concrete5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concrete5/concrete5/downloads","issues_url":"https://api.github.com/repos/concrete5/concrete5/issues{/number}","pulls_url":"https://api.github.com/repos/concrete5/concrete5/pulls{/number}","milestones_url":"https://api.github.com/repos/concrete5/concrete5/milestones{/number}","notifications_url":"https://api.github.com/repos/concrete5/concrete5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concrete5/concrete5/labels{/name}","releases_url":"https://api.github.com/repos/concrete5/concrete5/releases{/id}","deployments_url":"https://api.github.com/repos/concrete5/concrete5/deployments","created_at":"2014-04-22T18:12:28Z","updated_at":"2016-02-02T13:43:37Z","pushed_at":"2016-02-03T18:04:30Z","git_url":"git://github.com/concrete5/concrete5.git","ssh_url":"git@github.com:concrete5/concrete5.git","clone_url":"https://github.com/concrete5/concrete5.git","svn_url":"https://github.com/concrete5/concrete5","homepage":"https://www.concrete5.org","size":165148,"stargazers_count":249,"watchers_count":249,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":231,"mirror_url":null,"open_issues_count":274,"forks":231,"open_issues":274,"watchers":249,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/3439"},"html":{"href":"https://github.com/concrete5/concrete5/pull/3439"},"issue":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/3439"},"comments":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/3439/comments"},"review_comments":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/3439/comments"},"review_comment":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/3439/commits"},"statuses":{"href":"https://api.github.com/repos/concrete5/concrete5/statuses/b0f9f083e814e74080a116a4bd9efc0f3a4034a6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":2}}