{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/51899352","id":51899352,"diff_hunk":"@@ -21,8 +21,8 @@ import (\n \t\"net\"\n )\n \n-// MakeUnresolvedAddr creates a new UnresolvedAddr from a network\n-// and raw address string.\n+// MakeUnresolvedAddr populates an UnresolvedAddr from a network and raw\n+// address string.\n func MakeUnresolvedAddr(network string, str string) UnresolvedAddr {","path":"util/unresolved_addr.go","position":8,"original_position":8,"commit_id":"cf482ead20487f67f2a41e6f54e6d3344598a471","original_commit_id":"cf482ead20487f67f2a41e6f54e6d3344598a471","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-02-04T16:41:29Z","updated_at":"2016-02-04T16:41:29Z","html_url":"https://github.com/cockroachdb/cockroach/pull/4131#discussion_r51899352","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4131","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/51899352"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/4131#discussion_r51899352"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4131"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4131","id":58310622,"html_url":"https://github.com/cockroachdb/cockroach/pull/4131","diff_url":"https://github.com/cockroachdb/cockroach/pull/4131.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/4131.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4131","number":4131,"state":"open","locked":false,"title":"Make *UnresolvedAddr implement net.Addr, not UnresolvedAddr.","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"body":"This is done because assigning a non-empty struct to an interface requires an\nallocation, while assigning a pointer to an interface is allocation free. Using\nan *UnresolvedAddr makes it both clear that an allocation is occurring and\nallows us to avoid an allocation when an UnresolvedAddr is a field of a\nstruct (e.g. NodeDescriptor.Address). This saves a few allocations on every\nDistSender RPC.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/4131)\n<!-- Reviewable:end -->\n","created_at":"2016-02-04T16:23:08Z","updated_at":"2016-02-04T16:41:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9049a351a68b7c427491aef33f0bbb254b251871","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4131/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4131/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4131/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/cf482ead20487f67f2a41e6f54e6d3344598a471","head":{"label":"petermattis:pmattis/unresolved-addr","ref":"pmattis/unresolved-addr","sha":"cf482ead20487f67f2a41e6f54e6d3344598a471","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"repo":{"id":49213713,"name":"cockroach","full_name":"petermattis/cockroach","owner":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petermattis/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/petermattis/cockroach","forks_url":"https://api.github.com/repos/petermattis/cockroach/forks","keys_url":"https://api.github.com/repos/petermattis/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petermattis/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petermattis/cockroach/teams","hooks_url":"https://api.github.com/repos/petermattis/cockroach/hooks","issue_events_url":"https://api.github.com/repos/petermattis/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/petermattis/cockroach/events","assignees_url":"https://api.github.com/repos/petermattis/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/petermattis/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/petermattis/cockroach/tags","blobs_url":"https://api.github.com/repos/petermattis/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petermattis/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petermattis/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/petermattis/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petermattis/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/petermattis/cockroach/languages","stargazers_url":"https://api.github.com/repos/petermattis/cockroach/stargazers","contributors_url":"https://api.github.com/repos/petermattis/cockroach/contributors","subscribers_url":"https://api.github.com/repos/petermattis/cockroach/subscribers","subscription_url":"https://api.github.com/repos/petermattis/cockroach/subscription","commits_url":"https://api.github.com/repos/petermattis/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/petermattis/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/petermattis/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/petermattis/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/petermattis/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/petermattis/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petermattis/cockroach/merges","archive_url":"https://api.github.com/repos/petermattis/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petermattis/cockroach/downloads","issues_url":"https://api.github.com/repos/petermattis/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/petermattis/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/petermattis/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/petermattis/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petermattis/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/petermattis/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/petermattis/cockroach/deployments","created_at":"2016-01-07T15:46:02Z","updated_at":"2016-01-15T20:14:05Z","pushed_at":"2016-02-04T16:37:03Z","git_url":"git://github.com/petermattis/cockroach.git","ssh_url":"git@github.com:petermattis/cockroach.git","clone_url":"https://github.com/petermattis/cockroach.git","svn_url":"https://github.com/petermattis/cockroach","homepage":"http://www.cockroachlabs.com","size":55695,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"0dfd4757b6eb83aa506f584cbaf24b5a7d9af316","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-02-04T09:32:23Z","pushed_at":"2016-02-04T16:37:08Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"http://www.cockroachlabs.com","size":64404,"stargazers_count":6139,"watchers_count":6139,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":553,"mirror_url":null,"open_issues_count":269,"forks":553,"open_issues":269,"watchers":6139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4131"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/4131"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/4131"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/4131/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4131/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4131/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/cf482ead20487f67f2a41e6f54e6d3344598a471"}}}}