{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/52211212","id":52211212,"diff_hunk":"@@ -0,0 +1,62 @@\n+package com.hubspot.singularity;\n+\n+import com.fasterxml.jackson.annotation.JsonProperty;\n+\n+public class SingularityDeployProgress {\n+  private final int targetActiveInstances;\n+  private final int deployInstanceCountPerStep;\n+  private final long deployStepWaitTimeSeconds;\n+  private final boolean stepComplete;\n+  private final boolean  autoAdvanceDeploySteps;\n+  private final long timestamp;\n+\n+  public SingularityDeployProgress(@JsonProperty(\"targetActiveInstances\") int targetActiveInstances,","path":"SingularityBase/src/main/java/com/hubspot/singularity/SingularityDeployProgress.java","position":13,"original_position":13,"commit_id":"8c2acc4461d00e4c6e34c1c0ee6f4ca56ff99b14","original_commit_id":"8c2acc4461d00e4c6e34c1c0ee6f4ca56ff99b14","user":{"login":"wsorenson","id":281687,"avatar_url":"https://avatars.githubusercontent.com/u/281687?v=3","gravatar_id":"","url":"https://api.github.com/users/wsorenson","html_url":"https://github.com/wsorenson","followers_url":"https://api.github.com/users/wsorenson/followers","following_url":"https://api.github.com/users/wsorenson/following{/other_user}","gists_url":"https://api.github.com/users/wsorenson/gists{/gist_id}","starred_url":"https://api.github.com/users/wsorenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsorenson/subscriptions","organizations_url":"https://api.github.com/users/wsorenson/orgs","repos_url":"https://api.github.com/users/wsorenson/repos","events_url":"https://api.github.com/users/wsorenson/events{/privacy}","received_events_url":"https://api.github.com/users/wsorenson/received_events","type":"User","site_admin":false},"body":"<code>@JsonCreator</code>?","created_at":"2016-02-08T19:16:31Z","updated_at":"2016-02-08T19:16:31Z","html_url":"https://github.com/HubSpot/Singularity/pull/817#discussion_r52211212","pull_request_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/817","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/52211212"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/817#discussion_r52211212"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/817"}}},"pull_request":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/817","id":54303329,"html_url":"https://github.com/HubSpot/Singularity/pull/817","diff_url":"https://github.com/HubSpot/Singularity/pull/817.diff","patch_url":"https://github.com/HubSpot/Singularity/pull/817.patch","issue_url":"https://api.github.com/repos/HubSpot/Singularity/issues/817","number":817,"state":"open","locked":false,"title":"Incremental deploys","user":{"login":"ssalinas","id":6034439,"avatar_url":"https://avatars.githubusercontent.com/u/6034439?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalinas","html_url":"https://github.com/ssalinas","followers_url":"https://api.github.com/users/ssalinas/followers","following_url":"https://api.github.com/users/ssalinas/following{/other_user}","gists_url":"https://api.github.com/users/ssalinas/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalinas/subscriptions","organizations_url":"https://api.github.com/users/ssalinas/orgs","repos_url":"https://api.github.com/users/ssalinas/repos","events_url":"https://api.github.com/users/ssalinas/events{/privacy}","received_events_url":"https://api.github.com/users/ssalinas/received_events","type":"User","site_admin":false},"body":"Still needs plenty of work, but opening up early for feedback.\r\n\r\nRight now I am adding a field to the `SingularityPendingDeploy` object that will track the progress of an incremental deploy as it goes along. This new field is an object that holds information about the current target number of instances and rate at which the deploy should proceed.\r\n\r\nStill to-do:\r\n- [x] Better scheduling of upcoming tasks. Right now it's just keying off of numMissingInstances, but since we know the time between deploy steps, we can go ahead and schedule them\r\n- [x] Make it play nice with load balancer add/remove. Regular deploys add everything all at once when the deploy succeeds, this will need to do it per-task\r\n- [x] Surface more information about what is happening in the deploy, if you aren't watching the logs it's kind of mysterious right now\r\n- [x] Option to manually move the deploy forward or backward a step (should be fairly straightforward since we have the info in the `SingularityPendingDeploy` object)\r\n- [x] Tests, tests, tests, tests, tests....\r\n- [x] UI\r\n\r\n/cc @tpetr @wsorenson ","created_at":"2015-12-21T21:10:11Z","updated_at":"2016-02-08T19:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f608d585afb0ddcff7ff1c3b4fe959c9b260b5e","assignee":null,"milestone":{"url":"https://api.github.com/repos/HubSpot/Singularity/milestones/11","html_url":"https://github.com/HubSpot/Singularity/milestones/0.4.10","labels_url":"https://api.github.com/repos/HubSpot/Singularity/milestones/11/labels","id":1559731,"number":11,"title":"0.4.10","description":"","creator":{"login":"tpetr","id":47152,"avatar_url":"https://avatars.githubusercontent.com/u/47152?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetr","html_url":"https://github.com/tpetr","followers_url":"https://api.github.com/users/tpetr/followers","following_url":"https://api.github.com/users/tpetr/following{/other_user}","gists_url":"https://api.github.com/users/tpetr/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetr/subscriptions","organizations_url":"https://api.github.com/users/tpetr/orgs","repos_url":"https://api.github.com/users/tpetr/repos","events_url":"https://api.github.com/users/tpetr/events{/privacy}","received_events_url":"https://api.github.com/users/tpetr/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":9,"state":"open","created_at":"2016-02-02T22:25:53Z","updated_at":"2016-02-08T17:50:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/817/commits","review_comments_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/817/comments","review_comment_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/issues/817/comments","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/8c2acc4461d00e4c6e34c1c0ee6f4ca56ff99b14","head":{"label":"HubSpot:incremental_deploys","ref":"incremental_deploys","sha":"8c2acc4461d00e4c6e34c1c0ee6f4ca56ff99b14","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running Mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","deployments_url":"https://api.github.com/repos/HubSpot/Singularity/deployments","created_at":"2013-10-16T21:28:49Z","updated_at":"2016-02-07T19:47:27Z","pushed_at":"2016-02-08T19:03:22Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":27522,"stargazers_count":487,"watchers_count":487,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":44,"forks":71,"open_issues":44,"watchers":487,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"8cbb39d90f2d3dacca0df35322d2a1d0059946d2","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running Mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","deployments_url":"https://api.github.com/repos/HubSpot/Singularity/deployments","created_at":"2013-10-16T21:28:49Z","updated_at":"2016-02-07T19:47:27Z","pushed_at":"2016-02-08T19:03:22Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":27522,"stargazers_count":487,"watchers_count":487,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":44,"forks":71,"open_issues":44,"watchers":487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/817"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/817"},"issue":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/817"},"comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/817/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/817/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/817/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/Singularity/statuses/8c2acc4461d00e4c6e34c1c0ee6f4ca56ff99b14"}}}}