{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/91766328","pull_request_review_id":12278663,"id":91766328,"diff_hunk":"@@ -275,10 +279,6 @@ Status MergeHelper::MergeUntil(InternalIterator* iter,\n     // We haven't seen the beginning of the key nor a Put/Delete.\n     // Attempt to use the user's associative merge function to\n     // merge the stacked merge operands into a single operand.\n-    //\n-    // TODO(noetzli) The docblock of MergeUntil suggests that a successful","path":"db/merge_helper.cc","position":16,"original_position":16,"commit_id":"dc48650a64ce95bcec477e861f4dc6e952f705fa","original_commit_id":"dc48650a64ce95bcec477e861f4dc6e952f705fa","user":{"login":"al13n321","id":3629776,"avatar_url":"https://avatars.githubusercontent.com/u/3629776?v=3","gravatar_id":"","url":"https://api.github.com/users/al13n321","html_url":"https://github.com/al13n321","followers_url":"https://api.github.com/users/al13n321/followers","following_url":"https://api.github.com/users/al13n321/following{/other_user}","gists_url":"https://api.github.com/users/al13n321/gists{/gist_id}","starred_url":"https://api.github.com/users/al13n321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/al13n321/subscriptions","organizations_url":"https://api.github.com/users/al13n321/orgs","repos_url":"https://api.github.com/users/al13n321/repos","events_url":"https://api.github.com/users/al13n321/events{/privacy}","received_events_url":"https://api.github.com/users/al13n321/received_events","type":"User","site_admin":false},"body":"Seems clear to me that MergeInProgress is the right thing to return. But it's more of a philosophical question since none of the callers of MergeUntil distinguish between OK and MergeInProgress.","created_at":"2016-12-09T18:15:06Z","updated_at":"2016-12-09T18:15:06Z","html_url":"https://github.com/facebook/rocksdb/pull/1639#discussion_r91766328","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1639","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/91766328"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1639#discussion_r91766328"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1639"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/1639","id":97352510,"html_url":"https://github.com/facebook/rocksdb/pull/1639","diff_url":"https://github.com/facebook/rocksdb/pull/1639.diff","patch_url":"https://github.com/facebook/rocksdb/pull/1639.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/1639","number":1639,"state":"open","locked":false,"title":"Abort compactions more reliably when closing DB","user":{"login":"al13n321","id":3629776,"avatar_url":"https://avatars.githubusercontent.com/u/3629776?v=3","gravatar_id":"","url":"https://api.github.com/users/al13n321","html_url":"https://github.com/al13n321","followers_url":"https://api.github.com/users/al13n321/followers","following_url":"https://api.github.com/users/al13n321/following{/other_user}","gists_url":"https://api.github.com/users/al13n321/gists{/gist_id}","starred_url":"https://api.github.com/users/al13n321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/al13n321/subscriptions","organizations_url":"https://api.github.com/users/al13n321/orgs","repos_url":"https://api.github.com/users/al13n321/repos","events_url":"https://api.github.com/users/al13n321/events{/privacy}","received_events_url":"https://api.github.com/users/al13n321/received_events","type":"User","site_admin":false},"body":"DB shutdown aborts running compactions by setting an atomic shutting_down=true that CompactionJob periodically checks. Without this PR it checks it before processing every _output_ value. If compaction filter filters everything out, the compactions is essentially uninterruptible. This PR adds checks for shutting_down on every _input_ value (in CompactionIterator and MergeHelper).\r\n\r\nThere's also some minor code cleanup along the way.","created_at":"2016-12-09T17:56:14Z","updated_at":"2016-12-09T18:15:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc36cf793b4f73aa85862c53c9fc7688bc25a40b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1639/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1639/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/1639/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/dc48650a64ce95bcec477e861f4dc6e952f705fa","head":{"label":"al13n321:log","ref":"log","sha":"dc48650a64ce95bcec477e861f4dc6e952f705fa","user":{"login":"al13n321","id":3629776,"avatar_url":"https://avatars.githubusercontent.com/u/3629776?v=3","gravatar_id":"","url":"https://api.github.com/users/al13n321","html_url":"https://github.com/al13n321","followers_url":"https://api.github.com/users/al13n321/followers","following_url":"https://api.github.com/users/al13n321/following{/other_user}","gists_url":"https://api.github.com/users/al13n321/gists{/gist_id}","starred_url":"https://api.github.com/users/al13n321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/al13n321/subscriptions","organizations_url":"https://api.github.com/users/al13n321/orgs","repos_url":"https://api.github.com/users/al13n321/repos","events_url":"https://api.github.com/users/al13n321/events{/privacy}","received_events_url":"https://api.github.com/users/al13n321/received_events","type":"User","site_admin":false},"repo":{"id":27731413,"name":"rocksdb","full_name":"al13n321/rocksdb","owner":{"login":"al13n321","id":3629776,"avatar_url":"https://avatars.githubusercontent.com/u/3629776?v=3","gravatar_id":"","url":"https://api.github.com/users/al13n321","html_url":"https://github.com/al13n321","followers_url":"https://api.github.com/users/al13n321/followers","following_url":"https://api.github.com/users/al13n321/following{/other_user}","gists_url":"https://api.github.com/users/al13n321/gists{/gist_id}","starred_url":"https://api.github.com/users/al13n321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/al13n321/subscriptions","organizations_url":"https://api.github.com/users/al13n321/orgs","repos_url":"https://api.github.com/users/al13n321/repos","events_url":"https://api.github.com/users/al13n321/events{/privacy}","received_events_url":"https://api.github.com/users/al13n321/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/al13n321/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/al13n321/rocksdb","forks_url":"https://api.github.com/repos/al13n321/rocksdb/forks","keys_url":"https://api.github.com/repos/al13n321/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/al13n321/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/al13n321/rocksdb/teams","hooks_url":"https://api.github.com/repos/al13n321/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/al13n321/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/al13n321/rocksdb/events","assignees_url":"https://api.github.com/repos/al13n321/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/al13n321/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/al13n321/rocksdb/tags","blobs_url":"https://api.github.com/repos/al13n321/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/al13n321/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/al13n321/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/al13n321/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/al13n321/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/al13n321/rocksdb/languages","stargazers_url":"https://api.github.com/repos/al13n321/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/al13n321/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/al13n321/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/al13n321/rocksdb/subscription","commits_url":"https://api.github.com/repos/al13n321/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/al13n321/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/al13n321/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/al13n321/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/al13n321/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/al13n321/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/al13n321/rocksdb/merges","archive_url":"https://api.github.com/repos/al13n321/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/al13n321/rocksdb/downloads","issues_url":"https://api.github.com/repos/al13n321/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/al13n321/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/al13n321/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/al13n321/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/al13n321/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/al13n321/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/al13n321/rocksdb/deployments","created_at":"2014-12-08T19:35:25Z","updated_at":"2016-10-21T23:01:38Z","pushed_at":"2016-12-09T17:44:24Z","git_url":"git://github.com/al13n321/rocksdb.git","ssh_url":"git@github.com:al13n321/rocksdb.git","clone_url":"https://github.com/al13n321/rocksdb.git","svn_url":"https://github.com/al13n321/rocksdb","homepage":"http://rocksdb.org","size":57126,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"20ce081fae1afbd4cbc4e745d29b79f050951555","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2016-12-09T13:10:08Z","pushed_at":"2016-12-09T17:56:14Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":130889,"stargazers_count":6564,"watchers_count":6564,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1376,"mirror_url":null,"open_issues_count":334,"forks":1376,"open_issues":334,"watchers":6564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1639"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1639"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1639"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1639/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1639/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1639/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/dc48650a64ce95bcec477e861f4dc6e952f705fa"}}}}
{"actor":{"display_login":"al13n321"}}