{"action":"created","issue":{"url":"https://api.github.com/repos/mesos/storm/issues/109","repository_url":"https://api.github.com/repos/mesos/storm","labels_url":"https://api.github.com/repos/mesos/storm/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/mesos/storm/issues/109/comments","events_url":"https://api.github.com/repos/mesos/storm/issues/109/events","html_url":"https://github.com/mesos/storm/pull/109","id":142334924,"number":109,"title":"onbuild triggers for mesos/storm versioning and building","user":{"login":"lfundaro","id":137639,"avatar_url":"https://avatars.githubusercontent.com/u/137639?v=3","gravatar_id":"","url":"https://api.github.com/users/lfundaro","html_url":"https://github.com/lfundaro","followers_url":"https://api.github.com/users/lfundaro/followers","following_url":"https://api.github.com/users/lfundaro/following{/other_user}","gists_url":"https://api.github.com/users/lfundaro/gists{/gist_id}","starred_url":"https://api.github.com/users/lfundaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfundaro/subscriptions","organizations_url":"https://api.github.com/users/lfundaro/orgs","repos_url":"https://api.github.com/users/lfundaro/repos","events_url":"https://api.github.com/users/lfundaro/events{/privacy}","received_events_url":"https://api.github.com/users/lfundaro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-21T12:36:41Z","updated_at":"2016-03-24T09:27:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesos/storm/pulls/109","html_url":"https://github.com/mesos/storm/pull/109","diff_url":"https://github.com/mesos/storm/pull/109.diff","patch_url":"https://github.com/mesos/storm/pull/109.patch"},"body":"By deferring the building of mesos/storm one is able to use mesos/storm image as a base image and then being able to easily control the desired versioning. \r\nInstead of having to pull the mesos/storm repo and build the container passing the `--build-arg STORM_RELEASE/MESOS_RELEASE` I find more useful to just use an onbuild version of Dockerfile that allow me to simply do on my own dockerfile the following: \r\n\r\n```\r\nFROM mesos/storm-onbuild \r\n....\r\n<here I added my private things>\r\n.....\r\n```\r\nand then\r\n`docker build -t my_storm_mesos_image --build-arg STORM_RELEASE=0.10.0 .\r\n`\r\nwhat do you guys think ? "},"comment":{"url":"https://api.github.com/repos/mesos/storm/issues/comments/200752293","html_url":"https://github.com/mesos/storm/pull/109#issuecomment-200752293","issue_url":"https://api.github.com/repos/mesos/storm/issues/109","id":200752293,"user":{"login":"lfundaro","id":137639,"avatar_url":"https://avatars.githubusercontent.com/u/137639?v=3","gravatar_id":"","url":"https://api.github.com/users/lfundaro","html_url":"https://github.com/lfundaro","followers_url":"https://api.github.com/users/lfundaro/followers","following_url":"https://api.github.com/users/lfundaro/following{/other_user}","gists_url":"https://api.github.com/users/lfundaro/gists{/gist_id}","starred_url":"https://api.github.com/users/lfundaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfundaro/subscriptions","organizations_url":"https://api.github.com/users/lfundaro/orgs","repos_url":"https://api.github.com/users/lfundaro/repos","events_url":"https://api.github.com/users/lfundaro/events{/privacy}","received_events_url":"https://api.github.com/users/lfundaro/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T09:27:36Z","updated_at":"2016-03-24T09:27:36Z","body":"Hey guys, after the discussion I am a bit confused here. I understand @DarinJ 's solution and I think it's a good idea. But does this mean the ONBUILD triggers are no longer needed ? Are we creating separate docker images per mesos version and then let the user choose the storm_release ? "}}