{"action":"created","comment":{"url":"https://api.github.com/repos/cloudant/basho_bench/pulls/comments/59461750","id":59461750,"diff_hunk":"@@ -111,6 +113,8 @@ init([]) ->\n     %% successful operations\n     [begin\n          folsom_metrics:new_histogram({latencies, Op}, slide, basho_bench_config:get(report_interval)),\n+         folsom_metrics:new_histogram({overall_latencies, Op}, uniform, 16384),","path":"src/basho_bench_stats.erl","position":13,"original_position":13,"commit_id":"960e3b4ae80e1868d1d31b21e5a5590737718c4a","original_commit_id":"960e3b4ae80e1868d1d31b21e5a5590737718c4a","user":{"login":"MatthiasLeeIBM","id":12851253,"avatar_url":"https://avatars.githubusercontent.com/u/12851253?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthiasLeeIBM","html_url":"https://github.com/MatthiasLeeIBM","followers_url":"https://api.github.com/users/MatthiasLeeIBM/followers","following_url":"https://api.github.com/users/MatthiasLeeIBM/following{/other_user}","gists_url":"https://api.github.com/users/MatthiasLeeIBM/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthiasLeeIBM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthiasLeeIBM/subscriptions","organizations_url":"https://api.github.com/users/MatthiasLeeIBM/orgs","repos_url":"https://api.github.com/users/MatthiasLeeIBM/repos","events_url":"https://api.github.com/users/MatthiasLeeIBM/events{/privacy}","received_events_url":"https://api.github.com/users/MatthiasLeeIBM/received_events","type":"User","site_admin":false},"body":"Originally I started with 1024, but I figured that if we collect p999, we should have some more datapoints than just ~1, so I figured approx 10x  and then round up to the next power of two.\r\n\r\nIts a bit arbitrary, but that was my thought process","created_at":"2016-04-12T21:59:23Z","updated_at":"2016-04-12T21:59:23Z","html_url":"https://github.com/cloudant/basho_bench/pull/13#discussion_r59461750","pull_request_url":"https://api.github.com/repos/cloudant/basho_bench/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/comments/59461750"},"html":{"href":"https://github.com/cloudant/basho_bench/pull/13#discussion_r59461750"},"pull_request":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/cloudant/basho_bench/pulls/13","id":65923515,"html_url":"https://github.com/cloudant/basho_bench/pull/13","diff_url":"https://github.com/cloudant/basho_bench/pull/13.diff","patch_url":"https://github.com/cloudant/basho_bench/pull/13.patch","issue_url":"https://api.github.com/repos/cloudant/basho_bench/issues/13","number":13,"state":"open","locked":false,"title":"63515 added output of a JSON-formatted metrics representing the entire run","user":{"login":"MatthiasLeeIBM","id":12851253,"avatar_url":"https://avatars.githubusercontent.com/u/12851253?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthiasLeeIBM","html_url":"https://github.com/MatthiasLeeIBM","followers_url":"https://api.github.com/users/MatthiasLeeIBM/followers","following_url":"https://api.github.com/users/MatthiasLeeIBM/following{/other_user}","gists_url":"https://api.github.com/users/MatthiasLeeIBM/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthiasLeeIBM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthiasLeeIBM/subscriptions","organizations_url":"https://api.github.com/users/MatthiasLeeIBM/orgs","repos_url":"https://api.github.com/users/MatthiasLeeIBM/repos","events_url":"https://api.github.com/users/MatthiasLeeIBM/events{/privacy}","received_events_url":"https://api.github.com/users/MatthiasLeeIBM/received_events","type":"User","site_admin":false},"body":"Bugzid:  63515\r\n\r\nChanges:\r\n- added another histogram for collecting stats across the entire run\r\n- added JSON-formatted output of collected statistics\r\n\r\nGenerated Output:\r\n```json\r\n{ \"recordedMetrics\" : {\r\n\"put\": {\"n\":319546,\r\n\"standard_deviation\":0.9843117238528302,\r\n\"median\":2,\r\n\"harmonic_mean\":2.2260478373026475,\r\n\"geometric_mean\":2.2784470685780045,\r\n\"arithmetic_mean\":2.3607399247682648,\r\n\"min\":2,\r\n\"max\":93,\r\n\"p50\":2,\r\n\"p75\":3,\r\n\"p90\":3,\r\n\"p95\":3,\r\n\"p99\":5,\r\n\"p999\":15,\r\n\"variance\":0.9688695697141303,\r\n\"kurtosis\":1163.4918872449086,\r\n\"skewness\":21.457948218223454\r\n},\r\n\"put10\": {\"n\":282077,\r\n\"standard_deviation\":3.6205383023363447,\r\n\"median\":17,\r\n\"harmonic_mean\":17.28713647538748,\r\n\"geometric_mean\":17.4556781472093,\r\n\"arithmetic_mean\":17.693165341378418,\r\n\"min\":15,\r\n\"max\":242,\r\n\"p50\":17,\r\n\"p75\":18,\r\n\"p90\":20,\r\n\"p95\":24,\r\n\"p99\":32,\r\n\"p999\":50,\r\n\"variance\":13.10829759868454,\r\n\"kurtosis\":134.8276758531883,\r\n\"skewness\":6.980396917158458\r\n}\r\n}\r\n}\r\n```\r\n\r\n\r\nQuestions:\r\n- Is _slide_ the right histogram for this? looks like _slide_ only represents the last window-size worth of stats, might be better to do a _uniform_ histogram.\r\n- I'd be interested in pointers on style and best practices.\r\n\r\ncc: @chewbranca @djschlegel2 ","created_at":"2016-04-10T21:26:30Z","updated_at":"2016-04-12T21:59:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70679092bc4517e2052bdfbad29a7dd71a81e07a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudant/basho_bench/pulls/13/commits","review_comments_url":"https://api.github.com/repos/cloudant/basho_bench/pulls/13/comments","review_comment_url":"https://api.github.com/repos/cloudant/basho_bench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudant/basho_bench/issues/13/comments","statuses_url":"https://api.github.com/repos/cloudant/basho_bench/statuses/960e3b4ae80e1868d1d31b21e5a5590737718c4a","head":{"label":"cloudant:63515-add-nimbus-compatible-output","ref":"63515-add-nimbus-compatible-output","sha":"960e3b4ae80e1868d1d31b21e5a5590737718c4a","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":48444796,"name":"basho_bench","full_name":"cloudant/basho_bench","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/basho_bench","description":"A load-generation and testing tool for basically whatever you can write a returning Erlang function for.","fork":true,"url":"https://api.github.com/repos/cloudant/basho_bench","forks_url":"https://api.github.com/repos/cloudant/basho_bench/forks","keys_url":"https://api.github.com/repos/cloudant/basho_bench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/basho_bench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/basho_bench/teams","hooks_url":"https://api.github.com/repos/cloudant/basho_bench/hooks","issue_events_url":"https://api.github.com/repos/cloudant/basho_bench/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/basho_bench/events","assignees_url":"https://api.github.com/repos/cloudant/basho_bench/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/basho_bench/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/basho_bench/tags","blobs_url":"https://api.github.com/repos/cloudant/basho_bench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/basho_bench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/basho_bench/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/basho_bench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/basho_bench/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/basho_bench/languages","stargazers_url":"https://api.github.com/repos/cloudant/basho_bench/stargazers","contributors_url":"https://api.github.com/repos/cloudant/basho_bench/contributors","subscribers_url":"https://api.github.com/repos/cloudant/basho_bench/subscribers","subscription_url":"https://api.github.com/repos/cloudant/basho_bench/subscription","commits_url":"https://api.github.com/repos/cloudant/basho_bench/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/basho_bench/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/basho_bench/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/basho_bench/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/basho_bench/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/basho_bench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/basho_bench/merges","archive_url":"https://api.github.com/repos/cloudant/basho_bench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/basho_bench/downloads","issues_url":"https://api.github.com/repos/cloudant/basho_bench/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/basho_bench/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/basho_bench/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/basho_bench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/basho_bench/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/basho_bench/releases{/id}","deployments_url":"https://api.github.com/repos/cloudant/basho_bench/deployments","created_at":"2015-12-22T17:21:08Z","updated_at":"2015-12-22T17:21:10Z","pushed_at":"2016-04-12T21:42:27Z","git_url":"git://github.com/cloudant/basho_bench.git","ssh_url":"git@github.com:cloudant/basho_bench.git","clone_url":"https://github.com/cloudant/basho_bench.git","svn_url":"https://github.com/cloudant/basho_bench","homepage":"","size":2336,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"cloudant"}},"base":{"label":"cloudant:cloudant","ref":"cloudant","sha":"a044d4249598480999a3b0f1093c93ec3cee8fe7","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":48444796,"name":"basho_bench","full_name":"cloudant/basho_bench","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/basho_bench","description":"A load-generation and testing tool for basically whatever you can write a returning Erlang function for.","fork":true,"url":"https://api.github.com/repos/cloudant/basho_bench","forks_url":"https://api.github.com/repos/cloudant/basho_bench/forks","keys_url":"https://api.github.com/repos/cloudant/basho_bench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/basho_bench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/basho_bench/teams","hooks_url":"https://api.github.com/repos/cloudant/basho_bench/hooks","issue_events_url":"https://api.github.com/repos/cloudant/basho_bench/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/basho_bench/events","assignees_url":"https://api.github.com/repos/cloudant/basho_bench/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/basho_bench/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/basho_bench/tags","blobs_url":"https://api.github.com/repos/cloudant/basho_bench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/basho_bench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/basho_bench/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/basho_bench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/basho_bench/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/basho_bench/languages","stargazers_url":"https://api.github.com/repos/cloudant/basho_bench/stargazers","contributors_url":"https://api.github.com/repos/cloudant/basho_bench/contributors","subscribers_url":"https://api.github.com/repos/cloudant/basho_bench/subscribers","subscription_url":"https://api.github.com/repos/cloudant/basho_bench/subscription","commits_url":"https://api.github.com/repos/cloudant/basho_bench/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/basho_bench/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/basho_bench/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/basho_bench/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/basho_bench/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/basho_bench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/basho_bench/merges","archive_url":"https://api.github.com/repos/cloudant/basho_bench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/basho_bench/downloads","issues_url":"https://api.github.com/repos/cloudant/basho_bench/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/basho_bench/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/basho_bench/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/basho_bench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/basho_bench/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/basho_bench/releases{/id}","deployments_url":"https://api.github.com/repos/cloudant/basho_bench/deployments","created_at":"2015-12-22T17:21:08Z","updated_at":"2015-12-22T17:21:10Z","pushed_at":"2016-04-12T21:42:27Z","git_url":"git://github.com/cloudant/basho_bench.git","ssh_url":"git@github.com:cloudant/basho_bench.git","clone_url":"https://github.com/cloudant/basho_bench.git","svn_url":"https://github.com/cloudant/basho_bench","homepage":"","size":2336,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"cloudant"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/13"},"html":{"href":"https://github.com/cloudant/basho_bench/pull/13"},"issue":{"href":"https://api.github.com/repos/cloudant/basho_bench/issues/13"},"comments":{"href":"https://api.github.com/repos/cloudant/basho_bench/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudant/basho_bench/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/cloudant/basho_bench/statuses/960e3b4ae80e1868d1d31b21e5a5590737718c4a"}}}}