{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/60852993","id":60852993,"diff_hunk":"@@ -290,20 +254,27 @@\n \t\t\t\t\treturn 0\n \treturn 1\n \n-/obj/structure/window/proc/hit(damage, sound_effect = 1)\n+/obj/structure/window/proc/take_damage(damage, damage_type = BRUTE, sound_effect = 1)\n \tif(reinf)\n \t\tdamage *= 0.5\n-\thealth = max(0, health - damage)\n+\tswitch(damage_type)\n+\t\tif(BRUTE)\n+\t\t\tif(sound_effect)\n+\t\t\t\tplaysound(loc, 'sound/effects/Glasshit.ogg', 90, 1)\n+\t\tif(BURN)\n+\t\t\tif(sound_effect)\n+\t\t\t\tplaysound(src.loc, 'sound/items/Welder.ogg', 100, 1)\n+\t\telse\n+\t\t\treturn\n+\thealth -= damage\n \tupdate_nearby_icons()\n-\tif(sound_effect)\n-\t\tplaysound(loc, 'sound/effects/Glasshit.ogg', 75, 1)\n \tif(health <= 0)\n-\t\tspawnfragments()\n-\t\treturn\n+\t\tshatter()\n \n-/obj/structure/window/proc/spawnfragments()\n-\tif(qdeleted())\n+/obj/structure/window/proc/shatter()","path":"code/game/objects/structures/window.dm","position":null,"original_position":205,"commit_id":"fcf544283dac83c978d8b4ea14b3be581a8d2ebe","original_commit_id":"0480790b0a007b9dd8be9f71ba8124bbd545d2b9","user":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"body":"a more fitting proc name.","created_at":"2016-04-24T22:16:58Z","updated_at":"2016-04-24T22:16:58Z","html_url":"https://github.com/tgstation/-tg-station/pull/17094#discussion_r60852993","pull_request_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/17094","_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/60852993"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/17094#discussion_r60852993"},"pull_request":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/17094"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/17094","id":67647082,"html_url":"https://github.com/tgstation/-tg-station/pull/17094","diff_url":"https://github.com/tgstation/-tg-station/pull/17094.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/17094.patch","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/17094","number":17094,"state":"open","locked":false,"title":"Attackby destruction (Commented version, DNM)","user":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"body":"This is a copy of #17092.\r\nI'll put my comments of the code here so as to not clutter the discussion space in the real PR.","created_at":"2016-04-24T19:25:58Z","updated_at":"2016-04-24T22:16:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2baa97dbb88a92b7eb05d04e1c5b575e76a13917","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/17094/commits","review_comments_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/17094/comments","review_comment_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/17094/comments","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/fcf544283dac83c978d8b4ea14b3be581a8d2ebe","head":{"label":"phil235:CommentedAttackbyDestruction","ref":"CommentedAttackbyDestruction","sha":"fcf544283dac83c978d8b4ea14b3be581a8d2ebe","user":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"repo":{"id":23807273,"name":"-tg-station","full_name":"phil235/-tg-station","owner":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phil235/-tg-station","description":"/tg/'s SS13 branch","fork":true,"url":"https://api.github.com/repos/phil235/-tg-station","forks_url":"https://api.github.com/repos/phil235/-tg-station/forks","keys_url":"https://api.github.com/repos/phil235/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phil235/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phil235/-tg-station/teams","hooks_url":"https://api.github.com/repos/phil235/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/phil235/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/phil235/-tg-station/events","assignees_url":"https://api.github.com/repos/phil235/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/phil235/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/phil235/-tg-station/tags","blobs_url":"https://api.github.com/repos/phil235/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phil235/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phil235/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/phil235/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phil235/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/phil235/-tg-station/languages","stargazers_url":"https://api.github.com/repos/phil235/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/phil235/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/phil235/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/phil235/-tg-station/subscription","commits_url":"https://api.github.com/repos/phil235/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/phil235/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/phil235/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/phil235/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/phil235/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/phil235/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phil235/-tg-station/merges","archive_url":"https://api.github.com/repos/phil235/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phil235/-tg-station/downloads","issues_url":"https://api.github.com/repos/phil235/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/phil235/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/phil235/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/phil235/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phil235/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/phil235/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/phil235/-tg-station/deployments","created_at":"2014-09-08T20:34:40Z","updated_at":"2016-02-25T12:01:02Z","pushed_at":"2016-04-24T19:24:22Z","git_url":"git://github.com/phil235/-tg-station.git","ssh_url":"git@github.com:phil235/-tg-station.git","clone_url":"https://github.com/phil235/-tg-station.git","svn_url":"https://github.com/phil235/-tg-station","homepage":"http://www.tgstation13.org/","size":567309,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"3d14a51fba9a22153306813ebc0d7e84abda37c8","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"-tg-station","full_name":"tgstation/-tg-station","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/-tg-station","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/-tg-station","forks_url":"https://api.github.com/repos/tgstation/-tg-station/forks","keys_url":"https://api.github.com/repos/tgstation/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/-tg-station/teams","hooks_url":"https://api.github.com/repos/tgstation/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/-tg-station/events","assignees_url":"https://api.github.com/repos/tgstation/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/-tg-station/tags","blobs_url":"https://api.github.com/repos/tgstation/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/-tg-station/languages","stargazers_url":"https://api.github.com/repos/tgstation/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/tgstation/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/tgstation/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/tgstation/-tg-station/subscription","commits_url":"https://api.github.com/repos/tgstation/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/-tg-station/merges","archive_url":"https://api.github.com/repos/tgstation/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/-tg-station/downloads","issues_url":"https://api.github.com/repos/tgstation/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/-tg-station/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2016-04-17T03:12:54Z","pushed_at":"2016-04-24T21:44:10Z","git_url":"git://github.com/tgstation/-tg-station.git","ssh_url":"git@github.com:tgstation/-tg-station.git","clone_url":"https://github.com/tgstation/-tg-station.git","svn_url":"https://github.com/tgstation/-tg-station","homepage":"http://www.tgstation13.org/","size":784480,"stargazers_count":290,"watchers_count":290,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1025,"mirror_url":null,"open_issues_count":938,"forks":1025,"open_issues":938,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/17094"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/17094"},"issue":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/17094"},"comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/17094/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/17094/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/17094/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/-tg-station/statuses/fcf544283dac83c978d8b4ea14b3be581a8d2ebe"}}}}