{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/daikon/pulls/comments/89377764","pull_request_review_id":9923965,"id":89377764,"diff_hunk":"@@ -38,37 +41,62 @@\n      */\n     private static IndexedRecord record;\n \n+    private static void setLogicalType(Schema schema, LogicalType lt) throws Exception {\n+        Method setLogicalType = Schema.class.getDeclaredMethod(\"setLogicalType\", new Class[] { LogicalType.class });\n+        setLogicalType.setAccessible(true);\n+        setLogicalType.invoke(schema, new Object[] { lt });\n+    }\n+\n     /**\n      * Creates runtime schema, design schema and record, which is used as test arguments\n      */\n     @BeforeClass\n-    public static void setup() {\n+    public static void setup() throws Exception {\n         runtimeSchema = SchemaBuilder.builder().record(\"Record\").fields() //\n-                .name(\"id\").type().intType().noDefault() //\n+                .name(\"id\").type(Schema.create(Schema.Type.INT)).noDefault() //\n                 .name(\"name\").type().stringType().noDefault() //\n-                .name(\"age\").type().intType().noDefault() //\n+                .name(\"age\").type(Schema.create(Schema.Type.INT)).noDefault() //\n                 .name(\"valid\").type().booleanType().noDefault() //\n                 .name(\"createdDate\").prop(DiSchemaConstants.TALEND6_COLUMN_TALEND_TYPE, \"id_Date\") //\n                 .prop(DiSchemaConstants.TALEND6_COLUMN_PATTERN, \"yyyy-MM-dd'T'HH:mm:ss'000Z'\").type().nullable().longType() //\n                 .noDefault() //\n+                .name(\"logicalDate\").prop(\"logicalType\", \"date\").type(Schema.create(Schema.Type.INT)).noDefault() //","path":"daikon/src/test/java/org/talend/daikon/di/DiOutgoingSchemaEnforcerTest.java","position":39,"original_position":39,"commit_id":"8052283571be0e97c7509dc41208e74aadefa980","original_commit_id":"8052283571be0e97c7509dc41208e74aadefa980","user":{"login":"francisu","id":944949,"avatar_url":"https://avatars.githubusercontent.com/u/944949?v=3","gravatar_id":"","url":"https://api.github.com/users/francisu","html_url":"https://github.com/francisu","followers_url":"https://api.github.com/users/francisu/followers","following_url":"https://api.github.com/users/francisu/following{/other_user}","gists_url":"https://api.github.com/users/francisu/gists{/gist_id}","starred_url":"https://api.github.com/users/francisu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisu/subscriptions","organizations_url":"https://api.github.com/users/francisu/orgs","repos_url":"https://api.github.com/users/francisu/repos","events_url":"https://api.github.com/users/francisu/events{/privacy}","received_events_url":"https://api.github.com/users/francisu/received_events","type":"User","site_admin":false},"body":"Thank you *so much* I spent a lot of time trying to figure out how to build a logical type with the SchemaBuilder; this is just what I needed.","created_at":"2016-11-23T18:47:57Z","updated_at":"2016-11-23T18:47:57Z","html_url":"https://github.com/Talend/daikon/pull/96#discussion_r89377764","pull_request_url":"https://api.github.com/repos/Talend/daikon/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/Talend/daikon/pulls/comments/89377764"},"html":{"href":"https://github.com/Talend/daikon/pull/96#discussion_r89377764"},"pull_request":{"href":"https://api.github.com/repos/Talend/daikon/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/daikon/pulls/96","id":94996739,"html_url":"https://github.com/Talend/daikon/pull/96","diff_url":"https://github.com/Talend/daikon/pull/96.diff","patch_url":"https://github.com/Talend/daikon/pull/96.patch","issue_url":"https://api.github.com/repos/Talend/daikon/issues/96","number":96,"state":"open","locked":false,"title":"TDI-37709 Date/Time issues in DI conversion","user":{"login":"francisu","id":944949,"avatar_url":"https://avatars.githubusercontent.com/u/944949?v=3","gravatar_id":"","url":"https://api.github.com/users/francisu","html_url":"https://github.com/francisu","followers_url":"https://api.github.com/users/francisu/followers","following_url":"https://api.github.com/users/francisu/following{/other_user}","gists_url":"https://api.github.com/users/francisu/gists{/gist_id}","starred_url":"https://api.github.com/users/francisu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisu/subscriptions","organizations_url":"https://api.github.com/users/francisu/orgs","repos_url":"https://api.github.com/users/francisu/repos","events_url":"https://api.github.com/users/francisu/events{/privacy}","received_events_url":"https://api.github.com/users/francisu/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n- [X] The commit(s) message(s) follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md#commit-message-format) ?\r\n- [X] Tests for the changes have been added (for bug fixes / features) ?\r\n- [ ] Docs have been added / updated (for bug fixes / features) ?\r\n- [X] The code coverage on new code >75%\r\n- [ ] The new code does not introduce new technical issues (sonar / eslint)\r\n\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [X] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nhttps://jira.talendforge.org/browse/TDI-37709\r\n\r\n\r\n**What is the new behavior?**\r\n\r\nFixed.\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [X] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**: \r\n\r\nGoes with corresponding change in tcommon-studio-se\r\n\r\n","created_at":"2016-11-23T12:47:45Z","updated_at":"2016-11-23T18:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c18e74f8d918043e58c15b764818c304c9dd3e98","assignee":{"login":"gonchar-ivan","id":7621737,"avatar_url":"https://avatars.githubusercontent.com/u/7621737?v=3","gravatar_id":"","url":"https://api.github.com/users/gonchar-ivan","html_url":"https://github.com/gonchar-ivan","followers_url":"https://api.github.com/users/gonchar-ivan/followers","following_url":"https://api.github.com/users/gonchar-ivan/following{/other_user}","gists_url":"https://api.github.com/users/gonchar-ivan/gists{/gist_id}","starred_url":"https://api.github.com/users/gonchar-ivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonchar-ivan/subscriptions","organizations_url":"https://api.github.com/users/gonchar-ivan/orgs","repos_url":"https://api.github.com/users/gonchar-ivan/repos","events_url":"https://api.github.com/users/gonchar-ivan/events{/privacy}","received_events_url":"https://api.github.com/users/gonchar-ivan/received_events","type":"User","site_admin":false},"assignees":[{"login":"gonchar-ivan","id":7621737,"avatar_url":"https://avatars.githubusercontent.com/u/7621737?v=3","gravatar_id":"","url":"https://api.github.com/users/gonchar-ivan","html_url":"https://github.com/gonchar-ivan","followers_url":"https://api.github.com/users/gonchar-ivan/followers","following_url":"https://api.github.com/users/gonchar-ivan/following{/other_user}","gists_url":"https://api.github.com/users/gonchar-ivan/gists{/gist_id}","starred_url":"https://api.github.com/users/gonchar-ivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonchar-ivan/subscriptions","organizations_url":"https://api.github.com/users/gonchar-ivan/orgs","repos_url":"https://api.github.com/users/gonchar-ivan/repos","events_url":"https://api.github.com/users/gonchar-ivan/events{/privacy}","received_events_url":"https://api.github.com/users/gonchar-ivan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/daikon/pulls/96/commits","review_comments_url":"https://api.github.com/repos/Talend/daikon/pulls/96/comments","review_comment_url":"https://api.github.com/repos/Talend/daikon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/daikon/issues/96/comments","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/8052283571be0e97c7509dc41208e74aadefa980","head":{"label":"Talend:bugfix/TDI-37709_date_time_issues","ref":"bugfix/TDI-37709_date_time_issues","sha":"8052283571be0e97c7509dc41208e74aadefa980","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":42255499,"name":"daikon","full_name":"Talend/daikon","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/daikon","description":"Commons back-end java classes shared by dataprep and components services (for now)","fork":false,"url":"https://api.github.com/repos/Talend/daikon","forks_url":"https://api.github.com/repos/Talend/daikon/forks","keys_url":"https://api.github.com/repos/Talend/daikon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/daikon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/daikon/teams","hooks_url":"https://api.github.com/repos/Talend/daikon/hooks","issue_events_url":"https://api.github.com/repos/Talend/daikon/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/daikon/events","assignees_url":"https://api.github.com/repos/Talend/daikon/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/daikon/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/daikon/tags","blobs_url":"https://api.github.com/repos/Talend/daikon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/daikon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/daikon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/daikon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/daikon/languages","stargazers_url":"https://api.github.com/repos/Talend/daikon/stargazers","contributors_url":"https://api.github.com/repos/Talend/daikon/contributors","subscribers_url":"https://api.github.com/repos/Talend/daikon/subscribers","subscription_url":"https://api.github.com/repos/Talend/daikon/subscription","commits_url":"https://api.github.com/repos/Talend/daikon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/daikon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/daikon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/daikon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/daikon/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/daikon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/daikon/merges","archive_url":"https://api.github.com/repos/Talend/daikon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/daikon/downloads","issues_url":"https://api.github.com/repos/Talend/daikon/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/daikon/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/daikon/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/daikon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/daikon/labels{/name}","releases_url":"https://api.github.com/repos/Talend/daikon/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/daikon/deployments","created_at":"2015-09-10T16:08:46Z","updated_at":"2016-10-24T09:25:37Z","pushed_at":"2016-11-23T17:09:37Z","git_url":"git://github.com/Talend/daikon.git","ssh_url":"git@github.com:Talend/daikon.git","clone_url":"https://github.com/Talend/daikon.git","svn_url":"https://github.com/Talend/daikon","homepage":null,"size":3030,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"d7f13532bc59bf5d82529c5dbb55c2a0b9aa0491","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":42255499,"name":"daikon","full_name":"Talend/daikon","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/daikon","description":"Commons back-end java classes shared by dataprep and components services (for now)","fork":false,"url":"https://api.github.com/repos/Talend/daikon","forks_url":"https://api.github.com/repos/Talend/daikon/forks","keys_url":"https://api.github.com/repos/Talend/daikon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/daikon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/daikon/teams","hooks_url":"https://api.github.com/repos/Talend/daikon/hooks","issue_events_url":"https://api.github.com/repos/Talend/daikon/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/daikon/events","assignees_url":"https://api.github.com/repos/Talend/daikon/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/daikon/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/daikon/tags","blobs_url":"https://api.github.com/repos/Talend/daikon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/daikon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/daikon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/daikon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/daikon/languages","stargazers_url":"https://api.github.com/repos/Talend/daikon/stargazers","contributors_url":"https://api.github.com/repos/Talend/daikon/contributors","subscribers_url":"https://api.github.com/repos/Talend/daikon/subscribers","subscription_url":"https://api.github.com/repos/Talend/daikon/subscription","commits_url":"https://api.github.com/repos/Talend/daikon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/daikon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/daikon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/daikon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/daikon/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/daikon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/daikon/merges","archive_url":"https://api.github.com/repos/Talend/daikon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/daikon/downloads","issues_url":"https://api.github.com/repos/Talend/daikon/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/daikon/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/daikon/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/daikon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/daikon/labels{/name}","releases_url":"https://api.github.com/repos/Talend/daikon/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/daikon/deployments","created_at":"2015-09-10T16:08:46Z","updated_at":"2016-10-24T09:25:37Z","pushed_at":"2016-11-23T17:09:37Z","git_url":"git://github.com/Talend/daikon.git","ssh_url":"git@github.com:Talend/daikon.git","clone_url":"https://github.com/Talend/daikon.git","svn_url":"https://github.com/Talend/daikon","homepage":null,"size":3030,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/daikon/pulls/96"},"html":{"href":"https://github.com/Talend/daikon/pull/96"},"issue":{"href":"https://api.github.com/repos/Talend/daikon/issues/96"},"comments":{"href":"https://api.github.com/repos/Talend/daikon/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/daikon/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/daikon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/daikon/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/daikon/statuses/8052283571be0e97c7509dc41208e74aadefa980"}}}}
{"actor":{"display_login":"francisu"}}