{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/92249076","pull_request_review_id":12761156,"id":92249076,"diff_hunk":"@@ -192,6 +196,10 @@ MM_Collector::preCollect(MM_EnvironmentBase* env, MM_MemorySubSpace* subSpace, M\n {\n \tMM_GCExtensionsBase* extensions = env->getExtensions();\n \n+#if defined(OMR_GC_CONCURRENT_SCAVENGER)\n+\tcompleteConcurrentScavenge(env);","path":"gc/base/Collector.cpp","position":27,"original_position":27,"commit_id":"ce9a63c908d17c84208878319a918f2f2d36fbe7","original_commit_id":"ce9a63c908d17c84208878319a918f2f2d36fbe7","user":{"login":"charliegracie","id":15161849,"avatar_url":"https://avatars.githubusercontent.com/u/15161849?v=3","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false},"body":"@amicic should this be on GlobalCollector instead?  Isn't the Scavenger also a sub class of collector?","created_at":"2016-12-13T19:39:19Z","updated_at":"2016-12-13T19:39:26Z","html_url":"https://github.com/eclipse/omr/pull/592#discussion_r92249076","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/592","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/92249076"},"html":{"href":"https://github.com/eclipse/omr/pull/592#discussion_r92249076"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/592"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/592","id":97354851,"html_url":"https://github.com/eclipse/omr/pull/592","diff_url":"https://github.com/eclipse/omr/pull/592.diff","patch_url":"https://github.com/eclipse/omr/pull/592.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/592","number":592,"state":"open","locked":false,"title":"Complete CS cycle in progress before starting STW global GC","user":{"login":"amicic","id":18264984,"avatar_url":"https://avatars.githubusercontent.com/u/18264984?v=3","gravatar_id":"","url":"https://api.github.com/users/amicic","html_url":"https://github.com/amicic","followers_url":"https://api.github.com/users/amicic/followers","following_url":"https://api.github.com/users/amicic/following{/other_user}","gists_url":"https://api.github.com/users/amicic/gists{/gist_id}","starred_url":"https://api.github.com/users/amicic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amicic/subscriptions","organizations_url":"https://api.github.com/users/amicic/orgs","repos_url":"https://api.github.com/users/amicic/repos","events_url":"https://api.github.com/users/amicic/events{/privacy}","received_events_url":"https://api.github.com/users/amicic/received_events","type":"User","site_admin":false},"body":"More generic solution of https://github.com/eclipse/omr/pull/579. This\r\none additionally covers the case of plain Parallel Global GC, rather\r\nthan more typical ConcurrentGC (STW phase of it).\r\n\r\nAn example is running Java's Gencon GC policy with Concurrent Marking\r\nexplicitly disabled.\r\n\r\nSigned-off-by: Aleksandar Micic <amicic@ca.ibm.com>","created_at":"2016-12-09T18:12:02Z","updated_at":"2016-12-13T19:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94a7ec4be8651937eebdbea93ca9e02a7b83b31c","assignee":{"login":"charliegracie","id":15161849,"avatar_url":"https://avatars.githubusercontent.com/u/15161849?v=3","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false},"assignees":[{"login":"charliegracie","id":15161849,"avatar_url":"https://avatars.githubusercontent.com/u/15161849?v=3","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/592/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/592/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/592/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/ce9a63c908d17c84208878319a918f2f2d36fbe7","head":{"label":"amicic:concurrent-scavenger","ref":"concurrent-scavenger","sha":"ce9a63c908d17c84208878319a918f2f2d36fbe7","user":{"login":"amicic","id":18264984,"avatar_url":"https://avatars.githubusercontent.com/u/18264984?v=3","gravatar_id":"","url":"https://api.github.com/users/amicic","html_url":"https://github.com/amicic","followers_url":"https://api.github.com/users/amicic/followers","following_url":"https://api.github.com/users/amicic/following{/other_user}","gists_url":"https://api.github.com/users/amicic/gists{/gist_id}","starred_url":"https://api.github.com/users/amicic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amicic/subscriptions","organizations_url":"https://api.github.com/users/amicic/orgs","repos_url":"https://api.github.com/users/amicic/repos","events_url":"https://api.github.com/users/amicic/events{/privacy}","received_events_url":"https://api.github.com/users/amicic/received_events","type":"User","site_admin":false},"repo":{"id":55422149,"name":"omr","full_name":"amicic/omr","owner":{"login":"amicic","id":18264984,"avatar_url":"https://avatars.githubusercontent.com/u/18264984?v=3","gravatar_id":"","url":"https://api.github.com/users/amicic","html_url":"https://github.com/amicic","followers_url":"https://api.github.com/users/amicic/followers","following_url":"https://api.github.com/users/amicic/following{/other_user}","gists_url":"https://api.github.com/users/amicic/gists{/gist_id}","starred_url":"https://api.github.com/users/amicic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amicic/subscriptions","organizations_url":"https://api.github.com/users/amicic/orgs","repos_url":"https://api.github.com/users/amicic/repos","events_url":"https://api.github.com/users/amicic/events{/privacy}","received_events_url":"https://api.github.com/users/amicic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amicic/omr","description":"OMR project","fork":true,"url":"https://api.github.com/repos/amicic/omr","forks_url":"https://api.github.com/repos/amicic/omr/forks","keys_url":"https://api.github.com/repos/amicic/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amicic/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amicic/omr/teams","hooks_url":"https://api.github.com/repos/amicic/omr/hooks","issue_events_url":"https://api.github.com/repos/amicic/omr/issues/events{/number}","events_url":"https://api.github.com/repos/amicic/omr/events","assignees_url":"https://api.github.com/repos/amicic/omr/assignees{/user}","branches_url":"https://api.github.com/repos/amicic/omr/branches{/branch}","tags_url":"https://api.github.com/repos/amicic/omr/tags","blobs_url":"https://api.github.com/repos/amicic/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amicic/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amicic/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/amicic/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amicic/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/amicic/omr/languages","stargazers_url":"https://api.github.com/repos/amicic/omr/stargazers","contributors_url":"https://api.github.com/repos/amicic/omr/contributors","subscribers_url":"https://api.github.com/repos/amicic/omr/subscribers","subscription_url":"https://api.github.com/repos/amicic/omr/subscription","commits_url":"https://api.github.com/repos/amicic/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/amicic/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/amicic/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/amicic/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/amicic/omr/contents/{+path}","compare_url":"https://api.github.com/repos/amicic/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amicic/omr/merges","archive_url":"https://api.github.com/repos/amicic/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amicic/omr/downloads","issues_url":"https://api.github.com/repos/amicic/omr/issues{/number}","pulls_url":"https://api.github.com/repos/amicic/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/amicic/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/amicic/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amicic/omr/labels{/name}","releases_url":"https://api.github.com/repos/amicic/omr/releases{/id}","deployments_url":"https://api.github.com/repos/amicic/omr/deployments","created_at":"2016-04-04T15:22:53Z","updated_at":"2016-04-04T15:22:57Z","pushed_at":"2016-12-09T18:09:25Z","git_url":"git://github.com/amicic/omr.git","ssh_url":"git@github.com:amicic/omr.git","clone_url":"https://github.com/amicic/omr.git","svn_url":"https://github.com/amicic/omr","homepage":null,"size":10551,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"fea99e425e95519074c27ef85b20bbf8d92403ea","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2016-12-12T21:43:37Z","pushed_at":"2016-12-13T19:07:01Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":10670,"stargazers_count":265,"watchers_count":265,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":103,"forks":101,"open_issues":103,"watchers":265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/592"},"html":{"href":"https://github.com/eclipse/omr/pull/592"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/592"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/592/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/592/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/592/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/ce9a63c908d17c84208878319a918f2f2d36fbe7"}}}}
{"actor":{"display_login":"charliegracie"}}