{"action":"created","issue":{"url":"https://api.github.com/repos/youtube/vitess/issues/1665","repository_url":"https://api.github.com/repos/youtube/vitess","labels_url":"https://api.github.com/repos/youtube/vitess/issues/1665/labels{/name}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/1665/comments","events_url":"https://api.github.com/repos/youtube/vitess/issues/1665/events","html_url":"https://github.com/youtube/vitess/pull/1665","id":151751435,"number":1665,"title":"sqltypes bug: incorrect vitess type returned","user":{"login":"sougou","id":589370,"avatar_url":"https://avatars.githubusercontent.com/u/589370?v=3","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/youtube/vitess/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-28T21:49:48Z","updated_at":"2016-04-29T17:32:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/1665","html_url":"https://github.com/youtube/vitess/pull/1665","diff_url":"https://github.com/youtube/vitess/pull/1665.diff","patch_url":"https://github.com/youtube/vitess/pull/1665.patch"},"body":"@erzel \r\nBug: b/28409793\r\nMySQL sometimes sets stray flags that have to be ignored.\r\nSpecifically, for this query:\r\nselect max(uint) from t\r\nMySQL sets the binary flag along with the unsigned flag.\r\nThe bug fix changes the behavior where vitess only looks at\r\nthe relevant flags and ignores all others.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/youtube/vitess/1665)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/youtube/vitess/issues/comments/215824098","html_url":"https://github.com/youtube/vitess/pull/1665#issuecomment-215824098","issue_url":"https://api.github.com/repos/youtube/vitess/issues/1665","id":215824098,"user":{"login":"erzel","id":14099708,"avatar_url":"https://avatars.githubusercontent.com/u/14099708?v=3","gravatar_id":"","url":"https://api.github.com/users/erzel","html_url":"https://github.com/erzel","followers_url":"https://api.github.com/users/erzel/followers","following_url":"https://api.github.com/users/erzel/following{/other_user}","gists_url":"https://api.github.com/users/erzel/gists{/gist_id}","starred_url":"https://api.github.com/users/erzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erzel/subscriptions","organizations_url":"https://api.github.com/users/erzel/orgs","repos_url":"https://api.github.com/users/erzel/repos","events_url":"https://api.github.com/users/erzel/events{/privacy}","received_events_url":"https://api.github.com/users/erzel/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T17:32:30Z","updated_at":"2016-04-29T17:32:30Z","body":"\n\n\n\nReview status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[go/sqltypes/type.go, line 111 \\[r1\\]](https://reviewable.io:443/reviews/youtube/vitess/1665#-KGTusUF6k8GBDBjMvZ1:-KGY3Aifg7Zmad3Mdnb6:1088764132) ([raw file](https://github.com/youtube/vitess/blob/939ec958b291e307ad5ea9577999bf78f4353f2f/go/sqltypes/type.go#L111)):*\nCool. I actually think it's simpler and quicker to understand than the old version.\n\n---\n\n*[go/sqltypes/type.go, line 141 \\[r2\\]](https://reviewable.io:443/reviews/youtube/vitess/1665#-KGY3x9f-1ROj-UPG8MP:-KGY3x9f-1ROj-UPG8MQ:-1276465740) ([raw file](https://github.com/youtube/vitess/blob/9eb47e2de2de11b975275f2cf20b7e7f3c0d70ba/go/sqltypes/type.go#L141)):*\nNit: I find it easier to read if there's spaces around the ampersand.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/youtube/vitess/1665)*\n<!-- Sent from Reviewable.io -->\n"}}