{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/86948497","pull_request_review_id":7579305,"id":86948497,"diff_hunk":"@@ -112,7 +112,7 @@ def create_new_host_when_facts_are_uploaded?\n \n     # expect a facts hash\n     def import_facts(facts)\n-      return false unless create_new_host_when_facts_are_uploaded?\n+      return false if !create_new_host_when_facts_are_uploaded? && new_record?","path":"app/models/host/base.rb","position":5,"original_position":5,"commit_id":"061cc1681d95e749f1b6f1ad29e172c128ba9b9d","original_commit_id":"061cc1681d95e749f1b6f1ad29e172c128ba9b9d","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"Yeah, settings are cached tho.","created_at":"2016-11-08T09:11:22Z","updated_at":"2016-11-08T09:11:23Z","html_url":"https://github.com/theforeman/foreman/pull/4001#discussion_r86948497","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/4001","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/86948497"},"html":{"href":"https://github.com/theforeman/foreman/pull/4001#discussion_r86948497"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/4001"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/4001","id":92619998,"html_url":"https://github.com/theforeman/foreman/pull/4001","diff_url":"https://github.com/theforeman/foreman/pull/4001.diff","patch_url":"https://github.com/theforeman/foreman/pull/4001.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/4001","number":4001,"state":"closed","locked":false,"title":"Fixes #16546 - update facts on existing hosts","user":{"login":"jlsherrill","id":395077,"avatar_url":"https://avatars.githubusercontent.com/u/395077?v=3","gravatar_id":"","url":"https://api.github.com/users/jlsherrill","html_url":"https://github.com/jlsherrill","followers_url":"https://api.github.com/users/jlsherrill/followers","following_url":"https://api.github.com/users/jlsherrill/following{/other_user}","gists_url":"https://api.github.com/users/jlsherrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jlsherrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlsherrill/subscriptions","organizations_url":"https://api.github.com/users/jlsherrill/orgs","repos_url":"https://api.github.com/users/jlsherrill/repos","events_url":"https://api.github.com/users/jlsherrill/events{/privacy}","received_events_url":"https://api.github.com/users/jlsherrill/received_events","type":"User","site_admin":false},"body":"when create_new_host_when_facts_are_uploaded is set to false","created_at":"2016-11-07T16:48:03Z","updated_at":"2016-11-08T09:11:23Z","closed_at":"2016-11-07T20:03:48Z","merged_at":"2016-11-07T20:03:48Z","merge_commit_sha":"74002ce3a796ab626f4b5e9c5f031d501424fa22","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/4001/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/4001/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/4001/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/061cc1681d95e749f1b6f1ad29e172c128ba9b9d","head":{"label":"jlsherrill:16546","ref":"16546","sha":"061cc1681d95e749f1b6f1ad29e172c128ba9b9d","user":{"login":"jlsherrill","id":395077,"avatar_url":"https://avatars.githubusercontent.com/u/395077?v=3","gravatar_id":"","url":"https://api.github.com/users/jlsherrill","html_url":"https://github.com/jlsherrill","followers_url":"https://api.github.com/users/jlsherrill/followers","following_url":"https://api.github.com/users/jlsherrill/following{/other_user}","gists_url":"https://api.github.com/users/jlsherrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jlsherrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlsherrill/subscriptions","organizations_url":"https://api.github.com/users/jlsherrill/orgs","repos_url":"https://api.github.com/users/jlsherrill/repos","events_url":"https://api.github.com/users/jlsherrill/events{/privacy}","received_events_url":"https://api.github.com/users/jlsherrill/received_events","type":"User","site_admin":false},"repo":{"id":9306701,"name":"foreman","full_name":"jlsherrill/foreman","owner":{"login":"jlsherrill","id":395077,"avatar_url":"https://avatars.githubusercontent.com/u/395077?v=3","gravatar_id":"","url":"https://api.github.com/users/jlsherrill","html_url":"https://github.com/jlsherrill","followers_url":"https://api.github.com/users/jlsherrill/followers","following_url":"https://api.github.com/users/jlsherrill/following{/other_user}","gists_url":"https://api.github.com/users/jlsherrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jlsherrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlsherrill/subscriptions","organizations_url":"https://api.github.com/users/jlsherrill/orgs","repos_url":"https://api.github.com/users/jlsherrill/repos","events_url":"https://api.github.com/users/jlsherrill/events{/privacy}","received_events_url":"https://api.github.com/users/jlsherrill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlsherrill/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/jlsherrill/foreman","forks_url":"https://api.github.com/repos/jlsherrill/foreman/forks","keys_url":"https://api.github.com/repos/jlsherrill/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlsherrill/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlsherrill/foreman/teams","hooks_url":"https://api.github.com/repos/jlsherrill/foreman/hooks","issue_events_url":"https://api.github.com/repos/jlsherrill/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/jlsherrill/foreman/events","assignees_url":"https://api.github.com/repos/jlsherrill/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/jlsherrill/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/jlsherrill/foreman/tags","blobs_url":"https://api.github.com/repos/jlsherrill/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlsherrill/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlsherrill/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlsherrill/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlsherrill/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/jlsherrill/foreman/languages","stargazers_url":"https://api.github.com/repos/jlsherrill/foreman/stargazers","contributors_url":"https://api.github.com/repos/jlsherrill/foreman/contributors","subscribers_url":"https://api.github.com/repos/jlsherrill/foreman/subscribers","subscription_url":"https://api.github.com/repos/jlsherrill/foreman/subscription","commits_url":"https://api.github.com/repos/jlsherrill/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlsherrill/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlsherrill/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlsherrill/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlsherrill/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/jlsherrill/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlsherrill/foreman/merges","archive_url":"https://api.github.com/repos/jlsherrill/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlsherrill/foreman/downloads","issues_url":"https://api.github.com/repos/jlsherrill/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/jlsherrill/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/jlsherrill/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/jlsherrill/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlsherrill/foreman/labels{/name}","releases_url":"https://api.github.com/repos/jlsherrill/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/jlsherrill/foreman/deployments","created_at":"2013-04-08T20:59:00Z","updated_at":"2014-04-09T23:29:09Z","pushed_at":"2016-11-07T16:46:14Z","git_url":"git://github.com/jlsherrill/foreman.git","ssh_url":"git@github.com:jlsherrill/foreman.git","clone_url":"https://github.com/jlsherrill/foreman.git","svn_url":"https://github.com/jlsherrill/foreman","homepage":"http://theforeman.org","size":34908,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"bbd1b4e3864b1e004e50849ce1c5c8ee1a5c7f33","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-11-05T14:43:14Z","pushed_at":"2016-11-08T08:57:31Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":72849,"stargazers_count":1110,"watchers_count":1110,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":562,"mirror_url":null,"open_issues_count":85,"forks":562,"open_issues":85,"watchers":1110,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/4001"},"html":{"href":"https://github.com/theforeman/foreman/pull/4001"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/4001"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/4001/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/4001/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/4001/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/061cc1681d95e749f1b6f1ad29e172c128ba9b9d"}}}}
{"actor":{"display_login":"lzap"}}