{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/72322543","id":72322543,"diff_hunk":"@@ -130,14 +130,32 @@ describe('MdButton', () => {\n     });\n \n   });\n+\n+  // Ripple tests.\n+  describe('button ripples', () => {\n+    it('should remove ripple if md-ripple-disabled input is set', (done: () => void) => {\n+      return builder.createAsync(TestApp).then(fixture => {\n+        let testComponent = fixture.debugElement.componentInstance;\n+        let buttonDebugElement = fixture.debugElement.query(By.css('button'));\n+\n+        fixture.detectChanges();\n+        expect(buttonDebugElement.nativeElement.querySelectorAll('[md-ripple]').length).toBe(1);\n+\n+        testComponent.rippleDisabled = true;\n+        fixture.detectChanges();\n+        expect(buttonDebugElement.nativeElement.querySelectorAll('[md-ripple]').length).toBe(0);\n+        done();\n+      });\n+    });\n+  });","path":"src/components/button/button.spec.ts","position":21,"original_position":21,"commit_id":"d60b1d1eb6253ae8f246feacd246c6e11d48b6ed","original_commit_id":"d60b1d1eb6253ae8f246feacd246c6e11d48b6ed","user":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars.githubusercontent.com/u/838736?v=3","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"body":"Rather than using `done()`, just make the entire test async:\r\n\r\n\r\n```ts\r\nit('should do a thing', async(() => {\r\n  // ...\r\n}));\r\n```\r\n\r\nIt will automatically complete once all of the asynchronous tasks have completed.","created_at":"2016-07-26T19:44:34Z","updated_at":"2016-07-26T19:44:34Z","html_url":"https://github.com/angular/material2/pull/918#discussion_r72322543","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/918","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/72322543"},"html":{"href":"https://github.com/angular/material2/pull/918#discussion_r72322543"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/918"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/918","id":78788868,"html_url":"https://github.com/angular/material2/pull/918","diff_url":"https://github.com/angular/material2/pull/918.diff","patch_url":"https://github.com/angular/material2/pull/918.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/918","number":918,"state":"open","locked":false,"title":"feat(button): add ripple to md-button","user":{"login":"dozingcat","id":489398,"avatar_url":"https://avatars.githubusercontent.com/u/489398?v=3","gravatar_id":"","url":"https://api.github.com/users/dozingcat","html_url":"https://github.com/dozingcat","followers_url":"https://api.github.com/users/dozingcat/followers","following_url":"https://api.github.com/users/dozingcat/following{/other_user}","gists_url":"https://api.github.com/users/dozingcat/gists{/gist_id}","starred_url":"https://api.github.com/users/dozingcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dozingcat/subscriptions","organizations_url":"https://api.github.com/users/dozingcat/orgs","repos_url":"https://api.github.com/users/dozingcat/repos","events_url":"https://api.github.com/users/dozingcat/events{/privacy}","received_events_url":"https://api.github.com/users/dozingcat/received_events","type":"User","site_admin":false},"body":"Demo at https://dozingcat-material2.firebaseapp.com/ripple and https://dozingcat-material2.firebaseapp.com/button","created_at":"2016-07-26T04:08:03Z","updated_at":"2016-07-26T19:44:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc0527da5c29dcd8d21fe536cbeeda2978268459","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/918/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/918/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/918/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/d60b1d1eb6253ae8f246feacd246c6e11d48b6ed","head":{"label":"dozingcat:MdRipple_MdButton","ref":"MdRipple_MdButton","sha":"d60b1d1eb6253ae8f246feacd246c6e11d48b6ed","user":{"login":"dozingcat","id":489398,"avatar_url":"https://avatars.githubusercontent.com/u/489398?v=3","gravatar_id":"","url":"https://api.github.com/users/dozingcat","html_url":"https://github.com/dozingcat","followers_url":"https://api.github.com/users/dozingcat/followers","following_url":"https://api.github.com/users/dozingcat/following{/other_user}","gists_url":"https://api.github.com/users/dozingcat/gists{/gist_id}","starred_url":"https://api.github.com/users/dozingcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dozingcat/subscriptions","organizations_url":"https://api.github.com/users/dozingcat/orgs","repos_url":"https://api.github.com/users/dozingcat/repos","events_url":"https://api.github.com/users/dozingcat/events{/privacy}","received_events_url":"https://api.github.com/users/dozingcat/received_events","type":"User","site_admin":false},"repo":{"id":53767913,"name":"material2","full_name":"dozingcat/material2","owner":{"login":"dozingcat","id":489398,"avatar_url":"https://avatars.githubusercontent.com/u/489398?v=3","gravatar_id":"","url":"https://api.github.com/users/dozingcat","html_url":"https://github.com/dozingcat","followers_url":"https://api.github.com/users/dozingcat/followers","following_url":"https://api.github.com/users/dozingcat/following{/other_user}","gists_url":"https://api.github.com/users/dozingcat/gists{/gist_id}","starred_url":"https://api.github.com/users/dozingcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dozingcat/subscriptions","organizations_url":"https://api.github.com/users/dozingcat/orgs","repos_url":"https://api.github.com/users/dozingcat/repos","events_url":"https://api.github.com/users/dozingcat/events{/privacy}","received_events_url":"https://api.github.com/users/dozingcat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dozingcat/material2","description":"Material Design components for Angular 2","fork":true,"url":"https://api.github.com/repos/dozingcat/material2","forks_url":"https://api.github.com/repos/dozingcat/material2/forks","keys_url":"https://api.github.com/repos/dozingcat/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dozingcat/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dozingcat/material2/teams","hooks_url":"https://api.github.com/repos/dozingcat/material2/hooks","issue_events_url":"https://api.github.com/repos/dozingcat/material2/issues/events{/number}","events_url":"https://api.github.com/repos/dozingcat/material2/events","assignees_url":"https://api.github.com/repos/dozingcat/material2/assignees{/user}","branches_url":"https://api.github.com/repos/dozingcat/material2/branches{/branch}","tags_url":"https://api.github.com/repos/dozingcat/material2/tags","blobs_url":"https://api.github.com/repos/dozingcat/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dozingcat/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dozingcat/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dozingcat/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dozingcat/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/dozingcat/material2/languages","stargazers_url":"https://api.github.com/repos/dozingcat/material2/stargazers","contributors_url":"https://api.github.com/repos/dozingcat/material2/contributors","subscribers_url":"https://api.github.com/repos/dozingcat/material2/subscribers","subscription_url":"https://api.github.com/repos/dozingcat/material2/subscription","commits_url":"https://api.github.com/repos/dozingcat/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dozingcat/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dozingcat/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dozingcat/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dozingcat/material2/contents/{+path}","compare_url":"https://api.github.com/repos/dozingcat/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dozingcat/material2/merges","archive_url":"https://api.github.com/repos/dozingcat/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dozingcat/material2/downloads","issues_url":"https://api.github.com/repos/dozingcat/material2/issues{/number}","pulls_url":"https://api.github.com/repos/dozingcat/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/dozingcat/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/dozingcat/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dozingcat/material2/labels{/name}","releases_url":"https://api.github.com/repos/dozingcat/material2/releases{/id}","deployments_url":"https://api.github.com/repos/dozingcat/material2/deployments","created_at":"2016-03-13T04:44:56Z","updated_at":"2016-03-13T04:44:57Z","pushed_at":"2016-07-26T04:06:28Z","git_url":"git://github.com/dozingcat/material2.git","ssh_url":"git@github.com:dozingcat/material2.git","clone_url":"https://github.com/dozingcat/material2.git","svn_url":"https://github.com/dozingcat/material2","homepage":"","size":1299,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"839122c784114128ddda02d6e3e035f710170f94","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"name":"material2","full_name":"angular/material2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular 2","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2016-07-26T19:25:34Z","pushed_at":"2016-07-26T19:15:20Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io/","size":1903,"stargazers_count":3310,"watchers_count":3310,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":562,"mirror_url":null,"open_issues_count":128,"forks":562,"open_issues":128,"watchers":3310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/918"},"html":{"href":"https://github.com/angular/material2/pull/918"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/918"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/918/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/918/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/918/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/d60b1d1eb6253ae8f246feacd246c6e11d48b6ed"}}}}
{"actor":{"display_login":"jelbourn"}}