{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/73612462","id":73612462,"diff_hunk":"@@ -19,7 +20,7 @@ export default class PostsFromSubreddit extends BaseHandler {\n       multi,\n       multiUser,\n       sort,\n-      t,\n+      t: listingTime(queryParams, sort),","path":"src/app/router/handlers/PostsFromSubreddit.js","position":20,"original_position":20,"commit_id":"1473013ab81e965a1362b6b2cdb5719a70245e77","original_commit_id":"1473013ab81e965a1362b6b2cdb5719a70245e77","user":{"login":"nramadas","id":1679892,"avatar_url":"https://avatars.githubusercontent.com/u/1679892?v=3","gravatar_id":"","url":"https://api.github.com/users/nramadas","html_url":"https://github.com/nramadas","followers_url":"https://api.github.com/users/nramadas/followers","following_url":"https://api.github.com/users/nramadas/following{/other_user}","gists_url":"https://api.github.com/users/nramadas/gists{/gist_id}","starred_url":"https://api.github.com/users/nramadas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nramadas/subscriptions","organizations_url":"https://api.github.com/users/nramadas/orgs","repos_url":"https://api.github.com/users/nramadas/repos","events_url":"https://api.github.com/users/nramadas/events{/privacy}","received_events_url":"https://api.github.com/users/nramadas/received_events","type":"User","site_admin":false},"body":"could we name this `time` instead of `t`?","created_at":"2016-08-04T22:15:57Z","updated_at":"2016-08-04T22:15:57Z","html_url":"https://github.com/reddit/reddit-mobile/pull/665#discussion_r73612462","pull_request_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/665","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/73612462"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/665#discussion_r73612462"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/665"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/665","id":79977835,"html_url":"https://github.com/reddit/reddit-mobile/pull/665","diff_url":"https://github.com/reddit/reddit-mobile/pull/665.diff","patch_url":"https://github.com/reddit/reddit-mobile/pull/665.patch","issue_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/665","number":665,"state":"open","locked":false,"title":"Sort and Time selectors. Doesn't include comment tree updates.","user":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"body":"(edit: widgets patch merged, no longer dependent)\r\n\r\nThis patch adds sorting and time filtering selectors for lists of posts and comments. Comments don't completely work, but are included to get an MVP of this feature into 2X. Comments will need some api work, because the comment tree is stored ad-hoc in each individual comments' `.replies` field. e.g. Go to a comments page sorted by best (a), change sort to top (b), and then back to best (c). You may notice on page (c) that some comment replies aren't ordered the same as page (a) even though they have the same exact sort.","created_at":"2016-08-03T20:58:39Z","updated_at":"2016-08-04T22:15:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c4ef465ce65b897968eadf2a22484b7242d8449","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/665/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/665/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/665/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/1473013ab81e965a1362b6b2cdb5719a70245e77","head":{"label":"schwers:2X-sorts","ref":"2X-sorts","sha":"1473013ab81e965a1362b6b2cdb5719a70245e77","user":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"repo":{"id":46595984,"name":"reddit-mobile","full_name":"schwers/reddit-mobile","owner":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schwers/reddit-mobile","description":"","fork":true,"url":"https://api.github.com/repos/schwers/reddit-mobile","forks_url":"https://api.github.com/repos/schwers/reddit-mobile/forks","keys_url":"https://api.github.com/repos/schwers/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schwers/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schwers/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/schwers/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/schwers/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/schwers/reddit-mobile/events","assignees_url":"https://api.github.com/repos/schwers/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/schwers/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/schwers/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/schwers/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schwers/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schwers/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/schwers/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schwers/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/schwers/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/schwers/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/schwers/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/schwers/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/schwers/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/schwers/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/schwers/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/schwers/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/schwers/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/schwers/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/schwers/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schwers/reddit-mobile/merges","archive_url":"https://api.github.com/repos/schwers/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schwers/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/schwers/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/schwers/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/schwers/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/schwers/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schwers/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/schwers/reddit-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/schwers/reddit-mobile/deployments","created_at":"2015-11-21T01:25:16Z","updated_at":"2016-01-11T22:32:21Z","pushed_at":"2016-08-04T22:10:01Z","git_url":"git://github.com/schwers/reddit-mobile.git","ssh_url":"git@github.com:schwers/reddit-mobile.git","clone_url":"https://github.com/schwers/reddit-mobile.git","svn_url":"https://github.com/schwers/reddit-mobile","homepage":null,"size":6909,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reddit:2X","ref":"2X","sha":"33ad19e6da14182b5c6552e419afb6b881839f0d","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":23087554,"name":"reddit-mobile","full_name":"reddit/reddit-mobile","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-mobile","description":"","fork":false,"url":"https://api.github.com/repos/reddit/reddit-mobile","forks_url":"https://api.github.com/repos/reddit/reddit-mobile/forks","keys_url":"https://api.github.com/repos/reddit/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-mobile/events","assignees_url":"https://api.github.com/repos/reddit/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-mobile/merges","archive_url":"https://api.github.com/repos/reddit/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/reddit-mobile/deployments","created_at":"2014-08-18T21:42:05Z","updated_at":"2016-08-03T10:35:02Z","pushed_at":"2016-08-04T18:06:33Z","git_url":"git://github.com/reddit/reddit-mobile.git","ssh_url":"git@github.com:reddit/reddit-mobile.git","clone_url":"https://github.com/reddit/reddit-mobile.git","svn_url":"https://github.com/reddit/reddit-mobile","homepage":null,"size":10223,"stargazers_count":826,"watchers_count":826,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"open_issues_count":16,"forks":131,"open_issues":16,"watchers":826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/665"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/665"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/665"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/665/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/665/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/665/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-mobile/statuses/1473013ab81e965a1362b6b2cdb5719a70245e77"}}}}
{"actor":{"display_login":"nramadas"}}