{"push_id":1049301414,"size":3,"distinct_size":3,"ref":"refs/heads/1.x","head":"8a7c5e662208661dda257082a72c049d62ba8218","before":"f0a4fa678465491947554f6687c5fca5e482f8ec","commits":[{"sha":"d455b52e6b88eb2e3a0c5fea127f73a86259cbd5","author":{"email":"28396b212d27fd2061a71151f9f1653611410c02@epitech.eu","name":"chalasr"},"message":"Clarify exception message in Twig_Template::getAttribute\n\nAdd missing parenthesis\n\nAdapt twig.c extension\n\nUpdate the C extension\n\nUse php_ucfirst instead of ucfirst\n\nTry to implement a TWIG_UCFIRST in C extension\n\nLast try ucfirst\n\nRollback twig.c extension\n\nRemove useless ucfirst + update twig.c extension\n\nFix mis-escaped char\n\nRepeat argument item for sprintf (first try doesnt work)\n\nRemove unexpected breakline in code","distinct":true,"url":"https://api.github.com/repos/brendanmurty/Twig/commits/d455b52e6b88eb2e3a0c5fea127f73a86259cbd5"},{"sha":"3d0afc03892719b7eaa5f2b8d93260a79f8c578e","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"feature #2009 Clarify exception message in Twig_Template::getAttribute (chalasr)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\nClarify exception message in Twig_Template::getAttribute\n\nWhen a non existing property/method is called for an object, the exception message is:\n\n>  Method \"property()\" for object \"[class]\" does not exist in [template]\"\n\nBut in fact the `Twig_Template::getAttribute()` method check for (at least) 3 more methods (`isProperty()`, `getProperty()` and `__call__()`).\n\nIt could be more adapted and easier to be debugged if the message would be:\n\n> Neither the property \"property\" nor one of the methods \"property]()\", \"getProperty()\"/\"isPropertyt()\" or \"__call()\" exist and have public access in class \"[class]\" in [template]\n\nThis message is mostly inspired from the one used in the PropertyAccess component.\n\nBTW I think that it would be great to replace all the checks listed above by a `PropertyAccessor::isReadable([property])`.\nI can work on a PR if it's not overkill.\n\nCommits\n-------\n\nd455b52 Clarify exception message in Twig_Template::getAttribute","distinct":true,"url":"https://api.github.com/repos/brendanmurty/Twig/commits/3d0afc03892719b7eaa5f2b8d93260a79f8c578e"},{"sha":"8a7c5e662208661dda257082a72c049d62ba8218","author":{"email":"d88b10c6bc7c38a4ffb541994aef7d8a7f8e3819@murty.id.au","name":"Brendan Murty"},"message":"Merge pull request #1 from twigphp/1.x\n\nBring in changes from upstream","distinct":true,"url":"https://api.github.com/repos/brendanmurty/Twig/commits/8a7c5e662208661dda257082a72c049d62ba8218"}]}