{"action":"created","issue":{"url":"https://api.github.com/repos/freeorion/freeorion-sdk/issues/17","repository_url":"https://api.github.com/repos/freeorion/freeorion-sdk","labels_url":"https://api.github.com/repos/freeorion/freeorion-sdk/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/freeorion/freeorion-sdk/issues/17/comments","events_url":"https://api.github.com/repos/freeorion/freeorion-sdk/issues/17/events","html_url":"https://github.com/freeorion/freeorion-sdk/issues/17","id":186544909,"number":17,"title":"MSVC 2015 FreeOrion build fails","user":{"login":"geoffthemedio","id":11386908,"avatar_url":"https://avatars.githubusercontent.com/u/11386908?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffthemedio","html_url":"https://github.com/geoffthemedio","followers_url":"https://api.github.com/users/geoffthemedio/followers","following_url":"https://api.github.com/users/geoffthemedio/following{/other_user}","gists_url":"https://api.github.com/users/geoffthemedio/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffthemedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffthemedio/subscriptions","organizations_url":"https://api.github.com/users/geoffthemedio/orgs","repos_url":"https://api.github.com/users/geoffthemedio/repos","events_url":"https://api.github.com/users/geoffthemedio/events{/privacy}","received_events_url":"https://api.github.com/users/geoffthemedio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-11-01T14:18:03Z","updated_at":"2016-11-04T09:01:41Z","closed_at":null,"body":"Just generated the SDK (with the MSVC 2015 compiler), unpacked it, and ran the bootstrap to get the freeorion code, then loaded the MSVC 2013 project files in MSVC 2015). I then tried to build freeorion. Most of it compiles, but I'm getting some errors, mostly in boost serialization stuff...\r\n````\r\nSeverity\tCode\tDescription\tProject\tFile\tLine\tSuppression State\r\nError\tC2996\t'Deserialize': recursive function template definition\tFreeOrionD\tC:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\FreeOrion\\server\\SaveLoad.cpp\t485\t\r\nError\tC2996\t'CombatEvent::serialize': recursive function template definition\tCommon\tC:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\FreeOrion\\combat\\CombatEvents.cpp\t1056\t\r\nError\tC2996\t'CombatEvent::serialize': recursive function template definition\tCommon\tC:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\FreeOrion\\combat\\CombatEvents.cpp\t1056\t\r\nError\tC2064\tterm does not evaluate to a function taking 0 arguments (compiling source file ..\\..\\network\\ServerNetworking.cpp)\tFreeOrionD\tC:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\Boost\\include\\boost\\function\\function_template.hpp\t159\t\r\nError\tC2064\tterm does not evaluate to a function taking 0 arguments (compiling source file ..\\..\\network\\ServerNetworking.cpp)\tFreeOrionD\tC:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\Boost\\include\\boost\\function\\function_template.hpp\t159\t\r\nError\tC2996\t'Serialize': recursive function template definition\tFreeOrionD\tC:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\FreeOrion\\server\\SaveLoad.cpp\t485\t\r\nError\tC2996\t'Serialize': recursive function template definition\tFreeOrionD\tC:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\FreeOrion\\server\\SaveLoad.cpp\t485\t\r\nError\tC2996\t'Deserialize': recursive function template definition\tFreeOrionD\tC:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\FreeOrion\\server\\SaveLoad.cpp\t485\t\r\n````\r\nNot sure if you want such errors here in the SDK, but I wondering if using a newer version of boost (currently it downloads 1.59) might help...\r\n\r\nThere are also some possibly relevant warnings...\r\n````\r\n1>C:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\Boost\\include\\boost/asio/detail/config.hpp(227): warning C4005: 'BOOST_ASIO_ERROR_CATEGORY_NOEXCEPT': macro redefinition\r\n1>         C:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\Boost\\include\\boost/asio/detail/config.hpp(213): note: see previous definition of 'BOOST_ASIO_ERROR_CATEGORY_NOEXCEPT'\r\n1>     1>\r\n3>C:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\Boost\\include\\boost/asio/detail/config.hpp(227): warning C4005: 'BOOST_ASIO_ERROR_CATEGORY_NOEXCEPT': macro redefinition (compiling source file ..\\..\\network\\ServerNetworking.cpp)\r\n3>         C:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\Boost\\include\\boost/asio/detail/config.hpp(213): note: see previous definition of 'BOOST_ASIO_ERROR_CATEGORY_NOEXCEPT' (compiling source file ..\\..\\network\\ServerNetworking.cpp)\r\n3>     1>\r\n3>C:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\Boost\\include\\boost/asio/detail/config.hpp(227): warning C4005: 'BOOST_ASIO_ERROR_CATEGORY_NOEXCEPT': macro redefinition (compiling source file ..\\..\\server\\SaveLoad.cpp)\r\n3>         C:\\Users\\Geoff\\Desktop\\FreeOrionSDK_MSVC-_2016-11-01\\Boost\\include\\boost/asio/detail/config.hpp(213): note: see previous definition of 'BOOST_ASIO_ERROR_CATEGORY_NOEXCEPT' (compiling source file ..\\..\\server\\SaveLoad.cpp)\r\n3>     1>\r\n````\r\nWhich appear to be fixed in 1.60: https://github.com/boostorg/asio/commit/b9cb61416e1972d7490d91da91df549703fb0fef\r\nhttps://github.com/boostorg/asio/pull/22"},"comment":{"url":"https://api.github.com/repos/freeorion/freeorion-sdk/issues/comments/258376044","html_url":"https://github.com/freeorion/freeorion-sdk/issues/17#issuecomment-258376044","issue_url":"https://api.github.com/repos/freeorion/freeorion-sdk/issues/17","id":258376044,"user":{"login":"adrianbroher","id":84891,"avatar_url":"https://avatars.githubusercontent.com/u/84891?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianbroher","html_url":"https://github.com/adrianbroher","followers_url":"https://api.github.com/users/adrianbroher/followers","following_url":"https://api.github.com/users/adrianbroher/following{/other_user}","gists_url":"https://api.github.com/users/adrianbroher/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianbroher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianbroher/subscriptions","organizations_url":"https://api.github.com/users/adrianbroher/orgs","repos_url":"https://api.github.com/users/adrianbroher/repos","events_url":"https://api.github.com/users/adrianbroher/events{/privacy}","received_events_url":"https://api.github.com/users/adrianbroher/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T09:01:41Z","updated_at":"2016-11-04T09:01:41Z","body":"> The version string needs updating, as it still said MSVC 2013. I'm not sure where / how to set that.\r\n\r\nEdit the custom commands in the common project for the `util/Version.cpp.in` file."}}
{"actor":{"display_login":"adrianbroher"}}