{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/5503","repository_url":"https://api.github.com/repos/Automattic/jetpack","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/5503/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/5503/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/5503/events","html_url":"https://github.com/Automattic/jetpack/pull/5503","id":187172422,"number":5503,"title":"In progress: Remove post limit on sitemap","user":{"login":"nbloomf","id":9310939,"avatar_url":"https://avatars.githubusercontent.com/u/9310939?v=3","gravatar_id":"","url":"https://api.github.com/users/nbloomf","html_url":"https://github.com/nbloomf","followers_url":"https://api.github.com/users/nbloomf/followers","following_url":"https://api.github.com/users/nbloomf/following{/other_user}","gists_url":"https://api.github.com/users/nbloomf/gists{/gist_id}","starred_url":"https://api.github.com/users/nbloomf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbloomf/subscriptions","organizations_url":"https://api.github.com/users/nbloomf/orgs","repos_url":"https://api.github.com/users/nbloomf/repos","events_url":"https://api.github.com/users/nbloomf/events{/privacy}","received_events_url":"https://api.github.com/users/nbloomf/received_events","type":"User","site_admin":false},"labels":[{"id":306719875,"url":"https://api.github.com/repos/Automattic/jetpack/labels/Sitemaps","name":"Sitemaps","color":"006b75","default":false},{"id":136297617,"url":"https://api.github.com/repos/Automattic/jetpack/labels/Trial%20Project","name":"Trial Project","color":"d5ad6f","default":false},{"id":470168891,"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Pri]%20Normal","name":"[Pri] Normal","color":"fad8c7","default":false},{"id":136599217,"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20In%20Progress","name":"[Status] In Progress","color":"ededed","default":false},{"id":70896534,"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/67","html_url":"https://github.com/Automattic/jetpack/milestone/67","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/67/labels","id":2163955,"number":67,"title":"4.6","description":"Settings UI ","creator":{"login":"dereksmart","id":7129409,"avatar_url":"https://avatars.githubusercontent.com/u/7129409?v=3","gravatar_id":"","url":"https://api.github.com/users/dereksmart","html_url":"https://github.com/dereksmart","followers_url":"https://api.github.com/users/dereksmart/followers","following_url":"https://api.github.com/users/dereksmart/following{/other_user}","gists_url":"https://api.github.com/users/dereksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/dereksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereksmart/subscriptions","organizations_url":"https://api.github.com/users/dereksmart/orgs","repos_url":"https://api.github.com/users/dereksmart/repos","events_url":"https://api.github.com/users/dereksmart/events{/privacy}","received_events_url":"https://api.github.com/users/dereksmart/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":0,"state":"open","created_at":"2016-11-29T15:53:42Z","updated_at":"2016-12-07T18:45:22Z","due_on":"2017-02-08T00:00:00Z","closed_at":null},"comments":7,"created_at":"2016-11-03T19:51:21Z","updated_at":"2016-12-08T03:25:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/5503","html_url":"https://github.com/Automattic/jetpack/pull/5503","diff_url":"https://github.com/Automattic/jetpack/pull/5503.diff","patch_url":"https://github.com/Automattic/jetpack/pull/5503.patch"},"body":"Addresses #3314: Remove 1000 post limit on sitemaps.\r\n\r\n#### Changes proposed in this Pull Request:\r\nReplace sitemap generating code.\r\n\r\nNote that this PR is an update of [5394](https://github.com/Automattic/jetpack/pull/5394), which became broken after a messed up git merge.\r\n\r\n#### Testing instructions:\r\n1. Create some posts and upload some images (see [FakerPress](https://wordpress.org/plugins/fakerpress/)). Make sure some of them have a recent (<=2 day old) timestamp.\r\n2. Activate the sitemaps module of Jetpack.\r\n3. Set permalinks to \"pretty\" (doesn't matter what structure)\r\n4. Go to `example.com/news-sitemap.xml`.\r\n5. Go to `example.com/sitemap.xml`. (It may take a refresh or two the first time.)\r\n6. Set pemalinks to \"plain\"\r\n7. Go to `example.com/?jetpack-sitemap=sitemap.xml` and `example.com/?jetpack-sitemap=news-sitemap.xml`\r\n\r\nThese changes allow for arbitrarily large sitemap trees per the [spec](sitemaps.org). To test this functionality without having to create an arbitrarily large site, adjust the constant `SITEMAP_MAX_ITEMS` in `modules/sitemaps/sitemap-builder.php`, (5 is a good value.) This constant determines the maximum number of URLs on a single sitemap, so that if it's set to 5 and we have 6 posts/pages then the tree structure kicks in.\r\n\r\nThe constant `SITEMAP_INTERVAL` in `modules/sitemaps/sitemaps.php` is the minimum number of seconds between rebuilds; it's currently set to 60 for testing.\r\n\r\nPast issues:\r\n* [4093](https://github.com/Automattic/jetpack/pull/4093) (Support PATHINFO permalinks): This module should, at the URL `example.com/index.php/sitemap.xml`.\r\n\r\n<!-- Add the following only if this is meant to be in changelog -->\r\n#### Proposed changelog entry for your changes:\r\n\r\nNew filters:\r\n* `jetpack_sitemap_image_skip_post`: For selectively excluding images from the sitemap.\r\n* `jetpack_sitemap_image_sitemap_item`: For manipulating the XML of image entries in the sitemap.\r\n* `jetpack_sitemap_news_ns`: Add XML namespaces for the news sitemap.\r\n* `jetpack_sitemap_image_ns`: Add XML namespaces for image sitemaps.\r\n\r\nFilters with changed behavior:\r\n* `jetpack_sitemap_location`\r\n\r\n---\r\n- [ ] Make sure your changes respect [WordPress' coding standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/).\r\n- [x] Did you make changes, or create a **new .js file**? If [Gulp](http://gulpjs.com/) is installed on your testing environment, run `gulp js:hint` before to commit your changes. It will allow you to [detect errors in Javascript files](http://jshint.com/about/).\r\n- [x] Did you create a **new action or filter**? [Add inline documentation](https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#4-hooks-actions-and-filters) to help others understand how to use the action or the filter.\r\n- [x] Create **[unit tests](https://github.com/Automattic/jetpack/tree/master/tests)** if you can. If you're not familiar with Unit Testing, you can check [this tutorial](https://pippinsplugins.com/series/unit-tests-wordpress-plugins/).\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/265643324","html_url":"https://github.com/Automattic/jetpack/pull/5503#issuecomment-265643324","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/5503","id":265643324,"user":{"login":"eliorivero","id":1041600,"avatar_url":"https://avatars.githubusercontent.com/u/1041600?v=3","gravatar_id":"","url":"https://api.github.com/users/eliorivero","html_url":"https://github.com/eliorivero","followers_url":"https://api.github.com/users/eliorivero/followers","following_url":"https://api.github.com/users/eliorivero/following{/other_user}","gists_url":"https://api.github.com/users/eliorivero/gists{/gist_id}","starred_url":"https://api.github.com/users/eliorivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliorivero/subscriptions","organizations_url":"https://api.github.com/users/eliorivero/orgs","repos_url":"https://api.github.com/users/eliorivero/repos","events_url":"https://api.github.com/users/eliorivero/events{/privacy}","received_events_url":"https://api.github.com/users/eliorivero/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T03:25:13Z","updated_at":"2016-12-08T03:25:13Z","body":"Oh I see, then it's ok to leave the names as they are now.\r\n\r\nThis is great, really good work. You've been very responsive to the requests and thoughtful on the changes.\r\n\r\nI'm not sure how your trial continues but for now I think this is done. 🐑 "}}
{"actor":{"display_login":"eliorivero"}}