{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7910","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7910/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7910/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7910/events","html_url":"https://github.com/bitcoin/bitcoin/pull/7910","id":149494174,"number":7910,"title":"Segregated witness","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Consensus","name":"Consensus","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2016-04-19T15:22:33Z","updated_at":"2016-06-14T07:19:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7910","html_url":"https://github.com/bitcoin/bitcoin/pull/7910","diff_url":"https://github.com/bitcoin/bitcoin/pull/7910.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7910.patch"},"body":"This is the complete code for segregated witness on top of master (implementing BIP141, BIP143, BIP144, BIP145). Apart from commentary and merging (see further), the code is never rewritten/squashed/rebased, in order not to invalidate review. A rebased/squashed version is available here: #8149.\r\n\r\nSee also the detailed and up-to-date list of commits here: https://github.com/bitcoin/bitcoin/pull/7910#issuecomment-211998958\r\n\r\nThere are certainly some items left to do:\r\n- [x] Incorporate changes to BIP145/BIP9 when finalized (see https://github.com/bitcoin/bips/pull/365)\r\n- [x] Define a deployment time for testnet\r\n- [x] Seed nodes that provide segwit-capable peers\r\n- [ ] Do tests in a mixed network of upgraded and non-upgraded nodes\r\n- [x] Remove segnet from mainline merge\r\n- [ ] Define a deployment time for mainnet\r\n- [ ] Per-transaction caching of sighashes to fix the O(n^2) sighash problem (see https://github.com/sipa/bitcoin/pull/70)\r\n\r\nMany thanks to all contributors so far (including @jl2012, @NicolasDorier, @CodeShark, @sdaftuar, @morcos, @luke-jr, @afk11, @theuni, @TheBlueMatt, @MarcoFalke, @LongShao007, @jonasnick, @mruddy), the ideas it is based on (by @gmaxwell and @luke-jr), and many reviewers (including @SergioDemianLerner, @instagibbs, @dcousens, and @btcdrak).\r\n"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/225799237","html_url":"https://github.com/bitcoin/bitcoin/pull/7910#issuecomment-225799237","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7910","id":225799237,"user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T07:19:32Z","updated_at":"2016-06-14T07:19:32Z","body":"PROTOCOL_VERSION is indeed unused, so it doesn't matter. I'll change it for consistency.\n\nLonger term, I think the nSerType/nVersion should be replaced by a context object that encapsulates serialization parameters (for example, there could be a TransactionSerializationContext with a boolean fWitness, and a BlockSerializationContext that inherits from TransactionSerializationContext etc)."}}
{"actor":{"display_login":"sipa"}}