{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/57722911","id":57722911,"diff_hunk":"@@ -3,11 +3,70 @@ Guidelines for Contributing\n \n Welcome to the D community and thanks for your interest in contributing! To get started, please read the [Starting as a Contributor](http://wiki.dlang.org/Starting_as_a_Contributor) article on the D Wiki.\n \n-More Links\n-----------\n-\n-* Fork [on Github](https://github.com/D-Programming-Language/phobos)\n-* Use our [Bugzilla bug tracker](http://d.puremagic.com/issues/)\n-* Follow the [Styleguide](http://dlang.org/dstyle.html)\n-* Participate in [our forum](http://forum.dlang.org/)\n-* Review Phobos additions in the [Review Queue](http://wiki.dlang.org/Review_Queue).\n\\ No newline at end of file\n+Quick links\n+-----------\n+\n+- Fork [on Github](https://github.com/D-Programming-Language/phobos)\n+- Use our [Bugzilla bug tracker](http://d.puremagic.com/issues/)\n+- Follow the [Styleguide](http://dlang.org/dstyle.html)\n+- Participate in [our forum](http://forum.dlang.org/)\n+- Ask questions on `#d` ([Web interface](https://kiwiirc.com/client/irc.freenode.net/d))\n+- Review Phobos additions in the [Review Queue](http://wiki.dlang.org/Review_Queue)\n+\n+How to make a good submission?\n+------------------------------\n+\n+The usual workflow is:\n+\n+1. [Fork](https://help.github.com/articles/fork-a-repo/) [Phobos](https://github.com/D-Programming-Language/phobos) on Github\n+2. Create your [own branch](https://github.com/Kunena/Kunena-Forum/wiki/Create-a-new-branch-with-git-and-manage-branches)\n+3. Work locally on your new feature or fix (see the tips below)\n+4. Submit your [pull request](https://help.github.com/articles/creating-a-pull-request/)\n+\n+Below is a list of tips and checks that you should consider before opening your PR:\n+\n+### Code\n+\n+- Don't add `@nogc`, `@pure`, `@safe`, `nothrow` attributes yourself - let the compiler infer it! However add unittest check for these attributes if possible","path":"CONTRIBUTING.md","position":37,"original_position":37,"commit_id":"dc18236ee1e533f6ebb07ba0f00bae472c970566","original_commit_id":"dc18236ee1e533f6ebb07ba0f00bae472c970566","user":{"login":"ZombineDev","id":3475150,"avatar_url":"https://avatars.githubusercontent.com/u/3475150?v=3","gravatar_id":"","url":"https://api.github.com/users/ZombineDev","html_url":"https://github.com/ZombineDev","followers_url":"https://api.github.com/users/ZombineDev/followers","following_url":"https://api.github.com/users/ZombineDev/following{/other_user}","gists_url":"https://api.github.com/users/ZombineDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ZombineDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZombineDev/subscriptions","organizations_url":"https://api.github.com/users/ZombineDev/orgs","repos_url":"https://api.github.com/users/ZombineDev/repos","events_url":"https://api.github.com/users/ZombineDev/events{/privacy}","received_events_url":"https://api.github.com/users/ZombineDev/received_events","type":"User","site_admin":false},"body":"All those attributes should be put on non-templated functions manually. You should make it clear that the above statement only applies to templates.","created_at":"2016-03-29T13:33:05Z","updated_at":"2016-03-29T13:33:05Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/4128#discussion_r57722911","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/4128","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/57722911"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/4128#discussion_r57722911"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/4128"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/4128","id":64456587,"html_url":"https://github.com/D-Programming-Language/phobos/pull/4128","diff_url":"https://github.com/D-Programming-Language/phobos/pull/4128.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/4128.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/4128","number":4128,"state":"open","locked":false,"title":"Improve contribution guide","user":{"login":"greenify","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/greenify","html_url":"https://github.com/greenify","followers_url":"https://api.github.com/users/greenify/followers","following_url":"https://api.github.com/users/greenify/following{/other_user}","gists_url":"https://api.github.com/users/greenify/gists{/gist_id}","starred_url":"https://api.github.com/users/greenify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenify/subscriptions","organizations_url":"https://api.github.com/users/greenify/orgs","repos_url":"https://api.github.com/users/greenify/repos","events_url":"https://api.github.com/users/greenify/events{/privacy}","received_events_url":"https://api.github.com/users/greenify/received_events","type":"User","site_admin":false},"body":"In reference to [the forum thread](http://forum.dlang.org/post/jjigfhwklliwwrbqcbbb@forum.dlang.org), I propose some hints and advice for new contributors. The current list resembles stuff that I learned over the last weeks, feel fee to add your own insights ;-)\r\nThis guide should also inform new users about undocumented (or hard to find) policies like pinging people or `std.experimental`.\r\n\r\nI used `-` for all bullets as the Github markdown checklist syntax only supports `- [ ]` and I wanted to have only one type\r\n\r\n[Preview](https://github.com/greenify/phobos/blob/improve_contribution_guide/CONTRIBUTING.md).","created_at":"2016-03-29T12:23:36Z","updated_at":"2016-03-29T13:33:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2b839f5788d6bcf5e021cde8ca868de72ac8954","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/4128/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/4128/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/4128/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/dc18236ee1e533f6ebb07ba0f00bae472c970566","head":{"label":"greenify:improve_contribution_guide","ref":"improve_contribution_guide","sha":"dc18236ee1e533f6ebb07ba0f00bae472c970566","user":{"login":"greenify","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/greenify","html_url":"https://github.com/greenify","followers_url":"https://api.github.com/users/greenify/followers","following_url":"https://api.github.com/users/greenify/following{/other_user}","gists_url":"https://api.github.com/users/greenify/gists{/gist_id}","starred_url":"https://api.github.com/users/greenify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenify/subscriptions","organizations_url":"https://api.github.com/users/greenify/orgs","repos_url":"https://api.github.com/users/greenify/repos","events_url":"https://api.github.com/users/greenify/events{/privacy}","received_events_url":"https://api.github.com/users/greenify/received_events","type":"User","site_admin":false},"repo":{"id":52009651,"name":"phobos","full_name":"greenify/phobos","owner":{"login":"greenify","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/greenify","html_url":"https://github.com/greenify","followers_url":"https://api.github.com/users/greenify/followers","following_url":"https://api.github.com/users/greenify/following{/other_user}","gists_url":"https://api.github.com/users/greenify/gists{/gist_id}","starred_url":"https://api.github.com/users/greenify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenify/subscriptions","organizations_url":"https://api.github.com/users/greenify/orgs","repos_url":"https://api.github.com/users/greenify/repos","events_url":"https://api.github.com/users/greenify/events{/privacy}","received_events_url":"https://api.github.com/users/greenify/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greenify/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/greenify/phobos","forks_url":"https://api.github.com/repos/greenify/phobos/forks","keys_url":"https://api.github.com/repos/greenify/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenify/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenify/phobos/teams","hooks_url":"https://api.github.com/repos/greenify/phobos/hooks","issue_events_url":"https://api.github.com/repos/greenify/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/greenify/phobos/events","assignees_url":"https://api.github.com/repos/greenify/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/greenify/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/greenify/phobos/tags","blobs_url":"https://api.github.com/repos/greenify/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenify/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenify/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenify/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenify/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/greenify/phobos/languages","stargazers_url":"https://api.github.com/repos/greenify/phobos/stargazers","contributors_url":"https://api.github.com/repos/greenify/phobos/contributors","subscribers_url":"https://api.github.com/repos/greenify/phobos/subscribers","subscription_url":"https://api.github.com/repos/greenify/phobos/subscription","commits_url":"https://api.github.com/repos/greenify/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenify/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenify/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenify/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenify/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/greenify/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenify/phobos/merges","archive_url":"https://api.github.com/repos/greenify/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenify/phobos/downloads","issues_url":"https://api.github.com/repos/greenify/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/greenify/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/greenify/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/greenify/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenify/phobos/labels{/name}","releases_url":"https://api.github.com/repos/greenify/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/greenify/phobos/deployments","created_at":"2016-02-18T13:38:55Z","updated_at":"2016-03-08T13:03:37Z","pushed_at":"2016-03-29T13:03:53Z","git_url":"git://github.com/greenify/phobos.git","ssh_url":"git@github.com:greenify/phobos.git","clone_url":"https://github.com/greenify/phobos.git","svn_url":"https://github.com/greenify/phobos","homepage":"dlang.org/phobos","size":50032,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"15aa52af43cf6f51bc2559ee061a3cb4a4db74c4","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/D-Programming-Language/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-03-28T11:38:11Z","pushed_at":"2016-03-29T13:03:53Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":70514,"stargazers_count":689,"watchers_count":689,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":467,"mirror_url":null,"open_issues_count":94,"forks":467,"open_issues":94,"watchers":689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/4128"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/4128"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/4128"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/4128/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/4128/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/4128/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/dc18236ee1e533f6ebb07ba0f00bae472c970566"}}}}