{"action":"created","comment":{"url":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/comments/58711950","id":58711950,"diff_hunk":"@@ -211,13 +110,13 @@ private boolean isValidProcessDefinition(final String processDefinitionId) {\n      *\n      * @param webBonitaConstantsUtils\n      * @param processDefinitionId\n-     *            the process definition ID\n+     *        the process definition ID\n      * @return the config file or null if it doesn't exists\n      * @throws IOException\n      */\n-    protected File getProcessSecurityPropertiesFile(final WebBonitaConstantsUtils webBonitaConstantsUtils, final String processDefinitionId) {\n+    protected File getProcessSecurityPropertiesFile(final WebBonitaConstantsUtils webBonitaConstantsUtils, final ProcessIdentifier processDefinitionId) {","path":"common/src/main/java/org/bonitasoft/console/common/server/preferences/properties/SecurityProperties.java","position":191,"original_position":191,"commit_id":"51e09e6819b47575b7d32b83bdcb5a9cdf2b40f8","original_commit_id":"51e09e6819b47575b7d32b83bdcb5a9cdf2b40f8","user":{"login":"educhastenier","id":4921958,"avatar_url":"https://avatars.githubusercontent.com/u/4921958?v=3","gravatar_id":"","url":"https://api.github.com/users/educhastenier","html_url":"https://github.com/educhastenier","followers_url":"https://api.github.com/users/educhastenier/followers","following_url":"https://api.github.com/users/educhastenier/following{/other_user}","gists_url":"https://api.github.com/users/educhastenier/gists{/gist_id}","starred_url":"https://api.github.com/users/educhastenier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/educhastenier/subscriptions","organizations_url":"https://api.github.com/users/educhastenier/orgs","repos_url":"https://api.github.com/users/educhastenier/repos","events_url":"https://api.github.com/users/educhastenier/events{/privacy}","received_events_url":"https://api.github.com/users/educhastenier/received_events","type":"User","site_admin":false},"body":"wrong parameter name","created_at":"2016-04-06T14:13:50Z","updated_at":"2016-04-06T14:13:50Z","html_url":"https://github.com/bonitasoft/bonita-web/pull/249#discussion_r58711950","pull_request_url":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/249","_links":{"self":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/comments/58711950"},"html":{"href":"https://github.com/bonitasoft/bonita-web/pull/249#discussion_r58711950"},"pull_request":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/249"}}},"pull_request":{"url":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/249","id":65274640,"html_url":"https://github.com/bonitasoft/bonita-web/pull/249","diff_url":"https://github.com/bonitasoft/bonita-web/pull/249.diff","patch_url":"https://github.com/bonitasoft/bonita-web/pull/249.patch","issue_url":"https://api.github.com/repos/bonitasoft/bonita-web/issues/249","number":249,"state":"open","locked":false,"title":"feat(paas_ready): get all configuration from engine","user":{"login":"baptistemesta","id":2739234,"avatar_url":"https://avatars.githubusercontent.com/u/2739234?v=3","gravatar_id":"","url":"https://api.github.com/users/baptistemesta","html_url":"https://github.com/baptistemesta","followers_url":"https://api.github.com/users/baptistemesta/followers","following_url":"https://api.github.com/users/baptistemesta/following{/other_user}","gists_url":"https://api.github.com/users/baptistemesta/gists{/gist_id}","starred_url":"https://api.github.com/users/baptistemesta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baptistemesta/subscriptions","organizations_url":"https://api.github.com/users/baptistemesta/orgs","repos_url":"https://api.github.com/users/baptistemesta/repos","events_url":"https://api.github.com/users/baptistemesta/events{/privacy}","received_events_url":"https://api.github.com/users/baptistemesta/received_events","type":"User","site_admin":false},"body":"instead of reading it from the filesystem all configurations are get\r\nfrom the engine and put in the ConfigurationFilesManager\r\n\r\nThe PlatformTenantListener initialize it with configuration returned by\r\nthe platformApi","created_at":"2016-04-05T09:39:23Z","updated_at":"2016-04-06T14:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0649a3b758c924b7b0d88f1a6d23c6efd010bf75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/249/commits","review_comments_url":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/249/comments","review_comment_url":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-web/issues/249/comments","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-web/statuses/51e09e6819b47575b7d32b83bdcb5a9cdf2b40f8","head":{"label":"bonitasoft:feat/put_platform_conf_in_platform-setup","ref":"feat/put_platform_conf_in_platform-setup","sha":"51e09e6819b47575b7d32b83bdcb5a9cdf2b40f8","user":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"repo":{"id":11337147,"name":"bonita-web","full_name":"bonitasoft/bonita-web","owner":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonitasoft/bonita-web","description":"","fork":false,"url":"https://api.github.com/repos/bonitasoft/bonita-web","forks_url":"https://api.github.com/repos/bonitasoft/bonita-web/forks","keys_url":"https://api.github.com/repos/bonitasoft/bonita-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonitasoft/bonita-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonitasoft/bonita-web/teams","hooks_url":"https://api.github.com/repos/bonitasoft/bonita-web/hooks","issue_events_url":"https://api.github.com/repos/bonitasoft/bonita-web/issues/events{/number}","events_url":"https://api.github.com/repos/bonitasoft/bonita-web/events","assignees_url":"https://api.github.com/repos/bonitasoft/bonita-web/assignees{/user}","branches_url":"https://api.github.com/repos/bonitasoft/bonita-web/branches{/branch}","tags_url":"https://api.github.com/repos/bonitasoft/bonita-web/tags","blobs_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-web/statuses/{sha}","languages_url":"https://api.github.com/repos/bonitasoft/bonita-web/languages","stargazers_url":"https://api.github.com/repos/bonitasoft/bonita-web/stargazers","contributors_url":"https://api.github.com/repos/bonitasoft/bonita-web/contributors","subscribers_url":"https://api.github.com/repos/bonitasoft/bonita-web/subscribers","subscription_url":"https://api.github.com/repos/bonitasoft/bonita-web/subscription","commits_url":"https://api.github.com/repos/bonitasoft/bonita-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonitasoft/bonita-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonitasoft/bonita-web/contents/{+path}","compare_url":"https://api.github.com/repos/bonitasoft/bonita-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonitasoft/bonita-web/merges","archive_url":"https://api.github.com/repos/bonitasoft/bonita-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonitasoft/bonita-web/downloads","issues_url":"https://api.github.com/repos/bonitasoft/bonita-web/issues{/number}","pulls_url":"https://api.github.com/repos/bonitasoft/bonita-web/pulls{/number}","milestones_url":"https://api.github.com/repos/bonitasoft/bonita-web/milestones{/number}","notifications_url":"https://api.github.com/repos/bonitasoft/bonita-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonitasoft/bonita-web/labels{/name}","releases_url":"https://api.github.com/repos/bonitasoft/bonita-web/releases{/id}","deployments_url":"https://api.github.com/repos/bonitasoft/bonita-web/deployments","created_at":"2013-07-11T08:39:00Z","updated_at":"2016-03-23T05:19:07Z","pushed_at":"2016-04-06T14:06:10Z","git_url":"git://github.com/bonitasoft/bonita-web.git","ssh_url":"git@github.com:bonitasoft/bonita-web.git","clone_url":"https://github.com/bonitasoft/bonita-web.git","svn_url":"https://github.com/bonitasoft/bonita-web","homepage":"http://community.bonitasoft.com/","size":96053,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":4,"forks":31,"open_issues":4,"watchers":13,"default_branch":"master"}},"base":{"label":"bonitasoft:PaaS_ready","ref":"PaaS_ready","sha":"440c882f7fedb70a44023384cca7ac074bb5ccb3","user":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"repo":{"id":11337147,"name":"bonita-web","full_name":"bonitasoft/bonita-web","owner":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonitasoft/bonita-web","description":"","fork":false,"url":"https://api.github.com/repos/bonitasoft/bonita-web","forks_url":"https://api.github.com/repos/bonitasoft/bonita-web/forks","keys_url":"https://api.github.com/repos/bonitasoft/bonita-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonitasoft/bonita-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonitasoft/bonita-web/teams","hooks_url":"https://api.github.com/repos/bonitasoft/bonita-web/hooks","issue_events_url":"https://api.github.com/repos/bonitasoft/bonita-web/issues/events{/number}","events_url":"https://api.github.com/repos/bonitasoft/bonita-web/events","assignees_url":"https://api.github.com/repos/bonitasoft/bonita-web/assignees{/user}","branches_url":"https://api.github.com/repos/bonitasoft/bonita-web/branches{/branch}","tags_url":"https://api.github.com/repos/bonitasoft/bonita-web/tags","blobs_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-web/statuses/{sha}","languages_url":"https://api.github.com/repos/bonitasoft/bonita-web/languages","stargazers_url":"https://api.github.com/repos/bonitasoft/bonita-web/stargazers","contributors_url":"https://api.github.com/repos/bonitasoft/bonita-web/contributors","subscribers_url":"https://api.github.com/repos/bonitasoft/bonita-web/subscribers","subscription_url":"https://api.github.com/repos/bonitasoft/bonita-web/subscription","commits_url":"https://api.github.com/repos/bonitasoft/bonita-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonitasoft/bonita-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonitasoft/bonita-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonitasoft/bonita-web/contents/{+path}","compare_url":"https://api.github.com/repos/bonitasoft/bonita-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonitasoft/bonita-web/merges","archive_url":"https://api.github.com/repos/bonitasoft/bonita-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonitasoft/bonita-web/downloads","issues_url":"https://api.github.com/repos/bonitasoft/bonita-web/issues{/number}","pulls_url":"https://api.github.com/repos/bonitasoft/bonita-web/pulls{/number}","milestones_url":"https://api.github.com/repos/bonitasoft/bonita-web/milestones{/number}","notifications_url":"https://api.github.com/repos/bonitasoft/bonita-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonitasoft/bonita-web/labels{/name}","releases_url":"https://api.github.com/repos/bonitasoft/bonita-web/releases{/id}","deployments_url":"https://api.github.com/repos/bonitasoft/bonita-web/deployments","created_at":"2013-07-11T08:39:00Z","updated_at":"2016-03-23T05:19:07Z","pushed_at":"2016-04-06T14:06:10Z","git_url":"git://github.com/bonitasoft/bonita-web.git","ssh_url":"git@github.com:bonitasoft/bonita-web.git","clone_url":"https://github.com/bonitasoft/bonita-web.git","svn_url":"https://github.com/bonitasoft/bonita-web","homepage":"http://community.bonitasoft.com/","size":96053,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":4,"forks":31,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/249"},"html":{"href":"https://github.com/bonitasoft/bonita-web/pull/249"},"issue":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/issues/249"},"comments":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/bonitasoft/bonita-web/statuses/51e09e6819b47575b7d32b83bdcb5a9cdf2b40f8"}}}}