{"action":"created","comment":{"url":"https://api.github.com/repos/pyfa-org/eos/pulls/comments/83280908","pull_request_review_id":4135565,"id":83280908,"diff_hunk":"@@ -100,14 +104,28 @@ class Attribute(IntEnum):\n     required_skill_6_level = 1288\n     required_skill_5 = 1289\n     required_skill_6 = 1290\n+\n+    #Ship Groups","path":"eos/const/eve.py","position":16,"original_position":16,"commit_id":"dbe6c6bbd4115cbaf1b20d06430edfa35c14b343","original_commit_id":"dbe6c6bbd4115cbaf1b20d06430edfa35c14b343","user":{"login":"Regner","id":815037,"avatar_url":"https://avatars.githubusercontent.com/u/815037?v=3","gravatar_id":"","url":"https://api.github.com/users/Regner","html_url":"https://github.com/Regner","followers_url":"https://api.github.com/users/Regner/followers","following_url":"https://api.github.com/users/Regner/following{/other_user}","gists_url":"https://api.github.com/users/Regner/gists{/gist_id}","starred_url":"https://api.github.com/users/Regner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Regner/subscriptions","organizations_url":"https://api.github.com/users/Regner/orgs","repos_url":"https://api.github.com/users/Regner/repos","events_url":"https://api.github.com/users/Regner/events{/privacy}","received_events_url":"https://api.github.com/users/Regner/received_events","type":"User","site_admin":false},"body":"This is the only change the I would define as \"required\". The others are optional/debatable.","created_at":"2016-10-13T18:26:20Z","updated_at":"2016-10-13T18:26:20Z","html_url":"https://github.com/pyfa-org/eos/pull/17#discussion_r83280908","pull_request_url":"https://api.github.com/repos/pyfa-org/eos/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/pyfa-org/eos/pulls/comments/83280908"},"html":{"href":"https://github.com/pyfa-org/eos/pull/17#discussion_r83280908"},"pull_request":{"href":"https://api.github.com/repos/pyfa-org/eos/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/pyfa-org/eos/pulls/17","id":89251319,"html_url":"https://github.com/pyfa-org/eos/pull/17","diff_url":"https://github.com/pyfa-org/eos/pull/17.diff","patch_url":"https://github.com/pyfa-org/eos/pull/17.patch","issue_url":"https://api.github.com/repos/pyfa-org/eos/issues/17","number":17,"state":"open","locked":false,"title":"Enable Structure calculations","user":{"login":"Ebag333","id":7693907,"avatar_url":"https://avatars.githubusercontent.com/u/7693907?v=3","gravatar_id":"","url":"https://api.github.com/users/Ebag333","html_url":"https://github.com/Ebag333","followers_url":"https://api.github.com/users/Ebag333/followers","following_url":"https://api.github.com/users/Ebag333/following{/other_user}","gists_url":"https://api.github.com/users/Ebag333/gists{/gist_id}","starred_url":"https://api.github.com/users/Ebag333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ebag333/subscriptions","organizations_url":"https://api.github.com/users/Ebag333/orgs","repos_url":"https://api.github.com/users/Ebag333/repos","events_url":"https://api.github.com/users/Ebag333/events{/privacy}","received_events_url":"https://api.github.com/users/Ebag333/received_events","type":"User","site_admin":false},"body":"Requires #16 to be in place to work (both PRs touch `eve.py` but in different ways and for different reasons).\r\n\r\nThis enables structures to be calculated as a ship.  For all intents and purposes, the mechanics of structures *ARE* ships, they just have their own set of groups (and one special slot for services).\r\n\r\nThere are some validation issues with structures, but that's in different modules so needs to be cleared up in a seperate PR.  The structure itself validates correctly and without exception if you don't add any modules, the issue comes into play with some of the assumptions made for validation.\r\n\r\nKnown validation issues:\r\n1) Structures are assumed to be subcaps with capital mods, so `capital_item.py` throws an exception.\r\n2) Structure modules/rigs have no requirements, but an exception is thrown saying that the skills don't meet the requirements.","created_at":"2016-10-13T17:57:39Z","updated_at":"2016-10-13T18:26:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c4b615a4904f3eb02a50997589deea17698502d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pyfa-org/eos/pulls/17/commits","review_comments_url":"https://api.github.com/repos/pyfa-org/eos/pulls/17/comments","review_comment_url":"https://api.github.com/repos/pyfa-org/eos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyfa-org/eos/issues/17/comments","statuses_url":"https://api.github.com/repos/pyfa-org/eos/statuses/dbe6c6bbd4115cbaf1b20d06430edfa35c14b343","head":{"label":"Ebag333:EnableStructuresAsShips","ref":"EnableStructuresAsShips","sha":"dbe6c6bbd4115cbaf1b20d06430edfa35c14b343","user":{"login":"Ebag333","id":7693907,"avatar_url":"https://avatars.githubusercontent.com/u/7693907?v=3","gravatar_id":"","url":"https://api.github.com/users/Ebag333","html_url":"https://github.com/Ebag333","followers_url":"https://api.github.com/users/Ebag333/followers","following_url":"https://api.github.com/users/Ebag333/following{/other_user}","gists_url":"https://api.github.com/users/Ebag333/gists{/gist_id}","starred_url":"https://api.github.com/users/Ebag333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ebag333/subscriptions","organizations_url":"https://api.github.com/users/Ebag333/orgs","repos_url":"https://api.github.com/users/Ebag333/repos","events_url":"https://api.github.com/users/Ebag333/events{/privacy}","received_events_url":"https://api.github.com/users/Ebag333/received_events","type":"User","site_admin":false},"repo":{"id":70824747,"name":"eos","full_name":"Ebag333/eos","owner":{"login":"Ebag333","id":7693907,"avatar_url":"https://avatars.githubusercontent.com/u/7693907?v=3","gravatar_id":"","url":"https://api.github.com/users/Ebag333","html_url":"https://github.com/Ebag333","followers_url":"https://api.github.com/users/Ebag333/followers","following_url":"https://api.github.com/users/Ebag333/following{/other_user}","gists_url":"https://api.github.com/users/Ebag333/gists{/gist_id}","starred_url":"https://api.github.com/users/Ebag333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ebag333/subscriptions","organizations_url":"https://api.github.com/users/Ebag333/orgs","repos_url":"https://api.github.com/users/Ebag333/repos","events_url":"https://api.github.com/users/Ebag333/events{/privacy}","received_events_url":"https://api.github.com/users/Ebag333/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ebag333/eos","description":"Eos - library for modeling EVE online ship fits","fork":true,"url":"https://api.github.com/repos/Ebag333/eos","forks_url":"https://api.github.com/repos/Ebag333/eos/forks","keys_url":"https://api.github.com/repos/Ebag333/eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ebag333/eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ebag333/eos/teams","hooks_url":"https://api.github.com/repos/Ebag333/eos/hooks","issue_events_url":"https://api.github.com/repos/Ebag333/eos/issues/events{/number}","events_url":"https://api.github.com/repos/Ebag333/eos/events","assignees_url":"https://api.github.com/repos/Ebag333/eos/assignees{/user}","branches_url":"https://api.github.com/repos/Ebag333/eos/branches{/branch}","tags_url":"https://api.github.com/repos/Ebag333/eos/tags","blobs_url":"https://api.github.com/repos/Ebag333/eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ebag333/eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ebag333/eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ebag333/eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ebag333/eos/statuses/{sha}","languages_url":"https://api.github.com/repos/Ebag333/eos/languages","stargazers_url":"https://api.github.com/repos/Ebag333/eos/stargazers","contributors_url":"https://api.github.com/repos/Ebag333/eos/contributors","subscribers_url":"https://api.github.com/repos/Ebag333/eos/subscribers","subscription_url":"https://api.github.com/repos/Ebag333/eos/subscription","commits_url":"https://api.github.com/repos/Ebag333/eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ebag333/eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ebag333/eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ebag333/eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ebag333/eos/contents/{+path}","compare_url":"https://api.github.com/repos/Ebag333/eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ebag333/eos/merges","archive_url":"https://api.github.com/repos/Ebag333/eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ebag333/eos/downloads","issues_url":"https://api.github.com/repos/Ebag333/eos/issues{/number}","pulls_url":"https://api.github.com/repos/Ebag333/eos/pulls{/number}","milestones_url":"https://api.github.com/repos/Ebag333/eos/milestones{/number}","notifications_url":"https://api.github.com/repos/Ebag333/eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ebag333/eos/labels{/name}","releases_url":"https://api.github.com/repos/Ebag333/eos/releases{/id}","deployments_url":"https://api.github.com/repos/Ebag333/eos/deployments","created_at":"2016-10-13T16:12:30Z","updated_at":"2016-10-13T16:12:32Z","pushed_at":"2016-10-13T17:53:50Z","git_url":"git://github.com/Ebag333/eos.git","ssh_url":"git@github.com:Ebag333/eos.git","clone_url":"https://github.com/Ebag333/eos.git","svn_url":"https://github.com/Ebag333/eos","homepage":"","size":5271,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyfa-org:master","ref":"master","sha":"c339314554955e68b96148e2fdf945079412a30b","user":{"login":"pyfa-org","id":16587622,"avatar_url":"https://avatars.githubusercontent.com/u/16587622?v=3","gravatar_id":"","url":"https://api.github.com/users/pyfa-org","html_url":"https://github.com/pyfa-org","followers_url":"https://api.github.com/users/pyfa-org/followers","following_url":"https://api.github.com/users/pyfa-org/following{/other_user}","gists_url":"https://api.github.com/users/pyfa-org/gists{/gist_id}","starred_url":"https://api.github.com/users/pyfa-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyfa-org/subscriptions","organizations_url":"https://api.github.com/users/pyfa-org/orgs","repos_url":"https://api.github.com/users/pyfa-org/repos","events_url":"https://api.github.com/users/pyfa-org/events{/privacy}","received_events_url":"https://api.github.com/users/pyfa-org/received_events","type":"Organization","site_admin":false},"repo":{"id":69423718,"name":"eos","full_name":"pyfa-org/eos","owner":{"login":"pyfa-org","id":16587622,"avatar_url":"https://avatars.githubusercontent.com/u/16587622?v=3","gravatar_id":"","url":"https://api.github.com/users/pyfa-org","html_url":"https://github.com/pyfa-org","followers_url":"https://api.github.com/users/pyfa-org/followers","following_url":"https://api.github.com/users/pyfa-org/following{/other_user}","gists_url":"https://api.github.com/users/pyfa-org/gists{/gist_id}","starred_url":"https://api.github.com/users/pyfa-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyfa-org/subscriptions","organizations_url":"https://api.github.com/users/pyfa-org/orgs","repos_url":"https://api.github.com/users/pyfa-org/repos","events_url":"https://api.github.com/users/pyfa-org/events{/privacy}","received_events_url":"https://api.github.com/users/pyfa-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyfa-org/eos","description":"Eos - library for modeling EVE online ship fits","fork":true,"url":"https://api.github.com/repos/pyfa-org/eos","forks_url":"https://api.github.com/repos/pyfa-org/eos/forks","keys_url":"https://api.github.com/repos/pyfa-org/eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyfa-org/eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyfa-org/eos/teams","hooks_url":"https://api.github.com/repos/pyfa-org/eos/hooks","issue_events_url":"https://api.github.com/repos/pyfa-org/eos/issues/events{/number}","events_url":"https://api.github.com/repos/pyfa-org/eos/events","assignees_url":"https://api.github.com/repos/pyfa-org/eos/assignees{/user}","branches_url":"https://api.github.com/repos/pyfa-org/eos/branches{/branch}","tags_url":"https://api.github.com/repos/pyfa-org/eos/tags","blobs_url":"https://api.github.com/repos/pyfa-org/eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyfa-org/eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyfa-org/eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyfa-org/eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyfa-org/eos/statuses/{sha}","languages_url":"https://api.github.com/repos/pyfa-org/eos/languages","stargazers_url":"https://api.github.com/repos/pyfa-org/eos/stargazers","contributors_url":"https://api.github.com/repos/pyfa-org/eos/contributors","subscribers_url":"https://api.github.com/repos/pyfa-org/eos/subscribers","subscription_url":"https://api.github.com/repos/pyfa-org/eos/subscription","commits_url":"https://api.github.com/repos/pyfa-org/eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyfa-org/eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyfa-org/eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyfa-org/eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyfa-org/eos/contents/{+path}","compare_url":"https://api.github.com/repos/pyfa-org/eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyfa-org/eos/merges","archive_url":"https://api.github.com/repos/pyfa-org/eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyfa-org/eos/downloads","issues_url":"https://api.github.com/repos/pyfa-org/eos/issues{/number}","pulls_url":"https://api.github.com/repos/pyfa-org/eos/pulls{/number}","milestones_url":"https://api.github.com/repos/pyfa-org/eos/milestones{/number}","notifications_url":"https://api.github.com/repos/pyfa-org/eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyfa-org/eos/labels{/name}","releases_url":"https://api.github.com/repos/pyfa-org/eos/releases{/id}","deployments_url":"https://api.github.com/repos/pyfa-org/eos/deployments","created_at":"2016-09-28T03:55:54Z","updated_at":"2016-10-07T03:59:22Z","pushed_at":"2016-10-13T17:57:40Z","git_url":"git://github.com/pyfa-org/eos.git","ssh_url":"git@github.com:pyfa-org/eos.git","clone_url":"https://github.com/pyfa-org/eos.git","svn_url":"https://github.com/pyfa-org/eos","homepage":"","size":5271,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyfa-org/eos/pulls/17"},"html":{"href":"https://github.com/pyfa-org/eos/pull/17"},"issue":{"href":"https://api.github.com/repos/pyfa-org/eos/issues/17"},"comments":{"href":"https://api.github.com/repos/pyfa-org/eos/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/pyfa-org/eos/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/pyfa-org/eos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyfa-org/eos/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/pyfa-org/eos/statuses/dbe6c6bbd4115cbaf1b20d06430edfa35c14b343"}}}}
{"actor":{"display_login":"Regner"}}