{"action":"created","comment":{"url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/comments/78108944","id":78108944,"diff_hunk":"@@ -0,0 +1,125 @@\n+<?php\n+/**\n+ * Customize API: WP_Customize_Custom_CSS_Setting class\n+ *\n+ * @package WordPress\n+ * @subpackage Customize\n+ * @since 4.7.0\n+ */\n+\n+/**\n+ * A setting that is used to filter a value, but will not save the results.","path":"src/wp-includes/customize/class-wp-customize-custom-css-setting.php","position":11,"original_position":11,"commit_id":"b59dc4459f6fbb3a46c1ffacd777b643d2ab6e3a","original_commit_id":"b59dc4459f6fbb3a46c1ffacd777b643d2ab6e3a","user":{"login":"celloexpressions","id":7875961,"avatar_url":"https://avatars.githubusercontent.com/u/7875961?v=3","gravatar_id":"","url":"https://api.github.com/users/celloexpressions","html_url":"https://github.com/celloexpressions","followers_url":"https://api.github.com/users/celloexpressions/followers","following_url":"https://api.github.com/users/celloexpressions/following{/other_user}","gists_url":"https://api.github.com/users/celloexpressions/gists{/gist_id}","starred_url":"https://api.github.com/users/celloexpressions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celloexpressions/subscriptions","organizations_url":"https://api.github.com/users/celloexpressions/orgs","repos_url":"https://api.github.com/users/celloexpressions/repos","events_url":"https://api.github.com/users/celloexpressions/events{/privacy}","received_events_url":"https://api.github.com/users/celloexpressions/received_events","type":"User","site_admin":false},"body":"Need to update this description, although I'm also wondering whether this custom setting could be useful in plugins if it were a bit more generic. Something to think about.","created_at":"2016-09-08T23:44:06Z","updated_at":"2016-09-08T23:44:06Z","html_url":"https://github.com/xwp/wordpress-develop/pull/154#discussion_r78108944","pull_request_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/comments/78108944"},"html":{"href":"https://github.com/xwp/wordpress-develop/pull/154#discussion_r78108944"},"pull_request":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/154","id":84520747,"html_url":"https://github.com/xwp/wordpress-develop/pull/154","diff_url":"https://github.com/xwp/wordpress-develop/pull/154.diff","patch_url":"https://github.com/xwp/wordpress-develop/pull/154.patch","issue_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/154","number":154,"state":"open","locked":false,"title":"WIP - Trac 35395 (Custom CSS)","user":{"login":"johnregan3","id":2053940,"avatar_url":"https://avatars.githubusercontent.com/u/2053940?v=3","gravatar_id":"","url":"https://api.github.com/users/johnregan3","html_url":"https://github.com/johnregan3","followers_url":"https://api.github.com/users/johnregan3/followers","following_url":"https://api.github.com/users/johnregan3/following{/other_user}","gists_url":"https://api.github.com/users/johnregan3/gists{/gist_id}","starred_url":"https://api.github.com/users/johnregan3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnregan3/subscriptions","organizations_url":"https://api.github.com/users/johnregan3/orgs","repos_url":"https://api.github.com/users/johnregan3/repos","events_url":"https://api.github.com/users/johnregan3/events{/privacy}","received_events_url":"https://api.github.com/users/johnregan3/received_events","type":"User","site_admin":false},"body":"**Opening PR for Feedback.  DO NOT MERGE.**\r\n\r\n[35395](https://core.trac.wordpress.org/ticket/35395)\r\n\r\nAt this point, everything works (although there is a bug where changes display, then disappear in the Preview).  There is still plenty to do, but the implementation is functional.\r\n\r\nSeeking feedback on the following questions in particular:\r\n\r\n-  Class `WP_Custom_CSS`\r\n     -  I used a Class for the following reasons:\r\n          - It uses several methods specific to this feature (e.g., the transient)\r\n          - It can be extended by theme/plugin authors.  \r\n          - We can use class constants to make modifying the CPT slug and transient name simpler (DRY).  \r\n     -  Where should this class be fired?  Currently, it's at the bottom of the file.\r\n     -  Is it appropriate to use the CPT slug and transient name as constants/properties?\r\n     -  Is the slug name \"style\" appropriate for this CPT?  I kept it separate from \"custom-css\" because it is quite possible that plugins are using this term.\r\n     - I'd like to do CSSTidy and Custom CSS-specific Notifications within this class. Your thoughts?\r\n-  JavaScript\r\n     - Is the new code in `customize-controls.js` implemented correctly? (note that I still have a bug in the Preview to fix there)\r\n- File placement\r\n     - CodeMirror is found in `wp-includes/js/codemirror/`.  Is this appropriate?\r\n     - Where should CSSTidy be located?\r\n\r\n### Done\r\nIn this branch, I've done the following so far (with some foundational work from Nick Halsey):\r\n- [x]  Created the section for Custom CSS in the customizer\r\n- [x]  Created a new Controller, \"Code Editor\"\r\n- [x]  Added foundational JS for the Code Editor control\r\n- [x]  Installed CodeMirror\r\n- [x]  Created a CPT called \"style\" to hold our custom CSS\r\n     - Note: You can currently view the content of the posts at `wp-admin/edit.php?post_type=style`\r\n- [x]  Created a custom Setting called \"WP_Customize_CSS_Setting\"\r\n- [x]  Configured Setting to save to style CPT\r\n\r\n### To Do\r\n- [ ]  Fix bug when updating the Preview (changes flash correctly for a moment, then disappear)\r\n- [ ]  Implement CSSTidy\r\n- [ ]  Implement Notifications\r\n- [ ]  Add hooks\r\n- [ ]  Escaping/Validation/Sanitization throughout\r\n- [ ]  Make CPT hidden\r\n- [ ] Test on Networks\r\n- [ ]  Unit Tests\r\n\r\n@westonruter @MattGeri @valendesigns @kienstra @delawski ","created_at":"2016-09-08T17:36:36Z","updated_at":"2016-09-08T23:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61049cbe5ca897604dcb0fdd5ae229794e2d43cb","assignee":{"login":"westonruter","id":134745,"avatar_url":"https://avatars.githubusercontent.com/u/134745?v=3","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"assignees":[{"login":"westonruter","id":134745,"avatar_url":"https://avatars.githubusercontent.com/u/134745?v=3","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/154/commits","review_comments_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/154/comments","review_comment_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/154/comments","statuses_url":"https://api.github.com/repos/xwp/wordpress-develop/statuses/b59dc4459f6fbb3a46c1ffacd777b643d2ab6e3a","head":{"label":"xwp:trac-35395","ref":"trac-35395","sha":"b59dc4459f6fbb3a46c1ffacd777b643d2ab6e3a","user":{"login":"xwp","id":9003139,"avatar_url":"https://avatars.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"repo":{"id":17656498,"name":"wordpress-develop","full_name":"xwp/wordpress-develop","owner":{"login":"xwp","id":9003139,"avatar_url":"https://avatars.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xwp/wordpress-develop","description":"Clone of git://develop.git.wordpress.org/ synced once a minute","fork":false,"url":"https://api.github.com/repos/xwp/wordpress-develop","forks_url":"https://api.github.com/repos/xwp/wordpress-develop/forks","keys_url":"https://api.github.com/repos/xwp/wordpress-develop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwp/wordpress-develop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwp/wordpress-develop/teams","hooks_url":"https://api.github.com/repos/xwp/wordpress-develop/hooks","issue_events_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/events{/number}","events_url":"https://api.github.com/repos/xwp/wordpress-develop/events","assignees_url":"https://api.github.com/repos/xwp/wordpress-develop/assignees{/user}","branches_url":"https://api.github.com/repos/xwp/wordpress-develop/branches{/branch}","tags_url":"https://api.github.com/repos/xwp/wordpress-develop/tags","blobs_url":"https://api.github.com/repos/xwp/wordpress-develop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwp/wordpress-develop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwp/wordpress-develop/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwp/wordpress-develop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwp/wordpress-develop/statuses/{sha}","languages_url":"https://api.github.com/repos/xwp/wordpress-develop/languages","stargazers_url":"https://api.github.com/repos/xwp/wordpress-develop/stargazers","contributors_url":"https://api.github.com/repos/xwp/wordpress-develop/contributors","subscribers_url":"https://api.github.com/repos/xwp/wordpress-develop/subscribers","subscription_url":"https://api.github.com/repos/xwp/wordpress-develop/subscription","commits_url":"https://api.github.com/repos/xwp/wordpress-develop/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwp/wordpress-develop/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwp/wordpress-develop/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwp/wordpress-develop/contents/{+path}","compare_url":"https://api.github.com/repos/xwp/wordpress-develop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwp/wordpress-develop/merges","archive_url":"https://api.github.com/repos/xwp/wordpress-develop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwp/wordpress-develop/downloads","issues_url":"https://api.github.com/repos/xwp/wordpress-develop/issues{/number}","pulls_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls{/number}","milestones_url":"https://api.github.com/repos/xwp/wordpress-develop/milestones{/number}","notifications_url":"https://api.github.com/repos/xwp/wordpress-develop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwp/wordpress-develop/labels{/name}","releases_url":"https://api.github.com/repos/xwp/wordpress-develop/releases{/id}","deployments_url":"https://api.github.com/repos/xwp/wordpress-develop/deployments","created_at":"2014-03-12T05:32:08Z","updated_at":"2016-07-02T01:33:33Z","pushed_at":"2016-09-08T23:40:36Z","git_url":"git://github.com/xwp/wordpress-develop.git","ssh_url":"git@github.com:xwp/wordpress-develop.git","clone_url":"https://github.com/xwp/wordpress-develop.git","svn_url":"https://github.com/xwp/wordpress-develop","homepage":"","size":121587,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":88,"forks":6,"open_issues":88,"watchers":11,"default_branch":"master"}},"base":{"label":"xwp:master","ref":"master","sha":"8bae522ea8c611cfb3807499ff0e22f580fa9c6f","user":{"login":"xwp","id":9003139,"avatar_url":"https://avatars.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"repo":{"id":17656498,"name":"wordpress-develop","full_name":"xwp/wordpress-develop","owner":{"login":"xwp","id":9003139,"avatar_url":"https://avatars.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xwp/wordpress-develop","description":"Clone of git://develop.git.wordpress.org/ synced once a minute","fork":false,"url":"https://api.github.com/repos/xwp/wordpress-develop","forks_url":"https://api.github.com/repos/xwp/wordpress-develop/forks","keys_url":"https://api.github.com/repos/xwp/wordpress-develop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwp/wordpress-develop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwp/wordpress-develop/teams","hooks_url":"https://api.github.com/repos/xwp/wordpress-develop/hooks","issue_events_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/events{/number}","events_url":"https://api.github.com/repos/xwp/wordpress-develop/events","assignees_url":"https://api.github.com/repos/xwp/wordpress-develop/assignees{/user}","branches_url":"https://api.github.com/repos/xwp/wordpress-develop/branches{/branch}","tags_url":"https://api.github.com/repos/xwp/wordpress-develop/tags","blobs_url":"https://api.github.com/repos/xwp/wordpress-develop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwp/wordpress-develop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwp/wordpress-develop/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwp/wordpress-develop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwp/wordpress-develop/statuses/{sha}","languages_url":"https://api.github.com/repos/xwp/wordpress-develop/languages","stargazers_url":"https://api.github.com/repos/xwp/wordpress-develop/stargazers","contributors_url":"https://api.github.com/repos/xwp/wordpress-develop/contributors","subscribers_url":"https://api.github.com/repos/xwp/wordpress-develop/subscribers","subscription_url":"https://api.github.com/repos/xwp/wordpress-develop/subscription","commits_url":"https://api.github.com/repos/xwp/wordpress-develop/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwp/wordpress-develop/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwp/wordpress-develop/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwp/wordpress-develop/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwp/wordpress-develop/contents/{+path}","compare_url":"https://api.github.com/repos/xwp/wordpress-develop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwp/wordpress-develop/merges","archive_url":"https://api.github.com/repos/xwp/wordpress-develop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwp/wordpress-develop/downloads","issues_url":"https://api.github.com/repos/xwp/wordpress-develop/issues{/number}","pulls_url":"https://api.github.com/repos/xwp/wordpress-develop/pulls{/number}","milestones_url":"https://api.github.com/repos/xwp/wordpress-develop/milestones{/number}","notifications_url":"https://api.github.com/repos/xwp/wordpress-develop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwp/wordpress-develop/labels{/name}","releases_url":"https://api.github.com/repos/xwp/wordpress-develop/releases{/id}","deployments_url":"https://api.github.com/repos/xwp/wordpress-develop/deployments","created_at":"2014-03-12T05:32:08Z","updated_at":"2016-07-02T01:33:33Z","pushed_at":"2016-09-08T23:40:36Z","git_url":"git://github.com/xwp/wordpress-develop.git","ssh_url":"git@github.com:xwp/wordpress-develop.git","clone_url":"https://github.com/xwp/wordpress-develop.git","svn_url":"https://github.com/xwp/wordpress-develop","homepage":"","size":121587,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":88,"forks":6,"open_issues":88,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/154"},"html":{"href":"https://github.com/xwp/wordpress-develop/pull/154"},"issue":{"href":"https://api.github.com/repos/xwp/wordpress-develop/issues/154"},"comments":{"href":"https://api.github.com/repos/xwp/wordpress-develop/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xwp/wordpress-develop/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/xwp/wordpress-develop/statuses/b59dc4459f6fbb3a46c1ffacd777b643d2ab6e3a"}}}}
{"actor":{"display_login":"celloexpressions"}}