{"action":"created","issue":{"url":"https://api.github.com/repos/intel-iot-devkit/upm/issues/480","repository_url":"https://api.github.com/repos/intel-iot-devkit/upm","labels_url":"https://api.github.com/repos/intel-iot-devkit/upm/issues/480/labels{/name}","comments_url":"https://api.github.com/repos/intel-iot-devkit/upm/issues/480/comments","events_url":"https://api.github.com/repos/intel-iot-devkit/upm/issues/480/events","html_url":"https://github.com/intel-iot-devkit/upm/issues/480","id":186965987,"number":480,"title":"Some Grove-independent JS examples still using jsupm_grove","user":{"login":"SuyashLakhotia","id":8863065,"avatar_url":"https://avatars.githubusercontent.com/u/8863065?v=3","gravatar_id":"","url":"https://api.github.com/users/SuyashLakhotia","html_url":"https://github.com/SuyashLakhotia","followers_url":"https://api.github.com/users/SuyashLakhotia/followers","following_url":"https://api.github.com/users/SuyashLakhotia/following{/other_user}","gists_url":"https://api.github.com/users/SuyashLakhotia/gists{/gist_id}","starred_url":"https://api.github.com/users/SuyashLakhotia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuyashLakhotia/subscriptions","organizations_url":"https://api.github.com/users/SuyashLakhotia/orgs","repos_url":"https://api.github.com/users/SuyashLakhotia/repos","events_url":"https://api.github.com/users/SuyashLakhotia/events{/privacy}","received_events_url":"https://api.github.com/users/SuyashLakhotia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-03T02:18:32Z","updated_at":"2016-11-03T03:43:30Z","closed_at":null,"body":"I see that there are separate JS snippets for Grove sensors and otherwise. However, looks like some of the non-Grove examples also seem to be using `jsupm_grove` instead of `jsupm_<sensor>`, which means that when the sensors are being initialised (as JS objects), an incorrect constructor is being called. I've gone through some of the files really quickly and found that this mistake exists in:\r\n\r\n- [Grove Button](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/grovebutton.js) vs. [Button](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/button.js)\r\n- [Grove Rotary](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/groverotary.js) vs. [Rotary](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/rotary.js)\r\n- [Grove Relay](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/groverelay.js) vs. [Relay](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/relay.js)\r\n\r\nI'll build the above list if I find any more. I can also submit a PR fixing the issue if you wish.\r\n\r\nOn a side note, some of the correct usages can be found in:\r\n\r\n- [Grove LED](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/groveled.js) vs. [LED](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/led.js)\r\n- [Grove Temp](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/grovetemp.js) vs. [Temp](https://github.com/intel-iot-devkit/upm/blob/master/examples/javascript/temperature.js)\r\n\r\nCloses #474."},"comment":{"url":"https://api.github.com/repos/intel-iot-devkit/upm/issues/comments/258058997","html_url":"https://github.com/intel-iot-devkit/upm/issues/480#issuecomment-258058997","issue_url":"https://api.github.com/repos/intel-iot-devkit/upm/issues/480","id":258058997,"user":{"login":"Propanu","id":5123898,"avatar_url":"https://avatars.githubusercontent.com/u/5123898?v=3","gravatar_id":"","url":"https://api.github.com/users/Propanu","html_url":"https://github.com/Propanu","followers_url":"https://api.github.com/users/Propanu/followers","following_url":"https://api.github.com/users/Propanu/following{/other_user}","gists_url":"https://api.github.com/users/Propanu/gists{/gist_id}","starred_url":"https://api.github.com/users/Propanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Propanu/subscriptions","organizations_url":"https://api.github.com/users/Propanu/orgs","repos_url":"https://api.github.com/users/Propanu/repos","events_url":"https://api.github.com/users/Propanu/events{/privacy}","received_events_url":"https://api.github.com/users/Propanu/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T03:43:30Z","updated_at":"2016-11-03T03:43:30Z","body":"@SuyashLakhotia, some of the documentation and the samples out there will be updated over time, but I highly recommend moving to the new class names. As for how we group those into packages, we are working on that and I agree with you that it makes sense to provide kit specific library bundles."}}
{"actor":{"display_login":"Propanu"}}