{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/comments/56890656","id":56890656,"diff_hunk":"@@ -114,9 +140,56 @@ protected void resetEditorFrom(ManagedVmDeploymentConfiguration configuration) {\n   @Override\n   protected void applyEditorTo(ManagedVmDeploymentConfiguration configuration)\n       throws ConfigurationException {\n+    configuration.setUserSpecifiedArtifact(isUserSpecifiedPathDeploymentSource());\n+    configuration.setUserSpecifiedArtifactPath(userSpecifiedArtifactFileSelector.getText());\n     configuration.setDockerFilePath(dockerFilePathField.getText());\n     configuration.setAppYamlPath(appYamlPathField.getText());\n     configuration.setConfigType(getConfigType());\n+\n+    setDeploymentSourceName(configuration.getUserSpecifiedArtifactPath());\n+    toggleJarWarSelector();\n+    validateConfiguration();\n+  }\n+\n+  private void toggleJarWarSelector() {","path":"google-cloud-tools-plugin/src/com/google/gct/idea/appengine/cloud/ManagedVmDeploymentRunConfigurationEditor.java","position":null,"original_position":94,"commit_id":"298c4e18ea00a60b127134b0dc2c8fe6d9ab6cb3","original_commit_id":"2fd52c07a141854e6a152bcb6ed4b91e45528da0","user":{"login":"etanshaul","id":1735744,"avatar_url":"https://avatars.githubusercontent.com/u/1735744?v=3","gravatar_id":"","url":"https://api.github.com/users/etanshaul","html_url":"https://github.com/etanshaul","followers_url":"https://api.github.com/users/etanshaul/followers","following_url":"https://api.github.com/users/etanshaul/following{/other_user}","gists_url":"https://api.github.com/users/etanshaul/gists{/gist_id}","starred_url":"https://api.github.com/users/etanshaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etanshaul/subscriptions","organizations_url":"https://api.github.com/users/etanshaul/orgs","repos_url":"https://api.github.com/users/etanshaul/repos","events_url":"https://api.github.com/users/etanshaul/events{/privacy}","received_events_url":"https://api.github.com/users/etanshaul/received_events","type":"User","site_admin":false},"body":"I like your suggestion better actually. Updated the branch with both of your comments.","created_at":"2016-03-21T20:26:50Z","updated_at":"2016-03-21T20:26:50Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/505#discussion_r56890656","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/505","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/comments/56890656"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/505#discussion_r56890656"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/505","id":63009415,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/505","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/505.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/505.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/505","number":505,"state":"open","locked":false,"title":"adding support for user selection of jar or war files for mvm deployment","user":{"login":"etanshaul","id":1735744,"avatar_url":"https://avatars.githubusercontent.com/u/1735744?v=3","gravatar_id":"","url":"https://api.github.com/users/etanshaul","html_url":"https://github.com/etanshaul","followers_url":"https://api.github.com/users/etanshaul/followers","following_url":"https://api.github.com/users/etanshaul/following{/other_user}","gists_url":"https://api.github.com/users/etanshaul/gists{/gist_id}","starred_url":"https://api.github.com/users/etanshaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etanshaul/subscriptions","organizations_url":"https://api.github.com/users/etanshaul/orgs","repos_url":"https://api.github.com/users/etanshaul/repos","events_url":"https://api.github.com/users/etanshaul/events{/privacy}","received_events_url":"https://api.github.com/users/etanshaul/received_events","type":"User","site_admin":false},"body":"fixes #449 \r\n\r\nA possible approach to allowing the user to manually select jar or war files for mvm deployment. Gets around forcing the user to have preconfigured IJ Artifacts.\r\n\r\nThe other approach discussed was to use IJ Artifact system to create a custom Artifact pointing to a file on the filesystem for deployment. \r\n\r\ntodo and better documentation pending\r\n\r\nUpdated UI and placeholder deployment source selected:\r\n<img width=\"549\" alt=\"screen shot 2016-03-15 at 11 16 03 pm\" src=\"https://cloud.githubusercontent.com/assets/1735744/13801053/d7489b18-eb04-11e5-987a-df4f4eaed8d8.png\">\r\n\r\nA custom chosen jar file:\r\n<img width=\"553\" alt=\"screen shot 2016-03-15 at 11 19 56 pm\" src=\"https://cloud.githubusercontent.com/assets/1735744/13801068/f1b2a674-eb04-11e5-89ae-f2c7f1a34364.png\">\r\n\r\nDeployment source dropdown:\r\n<img width=\"331\" alt=\"screen shot 2016-03-15 at 11 20 12 pm\" src=\"https://cloud.githubusercontent.com/assets/1735744/13801079/00e60cc6-eb05-11e5-9864-336d1b734ce8.png\">\r\n\r\n","created_at":"2016-03-16T03:26:50Z","updated_at":"2016-03-21T20:26:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"347844c681dcbc52676f4843d55daa344fa4adbb","assignee":{"login":"patflynn","id":7862557,"avatar_url":"https://avatars.githubusercontent.com/u/7862557?v=3","gravatar_id":"","url":"https://api.github.com/users/patflynn","html_url":"https://github.com/patflynn","followers_url":"https://api.github.com/users/patflynn/followers","following_url":"https://api.github.com/users/patflynn/following{/other_user}","gists_url":"https://api.github.com/users/patflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/patflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patflynn/subscriptions","organizations_url":"https://api.github.com/users/patflynn/orgs","repos_url":"https://api.github.com/users/patflynn/repos","events_url":"https://api.github.com/users/patflynn/events{/privacy}","received_events_url":"https://api.github.com/users/patflynn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/505/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/505/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/505/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/statuses/298c4e18ea00a60b127134b0dc2c8fe6d9ab6cb3","head":{"label":"GoogleCloudPlatform:mvm-manualdeploymentsource","ref":"mvm-manualdeploymentsource","sha":"298c4e18ea00a60b127134b0dc2c8fe6d9ab6cb3","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":38834157,"name":"gcloud-intellij","full_name":"GoogleCloudPlatform/gcloud-intellij","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij","description":"Plugin to support the Google Cloud Platform in IntelliJ IDEA.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/deployments","created_at":"2015-07-09T17:08:59Z","updated_at":"2016-03-14T14:10:08Z","pushed_at":"2016-03-21T20:25:59Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-intellij.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-intellij.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij","homepage":"","size":19020,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":60,"forks":4,"open_issues":60,"watchers":11,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"9d00eaaa55ac5f82dde41ea16f039c27f73b95ff","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":38834157,"name":"gcloud-intellij","full_name":"GoogleCloudPlatform/gcloud-intellij","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij","description":"Plugin to support the Google Cloud Platform in IntelliJ IDEA.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/deployments","created_at":"2015-07-09T17:08:59Z","updated_at":"2016-03-14T14:10:08Z","pushed_at":"2016-03-21T20:25:59Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-intellij.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-intellij.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij","homepage":"","size":19020,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":60,"forks":4,"open_issues":60,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/505"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/505"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/505"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/statuses/298c4e18ea00a60b127134b0dc2c8fe6d9ab6cb3"}}}}