{"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/comments/70971855","id":70971855,"diff_hunk":"@@ -15,14 +17,16 @@ RUN yum install -y epel-release && \\\n            -e 's|<Directory \"/var/www\">|<Directory \"/usr/share/nagios/html\">|' \\\n            /etc/httpd/conf/httpd.conf && \\\n     touch /supervisord.log /supervisord.pid && \\\n-    mkdir -p /var/log/nagios/archives /var/log/nagios/rw/ /var/log/nagios/spool/checkresults && \\\n+    mkdir -p /var/log/nagios/archives /var/log/nagios/rw/ /var/log/nagios/spool/checkresults $NAGIOS_PLUGINS && \\\n     chmod -R 777 /supervisord.log /supervisord.pid /var/log/nagios \\\n                  /etc/httpd /etc/passwd /var/log /etc/nagios /usr/lib64/nagios \\\n                  /var/spool/nagios /run /usr/share/httpd /usr/share/nagios && \\\n     sed -i -e 's|cfg_file=/etc/nagios/objects/localhost.cfg||' /etc/nagios/nagios.cfg\n \n ADD supervisord.conf /etc/supervisord.conf\n ADD make-nagios-fhservices-cfg make-nagios-commands-cfg fhservices.cfg.j2 commands.cfg.j2 /opt/rhmap/\n+ADD /plugins/default/* /plugins/core/* $NAGIOS_PLUGINS","path":"Dockerfile","position":25,"original_position":25,"commit_id":"5efbe320f946a7a42c7a67ccaf4b6cc2bfe07ddc","original_commit_id":"5efbe320f946a7a42c7a67ccaf4b6cc2bfe07ddc","user":{"login":"mikenairn","id":327352,"avatar_url":"https://avatars.githubusercontent.com/u/327352?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenairn","html_url":"https://github.com/mikenairn","followers_url":"https://api.github.com/users/mikenairn/followers","following_url":"https://api.github.com/users/mikenairn/following{/other_user}","gists_url":"https://api.github.com/users/mikenairn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenairn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenairn/subscriptions","organizations_url":"https://api.github.com/users/mikenairn/orgs","repos_url":"https://api.github.com/users/mikenairn/repos","events_url":"https://api.github.com/users/mikenairn/events{/privacy}","received_events_url":"https://api.github.com/users/mikenairn/received_events","type":"User","site_admin":false},"body":"I wondered about this also, we don't do this for anything else, would you expect this to be:\r\n\r\n```\r\nADD plugins/default/* plugins/core/* $NAGIOS_PLUGINS\r\n```\r\n\r\n@jessesarn Any reason you made these absolute paths in your PR https://github.com/feedhenry/nagios-container/pull/5","created_at":"2016-07-15T13:25:17Z","updated_at":"2016-07-15T13:25:17Z","html_url":"https://github.com/feedhenry/nagios-container/pull/8#discussion_r70971855","pull_request_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/comments/70971855"},"html":{"href":"https://github.com/feedhenry/nagios-container/pull/8#discussion_r70971855"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/8","id":77602002,"html_url":"https://github.com/feedhenry/nagios-container/pull/8","diff_url":"https://github.com/feedhenry/nagios-container/pull/8.diff","patch_url":"https://github.com/feedhenry/nagios-container/pull/8.patch","issue_url":"https://api.github.com/repos/feedhenry/nagios-container/issues/8","number":8,"state":"open","locked":false,"title":"Rhmap 6722 add node core component checks","user":{"login":"mikenairn","id":327352,"avatar_url":"https://avatars.githubusercontent.com/u/327352?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenairn","html_url":"https://github.com/mikenairn","followers_url":"https://api.github.com/users/mikenairn/followers","following_url":"https://api.github.com/users/mikenairn/following{/other_user}","gists_url":"https://api.github.com/users/mikenairn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenairn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenairn/subscriptions","organizations_url":"https://api.github.com/users/mikenairn/orgs","repos_url":"https://api.github.com/users/mikenairn/repos","events_url":"https://api.github.com/users/mikenairn/events{/privacy}","received_events_url":"https://api.github.com/users/mikenairn/received_events","type":"User","site_admin":false},"body":"* Adds checks for all the core node.js components\r\n* Adds a new nagios module for querying the health endpoint (Copied from an existing check)\r\n\r\nSome cross over with https://github.com/feedhenry/nagios-container/pull/5 regarding nagios plugins setup.\r\n\r\nNote:\r\n\r\nCurrently the fh-appstore doesn't have the health endpoint so fails all the time.\r\n\r\n","created_at":"2016-07-15T11:32:19Z","updated_at":"2016-07-15T13:25:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c92b7a3ece6f6c46b6626222edc4bc0be047dae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/8/commits","review_comments_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/8/comments","review_comment_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry/nagios-container/issues/8/comments","statuses_url":"https://api.github.com/repos/feedhenry/nagios-container/statuses/5efbe320f946a7a42c7a67ccaf4b6cc2bfe07ddc","head":{"label":"mikenairn:RHMAP-6722_add_node_core_component_checks","ref":"RHMAP-6722_add_node_core_component_checks","sha":"5efbe320f946a7a42c7a67ccaf4b6cc2bfe07ddc","user":{"login":"mikenairn","id":327352,"avatar_url":"https://avatars.githubusercontent.com/u/327352?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenairn","html_url":"https://github.com/mikenairn","followers_url":"https://api.github.com/users/mikenairn/followers","following_url":"https://api.github.com/users/mikenairn/following{/other_user}","gists_url":"https://api.github.com/users/mikenairn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenairn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenairn/subscriptions","organizations_url":"https://api.github.com/users/mikenairn/orgs","repos_url":"https://api.github.com/users/mikenairn/repos","events_url":"https://api.github.com/users/mikenairn/events{/privacy}","received_events_url":"https://api.github.com/users/mikenairn/received_events","type":"User","site_admin":false},"repo":{"id":63138509,"name":"nagios-container","full_name":"mikenairn/nagios-container","owner":{"login":"mikenairn","id":327352,"avatar_url":"https://avatars.githubusercontent.com/u/327352?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenairn","html_url":"https://github.com/mikenairn","followers_url":"https://api.github.com/users/mikenairn/followers","following_url":"https://api.github.com/users/mikenairn/following{/other_user}","gists_url":"https://api.github.com/users/mikenairn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenairn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenairn/subscriptions","organizations_url":"https://api.github.com/users/mikenairn/orgs","repos_url":"https://api.github.com/users/mikenairn/repos","events_url":"https://api.github.com/users/mikenairn/events{/privacy}","received_events_url":"https://api.github.com/users/mikenairn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikenairn/nagios-container","description":"RHMAP Core Monitoring ","fork":true,"url":"https://api.github.com/repos/mikenairn/nagios-container","forks_url":"https://api.github.com/repos/mikenairn/nagios-container/forks","keys_url":"https://api.github.com/repos/mikenairn/nagios-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikenairn/nagios-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikenairn/nagios-container/teams","hooks_url":"https://api.github.com/repos/mikenairn/nagios-container/hooks","issue_events_url":"https://api.github.com/repos/mikenairn/nagios-container/issues/events{/number}","events_url":"https://api.github.com/repos/mikenairn/nagios-container/events","assignees_url":"https://api.github.com/repos/mikenairn/nagios-container/assignees{/user}","branches_url":"https://api.github.com/repos/mikenairn/nagios-container/branches{/branch}","tags_url":"https://api.github.com/repos/mikenairn/nagios-container/tags","blobs_url":"https://api.github.com/repos/mikenairn/nagios-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikenairn/nagios-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikenairn/nagios-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikenairn/nagios-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikenairn/nagios-container/statuses/{sha}","languages_url":"https://api.github.com/repos/mikenairn/nagios-container/languages","stargazers_url":"https://api.github.com/repos/mikenairn/nagios-container/stargazers","contributors_url":"https://api.github.com/repos/mikenairn/nagios-container/contributors","subscribers_url":"https://api.github.com/repos/mikenairn/nagios-container/subscribers","subscription_url":"https://api.github.com/repos/mikenairn/nagios-container/subscription","commits_url":"https://api.github.com/repos/mikenairn/nagios-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikenairn/nagios-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikenairn/nagios-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikenairn/nagios-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikenairn/nagios-container/contents/{+path}","compare_url":"https://api.github.com/repos/mikenairn/nagios-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikenairn/nagios-container/merges","archive_url":"https://api.github.com/repos/mikenairn/nagios-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikenairn/nagios-container/downloads","issues_url":"https://api.github.com/repos/mikenairn/nagios-container/issues{/number}","pulls_url":"https://api.github.com/repos/mikenairn/nagios-container/pulls{/number}","milestones_url":"https://api.github.com/repos/mikenairn/nagios-container/milestones{/number}","notifications_url":"https://api.github.com/repos/mikenairn/nagios-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikenairn/nagios-container/labels{/name}","releases_url":"https://api.github.com/repos/mikenairn/nagios-container/releases{/id}","deployments_url":"https://api.github.com/repos/mikenairn/nagios-container/deployments","created_at":"2016-07-12T07:57:42Z","updated_at":"2016-07-14T13:39:34Z","pushed_at":"2016-07-15T11:24:21Z","git_url":"git://github.com/mikenairn/nagios-container.git","ssh_url":"git@github.com:mikenairn/nagios-container.git","clone_url":"https://github.com/mikenairn/nagios-container.git","svn_url":"https://github.com/mikenairn/nagios-container","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"7cedb481773753ac89405c0d423a7676ff90ad4a","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":63078110,"name":"nagios-container","full_name":"feedhenry/nagios-container","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/nagios-container","description":"RHMAP Core Monitoring ","fork":false,"url":"https://api.github.com/repos/feedhenry/nagios-container","forks_url":"https://api.github.com/repos/feedhenry/nagios-container/forks","keys_url":"https://api.github.com/repos/feedhenry/nagios-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/nagios-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/nagios-container/teams","hooks_url":"https://api.github.com/repos/feedhenry/nagios-container/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/nagios-container/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/nagios-container/events","assignees_url":"https://api.github.com/repos/feedhenry/nagios-container/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/nagios-container/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/nagios-container/tags","blobs_url":"https://api.github.com/repos/feedhenry/nagios-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/nagios-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/nagios-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/nagios-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/nagios-container/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/nagios-container/languages","stargazers_url":"https://api.github.com/repos/feedhenry/nagios-container/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/nagios-container/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/nagios-container/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/nagios-container/subscription","commits_url":"https://api.github.com/repos/feedhenry/nagios-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/nagios-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/nagios-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/nagios-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry/nagios-container/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/nagios-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/nagios-container/merges","archive_url":"https://api.github.com/repos/feedhenry/nagios-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/nagios-container/downloads","issues_url":"https://api.github.com/repos/feedhenry/nagios-container/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/nagios-container/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/nagios-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/nagios-container/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/nagios-container/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry/nagios-container/deployments","created_at":"2016-07-11T15:09:01Z","updated_at":"2016-07-14T13:21:01Z","pushed_at":"2016-07-15T11:32:19Z","git_url":"git://github.com/feedhenry/nagios-container.git","ssh_url":"git@github.com:feedhenry/nagios-container.git","clone_url":"https://github.com/feedhenry/nagios-container.git","svn_url":"https://github.com/feedhenry/nagios-container","homepage":null,"size":14,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/8"},"html":{"href":"https://github.com/feedhenry/nagios-container/pull/8"},"issue":{"href":"https://api.github.com/repos/feedhenry/nagios-container/issues/8"},"comments":{"href":"https://api.github.com/repos/feedhenry/nagios-container/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/nagios-container/statuses/5efbe320f946a7a42c7a67ccaf4b6cc2bfe07ddc"}}}}
{"actor":{"display_login":"mikenairn"}}