{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/aptible/captain-comeback/pulls/5","id":84299224,"html_url":"https://github.com/aptible/captain-comeback/pull/5","diff_url":"https://github.com/aptible/captain-comeback/pull/5.diff","patch_url":"https://github.com/aptible/captain-comeback/pull/5.patch","issue_url":"https://api.github.com/repos/aptible/captain-comeback/issues/5","number":5,"state":"open","locked":false,"title":"Send SIGTERM to all processes in a group","user":{"login":"krallin","id":1737686,"avatar_url":"https://avatars.githubusercontent.com/u/1737686?v=3","gravatar_id":"","url":"https://api.github.com/users/krallin","html_url":"https://github.com/krallin","followers_url":"https://api.github.com/users/krallin/followers","following_url":"https://api.github.com/users/krallin/following{/other_user}","gists_url":"https://api.github.com/users/krallin/gists{/gist_id}","starred_url":"https://api.github.com/users/krallin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krallin/subscriptions","organizations_url":"https://api.github.com/users/krallin/orgs","repos_url":"https://api.github.com/users/krallin/repos","events_url":"https://api.github.com/users/krallin/events{/privacy}","received_events_url":"https://api.github.com/users/krallin/received_events","type":"User","site_admin":false},"body":"Aptible interprets Procfiles with a shell, which means that for most\r\ncontainers (i.e. unless they were designed to work around this problem),\r\nPID 1 will be a shell that will dutyfully ignore the SIGTERM we send\r\nwhen attempting to restart the container.\r\n\r\nThis is problematic, because it reduces our chances of getting a clean\r\nrestart by not letting running processes e.g. clean up their PID files.\r\n\r\nSo, to increase our odds of success, we send SIGTERM to everyone in the\r\ncontainer (like e.g. Heroku does).\r\n\r\n--\r\n\r\ncc @fancyremarker @blakepettersson ","created_at":"2016-09-07T13:24:19Z","updated_at":"2016-09-07T13:24:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f3a38b63ab66b63db9d5bec2b9fa0582fb95d12","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aptible/captain-comeback/pulls/5/commits","review_comments_url":"https://api.github.com/repos/aptible/captain-comeback/pulls/5/comments","review_comment_url":"https://api.github.com/repos/aptible/captain-comeback/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aptible/captain-comeback/issues/5/comments","statuses_url":"https://api.github.com/repos/aptible/captain-comeback/statuses/e9ca37295e81bff1e58ac974aee1b142df6868cc","head":{"label":"krallin:term-all","ref":"term-all","sha":"e9ca37295e81bff1e58ac974aee1b142df6868cc","user":{"login":"krallin","id":1737686,"avatar_url":"https://avatars.githubusercontent.com/u/1737686?v=3","gravatar_id":"","url":"https://api.github.com/users/krallin","html_url":"https://github.com/krallin","followers_url":"https://api.github.com/users/krallin/followers","following_url":"https://api.github.com/users/krallin/following{/other_user}","gists_url":"https://api.github.com/users/krallin/gists{/gist_id}","starred_url":"https://api.github.com/users/krallin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krallin/subscriptions","organizations_url":"https://api.github.com/users/krallin/orgs","repos_url":"https://api.github.com/users/krallin/repos","events_url":"https://api.github.com/users/krallin/events{/privacy}","received_events_url":"https://api.github.com/users/krallin/received_events","type":"User","site_admin":false},"repo":{"id":62813918,"name":"captain-comeback","full_name":"krallin/captain-comeback","owner":{"login":"krallin","id":1737686,"avatar_url":"https://avatars.githubusercontent.com/u/1737686?v=3","gravatar_id":"","url":"https://api.github.com/users/krallin","html_url":"https://github.com/krallin","followers_url":"https://api.github.com/users/krallin/followers","following_url":"https://api.github.com/users/krallin/following{/other_user}","gists_url":"https://api.github.com/users/krallin/gists{/gist_id}","starred_url":"https://api.github.com/users/krallin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krallin/subscriptions","organizations_url":"https://api.github.com/users/krallin/orgs","repos_url":"https://api.github.com/users/krallin/repos","events_url":"https://api.github.com/users/krallin/events{/privacy}","received_events_url":"https://api.github.com/users/krallin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krallin/captain-comeback","description":"Userland container OOM manager","fork":true,"url":"https://api.github.com/repos/krallin/captain-comeback","forks_url":"https://api.github.com/repos/krallin/captain-comeback/forks","keys_url":"https://api.github.com/repos/krallin/captain-comeback/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krallin/captain-comeback/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krallin/captain-comeback/teams","hooks_url":"https://api.github.com/repos/krallin/captain-comeback/hooks","issue_events_url":"https://api.github.com/repos/krallin/captain-comeback/issues/events{/number}","events_url":"https://api.github.com/repos/krallin/captain-comeback/events","assignees_url":"https://api.github.com/repos/krallin/captain-comeback/assignees{/user}","branches_url":"https://api.github.com/repos/krallin/captain-comeback/branches{/branch}","tags_url":"https://api.github.com/repos/krallin/captain-comeback/tags","blobs_url":"https://api.github.com/repos/krallin/captain-comeback/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krallin/captain-comeback/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krallin/captain-comeback/git/refs{/sha}","trees_url":"https://api.github.com/repos/krallin/captain-comeback/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krallin/captain-comeback/statuses/{sha}","languages_url":"https://api.github.com/repos/krallin/captain-comeback/languages","stargazers_url":"https://api.github.com/repos/krallin/captain-comeback/stargazers","contributors_url":"https://api.github.com/repos/krallin/captain-comeback/contributors","subscribers_url":"https://api.github.com/repos/krallin/captain-comeback/subscribers","subscription_url":"https://api.github.com/repos/krallin/captain-comeback/subscription","commits_url":"https://api.github.com/repos/krallin/captain-comeback/commits{/sha}","git_commits_url":"https://api.github.com/repos/krallin/captain-comeback/git/commits{/sha}","comments_url":"https://api.github.com/repos/krallin/captain-comeback/comments{/number}","issue_comment_url":"https://api.github.com/repos/krallin/captain-comeback/issues/comments{/number}","contents_url":"https://api.github.com/repos/krallin/captain-comeback/contents/{+path}","compare_url":"https://api.github.com/repos/krallin/captain-comeback/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krallin/captain-comeback/merges","archive_url":"https://api.github.com/repos/krallin/captain-comeback/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krallin/captain-comeback/downloads","issues_url":"https://api.github.com/repos/krallin/captain-comeback/issues{/number}","pulls_url":"https://api.github.com/repos/krallin/captain-comeback/pulls{/number}","milestones_url":"https://api.github.com/repos/krallin/captain-comeback/milestones{/number}","notifications_url":"https://api.github.com/repos/krallin/captain-comeback/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krallin/captain-comeback/labels{/name}","releases_url":"https://api.github.com/repos/krallin/captain-comeback/releases{/id}","deployments_url":"https://api.github.com/repos/krallin/captain-comeback/deployments","created_at":"2016-07-07T14:37:48Z","updated_at":"2016-07-07T14:38:11Z","pushed_at":"2016-09-07T13:23:48Z","git_url":"git://github.com/krallin/captain-comeback.git","ssh_url":"git@github.com:krallin/captain-comeback.git","clone_url":"https://github.com/krallin/captain-comeback.git","svn_url":"https://github.com/krallin/captain-comeback","homepage":null,"size":32,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aptible:master","ref":"master","sha":"2810a79cca7784fe9c5afe0b88c8f06c0b0a0b24","user":{"login":"aptible","id":4594193,"avatar_url":"https://avatars.githubusercontent.com/u/4594193?v=3","gravatar_id":"","url":"https://api.github.com/users/aptible","html_url":"https://github.com/aptible","followers_url":"https://api.github.com/users/aptible/followers","following_url":"https://api.github.com/users/aptible/following{/other_user}","gists_url":"https://api.github.com/users/aptible/gists{/gist_id}","starred_url":"https://api.github.com/users/aptible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptible/subscriptions","organizations_url":"https://api.github.com/users/aptible/orgs","repos_url":"https://api.github.com/users/aptible/repos","events_url":"https://api.github.com/users/aptible/events{/privacy}","received_events_url":"https://api.github.com/users/aptible/received_events","type":"Organization","site_admin":false},"repo":{"id":62813779,"name":"captain-comeback","full_name":"aptible/captain-comeback","owner":{"login":"aptible","id":4594193,"avatar_url":"https://avatars.githubusercontent.com/u/4594193?v=3","gravatar_id":"","url":"https://api.github.com/users/aptible","html_url":"https://github.com/aptible","followers_url":"https://api.github.com/users/aptible/followers","following_url":"https://api.github.com/users/aptible/following{/other_user}","gists_url":"https://api.github.com/users/aptible/gists{/gist_id}","starred_url":"https://api.github.com/users/aptible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptible/subscriptions","organizations_url":"https://api.github.com/users/aptible/orgs","repos_url":"https://api.github.com/users/aptible/repos","events_url":"https://api.github.com/users/aptible/events{/privacy}","received_events_url":"https://api.github.com/users/aptible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aptible/captain-comeback","description":"Userland container OOM manager","fork":false,"url":"https://api.github.com/repos/aptible/captain-comeback","forks_url":"https://api.github.com/repos/aptible/captain-comeback/forks","keys_url":"https://api.github.com/repos/aptible/captain-comeback/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aptible/captain-comeback/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aptible/captain-comeback/teams","hooks_url":"https://api.github.com/repos/aptible/captain-comeback/hooks","issue_events_url":"https://api.github.com/repos/aptible/captain-comeback/issues/events{/number}","events_url":"https://api.github.com/repos/aptible/captain-comeback/events","assignees_url":"https://api.github.com/repos/aptible/captain-comeback/assignees{/user}","branches_url":"https://api.github.com/repos/aptible/captain-comeback/branches{/branch}","tags_url":"https://api.github.com/repos/aptible/captain-comeback/tags","blobs_url":"https://api.github.com/repos/aptible/captain-comeback/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aptible/captain-comeback/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aptible/captain-comeback/git/refs{/sha}","trees_url":"https://api.github.com/repos/aptible/captain-comeback/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aptible/captain-comeback/statuses/{sha}","languages_url":"https://api.github.com/repos/aptible/captain-comeback/languages","stargazers_url":"https://api.github.com/repos/aptible/captain-comeback/stargazers","contributors_url":"https://api.github.com/repos/aptible/captain-comeback/contributors","subscribers_url":"https://api.github.com/repos/aptible/captain-comeback/subscribers","subscription_url":"https://api.github.com/repos/aptible/captain-comeback/subscription","commits_url":"https://api.github.com/repos/aptible/captain-comeback/commits{/sha}","git_commits_url":"https://api.github.com/repos/aptible/captain-comeback/git/commits{/sha}","comments_url":"https://api.github.com/repos/aptible/captain-comeback/comments{/number}","issue_comment_url":"https://api.github.com/repos/aptible/captain-comeback/issues/comments{/number}","contents_url":"https://api.github.com/repos/aptible/captain-comeback/contents/{+path}","compare_url":"https://api.github.com/repos/aptible/captain-comeback/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aptible/captain-comeback/merges","archive_url":"https://api.github.com/repos/aptible/captain-comeback/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aptible/captain-comeback/downloads","issues_url":"https://api.github.com/repos/aptible/captain-comeback/issues{/number}","pulls_url":"https://api.github.com/repos/aptible/captain-comeback/pulls{/number}","milestones_url":"https://api.github.com/repos/aptible/captain-comeback/milestones{/number}","notifications_url":"https://api.github.com/repos/aptible/captain-comeback/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aptible/captain-comeback/labels{/name}","releases_url":"https://api.github.com/repos/aptible/captain-comeback/releases{/id}","deployments_url":"https://api.github.com/repos/aptible/captain-comeback/deployments","created_at":"2016-07-07T14:35:56Z","updated_at":"2016-07-12T11:12:23Z","pushed_at":"2016-09-07T13:24:19Z","git_url":"git://github.com/aptible/captain-comeback.git","ssh_url":"git@github.com:aptible/captain-comeback.git","clone_url":"https://github.com/aptible/captain-comeback.git","svn_url":"https://github.com/aptible/captain-comeback","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aptible/captain-comeback/pulls/5"},"html":{"href":"https://github.com/aptible/captain-comeback/pull/5"},"issue":{"href":"https://api.github.com/repos/aptible/captain-comeback/issues/5"},"comments":{"href":"https://api.github.com/repos/aptible/captain-comeback/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/aptible/captain-comeback/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/aptible/captain-comeback/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aptible/captain-comeback/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/aptible/captain-comeback/statuses/e9ca37295e81bff1e58ac974aee1b142df6868cc"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":40,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"krallin"}}