{"action":"created","comment":{"url":"https://api.github.com/repos/apache/apex-core/pulls/comments/74525780","id":74525780,"diff_hunk":"@@ -285,6 +286,17 @@ private void redoMapping()\n             if (finalUnifier == null) {\n               finalUnifier = createUnifier(streamMeta, plan);\n             }\n+            // detach downstream from upstream operator when no final unifier existed previously\n+            for (PTOutput unifierSource : unifierSources) {\n+              Iterator<PTInput> sinks = unifierSource.sinks.iterator();\n+              while (sinks.hasNext()) {\n+                PTInput sink = sinks.next();\n+                if (sink.target == doperEntry.first) {\n+                  doperEntry.first.inputs.remove(sink);\n+                  sinks.remove();\n+                }\n+              }\n+            }\n             setInput(doperEntry.first, doperEntry.second, finalUnifier, (pks == null) || (pks.mask == 0) ? null : pks);","path":"engine/src/main/java/com/datatorrent/stram/plan/physical/StreamMapping.java","position":null,"original_position":23,"commit_id":"ec377c6435206ddefa3825a9ff4fc6e64c38c653","original_commit_id":"326cd04aab940bfac27d22fdedf1df69d6a43318","user":{"login":"tweise","id":263695,"avatar_url":"https://avatars.githubusercontent.com/u/263695?v=3","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"body":"Good catch, made the change and also added the test coverage.","created_at":"2016-08-12T00:09:30Z","updated_at":"2016-08-12T00:09:30Z","html_url":"https://github.com/apache/apex-core/pull/365#discussion_r74525780","pull_request_url":"https://api.github.com/repos/apache/apex-core/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/apache/apex-core/pulls/comments/74525780"},"html":{"href":"https://github.com/apache/apex-core/pull/365#discussion_r74525780"},"pull_request":{"href":"https://api.github.com/repos/apache/apex-core/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/apache/apex-core/pulls/365","id":80905873,"html_url":"https://github.com/apache/apex-core/pull/365","diff_url":"https://github.com/apache/apex-core/pull/365.diff","patch_url":"https://github.com/apache/apex-core/pull/365.patch","issue_url":"https://api.github.com/repos/apache/apex-core/issues/365","number":365,"state":"open","locked":false,"title":"APEXCORE-494 Fix scale up from single partition when partition remain…","user":{"login":"tweise","id":263695,"avatar_url":"https://avatars.githubusercontent.com/u/263695?v=3","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"body":"…s unchanged.","created_at":"2016-08-11T05:34:38Z","updated_at":"2016-08-12T00:09:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"034c7feadffdc07dfc45167c5b4e42449e1f3d76","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/apex-core/pulls/365/commits","review_comments_url":"https://api.github.com/repos/apache/apex-core/pulls/365/comments","review_comment_url":"https://api.github.com/repos/apache/apex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/apex-core/issues/365/comments","statuses_url":"https://api.github.com/repos/apache/apex-core/statuses/ec377c6435206ddefa3825a9ff4fc6e64c38c653","head":{"label":"tweise:APEXCORE-494","ref":"APEXCORE-494","sha":"ec377c6435206ddefa3825a9ff4fc6e64c38c653","user":{"login":"tweise","id":263695,"avatar_url":"https://avatars.githubusercontent.com/u/263695?v=3","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"repo":{"id":41408222,"name":"apex-core","full_name":"tweise/apex-core","owner":{"login":"tweise","id":263695,"avatar_url":"https://avatars.githubusercontent.com/u/263695?v=3","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tweise/apex-core","description":"Mirror of Apache Apex core","fork":true,"url":"https://api.github.com/repos/tweise/apex-core","forks_url":"https://api.github.com/repos/tweise/apex-core/forks","keys_url":"https://api.github.com/repos/tweise/apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tweise/apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tweise/apex-core/teams","hooks_url":"https://api.github.com/repos/tweise/apex-core/hooks","issue_events_url":"https://api.github.com/repos/tweise/apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/tweise/apex-core/events","assignees_url":"https://api.github.com/repos/tweise/apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/tweise/apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/tweise/apex-core/tags","blobs_url":"https://api.github.com/repos/tweise/apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tweise/apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tweise/apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tweise/apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tweise/apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/tweise/apex-core/languages","stargazers_url":"https://api.github.com/repos/tweise/apex-core/stargazers","contributors_url":"https://api.github.com/repos/tweise/apex-core/contributors","subscribers_url":"https://api.github.com/repos/tweise/apex-core/subscribers","subscription_url":"https://api.github.com/repos/tweise/apex-core/subscription","commits_url":"https://api.github.com/repos/tweise/apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tweise/apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tweise/apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tweise/apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tweise/apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/tweise/apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tweise/apex-core/merges","archive_url":"https://api.github.com/repos/tweise/apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tweise/apex-core/downloads","issues_url":"https://api.github.com/repos/tweise/apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/tweise/apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/tweise/apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/tweise/apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tweise/apex-core/labels{/name}","releases_url":"https://api.github.com/repos/tweise/apex-core/releases{/id}","deployments_url":"https://api.github.com/repos/tweise/apex-core/deployments","created_at":"2015-08-26T06:22:33Z","updated_at":"2016-06-04T00:07:49Z","pushed_at":"2016-08-12T00:07:25Z","git_url":"git://github.com/tweise/apex-core.git","ssh_url":"git@github.com:tweise/apex-core.git","clone_url":"https://github.com/tweise/apex-core.git","svn_url":"https://github.com/tweise/apex-core","homepage":"","size":13691,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"130ce6ba8af9bc9c68c7940bbaeb06c7d0f32784","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348333,"name":"apex-core","full_name":"apache/apex-core","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/apex-core","description":"Mirror of Apache Apex core","fork":false,"url":"https://api.github.com/repos/apache/apex-core","forks_url":"https://api.github.com/repos/apache/apex-core/forks","keys_url":"https://api.github.com/repos/apache/apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/apex-core/teams","hooks_url":"https://api.github.com/repos/apache/apex-core/hooks","issue_events_url":"https://api.github.com/repos/apache/apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/apex-core/events","assignees_url":"https://api.github.com/repos/apache/apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/apex-core/tags","blobs_url":"https://api.github.com/repos/apache/apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/apex-core/languages","stargazers_url":"https://api.github.com/repos/apache/apex-core/stargazers","contributors_url":"https://api.github.com/repos/apache/apex-core/contributors","subscribers_url":"https://api.github.com/repos/apache/apex-core/subscribers","subscription_url":"https://api.github.com/repos/apache/apex-core/subscription","commits_url":"https://api.github.com/repos/apache/apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/apex-core/merges","archive_url":"https://api.github.com/repos/apache/apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/apex-core/downloads","issues_url":"https://api.github.com/repos/apache/apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/apex-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/apex-core/releases{/id}","deployments_url":"https://api.github.com/repos/apache/apex-core/deployments","created_at":"2015-08-25T07:00:05Z","updated_at":"2016-08-11T06:34:27Z","pushed_at":"2016-08-12T00:07:26Z","git_url":"git://github.com/apache/apex-core.git","ssh_url":"git@github.com:apache/apex-core.git","clone_url":"https://github.com/apache/apex-core.git","svn_url":"https://github.com/apache/apex-core","homepage":"","size":20818,"stargazers_count":162,"watchers_count":162,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":104,"mirror_url":"git://git.apache.org/incubator-apex-core.git","open_issues_count":10,"forks":104,"open_issues":10,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/apex-core/pulls/365"},"html":{"href":"https://github.com/apache/apex-core/pull/365"},"issue":{"href":"https://api.github.com/repos/apache/apex-core/issues/365"},"comments":{"href":"https://api.github.com/repos/apache/apex-core/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/apex-core/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/apex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/apex-core/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/apache/apex-core/statuses/ec377c6435206ddefa3825a9ff4fc6e64c38c653"}}}}
{"actor":{"display_login":"tweise"}}