{"action":"created","comment":{"url":"https://api.github.com/repos/japaric/cortex-m/pulls/comments/88780977","pull_request_review_id":9346775,"id":88780977,"diff_hunk":"@@ -28,20 +57,22 @@ pub unsafe fn enable() {\n \n /// Execute closure `f` in an interrupt-free context.\n /// This as also known as a \"critical section\".\n-pub unsafe fn free<F>(f: F)\n-    where F: FnOnce()\n+pub unsafe fn free<F, R>(f: F) -> R","path":"src/interrupt.rs","position":41,"original_position":41,"commit_id":"0b774e9e9850ca483afaf89c09ee2e5841050fa7","original_commit_id":"0b774e9e9850ca483afaf89c09ee2e5841050fa7","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"body":"This is \"technically\" a breaking change because it breaks generic code. But I expect that most people is using this in a concrete way: `interrupt::free(|| something())` and that will continue to work so I'm *not* going to bump the version to 0.2 because of this.","created_at":"2016-11-19T15:02:23Z","updated_at":"2016-11-19T15:02:23Z","html_url":"https://github.com/japaric/cortex-m/pull/12#discussion_r88780977","pull_request_url":"https://api.github.com/repos/japaric/cortex-m/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/japaric/cortex-m/pulls/comments/88780977"},"html":{"href":"https://github.com/japaric/cortex-m/pull/12#discussion_r88780977"},"pull_request":{"href":"https://api.github.com/repos/japaric/cortex-m/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/japaric/cortex-m/pulls/12","id":94484120,"html_url":"https://github.com/japaric/cortex-m/pull/12","diff_url":"https://github.com/japaric/cortex-m/pull/12.diff","patch_url":"https://github.com/japaric/cortex-m/pull/12.patch","issue_url":"https://api.github.com/repos/japaric/cortex-m/issues/12","number":12,"state":"open","locked":false,"title":"add a mutex based on critical sections","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"body":"cc @thejpster ","created_at":"2016-11-19T15:00:23Z","updated_at":"2016-11-19T15:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7affb977ea9a6a0c2a9f63088630409f6c194a38","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/japaric/cortex-m/pulls/12/commits","review_comments_url":"https://api.github.com/repos/japaric/cortex-m/pulls/12/comments","review_comment_url":"https://api.github.com/repos/japaric/cortex-m/pulls/comments{/number}","comments_url":"https://api.github.com/repos/japaric/cortex-m/issues/12/comments","statuses_url":"https://api.github.com/repos/japaric/cortex-m/statuses/0b774e9e9850ca483afaf89c09ee2e5841050fa7","head":{"label":"japaric:mutex","ref":"mutex","sha":"0b774e9e9850ca483afaf89c09ee2e5841050fa7","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"repo":{"id":69407378,"name":"cortex-m","full_name":"japaric/cortex-m","owner":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/japaric/cortex-m","description":"Low level access to Cortex-M processors","fork":false,"url":"https://api.github.com/repos/japaric/cortex-m","forks_url":"https://api.github.com/repos/japaric/cortex-m/forks","keys_url":"https://api.github.com/repos/japaric/cortex-m/keys{/key_id}","collaborators_url":"https://api.github.com/repos/japaric/cortex-m/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/japaric/cortex-m/teams","hooks_url":"https://api.github.com/repos/japaric/cortex-m/hooks","issue_events_url":"https://api.github.com/repos/japaric/cortex-m/issues/events{/number}","events_url":"https://api.github.com/repos/japaric/cortex-m/events","assignees_url":"https://api.github.com/repos/japaric/cortex-m/assignees{/user}","branches_url":"https://api.github.com/repos/japaric/cortex-m/branches{/branch}","tags_url":"https://api.github.com/repos/japaric/cortex-m/tags","blobs_url":"https://api.github.com/repos/japaric/cortex-m/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/japaric/cortex-m/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/japaric/cortex-m/git/refs{/sha}","trees_url":"https://api.github.com/repos/japaric/cortex-m/git/trees{/sha}","statuses_url":"https://api.github.com/repos/japaric/cortex-m/statuses/{sha}","languages_url":"https://api.github.com/repos/japaric/cortex-m/languages","stargazers_url":"https://api.github.com/repos/japaric/cortex-m/stargazers","contributors_url":"https://api.github.com/repos/japaric/cortex-m/contributors","subscribers_url":"https://api.github.com/repos/japaric/cortex-m/subscribers","subscription_url":"https://api.github.com/repos/japaric/cortex-m/subscription","commits_url":"https://api.github.com/repos/japaric/cortex-m/commits{/sha}","git_commits_url":"https://api.github.com/repos/japaric/cortex-m/git/commits{/sha}","comments_url":"https://api.github.com/repos/japaric/cortex-m/comments{/number}","issue_comment_url":"https://api.github.com/repos/japaric/cortex-m/issues/comments{/number}","contents_url":"https://api.github.com/repos/japaric/cortex-m/contents/{+path}","compare_url":"https://api.github.com/repos/japaric/cortex-m/compare/{base}...{head}","merges_url":"https://api.github.com/repos/japaric/cortex-m/merges","archive_url":"https://api.github.com/repos/japaric/cortex-m/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/japaric/cortex-m/downloads","issues_url":"https://api.github.com/repos/japaric/cortex-m/issues{/number}","pulls_url":"https://api.github.com/repos/japaric/cortex-m/pulls{/number}","milestones_url":"https://api.github.com/repos/japaric/cortex-m/milestones{/number}","notifications_url":"https://api.github.com/repos/japaric/cortex-m/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/japaric/cortex-m/labels{/name}","releases_url":"https://api.github.com/repos/japaric/cortex-m/releases{/id}","deployments_url":"https://api.github.com/repos/japaric/cortex-m/deployments","created_at":"2016-09-27T23:35:04Z","updated_at":"2016-11-19T03:19:03Z","pushed_at":"2016-11-19T15:00:23Z","git_url":"git://github.com/japaric/cortex-m.git","ssh_url":"git@github.com:japaric/cortex-m.git","clone_url":"https://github.com/japaric/cortex-m.git","svn_url":"https://github.com/japaric/cortex-m","homepage":null,"size":24,"stargazers_count":9,"watchers_count":9,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":9,"default_branch":"master"}},"base":{"label":"japaric:master","ref":"master","sha":"9d97ed3e739dba4c9bff0a4733035a355a91b896","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"repo":{"id":69407378,"name":"cortex-m","full_name":"japaric/cortex-m","owner":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/japaric/cortex-m","description":"Low level access to Cortex-M processors","fork":false,"url":"https://api.github.com/repos/japaric/cortex-m","forks_url":"https://api.github.com/repos/japaric/cortex-m/forks","keys_url":"https://api.github.com/repos/japaric/cortex-m/keys{/key_id}","collaborators_url":"https://api.github.com/repos/japaric/cortex-m/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/japaric/cortex-m/teams","hooks_url":"https://api.github.com/repos/japaric/cortex-m/hooks","issue_events_url":"https://api.github.com/repos/japaric/cortex-m/issues/events{/number}","events_url":"https://api.github.com/repos/japaric/cortex-m/events","assignees_url":"https://api.github.com/repos/japaric/cortex-m/assignees{/user}","branches_url":"https://api.github.com/repos/japaric/cortex-m/branches{/branch}","tags_url":"https://api.github.com/repos/japaric/cortex-m/tags","blobs_url":"https://api.github.com/repos/japaric/cortex-m/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/japaric/cortex-m/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/japaric/cortex-m/git/refs{/sha}","trees_url":"https://api.github.com/repos/japaric/cortex-m/git/trees{/sha}","statuses_url":"https://api.github.com/repos/japaric/cortex-m/statuses/{sha}","languages_url":"https://api.github.com/repos/japaric/cortex-m/languages","stargazers_url":"https://api.github.com/repos/japaric/cortex-m/stargazers","contributors_url":"https://api.github.com/repos/japaric/cortex-m/contributors","subscribers_url":"https://api.github.com/repos/japaric/cortex-m/subscribers","subscription_url":"https://api.github.com/repos/japaric/cortex-m/subscription","commits_url":"https://api.github.com/repos/japaric/cortex-m/commits{/sha}","git_commits_url":"https://api.github.com/repos/japaric/cortex-m/git/commits{/sha}","comments_url":"https://api.github.com/repos/japaric/cortex-m/comments{/number}","issue_comment_url":"https://api.github.com/repos/japaric/cortex-m/issues/comments{/number}","contents_url":"https://api.github.com/repos/japaric/cortex-m/contents/{+path}","compare_url":"https://api.github.com/repos/japaric/cortex-m/compare/{base}...{head}","merges_url":"https://api.github.com/repos/japaric/cortex-m/merges","archive_url":"https://api.github.com/repos/japaric/cortex-m/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/japaric/cortex-m/downloads","issues_url":"https://api.github.com/repos/japaric/cortex-m/issues{/number}","pulls_url":"https://api.github.com/repos/japaric/cortex-m/pulls{/number}","milestones_url":"https://api.github.com/repos/japaric/cortex-m/milestones{/number}","notifications_url":"https://api.github.com/repos/japaric/cortex-m/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/japaric/cortex-m/labels{/name}","releases_url":"https://api.github.com/repos/japaric/cortex-m/releases{/id}","deployments_url":"https://api.github.com/repos/japaric/cortex-m/deployments","created_at":"2016-09-27T23:35:04Z","updated_at":"2016-11-19T03:19:03Z","pushed_at":"2016-11-19T15:00:23Z","git_url":"git://github.com/japaric/cortex-m.git","ssh_url":"git@github.com:japaric/cortex-m.git","clone_url":"https://github.com/japaric/cortex-m.git","svn_url":"https://github.com/japaric/cortex-m","homepage":null,"size":24,"stargazers_count":9,"watchers_count":9,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/japaric/cortex-m/pulls/12"},"html":{"href":"https://github.com/japaric/cortex-m/pull/12"},"issue":{"href":"https://api.github.com/repos/japaric/cortex-m/issues/12"},"comments":{"href":"https://api.github.com/repos/japaric/cortex-m/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/japaric/cortex-m/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/japaric/cortex-m/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/japaric/cortex-m/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/japaric/cortex-m/statuses/0b774e9e9850ca483afaf89c09ee2e5841050fa7"}}}}
{"actor":{"display_login":"japaric"}}