{"action":"created","comment":{"url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/comments/70189418","id":70189418,"diff_hunk":"@@ -260,12 +283,10 @@ export default class TracerImp extends EventEmitter {\n \n                 switch (suffix) {\n                 case 'traceid':\n-                    span.setFields({ trace_guid : value });\n+                    spanContext._traceGUID = value;","path":"src/imp/tracer_imp.js","position":136,"original_position":136,"commit_id":"021e5dae4b2ceb9e5f84a525a7c7379a64f45d18","original_commit_id":"691dd5b5e67b8588d2e59f6bd672452063420ca2","user":{"login":"bensigelman","id":2251553,"avatar_url":"https://avatars.githubusercontent.com/u/2251553?v=3","gravatar_id":"","url":"https://api.github.com/users/bensigelman","html_url":"https://github.com/bensigelman","followers_url":"https://api.github.com/users/bensigelman/followers","following_url":"https://api.github.com/users/bensigelman/following{/other_user}","gists_url":"https://api.github.com/users/bensigelman/gists{/gist_id}","starred_url":"https://api.github.com/users/bensigelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensigelman/subscriptions","organizations_url":"https://api.github.com/users/bensigelman/orgs","repos_url":"https://api.github.com/users/bensigelman/repos","events_url":"https://api.github.com/users/bensigelman/events{/privacy}","received_events_url":"https://api.github.com/users/bensigelman/received_events","type":"User","site_admin":false},"body":"hm, reading this over I realize there's a bug when extraction fails (we need to return `null` in that case)... I will fix this later, have to go soon.","created_at":"2016-07-10T22:23:21Z","updated_at":"2016-07-10T22:23:21Z","html_url":"https://github.com/lightstep/lightstep-tracer-javascript/pull/51#discussion_r70189418","pull_request_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/comments/70189418"},"html":{"href":"https://github.com/lightstep/lightstep-tracer-javascript/pull/51#discussion_r70189418"},"pull_request":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/51","id":76885141,"html_url":"https://github.com/lightstep/lightstep-tracer-javascript/pull/51","diff_url":"https://github.com/lightstep/lightstep-tracer-javascript/pull/51.diff","patch_url":"https://github.com/lightstep/lightstep-tracer-javascript/pull/51.patch","issue_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues/51","number":51,"state":"open","locked":false,"title":"Adjust to the SpanContext changes","user":{"login":"bensigelman","id":2251553,"avatar_url":"https://avatars.githubusercontent.com/u/2251553?v=3","gravatar_id":"","url":"https://api.github.com/users/bensigelman","html_url":"https://github.com/bensigelman","followers_url":"https://api.github.com/users/bensigelman/followers","following_url":"https://api.github.com/users/bensigelman/following{/other_user}","gists_url":"https://api.github.com/users/bensigelman/gists{/gist_id}","starred_url":"https://api.github.com/users/bensigelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensigelman/subscriptions","organizations_url":"https://api.github.com/users/bensigelman/orgs","repos_url":"https://api.github.com/users/bensigelman/repos","events_url":"https://api.github.com/users/bensigelman/events{/privacy}","received_events_url":"https://api.github.com/users/bensigelman/received_events","type":"User","site_admin":false},"body":"Also do a little bit of light cleansing from an OT standpoint.\r\n\r\n@bcronin the tests pass and eslint has no grievances. I will make a few comments inline.","created_at":"2016-07-10T22:14:47Z","updated_at":"2016-07-10T22:23:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98d8042e1f4e25f663fdeaa359906e565eabc517","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/51/commits","review_comments_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/51/comments","review_comment_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues/51/comments","statuses_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/statuses/021e5dae4b2ceb9e5f84a525a7c7379a64f45d18","head":{"label":"lightstep:bhs/span_context_changes","ref":"bhs/span_context_changes","sha":"021e5dae4b2ceb9e5f84a525a7c7379a64f45d18","user":{"login":"lightstep","id":16584245,"avatar_url":"https://avatars.githubusercontent.com/u/16584245?v=3","gravatar_id":"","url":"https://api.github.com/users/lightstep","html_url":"https://github.com/lightstep","followers_url":"https://api.github.com/users/lightstep/followers","following_url":"https://api.github.com/users/lightstep/following{/other_user}","gists_url":"https://api.github.com/users/lightstep/gists{/gist_id}","starred_url":"https://api.github.com/users/lightstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightstep/subscriptions","organizations_url":"https://api.github.com/users/lightstep/orgs","repos_url":"https://api.github.com/users/lightstep/repos","events_url":"https://api.github.com/users/lightstep/events{/privacy}","received_events_url":"https://api.github.com/users/lightstep/received_events","type":"Organization","site_admin":false},"repo":{"id":49531341,"name":"lightstep-tracer-javascript","full_name":"lightstep/lightstep-tracer-javascript","owner":{"login":"lightstep","id":16584245,"avatar_url":"https://avatars.githubusercontent.com/u/16584245?v=3","gravatar_id":"","url":"https://api.github.com/users/lightstep","html_url":"https://github.com/lightstep","followers_url":"https://api.github.com/users/lightstep/followers","following_url":"https://api.github.com/users/lightstep/following{/other_user}","gists_url":"https://api.github.com/users/lightstep/gists{/gist_id}","starred_url":"https://api.github.com/users/lightstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightstep/subscriptions","organizations_url":"https://api.github.com/users/lightstep/orgs","repos_url":"https://api.github.com/users/lightstep/repos","events_url":"https://api.github.com/users/lightstep/events{/privacy}","received_events_url":"https://api.github.com/users/lightstep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightstep/lightstep-tracer-javascript","description":"","fork":false,"url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript","forks_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/forks","keys_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/teams","hooks_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/hooks","issue_events_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/events","assignees_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/tags","blobs_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/languages","stargazers_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/stargazers","contributors_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/contributors","subscribers_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/subscribers","subscription_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/subscription","commits_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/merges","archive_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/downloads","issues_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/labels{/name}","releases_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/releases{/id}","deployments_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/deployments","created_at":"2016-01-12T21:54:18Z","updated_at":"2016-05-18T19:05:30Z","pushed_at":"2016-07-10T22:22:22Z","git_url":"git://github.com/lightstep/lightstep-tracer-javascript.git","ssh_url":"git@github.com:lightstep/lightstep-tracer-javascript.git","clone_url":"https://github.com/lightstep/lightstep-tracer-javascript.git","svn_url":"https://github.com/lightstep/lightstep-tracer-javascript","homepage":null,"size":434,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"lightstep:master","ref":"master","sha":"7c0e272c221492e0388c401381aee406bc86910b","user":{"login":"lightstep","id":16584245,"avatar_url":"https://avatars.githubusercontent.com/u/16584245?v=3","gravatar_id":"","url":"https://api.github.com/users/lightstep","html_url":"https://github.com/lightstep","followers_url":"https://api.github.com/users/lightstep/followers","following_url":"https://api.github.com/users/lightstep/following{/other_user}","gists_url":"https://api.github.com/users/lightstep/gists{/gist_id}","starred_url":"https://api.github.com/users/lightstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightstep/subscriptions","organizations_url":"https://api.github.com/users/lightstep/orgs","repos_url":"https://api.github.com/users/lightstep/repos","events_url":"https://api.github.com/users/lightstep/events{/privacy}","received_events_url":"https://api.github.com/users/lightstep/received_events","type":"Organization","site_admin":false},"repo":{"id":49531341,"name":"lightstep-tracer-javascript","full_name":"lightstep/lightstep-tracer-javascript","owner":{"login":"lightstep","id":16584245,"avatar_url":"https://avatars.githubusercontent.com/u/16584245?v=3","gravatar_id":"","url":"https://api.github.com/users/lightstep","html_url":"https://github.com/lightstep","followers_url":"https://api.github.com/users/lightstep/followers","following_url":"https://api.github.com/users/lightstep/following{/other_user}","gists_url":"https://api.github.com/users/lightstep/gists{/gist_id}","starred_url":"https://api.github.com/users/lightstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightstep/subscriptions","organizations_url":"https://api.github.com/users/lightstep/orgs","repos_url":"https://api.github.com/users/lightstep/repos","events_url":"https://api.github.com/users/lightstep/events{/privacy}","received_events_url":"https://api.github.com/users/lightstep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightstep/lightstep-tracer-javascript","description":"","fork":false,"url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript","forks_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/forks","keys_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/teams","hooks_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/hooks","issue_events_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/events","assignees_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/tags","blobs_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/languages","stargazers_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/stargazers","contributors_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/contributors","subscribers_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/subscribers","subscription_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/subscription","commits_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/merges","archive_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/downloads","issues_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/labels{/name}","releases_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/releases{/id}","deployments_url":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/deployments","created_at":"2016-01-12T21:54:18Z","updated_at":"2016-05-18T19:05:30Z","pushed_at":"2016-07-10T22:22:22Z","git_url":"git://github.com/lightstep/lightstep-tracer-javascript.git","ssh_url":"git@github.com:lightstep/lightstep-tracer-javascript.git","clone_url":"https://github.com/lightstep/lightstep-tracer-javascript.git","svn_url":"https://github.com/lightstep/lightstep-tracer-javascript","homepage":null,"size":434,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/51"},"html":{"href":"https://github.com/lightstep/lightstep-tracer-javascript/pull/51"},"issue":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues/51"},"comments":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/lightstep/lightstep-tracer-javascript/statuses/021e5dae4b2ceb9e5f84a525a7c7379a64f45d18"}}}}
{"actor":{"display_login":"bensigelman"}}