{"action":"created","issue":{"url":"https://api.github.com/repos/emacs-helm/helm/issues/1583","repository_url":"https://api.github.com/repos/emacs-helm/helm","labels_url":"https://api.github.com/repos/emacs-helm/helm/issues/1583/labels{/name}","comments_url":"https://api.github.com/repos/emacs-helm/helm/issues/1583/comments","events_url":"https://api.github.com/repos/emacs-helm/helm/issues/1583/events","html_url":"https://github.com/emacs-helm/helm/pull/1583","id":172151954,"number":1583,"title":"helm-do-grep-ag: search for text at the cursor position","user":{"login":"tddsg","id":20593743,"avatar_url":"https://avatars.githubusercontent.com/u/20593743?v=3","gravatar_id":"","url":"https://api.github.com/users/tddsg","html_url":"https://github.com/tddsg","followers_url":"https://api.github.com/users/tddsg/followers","following_url":"https://api.github.com/users/tddsg/following{/other_user}","gists_url":"https://api.github.com/users/tddsg/gists{/gist_id}","starred_url":"https://api.github.com/users/tddsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tddsg/subscriptions","organizations_url":"https://api.github.com/users/tddsg/orgs","repos_url":"https://api.github.com/users/tddsg/repos","events_url":"https://api.github.com/users/tddsg/events{/privacy}","received_events_url":"https://api.github.com/users/tddsg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-19T15:02:38Z","updated_at":"2016-08-19T15:27:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emacs-helm/helm/pulls/1583","html_url":"https://github.com/emacs-helm/helm/pull/1583","diff_url":"https://github.com/emacs-helm/helm/pull/1583.diff","patch_url":"https://github.com/emacs-helm/helm/pull/1583.patch"},"body":"Hello,\r\n\r\nI did a small improvement over the function `helm-do-grep-ag` that allows automatically inserting the text around the cursor or in the active region as an input of this function. This feature is quite common in some `helm` related functions, for example, `helm-occur`, `helm-projectile-grep`, but has not been updated to `helm-do-grep-ag`. \r\n\r\nSo I think that it could be useful, and in some sense more consistent, to have it implemented in `helm-do-grep-ag`.\r\n\r\nHow do you think about it? Please check if there is something can be improved about it?\r\n\r\nBests,\r\nTrung."},"comment":{"url":"https://api.github.com/repos/emacs-helm/helm/issues/comments/241049831","html_url":"https://github.com/emacs-helm/helm/pull/1583#issuecomment-241049831","issue_url":"https://api.github.com/repos/emacs-helm/helm/issues/1583","id":241049831,"user":{"login":"thierryvolpiatto","id":1533939,"avatar_url":"https://avatars.githubusercontent.com/u/1533939?v=3","gravatar_id":"","url":"https://api.github.com/users/thierryvolpiatto","html_url":"https://github.com/thierryvolpiatto","followers_url":"https://api.github.com/users/thierryvolpiatto/followers","following_url":"https://api.github.com/users/thierryvolpiatto/following{/other_user}","gists_url":"https://api.github.com/users/thierryvolpiatto/gists{/gist_id}","starred_url":"https://api.github.com/users/thierryvolpiatto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thierryvolpiatto/subscriptions","organizations_url":"https://api.github.com/users/thierryvolpiatto/orgs","repos_url":"https://api.github.com/users/thierryvolpiatto/repos","events_url":"https://api.github.com/users/thierryvolpiatto/events{/privacy}","received_events_url":"https://api.github.com/users/thierryvolpiatto/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T15:27:27Z","updated_at":"2016-08-19T15:27:27Z","body":"\ntddsg <notifications@github.com> writes:\n\n> Hello,\n>\n> I did a small improvement over the function helm-do-grep-ag that\n> allows automatically inserting the text around the cursor or in the\n> active region as an input of this function. This feature is quite\n> common in some helm related functions, for example, helm-occur,\n> helm-projectile-grep, but has not been updated to helm-do-grep-ag.\n>\n> So I think that it could be useful, and in some sense more consistent,\n> to have it implemented in helm-do-grep-ag.\n>\n> How do you think about it?\n\nI generally don't like adding thing-at-point in input, I prefer using\ndefault, which let you write immediately in prompt if what you want is\nnot thing-at-point, to achieve this, the only thing you have to do is:\n\n    (add-to-list 'helm-sources-using-default-as-input 'helm-source-grep-ag)\n\n> Please check if there is something can be improved about it?\n\nSo thanks for your PR, but I prefer not adding thing-at-point to input.\n\n-- \nThierry\n"}}
{"actor":{"display_login":"thierryvolpiatto"}}