{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/52296002","id":52296002,"diff_hunk":"@@ -111,8 +172,8 @@ func (dm *realDiskSpaceManager) isSpaceAvailable(fsType string, threshold int, f\n }\n \n func validatePolicy(policy DiskSpacePolicy) error {\n-\tif policy.DockerFreeDiskMB < 0 {\n-\t\treturn fmt.Errorf(\"free disk space should be non-negative. Invalid value %d for docker disk space threshold.\", policy.DockerFreeDiskMB)\n+\tif policy.ContainersFreeDiskMB < 0 {\n+\t\treturn fmt.Errorf(\"free disk space should be non-negative. Invalid value %d for docker disk space threshold.\", policy.ContainersFreeDiskMB)","path":"pkg/kubelet/disk_manager.go","position":108,"original_position":108,"commit_id":"09420886aeb79709be4d8ef7788880ffe935faa8","original_commit_id":"09420886aeb79709be4d8ef7788880ffe935faa8","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"needs update (docker)","created_at":"2016-02-09T11:29:44Z","updated_at":"2016-02-09T11:29:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/20887#discussion_r52296002","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20887","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/52296002"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20887#discussion_r52296002"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20887"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20887","id":58711102,"html_url":"https://github.com/kubernetes/kubernetes/pull/20887","diff_url":"https://github.com/kubernetes/kubernetes/pull/20887.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/20887.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20887","number":20887,"state":"open","locked":false,"title":"attempt at adding disk space monitoring for rkt","user":{"login":"sjpotter","id":1659735,"avatar_url":"https://avatars.githubusercontent.com/u/1659735?v=3","gravatar_id":"","url":"https://api.github.com/users/sjpotter","html_url":"https://github.com/sjpotter","followers_url":"https://api.github.com/users/sjpotter/followers","following_url":"https://api.github.com/users/sjpotter/following{/other_user}","gists_url":"https://api.github.com/users/sjpotter/gists{/gist_id}","starred_url":"https://api.github.com/users/sjpotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjpotter/subscriptions","organizations_url":"https://api.github.com/users/sjpotter/orgs","repos_url":"https://api.github.com/users/sjpotter/repos","events_url":"https://api.github.com/users/sjpotter/events{/privacy}","received_events_url":"https://api.github.com/users/sjpotter/received_events","type":"User","site_admin":false},"body":"proof of concept as cadvisor doesn't provide functionality for rkt yet.\r\n\r\nnot sure I'm happy w/ this, but figured it can spark discussion.","created_at":"2016-02-09T06:51:57Z","updated_at":"2016-02-09T11:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2f4ee7b20c309986c538a2734e4a39f3dedf3e5","assignee":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20887/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20887/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20887/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/09420886aeb79709be4d8ef7788880ffe935faa8","head":{"label":"sjpotter:rkt-diskmanager","ref":"rkt-diskmanager","sha":"09420886aeb79709be4d8ef7788880ffe935faa8","user":{"login":"sjpotter","id":1659735,"avatar_url":"https://avatars.githubusercontent.com/u/1659735?v=3","gravatar_id":"","url":"https://api.github.com/users/sjpotter","html_url":"https://github.com/sjpotter","followers_url":"https://api.github.com/users/sjpotter/followers","following_url":"https://api.github.com/users/sjpotter/following{/other_user}","gists_url":"https://api.github.com/users/sjpotter/gists{/gist_id}","starred_url":"https://api.github.com/users/sjpotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjpotter/subscriptions","organizations_url":"https://api.github.com/users/sjpotter/orgs","repos_url":"https://api.github.com/users/sjpotter/repos","events_url":"https://api.github.com/users/sjpotter/events{/privacy}","received_events_url":"https://api.github.com/users/sjpotter/received_events","type":"User","site_admin":false},"repo":{"id":51351187,"name":"kubernetes","full_name":"sjpotter/kubernetes","owner":{"login":"sjpotter","id":1659735,"avatar_url":"https://avatars.githubusercontent.com/u/1659735?v=3","gravatar_id":"","url":"https://api.github.com/users/sjpotter","html_url":"https://github.com/sjpotter","followers_url":"https://api.github.com/users/sjpotter/followers","following_url":"https://api.github.com/users/sjpotter/following{/other_user}","gists_url":"https://api.github.com/users/sjpotter/gists{/gist_id}","starred_url":"https://api.github.com/users/sjpotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjpotter/subscriptions","organizations_url":"https://api.github.com/users/sjpotter/orgs","repos_url":"https://api.github.com/users/sjpotter/repos","events_url":"https://api.github.com/users/sjpotter/events{/privacy}","received_events_url":"https://api.github.com/users/sjpotter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjpotter/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/sjpotter/kubernetes","forks_url":"https://api.github.com/repos/sjpotter/kubernetes/forks","keys_url":"https://api.github.com/repos/sjpotter/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjpotter/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjpotter/kubernetes/teams","hooks_url":"https://api.github.com/repos/sjpotter/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sjpotter/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sjpotter/kubernetes/events","assignees_url":"https://api.github.com/repos/sjpotter/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sjpotter/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sjpotter/kubernetes/tags","blobs_url":"https://api.github.com/repos/sjpotter/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjpotter/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjpotter/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjpotter/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjpotter/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sjpotter/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sjpotter/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sjpotter/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sjpotter/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sjpotter/kubernetes/subscription","commits_url":"https://api.github.com/repos/sjpotter/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjpotter/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjpotter/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjpotter/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjpotter/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sjpotter/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjpotter/kubernetes/merges","archive_url":"https://api.github.com/repos/sjpotter/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjpotter/kubernetes/downloads","issues_url":"https://api.github.com/repos/sjpotter/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sjpotter/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sjpotter/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sjpotter/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjpotter/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sjpotter/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/sjpotter/kubernetes/deployments","created_at":"2016-02-09T06:48:45Z","updated_at":"2016-02-09T06:48:56Z","pushed_at":"2016-02-09T06:51:11Z","git_url":"git://github.com/sjpotter/kubernetes.git","ssh_url":"git@github.com:sjpotter/kubernetes.git","clone_url":"https://github.com/sjpotter/kubernetes.git","svn_url":"https://github.com/sjpotter/kubernetes","homepage":"http://kubernetes.io","size":164444,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"beb5d01f9c72730768d875361ee9e0c08367a52e","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-02-09T11:10:51Z","pushed_at":"2016-02-09T11:05:37Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":321531,"stargazers_count":12579,"watchers_count":12579,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3580,"mirror_url":null,"open_issues_count":2807,"forks":3580,"open_issues":2807,"watchers":12579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20887"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20887"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20887"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20887/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20887/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20887/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/09420886aeb79709be4d8ef7788880ffe935faa8"}}}}