{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/85421521","pull_request_review_id":6137202,"id":85421521,"diff_hunk":"@@ -7798,6 +7802,53 @@ Example:\n Ignore all I<hdb> devices on any domain, but other block devices (eg. I<hda>)\n will be collected.\n \n+If I<BlockDeviceFormat> is set to B<dev>, then the device names will be the ones\n+in the I<target> node for the device in the XML definition of the domain. The\n+default is B<dev>. This is the behavior before adding the option.\n+\n+If I<BlockDeviceFormat> is set to B<source>, then the device names will be the ones\n+in the I<source> node for the device in the XML definition of the domain.\n+\n+Example:\n+\n+If the domain XML have the following device defined:\n+\n+   <disk type='block' device='disk'>\n+      <driver name='qemu' type='raw' cache='none' io='native' discard='unmap'/>\n+      <source dev='/var/lib/libvirt/images/image1.qcow2'/>\n+      <target dev='sda' bus='scsi'/>\n+      <boot order='2'/>\n+      <address type='drive' controller='0' bus='0' target='0' unit='0'/>\n+    </disk>\n+\n+setting \n+\n+\t BlockDeviceFormat dev\n+\n+will name the device in the graph as sda \n+\n+setting\n+ \n+\tBlockDeviceFormat source\n+\n+will name the device in the graph as var_lib_libvirt_images_image1.qcow2\n+\n+These names will also be part of the RRD filename.\n+\n+I<BlockDeviceFormatBasename> - this option is honored if and only if \n+option I<BlockDeviceFormat> is set to B<source>. If set to B<true> then \n+only the last part of the path will be used for device name and naming the\n+RRD file.\n+\n+Example: \n+\n+if the device path (source tag) is: /var/lib/libvirt/images/image1.qcow2","path":"src/collectd.conf.pod","position":55,"original_position":55,"commit_id":"46157584a54b425e80a68383b76998f9d0945175","original_commit_id":"46157584a54b425e80a68383b76998f9d0945175","user":{"login":"octo","id":116087,"avatar_url":"https://avatars.githubusercontent.com/u/116087?v=3","gravatar_id":"","url":"https://api.github.com/users/octo","html_url":"https://github.com/octo","followers_url":"https://api.github.com/users/octo/followers","following_url":"https://api.github.com/users/octo/following{/other_user}","gists_url":"https://api.github.com/users/octo/gists{/gist_id}","starred_url":"https://api.github.com/users/octo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octo/subscriptions","organizations_url":"https://api.github.com/users/octo/orgs","repos_url":"https://api.github.com/users/octo/repos","events_url":"https://api.github.com/users/octo/events{/privacy}","received_events_url":"https://api.github.com/users/octo/received_events","type":"User","site_admin":false},"body":"`C</var/lib/libvirt/images/image1.qcow2>`","created_at":"2016-10-27T20:33:10Z","updated_at":"2016-10-27T20:34:52Z","html_url":"https://github.com/collectd/collectd/pull/2004#discussion_r85421521","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/2004","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/85421521"},"html":{"href":"https://github.com/collectd/collectd/pull/2004#discussion_r85421521"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2004"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/2004","id":91025431,"html_url":"https://github.com/collectd/collectd/pull/2004","diff_url":"https://github.com/collectd/collectd/pull/2004.diff","patch_url":"https://github.com/collectd/collectd/pull/2004.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/2004","number":2004,"state":"open","locked":false,"title":"virt plugin: Add the BlockDeviceFormat and BlockDeviceFormatBasename options.","user":{"login":"dchepishev","id":23075625,"avatar_url":"https://avatars.githubusercontent.com/u/23075625?v=3","gravatar_id":"","url":"https://api.github.com/users/dchepishev","html_url":"https://github.com/dchepishev","followers_url":"https://api.github.com/users/dchepishev/followers","following_url":"https://api.github.com/users/dchepishev/following{/other_user}","gists_url":"https://api.github.com/users/dchepishev/gists{/gist_id}","starred_url":"https://api.github.com/users/dchepishev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchepishev/subscriptions","organizations_url":"https://api.github.com/users/dchepishev/orgs","repos_url":"https://api.github.com/users/dchepishev/repos","events_url":"https://api.github.com/users/dchepishev/events{/privacy}","received_events_url":"https://api.github.com/users/dchepishev/received_events","type":"User","site_admin":false},"body":"Added options:\r\nBlockDeviceFormat\r\nBlockDeviceFormatBasename","created_at":"2016-10-26T15:13:20Z","updated_at":"2016-10-27T20:34:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69b29a48fef9b4666f21ca387e3410d0ede3f186","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/2004/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/2004/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/2004/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/46157584a54b425e80a68383b76998f9d0945175","head":{"label":"dchepishev:dchepishev_virt_bd_path_patch","ref":"dchepishev_virt_bd_path_patch","sha":"46157584a54b425e80a68383b76998f9d0945175","user":{"login":"dchepishev","id":23075625,"avatar_url":"https://avatars.githubusercontent.com/u/23075625?v=3","gravatar_id":"","url":"https://api.github.com/users/dchepishev","html_url":"https://github.com/dchepishev","followers_url":"https://api.github.com/users/dchepishev/followers","following_url":"https://api.github.com/users/dchepishev/following{/other_user}","gists_url":"https://api.github.com/users/dchepishev/gists{/gist_id}","starred_url":"https://api.github.com/users/dchepishev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchepishev/subscriptions","organizations_url":"https://api.github.com/users/dchepishev/orgs","repos_url":"https://api.github.com/users/dchepishev/repos","events_url":"https://api.github.com/users/dchepishev/events{/privacy}","received_events_url":"https://api.github.com/users/dchepishev/received_events","type":"User","site_admin":false},"repo":{"id":71994622,"name":"collectd","full_name":"dchepishev/collectd","owner":{"login":"dchepishev","id":23075625,"avatar_url":"https://avatars.githubusercontent.com/u/23075625?v=3","gravatar_id":"","url":"https://api.github.com/users/dchepishev","html_url":"https://github.com/dchepishev","followers_url":"https://api.github.com/users/dchepishev/followers","following_url":"https://api.github.com/users/dchepishev/following{/other_user}","gists_url":"https://api.github.com/users/dchepishev/gists{/gist_id}","starred_url":"https://api.github.com/users/dchepishev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchepishev/subscriptions","organizations_url":"https://api.github.com/users/dchepishev/orgs","repos_url":"https://api.github.com/users/dchepishev/repos","events_url":"https://api.github.com/users/dchepishev/events{/privacy}","received_events_url":"https://api.github.com/users/dchepishev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dchepishev/collectd","description":"The system statistics collection daemon. Please send Pull Requests here!","fork":true,"url":"https://api.github.com/repos/dchepishev/collectd","forks_url":"https://api.github.com/repos/dchepishev/collectd/forks","keys_url":"https://api.github.com/repos/dchepishev/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dchepishev/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dchepishev/collectd/teams","hooks_url":"https://api.github.com/repos/dchepishev/collectd/hooks","issue_events_url":"https://api.github.com/repos/dchepishev/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/dchepishev/collectd/events","assignees_url":"https://api.github.com/repos/dchepishev/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/dchepishev/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/dchepishev/collectd/tags","blobs_url":"https://api.github.com/repos/dchepishev/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dchepishev/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dchepishev/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dchepishev/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dchepishev/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/dchepishev/collectd/languages","stargazers_url":"https://api.github.com/repos/dchepishev/collectd/stargazers","contributors_url":"https://api.github.com/repos/dchepishev/collectd/contributors","subscribers_url":"https://api.github.com/repos/dchepishev/collectd/subscribers","subscription_url":"https://api.github.com/repos/dchepishev/collectd/subscription","commits_url":"https://api.github.com/repos/dchepishev/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dchepishev/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dchepishev/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dchepishev/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dchepishev/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/dchepishev/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dchepishev/collectd/merges","archive_url":"https://api.github.com/repos/dchepishev/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dchepishev/collectd/downloads","issues_url":"https://api.github.com/repos/dchepishev/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/dchepishev/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/dchepishev/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/dchepishev/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dchepishev/collectd/labels{/name}","releases_url":"https://api.github.com/repos/dchepishev/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/dchepishev/collectd/deployments","created_at":"2016-10-26T10:59:46Z","updated_at":"2016-10-26T10:59:49Z","pushed_at":"2016-10-26T15:16:45Z","git_url":"git://github.com/dchepishev/collectd.git","ssh_url":"git@github.com:dchepishev/collectd.git","clone_url":"https://github.com/dchepishev/collectd.git","svn_url":"https://github.com/dchepishev/collectd","homepage":"http://collectd.org/","size":15422,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"bf70b5ba18d3fc58f976f2923ecf7135900537a7","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2016-10-27T12:54:11Z","pushed_at":"2016-10-27T20:13:44Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":35358,"stargazers_count":1312,"watchers_count":1312,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":729,"mirror_url":null,"open_issues_count":305,"forks":729,"open_issues":305,"watchers":1312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2004"},"html":{"href":"https://github.com/collectd/collectd/pull/2004"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/2004"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/2004/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2004/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2004/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/46157584a54b425e80a68383b76998f9d0945175"}}}}
{"actor":{"display_login":"octo"}}