{"action":"created","issue":{"url":"https://api.github.com/repos/sd16spring/GeneFinder/issues/44","repository_url":"https://api.github.com/repos/sd16spring/GeneFinder","labels_url":"https://api.github.com/repos/sd16spring/GeneFinder/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/sd16spring/GeneFinder/issues/44/comments","events_url":"https://api.github.com/repos/sd16spring/GeneFinder/issues/44/events","html_url":"https://github.com/sd16spring/GeneFinder/pull/44","id":132043739,"number":44,"title":"Committing my gene finder","user":{"login":"LivKelley","id":15851182,"avatar_url":"https://avatars.githubusercontent.com/u/15851182?v=3","gravatar_id":"","url":"https://api.github.com/users/LivKelley","html_url":"https://github.com/LivKelley","followers_url":"https://api.github.com/users/LivKelley/followers","following_url":"https://api.github.com/users/LivKelley/following{/other_user}","gists_url":"https://api.github.com/users/LivKelley/gists{/gist_id}","starred_url":"https://api.github.com/users/LivKelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LivKelley/subscriptions","organizations_url":"https://api.github.com/users/LivKelley/orgs","repos_url":"https://api.github.com/users/LivKelley/repos","events_url":"https://api.github.com/users/LivKelley/events{/privacy}","received_events_url":"https://api.github.com/users/LivKelley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-08T03:16:01Z","updated_at":"2016-02-10T03:38:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sd16spring/GeneFinder/pulls/44","html_url":"https://github.com/sd16spring/GeneFinder/pull/44","diff_url":"https://github.com/sd16spring/GeneFinder/pull/44.diff","patch_url":"https://github.com/sd16spring/GeneFinder/pull/44.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/sd16spring/genefinder/44)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sd16spring/GeneFinder/issues/comments/182183847","html_url":"https://github.com/sd16spring/GeneFinder/pull/44#issuecomment-182183847","issue_url":"https://api.github.com/repos/sd16spring/GeneFinder/issues/44","id":182183847,"user":{"login":"phuston","id":7811805,"avatar_url":"https://avatars.githubusercontent.com/u/7811805?v=3","gravatar_id":"","url":"https://api.github.com/users/phuston","html_url":"https://github.com/phuston","followers_url":"https://api.github.com/users/phuston/followers","following_url":"https://api.github.com/users/phuston/following{/other_user}","gists_url":"https://api.github.com/users/phuston/gists{/gist_id}","starred_url":"https://api.github.com/users/phuston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phuston/subscriptions","organizations_url":"https://api.github.com/users/phuston/orgs","repos_url":"https://api.github.com/users/phuston/repos","events_url":"https://api.github.com/users/phuston/events{/privacy}","received_events_url":"https://api.github.com/users/phuston/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T03:38:48Z","updated_at":"2016-02-10T03:38:48Z","body":"\n\n\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, 8 unresolved discussions.\n\n---\n\n*[gene_finder.py, line 34 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/genefinder/44#-KA8CHoL47e4cN6Exu_A:-KA8CHoL47e4cN6Exu_B:1899200709) ([raw file](https://github.com/sd16spring/genefinder/blob/e3b5da82ddfd76d2b9052226807ec8f56e5e43e3/gene_finder.py#L34)):*\nSeems reasonable, good comment of explanation.\n\nIn general, however, it is a good idea to test edge cases in doctests, or cases that might cause a function to error out - in this case, you might try inputting something that isn't a valid nucleotide at all.\n\n---\n\n*[gene_finder.py, line 37 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/genefinder/44#-KA8CC5l8PofRmavP3y0:-KA8CC5l8PofRmavP3y1:1449441139) ([raw file](https://github.com/sd16spring/genefinder/blob/e3b5da82ddfd76d2b9052226807ec8f56e5e43e3/gene_finder.py#L37)):*\nFeel free to take out all of these #TODO comments as you complete those parts of the assignment. Same goes for all #TODO comments below.\n\n---\n\n*[gene_finder.py, line 47 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/genefinder/44#-KA8CeL6oi-2DDQztTke:-KA8CeL7WvTZQTAJ1QI3:-566103453) ([raw file](https://github.com/sd16spring/genefinder/blob/e3b5da82ddfd76d2b9052226807ec8f56e5e43e3/gene_finder.py#L47)):*\nNice error handling. Something else you could try is looking to raising errors in python.\n\nIn this case, you could use 'raise ValueError(<Error message here>)'\n\n---\n\n*[gene_finder.py, line 88 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/genefinder/44#-KA8D21-HKo5KkUcO2F_:-KA8D21-HKo5KkUcO2Fa:-279215820) ([raw file](https://github.com/sd16spring/genefinder/blob/e3b5da82ddfd76d2b9052226807ec8f56e5e43e3/gene_finder.py#L88)):*\nNice. Great job adding some good extra test coverage.\n\n---\n\n*[gene_finder.py, line 99 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/genefinder/44#-KA8D6sKgwwhBddZ9D01:-KA8D6sKgwwhBddZ9D02:15100089) ([raw file](https://github.com/sd16spring/genefinder/blob/e3b5da82ddfd76d2b9052226807ec8f56e5e43e3/gene_finder.py#L99)):*\nYay comments!\n\n---\n\n*[gene_finder.py, line 112 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/genefinder/44#-KA8D92vXxnujtabPw9K:-KA8D92wQgvgvgIf9egX:472296282) ([raw file](https://github.com/sd16spring/genefinder/blob/e3b5da82ddfd76d2b9052226807ec8f56e5e43e3/gene_finder.py#L112)):*\nAwesome, thanks for the heads up. Collaboration is totally okay, thanks for mentioning it here. +1000\n\n---\n\n*[gene_finder.py, line 209 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/genefinder/44#-KA8EYK_h29zdIpyRqq0:-KA8EYK_h29zdIpyRqq1:-592831399) ([raw file](https://github.com/sd16spring/genefinder/blob/e3b5da82ddfd76d2b9052226807ec8f56e5e43e3/gene_finder.py#L209)):*\nThe range function by default starts at 0, meaning the first argument here is redundant.\n\n---\n\n*[gene_finder.py, line 223 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/genefinder/44#-KA8Er-JdheURhdL8H2C:-KA8Er-JdheURhdL8H2D:-1287178199) ([raw file](https://github.com/sd16spring/genefinder/blob/e3b5da82ddfd76d2b9052226807ec8f56e5e43e3/gene_finder.py#L223)):*\nWriting doctests is not an easy thing to do, but it'd be good to include a nontrivial test here\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/sd16spring/genefinder/44)*\n<!-- Sent from Reviewable.io -->\n"}}