{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/7641","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/7641/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7641/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/7641/events","html_url":"https://github.com/openshift/origin/pull/7641","id":136525412,"number":7641,"title":"Add full volume control to SCC","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-25T22:02:04Z","updated_at":"2016-03-04T14:12:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7641","html_url":"https://github.com/openshift/origin/pull/7641","diff_url":"https://github.com/openshift/origin/pull/7641.diff","patch_url":"https://github.com/openshift/origin/pull/7641.patch"},"body":"WIP - add full volume control to SCC.  In upstream PSP we have proposed using a Volumes slice on the SCC to control volumes.  This introduces that attribute to the SCC\r\n\r\nFixes https://github.com/openshift/origin/issues/7630\r\n\r\nImportant: \r\n\r\n1.  the comment on PSP was that if the slice was empty you are allowing all volumes.  This is not the case in this PR.  I think we can argue against it upstream if need be.  Nothing has been implemented yet to enforce it in kube.\r\n1.  please take note of how the interaction with `Allow*` fields works in conversions and defaulters\r\n\r\nOpen Questions\r\n\r\n1.  Can we retcon the addition of `AllowEmptyDir` in the SCC?  It was added and tagged in 1.1.3 but nothing was noted in the release for it.  I'd like to just rip it out if possible.  For now I've included the conversion code for it.\r\n\r\n- [x] types\r\n- [x] conversions, generation, and defaulting\r\n- [x] enforcement in the provider\r\n- [x] bootstrap settings\r\n\r\n@smarterclayton @liggitt @pmorie @childsb @eparis "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/192297043","html_url":"https://github.com/openshift/origin/pull/7641#issuecomment-192297043","issue_url":"https://api.github.com/repos/openshift/origin/issues/7641","id":192297043,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T14:12:42Z","updated_at":"2016-03-04T14:12:42Z","body":"We need to release note in 1.1.4 that users upgrading should run SCC reconcile.  Otherwise LGTM, do we have other comments?"}}