{"push_id":1071936763,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"0b472d860260f7063aee742939be23b921382741","before":"5843e6872f495fb0ad2f16e3805794eaf90a461b","commits":[{"sha":"0b472d860260f7063aee742939be23b921382741","author":{"email":"dbc64ab8a675880673029ed6b2cb1d084dfef0bb@gmail.com","name":"Micah Kornfield"},"message":"ARROW-82: Initial IPC support for ListArray\n\nThis is a work in progress because I can't get clang-tidy to shut-up on parameterized test files (see last commit which I need to revert before merge).   I'd like to make sure this is a clean build and make sure people are ok with these change.  This PR also has a lot of collateral damage for small/large things I cleaned up my way to make this work.  I tried to split the commits up logically but if people would prefer separate pull requests I can try to do that as well.\n\nOpen questions:\n1.  For supporting strings, binary, etc.  I was thinking of changing thei4 type definitions to inherit from ListType, and to hard-code the child type.  This would allow for simpler IPC code (all of the instantiation of types would happen in construct.h/.cc?) vs handling each of there types separately for IPC.\n2.  There are some TODOs I left sprinkled in the code and would like peoples thoughts on if they are urgent/worthwhile for following up on.\n\nOpen issues:\n1.  Supporting the rest of the List backed logical types\n2.  More unit tests for added functionality.\n\nAs part of this commit I also refactored the Builder interfaces a little bit for the following reasons:\n1.  It seems that if ArrayBuilder owns the bitmap it should be responsible for having methods to manipulate it.\n2.  This allows ListBuilder to use the parent class + a BufferBuilder instead of inheriting Int32Builder, which means it doesn't need to do strange length/capacity hacks.\n\nOther misc things here:\n1.  Native popcount in test-util.h\n2.  Ability to build a new list on top of an existing by incrementally add offsets/sizes\n3.  Added missing types primitive types in construct.h for primitive.\n\nAuthor: Micah Kornfield <emkornfield@gmail.com>\n\nCloses #59 from emkornfield/emk_list_ipc_PR and squashes the following commits:\n\n0c5162d [Micah Kornfield] another format fix\n0af558b [Micah Kornfield] remove a now unnecessary NOLINT, but mostly to trigger another travis-ci job that failed due to apt get issue\n7789205 [Micah Kornfield] make clang-format-3.7 happy\n6e57728 [Micah Kornfield] make format fixes\n5e15815 [Micah Kornfield] fix make lint\n8982723 [Micah Kornfield] remaining style cleanup\nbe04b3e [Micah Kornfield] add unit tests for zero length row batches and non-null batches.  fix bugs\n10e6651 [Micah Kornfield] add in maximum recursion depth, surfaced possible recursion issue with flatbuffers\n3b219a1 [Micah Kornfield] Make append is_null parameter is_valid for api consistency\n2e6c477 [Micah Kornfield] add missing RETURN_NOT_OK\ne71810b [Micah Kornfield] make Resize and Init virtual on builder\n8ab5315 [Micah Kornfield] make clang tidy ignore a little bit less hacky\n53d37bc [Micah Kornfield] filter out ipc-adapter-test from tidy\n8e464b5 [Micah Kornfield] Fixes per tidy and lint\naa0602c [Micah Kornfield] add potentially useful pool factories to test utils\n39c57ed [Micah Kornfield] add potentially useful methods for generative arrays to ipc test-common\na2e1e52 [Micah Kornfield] native popcount\n61b0481 [Micah Kornfield] small fixes to naming/style for c++ and potential bugs\n5f87aef [Micah Kornfield] Refactor ipc-adapter-test to make it paramaterizable.  add unit test for lists.  make unit test pass and and construction method for list arrays\n45e41c0 [Micah Kornfield] Make BufferBuilder more useable for appending primitives\n1374485 [Micah Kornfield] augment python unittest to have null element in list\n20f984b [Micah Kornfield] refactor primitive builders to use parent builders bitmap\n3895d34 [Micah Kornfield] Refactor list builder to use ArrayBuilders bitmap methods and a separate buffer builder\n01c50be [Micah Kornfield] Add utility methods for managing null bitmap directly to ArrayBuilder\ncc7f851 [Micah Kornfield] add Validate method to array and implementation for ListArray","distinct":true,"url":"https://api.github.com/repos/apache/arrow/commits/0b472d860260f7063aee742939be23b921382741"}]}