{"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/comments/80124833","id":80124833,"diff_hunk":"@@ -125,7 +125,7 @@ HashSet<ITypeSymbol> typeStack\n \r\n \t\t\t\t{\r\n \t\t\t\t\tforeach( ISymbol member in type.GetMembers() ) {\r\n-\t\t\t\t\t\tif( IsMemberMutableRecursive( member, typeStack ) ) {\r\n+\t\t\t\t\t\tif( !member.IsStatic && IsMemberMutableRecursive( member, typeStack ) ) {\r","path":"src/D2L.CodeStyle.Analysis/MutabilityInspector.cs","position":5,"original_position":5,"commit_id":"589e5feb53298aaa52606b50b5614d10c2c6d176","original_commit_id":"589e5feb53298aaa52606b50b5614d10c2c6d176","user":{"login":"travisMiehm","id":1072547,"avatar_url":"https://avatars.githubusercontent.com/u/1072547?v=3","gravatar_id":"","url":"https://api.github.com/users/travisMiehm","html_url":"https://github.com/travisMiehm","followers_url":"https://api.github.com/users/travisMiehm/followers","following_url":"https://api.github.com/users/travisMiehm/following{/other_user}","gists_url":"https://api.github.com/users/travisMiehm/gists{/gist_id}","starred_url":"https://api.github.com/users/travisMiehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisMiehm/subscriptions","organizations_url":"https://api.github.com/users/travisMiehm/orgs","repos_url":"https://api.github.com/users/travisMiehm/repos","events_url":"https://api.github.com/users/travisMiehm/events{/privacy}","received_events_url":"https://api.github.com/users/travisMiehm/received_events","type":"User","site_admin":false},"body":"In the case of `Foo`, it is not just the `static` that makes it safe.  The `readonly` is also needed.\r\n\r\nConsider your second case where `Default` is not `readonly`.  No longer safe.\r\n\r\nWhat about \r\n\r\n```\r\npublic class Foo {\r\n    public static readonly Bar Default = new Bar();\r\n}\r\n```\r\n\r\nwhere `Bar` is mutable?","created_at":"2016-09-22T20:06:18Z","updated_at":"2016-09-22T20:06:18Z","html_url":"https://github.com/Brightspace/D2L.CodeStyle/pull/15#discussion_r80124833","pull_request_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/comments/80124833"},"html":{"href":"https://github.com/Brightspace/D2L.CodeStyle/pull/15#discussion_r80124833"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/15","id":86378405,"html_url":"https://github.com/Brightspace/D2L.CodeStyle/pull/15","diff_url":"https://github.com/Brightspace/D2L.CodeStyle/pull/15.diff","patch_url":"https://github.com/Brightspace/D2L.CodeStyle/pull/15.patch","issue_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/15","number":15,"state":"open","locked":false,"title":"Ignore static members when inspecting for immutability.","user":{"login":"saquibmian","id":2387703,"avatar_url":"https://avatars.githubusercontent.com/u/2387703?v=3","gravatar_id":"","url":"https://api.github.com/users/saquibmian","html_url":"https://github.com/saquibmian","followers_url":"https://api.github.com/users/saquibmian/followers","following_url":"https://api.github.com/users/saquibmian/following{/other_user}","gists_url":"https://api.github.com/users/saquibmian/gists{/gist_id}","starred_url":"https://api.github.com/users/saquibmian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquibmian/subscriptions","organizations_url":"https://api.github.com/users/saquibmian/orgs","repos_url":"https://api.github.com/users/saquibmian/repos","events_url":"https://api.github.com/users/saquibmian/events{/privacy}","received_events_url":"https://api.github.com/users/saquibmian/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-22T17:16:24Z","updated_at":"2016-09-22T20:06:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5fe90ab686b6453b95005d91ef41c94fd811442","assignee":{"login":"travisMiehm","id":1072547,"avatar_url":"https://avatars.githubusercontent.com/u/1072547?v=3","gravatar_id":"","url":"https://api.github.com/users/travisMiehm","html_url":"https://github.com/travisMiehm","followers_url":"https://api.github.com/users/travisMiehm/followers","following_url":"https://api.github.com/users/travisMiehm/following{/other_user}","gists_url":"https://api.github.com/users/travisMiehm/gists{/gist_id}","starred_url":"https://api.github.com/users/travisMiehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisMiehm/subscriptions","organizations_url":"https://api.github.com/users/travisMiehm/orgs","repos_url":"https://api.github.com/users/travisMiehm/repos","events_url":"https://api.github.com/users/travisMiehm/events{/privacy}","received_events_url":"https://api.github.com/users/travisMiehm/received_events","type":"User","site_admin":false},"assignees":[{"login":"travisMiehm","id":1072547,"avatar_url":"https://avatars.githubusercontent.com/u/1072547?v=3","gravatar_id":"","url":"https://api.github.com/users/travisMiehm","html_url":"https://github.com/travisMiehm","followers_url":"https://api.github.com/users/travisMiehm/followers","following_url":"https://api.github.com/users/travisMiehm/following{/other_user}","gists_url":"https://api.github.com/users/travisMiehm/gists{/gist_id}","starred_url":"https://api.github.com/users/travisMiehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisMiehm/subscriptions","organizations_url":"https://api.github.com/users/travisMiehm/orgs","repos_url":"https://api.github.com/users/travisMiehm/repos","events_url":"https://api.github.com/users/travisMiehm/events{/privacy}","received_events_url":"https://api.github.com/users/travisMiehm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/15/comments","statuses_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/statuses/589e5feb53298aaa52606b50b5614d10c2c6d176","head":{"label":"Brightspace:smian/ignoreStaticMembers","ref":"smian/ignoreStaticMembers","sha":"589e5feb53298aaa52606b50b5614d10c2c6d176","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":66025309,"name":"D2L.CodeStyle","full_name":"Brightspace/D2L.CodeStyle","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/D2L.CodeStyle","description":"Annotations and analysis tools for D2L C# code style","fork":false,"url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle","forks_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/forks","keys_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/teams","hooks_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/events","assignees_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/tags","blobs_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/languages","stargazers_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/subscription","commits_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/merges","archive_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/downloads","issues_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/deployments","created_at":"2016-08-18T19:36:38Z","updated_at":"2016-08-22T19:59:46Z","pushed_at":"2016-09-22T17:39:24Z","git_url":"git://github.com/Brightspace/D2L.CodeStyle.git","ssh_url":"git@github.com:Brightspace/D2L.CodeStyle.git","clone_url":"https://github.com/Brightspace/D2L.CodeStyle.git","svn_url":"https://github.com/Brightspace/D2L.CodeStyle","homepage":"","size":115,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"b77f4de4650607f7d9ab3cd4786a2c3bf73df316","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":66025309,"name":"D2L.CodeStyle","full_name":"Brightspace/D2L.CodeStyle","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/D2L.CodeStyle","description":"Annotations and analysis tools for D2L C# code style","fork":false,"url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle","forks_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/forks","keys_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/teams","hooks_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/events","assignees_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/tags","blobs_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/languages","stargazers_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/subscription","commits_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/merges","archive_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/downloads","issues_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/deployments","created_at":"2016-08-18T19:36:38Z","updated_at":"2016-08-22T19:59:46Z","pushed_at":"2016-09-22T17:39:24Z","git_url":"git://github.com/Brightspace/D2L.CodeStyle.git","ssh_url":"git@github.com:Brightspace/D2L.CodeStyle.git","clone_url":"https://github.com/Brightspace/D2L.CodeStyle.git","svn_url":"https://github.com/Brightspace/D2L.CodeStyle","homepage":"","size":115,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/15"},"html":{"href":"https://github.com/Brightspace/D2L.CodeStyle/pull/15"},"issue":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/15"},"comments":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/statuses/589e5feb53298aaa52606b50b5614d10c2c6d176"}}}}
{"actor":{"display_login":"travisMiehm"}}