{"action":"opened","number":82,"pull_request":{"url":"https://api.github.com/repos/jobandtalent/nevada/pulls/82","id":97574022,"html_url":"https://github.com/jobandtalent/nevada/pull/82","diff_url":"https://github.com/jobandtalent/nevada/pull/82.diff","patch_url":"https://github.com/jobandtalent/nevada/pull/82.patch","issue_url":"https://api.github.com/repos/jobandtalent/nevada/issues/82","number":82,"state":"open","locked":false,"title":"Fix close event to avoid bad behaviour when clicking on document","user":{"login":"calderon","id":99109,"avatar_url":"https://avatars.githubusercontent.com/u/99109?v=3","gravatar_id":"","url":"https://api.github.com/users/calderon","html_url":"https://github.com/calderon","followers_url":"https://api.github.com/users/calderon/followers","following_url":"https://api.github.com/users/calderon/following{/other_user}","gists_url":"https://api.github.com/users/calderon/gists{/gist_id}","starred_url":"https://api.github.com/users/calderon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calderon/subscriptions","organizations_url":"https://api.github.com/users/calderon/orgs","repos_url":"https://api.github.com/users/calderon/repos","events_url":"https://api.github.com/users/calderon/events{/privacy}","received_events_url":"https://api.github.com/users/calderon/received_events","type":"User","site_admin":false},"body":"### What is the goal?\r\n\r\nCurrently we have a problem if we add a tooltip with close element. It prevents to click over anything on the page. This PR is a fix to ensure click on the close element works perfectly, also on the rest of the page.\r\n\r\n- [ ] It passses the `jt-frontend` lint commands (`--lint-js`, `--lint-less`, `--lint-coffee`, ...)\r\n- [ ] The `README.md` has been updated accordingly\r\n- [ ] **Issue:** (small PR's don't need it)\r\n\r\n### How is being implemented?\r\n\r\nI removed closeElement and closeTooltip locators, and add an `_initEvents` method to attach manually the click event on the close element.\r\n\r\n### Reviewers\r\n\r\n@jobandtalent/frontend \r\n\r\n","created_at":"2016-12-12T15:32:30Z","updated_at":"2016-12-12T15:32:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jobandtalent/nevada/pulls/82/commits","review_comments_url":"https://api.github.com/repos/jobandtalent/nevada/pulls/82/comments","review_comment_url":"https://api.github.com/repos/jobandtalent/nevada/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jobandtalent/nevada/issues/82/comments","statuses_url":"https://api.github.com/repos/jobandtalent/nevada/statuses/3ba075cd7b12d7727ea2c16a88c333f80d0735a2","head":{"label":"jobandtalent:HC-234-tooltip_close_fix","ref":"HC-234-tooltip_close_fix","sha":"3ba075cd7b12d7727ea2c16a88c333f80d0735a2","user":{"login":"jobandtalent","id":40731,"avatar_url":"https://avatars.githubusercontent.com/u/40731?v=3","gravatar_id":"","url":"https://api.github.com/users/jobandtalent","html_url":"https://github.com/jobandtalent","followers_url":"https://api.github.com/users/jobandtalent/followers","following_url":"https://api.github.com/users/jobandtalent/following{/other_user}","gists_url":"https://api.github.com/users/jobandtalent/gists{/gist_id}","starred_url":"https://api.github.com/users/jobandtalent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobandtalent/subscriptions","organizations_url":"https://api.github.com/users/jobandtalent/orgs","repos_url":"https://api.github.com/users/jobandtalent/repos","events_url":"https://api.github.com/users/jobandtalent/events{/privacy}","received_events_url":"https://api.github.com/users/jobandtalent/received_events","type":"Organization","site_admin":false},"repo":{"id":61018516,"name":"nevada","full_name":"jobandtalent/nevada","owner":{"login":"jobandtalent","id":40731,"avatar_url":"https://avatars.githubusercontent.com/u/40731?v=3","gravatar_id":"","url":"https://api.github.com/users/jobandtalent","html_url":"https://github.com/jobandtalent","followers_url":"https://api.github.com/users/jobandtalent/followers","following_url":"https://api.github.com/users/jobandtalent/following{/other_user}","gists_url":"https://api.github.com/users/jobandtalent/gists{/gist_id}","starred_url":"https://api.github.com/users/jobandtalent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobandtalent/subscriptions","organizations_url":"https://api.github.com/users/jobandtalent/orgs","repos_url":"https://api.github.com/users/jobandtalent/repos","events_url":"https://api.github.com/users/jobandtalent/events{/privacy}","received_events_url":"https://api.github.com/users/jobandtalent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jobandtalent/nevada","description":"Jobandtalent's web framework","fork":false,"url":"https://api.github.com/repos/jobandtalent/nevada","forks_url":"https://api.github.com/repos/jobandtalent/nevada/forks","keys_url":"https://api.github.com/repos/jobandtalent/nevada/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jobandtalent/nevada/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jobandtalent/nevada/teams","hooks_url":"https://api.github.com/repos/jobandtalent/nevada/hooks","issue_events_url":"https://api.github.com/repos/jobandtalent/nevada/issues/events{/number}","events_url":"https://api.github.com/repos/jobandtalent/nevada/events","assignees_url":"https://api.github.com/repos/jobandtalent/nevada/assignees{/user}","branches_url":"https://api.github.com/repos/jobandtalent/nevada/branches{/branch}","tags_url":"https://api.github.com/repos/jobandtalent/nevada/tags","blobs_url":"https://api.github.com/repos/jobandtalent/nevada/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jobandtalent/nevada/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jobandtalent/nevada/git/refs{/sha}","trees_url":"https://api.github.com/repos/jobandtalent/nevada/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jobandtalent/nevada/statuses/{sha}","languages_url":"https://api.github.com/repos/jobandtalent/nevada/languages","stargazers_url":"https://api.github.com/repos/jobandtalent/nevada/stargazers","contributors_url":"https://api.github.com/repos/jobandtalent/nevada/contributors","subscribers_url":"https://api.github.com/repos/jobandtalent/nevada/subscribers","subscription_url":"https://api.github.com/repos/jobandtalent/nevada/subscription","commits_url":"https://api.github.com/repos/jobandtalent/nevada/commits{/sha}","git_commits_url":"https://api.github.com/repos/jobandtalent/nevada/git/commits{/sha}","comments_url":"https://api.github.com/repos/jobandtalent/nevada/comments{/number}","issue_comment_url":"https://api.github.com/repos/jobandtalent/nevada/issues/comments{/number}","contents_url":"https://api.github.com/repos/jobandtalent/nevada/contents/{+path}","compare_url":"https://api.github.com/repos/jobandtalent/nevada/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jobandtalent/nevada/merges","archive_url":"https://api.github.com/repos/jobandtalent/nevada/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jobandtalent/nevada/downloads","issues_url":"https://api.github.com/repos/jobandtalent/nevada/issues{/number}","pulls_url":"https://api.github.com/repos/jobandtalent/nevada/pulls{/number}","milestones_url":"https://api.github.com/repos/jobandtalent/nevada/milestones{/number}","notifications_url":"https://api.github.com/repos/jobandtalent/nevada/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jobandtalent/nevada/labels{/name}","releases_url":"https://api.github.com/repos/jobandtalent/nevada/releases{/id}","deployments_url":"https://api.github.com/repos/jobandtalent/nevada/deployments","created_at":"2016-06-13T08:03:03Z","updated_at":"2016-10-27T19:28:59Z","pushed_at":"2016-12-12T15:30:29Z","git_url":"git://github.com/jobandtalent/nevada.git","ssh_url":"git@github.com:jobandtalent/nevada.git","clone_url":"https://github.com/jobandtalent/nevada.git","svn_url":"https://github.com/jobandtalent/nevada","homepage":null,"size":5973,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":14,"default_branch":"master"}},"base":{"label":"jobandtalent:master","ref":"master","sha":"0952b14c9b400802c2b5a755870fcba7519532de","user":{"login":"jobandtalent","id":40731,"avatar_url":"https://avatars.githubusercontent.com/u/40731?v=3","gravatar_id":"","url":"https://api.github.com/users/jobandtalent","html_url":"https://github.com/jobandtalent","followers_url":"https://api.github.com/users/jobandtalent/followers","following_url":"https://api.github.com/users/jobandtalent/following{/other_user}","gists_url":"https://api.github.com/users/jobandtalent/gists{/gist_id}","starred_url":"https://api.github.com/users/jobandtalent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobandtalent/subscriptions","organizations_url":"https://api.github.com/users/jobandtalent/orgs","repos_url":"https://api.github.com/users/jobandtalent/repos","events_url":"https://api.github.com/users/jobandtalent/events{/privacy}","received_events_url":"https://api.github.com/users/jobandtalent/received_events","type":"Organization","site_admin":false},"repo":{"id":61018516,"name":"nevada","full_name":"jobandtalent/nevada","owner":{"login":"jobandtalent","id":40731,"avatar_url":"https://avatars.githubusercontent.com/u/40731?v=3","gravatar_id":"","url":"https://api.github.com/users/jobandtalent","html_url":"https://github.com/jobandtalent","followers_url":"https://api.github.com/users/jobandtalent/followers","following_url":"https://api.github.com/users/jobandtalent/following{/other_user}","gists_url":"https://api.github.com/users/jobandtalent/gists{/gist_id}","starred_url":"https://api.github.com/users/jobandtalent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobandtalent/subscriptions","organizations_url":"https://api.github.com/users/jobandtalent/orgs","repos_url":"https://api.github.com/users/jobandtalent/repos","events_url":"https://api.github.com/users/jobandtalent/events{/privacy}","received_events_url":"https://api.github.com/users/jobandtalent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jobandtalent/nevada","description":"Jobandtalent's web framework","fork":false,"url":"https://api.github.com/repos/jobandtalent/nevada","forks_url":"https://api.github.com/repos/jobandtalent/nevada/forks","keys_url":"https://api.github.com/repos/jobandtalent/nevada/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jobandtalent/nevada/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jobandtalent/nevada/teams","hooks_url":"https://api.github.com/repos/jobandtalent/nevada/hooks","issue_events_url":"https://api.github.com/repos/jobandtalent/nevada/issues/events{/number}","events_url":"https://api.github.com/repos/jobandtalent/nevada/events","assignees_url":"https://api.github.com/repos/jobandtalent/nevada/assignees{/user}","branches_url":"https://api.github.com/repos/jobandtalent/nevada/branches{/branch}","tags_url":"https://api.github.com/repos/jobandtalent/nevada/tags","blobs_url":"https://api.github.com/repos/jobandtalent/nevada/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jobandtalent/nevada/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jobandtalent/nevada/git/refs{/sha}","trees_url":"https://api.github.com/repos/jobandtalent/nevada/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jobandtalent/nevada/statuses/{sha}","languages_url":"https://api.github.com/repos/jobandtalent/nevada/languages","stargazers_url":"https://api.github.com/repos/jobandtalent/nevada/stargazers","contributors_url":"https://api.github.com/repos/jobandtalent/nevada/contributors","subscribers_url":"https://api.github.com/repos/jobandtalent/nevada/subscribers","subscription_url":"https://api.github.com/repos/jobandtalent/nevada/subscription","commits_url":"https://api.github.com/repos/jobandtalent/nevada/commits{/sha}","git_commits_url":"https://api.github.com/repos/jobandtalent/nevada/git/commits{/sha}","comments_url":"https://api.github.com/repos/jobandtalent/nevada/comments{/number}","issue_comment_url":"https://api.github.com/repos/jobandtalent/nevada/issues/comments{/number}","contents_url":"https://api.github.com/repos/jobandtalent/nevada/contents/{+path}","compare_url":"https://api.github.com/repos/jobandtalent/nevada/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jobandtalent/nevada/merges","archive_url":"https://api.github.com/repos/jobandtalent/nevada/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jobandtalent/nevada/downloads","issues_url":"https://api.github.com/repos/jobandtalent/nevada/issues{/number}","pulls_url":"https://api.github.com/repos/jobandtalent/nevada/pulls{/number}","milestones_url":"https://api.github.com/repos/jobandtalent/nevada/milestones{/number}","notifications_url":"https://api.github.com/repos/jobandtalent/nevada/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jobandtalent/nevada/labels{/name}","releases_url":"https://api.github.com/repos/jobandtalent/nevada/releases{/id}","deployments_url":"https://api.github.com/repos/jobandtalent/nevada/deployments","created_at":"2016-06-13T08:03:03Z","updated_at":"2016-10-27T19:28:59Z","pushed_at":"2016-12-12T15:30:29Z","git_url":"git://github.com/jobandtalent/nevada.git","ssh_url":"git@github.com:jobandtalent/nevada.git","clone_url":"https://github.com/jobandtalent/nevada.git","svn_url":"https://github.com/jobandtalent/nevada","homepage":null,"size":5973,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jobandtalent/nevada/pulls/82"},"html":{"href":"https://github.com/jobandtalent/nevada/pull/82"},"issue":{"href":"https://api.github.com/repos/jobandtalent/nevada/issues/82"},"comments":{"href":"https://api.github.com/repos/jobandtalent/nevada/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/jobandtalent/nevada/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/jobandtalent/nevada/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jobandtalent/nevada/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/jobandtalent/nevada/statuses/3ba075cd7b12d7727ea2c16a88c333f80d0735a2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":18,"deletions":14,"changed_files":1}}
{"actor":{"display_login":"calderon"}}