{"action":"created","issue":{"url":"https://api.github.com/repos/craftyjs/Crafty/issues/1003","repository_url":"https://api.github.com/repos/craftyjs/Crafty","labels_url":"https://api.github.com/repos/craftyjs/Crafty/issues/1003/labels{/name}","comments_url":"https://api.github.com/repos/craftyjs/Crafty/issues/1003/comments","events_url":"https://api.github.com/repos/craftyjs/Crafty/issues/1003/events","html_url":"https://github.com/craftyjs/Crafty/pull/1003","id":127305979,"number":1003,"title":"Setup shaders that render as well","user":{"login":"matthijsgroen","id":23627,"avatar_url":"https://avatars.githubusercontent.com/u/23627?v=3","gravatar_id":"","url":"https://api.github.com/users/matthijsgroen","html_url":"https://github.com/matthijsgroen","followers_url":"https://api.github.com/users/matthijsgroen/followers","following_url":"https://api.github.com/users/matthijsgroen/following{/other_user}","gists_url":"https://api.github.com/users/matthijsgroen/gists{/gist_id}","starred_url":"https://api.github.com/users/matthijsgroen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthijsgroen/subscriptions","organizations_url":"https://api.github.com/users/matthijsgroen/orgs","repos_url":"https://api.github.com/users/matthijsgroen/repos","events_url":"https://api.github.com/users/matthijsgroen/events{/privacy}","received_events_url":"https://api.github.com/users/matthijsgroen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/craftyjs/Crafty/labels/ready","name":"ready","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"starwed","id":34907,"avatar_url":"https://avatars.githubusercontent.com/u/34907?v=3","gravatar_id":"","url":"https://api.github.com/users/starwed","html_url":"https://github.com/starwed","followers_url":"https://api.github.com/users/starwed/followers","following_url":"https://api.github.com/users/starwed/following{/other_user}","gists_url":"https://api.github.com/users/starwed/gists{/gist_id}","starred_url":"https://api.github.com/users/starwed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starwed/subscriptions","organizations_url":"https://api.github.com/users/starwed/orgs","repos_url":"https://api.github.com/users/starwed/repos","events_url":"https://api.github.com/users/starwed/events{/privacy}","received_events_url":"https://api.github.com/users/starwed/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2016-01-18T20:33:53Z","updated_at":"2016-02-06T22:06:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/craftyjs/Crafty/pulls/1003","html_url":"https://github.com/craftyjs/Crafty/pull/1003","diff_url":"https://github.com/craftyjs/Crafty/pull/1003.diff","patch_url":"https://github.com/craftyjs/Crafty/pull/1003.patch"},"body":"This is still a work in progress!\r\n\r\nIt is not yet finished. I create this pull request for now to get some early feedback :smile: \r\n\r\nTODO:\r\n\r\n- [x] Test this with a built version\r\n- [x] Create setup for images\r\n- [x] Create setup for color\r\n- [x] override default shader for sprites as demo\r\n- [x] Refactor\r\n- [x] Document the whole thing\r\n"},"comment":{"url":"https://api.github.com/repos/craftyjs/Crafty/issues/comments/180873018","html_url":"https://github.com/craftyjs/Crafty/pull/1003#issuecomment-180873018","issue_url":"https://api.github.com/repos/craftyjs/Crafty/issues/1003","id":180873018,"user":{"login":"matthijsgroen","id":23627,"avatar_url":"https://avatars.githubusercontent.com/u/23627?v=3","gravatar_id":"","url":"https://api.github.com/users/matthijsgroen","html_url":"https://github.com/matthijsgroen","followers_url":"https://api.github.com/users/matthijsgroen/followers","following_url":"https://api.github.com/users/matthijsgroen/following{/other_user}","gists_url":"https://api.github.com/users/matthijsgroen/gists{/gist_id}","starred_url":"https://api.github.com/users/matthijsgroen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthijsgroen/subscriptions","organizations_url":"https://api.github.com/users/matthijsgroen/orgs","repos_url":"https://api.github.com/users/matthijsgroen/repos","events_url":"https://api.github.com/users/matthijsgroen/events{/privacy}","received_events_url":"https://api.github.com/users/matthijsgroen/received_events","type":"User","site_admin":false},"created_at":"2016-02-06T22:06:00Z","updated_at":"2016-02-06T22:06:00Z","body":"It s actually a convention from other programming languages to prefix\nunused arguments with an underscore.\nOp za 6 feb. 2016 om 21:06 schreef Tim Martin <notifications@github.com>\n\n> Other than the entity/_entity typo in \"Color\" looks like this works ok.\n>\n> We don't have unit test coverage for webgl, and somewhat surprisingly\n> jshint didn't catch this one either. That said, I've been using Visual\n> Studio Code <https://code.visualstudio.com/> lately, and it does\n> highlight the use of entity as an unknown symbol, which is a nice catch.\n> For working with Crafty I generally prefer it to Sublime Text out of the\n> box, though I wasn't using many ST extensions.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/craftyjs/Crafty/pull/1003#issuecomment-180848146>.\n>\n"}}