{"action":"created","issue":{"url":"https://api.github.com/repos/runspired/ember-gestures/issues/57","repository_url":"https://api.github.com/repos/runspired/ember-gestures","labels_url":"https://api.github.com/repos/runspired/ember-gestures/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/runspired/ember-gestures/issues/57/comments","events_url":"https://api.github.com/repos/runspired/ember-gestures/issues/57/events","html_url":"https://github.com/runspired/ember-gestures/pull/57","id":162046085,"number":57,"title":"fastboot-bug/recognizers: Don't setup recognizers in fastboot","user":{"login":"eriktrom","id":830120,"avatar_url":"https://avatars.githubusercontent.com/u/830120?v=3","gravatar_id":"","url":"https://api.github.com/users/eriktrom","html_url":"https://github.com/eriktrom","followers_url":"https://api.github.com/users/eriktrom/followers","following_url":"https://api.github.com/users/eriktrom/following{/other_user}","gists_url":"https://api.github.com/users/eriktrom/gists{/gist_id}","starred_url":"https://api.github.com/users/eriktrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriktrom/subscriptions","organizations_url":"https://api.github.com/users/eriktrom/orgs","repos_url":"https://api.github.com/users/eriktrom/repos","events_url":"https://api.github.com/users/eriktrom/events{/privacy}","received_events_url":"https://api.github.com/users/eriktrom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-06-23T23:31:48Z","updated_at":"2016-07-25T22:07:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/runspired/ember-gestures/pulls/57","html_url":"https://github.com/runspired/ember-gestures/pull/57","diff_url":"https://github.com/runspired/ember-gestures/pull/57.diff","patch_url":"https://github.com/runspired/ember-gestures/pull/57.patch"},"body":"/cc @anthonybalmeo \r\n\r\nTry this out let me know if it works. The other option, to remove ember-gestures at build time (for fastboot only) is actually not possible b/c the recognizer mixin is already 'mixed' into the users app, thus the coupling there cannot be reversed at build time, bummer. \r\n\r\n**What this does**:\r\n\r\nThis will prevent issues where Hammer is not available in the built in recognizers and do the same when users generate/create their own recognizers(which prevents a footgun for users that would otherwise be required to understand the underlying implementation details for why they must use a typeof check for Hammer in their own recognizers)\r\n\r\n**Reasoning**: \r\n\r\nThe user events that fire any code paths in ember-gestures should never be triggered in node, and thus here we are simply preventing the Hammer errors by not 'registering' the recognizer(s) when user components that mixin the `ember-gestures/mixins/recognizer` 'mixin' are parsed and thus instantiated(which 'registers' the recognizer file associated with the `recognizers: 'a b c'` k/v pair on the component). \r\n\r\n**Need someone to test it out**\r\n\r\nI have not run this code, I just happened to see this and know enough to help out, but it's still speculation until someone tries it :) @anthonybalmeo - if this does not work drop me a stack trace and I'll fix it up, gratzi senior.\r\n\r\nrelated to #56 \r\n\r\n(fyi @tomdale - cause i know u just love more pings from github - but seriously - just so your aware of hackz for fastboot in user land addons that I once said I would help with, but got lost doing other things 👎 , but i know your keeping tabs 👍)"},"comment":{"url":"https://api.github.com/repos/runspired/ember-gestures/issues/comments/235101143","html_url":"https://github.com/runspired/ember-gestures/pull/57#issuecomment-235101143","issue_url":"https://api.github.com/repos/runspired/ember-gestures/issues/57","id":235101143,"user":{"login":"anthonybalmeo","id":967897,"avatar_url":"https://avatars.githubusercontent.com/u/967897?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonybalmeo","html_url":"https://github.com/anthonybalmeo","followers_url":"https://api.github.com/users/anthonybalmeo/followers","following_url":"https://api.github.com/users/anthonybalmeo/following{/other_user}","gists_url":"https://api.github.com/users/anthonybalmeo/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonybalmeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonybalmeo/subscriptions","organizations_url":"https://api.github.com/users/anthonybalmeo/orgs","repos_url":"https://api.github.com/users/anthonybalmeo/repos","events_url":"https://api.github.com/users/anthonybalmeo/events{/privacy}","received_events_url":"https://api.github.com/users/anthonybalmeo/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T22:07:39Z","updated_at":"2016-07-25T22:07:39Z","body":"@runspired this is good on my end. You can approve @eriktrom's PR of his changes if all is good on his end."}}
{"actor":{"display_login":"anthonybalmeo"}}