{"action":"created","comment":{"url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/comments/88057345","pull_request_review_id":8640241,"id":88057345,"diff_hunk":"@@ -4,8 +4,8 @@ model Bangbang \"BESTEST bang-bang heating system\"\n     final nLoads=1, final nTemSen = nZones);\n \n   parameter Modelica.SIunits.Volume[nZones] VZones;\n-  parameter Real corrCV = 5 \"Correction factor for thermal mass in zone\";","path":"IDEAS/Buildings/Validation/BaseClasses/HeatingSystem/Bangbang.mo","position":4,"original_position":4,"commit_id":"53fe7adc8bcd9b7f591a6f7965f813f8d0b08d27","original_commit_id":"53fe7adc8bcd9b7f591a6f7965f813f8d0b08d27","user":{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars.githubusercontent.com/u/5970879?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false},"body":"goed opgemerkt :)","created_at":"2016-11-15T16:39:36Z","updated_at":"2016-11-15T16:39:36Z","html_url":"https://github.com/open-ideas/IDEAS/pull/574#discussion_r88057345","pull_request_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/574","_links":{"self":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/comments/88057345"},"html":{"href":"https://github.com/open-ideas/IDEAS/pull/574#discussion_r88057345"},"pull_request":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/574"}}},"pull_request":{"url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/574","id":89184468,"html_url":"https://github.com/open-ideas/IDEAS/pull/574","diff_url":"https://github.com/open-ideas/IDEAS/pull/574.diff","patch_url":"https://github.com/open-ideas/IDEAS/pull/574.patch","issue_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/574","number":574,"state":"open","locked":false,"title":"Issue573 add ach to zone air thermal","user":{"login":"damienpicard","id":2987659,"avatar_url":"https://avatars.githubusercontent.com/u/2987659?v=3","gravatar_id":"","url":"https://api.github.com/users/damienpicard","html_url":"https://github.com/damienpicard","followers_url":"https://api.github.com/users/damienpicard/followers","following_url":"https://api.github.com/users/damienpicard/following{/other_user}","gists_url":"https://api.github.com/users/damienpicard/gists{/gist_id}","starred_url":"https://api.github.com/users/damienpicard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienpicard/subscriptions","organizations_url":"https://api.github.com/users/damienpicard/orgs","repos_url":"https://api.github.com/users/damienpicard/repos","events_url":"https://api.github.com/users/damienpicard/events{/privacy}","received_events_url":"https://api.github.com/users/damienpicard/received_events","type":"User","site_admin":false},"body":"This pull request fixes issue573.\n\nAdditional changes are the use of medium properties instead of hard coded heat capacity and density. This might causes minor changes in unit tests.\n","created_at":"2016-10-13T11:34:04Z","updated_at":"2016-11-15T16:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d59bbee7fda127e37a3254c3b3044d535ab748a","assignee":{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars.githubusercontent.com/u/5970879?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false},"assignees":[{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars.githubusercontent.com/u/5970879?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/574/commits","review_comments_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/574/comments","review_comment_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/574/comments","statuses_url":"https://api.github.com/repos/open-ideas/IDEAS/statuses/53fe7adc8bcd9b7f591a6f7965f813f8d0b08d27","head":{"label":"open-ideas:issue573_addACHToZoneAirThermal","ref":"issue573_addACHToZoneAirThermal","sha":"53fe7adc8bcd9b7f591a6f7965f813f8d0b08d27","user":{"login":"open-ideas","id":5467967,"avatar_url":"https://avatars.githubusercontent.com/u/5467967?v=3","gravatar_id":"","url":"https://api.github.com/users/open-ideas","html_url":"https://github.com/open-ideas","followers_url":"https://api.github.com/users/open-ideas/followers","following_url":"https://api.github.com/users/open-ideas/following{/other_user}","gists_url":"https://api.github.com/users/open-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ideas/subscriptions","organizations_url":"https://api.github.com/users/open-ideas/orgs","repos_url":"https://api.github.com/users/open-ideas/repos","events_url":"https://api.github.com/users/open-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/open-ideas/received_events","type":"Organization","site_admin":false},"repo":{"id":16949064,"name":"IDEAS","full_name":"open-ideas/IDEAS","owner":{"login":"open-ideas","id":5467967,"avatar_url":"https://avatars.githubusercontent.com/u/5467967?v=3","gravatar_id":"","url":"https://api.github.com/users/open-ideas","html_url":"https://github.com/open-ideas","followers_url":"https://api.github.com/users/open-ideas/followers","following_url":"https://api.github.com/users/open-ideas/following{/other_user}","gists_url":"https://api.github.com/users/open-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ideas/subscriptions","organizations_url":"https://api.github.com/users/open-ideas/orgs","repos_url":"https://api.github.com/users/open-ideas/repos","events_url":"https://api.github.com/users/open-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/open-ideas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-ideas/IDEAS","description":"Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.","fork":false,"url":"https://api.github.com/repos/open-ideas/IDEAS","forks_url":"https://api.github.com/repos/open-ideas/IDEAS/forks","keys_url":"https://api.github.com/repos/open-ideas/IDEAS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-ideas/IDEAS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-ideas/IDEAS/teams","hooks_url":"https://api.github.com/repos/open-ideas/IDEAS/hooks","issue_events_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/events{/number}","events_url":"https://api.github.com/repos/open-ideas/IDEAS/events","assignees_url":"https://api.github.com/repos/open-ideas/IDEAS/assignees{/user}","branches_url":"https://api.github.com/repos/open-ideas/IDEAS/branches{/branch}","tags_url":"https://api.github.com/repos/open-ideas/IDEAS/tags","blobs_url":"https://api.github.com/repos/open-ideas/IDEAS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-ideas/IDEAS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-ideas/IDEAS/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-ideas/IDEAS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-ideas/IDEAS/statuses/{sha}","languages_url":"https://api.github.com/repos/open-ideas/IDEAS/languages","stargazers_url":"https://api.github.com/repos/open-ideas/IDEAS/stargazers","contributors_url":"https://api.github.com/repos/open-ideas/IDEAS/contributors","subscribers_url":"https://api.github.com/repos/open-ideas/IDEAS/subscribers","subscription_url":"https://api.github.com/repos/open-ideas/IDEAS/subscription","commits_url":"https://api.github.com/repos/open-ideas/IDEAS/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-ideas/IDEAS/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-ideas/IDEAS/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-ideas/IDEAS/contents/{+path}","compare_url":"https://api.github.com/repos/open-ideas/IDEAS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-ideas/IDEAS/merges","archive_url":"https://api.github.com/repos/open-ideas/IDEAS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-ideas/IDEAS/downloads","issues_url":"https://api.github.com/repos/open-ideas/IDEAS/issues{/number}","pulls_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls{/number}","milestones_url":"https://api.github.com/repos/open-ideas/IDEAS/milestones{/number}","notifications_url":"https://api.github.com/repos/open-ideas/IDEAS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-ideas/IDEAS/labels{/name}","releases_url":"https://api.github.com/repos/open-ideas/IDEAS/releases{/id}","deployments_url":"https://api.github.com/repos/open-ideas/IDEAS/deployments","created_at":"2014-02-18T13:02:55Z","updated_at":"2016-10-14T14:02:17Z","pushed_at":"2016-11-15T14:21:57Z","git_url":"git://github.com/open-ideas/IDEAS.git","ssh_url":"git@github.com:open-ideas/IDEAS.git","clone_url":"https://github.com/open-ideas/IDEAS.git","svn_url":"https://github.com/open-ideas/IDEAS","homepage":"","size":35982,"stargazers_count":18,"watchers_count":18,"language":"Modelica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":41,"forks":23,"open_issues":41,"watchers":18,"default_branch":"master"}},"base":{"label":"open-ideas:develop","ref":"develop","sha":"5b2bd7327c61460cf7a6db18420cc4eb77ec3472","user":{"login":"open-ideas","id":5467967,"avatar_url":"https://avatars.githubusercontent.com/u/5467967?v=3","gravatar_id":"","url":"https://api.github.com/users/open-ideas","html_url":"https://github.com/open-ideas","followers_url":"https://api.github.com/users/open-ideas/followers","following_url":"https://api.github.com/users/open-ideas/following{/other_user}","gists_url":"https://api.github.com/users/open-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ideas/subscriptions","organizations_url":"https://api.github.com/users/open-ideas/orgs","repos_url":"https://api.github.com/users/open-ideas/repos","events_url":"https://api.github.com/users/open-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/open-ideas/received_events","type":"Organization","site_admin":false},"repo":{"id":16949064,"name":"IDEAS","full_name":"open-ideas/IDEAS","owner":{"login":"open-ideas","id":5467967,"avatar_url":"https://avatars.githubusercontent.com/u/5467967?v=3","gravatar_id":"","url":"https://api.github.com/users/open-ideas","html_url":"https://github.com/open-ideas","followers_url":"https://api.github.com/users/open-ideas/followers","following_url":"https://api.github.com/users/open-ideas/following{/other_user}","gists_url":"https://api.github.com/users/open-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ideas/subscriptions","organizations_url":"https://api.github.com/users/open-ideas/orgs","repos_url":"https://api.github.com/users/open-ideas/repos","events_url":"https://api.github.com/users/open-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/open-ideas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-ideas/IDEAS","description":"Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.","fork":false,"url":"https://api.github.com/repos/open-ideas/IDEAS","forks_url":"https://api.github.com/repos/open-ideas/IDEAS/forks","keys_url":"https://api.github.com/repos/open-ideas/IDEAS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-ideas/IDEAS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-ideas/IDEAS/teams","hooks_url":"https://api.github.com/repos/open-ideas/IDEAS/hooks","issue_events_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/events{/number}","events_url":"https://api.github.com/repos/open-ideas/IDEAS/events","assignees_url":"https://api.github.com/repos/open-ideas/IDEAS/assignees{/user}","branches_url":"https://api.github.com/repos/open-ideas/IDEAS/branches{/branch}","tags_url":"https://api.github.com/repos/open-ideas/IDEAS/tags","blobs_url":"https://api.github.com/repos/open-ideas/IDEAS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-ideas/IDEAS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-ideas/IDEAS/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-ideas/IDEAS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-ideas/IDEAS/statuses/{sha}","languages_url":"https://api.github.com/repos/open-ideas/IDEAS/languages","stargazers_url":"https://api.github.com/repos/open-ideas/IDEAS/stargazers","contributors_url":"https://api.github.com/repos/open-ideas/IDEAS/contributors","subscribers_url":"https://api.github.com/repos/open-ideas/IDEAS/subscribers","subscription_url":"https://api.github.com/repos/open-ideas/IDEAS/subscription","commits_url":"https://api.github.com/repos/open-ideas/IDEAS/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-ideas/IDEAS/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-ideas/IDEAS/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-ideas/IDEAS/contents/{+path}","compare_url":"https://api.github.com/repos/open-ideas/IDEAS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-ideas/IDEAS/merges","archive_url":"https://api.github.com/repos/open-ideas/IDEAS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-ideas/IDEAS/downloads","issues_url":"https://api.github.com/repos/open-ideas/IDEAS/issues{/number}","pulls_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls{/number}","milestones_url":"https://api.github.com/repos/open-ideas/IDEAS/milestones{/number}","notifications_url":"https://api.github.com/repos/open-ideas/IDEAS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-ideas/IDEAS/labels{/name}","releases_url":"https://api.github.com/repos/open-ideas/IDEAS/releases{/id}","deployments_url":"https://api.github.com/repos/open-ideas/IDEAS/deployments","created_at":"2014-02-18T13:02:55Z","updated_at":"2016-10-14T14:02:17Z","pushed_at":"2016-11-15T14:21:57Z","git_url":"git://github.com/open-ideas/IDEAS.git","ssh_url":"git@github.com:open-ideas/IDEAS.git","clone_url":"https://github.com/open-ideas/IDEAS.git","svn_url":"https://github.com/open-ideas/IDEAS","homepage":"","size":35982,"stargazers_count":18,"watchers_count":18,"language":"Modelica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":41,"forks":23,"open_issues":41,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/574"},"html":{"href":"https://github.com/open-ideas/IDEAS/pull/574"},"issue":{"href":"https://api.github.com/repos/open-ideas/IDEAS/issues/574"},"comments":{"href":"https://api.github.com/repos/open-ideas/IDEAS/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/open-ideas/IDEAS/statuses/53fe7adc8bcd9b7f591a6f7965f813f8d0b08d27"}}}}
{"actor":{"display_login":"Mathadon"}}