{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/83473562","pull_request_review_id":4317761,"id":83473562,"diff_hunk":"@@ -24,10 +24,9 @@ import (\n \t\"sync\"\n \t\"time\"\n \n-\t\"golang.org/x/net/context\"\n-\n \tlog \"github.com/Sirupsen/logrus\"\n \t\"github.com/golang/groupcache/lru\"\n+\t\"golang.org/x/net/context\"","path":"lib/portlayer/exec/handle.go","position":8,"original_position":8,"commit_id":"5bebf21cb518808509dacec0d88d3d6096e068ee","original_commit_id":"5bebf21cb518808509dacec0d88d3d6096e068ee","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"doesn't have to be in this PR but we should start switching to \"context\" ","created_at":"2016-10-14T18:09:59Z","updated_at":"2016-10-14T18:09:59Z","html_url":"https://github.com/vmware/vic/pull/2687#discussion_r83473562","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2687","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/83473562"},"html":{"href":"https://github.com/vmware/vic/pull/2687#discussion_r83473562"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2687"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2687","id":89068462,"html_url":"https://github.com/vmware/vic/pull/2687","diff_url":"https://github.com/vmware/vic/pull/2687.diff","patch_url":"https://github.com/vmware/vic/pull/2687.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2687","number":2687,"state":"open","locked":false,"title":"Check container status before waiting it to shutdown. Safer work with…","user":{"login":"vburenin","id":4350891,"avatar_url":"https://avatars.githubusercontent.com/u/4350891?v=3","gravatar_id":"","url":"https://api.github.com/users/vburenin","html_url":"https://github.com/vburenin","followers_url":"https://api.github.com/users/vburenin/followers","following_url":"https://api.github.com/users/vburenin/following{/other_user}","gists_url":"https://api.github.com/users/vburenin/gists{/gist_id}","starred_url":"https://api.github.com/users/vburenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vburenin/subscriptions","organizations_url":"https://api.github.com/users/vburenin/orgs","repos_url":"https://api.github.com/users/vburenin/repos","events_url":"https://api.github.com/users/vburenin/events{/privacy}","received_events_url":"https://api.github.com/users/vburenin/received_events","type":"User","site_admin":false},"body":"I started working on #2661, I was significantly worried about a potential issues related to race conditions which could happen due to not protected container state. Thus, I started dig deeper pursuing two goals: get better understanding of codebase and eliminate potential race issues in the future.\r\n\r\nI am not really confident that my fix is not breaking for anything else, so I would ask you folks to take a look if I didn't break anything.\r\n\r\nFixes #2661\r\n","created_at":"2016-10-12T18:31:25Z","updated_at":"2016-10-14T18:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e185fae46b258c9f8aa6de5077a99c76fb06c93e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2687/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2687/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2687/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/5bebf21cb518808509dacec0d88d3d6096e068ee","head":{"label":"vburenin:fix-for-stop-race-condition","ref":"fix-for-stop-race-condition","sha":"5bebf21cb518808509dacec0d88d3d6096e068ee","user":{"login":"vburenin","id":4350891,"avatar_url":"https://avatars.githubusercontent.com/u/4350891?v=3","gravatar_id":"","url":"https://api.github.com/users/vburenin","html_url":"https://github.com/vburenin","followers_url":"https://api.github.com/users/vburenin/followers","following_url":"https://api.github.com/users/vburenin/following{/other_user}","gists_url":"https://api.github.com/users/vburenin/gists{/gist_id}","starred_url":"https://api.github.com/users/vburenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vburenin/subscriptions","organizations_url":"https://api.github.com/users/vburenin/orgs","repos_url":"https://api.github.com/users/vburenin/repos","events_url":"https://api.github.com/users/vburenin/events{/privacy}","received_events_url":"https://api.github.com/users/vburenin/received_events","type":"User","site_admin":false},"repo":{"id":70089932,"name":"vic","full_name":"vburenin/vic","owner":{"login":"vburenin","id":4350891,"avatar_url":"https://avatars.githubusercontent.com/u/4350891?v=3","gravatar_id":"","url":"https://api.github.com/users/vburenin","html_url":"https://github.com/vburenin","followers_url":"https://api.github.com/users/vburenin/followers","following_url":"https://api.github.com/users/vburenin/following{/other_user}","gists_url":"https://api.github.com/users/vburenin/gists{/gist_id}","starred_url":"https://api.github.com/users/vburenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vburenin/subscriptions","organizations_url":"https://api.github.com/users/vburenin/orgs","repos_url":"https://api.github.com/users/vburenin/repos","events_url":"https://api.github.com/users/vburenin/events{/privacy}","received_events_url":"https://api.github.com/users/vburenin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vburenin/vic","description":"Integrated containers engine on vSphere","fork":true,"url":"https://api.github.com/repos/vburenin/vic","forks_url":"https://api.github.com/repos/vburenin/vic/forks","keys_url":"https://api.github.com/repos/vburenin/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vburenin/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vburenin/vic/teams","hooks_url":"https://api.github.com/repos/vburenin/vic/hooks","issue_events_url":"https://api.github.com/repos/vburenin/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vburenin/vic/events","assignees_url":"https://api.github.com/repos/vburenin/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vburenin/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vburenin/vic/tags","blobs_url":"https://api.github.com/repos/vburenin/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vburenin/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vburenin/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vburenin/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vburenin/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vburenin/vic/languages","stargazers_url":"https://api.github.com/repos/vburenin/vic/stargazers","contributors_url":"https://api.github.com/repos/vburenin/vic/contributors","subscribers_url":"https://api.github.com/repos/vburenin/vic/subscribers","subscription_url":"https://api.github.com/repos/vburenin/vic/subscription","commits_url":"https://api.github.com/repos/vburenin/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vburenin/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vburenin/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vburenin/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vburenin/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vburenin/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vburenin/vic/merges","archive_url":"https://api.github.com/repos/vburenin/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vburenin/vic/downloads","issues_url":"https://api.github.com/repos/vburenin/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vburenin/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vburenin/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vburenin/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vburenin/vic/labels{/name}","releases_url":"https://api.github.com/repos/vburenin/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vburenin/vic/deployments","created_at":"2016-10-05T18:59:46Z","updated_at":"2016-10-05T18:59:49Z","pushed_at":"2016-10-14T17:30:09Z","git_url":"git://github.com/vburenin/vic.git","ssh_url":"git@github.com:vburenin/vic.git","clone_url":"https://github.com/vburenin/vic.git","svn_url":"https://github.com/vburenin/vic","homepage":"","size":38050,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"e5dceda1afcd6c29112097d62d19d9256f4def61","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-10-13T07:43:08Z","pushed_at":"2016-10-14T18:05:31Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"","size":83589,"stargazers_count":140,"watchers_count":140,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":469,"forks":53,"open_issues":469,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2687"},"html":{"href":"https://github.com/vmware/vic/pull/2687"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2687"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2687/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2687/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2687/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/5bebf21cb518808509dacec0d88d3d6096e068ee"}}}}
{"actor":{"display_login":"caglar10ur"}}