{"action":"created","issue":{"url":"https://api.github.com/repos/webrtc/adapter/issues/389","repository_url":"https://api.github.com/repos/webrtc/adapter","labels_url":"https://api.github.com/repos/webrtc/adapter/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/webrtc/adapter/issues/389/comments","events_url":"https://api.github.com/repos/webrtc/adapter/issues/389/events","html_url":"https://github.com/webrtc/adapter/issues/389","id":194381990,"number":389,"title":"need upgrade path to chrome's spec stats","user":{"login":"fippo","id":289731,"avatar_url":"https://avatars.githubusercontent.com/u/289731?v=3","gravatar_id":"","url":"https://api.github.com/users/fippo","html_url":"https://github.com/fippo","followers_url":"https://api.github.com/users/fippo/followers","following_url":"https://api.github.com/users/fippo/following{/other_user}","gists_url":"https://api.github.com/users/fippo/gists{/gist_id}","starred_url":"https://api.github.com/users/fippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fippo/subscriptions","organizations_url":"https://api.github.com/users/fippo/orgs","repos_url":"https://api.github.com/users/fippo/repos","events_url":"https://api.github.com/users/fippo/events{/privacy}","received_events_url":"https://api.github.com/users/fippo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-12-08T16:31:59Z","updated_at":"2016-12-13T09:12:32Z","closed_at":null,"body":"Chrome Canary just landed spec-style stats and they're great.\r\nNow we have an issue we avoided for a very long time: how to upgrade from chrome-stats to legacy stats.\r\n\r\nWhen getStats is called with anything not a function as the first argument we shim from the legacy stats:\r\nhttps://github.com/webrtc/adapter/blob/master/src/js/chrome/chrome_shim.js#L114-L118\r\nThis was good because we could determine whether the user was interested in the chrome stats or a more spec-style statistics. Now the defintion of \"spec-style\" has changed since we made that decision.\r\n\r\nHow do we determine whether\r\na) the user wants spec stats\r\nb) the browser supports it. webrtcdetectedbrowser >= 57 doesn't work since that would mean legacy stats in opera for a looooong time (see also [here](https://lists.w3.org/Archives/Public/public-webrtc/2016Dec/0006.html))\r\n\r\nAlso how to deal with old chrome versions (real-world concern, even though appear.in officially only supports the latest two chrome versions we don't enforce this). I wonder if it makes sense to take @henbos' document and take another stab at writing the JS shim..."},"comment":{"url":"https://api.github.com/repos/webrtc/adapter/issues/comments/266685341","html_url":"https://github.com/webrtc/adapter/issues/389#issuecomment-266685341","issue_url":"https://api.github.com/repos/webrtc/adapter/issues/389","id":266685341,"user":{"login":"fippo","id":289731,"avatar_url":"https://avatars.githubusercontent.com/u/289731?v=3","gravatar_id":"","url":"https://api.github.com/users/fippo","html_url":"https://github.com/fippo","followers_url":"https://api.github.com/users/fippo/followers","following_url":"https://api.github.com/users/fippo/following{/other_user}","gists_url":"https://api.github.com/users/fippo/gists{/gist_id}","starred_url":"https://api.github.com/users/fippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fippo/subscriptions","organizations_url":"https://api.github.com/users/fippo/orgs","repos_url":"https://api.github.com/users/fippo/repos","events_url":"https://api.github.com/users/fippo/events{/privacy}","received_events_url":"https://api.github.com/users/fippo/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T09:12:32Z","updated_at":"2016-12-13T09:12:32Z","body":"we can do the usual PSA on discuss-webrtc"}}
{"actor":{"display_login":"fippo"}}