{"action":"created","issue":{"url":"https://api.github.com/repos/onelogin/php-saml/issues/152","repository_url":"https://api.github.com/repos/onelogin/php-saml","labels_url":"https://api.github.com/repos/onelogin/php-saml/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/onelogin/php-saml/issues/152/comments","events_url":"https://api.github.com/repos/onelogin/php-saml/issues/152/events","html_url":"https://github.com/onelogin/php-saml/pull/152","id":175287914,"number":152,"title":"NEW Allow overriding of host, port and protocol for URL building","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-06T16:10:13Z","updated_at":"2016-09-06T16:21:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/onelogin/php-saml/pulls/152","html_url":"https://github.com/onelogin/php-saml/pull/152","diff_url":"https://github.com/onelogin/php-saml/pull/152.diff","patch_url":"https://github.com/onelogin/php-saml/pull/152.patch"},"body":"Fixes #149 \r\n\r\n- Added ability to set custom host/port/protocol\r\n- Updated test coverage to include testing HTTP_X_FORWARDED_PORT\r\n- Split port detection into its own method"},"comment":{"url":"https://api.github.com/repos/onelogin/php-saml/issues/comments/245005880","html_url":"https://github.com/onelogin/php-saml/pull/152#issuecomment-245005880","issue_url":"https://api.github.com/repos/onelogin/php-saml/issues/152","id":245005880,"user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T16:21:28Z","updated_at":"2016-09-06T16:21:28Z","body":"This does allow this implicitly.\r\n\r\nFor example, if I don't want to use the `X-Forwarded-Port` header I can now use `OneLogin_Saml2_Utils::setRequestProto($_SERVER[\"SERVER_PORT\"]);`\r\n\r\nBecause the `getSelfHost()` method includes a port, one has to be able to override this, so I added this ability. If someone communicates via a proxy to `http://internal.machine.example.com:8080/saml/` and we want to present that as `https://publicsite.com/saml` then these utilities are required"}}
{"actor":{"display_login":"dhensby"}}