{"action":"created","comment":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/52967723","id":52967723,"diff_hunk":"@@ -375,6 +383,7 @@ class GameInfoWorkItem : public PrioritizedWorkQueueItem {\n \t\t\t\t\t\tgoto handleELF;\n \t\t\t\t\t}\n \t\t\t\t\tERROR_LOG(LOADER, \"invalid pbp %s\\n\", pbpLoader->Path().c_str());\n+\t\t\t\t\tinfo_->DisposeFileLoader();","path":"UI/GameInfoCache.cpp","position":50,"original_position":50,"commit_id":"3ea73e787097ef99c0ac70bc3e13e343610e8410","original_commit_id":"3ea73e787097ef99c0ac70bc3e13e343610e8410","user":{"login":"unknownbrackets","id":191233,"avatar_url":"https://avatars.githubusercontent.com/u/191233?v=3","gravatar_id":"","url":"https://api.github.com/users/unknownbrackets","html_url":"https://github.com/unknownbrackets","followers_url":"https://api.github.com/users/unknownbrackets/followers","following_url":"https://api.github.com/users/unknownbrackets/following{/other_user}","gists_url":"https://api.github.com/users/unknownbrackets/gists{/gist_id}","starred_url":"https://api.github.com/users/unknownbrackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknownbrackets/subscriptions","organizations_url":"https://api.github.com/users/unknownbrackets/orgs","repos_url":"https://api.github.com/users/unknownbrackets/repos","events_url":"https://api.github.com/users/unknownbrackets/events{/privacy}","received_events_url":"https://api.github.com/users/unknownbrackets/received_events","type":"User","site_admin":false},"body":"My memory tells me that this happens eventually anyway, although I saw you add it to the destructor so I might be wrong?  Is this leaking?\r\n\r\nDisposeFileLoader had originally been added, iirc, to avoid holding on to too many concurrent file descriptors.\r\n\r\n-[Unknown]","created_at":"2016-02-16T04:15:18Z","updated_at":"2016-02-16T04:15:18Z","html_url":"https://github.com/hrydgard/ppsspp/pull/8592#discussion_r52967723","pull_request_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8592","_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments/52967723"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/8592#discussion_r52967723"},"pull_request":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8592"}}},"pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8592","id":59308335,"html_url":"https://github.com/hrydgard/ppsspp/pull/8592","diff_url":"https://github.com/hrydgard/ppsspp/pull/8592.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/8592.patch","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8592","number":8592,"state":"closed","locked":false,"title":"Work that may or may not be towards fixing the Adreno/PowerVR shutdown crashes","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"body":"Nexus 4 is affected, and yeah, repro'd on PowerVR too (Zenfone).\r\n\r\nAnd this stuff doesn't help. But instead it crashes a bit more consistently, which should help finding a solution... Here's a typical crash, although there are a few variants:\r\n\r\n    F/libc    (18861): heap corruption detected by dlfree\r\n    F/libc    (18861): Fatal signal 6 (SIGABRT), code -6 in tid 18896 (AndroidRender)\r\n    I/DEBUG   (  194): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\r\n    I/DEBUG   (  194): Build fingerprint: 'google/occam/mako:5.1.1/LMY48T/2237560:user/release-keys'\r\n    I/DEBUG   (  194): Revision: '11'\r\n    I/DEBUG   (  194): ABI: 'arm'\r\n    I/DEBUG   (  194): pid: 18861, tid: 18896, name: AndroidRender  >>> org.ppsspp.ppsspp <<<\r\n    I/DEBUG   (  194): signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------\r\n    I/DEBUG   (  194): Abort message: 'heap corruption detected by dlfree'\r\n    I/DEBUG   (  194):     r0 00000000  r1 000049d0  r2 00000006  r3 00000000\r\n    I/DEBUG   (  194):     r4 a19f8dd8  r5 00000006  r6 0000003e  r7 0000010c\r\n    I/DEBUG   (  194):     r8 b6e3f1a0  r9 a19f8a48  sl b75e0d98  fp a35740e0\r\n    I/DEBUG   (  194):     ip 000049d0  sp a19f89b0  lr b6df9989  pc b6e1ee24  cpsr 600f0010\r\n    I/DEBUG   (  194):\r\n    I/DEBUG   (  194): backtrace:\r\n    I/DEBUG   (  194):     #00 pc 0003be24  /system/lib/libc.so (tgkill+12)\r\n    I/DEBUG   (  194):     #01 pc 00016985  /system/lib/libc.so (pthread_kill+52)\r\n    I/DEBUG   (  194):     #02 pc 00017597  /system/lib/libc.so (raise+10)\r\n    I/DEBUG   (  194):     #03 pc 00013d3d  /system/lib/libc.so (__libc_android_abort+36)\r\n    I/DEBUG   (  194):     #04 pc 000124ec  /system/lib/libc.so (abort+4)\r\n    I/DEBUG   (  194):     #05 pc 00015073  /system/lib/libc.so (__libc_fatal+16)\r\n    I/DEBUG   (  194):     #06 pc 00029719  /system/lib/libc.so (__bionic_heap_corruption_error+8)\r\n    I/DEBUG   (  194):     #07 pc 0002b78d  /system/lib/libc.so (dlfree+312)\r\n    I/DEBUG   (  194):     #08 pc 00012257  /system/lib/libc.so (free+10)\r\n    I/DEBUG   (  194):     #09 pc 00122d35  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (GameInfo::~GameInfo()+316)\r\n\r\nThe crashes are consistently \"Heap corruption\" of various kinds, and always happen during or after clearing the gameInfo cache. I can't find what's wrong with it though...\r\n\r\nDoes not happen on Windows, whatever I do I can't provoke it.\r\n\r\nDoes not happen on my 64-bit devices. Does not happen on my Android 2.3 devices. Only seems to happens on Android 4.x devices.","created_at":"2016-02-14T22:35:18Z","updated_at":"2016-02-16T04:15:18Z","closed_at":"2016-02-14T23:25:20Z","merged_at":null,"merge_commit_sha":"847b3227ddde2371647628f75c6e957844c476fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8592/commits","review_comments_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8592/comments","review_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8592/comments","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/3ea73e787097ef99c0ac70bc3e13e343610e8410","head":{"label":"hrydgard:improved-android-shutdown","ref":"improved-android-shutdown","sha":"3ea73e787097ef99c0ac70bc3e13e343610e8410","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"name":"ppsspp","full_name":"hrydgard/ppsspp","owner":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","deployments_url":"https://api.github.com/repos/hrydgard/ppsspp/deployments","created_at":"2012-11-01T08:41:48Z","updated_at":"2016-02-16T01:40:58Z","pushed_at":"2016-02-15T18:25:14Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"http://www.ppsspp.org","size":421597,"stargazers_count":2135,"watchers_count":2135,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":855,"mirror_url":null,"open_issues_count":580,"forks":855,"open_issues":580,"watchers":2135,"default_branch":"master"}},"base":{"label":"hrydgard:master","ref":"master","sha":"e954768a84ed380680f6b645683f3343da996cd8","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"name":"ppsspp","full_name":"hrydgard/ppsspp","owner":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","deployments_url":"https://api.github.com/repos/hrydgard/ppsspp/deployments","created_at":"2012-11-01T08:41:48Z","updated_at":"2016-02-16T01:40:58Z","pushed_at":"2016-02-15T18:25:14Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"http://www.ppsspp.org","size":421597,"stargazers_count":2135,"watchers_count":2135,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":855,"mirror_url":null,"open_issues_count":580,"forks":855,"open_issues":580,"watchers":2135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8592"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/8592"},"issue":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/8592"},"comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/8592/comments"},"review_comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8592/comments"},"review_comment":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8592/commits"},"statuses":{"href":"https://api.github.com/repos/hrydgard/ppsspp/statuses/3ea73e787097ef99c0ac70bc3e13e343610e8410"}}}}