{"action":"created","issue":{"url":"https://api.github.com/repos/syncthing/syncthing/issues/2875","repository_url":"https://api.github.com/repos/syncthing/syncthing","labels_url":"https://api.github.com/repos/syncthing/syncthing/issues/2875/labels{/name}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/2875/comments","events_url":"https://api.github.com/repos/syncthing/syncthing/issues/2875/events","html_url":"https://github.com/syncthing/syncthing/pull/2875","id":143384838,"number":2875,"title":"Hellomsg","user":{"login":"AudriusButkevicius","id":1144861,"avatar_url":"https://avatars.githubusercontent.com/u/1144861?v=3","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-24T23:12:50Z","updated_at":"2016-03-25T17:03:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/2875","html_url":"https://github.com/syncthing/syncthing/pull/2875","diff_url":"https://github.com/syncthing/syncthing/pull/2875.diff","patch_url":"https://github.com/syncthing/syncthing/pull/2875.patch"},"body":"### Purpose\r\n\r\nAdds a pre-protocol Hello message which does not require any authorization.\r\nThe message can be of variable size, but marshalled message sent must be padded to have the correct size.\r\nExpose device name in the connect prompts.\r\n\r\n### Testing\r\n\r\nRan this on two machines, connects fine, names show up in prompt and in edit device dialog.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/syncthing/syncthing/issues/comments/201365113","html_url":"https://github.com/syncthing/syncthing/pull/2875#issuecomment-201365113","issue_url":"https://api.github.com/repos/syncthing/syncthing/issues/2875","id":201365113,"user":{"login":"calmh","id":125426,"avatar_url":"https://avatars.githubusercontent.com/u/125426?v=3","gravatar_id":"","url":"https://api.github.com/users/calmh","html_url":"https://github.com/calmh","followers_url":"https://api.github.com/users/calmh/followers","following_url":"https://api.github.com/users/calmh/following{/other_user}","gists_url":"https://api.github.com/users/calmh/gists{/gist_id}","starred_url":"https://api.github.com/users/calmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calmh/subscriptions","organizations_url":"https://api.github.com/users/calmh/orgs","repos_url":"https://api.github.com/users/calmh/repos","events_url":"https://api.github.com/users/calmh/events{/privacy}","received_events_url":"https://api.github.com/users/calmh/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T17:03:17Z","updated_at":"2016-03-25T17:03:17Z","body":"1. Yeah I think we misunderstood each other. I think a length word, and a hard coded max length like 1024 bytes or so where we drop the connection if exceeded would be nicer. \r\n2. :+1:\r\n3. I'm unconvinced. I think we should leave this out until we need it, and then add whatever it is we need of the correct type at the time. "}}