{"action":"created","issue":{"url":"https://api.github.com/repos/angular/jasminewd/issues/68","repository_url":"https://api.github.com/repos/angular/jasminewd","labels_url":"https://api.github.com/repos/angular/jasminewd/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/angular/jasminewd/issues/68/comments","events_url":"https://api.github.com/repos/angular/jasminewd/issues/68/events","html_url":"https://github.com/angular/jasminewd/issues/68","id":191051441,"number":68,"title":"Wait for promises explicitly, rather than putting them on the control flow","user":{"login":"sjelin","id":4841675,"avatar_url":"https://avatars.githubusercontent.com/u/4841675?v=3","gravatar_id":"","url":"https://api.github.com/users/sjelin","html_url":"https://github.com/sjelin","followers_url":"https://api.github.com/users/sjelin/followers","following_url":"https://api.github.com/users/sjelin/following{/other_user}","gists_url":"https://api.github.com/users/sjelin/gists{/gist_id}","starred_url":"https://api.github.com/users/sjelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjelin/subscriptions","organizations_url":"https://api.github.com/users/sjelin/orgs","repos_url":"https://api.github.com/users/sjelin/repos","events_url":"https://api.github.com/users/sjelin/events{/privacy}","received_events_url":"https://api.github.com/users/sjelin/received_events","type":"User","site_admin":false},"labels":[{"id":104283305,"url":"https://api.github.com/repos/angular/jasminewd/labels/type:%20enhancement","name":"type: enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":{"login":"sjelin","id":4841675,"avatar_url":"https://avatars.githubusercontent.com/u/4841675?v=3","gravatar_id":"","url":"https://api.github.com/users/sjelin","html_url":"https://github.com/sjelin","followers_url":"https://api.github.com/users/sjelin/followers","following_url":"https://api.github.com/users/sjelin/following{/other_user}","gists_url":"https://api.github.com/users/sjelin/gists{/gist_id}","starred_url":"https://api.github.com/users/sjelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjelin/subscriptions","organizations_url":"https://api.github.com/users/sjelin/orgs","repos_url":"https://api.github.com/users/sjelin/repos","events_url":"https://api.github.com/users/sjelin/events{/privacy}","received_events_url":"https://api.github.com/users/sjelin/received_events","type":"User","site_admin":false},"assignees":[{"login":"sjelin","id":4841675,"avatar_url":"https://avatars.githubusercontent.com/u/4841675?v=3","gravatar_id":"","url":"https://api.github.com/users/sjelin","html_url":"https://github.com/sjelin","followers_url":"https://api.github.com/users/sjelin/followers","following_url":"https://api.github.com/users/sjelin/following{/other_user}","gists_url":"https://api.github.com/users/sjelin/gists{/gist_id}","starred_url":"https://api.github.com/users/sjelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjelin/subscriptions","organizations_url":"https://api.github.com/users/sjelin/orgs","repos_url":"https://api.github.com/users/sjelin/repos","events_url":"https://api.github.com/users/sjelin/events{/privacy}","received_events_url":"https://api.github.com/users/sjelin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-11-22T16:15:56Z","updated_at":"2016-11-22T17:27:41Z","closed_at":null,"body":"Right now if an `it()` block returns a promise, [it gets put directly on the control flow](https://github.com/angular/jasminewd/blob/jasminewd2/index.js#L94), which causes problems if it isn't a WebDriver promise.  Instead, we should explicitly use the promise's `.then()` block.  This will also help with the transition to supporting `SELENIUM_PROMISE_MANAGER=0`"},"comment":{"url":"https://api.github.com/repos/angular/jasminewd/issues/comments/262307155","html_url":"https://github.com/angular/jasminewd/issues/68#issuecomment-262307155","issue_url":"https://api.github.com/repos/angular/jasminewd/issues/68","id":262307155,"user":{"login":"thorn0","id":94334,"avatar_url":"https://avatars.githubusercontent.com/u/94334?v=3","gravatar_id":"","url":"https://api.github.com/users/thorn0","html_url":"https://github.com/thorn0","followers_url":"https://api.github.com/users/thorn0/followers","following_url":"https://api.github.com/users/thorn0/following{/other_user}","gists_url":"https://api.github.com/users/thorn0/gists{/gist_id}","starred_url":"https://api.github.com/users/thorn0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorn0/subscriptions","organizations_url":"https://api.github.com/users/thorn0/orgs","repos_url":"https://api.github.com/users/thorn0/repos","events_url":"https://api.github.com/users/thorn0/events{/privacy}","received_events_url":"https://api.github.com/users/thorn0/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T17:27:41Z","updated_at":"2016-11-22T17:27:41Z","body":"[ControlFlow.html#execute](http://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/lib/promise_exports_ControlFlow.html#execute):\r\n\r\n> Returns: A promise that will be resolved with the task result.\r\n\r\nSo it doesn't wait for the rest of the scheduled tasks."}}
{"actor":{"display_login":"thorn0"}}