{"action":"created","issue":{"url":"https://api.github.com/repos/mxcl/PromiseKit/issues/491","repository_url":"https://api.github.com/repos/mxcl/PromiseKit","labels_url":"https://api.github.com/repos/mxcl/PromiseKit/issues/491/labels{/name}","comments_url":"https://api.github.com/repos/mxcl/PromiseKit/issues/491/comments","events_url":"https://api.github.com/repos/mxcl/PromiseKit/issues/491/events","html_url":"https://github.com/mxcl/PromiseKit/pull/491","id":169779688,"number":491,"title":"make AnimationOptions members public","user":{"login":"allen-zeng","id":7380931,"avatar_url":"https://avatars.githubusercontent.com/u/7380931?v=3","gravatar_id":"","url":"https://api.github.com/users/allen-zeng","html_url":"https://github.com/allen-zeng","followers_url":"https://api.github.com/users/allen-zeng/followers","following_url":"https://api.github.com/users/allen-zeng/following{/other_user}","gists_url":"https://api.github.com/users/allen-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/allen-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allen-zeng/subscriptions","organizations_url":"https://api.github.com/users/allen-zeng/orgs","repos_url":"https://api.github.com/users/allen-zeng/repos","events_url":"https://api.github.com/users/allen-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/allen-zeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-07T04:46:24Z","updated_at":"2016-08-07T05:03:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mxcl/PromiseKit/pulls/491","html_url":"https://github.com/mxcl/PromiseKit/pull/491","diff_url":"https://github.com/mxcl/PromiseKit/pull/491.diff","patch_url":"https://github.com/mxcl/PromiseKit/pull/491.patch"},"body":"## What is this?\r\nThis change opens up the `AnimationOptions` members `None`, `Appear` and `Disappear` as public.\r\n\r\n## Why?\r\n`promiseViewController(_:animate:fulfills:completion:)` asks for `AnimationOptions` as a parameter, however none of its members are marked `public` so users of the framework can't actually get to them. The only alternative is by calling the public initialiser `init(rawValue:)`, which is rather fragile."},"comment":{"url":"https://api.github.com/repos/mxcl/PromiseKit/issues/comments/238063875","html_url":"https://github.com/mxcl/PromiseKit/pull/491#issuecomment-238063875","issue_url":"https://api.github.com/repos/mxcl/PromiseKit/issues/491","id":238063875,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-08-07T05:03:24Z","updated_at":"2016-08-07T05:03:24Z","body":"## [Current coverage](https://codecov.io/gh/mxcl/PromiseKit/pull/491?src=pr) is 53.32% (diff: 100%)\n> Merging [#491](https://codecov.io/gh/mxcl/PromiseKit/pull/491?src=pr) into [master](https://codecov.io/gh/mxcl/PromiseKit/branch/master?src=pr) will not change coverage\n\n```diff\n@@             master       #491   diff @@\n==========================================\n  Files           102        102          \n  Lines          3173       3173          \n  Methods           0          0          \n  Messages          0          0          \n  Branches          0          0          \n==========================================\n  Hits           1692       1692          \n  Misses         1481       1481          \n  Partials          0          0          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [0013c98...f1d1283](https://codecov.io/gh/mxcl/PromiseKit/compare/0013c9821555f27d5cca6972f4d82ee1b144b8e6...f1d128373681d90c392acd65d071cae12a6fc0d6?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}