{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/82414177","pull_request_review_id":3287062,"id":82414177,"diff_hunk":"@@ -51,17 +53,35 @@ class PiecewiseLinearInterpolation final\n     /**\n      * \\brief Calculates the interpolation value.\n      * @param pnt_to_interpolate The point should be located within the range\n-     * \\f$[x_{\\min}, x_{\\max}]\\f$, where \\f$x_{\\min} = \\min_{1 \\le j \\le n} x_j\\f$ and\n-     * \\f$x_{\\max} = \\max_{1 \\le j \\le n} x_j\\f$. Points outside of this interval are\n-     * extrapolated.\n+     * \\f$[x_{\\min}, x_{\\max}]\\f$, where \\f$x_{\\min} = \\min_{1 \\le j \\le n}\n+     * x_j\\f$ and\n+     * \\f$x_{\\max} = \\max_{1 \\le j \\le n} x_j\\f$. Points outside of this\n+     * interval are\n+     * set to x_{\\min} or x_{\\max}.\n      * @return The interpolated value.\n      */\n     double getValue(double pnt_to_interpolate) const;\n \n+    /**\n+     * \\brief Calculates the derivative value.\n+     * @param pnt_to_interpolate The point should be located within the range\n+     * \\f$[x_{\\min}, x_{\\max}]\\f$, where \\f$x_{\\min} = \\min_{1 \\le j \\le n}\n+     * x_j\\f$ and\n+     * \\f$x_{\\max} = \\max_{1 \\le j \\le n} x_j\\f$. when points are located\n+     * outside of this interval\n+     * the derivative is set to 0\n+     * \\attention if the points is located between the first and second points","path":"MathLib/InterpolationAlgorithms/PiecewiseLinearInterpolation.h","position":44,"original_position":44,"commit_id":"1939b4283e41c31263d59918d3adda1e122df885","original_commit_id":"1939b4283e41c31263d59918d3adda1e122df885","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"body":"or ``if a point is``","created_at":"2016-10-07T15:39:03Z","updated_at":"2016-10-07T15:49:01Z","html_url":"https://github.com/ufz/ogs/pull/1471#discussion_r82414177","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1471","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/82414177"},"html":{"href":"https://github.com/ufz/ogs/pull/1471#discussion_r82414177"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1471"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1471","id":88342631,"html_url":"https://github.com/ufz/ogs/pull/1471","diff_url":"https://github.com/ufz/ogs/pull/1471.diff","patch_url":"https://github.com/ufz/ogs/pull/1471.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1471","number":1471,"state":"open","locked":false,"title":"Update PiecewiseLinearInterpolation functions","user":{"login":"Yonghui56","id":6373576,"avatar_url":"https://avatars.githubusercontent.com/u/6373576?v=3","gravatar_id":"","url":"https://api.github.com/users/Yonghui56","html_url":"https://github.com/Yonghui56","followers_url":"https://api.github.com/users/Yonghui56/followers","following_url":"https://api.github.com/users/Yonghui56/following{/other_user}","gists_url":"https://api.github.com/users/Yonghui56/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonghui56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonghui56/subscriptions","organizations_url":"https://api.github.com/users/Yonghui56/orgs","repos_url":"https://api.github.com/users/Yonghui56/repos","events_url":"https://api.github.com/users/Yonghui56/events{/privacy}","received_events_url":"https://api.github.com/users/Yonghui56/received_events","type":"User","site_admin":false},"body":"This PR includes\r\n1) add GetCurveDerivative function in order to get the curve slope\r\n2) update the getValue functions\r\n3) add g-test for test these functions\r\n4) fix some settings in order to run testrunner in VS2015/windows","created_at":"2016-10-06T21:16:05Z","updated_at":"2016-10-07T15:49:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2b66f69bf87a08b1e85d779d018a8f777dc2375","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1471/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1471/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1471/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/1939b4283e41c31263d59918d3adda1e122df885","head":{"label":"Yonghui56:pr_pwinterpolation","ref":"pr_pwinterpolation","sha":"1939b4283e41c31263d59918d3adda1e122df885","user":{"login":"Yonghui56","id":6373576,"avatar_url":"https://avatars.githubusercontent.com/u/6373576?v=3","gravatar_id":"","url":"https://api.github.com/users/Yonghui56","html_url":"https://github.com/Yonghui56","followers_url":"https://api.github.com/users/Yonghui56/followers","following_url":"https://api.github.com/users/Yonghui56/following{/other_user}","gists_url":"https://api.github.com/users/Yonghui56/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonghui56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonghui56/subscriptions","organizations_url":"https://api.github.com/users/Yonghui56/orgs","repos_url":"https://api.github.com/users/Yonghui56/repos","events_url":"https://api.github.com/users/Yonghui56/events{/privacy}","received_events_url":"https://api.github.com/users/Yonghui56/received_events","type":"User","site_admin":false},"repo":{"id":59653351,"name":"ogs","full_name":"Yonghui56/ogs","owner":{"login":"Yonghui56","id":6373576,"avatar_url":"https://avatars.githubusercontent.com/u/6373576?v=3","gravatar_id":"","url":"https://api.github.com/users/Yonghui56","html_url":"https://github.com/Yonghui56","followers_url":"https://api.github.com/users/Yonghui56/followers","following_url":"https://api.github.com/users/Yonghui56/following{/other_user}","gists_url":"https://api.github.com/users/Yonghui56/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonghui56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonghui56/subscriptions","organizations_url":"https://api.github.com/users/Yonghui56/orgs","repos_url":"https://api.github.com/users/Yonghui56/repos","events_url":"https://api.github.com/users/Yonghui56/events{/privacy}","received_events_url":"https://api.github.com/users/Yonghui56/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yonghui56/ogs","description":"Experimental OGS-6 source code","fork":true,"url":"https://api.github.com/repos/Yonghui56/ogs","forks_url":"https://api.github.com/repos/Yonghui56/ogs/forks","keys_url":"https://api.github.com/repos/Yonghui56/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yonghui56/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yonghui56/ogs/teams","hooks_url":"https://api.github.com/repos/Yonghui56/ogs/hooks","issue_events_url":"https://api.github.com/repos/Yonghui56/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/Yonghui56/ogs/events","assignees_url":"https://api.github.com/repos/Yonghui56/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/Yonghui56/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/Yonghui56/ogs/tags","blobs_url":"https://api.github.com/repos/Yonghui56/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yonghui56/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yonghui56/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yonghui56/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yonghui56/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/Yonghui56/ogs/languages","stargazers_url":"https://api.github.com/repos/Yonghui56/ogs/stargazers","contributors_url":"https://api.github.com/repos/Yonghui56/ogs/contributors","subscribers_url":"https://api.github.com/repos/Yonghui56/ogs/subscribers","subscription_url":"https://api.github.com/repos/Yonghui56/ogs/subscription","commits_url":"https://api.github.com/repos/Yonghui56/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yonghui56/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yonghui56/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yonghui56/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yonghui56/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/Yonghui56/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yonghui56/ogs/merges","archive_url":"https://api.github.com/repos/Yonghui56/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yonghui56/ogs/downloads","issues_url":"https://api.github.com/repos/Yonghui56/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/Yonghui56/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/Yonghui56/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/Yonghui56/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yonghui56/ogs/labels{/name}","releases_url":"https://api.github.com/repos/Yonghui56/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/Yonghui56/ogs/deployments","created_at":"2016-05-25T10:15:44Z","updated_at":"2016-06-29T01:05:24Z","pushed_at":"2016-10-07T12:28:28Z","git_url":"git://github.com/Yonghui56/ogs.git","ssh_url":"git@github.com:Yonghui56/ogs.git","clone_url":"https://github.com/Yonghui56/ogs.git","svn_url":"https://github.com/Yonghui56/ogs","homepage":"www.opengeosys.org","size":15841,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"4b83f85334e38c8166f60c19a07345c230762439","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-08-30T02:27:56Z","pushed_at":"2016-10-07T15:19:42Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":20021,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":93,"forks":53,"open_issues":93,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1471"},"html":{"href":"https://github.com/ufz/ogs/pull/1471"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1471"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1471/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1471/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1471/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/1939b4283e41c31263d59918d3adda1e122df885"}}}}
{"actor":{"display_login":"wenqing"}}