{"action":"created","issue":{"url":"https://api.github.com/repos/Pylons/pyramid/issues/2413","repository_url":"https://api.github.com/repos/Pylons/pyramid","labels_url":"https://api.github.com/repos/Pylons/pyramid/issues/2413/labels{/name}","comments_url":"https://api.github.com/repos/Pylons/pyramid/issues/2413/comments","events_url":"https://api.github.com/repos/Pylons/pyramid/issues/2413/events","html_url":"https://github.com/Pylons/pyramid/pull/2413","id":142557228,"number":2413,"title":"require_csrf to replace check_csrf","user":{"login":"mmerickel","id":487237,"avatar_url":"https://avatars.githubusercontent.com/u/487237?v=3","gravatar_id":"","url":"https://api.github.com/users/mmerickel","html_url":"https://github.com/mmerickel","followers_url":"https://api.github.com/users/mmerickel/followers","following_url":"https://api.github.com/users/mmerickel/following{/other_user}","gists_url":"https://api.github.com/users/mmerickel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerickel/subscriptions","organizations_url":"https://api.github.com/users/mmerickel/orgs","repos_url":"https://api.github.com/users/mmerickel/repos","events_url":"https://api.github.com/users/mmerickel/events{/privacy}","received_events_url":"https://api.github.com/users/mmerickel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-22T06:11:17Z","updated_at":"2016-04-11T02:33:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Pylons/pyramid/pulls/2413","html_url":"https://github.com/Pylons/pyramid/pull/2413","diff_url":"https://github.com/Pylons/pyramid/pull/2413.diff","patch_url":"https://github.com/Pylons/pyramid/pull/2413.patch"},"body":"Fixes https://github.com/Pylons/pyramid/issues/2367\r\n\r\n- [x] Merge https://github.com/Pylons/pyramid/pull/2021 and rebase this PR on that.\r\n- [x] Deprecate `check_csrf`.\r\n- [ ] Fix any other docs and docstrings referencing `check_csrf` to point to `require_csrf` instead.\r\n    - [ ] Exclude `docs/whatsnew-*`\r\n    - [x] `docs/api/session.rst`\r\n    - [x] `docs/narr/hooks.rst`\r\n    - [x] `docs/narr/sessions.rst`\r\n    - [x] `docs/narr/viewconfig.rst`\r\n    - [x] `pyramid/session.py`\r\n    - [x] `pyramid/view.py`\r\n    - [x] `pyramid/config/predicates.py`\r\n    - [x] `pyramid/config/views.py`\r\n    - [x] `pyramid/tests/tests_session.py`\r\n    - [x] `pyramid/tests/test_predicates.py`\r\n- [ ] Update the request processing diagram to show the csrf checks just below authorization in the view pipeline.\r\n- [ ] Update scaffolds to set `pyramid.require_default_csrf = yes` in `development.ini` and `production.ini`."},"comment":{"url":"https://api.github.com/repos/Pylons/pyramid/issues/comments/208127750","html_url":"https://github.com/Pylons/pyramid/pull/2413#issuecomment-208127750","issue_url":"https://api.github.com/repos/Pylons/pyramid/issues/2413","id":208127750,"user":{"login":"bertjwregeer","id":649426,"avatar_url":"https://avatars.githubusercontent.com/u/649426?v=3","gravatar_id":"","url":"https://api.github.com/users/bertjwregeer","html_url":"https://github.com/bertjwregeer","followers_url":"https://api.github.com/users/bertjwregeer/followers","following_url":"https://api.github.com/users/bertjwregeer/following{/other_user}","gists_url":"https://api.github.com/users/bertjwregeer/gists{/gist_id}","starred_url":"https://api.github.com/users/bertjwregeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertjwregeer/subscriptions","organizations_url":"https://api.github.com/users/bertjwregeer/orgs","repos_url":"https://api.github.com/users/bertjwregeer/repos","events_url":"https://api.github.com/users/bertjwregeer/events{/privacy}","received_events_url":"https://api.github.com/users/bertjwregeer/received_events","type":"User","site_admin":false},"created_at":"2016-04-11T02:33:24Z","updated_at":"2016-04-11T02:33:24Z","body":"Besides the typo, this looks great :-)"}}