{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5569","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5569/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5569/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5569/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5569","id":113056446,"number":5569,"title":"[WIP] ENH Make stratified a parameter and conflate all the stratified/non-stratified cross-validator class pairs.","user":{"login":"rvraghav93","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/rvraghav93","html_url":"https://github.com/rvraghav93","followers_url":"https://api.github.com/users/rvraghav93/followers","following_url":"https://api.github.com/users/rvraghav93/following{/other_user}","gists_url":"https://api.github.com/users/rvraghav93/gists{/gist_id}","starred_url":"https://api.github.com/users/rvraghav93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvraghav93/subscriptions","organizations_url":"https://api.github.com/users/rvraghav93/orgs","repos_url":"https://api.github.com/users/rvraghav93/repos","events_url":"https://api.github.com/users/rvraghav93/events{/privacy}","received_events_url":"https://api.github.com/users/rvraghav93/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-10-23T16:40:22Z","updated_at":"2016-04-13T05:05:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5569","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5569","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5569.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5569.patch"},"body":"Partially fixes #5053 \r\n\r\n<hr>\r\n\r\n**TODO**\r\n\r\n- [ ] Make `stratified` a constructor parameter.\r\n- [ ] Conflate all the stratified/non-stratified class pairs\r\n- [ ] Make the tests pass.\r\n\r\n<hr>\r\n\r\n**NOTES**\r\n\r\n* +1 from Joel, Andy and Matheiu, [here](https://github.com/scikit-learn/scikit-learn/issues/5053#issuecomment-127148019), [here](https://github.com/scikit-learn/scikit-learn/issues/5053#issuecomment-127287215) and [here](https://github.com/scikit-learn/scikit-learn/issues/5053#issuecomment-128032545)\r\n* Also refer https://github.com/scikit-learn/scikit-learn/issues/4757 for discussion on stratification in the case of regression\r\n* Refer [this](https://github.com/ljchang/neurolearn/blob/ee43f3252726a232a3a7cfbe855b207de8287f5e/nltools/cross_validation.py) for an existing implementation(?)\r\n\r\n<hr>\r\n\r\n**cc:** @amueller @vene @jnothman @MechCoder"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/209228368","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5569#issuecomment-209228368","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5569","id":209228368,"user":{"login":"GaelVaroquaux","id":208217,"avatar_url":"https://avatars.githubusercontent.com/u/208217?v=3","gravatar_id":"","url":"https://api.github.com/users/GaelVaroquaux","html_url":"https://github.com/GaelVaroquaux","followers_url":"https://api.github.com/users/GaelVaroquaux/followers","following_url":"https://api.github.com/users/GaelVaroquaux/following{/other_user}","gists_url":"https://api.github.com/users/GaelVaroquaux/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelVaroquaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelVaroquaux/subscriptions","organizations_url":"https://api.github.com/users/GaelVaroquaux/orgs","repos_url":"https://api.github.com/users/GaelVaroquaux/repos","events_url":"https://api.github.com/users/GaelVaroquaux/events{/privacy}","received_events_url":"https://api.github.com/users/GaelVaroquaux/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T05:05:00Z","updated_at":"2016-04-13T05:05:00Z","body":"> I think the advantage is mostly just in a reduction of the number of classes.\n\nGiven that the code is not getting simpler, that's probably a potential\nadvantage in terms of usability right? But I am not sure whether finding\nan argument hidden in a class is easier to find a class. And the way\npeople now learn CV with scikit-learn, they pretty much need to look at a\nlist of class. Hence, I think that for usuability, stratified as a\ndifferent class is probably a good thing.\n\nWhat do people think about the above reasonning?\n"}}