{"action":"closed","number":105,"pull_request":{"url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/105","id":76999173,"html_url":"https://github.com/mobify/astro-scaffold/pull/105","diff_url":"https://github.com/mobify/astro-scaffold/pull/105.diff","patch_url":"https://github.com/mobify/astro-scaffold/pull/105.patch","issue_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/105","number":105,"state":"closed","locked":false,"title":"iOS Cordova Charset","user":{"login":"coffee-cup","id":3044853,"avatar_url":"https://avatars.githubusercontent.com/u/3044853?v=3","gravatar_id":"","url":"https://api.github.com/users/coffee-cup","html_url":"https://github.com/coffee-cup","followers_url":"https://api.github.com/users/coffee-cup/followers","following_url":"https://api.github.com/users/coffee-cup/following{/other_user}","gists_url":"https://api.github.com/users/coffee-cup/gists{/gist_id}","starred_url":"https://api.github.com/users/coffee-cup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffee-cup/subscriptions","organizations_url":"https://api.github.com/users/coffee-cup/orgs","repos_url":"https://api.github.com/users/coffee-cup/repos","events_url":"https://api.github.com/users/coffee-cup/events{/privacy}","received_events_url":"https://api.github.com/users/coffee-cup/received_events","type":"User","site_admin":false},"body":"Allow emojis to be passed over the worker/native bridge by specifying `utf-8` charset in the iOS Cordova `index.html` file.\r\n\r\nJIRA: **N/A**\r\nLinked PRs: **N/A**\r\n\r\n## Changes\r\n- Add `charset` `meta` tag with the `utf-8` value\r\n\r\n## How to test-drive this PR\r\n- A good test is to try and pass an emoji from `app.js` to the `AlertViewPlugin`. The emoji should appear.\r\n\r\n## TODOS:\r\n- [x] Change works in both ~~Android and~~ iOS.\r\n\r\n~~- [ ] CHANGELOG.md has been updated.~~\r\n~~- [ ] Run the generator to make sure it still functions correctly.~~\r\n\r\n- [x] +1 from an engineer on the Astro team.\r\n\r\n~~- [ ] Both tab layout and drawer layout are fully functional in ios. (Set `iosUsingTabLayout` in `baseConfig`)~~\r\n\r\n","created_at":"2016-07-11T18:18:45Z","updated_at":"2016-07-11T19:02:48Z","closed_at":"2016-07-11T19:02:47Z","merged_at":"2016-07-11T19:02:47Z","merge_commit_sha":"e47f19c088b3191703240dbaf1c84aaedd4bb4cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/105/commits","review_comments_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/105/comments","review_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/105/comments","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/ca4898542426c08d8286ecd333b3514f84b4e214","head":{"label":"mobify:ios-cordova-charset","ref":"ios-cordova-charset","sha":"ca4898542426c08d8286ecd333b3514f84b4e214","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":34024647,"name":"astro-scaffold","full_name":"mobify/astro-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/astro-scaffold","description":"Starting point for building Astro applications!","fork":false,"url":"https://api.github.com/repos/mobify/astro-scaffold","forks_url":"https://api.github.com/repos/mobify/astro-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/astro-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/astro-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/astro-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/astro-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/astro-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/astro-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/astro-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/astro-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/astro-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/astro-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/astro-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/astro-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/astro-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/astro-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/astro-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/astro-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/astro-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/astro-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/astro-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/astro-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/astro-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/astro-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/astro-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/astro-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/astro-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/astro-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/astro-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/astro-scaffold/deployments","created_at":"2015-04-15T23:56:36Z","updated_at":"2016-05-20T06:33:58Z","pushed_at":"2016-07-11T19:02:47Z","git_url":"git://github.com/mobify/astro-scaffold.git","ssh_url":"git@github.com:mobify/astro-scaffold.git","clone_url":"https://github.com/mobify/astro-scaffold.git","svn_url":"https://github.com/mobify/astro-scaffold","homepage":"http://astro.mobify.com/","size":981,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"develop"}},"base":{"label":"mobify:develop","ref":"develop","sha":"647b558828439956a1c8ea52d0490dc0d12c2ca8","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":34024647,"name":"astro-scaffold","full_name":"mobify/astro-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/astro-scaffold","description":"Starting point for building Astro applications!","fork":false,"url":"https://api.github.com/repos/mobify/astro-scaffold","forks_url":"https://api.github.com/repos/mobify/astro-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/astro-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/astro-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/astro-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/astro-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/astro-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/astro-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/astro-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/astro-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/astro-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/astro-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/astro-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/astro-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/astro-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/astro-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/astro-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/astro-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/astro-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/astro-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/astro-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/astro-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/astro-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/astro-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/astro-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/astro-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/astro-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/astro-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/astro-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/astro-scaffold/deployments","created_at":"2015-04-15T23:56:36Z","updated_at":"2016-05-20T06:33:58Z","pushed_at":"2016-07-11T19:02:47Z","git_url":"git://github.com/mobify/astro-scaffold.git","ssh_url":"git@github.com:mobify/astro-scaffold.git","clone_url":"https://github.com/mobify/astro-scaffold.git","svn_url":"https://github.com/mobify/astro-scaffold","homepage":"http://astro.mobify.com/","size":981,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/105"},"html":{"href":"https://github.com/mobify/astro-scaffold/pull/105"},"issue":{"href":"https://api.github.com/repos/mobify/astro-scaffold/issues/105"},"comments":{"href":"https://api.github.com/repos/mobify/astro-scaffold/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/astro-scaffold/statuses/ca4898542426c08d8286ecd333b3514f84b4e214"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"coffee-cup","id":3044853,"avatar_url":"https://avatars.githubusercontent.com/u/3044853?v=3","gravatar_id":"","url":"https://api.github.com/users/coffee-cup","html_url":"https://github.com/coffee-cup","followers_url":"https://api.github.com/users/coffee-cup/followers","following_url":"https://api.github.com/users/coffee-cup/following{/other_user}","gists_url":"https://api.github.com/users/coffee-cup/gists{/gist_id}","starred_url":"https://api.github.com/users/coffee-cup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffee-cup/subscriptions","organizations_url":"https://api.github.com/users/coffee-cup/orgs","repos_url":"https://api.github.com/users/coffee-cup/repos","events_url":"https://api.github.com/users/coffee-cup/events{/privacy}","received_events_url":"https://api.github.com/users/coffee-cup/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"coffee-cup"}}