{"action":"opened","number":349,"pull_request":{"url":"https://api.github.com/repos/Froxlor/Froxlor/pulls/349","id":66332678,"html_url":"https://github.com/Froxlor/Froxlor/pull/349","diff_url":"https://github.com/Froxlor/Froxlor/pull/349.diff","patch_url":"https://github.com/Froxlor/Froxlor/pull/349.patch","issue_url":"https://api.github.com/repos/Froxlor/Froxlor/issues/349","number":349,"state":"open","locked":false,"title":"Letsencrypt alias domains ","user":{"login":"eis-os","id":684359,"avatar_url":"https://avatars.githubusercontent.com/u/684359?v=3","gravatar_id":"","url":"https://api.github.com/users/eis-os","html_url":"https://github.com/eis-os","followers_url":"https://api.github.com/users/eis-os/followers","following_url":"https://api.github.com/users/eis-os/following{/other_user}","gists_url":"https://api.github.com/users/eis-os/gists{/gist_id}","starred_url":"https://api.github.com/users/eis-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eis-os/subscriptions","organizations_url":"https://api.github.com/users/eis-os/orgs","repos_url":"https://api.github.com/users/eis-os/repos","events_url":"https://api.github.com/users/eis-os/events{/privacy}","received_events_url":"https://api.github.com/users/eis-os/received_events","type":"User","site_admin":false},"body":"At least for Apache:\r\n\r\nServerAlias is used for ssl alias domains, however the certificate is only for the primary domain.\r\nThis patch adds the alias domains as additional san domains.  The primary domain currently is responsible for activating let's encrypt. \r\n\r\nThis won't solve the problem that changing wwwalias settings or alias domains won't recreate a proper new certificate request as the old domains will always used.\r\nTechnical expire needs to be reset and the csr recreated when csr old domain list != domains.\r\n\r\nPatch 2 $csrfile:\r\nSeems like a variable from upstream lescript was not converted to database fields (untested) ","created_at":"2016-04-13T14:40:01Z","updated_at":"2016-04-13T14:40:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Froxlor/Froxlor/pulls/349/commits","review_comments_url":"https://api.github.com/repos/Froxlor/Froxlor/pulls/349/comments","review_comment_url":"https://api.github.com/repos/Froxlor/Froxlor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Froxlor/Froxlor/issues/349/comments","statuses_url":"https://api.github.com/repos/Froxlor/Froxlor/statuses/c06028eb461888806a0135996d762aeec469ac95","head":{"label":"eis-os:letsencrypt-aliasdomains","ref":"letsencrypt-aliasdomains","sha":"c06028eb461888806a0135996d762aeec469ac95","user":{"login":"eis-os","id":684359,"avatar_url":"https://avatars.githubusercontent.com/u/684359?v=3","gravatar_id":"","url":"https://api.github.com/users/eis-os","html_url":"https://github.com/eis-os","followers_url":"https://api.github.com/users/eis-os/followers","following_url":"https://api.github.com/users/eis-os/following{/other_user}","gists_url":"https://api.github.com/users/eis-os/gists{/gist_id}","starred_url":"https://api.github.com/users/eis-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eis-os/subscriptions","organizations_url":"https://api.github.com/users/eis-os/orgs","repos_url":"https://api.github.com/users/eis-os/repos","events_url":"https://api.github.com/users/eis-os/events{/privacy}","received_events_url":"https://api.github.com/users/eis-os/received_events","type":"User","site_admin":false},"repo":{"id":33436437,"name":"Froxlor","full_name":"eis-os/Froxlor","owner":{"login":"eis-os","id":684359,"avatar_url":"https://avatars.githubusercontent.com/u/684359?v=3","gravatar_id":"","url":"https://api.github.com/users/eis-os","html_url":"https://github.com/eis-os","followers_url":"https://api.github.com/users/eis-os/followers","following_url":"https://api.github.com/users/eis-os/following{/other_user}","gists_url":"https://api.github.com/users/eis-os/gists{/gist_id}","starred_url":"https://api.github.com/users/eis-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eis-os/subscriptions","organizations_url":"https://api.github.com/users/eis-os/orgs","repos_url":"https://api.github.com/users/eis-os/repos","events_url":"https://api.github.com/users/eis-os/events{/privacy}","received_events_url":"https://api.github.com/users/eis-os/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eis-os/Froxlor","description":"Froxlor fork with libnss-extrausers support","fork":true,"url":"https://api.github.com/repos/eis-os/Froxlor","forks_url":"https://api.github.com/repos/eis-os/Froxlor/forks","keys_url":"https://api.github.com/repos/eis-os/Froxlor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eis-os/Froxlor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eis-os/Froxlor/teams","hooks_url":"https://api.github.com/repos/eis-os/Froxlor/hooks","issue_events_url":"https://api.github.com/repos/eis-os/Froxlor/issues/events{/number}","events_url":"https://api.github.com/repos/eis-os/Froxlor/events","assignees_url":"https://api.github.com/repos/eis-os/Froxlor/assignees{/user}","branches_url":"https://api.github.com/repos/eis-os/Froxlor/branches{/branch}","tags_url":"https://api.github.com/repos/eis-os/Froxlor/tags","blobs_url":"https://api.github.com/repos/eis-os/Froxlor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eis-os/Froxlor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eis-os/Froxlor/git/refs{/sha}","trees_url":"https://api.github.com/repos/eis-os/Froxlor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eis-os/Froxlor/statuses/{sha}","languages_url":"https://api.github.com/repos/eis-os/Froxlor/languages","stargazers_url":"https://api.github.com/repos/eis-os/Froxlor/stargazers","contributors_url":"https://api.github.com/repos/eis-os/Froxlor/contributors","subscribers_url":"https://api.github.com/repos/eis-os/Froxlor/subscribers","subscription_url":"https://api.github.com/repos/eis-os/Froxlor/subscription","commits_url":"https://api.github.com/repos/eis-os/Froxlor/commits{/sha}","git_commits_url":"https://api.github.com/repos/eis-os/Froxlor/git/commits{/sha}","comments_url":"https://api.github.com/repos/eis-os/Froxlor/comments{/number}","issue_comment_url":"https://api.github.com/repos/eis-os/Froxlor/issues/comments{/number}","contents_url":"https://api.github.com/repos/eis-os/Froxlor/contents/{+path}","compare_url":"https://api.github.com/repos/eis-os/Froxlor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eis-os/Froxlor/merges","archive_url":"https://api.github.com/repos/eis-os/Froxlor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eis-os/Froxlor/downloads","issues_url":"https://api.github.com/repos/eis-os/Froxlor/issues{/number}","pulls_url":"https://api.github.com/repos/eis-os/Froxlor/pulls{/number}","milestones_url":"https://api.github.com/repos/eis-os/Froxlor/milestones{/number}","notifications_url":"https://api.github.com/repos/eis-os/Froxlor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eis-os/Froxlor/labels{/name}","releases_url":"https://api.github.com/repos/eis-os/Froxlor/releases{/id}","deployments_url":"https://api.github.com/repos/eis-os/Froxlor/deployments","created_at":"2015-04-05T09:34:55Z","updated_at":"2016-04-09T09:00:17Z","pushed_at":"2016-04-13T14:28:36Z","git_url":"git://github.com/eis-os/Froxlor.git","ssh_url":"git@github.com:eis-os/Froxlor.git","clone_url":"https://github.com/eis-os/Froxlor.git","svn_url":"https://github.com/eis-os/Froxlor","homepage":"","size":15256,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Froxlor:master","ref":"master","sha":"e8f5fc1a8a968da1f85e9a7c34091a061d4941c9","user":{"login":"Froxlor","id":1507525,"avatar_url":"https://avatars.githubusercontent.com/u/1507525?v=3","gravatar_id":"","url":"https://api.github.com/users/Froxlor","html_url":"https://github.com/Froxlor","followers_url":"https://api.github.com/users/Froxlor/followers","following_url":"https://api.github.com/users/Froxlor/following{/other_user}","gists_url":"https://api.github.com/users/Froxlor/gists{/gist_id}","starred_url":"https://api.github.com/users/Froxlor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Froxlor/subscriptions","organizations_url":"https://api.github.com/users/Froxlor/orgs","repos_url":"https://api.github.com/users/Froxlor/repos","events_url":"https://api.github.com/users/Froxlor/events{/privacy}","received_events_url":"https://api.github.com/users/Froxlor/received_events","type":"Organization","site_admin":false},"repo":{"id":3639119,"name":"Froxlor","full_name":"Froxlor/Froxlor","owner":{"login":"Froxlor","id":1507525,"avatar_url":"https://avatars.githubusercontent.com/u/1507525?v=3","gravatar_id":"","url":"https://api.github.com/users/Froxlor","html_url":"https://github.com/Froxlor","followers_url":"https://api.github.com/users/Froxlor/followers","following_url":"https://api.github.com/users/Froxlor/following{/other_user}","gists_url":"https://api.github.com/users/Froxlor/gists{/gist_id}","starred_url":"https://api.github.com/users/Froxlor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Froxlor/subscriptions","organizations_url":"https://api.github.com/users/Froxlor/orgs","repos_url":"https://api.github.com/users/Froxlor/repos","events_url":"https://api.github.com/users/Froxlor/events{/privacy}","received_events_url":"https://api.github.com/users/Froxlor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Froxlor/Froxlor","description":"The server administration software for your needs - The official Froxlor development Git repository","fork":false,"url":"https://api.github.com/repos/Froxlor/Froxlor","forks_url":"https://api.github.com/repos/Froxlor/Froxlor/forks","keys_url":"https://api.github.com/repos/Froxlor/Froxlor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Froxlor/Froxlor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Froxlor/Froxlor/teams","hooks_url":"https://api.github.com/repos/Froxlor/Froxlor/hooks","issue_events_url":"https://api.github.com/repos/Froxlor/Froxlor/issues/events{/number}","events_url":"https://api.github.com/repos/Froxlor/Froxlor/events","assignees_url":"https://api.github.com/repos/Froxlor/Froxlor/assignees{/user}","branches_url":"https://api.github.com/repos/Froxlor/Froxlor/branches{/branch}","tags_url":"https://api.github.com/repos/Froxlor/Froxlor/tags","blobs_url":"https://api.github.com/repos/Froxlor/Froxlor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Froxlor/Froxlor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Froxlor/Froxlor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Froxlor/Froxlor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Froxlor/Froxlor/statuses/{sha}","languages_url":"https://api.github.com/repos/Froxlor/Froxlor/languages","stargazers_url":"https://api.github.com/repos/Froxlor/Froxlor/stargazers","contributors_url":"https://api.github.com/repos/Froxlor/Froxlor/contributors","subscribers_url":"https://api.github.com/repos/Froxlor/Froxlor/subscribers","subscription_url":"https://api.github.com/repos/Froxlor/Froxlor/subscription","commits_url":"https://api.github.com/repos/Froxlor/Froxlor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Froxlor/Froxlor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Froxlor/Froxlor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Froxlor/Froxlor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Froxlor/Froxlor/contents/{+path}","compare_url":"https://api.github.com/repos/Froxlor/Froxlor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Froxlor/Froxlor/merges","archive_url":"https://api.github.com/repos/Froxlor/Froxlor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Froxlor/Froxlor/downloads","issues_url":"https://api.github.com/repos/Froxlor/Froxlor/issues{/number}","pulls_url":"https://api.github.com/repos/Froxlor/Froxlor/pulls{/number}","milestones_url":"https://api.github.com/repos/Froxlor/Froxlor/milestones{/number}","notifications_url":"https://api.github.com/repos/Froxlor/Froxlor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Froxlor/Froxlor/labels{/name}","releases_url":"https://api.github.com/repos/Froxlor/Froxlor/releases{/id}","deployments_url":"https://api.github.com/repos/Froxlor/Froxlor/deployments","created_at":"2012-03-06T15:14:46Z","updated_at":"2016-04-12T18:12:29Z","pushed_at":"2016-04-13T12:49:21Z","git_url":"git://github.com/Froxlor/Froxlor.git","ssh_url":"git@github.com:Froxlor/Froxlor.git","clone_url":"https://github.com/Froxlor/Froxlor.git","svn_url":"https://github.com/Froxlor/Froxlor","homepage":"http://www.froxlor.org","size":19084,"stargazers_count":534,"watchers_count":534,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":21,"forks":198,"open_issues":21,"watchers":534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Froxlor/Froxlor/pulls/349"},"html":{"href":"https://github.com/Froxlor/Froxlor/pull/349"},"issue":{"href":"https://api.github.com/repos/Froxlor/Froxlor/issues/349"},"comments":{"href":"https://api.github.com/repos/Froxlor/Froxlor/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/Froxlor/Froxlor/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/Froxlor/Froxlor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Froxlor/Froxlor/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/Froxlor/Froxlor/statuses/c06028eb461888806a0135996d762aeec469ac95"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":18,"deletions":1,"changed_files":2}}