{"action":"opened","number":34,"pull_request":{"url":"https://api.github.com/repos/entando/entando-core/pulls/34","id":64905027,"html_url":"https://github.com/entando/entando-core/pull/34","diff_url":"https://github.com/entando/entando-core/pull/34.diff","patch_url":"https://github.com/entando/entando-core/pull/34.patch","issue_url":"https://api.github.com/repos/entando/entando-core/issues/34","number":34,"state":"open","locked":false,"title":"multiple code improvements: squid:CommentedOutCodeLine, squid:S1213, squid:S1192, squid:UselessParenthesesCheck, squid:S00122, squid:S1066, squid:S1170, squid:S2130","user":{"login":"georgekankava","id":16732352,"avatar_url":"https://avatars.githubusercontent.com/u/16732352?v=3","gravatar_id":"","url":"https://api.github.com/users/georgekankava","html_url":"https://github.com/georgekankava","followers_url":"https://api.github.com/users/georgekankava/followers","following_url":"https://api.github.com/users/georgekankava/following{/other_user}","gists_url":"https://api.github.com/users/georgekankava/gists{/gist_id}","starred_url":"https://api.github.com/users/georgekankava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgekankava/subscriptions","organizations_url":"https://api.github.com/users/georgekankava/orgs","repos_url":"https://api.github.com/users/georgekankava/repos","events_url":"https://api.github.com/users/georgekankava/events{/privacy}","received_events_url":"https://api.github.com/users/georgekankava/received_events","type":"User","site_admin":false},"body":"This pull request is focused on resolving occurrences of Sonar rules\r\nsquid:CommentedOutCodeLine - Sections of code should not be \"commented out\".\r\nsquid:S1213 - The members of an interface declaration or class should appear in a pre-defined order.\r\nsquid:S1192 - String literals should not be duplicated.\r\nsquid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding.\r\nsquid:S00122 - Statements should be on separate lines.\r\nsquid:S1066 - Collapsible \"if\" statements should be merged.\r\nsquid:S1170 - Public constants should be declared \"static final\" rather than merely \"final\".\r\nsquid:S2130 - Parsing should be used to convert \"Strings\" to primitives.\r\nYou can find more information about the issue here:\r\nhttps://dev.eclipse.org/sonar/coding_rules#q=squid%3ACommentedOutCodeLine\r\nhttps://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1213\r\nhttps://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1192\r\nhttps://dev.eclipse.org/sonar/coding_rules#q=squid%3AUselessParenthesesCheck\r\nhttps://dev.eclipse.org/sonar/coding_rules#q=squid%3AS00122\r\nhttps://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1066\r\nhttps://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1170\r\nhttps://dev.eclipse.org/sonar/coding_rules#q=squid%3AS2130\r\nPlease let me know if you have any questions.\r\nGeorge Kankava","created_at":"2016-04-01T07:23:25Z","updated_at":"2016-04-01T07:23:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/entando/entando-core/pulls/34/commits","review_comments_url":"https://api.github.com/repos/entando/entando-core/pulls/34/comments","review_comment_url":"https://api.github.com/repos/entando/entando-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/entando/entando-core/issues/34/comments","statuses_url":"https://api.github.com/repos/entando/entando-core/statuses/eec85036520fbd63ec586e6861e9877a8eb89d4f","head":{"label":"DevFactory:release/multiple-code-improvements-fix-1","ref":"release/multiple-code-improvements-fix-1","sha":"eec85036520fbd63ec586e6861e9877a8eb89d4f","user":{"login":"DevFactory","id":1516696,"avatar_url":"https://avatars.githubusercontent.com/u/1516696?v=3","gravatar_id":"","url":"https://api.github.com/users/DevFactory","html_url":"https://github.com/DevFactory","followers_url":"https://api.github.com/users/DevFactory/followers","following_url":"https://api.github.com/users/DevFactory/following{/other_user}","gists_url":"https://api.github.com/users/DevFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/DevFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevFactory/subscriptions","organizations_url":"https://api.github.com/users/DevFactory/orgs","repos_url":"https://api.github.com/users/DevFactory/repos","events_url":"https://api.github.com/users/DevFactory/events{/privacy}","received_events_url":"https://api.github.com/users/DevFactory/received_events","type":"Organization","site_admin":false},"repo":{"id":55210329,"name":"entando-core","full_name":"DevFactory/entando-core","owner":{"login":"DevFactory","id":1516696,"avatar_url":"https://avatars.githubusercontent.com/u/1516696?v=3","gravatar_id":"","url":"https://api.github.com/users/DevFactory","html_url":"https://github.com/DevFactory","followers_url":"https://api.github.com/users/DevFactory/followers","following_url":"https://api.github.com/users/DevFactory/following{/other_user}","gists_url":"https://api.github.com/users/DevFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/DevFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevFactory/subscriptions","organizations_url":"https://api.github.com/users/DevFactory/orgs","repos_url":"https://api.github.com/users/DevFactory/repos","events_url":"https://api.github.com/users/DevFactory/events{/privacy}","received_events_url":"https://api.github.com/users/DevFactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevFactory/entando-core","description":"Entando Core. The leading repository of Entando Platform.","fork":true,"url":"https://api.github.com/repos/DevFactory/entando-core","forks_url":"https://api.github.com/repos/DevFactory/entando-core/forks","keys_url":"https://api.github.com/repos/DevFactory/entando-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevFactory/entando-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevFactory/entando-core/teams","hooks_url":"https://api.github.com/repos/DevFactory/entando-core/hooks","issue_events_url":"https://api.github.com/repos/DevFactory/entando-core/issues/events{/number}","events_url":"https://api.github.com/repos/DevFactory/entando-core/events","assignees_url":"https://api.github.com/repos/DevFactory/entando-core/assignees{/user}","branches_url":"https://api.github.com/repos/DevFactory/entando-core/branches{/branch}","tags_url":"https://api.github.com/repos/DevFactory/entando-core/tags","blobs_url":"https://api.github.com/repos/DevFactory/entando-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevFactory/entando-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevFactory/entando-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevFactory/entando-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevFactory/entando-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DevFactory/entando-core/languages","stargazers_url":"https://api.github.com/repos/DevFactory/entando-core/stargazers","contributors_url":"https://api.github.com/repos/DevFactory/entando-core/contributors","subscribers_url":"https://api.github.com/repos/DevFactory/entando-core/subscribers","subscription_url":"https://api.github.com/repos/DevFactory/entando-core/subscription","commits_url":"https://api.github.com/repos/DevFactory/entando-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevFactory/entando-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevFactory/entando-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevFactory/entando-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevFactory/entando-core/contents/{+path}","compare_url":"https://api.github.com/repos/DevFactory/entando-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevFactory/entando-core/merges","archive_url":"https://api.github.com/repos/DevFactory/entando-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevFactory/entando-core/downloads","issues_url":"https://api.github.com/repos/DevFactory/entando-core/issues{/number}","pulls_url":"https://api.github.com/repos/DevFactory/entando-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DevFactory/entando-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DevFactory/entando-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevFactory/entando-core/labels{/name}","releases_url":"https://api.github.com/repos/DevFactory/entando-core/releases{/id}","deployments_url":"https://api.github.com/repos/DevFactory/entando-core/deployments","created_at":"2016-04-01T06:52:50Z","updated_at":"2016-04-01T06:52:59Z","pushed_at":"2016-04-01T07:20:49Z","git_url":"git://github.com/DevFactory/entando-core.git","ssh_url":"git@github.com:DevFactory/entando-core.git","clone_url":"https://github.com/DevFactory/entando-core.git","svn_url":"https://github.com/DevFactory/entando-core","homepage":"","size":5389,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"entando:master","ref":"master","sha":"06a090c4316d72fc3f1940b8bb0e12dae50d5638","user":{"login":"entando","id":673103,"avatar_url":"https://avatars.githubusercontent.com/u/673103?v=3","gravatar_id":"","url":"https://api.github.com/users/entando","html_url":"https://github.com/entando","followers_url":"https://api.github.com/users/entando/followers","following_url":"https://api.github.com/users/entando/following{/other_user}","gists_url":"https://api.github.com/users/entando/gists{/gist_id}","starred_url":"https://api.github.com/users/entando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entando/subscriptions","organizations_url":"https://api.github.com/users/entando/orgs","repos_url":"https://api.github.com/users/entando/repos","events_url":"https://api.github.com/users/entando/events{/privacy}","received_events_url":"https://api.github.com/users/entando/received_events","type":"Organization","site_admin":false},"repo":{"id":23227907,"name":"entando-core","full_name":"entando/entando-core","owner":{"login":"entando","id":673103,"avatar_url":"https://avatars.githubusercontent.com/u/673103?v=3","gravatar_id":"","url":"https://api.github.com/users/entando","html_url":"https://github.com/entando","followers_url":"https://api.github.com/users/entando/followers","following_url":"https://api.github.com/users/entando/following{/other_user}","gists_url":"https://api.github.com/users/entando/gists{/gist_id}","starred_url":"https://api.github.com/users/entando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entando/subscriptions","organizations_url":"https://api.github.com/users/entando/orgs","repos_url":"https://api.github.com/users/entando/repos","events_url":"https://api.github.com/users/entando/events{/privacy}","received_events_url":"https://api.github.com/users/entando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/entando/entando-core","description":"Entando Core. The leading repository of Entando Platform.","fork":false,"url":"https://api.github.com/repos/entando/entando-core","forks_url":"https://api.github.com/repos/entando/entando-core/forks","keys_url":"https://api.github.com/repos/entando/entando-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/entando/entando-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/entando/entando-core/teams","hooks_url":"https://api.github.com/repos/entando/entando-core/hooks","issue_events_url":"https://api.github.com/repos/entando/entando-core/issues/events{/number}","events_url":"https://api.github.com/repos/entando/entando-core/events","assignees_url":"https://api.github.com/repos/entando/entando-core/assignees{/user}","branches_url":"https://api.github.com/repos/entando/entando-core/branches{/branch}","tags_url":"https://api.github.com/repos/entando/entando-core/tags","blobs_url":"https://api.github.com/repos/entando/entando-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/entando/entando-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/entando/entando-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/entando/entando-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/entando/entando-core/statuses/{sha}","languages_url":"https://api.github.com/repos/entando/entando-core/languages","stargazers_url":"https://api.github.com/repos/entando/entando-core/stargazers","contributors_url":"https://api.github.com/repos/entando/entando-core/contributors","subscribers_url":"https://api.github.com/repos/entando/entando-core/subscribers","subscription_url":"https://api.github.com/repos/entando/entando-core/subscription","commits_url":"https://api.github.com/repos/entando/entando-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/entando/entando-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/entando/entando-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/entando/entando-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/entando/entando-core/contents/{+path}","compare_url":"https://api.github.com/repos/entando/entando-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/entando/entando-core/merges","archive_url":"https://api.github.com/repos/entando/entando-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/entando/entando-core/downloads","issues_url":"https://api.github.com/repos/entando/entando-core/issues{/number}","pulls_url":"https://api.github.com/repos/entando/entando-core/pulls{/number}","milestones_url":"https://api.github.com/repos/entando/entando-core/milestones{/number}","notifications_url":"https://api.github.com/repos/entando/entando-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/entando/entando-core/labels{/name}","releases_url":"https://api.github.com/repos/entando/entando-core/releases{/id}","deployments_url":"https://api.github.com/repos/entando/entando-core/deployments","created_at":"2014-08-22T14:23:11Z","updated_at":"2016-03-28T20:19:50Z","pushed_at":"2016-04-01T07:23:26Z","git_url":"git://github.com/entando/entando-core.git","ssh_url":"git@github.com:entando/entando-core.git","clone_url":"https://github.com/entando/entando-core.git","svn_url":"https://github.com/entando/entando-core","homepage":"","size":5390,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":10,"forks":16,"open_issues":10,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/entando/entando-core/pulls/34"},"html":{"href":"https://github.com/entando/entando-core/pull/34"},"issue":{"href":"https://api.github.com/repos/entando/entando-core/issues/34"},"comments":{"href":"https://api.github.com/repos/entando/entando-core/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/entando/entando-core/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/entando/entando-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/entando/entando-core/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/entando/entando-core/statuses/eec85036520fbd63ec586e6861e9877a8eb89d4f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":84,"deletions":86,"changed_files":6}}