{"action":"created","comment":{"url":"https://api.github.com/repos/Teradata/presto/pulls/comments/56422770","id":56422770,"diff_hunk":"@@ -100,8 +104,8 @@ public void shouldInsertSelectQuery()\n     public void shouldExecuteQueryWithSelectedCatalogAndSchema()\n             throws SQLException\n     {\n-       connection.setCatalog(\"hive\");\n-       connection.setSchema(\"default\");\n+        connection.setCatalog(\"hive\");\n+        connection.setSchema(\"default\");","path":"presto-product-tests/src/main/java/com/facebook/presto/tests/jdbc/JdbcTests.java","position":33,"original_position":33,"commit_id":"7814bd692b64ee67a9b440d5cf3dbd9669601f85","original_commit_id":"7814bd692b64ee67a9b440d5cf3dbd9669601f85","user":{"login":"brian-rickman","id":12533044,"avatar_url":"https://avatars.githubusercontent.com/u/12533044?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-rickman","html_url":"https://github.com/brian-rickman","followers_url":"https://api.github.com/users/brian-rickman/followers","following_url":"https://api.github.com/users/brian-rickman/following{/other_user}","gists_url":"https://api.github.com/users/brian-rickman/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-rickman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-rickman/subscriptions","organizations_url":"https://api.github.com/users/brian-rickman/orgs","repos_url":"https://api.github.com/users/brian-rickman/repos","events_url":"https://api.github.com/users/brian-rickman/events{/privacy}","received_events_url":"https://api.github.com/users/brian-rickman/received_events","type":"User","site_admin":false},"body":"This get the alignment back to where it was originally.","created_at":"2016-03-16T21:55:36Z","updated_at":"2016-03-16T21:55:36Z","html_url":"https://github.com/Teradata/presto/pull/154#discussion_r56422770","pull_request_url":"https://api.github.com/repos/Teradata/presto/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/Teradata/presto/pulls/comments/56422770"},"html":{"href":"https://github.com/Teradata/presto/pull/154#discussion_r56422770"},"pull_request":{"href":"https://api.github.com/repos/Teradata/presto/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/Teradata/presto/pulls/154","id":62946781,"html_url":"https://github.com/Teradata/presto/pull/154","diff_url":"https://github.com/Teradata/presto/pull/154.diff","patch_url":"https://github.com/Teradata/presto/pull/154.patch","issue_url":"https://api.github.com/repos/Teradata/presto/issues/154","number":154,"state":"open","locked":false,"title":"Support Simba JDBC driver for product-tests","user":{"login":"brian-rickman","id":12533044,"avatar_url":"https://avatars.githubusercontent.com/u/12533044?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-rickman","html_url":"https://github.com/brian-rickman","followers_url":"https://api.github.com/users/brian-rickman/followers","following_url":"https://api.github.com/users/brian-rickman/following{/other_user}","gists_url":"https://api.github.com/users/brian-rickman/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-rickman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-rickman/subscriptions","organizations_url":"https://api.github.com/users/brian-rickman/orgs","repos_url":"https://api.github.com/users/brian-rickman/repos","events_url":"https://api.github.com/users/brian-rickman/events{/privacy}","received_events_url":"https://api.github.com/users/brian-rickman/received_events","type":"User","site_admin":false},"body":"The SQL (convention) based tests all pass using the open source JDBC driver or the Simba JDBC driver.  \r\n\r\n2 tests in the JDBC group used methods which are only present in the open source JDBC driver, so those are skipped when the test is run with the Simba JDBC driver.  \r\n\r\n2 tests in the JDBC group fail when run with the Simba driver (JdbcTests.shouldGetColumns and JdbcTests.shouldGetTableTypes).  I think the failure of shouldGetTableTypes() indicates a bug in the Simba driver.  I am not sure about the failure of shouldGetColumns().\r\n\r\nAll tests in the SYSTEM, JMX, and HIVE_CONNECTOR groups now pass with either JDBC driver.","created_at":"2016-03-15T17:37:44Z","updated_at":"2016-03-16T21:55:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec6d6f6fb039ca85fc65c9c473c385525952de17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Teradata/presto/pulls/154/commits","review_comments_url":"https://api.github.com/repos/Teradata/presto/pulls/154/comments","review_comment_url":"https://api.github.com/repos/Teradata/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Teradata/presto/issues/154/comments","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/7814bd692b64ee67a9b440d5cf3dbd9669601f85","head":{"label":"Teradata:product-tests-for-simba-jdbc","ref":"product-tests-for-simba-jdbc","sha":"7814bd692b64ee67a9b440d5cf3dbd9669601f85","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata's Certified Version of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2016-03-14T16:07:23Z","pushed_at":"2016-03-16T21:51:50Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"git@github.com:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":94642,"stargazers_count":42,"watchers_count":42,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":42,"default_branch":"master"}},"base":{"label":"Teradata:integration","ref":"integration","sha":"451b2df8891ddcc9ba23ae7825a7fba4622a080a","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata's Certified Version of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2016-03-14T16:07:23Z","pushed_at":"2016-03-16T21:51:50Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"git@github.com:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":94642,"stargazers_count":42,"watchers_count":42,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Teradata/presto/pulls/154"},"html":{"href":"https://github.com/Teradata/presto/pull/154"},"issue":{"href":"https://api.github.com/repos/Teradata/presto/issues/154"},"comments":{"href":"https://api.github.com/repos/Teradata/presto/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/Teradata/presto/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/Teradata/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Teradata/presto/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/Teradata/presto/statuses/7814bd692b64ee67a9b440d5cf3dbd9669601f85"}}}}