{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/78404976","id":78404976,"diff_hunk":"@@ -248,10 +256,16 @@ struct UnsortedSegmentSumFunctor<CPUDevice, T, Index> {\n \n // Similar to SegmentReductionOp but can handle unsorted segment definitions and\n // specifying size of output.\n-template <typename Device, class T, class Index>\n-class UnsortedSegmentSumOp : public OpKernel {\n+template <typename Device, class T, class Index,\n+          void (*unsortedSegmentInitializationOp)(","path":"tensorflow/core/kernels/segment_reduction_ops.cc","position":null,"original_position":110,"commit_id":"83fa25331eb279152a5ccd678d1339996e2de794","original_commit_id":"77688f04a8c4f2ce0b87439d60db7991f2c72db1","user":{"login":"andydavis1","id":15696327,"avatar_url":"https://avatars.githubusercontent.com/u/15696327?v=3","gravatar_id":"","url":"https://api.github.com/users/andydavis1","html_url":"https://github.com/andydavis1","followers_url":"https://api.github.com/users/andydavis1/followers","following_url":"https://api.github.com/users/andydavis1/following{/other_user}","gists_url":"https://api.github.com/users/andydavis1/gists{/gist_id}","starred_url":"https://api.github.com/users/andydavis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andydavis1/subscriptions","organizations_url":"https://api.github.com/users/andydavis1/orgs","repos_url":"https://api.github.com/users/andydavis1/repos","events_url":"https://api.github.com/users/andydavis1/events{/privacy}","received_events_url":"https://api.github.com/users/andydavis1/received_events","type":"User","site_admin":false},"body":"I dont like passing these things as template arguments.  Can we make these things functors, and pass the proper functor in to the base classes' Compute method?\r\n\r\nclass UnsortedSegmentSumOp : public UnsortedSegmentBase\r\n\r\n  void Compute(...) {\r\n      // Pass in UnsortedSegmentSum functor here.\r\n      UnsortedSegmentBase::Compute(functor);\r\n   }\r\n","created_at":"2016-09-12T16:22:52Z","updated_at":"2016-09-12T16:22:52Z","html_url":"https://github.com/tensorflow/tensorflow/pull/4051#discussion_r78404976","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/4051","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/78404976"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/4051#discussion_r78404976"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/4051"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/4051","id":82851040,"html_url":"https://github.com/tensorflow/tensorflow/pull/4051","diff_url":"https://github.com/tensorflow/tensorflow/pull/4051.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/4051.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/4051","number":4051,"state":"open","locked":false,"title":"549 unsorted segment max","user":{"login":"nikste","id":11996097,"avatar_url":"https://avatars.githubusercontent.com/u/11996097?v=3","gravatar_id":"","url":"https://api.github.com/users/nikste","html_url":"https://github.com/nikste","followers_url":"https://api.github.com/users/nikste/followers","following_url":"https://api.github.com/users/nikste/following{/other_user}","gists_url":"https://api.github.com/users/nikste/gists{/gist_id}","starred_url":"https://api.github.com/users/nikste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikste/subscriptions","organizations_url":"https://api.github.com/users/nikste/orgs","repos_url":"https://api.github.com/users/nikste/repos","events_url":"https://api.github.com/users/nikste/events{/privacy}","received_events_url":"https://api.github.com/users/nikste/received_events","type":"User","site_admin":false},"body":"added unsorted segment max for #549","created_at":"2016-08-26T08:37:18Z","updated_at":"2016-09-12T16:22:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce1f9aa70e53fd0da6eea669b249a8816e271f61","assignee":{"login":"andydavis1","id":15696327,"avatar_url":"https://avatars.githubusercontent.com/u/15696327?v=3","gravatar_id":"","url":"https://api.github.com/users/andydavis1","html_url":"https://github.com/andydavis1","followers_url":"https://api.github.com/users/andydavis1/followers","following_url":"https://api.github.com/users/andydavis1/following{/other_user}","gists_url":"https://api.github.com/users/andydavis1/gists{/gist_id}","starred_url":"https://api.github.com/users/andydavis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andydavis1/subscriptions","organizations_url":"https://api.github.com/users/andydavis1/orgs","repos_url":"https://api.github.com/users/andydavis1/repos","events_url":"https://api.github.com/users/andydavis1/events{/privacy}","received_events_url":"https://api.github.com/users/andydavis1/received_events","type":"User","site_admin":false},"assignees":[{"login":"andydavis1","id":15696327,"avatar_url":"https://avatars.githubusercontent.com/u/15696327?v=3","gravatar_id":"","url":"https://api.github.com/users/andydavis1","html_url":"https://github.com/andydavis1","followers_url":"https://api.github.com/users/andydavis1/followers","following_url":"https://api.github.com/users/andydavis1/following{/other_user}","gists_url":"https://api.github.com/users/andydavis1/gists{/gist_id}","starred_url":"https://api.github.com/users/andydavis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andydavis1/subscriptions","organizations_url":"https://api.github.com/users/andydavis1/orgs","repos_url":"https://api.github.com/users/andydavis1/repos","events_url":"https://api.github.com/users/andydavis1/events{/privacy}","received_events_url":"https://api.github.com/users/andydavis1/received_events","type":"User","site_admin":false},{"login":"agarwal-ashish","id":19335798,"avatar_url":"https://avatars.githubusercontent.com/u/19335798?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-ashish","html_url":"https://github.com/agarwal-ashish","followers_url":"https://api.github.com/users/agarwal-ashish/followers","following_url":"https://api.github.com/users/agarwal-ashish/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-ashish/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-ashish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-ashish/subscriptions","organizations_url":"https://api.github.com/users/agarwal-ashish/orgs","repos_url":"https://api.github.com/users/agarwal-ashish/repos","events_url":"https://api.github.com/users/agarwal-ashish/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-ashish/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/4051/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/4051/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/4051/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/83fa25331eb279152a5ccd678d1339996e2de794","head":{"label":"nikste:TF-549_unsorted_segment_max","ref":"TF-549_unsorted_segment_max","sha":"83fa25331eb279152a5ccd678d1339996e2de794","user":{"login":"nikste","id":11996097,"avatar_url":"https://avatars.githubusercontent.com/u/11996097?v=3","gravatar_id":"","url":"https://api.github.com/users/nikste","html_url":"https://github.com/nikste","followers_url":"https://api.github.com/users/nikste/followers","following_url":"https://api.github.com/users/nikste/following{/other_user}","gists_url":"https://api.github.com/users/nikste/gists{/gist_id}","starred_url":"https://api.github.com/users/nikste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikste/subscriptions","organizations_url":"https://api.github.com/users/nikste/orgs","repos_url":"https://api.github.com/users/nikste/repos","events_url":"https://api.github.com/users/nikste/events{/privacy}","received_events_url":"https://api.github.com/users/nikste/received_events","type":"User","site_admin":false},"repo":{"id":52998342,"name":"tensorflow","full_name":"nikste/tensorflow","owner":{"login":"nikste","id":11996097,"avatar_url":"https://avatars.githubusercontent.com/u/11996097?v=3","gravatar_id":"","url":"https://api.github.com/users/nikste","html_url":"https://github.com/nikste","followers_url":"https://api.github.com/users/nikste/followers","following_url":"https://api.github.com/users/nikste/following{/other_user}","gists_url":"https://api.github.com/users/nikste/gists{/gist_id}","starred_url":"https://api.github.com/users/nikste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikste/subscriptions","organizations_url":"https://api.github.com/users/nikste/orgs","repos_url":"https://api.github.com/users/nikste/repos","events_url":"https://api.github.com/users/nikste/events{/privacy}","received_events_url":"https://api.github.com/users/nikste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikste/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/nikste/tensorflow","forks_url":"https://api.github.com/repos/nikste/tensorflow/forks","keys_url":"https://api.github.com/repos/nikste/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikste/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikste/tensorflow/teams","hooks_url":"https://api.github.com/repos/nikste/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/nikste/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/nikste/tensorflow/events","assignees_url":"https://api.github.com/repos/nikste/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/nikste/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/nikste/tensorflow/tags","blobs_url":"https://api.github.com/repos/nikste/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikste/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikste/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikste/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikste/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/nikste/tensorflow/languages","stargazers_url":"https://api.github.com/repos/nikste/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/nikste/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/nikste/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/nikste/tensorflow/subscription","commits_url":"https://api.github.com/repos/nikste/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikste/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikste/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikste/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikste/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/nikste/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikste/tensorflow/merges","archive_url":"https://api.github.com/repos/nikste/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikste/tensorflow/downloads","issues_url":"https://api.github.com/repos/nikste/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/nikste/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/nikste/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/nikste/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikste/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/nikste/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/nikste/tensorflow/deployments","created_at":"2016-03-02T21:39:13Z","updated_at":"2016-03-02T21:39:19Z","pushed_at":"2016-09-11T21:50:16Z","git_url":"git://github.com/nikste/tensorflow.git","ssh_url":"git@github.com:nikste/tensorflow.git","clone_url":"https://github.com/nikste/tensorflow.git","svn_url":"https://github.com/nikste/tensorflow","homepage":"http://tensorflow.org","size":56762,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"37256f4857cdadefa09e0505f4acc91ffbf626e2","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2016-09-12T16:15:35Z","pushed_at":"2016-09-12T12:23:51Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"http://tensorflow.org","size":227335,"stargazers_count":31713,"watchers_count":31713,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13567,"mirror_url":null,"open_issues_count":537,"forks":13567,"open_issues":537,"watchers":31713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/4051"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/4051"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/4051"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/4051/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/4051/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/4051/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/83fa25331eb279152a5ccd678d1339996e2de794"}}}}
{"actor":{"display_login":"andydavis1"}}