{"action":"created","comment":{"url":"https://api.github.com/repos/opentk/opentk/pulls/comments/64140895","id":64140895,"diff_hunk":"@@ -97,7 +95,7 @@ abstract class EglContext : EmbeddedGraphicsContext\n                 window.CreateWindowSurface(config);\n \n             int[] attrib_list = new int[] { Egl.CONTEXT_CLIENT_VERSION, major, Egl.NONE };\n-            HandleAsEGLContext = Egl.CreateContext(window.Display, config, shared != null ? shared.HandleAsEGLContext : IntPtr.Zero, attrib_list);\n+            HandleAsEGLContext = Egl.CreateContext(window.Display, config, sharedContext != null ? (sharedContext as IGraphicsContextInternal).Context.Handle : IntPtr.Zero, attrib_list);","path":"Source/OpenTK/Platform/Egl/EglContext.cs","position":null,"original_position":14,"commit_id":"1652cf0d237b7db6c088ee3be5029ddf17ed1afe","original_commit_id":"1652cf0d237b7db6c088ee3be5029ddf17ed1afe","user":{"login":"varon","id":1936994,"avatar_url":"https://avatars.githubusercontent.com/u/1936994?v=3","gravatar_id":"","url":"https://api.github.com/users/varon","html_url":"https://github.com/varon","followers_url":"https://api.github.com/users/varon/followers","following_url":"https://api.github.com/users/varon/following{/other_user}","gists_url":"https://api.github.com/users/varon/gists{/gist_id}","starred_url":"https://api.github.com/users/varon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varon/subscriptions","organizations_url":"https://api.github.com/users/varon/orgs","repos_url":"https://api.github.com/users/varon/repos","events_url":"https://api.github.com/users/varon/events{/privacy}","received_events_url":"https://api.github.com/users/varon/received_events","type":"User","site_admin":false},"body":"The cast on SharedContext violates [Liskov](https://en.wikipedia.org/wiki/Liskov_substitution_principle).\r\n\r\nAs a quick fix for robustness, could you perform another null-check after the cast? The alternative path handling can be really simple, use your best judgement for that.","created_at":"2016-05-21T21:56:23Z","updated_at":"2016-05-21T21:56:23Z","html_url":"https://github.com/opentk/opentk/pull/390#discussion_r64140895","pull_request_url":"https://api.github.com/repos/opentk/opentk/pulls/390","_links":{"self":{"href":"https://api.github.com/repos/opentk/opentk/pulls/comments/64140895"},"html":{"href":"https://github.com/opentk/opentk/pull/390#discussion_r64140895"},"pull_request":{"href":"https://api.github.com/repos/opentk/opentk/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/opentk/opentk/pulls/390","id":70936223,"html_url":"https://github.com/opentk/opentk/pull/390","diff_url":"https://github.com/opentk/opentk/pull/390.diff","patch_url":"https://github.com/opentk/opentk/pull/390.patch","issue_url":"https://api.github.com/repos/opentk/opentk/issues/390","number":390,"state":"open","locked":false,"title":"Egl context fixes","user":{"login":"xen2","id":527565,"avatar_url":"https://avatars.githubusercontent.com/u/527565?v=3","gravatar_id":"","url":"https://api.github.com/users/xen2","html_url":"https://github.com/xen2","followers_url":"https://api.github.com/users/xen2/followers","following_url":"https://api.github.com/users/xen2/following{/other_user}","gists_url":"https://api.github.com/users/xen2/gists{/gist_id}","starred_url":"https://api.github.com/users/xen2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xen2/subscriptions","organizations_url":"https://api.github.com/users/xen2/orgs","repos_url":"https://api.github.com/users/xen2/repos","events_url":"https://api.github.com/users/xen2/events{/privacy}","received_events_url":"https://api.github.com/users/xen2/received_events","type":"User","site_admin":false},"body":"Various Egl bugfixes:\r\n- Egl & Cocoa: Don't change context when creating/deleting them\r\n- Egl: Unset context when calling MakeCurrent(null)\r\n- Egl: Fix context sharing","created_at":"2016-05-21T01:41:30Z","updated_at":"2016-05-21T21:56:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ae56c8b203e6a667920f9fa3b84e2ee1887800e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentk/opentk/pulls/390/commits","review_comments_url":"https://api.github.com/repos/opentk/opentk/pulls/390/comments","review_comment_url":"https://api.github.com/repos/opentk/opentk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentk/opentk/issues/390/comments","statuses_url":"https://api.github.com/repos/opentk/opentk/statuses/1652cf0d237b7db6c088ee3be5029ddf17ed1afe","head":{"label":"SiliconStudio:egl_context_fixes","ref":"egl_context_fixes","sha":"1652cf0d237b7db6c088ee3be5029ddf17ed1afe","user":{"login":"SiliconStudio","id":4505864,"avatar_url":"https://avatars.githubusercontent.com/u/4505864?v=3","gravatar_id":"","url":"https://api.github.com/users/SiliconStudio","html_url":"https://github.com/SiliconStudio","followers_url":"https://api.github.com/users/SiliconStudio/followers","following_url":"https://api.github.com/users/SiliconStudio/following{/other_user}","gists_url":"https://api.github.com/users/SiliconStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SiliconStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiliconStudio/subscriptions","organizations_url":"https://api.github.com/users/SiliconStudio/orgs","repos_url":"https://api.github.com/users/SiliconStudio/repos","events_url":"https://api.github.com/users/SiliconStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SiliconStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":25291868,"name":"opentk","full_name":"SiliconStudio/opentk","owner":{"login":"SiliconStudio","id":4505864,"avatar_url":"https://avatars.githubusercontent.com/u/4505864?v=3","gravatar_id":"","url":"https://api.github.com/users/SiliconStudio","html_url":"https://github.com/SiliconStudio","followers_url":"https://api.github.com/users/SiliconStudio/followers","following_url":"https://api.github.com/users/SiliconStudio/following{/other_user}","gists_url":"https://api.github.com/users/SiliconStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SiliconStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiliconStudio/subscriptions","organizations_url":"https://api.github.com/users/SiliconStudio/orgs","repos_url":"https://api.github.com/users/SiliconStudio/repos","events_url":"https://api.github.com/users/SiliconStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SiliconStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SiliconStudio/opentk","description":"This Open Toolkit library is a fast, low-level C# wrapper for OpenGL and OpenAL. It can be used standalone or inside a GUI on Windows, Linux, Mac, Android and iOS.","fork":true,"url":"https://api.github.com/repos/SiliconStudio/opentk","forks_url":"https://api.github.com/repos/SiliconStudio/opentk/forks","keys_url":"https://api.github.com/repos/SiliconStudio/opentk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SiliconStudio/opentk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SiliconStudio/opentk/teams","hooks_url":"https://api.github.com/repos/SiliconStudio/opentk/hooks","issue_events_url":"https://api.github.com/repos/SiliconStudio/opentk/issues/events{/number}","events_url":"https://api.github.com/repos/SiliconStudio/opentk/events","assignees_url":"https://api.github.com/repos/SiliconStudio/opentk/assignees{/user}","branches_url":"https://api.github.com/repos/SiliconStudio/opentk/branches{/branch}","tags_url":"https://api.github.com/repos/SiliconStudio/opentk/tags","blobs_url":"https://api.github.com/repos/SiliconStudio/opentk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SiliconStudio/opentk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SiliconStudio/opentk/git/refs{/sha}","trees_url":"https://api.github.com/repos/SiliconStudio/opentk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SiliconStudio/opentk/statuses/{sha}","languages_url":"https://api.github.com/repos/SiliconStudio/opentk/languages","stargazers_url":"https://api.github.com/repos/SiliconStudio/opentk/stargazers","contributors_url":"https://api.github.com/repos/SiliconStudio/opentk/contributors","subscribers_url":"https://api.github.com/repos/SiliconStudio/opentk/subscribers","subscription_url":"https://api.github.com/repos/SiliconStudio/opentk/subscription","commits_url":"https://api.github.com/repos/SiliconStudio/opentk/commits{/sha}","git_commits_url":"https://api.github.com/repos/SiliconStudio/opentk/git/commits{/sha}","comments_url":"https://api.github.com/repos/SiliconStudio/opentk/comments{/number}","issue_comment_url":"https://api.github.com/repos/SiliconStudio/opentk/issues/comments{/number}","contents_url":"https://api.github.com/repos/SiliconStudio/opentk/contents/{+path}","compare_url":"https://api.github.com/repos/SiliconStudio/opentk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SiliconStudio/opentk/merges","archive_url":"https://api.github.com/repos/SiliconStudio/opentk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SiliconStudio/opentk/downloads","issues_url":"https://api.github.com/repos/SiliconStudio/opentk/issues{/number}","pulls_url":"https://api.github.com/repos/SiliconStudio/opentk/pulls{/number}","milestones_url":"https://api.github.com/repos/SiliconStudio/opentk/milestones{/number}","notifications_url":"https://api.github.com/repos/SiliconStudio/opentk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SiliconStudio/opentk/labels{/name}","releases_url":"https://api.github.com/repos/SiliconStudio/opentk/releases{/id}","deployments_url":"https://api.github.com/repos/SiliconStudio/opentk/deployments","created_at":"2014-10-16T07:48:40Z","updated_at":"2016-05-21T14:20:19Z","pushed_at":"2016-05-21T02:45:53Z","git_url":"git://github.com/SiliconStudio/opentk.git","ssh_url":"git@github.com:SiliconStudio/opentk.git","clone_url":"https://github.com/SiliconStudio/opentk.git","svn_url":"https://github.com/SiliconStudio/opentk","homepage":"http://www.opentk.com","size":63740,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"opentk:develop","ref":"develop","sha":"1b6fdd28ca0b9215126729db856bb8db7eb2bdd7","user":{"login":"opentk","id":5914736,"avatar_url":"https://avatars.githubusercontent.com/u/5914736?v=3","gravatar_id":"","url":"https://api.github.com/users/opentk","html_url":"https://github.com/opentk","followers_url":"https://api.github.com/users/opentk/followers","following_url":"https://api.github.com/users/opentk/following{/other_user}","gists_url":"https://api.github.com/users/opentk/gists{/gist_id}","starred_url":"https://api.github.com/users/opentk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentk/subscriptions","organizations_url":"https://api.github.com/users/opentk/orgs","repos_url":"https://api.github.com/users/opentk/repos","events_url":"https://api.github.com/users/opentk/events{/privacy}","received_events_url":"https://api.github.com/users/opentk/received_events","type":"Organization","site_admin":false},"repo":{"id":14318990,"name":"opentk","full_name":"opentk/opentk","owner":{"login":"opentk","id":5914736,"avatar_url":"https://avatars.githubusercontent.com/u/5914736?v=3","gravatar_id":"","url":"https://api.github.com/users/opentk","html_url":"https://github.com/opentk","followers_url":"https://api.github.com/users/opentk/followers","following_url":"https://api.github.com/users/opentk/following{/other_user}","gists_url":"https://api.github.com/users/opentk/gists{/gist_id}","starred_url":"https://api.github.com/users/opentk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentk/subscriptions","organizations_url":"https://api.github.com/users/opentk/orgs","repos_url":"https://api.github.com/users/opentk/repos","events_url":"https://api.github.com/users/opentk/events{/privacy}","received_events_url":"https://api.github.com/users/opentk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentk/opentk","description":"This Open Toolkit library is a fast, low-level C# wrapper for OpenGL and OpenAL. It can be used standalone or inside a GUI on Windows, Linux, Mac, Android and iOS.","fork":true,"url":"https://api.github.com/repos/opentk/opentk","forks_url":"https://api.github.com/repos/opentk/opentk/forks","keys_url":"https://api.github.com/repos/opentk/opentk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentk/opentk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentk/opentk/teams","hooks_url":"https://api.github.com/repos/opentk/opentk/hooks","issue_events_url":"https://api.github.com/repos/opentk/opentk/issues/events{/number}","events_url":"https://api.github.com/repos/opentk/opentk/events","assignees_url":"https://api.github.com/repos/opentk/opentk/assignees{/user}","branches_url":"https://api.github.com/repos/opentk/opentk/branches{/branch}","tags_url":"https://api.github.com/repos/opentk/opentk/tags","blobs_url":"https://api.github.com/repos/opentk/opentk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentk/opentk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentk/opentk/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentk/opentk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentk/opentk/statuses/{sha}","languages_url":"https://api.github.com/repos/opentk/opentk/languages","stargazers_url":"https://api.github.com/repos/opentk/opentk/stargazers","contributors_url":"https://api.github.com/repos/opentk/opentk/contributors","subscribers_url":"https://api.github.com/repos/opentk/opentk/subscribers","subscription_url":"https://api.github.com/repos/opentk/opentk/subscription","commits_url":"https://api.github.com/repos/opentk/opentk/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentk/opentk/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentk/opentk/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentk/opentk/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentk/opentk/contents/{+path}","compare_url":"https://api.github.com/repos/opentk/opentk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentk/opentk/merges","archive_url":"https://api.github.com/repos/opentk/opentk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentk/opentk/downloads","issues_url":"https://api.github.com/repos/opentk/opentk/issues{/number}","pulls_url":"https://api.github.com/repos/opentk/opentk/pulls{/number}","milestones_url":"https://api.github.com/repos/opentk/opentk/milestones{/number}","notifications_url":"https://api.github.com/repos/opentk/opentk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentk/opentk/labels{/name}","releases_url":"https://api.github.com/repos/opentk/opentk/releases{/id}","deployments_url":"https://api.github.com/repos/opentk/opentk/deployments","created_at":"2013-11-12T01:34:24Z","updated_at":"2016-05-20T02:47:46Z","pushed_at":"2016-05-21T02:49:51Z","git_url":"git://github.com/opentk/opentk.git","ssh_url":"git@github.com:opentk/opentk.git","clone_url":"https://github.com/opentk/opentk.git","svn_url":"https://github.com/opentk/opentk","homepage":"http://www.opentk.com","size":75869,"stargazers_count":477,"watchers_count":477,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":113,"forks":202,"open_issues":113,"watchers":477,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/opentk/opentk/pulls/390"},"html":{"href":"https://github.com/opentk/opentk/pull/390"},"issue":{"href":"https://api.github.com/repos/opentk/opentk/issues/390"},"comments":{"href":"https://api.github.com/repos/opentk/opentk/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/opentk/opentk/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/opentk/opentk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentk/opentk/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/opentk/opentk/statuses/1652cf0d237b7db6c088ee3be5029ddf17ed1afe"}}}}
{"actor":{"display_login":"varon"}}