{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/83637273","pull_request_review_id":4467100,"id":83637273,"diff_hunk":"@@ -6,69 +6,244 @@ use dom::bindings::cell::DOMRefCell;\n use dom::bindings::codegen::Bindings::EventHandlerBinding::EventHandlerNonNull;\n use dom::bindings::codegen::Bindings::EventSourceBinding::{EventSourceInit, EventSourceMethods, Wrap};\n use dom::bindings::error::{Error, Fallible};\n+use dom::bindings::inheritance::Castable;\n use dom::bindings::js::Root;\n-use dom::bindings::reflector::reflect_dom_object;\n+use dom::bindings::refcounted::Trusted;\n+use dom::bindings::reflector::{Reflectable, reflect_dom_object};\n use dom::bindings::str::DOMString;\n use dom::eventtarget::EventTarget;\n use dom::globalscope::GlobalScope;\n+use hyper::header::{Accept, qitem};\n+use ipc_channel::ipc;\n+use ipc_channel::router::ROUTER;\n+use mime::{Mime, TopLevel, SubLevel};\n+use net_traits::{CoreResourceMsg, FetchMetadata, FetchResponseListener, NetworkError};\n+use net_traits::request::{CacheMode, CORSSettings, CredentialsMode};\n+use net_traits::request::{RequestInit, RequestMode};\n+use network_listener::{NetworkListener, PreInvoke};\n+use script_thread::Runnable;\n use std::cell::Cell;\n+use std::sync::{Arc, Mutex};\n+use std::sync::mpsc::{Sender, channel};\n+use task_source::TaskSource;\n use url::Url;\n \n+header! { (LastEventId, \"Last-Event-ID\") => [String] }\n+\n+#[derive(JSTraceable, PartialEq, Copy, Clone, Debug, HeapSizeOf)]\n+struct GenerationId(u32);\n+\n #[derive(JSTraceable, PartialEq, Copy, Clone, Debug, HeapSizeOf)]\n-enum EventSourceReadyState {\n+enum ReadyState {","path":"components/script/dom/eventsource.rs","position":34,"original_position":34,"commit_id":"555d576f25cd7cfc5f86f156313d2ac077ec140d","original_commit_id":"555d576f25cd7cfc5f86f156313d2ac077ec140d","user":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"body":"Can you add a comment here?\r\n\r\n```\r\nhttps://html.spec.whatwg.org/multipage/#dom-eventsource-readystate\r\n```","created_at":"2016-10-17T13:00:42Z","updated_at":"2016-10-17T13:00:43Z","html_url":"https://github.com/servo/servo/pull/13774#discussion_r83637273","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13774","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/83637273"},"html":{"href":"https://github.com/servo/servo/pull/13774#discussion_r83637273"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13774"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13774","id":89439938,"html_url":"https://github.com/servo/servo/pull/13774","diff_url":"https://github.com/servo/servo/pull/13774.diff","patch_url":"https://github.com/servo/servo/pull/13774.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13774","number":13774,"state":"open","locked":false,"title":"Implement EventSource constructor, parse metadata in EventSource response","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"body":"It still doesn't parse the event stream correctly, but it does announce and fail the connection correctly. Re-establishing the connection is not supported yet.\r\n\r\nPartial #8925.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13774)\n<!-- Reviewable:end -->\n","created_at":"2016-10-14T19:20:50Z","updated_at":"2016-10-17T13:00:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebbf071793cb28a69f34ffd434ac1545b3fc61b2","assignee":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"assignees":[{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13774/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13774/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13774/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/555d576f25cd7cfc5f86f156313d2ac077ec140d","head":{"label":"KiChjang:event-source-constructor","ref":"event-source-constructor","sha":"555d576f25cd7cfc5f86f156313d2ac077ec140d","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"repo":{"id":30110248,"name":"servo","full_name":"KiChjang/servo","owner":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KiChjang/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/KiChjang/servo","forks_url":"https://api.github.com/repos/KiChjang/servo/forks","keys_url":"https://api.github.com/repos/KiChjang/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KiChjang/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KiChjang/servo/teams","hooks_url":"https://api.github.com/repos/KiChjang/servo/hooks","issue_events_url":"https://api.github.com/repos/KiChjang/servo/issues/events{/number}","events_url":"https://api.github.com/repos/KiChjang/servo/events","assignees_url":"https://api.github.com/repos/KiChjang/servo/assignees{/user}","branches_url":"https://api.github.com/repos/KiChjang/servo/branches{/branch}","tags_url":"https://api.github.com/repos/KiChjang/servo/tags","blobs_url":"https://api.github.com/repos/KiChjang/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KiChjang/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KiChjang/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/KiChjang/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KiChjang/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/KiChjang/servo/languages","stargazers_url":"https://api.github.com/repos/KiChjang/servo/stargazers","contributors_url":"https://api.github.com/repos/KiChjang/servo/contributors","subscribers_url":"https://api.github.com/repos/KiChjang/servo/subscribers","subscription_url":"https://api.github.com/repos/KiChjang/servo/subscription","commits_url":"https://api.github.com/repos/KiChjang/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/KiChjang/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/KiChjang/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/KiChjang/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/KiChjang/servo/contents/{+path}","compare_url":"https://api.github.com/repos/KiChjang/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KiChjang/servo/merges","archive_url":"https://api.github.com/repos/KiChjang/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KiChjang/servo/downloads","issues_url":"https://api.github.com/repos/KiChjang/servo/issues{/number}","pulls_url":"https://api.github.com/repos/KiChjang/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/KiChjang/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/KiChjang/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KiChjang/servo/labels{/name}","releases_url":"https://api.github.com/repos/KiChjang/servo/releases{/id}","deployments_url":"https://api.github.com/repos/KiChjang/servo/deployments","created_at":"2015-01-31T11:19:01Z","updated_at":"2016-01-11T11:18:01Z","pushed_at":"2016-10-16T20:55:27Z","git_url":"git://github.com/KiChjang/servo.git","ssh_url":"git@github.com:KiChjang/servo.git","clone_url":"https://github.com/KiChjang/servo.git","svn_url":"https://github.com/KiChjang/servo","homepage":"","size":212417,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"4af21e3ae1676f943a9a01688fef854487bcddfc","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-10-17T11:09:50Z","pushed_at":"2016-10-17T10:16:15Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":301862,"stargazers_count":8060,"watchers_count":8060,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1310,"mirror_url":null,"open_issues_count":1811,"forks":1310,"open_issues":1811,"watchers":8060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13774"},"html":{"href":"https://github.com/servo/servo/pull/13774"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13774"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13774/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13774/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13774/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/555d576f25cd7cfc5f86f156313d2ac077ec140d"}}}}
{"actor":{"display_login":"frewsxcv"}}