{"push_id":1396403116,"size":11,"distinct_size":11,"ref":"refs/heads/reset-peculiar-platforms","head":"84a167865f59419ecbbda17836bc87a27158e9a1","before":"20e27225259133c069fb31993f9d0341453ca999","commits":[{"sha":"409a839cee651b21885577ec9b5d0582ff1891dc","author":{"name":"Moses Mendoza","email":"8f0a9182be9eaa841bfebb6b1d4aa07f41618fc7@puppet.com"},"message":"(PUP-6876) Add spec coverage for `puppet config set`\n\nPrior to this commit, there was nothing in specs (at least not that I could\nfind) that exercised and tested the :set action to `puppet config`. Prior\nchanges appear to have added testing only in the Puppet::Settings namespace.\nThis commit adds new specs that validate that `puppet config set`:\n  1) actually opens the correct config file\n  2) creates the config file if it doesn't exist\n  3) sets the correct value in the config file\n  4) sets the value in the correct config section if supplied\n\n- Ensured test behavior works on Windows.\n- Ensured test behavior works on Ruby 1.9.3 on Linux\n\nSigned-off-by: Moses Mendoza <moses@puppet.com>\nUpdated-by: Ethan J. Brown <ethan@puppet.com>","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/409a839cee651b21885577ec9b5d0582ff1891dc"},{"sha":"6d98d0e591e7fd21e9d884568554e2262654c104","author":{"name":"Iristyle","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-6876) Allow UTF-8 chars in INI keys / values\n\n - Previously, INI files were using the \\w regex character class to\n   match the \"key\" in a INI file line like:\n\n   key = value\n\n   Unfortunately, \\w is limited to ASCII characters [a-zA-Z0-9_] in\n   Ruby and will fail to match properly on any Unicode word\n   characters, such as:\n\n   Aۿᚠ𠜎 = value\n\n - In addition to breaking any code paths using the INI file parser,\n   that bug also breaks the CLI `config set` and `config print` commands\n   when specifying existing keys, by causing duplicate entries to\n   be written to an existing config file. That then results in the\n   value not properly being read out.\n\n - Change the \\w character class to [[:word]] which Ruby describes as\n   a \"character in one of the following Unicode general categories\n   Letter, Mark, Number, Connector_Punctuation\"\n\n - Supply tests demonstrating previously failing behavior\n\n - Note that StringIO.new defaults to ASCII on Ruby 1.9.3 and not UTF-8\n   so call set_encoding explicitly in tests to ensure tests pass","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/6d98d0e591e7fd21e9d884568554e2262654c104"},{"sha":"84f60c036ca086eb1ee377715e95864222150203","author":{"name":"Iristyle","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-6876) Allow UTF-8 characters in INI sections\n\n - Previously, INI files were using the \\w regex character class to\n   match the section in a INI file line like:\n\n   [Aۿᚠ𠜎]\n\n   Unfortunately, \\w is limited to ASCII characters [a-zA-Z0-9_] in\n   Ruby and will fail to match properly on any Unicode word\n   characters, like the above.\n\n - Change the \\w character class to [[:word]] which Ruby describes as\n   a \"character in one of the following Unicode general categories\n   Letter, Mark, Number, Connector_Punctuation\"\n\n - Supply tests demonstrating previously failing behavior\n\n - In addition to fixing any code paths using the INI file parser,\n   this also fixes the CLI `config set` and `config print` commands\n   when specifying existing keys.  Without the fix, duplicate sections\n   may be written to an existing config file - which can then cause\n   problems when retrieving values.","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/84f60c036ca086eb1ee377715e95864222150203"},{"sha":"4a1d5e3167802ee4e3574397a97bb275d248a2f9","author":{"name":"Moses Mendoza","email":"8f0a9182be9eaa841bfebb6b1d4aa07f41618fc7@puppet.com"},"message":"(PUP-6876) use UTF-8 in `config set`\n\nThis commit updates the :set action of Puppet::Face[:config] to call\nPuppet::FileSystem.open with UTF-8 encoding, ensuring config files are\nread/set using this encoding. This is part of a larger effort to update all\ncalls to Puppet::FileSystem.open to use UTF-8 file encoding.\n\nSigned-off-by: Moses Mendoza <moses@puppet.com>","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/4a1d5e3167802ee4e3574397a97bb275d248a2f9"},{"sha":"ef7dd35955f4de1451cbb2ee4c1fb3f90c0dc805","author":{"name":"Iristyle","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-6876) Add config face UTF-8 tests\n\n - Show that set / print roundtrip properly when dealing with UTF-8","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/ef7dd35955f4de1451cbb2ee4c1fb3f90c0dc805"},{"sha":"538125debeb0215eaafc70d44b942b1dbc2f0fd8","author":{"name":"Glenn Sarti","email":"900edb71f3a42fb982755727aa85ef464ad14b72@users.noreply.github.com"},"message":"Merge pull request #5361 from Iristyle/ticket/stable/PUP-6876-INI-file-UTF8-encoding\n\n(PUP-6876) Fix INI parsing for UTF-8 keys / values / sections and `config set`","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/538125debeb0215eaafc70d44b942b1dbc2f0fd8"},{"sha":"fd7cc0e8dc3531347a62019822fbca75c3d1cdb2","author":{"name":"Thomas Hallgren","email":"5f919b14acad347486cfcc925fe5476cb2791020@tada.se"},"message":"(PUP-6856) Catch :no_such_key during interpolation sub_lookup\n\nAn interpolation that uses dotted keys that in turn results in a\n`:no_such_key` being thrown (because the key is missing), would not catch the\nthrow and hence, yield strange results. This commit ensures that the thrown\nsymbol `:no_such_key` is caught so that the call instead results in an empty\nstring.","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/fd7cc0e8dc3531347a62019822fbca75c3d1cdb2"},{"sha":"9ebf7f675708b822c83bf070ee2984f501812195","author":{"name":"Kurt Wall","email":"227b98b4a5b2b1b5baf7e213fc5427ef3ac751a1@puppet.com"},"message":"(PA-672) Automate LDOM resets","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/9ebf7f675708b822c83bf070ee2984f501812195"},{"sha":"8a355b73875aa58acd8a95717e80c31fb0df0795","author":{"name":"Glenn Sarti","email":"900edb71f3a42fb982755727aa85ef464ad14b72@users.noreply.github.com"},"message":"Merge branch 'stable'\n\n* stable:\n  (PUP-6876) Add config face UTF-8 tests\n  (PUP-6876) use UTF-8 in `config set`\n  (PUP-6876) Allow UTF-8 characters in INI sections\n  (PUP-6876) Allow UTF-8 chars in INI keys / values\n  (PUP-6876) Add spec coverage for `puppet config set`","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/8a355b73875aa58acd8a95717e80c31fb0df0795"},{"sha":"b0209f5daae9334d7335aa06de551c09669a65d0","author":{"name":"Henrik Lindberg","email":"84c6afaba0f0b7074a7a49470da8211284cb60c2@puppetlabs.com"},"message":"Merge pull request #5367 from thallgren/issue/pup-6856/no_such_key-during-interpolation-sub_lookup\n\n(PUP-6856) Catch :no_such_key during interpolation sub_lookup","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/b0209f5daae9334d7335aa06de551c09669a65d0"},{"sha":"84a167865f59419ecbbda17836bc87a27158e9a1","author":{"name":"Kurt Wall","email":"227b98b4a5b2b1b5baf7e213fc5427ef3ac751a1@puppet.com"},"message":"Merge branch 'master' of https://github.com/puppetlabs/puppet into reset-peculiar-platforms","distinct":true,"url":"https://api.github.com/repos/kurtwall/puppet/commits/84a167865f59419ecbbda17836bc87a27158e9a1"}]}
{"actor":{"display_login":"kurtwall"}}