{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5429","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5429/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5429/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5429/events","html_url":"https://github.com/NREL/EnergyPlus/issues/5429","id":127778816,"number":5429,"title":"Construction:InternalSource Tube Spacing should be half of distance between tubes in 2D model","user":{"login":"sebastienbrideau","id":7142738,"avatar_url":"https://avatars.githubusercontent.com/u/7142738?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienbrideau","html_url":"https://github.com/sebastienbrideau","followers_url":"https://api.github.com/users/sebastienbrideau/followers","following_url":"https://api.github.com/users/sebastienbrideau/following{/other_user}","gists_url":"https://api.github.com/users/sebastienbrideau/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienbrideau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienbrideau/subscriptions","organizations_url":"https://api.github.com/users/sebastienbrideau/orgs","repos_url":"https://api.github.com/users/sebastienbrideau/repos","events_url":"https://api.github.com/users/sebastienbrideau/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienbrideau/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Defect","name":"Defect","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"mitchute","id":2985979,"avatar_url":"https://avatars.githubusercontent.com/u/2985979?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchute","html_url":"https://github.com/mitchute","followers_url":"https://api.github.com/users/mitchute/followers","following_url":"https://api.github.com/users/mitchute/following{/other_user}","gists_url":"https://api.github.com/users/mitchute/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchute/subscriptions","organizations_url":"https://api.github.com/users/mitchute/orgs","repos_url":"https://api.github.com/users/mitchute/repos","events_url":"https://api.github.com/users/mitchute/events{/privacy}","received_events_url":"https://api.github.com/users/mitchute/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/2","html_url":"https://github.com/NREL/EnergyPlus/milestones/EnergyPlus%208.5.0","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/2/labels","id":1240491,"number":2,"title":"EnergyPlus 8.5.0","description":"The EnergyPlus 8.5.0 public release at the end of FY16Q2.","creator":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars.githubusercontent.com/u/849824?v=3","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":10,"state":"open","created_at":"2015-08-04T16:18:56Z","updated_at":"2016-01-29T21:58:00Z","due_on":"2016-03-31T06:00:00Z","closed_at":null},"comments":11,"created_at":"2016-01-20T20:39:00Z","updated_at":"2016-02-05T20:47:31Z","closed_at":null,"body":"I had found this a while back and discussed with Rick Strand.  He said that he'd let the development team know but I think that it may have fallen through the cracks.\r\n\r\nThe 2D LowTemperatureRadiant model uses symmetry around the tube axis and halfway between the tubes (so that only half of the distance between the tubes is modelled).\r\n\r\nI discuss this in a paper here\r\nhttp://www.tandfonline.com/doi/abs/10.1080/19401493.2015.1027065\r\n\r\nThis is explained in the code: DataHeatBalance.hh line 1035-1037\r\nThicknessPerpend is defined.\r\n\r\nBut then, in HeatBalanceManager.cc line 3856, the value given to ThicknessPerpend is not divided by two (it's taken straight from the IDF file which states \"tube spacing\").\r\n\r\nEither, the tube spacing in the IDF editor should be redefined as half of the tube spacing, or the code should be modified so that ThicknessPerpend is divided by two.\r\n\r\nI'm not familiar with C++, or github and I am not an advanced E+ user, so I would appreciate if someone would verify this.\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/180549312","html_url":"https://github.com/NREL/EnergyPlus/issues/5429#issuecomment-180549312","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5429","id":180549312,"user":{"login":"RKStrand","id":5804989,"avatar_url":"https://avatars.githubusercontent.com/u/5804989?v=3","gravatar_id":"","url":"https://api.github.com/users/RKStrand","html_url":"https://github.com/RKStrand","followers_url":"https://api.github.com/users/RKStrand/followers","following_url":"https://api.github.com/users/RKStrand/following{/other_user}","gists_url":"https://api.github.com/users/RKStrand/gists{/gist_id}","starred_url":"https://api.github.com/users/RKStrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RKStrand/subscriptions","organizations_url":"https://api.github.com/users/RKStrand/orgs","repos_url":"https://api.github.com/users/RKStrand/repos","events_url":"https://api.github.com/users/RKStrand/events{/privacy}","received_events_url":"https://api.github.com/users/RKStrand/received_events","type":"User","site_admin":false},"created_at":"2016-02-05T20:47:31Z","updated_at":"2016-02-05T20:47:31Z","body":"@mitchute Thanks for running that case and posting the data for the first week of July.  I think in general the trends are pretty believable and in line with what might be expected when correcting this error.  It's not perfect in part because the system is not turning on at the same time across the three different cases.  However, I think there is enough evidence here to say that the correction made is appropriate and is producing believable results.  I don't see anything that would prevent this from moving forward as a valid fix."}}