{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/comments/66850388","id":66850388,"diff_hunk":"@@ -55,6 +57,11 @@\n \tprivate ResourceIdResolver resourceIdResolver;\n \n \t@Bean\n+\tpublic TriggerProperties triggerProperties() {\n+\t\treturn new TriggerPropertiesMaxMessagesDefaultUnlimited();","path":"aws-s3/spring-cloud-starter-stream-source-s3/src/main/java/org/springframework/cloud/stream/app/s3/source/AmazonS3SourceConfiguration.java","position":14,"original_position":14,"commit_id":"fb51b816db7f432d48c1f6aff0761412d2b8b338","original_commit_id":"fb51b816db7f432d48c1f6aff0761412d2b8b338","user":{"login":"markpollack","id":247466,"avatar_url":"https://avatars.githubusercontent.com/u/247466?v=3","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"body":"The bigger concern isn't how it is wired, but the fact we need a TriggerPropertiesMaxMessagesDefaultUnlimited class at all.  It is all around getting good metadata files generated.  We could use an `@EnableConfigurationProperties(TriggerPropertiesMaxMessagesDefaultUnlimited.class) here, but it is really just the same thing.  I believe I went this route probably out of evolution in terms of trying to use the same class and doing some extra configuration in the `@Bean` method vs. just newing it up.","created_at":"2016-06-13T19:17:58Z","updated_at":"2016-06-13T19:17:58Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters/pull/127#discussion_r66850388","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/127","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/comments/66850388"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream-app-starters/pull/127#discussion_r66850388"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/127","id":73612233,"html_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters/pull/127","diff_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters/pull/127.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters/pull/127.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/127","number":127,"state":"open","locked":false,"title":"Gh 97b","user":{"login":"markpollack","id":247466,"avatar_url":"https://avatars.githubusercontent.com/u/247466?v=3","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"body":"Several commits to provide an application prefix for source/sinks and whitelist properties.\r\n\r\nSeveral descisions might not be obvious from the PR, which relate to quirks in sharing metadata/default values when using inheritance for @ConfigurationProperties class.  \r\n\r\nResolves spring-cloud/spring-cloud-stream-app-starters#121\r\nResolves spring-cloud/spring-cloud-stream-app-starters#97","created_at":"2016-06-13T17:23:07Z","updated_at":"2016-06-13T19:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f619b504d9f5915b5b79772a904e72693ca9e15","assignee":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/127/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/127/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/127/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/statuses/fb51b816db7f432d48c1f6aff0761412d2b8b338","head":{"label":"markpollack:GH-97b","ref":"GH-97b","sha":"fb51b816db7f432d48c1f6aff0761412d2b8b338","user":{"login":"markpollack","id":247466,"avatar_url":"https://avatars.githubusercontent.com/u/247466?v=3","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"repo":{"id":55253068,"name":"spring-cloud-stream-app-starters","full_name":"markpollack/spring-cloud-stream-app-starters","owner":{"login":"markpollack","id":247466,"avatar_url":"https://avatars.githubusercontent.com/u/247466?v=3","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markpollack/spring-cloud-stream-app-starters","description":"Starters for Spring Cloud Stream Apps","fork":true,"url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters","forks_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/forks","keys_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/teams","hooks_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/hooks","issue_events_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/issues/events{/number}","events_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/events","assignees_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/assignees{/user}","branches_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/branches{/branch}","tags_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/tags","blobs_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/git/refs{/sha}","trees_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/statuses/{sha}","languages_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/languages","stargazers_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/stargazers","contributors_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/contributors","subscribers_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/subscribers","subscription_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/subscription","commits_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/commits{/sha}","git_commits_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/git/commits{/sha}","comments_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/comments{/number}","issue_comment_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/issues/comments{/number}","contents_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/contents/{+path}","compare_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/merges","archive_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/downloads","issues_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/issues{/number}","pulls_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/pulls{/number}","milestones_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/milestones{/number}","notifications_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/labels{/name}","releases_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/releases{/id}","deployments_url":"https://api.github.com/repos/markpollack/spring-cloud-stream-app-starters/deployments","created_at":"2016-04-01T18:18:00Z","updated_at":"2016-06-08T21:03:42Z","pushed_at":"2016-06-13T16:46:19Z","git_url":"git://github.com/markpollack/spring-cloud-stream-app-starters.git","ssh_url":"git@github.com:markpollack/spring-cloud-stream-app-starters.git","clone_url":"https://github.com/markpollack/spring-cloud-stream-app-starters.git","svn_url":"https://github.com/markpollack/spring-cloud-stream-app-starters","homepage":null,"size":1840,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"55f428eb09a296f4be24566bb793160c89de1446","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":52888997,"name":"spring-cloud-stream-app-starters","full_name":"spring-cloud/spring-cloud-stream-app-starters","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters","description":"Starters for Spring Cloud Stream Apps","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/deployments","created_at":"2016-03-01T15:48:03Z","updated_at":"2016-05-25T06:46:11Z","pushed_at":"2016-06-13T17:23:07Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream-app-starters.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream-app-starters.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters","homepage":null,"size":1842,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":67,"forks":31,"open_issues":67,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/127"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream-app-starters/pull/127"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/127"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/statuses/fb51b816db7f432d48c1f6aff0761412d2b8b338"}}}}
{"actor":{"display_login":"markpollack"}}