{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto-admin/pulls/comments/79931427","id":79931427,"diff_hunk":"@@ -91,91 +91,6 @@ def test_install_exclude_nodes(self):\n         for container in self.cluster.all_hosts():\n             self.installer.assert_uninstalled(container, msg=output)\n \n-    def test_install_invalid_path(self):\n-        rpm_name = self.installer.copy_presto_rpm_to_master()\n-        cmd_output = self.run_prestoadmin('package install /mnt/presto-admin'\n-                                          '/invalid-path/presto.rpm',\n-                                          rpm=rpm_name, raise_error=False)\n-        error = '\\nFatal error: [%s] error: ' \\\n-                '/mnt/presto-admin/invalid-path/presto.rpm: open failed: ' \\\n-                'No such file or directory\\n\\nAborting.\\n'\n-        expected = ''\n-        for host in self.cluster.all_internal_hosts():\n-            expected += error % host\n-\n-        self.assertEqualIgnoringOrder(cmd_output, expected)\n-\n-    def test_install_no_path_arg(self):\n-        self.installer.copy_presto_rpm_to_master()\n-        output = self.run_prestoadmin('package install', raise_error=False)\n-        self.assertEqual(output, 'Incorrect number of arguments to task.\\n\\n'\n-                                 'Displaying detailed information for task '\n-                                 '\\'package install\\':\\n\\n'\n-                                 '    Install the rpm package on the cluster\\n'\n-                                 '    \\n    Args:\\n'\n-                                 '        local_path: Absolute path to the rpm'\n-                                 ' to be installed\\n        '\n-                                 '--nodeps (optional): Flag to indicate if '\n-                                 'rpm install\\n'\n-                                 '            should ignore c'\n-                                 'hecking package dependencies. Equivalent\\n'\n-                                 '            to adding --nodeps flag to rpm '\n-                                 '-i.\\n\\n')\n-\n-    def test_install_already_uninstalled(self):","path":"tests/product/test_package_install.py","position":35,"original_position":35,"commit_id":"09be3256210c2bf20746bc7d3030994ffae996fc","original_commit_id":"09be3256210c2bf20746bc7d3030994ffae996fc","user":{"login":"rschlussel","id":10963789,"avatar_url":"https://avatars.githubusercontent.com/u/10963789?v=3","gravatar_id":"","url":"https://api.github.com/users/rschlussel","html_url":"https://github.com/rschlussel","followers_url":"https://api.github.com/users/rschlussel/followers","following_url":"https://api.github.com/users/rschlussel/following{/other_user}","gists_url":"https://api.github.com/users/rschlussel/gists{/gist_id}","starred_url":"https://api.github.com/users/rschlussel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschlussel/subscriptions","organizations_url":"https://api.github.com/users/rschlussel/orgs","repos_url":"https://api.github.com/users/rschlussel/repos","events_url":"https://api.github.com/users/rschlussel/events{/privacy}","received_events_url":"https://api.github.com/users/rschlussel/received_events","type":"User","site_admin":false},"body":"we already unit test that it calls to rpm.  So this is just testing rpm","created_at":"2016-09-21T20:59:37Z","updated_at":"2016-09-21T21:02:07Z","html_url":"https://github.com/prestodb/presto-admin/pull/265#discussion_r79931427","pull_request_url":"https://api.github.com/repos/prestodb/presto-admin/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/comments/79931427"},"html":{"href":"https://github.com/prestodb/presto-admin/pull/265#discussion_r79931427"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto-admin/pulls/265","id":86239146,"html_url":"https://github.com/prestodb/presto-admin/pull/265","diff_url":"https://github.com/prestodb/presto-admin/pull/265.diff","patch_url":"https://github.com/prestodb/presto-admin/pull/265.patch","issue_url":"https://api.github.com/repos/prestodb/presto-admin/issues/265","number":265,"state":"open","locked":false,"title":"Remove unnecessary tests","user":{"login":"rschlussel","id":10963789,"avatar_url":"https://avatars.githubusercontent.com/u/10963789?v=3","gravatar_id":"","url":"https://api.github.com/users/rschlussel","html_url":"https://github.com/rschlussel","followers_url":"https://api.github.com/users/rschlussel/followers","following_url":"https://api.github.com/users/rschlussel/following{/other_user}","gists_url":"https://api.github.com/users/rschlussel/gists{/gist_id}","starred_url":"https://api.github.com/users/rschlussel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschlussel/subscriptions","organizations_url":"https://api.github.com/users/rschlussel/orgs","repos_url":"https://api.github.com/users/rschlussel/repos","events_url":"https://api.github.com/users/rschlussel/events{/privacy}","received_events_url":"https://api.github.com/users/rschlussel/received_events","type":"User","site_admin":false},"body":"Tests removed when the functionality is sufficiently unit tested, or\r\nthere is another product test covering the case.\r\n\r\nI removed more tests!  hopefully the prestodb/presto-admin builds will stop timing out on connector tests and short product tests.   @petroav @ebd2 ","created_at":"2016-09-21T20:52:12Z","updated_at":"2016-09-21T21:02:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b82714b554d7d6ce5330367ed3fd40b0926e250","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto-admin/pulls/265/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto-admin/pulls/265/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto-admin/issues/265/comments","statuses_url":"https://api.github.com/repos/prestodb/presto-admin/statuses/09be3256210c2bf20746bc7d3030994ffae996fc","head":{"label":"Teradata:remove-tests","ref":"remove-tests","sha":"09be3256210c2bf20746bc7d3030994ffae996fc","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":49295918,"name":"presto-admin","full_name":"Teradata/presto-admin","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto-admin","description":"A tool to install, configure and manage Presto installations","fork":true,"url":"https://api.github.com/repos/Teradata/presto-admin","forks_url":"https://api.github.com/repos/Teradata/presto-admin/forks","keys_url":"https://api.github.com/repos/Teradata/presto-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto-admin/teams","hooks_url":"https://api.github.com/repos/Teradata/presto-admin/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto-admin/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto-admin/events","assignees_url":"https://api.github.com/repos/Teradata/presto-admin/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto-admin/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto-admin/tags","blobs_url":"https://api.github.com/repos/Teradata/presto-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto-admin/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto-admin/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto-admin/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto-admin/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto-admin/subscription","commits_url":"https://api.github.com/repos/Teradata/presto-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto-admin/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto-admin/merges","archive_url":"https://api.github.com/repos/Teradata/presto-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto-admin/downloads","issues_url":"https://api.github.com/repos/Teradata/presto-admin/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto-admin/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto-admin/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto-admin/deployments","created_at":"2016-01-08T20:59:23Z","updated_at":"2016-08-29T16:53:22Z","pushed_at":"2016-09-21T20:58:23Z","git_url":"git://github.com/Teradata/presto-admin.git","ssh_url":"git@github.com:Teradata/presto-admin.git","clone_url":"https://github.com/Teradata/presto-admin.git","svn_url":"https://github.com/Teradata/presto-admin","homepage":"http://www.teradata.com/presto","size":39170,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":30,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"083b301313393d0543739d666cfa605f32b478d0","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":36050721,"name":"presto-admin","full_name":"prestodb/presto-admin","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto-admin","description":"A tool to install, configure and manage Presto installations","fork":false,"url":"https://api.github.com/repos/prestodb/presto-admin","forks_url":"https://api.github.com/repos/prestodb/presto-admin/forks","keys_url":"https://api.github.com/repos/prestodb/presto-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto-admin/teams","hooks_url":"https://api.github.com/repos/prestodb/presto-admin/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto-admin/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto-admin/events","assignees_url":"https://api.github.com/repos/prestodb/presto-admin/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto-admin/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto-admin/tags","blobs_url":"https://api.github.com/repos/prestodb/presto-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto-admin/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto-admin/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto-admin/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto-admin/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto-admin/subscription","commits_url":"https://api.github.com/repos/prestodb/presto-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto-admin/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto-admin/merges","archive_url":"https://api.github.com/repos/prestodb/presto-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto-admin/downloads","issues_url":"https://api.github.com/repos/prestodb/presto-admin/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto-admin/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto-admin/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto-admin/deployments","created_at":"2015-05-22T03:40:42Z","updated_at":"2016-09-15T11:17:49Z","pushed_at":"2016-09-21T20:52:12Z","git_url":"git://github.com/prestodb/presto-admin.git","ssh_url":"git@github.com:prestodb/presto-admin.git","clone_url":"https://github.com/prestodb/presto-admin.git","svn_url":"https://github.com/prestodb/presto-admin","homepage":"http://prestodb.github.io/presto-admin/","size":39994,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":46,"forks":22,"open_issues":46,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/265"},"html":{"href":"https://github.com/prestodb/presto-admin/pull/265"},"issue":{"href":"https://api.github.com/repos/prestodb/presto-admin/issues/265"},"comments":{"href":"https://api.github.com/repos/prestodb/presto-admin/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto-admin/statuses/09be3256210c2bf20746bc7d3030994ffae996fc"}}}}
{"actor":{"display_login":"rschlussel"}}