{"action":"created","issue":{"url":"https://api.github.com/repos/kazeburo/WWW-Form-UrlEncoded/issues/3","repository_url":"https://api.github.com/repos/kazeburo/WWW-Form-UrlEncoded","labels_url":"https://api.github.com/repos/kazeburo/WWW-Form-UrlEncoded/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/kazeburo/WWW-Form-UrlEncoded/issues/3/comments","events_url":"https://api.github.com/repos/kazeburo/WWW-Form-UrlEncoded/issues/3/events","html_url":"https://github.com/kazeburo/WWW-Form-UrlEncoded/issues/3","id":188070535,"number":3,"title":"Should not warn if XS is not new enough","user":{"login":"eserte","id":65852,"avatar_url":"https://avatars.githubusercontent.com/u/65852?v=3","gravatar_id":"","url":"https://api.github.com/users/eserte","html_url":"https://github.com/eserte","followers_url":"https://api.github.com/users/eserte/followers","following_url":"https://api.github.com/users/eserte/following{/other_user}","gists_url":"https://api.github.com/users/eserte/gists{/gist_id}","starred_url":"https://api.github.com/users/eserte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eserte/subscriptions","organizations_url":"https://api.github.com/users/eserte/orgs","repos_url":"https://api.github.com/users/eserte/repos","events_url":"https://api.github.com/users/eserte/events{/privacy}","received_events_url":"https://api.github.com/users/eserte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-08T18:40:26Z","updated_at":"2016-11-13T17:51:31Z","closed_at":null,"body":"Currently there's a warning if `WWW::Form::UrlEncoded::XS` is older than `WWW::Form::UrlEncoded`:\r\n```\r\n$ perl5.20.2 -MWWW::Form::UrlEncoded -e1            \r\nWWW::Form::UrlEncoded::XS 0.23 is require. fallback to PP version at /usr/perl5.20.2p/lib/site_perl/5.20.2/amd64-freebsd/WWW/Form/UrlEncoded.pm line 17.\r\n```\r\nHowever, if `WWW::Form::UrlEncoded::XS` is not installed at all, then there's no warning. So it seems that the XS is not really needed to work properly, and so there should be no warning if it's too old. Or the warning could be optionally triggered, maybe using a new environment variable.\r\n\r\nThe current behavior may cause failures in other modules' test suites, especially if something like `Test::NoWarnings` is used there. Currently I see such test failures for HORNBURG/Dancer2-Plugin-Auth-Extensible-0.621.tar.gz (@racke: FYI)"},"comment":{"url":"https://api.github.com/repos/kazeburo/WWW-Form-UrlEncoded/issues/comments/260200907","html_url":"https://github.com/kazeburo/WWW-Form-UrlEncoded/issues/3#issuecomment-260200907","issue_url":"https://api.github.com/repos/kazeburo/WWW-Form-UrlEncoded/issues/3","id":260200907,"user":{"login":"eserte","id":65852,"avatar_url":"https://avatars.githubusercontent.com/u/65852?v=3","gravatar_id":"","url":"https://api.github.com/users/eserte","html_url":"https://github.com/eserte","followers_url":"https://api.github.com/users/eserte/followers","following_url":"https://api.github.com/users/eserte/following{/other_user}","gists_url":"https://api.github.com/users/eserte/gists{/gist_id}","starred_url":"https://api.github.com/users/eserte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eserte/subscriptions","organizations_url":"https://api.github.com/users/eserte/orgs","repos_url":"https://api.github.com/users/eserte/repos","events_url":"https://api.github.com/users/eserte/events{/privacy}","received_events_url":"https://api.github.com/users/eserte/received_events","type":"User","site_admin":false},"created_at":"2016-11-13T17:51:31Z","updated_at":"2016-11-13T17:51:31Z","body":"A possible workaround, it could work in the particular case. However, there may be other modules which do the same like Test::NoWarnings, or users may simply build a custom check with `$SIG{__WARN__}` in their test suites.\r\n\r\nI wonder if there are other possibilities to make sure that the XS in the current version is there. E.g. `WWW::Form::UrlEncode`'s Makefile.PL could check if the XS is already is installed, and if it is, then add the XS dynamically to the `PREREQ_PM` list with the appropriate version. So it's made sure that the XS is uptodate after a `WWW::Form::UrlEncode` upgrade."}}
{"actor":{"display_login":"eserte"}}